15 years ago2007-11-19 Doug Turner <dougt@meer.net>
alp@webkit.org [Tue, 20 Nov 2007 02:39:31 +0000 (02:39 +0000)]
2007-11-19  Doug Turner  <dougt@meer.net>

        Reviewed by Alp Toker.

        Crash when GlyphPage::fill is called with more than 256 bytes of data

        [GDK] Crash on http://www.wikipedia.org/

        setGlyphDataForIndex() uses a fixed array of size 256 which we can't
        exceed. We need to return failure if the buffer has Unicode
        supplementary characters for now.

        This strategy matches the Win port, which also doesn't support this
        case yet.

        Add an assertion so nobody makes this mistake again.

        * platform/GlyphPageTreeNode.h:
        * platform/gtk/GlyphPageTreeNodeGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agowx port build fix (wx headers include ctype functions).
kevino@webkit.org [Tue, 20 Nov 2007 00:24:49 +0000 (00:24 +0000)]
wx port build fix (wx headers include ctype functions).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber-stamped by bdash.
antti@apple.com [Mon, 19 Nov 2007 22:53:07 +0000 (22:53 +0000)]
    Rubber-stamped by bdash.

        Improve coverage of these tests.

        * media/video-muted-expected.txt:
        * media/video-muted.html:
        * media/video-volume-expected.txt:
        * media/video-volume.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove outdated and unused Windows port files.
kevino@webkit.org [Mon, 19 Nov 2007 19:00:54 +0000 (19:00 +0000)]
Remove outdated and unused Windows port files.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Doug Turner <dougt@meer.net>
alp@webkit.org [Mon, 19 Nov 2007 18:01:58 +0000 (18:01 +0000)]
2007-11-19  Doug Turner  <dougt@meer.net>

        Reviewed by Timothy Hatcher.

        sqlite3_prepare16_v2 build bustage.

        Using the correct SQLITE_VERSION_NUMBER around sqlite_prepare16_v2
        to fix build bustage.

        * platform/sql/SQLiteStatement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 19 Nov 2007 17:56:33 +0000 (17:56 +0000)]
2007-11-19  Mark Rowe  <mrowe@apple.com>

        Build fix.  Don't over-qualify the constructor name.

        * storage/DatabaseDetails.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson@apple.com [Mon, 19 Nov 2007 17:51:44 +0000 (17:51 +0000)]

        Reviewed by Maciej

        Stub out the WebCore parts of the WebKit API

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

        * storage/DatabaseDetails.h: Added.  Simple container for vitals on a specific database

        * storage/DatabaseTracker.cpp:  Added various methods for API usage
        * storage/DatabaseTracker.h:


        Reviewed by Maciej

        * WebKit.xcodeproj/project.pbxproj: Sorted!


        Reviewed by Maciej

        Finished hooking up the WebKit API for database management.
        Most of the API is actually implemented in WebCore and some of those methods might
        only be stubs for now.

        * Storage/WebDatabaseManager.mm:
        (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
        (-[WebDatabaseManager databasesWithOrigin:]): Ditto
        (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto

        * Storage/WebSecurityOrigin.mm:
        (-[WebSecurityOrigin usage]): Call through to WebCore
        (-[WebSecurityOrigin quota]): Ditto
        (-[WebSecurityOrigin setQuota:]): Ditto
        (-[WebSecurityOrigin _core]): Get WebCore version of this object
        * Storage/WebSecurityOriginInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agowx port build fix for !USE(WXGC).
kevino@webkit.org [Mon, 19 Nov 2007 17:28:38 +0000 (17:28 +0000)]
wx port build fix for !USE(WXGC).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 19 Nov 2007 15:59:17 +0000 (15:59 +0000)]
2007-11-19  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] GtkLauncher should be written in C

        Port GtkLauncher to plain C.

        Use a more conventional GTK+ coding style.

        Use a toolbar instead of menus.

        Various signature fixes and cleanups.

        Add a license header. Assume all previous modifications were copyright
        assigned to Apple Inc. by default.

        * GtkLauncher/GtkLauncher.pro:
        * GtkLauncher/main.c: Added.
        * GtkLauncher/main.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 19 Nov 2007 15:53:38 +0000 (15:53 +0000)]
2007-11-19  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        GTK+ drawing fixes.

        Add a check to avoid crashing when the GraphicsContext is not
        associated with a GdkDrawable. This was noticed when adding printing
        support but might be triggered in other situations too.

        Do not render themes when painting is disabled. This is an
        optimisation for cases where GraphicsContext is used to calculate page
        dimensions etc. without actually rendering.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/gtk/RenderThemeGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Don't segfault when event pos is outside of the widget.
treat@webkit.org [Mon, 19 Nov 2007 15:33:55 +0000 (15:33 +0000)]
* Don't segfault when event pos is outside of the widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-13 Rahul Abrol <ra5ul@comcast.net>
mrowe@apple.com [Mon, 19 Nov 2007 13:43:55 +0000 (13:43 +0000)]
2007-11-13  Rahul Abrol  <ra5ul@comcast.net>

        Reviewed by Tim Hatcher.

        Resizing images preference now toggles default image state.

        * loader/ImageDocument.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r27896 as it caused lots of build breakages.
mrowe@apple.com [Mon, 19 Nov 2007 13:02:46 +0000 (13:02 +0000)]
Roll out r27896 as it caused lots of build breakages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 19 Nov 2007 12:51:30 +0000 (12:51 +0000)]
2007-11-19  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 19 Nov 2007 12:47:52 +0000 (12:47 +0000)]
2007-11-19  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::initFrameBuffer): Remove reference to SkBitmap type that doesn't belong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Kevin Ollivier <kevino@theolliviers.com>
mrowe@apple.com [Mon, 19 Nov 2007 12:37:13 +0000 (12:37 +0000)]
2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>

        Build script fixes to ensure they do the right thing for the
        wx port, and update build-wxwebkit to reflect the way the
        build scripts now work.

        Reviewed by Adam.

        * Scripts/build-testkjs:
        * Scripts/build-webkit:
        * Scripts/run-javascriptcore-tests:
        * Scripts/webkitdirs.pm:
        * wx/build-wxwebkit:

2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>

        Add pcre directory to JSCore includes, and update the wx port
        to reflect the Shared -> RefCounted name change. Also, fix
        WebFrame.cpp to re-enable code that should never have been
        committed disabled.

        Reviewed by Adam.

2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>

        Update wx port build sources with recent changes, update
        wx FontPlatformData to be a class (MSVC7 gets confused
        otherwise...) and implement its hash() method.

        Reviewed by Adam.

        * WebCoreSources.bkl:
        * platform/wx/FontPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>
mrowe@apple.com [Mon, 19 Nov 2007 12:30:34 +0000 (12:30 +0000)]
2007-11-19  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Darin.

        Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they
        are not available should raise an exception

        Tests: http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html

        * bindings/js/JSXMLHttpRequest.cpp:
        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h:

2007-11-19  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Darin.

        Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they are not
        available should raise an exception

        * http/tests/xmlhttprequest/xmlhttprequest-responseText-exception-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html: Added.
        * http/tests/xmlhttprequest/zero-length-response-expected.txt: Updated result
        * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated result
        * http/tests/xmlhttprequest/zero-length-response-sync.html: Corrected URL & added
        exception handling to test case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Peter Kasting <zerodpx@gmail.com>
mrowe@apple.com [Mon, 19 Nov 2007 12:22:50 +0000 (12:22 +0000)]
2007-11-19  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Darin Adler.

        The GIF decoder should not fail decoding if the caller asks it to
        decode again when no new data has arrived since the last call.

        * platform/image-decoders/gif/GIFImageReader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-19 Peter Kasting <zerodpx@gmail.com>
mrowe@apple.com [Mon, 19 Nov 2007 12:22:19 +0000 (12:22 +0000)]
2007-11-19  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Darin Adler.

        GIF decoding should respect frames' specified disposal methods.

        * platform/image-decoders/ImageDecoder.h:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        * platform/image-decoders/gif/GIFImageReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric
beidson@apple.com [Mon, 19 Nov 2007 07:14:37 +0000 (07:14 +0000)]
    Reviewed by Eric

        Fix a crash hashing a default SecurityOriginData object

        * storage/DatabaseTracker.cpp:
        (WebCore::SecurityOriginDataHash::hash): The default object has some default strings with NULL
          StringImpls - don't try to hash those!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 19 Nov 2007 00:40:38 +0000 (00:40 +0000)]
2007-11-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        * tests/mozilla/jsDriver.pl: exit non-0 when user aborts test run

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
timothy@apple.com [Sun, 18 Nov 2007 23:04:19 +0000 (23:04 +0000)]
    Reviewed by Sam Weinig.

        Bug 16043: Remove InspectorController.log now that console.log works

        Remove the last uses of InspectorController.log. Once use was no longer needed,
        checking an erro case that can't happen anymore. The other case now uses console.error.

        * page/InspectorController.cpp: Remove the log function.
        (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from
        InspectorController script class.
        * page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
        * page/inspector/Panel.js: Change InspectorController.log to console.log and early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
timothy@apple.com [Sun, 18 Nov 2007 23:01:03 +0000 (23:01 +0000)]
    Reviewed by Brady.

        Bug 16041: REGRESSION: the Database panel in the Inspector stopped showing errors

        * page/inspector/DatabasePanel.js: Implement error callbacks to pass to executeSql()
          and transaction(). Refactored some code for the success and error callbacks to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Nov 2007 22:18:49 +0000 (22:18 +0000)]
2007-11-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Anders.

        Make run-javascriptcore-tests report failures on exit (to support git bisect)

        * Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
ap@webkit.org [Sun, 18 Nov 2007 17:54:55 +0000 (17:54 +0000)]
    Reviewed by Adam Roben.

        Make run-webkit-tests work with Windows debug build.

        * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
        as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
        symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
        and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd wxWebKit sample and build script, and integrate it with build-webkit. Also make...
kevino@webkit.org [Sun, 18 Nov 2007 17:15:24 +0000 (17:15 +0000)]
Add wxWebKit sample and build script, and integrate it with build-webkit. Also make build-webkit --clean work for all ports.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-18 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Sun, 18 Nov 2007 11:31:04 +0000 (11:31 +0000)]
2007-11-18  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp.

        [GTK] Javascript console and dialogs are not implemented

        Correct script-prompt to return NULL when cancelled.

        Small changes to avoid compiler warnings.

        * Api/webkitgtkpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRestoring a binary svn:mime-type on the test.
ap@webkit.org [Sun, 18 Nov 2007 09:49:21 +0000 (09:49 +0000)]
Restoring a binary svn:mime-type on the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap@webkit.org [Sun, 18 Nov 2007 09:46:05 +0000 (09:46 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5546393> Whitespace handling doesn't match HTML5.

        HTML5 definition is the same as MSIE's, with the exception that the latter strips null
        characters. Firefox also treats U+0008 as whitespace, but not U+000B or U+000C.

        Test: fast/parser/html-whitespace.html

        * html/HTMLTokenizer.cpp:
        Use isASCIISpace, which matches HTML5 definition of whitespace, and also what we use to
        check for whitespace almost everywhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix: <rdar://problem/5607032> (REGRESSION: testapi exits with assertion failure in...
mrowe@apple.com [Sun, 18 Nov 2007 09:09:27 +0000 (09:09 +0000)]
Fix: <rdar://problem/5607032> (REGRESSION: testapi exits with assertion failure in debug build) and <rdar://problem/5440659> (JSGlobalContextCreate throws away globalObjectClass's prototype)

Split Interpreter's initialization into two distinct steps:  the creation of the global prototypes
and constructors, and storing them on the global object.  This allows JSClassRef's passed to
JSGlobalContextCreate to be instantiated with the correct prototype.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAttempt to fix port builds.
timothy@apple.com [Sun, 18 Nov 2007 06:58:49 +0000 (06:58 +0000)]
Attempt to fix port builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
timothy@apple.com [Sun, 18 Nov 2007 06:40:27 +0000 (06:40 +0000)]

        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        Add support for localization to the Web Inspector. Clients need to
        implement localizedStringsURL() to return the URL of the
        InspectorLocalizedStrings.js that best matches the user's language.

        * English.lproj: Added.
        * English.lproj/InspectorLocalizedStrings.js: Added.
        * WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
        * page/InspectorClient.h: Add localizedStringsURL.
        * page/InspectorController.cpp: Add localizedStringsURL that calls
          the client. Also added a version exposed to JavaScript.
        * page/InspectorController.h: Add localizedStringsURL.
        * page/inspector/ConsolePanel.js: Call WebInspector.UIString
          for user visible strings.
        * page/inspector/DatabasePanel.js: Ditto.
        * page/inspector/DocumentPanel.js: Ditto.
        * page/inspector/ImagePanel.js: Ditto.
        * page/inspector/MetricsSidebarPane.js: Ditto.
        * page/inspector/NetworkPanel.js: Ditto.
        * page/inspector/Panel.js: Ditto.
        * page/inspector/PropertiesSidebarPane.js: Ditto.
        * page/inspector/Resource.js: Ditto.
        * page/inspector/ResourceCategory.js: Ditto.
        * page/inspector/SourcePanel.js: Ditto.
        * page/inspector/StylesSidebarPane.js: Ditto.
        * page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
        * page/inspector/inspector.html: Remove some user visible strings.
        * page/inspector/inspector.js: Added WebInspector.UIString and call
          WebInspector.UIString for user visible strings. Some code needed to be
          moved to WebInspector.loaded to use UIString after the localized strings
          get loaded.
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix.
        (WebCore::SVGEmptyInspectorClient::createPage): Ditto.
        (WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub.
        (WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix.
        (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.


        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        Update the localized strings and the file encoding of WebInspectorClient.mm.

        * English.lproj/Localizable.strings:
        * StringsNotToBeLocalized.txt:
        * WebKit.xcodeproj/project.pbxproj:


        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::localizedStringsURL): Empty stub.
        * WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.


        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        Implement the localizedStringsURL() client method to return the
        localized URL of InspectorLocalizedStrings.js in WebCore.

        * WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::localizedStringsURL): Added.
        (WebInspectorClient::updateWindowTitle): Localized the window title.
        (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
        (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.


        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
        * WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.


        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        * English.lproj/Localizable.strings: Updated.
        * WebInspectorClient.cpp:
        (WebInspectorClient::localizedStringsURL): Empty stub.
        * WebInspectorClient.h: Added localizedStringsURL.


        Reviewed by Mark Rowe.

        Bug 13470: i18n: The Web Inspector is not localizable

        * WebKitSupport/InspectorClientWx.cpp:
        (WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
        * WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPrevent testapi from reporting false leaks.
mrowe@apple.com [Sun, 18 Nov 2007 05:36:52 +0000 (05:36 +0000)]
Prevent testapi from reporting false leaks.

Clear out local variables pointing at JSObjectRefs to allow their values to be collected.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPrevent testapi from crashing if testapi.js can not be found by nil-checking the...
mrowe@apple.com [Sun, 18 Nov 2007 05:36:29 +0000 (05:36 +0000)]
Prevent testapi from crashing if testapi.js can not be found by nil-checking the result of createStringWithContentsOfFile.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove IDL files from the WebCore.framework Resources.
timothy@apple.com [Sun, 18 Nov 2007 01:14:41 +0000 (01:14 +0000)]
Remove IDL files from the WebCore.framework Resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 17 Nov 2007 23:14:40 +0000 (23:14 +0000)]
2007-11-17  Alp Toker  <alp@atoker.com>

        Reviewed by Eric.

        JS minidom is not portable

        Use a plain UTF-8 string instead of a CFString.

        Print to stdout, not stderr like CFShow() would have done, since that
        behaviour seems unintentional.

        * API/minidom.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make it easy to run Safari in the debugger on Windows
aroben@apple.com [Sat, 17 Nov 2007 20:49:33 +0000 (20:49 +0000)]
 Make it easy to run Safari in the debugger on Windows


         Update Windows debugging instructions

         Reviewed by Mark Rowe.

         * building/debug.html:


         Make it easy to run Safari in the debugger on Windows

         I've added a new script, debug-safari, which launches Safari in the
         debugger. On OS X it just calls gdb-safari.

         Reviewed by Mark Rowe.

         * FindSafari/FindSafari.cpp:
         (_tmain): Added a /debugger flag, which in combination with
         /printSafariLauncher will print a script that launches Safari in the
         * Scripts/debug-safari: Added.
         * Scripts/run-safari: Changed to call runSafari().
         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
         first argument along to FindSafari.
         * Scripts/webkitdirs.pm:
         (sub runSafari): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
timothy@apple.com [Sat, 17 Nov 2007 20:02:10 +0000 (20:02 +0000)]
    Reviewed by Adam.

        Reworte String.sprintf to fix many bad bugs and to not use RegExp. Also added
        String.vsprintf so it can be used later for the localization function.

        This version only supports argument reordering, precision for floats, and these
        format characters: d, f, s and @. Any unsupported format characters are logged
        and substituted like strings.

        * page/inspector/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix.
sfalken@apple.com [Sat, 17 Nov 2007 16:53:38 +0000 (16:53 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix
ap@webkit.org [Sat, 17 Nov 2007 10:39:11 +0000 (10:39 +0000)]
    Windows build fix

        * WebView.cpp:
        (WebView::deleteSelection): Use canSmartCopyOrDelete() directly.

        * editing/Editor.h: Made canSmartCopyOrDelete public, as Windows WebView still needs it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Sat, 17 Nov 2007 08:58:24 +0000 (08:58 +0000)]
    Reviewed by Darin.

        Eliminate Editor::deleteRange()

        No change in functionality.

        * editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().

        * editing/Editor.cpp:
        * editing/Editor.h:
        Moved relevant Editor::deleteRange() functionality to its callers.
        Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful
        in my opinion.

        * editing/mac/EditorMac.mm:
        Pushed kill ring handling down from WebCore.

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        Removed setMarkDOMRange (the corresponding getter is still needed).

        * WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent().
        Export the new kill ring functions.

        * WebView/WebHTMLView.mm:
        (+[WebHTMLView initialize]):
        (-[WebHTMLView yank:]):
        (-[WebHTMLView yankAndSelect:]):
        (-[WebHTMLView setMark:]):
        (-[WebHTMLView deleteToMark:]):
        (-[WebHTMLView selectToMark:]):
        (-[WebHTMLView swapWithMark:]):
        Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
ap@webkit.org [Sat, 17 Nov 2007 08:28:23 +0000 (08:28 +0000)]
    Reviewed by Adam Roben.

        * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-16 Ryan Leavengood <leavengood@gmail.com>
ddkilzer@apple.com [Sat, 17 Nov 2007 06:47:50 +0000 (06:47 +0000)]
2007-11-16  Ryan Leavengood  <leavengood@gmail.com>

        Reviewed by David Kilzer.

        Build fix: the needed headers for POSIX file functions were not

        * platform/posix/FileSystemPOSIX.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-16 Ryan Leavengood <leavengood@gmail.com>
ddkilzer@apple.com [Sat, 17 Nov 2007 06:42:36 +0000 (06:42 +0000)]
2007-11-16  Ryan Leavengood  <leavengood@gmail.com>

        Reviewed by David Kilzer.

        The git config command was renamed to repo-config at some point. This
        change tries git config and then git repo-config if the first fails.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Sat, 17 Nov 2007 05:10:41 +0000 (05:10 +0000)]

        Reviewed by Darin Adler.

        - fix the common case of <http://bugs.webkit.org/show_bug.cgi?id=15994>
          REGRESSION: Incomplete repaint of CSS image substitution

        Test: fast/repaint/clip-with-layout-delta.html

        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState): Account for layout delta when
        pushing additional clip.


        Reviewed by Darin Adler.

        - repaint test for <http://bugs.webkit.org/show_bug.cgi?id=15994>
          REGRESSION: Incomplete repaint of CSS image substitution

        * fast/repaint/clip-with-layout-delta.html: Added.
        * platform/mac/fast/repaint/clip-with-layout-delta-expected.checksum: Added.
        * platform/mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
        * platform/mac/fast/repaint/clip-with-layout-delta-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Sat, 17 Nov 2007 04:05:51 +0000 (04:05 +0000)]
    Reviewed by Adam.

        XMLHttpRequest readyState 3 & responseText buffer issues.

        Add wkSetCFURLRequestShouldContentSniff.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ChangeLog
antti@apple.com [Sat, 17 Nov 2007 02:13:48 +0000 (02:13 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti@apple.com [Sat, 17 Nov 2007 02:10:16 +0000 (02:10 +0000)]

        Reviewed by Adele.

        Seeking related fixes, updates match to the latest specification
        - rename loopCount of HTMLMediaElement to playCount
        - add explicit seeking attribute to HTMLMediaElement to get semantics right
        - implement the specification behavior that currentTime must immediately return seeked position in HTMLMediaElement
          instead of MoviePrivateQTKit
        - fix broken behavior when seeking past end of the media, add tests
        - replace Movie didEnd callback with broader timeChanged callback (which gets called in didEnd case too)
        - use setDelayCallbacks: in various MoviePrivateQTKit methods to avoid bug prone synchronous callbacks from QT, make
          HTMLMediaElement not depend on synchronous callbacks
        - do some cleanups and simplifications in MoviePrivateQTKit, get rid of m_rateBeforeSeek and m_blockStateUpdate variables

        Tests: http/tests/media/video-seekable-stall.html

        * html/HTMLAttributeNames.in:
        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:
        * platform/graphics/Movie.cpp:
        * platform/graphics/Movie.h:
        * platform/graphics/mac/MoviePrivateQTKit.h:
        * platform/graphics/mac/MoviePrivateQTKit.mm:


        Reviewed by Adele.

        Seeking related test updates
        - update to match specificiation
            - rename loopCount to playCount everywhere
            - timeupdate events during seek
        - fix that some tests (like audio ones) depended on timing sensitive ordering of play and load events
        - add text about what is being tested

        Add new tests for seeking past end, seeking past loaded position and 'seeking' DOM attribute.

        * http/tests/media/video-seekable-stall-expected.txt: Added.
        * http/tests/media/video-seekable-stall.html: Added.
        * media/audio-constructor-expected.txt:
        * media/audio-constructor-src-expected.txt:
        * media/audio-constructor-src.html:
        * media/audio-constructor.html:
        * media/video-dom-loopcount-expected.txt:
        * media/video-dom-loopcount.html:
        * media/video-dom-loopend-expected.txt:
        * media/video-dom-loopend.html:
        * media/video-dom-loopstart-expected.txt:
        * media/video-dom-loopstart.html:
        * media/video-dom-start-expected.txt:
        * media/video-dom-start.html:
        * media/video-loopcount-expected.txt:
        * media/video-loopcount.html:
        * media/video-loopend-expected.txt:
        * media/video-loopend.html:
        * media/video-loopstart-expected.txt:
        * media/video-loopstart.html:
        * media/video-seek-past-end-paused-expected.txt: Added.
        * media/video-seek-past-end-paused.html: Added.
        * media/video-seek-past-end-playing-expected.txt: Added.
        * media/video-seek-past-end-playing.html: Added.
        * media/video-seeking-expected.txt: Added.
        * media/video-seeking.html: Added.
        * media/video-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca@apple.com [Sat, 17 Nov 2007 01:32:01 +0000 (01:32 +0000)]

        Reviewed by Adam.

        XMLHttpRequest readyState 3 & responseText buffer issues.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        Add new parameter which controls whether content sniffing should be turned off.

        Always content sniff sync loads.

        * platform/network/cf/ResourceRequestCFNet.cpp:
        If the ResourceRequest already has a backing CFURLRequest, make a copy of it. This preserves
        any properties set on the CFURLRequest.


        Reviewed by Adam.

        XMLHttpRequest readyState 3 & responseText buffer issues.

        Remove http/tests/xmlhttprequest/small-chunks-response-text.html from the Skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ChangeLog
mitz@apple.com [Sat, 17 Nov 2007 01:25:55 +0000 (01:25 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKitTools:
mitz@apple.com [Sat, 17 Nov 2007 01:24:53 +0000 (01:24 +0000)]

        Reviewed by Darin Adler and Sam Weinig.

        - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on boomer

        * DumpRenderTree/win/EventSender.cpp:
        (keyDownCallback): For characters that cannot be entered on the active
        keyboard layout, send a WM_CHAR message with the character along with
        a WM_KEYDOWN message with a virtual key code of 255.


        Reviewed by Darin Adler and Sam Weinig.

        - remove fast/forms/select-type-ahead-non-latin.html after fixing <rdar://problem/5134075>

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 17 Nov 2007 01:16:56 +0000 (01:16 +0000)]
2007-11-16  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Ollie.

        <rdar://problem/5605175> Crash closing or leaving window with ViewPoint
        Media player plugin

        ViewPoint plugin requires that we pass a valid NPSavedData* to

        * plugins/win/PluginViewWin.cpp: Pass a valid NPSavedData* to
        NPP_Destroy. If the plugin allocates data, discard it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWindows build fix.
mrowe@apple.com [Sat, 17 Nov 2007 00:52:17 +0000 (00:52 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild WebCore as a sub-framework of WebKit in all configurations.
mrowe@apple.com [Fri, 16 Nov 2007 23:50:45 +0000 (23:50 +0000)]
Build WebCore as a sub-framework of WebKit in all configurations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-16 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 16 Nov 2007 22:43:36 +0000 (22:43 +0000)]
2007-11-16  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric.

        Replace strings, identifier, buffer8 and buffer16 members of Lexer with vectors.
        SunSpider claims this is a 0.7% speedup.

        * kjs/lexer.cpp:
        * kjs/lexer.h:
        * kjs/ustring.cpp:
        (KJS::UString::UString): Add a convenience constructor that takes a const Vector<UChar>&.
        * kjs/ustring.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-16 Doug Turner <dougt@meer.net>
alp@webkit.org [Fri, 16 Nov 2007 22:27:03 +0000 (22:27 +0000)]
2007-11-16  Doug Turner  <dougt@meer.net>

        Reviewed by Alp.

        build bustage when building on debian 4.0

        Fix build bustage on GTK+ with older versions of Pango.

        Don't cache the return value since the docs say it can change.

        * platform/gtk/Language.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix
aroben@apple.com [Fri, 16 Nov 2007 21:55:14 +0000 (21:55 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path
        and ignore the int -> bool conversion warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady
sullivan@apple.com [Fri, 16 Nov 2007 19:21:42 +0000 (19:21 +0000)]
    Reviewed by Brady

        * WebKit.exp:
        Exported some new database-related symbols

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!
beidson@apple.com [Fri, 16 Nov 2007 19:06:23 +0000 (19:06 +0000)]
    * WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so
beidson@apple.com [Fri, 16 Nov 2007 18:59:25 +0000 (18:59 +0000)]
    * WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so
          it is exported

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/mac:
beidson@apple.com [Fri, 16 Nov 2007 17:34:57 +0000 (17:34 +0000)]

        Reviewed by John

        Database management API tweaks

        Fleshed out "WebSecurityOrigin" to be the API object representing an origin.  This relieves some
        burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself

        Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
        the WebKit tree?

        * Misc/WebSecurityOrigin.mm: Removed.
        * Misc/WebSecurityOriginInternal.h: Removed.
        * Misc/WebSecurityOriginPrivate.h: Removed.

        * Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
        * Storage/WebDatabaseManagerPrivate.h:

        * Storage/WebSecurityOrigin.mm: Added.
        (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
        (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
        (-[WebSecurityOriginPrivate finalize]):
        (-[WebSecurityOriginPrivate dealloc]):
        (-[WebSecurityOrigin initWithProtocol:domain:]):
        (-[WebSecurityOrigin initWithProtocol:domain:port:]):
        (-[WebSecurityOrigin protocol]):
        (-[WebSecurityOrigin domain]):
        (-[WebSecurityOrigin port]):
        (-[WebSecurityOrigin usage]):
        (-[WebSecurityOrigin quota]):
        (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
        (-[WebSecurityOrigin dealloc]):
        (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
        * Storage/WebSecurityOriginInternal.h: Added.
        * Storage/WebSecurityOriginPrivate.h: Added.


        Reviewed by John

        Database management API tweaks

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix
beidson@apple.com [Fri, 16 Nov 2007 17:25:17 +0000 (17:25 +0000)]
    Build fix

        * platform/SecurityOriginData.h:
        (WebCore::operator!=): Whoops!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam
beidson@apple.com [Fri, 16 Nov 2007 17:13:20 +0000 (17:13 +0000)]
    Reviewed by Sam

        Further purify DatabaseTracker to use SecurityOriginData instead of "a String"

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCore.vcproj/WebCore.vcproj
        * WebCore.pro

        * platform/SecurityOriginData.cpp: Added.
        (WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string,
          since that form is what will be stored in the Databases.db on disk
        * platform/SecurityOriginData.h:

        * storage/DatabaseTracker.cpp:
        (WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for
          a SecurityOriginData object
        (WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation
        (WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation
        * storage/DatabaseTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubberstamped by Eric.
zimmermann@webkit.org [Fri, 16 Nov 2007 12:22:34 +0000 (12:22 +0000)]
Rubberstamped by Eric.

Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix.
ap@webkit.org [Fri, 16 Nov 2007 12:20:01 +0000 (12:20 +0000)]
    Windows build fix.

        * WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann@webkit.org [Fri, 16 Nov 2007 11:20:56 +0000 (11:20 +0000)]
Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290
Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.

Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Windows debug build.
ap@webkit.org [Fri, 16 Nov 2007 10:49:40 +0000 (10:49 +0000)]
    Fix Windows debug build.
        Rubber-stamped by Eric

        * pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC
        complain about unreachable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 16 Nov 2007 07:47:52 +0000 (07:47 +0000)]
2007-11-15  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/Parser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMac build and header search path sanity fix.
mrowe@apple.com [Fri, 16 Nov 2007 07:44:18 +0000 (07:44 +0000)]
Mac build and header search path sanity fix.

Reviewed by Sam Weinig and Tim Hatcher.

Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig.  This removes the need to override it on a
per-target basis inside the .xcodeproj file.

* Configurations/Base.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 16 Nov 2007 07:08:05 +0000 (07:08 +0000)]
2007-11-15  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * kjs/Parser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele@apple.com [Fri, 16 Nov 2007 07:00:50 +0000 (07:00 +0000)]

        Reviewed by Oliver.

        Fix for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

        Test: fast/forms/menulist-no-renderer-onmousedown.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here.  None of the default behavior makes sense if there's no renderer.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.


        Reviewed by Oliver.

        Test for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

        * fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
        * fast/forms/menulist-no-renderer-onmousedown.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric Seidel.
ggaren@apple.com [Fri, 16 Nov 2007 06:54:09 +0000 (06:54 +0000)]
    Reviewed by Eric Seidel.

        Another round of grammar / parsing cleanup.

        1. Created distinct parser calls for parsing function bodies vs
        programs. This will help later with optimizing global variable access.

        2. Turned Parser into a singleton. Cleaned up Lexer's singleton

        3. Modified Lexer to free a little more memory when done lexing. (Added
        FIXMEs for similar issues that I didn't fix.)

        4. Changed Lexer::makeIdentifier and Lexer::makeUString to start
        respecting the arguments passed to them. (No behavior change, but this
        problem could have caused serious problems for an unsuspecting user of
        these functions.)

        5. Removed KJS_DEBUG_MEM because it was bit-rotted.

        6. Removed Parser::prettyPrint because the same work was simpler to do
        at the call site.

        7. Some renames:

            "Parser::accept" => "Parser::didFinishParsing"
            "Parser::sid" => "Parser::m_sourceID"
            "Lexer::doneParsing" => "Lexer::clear"
            "sid" => "sourceId"
            "lineno" => "lineNo"

        * JavaScriptCore.exp:
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/function.cpp:
        * kjs/function_object.cpp:
        * kjs/grammar.y:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        * kjs/lexer.cpp:
        * kjs/lexer.h:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/testkjs.cpp:
        * kjs/ustring.cpp:
        * kjs/ustring.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
antti@apple.com [Fri, 16 Nov 2007 06:25:36 +0000 (06:25 +0000)]
    Reviewed by Adele.

        Fix <rdar://problem/5601598>
        The movie tag should do initialization on need and not during startup.

        Initialize Movie MIME type hash on demand

        * platform/MIMETypeRegistry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 16 Nov 2007 06:18:22 +0000 (06:18 +0000)]
2007-11-15  Mark Rowe  <mrowe@apple.com>

        Build fix for Qt on Windows.

        * xml/XPathStep.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
timothy@apple.com [Fri, 16 Nov 2007 06:15:18 +0000 (06:15 +0000)]
    Reviewed by Mark Rowe.

        Bug 14761: Web Inspector leaks JS objects and DOM nodes

        * page/InspectorController.cpp:
        Change the tear down order so that inspectorDestroyed() is called before
        InspectorController private data is set to Zero. The inspectorDestroyed()
        call ends up closing the WebView and triggering InspectorController::close()
        which unprotects m_scriptObject. This didn't happen when the private data
        was cleared before calling inspectorDestroyed().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 16 Nov 2007 06:10:30 +0000 (06:10 +0000)]
2007-11-15  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Fri, 16 Nov 2007 06:04:45 +0000 (06:04 +0000)]
    Reviewed by Darin.

        XPath queries with predicates incorrectly retains the current node across unions

        Test: fast/xpath/union-context-node.xhtml

        * xml/XPathPath.cpp:
        (WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Fri, 16 Nov 2007 06:02:20 +0000 (06:02 +0000)]
    Reviewed by Darin.

        Import XPath test suite from amachang.art-code.org

        Test by Hitoshi Amano <seijro@gmail.com>.

        * fast/xpath/xpath-functional-test-expected.txt: Added.
        * fast/xpath/xpath-functional-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Fri, 16 Nov 2007 06:00:53 +0000 (06:00 +0000)]
    Reviewed by Darin.

        REGRESSION: XPath preceding-axis query misses nested elements

        Test: fast/xpath/preceding-axis.xhtml

        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe and Sam.
timothy@apple.com [Fri, 16 Nov 2007 01:21:32 +0000 (01:21 +0000)]
    Reviewed by Mark Rowe and Sam.

        This corrects a couple of issues in the Web Inspector where selected search results
        would not have the right text color when the window is inactive or the results are focused.

        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
timothy@apple.com [Fri, 16 Nov 2007 01:04:48 +0000 (01:04 +0000)]
    Reviewed by Sam.

        Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels

        Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
        a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
        20 pixels, and the default is 10 pixels.

        * page/inspector/ResourceCategory.js:
        * page/inspector/treeoutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Fri, 16 Nov 2007 00:42:55 +0000 (00:42 +0000)]
    Reviewed by Brady.

        Pass a VoidCallback to Database::transaction and Database::changeVersion.
        This is not yet hooked up to the database machinery.

        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/JSDatabaseCustom.cpp:
        * storage/Database.cpp:
        * storage/Database.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago<rdar://problem/5601548> REGRESSION: All SourceElements and their children leak after...
oliver@apple.com [Fri, 16 Nov 2007 00:40:24 +0000 (00:40 +0000)]
<rdar://problem/5601548> REGRESSION: All SourceElements and their children leak after a syntax error

Reviewed by Darin.

Add a stub node to maintain the Vector of SourceElements until assignment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 16 Nov 2007 00:17:54 +0000 (00:17 +0000)]
2007-11-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Abstract most of RMATCH into MatchStack functions.

        SunSpider claims this, combined with the last 2 patches was a 1% speedup, 10% for dna-regexp.

        * pcre/pcre_exec.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 16 Nov 2007 00:16:21 +0000 (00:16 +0000)]
2007-11-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Remove RETURN_ERROR, add MatchStack

        * pcre/pcre_exec.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 16 Nov 2007 00:14:33 +0000 (00:14 +0000)]
2007-11-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Clean up match function to match WebKit style

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * pcre/pcre_exec.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
timothy@apple.com [Fri, 16 Nov 2007 00:07:44 +0000 (00:07 +0000)]
    Reviewed by Adam.

        Bug 16005: Hovering in the breadcrumbs causes jumpy behavior

        Hovering over cumbs no longer exposes new crumbs. Clicking on a collapsed
        crumb will expose as many hidden crumbs as possible to the user. Also crumbs
        that have ID attributes will compact to the ID over the tag name.

        * page/inspector/DocumentPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
andersca@apple.com [Thu, 15 Nov 2007 23:53:19 +0000 (23:53 +0000)]
    Reviewed by Sam.

        Make the VoidCallback DOM interface behave more like our other DOM interfaces.

        * bindings/js/JSCustomVoidCallback.h: Added.
        * bindings/js/JSCustomVoidCallback.cpp: Added.
        VoidCallback implementation that wraps a JS object.

        New method that creates a VoidCallback implementation given a JS object.

        * bindings/scripts/CodeGeneratorJS.pm:
        Specify that VoidCallback can fail conversion and add a custom conversion function.

        * html/HTMLMediaElement.cpp:
        Call handleEvent on the callback.

        Comment out parts of this method, it has already been removed in the HTML5 spec and it relies
        on overriding VoidCallback equality.

        * html/VoidCallback.cpp: Removed.

        * html/VoidCallback.h:
        Make this an abstract class with a pure virtual handleEvent method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix <rdar://5485108> Type-select while a <select> menu is open doesn't work
aroben@apple.com [Thu, 15 Nov 2007 23:42:41 +0000 (23:42 +0000)]
     Fix <rdar://5485108> Type-select while a <select> menu is open doesn't work

         There were two things broken here:
            - WebView now requires a WM_CHAR message to be sent before it will
              create a keyboard event with a charCode, but we were only sending
              a WM_KEYDOWN event.
            - The popup menu was not updating its focused index when the
              <select> element's selectedIndex changed.

         Reviewed by Adele.

         * platform/win/PopupMenuWin.cpp:
         (WebCore::PopupMenu::updateFromElement): Update the focused index from
         the client's selected index.
         (WebCore::PopupWndProc): When we receive a WM_CHAR message for a
         printable character, manufacture a WM_KEYDOWN message for it and post
         both that and the current WM_CHAR message to the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix
beidson@apple.com [Thu, 15 Nov 2007 23:23:54 +0000 (23:23 +0000)]
    Build fix

        * storage/DatabaseTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot this new expected result in my previous check-in.
justin.garcia@apple.com [Thu, 15 Nov 2007 22:54:29 +0000 (22:54 +0000)]
Forgot this new expected result in my previous check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John and Sam
beidson@apple.com [Thu, 15 Nov 2007 22:29:34 +0000 (22:29 +0000)]
    Reviewed by John and Sam

        Stubbing out everything required for a WebKit API for databases

        Biggest change in WebCore is that we passed around SecurityOriginData as the representation
        of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
        that has a different purpose besides just hanging on to the data)

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:
        * platform/SecurityOriginData.h: Added.  Simple object to encapsulate the 3
          pieces of data in the SecurityOrigin tuple
        (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components,
          colon separated

        * storage/Database.cpp:
        (WebCore::Database::Database): Use SecurityOriginData instead

        * storage/DatabaseTracker.cpp:
        * storage/DatabaseTracker.h:

        * storage/DatabaseTrackerClient.h: Added.  For dispatching notifications up to WebKit
        (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):2007-11-15  Jon Honeycutt  <jhoneycutt@apple.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson@apple.com [Thu, 15 Nov 2007 22:27:14 +0000 (22:27 +0000)]

        Reviewed by John and Sam

        Stubbing out everything required for a WebKit API for databases

        Biggest change in WebCore is that we passed around SecurityOriginData as the representation
        of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
        that has a different purpose besides just hanging on to the data)

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:
        * platform/SecurityOriginData.h: Added.  Simple object to encapsulate the 3
          pieces of data in the SecurityOrigin tuple
        (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components,
          colon separated

        * storage/Database.cpp:
        (WebCore::Database::Database): Use SecurityOriginData instead

        * storage/DatabaseTracker.cpp:
        * storage/DatabaseTracker.h:

        * storage/DatabaseTrackerClient.h: Added.  For dispatching notifications up to WebKit


        Reviewed by John

        Stubbing out everything required for a WebKit API for databases

        * WebKit.xcodeproj/project.pbxproj:


        Reviewed by John

        Stubbing out everything required for a WebKit API for databases

        These interfaces seem to provide everything we need for UI and management at the browser level

        * Misc/WebDatabaseManager.h: Removed.
        * Misc/WebDatabaseManager.mm: Removed.
        * Misc/WebDatabaseManagerPrivate.h: Removed.

        * Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
          (protocol, domain, and port)
        (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
        (-[WebSecurityOriginPrivate dealloc]):
        (-[WebSecurityOrigin initWithProtocol:domain:]):
        (-[WebSecurityOrigin initWithProtocol:domain:port:]):
        (-[WebSecurityOrigin protocol]):
        (-[WebSecurityOrigin domain]):
        (-[WebSecurityOrigin port]):
        (-[WebSecurityOrigin dealloc]):
        (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
        * Misc/WebSecurityOriginInternal.h: Added.
        * Misc/WebSecurityOriginPrivate.h: Added.

        * Storage/WebDatabaseManager.mm: Added.
        (+[WebDatabaseManager sharedWebDatabaseManager]):
        (-[WebDatabaseManager origins]):  Get a list of all origins currently tracked
        (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
        (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
        (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
        (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
        (-[WebDatabaseManager deleteAllDatabases]):
        (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
        (-[WebDatabaseManager deleteDatabase:withOrigin:]):
        * Storage/WebDatabaseManagerPrivate.h: Added.
        * Storage/WebDatabaseManagerInternal.h: Added.
        (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things

        * Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
        * Storage/WebDatabaseTrackerClient.mm: Added.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
          Database-related things here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 15 Nov 2007 22:23:42 +0000 (22:23 +0000)]
2007-11-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        NP_ASFILEONLY streams should not buffer data in m_deliveryData.

        * plugins/win/PluginStreamWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRevert accidental change. andersca--
andersca@apple.com [Thu, 15 Nov 2007 22:02:47 +0000 (22:02 +0000)]
Revert accidental change. andersca--

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
justin.garcia@apple.com [Thu, 15 Nov 2007 21:52:41 +0000 (21:52 +0000)]

        Reviewed by Adele Peterson.

        <rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

        A textarea that contained the selection was removed but the selection wasn't cleared,
        and we'd crash in code that assumed a valid, in-document selection.

        * editing/SelectionController.cpp:
        (WebCore::removingNodeRemovesPosition): Clear the selection if the node being removed is the
        shadowAncestorNode of the node that contains the position, not just if the node being removed
        contains that shadowAncestorNode.


        Reviewed by Adele Peterson.

        <rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

        * editing/selection/5497643-expected.txt: Added.
        * editing/selection/5497643.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make run-safari actually work on Windows
aroben@apple.com [Thu, 15 Nov 2007 21:35:28 +0000 (21:35 +0000)]
    Make run-safari actually work on Windows

        * Scripts/run-safari: Fixed the order of arguments to cp, and added a
        chdir call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Maciej.
zimmermann@webkit.org [Thu, 15 Nov 2007 21:22:57 +0000 (21:22 +0000)]
Reviewed by Maciej.
Fix logic error: calculateGlyphBoundaries takes RTL text into account itself, no need to adjust offsets before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca@apple.com [Thu, 15 Nov 2007 20:27:44 +0000 (20:27 +0000)]

        Reviewed by Brady.

        openDatabase does not work when the version string is empty

        If the string is empty, pass a real empty string to sqlite3_bind_text16.

        * platform/sql/SQLiteStatement.cpp:


        Reviewed by Brady.

        openDatabase does not work when the version string is empty

        * storage/open-database-empty-version-expected.txt: Added.
        * storage/open-database-empty-version.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Thu, 15 Nov 2007 19:49:25 +0000 (19:49 +0000)]
    Reviewed by Brady.

        Get rid of SQLiteStatement::bindText and rename bindText16 to bindText.
        Remove the copy parameter from bindText and bindBlob and always copy passed in data instead.

        * loader/icon/IconDatabase.cpp:
        * platform/sql/SQLiteStatement.cpp:
        * platform/sql/SQLiteStatement.h:
        * storage/Database.cpp:
        * storage/DatabaseTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27813 268f45cc-cd09-0410-ab3c-d52691b4dbfc