WebKit-https.git
8 years agoEWS bubbles need more space
rniwa@webkit.org [Thu, 21 Mar 2013 21:49:22 +0000 (21:49 +0000)]
EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=112964

Reviewed by Philip Rogers.

Increased the width from 500px to 600px so that all bubbles fit.

* template/en/custom/attachment/list.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/frames/detach-frame-during-focus.html fails on some platforms
tkent@chromium.org [Thu, 21 Mar 2013 21:47:37 +0000 (21:47 +0000)]
fast/frames/detach-frame-during-focus.html fails on some platforms
https://bugs.webkit.org/show_bug.cgi?id=112904

* fast/frames/detach-frame-during-focus.html:
Do not run the test sequence twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttp://trac.webkit.org/changeset/146375 causing CrOS crashes
commit-queue@webkit.org [Thu, 21 Mar 2013 21:37:38 +0000 (21:37 +0000)]
trac.webkit.org/changeset/146375 causing CrOS crashes
https://bugs.webkit.org/show_bug.cgi?id=112958

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/flexbox/crash-anonymous-box.html

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Anonymous renderers don't have a node in their constructor, so
don't get document() in there.

LayoutTests:

* fast/flexbox/crash-anonymous-box-expected.txt: Added.
* fast/flexbox/crash-anonymous-box.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add possibleUserNames to WebPasswordFormData
commit-queue@webkit.org [Thu, 21 Mar 2013 21:30:19 +0000 (21:30 +0000)]
[chromium] Add possibleUserNames to WebPasswordFormData
https://bugs.webkit.org/show_bug.cgi?id=112375

Patch by Garrett Casto <gcasto@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

* public/WebPasswordFormData.h:
(WebPasswordFormData):
* src/WebPasswordFormData.cpp:
(WebKit::WebPasswordFormData::WebPasswordFormData):
* src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):
* src/WebPasswordFormUtils.h:
(PasswordFormFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSP 1.1: Fire a SecurityPolicyViolationEvent when violations occur.
mkwst@chromium.org [Thu, 21 Mar 2013 21:25:36 +0000 (21:25 +0000)]
CSP 1.1: Fire a SecurityPolicyViolationEvent when violations occur.
https://bugs.webkit.org/show_bug.cgi?id=112783

Reviewed by Adam Barth.

Source/WebCore:

A new event type for Content Security Policy violations landed in
http://wkrev.com/146305; this patch takes that stub, and wires it up to
ContentSecurityPolicy::reportViolation such that violation events fire
when resources are blocked.

This should bring WebKit up to date with the current description of
CSP's event model in sections 3.3[1] and 3.4.1.3[2] of the editor's
draft.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model
[2]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#firing-events-using-the-securitypolicyviolationevent-interface

Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html

* page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
    Populate a SecurityPolicyViolationEventInit object with the various
    bits of data that should be passed into the event constructor.

    This static method is strictly an implementation detail; it's not
    part of ContentSecurityPolicy's public API.
(WebCore::ContentSecurityPolicy::reportViolation):
    Regardless of whether the policy has set a 'report-uri' directive
    or not, gather together all the data we'll need to fire an event,
    create the event, and queue it up for dispatching on the Document.

LayoutTests:

* http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
tdanderson@chromium.org [Thu, 21 Mar 2013 21:22:53 +0000 (21:22 +0000)]
[chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
https://bugs.webkit.org/show_bug.cgi?id=112928

Reviewed by Stephen White.

This flag was only for ChromeOS builds with HighDPI. It is no longer needed and can be removed.
See http://crbug.com/17550

Source/WebCore:

No new tests needed since this is just removing unused code.

* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):
* platform/graphics/skia/PlatformContextSkia.h:

Source/WebKit/chromium:

* features.gypi:
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
* tests/PlatformContextSkiaTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport connecting the Web Inspector without showing it.
timothy@apple.com [Thu, 21 Mar 2013 21:16:41 +0000 (21:16 +0000)]
Support connecting the Web Inspector without showing it.

This allows you to get the debugger attached in the background. When a breakpoint is hit
the Inspector will open. This change also reduces some WebProcess messaging by removing
the DidLoadInspectorPage message and stops sending the SetAttachedWindow message on close.

https://bugs.webkit.org/show_bug.cgi?id=112445

Reviewed by Sam Weinig.

* UIProcess/API/C/WKInspector.cpp:
(WKInspectorIsConnected): Added.
(WKInspectorConnect): Added.
(WKInspectorHide): Added.

* UIProcess/API/C/WKInspector.h:
Added new APIs.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
Initialize new state booleans.

(WebKit::WebInspectorProxy::invalidate):
Don't set state booleans that didClose already resets.

(WebKit::WebInspectorProxy::connect): Added.
(WebKit::WebInspectorProxy::show):
Open if we are already connected. Call connect().

(WebKit::WebInspectorProxy::hide): Added.

(WebKit::WebInspectorProxy::close):
Call didClose we can detach or close the window immediately instead of waiting for a
message from the WebProcess.

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
Check for !m_page to match other functions.

(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
Removed. Moved logic to open().

(WebKit::WebInspectorProxy::open): Added.

(WebKit::WebInspectorProxy::didClose):
Clear new state booleans. Don't perform work again if already closed. Use platformDetach()
instead of detach() to avoid sending the SetAttachedWindow message.

(WebKit::WebInspectorProxy::bringToFront):
Call open() if we are not visible yet, otherwise platformBringToFront.

* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::isConnected): Added.

* UIProcess/WebInspectorProxy.messages.in: Removed DidLoadInspectorPage.

* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformHide): Added stub.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformHide): Added.

* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformHide): Added stub.

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
Removed frontendLoaded().

* WebProcess/WebPage/WebInspector.cpp:
* WebProcess/WebPage/WebInspector.h:
Removed didLoadInspectorPage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup android media layout test code
commit-queue@webkit.org [Thu, 21 Mar 2013 21:02:57 +0000 (21:02 +0000)]
Cleanup android media layout test code
https://bugs.webkit.org/show_bug.cgi?id=112944

Patch by Min Qin <qinmin@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

Chromium change: https://codereview.chromium.org/12892010/
The current android layout tests are using WebmediaPlayerInProcessAndroid class.
The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
Instead, we should switch to use content shell for layout tests.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDrop full URLs from cross-origin access errors caused by protocol mismatches.
mkwst@chromium.org [Thu, 21 Mar 2013 21:02:34 +0000 (21:02 +0000)]
Drop full URLs from cross-origin access errors caused by protocol mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112894

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112813, this patch brings protocol
mismatch errors into line with the new origin-only hotness. The message
is also changed to display the URL's protocol rather than the origin's
protocol: it makes a big difference for 'data:' URLs, for instance.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):

LayoutTests:

* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
* http/tests/security/cross-frame-access-protocol-expected.txt:
* http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
* http/tests/security/view-source-no-javascript-url-expected.txt:
* http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
* http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
* http/tests/security/xssAuditor/full-block-base-href-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
* http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
* http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
* platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
* platform/chromium/http/tests/security/window-named-proto-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG text path referencing parent text infinite loops
schenney@chromium.org [Thu, 21 Mar 2013 20:57:35 +0000 (20:57 +0000)]
SVG text path referencing parent text infinite loops
https://bugs.webkit.org/show_bug.cgi?id=112078

Reviewed by Philip Rogers.

Source/WebCore:

We do not check the target type when adding a resource reference for
SVG Text Path's URI. This goes horribly wrong when the target is the
text path's parent text element. In this patch we check that the target
element of the text path is indeed a path element, as the spec
requires. No other element type is allowed.

Note that RenderSVGTextPath enforces this check in the renderer code
also, so if we get past this check via pending resources, it doesn't
matter. You can't get into this situation with a pending reference
because, by definition, the parent must be defined before the text
path child.

Test: svg/text/textpath-referencing-text-crash.svg

* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::buildPendingResource):

LayoutTests:

* svg/text/textpath-referencing-text-crash-expected.txt: Added.
* svg/text/textpath-referencing-text-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] add missing project dependencies to DRT to fix Mac Valgrind
dpranke@chromium.org [Thu, 21 Mar 2013 20:56:16 +0000 (20:56 +0000)]
[chromium] add missing project dependencies to DRT to fix Mac Valgrind
https://bugs.webkit.org/show_bug.cgi?id=112953

Reviewed by Tony Chang.

When I created the DumpRenderTree_resources target in r144863 I
forgot to declare the needed dependencies on the other resource
targets. Due to a quirk of ordering, this appears to have been fine
w/ ninja but not w/ Xcode (which is still being used on the chromium
mac valgrind bots). Declaring the dependencies fixes the build
failures.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Build fix.
ap@apple.com [Thu, 21 Mar 2013 20:53:02 +0000 (20:53 +0000)]
    Build fix.

        * NetworkProcess/mac/NetworkResourceLoaderMac.mm: Include CurrentTime.h, as needed
        to call currentTime().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
pilgrim@chromium.org [Thu, 21 Mar 2013 20:49:06 +0000 (20:49 +0000)]
[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
https://bugs.webkit.org/show_bug.cgi?id=112931

Reviewed by Adam Barth.

Migration complete; flag no longer needed.

* chromium/public/WebFileSystemType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Remove onVersionChange(string) plumbing
jsbell@chromium.org [Thu, 21 Mar 2013 20:43:58 +0000 (20:43 +0000)]
IndexedDB: Remove onVersionChange(string) plumbing
https://bugs.webkit.org/show_bug.cgi?id=112712

Reviewed by Adam Barth.

Source/WebCore:

Delete unused onVersionChange(string) overload.

No new tests - just deleting dead code.

* Modules/indexeddb/IDBDatabase.cpp: Delete onVersionChange(string) overload.
* Modules/indexeddb/IDBDatabase.h: Ditto.
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Ditto.
* Modules/indexeddb/IDBDatabaseCallbacks.h: Ditto.
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Ditto.
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Ditto.

Source/WebKit/chromium:

* public/WebIDBDatabaseCallbacks.h: Remove onVersionChange(string) overload.
* src/IDBDatabaseCallbacksProxy.cpp: Ditto.
* src/IDBDatabaseCallbacksProxy.h: Ditto.
* src/WebIDBDatabaseCallbacksImpl.cpp: Ditto.
* src/WebIDBDatabaseCallbacksImpl.h: Ditto.
* tests/IDBAbortOnCorruptTest.cpp: Ditto.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect bisector angle calculation for markers
pdr@google.com [Thu, 21 Mar 2013 20:35:36 +0000 (20:35 +0000)]
Correct bisector angle calculation for markers
https://bugs.webkit.org/show_bug.cgi?id=112054

Reviewed by Stephen Chenney.

Source/WebCore:

The SVG marker spec states that mid markers with orient=auto should be aligned with their
x-axis along the bisector of the incoming (in) and outgoing (out) angles. Previously we
calculated this bisector angle as:
    bisector = (in + out) / 2;
Angles cannot be averaged this way! Consider in=90deg and out=-180deg: the bisector should
be 135deg but a naive average gives -45deg. This patch corrects for the discontinuity in
angle values with:
    bisector = (in + out + 360) / 2   // if |in - out| > 180
    bisector = (in + out) / 2         // otherwise
This patch includes an exhaustive test of angle values.

Test: svg/custom/marker-orient-auto.html

* rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::currentAngle):

LayoutTests:

* platform/chromium-linux/svg/custom/marker-orient-auto-expected.png: Added.
* platform/chromium-linux/svg/custom/marker-orient-auto-expected.txt: Added.
* platform/chromium/TestExpectations:
* svg/custom/marker-orient-auto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose the Type field of an RTCStatsReport
commit-queue@webkit.org [Thu, 21 Mar 2013 20:28:46 +0000 (20:28 +0000)]
Expose the Type field of an RTCStatsReport
https://bugs.webkit.org/show_bug.cgi?id=112951

Patch by Harald Alvestrand <hta@google.com> on 2013-03-21
Reviewed by Adam Barth.

Source/WebCore:

Covered by an extension of an existing test.

* Modules/mediastream/RTCStatsReport.h:
(WebCore::RTCStatsReport::type):
* Modules/mediastream/RTCStatsReport.idl:

LayoutTests:

* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Move non-trivial virtual functions out of ResourceHandleClient.h
ap@apple.com [Thu, 21 Mar 2013 20:27:08 +0000 (20:27 +0000)]
    Move non-trivial virtual functions out of ResourceHandleClient.h
        https://bugs.webkit.org/show_bug.cgi?id=112950

        Reviewed by Brady Eidson.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/ResourceHandleClient.cpp: Added.
        (WebCore::ResourceHandleClient::ResourceHandleClient):
        (WebCore::ResourceHandleClient::~ResourceHandleClient):
        (WebCore::ResourceHandleClient::didReceiveBuffer):
        (WebCore::ResourceHandleClient::getBuffer):
        * platform/network/ResourceHandleClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Correct assert in Empty BitmapImage Test.
bfulgham@webkit.org [Thu, 21 Mar 2013 20:19:26 +0000 (20:19 +0000)]
[WinCairo] Correct assert in Empty BitmapImage Test.
https://bugs.webkit.org/show_bug.cgi?id=112934

Reviewed by Tim Horton.

* TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
(TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
to avoid ref counting assertion when leaving test scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows rebaseline after r146469.
rniwa@webkit.org [Thu, 21 Mar 2013 20:11:06 +0000 (20:11 +0000)]
Windows rebaseline after r146469.

* platform/win/css3/filters/effect-reference-expected.txt:
* platform/win/css3/filters/effect-reference-hw-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix lexer charPosition computation when "rewind"ing the lexer.
mark.lam@apple.com [Thu, 21 Mar 2013 20:06:26 +0000 (20:06 +0000)]
Fix lexer charPosition computation when "rewind"ing the lexer.
https://bugs.webkit.org/show_bug.cgi?id=112952.

Reviewed by Michael Saboff.

Changed the Lexer to no longer keep a m_charPosition. Instead, we compute
currentCharPosition() from m_code and m_codeStartPlusOffset, where
m_codeStartPlusOffset is the SourceProvider m_codeStart + the SourceCode
start offset. This ensures that the charPosition is always in sync with
m_code.

* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
* parser/Lexer.h:
(JSC::Lexer::currentCharPosition):
(JSC::::lexExpectIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] generate-feature-defines-files is incompatible with Python3
zandobersek@gmail.com [Thu, 21 Mar 2013 20:05:49 +0000 (20:05 +0000)]
[GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956

Reviewed by Martin Robinson.

Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.

* gtk/generate-feature-defines-files:
(write_feature_defines_header):
(write_flattened_feature_defines_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[SVG] Remove explicit LightSource dispatchers
fmalita@chromium.org [Thu, 21 Mar 2013 20:02:40 +0000 (20:02 +0000)]
[SVG] Remove explicit LightSource dispatchers
https://bugs.webkit.org/show_bug.cgi?id=112827

Reviewed by Stephen Chenney.

Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp
altogether.

No new tests: refactoring only.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/DistantLightSource.h:
(DistantLightSource):
* platform/graphics/filters/LightSource.cpp: Removed.
* platform/graphics/filters/LightSource.h:
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):
* platform/graphics/filters/PointLightSource.h:
(PointLightSource):
* platform/graphics/filters/SpotLightSource.h:
(SpotLightSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
commit-queue@webkit.org [Thu, 21 Mar 2013 19:55:26 +0000 (19:55 +0000)]
[BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
https://bugs.webkit.org/show_bug.cgi?id=112448

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.

This changed in r121381.

* runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::doWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Implement support for OpenGLES EXT_unpack_subimage extension
igor.o@sisa.samsung.com [Thu, 21 Mar 2013 19:51:59 +0000 (19:51 +0000)]
[Texmap] Implement support for OpenGLES EXT_unpack_subimage extension
https://bugs.webkit.org/show_bug.cgi?id=108716

If the extension GL_EXT_unpack_subimage is supported, it adds GL_UNPACK_ROW_LENGTH,
GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS as valid enums to PixelStore.

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Regression: drawer resizes slowly with animation.
commit-queue@webkit.org [Thu, 21 Mar 2013 19:42:34 +0000 (19:42 +0000)]
Web Inspector: Regression: drawer resizes slowly with animation.
https://bugs.webkit.org/show_bug.cgi?id=112920

Drawer status bar opacity wasn't set to zero on inialization, so no transition event
was fired on first time drawer appeared,thus animation styles wasn't removed properly.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-21
Reviewed by Vsevolod Vlasov.

* inspector/front-end/Drawer.js:
(WebInspector.Drawer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] GraphicsLayer: fix code that was accidentally reverted
commit-queue@webkit.org [Thu, 21 Mar 2013 19:36:10 +0000 (19:36 +0000)]
[BlackBerry] GraphicsLayer: fix code that was accidentally reverted
https://bugs.webkit.org/show_bug.cgi?id=112143

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.

Several changes were accidentally reverted in r144465 due to the
upstreaming of some new code:

- clearBackgroundColor() and m_contentsLayerHasBackgroundColor had
  been removed in r137798.

- showDebugBorders() had been renamed to isShowingDebugBorder() in
  r133517.

- A new GraphicsLayer::create() overload had been introduced in
  r130185.

This patch fixes them all.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayer::create):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Move libLevelDB.la setup into a separate GNUmakefile.am
zandobersek@gmail.com [Thu, 21 Mar 2013 19:25:41 +0000 (19:25 +0000)]
[GTK] Move libLevelDB.la setup into a separate GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=112947

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Include the new GNUmakefile.am, located under Source/ThirdParty/leveldb.

Source/ThirdParty:

* leveldb/GNUmakefile.am: Added, sets up the libLevelDB.la library.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.am: Move the libLevelDD.la setup into the new GNUmakefile.am that's placed in
the third-party leveldb source directory.
* GNUmakefile.list.am: Move the LevelDB sources listing there as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] DrawingBuffer: add clearPlatformLayer() implementation
commit-queue@webkit.org [Thu, 21 Mar 2013 19:22:59 +0000 (19:22 +0000)]
[BlackBerry] DrawingBuffer: add clearPlatformLayer() implementation
https://bugs.webkit.org/show_bug.cgi?id=112696

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.

DrawingBuffer::clearPlatformLayer() was added in r139142.

This is not needed in the BlackBerry port, so this patch only
contains a dummy implementation.

* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agokill-old-processes spits out error messages on Mac
rniwa@webkit.org [Thu, 21 Mar 2013 19:19:23 +0000 (19:19 +0000)]
kill-old-processes spits out error messages on Mac
https://bugs.webkit.org/show_bug.cgi?id=112878

Reviewed by Jessie Berlin.

Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
included in the list of options grep --help shows.

Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.

* BuildSlaveSupport/kill-old-processes:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[SVG] Suppress painting when an empty viewBox is specified
fmalita@chromium.org [Thu, 21 Mar 2013 19:14:00 +0000 (19:14 +0000)]
[SVG] Suppress painting when an empty viewBox is specified
https://bugs.webkit.org/show_bug.cgi?id=112623

Reviewed by Philip Rogers.

Source/WebCore:

Per spec, elements with an empty viewBox should not be rendered:
http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute.

This patch adds the missing viewBox checks to RenderSVGRoot, RenderSVGViewPortContainer,
RenderSVGResourceMarker and RenderSVGResourceMarker's paint methods.

In order to detect the case of "viewBox present but invalid", the patch also introduces
SVGAnimatedProperty plumbing for tracking property validity: the baseVal setter now takes
an additional optional 'validValue' boolean parameter, which can later be queried via a
macroed getter (LowerProperty##IsValid()).

Test: svg/custom/viewBox-empty.html

* rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::draw):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::paint):
(WebCore):
* rendering/svg/RenderSVGViewportContainer.h:
(RenderSVGViewportContainer):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
* svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::hasEmptyViewBox):
(SVGSVGElement):
Suppress painting if a valid empty viewBox is found.

* svg/SVGFitToViewBox.h:
(WebCore::SVGFitToViewBox::parseAttribute):
Mark the viewBox property as invalid if not successfully parsed.

* svg/SVGExternalResourcesRequired.h:
(SVGExternalResourcesRequired):
* svg/SVGURIReference.h:
(SVGURIReference):
* svg/properties/SVGAnimatedPropertyMacros.h:
(WebCore::SVGSynchronizableAnimatedProperty::SVGSynchronizableAnimatedProperty):
(SVGSynchronizableAnimatedProperty):
(WebCore):
Plumbing for tracking property value validation.

LayoutTests:

* svg/custom/script-tests/svg-viewBox-dynamic.js:
* svg/custom/svg-viewBox-dynamic-expected.txt:
* svg/custom/viewBox-empty-expected.html: Added.
* svg/custom/viewBox-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoObjective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects...
mhahnenberg@apple.com [Thu, 21 Mar 2013 19:06:05 +0000 (19:06 +0000)]
Objective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects to leak
https://bugs.webkit.org/show_bug.cgi?id=112856

Reviewed by Geoffrey Garen.

Through a very convoluted path that involves the caching of prototypes on the JSClassRef, we can leak
JSGlobalObjects when inserting an Objective-C object into multiple independent JSContexts.

* API/JSAPIWrapperObject.cpp: Removed.
* API/JSAPIWrapperObject.h:
(JSAPIWrapperObject):
* API/JSAPIWrapperObject.mm: Copied from Source/JavaScriptCore/API/JSAPIWrapperObject.cpp. Made this an
Objective-C++ file so that we can call release on the wrappedObject. Also added a WeakHandleOwner for
JSAPIWrapperObjects. This will also be used in a future patch for https://bugs.webkit.org/show_bug.cgi?id=112608.
(JSAPIWrapperObjectHandleOwner):
(jsAPIWrapperObjectHandleOwner):
(JSAPIWrapperObjectHandleOwner::finalize): This finalize replaces the old finalize that was done through
the C API.
(JSC::JSAPIWrapperObject::finishCreation): Allocate the WeakImpl. Balanced in finalize.
(JSC::JSAPIWrapperObject::setWrappedObject): We now do the retain of the wrappedObject here rather than in random
places scattered around JSWrapperMap.mm
* API/JSObjectRef.cpp: Added some ifdefs for platforms that don't support the Obj-C API.
(JSObjectGetPrivate): Ditto.
(JSObjectSetPrivate): Ditto.
(JSObjectGetPrivateProperty): Ditto.
(JSObjectSetPrivateProperty): Ditto.
(JSObjectDeletePrivateProperty): Ditto.
* API/JSValueRef.cpp: Ditto.
(JSValueIsObjectOfClass): Ditto.
* API/JSWrapperMap.mm: Remove wrapperClass().
(objectWithCustomBrand): Change to no longer use a parent class, which was only used to give the ability to
finalize wrapper objects.
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]): Change to no longer use wrapperClass().
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): Ditto.
(tryUnwrapObjcObject): We now check if the object inherits from JSAPIWrapperObject.
* API/tests/testapi.mm: Added a test that exports an Objective-C object to two different JSContexts and makes
sure that the first one is collected properly by using a weak JSManagedValue for the wrapper in the first JSContext.
* CMakeLists.txt: Build file modifications.
* GNUmakefile.list.am: Ditto.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* runtime/JSGlobalObject.cpp: More ifdefs for unsupported platforms.
(JSC::JSGlobalObject::reset): Ditto.
(JSC::JSGlobalObject::visitChildren): Ditto.
* runtime/JSGlobalObject.h: Ditto.
(JSGlobalObject): Ditto.
(JSC::JSGlobalObject::objcCallbackFunctionStructure): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Hide toolbar customization experimental setting
commit-queue@webkit.org [Thu, 21 Mar 2013 18:54:35 +0000 (18:54 +0000)]
Web Inspector: Hide toolbar customization experimental setting
https://bugs.webkit.org/show_bug.cgi?id=112942

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isToolbarCustomizable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 21 Mar 2013 18:52:53 +0000 (18:52 +0000)]
[Chromium] Unreviewed gardening.

New test results for effect-reference and effect-reference-hw.

* platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Removed.
* platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Removed.
* platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
* platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Removed.
* platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Removed.
* platform/chromium-mac/css3/filters/effect-reference-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-expected.txt:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
* platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Removed.
* platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Removed.
* platform/chromium-win/css3/filters/effect-reference-expected.png:
* platform/chromium-win/css3/filters/effect-reference-expected.txt:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
commit-queue@webkit.org [Thu, 21 Mar 2013 18:52:46 +0000 (18:52 +0000)]
[BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
https://bugs.webkit.org/show_bug.cgi?id=112597

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.

These were introduced for the Chromium port in r105295. We need
dummy implementations in order to compile the BlackBerry port.

* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK+ gardening.
csaavedra@igalia.com [Thu, 21 Mar 2013 18:45:46 +0000 (18:45 +0000)]
Unreviewed GTK+ gardening.

* platform/gtk/TestExpectations: Remove redundant entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r146483.
antonm@chromium.org [Thu, 21 Mar 2013 18:26:41 +0000 (18:26 +0000)]
Unreviewed, rolling out r146483.
http://trac.webkit.org/changeset/146483
https://bugs.webkit.org/show_bug.cgi?id=111695

Source/JavaScriptCore:

Breaks debug builds.

* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Source/Platform:

Breaks

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
* chromium/public/WebSpeechSynthesisUtterance.h: Removed.
* chromium/public/WebSpeechSynthesisVoice.h: Removed.
* chromium/public/WebSpeechSynthesizer.h: Removed.
* chromium/public/WebSpeechSynthesizerClient.h: Removed.

Source/WebCore:

Breaks

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
* Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
(SpeechSynthesisUtterance):
* Modules/speech/SpeechSynthesisVoice.h:
(SpeechSynthesisVoice):
* WebCore.exp.in:
* WebCore.gypi:
* platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
* platform/PlatformSpeechSynthesisUtterance.cpp:
* platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::client):
* platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
* platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):
* platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):
* platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::speak):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create):
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
* platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [Mac] Consolidate bits of willSendRequest implementation
ap@apple.com [Thu, 21 Mar 2013 18:19:33 +0000 (18:19 +0000)]
    [Mac] Consolidate bits of willSendRequest implementation
        https://bugs.webkit.org/show_bug.cgi?id=112932

        Reviewed by Brady Eidson.

        Moved some logic from WebCoreResourceHandleAsDelegate to ResourceHandle for clarity.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willSendRequest):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add isOrphan() to the WebLayer API
danakj@chromium.org [Thu, 21 Mar 2013 18:08:10 +0000 (18:08 +0000)]
[chromium] Add isOrphan() to the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=112649

Reviewed by James Robinson.

This method will be used by WebMediaPlayerClientImpl to tell
if the compositing video layer is currently being used to
display the video content or not.

* chromium/public/WebLayer.h:
(WebLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove AudioGain.idl from compilation.
commit-queue@webkit.org [Thu, 21 Mar 2013 18:08:05 +0000 (18:08 +0000)]
Remove AudioGain.idl from compilation.
https://bugs.webkit.org/show_bug.cgi?id=112650

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-21
Reviewed by Chris Rogers.

Source/WebCore:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#GainNode
      https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBufferSourceNode

AudioParam serves the same purpose as AudioGain. Infact, AudioGain inherits
AudioParam class and doesn't have its own member functions/parameters. Also,
AudioGain is not part of WebAudio W3C specifications.

Test: webaudio/gain-basic.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
* Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::gain):
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioGain.h: Removed.
* Modules/webaudio/AudioGain.idl: Removed.
* Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
* Modules/webaudio/GainNode.h:
(WebCore):
(WebCore::GainNode::create):
(GainNode):
(WebCore::GainNode::gain):
* Modules/webaudio/GainNode.idl:
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
* Modules/webaudio/PannerNode.h:
(WebCore::PannerNode::distanceGain):
(WebCore::PannerNode::coneGain):
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Test to verify GainNode attributes.

* webaudio/gain-basic-expected.txt: Added.
* webaudio/gain-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-enable WinEWS tests following r146376.
roger_fong@apple.com [Thu, 21 Mar 2013 17:56:31 +0000 (17:56 +0000)]
Re-enable WinEWS tests following r146376.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium gardening.
antonm@chromium.org [Thu, 21 Mar 2013 17:31:39 +0000 (17:31 +0000)]
Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Web Speech Synthesis for Chromium
dmazzoni@google.com [Thu, 21 Mar 2013 17:24:57 +0000 (17:24 +0000)]
Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):
* chromium/public/WebSpeechSynthesisUtterance.h: Added.
(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):
* chromium/public/WebSpeechSynthesisVoice.h: Added.
(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):
* chromium/public/WebSpeechSynthesizer.h: Added.
(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):
* chromium/public/WebSpeechSynthesizerClient.h: Added.
(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
* Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
* Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):
* WebCore.exp.in:
* WebCore.gypi:
* platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
* platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):
* platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):
* platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
* platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):
* platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):
* platform/PlatformSpeechSynthesizer.h:
(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
* platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):
* platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):
* platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):
* platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.
(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):
* platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.
(WebCore):
(WebSpeechSynthesizerClientImpl):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
* platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
jchaffraix@webkit.org [Thu, 21 Mar 2013 17:14:55 +0000 (17:14 +0000)]
[CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
https://bugs.webkit.org/show_bug.cgi?id=112389

Reviewed by Tony Chang.

Source/WebCore:

This change updates our core minmax resolution function to be spanning grid
items aware. The new implementation of the algorithm doesn't totally match
the specification but it is fairly close that it's a good first pass. The
extra complexity in the specification needs to be carefully examinated
first (not to mention the probable change in the core layout algorithm).

Tests: fast/css-grid-layout/minmax-spanning-resolution-columns.html
       fast/css-grid-layout/minmax-spanning-resolution-rows.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated this function to account for spanning grid items by:
- iterating over all spanned grid tracks.
- removing any used breadth from all spanned grid tracks.

LayoutTests:

* fast/css-grid-layout/grid-item-spanning-resolution.html:
* fast/css-grid-layout/resources/grid.css:
(.firstRowBothColumn):
(.secondRowBothColumn):
(.bothRowFirstColumn):
(.bothRowSecondColumn):
(.bothRowBothColumn):
Moved the previous classes for maximum reuse.

* fast/css-grid-layout/minmax-spanning-resolution-columns-expected.txt: Added.
* fast/css-grid-layout/minmax-spanning-resolution-columns.html: Added.
* fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt: Added.
* fast/css-grid-layout/minmax-spanning-resolution-rows.html: Added.
New tests.

* fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
* fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
Unintended consistent progression from this change, it's unclear why these baselines
change as the tests involve no spanning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium gardening.
antonm@chromium.org [Thu, 21 Mar 2013 16:55:39 +0000 (16:55 +0000)]
Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add Bem Jones-Bey to the list of contributors.
zoltan@webkit.org [Thu, 21 Mar 2013 16:51:29 +0000 (16:51 +0000)]
Unreviewed. Add Bem Jones-Bey to the list of contributors.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] New reference returned by g_main_context_new() must be freed
commit-queue@webkit.org [Thu, 21 Mar 2013 16:45:37 +0000 (16:45 +0000)]
[GStreamer] New reference returned by g_main_context_new() must be freed
https://bugs.webkit.org/show_bug.cgi?id=112899

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak by adopting the new reference returned
by g_main_context_new().

No new tests. No change in behavior.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
commit-queue@webkit.org [Thu, 21 Mar 2013 16:32:16 +0000 (16:32 +0000)]
[BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
https://bugs.webkit.org/show_bug.cgi?id=112915

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-03-21
Reviewed by Rob Buis.

* PlatformBlackBerry.cmake: Add page/scrolling/blackberry to the
indlude dir list.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create): Create a
ScrollingCoordinatorBlackBerry for the BlackBerry platform.
* page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerFixedToContainerLayerEdge):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewFrameRectDidChange):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewContentsSizeDidChange):
* page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h: Added.
(WebCore):
(ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::supportsFixedPositionLayers):
* platform/graphics/PlatformLayer.h:
(WebCore): Add PlatformLayer definition for BlackBerry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium gardening.
antonm@chromium.org [Thu, 21 Mar 2013 16:28:15 +0000 (16:28 +0000)]
Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Paint rectangles shown on hover over Timeline's paint records occasion...
caseq@chromium.org [Thu, 21 Mar 2013 15:57:31 +0000 (15:57 +0000)]
Web Inspector: Paint rectangles shown on hover over Timeline's paint records occasionally have wrong offsets
https://bugs.webkit.org/show_bug.cgi?id=112371

Reviewed by Pavel Feldman.

Source/WebCore:

- pass frame to InspectorTimelineAgent::didPaint();
- convert paint coordinates to root view.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didPaint):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):

LayoutTests:

* http/tests/inspector/timeline-test.js:
(initialize_Timeline.InspectorTest.startTimeline.InspectorTest._addTimelineEvent):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addEvent):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):
* inspector/timeline/timeline-paint-expected.txt:
* inspector/timeline/timeline-paint.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: do not use inspector cookie in InspectorInstrumentation::{will,did...
caseq@chromium.org [Thu, 21 Mar 2013 15:49:26 +0000 (15:49 +0000)]
Web Inspector: do not use inspector cookie in InspectorInstrumentation::{will,did}Paint
https://bugs.webkit.org/show_bug.cgi?id=112787

Reviewed by Pavel Feldman.

- pass frame, not inspector cookie to InspectorInstrumentation::didPaint;
- use frame to determine timeline agent in InspectorInstrumentation::didPaint.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
kov@webkit.org [Thu, 21 Mar 2013 15:36:43 +0000 (15:36 +0000)]
[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

* mr.po: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Missing atk in install-dependencies script
csaavedra@igalia.com [Thu, 21 Mar 2013 15:28:16 +0000 (15:28 +0000)]
[GTK] Missing atk in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112272

Reviewed by Gustavo Noronha Silva.

* gtk/install-dependencies: Add missing atk dependency.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 21 Mar 2013 15:16:56 +0000 (15:16 +0000)]
Unreviewed GTK gardening.

Marking http/tests/appcache/abort-cache-ondownloading-resource-404.html as flaky.
Unskipping tests under perf/ to see how they behave.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Grid Layout] OOB access in RenderGrid with a grid item with negative position...
jchaffraix@webkit.org [Thu, 21 Mar 2013 15:09:49 +0000 (15:09 +0000)]
[CSS Grid Layout] OOB access in RenderGrid with a grid item with negative position index
https://bugs.webkit.org/show_bug.cgi?id=112853

Reviewed by Tony Chang.

Source/WebCore:

This issue was caused by us casting a negative int to a size_t by mistake. This
would make us not size the grid properly thus yielding to OOB access during the
rest of the layout.

Test: fast/css-grid-layout/grid-item-negative-indexes.html

* rendering/RenderGrid.cpp:
(WebCore::estimatedGridSizeForPosition):
Added this helper function to do the proper estimation and checks that our
position can be represented by a size_t.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to use estimatedGridSizeForPosition.

LayoutTests:

* fast/css-grid-layout/grid-item-negative-indexes-expected.txt: Added.
* fast/css-grid-layout/grid-item-negative-indexes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] feConvolveMatrix should use accelerated path
senorblanco@chromium.org [Thu, 21 Mar 2013 14:58:19 +0000 (14:58 +0000)]
[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Reviewed by James Robinson.

Source/WebCore:

Covered by layout tests css3/filters/effect-reference*.html.

* WebCore.gypi:
Add FEConvolveMatrixSkia.cpp to the build.
* platform/graphics/filters/FEConvolveMatrix.h:
Enable the skia accelerated path for feConvolveMatrix.
* platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:
(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.

LayoutTests:

* css3/filters/effect-reference-hw.html:
* css3/filters/effect-reference.html:
Add new test case for feConvolveMatrix as a reference filter.
* platform/chromium/TestExpectations:
Suppress failures until the test can be rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/ThirdParty/leveldb/db/builder.cc does not build on systems without <endian.h>
commit-queue@webkit.org [Thu, 21 Mar 2013 14:56:12 +0000 (14:56 +0000)]
Source/ThirdParty/leveldb/db/builder.cc does not build on systems without <endian.h>
https://bugs.webkit.org/show_bug.cgi?id=111817

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva.

.:

Improve processing of the autoconf host variable.  Setup up the wiring to detect
whether or not we are compiling for Darwin.

* Source/autotools/CheckSystemAndBasicDependencies.m4: Improve host detection.
* Source/autotools/SetupAutomake.m4: Tell automake if we are compiling for Darwin or not.

Source/WebCore:

* GNUmakefile.am: Add the appropriate flags to the LevelDB build if we are on FreeBSD
or OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Grid Layout] Support default grid items sizing
jchaffraix@webkit.org [Thu, 21 Mar 2013 14:53:10 +0000 (14:53 +0000)]
[CSS Grid Layout] Support default grid items sizing
https://bugs.webkit.org/show_bug.cgi?id=103333

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html
       fast/css-grid-layout/grid-auto-columns-rows-resolution.html
       fast/css-grid-layout/grid-auto-columns-rows-update.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):
Core of the change: return the grid-auto-{rows|columns} instead of a pre-defined value.

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Fixed a latent bug: we need to iterate over the internal grid representation instead of the
style's rows / columns as the latter doesn't account for implicit rows / columns.

LayoutTests:

* fast/css-grid-layout/grid-auto-columns-rows-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-auto-columns-rows-resolution.html: Added.
This test covers the simple implicit column / row case.

* fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt: Added.
* fast/css-grid-layout/grid-auto-columns-rows-update.html: Added.
This test covers that modifying grid-auto-{rows|columns} updates the grid items' sizes.

* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html: Added.
This test covers the implicit rows / columns generated by the auto placement. We are failing
2 sub-tests due to a bug involving percentage grid items in grid rows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip some failing tests.
kadam@inf.u-szeged.hu [Thu, 21 Mar 2013 14:46:49 +0000 (14:46 +0000)]
[Qt] Unreviewed gardening. Skip some failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Missing backslash in install-dependencies script
csaavedra@igalia.com [Thu, 21 Mar 2013 14:43:32 +0000 (14:43 +0000)]
[GTK] Missing backslash in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112907

Reviewed by Philippe Normand.

* gtk/install-dependencies: Add missing backslash to dependencies
list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLNames should construct strings at compile time
abarth@webkit.org [Thu, 21 Mar 2013 14:30:38 +0000 (14:30 +0000)]
HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831

Reviewed by Darin Adler.

Source/WebCore:

This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
    - Teach the Chromium build how to deal with Perl modules.
* bindings/scripts/StaticString.pm: Added.
    - A Perl module for constructing static strings.
(GenerateStrings):
(GenerateValidateStrings):
* dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
    - createQualifiedName now takes an already-constructed StringImpl
      object.
* dom/QualifiedName.h:
* dom/make_names.pl:
(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):
    - Teach make_names how to use StaticString.pm.

Source/WTF:

* wtf/text/StringImpl.h:
(StringImpl):
(StaticASCIILiteral):
    - This struct lets us construct StringImpl objects at compile time.
(WTF::StringImpl::assertHashIsCorrect):
    - This function lets us sanity check StringImpl objects created from StaticData.
(WTF::StringImpl::find): Remove a stray ;
(WTF::StringImpl::findIgnoringCase): ditto
(WTF::StringImpl::startsWith): ditto
(WTF::ValueCheck<StringImpl*>):
* wtf/text/AtomicStringImpl.h:
(WTF::ValueCheck<AtomicStringImpl*>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[l10n] Updated Polish translation of WebKitGTK+
kov@webkit.org [Thu, 21 Mar 2013 14:09:55 +0000 (14:09 +0000)]
[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

* pl.po: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[as-IN] Translations of WebKitGtk+
kov@webkit.org [Thu, 21 Mar 2013 13:49:03 +0000 (13:49 +0000)]
[as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

* as.po: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rebaseline most "needs rebaseline" sections of EFL test expectations, and updat...
commit-queue@webkit.org [Thu, 21 Mar 2013 13:43:45 +0000 (13:43 +0000)]
[EFL] Rebaseline most "needs rebaseline" sections of EFL test expectations, and update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=112901

https://bugs.webkit.org/show_bug.cgi?id=105437
https://bugs.webkit.org/show_bug.cgi?id=65643
https://bugs.webkit.org/show_bug.cgi?id=14664
https://bugs.webkit.org/show_bug.cgi?id=110654

Unreviewed, rebaselining.
Adding failure expectation for the test added in r133834.

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-21

* platform/efl/TestExpectations:
* platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/efl/fast/block/float/024-expected.txt:
* platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
* platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Added.
* platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/efl/svg/css/arrow-with-shadow-expected.txt:
* platform/efl/svg/css/clippath-with-shadow-expected.txt:
* platform/efl/svg/css/composite-shadow-example-expected.png: Added.
* platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
* platform/efl/svg/css/composite-shadow-with-opacity-expected.png: Added.
* platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
* platform/efl/svg/custom/feDisplacementMap-01-expected.png: Added.
* platform/efl/svg/custom/feDisplacementMap-01-expected.txt: Added.
* platform/efl/svg/custom/foreign-object-skew-expected.png: Added.
* platform/efl/svg/custom/foreign-object-skew-expected.txt:
* platform/efl/svg/custom/simple-text-double-shadow-expected.png: Added.
* platform/efl/svg/custom/simple-text-double-shadow-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement LLInt for CPU(ARM_TRADITIONAL)
rgabor@webkit.org [Thu, 21 Mar 2013 13:19:40 +0000 (13:19 +0000)]
Implement LLInt for CPU(ARM_TRADITIONAL)
https://bugs.webkit.org/show_bug.cgi?id=97589

Reviewed by Zoltan Herczeg.

Enable LLInt for ARMv5 and ARMv7 traditional as well.

Source/JavaScriptCore:

* llint/LLIntOfflineAsmConfig.h:
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* offlineasm/arm.rb:
* offlineasm/backends.rb:
* offlineasm/instructions.rb:

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WebGL] Implement a common GraphicsSurface Implementation.
commit-queue@webkit.org [Thu, 21 Mar 2013 13:14:32 +0000 (13:14 +0000)]
[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

* PlatformEfl.cmake:
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

* platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createTransportSurface):
* platform/graphics/opengl/GLPlatformSurface.h:
* platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):
* platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.
(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

* platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.
(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

* platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
* platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):
* platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r146454.
commit-queue@webkit.org [Thu, 21 Mar 2013 12:58:22 +0000 (12:58 +0000)]
Unreviewed, rolling out r146454.
http://trac.webkit.org/changeset/146454
https://bugs.webkit.org/show_bug.cgi?id=112906

compile failures (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-21

Source/WebCore:

* WebCore.gypi:
* platform/graphics/filters/FEConvolveMatrix.h:
(FEConvolveMatrix):
* platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp: Removed.

LayoutTests:

* css3/filters/effect-reference-hw.html:
* css3/filters/effect-reference.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove obsolete conditionals around calling SkTypeface::getUnitsPerEm()
reed@google.com [Thu, 21 Mar 2013 12:49:44 +0000 (12:49 +0000)]
Remove obsolete conditionals around calling SkTypeface::getUnitsPerEm()
https://bugs.webkit.org/show_bug.cgi?id=112846

Reviewed by Stephen White.

Existing complex-text layouttests exercise this code.

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2013-03-21 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Thu, 21 Mar 2013 12:28:55 +0000 (12:28 +0000)]
2013-03-21  Anton Muhin  <antonm@chromium.org>

        Unreviewed Chromium gardening.

        Mass rebaselining.

        * fast/repaint/moving-shadow-on-container-expected.txt: Removed.
        * platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Added.
        * platform/chromium-linux-x86/platform/chromium/fast: Added.
        * platform/chromium-linux-x86/platform/chromium/fast/forms: Added.
        * platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Added.
        * platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
        * platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt:
        * platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt:
        * platform/chromium-linux-x86/svg/css/shadow-changes-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-linux-x86/svg/repaint: Added.
        * platform/chromium-linux-x86/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
        * platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
        * platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
        * platform/chromium-linux/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-linux/svg/css/shadow-changes-expected.png:
        * platform/chromium-linux/svg/css/shadow-changes-expected.txt: Added.
        * platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-linux/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png: Added.
        * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
        * platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.png:
        * platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-mac-lion/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-mac-lion/svg/css/shadow-changes-expected.png:
        * platform/chromium-mac-lion/svg/css/shadow-changes-expected.txt: Added.
        * platform/chromium-mac-lion/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-mac-lion/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
        * platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
        * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
        * platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.png:
        * platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-mac-snowleopard/svg/css/shadow-changes-expected.txt: Added.
        * platform/chromium-mac-snowleopard/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-mac-snowleopard/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
        * platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
        * platform/chromium-mac/svg/css/arrow-with-shadow-expected.png:
        * platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
        * platform/chromium-mac/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-mac/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-mac/svg/css/shadow-changes-expected.png:
        * platform/chromium-mac/svg/css/shadow-changes-expected.txt:
        * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Added.
        * platform/chromium-win-xp/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-win-xp/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-win-xp/svg/css/shadow-changes-expected.png:
        * platform/chromium-win-xp/svg/css/shadow-changes-expected.txt: Added.
        * platform/chromium-win-xp/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-win-xp/svg/repaint: Added.
        * platform/chromium-win-xp/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
        * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
        * platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-example-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-win/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-win/svg/css/shadow-changes-expected.png:
        * platform/chromium-win/svg/css/shadow-changes-expected.txt:
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt:
        * platform/chromium-win/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
        * platform/chromium/TestExpectations:
        * platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Added.
        * platform/chromium/svg/css/arrow-with-shadow-expected.txt: Removed.
        * platform/chromium/svg/css/clippath-with-shadow-expected.txt: Removed.
        * platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
        * platform/gtk/svg/css/arrow-with-shadow-expected.txt: Removed.
        * platform/gtk/svg/css/clippath-with-shadow-expected.txt: Removed.
        * platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
        * platform/mac/svg/css/arrow-with-shadow-expected.txt: Removed.
        * platform/mac/svg/css/clippath-with-shadow-expected.txt: Removed.
        * platform/mac/svg/css/composite-shadow-text-expected.png: Removed.
        * platform/qt/svg/css/arrow-with-shadow-expected.txt: Removed.
        * platform/qt/svg/css/clippath-with-shadow-expected.txt: Removed.
        * platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
        * svg/css/arrow-with-shadow-expected.txt: Added.
        * svg/css/clippath-with-shadow-expected.txt: Added.
        * svg/css/composite-shadow-text-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] feConvolveMatrix should use accelerated path
senorblanco@chromium.org [Thu, 21 Mar 2013 12:16:35 +0000 (12:16 +0000)]
[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Reviewed by James Robinson.

Source/WebCore:

Covered by layout tests css3/filters/effect-reference*.html.

* WebCore.gypi:
Add FEConvolveMatrixSkia.cpp to the build.
* platform/graphics/filters/FEConvolveMatrix.h:
Enable the skia accelerated path for feConvolveMatrix.
* platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:
(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.

LayoutTests:

* css3/filters/effect-reference-hw.html:
* css3/filters/effect-reference.html:
Add new test case for feConvolveMatrix as a reference filter.
* platform/chromium/TestExpectations:
Suppress failures until the test can be rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Reorganize datetime field element parameters
commit-queue@webkit.org [Thu, 21 Mar 2013 11:54:50 +0000 (11:54 +0000)]
Refactoring: Reorganize datetime field element parameters
https://bugs.webkit.org/show_bug.cgi?id=112877

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-21
Reviewed by Kent Tamura.

Before this patch, the field element constructors took minimum/maximum
as a pair of integers, and step/stepbase as a DateTimeNumericFieldElement::Parameters.
This patch makes these constructors to take a Range (for minimum/maximum)
and a Step (for step/stepbase).

No new tests. Just refactoring.

* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Replaced min/max data members by Ranges.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::createStep):
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeWeekFieldElement::create):
* html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement):
(DateTimeMinuteFieldElement):
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement):
(DateTimeWeekFieldElement):
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::roundDown):
(WebCore::DateTimeNumericFieldElement::roundUp):
* html/shadow/DateTimeNumericFieldElement.h:
(WebCore::DateTimeNumericFieldElement::Step::Step): Renamed from Parameters.
(WebCore::DateTimeNumericFieldElement::Range::Range):
(WebCore::DateTimeNumericFieldElement::Range::isSingleton): Returns true if the range is a singleton range (i.e. contains exactly one value).
(Range): Now it's parameter type, hence public.
(DateTimeNumericFieldElement): Replaced two int members (m_step and m_stepBase) by a Range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Track CSS error location information.
commit-queue@webkit.org [Thu, 21 Mar 2013 11:41:39 +0000 (11:41 +0000)]
Web Inspector: Track CSS error location information.
https://bugs.webkit.org/show_bug.cgi?id=111314

Source/WebCore:

Added CSS syntax error reporting to some (other rules will be covered later) error recovery grammar rules.
Added code to CSSParser to allow track error location information.
Added empty rule to declaration_list. Needed to not report error about declarations like "body {}".
Added helper grammar rule "errors: error | errors error". Handles the same grammar as "error" but simplifies error location tracking.

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

Test: inspector/console/console-css-warnings.html

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::currentLocation):
(WebCore):
(WebCore::CSSParser::realLex):
* css/CSSParser.h:
(CSSParser):

LayoutTests:

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

* inspector/console/console-css-warnings-expected.txt: Added.
* inspector/console/console-css-warnings.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanging "#define YYDEBUG 0" to 1 causing compilation error
commit-queue@webkit.org [Thu, 21 Mar 2013 11:17:30 +0000 (11:17 +0000)]
Changing "#define YYDEBUG 0" to 1 causing compilation error
https://bugs.webkit.org/show_bug.cgi?id=111178

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

Code that reference tokens can't be placed into CSSGrammar.yy.include because it's included before tokens defined.
YYDEBUG can't be used in CSSGrammar.yy.in because the #define is only defined in CSSGrammar.yy.include. This
change simplifies CSS debugging letting manipulate only #define YYDEBUG in CSSGrammar.yy.include and/or in CSSParser.cpp.

* css/CSSGrammar.y.in:
* css/CSSGrammar.y.includes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Thu, 21 Mar 2013 10:40:25 +0000 (10:40 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skip failing tests after r146361 and r146399.
* platform/qt/fast/repaint/caret-with-transformation-expected.png: Added after r139282.
* platform/qt/fast/repaint/caret-with-transformation-expected.txt: Added after r139282.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge MainResourceLoader into DocumentLoader
rniwa@webkit.org [Thu, 21 Mar 2013 09:05:45 +0000 (09:05 +0000)]
Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969

Patch by Nate Chapin <japhet@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

No new tests, refactor only.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from
    ~MainResourceLoader.
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
(WebCore):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::dataReceived):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks
     for normal and empty loads, just use a single boolean.
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoadingMainResource):
* loader/MainResourceLoader.cpp: Removed.
* loader/MainResourceLoader.h: Removed.
* loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Flame Chart. draw background for the FlameChart overview pane with...
loislo@chromium.org [Thu, 21 Mar 2013 08:02:10 +0000 (08:02 +0000)]
Web Inspector: Flame Chart. draw background for the FlameChart overview pane with the CPU aggregated data.
https://bugs.webkit.org/show_bug.cgi?id=112823

Reviewed by Yury Semikhatsky.

The idea of the patch is to collect the data about stack depth for the each X
and draw a line with help of this data.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTiled page overlay layers don't create tiles until the first flush after they switch...
timothy_horton@apple.com [Thu, 21 Mar 2013 07:52:58 +0000 (07:52 +0000)]
Tiled page overlay layers don't create tiles until the first flush after they switch to being tiled
https://bugs.webkit.org/show_bug.cgi?id=112860
<rdar://problem/13468400>

Reviewed by Simon Fraser.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add storage for m_clipsToExposedRect.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
The page overlay layer will never have children, so we can use flushCompositingState instead of the ForThisLayerOnly variant.
Pass the visible rect of the page overlay layer (computed by intersecting its bounds with the exposed
rect that comes from the WKView) to flushCompositingState; don't bother setting the visible rect manually.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
Store m_clipsToExposedRect so we can use it in flushLayers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 21 Mar 2013 07:49:43 +0000 (07:49 +0000)]
Unreviewed GTK gardening.
Adding failure expectation for the test added in r146427.
Removing failure expectations for tests fixed by r146430.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix after r146430.
rniwa@webkit.org [Thu, 21 Mar 2013 07:42:13 +0000 (07:42 +0000)]
Windows build fix after r146430.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect some apparent problems in previous rebaselines.
pkasting@chromium.org [Thu, 21 Mar 2013 07:42:06 +0000 (07:42 +0000)]
Correct some apparent problems in previous rebaselines.

Unreviewed, rebaselining.

* css2.1/20110323/replaced-elements-001-expected.txt: Added.
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-win-xp/css3/flexbox: Removed.
* platform/chromium-win/css3/flexbox/button-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEWS bots have stopped uploading results to bugzilla
rniwa@webkit.org [Thu, 21 Mar 2013 07:30:30 +0000 (07:30 +0000)]
EWS bots have stopped uploading results to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=101091

Reviewed by Adam Barth.

The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
this relative file path resoled to a file inside a non-existent directory for "zip".

Fixed the bug by resolving both test results directory and zip archive paths in
LayoutTestResultsReader.archive.

Also made workspace.create_zip print the source_path so that we may debug these issues more easily
in the future.

* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".

* Scripts/webkitpy/common/system/workspace.py:
(Workspace.create_zip): Log the source path when "zip" failed.

* Scripts/webkitpy/common/system/workspace_mock.py:
(MockWorkspace.create_zip): Record zip_path and source_path for testing.

* Scripts/webkitpy/common/system/workspace_unittest.py:
(WorkspaceTest.test_create_zip_exception): Test that.

* Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
This is the actual bug fix.

* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_archive_last_layout_test_results_with_relative_path): Added a test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Settings] Fix JS compiler warnings.
eustas@chromium.org [Thu, 21 Mar 2013 07:15:08 +0000 (07:15 +0000)]
Web Inspector: [Settings] Fix JS compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=112879

Reviewed by Pavel Feldman.

Removed erroneous JSDoc.

* inspector/front-end/Settings.js: Removed erroneous JSDoc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline most "needs rebaseline" sections of Chromium test expectations...
pkasting@chromium.org [Thu, 21 Mar 2013 06:35:24 +0000 (06:35 +0000)]
[chromium] Rebaseline most "needs rebaseline" sections of Chromium test expectations, and fix a few other wrong expectations.
https://bugs.webkit.org/show_bug.cgi?id=11645
https://bugs.webkit.org/show_bug.cgi?id=89826
https://bugs.webkit.org/show_bug.cgi?id=96597
https://bugs.webkit.org/show_bug.cgi?id=97325
https://bugs.webkit.org/show_bug.cgi?id=101396
https://bugs.webkit.org/show_bug.cgi?id=102624
https://bugs.webkit.org/show_bug.cgi?id=103149
https://bugs.webkit.org/show_bug.cgi?id=106746
https://bugs.webkit.org/show_bug.cgi?id=107339
https://bugs.webkit.org/show_bug.cgi?id=109439
https://bugs.webkit.org/show_bug.cgi?id=110654
https://bugs.webkit.org/show_bug.cgi?id=111319
https://bugs.webkit.org/show_bug.cgi?id=112755
http://crbug.com/67416
http://crbug.com/148638

Unreviewed, test expectations update.

* css2.1/20110323/replaced-elements-001-expected.txt: Removed.
* fast/css/empty-generated-content-expected.txt: Added.
* fast/css/word-space-extra-expected.txt: Added.
* fast/table/025-expected.txt: Added.
* platform/chromium-linux-x86/css3/masking: Added.
* platform/chromium-linux-x86/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/date: Removed.
* platform/chromium-linux-x86/fast/forms/time: Removed.
* platform/chromium-linux-x86/platform/chromium/fast: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
* platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png:
* platform/chromium-linux/fast/css/word-space-extra-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-mac-lion/css3/masking: Added.
* platform/chromium-mac-lion/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
* platform/chromium-mac-lion/fast/css/word-space-extra-expected.png: Added.
* platform/chromium-mac-lion/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac-lion/fast/table/025-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-mac-snowleopard/css3/masking: Added.
* platform/chromium-mac-snowleopard/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/word-space-extra-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac-snowleopard/fast/table/025-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
* platform/chromium-mac/fast/css/word-space-extra-expected.png:
* platform/chromium-mac/fast/css/word-space-extra-expected.txt: Removed.
* platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac/fast/table/025-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win-xp/css3/masking: Added.
* platform/chromium-win-xp/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
* platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png:
* platform/chromium-win/fast/css/empty-generated-content-expected.txt:
* platform/chromium-win/fast/css/word-space-extra-expected.png:
* platform/chromium-win/fast/css/word-space-extra-expected.txt:
* platform/chromium-win/fast/events/stopPropagation-submit-expected.txt: Added.
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/chromium-win-xp/css2.1/20110323/replaced-elements-001-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/css3/filters/filter-property-parsing-expected.txt: Replaced.
* platform/chromium/fast/css/empty-generated-content-expected.txt: Removed.
* platform/chromium/fast/table/025-expected.txt: Removed.
* platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
* platform/mac/fast/css/empty-generated-content-expected.txt: Removed.
* platform/mac/fast/css/word-space-extra-expected.txt: Removed.
* platform/mac/fast/table/025-expected.txt: Removed.
* platform/win-future/css2.1: Added.
* platform/win-future/css2.1/20110323: Added.
* platform/win-future/css2.1/20110323/replaced-elements-001-expected.txt: Added.
* platform/win/fast/css/empty-generated-content-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a flaky crash test expectation per bug 112881.
rniwa@webkit.org [Thu, 21 Mar 2013 06:22:13 +0000 (06:22 +0000)]
Add a flaky crash test expectation per bug 112881.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move WebThemeEngine implementations to TestRunner library
jochen@chromium.org [Thu, 21 Mar 2013 06:16:51 +0000 (06:16 +0000)]
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(WebKit):
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled...
simon.fraser@apple.com [Thu, 21 Mar 2013 05:59:13 +0000 (05:59 +0000)]
Make GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled layers
https://bugs.webkit.org/show_bug.cgi?id=112864

Reviewed by Tim Horton.

If a GraphicsLayerCA has TiledBacking, ask the TiledBacking how
much memory it's using for tiles, rather than just using
height * width * 4.

Implement retainedTileBackingStoreMemory() in the TileController,
summing the memory used by parented tiles.

The original code was incorrectly multiplying by contentsScale
only once rather than twice (2x contents scale uses 4x as much memory).

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreMemoryEstimate):
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::retainedTileBackingStoreMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update for r145055
tkent@chromium.org [Thu, 21 Mar 2013 05:53:20 +0000 (05:53 +0000)]
[Chromium] Test expectation update for r145055
https://bugs.webkit.org/show_bug.cgi?id=111319

* platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Removed.
* platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled Chromium DEPS to r189497. Requested by
commit-queue@webkit.org [Thu, 21 Mar 2013 04:57:48 +0000 (04:57 +0000)]
Unreviewed.  Rolled Chromium DEPS to r189497.  Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Test expectations updates, and rebaseline to parallel r143389.
pkasting@chromium.org [Thu, 21 Mar 2013 04:05:39 +0000 (04:05 +0000)]
[chromium] Test expectations updates, and rebaseline to parallel r143389.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=99984
https://bugs.webkit.org/show_bug.cgi?id=111004
https://bugs.webkit.org/show_bug.cgi?id=112288
https://bugs.webkit.org/show_bug.cgi?id=112755

Unreviewed, test expectations updates.

* platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline some of my recent test changes
commit-queue@webkit.org [Thu, 21 Mar 2013 03:43:47 +0000 (03:43 +0000)]
Rebaseline some of my recent test changes
https://bugs.webkit.org/show_bug.cgi?id=112843

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Ojan Vafai.

* platform/chromium-mac-lion/css3/flexbox/button-expected.png: Added.
* platform/chromium-mac-lion/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac-snowleopard/css3/flexbox/button-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac/css3/flexbox/button-expected.png: Added.
* platform/chromium-mac/css3/flexbox/button-expected.txt: Added.
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-win/css3/flexbox/button-expected.png: Added.
* platform/chromium-win/css3/flexbox/button-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r146418.
commit-queue@webkit.org [Thu, 21 Mar 2013 03:35:02 +0000 (03:35 +0000)]
Unreviewed, rolling out r146418.
http://trac.webkit.org/changeset/146418
https://bugs.webkit.org/show_bug.cgi?id=112872

It turns out that these sub pixel tests still do fail on Mac
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.
gyuyoung.kim@samsung.com [Thu, 21 Mar 2013 02:47:04 +0000 (02:47 +0000)]
Unreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r146419.
rniwa@webkit.org [Thu, 21 Mar 2013 02:43:43 +0000 (02:43 +0000)]
Unreviewed, rolling out r146419.
http://trac.webkit.org/changeset/146419
https://bugs.webkit.org/show_bug.cgi?id=112870

Broke many tests on debug builds (Requested by rniwa_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

Source/WebCore:

* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
(main):
* bindings/scripts/StaticString.pm: Removed.
* dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
* dom/QualifiedName.h:
(WebCore):
* dom/make_names.pl:
(printNamesCppFile):
(printDefinitions):

Source/WTF:

* wtf/text/StringImpl.h:
(StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Implement EnforceRange IDL attribute for integer conversions
commit-queue@webkit.org [Thu, 21 Mar 2013 02:42:02 +0000 (02:42 +0000)]
[JSC] Implement EnforceRange IDL attribute for integer conversions
https://bugs.webkit.org/show_bug.cgi?id=112506

Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Implement the EnforceRange attribute for JSC bindings.

The EnforceRange attribute requires a type error to be thrown when
converting an ECMAScript number which is beyond the representable
range of the IDL integer type.

Tests: fast/js/webidl-type-mapping.html
       storage/indexeddb/cursor-advance-workers.html
       storage/indexeddb/cursor-advance.html
       storage/indexeddb/intversion-bad-parameters.html

* WebCore.exp.in:
* bindings/js/JSDOMBinding.cpp:
(WebCore):
(WebCore::enforceRange):
(WebCore::toInt32EnforceRange):
(WebCore::toUInt32EnforceRange):
(WebCore::toInt64):
(WebCore::toUInt64):
* bindings/js/JSDOMBinding.h:
(WebCore::toInt32):
(WebCore):
(WebCore::toUInt32):
* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

* fast/js/webidl-type-mapping-expected.txt:
* platform/chromium/fast/js/webidl-type-mapping-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[QNX][ARM] REGRESSION(r135330): Various failures in Octane
commit-queue@webkit.org [Thu, 21 Mar 2013 02:33:41 +0000 (02:33 +0000)]
[QNX][ARM] REGRESSION(r135330): Various failures in Octane
https://bugs.webkit.org/show_bug.cgi?id=112863

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-03-20
Reviewed by Yong Li.

This was fixed in http://trac.webkit.org/changeset/146396 on Linux only.
Enable this fix on QNX.

* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
rniwa@webkit.org [Thu, 21 Mar 2013 02:26:21 +0000 (02:26 +0000)]
Add flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
and fast/dom/MutationObserver/database-callback-delivery.html on Windows per bugs
112867 and 112868.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGesture events should include AllowShadowContent in hit testing
hayato@chromium.org [Thu, 21 Mar 2013 01:51:31 +0000 (01:51 +0000)]
Gesture events should include AllowShadowContent in hit testing
https://bugs.webkit.org/show_bug.cgi?id=112073

Reviewed by Dimitri Glazkov.

Source/WebCore:

Support gesture events for Shadow DOM.
Now 'gesturetap' events can be correctly dispatched in shadow trees.

Test: fast/dom/shadow/gesture-tap.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

* fast/dom/shadow/gesture-tap-expected.txt: Added.
* fast/dom/shadow/gesture-tap.html: Added.
* fast/dom/shadow/resources/event-dispatching.js:
(addEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShould add test for bug #112694
msaboff@apple.com [Thu, 21 Mar 2013 01:46:35 +0000 (01:46 +0000)]
Should add test for bug #112694
https://bugs.webkit.org/show_bug.cgi?id=112859

Reviewed by Filip Pizlo.

New regression test to check that eliminating a var arg DFG Node (array in this case) doesn't
cause a ASSERT or crash.

* fast/js/dfg-array-dead-expected.txt: Added.
* fast/js/dfg-array-dead.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-array-dead.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
mrowe@apple.com [Thu, 21 Mar 2013 01:44:23 +0000 (01:44 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac rebaseline after r146415. I somehow missed the 1px difference.
rniwa@webkit.org [Thu, 21 Mar 2013 01:44:13 +0000 (01:44 +0000)]
Mac rebaseline after r146415. I somehow missed the 1px difference.

* platform/mac/svg/custom/text-ctm-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
bfulgham@webkit.org [Thu, 21 Mar 2013 00:49:16 +0000 (00:49 +0000)]
../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861

Reviewed by Tim Horton.

* gtest/msvc/gtest-md.vcxproj: Add WinCairo targets.

../WebKit: [WinCairo] Top-level solution change to build under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861.

Reviewed by Tim Horton.

* WebKit.vcxproj/WebKit.sln: Add final set of WinCairo build
targets.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Add #if/def guards around some media-specific exports that
are not provided by the WinCairo port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146422 268f45cc-cd09-0410-ab3c-d52691b4dbfc