WebKit-https.git
9 years agoUnreviewed, rolling out r148851.
rniwa@webkit.org [Mon, 22 Apr 2013 06:06:18 +0000 (06:06 +0000)]
Unreviewed, rolling out r148851.
http://trac.webkit.org/changeset/148851
https://bugs.webkit.org/show_bug.cgi?id=114935

EFL Buildbot reports fail after gardening on r148851
(Requested by gyuyoung on #webkit).

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 06:00:01 +0000 (06:00 +0000)]
[EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114922

Reviewed by Gyuyoung Kim.

Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix some minor bad use of strings in WebCore
benjamin@webkit.org [Mon, 22 Apr 2013 05:54:11 +0000 (05:54 +0000)]
Fix some minor bad use of strings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114907

Reviewed by Darin Adler.

* editing/Editor.cpp:
(WebCore::Editor::selectedText): This was implicitly getting the emptyString()
for the argument "".
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::takeResults): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions
krit@webkit.org [Mon, 22 Apr 2013 04:39:07 +0000 (04:39 +0000)]
[Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions
https://bugs.webkit.org/show_bug.cgi?id=71444

Reviewed by Dean Jackson.

Source/WebCore:

Custom filter parameters should support mat2 to mat4 value functions. Added parsing
and style resolving bits to support the matrix function values. A later patch will
add the matrices to the shader program.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters

Modified existing tests to cover changes.

* GNUmakefile.list.am: Added WebKitCSSMatFunctionValue to individual build systems.
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterMatParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseMatValue):
(WebCore):
(WebCore::CSSParser::parseCustomFilterParameters):
* css/CSSParser.h:
(WebCore):
* css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
* css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSMatFunctionValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
* css/StyleResolver.h:
(StyleResolver):
* css/WebKitCSSMatFunctionValue.cpp:
(WebCore::WebKitCSSMatFunctionValue::WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::customCssText):
(WebCore::WebKitCSSMatFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMatFunctionValue::equals):
(WebCore::WebKitCSSMatFunctionValue::reportDescendantMemoryUsage):
* css/WebKitCSSMatFunctionValue.h:
(WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::create):
* platform/graphics/filters/CustomFilterArrayParameter.h:
(WebCore::CustomFilterArrayParameter::create):
(WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
* platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
* platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):

LayoutTests:

Added tests for mat2 to mat4 parameter functions on custom fiter function and
parameter descriptor.

* css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, EFL gardening. Remove test cases which are expected failed, but passed...
gyuyoung.kim@samsung.com [Mon, 22 Apr 2013 02:16:09 +0000 (02:16 +0000)]
Unreviewed, EFL gardening. Remove test cases which are expected failed, but passed now.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Lexer and Parser should be more informative when they encounter errors
oliver@apple.com [Sun, 21 Apr 2013 23:26:56 +0000 (23:26 +0000)]
JS Lexer and Parser should be more informative when they encounter errors
https://bugs.webkit.org/show_bug.cgi?id=114924

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add new tokens to represent the various ways that parsing and lexing have failed.
This gives us the ability to produce better error messages in some cases,
and to indicate whether or not the failure was due to invalid source, or simply
early termination.

The jsc prompt now makes use of this so that you can write functions that
are more than one line long.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* jsc.cpp:
(stringFromUTF):
(jscSource):
(runInteractive):
* parser/Lexer.cpp:
(JSC::::parseFourDigitUnicodeHex):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::lex):
* parser/Lexer.h:
(UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::valueType):
(JSC::Lexer::UnicodeHexValue::isValid):
(JSC::Lexer::UnicodeHexValue::value):
(Lexer):
* parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::::parse):
* parser/ParserError.h:
(ParserError):
(JSC::ParserError::ParserError):
* parser/ParserTokens.h:
* runtime/Completion.cpp:
(JSC):
(JSC::checkSyntax):
* runtime/Completion.h:
(JSC):

LayoutTests:

Update test results to cover improved error messages.

* fast/js/kde/parse-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T10-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T9-expected.txt:
* sputnik/Conformance/13_Function_Definition/S13_A7_T3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression(r148672): fast/events/touch/frame-hover-update.html fails
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 20:52:35 +0000 (20:52 +0000)]
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912

Reviewed by Allan Sandfeld Jensen.

Fix relative path to js-test-post.js in fast/events/touch/frame-hover-update.html.

* fast/events/touch/frame-hover-update.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRewrite fast/workers/dedicated-worker-lifecycle.html to verify that
mark.lam@apple.com [Sun, 21 Apr 2013 20:28:04 +0000 (20:28 +0000)]
Rewrite fast/workers/dedicated-worker-lifecycle.html to verify that
the GC is able to reclaim orphaned Workers on a timely basis.
https://bugs.webkit.org/show_bug.cgi?id=114893.

Reviewed by Geoffrey Garen.

* fast/workers/resources/dedicated-worker-lifecycle.js:
(orphanAllWorkers):
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
* fast/workers/resources/worker-util.js:
(waitUntilThreadCountMatchesCondition):
(waitUntilThreadCountMatches):
(waitUntilThreadCountDoesNotExceed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 19:51:22 +0000 (19:51 +0000)]
Unreviewed EFL gardening.

Mark css1/cascade/cascade_order.html as flaky.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 19:48:40 +0000 (19:48 +0000)]
Unreviewed EFL gardening.

Mark several webgl tests as flaky.
Mark several ref tests as failing (started between r148032 and r148102).

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 19:15:20 +0000 (19:15 +0000)]
Unreviewed EFL gardening.

Mark websocket tests as flaky and webgl/conformance/rendering/gl-scissor-test.html
as failing.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] Media attribute preload="none" is not honored
kbalazs@webkit.org [Sun, 21 Apr 2013 18:36:58 +0000 (18:36 +0000)]
[GStreamer] Media attribute preload="none" is not honored
https://bugs.webkit.org/show_bug.cgi?id=114357

Reviewed by Philippe Normand.

Source/WebCore:

Fix the logic that prevents live streams from being buffered to not make preload="none" ignored.

Test: http/tests/media/video-preload.html
We need a http test because the bug does not triggered with local files.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
Remove m_originalPreloadWasAutoAndWasOverridden because it is not necessary and it is causing this bug.
Currently if the tag has preload="none" attribute we set m_preload to Auto in the constructor. After that
MedaPlayer calls setPreload(None), so we set m_originalPreloadWasAutoAndWasOverridden to true and later
reset m_preload to Auto. The error prone factor here is that the m_preload member is repeated in the
private class and setPreload is also used there. This seems to be necessary because we need to be able
to ignore preloading if this is a live stream. Fortunately the original parsed value is available in the
constructor, so we can use that. This will give the correct value that we should override only in the case
of a live stream and that's it, we don't need to reset it later to Auto.
Furthermore, we should ignore setting preload to auto from js if it is a live stream. This patch also handles
this with an early return in setPreload.

LayoutTests:

* http/tests/media/video-preload-expected.txt: Added.
* http/tests/media/video-preload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 17:46:21 +0000 (17:46 +0000)]
Unreviewed EFL gardening.

Mark several tests as failing on EFL port due to the bump to libsoup
2.42.0.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 17:34:14 +0000 (17:34 +0000)]
Unreviewed EFL gardening.

Mark several test cases as failing on EFL port and filed bugs for them.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 17:19:42 +0000 (17:19 +0000)]
Unreviewed EFL gardening.

Mark websocket tests as flaky on EFL WK2.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/media/mq-resolution.html throws TypeError when calling setPageScaleFactor
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 16:14:52 +0000 (16:14 +0000)]
fast/media/mq-resolution.html throws TypeError when calling setPageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=114914

Reviewed by Antonio Gomes.

Update fast/media/mq-resolution.html to call setPageScaleFactor() method on
window.internals instead of window.internals.settings. This method was moved
out of settings in r136055.

* fast/media/mq-resolution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 15:11:32 +0000 (15:11 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/forms/validation-message-appearance.html and fix expectation
for editing/pasteboard/paste-text-004.html.

* platform/efl/TestExpectations:
* platform/efl/fast/forms/validation-message-appearance-expected.png: Added.
* platform/efl/fast/forms/validation-message-appearance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 15:02:00 +0000 (15:02 +0000)]
Unreviewed EFL gardening.

Mark more compositing test cases as crashing due to r148433 for
EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression(r148672): fast/events/touch/frame-hover-update.html fails
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 14:22:04 +0000 (14:22 +0000)]
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912

Reviewed by Allan Sandfeld Jensen.

Fix relative path to js-test-pre.js in the test case.

* fast/events/touch/frame-hover-update.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 14:10:14 +0000 (14:10 +0000)]
Unreviewed EFL gardening.

Rebaseline several test cases for EFL port.

* platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt:
* platform/efl/fast/backgrounds/background-position-parsing-expected.png:
* platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
* platform/wk2/loader/go-back-cached-main-resource-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 13:54:38 +0000 (13:54 +0000)]
Unreviewed EFL gardening.

Remove duplicate entry in EFL's TestExpectations for:
inspector/debugger/dynamic-script-tag.html

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 13:50:01 +0000 (13:50 +0000)]
Unreviewed EFL gardening.

Mark more compisiting / webgl tests as crashing due to r148433 for
EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Removing the remaining redundant baselines.
zandobersek@gmail.com [Sun, 21 Apr 2013 12:56:15 +0000 (12:56 +0000)]
Unreviewed GTK gardening. Removing the remaining redundant baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under accessibility, fast...
zandobersek@gmail.com [Sun, 21 Apr 2013 12:54:00 +0000 (12:54 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under accessibility, fast/backgrounds, fast/body-propagation,
fast/doctypes, fast/fast-mobile-scrolling, fast/inspector-support, fast/loader, fast/tokenizer and fast/xsl directories
after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/block, fast/borders...
zandobersek@gmail.com [Sun, 21 Apr 2013 12:46:05 +0000 (12:46 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/block, fast/borders, fast/box-shadow,
fast/box-sizing, fast/canvas, fast/clip and fast/compact directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 11:06:43 +0000 (11:06 +0000)]
Unreviewed EFL gardening.

Mark several compositing test as crashing on EFL port due to
r148433.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWidget should not depend on AXObjectCache
carlosgc@webkit.org [Sun, 21 Apr 2013 10:07:28 +0000 (10:07 +0000)]
Widget should not depend on AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=114514

Reviewed by Chris Fleizach.

Source/WebCore:

Move AXObjectCache usage from platform files to FrameView.

* WebCore.exp.in: Update symbols.
* page/FrameView.cpp:
(WebCore::FrameView::didAddScrollbar): Handle scrollbar updates in
AXObjectCache.
(WebCore::FrameView::willRemoveScrollbar): Handle scrollbar
updates in AXObjectCache and remove the scrollbar from the cache.
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Use
didAddScrollbar/willRemoveScrollbar
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddScrollbar): This is the old
didAddVerticalScrollbar and didAddHorizontalScrollbar joined in a
single method that receives a ScrollbarOrientation parameter.
(WebCore::ScrollableArea::willRemoveScrollbar): This is the old
willRemoveVerticalScrollbar and
willRemoveHorizontalScrollbarScrollbar joined in a single method
that receives a ScrollbarOrientation parameter.
* platform/ScrollableArea.h:
(ScrollableArea):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar): Remove AXObjectCache usage.
* platform/Scrollbar.h:
* platform/Widget.h:
(Widget): Remove axObjectCache() method.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar): Use didAddScrollbar.
(WebCore::RenderLayer::destroyScrollbar): Use willRemoveScrollbar.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar): Use didAddScrollbar.
(WebCore::RenderListBox::destroyScrollbar): Use willRemoveScrollbar.

Source/WebKit2:

Update to API changes.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::createScrollbar):
* WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::createScrollbar):
(WebKit::SimplePDFPlugin::destroyScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/css, fast/css-gener...
zandobersek@gmail.com [Sun, 21 Apr 2013 09:26:25 +0000 (09:26 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/css, fast/css-generated-content,
fast/css3-text and fast/dom directories after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/dynamic, fast/encod...
zandobersek@gmail.com [Sun, 21 Apr 2013 09:18:07 +0000 (09:18 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/dynamic, fast/encoding, fast/events,
fast/flexbox, fast/forms, fast/frames, fast/gradients, fast/hidpi and fast/html directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
mark.lam@apple.com [Sun, 21 Apr 2013 09:04:09 +0000 (09:04 +0000)]
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.
https://bugs.webkit.org/show_bug.cgi?id=114910.

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/images, fast/inline...
zandobersek@gmail.com [Sun, 21 Apr 2013 08:23:41 +0000 (08:23 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/images, fast/inline, fast/inline-block,
fast/invalid, fast/js, fast/layers, fast/line-grid, fast/lists and fast/multicol directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/overflow, fast...
zandobersek@gmail.com [Sun, 21 Apr 2013 08:15:33 +0000 (08:15 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/overflow, fast/parser, fast/reflections,
fast/regions and fast/repaint directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, gardening. Remove duplicated tests.
gyuyoung.kim@samsung.com [Sun, 21 Apr 2013 08:05:36 +0000 (08:05 +0000)]
Unreviewed, gardening. Remove duplicated tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/replaced, fast...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:48:48 +0000 (07:48 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/replaced, fast/ruby, fast/runin,
fast/scrolling, fast/selectors, fast/spatial-navigation, fast/subpixel and mathml directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/text, fast/transfor...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:38:24 +0000 (07:38 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/text, fast/transforms, fast/writing-mode,
ietestcenter, media, plugins and scrollbars directories after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Removing redundant baselines under the svg/ directory.
zandobersek@gmail.com [Sun, 21 Apr 2013 07:29:20 +0000 (07:29 +0000)]
Unreviewed GTK gardening. Removing redundant baselines under the svg/ directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Part 2 of updating baselines for tests under svg/dynamic...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:27:50 +0000 (07:27 +0000)]
Unreviewed GTK gardening. Part 2 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Part 1 of updating baselines for tests under svg/dynamic...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:22:34 +0000 (07:22 +0000)]
Unreviewed GTK gardening. Part 1 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Part 3 of updating baselines for tests under the tables...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:15:53 +0000 (07:15 +0000)]
Unreviewed GTK gardening. Part 3 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Part 2 of updating baselines for tests under the tables...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:06:09 +0000 (07:06 +0000)]
Unreviewed GTK gardening. Part 2 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Part 1 of updating baselines for tests under the tables...
zandobersek@gmail.com [Sun, 21 Apr 2013 06:57:52 +0000 (06:57 +0000)]
Unreviewed GTK gardening. Part 1 of updating baselines for tests under the tables directory
after enabling the subpixel layout for the GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under svg/batik, svg/canvas...
zandobersek@gmail.com [Sun, 21 Apr 2013 06:27:47 +0000 (06:27 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under svg/batik, svg/canvas, svg/carto.net, svg/clip-path,
svg/css, svg/custom and svg/hixie after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under svg/W3C-* after enabling...
zandobersek@gmail.com [Sun, 21 Apr 2013 06:23:09 +0000 (06:23 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under svg/W3C-* after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under svg/custom, svg/dom...
zandobersek@gmail.com [Sun, 21 Apr 2013 05:53:22 +0000 (05:53 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under svg/custom, svg/dom, svg/in-html,
svg/overflow, svg/repaint and svg/transforms after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for tests under svg/as-*, svg/filters...
zandobersek@gmail.com [Sun, 21 Apr 2013 05:43:48 +0000 (05:43 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under svg/as-*, svg/filters, svg/stroke,
svg/text, svg/wicd and svg/zoom directories after enabling subpixel layout for the GTK port.

Patch #7 of approx. 24, `svn commit` is used directly to avoid the webkit-patch and ChangeLog overhead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Part 5] Parse color value for custom() function parameters
krit@webkit.org [Sun, 21 Apr 2013 03:32:31 +0000 (03:32 +0000)]
[Part 5] Parse color value for custom() function parameters
https://bugs.webkit.org/show_bug.cgi?id=114902

Reviewed by Dean Jackson.

Source/WebCore:

Custom filter parameters should support color values. Added parsing
and style resolving bits to support color values. A later patch will
add the color values to the shader program.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters

Modified existing tests to cover changes.

* GNUmakefile.list.am: Added CustomFilterColorParameter to support color values
    as custom filter parameters.
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterColorParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilterParameters):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore):
(WebCore::StyleResolver::parseCustomFilterParameter):
* css/StyleResolver.h:
(StyleResolver):
* platform/graphics/filters/CustomFilterColorParameter.h: Added.
(WebCore):
(WebCore::blendFunc):
(CustomFilterColorParameter):
(WebCore::CustomFilterColorParameter::create):
(WebCore::CustomFilterColorParameter::blend):
(WebCore::CustomFilterColorParameter::color):
(WebCore::CustomFilterColorParameter::setColor):
(WebCore::CustomFilterColorParameter::operator==):
(WebCore::CustomFilterColorParameter::CustomFilterColorParameter):
(WebCore::CustomFilterColorParameter::~CustomFilterColorParameter):
* platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
* platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):

LayoutTests:

Added tests for color parameters on custom fiter function and parameter descriptor.

* css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for editing tests after enabling subpixe...
zandobersek@gmail.com [Sat, 20 Apr 2013 23:25:07 +0000 (23:25 +0000)]
Unreviewed GTK gardening. Updating baselines for editing tests after enabling subpixel layout for the GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for the remaining tests under the css3...
zandobersek@gmail.com [Sat, 20 Apr 2013 23:11:13 +0000 (23:11 +0000)]
Unreviewed GTK gardening. Updating baselines for the remaining tests under the css3 directory
after enabling the subpixel layout for the GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening. Updating baselines for the css3/selectors/html and css3...
zandobersek@gmail.com [Sat, 20 Apr 2013 23:03:19 +0000 (23:03 +0000)]
Unreviewed GTK gardening. Updating baselines for the css3/selectors/html and css3/selectors/xml tests
after enabling the subpixel layout. Patch #3 of many more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening, updating css2.1 baselines after enabling the subpixel layout.
zandobersek@gmail.com [Sat, 20 Apr 2013 22:51:40 +0000 (22:51 +0000)]
Unreviewed GTK gardening, updating css2.1 baselines after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Rebaseline after r148792. Fix mac-wk2 text.
glenn@skynav.com [Sat, 20 Apr 2013 20:13:36 +0000 (20:13 +0000)]
Unreviewed gardening. Rebaseline after r148792. Fix mac-wk2 text.

* platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSunSpider/string-tagcloud should be more lenient in validating its results, since...
fpizlo@apple.com [Sat, 20 Apr 2013 20:11:25 +0000 (20:11 +0000)]
SunSpider/string-tagcloud should be more lenient in validating its results, since they depend on Math.log, which isn't formally specified
https://bugs.webkit.org/show_bug.cgi?id=114895

Reviewed by Michael Saboff.

* tests/sunspider-1.0/string-tagcloud.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Sat, 20 Apr 2013 19:55:44 +0000 (19:55 +0000)]
Unreviewed GTK gardening.

Rebaseline #1 after enabling the subpixel layout, covering the animations, css1, fonts, fullscreen,
transforms and transitions directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix baseline positioning issue by updating Freetype
zandobersek@gmail.com [Sat, 20 Apr 2013 19:22:59 +0000 (19:22 +0000)]
[GTK] Fix baseline positioning issue by updating Freetype
https://bugs.webkit.org/show_bug.cgi?id=106775

Reviewed by Martin Robinson.

* gtk/jhbuild.modules: Bump the Freetype Jhbuild dependency to 2.4.11.
* gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added. This is the Freetype
patch (committed as e0469372) that fixes rounding issues for smaller fonts. It is bound to be included
in the 2.4.12 release of Freetype (not released yet) but is provided here as its effect on baselines is
considered positive and will reduce the amout of future rebaselining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable sub-pixel layout for the GTK port
zandobersek@gmail.com [Sat, 20 Apr 2013 19:21:51 +0000 (19:21 +0000)]
Enable sub-pixel layout for the GTK port
https://bugs.webkit.org/show_bug.cgi?id=94792

Reviewed by Martin Robinson.

* Source/autotools/SetupWebKitFeatures.m4: Enable the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Rebaseline after r148791. Update text expectations.
glenn@skynav.com [Sat, 20 Apr 2013 19:20:58 +0000 (19:20 +0000)]
Unreviewed gardening. Rebaseline after r148791. Update text expectations.

* platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
* platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r147588): Line breaks occur in the middle of Hebrew words at haaertz...
glenn@skynav.com [Sat, 20 Apr 2013 16:41:15 +0000 (16:41 +0000)]
REGRESSION (r147588): Line breaks occur in the middle of Hebrew words at haaertz.co.il and other websites
https://bugs.webkit.org/show_bug.cgi?id=114721

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/text/line-break-after-empty-inline-hebrew.html
       fast/text/line-break-after-inline-latin1.html

If prior context changes content or length after creating line break iterator, then need to
create new iterator with new prior context instead of using cached iterator with old prior context.

* platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator): Initialize members to cache reference to initialized prior context.
(WebCore::LazyLineBreakIterator::get): Create new iterator if prior context content reference changes.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Reset cached prior context references.
(LazyLineBreakIterator): Add members to cache reference to initialized prior context.

LayoutTests:

* fast/text/line-break-after-empty-inline-hebrew-expected.txt: Added.
* fast/text/line-break-after-empty-inline-hebrew.html: Added.
* fast/text/line-break-after-inline-latin1-expected.txt: Added.
* fast/text/line-break-after-inline-latin1.html: Added.
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLint should be able to use x87 instead of SSE for floating pointer
allan.jensen@digia.com [Sat, 20 Apr 2013 10:27:33 +0000 (10:27 +0000)]
LLint should be able to use x87 instead of SSE for floating pointer
https://bugs.webkit.org/show_bug.cgi?id=112239

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Implements LLInt floating point operations in x87, to ensure we support
x86 without SSE2.

X86 (except 64bit) now defaults to using x87 instructions in order to
support all 32bit x86 back to i686. The implementation uses the fucomi
instruction from i686 which sets the new minimum.

The FPU registers must always be empty on entering or exiting a function.
We make sure to only use two X87 registers, and they are always emptied
before calling deeper functions or returning from the LLInt.

* jit/JITStubs.cpp:
(JSC): Empty FPU registers before exiting.
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/instructions.rb:
* offlineasm/x86.rb:

Source/WTF:

Disable GTK workaround now that LLInt does not require SSE2.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Remove obsolete workaround for debug builds
abecsi@webkit.org [Sat, 20 Apr 2013 09:53:06 +0000 (09:53 +0000)]
[Qt][Mac] Remove obsolete workaround for debug builds
https://bugs.webkit.org/show_bug.cgi?id=114750

Reviewed by Jocelyn Turcotte.

This workaround made default builds fail with recent Qt5 because
it removed the major version number from the library name, producing
QtWebKitWidgets, whereas the linking command line tried to link
against Qt5WebKitWidgets.
Debug builds are possible with and without framework-enabled builds
of Qt, but the debug versions of the Qt libraries have to be present.
Debug builds with a release version of Qt are not possible on Mac
since for debug builds qmake produces a linker command line where
all the Qt libraries have the "_debug" suffix, therefore if the debug
libraries are missing the build fails.

* Source/widgetsapi.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix unit test webkit2/WebKitFindController/hide
commit-queue@webkit.org [Sat, 20 Apr 2013 08:23:19 +0000 (08:23 +0000)]
[GTK] Fix unit test webkit2/WebKitFindController/hide
https://bugs.webkit.org/show_bug.cgi?id=89810

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-20
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

The test had some hacks in order to compare a page with highlighted
results after using the find command with the original page. Now it uses
the snapshots API that allows to make the test simpler and more
reliable.

* UIProcess/API/gtk/tests/TestMain.h:
(Test::cairoSurfacesEqual): Moved helper function to compare two cairo
surfaces from TestWebKitWebView.
(Test):
* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide): Modify test to use snapshots.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSnapshot): Move basic snapshop methods to WebViewTest to
share them with TestWebKitFindController test.
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest): Initialize cairo surface.
(WebViewTest::~WebViewTest): Destroy cairo surface.
(onSnapshotReady): Callback to set the cairo surface when the snapshot
is ready.
(WebViewTest::getSnapshotAndWaitUntilReady): Method that takes a
snapshot and returns the cairo surface when it is ready.
* UIProcess/API/gtk/tests/WebViewTest.h: Add new method headers and
attribute for the cairo surface.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Unskip test webkit2/WebKitFindController/hide.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Arrow of combo box are drawn twice
ryuan.choi@samsung.com [Sat, 20 Apr 2013 04:38:43 +0000 (04:38 +0000)]
[EFL] Arrow of combo box are drawn twice
https://bugs.webkit.org/show_bug.cgi?id=113917

Reviewed by Gyuyoung Kim.

combo_button_icon part is for arrow so that images of combo_button part should
not contain arrow.

No new tests required due to no behavioral change.

* platform/efl/DefaultTheme/widget/combo/combo_focus_button.png:
* platform/efl/DefaultTheme/widget/combo/combo_hover_button.png:
* platform/efl/DefaultTheme/widget/combo/combo_press_button.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[css exclusions] Fix up shape-inside-recursive-layout test case
betravis@adobe.com [Sat, 20 Apr 2013 01:03:57 +0000 (01:03 +0000)]
[css exclusions] Fix up shape-inside-recursive-layout test case
https://bugs.webkit.org/show_bug.cgi?id=114890

Reviewed by Dirk Schulze.

The children of the old-flexbox, new-flexbox, and grid shape-inside  containers
should have their display value set to -webkit-inline-box, -webkit-inline-flex,
and -webkit-inline-grid respectively. These values should not be set for
the containers themselves, as we are interested in the behavior of descendants
of the shape-inside container.

* fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
* fast/exclusions/shape-inside/shape-inside-recursive-layout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd interfaces and stubs for audio and video tracks
commit-queue@webkit.org [Sat, 20 Apr 2013 01:03:14 +0000 (01:03 +0000)]
Add interfaces and stubs for audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=113965

Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-19
Reviewed by Jer Noble.

No new tests because there's no implementations, so there's nothing
interesting to test.

* CMakeLists.txt: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
* DerivedSources.cpp: Same.
* DerivedSources.make: Same.
* DerivedSources.pri: Same.
* GNUmakefile.list.am: Same.
* Target.pri: Same.
* UseJSC.cmake: Same.
* WebCore.vcproj/WebCore.vcproj: Same.
* WebCore.xcodeproj/project.pbxproj: Same.
* bindings/gobject/GNUmakefile.am: Same.
* bindings/js/JSAudioTrackCustom.cpp: Added, based on JSTestTrackCustom
* bindings/js/JSAudioTrackListCustom.cpp: Same.
* bindings/js/JSBindingsAllInOne.cpp: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
* bindings/js/JSVideoTrackCustom.cpp: Added, based on JSTestTrackCustom
* bindings/js/JSVideoTrackListCustom.cpp: Same.
* dom/EventTarget.h: Make AudioTrackList and VideoTrackList event targets.
* dom/EventTargetFactory.in: Same.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Add m_audioTracks and m_videoTracks
(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear clients for audio and video tracks
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Added.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Added.
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Same.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveVideoTrack): Same.
(WebCore::HTMLMediaElement::addAudioTrack): Added, based on addTextTrack
(WebCore::HTMLMediaElement::addVideoTrack): Same.
(WebCore::HTMLMediaElement::removeAudioTrack): Added, based on removeTextTrack
(WebCore::HTMLMediaElement::removeVideoTrack): Added, based on removeTextTrack
(WebCore::HTMLMediaElement::removeAllInbandTracks): Remove audio and video tracks too
(WebCore::HTMLMediaElement::audioTracks): Added, based on textTracks
(WebCore::HTMLMediaElement::videoTracks): Added, based on textTracks
(WebCore::HTMLMediaElement::reportMemoryUsage): Add audio and video tracks
* html/HTMLMediaElement.h: Add audioTracks and videoTracks and related functions
* html/HTMLMediaElement.idl: Add audioTracks and videoTracks
* html/track/AudioTrack.cpp: Added, based on TextTrack and InbandTextTrack.
* html/track/AudioTrack.h: Same.
* html/track/AudioTrack.idl: Added.
* html/track/AudioTrackList.cpp: Added, based on TextTrackList
* html/track/AudioTrackList.h: Same.
* html/track/AudioTrackList.idl: Added.
* html/track/TextTrackList.h: Add missing OVERRIDE on interfaceName()
* html/track/VideoTrack.cpp: Added, based on TextTrack and InbandTextTrack.
* html/track/VideoTrack.h: Same.
* html/track/VideoTrack.idl: Added.
* html/track/VideoTrackList.cpp: Added, based on TextTrackList
* html/track/VideoTrackList.h: Same.
* html/track/VideoTrackList.idl: Added.
* platform/graphics/AudioTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::addAudioTrack): Added, based on addTextTrack
(WebCore::MediaPlayer::removeAudioTrack): Added, based on removeTextTrack
(WebCore::MediaPlayer::addVideoTrack): Added, based on addTextTrack
(WebCore::MediaPlayer::removeVideoTrack): Added, based on removeTextTrack
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
(WebCore::MediaPlayerClient::mediaPlayerDidAddVideoTrack): Same
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveVideoTrack): Same
* platform/graphics/VideoTrackPrivate.h: Added, based on InbandTextTrackPrivate.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhenever it is cheap and non-invasive, SunSpider tests should validate their results...
fpizlo@apple.com [Sat, 20 Apr 2013 00:27:23 +0000 (00:27 +0000)]
Whenever it is cheap and non-invasive, SunSpider tests should validate their results to ensure that the browser runs them correctly
https://bugs.webkit.org/show_bug.cgi?id=114852

Reviewed by Geoffrey Garen.

This adds low-overhead checking of the results of each SunSpider tests. This is not
meant to be an exhaustive test that everything was executed correctly, but rather a
simple sanity check that will catch glaring mistakes. The philosophy here is that we're
not trying to prevent all forms of cheating, or that we're trying to prove the
browser's correctness. Moreover, these checks are meant to incur minimal overhead;
they currently clock in at <2% slow-down in SunSpider 1.0.

The test expectations were generated using the LLInt on command-line, and I've verified
that Firefox 20, Chrome 26, IE 10, Safari 6, and ToT with all of the JITs agree. Note
that some tests cannot be precisely validated because they use Math functions, which
ECMAScript chooses to not formally specify - those functions like sin() and friends are
allowed to return implementation-dependent results. Also some tests cannot be validated
at all because their behavior is either intentionally random or is timezone-dependent.
But 23 out of 26 tests now have some kind of validation.

I've updated the harnesses to show erroneous runs when displaying results.

* resources/TEMPLATE.html:
* resources/driver-TEMPLATE.html:
* resources/sunspider-analyze-results.js:
(formatResult):
(resultLine):
(printOutput):
* resources/sunspider-compare-results.js:
(.formatMean):
(.resultLine):
(.printOutput):
(sunspiderCompareResults):
* resources/sunspider-standalone-driver.js:
* tests/sunspider-1.0/3d-cube.js:
(Init):
* tests/sunspider-1.0/3d-morph.js:
* tests/sunspider-1.0/3d-raytrace.js:
* tests/sunspider-1.0/access-binary-trees.js:
* tests/sunspider-1.0/access-fannkuch.js:
* tests/sunspider-1.0/access-nbody.js:
* tests/sunspider-1.0/access-nsieve.js:
(sieve):
* tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
* tests/sunspider-1.0/bitops-bits-in-byte.js:
* tests/sunspider-1.0/bitops-bitwise-and.js:
* tests/sunspider-1.0/bitops-nsieve-bits.js:
* tests/sunspider-1.0/controlflow-recursive.js:
* tests/sunspider-1.0/crypto-aes.js:
* tests/sunspider-1.0/crypto-md5.js:
* tests/sunspider-1.0/crypto-sha1.js:
* tests/sunspider-1.0/date-format-tofte.js:
* tests/sunspider-1.0/date-format-xparb.js:
* tests/sunspider-1.0/math-cordic.js:
* tests/sunspider-1.0/math-partial-sums.js:
(partial):
* tests/sunspider-1.0/math-spectral-norm.js:
* tests/sunspider-1.0/regexp-dna.js:
* tests/sunspider-1.0/string-base64.js:
* tests/sunspider-1.0/string-fasta.js:
(fastaRepeat):
(fastaRandom):
* tests/sunspider-1.0/string-tagcloud.js:
* tests/sunspider-1.0/string-unpack-code.js:
* tests/sunspider-1.0/string-validate-input.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, revert r148782. It was not reviewed by a WebKit2 owner.
jer.noble@apple.com [Sat, 20 Apr 2013 00:15:28 +0000 (00:15 +0000)]
Unreviewed, revert r148782. It was not reviewed by a WebKit2 owner.

* PluginProcess/mac/PluginProcessShim.mm:
* Shared/mac/CookieStorageShim.cpp: Removed.
* Shared/mac/CookieStorageShim.h: Removed.
* Shared/mac/CookieStorageShimLibrary.cpp: Removed.
* Shared/mac/CookieStorageShimLibrary.h: Removed.
* Shared/mac/DYLDInterpose.h: Removed.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/mac/SecItemShimLibrary.mm:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWWDC session videos don’t play at developer.apple.com
jer.noble@apple.com [Fri, 19 Apr 2013 23:32:29 +0000 (23:32 +0000)]
WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858

Reviewed by Eric Carlson.

AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.

Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:
* Shared/mac/CookieStorageShimLibrary.h: Added
(CookieStorageShimCallbacks):
* Shared/mac/CookieStorageShimLibrary.cpp: Added.
(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
    the CFNetwork call, and pass to the registered callback.
(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.

Add a helper singleton class which will talk to the shim through the
registered callbacks:
* Shared/mac/CookieStorageShim.h: Added
(WebKit::CookieStorageShim::CookieStorageShim):
* Shared/mac/CookieStorageShim.cpp: Added.
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
    over to the NetworkProcess.
(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.

Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
* WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):

As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:
* Shared/mac/DYLDInterpose.h: Added.
* PluginProcess/mac/PluginProcessShim.mm:
* WebProcess/mac/SecItemShimLibrary.mm:

Add new files to the project:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Exclusions] Implement empty segments for multiple-segment shape-insides
betravis@adobe.com [Fri, 19 Apr 2013 23:28:26 +0000 (23:28 +0000)]
[CSS Exclusions] Implement empty segments for multiple-segment shape-insides
https://bugs.webkit.org/show_bug.cgi?id=100049

Reviewed by David Hyatt.

Source/WebCore:

Content should not overflow a shape-inside segment, even if that means no content
will be placed in that segment. Overflow may be pushed to outside the shape. This
patch removes the restriction that every line must consume at least some text
input while inside a shape-inside. Content that does not fit is pushed down until
it does, either inside the shape or just below it.

Test: fast/exclusions/shape-inside/shape-inside-empty-segments.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForSegment): Do not include empty segments for
consideration, as the actual BidiRuns construction expects to consume at
least one character.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::firstPositiveWidth): Find the first positive word measurement width,
as there may be some empty word break measurements inserted.
(WebCore::adjustLogicalLineTop): Move the current line down, if necessary, to
fit it within the shape inside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): If nothing fit in the
current segment, find the first available position for the smallest item
at the beginning of the text.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Return an empty segment
for a line that is inside the shape, but has no segments.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Do not consume
input to meet minimum size requirements if you are inside a shape.

LayoutTests:

Testing that shape-insides do not place content where it will not fit. Also
fixing up some previous tests and expectations.

* fast/exclusions/resources/multi-segment-polygon.js:
(simulateWithText): Enable multi-line shape expectations using arrays.
* fast/exclusions/resources/simple-rectangle.js:
(createRectangleTest): Add overflow: break-word property to tests.
(createRectangleTestResult): Ditto.
* fast/exclusions/shape-inside/shape-inside-empty-expected.html: Adjust results
for tests where content should be pushed down.
* fast/exclusions/shape-inside/shape-inside-empty-segments-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-empty-segments.html: Added.
* fast/exclusions/shape-inside/shape-inside-empty.html: Shapes with height but
no width should still push content down below the shape.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove uses of WebKit_Source from AppleWin build in WTF and JavaScriptCore.
roger_fong@apple.com [Fri, 19 Apr 2013 23:03:49 +0000 (23:03 +0000)]
Remove uses of WebKit_Source from AppleWin build in WTF and JavaScriptCore.

* JavaScriptCore.vcxproj/JavaScriptCore.make:
* JavaScriptCore.vcxproj/build-generated-files.sh:
* JavaScriptCore.vcxproj/copy-files.cmd:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
* WTF.vcxproj/WTF.make:
* WTF.vcxproj/copy-files.cmd:
* WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
(react_to_vsprops_changes):
(react_to_webkit1_interface_changes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fixes for the flakiness dashboard.
rniwa@webkit.org [Fri, 19 Apr 2013 23:03:38 +0000 (23:03 +0000)]
Build fixes for the flakiness dashboard.

* TestResultServer/static-dashboards/flakiness_dashboard.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a missing null pointer check after r148759.
rniwa@webkit.org [Fri, 19 Apr 2013 22:47:59 +0000 (22:47 +0000)]
Add a missing null pointer check after r148759.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug...
jberlin@webkit.org [Fri, 19 Apr 2013 22:16:06 +0000 (22:16 +0000)]
[Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571

* platform/mac-wk2/TestExpectations:
The bots are also seeing image failures flakily, so add that expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac Lion] media/W3C/video/events/event_canplay.html is flakey, sometimes times out
jberlin@webkit.org [Fri, 19 Apr 2013 21:32:47 +0000 (21:32 +0000)]
[Mac Lion] media/W3C/video/events/event_canplay.html is flakey, sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=114889

* platform/mac-lion/TestExpectations:
Mark it as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse Vector instead of StringBuilder for CSSPreloadScanner's buffers
benjamin@webkit.org [Fri, 19 Apr 2013 21:17:33 +0000 (21:17 +0000)]
Use Vector instead of StringBuilder for CSSPreloadScanner's buffers
https://bugs.webkit.org/show_bug.cgi?id=114794

Reviewed by Ryosuke Niwa.

Cleanup for other String changes.

CSSPreloadScanner only handles UChar, StringBuilder was a little
overkill.

* html/parser/CSSPreloadScanner.cpp:
(WebCore):
(WebCore::ruleEqualIgnoringCase):
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/CSSPreloadScanner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the declaration of MemoryObjectInfo from StringImpl
benjamin@webkit.org [Fri, 19 Apr 2013 21:13:47 +0000 (21:13 +0000)]
Remove the declaration of MemoryObjectInfo from StringImpl
https://bugs.webkit.org/show_bug.cgi?id=114788

Reviewed by Andreas Kling.

* wtf/text/StringImpl.h: The declaration is an other left over from chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder
benjamin@webkit.org [Fri, 19 Apr 2013 21:10:34 +0000 (21:10 +0000)]
StyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=114847

Reviewed by Geoffrey Garen.

For some reason StyledMarkupAccumulator::appendText() was allocating a separate buffer
for invoking appendStyleNodeOpenTag. This is a bad idea.

* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::appendText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Support the SourceMap header, X-SourceMap was deprecated
joepeck@webkit.org [Fri, 19 Apr 2013 21:06:06 +0000 (21:06 +0000)]
Web Inspector: Support the SourceMap header, X-SourceMap was deprecated
https://bugs.webkit.org/show_bug.cgi?id=114888

Check first for SourceMap, then fallback to X-SourceMap. Leaving in
support for the deprecated header because most tools and articles
online mention that version and have not yet updated.

Reviewed by Timothy Hatcher.

* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Backend should detect sourceMappingURLs in CSS Resources
joepeck@webkit.org [Fri, 19 Apr 2013 21:06:03 +0000 (21:06 +0000)]
Web Inspector: Backend should detect sourceMappingURLs in CSS Resources
https://bugs.webkit.org/show_bug.cgi?id=114854

Source/WebCore:

Reviewed by Timothy Hatcher.

Test: http/tests/inspector/network/css-source-mapping-url.html

* inspector/Inspector.json:
- Page.getResourceTree - add sourceMapURL to resource payloads
- Network.loadingFinished and Network.requestServedFromMemoryCache,
  include extra resource info object with possible sourceMapURL.

* inspector/ContentSearchUtils.h:
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::scriptCommentPattern):
(WebCore::ContentSearchUtils::stylesheetCommentPattern):
(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findScriptSourceURL):
(WebCore::ContentSearchUtils::findScriptSourceMapURL):
(WebCore::ContentSearchUtils::findStylesheetSourceMapURL):
Separate Script and Stylesheet regex pattern creation, but
share the search function using the pattern.

* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
Update function names. Check for the SourceMap header before
checking for a sourceMappingURL comment.

* inspector/InspectorPageAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
Provide the sourceMapURL for Page.getResourceTree.

* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForExtraResourceInfo):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
Include ExtraResourceInfo objects in finish loading and
request served from cache.

LayoutTests:

Test a different ways we would expect to see a sourceMapURL for
stylesheet resources.

Reviewed by NOBODY (OOPS!).

* http/tests/inspector/network/css-source-mapping-url-expected.txt: Added.
* http/tests/inspector/network/css-source-mapping-url.html: Added.
* http/tests/inspector/network/resources/source-map-test-style.css: Added.
* http/tests/inspector/network/resources/source-map-test-style.css.map: Added.
* http/tests/inspector/network/resources/source-map-test-style.scss: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename JSStringJoiner::build() to join()
benjamin@webkit.org [Fri, 19 Apr 2013 21:02:21 +0000 (21:02 +0000)]
Rename JSStringJoiner::build() to join()
https://bugs.webkit.org/show_bug.cgi?id=114845

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-19
Reviewed by Geoffrey Garen.

The method name build() came from StringBuilder history. It does not make much
sense on the StringJoiner.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::join):
* runtime/JSStringJoiner.h:
(JSStringJoiner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake StringImpl::cost const
benjamin@webkit.org [Fri, 19 Apr 2013 20:56:39 +0000 (20:56 +0000)]
Make StringImpl::cost const
https://bugs.webkit.org/show_bug.cgi?id=114790

Reviewed by Andreas Kling.

* wtf/text/StringImpl.h:
(WTF::StringImpl::cost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove non-overlap testing code in RenderLayerCompositor
shawnsingh@chromium.org [Fri, 19 Apr 2013 20:41:23 +0000 (20:41 +0000)]
Remove non-overlap testing code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=85521

Reviewed by Simon Fraser.

m_compositingConsultsOverlap is always true in the current
code. This patch removes this flag, and removes dead code that is
never executed because it was never false.

No new tests, no change in behavior.  The cleanup is covered by
existing tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
removed if-statement that is always true.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
removed if-statement that would never get triggered.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
removed m_compositingConsultsOverlap, and retained the code as if the flag were "true".

* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Find-on-page should do the scoping again when highlight policy changed
commit-queue@webkit.org [Fri, 19 Apr 2013 20:29:23 +0000 (20:29 +0000)]
[BlackBerry] Find-on-page should do the scoping again when highlight policy changed
https://bugs.webkit.org/show_bug.cgi?id=114885

Patch by Andy Chen <andchen@blackberry.com> on 2013-04-19
Reviewed by Rob Buis.

PR 195773
Internally reviewed by Mike Fenton.
For find on page, we need to treat it as a new search if highlightAllMatches
changes but the text is not changed.

* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. WebKit_Source is incorrectly set.
roger_fong@apple.com [Fri, 19 Apr 2013 20:14:35 +0000 (20:14 +0000)]
Unreviewed. WebKit_Source is incorrectly set.

* WTF.vcxproj/WTF.make:
* JavaScriptCore.vcxproj/JavaScriptCore.make:
* WebCore.vcxproj/WebCore.make:
* WebKit.vcxproj/WebKit.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake loops in RenderObject::containingBlock homogeneous in their forms to simplify
rniwa@webkit.org [Fri, 19 Apr 2013 19:58:08 +0000 (19:58 +0000)]
Make loops in RenderObject::containingBlock homogeneous in their forms to simplify
https://bugs.webkit.org/show_bug.cgi?id=114853

Reviewed by David Hyatt.

This patch prepares us to avoid computing containing blocks during a depth-first traversal of the render tree.

Extracted inline functions out of RenderBlock::containingBlock to make the code simpler. Also moved the code
to obtain the nearest containing block out of the loop for a relatively positioned inline.

* rendering/RenderObject.cpp:
(WebCore::isNonReplacedInlineInFlowPosition): Extracted.
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Extracted.
(WebCore::isNonRenderBlockInline): Extracted.
(WebCore::RenderObject::containingBlock): Refactored as stated above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit should not decode or support PDF favicons
timothy_horton@apple.com [Fri, 19 Apr 2013 19:45:22 +0000 (19:45 +0000)]
WebKit should not decode or support PDF favicons
https://bugs.webkit.org/show_bug.cgi?id=114650
<rdar://problem/10133914>

Reviewed by Dan Bernstein.

Drop the image data on the floor if it begins with the PDF magic number.
No other browser I can find on OS X supports PDF favicons (by experimentation),
and we do not properly display them.

* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the OpenVG backend
mrobinson@webkit.org [Fri, 19 Apr 2013 19:00:14 +0000 (19:00 +0000)]
Remove the OpenVG backend
https://bugs.webkit.org/show_bug.cgi?id=114881

Reviewed by Tim Horton.

* platform/graphics/FloatRect.h:
(FloatRect): Remove #ifdefs for OpenVG backend.
* platform/graphics/GraphicsContext.cpp:
(WebCore): Ditto.
* platform/graphics/GraphicsContext.h:
* platform/graphics/NativeImagePtr.h:
(WebCore): Ditto.
* platform/graphics/Path.cpp:
(WebCore): Ditto.
* platform/graphics/Path.h:
* platform/graphics/openvg/EGLDisplayOpenVG.cpp: Removed.
* platform/graphics/openvg/EGLDisplayOpenVG.h: Removed.
* platform/graphics/openvg/EGLUtils.h: Removed.
* platform/graphics/openvg/GraphicsContextOpenVG.cpp: Removed.
* platform/graphics/openvg/ImageOpenVG.cpp: Removed.
* platform/graphics/openvg/PainterOpenVG.cpp: Removed.
* platform/graphics/openvg/PainterOpenVG.h: Removed.
* platform/graphics/openvg/PathOpenVG.cpp: Removed.
* platform/graphics/openvg/PlatformPathOpenVG.h: Removed.
* platform/graphics/openvg/SharedResourceOpenVG.cpp: Removed.
* platform/graphics/openvg/SharedResourceOpenVG.h: Removed.
* platform/graphics/openvg/SurfaceOpenVG.cpp: Removed.
* platform/graphics/openvg/SurfaceOpenVG.h: Removed.
* platform/graphics/openvg/TiledImageOpenVG.cpp: Removed.
* platform/graphics/openvg/TiledImageOpenVG.h: Removed.
* platform/graphics/openvg/VGUtils.cpp: Removed.
* platform/graphics/openvg/VGUtils.h: Removed.
* platform/graphics/transforms/AffineTransform.h:
(AffineTransform): Ditto.
* platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix): Ditto.
* platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd JoinExistingSession to the WebContext XPC.
beidson@apple.com [Fri, 19 Apr 2013 18:12:40 +0000 (18:12 +0000)]
Add JoinExistingSession to the WebContext XPC.
<rdar://problem/13541540> and https://bugs.webkit.org/show_bug.cgi?id=114882

Reviewed by Sam Weinig.

This fixes <keygen> and maybe other things.

* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] JSCore.gir.in has a few problems
mrobinson@webkit.org [Fri, 19 Apr 2013 17:55:57 +0000 (17:55 +0000)]
[GTK] JSCore.gir.in has a few problems
https://bugs.webkit.org/show_bug.cgi?id=114710

Reviewed by Philippe Normand.

.:

* GNUmakefile.am: Move common GIR initialization here from WebKit1.
* configure.ac: Updated to reflect new JSC gir file location.

Source/JavaScriptCore:

* GNUmakefile.am: Add the gobject introspection steps for JavaScriptCore here,
because they are shared between WebKit1 and WebKit2.
* JavaScriptCore.gir.in: Added. Moved from the WebKit1 directory. Now written
as foreign interfaces and referencing the javascriptcoregtk library.

Source/WebKit/gtk:

* GNUmakefile.am: Updated to reflect new name and location of JavaScriptCore-x.0.gir.
* JSCore.gir.in: Removed.

Source/WebKit2:

* GNUmakefile.am: Updated to reflect new location of JavaScriptCore gir file. Share the
same autotools data task as the WebKit1 and JavaScriptCore gir installations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoContainerNode::removeChildren should first detach the children then remove them
abucur@adobe.com [Fri, 19 Apr 2013 17:25:54 +0000 (17:25 +0000)]
ContainerNode::removeChildren should first detach the children then remove them
https://bugs.webkit.org/show_bug.cgi?id=113433

Reviewed by Ryosuke Niwa.

Currently, ContainerNode::removeChildren initially removes the nodes from the DOM tree and then
calls detach() on each of them. This is anti-intuitive and can lead to subtle bugs because the
detached renderers are not backed by a valid DOM tree any more. With the patch, the nodes are first
detached and then removed from the DOM.
The patch also lets the tree in a consistent state after each node removal by clearing the previous
sibling pointer of the node following the one removed.
I haven't found any proof the performance will get worse if the detachment happens when the children
are still in the DOM tree.

Tests: No changed visible functionality.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor transform code in StyleResolver
krit@webkit.org [Fri, 19 Apr 2013 17:17:42 +0000 (17:17 +0000)]
Refactor transform code in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=114874

Reviewed by Andreas Kling.

Move transform code frome StyleResolver into own files.

Refactoring, no changes in functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
* css/StyleResolver.h:
* css/TransformFunctions.cpp: Added.
(WebCore):
(WebCore::transformOperationType):
(WebCore::convertToFloatLength):
(WebCore::transformsForValue):
* css/TransformFunctions.h: Added.
(WebCore):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename TextTrackList owner to element for consistency
arv@chromium.org [Fri, 19 Apr 2013 17:03:36 +0000 (17:03 +0000)]
Rename TextTrackList owner to element for consistency
https://bugs.webkit.org/show_bug.cgi?id=79822

Reviewed by Eric Carlson.

No new tests. Covered by existing tests.

* bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):
(WebCore::JSTextTrackList::visitChildren):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
* html/track/TextTrackList.cpp:
(TextTrackList::append):
(TextTrackList::remove):
* html/track/TextTrackList.h:
(WebCore::TextTrackList::create):
* html/track/TrackListBase.cpp:
(TrackListBase::TrackListBase):
(TrackListBase::remove):
* html/track/TrackListBase.h:
(WebCore::TrackListBase::clearElement):
(WebCore::TrackListBase::element):
(TrackListBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed Gardening.
sudarsana.nagineni@linux.intel.com [Fri, 19 Apr 2013 16:40:17 +0000 (16:40 +0000)]
[EFL] Unreviewed Gardening.

* platform/efl/TestExpectations: Adding failure expectations for two tests
which are failing on EFL bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] ComplexTextController is slow with large numbers of text runs.
akling@apple.com [Fri, 19 Apr 2013 16:17:42 +0000 (16:17 +0000)]
[Mac] ComplexTextController is slow with large numbers of text runs.
<http://webkit.org/b/114875>
<rdar://problem/13337036>

Reviewed by Dan Bernstein.

Instead of iterating over the text runs in indexOfCurrentRun() to figure out the leftmost glyph,
create a lookup table of [run# -> distance in glyphs] at ComplexTextController construction time.

This avoids O(n^2) behavior in indexOfCurrentRun().

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::indexOfCurrentRun):
* platform/graphics/mac/ComplexTextController.h:
(ComplexTextController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Minimize calls to GailTextUtil in AtkText implementation
commit-queue@webkit.org [Fri, 19 Apr 2013 16:03:46 +0000 (16:03 +0000)]
[GTK] Minimize calls to GailTextUtil in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=114868

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-04-19
Reviewed by Martin Robinson.

Create a new helper function to concentrate inside of it the calls to
gail_text_util_get_text(), so we can get rid of it later more easily.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): New helper function.
(webkitAccessibleTextGetTextAfterOffset): Rely on the new function.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] Implementation for pattern compositing
commit-queue@webkit.org [Fri, 19 Apr 2013 16:01:25 +0000 (16:01 +0000)]
[Texmap] Implementation for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=109588

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-19
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Enable pattern compositing (background images) for CoordinatedGraphics/TextureMapperGL.
Use the existing patternTransform shader uniform, multiplying it by a matrix calculated
using the contentsRect, tileSize and tilePhase.

Covered by existing tests in compositing/patterns.

* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
    Conditionally enable pattern compositing for coordinated graphics.

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::TextureMapper):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setPatternTransform):
(WebCore::TextureMapper::setWrapMode):
(WebCore::TextureMapper::wrapMode):
(WebCore::TextureMapper::patternTransform):
    Add wrapMode and patternTransform properties to the TextureMapper state.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
    Paint with GL_REPEAT and a pattern transform when needed.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::setContentsRect):
(WebCore::TextureMapperLayer::setContentsTileSize):
(WebCore::TextureMapperLayer::setContentsTilePhase):
    Apply the patternTransform from the tile size/phase.

* platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setShouldMapBackingStoreToContentsRect):
(State):
(WebCore::TextureMapperLayer::State::State):
    Allow the client to configure whether a layer uses its bounds or its
    contents rect to paint the backing store.
    This is needed now since layers with background images, unlike layers
    with regular images, may have bounds that are greater than the contents
    rect.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsTileSize):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::setContentsTilePhase):
(WebCore::CoordinatedGraphicsLayer::setShouldSupportContentsTiling):
(WebCore::GraphicsLayer::supportsContentsTiling):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
    Logic to pass the tileSize/tilePhase from CoordinatedGraphicsLayer
    to TextureMapperLayer.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
    Don't reset the layer's image contents when this is a directly composited image.

Source/WebKit2:

Serialize the two new properties from CoordinatedGraphicsLayer to CoordinatedGraphicsScene.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
    Encode/decode the new tiling properties.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
    Enable pattern compositing for coordinated graphics.
    This is needed since we don't want to enable pattern compositing for
    WebKit1 yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed Gardening.
sudarsana.nagineni@linux.intel.com [Fri, 19 Apr 2013 15:34:53 +0000 (15:34 +0000)]
[EFL] Unreviewed Gardening.

Marking compositing reftests added in r148172 as ImageOnlyFailure.
Also, skip failing tests on EFL bots.

* platform/efl/TestExpectations:
* platform/efl/compositing/geometry/foreground-layer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix expectations added in r148720.
jberlin@webkit.org [Fri, 19 Apr 2013 15:21:49 +0000 (15:21 +0000)]
Fix expectations added in r148720.

* fast/js/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Make the 32 bits bot only build and run API tests
kov@webkit.org [Fri, 19 Apr 2013 14:53:48 +0000 (14:53 +0000)]
[GTK] Make the 32 bits bot only build and run API tests
https://bugs.webkit.org/show_bug.cgi?id=113532

Reviewed by Martin Robinson.

* BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
moment;
(BuildAndAPITestFactory.__init__): add API tests step for platforms that have it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Only use thin archives on Linux
abecsi@webkit.org [Fri, 19 Apr 2013 14:32:51 +0000 (14:32 +0000)]
[Qt] Only use thin archives on Linux

Rubber-stamped by Jocelyn Turcotte.

Since "thin archive" is a feature of GNU's ar
we limit the usage to Linux to avoid problems
with other configurations (eg. macx-g++).

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] Manage actor's children by using clutter's own way.
commit-queue@webkit.org [Fri, 19 Apr 2013 13:54:27 +0000 (13:54 +0000)]
[GTK][AC] Manage actor's children by using clutter's own way.
https://bugs.webkit.org/show_bug.cgi?id=114257

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-19
Reviewed by Gustavo Noronha Silva.

I believe we don't need to maintain a children list of GList. We can do it
by using clutter APIs like clutter_actor_get_children, clutter_actor_get_first_child, etc.

No new tests since no functionality changed.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphics_layer_actor_init):
(graphicsLayerActorAllocate):
(graphicsLayerActorPaint):
(graphicsLayerActorRemoveAll):
(graphicsLayerActorGetnChildren):
(graphicsLayerActorReplaceSublayer):
(graphicsLayerActorInsertSublayer):
* platform/graphics/clutter/GraphicsLayerActor.h:
(_GraphicsLayerActor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] Support masksToBounds for clutter AC backend.
commit-queue@webkit.org [Fri, 19 Apr 2013 13:51:10 +0000 (13:51 +0000)]
[GTK][AC] Support masksToBounds for clutter AC backend.
https://bugs.webkit.org/show_bug.cgi?id=114113

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-19
Reviewed by Gustavo Noronha Silva.

We can support the masksToBounds property by using clutter_actor_set_clip simply.

Covered by existing AC tests.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetMasksToBounds):
* platform/graphics/clutter/GraphicsLayerActor.h:
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setMasksToBounds):
(WebCore):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateMasksToBounds):
* platform/graphics/clutter/GraphicsLayerClutter.h:
(GraphicsLayerClutter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148742 268f45cc-cd09-0410-ab3c-d52691b4dbfc