rniwa@webkit.org [Tue, 24 Jul 2012 13:40:52 +0000 (13:40 +0000)]
Add some Japanese and Swedish websites to replay tests
https://bugs.webkit.org/show_bug.cgi?id=92076
Reviewed by Andreas Kling.
Added new replay tests as follows.
* Replay/Japanese: Added.
* Replay/Japanese/2ch.net-newsplus.replay: Added.
* Replay/Japanese/ja.wikipedia.org.replay: Added.
* Replay/Japanese/www.livedoor.com.replay: Added.
* Replay/Japanese/www.rakuten.co.jp.replay: Added.
* Replay/Japanese/www.yahoo.co.jp.replay: Added.
* Replay/Swedish: Added.
* Replay/Swedish/www.flashback.se.replay: Added.
* Replay/Swedish/www.tradera.com.replay: Added.
* Replay/www.techcrunch.com.replay: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
allan.jensen@nokia.com [Tue, 24 Jul 2012 13:37:43 +0000 (13:37 +0000)]
Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398
Reviewed by Nikolas Zimmermann.
To support auto-vectorizing, the loop had to be unswitched, and regular arrays used that
did not do boundary-checks in the inner loop. Finally the integer division by 255
was optimized not use integer division intrinsics.
On a X86-64 architechture using GCC -O3 on the file, this gives a speed-up of 2.9x.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::fastDivideBy255):
(BlendNormal):
(WebCore::BlendNormal::apply):
(BlendMultiply):
(WebCore::BlendMultiply::apply):
(BlendScreen):
(WebCore::BlendScreen::apply):
(BlendDarken):
(WebCore::BlendDarken::apply):
(BlendLighten):
(WebCore::BlendLighten::apply):
(BlendUnknown):
(WebCore::BlendUnknown::apply):
(WebCore::platformApply):
(WebCore::FEBlend::platformApplyGeneric):
(WebCore::FEBlend::platformApplySoftware):
* platform/graphics/filters/FEBlend.h:
(FEBlend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 13:33:57 +0000 (13:33 +0000)]
[Qt] Unreviewed gardening. Update expectations after r122988 and r122712.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-24
* platform/qt-5.0-wk2/editing/deleting/
5144139-2-expected.txt: Added after r122712.
* platform/qt-5.0/editing/deleting/
5144139-2-expected.txt: Removed.
* platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.png: Added after r122988.
* platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.txt: Added after r122988.
* platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added after r122988.
* platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added after r122988.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 24 Jul 2012 13:24:30 +0000 (13:24 +0000)]
[Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
https://bugs.webkit.org/show_bug.cgi?id=91229
Reviewed by Jocelyn Turcotte.
In order to successfully link a DLL on Windows we need to have at least
one object file (or compilation unit). The forward export header files were
supposed to be that, but unfortunately the rule in win32/default_post.prf for
creating the header files had some bugs, among others that it did an exists()
check on the depending static library. At the time qmake is ran those libraries
do not exist yet and therefore the corresponding extra compiler rules were never
created, resulting in empty OBJECTS/SOURCES.
Even without such an exists() check, qmake extra compilers require the files
referred to in the .input variable to exist at qmake time. In this case the input
files were the static libraries, which do not exist yet.
This patch solves this by using a qmake extra target instead of extra
compiler, which does not have this limitation. The target is referenced
through the extension of GENERATED_SOURCES.
The patch also adds a d/_debug suffix for debug builds, do allow for separate
symbol exports if necessary.
* Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
consider the last argument to be the output file and everything else input.
* qmake/mkspecs/features/win32/default_post.prf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 24 Jul 2012 13:14:46 +0000 (13:14 +0000)]
[Qt] Add quirks for running the web process in a profiler shell, like valgrind
https://bugs.webkit.org/show_bug.cgi?id=87672
Reviewed by Jocelyn Turcotte.
Source/WebKit2:
If environment variables QT_WEBKIT_WEB_PROCESS_COMMAND_PREFIX
and/or QT_WEBKIT_PLUGIN_PROCESS_COMMAND_PREFIX are set, use their
values as the prefix of the command when launching the child process.
Example usage:
export QT_WEB_PROCESS_COMMAND_PREFIX="valgrind --smc-check=all"
./MiniBrowser http://somepage.html
./WebKitTestRunner --no-timeout-at-all some_layouttest.html
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
Tools:
Add --no-timeout-at-all command line switch to not time out no matter how
long the web process does it's job. --no-timeout is not enough for profiling
purposes because it only affects the timeout when we are waiting for the end
of the test. We use another timeout to control how much we wait for the web
process to initialize before and reset after the test and it could also easily
expire when running under valgrind. We should keep the behavior of --no-timeout
to not disable this timout check because --no-timeout is used by performace tests
and those should not wait for the web process to initialize and reset more than
normal tests.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runUntil):
* WebKitTestRunner/TestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Tue, 24 Jul 2012 12:38:02 +0000 (12:38 +0000)]
[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092
Reviewed by Kent Tamura.
Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.
* src/WebPagePopupImpl.h:
(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 24 Jul 2012 12:26:48 +0000 (12:26 +0000)]
[Qt] fast/css/text-transform-select.html should be rebaselined for WK1 and WK2 on Qt 5.0
https://bugs.webkit.org/show_bug.cgi?id=77377
Reviewed by Simon Hausmann.
Test now pass in both WK1 and WK2.
* platform/qt-5.0/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Tue, 24 Jul 2012 12:25:13 +0000 (12:25 +0000)]
Speech JavaScript API: Add the SpeechRecognitionResult.emma attribute
https://bugs.webkit.org/show_bug.cgi?id=91743
Reviewed by Adam Barth.
Source/WebCore:
Implement the 'emma' attribute as described in the spec draft at
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html
Test: fast/speech/scripted/emma.html
* Modules/speech/SpeechRecognitionResult.cpp:
(WebCore::SpeechRecognitionResult::~SpeechRecognitionResult):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):
* Modules/speech/SpeechRecognitionResult.h:
(WebCore):
(SpeechRecognitionResult):
* Modules/speech/SpeechRecognitionResult.idl:
* WebCore.gypi:
* bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:
(WebCore):
(WebCore::V8SpeechRecognitionResult::visitDOMWrapper):
We need to add an implicit reference from the result object to the
emma object to keep the latters DOM tree alive across
garbage-collection.
LayoutTests:
Add layout test for the SpeechRecognitionResult.emma attribute.
* fast/speech/scripted/emma.html: Added.
* fast/speech/scripted/emma-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 24 Jul 2012 12:09:49 +0000 (12:09 +0000)]
Unreviewed GTK gardening.
Skipping tests added in r123343 and adding a test expectation for
an accessibility test added in r123428.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 12:00:33 +0000 (12:00 +0000)]
Web Inspector: Protocol Extension: add getFlowByName command
https://bugs.webkit.org/show_bug.cgi?id=91855
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-24
Reviewed by Pavel Feldman.
Source/WebCore:
The "getFlowByName" command should return a NamedFlow for a given document and name.
Test: inspector/styles/protocol-css-regions-commands.html
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayload):
LayoutTests:
Created a single test suite for the WebInspector protocol extension for CSS Regions.
* inspector/styles/protocol-css-regions-commands-expected.txt: Added.
* inspector/styles/protocol-css-regions-commands.html: Added.
* inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Removed.
* inspector/styles/protocol-getNamedFlowCollection-command.html: Removed.
* platform/efl/TestExpectations:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Tue, 24 Jul 2012 11:48:20 +0000 (11:48 +0000)]
[Qt][WK1] color input type support
https://bugs.webkit.org/show_bug.cgi?id=91998
Reviewed by Simon Hausmann.
Using QColorDialog. This is private for now, but
it could be exposed via a virtual function in
QWebPage at a later point in a Qt 5 minor release
if there are requests for that.
* Api/qwebpage.cpp:
(QWebPagePrivate::colorSelectionRequested):
* Api/qwebpage_p.h:
(QWebPagePrivate):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createColorChooser):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Tue, 24 Jul 2012 11:37:15 +0000 (11:37 +0000)]
[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
https://bugs.webkit.org/show_bug.cgi?id=92097
Unreviewed build fix.
WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
but TestDelegate.h forward declares it as a class.
* DumpRenderTree/chromium/TestRunner/TestDelegate.h:
(WebKit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 24 Jul 2012 11:33:43 +0000 (11:33 +0000)]
[Qt] Fix compilation against namespaced Qt
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-23
Reviewed by Simon Hausmann.
Source/WebCore:
* platform/graphics/Font.h:
* platform/network/ResourceHandleInternal.h:
* platform/qt/ThirdPartyCookiesQt.h:
Source/WebKit/qt:
* WebCoreSupport/GeolocationClientQt.h:
* examples/platformplugin/WebPlugin.h:
Source/WebKit2:
* Platform/CoreIPC/Connection.h:
* Platform/PlatformProcessIdentifier.h:
* Platform/WorkQueue.h:
* Shared/qt/QtNetworkRequestData.h:
* Shared/qt/WebEventFactoryQt.h:
* UIProcess/API/C/qt/WKNativeEvent.h:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/raw/qrawwebview_p.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/Launcher/ThreadLauncher.h:
* UIProcess/LayerTreeCoordinatorProxy.h:
* UIProcess/qt/QtViewportHandler.h:
* UIProcess/qt/QtWebPageSGNode.h:
* UIProcess/qt/WebColorChooserProxyQt.h:
* UIProcess/qt/WebGeolocationProviderQt.h:
* UIProcess/qt/WebPopupMenuProxyQt.h:
* WebProcess/WebProcess.h:
Tools:
* QtTestBrowser/launcherwindow.h:
* WebKitTestRunner/PlatformWebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Tue, 24 Jul 2012 11:23:03 +0000 (11:23 +0000)]
Update a few Chromium Android contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=92090
Reviewed by Kent Tamura.
Add Sami Kyostila, who has been doing significant work on Chromium's
compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
remove John Grabowski who changed projects, and add my webkit.org alias.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 11:18:12 +0000 (11:18 +0000)]
[EFL][WK2] Remove unneeded WebURLRequestEfl and WebURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=92087
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.
Remove WebURLRequestEfl and WebURLResponseEfl classes
and their corresponding C APIs since we don't need / use
them.
* Shared/API/c/efl/WKURLRequestEfl.cpp: Removed.
* Shared/API/c/efl/WKURLRequestEfl.h: Removed.
* Shared/API/c/efl/WKURLResponseEfl.cpp: Removed.
* Shared/API/c/efl/WKURLResponseEfl.h: Removed.
* Shared/efl/WebURLRequestEfl.cpp: Removed.
* Shared/efl/WebURLRequestEfl.h: Removed.
* Shared/efl/WebURLResponseEfl.cpp: Removed.
* Shared/efl/WebURLResponseEfl.h: Removed.
* UIProcess/API/efl/ewk_url_request.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Tue, 24 Jul 2012 11:08:39 +0000 (11:08 +0000)]
[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013
Reviewed by Kenneth Rohde Christiansen.
TOUCH_SLIDER guards are used in WebCore, so we should really
be setting the corresponding ENABLE define in features.prf.
Source/WebKit2:
* Target.pri:
Tools:
* qmake/mkspecs/features/features.prf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 10:33:10 +0000 (10:33 +0000)]
Web Inspector [JSC]: Enable initiator column in network panel.
https://bugs.webkit.org/show_bug.cgi?id=65533
Patch by Anthony Scian <ascian@rim.com> on 2012-07-24
Reviewed by Vsevolod Vlasov.
Source/WebCore:
With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.
Test: http/tests/inspector/network/network-initiator.html
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
* inspector/front-end/Settings.js:
Source/WebKit/chromium:
With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.
Test: http/tests/inspector/network/network-initiator.html
* src/js/DevTools.js:
LayoutTests:
Bug https://bugs.webkit.org/show_bug.cgi?id=65105 caused
network-initiator.html to be disabled due to caching CSS information.
Tweaked the test so that reloads could be forced to avoid the cache
copy (thanks to Vsevolod Vlasov for help on this); test works now and
is updated for availability of stack traces fixed in 40118. Consolidated
results into common expected results output.
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.hardReloadPage):
(initialize_InspectorTest.InspectorTest.reloadPage):
(initialize_InspectorTest.InspectorTest._innerReloadPage):
* http/tests/inspector/network/network-initiator-expected.txt:
* http/tests/inspector/network/network-initiator.html:
* platform/chromium/TestExpectations:
* platform/chromium/http/tests/inspector/network/network-initiated-expected.txt: Removed.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 24 Jul 2012 10:27:51 +0000 (10:27 +0000)]
Missing *explicit* keyword in dom and page.
https://bugs.webkit.org/show_bug.cgi?id=92074
Reviewed by Kentaro Hara.
Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.
Some files in dom directory can't use explicit keyword because of build breaks.
No new tests. Covered by existing tests.
* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
* dom/BeforeTextInsertedEvent.h:
(BeforeTextInsertedEvent):
* dom/ChildListMutationScope.h:
(WebCore::ChildListMutationScope::ChildListMutationScope):
* dom/ChildNodeList.h:
(ChildNodeList):
* dom/ClientRect.h:
(ClientRect):
* dom/ClientRectList.h:
(ClientRectList):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeParentWalker):
* dom/DOMCoreException.h:
(WebCore::DOMCoreException::DOMCoreException):
* dom/DOMImplementation.h:
(DOMImplementation):
* dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):
* dom/DeviceMotionController.h:
(DeviceMotionController):
* dom/DeviceOrientationController.h:
(DeviceOrientationController):
* dom/DocumentParser.h:
(DocumentParser):
* dom/EventException.h:
(WebCore::EventException::EventException):
* dom/EventListener.h:
(WebCore::EventListener::EventListener):
* dom/ExceptionBase.h:
(ExceptionBase):
* dom/GenericEventQueue.h:
(GenericEventQueue):
* dom/KeyboardEvent.h:
(WebCore::KeypressCommand::KeypressCommand):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
* dom/MessageChannel.h:
(MessageChannel):
* dom/MessagePort.h:
(MessagePort):
* dom/MessagePortChannel.h:
(MessagePortChannel):
* dom/MutationObserver.h:
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::NamedNodeMap):
* dom/NodeFilter.h:
(WebCore::NodeFilter::NodeFilter):
* dom/NodeWithIndex.h:
(WebCore::NodeWithIndex::NodeWithIndex):
* dom/Range.h:
* dom/RangeException.h:
(WebCore::RangeException::RangeException):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::RawDataDocumentParser):
* dom/ScriptRunner.h:
(ScriptRunner):
* dom/SelectorQuery.h:
(SelectorQuery):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/SpaceSplitString.h:
(SpaceSplitStringData):
* dom/StaticHashSetNodeList.h:
(StaticHashSetNodeList):
* dom/StaticNodeList.h:
(WebCore::StaticNodeList::StaticNodeList):
* dom/TransformSource.h:
(TransformSource):
* dom/TreeScope.h:
(TreeScope):
* dom/WebKitNamedFlowCollection.h:
(WebKitNamedFlowCollection):
* page/EventHandler.h:
(EventHandler):
* page/FocusController.h:
(FocusController):
* page/FrameView.h:
(FrameView):
* page/MemoryInfo.h:
(MemoryInfo):
* page/Page.h:
(Page):
* page/PageGroup.h:
(PageGroup):
* page/PrintContext.h:
(PrintContext):
* page/Settings.h:
(Settings):
* page/SpeechInput.h:
(SpeechInput):
* page/SpeechInputResultList.h:
(SpeechInputResultList):
* page/WebKitAnimation.h:
* page/WindowFeatures.h:
(WindowFeatures):
* page/WorkerNavigator.h:
(WorkerNavigator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 24 Jul 2012 10:27:07 +0000 (10:27 +0000)]
[EFL] EWebLauncher should not require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=92070
Reviewed by Kentaro Hara.
* Scripts/webkitpy/style/checker.py:
Remove the include rules from the style-check for EWebLauncher because
EWebLauncher is simple EFL application.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.or [Tue, 24 Jul 2012 10:23:54 +0000 (10:23 +0000)]
[Chromium] EventSender shouldn't know about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91449
Reviewed by Adam Barth.
Original patch by Adam Barth.
This patch removes the dependency from EventSender to TestShell. Most
of EventSender works directly with a WebView, but there are a handful
of references to WebViewHost. We don't want to re-use WebViewHost in
ContentShell because we want to use the multi-process embedding
environment for WebViews.
To avoid the dependency on WebViewHost, this patch introduces
TestDelegate, which is an abstract base class for WebViewHost. In
ContentShell, we'll need another object to implement these functions.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::keyDown):
(makeMenuItemStringsFor):
(EventSender::contextClick):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):
(EventSender::setDelegate):
(EventSender::setWebView):
(EventSender::webview):
* DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
(WebKit):
(TestDelegate):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::fillSpellingSuggestionList):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 24 Jul 2012 09:50:56 +0000 (09:50 +0000)]
[Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-losing-renderer-on-click.html to fast/forms/resources
https://bugs.webkit.org/show_bug.cgi?id=92083
Reviewed by Kent Tamura.
This patch copies two test HTML files in fast/forms/number into JavaScript code directory,
fast/forms/resources:
- number-change-type-on-focus.html -> common-change-type-on-focus.js
- number-losing-renderer-on-click.html -> common-losing-renderer-on-click.js
* fast/forms/resources/common-change-type-on-focus.js: Copied from LayoutTests/fast/forms/number/number-change-type-on-focus.html.
* fast/forms/resources/common-losing-renderer-on-click.js: Copied from LayoutTests/fast/forms/number/number-losing-renderer-on-click.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 09:48:20 +0000 (09:48 +0000)]
Make WebIntents and WebIntentsTag a build option for the build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=91841
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-24
Reviewed by Philippe Normand.
And it will also be disabled when building with --minimal.
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 24 Jul 2012 09:38:13 +0000 (09:38 +0000)]
[Tests] Rename fast/forms/number/number-crash.html to number-losing-renderer-on-click.html
https://bugs.webkit.org/show_bug.cgi?id=92085
Reviewed by Kent Tamura.
This patch renames test file fast/forms/number/number-crash.html to number-losing-renderer-on-click.html
to make test name denotes what test will be done.
* fast/forms/number/number-crash-expected.txt: Removed.
* fast/forms/number/number-crash.html: Removed.
* fast/forms/number/number-losing-renderer-on-click-expected.txt: Copied from LayoutTests/fast/forms/number/number-crash-expected.txt.
* fast/forms/number/number-losing-renderer-on-click.html: Copied from LayoutTests/fast/forms/number/number-crash.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Tue, 24 Jul 2012 09:25:06 +0000 (09:25 +0000)]
Unreviewed. Rolled DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 09:21:37 +0000 (09:21 +0000)]
[EFL][WK2] Fix possible crash in didSendRequestForResource
https://bugs.webkit.org/show_bug.cgi?id=92077
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.
Add NULL check for wkRedirectResponse in
didSendRequestForResource() before using it. The
argument may be NULL if there was no redirection.
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_resource_load_client.cpp:
(didSendRequestForResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 24 Jul 2012 09:17:30 +0000 (09:17 +0000)]
Replace some callsites of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=92060
Reviewed by Hajime Morita.
shadowAncestorNode() is deprecated.
No new tests. This shouldn't change behaviors.
* html/shadow/MediaControlElements.cpp:
(WebCore::toParentMediaElement):
* html/shadow/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::isReadOnlyFormControl):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
(WebCore::centerRectVerticallyInParentInputElement):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
Removed an ASSERT() because nullness of o->node() is already asserted.
* rendering/RenderInputSpeech.cpp:
(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSliderThumb):
Passing shadowHost() to toParentMediaElement(), which accepts 0 and will return 0.
(WebCore::paintMediaVolumeSliderThumb): ditto.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
Remove an ASSERT(input) because input never be null unless o->node() is
null. If o->node() is null, this function crashes.
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
It's ok to ignore "node is a media element" case because this function
works only if node->isMediaControlElement().
(WebCore::RenderThemeMac::paintMediaPlayButton): ditto.
(WebCore::RenderThemeMac::paintMediaSliderTrack): ditto.
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
Remove an ASSERT(input) because input never be null unless o->node() is
null. If o->node() is null, this function crashes.
(WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): ditto.
(WebCore::RenderThemeSafari::paintSearchFieldResultsButton): ditto.
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 09:13:23 +0000 (09:13 +0000)]
[WK2][EFL][GTK] Share WebCoreArgumentCoders for soup-related types
https://bugs.webkit.org/show_bug.cgi?id=92073
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.
Move WebCoreArgumentCoders for soup-related types such as
ResourceRequest, ResourceResponse and ResourceError from
port specific file to Shared/soup/WebCoreArgumentCodersSoup.cpp.
This way, the different ports using libsoup can share
code and avoid duplication.
* GNUmakefile.list.am:
* PlatformEfl.cmake:
* Shared/efl/WebCoreArgumentCodersEfl.cpp: Removed.
* Shared/soup/WebCoreArgumentCodersSoup.cpp: Renamed from Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp.
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 09:09:18 +0000 (09:09 +0000)]
[Qt] Unreviewed gardening after r123379. Newly added fast/css/sticky/parsing-position-sticky.html fails.
https://bugs.webkit.org/show_bug.cgi?id=92080
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Tue, 24 Jul 2012 08:55:18 +0000 (08:55 +0000)]
[Chromium] Build fix for Android after r123424
https://bugs.webkit.org/show_bug.cgi?id=92082
Unreviewed build fix.
Mark removed the PlatformSupport.h header from ScrollbarThemeChromiumAndroid.cpp
in r123424, while there still are two references left to another method and a
constant. Re-add the include directive.
* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 24 Jul 2012 08:44:58 +0000 (08:44 +0000)]
[JSC] REGRESSION(r122912): CodeGeneratorJS.pm generates wrong code
for static attributes in supplemental IDL files
https://bugs.webkit.org/show_bug.cgi?id=91925
Reviewed by Adam Barth.
r122912 implemented static attributes in CodeGeneratorJS.pm.
However, it generates wrong code for static attributes in supplemental
IDL files. This patch fixes it as shown in JSTestInterface.cpp.
This fix aligns with the fix in CodeGeneratorV8.pm (r123308).
Test: bindings/scripts/test/TestSupplemental.idl
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 24 Jul 2012 08:42:45 +0000 (08:42 +0000)]
Add *explicit* keyword to constructor which has a parameter in bridge, history, loader and plugins.
https://bugs.webkit.org/show_bug.cgi?id=92064
Reviewed by Kentaro Hara.
Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.
No new tests. Covered by existing tests.
* bridge/IdentifierRep.h:
(WebCore::IdentifierRep::IdentifierRep):
* history/BackForwardListImpl.h:
(BackForwardListImpl):
* history/CachedFrame.h:
(CachedFrame):
* history/HistoryItem.h:
(HistoryItem):
* loader/DocumentWriter.h:
(DocumentWriter):
* loader/FrameNetworkingContext.h:
(WebCore::FrameNetworkingContext::FrameNetworkingContext):
* loader/HistoryController.h:
* loader/ImageLoader.h:
(ImageLoader):
* loader/LinkLoader.h:
(LinkLoader):
* loader/MainResourceLoader.h:
(MainResourceLoader):
* loader/NavigationAction.h:
(NavigationAction):
* loader/NavigationScheduler.h:
(NavigationScheduler):
* loader/PolicyChecker.h:
(PolicyChecker):
* loader/SubframeLoader.h:
(SubframeLoader):
* loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
* plugins/PluginData.h:
(PluginData):
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::PluginViewBase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 08:24:35 +0000 (08:24 +0000)]
[Qt] Unreview gardening.
Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-24
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 08:21:32 +0000 (08:21 +0000)]
[Qt] Unreviewed gardening. Skipped a test because of a missing feature.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 24 Jul 2012 08:02:24 +0000 (08:02 +0000)]
[Qt] Fix conversion from GregorianDateTime to QTime
https://bugs.webkit.org/show_bug.cgi?id=92068
Reviewed by Simon Hausmann.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
* bridge/qt/qt_runtime_qt4.cpp:
(JSC::Bindings::convertValueToQVariant):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arko@motorola.com [Tue, 24 Jul 2012 07:37:44 +0000 (07:37 +0000)]
Microdata: Implement PropertyNodeList interface.
https://bugs.webkit.org/show_bug.cgi?id=80269
Reviewed by Ryosuke Niwa.
Source/WebCore:
Added support for PropertyNodeList interface. Currently HTMLPropertiesCollection.namedItem(name)
returns NodeList object. Made changes so that it will return PropertyNodeList object.
Implemented propertyNodeList.getValues() method. It returns an array of various values. Its
values are obtained from the "itemValue" DOM property of each of the elements represented by
the object, in tree order.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#propertynodelist
Tests: fast/dom/MicroData/nameditem-returns-propertynodelist.html
fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html
fast/dom/MicroData/propertynodelist-getvalues-test.html
fast/dom/MicroData/propertynodelist-test-add-remove-element.html
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSMicroDataItemValueCustom.cpp: Added.
(WebCore):
(WebCore::toJS): Added toJS() custom method. Returns Node if itemValue is node else returns String.
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp: Added.
(WebCore):
(WebCore::toV8): Added toV8 custom code.
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::rootNode): Return document if owner node has itemref attribute specified.
(WebCore):
(WebCore::DynamicNodeListCacheBase::ownerNodeHasItemRefAttribute): Returns true if owner node has itemref attribute
specified with root type NodeListRootedAtDocumentIfOwnerHasItemrefAttr.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::itemWithName): Update itemrefElements cache if root type is
NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.
* dom/DynamicNodeList.h: Added m_hasItemRefElements in DynamicNodeListCacheBase to check if itemRefElmenets cache
is valid.
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument):
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isItemRefElementsCacheValid):
(WebCore::DynamicNodeListCacheBase::setItemRefElementsCacheValid):
(WebCore::DynamicNodeListCacheBase::rootType): Returns cached root type.
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Invalidate NodeListCache on itemref
attribute change.
* dom/Node.cpp:
(WebCore::Node::propertyNodeList):
* dom/Node.h:
(WebCore):
(Node):
* dom/PropertyNodeList.cpp: Added.
(WebCore):
(WebCore::PropertyNodeList::PropertyNodeList):
(WebCore::PropertyNodeList::~PropertyNodeList):
(WebCore::PropertyNodeList::elementIsPropertyOfRefElement): Checks if the testElement is a property of Microdata
item.
(WebCore::PropertyNodeList::updateRefElements):
(WebCore::PropertyNodeList::nodeMatches):
(WebCore::PropertyNodeList::getValues): Returns PropertyValueArray whose values are obtained from the
itemValue DOM property of each of the elements represented by the object, in tree order.
* dom/PropertyNodeList.h: Added.
(WebCore):
(PropertyNodeList):
(WebCore::PropertyNodeList::create):
* dom/PropertyNodeList.idl: Added.
* html/HTMLCollection.cpp:
(WebCore::DynamicNodeListCacheBase::itemCommon): Update itemrefElements cache if its a NodeListCollectionType with
root type NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::properties):
(WebCore):
(WebCore::HTMLElement::getItemRefElements): Returns the ItemRefElements list of given element. Added this
method to share the code between HTMLPropertiesCollection and PropertyNodeList to update itemRefElements.
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::updateNameCache):
(WebCore::HTMLPropertiesCollection::namedItem): Return PropertyNodeList object instead of NodeList.
(WebCore::HTMLPropertiesCollection::hasNamedItem): Return true if it finds an item with given
name in the properties collection.
* html/HTMLPropertiesCollection.h: Removed m_hasItemRefElements member variable, now DynamicNodeListCacheBase
has isItemRefElementsCacheValid. Also removed m_hasPropertyNameCache, as DynamicNodeListCacheBase already has
hasNameCache() and setHasNameCache().
(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCache):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):
* html/HTMLPropertiesCollection.idl:
* html/MicroDataItemValue.idl: Added.
* page/DOMWindow.idl:
LayoutTests:
Added test cases for PropertyNodeList interface and PropertyNodeList.getValues() method.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#propertynodelist
* fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Added.
* fast/dom/MicroData/nameditem-returns-propertynodelist.html: Added.
* fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Added.
* fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Added.
* fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Added.
* fast/dom/MicroData/propertynodelist-getvalues-test.html: Added.
* fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Added.
* fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 24 Jul 2012 07:21:25 +0000 (07:21 +0000)]
[JSC] REGRESSION(r122912): CodeGeneratorJS.pm should not
implicitly assume ScriptExecutionContext for static attributes
https://bugs.webkit.org/show_bug.cgi?id=91924
Reviewed by Adam Barth.
r122912 implemented static attributes in CodeGeneratorJS.pm.
However, the generated code assumes that static attributes
always require ScriptExecutionContext, which is wrong.
If we need a ScriptExecutionContext, we should specify
[CallWith=ScriptExecutionContext].
This patch fixes CodeGeneratorJS.pm so that static attributes
do not assume ScriptExecutionContext. This fix aligns with
the fix in CodeGeneratorV8.pm in r123308.
Test: bindings/scripts/test/TestObj.idl
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorStaticReadOnlyIntAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjConstructorStaticStringAttr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 07:11:31 +0000 (07:11 +0000)]
[Qt] from platform/qt/fast/overflow to platform/qt/fast/xsl tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91971
Unreviewed rebaseline.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-23
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/fast/overflow/001-expected.png: Added.
* platform/qt/fast/overflow/001-expected.txt:
* platform/qt/fast/overflow/002-expected.png: Added.
* platform/qt/fast/overflow/002-expected.txt:
* platform/qt/fast/overflow/004-expected.png:
* platform/qt/fast/overflow/004-expected.txt:
* platform/qt/fast/overflow/006-expected.png: Added.
* platform/qt/fast/overflow/006-expected.txt:
* platform/qt/fast/overflow/007-expected.png:
* platform/qt/fast/overflow/007-expected.txt:
* platform/qt/fast/overflow/008-expected.png: Added.
* platform/qt/fast/overflow/008-expected.txt:
* platform/qt/fast/overflow/border-radius-clipping-expected.png: Added.
* platform/qt/fast/overflow/border-radius-clipping-expected.txt:
* platform/qt/fast/overflow/childFocusRingClip-expected.png: Added.
* platform/qt/fast/overflow/childFocusRingClip-expected.txt:
* platform/qt/fast/overflow/dynamic-hidden-expected.png: Added.
* platform/qt/fast/overflow/dynamic-hidden-expected.txt:
* platform/qt/fast/overflow/float-in-relpositioned-expected.png: Added.
* platform/qt/fast/overflow/float-in-relpositioned-expected.txt:
* platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png: Added.
* platform/qt/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/qt/fast/overflow/hit-test-overflow-controls-expected.png: Added.
* platform/qt/fast/overflow/hit-test-overflow-controls-expected.txt:
* platform/qt/fast/overflow/image-selection-highlight-expected.png:
* platform/qt/fast/overflow/image-selection-highlight-expected.txt:
* platform/qt/fast/overflow/infiniteRecursion-expected.png:
* platform/qt/fast/overflow/infiniteRecursion-expected.txt:
* platform/qt/fast/overflow/line-clamp-expected.png:
* platform/qt/fast/overflow/line-clamp-expected.txt:
* platform/qt/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
* platform/qt/fast/overflow/overflow-auto-position-absolute-expected.txt:
* platform/qt/fast/overflow/overflow-auto-table-expected.png:
* platform/qt/fast/overflow/overflow-auto-table-expected.txt:
* platform/qt/fast/overflow/overflow-float-stacking-expected.png: Added.
* platform/qt/fast/overflow/overflow-float-stacking-expected.txt:
* platform/qt/fast/overflow/overflow-focus-ring-expected.png:
* platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
* platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
* platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
* platform/qt/fast/overflow/overflow-stacking-expected.png: Added.
* platform/qt/fast/overflow/overflow-stacking-expected.txt:
* platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
* platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
* platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
* platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/qt/fast/overflow/scrollbar-position-update-expected.png: Added.
* platform/qt/fast/overflow/scrollbar-position-update-expected.txt:
* platform/qt/fast/overflow/table-overflow-float-expected.png:
* platform/qt/fast/overflow/table-overflow-float-expected.txt:
* platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
* platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
* platform/qt/fast/parser/001-expected.png:
* platform/qt/fast/parser/001-expected.txt:
* platform/qt/fast/parser/bad-xml-slash-expected.png: Copied from LayoutTests/platform/qt/fast/text/whitespace/023-expected.png.
* platform/qt/fast/parser/bad-xml-slash-expected.txt:
* platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
* platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
* platform/qt/fast/parser/document-write-option-expected.png: Added.
* platform/qt/fast/parser/document-write-option-expected.txt:
* platform/qt/fast/parser/entity-comment-in-style-expected.png: Added.
* platform/qt/fast/parser/entity-comment-in-style-expected.txt:
* platform/qt/fast/parser/entity-comment-in-textarea-expected.png:
* platform/qt/fast/parser/entity-comment-in-textarea-expected.txt:
* platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
* platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
* platform/qt/fast/parser/open-comment-in-style-expected.png: Added.
* platform/qt/fast/parser/open-comment-in-style-expected.txt:
* platform/qt/fast/parser/open-comment-in-textarea-expected.png:
* platform/qt/fast/parser/open-comment-in-textarea-expected.txt:
* platform/qt/fast/parser/title-error-test-expected.png: Added.
* platform/qt/fast/parser/title-error-test-expected.txt:
* platform/qt/fast/reflections/abs-position-in-reflection-expected.png: Added.
* platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
* platform/qt/fast/reflections/inline-crash-expected.png: Added.
* platform/qt/fast/reflections/inline-crash-expected.txt:
* platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
* platform/qt/fast/reflections/opacity-reflection-transform-expected.txt:
* platform/qt/fast/reflections/reflection-nesting-expected.png: Added.
* platform/qt/fast/reflections/reflection-nesting-expected.txt:
* platform/qt/fast/reflections/reflection-overflow-hidden-expected.png: Added.
* platform/qt/fast/reflections/reflection-overflow-hidden-expected.txt:
* platform/qt/fast/reflections/transparent-reflected-sublayers-expected.png: Added.
* platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
* platform/qt/fast/repaint/
4774354-expected.png:
* platform/qt/fast/repaint/
4774354-expected.txt:
* platform/qt/fast/repaint/
4776765-expected.png:
* platform/qt/fast/repaint/
4776765-expected.txt:
* platform/qt/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/qt/fast/repaint/backgroundSizeRepaint-expected.txt:
* platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/qt/fast/repaint/body-background-image-expected.png:
* platform/qt/fast/repaint/body-background-image-expected.txt:
* platform/qt/fast/repaint/border-fit-lines-expected.png:
* platform/qt/fast/repaint/border-fit-lines-expected.txt:
* platform/qt/fast/repaint/border-radius-repaint-expected.png:
* platform/qt/fast/repaint/border-radius-repaint-expected.txt:
* platform/qt/fast/repaint/border-repaint-glitch-expected.png:
* platform/qt/fast/repaint/border-repaint-glitch-expected.txt:
* platform/qt/fast/repaint/box-shadow-dynamic-expected.png:
* platform/qt/fast/repaint/box-shadow-dynamic-expected.txt:
* platform/qt/fast/repaint/bugzilla-3509-expected.png:
* platform/qt/fast/repaint/bugzilla-3509-expected.txt:
* platform/qt/fast/repaint/bugzilla-5699-expected.png:
* platform/qt/fast/repaint/bugzilla-5699-expected.txt:
* platform/qt/fast/repaint/bugzilla-6278-expected.png:
* platform/qt/fast/repaint/bugzilla-6278-expected.txt:
* platform/qt/fast/repaint/bugzilla-6388-expected.png:
* platform/qt/fast/repaint/bugzilla-6388-expected.txt:
* platform/qt/fast/repaint/bugzilla-6473-expected.png:
* platform/qt/fast/repaint/bugzilla-6473-expected.txt:
* platform/qt/fast/repaint/bugzilla-7235-expected.png:
* platform/qt/fast/repaint/bugzilla-7235-expected.txt:
* platform/qt/fast/repaint/caret-outside-block-expected.png:
* platform/qt/fast/repaint/caret-outside-block-expected.txt:
* platform/qt/fast/repaint/change-transform-expected.png:
* platform/qt/fast/repaint/change-transform-expected.txt:
* platform/qt/fast/repaint/clipped-relative-expected.png:
* platform/qt/fast/repaint/clipped-relative-expected.txt:
* platform/qt/fast/repaint/containing-block-position-change-expected.png:
* platform/qt/fast/repaint/containing-block-position-change-expected.txt:
* platform/qt/fast/repaint/control-clip-expected.png:
* platform/qt/fast/repaint/control-clip-expected.txt:
* platform/qt/fast/repaint/create-layer-repaint-expected.png:
* platform/qt/fast/repaint/create-layer-repaint-expected.txt:
* platform/qt/fast/repaint/delete-into-nested-block-expected.png:
* platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
* platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
* platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
* platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.png:
* platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
* platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
* platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
* platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
* platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
* platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
* platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
* platform/qt/fast/repaint/fixed-move-after-scroll-expected.png:
* platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
* platform/qt/fast/repaint/float-move-during-layout-expected.png:
* platform/qt/fast/repaint/float-move-during-layout-expected.txt:
* platform/qt/fast/repaint/focus-layers-expected.png:
* platform/qt/fast/repaint/focus-layers-expected.txt:
* platform/qt/fast/repaint/inline-color-change-expected.png:
* platform/qt/fast/repaint/inline-color-change-expected.txt:
* platform/qt/fast/repaint/inline-outline-repaint-expected.png:
* platform/qt/fast/repaint/inline-outline-repaint-expected.txt:
* platform/qt/fast/repaint/layout-state-relative-expected.png:
* platform/qt/fast/repaint/layout-state-relative-expected.txt:
* platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
* platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
* platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
* platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
* platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
* platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-1-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-10-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-2-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-3-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-4-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-5-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-6-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-7-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-8-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-9-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt:
* platform/qt/fast/repaint/line-overflow-expected.png:
* platform/qt/fast/repaint/line-overflow-expected.txt:
* platform/qt/fast/repaint/list-marker-2-expected.png:
* platform/qt/fast/repaint/list-marker-2-expected.txt:
* platform/qt/fast/repaint/make-children-non-inline-expected.png:
* platform/qt/fast/repaint/make-children-non-inline-expected.txt:
* platform/qt/fast/repaint/multicol-repaint-expected.png:
* platform/qt/fast/repaint/multicol-repaint-expected.txt:
* platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
* platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt:
* platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
* platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/qt/fast/repaint/outline-child-repaint-expected.png:
* platform/qt/fast/repaint/outline-child-repaint-expected.txt:
* platform/qt/fast/repaint/outline-inset-expected.png:
* platform/qt/fast/repaint/outline-inset-expected.txt:
* platform/qt/fast/repaint/outline-repaint-glitch-expected.png:
* platform/qt/fast/repaint/outline-repaint-glitch-expected.txt:
* platform/qt/fast/repaint/outline-shrinking-expected.png:
* platform/qt/fast/repaint/outline-shrinking-expected.txt:
* platform/qt/fast/repaint/overflow-delete-line-expected.png:
* platform/qt/fast/repaint/overflow-delete-line-expected.txt:
* platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png:
* platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt:
* platform/qt/fast/repaint/overflow-scroll-delete-expected.png:
* platform/qt/fast/repaint/overflow-scroll-delete-expected.txt:
* platform/qt/fast/repaint/positioned-document-element-expected.png:
* platform/qt/fast/repaint/positioned-document-element-expected.txt:
* platform/qt/fast/repaint/reflection-redraw-expected.png:
* platform/qt/fast/repaint/reflection-redraw-expected.txt:
* platform/qt/fast/repaint/region-painting-invalidation-expected.png:
* platform/qt/fast/repaint/region-painting-invalidation-expected.txt:
* platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
* platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
* platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
* platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/qt/fast/repaint/scale-page-shrink-expected.png:
* platform/qt/fast/repaint/scale-page-shrink-expected.txt:
* platform/qt/fast/repaint/search-field-cancel-expected.png:
* platform/qt/fast/repaint/search-field-cancel-expected.txt:
* platform/qt/fast/repaint/select-option-background-color-expected.png:
* platform/qt/fast/repaint/select-option-background-color-expected.txt:
* platform/qt/fast/repaint/selected-replaced-expected.png:
* platform/qt/fast/repaint/selected-replaced-expected.txt:
* platform/qt/fast/repaint/selection-after-delete-expected.png:
* platform/qt/fast/repaint/selection-after-delete-expected.txt:
* platform/qt/fast/repaint/selection-after-remove-expected.png:
* platform/qt/fast/repaint/selection-after-remove-expected.txt:
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
* platform/qt/fast/repaint/selection-rl-expected.png:
* platform/qt/fast/repaint/selection-rl-expected.txt:
* platform/qt/fast/repaint/stacked-diacritics-expected.png:
* platform/qt/fast/repaint/stacked-diacritics-expected.txt:
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png:
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/qt/fast/repaint/subtree-root-skipped-expected.png:
* platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
* platform/qt/fast/repaint/table-cell-collapsed-border-expected.png:
* platform/qt/fast/repaint/table-cell-collapsed-border-expected.txt:
* platform/qt/fast/repaint/table-cell-move-expected.png:
* platform/qt/fast/repaint/table-cell-move-expected.txt:
* platform/qt/fast/repaint/table-collapsed-border-expected.png:
* platform/qt/fast/repaint/table-collapsed-border-expected.txt:
* platform/qt/fast/repaint/table-extra-bottom-grow-expected.png:
* platform/qt/fast/repaint/table-extra-bottom-grow-expected.txt:
* platform/qt/fast/repaint/text-append-dirty-lines-expected.png:
* platform/qt/fast/repaint/text-append-dirty-lines-expected.txt:
* platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/qt/fast/repaint/transform-relative-position-expected.png:
* platform/qt/fast/repaint/transform-relative-position-expected.txt:
* platform/qt/fast/repaint/transform-repaint-descendants-expected.png:
* platform/qt/fast/repaint/transform-repaint-descendants-expected.txt:
* platform/qt/fast/repaint/transform-translate-expected.png:
* platform/qt/fast/repaint/transform-translate-expected.txt:
* platform/qt/fast/replaced/001-expected.png:
* platform/qt/fast/replaced/001-expected.txt:
* platform/qt/fast/replaced/002-expected.png:
* platform/qt/fast/replaced/002-expected.txt:
* platform/qt/fast/replaced/003-expected.png:
* platform/qt/fast/replaced/003-expected.txt:
* platform/qt/fast/replaced/004-expected.png:
* platform/qt/fast/replaced/004-expected.txt:
* platform/qt/fast/replaced/005-expected.png:
* platform/qt/fast/replaced/005-expected.txt:
* platform/qt/fast/replaced/006-expected.png:
* platform/qt/fast/replaced/006-expected.txt:
* platform/qt/fast/replaced/007-expected.png:
* platform/qt/fast/replaced/007-expected.txt:
* platform/qt/fast/replaced/absolute-image-sizing-expected.png:
* platform/qt/fast/replaced/absolute-image-sizing-expected.txt:
* platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
* platform/qt/fast/replaced/absolute-position-percentage-height-expected.txt:
* platform/qt/fast/replaced/absolute-position-percentage-width-expected.png:
* platform/qt/fast/replaced/absolute-position-percentage-width-expected.txt:
* platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
* platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
* platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
* platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.txt:
* platform/qt/fast/replaced/applet-disabled-positioned-expected.png:
* platform/qt/fast/replaced/applet-disabled-positioned-expected.txt:
* platform/qt/fast/replaced/applet-display-none-expected.png:
* platform/qt/fast/replaced/applet-display-none-expected.txt:
* platform/qt/fast/replaced/applet-rendering-java-disabled-expected.png:
* platform/qt/fast/replaced/applet-rendering-java-disabled-expected.txt:
* platform/qt/fast/replaced/border-radius-clip-expected.png:
* platform/qt/fast/replaced/border-radius-clip-expected.txt:
* platform/qt/fast/replaced/embed-display-none-expected.png:
* platform/qt/fast/replaced/embed-display-none-expected.txt:
* platform/qt/fast/replaced/image-resize-width-expected.png:
* platform/qt/fast/replaced/image-resize-width-expected.txt:
* platform/qt/fast/replaced/image-sizing-expected.png:
* platform/qt/fast/replaced/image-sizing-expected.txt:
* platform/qt/fast/replaced/inline-box-wrapper-handover-expected.png:
* platform/qt/fast/replaced/inline-box-wrapper-handover-expected.txt:
* platform/qt/fast/replaced/max-width-percent-expected.png:
* platform/qt/fast/replaced/max-width-percent-expected.txt:
* platform/qt/fast/replaced/maxheight-percent-expected.png:
* platform/qt/fast/replaced/maxheight-percent-expected.txt:
* platform/qt/fast/replaced/maxheight-pxs-expected.png:
* platform/qt/fast/replaced/maxheight-pxs-expected.txt:
* platform/qt/fast/replaced/maxwidth-percent-expected.png:
* platform/qt/fast/replaced/maxwidth-percent-expected.txt:
* platform/qt/fast/replaced/maxwidth-pxs-expected.png:
* platform/qt/fast/replaced/maxwidth-pxs-expected.txt:
* platform/qt/fast/replaced/minheight-percent-expected.png:
* platform/qt/fast/replaced/minheight-percent-expected.txt:
* platform/qt/fast/replaced/minheight-pxs-expected.png:
* platform/qt/fast/replaced/minheight-pxs-expected.txt:
* platform/qt/fast/replaced/minwidth-percent-expected.png:
* platform/qt/fast/replaced/minwidth-percent-expected.txt:
* platform/qt/fast/replaced/minwidth-pxs-expected.png:
* platform/qt/fast/replaced/minwidth-pxs-expected.txt:
* platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
* platform/qt/fast/replaced/object-align-hspace-vspace-expected.txt:
* platform/qt/fast/replaced/object-display-none-expected.png:
* platform/qt/fast/replaced/object-display-none-expected.txt:
* platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
* platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
* platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
* platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt:
* platform/qt/fast/replaced/replaced-breaking-expected.png:
* platform/qt/fast/replaced/replaced-breaking-expected.txt:
* platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/qt/fast/replaced/replaced-child-of-absolute-with-auto-height-expected.png:
* platform/qt/fast/replaced/replaced-child-of-absolute-with-auto-height-expected.txt:
* platform/qt/fast/replaced/selection-rect-in-table-cell-expected.png:
* platform/qt/fast/replaced/selection-rect-in-table-cell-expected.txt:
* platform/qt/fast/replaced/selection-rect-transform-expected.png:
* platform/qt/fast/replaced/selection-rect-transform-expected.txt:
* platform/qt/fast/replaced/three-selects-break-expected.png:
* platform/qt/fast/replaced/three-selects-break-expected.txt:
* platform/qt/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
* platform/qt/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt:
* platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
* platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
* platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
* platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt:
* platform/qt/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
* platform/qt/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt:
* platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
* platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
* platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
* platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt:
* platform/qt/fast/replaced/width100percent-button-expected.png:
* platform/qt/fast/replaced/width100percent-button-expected.txt:
* platform/qt/fast/replaced/width100percent-checkbox-expected.png:
* platform/qt/fast/replaced/width100percent-checkbox-expected.txt:
* platform/qt/fast/replaced/width100percent-image-expected.png:
* platform/qt/fast/replaced/width100percent-image-expected.txt:
* platform/qt/fast/replaced/width100percent-radio-expected.png: Added.
* platform/qt/fast/replaced/width100percent-radio-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.png:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/fast/replaced/width100percent-textfield-expected.png:
* platform/qt/fast/replaced/width100percent-textfield-expected.txt:
* platform/qt/fast/ruby/ruby-inline-table-expected.png:
* platform/qt/fast/ruby/ruby-inline-table-expected.txt:
* platform/qt/fast/ruby/ruby-text-before-after-content-expected.png:
* platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt:
* platform/qt/fast/runin/001-expected.png:
* platform/qt/fast/runin/001-expected.txt:
* platform/qt/fast/runin/generated-expected.png:
* platform/qt/fast/runin/generated-expected.txt:
* platform/qt/fast/runin/generated2-expected.png:
* platform/qt/fast/runin/generated2-expected.txt:
* platform/qt/fast/runin/generated3-expected.png:
* platform/qt/fast/runin/generated3-expected.txt:
* platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png:
* platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
* platform/qt/fast/text/atsui-kerning-and-ligatures-expected.png: Added.
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-euc-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/qt/fast/text/backslash-to-yen-sign-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-expected.txt:
* platform/qt/fast/text/basic/001-expected.png:
* platform/qt/fast/text/basic/002-expected.png: Added.
* platform/qt/fast/text/basic/003-expected.png:
* platform/qt/fast/text/basic/003-expected.txt:
* platform/qt/fast/text/basic/004-expected.png: Added.
* platform/qt/fast/text/basic/005-expected.png: Added.
* platform/qt/fast/text/basic/006-expected.png: Added.
* platform/qt/fast/text/basic/007-expected.png: Added.
* platform/qt/fast/text/basic/008-expected.png: Added.
* platform/qt/fast/text/basic/009-expected.png:
* platform/qt/fast/text/basic/011-expected.png: Added.
* platform/qt/fast/text/basic/012-expected.png: Added.
* platform/qt/fast/text/basic/generic-family-changes-expected.png:
* platform/qt/fast/text/basic/generic-family-reset-expected.png:
* platform/qt/fast/text/break-word-expected.png:
* platform/qt/fast/text/capitalize-empty-generated-string-expected.png: Added.
* platform/qt/fast/text/capitalize-preserve-nbsp-expected.png: Added.
* platform/qt/fast/text/cg-vs-atsui-expected.png:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
* platform/qt/fast/text/complex-text-opacity-expected.png:
* platform/qt/fast/text/complex-text-opacity-expected.txt:
* platform/qt/fast/text/delete-hard-break-character-expected.png: Added.
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
* platform/qt/fast/text/fake-italic-expected.png: Added.
* platform/qt/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/qt/fast/text/fallback-traits-fixup-expected.txt:
* platform/qt/fast/text/firstline/001-expected.png: Added.
* platform/qt/fast/text/firstline/002-expected.png: Added.
* platform/qt/fast/text/firstline/003-expected.png: Added.
* platform/qt/fast/text/font-initial-expected.png: Added.
* platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
* platform/qt/fast/text/hyphenate-limit-lines-expected.png:
* platform/qt/fast/text/international/arabic-justify-expected.png: Added.
* platform/qt/fast/text/international/arabic-justify-expected.txt:
* platform/qt/fast/text/international/hindi-whitespace-expected.png: Added.
* platform/qt/fast/text/international/hindi-whitespace-expected.txt:
* platform/qt/fast/text/international/text-spliced-font-expected.png:
* platform/qt/fast/text/international/text-spliced-font-expected.txt:
* platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
* platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/qt/fast/text/justified-selection-at-edge-expected.png: Added.
* platform/qt/fast/text/justified-selection-expected.png: Added.
* platform/qt/fast/text/large-text-composed-char-expected.png:
* platform/qt/fast/text/large-text-composed-char-expected.txt:
* platform/qt/fast/text/letter-spacing-negative-opacity-expected.png:
* platform/qt/fast/text/letter-spacing-negative-opacity-expected.txt:
* platform/qt/fast/text/line-breaks-after-white-space-expected.png:
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/multicol-repaint-expected.png.
* platform/qt/fast/text/midword-break-hang-expected.png: Added.
* platform/qt/fast/text/reset-emptyRun-expected.png: Added.
* platform/qt/fast/text/selection-hard-linebreak-expected.png:
* platform/qt/fast/text/shadow-no-blur-expected.png:
* platform/qt/fast/text/shadow-translucent-fill-expected.png: Added.
* platform/qt/fast/text/should-use-atsui-expected.png: Added.
* platform/qt/fast/text/softHyphen-expected.png: Added.
* platform/qt/fast/text/softHyphen-expected.txt:
* platform/qt/fast/text/stroking-decorations-expected.png: Added.
* platform/qt/fast/text/stroking-expected.png: Added.
* platform/qt/fast/text/text-letter-spacing-expected.png:
* platform/qt/fast/text/text-letter-spacing-expected.txt:
* platform/qt/fast/text/text-shadow-no-default-color-expected.png: Added.
* platform/qt/fast/text/textIteratorNilRenderer-expected.png:
* platform/qt/fast/text/unicode-variation-selector-expected.png:
* platform/qt/fast/text/wbr-expected.png: Added.
* platform/qt/fast/text/wbr-in-pre-crash-expected.png: Added.
* platform/qt/fast/text/wbr-pre-expected.png:
* platform/qt/fast/text/wbr-styled-expected.png:
* platform/qt/fast/text/whitespace/002-expected.png:
* platform/qt/fast/text/whitespace/003-expected.png:
* platform/qt/fast/text/whitespace/006-expected.png: Added.
* platform/qt/fast/text/whitespace/007-expected.png: Added.
* platform/qt/fast/text/whitespace/008-expected.png: Added.
* platform/qt/fast/text/whitespace/009-expected.png: Added.
* platform/qt/fast/text/whitespace/012-expected.png:
* platform/qt/fast/text/whitespace/013-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/multicol-repaint-expected.png.
* platform/qt/fast/text/whitespace/014-expected.png: Copied from LayoutTests/platform/qt/fast/replaced/three-selects-break-expected.png.
* platform/qt/fast/text/whitespace/018-expected.png: Added.
* platform/qt/fast/text/whitespace/020-expected.png: Added.
* platform/qt/fast/text/whitespace/021-expected.png: Added.
* platform/qt/fast/text/whitespace/022-expected.png:
* platform/qt/fast/text/whitespace/023-expected.png:
* platform/qt/fast/text/whitespace/025-expected.png: Added.
* platform/qt/fast/text/whitespace/026-expected.png: Added.
* platform/qt/fast/text/whitespace/027-expected.png: Added.
* platform/qt/fast/text/whitespace/030-expected.png:
* platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/qt/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
* platform/qt/fast/text/whitespace/pre-break-word-expected.png:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
* platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png: Added.
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
* platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
* platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
* platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.png: Added.
* platform/qt/fast/text/word-break-expected.png:
* platform/qt/fast/text/word-break-expected.txt:
* platform/qt/fast/text/zero-font-size-expected.png:
* platform/qt/fast/text/zero-font-size-expected.txt:
* platform/qt/fast/tokenizer/001-expected.png:
* platform/qt/fast/tokenizer/001-expected.txt:
* platform/qt/fast/tokenizer/003-expected.png:
* platform/qt/fast/tokenizer/003-expected.txt:
* platform/qt/fast/transforms/bounding-rect-zoom-expected.png: Added.
* platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/qt/fast/transforms/diamond-expected.png:
* platform/qt/fast/transforms/diamond-expected.txt:
* platform/qt/fast/transforms/identity-matrix-expected.png:
* platform/qt/fast/transforms/identity-matrix-expected.txt:
* platform/qt/fast/transforms/overflow-with-transform-expected.png:
* platform/qt/fast/transforms/overflow-with-transform-expected.txt:
* platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
* platform/qt/fast/transforms/skew-with-unitless-zero-expected.txt:
* platform/qt/fast/transforms/transform-on-inline-expected.png:
* platform/qt/fast/transforms/transform-on-inline-expected.txt:
* platform/qt/fast/transforms/transform-overflow-expected.png:
* platform/qt/fast/transforms/transform-overflow-expected.txt:
* platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
* platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt:
* platform/qt/fast/transforms/transform-table-row-expected.png:
* platform/qt/fast/transforms/transform-table-row-expected.txt:
* platform/qt/fast/transforms/transformed-caret-expected.png:
* platform/qt/fast/transforms/transformed-caret-expected.txt:
* platform/qt/fast/transforms/transformed-document-element-expected.png:
* platform/qt/fast/transforms/transformed-document-element-expected.txt:
* platform/qt/fast/transforms/transforms-with-opacity-expected.png:
* platform/qt/fast/transforms/transforms-with-opacity-expected.txt:
* platform/qt/fast/transforms/transforms-with-zoom-expected.png:
* platform/qt/fast/transforms/transforms-with-zoom-expected.txt:
* platform/qt/fast/writing-mode/background-horizontal-bt-expected.png:
* platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt:
* platform/qt/fast/writing-mode/background-vertical-lr-expected.png:
* platform/qt/fast/writing-mode/background-vertical-lr-expected.txt:
* platform/qt/fast/writing-mode/background-vertical-rl-expected.png:
* platform/qt/fast/writing-mode/background-vertical-rl-expected.txt:
* platform/qt/fast/writing-mode/basic-vertical-line-expected.png:
* platform/qt/fast/writing-mode/basic-vertical-line-expected.txt:
* platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
* platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.txt:
* platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.txt:
* platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.txt:
* platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.txt:
* platform/qt/fast/writing-mode/english-bt-text-expected.png:
* platform/qt/fast/writing-mode/english-bt-text-expected.txt:
* platform/qt/fast/writing-mode/english-lr-text-expected.png:
* platform/qt/fast/writing-mode/english-lr-text-expected.txt:
* platform/qt/fast/writing-mode/english-rl-text-expected.png:
* platform/qt/fast/writing-mode/english-rl-text-expected.txt:
* platform/qt/fast/writing-mode/fallback-orientation-expected.png:
* platform/qt/fast/writing-mode/fallback-orientation-expected.txt:
* platform/qt/fast/writing-mode/fieldsets-expected.png:
* platform/qt/fast/writing-mode/fieldsets-expected.txt:
* platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
* platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt:
* platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
* platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.txt:
* platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
* platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.txt:
* platform/qt/fast/xsl/document-function-expected.png: Added.
* platform/qt/fast/xsl/document-function-expected.txt:
* platform/qt/fast/xsl/xslt-entity-expected.png: Copied from LayoutTests/platform/qt/fast/text/whitespace/023-expected.png.
* platform/qt/fast/xsl/xslt-entity-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 24 Jul 2012 06:43:17 +0000 (06:43 +0000)]
[GTK] Remove unnecessary trailing space in the previous commit.
* Source/autotools/symbols.filter:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 24 Jul 2012 06:35:19 +0000 (06:35 +0000)]
[GTK] Attempt to fix build
* Source/autotools/symbols.filter: Export DocumentMarkerController::addTextMatchMarker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 24 Jul 2012 06:33:55 +0000 (06:33 +0000)]
Missing *explicit* keyword in editing.
https://bugs.webkit.org/show_bug.cgi?id=92055
Reviewed by Ryosuke Niwa.
Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.
No new tests. Covered by existing tests.
* editing/AlternativeTextController.h:
(WebCore::AlternativeTextController::UNLESS_ENABLED):
* editing/BreakBlockquoteCommand.h:
(BreakBlockquoteCommand):
* editing/DeleteButton.h:
(DeleteButton):
* editing/DeleteButtonController.h:
(DeleteButtonController):
* editing/EditCommand.h:
(EditCommand):
(WebCore::SimpleEditCommand::SimpleEditCommand):
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::EditingBehavior):
* editing/EditingStyle.h:
(EditingStyle):
* editing/Editor.h:
(Editor):
* editing/FrameSelection.h:
(FrameSelection):
* editing/InsertLineBreakCommand.h:
(InsertLineBreakCommand):
* editing/ModifySelectionListLevel.h:
(ModifySelectionListLevelCommand):
(DecreaseSelectionListLevelCommand):
* editing/RemoveFormatCommand.h:
(RemoveFormatCommand):
* editing/RemoveNodeCommand.h:
(RemoveNodeCommand):
* editing/RemoveNodePreservingChildrenCommand.h:
(RemoveNodePreservingChildrenCommand):
* editing/ReplaceNodeWithSpanCommand.h:
(ReplaceNodeWithSpanCommand):
* editing/TextInsertionBaseCommand.h:
(TextInsertionBaseCommand):
* editing/UndoManager.h:
(UndoManager):
* editing/UnlinkCommand.h:
(UnlinkCommand):
* editing/WrapContentsInDummySpanCommand.h:
(WrapContentsInDummySpanCommand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Tue, 24 Jul 2012 06:26:32 +0000 (06:26 +0000)]
AX: Need AccessibilityObjects for nodes without renderers in canvas subtree
https://bugs.webkit.org/show_bug.cgi?id=87899
Reviewed by Chris Fleizach.
Source/WebCore:
Refactors AccessibilityRenderObject so that it inherits from a new class,
AccessibilityNodeObject, that can be constructed from a Node without a
renderer. Modifies AXObjectCache so that it automatically creates an
AccessibilityNodeObject for elements in a canvas subtree but not otherwise.
A new layout test verifies that this correctly exposes an accessibility
tree with appropriate roles for elements in a canvas subtree.
This patch does not try to complete the implementation of
AccessibilityNodeObject. Most AX methods are still unimplemented and need
to be migrated from AccessibilityRenderObject to AccessibilityNodeObject
in a future patch.
This patch also doesn't change anything outside of WebCore/accessibility, so
the rest of WebCore only calls AXObjectCache when there are changes to a
RenderObject, not to a Node. Accessible notifications on nodes without
renderers need to be implemented in a future patch.
Test: accessibility/canvas-accessibilitynodeobject.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
(WebCore):
(WebCore::createFromNode):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
* accessibility/AXObjectCache.h:
(AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::init):
(WebCore::AccessibilityARIAGrid::create):
* accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::create):
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::create):
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::create):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::create):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::create):
(WebCore):
* accessibility/AccessibilityMenuList.h:
(AccessibilityMenuList):
* accessibility/AccessibilityNodeObject.cpp: Added.
(WebCore):
(WebCore::AccessibilityNodeObject::AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::~AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::init):
(WebCore::AccessibilityNodeObject::create):
(WebCore::AccessibilityNodeObject::detach):
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::updateAccessibilityRole):
(WebCore::AccessibilityNodeObject::firstChild):
(WebCore::AccessibilityNodeObject::lastChild):
(WebCore::AccessibilityNodeObject::previousSibling):
(WebCore::AccessibilityNodeObject::nextSibling):
(WebCore::AccessibilityNodeObject::parentObjectIfExists):
(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::elementRect):
(WebCore::AccessibilityNodeObject::setNode):
(WebCore::AccessibilityNodeObject::document):
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute):
(WebCore::AccessibilityNodeObject::ariaRoleAttribute):
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent):
* accessibility/AccessibilityNodeObject.h: Added.
(WebCore):
(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::isAccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):
(WebCore::AccessibilityNodeObject::isDetached):
(WebCore::toAccessibilityNodeObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityNodeObject):
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::create):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::init):
(WebCore):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::setRenderer):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addCanvasChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::create):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore::AccessibilityTable::init):
(WebCore::AccessibilityTable::create):
* accessibility/AccessibilityTable.h:
(AccessibilityTable):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::create):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::create):
LayoutTests:
This new test adds a bunch of elements to a normal container and the same elements to
a canvas subtree, then it iterates over all of the accessible objects within each
container and makes sure they have identical roles. Because we know the nodes in the
canvas subtree don't have renderers, this successfully tests that AccessibilityNodeObjects
are getting created for these nodes.
* accessibility/canvas-accessibilitynodeobject-expected.txt: Added.
* accessibility/canvas-accessibilitynodeobject.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 05:46:51 +0000 (05:46 +0000)]
Fix ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=91961
Patch by David Barr <davidbarr@chromium.org> on 2012-07-23
Reviewed by Tony Chang.
https://bugs.webkit.org/show_bug.cgi?id=89055
A rule was missed implementing the ENABLE_CSS_IMAGE_ORIENTATION compile flag.
https://bugs.webkit.org/show_bug.cgi?id=90046
Half of the missing rule was inadvertently added together with ENABLE_CSS_STICKY_POSITION.
No new tests; build configuration fix.
* Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 05:34:42 +0000 (05:34 +0000)]
Null-pointer crash when a derived color like -webkit-activelink is set in a gradient stop
https://bugs.webkit.org/show_bug.cgi?id=89148
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-23
Reviewed by Simon Fraser.
Source/WebCore:
CSSGradientValue attempted to resolve colors during paint, this crashed
when a derived color like -webkit-activelink was encountered because the
corresponding element was no longer available in the StyleResolver.
Instead, by adding a field to CSSGradientColorStop we can resolve and
then cache the resolved colors at the correct time. To avoid sharing
cached derived colors between elements we clone the gradient values when
needed.
Test: fast/css/crash-on-gradient-with-derived-color.html
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved): Added. Resolve and cache
resolved colors, clone if colors are derived from the element.
(WebCore):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::isCacheable): Defer to new logic in
StyleResolver.
* css/CSSGradientValue.h:
(CSSGradientColorStop): Added cache of resolved color.
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):
* css/CSSImageGeneratorValue.h:
(WebCore):
* css/CSSValue.h:
(WebCore::CSSValue::isGradientValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image): Revert change from r96449. This
is no longer necessary as the gradient colors are now resolved at a
time when the style is set on StyleResolver.
LayoutTests:
* fast/css/crash-on-gradient-with-derived-color-expected.txt: Added.
* fast/css/crash-on-gradient-with-derived-color.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 24 Jul 2012 05:19:55 +0000 (05:19 +0000)]
Move GregorianDateTime from JSC to WTF namespace
https://bugs.webkit.org/show_bug.cgi?id=91948
Reviewed by Geoffrey Garen.
Moving GregorianDateTime into the WTF namespace allows us to us to
use it in WebCore too. The new class has the same behaviour as the
old struct. Only the unused timeZone member has been removed.
Source/JavaScriptCore:
* runtime/DateConstructor.cpp:
* runtime/DateConversion.cpp:
* runtime/DateConversion.h:
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
* runtime/JSDateMath.cpp:
* runtime/JSDateMath.h:
Source/WebCore:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
* bridge/qt/qt_runtime_qt4.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
Source/WTF:
* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/GregorianDateTime.h: Added.
(GregorianDateTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pilgrim@chromium.org [Tue, 24 Jul 2012 05:05:25 +0000 (05:05 +0000)]
[Chromium] Move layoutTestMode to WebCore
https://bugs.webkit.org/show_bug.cgi?id=92010
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* platform/LayoutTestSupport.cpp: Added.
(WebCore):
(WebCore::isRunningLayoutTest):
(WebCore::setIsRunningLayoutTest):
* platform/LayoutTestSupport.h: Added.
(WebCore):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore):
(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::determineClassicState):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
* src/WebKit.cpp:
(WebKit::setLayoutTestMode):
(WebKit::layoutTestMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joone@webkit.org [Tue, 24 Jul 2012 04:57:58 +0000 (04:57 +0000)]
Unreviewed GTK/EFL gardening after r123379
Marked fast/css/sticky/parsing-position-sticky.html as known failure
tracked by the bug 92063
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 24 Jul 2012 04:22:29 +0000 (04:22 +0000)]
[Tests] Rename fast/forms/time/*.html to time-*.html
https://bugs.webkit.org/show_bug.cgi?id=92058
Reviewed by Kent Tamura.
This patch renames test scripts and expected text to same naming
scheme(name starts with "time-"), for fast/forms/time.
* fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Removed.
* fast/forms/time/ValidityState-rangeOverflow-time.html: Removed.
* fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Removed.
* fast/forms/time/ValidityState-rangeUnderflow-time.html: Removed.
* fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Removed.
* fast/forms/time/ValidityState-stepMismatch-time.html: Removed.
* fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Removed.
* fast/forms/time/ValidityState-typeMismatch-time.html: Removed.
* fast/forms/time/input-valueasdate-time-expected.txt: Removed.
* fast/forms/time/input-valueasdate-time.html: Removed.
* fast/forms/time/input-valueasnumber-time-expected.txt: Removed.
* fast/forms/time/input-valueasnumber-time.html: Removed.
* fast/forms/time/time-validity-state-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time-expected.txt.
* fast/forms/time/time-validity-state-range-overflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time.html.
* fast/forms/time/time-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt.
* fast/forms/time/time-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time.html.
* fast/forms/time/time-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time-expected.txt.
* fast/forms/time/time-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time.html.
* fast/forms/time/time-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time-expected.txt.
* fast/forms/time/time-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time.html.
* fast/forms/time/time-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasdate-time-expected.txt.
* fast/forms/time/time-valueasdate.html: Copied from LayoutTests/fast/forms/time/input-valueasdate-time.html.
* fast/forms/time/time-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time-expected.txt.
* fast/forms/time/time-valueasnumber.html: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 04:17:49 +0000 (04:17 +0000)]
[chromium] Add droppedFrameCount to renderingStats.
https://bugs.webkit.org/show_bug.cgi?id=91694
Patch by Dave Tu <dtu@chromium.org> on 2012-07-23
Reviewed by Adrienne Walker.
Source/Platform:
* chromium/public/WebRenderingStats.h:
(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):
Source/WebCore:
* platform/graphics/chromium/cc/CCFrameRateCounter.cpp:
(WebCore):
(WebCore::CCFrameRateCounter::frameInterval):
(WebCore::CCFrameRateCounter::frameIndex):
(WebCore::CCFrameRateCounter::CCFrameRateCounter):
(WebCore::CCFrameRateCounter::markBeginningOfFrame):
(WebCore::CCFrameRateCounter::isBadFrame):
* platform/graphics/chromium/cc/CCFrameRateCounter.h:
(WebCore::CCFrameRateCounter::droppedFrameCount):
(CCFrameRateCounter):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::renderingStats):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCRenderingStats.h:
(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::implSideRenderingStats):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::implSideRenderingStatsOnImplThread):
Source/WebKit/chromium:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStats):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 24 Jul 2012 02:55:43 +0000 (02:55 +0000)]
Fixed the build after r123418.
* WebCore.exp.in: Added DocumentMarkerController::addTextMatchMarker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Tue, 24 Jul 2012 02:44:29 +0000 (02:44 +0000)]
CSS3 calc: optimise blending expression
https://bugs.webkit.org/show_bug.cgi?id=90037
Reviewed by Tony Chang.
Introduce a new calc expression node - a BlendLength node. Given two Lengths and a progress
this blends them together when evaluated.
An alternative and more general approach of being able to blend two CalcExpressionNodes was
tested, but involves more memory allocations, was measurably slower, and nothing currently
would make use of the generality.
No functional change. Covered by existing tests.
* platform/CalculationValue.h:
(CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::operator==):
(WebCore::CalcExpressionBlendLength::evaluate):
(WebCore):
* platform/Length.cpp:
(WebCore::Length::blendCalculation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 24 Jul 2012 02:19:13 +0000 (02:19 +0000)]
[chromium] Show search tickmarks on css-styled scrollbars
https://bugs.webkit.org/show_bug.cgi?id=91949
Reviewed by Adrienne Walker.
This is done by letting RenderScrollbarTheme::paintTickmarks()
delegate to the native ScrollbarTheme. To make this possible,
move paintTickmarks() from ScrollbarThemeComposite to the
superclass ScrollbarTheme.
For testing, add internals.addTextMatchMarker() and add a pixel test.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintTickmarks):
Moved paintTickmarks() from ScrollbarThemeComposite to here.
* platform/ScrollbarThemeComposite.h:
Remove paintTickmarks().
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
Switch to drawing tickmarks as vectors, so they can be arbitrarily wide.
* platform/chromium/ScrollbarThemeChromiumMac.h:
(ScrollbarThemeChromiumMac):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::paintTickmarks):
Delegate to the native ScrollbarTheme for tickmark drawing.
(WebCore):
* rendering/RenderScrollbarTheme.h:
(RenderScrollbarTheme):
Override paintTickmarks().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 24 Jul 2012 02:13:19 +0000 (02:13 +0000)]
Property storage should grow in reverse address direction, to support butterflies
https://bugs.webkit.org/show_bug.cgi?id=91788
Reviewed by Geoffrey Garen.
Changes property storage to grow to the left, and changes the property storage pointer to point
one 8-byte word (i.e. JSValue) to the right of the first value in the storage.
Also improved debug support somewhat, by adding a describe() function to the jsc command-line,
and a slow mode of object access in LLInt.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchCompact):
* assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerX86Common::repatchCompact):
* assembler/X86Assembler.h:
(JSC::X86Assembler::repatchCompact):
* bytecode/CodeBlock.cpp:
(JSC::dumpStructure):
* bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::emitPutTransitionStub):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::pinIfNecessary):
(JSC):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetDirectOffset):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionDescribe):
* llint/LLIntCommon.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::growOutOfLineStorage):
* runtime/JSObject.h:
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):
* runtime/JSValue.h:
(JSValue):
* runtime/PropertyOffset.h:
(JSC::offsetInOutOfLineStorage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 02:03:53 +0000 (02:03 +0000)]
[chromium] Use shallow flushes that don't glFlush
https://bugs.webkit.org/show_bug.cgi?id=90325
Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-23
Reviewed by Kenneth Russell.
Source/Platform:
Adds shallowFlushCHROMIUM to WebGraphicsContext3D.
* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::shallowFlushCHROMIUM):
Source/WebCore:
Adds plumbing for the shallowFlushCHROMIUM extension and uses
shallow flushes instead of normal flushes when uploading textures.
Shallow flushes allow us to initiate command buffer flushes to
the GPU thread/process without the overhead of a true glFlush.
CCTextureUpdaterTest updated to recognize shallow flushes.
* platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::shallowFlushCHROMIUM):
(WebCore):
* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):
* platform/graphics/chromium/cc/CCGraphicsContext.h:
* platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::initialize):
* platform/graphics/chromium/cc/CCResourceProvider.h:
(CCResourceProvider):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
Source/WebKit/chromium:
Changed CCTextureUpdaterTest to recognize shallowFlushCHROMIUM().
* tests/CCTextureUpdaterTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 01:59:17 +0000 (01:59 +0000)]
Disable flexbox on Windows
https://bugs.webkit.org/show_bug.cgi?id=92047
<rdar://problem/
11570384>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Darin Adler.
Disabled Flexbox CSS3 syntax on Mac, need to do the same for Windows.
WebKitLibraries:
* win/tools/vsprops/FeatureDefines.vsprops:
Disable ENABLE_CSS3_FLEXBOX property.
LayoutTests:
* platform/win/Skipped:
Add related CSS3 Flexbox tests to skip list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 01:14:58 +0000 (01:14 +0000)]
Source/WebCore: When using TextureMapper, WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame.
https://bugs.webkit.org/show_bug.cgi?id=91322
Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.
When -webkit-fill-mode is forwards, GraphicsLayerAnimation::apply does not apply
the property values defined in the last executing keyframe after the final iteration of animation.
This patch does not return right after the end of animation, but it keeps applying
the property values defined in the last executing keyframe.
Add normalizedAnimationValueForFillsForwards function that returns a normalized value of the
last executing keyframe.
Link to CSS Animations spec: http://www.w3.org/TR/css3-animations/#animation-fill-mode-property
Test: animations/fill-mode-forwards2.html
* platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::normalizedAnimationValueForFillsForwards):
(WebCore):
(WebCore::GraphicsLayerAnimation::apply):
LayoutTests: WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame
https://bugs.webkit.org/show_bug.cgi?id=91322
Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.
Added a test to check if the opacity has the right value after animation.
* animations/fill-mode-forwards2-expected.txt: Added.
* animations/fill-mode-forwards2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 24 Jul 2012 00:57:18 +0000 (00:57 +0000)]
[chromium] Add more compositor unit tests for high DPI transforms
https://bugs.webkit.org/show_bug.cgi?id=91917
Reviewed by Kenneth Russell.
The current set of high DPI tests only deal with layers in a render
surface. Add some extra tests for non-surface layers. Also add a test
to make sure that an owning layer in a surface doesn't differ from a
non-owning layer in high DPI circumstances.
* tests/CCLayerTreeHostCommonTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 00:53:24 +0000 (00:53 +0000)]
Unreviewed, rolling out r123184, r123195, and r123197.
http://trac.webkit.org/changeset/123184
http://trac.webkit.org/changeset/123195
http://trac.webkit.org/changeset/123197
https://bugs.webkit.org/show_bug.cgi?id=92049
pagecycler regression (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::suggestedMIMEType):
* dom/Document.h:
(WebCore):
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::setDocument):
(WebCore):
(WebCore::Node::setTreeScope):
(WebCore::Node::treeScope):
(WebCore::Node::isInShadowTree):
(WebCore::Node::reportMemoryUsage):
* dom/Node.h:
(Node):
(WebCore::Node::document):
(WebCore::Node::inDocument):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::treeScope):
(WebCore::NodeRareData::setTreeScope):
(NodeRareData):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
* dom/TreeScope.h:
(WebCore):
(WebCore::TreeScope::idTargetObserverRegistry):
(TreeScope):
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
* editing/MoveSelectionCommand.cpp:
* editing/RemoveNodeCommand.cpp:
* editing/RemoveNodePreservingChildrenCommand.cpp:
* inspector/PageConsoleAgent.cpp:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 00:48:06 +0000 (00:48 +0000)]
.: If select element in Windows is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/
7611229>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.
Add a manual test to verify that popup menus render in the correct place.
* ManualTests/win/select-menu-off-screen.html: Added.
Source/WebCore: On Windows, if select element is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/
7611229>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.
If the select element is positioned off the edge of the screen to the left,
the menu is resized. It should not be resized, just shifted to remain on the screen.
If the select element is positioned off the edge of the screen to the right,
the menu goes off screen instead of being shifted over to appear on screen.
This problem only occurs on Windows.
Test: ManualTests/win/select-menu-off-screen.html
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
Modified final horizontal position calculation code to position
popup menu on screen if it would otherwise go off.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 00:37:36 +0000 (00:37 +0000)]
Fixed crash in webkitAddKey() when key parameter is null.
https://bugs.webkit.org/show_bug.cgi?id=85444
Patch by David Dorwin <ddorwin@chromium.org> on 2012-07-23
Reviewed by Kentaro Hara.
Reference: Step 1 of http://dvcs.w3.org/hg/html-media/raw-file/
5f76a0b43836/encrypted-media/encrypted-media.html#dom-addkey
Source/WebCore:
Tests: media/encrypted-media/encrypted-media-syntax.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
LayoutTests:
* media/encrypted-media/encrypted-media-syntax-expected.txt:
* media/encrypted-media/encrypted-media-syntax.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 24 Jul 2012 00:36:21 +0000 (00:36 +0000)]
http/tests/multipart/policy-ignore-crash.php is failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=92046
Reviewed by Adam Barth.
Chromium's network layer now shows most text/* mime types. This test was using text/random to
try to trigger a crash when multipart content switch from a text type to a non-text type.
Change the test to use a text type that we don't render.
* http/tests/multipart/policy-ignore-crash.php: Use text/rtf instead of text/random.
* platform/chromium/TestExpectations: Test should be passing again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 24 Jul 2012 00:12:13 +0000 (00:12 +0000)]
A FocusScope for a distributed node should not be its TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=91829
Reviewed by Dimitri Glazkov.
Source/WebCore:
Current implementation of FocusScope::focusScopeOf(Node*) returns
the given node's treeScope(). That does not apply if the node is
a distributed node. We should calculate a FocusScope for a
distributed node by traversing ancestor nodes in Composed Shadow
Tree.
Test: fast/dom/shadow/focus-navigation-with-distributed-nodes.html
* page/FocusController.cpp:
(WebCore::FocusScope::focusScopeOf):
LayoutTests:
* fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt: Added.
* fast/dom/shadow/focus-navigation-with-distributed-nodes.html: Added.
* fast/dom/shadow/resources/shadow-dom.js:
(shouldNavigateFocus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Jul 2012 00:06:23 +0000 (00:06 +0000)]
Null-pointer crash when parsing border-image
https://bugs.webkit.org/show_bug.cgi?id=91963
Patch by Douglas Stockwell <dstockwell@google.com> on 2012-07-23
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/border-image-fill-crash.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImageRepeat): Handle the case where
parseBorderImageRepeat is called when the value list is empty.
LayoutTests:
* fast/css/border-image-fill-crash-expected.txt: Added.
* fast/css/border-image-fill-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 23:56:38 +0000 (23:56 +0000)]
[CSS Exclusions] SVG shape errors should invalidate exclusion shapes
https://bugs.webkit.org/show_bug.cgi?id=91761
Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2012-07-23
Reviewed by Andreas Kling.
Source/WebCore:
CSS exclusion shapes that are specified with negative radiuses or
height/width are now considered invalid and ignored.
Tests added to
LayoutTests/fast/exclusions/parsing-wrap-shape-lengths.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):
LayoutTests:
Test that negative heights. widths, and radiuses are ignored.
* fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
* fast/exclusions/parsing-wrap-shape-lengths.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 23:46:01 +0000 (23:46 +0000)]
[Qt] css3/selectors3 rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92038
Reviewed by Alexis Menard.
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped: These tests are failing because of <input> default size in
WK2, which is different than the expected results generated from WK1. Moved them to
appropriate block in skipped list.
* platform/qt-5.0/Skipped:
* platform/qt/css3/selectors3/html/css3-modsel-21c-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-21c-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-148-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-148-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 23 Jul 2012 23:40:21 +0000 (23:40 +0000)]
Unreviewed gardening. Land pixel results for fast/frames/valid.html on chromium mac snowleopard.
* fast/frames/valid-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/valid-expected.txt.
* platform/chromium-mac-snowleopard/fast/frames/valid-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/gtk/fast/frames/valid-expected.txt: Removed.
* platform/mac/fast/frames/valid-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 23:38:54 +0000 (23:38 +0000)]
[chromium] Implement scrollbar theme for Android
https://bugs.webkit.org/show_bug.cgi?id=91674
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-07-23
Reviewed by Adam Barth.
Previously the scrollbar for Android was implemented as an extra
drawing pass in the compositor. Now we switch to use the standard
ScrollbarTheme mechanism.
No new tests. We use mock scrollbars during layout test to share
pixel results with Linux.
* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::thumbPosition):
(WebCore::ScrollbarThemeChromiumAndroid::thumbLength):
(WebCore::ScrollbarThemeChromiumAndroid::backButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::trackRect):
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(ScrollbarThemeChromiumAndroid):
(WebCore::ScrollbarThemeChromiumAndroid::hasButtons):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Mon, 23 Jul 2012 23:37:10 +0000 (23:37 +0000)]
Unreviewed chromium expectations change to mark test as slow: fast/forms/select-set-length-with-mutation-remove.html.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Mon, 23 Jul 2012 23:33:51 +0000 (23:33 +0000)]
Update website for new hardware.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Mon, 23 Jul 2012 23:15:50 +0000 (23:15 +0000)]
Use the original token to create an element in "reconstruct the active formatting elements" and "call the adoption agency"
https://bugs.webkit.org/show_bug.cgi?id=91703
Reviewed by Adam Barth.
Source/WebCore:
The current WebKit HTML5 parser implementation does not hold the original token
in the stack of open elements and the active formatting elements. This is
problematic because the original token is used to create an element in
"reconstruct the active formatting elements" and "call the adoption agency".
As a workaround, WebKit uses the saved element instead of the original token
to create an element. But this causes us to fail examples like this:
<b id="1"><p><script>document.getElementById("1").id = "2"</script></p>TEXT</b>
reconstructTheActiveFormattingElements calls this method to open a second <b>
tag to wrap TEXT, it will have id "2", even though the HTML5 spec implies it
should be "1".
Created a ref-counted container class, HTMLStackItem to hold the original token
and the namespace URI as well as the element. Changed HTMLElementStack and
HTMLFormattingElementList to use HTMLStackItem.
Changed HTMLConstructionSite::reconstructTheActiveFormattingElements and
HTMLTreeBuilder::callTheAdoptionAgency to create an element from the saved token
instead of the saved element.
Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
* html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::currentElementRecord):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushRootNodeCommon):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::ElementRecord::stackItem):
(ElementRecord):
(HTMLElementStack):
* html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::swapTo):
(WebCore::HTMLFormattingElementList::append):
* html/parser/HTMLFormattingElementList.h:
(WebCore::HTMLFormattingElementList::Entry::Entry):
(WebCore::HTMLFormattingElementList::Entry::isMarker):
(WebCore::HTMLFormattingElementList::Entry::stackItem):
(WebCore::HTMLFormattingElementList::Entry::element):
(WebCore::HTMLFormattingElementList::Entry::replaceElement):
(WebCore::HTMLFormattingElementList::Entry::operator==):
(WebCore::HTMLFormattingElementList::Entry::operator!=):
(Entry):
(HTMLFormattingElementList):
* html/parser/HTMLStackItem.h: Added.
(WebCore):
(HTMLStackItem):
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::element):
(WebCore::HTMLStackItem::node):
(WebCore::HTMLStackItem::token):
(WebCore::HTMLStackItem::namespaceURI):
(WebCore::HTMLStackItem::HTMLStackItem):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
LayoutTests:
Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.
* html5lib/runner-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Mon, 23 Jul 2012 23:06:13 +0000 (23:06 +0000)]
[chromium] Fix unit tests in debug mode after r123375
https://bugs.webkit.org/show_bug.cgi?id=92030
Reviewed by Adrienne Walker.
Fixed two unit tests that were causing debug assertions because
they gave calcDrawTransforms an empty sized root layer.
* tests/CCLayerTreeHostCommonTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rafael.lobo@openbossa.org [Mon, 23 Jul 2012 22:57:31 +0000 (22:57 +0000)]
[Qt] svg/{in-html,overflow,repaint,wicd} needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92023
Unreviewed gardening.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Removed.
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/svg/in-html/by-reference-expected.txt:
* platform/qt/svg/in-html/circle-expected.png:
* platform/qt/svg/in-html/circle-expected.txt:
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.png:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
* platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
* platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
* platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
* platform/qt/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
* platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
* platform/qt/svg/repaint/mask-clip-target-transform-expected.png: Added.
* platform/qt/svg/repaint/text-mask-update-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
* platform/qt/svg/repaint/text-mask-update-expected.txt: Added.
* platform/qt/svg/wicd/rightsizing-grid-expected.png:
* platform/qt/svg/wicd/rightsizing-grid-expected.txt:
* platform/qt/svg/wicd/sizing-flakiness-expected.txt:
* platform/qt/svg/wicd/test-rightsizing-a-expected.png:
* platform/qt/svg/wicd/test-rightsizing-a-expected.txt:
* platform/qt/svg/wicd/test-rightsizing-b-expected.png:
* platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
* platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
* platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
* platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
* platform/qt/svg/wicd/test-scalable-background-image2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 23 Jul 2012 22:56:30 +0000 (22:56 +0000)]
Report the extra memory used by immutable StylePropertySet objects.
<http://webkit.org/b/92032>
Reviewed by Anders Carlsson.
Add an optional parameter to the MemoryClassInfo constructor for passing in additional base object
size on top of sizeof(T).
Use this in StylePropertySet::reportMemoryUsage() to properly account for the CSSProperty array
tacked onto the end of the object when m_isMutable == false.
* css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 22:53:25 +0000 (22:53 +0000)]
Fix WebGL texSubImage2D for cube maps
https://bugs.webkit.org/show_bug.cgi?id=91927
Patch by Gregg Tavares <gman@google.com> on 2012-07-23
Reviewed by Kenneth Russell.
Source/WebCore:
Fixes texSubImage2D so any size rectangle can be passed in
for cube maps.
Test: fast/canvas/webgl/tex-sub-image-cube-maps.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
LayoutTests:
Tests for WebGL texSubImage2D for cube maps.
* fast/canvas/webgl/tex-sub-image-cube-maps-expected.txt: Added.
* fast/canvas/webgl/tex-sub-image-cube-maps.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 23 Jul 2012 22:46:14 +0000 (22:46 +0000)]
DFG is too aggressive in performing the specific value optimization on loads
https://bugs.webkit.org/show_bug.cgi?id=92034
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This ensures that we don't do optimizations based on a structure having a specific
value, if there is no way to detect that the value is despecified. This is the
case for dictionaries, since despecifying a value in a dictionary does not lead to
a transition and so cannot be caught by either structure checks or structure
transition watchpoints.
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
* bytecode/ResolveGlobalStatus.cpp:
(JSC::computeForStructure):
LayoutTests:
* fast/js/dfg-resolve-global-polymorphic-non-dictionary-expected.txt: Added.
* fast/js/dfg-resolve-global-polymorphic-non-dictionary.html: Added.
* fast/js/dfg-resolve-global-specific-dictionary-expected.txt: Added.
* fast/js/dfg-resolve-global-specific-dictionary.html: Added.
* fast/js/script-tests/dfg-resolve-global-polymorphic-non-dictionary.js: Added.
(description.foo):
* fast/js/script-tests/dfg-resolve-global-specific-dictionary.js: Added.
(description.foo):
(x):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 23 Jul 2012 22:38:30 +0000 (22:38 +0000)]
REGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code.html fail on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=92002
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
In the process of changing the nature of local variable typing, I forgot to modify one of the places where
we glue the DFG's notion of variable prediction to the runtime's notion of variable tagging.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Unskip test that this change fixes, as requested by Ossy.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 22:36:43 +0000 (22:36 +0000)]
Unreviewed, rolling out r123387.
http://trac.webkit.org/changeset/123387
https://bugs.webkit.org/show_bug.cgi?id=92036
Broke chromium win build (Requested by tony^work on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/rule_bison.py:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
* make-hash-tools.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 22:34:11 +0000 (22:34 +0000)]
[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541
Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.
PR# 181304.
Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
reload and history navigation can work.
Other changes: Remove about:version which makes little sense. Make about:memory partially visible.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()
* Api/WebPage_p.h: Remove loadAbout()
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.
* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::numberToHTMLTr): Make it static
(BlackBerry::WebKit::configPage): Make it static
(BlackBerry::WebKit::memoryPage): Make it static
(BlackBerry::WebKit::cachePage):
(BlackBerry::WebKit::buildPage):
(BlackBerry::WebKit::creditsPage):
(BlackBerry::WebKit::cookiePage):
(BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
(WebKit):
* WebKitSupport/AboutData.h:
(WebKit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 23 Jul 2012 22:09:51 +0000 (22:09 +0000)]
Unreviewed, rolling out r123360.
http://trac.webkit.org/changeset/123360
https://bugs.webkit.org/show_bug.cgi?id=91890
broke the chromium bots
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_build_path):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Mon, 23 Jul 2012 22:02:09 +0000 (22:02 +0000)]
Ref-count AtomicHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=91981
Reviewed by Adam Barth.
Ref-count AtomicHTMLToken to avoid copying AtomicHTMLToken in Bug 91703.
No new tests - no functional changes.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
* html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::create):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
(WebCore::HTMLTreeBuilder::parseError):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Mon, 23 Jul 2012 21:54:30 +0000 (21:54 +0000)]
More unreviewed chromium expectation changes to mark tests as failing/slow.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 23 Jul 2012 21:52:00 +0000 (21:52 +0000)]
Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667
Patch by Scott Graham <scottmg@google.com> on 2012-07-23
Reviewed by Tony Chang.
Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).
Also, use - instead of / for cl flags because a layer of project
generator converts them to \ otherwise, which causes the preprocessing
to fail (very slowly because of the cygwin-loop with a sleep 1).
No new tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/rule_bison.py:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
* make-hash-tools.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 23 Jul 2012 21:39:19 +0000 (21:39 +0000)]
MediaController.currentTime should be kept stable during script execution.
https://bugs.webkit.org/show_bug.cgi?id=88555
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-controller-time-constant.html
To keep MediaController.currentTime stable, add a new m_position variable and
a new m_clearPositionTimer timer. Both must be mutable variables as they will
be updated from within const functions. Calls to currentTime() will result in
stable values until the next runloop iteration.
* html/MediaController.cpp:
(MediaController::MediaController):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::clearPositionTimerFired):
* html/MediaController.h:
LayoutTests:
* media/media-controller-time-constant-expected.txt: Added.
* media/media-controller-time-constant.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Mon, 23 Jul 2012 21:38:06 +0000 (21:38 +0000)]
Destroy CSS decoded data more eagerly once they become dead caches.
https://bugs.webkit.org/show_bug.cgi?id=91733
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-23
Reviewed by Geoffrey Garen.
Internal review by Kwang Yul Seo.
There are three CachedResources with decoded data: CachedImage, CachedScript
and CachedCSSStyleSheet. In the cases of CachedImage and CachedScript, we
eagerly destroy the decoded data using Timer in CacehdResource::allClientsRemoved().
We must apply the same policy here in CachedCSSStyleSheet because priority
inversion can occur. For example, we can't destroy the decoded data of CachedImages
when they are referenced by CachedCSSStyleSheet as background, mask or border
images.
No new tests - no new testable functionality.
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 23 Jul 2012 21:24:22 +0000 (21:24 +0000)]
[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459
Reviewed by Ryosuke Niwa.
Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.
* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::accessibilityController):
(TestShell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 21:23:29 +0000 (21:23 +0000)]
[Qt] dom/xhtml/level3/core rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92028
Unreviewed.
* platform/qt-5.0/Skipped:
* platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
* platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
* platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 23 Jul 2012 21:21:25 +0000 (21:21 +0000)]
nrwt swallows early exceptions
https://bugs.webkit.org/show_bug.cgi?id=91884
Reviewed by Dirk Pranke.
Put everything in a try block so we won't miss any error.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 23 Jul 2012 21:03:45 +0000 (21:03 +0000)]
Part 2 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Source/JavaScriptCore:
Turn on ENABLE_CSS_STICKY_POSITION.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Turn on ENABLE_CSS_STICKY_POSITION. Add support for parsing the new '-webkit-sticky'
value for position, returning it from getComputedStyle(), and storing it in RenderStyle.
Test: fast/css/sticky/parsing-position-sticky.html
* Configurations/FeatureDefines.xcconfig:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPosition):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
Source/WebKit/chromium:
Turn on ENABLE_CSS_STICKY_POSITION.
* features.gypi:
Source/WebKit/mac:
Turn on ENABLE_CSS_STICKY_POSITION.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Turn on ENABLE_CSS_STICKY_POSITION.
* Configurations/FeatureDefines.xcconfig:
LayoutTests:
Test for parsing and returning fro getComputedStyle() the new
-webkit-sticky value for position.
* fast/css/sticky/parsing-position-sticky-expected.txt: Added.
* fast/css/sticky/parsing-position-sticky.html: Added.
* fast/css/sticky/resources/parsing-position-sticky.js: Added.
(test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Mon, 23 Jul 2012 21:03:15 +0000 (21:03 +0000)]
Unreviewed chromium expectations change to mark media/media-fragments/TC0010-TC0019.html as flaky/crashy.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 23 Jul 2012 20:57:13 +0000 (20:57 +0000)]
Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024
Reviewed by Andreas Kling.
Source/WebCore:
Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.
Test: svg/custom/empty-className-baseVal-crash.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()
LayoutTests:
Add a check for null attributeData() when setting the className to an
empty string on a newly created element.
* svg/custom/empty-className-baseVal-crash-expected.txt: Added.
* svg/custom/empty-className-baseVal-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 23 Jul 2012 20:53:35 +0000 (20:53 +0000)]
Move JSC::parseDate() from DateConversion to JSDateMath
https://bugs.webkit.org/show_bug.cgi?id=91982
Reviewed by Geoffrey Garen.
Moveing this function into the other files removes the dependency
on JSC spcific classes in DateConversion.{cpp|h}.
* runtime/DateConversion.cpp:
* runtime/DateConversion.h:
(JSC):
* runtime/JSDateMath.cpp:
(JSC::parseDate):
(JSC):
* runtime/JSDateMath.h:
(JSC):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Mon, 23 Jul 2012 20:46:11 +0000 (20:46 +0000)]
[chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design
https://bugs.webkit.org/show_bug.cgi?id=80622
Reviewed by Adrienne Walker.
Source/WebCore:
clipRect(), usesLayerClipping(), and drawableContentRect() have been
very confusing in CCLayerTreeHostCommon for a while. This patch
refactors it so that (1) clipping is only done locally in
calcDrawTransforms, and (2) the layer's drawableContentRect value
is now meaningful value outside of calcDrawTransforms.
Additionally, the layer is now always clipped to the root
surface's contentBounds (which are set to the viewport bounds).
This refactor not only makes calcDrawTransforms far more readable and intuitive, but
this patch enables more upcoming beneficial refactors, including
the pending refactor in https://bugs.webkit.org/show_bug.cgi?id=88953.
Tests are also significantly updated to keep up with this refactoring change.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
Removed m_usesLayerClipping and m_clipRect and associated accessors.
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
Updated comment
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
Removed m_usesLayerClipping and m_clipRect and associated accessors.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
removed setClipRect code that no longer applies
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateLayerScissorRect):
scissor rect is now a little bit tighter, the intersection between damage and layer's new drawableContentRect.
(WebCore::calculateSurfaceScissorRect):
scissor rect is now a little bit tighter, except when filters are involved.
(WebCore::layerClipsSubtree):
new helper function
(WebCore):
(WebCore::calculateVisibleContentRect):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsInternal):
- added drawableContentRectOfSubtree to the function args, it is valid only after recursion returns,
- added clipRectFromAncestor and bool ancestorClipsSubtree to function args, this replaces the layer's clipRect and usesLayerClipping.
- removed the boolean return value, which was redundant with drawableContentRectOfSubtree.
- replaced all the "setDrawableContentRect" logic with more intuitive, clear logic.
- now, layer's drawableContentRect represents the clipped bounds of the layer expressed in the target surface space.
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::pointIsClippedBySurfaceOrClipRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::layerScissorRectInTargetSurface):
Updated this accessor. It could be removed in the future, but not appropriate for this patch.
* platform/graphics/chromium/cc/CCRenderSurface.h:
Source/WebKit/chromium:
Many tests needed to be updated because the semantics of the layer tree have changed:
- a few tests that were no longer applicable were removed.
- many tests needed to have fixed initialization, properly
setting surface contentRect and rootLayer bounds.
- because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed
- the scissorRect tests needed to have updated expectations
because after this patch, the rootLayer Surface now clips
to its contentBounds.
- the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead.
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerIteratorTest.cpp:
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
* tests/LayerChromiumTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 20:37:39 +0000 (20:37 +0000)]
[WK2] WebKitTestRunner needs to print information about Web intents
https://bugs.webkit.org/show_bug.cgi?id=90873
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Anders Carlsson.
Source/WebKit2:
Add Bundle API for Web Intents. This is needed by the WebKitTestRunner
to print information about the new intent requests and the intent
service registrations.
* CMakeLists.txt: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
* GNUmakefile.list.am: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
* Shared/APIClientTraits.h:
* Shared/WebIntentData.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentData.cpp.
(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::extra):
(WebKit::WebIntentData::extras):
* Shared/WebIntentData.h: Renamed from Source/WebKit2/UIProcess/WebIntentData.h.
(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::service):
(WebKit::WebIntentData::store):
(WebKit::WebIntentData::type):
* Shared/WebIntentServiceInfo.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.cpp.
(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
* Shared/WebIntentServiceInfo.h: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.h.
(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):
* Target.pri: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(registerIntentServiceForFrame):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveIntentForFrame):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerIntentServiceForFrame):
(WebKit::WebPageProxy::didReceiveIntentForFrame):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit):
(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):
(WebKit::InjectedBundlePageLoaderClient::registerIntentServiceForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(WebKit):
(InjectedBundlePageLoaderClient):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchIntent):
(WebKit::WebFrameLoaderClient::registerIntentService):
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
Print out information about new intents requests and intent
services registrations in WebKitTestRunner. This is expected
by tests under webintents/*.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 20:32:16 +0000 (20:32 +0000)]
[Qt] tables/mozilla_expected_failures rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92013
Unreviewed.
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Jul 2012 20:26:00 +0000 (20:26 +0000)]
[EFL][WK2] Add unit tests for Ewk_Cookie_Manager
https://bugs.webkit.org/show_bug.cgi?id=91639
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Antonio Gomes.
Add unit tests for Ewk_Cookie_Manager.
* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_cookie_manager.h: Fix "accept policy" documentation
to indicate that only cookies set by the main document are accepted by default.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp: Added.
(EWK2UnitTestServer::EWK2UnitTestServer): Add HTTP server similar to the one
used by GTK port unit tests.
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::run):
(EWK2UnitTestServer::getURIForPath):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h: Added.
(EWK2UnitTestServer):
(EWK2UnitTestServer::baseURI):
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Added.
(serverCallback):
(getAcceptPolicyCallback):
(getAcceptPolicy):
(getHostnamesWithCookiesCallback):
(getHostnamesWithCookies):
(freeHostNames):
(countHostnamesWithCookies):
(TEST_F):
(cleanUpCookieFiles):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 23 Jul 2012 20:23:47 +0000 (20:23 +0000)]
Build fix if NOMINMAX is defined by the build system.
* COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
* COMPropertyBag.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Mon, 23 Jul 2012 20:22:29 +0000 (20:22 +0000)]
[chromium] Fix build on Ubuntu Precise.
https://bugs.webkit.org/show_bug.cgi?id=92021
Reviewed by Adrienne Walker.
Remove an array that's written but never read.
* tests/CCResourceProviderTest.cpp:
(WebKit::TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 23 Jul 2012 20:16:27 +0000 (20:16 +0000)]
[CMAKE] Added missing RenderLayerFilterInfo.cpp to build system.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Mon, 23 Jul 2012 20:06:19 +0000 (20:06 +0000)]
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017
Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-07-23
Reviewed by Alexis Menard.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 23 Jul 2012 20:01:31 +0000 (20:01 +0000)]
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017
Reviewed by Alexis Menard.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rafael.lobo@openbossa.org [Mon, 23 Jul 2012 19:54:49 +0000 (19:54 +0000)]
[Qt] svg/zoom needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92007
Reviewed by Alexis Menard.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/qt/Skipped:
* platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-background-images-expected.png:
* platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
* platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
* platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc