WebKit-https.git
9 years ago[chromium] Rebaseline after r107881
loislo@chromium.org [Thu, 16 Feb 2012 13:59:58 +0000 (13:59 +0000)]
[chromium] Rebaseline after r107881

* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 13:48:16 +0000 (13:48 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #21 of N.

* platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
* platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png:
* platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
* platform/mac/fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png.
* platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for unsigned long[] to idl bindings to JSC.
commit-queue@webkit.org [Thu, 16 Feb 2012 13:46:34 +0000 (13:46 +0000)]
Add support for unsigned long[] to idl bindings to JSC.
https://bugs.webkit.org/show_bug.cgi?id=78210

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-16
Reviewed by Kentaro Hara.

Add support for unsigned long[] parameter type in idl.
This patch adds support just for unsigned long[] parameter type.
(support for other types of array should be done in another patch.)

tests added to TestObj.idl.

* bindings/js/JSDOMBinding.h:
(WebCore::jsUnsignedLongArrayToVector):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [InspectorIndexedDB] Add IndexedDB TreeElement to resources panel.
vsevik@chromium.org [Thu, 16 Feb 2012 13:30:00 +0000 (13:30 +0000)]
Web Inspector: [InspectorIndexedDB] Add IndexedDB TreeElement to resources panel.
https://bugs.webkit.org/show_bug.cgi?id=78609

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added IndexedDB tree element to resources panel (behind experimental setting).
Test is currently disabled, since we don't run tests with experiments enabled.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* inspector/front-end/Images/indexedDB.png: Added.
* inspector/front-end/Images/indexedDBIndex.png: Added.
* inspector/front-end/Images/indexedDBObjectStore.png: Added.
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype.refreshDatabase):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._databaseAdded):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.DatabaseId):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.Index):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onexpand):
(WebInspector.IndexedDBTreeElement.prototype._createIndexedDBModel):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.update):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/resourcesPanel.css:
(.indexed-db-storage-tree-item .icon):
(.indexed-db-object-store-storage-tree-item .icon):
(.indexed-db-index-storage-tree-item .icon):

LayoutTests:

* http/tests/inspector/indexeddb/database-data-expected.txt:
* http/tests/inspector/indexeddb/database-data.html:
* http/tests/inspector/indexeddb/database-names-expected.txt:
* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/database-structure.html:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest.dumpIndexedDBTree):
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
(createDatabase.closeDatabase):
(createDatabase):
(deleteDatabase):
* http/tests/inspector/indexeddb/resources-panel-expected.txt: Added.
* http/tests/inspector/indexeddb/resources-panel.html_disabled: Added.
* http/tests/inspector/indexeddb/resources/without-indexed-db.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 16 Feb 2012 13:07:36 +0000 (13:07 +0000)]
2012-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing results for Lion, and regenerate one test result with Lion,
        so my baseline passes again with --tolerance 0 -p svg.

        * platform/mac/svg/text/text-fill-opacity-expected.png: Added.
        * platform/mac/svg/text/text-fill-opacity-expected.txt: Added.
        * platform/mac/svg/text/tspan-dynamic-positioning-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effect...
zimmermann@webkit.org [Thu, 16 Feb 2012 12:58:42 +0000 (12:58 +0000)]
REGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effects.xhtml
https://bugs.webkit.org/show_bug.cgi?id=65072

Reviewed by Zoltan Herczeg.

Source/WebCore:

Fix EMS/EXS length resolving, when the target context has no renderer, eg.
<text display="none" dy="1em">ABC</text>, myText.dy.baseVal.getItem(0).value()
currently throws, even if <text> has a parent, we could use to resolve the length.

Always fall-back to parent context, to resolve EMS/EXS units, instead of ignoring it.
The current behaviour stays the same, if the target element is not in the document,
then we really can't resolve lengths like this.

Tests: svg/text/ems-display-none.svg
       svg/text/exs-display-none.svg

* svg/SVGLengthContext.cpp:
(WebCore::renderStyleForLengthResolving):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
(WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS):
(WebCore::SVGLengthContext::convertValueFromEXSToUserUnits):

LayoutTests:

* platform/chromium/test_expectations.txt:
* platform/mac/svg/text/ems-display-none-expected.png: Added.
* platform/mac/svg/text/ems-display-none-expected.txt: Added.
* platform/mac/svg/text/exs-display-none-expected.png: Added.
* platform/mac/svg/text/exs-display-none-expected.txt: Added.
* svg/text/ems-display-none.svg: Added.
* svg/text/exs-display-none.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for Qt 5 without QtWidgets.
hausmann@webkit.org [Thu, 16 Feb 2012 12:46:12 +0000 (12:46 +0000)]
Build fix for Qt 5 without QtWidgets.

Reviewed by Tor Arne Vestbø.

The reason why QGLContext is included in Extensions3DQt.cpp is to
achieve an implicit gl.h inclusion (needed for GL_FALSE). This patch
replaces the inclusion with the OpenGLShims.h inclusions, which has
the necessary #ifdefs in place to pull in gl.h with Qt 5 without QtWidgets.

* platform/graphics/qt/Extensions3DQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Refactor CCLayerTreeHostCommon: create helper function for complex boolean...
shawnsingh@chromium.org [Thu, 16 Feb 2012 12:15:50 +0000 (12:15 +0000)]
[chromium] Refactor CCLayerTreeHostCommon: create helper function for complex boolean condition
https://bugs.webkit.org/show_bug.cgi?id=78539

Reviewed by James Robinson.

This change should introduce no change in behavior, and its
expected behavior is already covered by existing tests.

In calculateDrawTransformsAndVisibility, there is a complex
boolean condition that indicates whether we should create a
RenderSurface or not. This patch pulls out that boolean logic,
and wraps it in a helper function for much better readability.

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [refactoring] move timeline overview sidebar creation to TimelineOverv...
caseq@chromium.org [Thu, 16 Feb 2012 12:11:33 +0000 (12:11 +0000)]
Web Inspector: [refactoring] move timeline overview sidebar creation to TimelineOverviewPane
https://bugs.webkit.org/show_bug.cgi?id=78782

Reviewed by Vsevolod Vlasov.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.showTimelines):
(WebInspector.TimelineOverviewPane.prototype.showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShare font-family CSS values through CSSValuePool.
kling@webkit.org [Thu, 16 Feb 2012 11:05:24 +0000 (11:05 +0000)]
Share font-family CSS values through CSSValuePool.
<http://webkit.org/b/78604>

Reviewed by Darin Adler.

Cache and share FontFamilyValue instances in the per-document CSSValuePool.
This reduces memory consumption by 248 kB on the Moz page cycler (64-bit)
and avoids a bunch of extra work.

This is a regression from the recent attribute style refactoring; previously
the mapped attribute declaration table would ensure that multiple 'font'
elements with the same 'face' value would share the same FontFamilyValue.

We're not yet sharing the entire CSSValueList returned by parseFontFamily()
but this is a step on the way there.

* css/FontFamilyValue.cpp:
* css/FontFamilyValue.h:

    Removed appendSpaceSeparated(), making FontFamilyValue immutable.

* css/CSSParser.cpp:
(FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::add):
(WebCore::FontFamilyValueBuilder::commit):
(WebCore::CSSParser::parseFontFamily):

    Refactor parseFontFamily() to defer creation of FontFamilyValue until
    the whole family name is known. Added a little helper class to avoid
    code duplication.

* css/CSSValuePool.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):

    Added a FontFamilyValue cache to CSSValuePool. All values are tied to
    the lifetime of the pool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed brown-paper bag build fix.
hausmann@webkit.org [Thu, 16 Feb 2012 10:47:32 +0000 (10:47 +0000)]
Unreviewed brown-paper bag build fix.

* WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild Fix: R107894 breaks Chromium Linux Build.
tkent@chromium.org [Thu, 16 Feb 2012 10:46:20 +0000 (10:46 +0000)]
Build Fix: R107894 breaks Chromium Linux Build.
https://bugs.webkit.org/show_bug.cgi?id=78790

WebDragDataPrivate::types, inherited from ChromiumDataObject, returns PassRef<DOMStringList> since r107894. However, WebDragData expected to get old return value type HashSet<String>.

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-16
Reviewed by Kent Tamura.

* src/WebDragData.cpp:
(WebKit::WebDragData::items): Use RefPtr<DOMStringList> rather than HashSet<String> for value of m_private->types().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 16 Feb 2012 10:34:04 +0000 (10:34 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip new failing tests.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r107869.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r107869.
* platform/qt/fast/js/global-constructors-expected.txt: Updated after r107869.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Move event conversion functions from WebCore to WebKit
hausmann@webkit.org [Thu, 16 Feb 2012 10:31:01 +0000 (10:31 +0000)]
[Qt] Move event conversion functions from WebCore to WebKit
https://bugs.webkit.org/show_bug.cgi?id=78788

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/api.pri: Add new files to the build.

Source/WebCore:

Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.

* Target.pri:
* platform/PlatformMouseEvent.h:
(PlatformMouseEvent):
* platform/PlatformWheelEvent.h:
(PlatformWheelEvent):

Source/WebKit/qt:

Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.

* Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPage::swallowContextMenuEvent):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
* WebCoreSupport/WebEventConversion.cpp: Added.
(WebCore):
(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
(WebKitPlatformMouseEvent):
(WebCore::WebKitPlatformMouseEvent::WebKitPlatformMouseEvent):
(WebCore::convertMouseEvent):
(WebKitPlatformWheelEvent):
(WebCore::WebKitPlatformWheelEvent::applyDelta):
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
(WebCore::convertWheelEvent):
* WebCoreSupport/WebEventConversion.h: Added.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
hausmann@webkit.org [Thu, 16 Feb 2012 10:28:39 +0000 (10:28 +0000)]
[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=73215

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Adding a class to access security information data
(e.g. port/scheme/etc),
while allowing it to be handled in QML side.

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Introducing a new class to expose security origin information
(port/scheme/etc), useful for inspecting the origin of permission
requests.

* Target.pri:
* UIProcess/API/qt/qtwebsecurityorigin.cpp: Added.
(QtWebSecurityOrigin::QtWebSecurityOrigin):
(QtWebSecurityOrigin::~QtWebSecurityOrigin):
(QtWebSecurityOrigin::host):
(QtWebSecurityOrigin::scheme):
(QtWebSecurityOrigin::path):
(QtWebSecurityOrigin::port):
(QtWebSecurityOrigin::setHost):
(QtWebSecurityOrigin::setScheme):
(QtWebSecurityOrigin::setPath):
(QtWebSecurityOrigin::setPort):
* UIProcess/API/qt/qtwebsecurityorigin_p.h: Added.
* UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Added.
* UIProcess/API/qt/qwebpermissionrequest.cpp:
(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequest::securityOrigin):
* UIProcess/API/qt/qwebpermissionrequest_p.h:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed prospective Qt 4.8/Mac build fix.
hausmann@webkit.org [Thu, 16 Feb 2012 10:06:38 +0000 (10:06 +0000)]
Unreviewed prospective Qt 4.8/Mac build fix.

Cast the PlatformWidget from QObject* to QWidget* to gain access
to QWidget methods.

* plugins/mac/PluginViewMac.mm:
(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should not check the types of arguments that are dead
fpizlo@apple.com [Thu, 16 Feb 2012 10:06:28 +0000 (10:06 +0000)]
DFG should not check the types of arguments that are dead
https://bugs.webkit.org/show_bug.cgi?id=78518

Reviewed by Geoff Garen.

The argument checks are now elided if the corresponding SetArgument is dead,
and the abstract value of the argument is set to bottom (None, []). This is
performance neutral on the benchmarks we currently track.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<style scoped>: Implement scoped selector matching in the slow path
rolandsteiner@chromium.org [Thu, 16 Feb 2012 09:31:17 +0000 (09:31 +0000)]
<style scoped>: Implement scoped selector matching in the slow path
https://bugs.webkit.org/show_bug.cgi?id=77528

Source/WebCore:

Added scope information to SelectorCheckingContext, SelectorChecker methods and CSSStyleSelector methods.
Added matchOptions struct to CSSStyleSelector similar to SelectorCheckingContext in SelectorChecker.
Adapted the calling sites.

Reviewed by Antti Koivisto.

No new tests. (extended existing tests)

* css/CSSStyleSelector.cpp:
(RuleData):
(RuleSet):
(WebCore::CSSStyleSelector::determineScopingElement):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
(MatchOptions):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):

LayoutTests:

Extended existing <style scoped> tests to also verify that selector matching doesn't exceed the scoping element.

Reviewed by Antti Koivisto.

* fast/css/style-scoped/style-scoped-basic-expected.txt:
* fast/css/style-scoped/style-scoped-basic.html:
* fast/css/style-scoped/style-scoped-remove-scoped-expected.txt:
* fast/css/style-scoped/style-scoped-remove-scoped.html:
* fast/css/style-scoped/style-scoped-set-scoped-expected.txt:
* fast/css/style-scoped/style-scoped-set-scoped.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 09:15:53 +0000 (09:15 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #20 of N.

* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 08:50:21 +0000 (08:50 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #19 of N.

* platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
* platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable inspector on WinCE.
paroga@webkit.org [Thu, 16 Feb 2012 08:44:08 +0000 (08:44 +0000)]
Disable inspector on WinCE.

Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit: [CMake] Add missing include directories.
paroga@webkit.org [Thu, 16 Feb 2012 08:42:54 +0000 (08:42 +0000)]
Source/WebKit: [CMake] Add missing include directories.

* CMakeLists.txt:

Source/WebKit2: [CMake] Add missing include directories.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWinCE build fix after r107656.
paroga@webkit.org [Thu, 16 Feb 2012 08:40:19 +0000 (08:40 +0000)]
WinCE build fix after r107656.

Disable FTPDIR on WinCE, since it does not compile there.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 08:31:35 +0000 (08:31 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #18 of N.

* platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
* platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Document that local paths in html loaded with loadHTML might cause the web...
carlosgc@webkit.org [Thu, 16 Feb 2012 08:26:10 +0000 (08:26 +0000)]
[GTK] Document that local paths in html loaded with loadHTML might cause the web process to terminate
https://bugs.webkit.org/show_bug.cgi?id=78719

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 08:22:34 +0000 (08:22 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #17 of N.

* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 08:13:37 +0000 (08:13 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #16 of N.

* platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29314-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png: Removed.
* platform/chromium-win/tables/mozilla/bugs/bug29314-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
* tables/mozilla/bugs/bug29314-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug29314-expected.txt.
* tables/mozilla/bugs/bug50695-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug50695-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 08:01:31 +0000 (08:01 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #15 of N.

* platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1271-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-1-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
* platform/chromium-win/tables/mozilla/bugs/bug1271-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/tables/mozilla/bugs/bug1271-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug13169-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug1271-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug13169-expected.txt: Removed.
* tables/mozilla/bugs/bug1271-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug1271-expected.txt.
* tables/mozilla/bugs/bug13169-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug13169-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix for !ENABLE(CSS_FILTERS) after r106593.
paroga@webkit.org [Thu, 16 Feb 2012 07:50:48 +0000 (07:50 +0000)]
Windows build fix for !ENABLE(CSS_FILTERS) after r106593.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove the context invalidation code out from StylePropertySet
antti@apple.com [Thu, 16 Feb 2012 07:39:17 +0000 (07:39 +0000)]
Move the context invalidation code out from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=78589

Reviewed by Ryosuke Niwa.

StylePropertySet should be independent of its context so that they can in the future
be shared between documents. The context invalidation code should move to the CSSOM wrapper.

Parent rule and parent element pointers move to the CSSOM wrapper classes.

The wrapper is responsible of invalidating the element or document style on mutation.
In case of internal mutation of style attribute, StyledElement takes care of the
invalidation.

The StylePropertySet will still have a pointer to the context stylesheet so the patch
doesn't actually reduce memory usage. That pointer will be factored out later.

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
* css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::style):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::~CSSPageRule):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::setDeclaration):
* css/CSSParser.cpp:
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::~CSSStyleRule):
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
* css/StylePropertySet.cpp:
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(WebCore):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureRuleCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::useStrictParsing):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::setContextStyleSheet):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
* css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::style):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/StyledElement.cpp:
(WebCore::StyledElement::insertedIntoDocument):
(WebCore):
(WebCore::StyledElement::removedFromDocument):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::updateAttributeStyle):
* dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):
* editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
* editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::updateColorSwatch):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
* html/shadow/MeterShadowElement.cpp:
(WebCore::MeterValueElement::setWidthPercentage):
* html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressValueElement::setWidthPercentage):
* html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r107814.
ossy@webkit.org [Thu, 16 Feb 2012 07:39:07 +0000 (07:39 +0000)]
[Qt] Unreviewed gardening after r107814.

* platform/qt/css3/filters/effect-blur-hw-expected.png:
* platform/qt/css3/filters/effect-blur-hw-expected.txt:
* platform/qt/css3/filters/effect-combined-expected.png:
* platform/qt/css3/filters/effect-combined-expected.txt:
* platform/qt/css3/filters/effect-combined-hw-expected.png:
* platform/qt/css3/filters/effect-combined-hw-expected.txt:
* platform/qt/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt:
* platform/qt/css3/filters/effect-grayscale-hw-expected.png:
* platform/qt/css3/filters/effect-grayscale-hw-expected.txt:
* platform/qt/css3/filters/effect-hue-rotate-hw-expected.png:
* platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt:
* platform/qt/css3/filters/effect-invert-hw-expected.png:
* platform/qt/css3/filters/effect-invert-hw-expected.txt:
* platform/qt/css3/filters/effect-opacity-hw-expected.png:
* platform/qt/css3/filters/effect-opacity-hw-expected.txt:
* platform/qt/css3/filters/effect-saturate-hw-expected.png:
* platform/qt/css3/filters/effect-saturate-hw-expected.txt:
* platform/qt/css3/filters/effect-sepia-hw-expected.png:
* platform/qt/css3/filters/effect-sepia-hw-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodataTransfer.types (HTML5 drag & drop) should return DOMStringList
ossy@webkit.org [Thu, 16 Feb 2012 07:38:31 +0000 (07:38 +0000)]
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416

Reviewed by Eric Seidel.

Source/WebCore:

This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.

Test: fast/events/drag-dataTransfer-live-attributes.html

* bindings/js/JSClipboardCustom.cpp:
(WebCore):
* bindings/v8/custom/V8ClipboardCustom.cpp:
* dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
* dom/Clipboard.h:
(WebCore):
(Clipboard):
* dom/Clipboard.idl:
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
* platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
* platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
* platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h:
(ClipboardEfl):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
* platform/mac/ClipboardMac.h:
(ClipboardMac):
* platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h:
(ClipboardQt):
* platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h:
(ClipboardWin):
* platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
* platform/wx/ClipboardWx.h:
(ClipboardWx):

LayoutTests:

Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().

* editing/pasteboard/clipboard-customData.html:
* editing/pasteboard/onpaste-text-html-types.html:
* fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
* fast/events/drag-customData.html:
* fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
* fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
* http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
* http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCE build fix after r107606.
paroga@webkit.org [Thu, 16 Feb 2012 07:37:55 +0000 (07:37 +0000)]
Unreviewed WinCE build fix after r107606.

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::createPasteboardStrategy):
* WebCoreSupport/PlatformStrategiesWinCE.h:
(PlatformStrategiesWinCE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRepaint issues on changing 'viewBox' of inner SVG
ossy@webkit.org [Thu, 16 Feb 2012 07:28:18 +0000 (07:28 +0000)]
Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903

Source/WebCore:

Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.

Test: svg/repaint/inner-svg-change-viewBox-contract.svg

* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
* rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):

LayoutTests:

Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.

Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

* platform/chromium/test_expectations.txt:
* svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
* svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
* svg/repaint/inner-svg-change-viewBox-contract.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodataTransfer.types (HTML5 drag & drop) should return DOMStringList
dcheng@chromium.org [Thu, 16 Feb 2012 07:26:18 +0000 (07:26 +0000)]
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416

Reviewed by Eric Seidel.

Source/WebCore:

This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.

Test: fast/events/drag-dataTransfer-live-attributes.html

* bindings/js/JSClipboardCustom.cpp:
(WebCore):
* bindings/v8/custom/V8ClipboardCustom.cpp:
* dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
* dom/Clipboard.h:
(WebCore):
(Clipboard):
* dom/Clipboard.idl:
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
* platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
* platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
* platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h:
(ClipboardEfl):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
* platform/mac/ClipboardMac.h:
(ClipboardMac):
* platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h:
(ClipboardQt):
* platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h:
(ClipboardWin):
* platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
* platform/wx/ClipboardWx.h:
(ClipboardWx):

LayoutTests:

Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().

* editing/pasteboard/clipboard-customData.html:
* editing/pasteboard/onpaste-text-html-types.html:
* fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
* fast/events/drag-customData.html:
* fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
* fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
* http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
* http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRepaint issues on changing 'viewBox' of inner SVG
commit-queue@webkit.org [Thu, 16 Feb 2012 07:16:34 +0000 (07:16 +0000)]
Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903

Source/WebCore:

Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.

Test: svg/repaint/inner-svg-change-viewBox-contract.svg

* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
* rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):

LayoutTests:

Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.

Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.

* platform/chromium/test_expectations.txt:
* svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
* svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
* svg/repaint/inner-svg-change-viewBox-contract.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r107811.
ossy@webkit.org [Thu, 16 Feb 2012 07:14:09 +0000 (07:14 +0000)]
[Qt] Unreviewed gardening after r107811.

* platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
* platform/qt/plugins/application-plugin-plugins-disabled-expected.txt:
* platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
* platform/qt/plugins/netscape-dom-access-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix unused parameter warnings.
andersca@apple.com [Thu, 16 Feb 2012 07:12:19 +0000 (07:12 +0000)]
Fix unused parameter warnings.

* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove ResourceHolderImpl.cpp from build system
leo.yang@torchmobile.com.cn [Thu, 16 Feb 2012 07:05:34 +0000 (07:05 +0000)]
[BlackBerry] Remove ResourceHolderImpl.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=78779

Reviewed by George Staikos.

blackberry/Api/ResourceHolderImpl.cpp which hasn't been upstreamed
has been removed internally. So remove it from the build system.

* blackberry/CMakeListsBlackBerry.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
eae@chromium.org [Thu, 16 Feb 2012 07:04:15 +0000 (07:04 +0000)]
Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78526

Reviewed by Eric Seidel.

Revert paintColumnBorder and paintRowBorder to IntRect and pixel snap in
paint before calling them. This way the rounding logic is contained in a
single place (in paint).

No new tests, no new functionality.

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::paint):
(WebCore::RenderFrameSet::getCursor):
* rendering/RenderFrameSet.h:
(RenderFrameSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed rebaseline after r107864.
loislo@chromium.org [Thu, 16 Feb 2012 06:47:29 +0000 (06:47 +0000)]
[chromium] Unreviewed rebaseline after r107864.

* platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac-leopard/svg/text/text-text-08-b-expected.png:
* platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-text-08-b-expected.png:
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac/compositing/plugins/composited-plugin-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FractionalLayoutPoint/Size/Rect for sub-pixel layout
leviw@chromium.org [Thu, 16 Feb 2012 06:40:30 +0000 (06:40 +0000)]
Add FractionalLayoutPoint/Size/Rect for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=76571

Reviewed by Eric Seidel.

Add fixed point versions of the Point, Size and Rect classes using
the new FractionalLayoutPoint type and.

FractionalLayoutPoint, FractionalLayoutSize and FractionalLayoutRect are
Point, Size and Rect implementations respectively using this new type.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/FractionalLayoutUnit.h:
Fixed a couple of typos and signed/unsigned bugs.

* platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::FloatPoint):
Add explicit FloatPoint(FractionalLayoutPoint) constructor.

(WebCore::FloatPoint::move):
Add move(FractionalLayoutSize) implementation.

(WebCore::FloatPoint::moveBy):
Add moveBy(FractionalLayoutPoint) implementation.

* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::FloatRect):
Add explicit FloatRectFractionalLayoutRect) constructor.

* platform/graphics/FloatRect.h:
(WebCore):
(FloatRect):
* platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::FloatSize):
Add explicit FloatSize(FractionalLayoutSize) constructor.

* platform/graphics/FloatSize.h:
* platform/graphics/FractionalLayoutPoint.h: Added.
* platform/graphics/FractionalLayoutRect.cpp: Added.
* platform/graphics/FractionalLayoutRect.h: Added.
* platform/graphics/FractionalLayoutSize.cpp: Added.
* platform/graphics/FractionalLayoutSize.h: Added.
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::IntRect):
Add explicit IntRect(FractionalLayoutRect) constructor.

* platform/graphics/IntRect.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] PasteboardMac.mm build fails
haraken@chromium.org [Thu, 16 Feb 2012 06:14:48 +0000 (06:14 +0000)]
[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655

Reviewed by Enrica Casucci.

Source/WebCore:

This patch fixes the code to make a plain text for pasted file names.
The code should return a string of concatenated file names.

Test: editing/pasteboard/drag-files-to-editable-element.html

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):

LayoutTests:

The added test drops multiple files onto an editable element,
and checks if the filenames are inserted into the editable element.

* editing/pasteboard/drag-files-to-editable-element-expected.txt: Added.
* editing/pasteboard/drag-files-to-editable-element.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempt at fixing the Snow Leopard build.
andersca@apple.com [Thu, 16 Feb 2012 06:10:24 +0000 (06:10 +0000)]
Another attempt at fixing the Snow Leopard build.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed rebaseline after r107864.
loislo@chromium.org [Thu, 16 Feb 2012 05:57:10 +0000 (05:57 +0000)]
[chromium] Unreviewed rebaseline after r107864.

* platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Added.
* platform/chromium-mac/fast/canvas/text-globalAlpha-expected.txt: Removed.
* platform/chromium-win/svg/text/text-fill-opacity-expected.png: Added.
* platform/chromium-win/svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/text/text-fill-opacity-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for the translate attribute in html elements.
commit-queue@webkit.org [Thu, 16 Feb 2012 05:42:02 +0000 (05:42 +0000)]
Add support for the translate attribute in html elements.
https://bugs.webkit.org/show_bug.cgi?id=78751

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-15
Reviewed by Adam Barth.

The translate attribute is used to specify whether an element's
attribute values and the values of its Text node children are to be
translated when the page is localized, or whether to leave them
unchanged.

Details at http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate

Source/WebCore:

Test: fast/dom/HTMLElement/translate.html

* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::translateAttributeMode):
(WebCore):
(WebCore::HTMLElement::translate):
(WebCore::HTMLElement::setTranslate):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLElement.idl:

LayoutTests:

* fast/dom/HTMLElement/translate-expected.txt: Added.
* fast/dom/HTMLElement/translate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. compositing/culling/scrolled-within-boxshadow.html IMAGE failure.
noel.gordon@gmail.com [Thu, 16 Feb 2012 05:29:23 +0000 (05:29 +0000)]
Unreviewed. compositing/culling/scrolled-within-boxshadow.html IMAGE failure.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Add -webkit-overflow-scrolling CSS property
commit-queue@webkit.org [Thu, 16 Feb 2012 05:09:09 +0000 (05:09 +0000)]
Source/WebCore: Add -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664

Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.

Add a CSS property indicating that an element with overflow scrolling
should follow the platform's behavior for touch scrollable user
interface objects. For instance, this property could enable momentum
scrolling for the element if that is the platform convention.

The property has two possible values: auto (default) and touch. The
former does not alter overflow scrolling behavior, while the latter
activates touch scrolling.

As a side effect, enabling touch scrolling also causes an element to
gain a stacking context. This is to allow the implementation to promote
the scrolling contents into a render layer, which can be translated more
efficiently.

This property was introduced with iOS 5 WebKit. Another implementation
is in Chrome for Android.

Test: platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

Source/WebKit/chromium: Enable -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664

Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.

* features.gypi:

LayoutTests: Add stacking context test for -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664

Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.

Make sure a stacking context is created for elements with touch overflow scrolling.

* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Added new property.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Ditto.
* platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Added.
* platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Added.
* platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd zeroLayoutUnit constant.
leviw@chromium.org [Thu, 16 Feb 2012 04:49:03 +0000 (04:49 +0000)]
Add zeroLayoutUnit constant.
https://bugs.webkit.org/show_bug.cgi?id=78747

Reviewed by Eric Seidel.

Converting call sites where LayoutUnits and raw zeros are in ternary operations
and templatized function calls (like std::max and min) to use a new zeroLayoutUnit
constant instead of the raw zero.

No new tests. No change in behavior.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
* rendering/LayoutTypes.h:
(WebCore):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::adjustForUnsplittableChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
* rendering/RenderBox.h:
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
* rendering/RenderFileUploadControl.cpp:
(WebCore::nodeWidth):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
* rendering/RenderTable.h:
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash after trying to use FileReader in a document with null origin string
ap@apple.com [Thu, 16 Feb 2012 04:18:00 +0000 (04:18 +0000)]
Crash after trying to use FileReader in a document with null origin string
https://bugs.webkit.org/show_bug.cgi?id=78649

Reviewed by Enrica Casucci.

Source/WebCore:

Test: fast/files/null-origin-string.html

* fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::~FileReaderLoader):
HashMaps don't like empty keys, and they don't like removing keys that have never been added.

LayoutTests:

* fast/files/null-origin-string-expected.txt: Added.
* fast/files/null-origin-string.html: Added.

Dragging files is only implemented on a few platforms. Brought some order to skipped files
for these tests:

* platform/mac/Skipped: Bug 45576 has been fixed long ago; unskip the test.

* platform/efl/Skipped:
* platform/qt/Skipped:
Skipped the new tests.

* platform/gtk-wk2/Skipped:
* platform/mac-wk2/Skipped:
* platform/win-wk2/Skipped:
* platform/wk2/Skipped:
Skipped the new tests, and moved other tests using eventSender.beginDragWithFiles to a
central location. No WK2 port implements these yet, so we needn't maintain the lists
separately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix the Snow Leopard build.
andersca@apple.com [Thu, 16 Feb 2012 03:57:34 +0000 (03:57 +0000)]
Attempt to fix the Snow Leopard build.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r107863.
leo.yang@torchmobile.com.cn [Thu, 16 Feb 2012 03:57:05 +0000 (03:57 +0000)]
Build fix after r107863.

* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Thu, 16 Feb 2012 03:53:36 +0000 (03:53 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #14 of N.

* platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Removed.
* platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug196870-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug120107-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug196870-expected.txt: Removed.
* tables/mozilla/bugs/bug120107-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug120107-expected.txt.
* tables/mozilla/bugs/bug12908-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt.
* tables/mozilla/bugs/bug196870-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug196870-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] add linux dbg back to garden-o-matic
tony@chromium.org [Thu, 16 Feb 2012 03:52:34 +0000 (03:52 +0000)]
[chromium] add linux dbg back to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=78752

Reviewed by Adam Barth.

This reflects the current linux debug bot name (there's only one bot).
I'm also remove the mac clang builder since it doesn't exist (mac
always uses clang now).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* Scripts/webkitpy/layout_tests/port/builders.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow...
mitz@apple.com [Thu, 16 Feb 2012 03:32:07 +0000 (03:32 +0000)]
REGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing
https://bugs.webkit.org/show_bug.cgi?id=78759

Reviewed by Simon Fraser.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::boxShadowCanBeAppliedToBackground): Added. Returns false if
paintFillLayer() would push a clip before painting the layer, thus preventing it from casting
its own shadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Pass this as an additional parameter to
boxShadowShouldBeAppliedToBackground().
* rendering/InlineFlowBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass the InlineFlowBox along to
boxShadowShouldBeAppliedToBackground().
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added an InlineFlowBox
parameter. If non-0, check boxShadowCanBeAppliedToBackground(). Also check for shadow spread,
and for the case of border radius with a background image, in which paintFillLayerExtended uses
clipping. Finally, fixed a bug in the for() loop for finding the last background layer which
was noticed by Tony Chang.
* rendering/RenderBoxModelObject.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground):
* rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
leo.yang@torchmobile.com.cn [Thu, 16 Feb 2012 03:27:58 +0000 (03:27 +0000)]
[BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78770

Reviewed by Rob Buis.

Initial upstreaming, no new tests.

* blackberry/Api/WebPageGroupLoadDeferrer.cpp: Added.
* blackberry/Api/WebPageGroupLoadDeferrer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd style check for ctype functions that are generally frowned upon in WebKit
commit-queue@webkit.org [Thu, 16 Feb 2012 03:18:27 +0000 (03:18 +0000)]
Add style check for ctype functions that are generally frowned upon in WebKit
https://bugs.webkit.org/show_bug.cgi?id=78748

Patch by Sam Weinig <sam@webkit.org> on 2012-02-15
Reviewed by Anders Carlsson.

Not every platform has DisallowCType.h to check for uses of the ctype.h
functions, so add a style check for them as well.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_ctype_functions):
(check_style):
(CppChecker):
Add check.

* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_ctype_fucntion):
Add checker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream BlackBerry specific Web Inspector resources
commit-queue@webkit.org [Thu, 16 Feb 2012 03:16:48 +0000 (03:16 +0000)]
[BlackBerry] Upstream BlackBerry specific Web Inspector resources
https://bugs.webkit.org/show_bug.cgi?id=78727

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-15
Reviewed by Rob Buis.

* blackberry/WebCoreSupport/inspectorBB.html: Added.
* blackberry/WebCoreSupport/inspectorBB.js: Added.
():
(InspectorFrontendHost.copyText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInitial upstreaming of EditorClientBlackBerry
commit-queue@webkit.org [Thu, 16 Feb 2012 02:58:17 +0000 (02:58 +0000)]
Initial upstreaming of EditorClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78730

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-15
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

* blackberry/WebCoreSupport/EditorClientBlackBerry.cpp: Added.
(WebCore):
(WebCore::EditorClientBlackBerry::EditorClientBlackBerry):
(WebCore::EditorClientBlackBerry::pageDestroyed):
(WebCore::EditorClientBlackBerry::shouldDeleteRange):
(WebCore::EditorClientBlackBerry::shouldShowDeleteInterface):
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientBlackBerry::enableSpellChecking):
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleContinuousSpellChecking):
(WebCore::EditorClientBlackBerry::isGrammarCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleGrammarChecking):
(WebCore::EditorClientBlackBerry::spellCheckerDocumentTag):
(WebCore::EditorClientBlackBerry::shouldBeginEditing):
(WebCore::EditorClientBlackBerry::shouldEndEditing):
(WebCore::EditorClientBlackBerry::shouldInsertNode):
(WebCore::EditorClientBlackBerry::shouldInsertText):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::shouldApplyStyle):
(WebCore::EditorClientBlackBerry::shouldMoveRangeAfterDelete):
(WebCore::EditorClientBlackBerry::didBeginEditing):
(WebCore::EditorClientBlackBerry::respondToChangedContents):
(WebCore::EditorClientBlackBerry::respondToChangedSelection):
(WebCore::EditorClientBlackBerry::didEndEditing):
(WebCore::EditorClientBlackBerry::respondToSelectionAppearanceChange):
(WebCore::EditorClientBlackBerry::didWriteSelectionToPasteboard):
(WebCore::EditorClientBlackBerry::didSetSelectionTypesForPasteboard):
(WebCore::EditorClientBlackBerry::registerCommandForUndo):
(WebCore::EditorClientBlackBerry::registerCommandForRedo):
(WebCore::EditorClientBlackBerry::clearUndoRedoOperations):
(WebCore::EditorClientBlackBerry::canUndo):
(WebCore::EditorClientBlackBerry::canRedo):
(WebCore::EditorClientBlackBerry::canCopyCut):
(WebCore::EditorClientBlackBerry::canPaste):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):
(KeyDownEntry):
(KeyPressEntry):
(WebCore::EditorClientBlackBerry::interpretKeyEvent):
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):
(WebCore::EditorClientBlackBerry::handleInputMethodKeydown):
(WebCore::EditorClientBlackBerry::textFieldDidBeginEditing):
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):
(WebCore::EditorClientBlackBerry::doTextFieldCommandFromEvent):
(WebCore::EditorClientBlackBerry::textWillBeDeletedInTextField):
(WebCore::EditorClientBlackBerry::textDidChangeInTextArea):
(WebCore::EditorClientBlackBerry::ignoreWordInSpellDocument):
(WebCore::EditorClientBlackBerry::learnWord):
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::EditorClientBlackBerry::checkGrammarOfString):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::textChecker):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithGrammarString):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithMisspelledWord):
(WebCore::EditorClientBlackBerry::showSpellingUI):
(WebCore::EditorClientBlackBerry::spellingUIIsShowing):
(WebCore::EditorClientBlackBerry::getGuessesForWord):
(WebCore::EditorClientBlackBerry::willSetInputMethodState):
(WebCore::EditorClientBlackBerry::setInputMethodState):
* blackberry/WebCoreSupport/EditorClientBlackBerry.h: Added.
(WebKit):
(WebCore):
(EditorClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpose Window constructor
arv@chromium.org [Thu, 16 Feb 2012 02:47:12 +0000 (02:47 +0000)]
Expose Window constructor
https://bugs.webkit.org/show_bug.cgi?id=78722

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/Window/window-constructor-presence.html

* page/DOMWindow.idl:

LayoutTests:

* fast/dom/Window/window-constructor-presence-expected.txt: Added.
* fast/dom/Window/window-constructor-presence.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
commit-queue@webkit.org [Thu, 16 Feb 2012 02:43:17 +0000 (02:43 +0000)]
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546

Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-15
Reviewed by Simon Hausmann.

Resize the web view programatically because the declarative property binding
does not work. Seems like our qml environment is not initialized fully but it
needs more investigation.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: add a worker_args concept to start_worker()
dpranke@chromium.org [Thu, 16 Feb 2012 02:41:08 +0000 (02:41 +0000)]
webkitpy: add a worker_args concept to start_worker()
https://bugs.webkit.org/show_bug.cgi?id=78572

Reviewed by Tony Chang.

This change replaces the three NRWT-specific arguments passed
through the broker to the worker with a generic WorkerArguments
wrapper class and a separate set_inline_arguments() call that can
be used to pass additional data to the worker when it is running
in the same process as the manager (this is needed for testing).
With the addition of set_inline_arguments() we also no longer
need to pass an optional argument to the worker.run() call.

Note that this method is *only* implemented on inline workers,
so calling this on a regular (child process) worker will result
in a runtime error.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.__init__):
(AbstractWorker.run):
(_ManagerConnection.start_worker):
(_InlineManager.start_worker):
(_InlineManager.set_inline_arguments):
(_InlineManager.run_message_loop):
(_MultiProcessManager.start_worker): Reworked signature.
(_WorkerConnection.__init__):
(_InlineWorkerConnection.__init__):
(_InlineWorkerConnection.set_inline_arguments): New method.
(_InlineWorkerConnection):
(_InlineWorkerConnection.run):
(_Process.run):
(_MultiProcessWorkerConnection.__init__):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.__init__):
(_TestWorker.set_inline_arguments):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InlineBrokerTests): New class for more testing.
(InlineBrokerTests.setUp):
(InlineBrokerTests.test_inline_arguments): New test.
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(WorkerArguments):
(WorkerArguments.__init__):
(Worker.__init__):
(Worker.set_inline_arguments):
(Worker):
(Worker.run):
* Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
(WorkerTest.test_default_platform_in_worker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofill-opacity does not render properly only on Chromium Mac.
knorton@google.com [Thu, 16 Feb 2012 02:15:47 +0000 (02:15 +0000)]
fill-opacity does not render properly only on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=78624

Reviewed by Stephen White.

Source/WebCore:

Test: svg/text/text-fill-opacity.svg

* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):

LayoutTests:

* platform/chromium-linux/svg/text/text-fill-opacity-expected.png: Added.
* platform/chromium-linux/svg/text/text-fill-opacity-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* svg/text/text-fill-opacity.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream WebPageClient.h
leo.yang@torchmobile.com.cn [Thu, 16 Feb 2012 02:02:33 +0000 (02:02 +0000)]
[BlackBerry] Upstream WebPageClient.h
https://bugs.webkit.org/show_bug.cgi?id=78660

Reviewed by Antonio Gomes.

Source/WebCore:

Header inclusion fix, no new test.

* plugins/blackberry/PluginViewPrivateBlackBerry.h:
Add #include <BlackBerryPlatformIntRectRegion.h>
and #include <BlackBerryPlatformGraphics.h> because they
are being removed from WebKit/blackberry/Api/WebPageClient.h.

Source/WebKit:

Initial upstreaming, no new tests.

* blackberry/Api/BackingStore.cpp: Add #include <BlackBerryPlatformWindow.h> because this inclusion
is being removed from WebPageClient.h.
* blackberry/Api/WebPageClient.h: Added.
* blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Add #include <BlackBerryPlatformWindow.h>
because this inclusion is being removed from WebPageClient.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r105057): Dynamically changing <tspan> offsets is broken
timothy_horton@apple.com [Thu, 16 Feb 2012 01:50:51 +0000 (01:50 +0000)]
REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>

Reviewed by Simon Fraser.

Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).

Test: svg/text/tspan-dynamic-positioning.svg

* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):

Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
* svg/text/tspan-dynamic-positioning.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: Removing SecurityContext from the embedder API
tommyw@google.com [Thu, 16 Feb 2012 01:35:00 +0000 (01:35 +0000)]
MediaStream API: Removing SecurityContext from the embedder API
https://bugs.webkit.org/show_bug.cgi?id=73816

Reviewed by Darin Fisher.

Source/WebCore:

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::PeerConnection):
* platform/mediastream/PeerConnectionHandler.h:
(WebCore):
(PeerConnectionHandler):
* platform/mediastream/gstreamer/PeerConnectionHandler.cpp:
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):

Source/WebKit/chromium:

* bridge/PeerConnectionHandler.cpp:
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
* bridge/PeerConnectionHandlerInternal.cpp:
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
* bridge/PeerConnectionHandlerInternal.h:
(WebCore):
(PeerConnectionHandlerInternal):
* public/platform/WebPeerConnectionHandler.h:
(WebPeerConnectionHandler):
(WebKit::WebPeerConnectionHandler::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure that the DFG JIT always plants a CodeOrigin when making calls
oliver@apple.com [Thu, 16 Feb 2012 01:29:12 +0000 (01:29 +0000)]
Ensure that the DFG JIT always plants a CodeOrigin when making calls
https://bugs.webkit.org/show_bug.cgi?id=78763

Reviewed by Gavin Barraclough.

Make all calls plant a CodeOrigin prior to the actual
call.  Also clobbers the Interpreter with logic to ensure
that the interpreter always plants a bytecode offset.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(CallBeginToken):
(JSC::DFG::JITCompiler::beginJSCall):
(JSC::DFG::JITCompiler::beginCall):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(ExecState):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::codeOriginIndexForDFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix test regressons from r107672.
japhet@chromium.org [Thu, 16 Feb 2012 01:19:28 +0000 (01:19 +0000)]
Source/WebCore: Fix test regressons from r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564

Move setting CachedRawResource::m_identifer from
data() to setResponse(). WorkerScriptLoader depends
on the identifier being set correctly during setResponse()
in order to correctly mark itself as a ScriptResource in
the inspector.

Reviewed by Adam Barth.

Fixes several worker script loading tests.

* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data):
(WebCore::CachedRawResource::setResponse):

LayoutTests: Remove Skipped tests that were broken by r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Adam Barth.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r107704.
adamk@chromium.org [Thu, 16 Feb 2012 01:06:44 +0000 (01:06 +0000)]
Unreviewed, rolling out r107704.
http://trac.webkit.org/changeset/107704
https://bugs.webkit.org/show_bug.cgi?id=78486

Caused layout test crashes in debug builds.

Specific crashing tests:

fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html
inspector/console/console-long-eval-crash.html

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed. regionOverflow tests are flaky in debug.
tony@chromium.org [Thu, 16 Feb 2012 00:47:23 +0000 (00:47 +0000)]
[chromium] Unreviewed.  regionOverflow tests are flaky in debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: "Copy image" fails...copies image URL instead.
enrica@apple.com [Thu, 16 Feb 2012 00:45:53 +0000 (00:45 +0000)]
REGRESSION: "Copy image" fails...copies image URL instead.
https://bugs.webkit.org/show_bug.cgi?id=78723
<rdar://problem/10869104>

During the refactoring of the Pasteboard class some code was lost.
When placing an NSImage in the NSPasteboard as NSTIFFPboardType, we need
to use the its TIFF representation.

Reviewed by Andy Estes.

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream remaining classes in Api
rwlbuis@webkit.org [Thu, 16 Feb 2012 00:39:25 +0000 (00:39 +0000)]
[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644

Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

* blackberry/Api/ActiveNodeContext.h: Renamed from Source/WebKit/blackberry/Api/BlackBerryContext.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[soup] Add support for multiple SoupSessions.
kubo@profusion.mobi [Thu, 16 Feb 2012 00:27:45 +0000 (00:27 +0000)]
[soup] Add support for multiple SoupSessions.
https://bugs.webkit.org/show_bug.cgi?id=77341

Source/WebCore:

Reviewed by Gustavo Noronha Silva.

Make the libsoup network backend support multiple SoupSessions. This is
accomplished by using the NetworkingContext classes, which now have a
`soupSession()' method when the libsoup backend is being used.

libsoup's ResourceHandle implementation now retrieves the SoupSession
via the NetworkingContext it receives instead of relying on
defaultSession(). defaultSession() is still used when a null
NetworkingContext is passed to ResourceHandle::start (for example, via
webkit_download_start).

The CookieJar implementation retrieves the SoupSession from the
NetworkingContext as much as possible as well -- the functions used by
WebKit2 could not be converted, though, as they seem to assume there is
only one shared cookie jar.

No new tests, covered by the existing ones.

* platform/network/NetworkingContext.h:
(NetworkingContext): Add soupSession() method if USE(SOUP) is set.
* platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForDocument):
(WebCore):
(WebCore::defaultCookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::soupSession): Add method to retrieve
a SoupSession from a NetworkingContext and fallback to defaultSession()
if there's no valid NetworkingContext.
(WebCore):
(WebCore::ensureSessionIsInitialized): Only change or use the default
cookie jar if the SoupSession being changed is the default one.
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::cancel):
(WebCore::startNonHTTPRequest):

Source/WebKit/efl:

Add the necessary infrastructure to support multiple SoupSessions. Each
WebView now has a "session" property, which defaults to
ResourceHandle::defaultSession() and can be changed to another
SoupSession by the user.

Some API in ewk_network and ewk_view which required SoupSession to be a
valid type in the headers has now been moved inside #if USE(SOUP)
ifdefs so we can actually the required Soup header and avoid build
problems with duplicate typedefs.

* CMakeListsEfl.txt:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::createNetworkingContext):
* WebCoreSupport/FrameNetworkingContextEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h.
(WebCore):
(WebCore::FrameNetworkingContextEfl::create):
(WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
(WebCore::FrameNetworkingContextEfl::soupSession):
* WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
* ewk/ewk_cookies.h: Mention this API is only valid with the
default SoupSession.
* ewk/ewk_network.cpp:
(ewk_network_default_soup_session_get): Define only if USE(SOUP) is set.
* ewk/ewk_network.h: Ditto, and mention this API is only valid with the
default SoupSession.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
* ewk/ewk_view.h:
():

Source/WebKit/gtk:

Reviewed by Gustavo Noronha Silva.

Adapt to the changes to FrameNetworkingContext in WebCore.

* GNUmakefile.am:
* WebCoreSupport/FrameNetworkingContextGtk.cpp: Copied from Source/WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h.
(WebKit):
(WebKit::FrameNetworkingContextGtk::soupSession): Always return ResourceHandle::defaultSession().
* WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe TileCache object should be deallocated on the main thread
andersca@apple.com [Thu, 16 Feb 2012 00:01:55 +0000 (00:01 +0000)]
The TileCache object should be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78757
<rdar://problem/10866161>

Reviewed by Sam Weinig.

Since the WebTileCacheLayer can be deleted on the scrolling thread, we need to make sure that the underlying
TileCache object is actually destroyed on the main thread.

* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::~TileCache):
Assert that this object is being destroyed on the main thread.

* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer dealloc]):
If dealloc is being called from a non-main thread, make sure to delete the tile cache object on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, rebasing tests after r107836.
tony@chromium.org [Wed, 15 Feb 2012 23:58:55 +0000 (23:58 +0000)]
[chromium] Unreviewed, rebasing tests after r107836.

* platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac-leopard/fast/transforms/shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png:
* platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Roll DEPS to r122122
peter@chromium.org [Wed, 15 Feb 2012 23:54:02 +0000 (23:54 +0000)]
[Chromium] Roll DEPS to r122122
https://bugs.webkit.org/show_bug.cgi?id=78754

Unreviewed DEPS roll.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrolling Coordinator must be deleted on the main thread
andersca@apple.com [Wed, 15 Feb 2012 23:47:26 +0000 (23:47 +0000)]
Scrolling Coordinator must be deleted on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78756
<rdar://problem/10866167>

Reviewed by Sam Weinig.

ScrollingTree::invalidate will finish breaking the cycle between the scrolling coordinator and the
scrolling tree by dereffing the scrolling coordinator. We need to make sure that this happens on the main
thread because the scrolling coordinator expects to be destroyed from there.

* page/scrolling/ScrollingTree.cpp:
(WebCore::derefScrollingCoordinator):
(WebCore):
(WebCore::ScrollingTree::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrolling coordinator should handle pages being restored from the page cache
andersca@apple.com [Wed, 15 Feb 2012 23:37:25 +0000 (23:37 +0000)]
Scrolling coordinator should handle pages being restored from the page cache
https://bugs.webkit.org/show_bug.cgi?id=78753
<rdar://problem/10866171>

Reviewed by Sam Weinig.

Replace ScrollingCoordinator::frameViewScrollLayerDidChange with a new member function,
ScrollingCoordinator::frameViewRootLayerDidChange which is called whenever the root layer
of the frame view changes (which happens on back/forward navigation as well).

In this function, reset the scrolling tree state from the frame view.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::scrollLayerForFrameView):
Add a helper function.

(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Reset the entire scrolling tree state.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Call the newly added helper function.

* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
Remove frameViewScrollLayerDidChange.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
Remove call to ScrollingCoordinator::frameViewScrollLayerDidChange.

(WebCore::RenderLayerCompositor::attachRootLayer):
Call ScrollingCoordinator::frameViewRootLayerDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add setter/getter to expose drag data as a list of items
dcheng@chromium.org [Wed, 15 Feb 2012 23:14:24 +0000 (23:14 +0000)]
[chromium] Add setter/getter to expose drag data as a list of items
https://bugs.webkit.org/show_bug.cgi?id=77125

This change supports the unification of the data store backing ChromiumDataObject and
DataTransferItemListChromium. ChromiumDataObject will represent dragging and clipboard data
as a list of data nodes to make it more straightforward to implement the HTML spec for
DataTransferItemList. Thus, we extend the abstraction to the webkit glue layer to
simplify the serialization/deserialization between platform-specific data and WebDragData.
The other setter/getter methods are deprecated and will be removed once the dependencies in
Chromium code are gone.

Reviewed by Darin Fisher.

* public/platform/WebDragData.h:
(WebKit):
(WebDragData):
* src/WebDragData.cpp:
(WebKit::WebDragData::items):
(WebKit):
(WebKit::WebDragData::setItems):
(WebKit::WebDragData::addItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd TiledCoreAnimationDrawingArea::forceRepaint
andersca@apple.com [Wed, 15 Feb 2012 23:10:26 +0000 (23:10 +0000)]
Add TiledCoreAnimationDrawingArea::forceRepaint
https://bugs.webkit.org/show_bug.cgi?id=78749
<rdar://problem/10866221>

Reviewed by Sam Weinig.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Force a repaint and synchronize the layer tree to the UI process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor ClipboardMac class to use PlatformStrategies.
enrica@apple.com [Wed, 15 Feb 2012 23:08:25 +0000 (23:08 +0000)]
Refactor ClipboardMac class to use PlatformStrategies.
https://bugs.webkit.org/show_bug.cgi?id=78554

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests. No change in behavior.

* WebCore.exp.in: Added new exported methods of the PlatformPasteboard class
* editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard): Use name based pasteboard references.
* page/DragClient.h:
(WebCore::DragClient::declareAndWriteDragImage): Ditto.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard): Ditto.
* platform/PasteboardStrategy.h: Added new methods to get a unique pasteboard name
and the pasteboard change count.
* platform/PlatformPasteboard.h: Ditto.
* platform/mac/ClipboardMac.h:
(WebCore::ClipboardMac::create): Using name based pasteboard.
(WebCore::ClipboardMac::pasteboardName): Replacing the old pasteboard() method.
* platform/mac/ClipboardMac.mm: All the methods below have been modified to avoid
using Objective-C types and direct access to NSPasteboard object.
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::hasData):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::absoluteURLsFromPasteboardFilenames):
(WebCore::absoluteURLsFromPasteboard):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writePlainText):
(WebCore::ClipboardMac::writeURL):
(WebCore::ClipboardMac::declareAndWriteDragImage):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard): Using name based pasteboard reference.
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::getPathnamesForType): Fixed to support NSArray and NString content.
(WebCore::PlatformPasteboard::changeCount): Added.
(WebCore::PlatformPasteboard::uniqueName): Added.

Source/WebKit/mac:

* WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
* WebCoreSupport/WebDragClient.mm: Ditto.
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
* WebCoreSupport/WebPlatformStrategies.h: Added new methods.
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::changeCount):
(WebPlatformStrategies::uniqueName):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebDragClient.h: Changed method signature to reference
the pasteboard by name.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added new methods.
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Changed method signature to reference
the pasteboard by name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTileCache needs to support setting the contents scale
andersca@apple.com [Wed, 15 Feb 2012 22:48:36 +0000 (22:48 +0000)]
TileCache needs to support setting the contents scale
https://bugs.webkit.org/show_bug.cgi?id=78741
<rdar://problem/10710773>

Reviewed by Sam Weinig.

* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):
Update the contents scale of all the tiles and then revalidate the tile cache since tiles
might have come and gone as a result of setting the contents scale.

(WebCore::TileCache::createTileLayer):
Set the contents scale of the tile layer.

* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setContentsScale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Chromium build and remove a snarky comment in the process.
andersca@apple.com [Wed, 15 Feb 2012 22:36:31 +0000 (22:36 +0000)]
Try to fix the Chromium build and remove a snarky comment in the process.

* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: mark a test as no longer MISSING.
senorblanco@chromium.org [Wed, 15 Feb 2012 22:14:51 +0000 (22:14 +0000)]
Unreviewed gardening:  mark a test as no longer MISSING.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: Fix more results after r107833.
tony@chromium.org [Wed, 15 Feb 2012 22:09:29 +0000 (22:09 +0000)]
Unreviewed gardening: Fix more results after r107833.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWheel events should be re-dispatched to the scrolling thread
andersca@apple.com [Wed, 15 Feb 2012 22:06:39 +0000 (22:06 +0000)]
Wheel events should be re-dispatched to the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78731
<rdar://problem/10866144>

Reviewed by Sam Weinig.

When threaded scrolling is enabled, all the state is assumed to be kept in the scrolling tree,
on the scrolling thread. This means that even if we do end up processing an event on the main thread
(because of wheel event handlers for example), we still have to dispatch the wheel event back to the
scrolling thread.

* page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
Move wheelEvent from ScrollView and ask the scrolling coordinator to handle the wheel event.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEvent):
Dispatch the event to the scrolling thread, unless it will start a gesture. In that case we'll return false
so that information will be passed back to the UI process.

(ScrollingCoordinator):
* platform/ScrollView.cpp:
* platform/ScrollView.h:
Move wheelEvent to FrameView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRootObject::finalize can cause a crash in object->invalidate()
mhahnenberg@apple.com [Wed, 15 Feb 2012 21:59:36 +0000 (21:59 +0000)]
RootObject::finalize can cause a crash in object->invalidate()
https://bugs.webkit.org/show_bug.cgi?id=78645

Reviewed by Geoffrey Garen.

No new tests.

* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::finalize): Added a stack-allocated RefPtr to protect the RootObject
during the call to invalidate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10870238> Box shadow drawing takes an unnecessarily slow code path...
mitz@apple.com [Wed, 15 Feb 2012 21:57:02 +0000 (21:57 +0000)]
<rdar://problem/10870238> Box shadow drawing takes an unnecessarily slow code path in some single-shadow, opaque-background cases
https://bugs.webkit.org/show_bug.cgi?id=78728

In some cases, when there is only one normal box shadow, and the box has an opaque background,
it is possible to draw the box shadow by having the background cast it directly. This appears
to be faster than the generic code path that uses a separate drawing pass to cast the shadow,
clipping out the border box and the shadow-casting box.

Reviewed by Dave Hyatt.

No new tests, because behavior is unchanged.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Ditto.
* rendering/RenderBox.h: Made determineBackgroundBleedAvoidance() protected.
* rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground): Added this helper function, which applies the first
normal shadow from the given RenderStyle to the given GraphicsContext.
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Added calls to
applyBoxShadowForBackground() before drawing the background color when needed.
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added. Returns true
in some of the cases where the box shadow can be cast by the background directly.
* rendering/RenderBoxModelObject.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground): Added this override that
always returns false, because table cells sometimes apply a clip before drawing the background.
* rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, adding the chromium-mac result for this test (test added in...
tony@chromium.org [Wed, 15 Feb 2012 21:02:37 +0000 (21:02 +0000)]
[chromium] Unreviewed, adding the chromium-mac result for this test (test added in r107822).

* platform/chromium-mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a test asserting that the second argument to MutationCallback is the observer
adamk@chromium.org [Wed, 15 Feb 2012 20:30:13 +0000 (20:30 +0000)]
Add a test asserting that the second argument to MutationCallback is the observer
https://bugs.webkit.org/show_bug.cgi?id=78653

Reviewed by Ryosuke Niwa.

This is specified in the spec text, so I wanted to make sure it was
properly exercised in a layout test.

* fast/mutation/callback-second-argument-expected.txt: Added.
* fast/mutation/callback-second-argument.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align...
ojan@chromium.org [Wed, 15 Feb 2012 20:26:40 +0000 (20:26 +0000)]
getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
https://bugs.webkit.org/show_bug.cgi?id=76326

Reviewed by Tony Chang.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNotify ChromeClient when touch-event handlers are installed/removed.
commit-queue@webkit.org [Wed, 15 Feb 2012 20:21:15 +0000 (20:21 +0000)]
Notify ChromeClient when touch-event handlers are installed/removed.
https://bugs.webkit.org/show_bug.cgi?id=77440

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-15
Reviewed by Darin Fisher and Ryosuke Niwa.

Source/WebCore:

Keep a count of the number of touch-event handlers and notify the
embedder when the count changes. Depending on the count, the embedder
can decide whether or not to dispatch touch events to webkit.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler):
(WebCore):
(WebCore::Document::didRemoveTouchEventHandler):
* dom/Document.h:
(WebCore::Document::touchEventHandlerCount):
(Document):
* dom/Node.cpp:
(WebCore::isTouchEventType):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::numTouchEventHandlersChanged):
* page/ChromeClient.h:
(ChromeClient):
* page/Frame.cpp:
(WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
(WebCore::Frame::notifyChromeClientTouchEventHandlerCountChanged):
(WebCore):
* page/Frame.h:
(Frame):

Source/WebKit/chromium:

* public/WebViewClient.h:
(WebKit::WebViewClient::numberOfTouchEventHandlersChanged):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numTouchEventHandlersChanged):
(WebKit):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfTouchEventHandlersChanged):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::numTouchEventHandlersChanged):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::numTouchEventHandlersChanged):

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::numTouchEventHandlersChanged):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numTouchEventHandlersChanged):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.h:
(WebKit::ChromeClientWinCE::numTouchEventHandlersChanged):

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::numTouchEventHandlersChanged):

Source/WebKit2:

* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::numTouchEventHandlersChanged):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnset the active flag when TextTrackCues go away
eric.carlson@apple.com [Wed, 15 Feb 2012 20:03:27 +0000 (20:03 +0000)]
Unset the active flag when TextTrackCues go away
https://bugs.webkit.org/show_bug.cgi?id=72552

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/track/track-active-cues.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired): Configure new text tracks before preparing to load
    so we know about all tracks when resource selection begins.
(WebCore::HTMLMediaElement::prepareForLoad): Call updateActiveTextTrackCues after setting
    to m_readyState is HAVE_NOTHING so all cues get deactivated. Don't build list of
    available text tracks because resource selection won't actually start until after the load timer fires.
(WebCore::HTMLMediaElement::loadInternal): Build list of non-disabled tracks.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):  Clear the active flag on all cues
    when m_readyState is HAVE_NOTHING or m_player is 0.
(WebCore::HTMLMediaElement::setReadyState): Don't update m_readyState when tracks which haven't
    loaded yet will prevent events from firing. Call updateActiveTextTrackCues to ensure that the
    first cue(s) are shown as soon as possible.
(WebCore::HTMLMediaElement::userCancelledLoad): Call updateActiveTextTrackCues when when m_readyState
    is HAVE_NOTHING so all cues get deactivated.

LayoutTests:

* media/track/track-active-cues-expected.txt: Added.
* media/track/track-active-cues.html: Added.
* track-cue-mutable-text.html: Update to not run test until track and video have
    both loaded.
* media/video-test.js:
(waitForEventsAndCall): New, call the specified function after the list of events
    has been seen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
senorblanco@chromium.org [Wed, 15 Feb 2012 19:52:07 +0000 (19:52 +0000)]
Unreviewed gardening.

Added baseline for new test multiple-filters-invalidation.html.

* platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop skipping fast/filesystem/file-writer-gc-blob.html, as FileWriter is well-support...
adamk@chromium.org [Wed, 15 Feb 2012 19:44:34 +0000 (19:44 +0000)]
Stop skipping fast/filesystem/file-writer-gc-blob.html, as FileWriter is well-supported in DRT.

Unreviewed test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, land chromium pixel results after r107797.
tony@chromium.org [Wed, 15 Feb 2012 19:43:47 +0000 (19:43 +0000)]
[chromium] Unreviewed, land chromium pixel results after r107797.

* platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/regions/element-region-overflow-state.html is flaky
tony@chromium.org [Wed, 15 Feb 2012 19:37:01 +0000 (19:37 +0000)]
fast/regions/element-region-overflow-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=78654

Reviewed by Ojan Vafai.

Sometimes layout happens before test() is called (e.g., if one of the
script or other resources take a long time to load).  In that case, we
get different results.  Not waiting for the load event should always
be before layout.

* fast/regions/element-region-overflow-state-expected.txt:
* fast/regions/element-region-overflow-state.html:
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt
* fast/regions/element-region-overflow-state-vertical-rl.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they...
adamk@chromium.org [Wed, 15 Feb 2012 19:16:39 +0000 (19:16 +0000)]
Re-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they never crash.

Unreviewed test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore build exceeds address space on 32-bit Windows builders (again).
jberlin@webkit.org [Wed, 15 Feb 2012 18:57:06 +0000 (18:57 +0000)]
WebCore build exceeds address space on 32-bit Windows builders (again).
https://bugs.webkit.org/show_bug.cgi?id=78724

Reviewed by Jon Honeycutt.

Add the rest of the inspector .cpp files to the InspectorAllInOne.cpp file in Production and
Release builds.

* WebCore.vcproj/WebCore.vcproj:
In the process, let VS have its way with this file.

* inspector/InspectorAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove ScrollableArea::handleGestureEvent
andersca@apple.com [Wed, 15 Feb 2012 18:53:50 +0000 (18:53 +0000)]
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661

Reviewed by Adam Roben.

Source/WebCore:

ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/ScrollAnimator.cpp:
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
* platform/ScrollableArea.h:
(ScrollableArea):

Source/WebKit/chromium:

Update for WebCore changes.

* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107823 268f45cc-cd09-0410-ab3c-d52691b4dbfc