WebKit-https.git
9 years agoREGRESSION (r105453): Crash when handling touch events
commit-queue@webkit.org [Tue, 17 Apr 2012 15:20:01 +0000 (15:20 +0000)]
REGRESSION (r105453): Crash when handling touch events
https://bugs.webkit.org/show_bug.cgi?id=81958

Patch by Yong Li <yoli@rim.com> on 2012-04-17
Reviewed by Antonio Gomes.

.:

Add a manual test for this issue because DumpRenderTree
currently cannot send a group of touch points with
different touch states in one shot.

* ManualTests/resources/iframe-reloaded-on-touch.html: Added.
* ManualTests/touch-stale-iframe-crash.html: Added.

Source/WebCore:

Always perform sanity checks when handling every touch point
because the node and document may have been destroyed or detached.

ManualTests/touch-stale-iframe-crash.html added.
(DumpRenderTree doesn't support transiting touch states in one shot yet)

* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline svg/carto.net/colourpicker.svg
schenney@chromium.org [Tue, 17 Apr 2012 15:18:37 +0000 (15:18 +0000)]
[Chromium] Rebaseline svg/carto.net/colourpicker.svg

Unreviewed Chromium test expectations update.

This test has been marked as failing for so long that its result is
always wrong. Rebaselining to review flakiness.

* platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
* platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
schenney@chromium.org [Tue, 17 Apr 2012 15:06:37 +0000 (15:06 +0000)]
[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
https://bugs.webkit.org/show_bug.cgi?id=84150

Unreviewed Chromium test expectations update.

* fast/repaint/background-misaligned-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
* platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win-vista/fast/repaint: Added.
* platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-win-xp/svg/as-border-image: Removed.
* platform/chromium-win/fast/repaint/background-misaligned-expected.png:
* platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
commit-queue@webkit.org [Tue, 17 Apr 2012 15:02:36 +0000 (15:02 +0000)]
[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
from postProgressFinishedNotification() since it is already emitted
from dispatchDidFinishLoad(). This avoids unwanted extra signals we
prevent some tests from passing (e.g.
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
* ewk/ewk_frame.cpp:
(ewk_frame_load_committed):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_onload_event):
* ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed ARM build fix
kbalazs@webkit.org [Tue, 17 Apr 2012 14:15:38 +0000 (14:15 +0000)]
[Qt] Unreviewed ARM build fix

* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain): Export this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAsserts in XMLHttpRequestProgressEventThrottle
commit-queue@webkit.org [Tue, 17 Apr 2012 14:02:07 +0000 (14:02 +0000)]
Asserts in XMLHttpRequestProgressEventThrottle
https://bugs.webkit.org/show_bug.cgi?id=81506

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Julien Chaffraix.

Source/WebCore:

The asserts were incorrectly triggered because suspending active DOM objects
(which suspends the XMLHttpRequestProgressEventThrottle) doesn't stop JavaScript
from running or suspend any running loader we may have. The previous code would
assume those 2 cases were impossible.

When XmlHttpRequest::open is called or data is received while the XmlHttpRequest object
is suspended the object may attempt to dispatch events. This patch defers these events
until the object is resumed.

Progress events are coalesced similar to normal throttling, and readystate-change events
are coalesced to avoid identical events emitted right after eachother.

On resume the events are dispatched after a timer to avoid interfering with
ScriptExecutionContext which is iterating over suspended objects.

Test: fast/events/pagehide-xhr-open.html

* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
(WebCore::XMLHttpRequestProgressEventThrottle::resume):
* xml/XMLHttpRequestProgressEventThrottle.h:
(XMLHttpRequestProgressEventThrottle):

LayoutTests:

Tests that xmlhttprequest.open does not assert in when called from onpagehide.

* fast/events/pagehide-xhr-open-expected.txt: Added.
* fast/events/pagehide-xhr-open.html: Added.
* fast/events/resources/subframe-xmlhttprequest.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
vsevik@chromium.org [Tue, 17 Apr 2012 13:44:43 +0000 (13:44 +0000)]
Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035

Reviewed by Pavel Feldman.

Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.

* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: the fix for test after massive rename in r114271.
loislo@chromium.org [Tue, 17 Apr 2012 13:35:32 +0000 (13:35 +0000)]
Web Inspector: the fix for test after massive rename in r114271.
https://bugs.webkit.org/show_bug.cgi?id=84147

Drive by fix. The test was renamed to heap-snapshot.html

Reviewed by Yury Semikhatsky.

* inspector/heap-snapshot.html: Renamed from PerformanceTests/inspector/detailed-heapshots-smoke-test.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
commit-queue@webkit.org [Tue, 17 Apr 2012 13:29:23 +0000 (13:29 +0000)]
[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
https://bugs.webkit.org/show_bug.cgi?id=83035

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

The force_static_libs_as_shared feature for the Qt port will remove
hide_symbols from Qt's CONFIG in order to make them visible to other
libraries again.

Due to an evaluation order problem in qmake, the flags for the C++ compiler
that are set by adding hide_symbols to the CONFIG variables get applied
to qmake's C++ compiler flags directly and hence trying to remove these
later will not work and cause build failures when using the force_static_libs_as_shared
feature of the Qt port.

This is fixed by removing the flags that hide the exports from the compiler flags directly.

* qmake/mkspecs/features/force_static_libs_as_shared.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Zoom out on second double-tap.
commit-queue@webkit.org [Tue, 17 Apr 2012 13:14:50 +0000 (13:14 +0000)]
[Qt] Zoom out on second double-tap.
https://bugs.webkit.org/show_bug.cgi?id=84145

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to rebaseline these images after skia 3695 lands
reed@google.com [Tue, 17 Apr 2012 13:10:45 +0000 (13:10 +0000)]
Need to rebaseline these images after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84144

Unreviewed. Expectations change only

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [regression r112413]content scripts tree outline is not added to the...
pfeldman@chromium.org [Tue, 17 Apr 2012 13:03:55 +0000 (13:03 +0000)]
Web Inspector: [regression r112413]content scripts tree outline is not added to the tab.
https://bugs.webkit.org/show_bug.cgi?id=84146

Reviewed by Vsevolod Vlasov.

Adding the tree to the container.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
commit-queue@webkit.org [Tue, 17 Apr 2012 11:56:19 +0000 (11:56 +0000)]
[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=83285

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

* platform/ContextMenuItem.h: Remove macro around enums - needed by InjectedBundle.
(WebCore):
* platform/Widget.h: Remove namespace WebCore for PlatformPageClient typedef.

Source/WebKit/efl:

Remove WebCore namespace from PageClientEfl.

* WebCoreSupport/PageClientEfl.cpp:
(WebCore):
* WebCoreSupport/PageClientEfl.h:
* ewk/ewk_private.h:
(EWKPrivate):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(EWKPrivate::corePageClient):

Source/WebKit2:

Surround code related to context menu with ENABLE(CONTEXT_MENUS) macro.
Add dummy functions for public API implementation related to context menu.

* Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):
* Shared/WebContextMenuItem.cpp:
* Shared/WebContextMenuItem.h:
* Shared/WebContextMenuItemData.cpp:
* Shared/WebContextMenuItemData.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
* UIProcess/WebPageContextMenuClient.cpp:
* UIProcess/WebPageContextMenuClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient):
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.h:
* WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:
* WebProcess/WebPage/WebContextMenu.cpp:
* WebProcess/WebPage/WebContextMenu.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fix wrong paths to JS resources in GTK tests.
mario@webkit.org [Tue, 17 Apr 2012 11:53:51 +0000 (11:53 +0000)]
Unreviewed, fix wrong paths to JS resources in GTK tests.

* platform/gtk/accessibility/aria-list-and-listitem.html:
* platform/gtk/accessibility/aria-option-role.html:
* platform/gtk/accessibility/aria-option-role-expected.txt: Fixed
typo in the expected output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.
ossy@webkit.org [Tue, 17 Apr 2012 11:36:57 +0000 (11:36 +0000)]
[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-17

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Rebaseline and add platform specific expectations, after r114283.
ossy@webkit.org [Tue, 17 Apr 2012 11:35:45 +0000 (11:35 +0000)]
[Qt] Rebaseline and add platform specific expectations, after r114283.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-17
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update expectations for worker WebSocket tests
toyoshim@chromium.org [Tue, 17 Apr 2012 11:05:08 +0000 (11:05 +0000)]
Unreviewed, update expectations for worker WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=84125

Add BUGWK84125 and mark as CRASH.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r113981.
mario@webkit.org [Tue, 17 Apr 2012 10:58:40 +0000 (10:58 +0000)]
Unreviewed, GTK rebaseline after r113981.

* accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt.
* accessibility/aria-labelledby-stay-within-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-stay-within-expected.txt.
* platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Added.
* platform/gtk/accessibility/aria-list-and-listitem.html: Added.
* platform/gtk/accessibility/aria-option-role-expected.txt: Added.
* platform/gtk/accessibility/aria-option-role.html: Added.
* platform/gtk/accessibility/lists-expected.txt: Added.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExport the initialization function so it can be called earlier.
staikos@webkit.org [Tue, 17 Apr 2012 09:48:15 +0000 (09:48 +0000)]
Export the initialization function so it can be called earlier.
https://bugs.webkit.org/show_bug.cgi?id=84134

Reviewed by Nikolas Zimmermann.

* Api/BlackBerryGlobal.h: export globalInitialize()
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce an internal feature for a fixed placeholder
tkent@chromium.org [Tue, 17 Apr 2012 08:36:38 +0000 (08:36 +0000)]
Introduce an internal feature for a fixed placeholder
https://bugs.webkit.org/show_bug.cgi?id=84009

Reviewed by Hajime Morita.

This change adds a framework to support fixed placeholder string for
textfield-like <input> without the palceholder attribute support. This
doesn't change any behavior of input types which support the
'placeholder' attribute.

According to the standard, <input type=date> doesn't support the
'placeholder' attribute. However it is a kind of text field in WebKit
platforms with ENABLE_CALENDAR_PICKER, and we may show something useful
information as the default placeholder.

No new tests because of no behavior changes.

* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement): Make isPlaceholderEmpty() virtual.
* html/HTMLInputElement.h:
(HTMLInputElement): Overrides isPlaceholderEmpty().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPlaceholderEmpty):
Check InputType::defaultPlaceholder() if InputType::usesFixedPlaceholder().
* html/InputType.cpp:
(WebCore::InputType::usesFixedPlaceholder): Added. Returns false.
(WebCore::InputType::fixedPlaceholder): Added. Returns a null string.
* html/InputType.h:
(InputType): Add usesFixedPlaceholder() and fixedPlaceholder().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
Uses fixedPlaceholder() instead of strippedPlaceholder() if usesFixedPlaceholder().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove some code of LocalizedNumberICU.cpp to ICULocale.cpp
tkent@chromium.org [Tue, 17 Apr 2012 08:20:38 +0000 (08:20 +0000)]
Move some code of LocalizedNumberICU.cpp to ICULocale.cpp
https://bugs.webkit.org/show_bug.cgi?id=84128

Reviewed by Hajime Morita.

No new tests. No behavior change.

* WebCore.gypi: Add ICULocale.cpp
* platform/text/ICULocale.cpp:
Added. Move some code from LocalizedNumberICU.cpp
* platform/text/ICULocale.h:
(ICULocale): Add currentLocale().
* platform/text/LocalizedNumberICU.cpp:
(WebCore::convertToLocalizedNumber): Use ICULocale::currentLocale().
(WebCore::convertFromLocalizedNumber): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Plugins] delete ws_info regardless of window mode.
hausmann@webkit.org [Tue, 17 Apr 2012 07:47:28 +0000 (07:47 +0000)]
[Plugins] delete ws_info regardless of window mode.
https://bugs.webkit.org/show_bug.cgi?id=83004

Patch by Bang Kwang min <justine.bang@samsung.com> on 2012-04-17
Reviewed by Simon Hausmann.

m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
Every plugin works well after this patch without any crash.
Additionally, change casting syntax to C++ style.

* plugins/PluginView.cpp:
(WebCore::PluginView::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Calendar Picker: Popup position is wrong when there are
tkent@chromium.org [Tue, 17 Apr 2012 07:40:30 +0000 (07:40 +0000)]
[Chromium] Calendar Picker: Popup position is wrong when there are
no enough space below the target date field
https://bugs.webkit.org/show_bug.cgi?id=84007

Reviewed by Hajime Morita.

The popup was detached from the origin element because
calendarPicker.js resizes its window. To fix this bug, we move the
window position vertically when it is resized.

No new tests. This is not testable in WebKit.

* src/WebPagePopupImpl.cpp:
(WebKit::PagePopupChromeClient::setWindowRect):
If this request is just a resize and m_isPutAboveOrigin is true,
update the vertical position so that the popup attaches to the
origin rectangle.
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_isPutAboveOrigin with false.
(WebKit::WebPagePopupImpl::init): Set m_isPutAboveOrigin true.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Add m_isPutAboveOrigin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCalendar Picker: Support RTL layout
tkent@chromium.org [Tue, 17 Apr 2012 07:30:46 +0000 (07:30 +0000)]
Calendar Picker: Support RTL layout
https://bugs.webkit.org/show_bug.cgi?id=83668

Reviewed by Hajime Morita.

.:

* ManualTests/forms/calendar-picker.html:
Add Arabic parameters.
Add <select> to select a locale.

Source/WebCore:

Manual test: ManualTests/forms/calendar-picker.html

* Resources/calendarPicker.js:
(layout): If params.isRTL, add dir=rtl to the body.
(DaysTable.prototype._handleKey): Reverse Left and Right cursor keys if RTL.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::addProperty): Add addProperty() with a bool value.
(WebCore::CalendarPickerElement::writeDocument):
Check the direction of the first character of localized January label,
and pass it as isRTL property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.
ossy@webkit.org [Tue, 17 Apr 2012 07:21:42 +0000 (07:21 +0000)]
[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium expectations.
toyoshim@chromium.org [Tue, 17 Apr 2012 07:18:46 +0000 (07:18 +0000)]
Unreviewed, update chromium expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
rniwa@webkit.org [Tue, 17 Apr 2012 07:18:44 +0000 (07:18 +0000)]
Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
https://bugs.webkit.org/show_bug.cgi?id=84068

Reviewed by Eric Seidel.

Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
automatically creates the build directory if needed.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadAndPerfTestFactory.__init__):
(DownloadAndPerfTestWebKit2Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix make distcheck issues.
carlosgc@webkit.org [Tue, 17 Apr 2012 06:45:27 +0000 (06:45 +0000)]
Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.list.am: Add missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinsertedIntoDocument and insertedIntoTree should be unitifed.
commit-queue@webkit.org [Tue, 17 Apr 2012 06:40:55 +0000 (06:40 +0000)]
insertedIntoDocument and insertedIntoTree should be unitifed.
https://bugs.webkit.org/show_bug.cgi?id=82701

Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
served as lifecycle callbacks which are invoked when a node is
inserted into its new parent. There are also removedFromTree()
and removedFromDocument() respectively. Considering that this pair
of virtual functions are laid onto the hot path, it's worth
merging them into one, to gain some speedup. Such
unification could clarify the semantics as well.

This change makes following change to merge these functions.

- pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
- letting new Node::insertInto() do the job for its own, but not
  for its children and
- Pass the parent of each insertion root as a parameter of insertedInto().
  This root node can tell inserted node where it is inserted,
  specifically whetehr the insertion is to the document or not.

Same pattern is also applied to Node::removedFromDocument() and
Node::removedFromTree(), which are factored to Node::removedFrom()
and ChildNodeRemovalNotifier respectively.

Speed up on Dromaeo/dom-modify.html is about 2%.
Further speed-up by de-virtulization would be possible.

Caveat:

There is possible situation where a node need to invoke
insertedInto() after its children is nofitied, instead of before
that.  It was represented naturally with previous
traversal-by-ContainerNode pattern, but is no longer simple with
this new external traversal. To support this scenario, we
introduced the InsertionNotificationRequest as a return value of insertedInto()
and a supplemental hook Node::didNotifyDescendantInseretions(). See for
example HTMLFormElement.cpp to learn how it works.

No new tests. Covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
(WebCore::updateTreeAfterInsertion):
* dom/ContainerNode.h:
(ContainerNode):
(WebCore::Node::highestAncestor):
(WebCore):
* dom/ContainerNodeAlgorithms.cpp: Added.
(WebCore):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
* dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
(WebCore):
(ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(Private):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
(WebCore::ChildNodeRemovalNotifier::notify):
* dom/DOMAllInOne.cpp:
* dom/DocumentType.cpp:
(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):
* dom/DocumentType.h:
(DocumentType):
* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(Element):
* dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):
* dom/Node.h:
(Node):
(WebCore::Node::didNotifyDescendantInseretions):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* dom/ProcessingInstruction.h:
(ProcessingInstruction):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::insertedInto):
* dom/ScriptElement.h:
(WebCore):
(ScriptElement):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
* dom/ShadowTree.h:
(ShadowTree):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):
* html/HTMLBaseElement.h:
(HTMLBaseElement):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):
* html/HTMLBodyElement.h:
(HTMLBodyElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInseretions):
(WebCore::HTMLFormElement::removedFrom):
* html/HTMLFormElement.h:
(HTMLFormElement):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):
* html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):
* html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):
* html/HTMLIFrameElement.h:
(HTMLIFrameElement):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
* html/HTMLImageElement.h:
(HTMLImageElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):
* html/HTMLInputElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
* html/HTMLLinkElement.h:
(HTMLLinkElement):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
* html/HTMLMapElement.h:
(HTMLMapElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::insertedInto):
* html/HTMLMetaElement.h:
(HTMLMetaElement):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):
* html/HTMLObjectElement.h:
(HTMLObjectElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedInto):
* html/HTMLOptionElement.h:
(HTMLOptionElement):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
* html/HTMLQuoteElement.h:
(HTMLQuoteElement):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
* html/HTMLScriptElement.h:
(HTMLScriptElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto):
* html/HTMLSelectElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
* html/HTMLSourceElement.h:
(HTMLSourceElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
* html/HTMLStyleElement.h:
(HTMLStyleElement):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto):
* html/HTMLTextFormControlElement.h:
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):
* html/HTMLTitleElement.h:
(HTMLTitleElement):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto):
* html/HTMLTrackElement.h:
(HTMLTrackElement):
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
* mathml/MathMLMathElement.h:
(MathMLMathElement):
* svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):
* svg/SVGFEImageElement.h:
(SVGFEImageElement):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):
* svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::insertedInto):
* svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):
* svg/SVGGlyphElement.h:
(SVGGlyphElement):
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
* svg/SVGHKernElement.h:
(SVGHKernElement):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::insertedInto):
* svg/SVGImageElement.h:
(SVGImageElement):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
* svg/SVGSVGElement.h:
(SVGSVGElement):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
* svg/SVGScriptElement.h:
(SVGScriptElement):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):
* svg/SVGStyleElement.h:
(SVGStyleElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
* svg/SVGStyledElement.h:
(SVGStyledElement):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):
* svg/SVGTRefElement.h:
(SVGTRefElement):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
* svg/SVGTextPathElement.h:
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):
* svg/SVGTitleElement.h:
(SVGTitleElement):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
* svg/SVGUseElement.h:
(SVGUseElement):
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
* svg/SVGVKernElement.h:
(SVGVKernElement):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStack overflow in CSS parser caused by recursive stylesheet import
commit-queue@webkit.org [Tue, 17 Apr 2012 06:26:53 +0000 (06:26 +0000)]
Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/css/css-imports-redirect-cycle.html

* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):

LayoutTests:

* http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
* http/tests/css/css-imports-redirect-cycle.css: Added.
* http/tests/css/css-imports-redirect-cycle.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix Chromium-Mac build
tkent@chromium.org [Tue, 17 Apr 2012 06:11:54 +0000 (06:11 +0000)]
[Chromium] Fix Chromium-Mac build
https://bugs.webkit.org/show_bug.cgi?id=80054

* chromium/public/WebFilterOperations.h:
(WebKit): WebFilterOperation is a struct, not a class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename LocalizedNumberICU.h to ICULocale.h
tkent@chromium.org [Tue, 17 Apr 2012 05:57:20 +0000 (05:57 +0000)]
Rename LocalizedNumberICU.h to ICULocale.h
https://bugs.webkit.org/show_bug.cgi?id=84119

Reviewed by Kentaro Hara.

Source/WebCore:

LocalizedNumberICU.h contains only ICULocale class. It should be
named as ICULocale.h. We're going to move some functions in
LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale,
and add unit tests for them.

* WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h
* platform/text/ICULocale.h:
Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h.
* platform/text/LocalizedNumberICU.cpp:
Rename LocalizedNumberICU.h to ICULocale.h

Source/WebKit/chromium:

* tests/LocalizedNumberICUTest.cpp: Rename LocalizedNumberICU.h to ICULocale.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip one more worker WebSocket test.
toyoshim@chromium.org [Tue, 17 Apr 2012 05:49:08 +0000 (05:49 +0000)]
Unreviewed, skip one more worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add missing files to build webkit2/Efl.
ryuan.choi@samsung.com [Tue, 17 Apr 2012 05:46:55 +0000 (05:46 +0000)]
[EFL][WK2] Add missing files to build webkit2/Efl.
https://bugs.webkit.org/show_bug.cgi?id=76139

Reviewed by Ryosuke Niwa.

Add missing files needed to build webkit2/Efl.

* Shared/efl/PlatformCertificateInfo.h: Added.
(WebKit):
(PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
* UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Added.
(WebKit):
(WebKit::ThreadLauncher::createWebThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
commit-queue@webkit.org [Tue, 17 Apr 2012 05:36:46 +0000 (05:36 +0000)]
[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=84066

Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.

WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
printing, etc), but this path no longer has any compositor interaction. This moves the code into
DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.

* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Expose compositor filters to Aura through WebLayer
danakj@chromium.org [Tue, 17 Apr 2012 05:28:33 +0000 (05:28 +0000)]
[chromium] Expose compositor filters to Aura through WebLayer
https://bugs.webkit.org/show_bug.cgi?id=80054

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebFilterOperation.h: Added.
(WebKit):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBlurFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebDropShadowFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):
* chromium/public/WebFilterOperations.h: Added.
(WebKit):
(WebFilterOperations):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):

Source/WebCore:

Adds WebFilterOperation that wraps WebCore::FilterOperation and
WebFilterOperations that wraps WebCore::FilterOperations.

We add support for most of the FilterOperation subclasses, and
allow the user to set the WebFilterOperations for both layer
content filters and background filters.

* WebCore.gypi:
* platform/chromium/support/WebFilterOperation.cpp: Added.
(WebKit):
(WebKit::WebBasicColorMatrixFilterOperation::toFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::toFilterOperation):
(WebKit::WebBlurFilterOperation::toFilterOperation):
(WebKit::WebDropShadowFilterOperation::toFilterOperation):
* platform/chromium/support/WebFilterOperations.cpp: Added.
(WebKit):
(WebKit::WebFilterOperations::WebFilterOperations):
(WebKit::WebFilterOperations::append):
(WebKit::WebFilterOperations::clear):
(WebKit::WebFilterOperations::toFilterOperations):

Source/WebKit/chromium:

* WebKit.gyp:
* src/WebLayer.cpp:
(WebKit::WebLayer::setFilters):
(WebKit):
(WebKit::WebLayer::setBackgroundFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAuto-sized frames may be taller than expected
commit-queue@webkit.org [Tue, 17 Apr 2012 05:08:58 +0000 (05:08 +0000)]
Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.

No new tests. The repro steps require using Chrome notifications on Win.

* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, remove invalid text expectation for Snow Leopard.
toyoshim@chromium.org [Tue, 17 Apr 2012 05:08:25 +0000 (05:08 +0000)]
Unreviewed, remove invalid text expectation for Snow Leopard.

* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, remove useless text expectation for WinXP
toyoshim@chromium.org [Tue, 17 Apr 2012 04:32:38 +0000 (04:32 +0000)]
Unreviewed, remove useless text expectation for WinXP

* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip a worker WebSocket test.
toyoshim@chromium.org [Tue, 17 Apr 2012 04:09:44 +0000 (04:09 +0000)]
Unreviewed, skip a worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 17 Apr 2012 03:58:18 +0000 (03:58 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
tkent@chromium.org [Tue, 17 Apr 2012 03:42:46 +0000 (03:42 +0000)]
[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
https://bugs.webkit.org/show_bug.cgi?id=84116

Reviewed by Kentaro Hara.

This makes no behavior change. Just move some code.
To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
above the target element or below the target element.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Rename an argument name.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl...
jamesr@google.com [Tue, 17 Apr 2012 03:04:11 +0000 (03:04 +0000)]
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
https://bugs.webkit.org/show_bug.cgi?id=83963

Reviewed by Adrienne Walker.

Source/Platform:

Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface.

* Platform.gypi:
* chromium/public/WebContentLayer.h:
(WebContentLayer):
* chromium/public/WebLayer.h:
(WebLayer):
(WebKit::WebLayer::unwrap):
* chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h.
(WebKit):
(WebVideoFrameProvider):
(WebKit::WebVideoFrameProvider::~WebVideoFrameProvider):
(Client):
* chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::~WebVideoLayer):

Source/WebCore:

Converts VideoLayerChromium / CCVideoLayerImpl to use a Platform WebVideoFrameProvider interface instead of a
WebCore VideoFrameProvider.

* WebCore.gypi:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
* platform/graphics/chromium/VideoLayerChromium.h:
(WebKit):
(WebCore):
(VideoLayerChromium):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):
(CCVideoLayerImpl):

Source/WebKit/chromium:

Adds implementation of WebVideoLayer and ports WebMediaPlayerClientImpl over to using it.
WebMediaPlayerClientImpl still exposes a WebCore::VideoLayerChromium* to the compositor via the platformLayer()
interface, but this is temporary until we can change the PlatformLayer typedef over to WebLayer.

* WebKit.gyp:
* src/WebContentLayer.cpp:
* src/WebLayer.cpp:
(WebKit::WebLayer::invalidate):
(WebKit):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebVideoLayer.cpp: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Shadow DOM] InsertionPoint should have isActive() member function.
commit-queue@webkit.org [Tue, 17 Apr 2012 02:55:40 +0000 (02:55 +0000)]
[Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010

Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-16
Reviewed by Hajime Morita.

This patch adds isActive public member function to InsertionPoint and
makes InsertionPoint elements consider whether active or not.
If an InsertionPoint is inactive, the element is not shadow boundary
and is needed to be rendered.
c.f. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point

Test: update existing tests, i.e.
LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html and
LayoutTests/fast/dom/shadow/shadow-contents-fallback.html

* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::isActive):
A new public method for checking whether an insertion point is active or inactive.
If active, returns true. Otherwise, false.
(WebCore::InsertionPoint::isShadowBoundary):
Make the method consider whether an insertin point is active or inactive.
(WebCore::InsertionPoint::rendererIsNeeded):
Changed to return true If an insertion point is inactive.
(WebCore::InsertionPoint::attach):
Changed to call only HTMLElement::attach If an insertion point is inactive.
(WebCore::InsertionPoint::detach):
Changed to call only HTMLElement::detach If an insertion point is inactive.
* html/shadow/InsertionPoint.h:
(InsertionPoint):
Added isActive public method.
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
Changed to take into account an insertion point's activeness when parent is an insertion point.
(WebCore::NodeRenderingContext::firstRendererOf):
(WebCore::NodeRenderingContext::lastRendererOf):
Changed to take into account an insertion point's activeness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoType tags in NodeFlags could be compressed
morrita@google.com [Tue, 17 Apr 2012 02:15:18 +0000 (02:15 +0000)]
Type tags in NodeFlags could be compressed
https://bugs.webkit.org/show_bug.cgi?id=79299

Because existing node flags which indicate the class of each node
are mutually exclusive, these flags can be represented as a enum.
This patch introduces Node::NodeTypeTag to turn these flags into a
enum, and embeds it into Node::m_nodeFlags.

Reviewed by Antti Koivisto.

No new tests. No bahavior change.

* dom/Node.cpp:
(WebCore):
* dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::typeTag):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
(WebCore::Node::isContainerNode):
(WebCore::Node::isElementNode):
(WebCore::Node::isStyledElement):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isShadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use configure instead of autogen.sh for gtk+
kov@webkit.org [Tue, 17 Apr 2012 02:02:26 +0000 (02:02 +0000)]
[GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112

Rubber-stamped by Martin Robinson.

* gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114285.
commit-queue@webkit.org [Tue, 17 Apr 2012 00:55:31 +0000 (00:55 +0000)]
Unreviewed, rolling out r114285.
http://trac.webkit.org/changeset/114285
https://bugs.webkit.org/show_bug.cgi?id=84107

broke fast/media/media-query-list-08.html in Mac (Requested by
andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
* dom/Document.h:
(Document):
* page/FrameView.cpp:
(WebCore::FrameView::layout):

LayoutTests:

* fast/media/media-query-list-08-expected.txt: Removed.
* fast/media/media-query-list-08.html: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
commit-queue@webkit.org [Tue, 17 Apr 2012 00:48:17 +0000 (00:48 +0000)]
Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=84046

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebMediaPlayer.h:
(WebKit):
* public/WebMediaPlayerClient.h:
* public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.
(WebKit):
(WebKit::WebTimeRange::WebTimeRange):
(WebTimeRange):
* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused variable CachedResourceLoader::m_loadFinishing
japhet@chromium.org [Tue, 17 Apr 2012 00:47:31 +0000 (00:47 +0000)]
Remove unused variable CachedResourceLoader::m_loadFinishing
https://bugs.webkit.org/show_bug.cgi?id=84100

Reviewed by Alexey Proskuryakov.

No new tests, removing dead code.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::decrementRequestCount):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
(WebCore::CachedResourceLoader::requestCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollowup to http://trac.webkit.org/changeset/114323
beidson@apple.com [Tue, 17 Apr 2012 00:35:09 +0000 (00:35 +0000)]
Followup to trac.webkit.org/changeset/114323

For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.

Reviewed by Mark Rowe.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114322.
kov@webkit.org [Tue, 17 Apr 2012 00:35:01 +0000 (00:35 +0000)]
Unreviewed, rolling out r114322.
http://trac.webkit.org/changeset/114322
https://bugs.webkit.org/show_bug.cgi?id=84096

Didn't make the debug bot happy, so back out

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
kling@webkit.org [Tue, 17 Apr 2012 00:28:11 +0000 (00:28 +0000)]
Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
<http://webkit.org/b/83988>

Reviewed by Antti Koivisto.

Remove the 'context style sheet' argument to <font face> value parsing.
It was only ever used to grab at the CSSValuePool back when they were per-Document.

* css/CSSParser.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
* css/CSSValuePool.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFaceValue):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Consistent checking for clipped rects when we need the computed result...
danakj@chromium.org [Tue, 17 Apr 2012 00:21:46 +0000 (00:21 +0000)]
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/11238965> Leak in Plugin Process when launched 32-bit
beidson@apple.com [Tue, 17 Apr 2012 00:21:10 +0000 (00:21 +0000)]
<rdar://problem/11238965> Leak in Plugin Process when launched 32-bit

Reviewed by Jessie Berlin.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Try to fix debug bot by adding gobject-introspection to the build
kov@webkit.org [Tue, 17 Apr 2012 00:18:15 +0000 (00:18 +0000)]
[GTK] Try to fix debug bot by adding gobject-introspection to the build
https://bugs.webkit.org/show_bug.cgi?id=84096

Unreviewed speculative build fix.

* gtk/jhbuild.modules: Added gobject-introspection, since modules need
an up-to-date introspection m4 for running autogen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd two flaky tests in fast/profiler.
andersca@apple.com [Tue, 17 Apr 2012 00:17:09 +0000 (00:17 +0000)]
Add two flaky tests in fast/profiler.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Don't delete the per context data until the V8IsolatedContext is deleted
arv@chromium.org [Mon, 16 Apr 2012 23:53:38 +0000 (23:53 +0000)]
[V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/security/isolatedWorld/context-destroy.html

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):

LayoutTests:

* http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
* http/tests/security/isolatedWorld/context-destroy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd V8 code generation support for MessagePortArray attributes.
commit-queue@webkit.org [Mon, 16 Apr 2012 23:50:37 +0000 (23:50 +0000)]
Add V8 code generation support for MessagePortArray attributes.
https://bugs.webkit.org/show_bug.cgi?id=83943

Patch by Greg Billock <gbillock@google.com> on 2012-04-16
Reviewed by Kentaro Hara.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::ports):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_get_ports):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface ports]):
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property...
scheib@chromium.org [Mon, 16 Apr 2012 23:45:21 +0000 (23:45 +0000)]
[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114309.
commit-queue@webkit.org [Mon, 16 Apr 2012 23:37:40 +0000 (23:37 +0000)]
Unreviewed, rolling out r114309.
http://trac.webkit.org/changeset/114309
https://bugs.webkit.org/show_bug.cgi?id=84097

it broke everything (Requested by olliej on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/CodeBlock.h:
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(functionJSCStack):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
* parser/Parser.h:
(JSC::::parse):
* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
* runtime/Error.h:
(JSC):

LayoutTests:

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js:
(selfRecursive1):
* fast/js/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplatform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
xji@chromium.org [Mon, 16 Apr 2012 23:32:16 +0000 (23:32 +0000)]
platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521

Reviewed by David Levin.

No functionality change, so no new tests.

* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake borderBoxRect sub-pixel precise and add a pixel snapped version
leviw@chromium.org [Mon, 16 Apr 2012 23:24:15 +0000 (23:24 +0000)]
Make borderBoxRect sub-pixel precise and add a pixel snapped version
https://bugs.webkit.org/show_bug.cgi?id=84063

Reviewed by Eric Seidel.

In an effort to prevent misuse, we previously decided to have borderBoxRect return a
pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned
at (0,0), and therefore won't snap to the same size as the element it's covering.

There are a couple uses of borderBoxRect that don't pixel snap the values and require
sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping
explicit, and moves uses that would otherwise pixel snap the rect to this version to
avoid producing a rect of the incorrect size. For details about pixel snapping with
LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

* html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addVisualOverflowFromTheme):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
(WebCore::RenderBox::pixelSnappedBorderBoxRect):
(WebCore::RenderBox::borderBoundingBox):
(WebCore::RenderBox::hasVisualOverflow):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addOverflowFromChildren):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline continued from xji's rebase after r114267.
scheib@chromium.org [Mon, 16 Apr 2012 23:19:29 +0000 (23:19 +0000)]
[Chromium] Rebaseline continued from xji's rebase after r114267.

Unreviewed.

* platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening for ietestcenter/grid. Adding reference tests
tomz@codeaurora.org [Mon, 16 Apr 2012 23:10:32 +0000 (23:10 +0000)]
Unreviewed gardening for ietestcenter/grid.  Adding reference tests
and removing gtk expected.txt

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-16

* ietestcenter/css3/grid/display-grid-001-expected.htm: Added.
* ietestcenter/css3/grid/display-grid-002-expected.htm: Added.
* ietestcenter/css3/grid/grid-column-001-expected.htm: Added.
* ietestcenter/css3/grid/grid-column-002-expected.htm: Added.
* ietestcenter/css3/grid/grid-column-003-expected.htm: Added.
* ietestcenter/css3/grid/grid-columns-001-expected.htm: Added.
* ietestcenter/css3/grid/grid-items-001-expected.htm: Added.
* ietestcenter/css3/grid/grid-items-002-expected.htm: Added.
* ietestcenter/css3/grid/grid-items-003-expected.htm: Added.
* ietestcenter/css3/grid/grid-items-004-expected.htm: Added.
* ietestcenter/css3/grid/grid-items-005-expected.htm: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Removed.
* platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Removed.
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add pango to jhbuild
kov@webkit.org [Mon, 16 Apr 2012 22:54:01 +0000 (22:54 +0000)]
[GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086

Unreviewed build fix.

* gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when running some editing related tests
andersca@apple.com [Mon, 16 Apr 2012 22:50:33 +0000 (22:50 +0000)]
Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091

Reviewed by Andreas Kling.

Null check triggeringEvent.

* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoException stack traces aren't complete when the exception starts in native code
oliver@apple.com [Mon, 16 Apr 2012 22:26:36 +0000 (22:26 +0000)]
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOriginIndexForReturn):
(CodeBlock):
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(functionJSCStack):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
* parser/Parser.h:
(JSC::::parse):
* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
* runtime/Error.h:
(JSC):

LayoutTests:

Update tests to include new exception property ordering, and new functions

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js:
(selfRecursive1): Modified slightly so that we produce consistent traces
* fast/js/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] fonts jhbuild module needs an empty clean target
kov@webkit.org [Mon, 16 Apr 2012 22:25:52 +0000 (22:25 +0000)]
[GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085

Rubber-stamped by Martin Robinson.

* gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
includes a phony clean target that should make warnings and errors go
away.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a MIG call when creating a plug-in property list file
andersca@apple.com [Mon, 16 Apr 2012 22:19:50 +0000 (22:19 +0000)]
Use a MIG call when creating a plug-in property list file
https://bugs.webkit.org/show_bug.cgi?id=84084
<rdar://problem/11197341>

Reviewed by Sam Weinig.

* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::createPropertyListFile):
Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.

* Plugins/Hosted/WebKitPluginHost.defs:
Add PHCreatePluginMIMETypesPreferences.

* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage createPropertyListFile]):
NetscapePluginHostManager::createPropertyListFile is no longer a static member function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate test_expectations for chromium
commit-queue@webkit.org [Mon, 16 Apr 2012 22:14:02 +0000 (22:14 +0000)]
Update test_expectations for chromium
https://bugs.webkit.org/show_bug.cgi?id=83965

Patch by David Alcala <dalcala@adobe.com> on 2012-04-16
Reviewed by Dirk Schulze.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebasing pixel tests for composited-document-element, tiny text difference.
scheib@chromium.org [Mon, 16 Apr 2012 22:09:51 +0000 (22:09 +0000)]
[Chromium] Rebasing pixel tests for composited-document-element, tiny text difference.

Unreviewed.

* platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
* platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-add GPU DEPS builders to flakiness dashboard.
commit-queue@webkit.org [Mon, 16 Apr 2012 22:05:15 +0000 (22:05 +0000)]
Re-add GPU DEPS builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=84056

Patch by Dave Tu <dtu@chromium.org> on 2012-04-16
Reviewed by Ojan Vafai.

* Tools/TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Supressing test errors introduced by http://trac.webkit.org/changeset...
scheib@chromium.org [Mon, 16 Apr 2012 22:05:08 +0000 (22:05 +0000)]
[Chromium] Supressing test errors introduced by trac.webkit.org/changeset/114283.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename to updateZOrderListsSlowCase to rebuildZOrderLists
simon.fraser@apple.com [Mon, 16 Apr 2012 22:02:48 +0000 (22:02 +0000)]
Rename to updateZOrderListsSlowCase to rebuildZOrderLists
https://bugs.webkit.org/show_bug.cgi?id=84071

Reviewed by Antti Koivisto.

Use a better name for updateZOrderListsSlowCase().

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::rebuildZOrderLists):
* rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::updateZOrderLists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Allow WebGestureEvent to store four floating point values
commit-queue@webkit.org [Mon, 16 Apr 2012 21:50:48 +0000 (21:50 +0000)]
[chromium] Allow WebGestureEvent to store four floating point values
https://bugs.webkit.org/show_bug.cgi?id=84053

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

See bug description for an explanation of the changes made.

Source/WebCore:

* platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
(WebCore::PlatformGestureEvent::gammaX):
(WebCore::PlatformGestureEvent::gammaY):

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
* src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Flaky layout test LayoutTests/svg/hixie/error/012.xml
schenney@chromium.org [Mon, 16 Apr 2012 21:44:38 +0000 (21:44 +0000)]
[Chromium] Flaky layout test LayoutTests/svg/hixie/error/012.xml
https://bugs.webkit.org/show_bug.cgi?id=84082

Unreviewed Chromium test expectations update.

Results look right but the test maybe flaky.

* platform/chromium-mac-leopard/svg/hixie/error/012-expected.png:
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png:
* platform/chromium-mac/svg/hixie/error/012-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline now that SK_IGNORE_HAIRLINE_CLIP_FIX is undefined
schenney@chromium.org [Mon, 16 Apr 2012 21:33:29 +0000 (21:33 +0000)]
[Chromium] Rebaseline now that SK_IGNORE_HAIRLINE_CLIP_FIX is undefined
https://bugs.webkit.org/show_bug.cgi?id=84075

Unreviewed Chromium expectations update.

* platform/chromium-linux-x86/svg/as-image: Removed.
* platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium/test_expectations.txt:
* svg/hixie/perf/001-expected.txt: Removed.
* svg/hixie/perf/002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring][V8] Remove $indent from NativeToJSValue()
haraken@chromium.org [Mon, 16 Apr 2012 21:19:43 +0000 (21:19 +0000)]
[Refactoring][V8] Remove $indent from NativeToJSValue()
https://bugs.webkit.org/show_bug.cgi?id=84077

Reviewed by Nate Chapin.

$indent in NativeToJSValue() in CodeGeneratorV8.pm is not used.
This patch removes it.

No new tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Bump dependency on GTK+ 3.x to match reality
kov@webkit.org [Mon, 16 Apr 2012 21:19:23 +0000 (21:19 +0000)]
[GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060

Rubber-stamped by Martin Robinson.

.:

* configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we
already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.

Tools:

* gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
to their GNOME 3.4 versions.
* gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
is applied upstream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking failing test platform/chromium/compositing/filters/background...
scheib@chromium.org [Mon, 16 Apr 2012 21:02:59 +0000 (21:02 +0000)]
[Chromium] Marking failing test platform/chromium/compositing/filters/background-filter-blur-outsets.html.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNightly Back/Forward no longer calls plug-in's NPP_NewStream
andersca@apple.com [Mon, 16 Apr 2012 21:02:49 +0000 (21:02 +0000)]
Nightly Back/Forward no longer calls plug-in's NPP_NewStream
https://bugs.webkit.org/show_bug.cgi?id=83805
<rdar://problem/11238748>

Reviewed by Simon Fraser.

When a page with a full-frame plug-in is restored from the page cache, it needs to re-fetch the plug-in stream.

Fix this by breaking the assumption that a plug-in will always get its data from WebCore if it's a full-frame plug-in;
instead it only get its data from WebCore if it's a full-frame plug-in that's not being restored from the page cache.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Rename m_loadManually to m_shouldUseManualLoader.

(WebKit::NetscapePlugin::initialize):
Get the mode from parameters.isFullFramePlugin instead.

(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
Rename m_loadManually to m_shouldUseManualLoader.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Rename m_loadManually to m_shouldUseManualLoader.

* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
* WebProcess/Plugins/Plugin.h:
(Parameters):
Add an extra isFullFramePlugin parameter, and rename loadManually to shouldUseManualLoader.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameCameFromPageCache.

(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Set m_frameCameFromPageCache to true.

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Set m_frameCameFromPageCache to false.

(WebKit::WebFrameLoaderClient::createPlugin):
Initialize isFullFramePlugin and shouldUseManualLoader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline svg/filters/sourceAlpha.svg on mac
schenney@chromium.org [Mon, 16 Apr 2012 20:57:35 +0000 (20:57 +0000)]
[Chromium] Rebaseline svg/filters/sourceAlpha.svg on mac
https://bugs.webkit.org/show_bug.cgi?id=84069

Unreviewed Chromium test expectations update.

Finally closing out an expectations update from 2009.

* platform/chromium-mac-leopard/svg/filters/sourceAlpha-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png:
* platform/chromium-mac/svg/filters/sourceAlpha-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Layout test svg/filters/shadow-on-rect-with-filter.svg fails
schenney@chromium.org [Mon, 16 Apr 2012 20:32:35 +0000 (20:32 +0000)]
[Chromium] Layout test svg/filters/shadow-on-rect-with-filter.svg fails
https://bugs.webkit.org/show_bug.cgi?id=84064

Unreviewed Chromium expectations update.

One of these results, for svg/filters/filter-source-position.svg, is
incorrect, but it should be updated regardless.

* platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/chromium-linux/svg/filters/filter-clip-expected.png: Added.
* platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/chromium-win/svg/filters/filter-clip-expected.png: Added.
* platform/chromium-win/svg/filters/filter-source-position-expected.png: Added.
* platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/filters/filter-source-position-expected.png: Removed.
* platform/efl/svg/filters/filter-source-position-expected.txt: Removed.
* platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
* platform/gtk/svg/filters/filter-source-position-expected.png: Removed.
* platform/gtk/svg/filters/filter-source-position-expected.txt: Removed.
* platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
* platform/mac/svg/filters/filter-source-position-expected.txt: Removed.
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
* platform/qt/svg/filters/filter-source-position-expected.txt: Removed.
* platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
* svg/filters/filter-source-position-expected.png: Added.
* svg/filters/filter-source-position-expected.txt: Added.
* svg/filters/shadow-on-rect-with-filter-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaselining minor text difference in compositing/geometry/fixed-position...
scheib@chromium.org [Mon, 16 Apr 2012 20:26:37 +0000 (20:26 +0000)]
[Chromium] Rebaselining minor text difference in compositing/geometry/fixed-position-composited-page-scale-down.

Unreviewed.

* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove BlobRegistryProxy::createResourceHandle
ap@apple.com [Mon, 16 Apr 2012 20:14:39 +0000 (20:14 +0000)]
[chromium] Remove BlobRegistryProxy::createResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=84047

Reviewed by Nate Chapin.

* src/BlobRegistryProxy.h: (BlobRegistryProxy::createResourceHandle): This function
is no longer used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderImage ignores its percent width/height when setContainerSizeForRenderer
commit-queue@webkit.org [Mon, 16 Apr 2012 20:08:02 +0000 (20:08 +0000)]
RenderImage ignores its percent width/height when setContainerSizeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=80431

Add a test case for Bug 80431. It renders a 1x1 svg as an image with percent
width/height specified.

Patch by Yong Li <yoli@rim.com> on 2012-04-16
Reviewed by Nikolas Zimmermann.

* svg/as-image/resources/rect-1x1.svg: Added.
* svg/as-image/svg-as-image-with-relative-size-expected.html: Added.
* svg/as-image/svg-as-image-with-relative-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverting shader-precision-format.html reftest fix - it only fixed some DBG builders...
scheib@chromium.org [Mon, 16 Apr 2012 20:05:31 +0000 (20:05 +0000)]
Reverting shader-precision-format.html reftest fix - it only fixed some DBG builders. Marking test failing for those.

Unreviewed.

* fast/canvas/webgl/shader-precision-format-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-04-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Mon, 16 Apr 2012 20:00:42 +0000 (20:00 +0000)]
2012-04-16  Antonio Gomes  <agomes@rim.com>

        Screen shift down when VKB shows by clicking in a input box MKS_3601371
        PR #149846

        Reviewed by Rob Buis.

        After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
        we had a less restricted code path allowing/disallowing overscrolling. That caused
        some webpages like google.com to get on overscroll when adjusting the scroll
        position to ensure the focused input field is visible.

        Patch restricts the way we allow overscrolling to the bottom, where the virtual
        keyboard pops up from, clamping it to 0, 0 if it tries to
        overscroll upwards, and to maximum scroll position if it overscrolls
        downwards.

        Internally reviewed by Mike Fenton.
        PR #149846

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline after r114267.
xji@chromium.org [Mon, 16 Apr 2012 19:34:24 +0000 (19:34 +0000)]
Rebaseline after r114267.

* platform/chromium-linux/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
* platform/chromium-mac/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago EndPrinting message should be sent synchronously when printing was initiated...
ap@apple.com [Mon, 16 Apr 2012 18:52:20 +0000 (18:52 +0000)]
    EndPrinting message should be sent synchronously when printing was initiated from DOM.
        https://bugs.webkit.org/show_bug.cgi?id=84049
        <rdar://problem/11096575>

        Reviewed by Oliver Hunt.

        * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame): When printing is
        initiated by WebProcess, all messages from UI process are sent synchronously to
        avoid being queued, and so should EndPrinting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomatchMedia() MediaQueryList not updating
antti@apple.com [Mon, 16 Apr 2012 18:45:29 +0000 (18:45 +0000)]
matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-16
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/media-query-list-08.html

Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.

The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.

* dom/Document.cpp:
(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):
* dom/Document.h:
(Document):
* page/FrameView.cpp:
(WebCore::FrameView::layout):

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

* fast/media/media-query-list-08-expected.txt: Added.
* fast/media/media-query-list-08.html: Added.

Skipping the new test in Qt due to an issue in its DumpRenderTree.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Delete uncalled unreserveContentsTextures function
commit-queue@webkit.org [Mon, 16 Apr 2012 18:41:37 +0000 (18:41 +0000)]
[chromium] Delete uncalled unreserveContentsTextures function
https://bugs.webkit.org/show_bug.cgi?id=84005

Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.

This is vestigal dead code.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid using backing store for compositing layers that just need to clip
simon.fraser@apple.com [Mon, 16 Apr 2012 18:32:13 +0000 (18:32 +0000)]
Avoid using backing store for compositing layers that just need to clip
https://bugs.webkit.org/show_bug.cgi?id=40547

Source/WebCore:

Reviewed by Dean Jackson.

If a layer becomes composited because it needs to clip composited
descendants, or if it has perspective, then it doesn't actually
needs its own backing store; its contents can be painted by an
ancestor, and we can just have an empty layer that does the clipping
or applies the perspective transform.

This saves backing store memory on some pages.

Tests: compositing/backing/no-backing-for-clip-overlap.html
       compositing/backing/no-backing-for-clip.html
       compositing/backing/no-backing-for-perspective.html

* rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::paintLayer):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
(WebCore::RenderLayerBacking::paintsIntoCompositedAncestor):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore):
* rendering/RenderLayerCompositor.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

Reviewed by Dean Jackson.

New tests for backing store elimination with clip or perspective.

New results for some tests that no longer have backing store on some
layers.

* compositing/backing/no-backing-for-clip-expected.txt: Added.
* compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
* compositing/backing/no-backing-for-clip-overlap.html: Added.
* compositing/backing/no-backing-for-clip.html: Added.
* compositing/backing/no-backing-for-perspective-expected.txt: Added.
* compositing/backing/no-backing-for-perspective.html: Added.
* compositing/geometry/preserve-3d-switching-expected.txt:
* compositing/visibility/layer-visible-content-expected.png:
* compositing/visibility/layer-visible-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Increase padding for text element
commit-queue@webkit.org [Mon, 16 Apr 2012 18:27:42 +0000 (18:27 +0000)]
[BlackBerry] Increase padding for text element
https://bugs.webkit.org/show_bug.cgi?id=83903

Patch by Yongxin Dai <yodai@rim.com> on 2012-04-16
Reviewed by Antonio Gomes.

PR 125888

Increase the padding value for focused text element to make selection handle
at least partially visible when the user is dragging at edge of viewport
in in-region scoll mode.

Reviewed internally by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking css3/filters/huge-region.html and composited version MISSING,...
scheib@chromium.org [Mon, 16 Apr 2012 18:27:03 +0000 (18:27 +0000)]
[Chromium] Marking css3/filters/huge-region.html and composited version MISSING, CRASH.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding Contributors Brian Salomon and Tom Hudson to committers.py.
scheib@chromium.org [Mon, 16 Apr 2012 18:12:25 +0000 (18:12 +0000)]
Adding Contributors Brian Salomon and Tom Hudson to committers.py.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix a flaky JS test.
andersca@apple.com [Mon, 16 Apr 2012 18:06:00 +0000 (18:06 +0000)]
Try to fix a flaky JS test.

Use a URL that's allowed to load so the resource load delegate won't randomly complain about it depending on
if the load starts before the Audio object is garbage collected (that's my guess anyway).

* fast/js/custom-constructors-expected.txt:
* fast/js/script-tests/custom-constructors.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2...
beidson@apple.com [Mon, 16 Apr 2012 18:01:30 +0000 (18:01 +0000)]
<rdar://problem/11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2 back/forward items in the page cache are never removed when the page is closed

Reviewed by Jessie Berlin and unofficially reviewed by Jon Lee.

Source/WebCore:

* WebCore.exp.in: Export PageCache::remove()

Source/WebKit2:

Individual WebBackForwardListProxy's had no idea which items are associated with them.
This adds that association and makes sure the proxy removes all associated items from the PageCache when it closes.

* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem): Remove the item from the PageCache in case it was in it.
(WebKit::WebBackForwardListProxy::addItem): Add the item ID to this back/forward list's set of associated IDs.
(WebKit::WebBackForwardListProxy::close): Remove each associated item from the PageCache.
* WebProcess/WebPage/WebBackForwardListProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK build fix after r114269.
philn@webkit.org [Mon, 16 Apr 2012 17:51:18 +0000 (17:51 +0000)]
Unreviewed, GTK build fix after r114269.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for...
commit-queue@webkit.org [Mon, 16 Apr 2012 17:43:23 +0000 (17:43 +0000)]
Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606

Patch by Raymes Khoury <raymes@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114275 268f45cc-cd09-0410-ab3c-d52691b4dbfc