14 years ago Added 2 skipped tests
beidson@apple.com [Sat, 16 Feb 2008 02:02:30 +0000 (02:02 +0000)]
    Added 2 skipped tests

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Sat, 16 Feb 2008 00:51:38 +0000 (00:51 +0000)]

        Reviewed by Darin

        Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
        a page has closed or loaded a new document

        Deciding to make the Database I/O semantic the same as loaders/XHR when a document is shut down, this patch implements
        a policy of shutting down the databases in a document at the same time.  This includes removing all pending transactions
        in a database, cutting off an queued statements in the current transaction, and preventing further callbacks from being

        No new layout tests with this patch as the current layout tests were catching this issue in a plethora of ways already
        (crashing, unexpected exceptions and output, etc)

        * dom/Document.cpp:
        (WebCore::Document::~Document): Don't actually stop the database thread here - it better have been stopped already.
          Add an assertion to that effect.
        (WebCore::Document::addOpenDatabase): Add a new database handle to this Document's open database set
        (WebCore::Document::removeOpenDatabase): Remove such a handle
        (WebCore::Document:: stopDatabases): Call "close" on all open Database handles for this document
        * dom/Document.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): In addition to canceling all resource loads and XHRs, stop all database I/O

        * platform/MessageQueue.h:

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::stop): Added.  Explicit stop to cut off a transaction so it won't try anymore SQL activity
        * platform/sql/SQLiteTransaction.h:

        * storage/Database.cpp:
        (WebCore::Database::markAsDeletedAndClose): Check if the thread has terminated before committing to waiting on the
        (WebCore::Database::stop):  Stop this database, including all queued transactions and callbacks
        * storage/Database.h:

        * storage/DatabaseThread.cpp:
        * storage/DatabaseThread.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL): Throw an exception if a new executeSQL comes in after a database is closed
        (WebCore::SQLTransaction::checkAndHandleClosedDatabase): Added.  Clears queued statements and clear the next step
          when the database has been closed since the last step/callback was run.  Also stops the current SQLite transaction,
          if any
        * storage/SQLTransaction.h:


        Reviewed by Darin

        Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
        a page has closed or loaded a new document

        * storage/close-during-stress-test-expected.txt: Update results - this test contained output from a javascript callback
          that never should have taken place

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele@apple.com [Sat, 16 Feb 2008 00:44:56 +0000 (00:44 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

        The immediate cause of this bug was that we stopped sending keypress events for the tab key when it is used to advance focus.
        We had a special case for forward-tab in designMode, where the default behavior was to insert a tab key (or respect the keypress handler behavior).
        This change makes the shift-tab behavior match the forward-tab behavior.

        If the site had put their event handler (which does the indenting) on the keydown event, then this problem would have been avoided.
        This is something we should look into and maybe advise the site on in the future.  However, it's a low-risk change to just make tab and shift-tab uniform
        in this respect, so I think this is the way to go for right now.

        * page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):


        Reviewed by Darin.

        Updated test for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

        * editing/inserting/typing-tab-designmode-expected.txt:
        * editing/inserting/typing-tab-designmode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Alice.
andersca@apple.com [Fri, 15 Feb 2008 23:47:12 +0000 (23:47 +0000)]
    Reviewed by Alice.

        REGRESSION: "Loading" status remains when uploading file to .Mac iDisk via Safari

        Use the new CFNetwork functions for setting body parts.

        * platform/network/cf/FormDataStreamCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ggaren@apple.com [Fri, 15 Feb 2008 23:39:14 +0000 (23:39 +0000)]

        Reviewed by Anders Carlsson.

        Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
        surveys no longer work due to XMLHttpRequest exceptions

        Reverted some exception throwing code from r12194.

        To comply with the W3C draft spec, we used to throw an exception when
        trying to access responseText and responseXML at the wrong time, but
        that turned out to be a compatibility problem.

        Now, matching Firefox and previous versions of WebKit, we never throw
        an exception when accessing responseText or responseXML.

        See http://www.mail-archive.com/public-webapi@w3.org/msg02756.html.

        * xml/XMLHttpRequest.cpp:


        Reviewed by Anders Carlsson.

        Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
        surveys no longer work due to XMLHttpRequest exceptions

        Updated layout tests to expect an exception not to be thrown.

        * http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html:
        * http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html:
        * http/tests/xmlhttprequest/zero-length-response-expected.txt:
        * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agominor correction to my last Changlog entry.
alice.liu@apple.com [Fri, 15 Feb 2008 23:27:39 +0000 (23:27 +0000)]
minor correction to my last Changlog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Fri, 15 Feb 2008 23:25:26 +0000 (23:25 +0000)]

        Reviewed by Dan Bernstein.

        <rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace

        Rolled out <http://trac.webkit.org/projects/webkit/changeset/29667>

        * editing/SelectionController.cpp:


        Reviewed by Dan Bernstein.

        <rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace

        * editing/selection/inconsistent-in-removeChildNode.html: Removed.
        * editing/selection/inconsistent-in-removeChildNode.html-disabled: Added.

        Demonstrates fix:
        * editing/undo/5738768-expected.txt: Added.
        * editing/undo/5738768.html: Added.

        During a shouldChangeSelection call, the old selection is no longer null because
        nodeWillBeRemoved doesn't blow it away:
        * platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
        * platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
        * platform/mac/editing/style/remove-underline-in-bold-expected.txt:

        During a shouldChangeSelection call, the old selection is now null because
        nodeWillBeRemoved blows it away:
        * platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:

        More instances of <rdar://problem/5729315>, where, during a shouldChangeSelection
        call content that held the old selection is still around but it wouldn't make sense
        to leave the selection there, so we shouldn't call shouldChangeSelection at all:
        * platform/mac/editing/style/remove-underline-expected.txt:
        * platform/mac/editing/style/unbold-in-bold-expected.txt:

        Similar changes, but ones where I've also updated pixel results for old, unrelated fixes:
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
        * platform/mac/editing/deleting/delete-leading-ws-001-expected.checksum:
        * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-011-expected.checksum:
        * platform/mac/editing/deleting/delete-line-011-expected.txt:
        * platform/mac/editing/execCommand/paste-1-expected.checksum:
        * platform/mac/editing/execCommand/paste-1-expected.txt:
        * platform/mac/editing/execCommand/paste-2-expected.checksum:
        * platform/mac/editing/execCommand/paste-2-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-012-expected.checksum:
        * platform/mac/editing/selection/4960116-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
alice.liu@apple.com [Fri, 15 Feb 2008 23:18:25 +0000 (23:18 +0000)]
    Reviewed by Darin.

        Fixed <rdar://problem/5741440> REGRESSION (r28496): After deactivating JavaScript, scripts embedded in the HTML page continue to run

        Before this patch, Frame::scriptProxy() would only return null in the case that javascript was
        disabled and if the script proxy field wasn't set (which would only be the case if the window
        hasn't loaded anything yet).  Not all callers of scriptProxy() always check for a non-null return
        value.  Those that did check would effectively be checking if javascript was enabled before proceeding.
        This fix consists of 2 elements: first, make sure that scriptProxy() will never return null, regardless
        of whether javascript is disabled.  This will mean that callers who don't check for null won't crash.
        Second, callers who did check for null now instead check for javascript being disabled.  This means that
        code paths intended for preventing javascript from being run will be making the correct check.  Another
        minor addition to this patch is that I added a function on Frame to be a shortcut for checking if javascript
        is enabled.

        * bindings/js/JSCustomSQLStatementCallback.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_proxy.h:
        * bindings/js/kjs_window.cpp:
        * dom/Document.cpp:
        * dom/EventTarget.cpp:
        * html/HTMLPlugInElement.cpp:
        * html/HTMLScriptElement.cpp:
        * html/HTMLTokenizer.cpp:
        * loader/FrameLoader.cpp:
        * manual-tests/disable-javascript-reload.html: Added.
        * page/Frame.cpp:
        * page/Frame.h:
        * page/InspectorController.cpp:
        * page/mac/FrameMac.mm:
        * svg/SVGDocumentExtensions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 15 Feb 2008 21:30:48 +0000 (21:30 +0000)]

        Reviewed by Alexey Proskuryakov.

        - WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
          <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html

        Test: http/tests/loading/text-content-type-with-binary-extension.html

        Refined the workaround for <rdar://problem/5321972> to exclude files
        with extensions that are known to be associated with binary MIME types.

        * WebCore.xcodeproj/project.pbxproj: Added WebCoreURLResponse.{h,mm}.
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::doUpdateResourceResponse): Moved the
        workaround logic into WebCoreURLResponse.
        * platform/network/mac/WebCoreURLResponse.h: Added.
        * platform/network/mac/WebCoreURLResponse.mm: Added.
        (createBinaryExtensionsSet): Returns a set of extensions known to
        belong to MIME types of binary data.
        (-[NSURLResponse _webcore_MIMEType]):
        (-[NSHTTPURLResponse _webcore_MIMEType]): Forces the MIME type from
        application/octet-stream to text/plain if that is the specified
        Content-Type, unless the extension is in the binary extensions set.


        Reviewed by Alexey Proskuryakov.

        - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
          <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html

        * WebView/WebDataSource.mm:
        (+[WebDataSource _representationClassForMIMEType:]):
        (-[WebDataSource _responseMIMEType]):
        (-[WebDataSource subresources]):
        (-[WebDataSource subresourceForURL:]):
        * WebView/WebResource.mm:
        (-[WebResource _initWithData:URL:response:]):
        * WebView/WebResourcePrivate.h:


        Reviewed by Alexey Proskuryakov.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17360
          <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html

        * http/tests/loading/resources/.htaccess: Added.
        * http/tests/loading/resources/binaryData.m4a: Added.
        * http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
        * http/tests/loading/text-content-type-with-binary-extension.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and rubber-stamped by Oliver Hunt.
weinig@apple.com [Fri, 15 Feb 2008 21:26:50 +0000 (21:26 +0000)]
    Reviewed and rubber-stamped by Oliver Hunt.

        Add leopard specific results for stroke-width-click.svg to work around
        a CG regression.

        * platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Fri, 15 Feb 2008 21:08:05 +0000 (21:08 +0000)]
    Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17306
          <rdar://problem/5737923> Transitions between styles that have different transition-* properties behave inconsistently

        * manual-tests/transitions.html: Added.
        * page/AnimationController.cpp:
        (WebCore::CompositeImplicitAnimation::animate): Changed to use the
        transition properties of the current style rather than the target style.
        (WebCore::AnimationControllerPrivate::get): Changed to not create an
        animation if the style does not have transitions.
        (WebCore::AnimationController::updateImplicitAnimations): Added code to
        return the target style if the current style is not animating.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setAnimatableStyle): Changed to call
        updateImplicitAnimations() even if the current style does not have
        transitions, because we may be animating out of a style that had them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Darin.
ap@webkit.org [Fri, 15 Feb 2008 20:06:10 +0000 (20:06 +0000)]
    Rubber-stamped by Darin.

        Remove an obsolete WebCore readme file.

        * README: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
weinig@apple.com [Fri, 15 Feb 2008 18:29:46 +0000 (18:29 +0000)]
    Reviewed by Darin Adler.

        Remove more uses of DeprecatedString in preparation of getting rid of it.

        * bridge/mac/WebCoreScriptDebugger.mm:
        * css/CSSCursorImageValue.cpp:
        * css/CSSStyleSelector.h:
        * dom/Element.cpp:
        * dom/Position.cpp:
        * dom/Range.cpp:
        * dom/Text.cpp:
        * editing/Selection.cpp:
        * editing/SelectionController.cpp:
        * editing/VisiblePosition.cpp:
        * html/HTMLTokenizer.cpp:
        * svg/SVGFontFaceElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-15 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 15 Feb 2008 18:25:44 +0000 (18:25 +0000)]
2008-02-15  Alp Toker  <alp@atoker.com>

        Reviewed by Holger.

        GTK+ configure script cleanups

        Categorize the configuration summary printout.
        Bump GTK+ requirement to 2.8.
        Rename 'webkit_target' to just 'target'.
        Don't check for pthread on Win32.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * bindings/scripts/CodeGenerator.pm: Touch this to force bindings to regenerate.
aroben@apple.com [Fri, 15 Feb 2008 18:04:57 +0000 (18:04 +0000)]
    * bindings/scripts/CodeGenerator.pm: Touch this to force bindings to regenerate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Mac build fix
aroben@apple.com [Fri, 15 Feb 2008 17:49:10 +0000 (17:49 +0000)]
 Mac build fix


         Make JavaScriptCore's FEATURE_DEFINES match WebCore's

         Reviewed by Mark.

         * Configurations/JavaScriptCore.xcconfig:


         Make WebKit's FEATURE_DEFINES match WebCore's

         Reviewed by Mark.

         * Configurations/WebKit.xcconfig:


         Fix a typo that broke the Mac build

         Reviewed by Mark.

         * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Try to fix Qt/GTK+ builds
aroben@apple.com [Fri, 15 Feb 2008 17:04:37 +0000 (17:04 +0000)]
    Try to fix Qt/GTK+ builds

        * WebCore.pro: Remove MessageEvent.{idl,cpp} from the unconditional
        parts of this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Turn on cross-document messaging support by default
aroben@apple.com [Fri, 15 Feb 2008 16:36:54 +0000 (16:36 +0000)]
 Turn on cross-document messaging support by default

 top level:

         Turn on cross-document messaging support by default

         Reviewed by Darin.

         * configure.ac:


         Turn on cross-document messaging support by default

         Reviewed by Darin.

         * Configurations/WebCore.xcconfig:
         * WebCore.pro:
         * WebCore.vcproj/WebCore.vcproj:


         Turn on cross-document messaging support by default

         Reviewed by Darin.

         * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Conditionalize cross-document messaging support
aroben@apple.com [Fri, 15 Feb 2008 16:36:07 +0000 (16:36 +0000)]
 Conditionalize cross-document messaging support

 top level:

         Conditionalize cross-document messaging support

         The cross-document messaging parts of HTML 5 are in flux and we want
         ports to be able to turn off the support as needed.

         Note that the support is turned off by default right now. A subsequent
         commit will turn it on by default.

         Reviewed by Darin.

         * configure.ac:


         Conditionalize cross-document messaging support

         The cross-document messaging parts of HTML 5 are in flux and we want
         ports to be able to turn off the support as needed.

         Note that the support is turned off by default right now. A subsequent
         commit will turn it on by default.

         Reviewed by Darin.

         * GNUmakefile.am:
         * WebCore.vcproj/build-generated-files.sh:
         * bindings/js/JSDOMWindowCustom.cpp:
         * bindings/js/JSEventCustom.cpp:
         * dom/Event.cpp:
         * dom/Event.h:
         * dom/MessageEvent.cpp:
         * dom/MessageEvent.h:
         * dom/MessageEvent.idl:
         * page/DOMWindow.cpp:
         * page/DOMWindow.h:
         * page/DOMWindow.idl:


         Conditionalize cross-document messaging support

         The cross-document messaging parts of HTML 5 are in flux and we want
         ports to be able to turn off the support as needed.

         Note that the support is turned off by default right now. A subsequent
         commit will turn it on by default.

         Reviewed by Darin.

         * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
darin@apple.com [Fri, 15 Feb 2008 15:18:53 +0000 (15:18 +0000)]
    Reviewed by Adam.

        - quick fix for a problem causing an assertion on launch

        * WebFrame.cpp:
        (WebFrame::loadData): Make an empty KURL even if the BSTR is null.
        Later we might want to rethink this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-15 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 15 Feb 2008 11:41:23 +0000 (11:41 +0000)]
2008-02-15  Alp Toker  <alp@atoker.com>

        Fix the GTK+ build following breakage introduced in r30243.

        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - another Qt build fix
darin@apple.com [Fri, 15 Feb 2008 08:21:34 +0000 (08:21 +0000)]
    - another Qt build fix

        * platform/qt/KURLQt.cpp:
        (WebCore::KURL::operator QUrl): Use the characters directly, not ascii().
        Eliminate references to urlString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Fri, 15 Feb 2008 08:12:08 +0000 (08:12 +0000)]

        - another Qt build fix

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage): Use KURL instead of String.


        - another try at fixing the build

        * webkit/webkitwebview.cpp: Added some explicit conversions to KURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - another round of build fixes
darin@apple.com [Fri, 15 Feb 2008 07:23:34 +0000 (07:23 +0000)]
    - another round of build fixes

        * platform/KURL.cpp:
        (WebCore::appendEncodedHostname): Fix spelling (strLen, not strlen).
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl): Fix a ".." typo and call data instead of characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - added back accidentally-removed files
darin@apple.com [Fri, 15 Feb 2008 06:45:51 +0000 (06:45 +0000)]
    - added back accidentally-removed files

        * platform/DeprecatedStringList.cpp: Copied from platform/DeprecatedStringList.cpp.
        * platform/DeprecatedStringList.h: Copied from platform/DeprecatedStringList.h.
        * platform/mac/DeprecatedStringListMac.mm: Copied from platform/mac/DeprecatedStringListMac.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - more build fixes
darin@apple.com [Fri, 15 Feb 2008 06:38:49 +0000 (06:38 +0000)]
    - more build fixes

        * platform/KURL.cpp:
        (WebCore::appendEncodedHostname): Use String to make a QString.
        * platform/network/cf/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl): Updated to String rather than DeprecatedString functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake assign-to-window-status testcase to be more thorough
oliver@apple.com [Fri, 15 Feb 2008 06:03:11 +0000 (06:03 +0000)]
Make assign-to-window-status testcase to be more thorough

Reviewed by Jon H

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - next Qt build fix
darin@apple.com [Fri, 15 Feb 2008 05:36:58 +0000 (05:36 +0000)]
    - next Qt build fix

        * platform/network/qt/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - another build fix
darin@apple.com [Fri, 15 Feb 2008 05:29:13 +0000 (05:29 +0000)]
    - another build fix

        * platform/network/curl/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - first Qt build fix
darin@apple.com [Fri, 15 Feb 2008 05:14:14 +0000 (05:14 +0000)]
    - first Qt build fix

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::endElementNs): Added a missing string() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Fri, 15 Feb 2008 05:03:55 +0000 (05:03 +0000)]

        Reviewed by Eric Seidel.

        Based on work by Marvin Decker <marv.decker@gmail.com>

        - fix http://bugs.webkit.org/show_bug.cgi?id=16538
          KURL should use String instead of DeprecatedString

        - fix http://bugs.webkit.org/show_bug.cgi?id=16485
          DocLoader::checkForReload will crash if the URL isNull
          and a similar problem in IconDatabase

        - fix http://bugs.webkit.org/show_bug.cgi?id=16487
          KURL doesn't preserve isNull when constructed with a DeprecatedString

        - changed completeURL and various DOM getters to return KURL, to avoid
          conversion back and forth from KURL to String

        - changed the conversion of KURL to NSURL or NSString to be automatic,
          to ease the use of KURL in Objective C DOM bindings, and eliminated
          the getNSURL function

        - because I had to visit the DOM bindings anyway, eliminated almost all
          the use of the KJS namespace for things in WebCore

        - fixed HTMLOptionElement constructor to check for undefined rather
          than size of the arguments array

        - eliminated some other unnecessary uses of DeprecatedString

        - changed String::split to take a Vector parameter instead of returning
          a Vector, for better performance

        - added a couple of missing calls to do layout in SVG image handling;
          I was able to reproduce these only because I had broken URLs for a
          while -- not sure how to reproduce them now but the changes are
          clearly needed

        Performance testing shows this to be at least a 1% speedup.

        Added a new function protocolIs to efficiently compare protocols
        without case errors and a blankURL function so we don't have to
        code "about:blank" in multiple places in the code and don't have to
        construct a frash KURL each time. Moved decode_string and encode_string
        out of KURL and gave them clearer names.

        Made KURL constructors explicit to highlight potentially-expensive
        operations and the poor semantics of KURL's constructor that takes
        a String.

        * WebCore.base.exp: Updated.

        * bindings/js/JSAttrCustom.cpp:
        (WebCore::JSAttr::setValue): Use protocolIs.
        * bindings/js/JSAudioConstructor.h: KJS namespace change.
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS): Ditto.
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS): Ditto.
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location): Ditto.
        (WebCore::JSDocument::setLocation): Updated for KURL change.
        (WebCore::toJS): KJS namespace change.
        * bindings/js/JSElementCustom.cpp:
        (WebCore::allowSettingSrcToJavascriptURL): Use protocolIs.
        (WebCore::JSElement::setAttribute): KJS namespace change.
        (WebCore::JSElement::setAttributeNode): Ditto.
        (WebCore::JSElement::setAttributeNS): Ditto.
        (WebCore::JSElement::setAttributeNodeNS): Ditto.
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        (WebCore::allowSettingJavascriptURL): Use protocolIs.
        (WebCore::JSHTMLFrameElement::setSrc): KJS namespace change.
        (WebCore::JSHTMLFrameElement::setLocation): Ditto.
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        (WebCore::JSHTMLIFrameElement::setSrc): Use protocolIs.
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::JSHTMLOptionElementConstructor::construct): Cleaned up the
        structure a bit and changed checking to check for undefined rather than
        number of arguments.
        * bindings/js/JSHTMLOptionElementConstructor.h: KJS namespace change.
        * bindings/js/JSLocation.cpp:
        (WebCore::JSLocation::put): Eliminated some DeprecatedString use,
        and use protocolIs.
        (WebCore::jsLocationProtoFuncReplace): Ditto.
        (WebCore::jsLocationProtoFuncReload): Ditto.
        (WebCore::jsLocationProtoFuncAssign): Ditto.
        * bindings/js/JSLocation.h: KJS namespace change.
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMap::canGetItemsForName): Ditto.
        (WebCore::JSNamedNodeMap::nameGetter): Ditto.
        * bindings/js/JSNamedNodesCollection.cpp:
        (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Ditto.
        * bindings/js/JSNamedNodesCollection.h: Ditto.
        * bindings/js/JSXMLHttpRequest.cpp:
        (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Removed
        DeprecatedString use.
        (WebCore::jsXMLHttpRequestPrototypeFunctionSend): Ditto.
        * bindings/js/JSXMLHttpRequest.h: Moved this class into the WebCore
        * bindings/js/JSXSLTProcessor.cpp: Namespace change.
        * bindings/js/JSXSLTProcessor.h: Ditto.

        * bindings/js/kjs_binding.cpp: Updated for namespace change.
        (WebCore::jsStringOrNull): Added an overload for KURL to allow DOM
        classes to return KURL even if the DOM expects a string.
        (WebCore::jsStringOrUndefined): Ditto.
        (WebCore::jsStringOrFalse): Ditto.
        * bindings/js/kjs_binding.h: Moved everything into the WebCore

        * bindings/js/kjs_css.h: Namespace change.
        * bindings/js/kjs_events.cpp: Removed an include.
        * bindings/js/kjs_events.h: Namespace change.
        * bindings/js/kjs_html.h: Namespace change.

        * bindings/js/kjs_navigator.cpp: Moved everything into the
        WebCore namespace.
        * bindings/js/kjs_navigator.h: Ditto.

        * bindings/js/kjs_window.cpp:
        (KJS::parseModalDialogFeatures): Updated for String::split change.
        (KJS::createWindow): Use protocolIs and removed some DeprecatedString.
        (KJS::Window::put): Ditto.
        (KJS::Window::allowsAccessFrom): Ditto.
        (KJS::windowProtoFuncOpen): Ditto.

        * bindings/objc/DOM.mm:
        (-[DOMElement _getURLAttribute:]): Removed getNSURL call.
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.

        * bindings/scripts/CodeGeneratorCOM.pm: Updated includes so conversions from
        KURL will work.
        * bindings/scripts/CodeGeneratorJS.pm: Updated for namespace changes, and also
        updated includes so conversions from KURL will work.
        * bindings/scripts/CodeGeneratorObjC.pm: Updated includes so conversions from
        KURL will work.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeValue:]): Removed getNSURL call.
        Also streamlined the logic.
        (AXAttributedStringAppendText): Ditto.

        * bridge/mac/WebCoreScriptDebugger.mm:
        (toNSString): Tweaked.
        (toNSURL): Removed getNSURL call.

        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::image): Removed DeprecatedString use.
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent): Ditto.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Ditto.
        (WebCore::CSSParser::parseContent): Ditto.
        (WebCore::CSSParser::parseBackgroundImage): Ditto.
        (WebCore::CSSParser::parseFontFaceSrc): Ditto.
        (WebCore::CSSParser::parseBorderImage): Ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::setEncodedURL): Ditto.
        (WebCore::checkPseudoState): Ditto.
        * css/CSSStyleSelector.h: Ditto.

        * css/MediaList.cpp:
        (WebCore::MediaList::setMediaText): Updated for String::split change.

        * css/StyleBase.cpp:
        (WebCore::StyleBase::baseURL): Return KURL.
        * css/StyleBase.h: DItto.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Updated for namespace change.
        (WebCore::Document::documentURI): Return KURL.
        (WebCore::Document::setDocumentURI): Removed DeprecatedString use.
        (WebCore::Document::baseURI): Return KURL.
        (WebCore::Document::open): Updated to use blankURL.
        (WebCore::Document::setURL): Take KURL.
        (WebCore::Document::shouldBeAllowedToLoadLocalResources): Updated for
        change to use KURL
        (WebCore::Document::setBaseURL): Take KURL.
        (WebCore::Document::elementSheet): Updated for KURL change.
        (WebCore::Document::mappedElementSheet): Ditto.
        (WebCore::Document::processHttpEquiv): Ditto.
        (WebCore::Document::recalcStyleSelector): Removed use of
        DeprecatedString -- also noticed some dead code here!
        (WebCore::Document::setCookie): Ditto.
        (WebCore::Document::completeURL): Return KURL.
        * dom/Document.h: Use KURL instead of String in a few places.

        * dom/DocumentType.cpp:
        (WebCore::DocumentType::baseURI): Return KURL.
        * dom/DocumentType.h: Ditto.

        * dom/Element.cpp:
        (WebCore::Element::baseURI): Return KURL.
        * dom/Element.h: Ditto.

        * dom/Node.cpp:
        (WebCore::Node::setDocument): Namespace change.
        (WebCore::Node::baseURI): Return KURL.
        * dom/Node.h: Ditto.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet): Updated for KURL change.
        * dom/StyleElement.cpp:
        (WebCore::StyleElement::process): Changed to use Vector<UChar> instead of
        String for better performance.
        (WebCore::StyleElement::createSheet): Removed use of DeprecateString.
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::endElementNs): Updated for KURL change.
        (WebCore::XMLTokenizer::end): Ditto.
        (WebCore::xmlDocPtrForString): Removed use of DeprecateString.
        * dom/XMLTokenizer.h: Ditto.

        * editing/markup.cpp: Moved appendString to PlatformString.h.
        (WebCore::appendQuotedURLAttributeValue): Use protocolIs.
        (WebCore::completeURLs): Removed DeprecatedString use.
        (WebCore::createFragmentFromMarkup): Use blankURL.
        (WebCore::fillContainerFromString): Removed DeprecatedString use.
        (WebCore::createFragmentFromText): Ditto.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::url): Removed DeprecatedString use.
        (WebCore::HistoryItem::originalURL): Ditto.
        * history/HistoryItem.h: Removed include.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler): Removed use of
        (WebCore::HTMLAnchorElement::href): Return KURL.
        (WebCore::HTMLAnchorElement::hash): Removed DeprecatedString use.
        (WebCore::HTMLAnchorElement::host): Ditto.
        (WebCore::HTMLAnchorElement::hostname): Ditto.
        (WebCore::HTMLAnchorElement::pathname): Ditto.
        (WebCore::HTMLAnchorElement::port): Ditto.
        (WebCore::HTMLAnchorElement::protocol): Ditto.
        (WebCore::HTMLAnchorElement::search): Ditto.
        (WebCore::HTMLAnchorElement::toString): Ditto.
        * html/HTMLAnchorElement.h: Ditto.
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer): Updated for KURL change.
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::href): Return KURL.
        * html/HTMLAreaElement.h: Ditto.
        * html/HTMLBaseElement.cpp:
        (WebCore::HTMLBaseElement::removedFromDocument): Updated for KURL change.
        (WebCore::HTMLBaseElement::process): Removed DeprecatedString use.
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute): Updated for KURL change.
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed use of
        * html/HTMLEmbedElement.h: Removed DeprecatedString use.
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): Use protocolIs.
        (WebCore::encodeCString): Updated for change to String::split.
        (WebCore::HTMLFormElement::dataEncoding): Ditto.
        (WebCore::HTMLFormElement::formData): Removed DeprecatedString use.
        (WebCore::HTMLFormElement::isMailtoForm): Use protocolIs.
        (WebCore::HTMLFormElement::submit): Updated for KURL change.
        (WebCore::HTMLFormElement::reset): Ditto.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed): Updated for KURL change
        and use equalIgnoringRef instead of doing a setRef to get the same effect.
        (WebCore::HTMLFrameElementBase::openURL): Use blankURL.
        (WebCore::HTMLFrameElementBase::location): Return KURL.
        (WebCore::HTMLFrameElementBase::src): Return KURL.
        * html/HTMLFrameElementBase.h: Ditto.
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute): Updated for KURL change.
        (WebCore::HTMLImageElement::longDesc): Return KURL.
        (WebCore::HTMLImageElement::lowsrc): Return KURL.
        (WebCore::HTMLImageElement::src): Return KURL.
        * html/HTMLImageElement.h: Ditto. Also removed imageMap() function.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::src): Return KURL.
        * html/HTMLInputElement.h: Ditto.
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute): Updated for KURL change.
        (WebCore::HTMLLinkElement::tokenizeRelAttribute): Updated for String::split change.
        (WebCore::HTMLLinkElement::href): Return KURL.
        * html/HTMLLinkElement.h: Ditto.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::src): Return KURL.
        (WebCore::HTMLMediaElement::pickMedia): Updated for KURL change.
        * html/HTMLMediaElement.h: Ditto.
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::isImageType): Use protocolIs.
        (WebCore::HTMLObjectElement::data): Return KURL.
        * html/HTMLObjectElement.h: Ditto.
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::groupLabelText): Removed DeprecatedString use.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::reportErrorToConsole): Updated for KURL change.
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLScriptElement::text): Changed to use Vector<UChar> instead of
        String for better performance.
        (WebCore::HTMLScriptElement::src): Return KURL.
        * html/HTMLScriptElement.h: Ditto.
        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::src): Return KURL.
        * html/HTMLSourceElement.h: Ditto.
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::parseMappedAttribute): Updated for KURL change.
        * html/HTMLTablePartElement.cpp:
        (WebCore::HTMLTablePartElement::parseMappedAttribute): Updated for KURL change.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setValue): Removed DeprecatedString use.
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptExecution): Ditto.
        (WebCore::HTMLTokenizer::notifyFinished): Use protocolIs.
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::poster): Return KURL.
        * html/HTMLVideoElement.h: Ditto.
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addText): Updated for String::split change.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::checkForReload): Add an explicit check for an empty URL
        here to avoid problems using its string as a hash table key later.
        (WebCore::DocLoader::requestResource): Removed DeprecatedString use.

        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryTokenizer::createTDForFilename): Updated for KURL change.
        (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Removed use of

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestFrame): Use protocolIs.
        (WebCore::FrameLoader::loadSubframe): Use blankURL.
        (WebCore::FrameLoader::submitForm): Use protocolIs and removed use of
        (WebCore::FrameLoader::iconURL): Return KURL. Use protcolIs.
        (WebCore::FrameLoader::didOpenURL): Use protocolIs.
        (WebCore::FrameLoader::didExplicitOpen): Use blankURL.
        (WebCore::FrameLoader::executeIfJavaScriptURL): Use protocolIs.
        Update for name change to decodeURLEscapeSequences.
        (WebCore::FrameLoader::receivedFirstData): Updated for KURL changes.
        (WebCore::FrameLoader::begin): Removed DeprecatedString use.
        Renamed baseurl to baseURL. Updated to use KURL more.
        (WebCore::FrameLoader::gotoAnchor): Removed use of encodedHtmlRef
        function, which is no different from ref.
        (WebCore::FrameLoader::completeURL): Updated for KURL change.
        (WebCore::FrameLoader::scheduleLocationChange): Ditto.
        (WebCore::FrameLoader::canCachePage): Use protocolIs.
        (WebCore::FrameLoader::updatePolicyBaseURL): Update for KURL change.
        (WebCore::FrameLoader::setPolicyBaseURL): Take KURL.
        (WebCore::FrameLoader::startRedirectionTimer): Removed use of
        (WebCore::FrameLoader::load): Use protocolIs.
        (WebCore::FrameLoader::shouldHideReferrer): Use protocolIs.
        (WebCore::FrameLoader::shouldAllowNavigation): Updated for KURL change.
        (WebCore::FrameLoader::commitProvisionalLoad): Use blankURL.
        (WebCore::FrameLoader::open): Use protcolIs.
        (WebCore::FrameLoader::createHistoryItem): Use blankURL.
        (WebCore::FrameLoader::createJavaAppletWidget): Updated for KURL change.
        (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Removed
        DeprecatedString use.
        * loader/FrameLoader.h: Ditto.

        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::createDocumentStructure): Updated for KURL change.
        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::createDocumentStructure): Ditto.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::iconForPageURL): Added a check for an empty URL
        before trying to use it as a hash table key.

        * loader/icon/IconLoader.h: Tweaked includes.

        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests): Use protcolIs. Also removed some
        code to set up a local variable that is never used (and a DeprecatedString
        on to boot!).

        * loader/mac/LoaderNSURLExtras.m:
        (suggestedFilenameWithMIMEType): Removed unnecessary typecast.

        * page/ContextMenuController.cpp: Removed include.

        * page/mac/EventHandlerMac.mm:
        Use protocolIs.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge URLWithAttributeString:]): Removed getNSURL call.
        (-[WebCoreFrameBridge baseURL]): Ditto.

        * platform/KURL.cpp:
        (WebCore::isSchemeFirstChar): Fixed bug in handling of values >= 0x80.
        (WebCore::isSchemeChar): Ditto.
        (WebCore::isPathSegmentEndChar): Ditto.
        (WebCore::hexDigitValue): Changed parameter type to UChar.
        (WebCore::copyASCII): Added.
        (WebCore::findFirstOf): Added.
        (WebCore::KURL::protocolIs): Added.
        (WebCore::KURL::KURL): Tightened logic up quite a bit. Changed parameter
        types from DeprecatedString to String.
        (WebCore::KURL::init): Changed parameter type to String. Preserved the
        passed-in string even if the base is invalid. Cleaned up logic to determine
        if the originalString should be pased in to the parse function. Simplified
        by calling the new parse overload that takes String in many cases.
        (WebCore::KURL::lastPathComponent): Return String.
        (WebCore::KURL::protocol): Ditto.
        (WebCore::KURL::host): Ditto.
        (WebCore::KURL::port): Changed logic to use early return for clarity.
        (WebCore::KURL::pass): Return String.
        (WebCore::KURL::user): Ditto.
        (WebCore::KURL::ref): Ditto.
        (WebCore::assertProtocolIsGood): Added.
        (WebCore::KURL::protocolIs): Added.
        (WebCore::KURL::query): Return String.
        (WebCore::KURL::path): Ditto.
        (WebCore::KURL::setProtocol): Take String.
        (WebCore::KURL::setHost): Ditto.
        (WebCore::KURL::setPort): Use String.
        (WebCore::KURL::setHostAndPort): Take String.
        (WebCore::KURL::setUser): Ditto.
        (WebCore::KURL::setPass): Ditto.
        (WebCore::KURL::setRef): Ditto.
        (WebCore::KURL::setQuery): Ditto.
        (WebCore::KURL::setPath): Ditto.
        (WebCore::KURL::prettyURL): Return String. Use Vector<UChar> to build it.
        (WebCore::decodeURLEscapeSequences): Renamed from KURL::decode_string.
        Return String. Use Vector<UChar> to build it.
        (WebCore::KURL::isLocalFile): Use protocolIs.
        (WebCore::KURL::parse): Added an overload that takes a String to replace
        the use of DeprecatedString::ascii at various call sites. Updated for
        name change (urlString -> m_string).
        (WebCore::equalIgnoringRef): Wrote a new implementation that doesn't
        do any allocation.
        (WebCore::encodeWithURLEscapeSequences): Renamed from KURL::encode_string.
        Return String.
        (WebCore::appendEncodedHostname): Added. Replaces encodeHostname and
        avoids the need to allocate a string.
        (WebCore::findHostnamesInMailToURL): Update to use findFirstOf instead of
        regular expressions.
        (WebCore::findHostnameInHierarchicalURL): Ditto.
        (WebCore::encodeHostnames): Use protocolIs and the other helpers above.
        (WebCore::encodeRelativeString): Changed to put result into a CharBuffer.
        (WebCore::substituteBackslashes): Updated to use String.
        (WebCore::KURL::copyToBuffer): Added.
        (WebCore::protocolIs): Added.
        (WebCore::blankURL): Added.
        (WebCore::KURL::print): Updated.
        * platform/KURL.h: Added a number of comments. Reorganized the header a bit.
        Made the string constructors explicit. Changed to use String instead of
        DeprecatedString. Removed encodedHTMLRef. Renamed and added a few functions.

        * platform/cf/KURLCFNet.cpp:
        (WebCore::KURL::KURL): Streamlined the logic a bit.
        (WebCore::KURL::createCFURL): Changed to use copyToBuffer.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie): Removed getNSURL call.
        Use protocolIs.
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::declareAndWriteDragImage): Removed getNSURL call.
        * platform/mac/CookieJar.mm:
        (WebCore::cookies): Removed getNSURL call.
        (WebCore::setCookies): Removed getNSURL call.
        * platform/mac/KURLMac.mm:
        (WebCore::KURL::KURL): Streamlined the logic a bit.
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeURL): Removed getNSURL call.
        (WebCore::Pasteboard::writeImage): Ditto.
        * platform/mac/SSLKeyGeneratorMac.mm:
        (WebCore::signedPublicKeyAndChallengeString): Ditto.

        * platform/network/HTTPParsers.cpp:
        (WebCore::filenameFromHTTPContentDisposition): Updated for String::split.
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::portAllowed): Use protocolIs.

        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::operator CFErrorRef): Removed deprecatedString call.
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::headerCallback): Ditto.
        (WebCore::parseDataUrl): Use String instead of DeprecatedString.
        (WebCore::ResourceHandleManager::startJob): Updated for KURL changes.
        * platform/network/mac/ResourceErrorMac.mm:
        (WebCore::ResourceError::operator NSError*): Removed getNSURL call.
        * platform/network/mac/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest): Removed DeprecatedString use.
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Removed getNSURL call.
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::nsURLResponse): Removed getNSURL call.

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::writeURL): Removed deprecatedString call.

        * platform/text/CString.h:
        (WebCore::CStringBuffer::length): Fixed size_t/unsigned mismatch to make it
        possible to compile this on Windows with higher warning level

        * platform/text/PlatformString.h: Updated split to modify a result parameter
        rather than returning a Vector. Added charactersAreAllASCII and an append
        function that appends a String to a Vector<UChar>.
        * platform/text/String.cpp:
        (WebCore::String::split): Updated.

        * platform/win/BString.cpp:
        (WebCore::BString::BString): Added conversion from KURL.
        * platform/win/BString.h: Ditto.

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::markupToCF_HTML): Removed use of deprecatedString.
        * platform/win/ClipboardWin.cpp:
        (WebCore::filesystemPathFromUrlOrTitle): Ditto.
        (WebCore::createGlobalHDropContent): Ditto.
        (WebCore::ClipboardWin::setData): Ditto.
        (WebCore::ClipboardWin::writeRange): Ditto.
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeSelection): Ditto.
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream): Ditto.
        (WebCore::PluginStream::destroyStream): Ditto.
        * plugins/win/PluginViewWin.cpp:
        (WebCore::scriptStringIfJavaScriptURL): Ditto.
        (WebCore::PluginView::performRequest): Ditto.
        (WebCore::PluginView::PluginView): Ditto.

        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteImageURL): Removed DeprecatedString use.
        (WebCore::HitTestResult::absoluteLinkURL): Ditto.

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layOutAxis): Fixed comment wording.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced): Removed use of DeperecatedString,
        (WebCore::RenderImage::imageMap): Changed to call useMap instead of imageMap;
        both do the same thing, and the first is standard DOM.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addPDFURLRect): Rewrote and streamlined to remove
        DeprecatedString use.
        * rendering/RenderObject.h: Changed addPDFURLRect to take const IntRect&.

        * rendering/RenderPartObject.cpp:
        (WebCore::isURLAllowed): Updated for KURL change and use equalIgnoringRef
        instead of doing a setRef to get the same effect.
        (WebCore::RenderPartObject::updateWidget): Updated for KURL change.

        * rendering/RenderText.cpp:
        (WebCore::charactersAreAllASCII): Moved the guts to PlatformString.h.

        * rendering/SVGRenderSupport.cpp:
        (WebCore::renderSubtreeToImage): Added missing call to do layout. I ran
        into this while doing some layout tests while URL processing was broken.

        * rendering/SVGRenderTreeAsText.h: Removed include.

        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::updateFromElement): Removed DeprecatedString use.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::draw): Added missing call to do layout. I ran
        into this while doing some layout tests while URL processing was broken.
        (WebCore::SVGImage::dataChanged): Use a null URL rather than an arbitrary
        string for the document.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getResponseXML): Removed DeprecatedString use.
        (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): Ditto.
        (WebCore::XMLHttpRequest::open): Ditto.
        (WebCore::XMLHttpRequest::send):  Namespace change.
        (WebCore::XMLHttpRequest::dropProtection): Ditto.
        * xml/XMLHttpRequest.h: Removed DeprecatedString use.

        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::loadSheet): Removed DeprecatedString use.
        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::loadChildSheets): Ditto.
        (WebCore::XSLStyleSheet::loadChildSheet): Ditto.
        * xml/XSLStyleSheet.h: Ditto.
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc): Ditto.
        (WebCore::xsltStylesheetPointer): Ditto.
        (WebCore::xmlDocPtrFromNode): Ditto.


        * webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building.
        * webkit/webkitwebview.cpp: Ditto.


        Reviewed by Eric Seidel.

        - updated for WebCore KURL changes

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem URL]): Removed getNSURL call.
        * Misc/WebElementDictionary.mm:
        (-[WebElementDictionary _absoluteImageURL]): Ditto.
        (-[WebElementDictionary _absoluteLinkURL]): Ditto.
        * Misc/WebNSAttributedStringExtras.mm:
        (fileWrapperForElement): Ditto.
        (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
        * Misc/WebNSURLExtras.mm:
        (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
        for function name change.
        * WebCoreSupport/WebContextMenuClient.mm:
        (WebContextMenuClient::downloadURL): Removed getNSURL call.
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::createDragImageForLink): Ditto.
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
        (WebFrameLoaderClient::startDownload): Ditto.
        (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
        (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
        (WebFrameLoaderClient::cancelledError): Ditto.
        (WebFrameLoaderClient::blockedError): Ditto.
        (WebFrameLoaderClient::cannotShowURLError): Ditto.
        (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
        (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
        (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
        (WebFrameLoaderClient::willUseArchive): Ditto.
        (WebFrameLoaderClient::setTitle): Ditto.
        (WebFrameLoaderClient::actionDictionary): Ditto.
        (WebFrameLoaderClient::createFrame): Ditto.
        (WebFrameLoaderClient::objectContentType): Ditto.
        (WebFrameLoaderClient::createPlugin): Ditto.
        (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
        * WebView/WebDataSource.mm:
        (-[WebDataSource _URL]): Ditto.
        (-[WebDataSource _initWithDocumentLoader:]): Ditto.
        (-[WebDataSource unreachableURL]): Ditto.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.


        - updated for WebCore KURL changes

        * MarshallingHelpers.cpp:
        (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call.
        (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
        * WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
        * WebDataSource.cpp:
        (WebDataSource::unreachableURL): Ditto.
        * WebDownload.cpp:
        (WebDownload::init): Ditto.
        (WebDownload::initWithRequest): Ditto.
        * WebFrame.cpp:
        (WebFrame::loadData): Ditto.
        (WebFrame::loadURLIntoChild): Ditto.
        (WebFrame::objectContentType): Ditto.
        * WebResource.cpp:
        (WebResource::initWithData): Ditto.
        * WebURLResponse.cpp:
        (WebURLResponse::createInstance): Ditto.
        (WebURLResponse::initWithURL): Ditto.
        * WebView.cpp:
        (WebView::userAgentForURL): Ditto.
        (WebView::copyURL): Ditto.
        (WebView::notifyPreferencesChanged): Ditto.


        * WebView.cpp: Removed use of DeprecatedString to keep this compiling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix Windows build
darin@apple.com [Fri, 15 Feb 2008 04:32:01 +0000 (04:32 +0000)]
   - fix Windows build

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::setStatusText): Update parameter types to match declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - update this test further, so that it succeeds
darin@apple.com [Fri, 15 Feb 2008 04:30:11 +0000 (04:30 +0000)]
    - update this test further, so that it succeeds

        * fast/dom/assign-to-window-status-expected.txt: Updated.
        * fast/dom/assign-to-window-status.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5744728> Fix leaks of RegularExpression objects in Frame...
adachan@apple.com [Fri, 15 Feb 2008 02:17:28 +0000 (02:17 +0000)]
    <rdar://problem/5744728> Fix leaks of RegularExpression objects in Frame.cpp.

        Reviewed by Jon and Darin.

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-14 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Fri, 15 Feb 2008 02:03:55 +0000 (02:03 +0000)]
2008-02-14  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Geoff.

        Update order files.

        * WebKit.order:
        * WebCore.order:
        * JavaScriptCore.order:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5726608> REGRESSION (r29428): Assigning to window.status does not...
oliver@apple.com [Fri, 15 Feb 2008 02:00:13 +0000 (02:00 +0000)]
<rdar://problem/5726608> REGRESSION (r29428): Assigning to window.status does not update status bar

Reviewed by Geoff G and Weinig.

Revert the portions of r29428 responsible for breaking the ability to
set window.status

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca@apple.com [Fri, 15 Feb 2008 01:35:44 +0000 (01:35 +0000)]
    Reviewed by Darin.

        Crash in WebCore::DeprecatedString::operator= + 31 at news.google.com

        Use pointers in the cache map tables. Otherwise when we rehash,
        we will end up destroying Cache objects that node lists might point to.

        * dom/Node.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 15 Feb 2008 00:30:24 +0000 (00:30 +0000)]
2008-02-14  Alp Toker  <alp@atoker.com>

        Reviewed by Darin.

        XMLTokenizer installs global libxml2 callbacks that can break client applications

        Patch by Mark Rowe (with a few changes).

        The xmlRegisterInputCallbacks/xmlRegisterOutputCallbacks done at
        init are global so we need to make sure these callbacks only get used
        by XMLTokenizer and never by libxml2 calls in user applications.

        This patch modifies the match and open functions to only apply when we
        are certain the caller is XMLTokenizer by checking globalDocLoader and
        ensuring we're on the correct thread.

        Some possible issues remain. See the bug report for details.

        * dom/XMLTokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren@apple.com [Thu, 14 Feb 2008 23:29:51 +0000 (23:29 +0000)]

        Reviewed by Sam Weinig.

        Fixed <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
        Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)

        Don't reset the "activations" stack in JSGlobalObject::reset, since we
        might be executing a script during the call to reset, and the script
        needs to safely run to completion.

        Instead, initialize the "activations" stack when the global object is
        created, and subsequently rely on pushing and popping during normal
        execution to maintain the stack's state.

        * kjs/JSGlobalObject.cpp:


        Reviewed by Sam Weinig.

        Layout test for <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
        Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)

        * fast/dom/javascript-url-crash-function.html: Added.
        * fast/dom/javascript-url-crash-function-expected.txt: Added.
        * fast/dom/resources/javascript-url-crash-function-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
timothy@apple.com [Thu, 14 Feb 2008 21:00:00 +0000 (21:00 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5743768> A deadlock during storage layout tests

        Make sure not to hold the m_openDatabaseMapGuard mutex when calling
        Database::markAsDeletedAndClose(), since that can cause a deadlock
        during the synchronous DatabaseThread call it triggers.

        * storage/DatabaseTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann@webkit.org [Thu, 14 Feb 2008 19:45:18 +0000 (19:45 +0000)]
Reviewed by Oliver.
Add dynamic update tests for SVGEllipseElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Improve the efficiency of SecurityOriginHash
aroben@apple.com [Thu, 14 Feb 2008 16:34:28 +0000 (16:34 +0000)]
    Improve the efficiency of SecurityOriginHash

        Reviewed by Alexey.

        * platform/SecurityOriginHash.h:
        (WebCore::SecurityOriginHash::hash): Now takes a const
        RefPtr<SecurityOrigin>& to reduce ref-count churn.
        (WebCore::SecurityOriginHash::equal): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to...
ap@webkit.org [Thu, 14 Feb 2008 15:41:53 +0000 (15:41 +0000)]
    * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to
        the previous check-in, fixing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
ap@webkit.org [Thu, 14 Feb 2008 15:36:28 +0000 (15:36 +0000)]
    Reviewed by Adam Roben.

        Database example doesn't work (requires not-yet-released Safari)

        * mac/WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
        if it's too old.

        * win/WebChromeClient.cpp:
        (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
        if it's too old.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrect the e-mail address in the ChangeLog.
zecke@webkit.org [Thu, 14 Feb 2008 12:37:44 +0000 (12:37 +0000)]
Correct the e-mail address in the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Make the handling of the coreFrame consistent. We construct the coreFrame
zecke@webkit.org [Thu, 14 Feb 2008 12:27:16 +0000 (12:27 +0000)]
* Make the handling of the coreFrame consistent. We construct the coreFrame
  at the beginning and it will live until the end. Change the g_return_(val_)if
  to ASSERTs as having a 0 coreFrame can never happen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Make sure that the WebCore::Frame is living as long as the WebKitWebFrame
zecke@webkit.org [Thu, 14 Feb 2008 12:26:44 +0000 (12:26 +0000)]
* Make sure that the WebCore::Frame is living as long as the WebKitWebFrame
  wrapped around it. All current calls to WebCore::Frame from within the
  WebKitWebFrame are safe, even in the case where the WebCore::Frame is already
  detached from the WebCore::Page.
* For the mainFrame the WebKitWebView is holding the initial reference and
  will unref on destruction.
* For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the
  frame gets detached from the parent.
* Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore::Frame is RefCounted, do not manually delete it!
zecke@webkit.org [Thu, 14 Feb 2008 12:25:59 +0000 (12:25 +0000)]
WebCore::Frame is RefCounted, do not manually delete it!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Plug a leak
zecke@webkit.org [Thu, 14 Feb 2008 12:25:28 +0000 (12:25 +0000)]
* Plug a leak

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Update the Copyright Information
zecke@webkit.org [Thu, 14 Feb 2008 12:24:58 +0000 (12:24 +0000)]
* Update the Copyright Information

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Thu, 14 Feb 2008 05:14:32 +0000 (05:14 +0000)]

        Reviewed by Oliver Hunt.

        Fixes the editing/deleting/5729680.html failure.  It succeeds when run by itself
        but fails when run with other tests because FramePrivate's m_selectionGranularity
        isn't reset when a Frame receives a new document.  It was also uninitialized in
        the constructor.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
        * page/Frame.cpp:
        (WebCore::FramePrivate::FramePrivate): Ditto.


        Reviewed by Oliver Hunt.

        * platform/mac/editing/deleting/table-cells-expected.checksum: Fixed.  Before, a space was
        incorrectly removed by a delete (this isn't a smart delete).
        * platform/mac/editing/deleting/table-cells-expected.png:
        * platform/mac/editing/deleting/table-cells-expected.txt:
        * platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed.  Before a space
        was incorrectly added by paste (this isn't a smart paste).
        * platform/mac/editing/pasteboard/input-field-1-expected.png:
        * platform/mac/editing/pasteboard/input-field-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-13 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 14 Feb 2008 02:13:53 +0000 (02:13 +0000)]
2008-02-13  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://problem/5739282> Hangs after closing video trailer popup with
        VLC plugin

        VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window

        * plugins/PluginQuirkSet.h: Added new quirk
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::stop): Selectively call NPP_SetWindow.
        (WebCore::PluginView::determineQuirks): Set new quirk for VLC plug-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
sfalken@apple.com [Thu, 14 Feb 2008 00:15:30 +0000 (00:15 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning
sfalken@apple.com [Thu, 14 Feb 2008 00:07:07 +0000 (00:07 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Wed, 13 Feb 2008 23:51:30 +0000 (23:51 +0000)]
2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Fix non-SVG builds.

        * css/CSSCursorImageValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
mrowe@apple.com [Wed, 13 Feb 2008 22:58:37 +0000 (22:58 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Wed, 13 Feb 2008 22:00:09 +0000 (22:00 +0000)]

        Reviewed by Adam Roben.

        <rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

        * editing/Editor.cpp:
        (WebCore::Editor::deleteWithDirection): Fixed a typo.


        Reviewed by Adam Roben.

        <rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

        * editing/deleting/5729680-expected.txt: Added.
        * editing/deleting/5729680.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Adam.
zimmermann@webkit.org [Wed, 13 Feb 2008 21:56:23 +0000 (21:56 +0000)]
Reviewed by Adam.
Make svg/dynamic-updates/* tests deterministic. s/setTimeout('executTest()', 0)/executeTest/ -- as discussed with Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann@webkit.org [Wed, 13 Feb 2008 21:49:41 +0000 (21:49 +0000)]
Reviewed by Oliver.

Actually fix the manual-tests/svg-cursor-changes.svg testcase.
I only reran layout tests when fixing the last issues with the patch,
instead of trying the manual-test :( Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben@apple.com [Wed, 13 Feb 2008 21:31:35 +0000 (21:31 +0000)]
    Windows build fix

        * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWindows/GTK+ build fixes
aroben@apple.com [Wed, 13 Feb 2008 21:19:31 +0000 (21:19 +0000)]
Windows/GTK+ build fixes


        Windows build fix

        * css/CSSCursorImageValue.cpp: #include MathExtras.h to get roundf.


        Windows/GTK+ build fix

        * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
        get isnan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Darin & Eric.
zimmermann@webkit.org [Wed, 13 Feb 2008 20:41:47 +0000 (20:41 +0000)]
Reviewed by Darin & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation)
SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore.
SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from
CachedResourceClient itself, handling remote-image acquisation on its own.

RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image"
and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id).

SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself -
instead of storing the CachedImage in the CursorData class, as it's supposed to be.
Because of that several places in WebCore contain special SVG cursor handling - which
is unneeded.

Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId'
from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute
changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 13 Feb 2008 20:14:21 +0000 (20:14 +0000)]
2008-02-13  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Split out pure-cairo Font code to FontCairo.cpp.

        Part of the ongoing work to share code with the Win port.

        * GNUmakefile.am:
        * WebCore.pro:
        * platform/graphics/cairo/FontCairo.cpp: Added.
        * platform/graphics/gtk/FontGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase
adachan@apple.com [Wed, 13 Feb 2008 19:34:47 +0000 (19:34 +0000)]
    <rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase

        Reviewed by Darin.

        * WebIconDatabase.cpp:
        (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag,
        which already has a ref count of 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
beidson@apple.com [Wed, 13 Feb 2008 18:47:14 +0000 (18:47 +0000)]

        Reviewed by Darin Adler

        Add some much needed Database support to DRT

        * DumpRenderTree/LayoutTestController.cpp:
        (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
          databases are called
        (clearAllDatabasesCallback): Allow a test to delete all databases
        (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get

        * DumpRenderTree/LayoutTestController.h:

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::clearAllDatabases): Stubbed out
        (LayoutTestController::setDatabaseQuota): Ditto
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::clearAllDatabases): Stubbed out with error message
        (LayoutTestController::setDatabaseQuota): Ditto

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
          message with details about the event then return a 5mb quota like before


        Reviewed by Darin Adler

        Added layout tests to cover

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/quota-tracking-expected.txt: Added.
        * storage/quota-tracking.html: Added.
        * storage/success-callback-expected.txt: Added.
        * storage/success-callback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix issues with the paint origin when using wxGCDC, with computing the font platform...
kevino@webkit.org [Wed, 13 Feb 2008 17:49:28 +0000 (17:49 +0000)]
Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
aroben@apple.com [Wed, 13 Feb 2008 17:28:37 +0000 (17:28 +0000)]
2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>

Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase


        Fix Bug 17220: Illogical dependency between PluginView and


        Reviewed by Adam and Darin.

        Rename PluginDatabase::createPluginView to PluginView::create, to make
        the illogical dependency between the two, logical
        Make PluginDatabase::findPlugin a public method
        Update the includes in PluginView and PluginDatabase for the change

        * plugins/PluginDatabase.h:
        * plugins/PluginView.h:
        * plugins/win/PluginDatabaseWin.cpp:
        * plugins/win/PluginViewWin.cpp:


        Fix Bug 17220: Illogical dependency between PluginView and


        Reviewed by Adam and Darin.

        Update for the rename of PluginDatabase::createPluginView
        to PluginView::create

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWindows build fixes
aroben@apple.com [Wed, 13 Feb 2008 17:20:47 +0000 (17:20 +0000)]
Windows build fixes


        Build fix

        * platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.


        Windows build fix

        * Interfaces/WebKit.idl: Create the typelib version symbol ourselves.


        * win/tools/scripts/auto-version.sh: Removed a redundant symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 13 Feb 2008 16:29:00 +0000 (16:29 +0000)]
2008-02-13  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Fix very small, upside down, inside out text on GTK+/DirectFB.

        Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com>

        Test the result of gdk_screen_get_resolution() and use a default
        fallback in case of failure.

        Also remove an unhelpful runtime warning.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * platform/mac/svg/hixie/perf/001-expected.txt: Removed.
darin@apple.com [Wed, 13 Feb 2008 15:56:30 +0000 (15:56 +0000)]
    * platform/mac/svg/hixie/perf/001-expected.txt: Removed.
        * platform/mac/svg/hixie/perf/002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Not reviewed, build fix.
pewtermoose@webkit.org [Wed, 13 Feb 2008 15:29:11 +0000 (15:29 +0000)]
    Not reviewed, build fix.

        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix Wx build
darin@apple.com [Wed, 13 Feb 2008 14:25:29 +0000 (14:25 +0000)]
    - try to fix Wx build

        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::paintBuffer): Added.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::paintBuffer): Ditto.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::paintBuffer): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix Wx build
darin@apple.com [Wed, 13 Feb 2008 13:33:44 +0000 (13:33 +0000)]
    - try to fix Wx build

        * platform/wx/LocalizedStringsWx.cpp: Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Wed, 13 Feb 2008 13:26:40 +0000 (13:26 +0000)]

        - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

        * WebCore.base.exp: Rolled out change.
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Ditto. But keep the initialization of
        (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
        * page/Settings.h:
        (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.


        - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

        * Misc/WebKitVersionChecks.h: Removed the constant.

        * WebView/WebView.mm:
        (-[WebView _needsXcodeVisibilityQuirk]): Removed.
        (-[WebView _preferencesChangedNotification:]): Removed call to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Wed, 13 Feb 2008 12:51:41 +0000 (12:51 +0000)]
    Reviewed by Darin.

        <rdar://problem/5740042> Database termination issues

        Test: storage/close-during-stress-test.html

        * dom/Document.cpp:
        * dom/Document.h:
        Don't re-create the database thread if it has been already terminated.

        * storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid
        having a hanging reference.

        * storage/DatabaseThread.cpp:

        * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging.
        Transactions are deleted during GC, so it's usually not importatnt to know when it happens.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - check in results for these tests
darin@apple.com [Wed, 13 Feb 2008 12:33:24 +0000 (12:33 +0000)]
    - check in results for these tests

        No idea if these are right or not; just what was generated on my computer.
        If someone has a better version, feel free to replace these results with correct ones.

        * platform/mac/svg/hixie/perf/001-expected.txt: Added.
        * platform/mac/svg/hixie/perf/002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin@apple.com [Wed, 13 Feb 2008 12:27:46 +0000 (12:27 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17340
          WebCore/platform/Timer.cpp fails to build with gcc 4.3

        * platform/Timer.cpp: Add include of <limits.h> since this file uses UINT_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin@apple.com [Wed, 13 Feb 2008 12:10:00 +0000 (12:10 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=17339
          JavaScriptCore does not build with gcc 4.3

        * kjs/interpreter.cpp: Add include of <unistd.h>, since that's where
        getpid() comes from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com
oliver@apple.com [Wed, 13 Feb 2008 09:51:59 +0000 (09:51 +0000)]
<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com

Reviewed by Alexey P.

When converting numeric values to booleans we need to account for NaN

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoComment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818...
timothy@apple.com [Wed, 13 Feb 2008 06:32:27 +0000 (06:32 +0000)]
Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady Eidson.
timothy@apple.com [Wed, 13 Feb 2008 06:04:19 +0000 (06:04 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5652560> Can't delete database if the website that
        uses it has been opened in this session

        Close the Database on the database thread before deleting the file.
        Tested and works on Windows and Mac.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
        * storage/Database.cpp:
        (WebCore::Database::markAsDeletedAndClose): Unschedule any pending
        Database tasks, and start and imediate DatabaseCloseTask.
        (WebCore::Database::close): Close the SQLDatabase.
        * storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task.
        (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database.
        (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
        * storage/DatabaseTask.h: Add DatabaseCloseTask.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoEndeavour to fix qt and gtk builds
oliver@apple.com [Wed, 13 Feb 2008 04:22:25 +0000 (04:22 +0000)]
Endeavour to fix qt and gtk builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Clean up auto-version.sh a bit
aroben@apple.com [Wed, 13 Feb 2008 03:07:15 +0000 (03:07 +0000)]
     Clean up auto-version.sh a bit

         It now does quite a bit less file I/O and many fewer fork/exec pairs.
         It's also quite a bit easier to read.

         Reviewed by Steve.

         * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Use a precompiled header to build WebKit.
sfalken@apple.com [Wed, 13 Feb 2008 02:53:48 +0000 (02:53 +0000)]
    Use a precompiled header to build WebKit.

        Reviewed by Adam.

        * WebKit.vcproj/WebKit.vcproj:
        * WebKitPrefix.cpp: Added.
        * WebKitPrefix.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 17269: Deobfuscate CanvasRenderingContext2D.cpp
oliver@apple.com [Wed, 13 Feb 2008 02:11:55 +0000 (02:11 +0000)]
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler
beidson@apple.com [Wed, 13 Feb 2008 01:10:42 +0000 (01:10 +0000)]
    Reviewed by Darin Adler

        Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

        Layout tests will come shortly with a mess of DRT changes

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string
          as different paths of constructing a SecurityOrigin were causing different hashes for the "same"

        * storage/Database.cpp:
        (WebCore::Database::changeVersion): Pass in the successCallback
        (WebCore::Database::transaction): Ditto

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps
        (WebCore::SQLTransaction::performPendingCallback): Ditto
        (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise
          skip straight to cleanupAfterSuccessCallback()
        (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then
          schedule cleanupAfterSuccessCallback()
        (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction
        * storage/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Versioning script change.
sfalken@apple.com [Wed, 13 Feb 2008 00:18:33 +0000 (00:18 +0000)]
    Versioning script change.

        * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:39 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * bindings/scripts/CodeGeneratorCOM.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:27 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * Drosera/win/BaseDelegate.h:
        * Drosera/win/DebuggerClient.cpp:
        * Drosera/win/DebuggerDocumentPlatform.cpp:
        * Drosera/win/Drosera.cpp:
        * Drosera/win/ServerConnection.cpp:
        * Drosera/win/ServerConnection.h:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/EditingDelegate.h:
        * DumpRenderTree/win/EventSender.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.h:
        * DumpRenderTree/win/GCControllerWin.cpp:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/win/PolicyDelegate.h:
        * DumpRenderTree/win/ResourceLoadDelegate.h:
        * DumpRenderTree/win/UIDelegate.cpp:
        * DumpRenderTree/win/UIDelegate.h:
        * DumpRenderTree/win/WorkQueueItemWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:05 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * DOMCSSClasses.h:
        * DOMCoreClasses.h:
        * DOMEventsClasses.h:
        * DOMHTMLClasses.h:
        * DefaultDownloadDelegate.h:
        * DefaultPolicyDelegate.cpp:
        * DefaultPolicyDelegate.h:
        * GEN_DOMObject.h:
        * Interfaces/DOMCSS.idl:
        * Interfaces/DOMCore.idl:
        * Interfaces/DOMEvents.idl:
        * Interfaces/DOMExtensions.idl:
        * Interfaces/DOMHTML.idl:
        * Interfaces/DOMPrivate.idl:
        * Interfaces/DOMRange.idl:
        * Interfaces/DOMWindow.idl:
        * Interfaces/IGEN_DOMObject.idl:
        * Interfaces/IWebArchive.idl:
        * Interfaces/IWebBackForwardList.idl:
        * Interfaces/IWebBackForwardListPrivate.idl:
        * Interfaces/IWebCache.idl:
        * Interfaces/IWebDataSource.idl:
        * Interfaces/IWebDatabaseManager.idl:
        * Interfaces/IWebDocument.idl:
        * Interfaces/IWebDownload.idl:
        * Interfaces/IWebEditingDelegate.idl:
        * Interfaces/IWebError.idl:
        * Interfaces/IWebErrorPrivate.idl:
        * Interfaces/IWebFormDelegate.idl:
        * Interfaces/IWebFrame.idl:
        * Interfaces/IWebFrameLoadDelegate.idl:
        * Interfaces/IWebFrameLoadDelegatePrivate.idl:
        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/IWebFrameView.idl:
        * Interfaces/IWebHTMLRepresentation.idl:
        * Interfaces/IWebHTTPURLResponse.idl:
        * Interfaces/IWebHistory.idl:
        * Interfaces/IWebHistoryItem.idl:
        * Interfaces/IWebHistoryItemPrivate.idl:
        * Interfaces/IWebIconDatabase.idl:
        * Interfaces/IWebInspector.idl:
        * Interfaces/IWebJavaScriptCollector.idl:
        * Interfaces/IWebKitStatistics.idl:
        * Interfaces/IWebMutableURLRequest.idl:
        * Interfaces/IWebMutableURLRequestPrivate.idl:
        * Interfaces/IWebNotification.idl:
        * Interfaces/IWebNotificationCenter.idl:
        * Interfaces/IWebNotificationObserver.idl:
        * Interfaces/IWebPolicyDelegate.idl:
        * Interfaces/IWebPreferences.idl:
        * Interfaces/IWebPreferencesPrivate.idl:
        * Interfaces/IWebResource.idl:
        * Interfaces/IWebResourceLoadDelegate.idl:
        * Interfaces/IWebResourceLoadDelegatePrivate.idl:
        * Interfaces/IWebScriptCallFrame.idl:
        * Interfaces/IWebScriptDebugListener.idl:
        * Interfaces/IWebScriptDebugServer.idl:
        * Interfaces/IWebScriptObject.idl:
        * Interfaces/IWebScriptScope.idl:
        * Interfaces/IWebScrollBarDelegatePrivate.idl:
        * Interfaces/IWebScrollBarPrivate.idl:
        * Interfaces/IWebSecurityOrigin.idl:
        * Interfaces/IWebTextRenderer.idl:
        * Interfaces/IWebUIDelegate.idl:
        * Interfaces/IWebUIDelegatePrivate.idl:
        * Interfaces/IWebURLAuthenticationChallenge.idl:
        * Interfaces/IWebURLRequest.idl:
        * Interfaces/IWebURLResponse.idl:
        * Interfaces/IWebURLResponsePrivate.idl:
        * Interfaces/IWebUndoManager.idl:
        * Interfaces/IWebUndoTarget.idl:
        * Interfaces/IWebView.idl:
        * Interfaces/IWebViewPrivate.idl:
        * Interfaces/WebKit.idl:
        * WebActionPropertyBag.cpp:
        * WebBackForwardList.h:
        * WebCache.h:
        * WebDataSource.cpp:
        * WebDataSource.h:
        * WebDatabaseManager.h:
        * WebDownload.h:
        * WebEditorClient.cpp:
        * WebEditorClient.h:
        * WebError.h:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebFramePolicyListener.h:
        * WebHTMLRepresentation.cpp:
        * WebHTMLRepresentation.h:
        * WebHistory.cpp:
        * WebHistory.h:
        * WebHistoryItem.h:
        * WebIconDatabase.h:
        * WebInspector.h:
        * WebJavaScriptCollector.h:
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKitDLL.cpp:
        * WebKitStatistics.h:
        * WebMutableURLRequest.cpp:
        * WebMutableURLRequest.h:
        * WebNotification.h:
        * WebNotificationCenter.h:
        * WebPreferences.h:
        * WebResource.h:
        * WebScriptCallFrame.h:
        * WebScriptDebugServer.cpp:
        * WebScriptDebugServer.h:
        * WebScriptDebugger.cpp:
        * WebScriptDebugger.h:
        * WebScriptObject.h:
        * WebScrollBar.h:
        * WebSecurityOrigin.h:
        * WebTextRenderer.h:
        * WebURLAuthenticationChallenge.h:
        * WebURLAuthenticationChallengeSender.h:
        * WebURLCredential.h:
        * WebURLProtectionSpace.h:
        * WebURLResponse.h:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
mitz@apple.com [Tue, 12 Feb 2008 23:54:39 +0000 (23:54 +0000)]
    Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17041
          <rdar://problem/5709660> Eastern Asian fonts do not display without specific box in Control Panel

        Revised the system fallback font lookup logic to use MLang font linking
        again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
        for CJK characters, try linking based on a single code page at a time,
        starting with the user's default code page (if it is one of the CJK
        code pages) followed by the other CJK code pages in a prescribed order
        that matches what Firefox does.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK
        code pages, with the user's default code page first.
        (WebCore::currentFontContainsCharacter): Factored out of
        (WebCore::createMLangFont): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Tue, 12 Feb 2008 23:34:04 +0000 (23:34 +0000)]
    Reviewed by Adam.

        Implement imageTitle.

        * WebCoreLocalizedStrings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady Eidson.
weinig@apple.com [Tue, 12 Feb 2008 21:29:51 +0000 (21:29 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

        - Tweak the statements in isASCIISpace to account for the statistical distribution of
          usage in the PLT.

        .4% speedup on my machine.  Stephanie's machine shows this as .3% speedup.

        * wtf/ASCIICType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
mitz@apple.com [Tue, 12 Feb 2008 21:17:47 +0000 (21:17 +0000)]
    Rubber-stamped by Adam Roben.

        - make fast/css/css3-nth-child pass

        * fast/css/css3-nth-child.html: Removed spaces that were making the
        :nth-child selector fail to parse because of <rdar://problem/5733761>.
        * platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
        * platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-02-12 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Tue, 12 Feb 2008 21:04:50 +0000 (21:04 +0000)]
2008-02-12  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
        Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy Hatcher.
mitz@apple.com [Tue, 12 Feb 2008 20:13:46 +0000 (20:13 +0000)]
    Reviewed by Timothy Hatcher.

        - <rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds

        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Release build fix
beidson@apple.com [Tue, 12 Feb 2008 20:11:55 +0000 (20:11 +0000)]
    Release build fix

        * storage/DatabaseTask.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
ap@webkit.org [Tue, 12 Feb 2008 19:37:03 +0000 (19:37 +0000)]
    Reviewed by Brady.

        <rdar://problem/5729619> Storage tasks are getting lost

        <rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

        <rdar://problem/5729446> Major thread safety issue in Database code

        * platform/MessageQueue.h: Added a thread-safe queue abstraction.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Added MessageQueue.h.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.

        * storage/Database.idl: Fixed parameter declarations to actually match implementation
        (which is custom, so it got out of sync).

        * storage/DatabaseTask.h:
        Changed tasks to hold more information internally. Added helpers for better debug logging.

        * storage/DatabaseTask.cpp:
        Implementation for the above.

        Fixed a potential race condition: if the task completed before we entered a wait, we'd never
        wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

        * storage/DatabaseThread.cpp:
        * storage/DatabaseThread.h:
        Changed to use MessageQueue.

        * storage/Database.cpp:
        * storage/Database.h:
        Changed m_transactionQueue to a MessageQueue.
        Got rid of callback tracking - these can take care of themselves.
        Got rid of a DatabaseThread member, as the Document can be asked for it.
        Moved private static members and helpers out of the header.
        Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.

        * storage/SQLTransaction.h:
        * storage/SQLTransaction.cpp: Added a lot of debug logging.
        (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment,
        as it created a race condition. Everything seems to work better without it, although a real fix
        would be to get rid of this variable - it's evil shared data that isn't even protected in any way.

        * manual-tests/database-threading-stress-test-2.html: Added.
        * manual-tests/database-threading-stress-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows
aroben@apple.com [Tue, 12 Feb 2008 19:29:52 +0000 (19:29 +0000)]
 Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows


         Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows


         Reviewed by Mitz.

         Test: fast/loader/local-css-allowed-in-strict-mode.html

         * platform/network/cf/ResourceResponseCFNet.cpp:
         (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for
         .css files.


         Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
         on Windows


         Reviewed by Mitz.

         * fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
         * fast/loader/local-css-allowed-in-strict-mode.html: Added.
         * fast/loader/resources/stylesheet.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
andersca@apple.com [Tue, 12 Feb 2008 19:17:24 +0000 (19:17 +0000)]
    Build fix.

        * loader/ImageDocument.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30170 268f45cc-cd09-0410-ab3c-d52691b4dbfc