justing [Wed, 16 Aug 2006 21:17:47 +0000 (21:17 +0000)]
LayoutTests:
Reviewed by thatcher
Added:
* editing/pasteboard/interchange-newline-4-expected.checksum: Added.
* editing/pasteboard/interchange-newline-4-expected.png: Added.
* editing/pasteboard/interchange-newline-4-expected.txt: Added.
* editing/pasteboard/interchange-newline-4.html: Added.
* editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
* editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
* editing/deleting/paragraph-in-preserveNewline-expected.txt: Added.
* editing/deleting/paragraph-in-preserveNewline.html: Added.
Equivalent render trees, fixes, or bugs exposed (10427, 10428):
* editing/execCommand/insertHTML-expected.checksum:
* editing/execCommand/insertHTML-expected.png:
* editing/execCommand/insertHTML-expected.txt:
* editing/execCommand/insertHTML.html:
* editing/execCommand/insertHorizontalRule-expected.checksum:
* editing/execCommand/insertHorizontalRule-expected.png:
* editing/execCommand/insertHorizontalRule-expected.txt:
* editing/inserting/insert-
3786362-fix-expected.checksum:
* editing/inserting/insert-
3786362-fix-expected.png:
* editing/inserting/insert-
3786362-fix-expected.txt:
* editing/inserting/insert-
3786362-fix.html:
* editing/inserting/insert-
3907422-fix-expected.txt:
* editing/pasteboard/
3976872-expected.checksum:
* editing/pasteboard/
3976872-expected.png:
* editing/pasteboard/
3976872-expected.txt:
* editing/pasteboard/
4076267-3-expected.checksum:
* editing/pasteboard/
4076267-3-expected.png:
* editing/pasteboard/
4076267-3-expected.txt:
* editing/pasteboard/
4076267-3.html:
* editing/pasteboard/
4076267-expected.checksum:
* editing/pasteboard/
4076267-expected.png:
* editing/pasteboard/
4076267-expected.txt:
* editing/pasteboard/
4076267.html:
* editing/pasteboard/
4242293-1-expected.txt:
* editing/pasteboard/
4242293-expected.checksum:
* editing/pasteboard/
4242293-expected.png:
* editing/pasteboard/
4242293-expected.txt:
* editing/pasteboard/
4631972-expected.txt:
* editing/pasteboard/8145-1-expected.txt:
* editing/pasteboard/8145-3-expected.txt:
* editing/pasteboard/block-wrappers-necessary-expected.txt:
* editing/pasteboard/copy-paste-bidi-expected.txt:
* editing/pasteboard/display-block-on-spans-expected.checksum:
* editing/pasteboard/display-block-on-spans-expected.png:
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/interchange-newline-1-expected.txt:
* editing/pasteboard/merge-end-1-expected.checksum:
* editing/pasteboard/merge-end-1-expected.png:
* editing/pasteboard/merge-end-1-expected.txt:
* editing/pasteboard/merge-end-1.html:
* editing/pasteboard/merge-end-2-expected.checksum:
* editing/pasteboard/merge-end-2-expected.png:
* editing/pasteboard/merge-end-2-expected.txt:
* editing/pasteboard/merge-end-2.html:
* editing/pasteboard/merge-end-4-expected.txt:
* editing/pasteboard/merge-end-list-expected.txt:
* editing/pasteboard/merge-end-table-expected.checksum:
* editing/pasteboard/merge-end-table-expected.png:
* editing/pasteboard/merge-end-table-expected.txt:
* editing/pasteboard/nested-blocks-with-text-area-expected.txt:
* editing/pasteboard/nested-blocks-with-text-field-expected.txt:
* editing/pasteboard/paste-
4039777-fix-expected.checksum:
* editing/pasteboard/paste-
4039777-fix-expected.png:
* editing/pasteboard/paste-
4039777-fix-expected.txt:
* editing/pasteboard/paste-line-endings-002-expected.txt:
* editing/pasteboard/paste-line-endings-004-expected.txt:
* editing/pasteboard/paste-line-endings-007-expected.txt:
* editing/pasteboard/paste-line-endings-008-expected.txt:
* editing/pasteboard/paste-line-endings-009-expected.txt:
* editing/pasteboard/paste-match-style-002-expected.txt:
* editing/pasteboard/paste-pre-001-expected.txt:
* editing/pasteboard/paste-pre-002-expected.txt:
* editing/pasteboard/paste-table-001-expected.checksum:
* editing/pasteboard/paste-table-001-expected.png:
* editing/pasteboard/paste-table-001-expected.txt:
* editing/pasteboard/paste-table-003-expected.txt:
* editing/pasteboard/paste-text-001-expected.txt:
* editing/pasteboard/paste-text-003-expected.txt:
* editing/pasteboard/paste-text-007-expected.checksum:
* editing/pasteboard/paste-text-007-expected.png:
* editing/pasteboard/paste-text-007-expected.txt:
* editing/pasteboard/paste-text-008-expected.txt:
* editing/pasteboard/paste-text-009-expected.txt:
* editing/pasteboard/paste-text-010-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:
* editing/pasteboard/paste-text-012-expected.checksum:
* editing/pasteboard/paste-text-012-expected.png:
* editing/pasteboard/paste-text-012-expected.txt:
* editing/pasteboard/paste-text-012.html:
* editing/pasteboard/paste-text-013-expected.checksum:
* editing/pasteboard/paste-text-013-expected.png:
* editing/pasteboard/paste-text-013-expected.txt:
* editing/pasteboard/paste-text-015-expected.txt:
* editing/pasteboard/paste-text-017-expected.txt:
* editing/pasteboard/paste-text-019-expected.checksum:
* editing/pasteboard/paste-text-019-expected.png:
* editing/pasteboard/paste-text-019-expected.txt:
* editing/pasteboard/paste-text-019.html:
* editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
* editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* editing/pasteboard/pasting-object-expected.txt:
* editing/pasteboard/prevent-block-nesting-01-expected.txt:
* editing/pasteboard/quirks-mode-br-1-expected.txt:
* editing/pasteboard/smart-paste-001-expected.txt:
* editing/pasteboard/smart-paste-002-expected.txt:
* editing/pasteboard/smart-paste-003-expected.txt:
* editing/pasteboard/smart-paste-004-expected.txt:
* editing/pasteboard/smart-paste-005-expected.txt:
* editing/pasteboard/smart-paste-006-expected.txt:
* editing/pasteboard/smart-paste-007-expected.txt:
* editing/pasteboard/smart-paste-008-expected.txt:
* editing/pasteboard/undoable-fragment-removes-expected.checksum:
* editing/pasteboard/undoable-fragment-removes-expected.png:
* editing/pasteboard/undoable-fragment-removes-expected.txt:
* editing/pasteboard/undoable-fragment-removes.html:
* editing/style/smoosh-styles-001-expected.txt:
* editing/style/smoosh-styles-002-expected.txt:
WebCore:
Reviewed by thatcher
First part of fix for:
<rdar://problem/
4384589>
Mail hung on paste text
Fixes:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8592>
Extra line left after deleting whitespace:pre text
<rdar://problem/
4128080> Paste as HTML does not yield equivalent style
<rdar://problem/
4046469> Box styles on first element aren't copied/pasted
Copy/paste of arstechnica.com
Here's how we avoid adding redundant style information on paste: insert
the fragment and do a test rendering, save away style information for
every node in the fragment, remove all style information from the fragment,
remove the fragment, insert it into the appropriate place in the document,
then restore only those styles gathered during the test insertion that aren't
redundant. Restoring the styles in this way results in an ApplyStyleCommand
and a layout for nearly every inserted node.
Instead we want to insert the fragment into the document without removing the
style information, then mark style nodes and inline style declarations for
removal if they are redundant, and sweep to remove them. This means that we
can't rely on ReplacementFragment::wasBlock anymore, because blocks will now
have style spans around them. This patch removes the use of wasBlock in
ReplaceSelectionCommand.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Added code
to remove the line placeholder left after a move from preserveNewline text.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::doApply): Don't add a placeholder if
we're deleting a paragraph in preserveNewline text.
* editing/JSEditor.cpp: Pass true to prevent nesting.
* editing/ReplaceSelectionCommand.cpp: Removed wasBlock and friends.
(WebCore::ReplacementFragment::ReplacementFragment): Ditto.
(WebCore::ReplacementFragment::saveRenderingInfo): Ditto.
(WebCore::RenderingInfo::RenderingInfo): Ditto.
(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
(WebCore::ReplaceSelectionCommand::shouldMergeStart): Combined the to/from
merging rules into one method.
(WebCore::ReplaceSelectionCommand::shouldMergeEnd):
(WebCore::ReplaceSelectionCommand::shouldMerge):
(WebCore::ReplaceSelectionCommand::doApply):
Don't do nesting prevention when pasting into an empty paragraph, this
fixes
4046469, the common cause of paste fidelity bugs, but needs
to be tweaked a little because this can lead to margin/border build-up
on repeated copy/pastes.
Don't track startPos in addition to insertionPos. It was never used.
Fixed a bug where a fragment starting with an interchange newline would
cause content to be put outside of an editable region when pasting at the
very end of it.
Adjust insertionPos before insertion (not during) and do not consult wasBlock
to decide whether or not to do so.
Changed the way we do the start merge: insert the fragment, then stich
paragraphs together, in the same way that we do the end merge. This
doesn't require wasBlock and fixes bugs.
Replaced some uses of insertionPos with endOfInsertedContent.
Fixed a bug in the expansion of the last incoming br (a "collapsed" br
is one where !isStartOfParagraph([br,0])).
Removed the special case code that did the end merge for the preserveNewline
case, since this patch fixes the moveParagraph bug in the preserveNewline case.
Removed some unused variables.
(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): An endBR that was
holding a line open should always be displaced by inserted content, unless
the inserted content ends with a br.
(WebCore::ReplaceSelectionCommand::updateNodesInserted):
* editing/ReplaceSelectionCommand.h:
(WebCore::RenderingInfo::style):
* editing/markup.cpp:
(WebCore::createMarkup): Only add mail blockquotes and list/table/pre when
annotate is true (when we're creating markup for the pasteboard).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 16 Aug 2006 18:56:27 +0000 (18:56 +0000)]
Fix Win32 build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 16 Aug 2006 18:31:23 +0000 (18:31 +0000)]
Reviewed by Brady Eidson
- fixed <rdar://problem/
4637156> underlines appearing in white selection text
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintDecorations):
bail out if phase is PaintPhaseSelection and forceWhiteText is true
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 16 Aug 2006 18:03:52 +0000 (18:03 +0000)]
Reviewed by John
Updated the DB version number and added a helpful comment explaining its meaning
* loader/icon/IconDatabase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 16 Aug 2006 08:16:51 +0000 (08:16 +0000)]
Reviewed by Maciej
* Misc/WebIconDatabase.m: Pruned unused method
* Misc/WebIconDatabasePrivate.h: Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 16 Aug 2006 08:16:04 +0000 (08:16 +0000)]
Reviewed by Maciej
Major refactoring of new iconDB:
-Instead of private browsing being handled by in-memory tables, it's now handled
by a separate in-memory database with the same table names. This allows us to
re-use the same SQL on either the main or private-browsing database
-So it follows, I broke out much of the SQL queries into seperate methods suffixed with
"Query" that take a database as the method's argument so the same language can run on
both private and main tables
-Now that we have two DBs, moved the retain/release count to the m_mainDB
-While I was at it, updated the schema to combine the Icon and IconResource table - cuts
down on some high-usage, low value queries which were too expensive
-Ditched the _url -> url convention for escaping urls for SQL. Now its url and escapedURL
-Pruned tons of unused methods from previous revisions
* bridge/mac/WebCoreIconDatabaseBridge.h: Removed isIconExpiredForPageURL as it was never used
* bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase): Updated initializer list
(WebCore::IconDatabase::open): Sets up both databases
(WebCore::IconDatabase::close): Closes both databases
(WebCore::IconDatabase::isEmpty): Queries both databases for at least 1 record
(WebCore::IconDatabase::isValidDatabase): Reflect the updated schema
(WebCore::IconDatabase::clearDatabaseTables): Ditto - and takes DB as a parameter
(WebCore::IconDatabase::createDatabaseTables): Ditto
(WebCore::IconDatabase::imageDataForIconURL): style cleanup, and using a query-function
(WebCore::IconDatabase::setPrivateBrowsingEnabled): Resets private DB instead of private tables
(WebCore::IconDatabase::isIconExpiredForIconURL): Uses a query-function on each DB
(WebCore::IconDatabase::iconURLForPageURL): Uses a query-function on each DB
(WebCore::IconDatabase::retainIconForPageURL): Retain count DB changes
(WebCore::IconDatabase::releaseIconForPageURL): Ditto
(WebCore::IconDatabase::isIconURLRetained): Determine if it's time to prune a released icon yet
(WebCore::IconDatabase::forgetIconForIconURLFromDatabase): Alot simpler
(WebCore::IconDatabase::setIconDataForIconURL): Style cleanup
(WebCore::IconDatabase::setHaveNoIconForIconURL): Ditto
(WebCore::IconDatabase::setIconURLForPageURL): Ditto - and using a query-function
(WebCore::IconDatabase::establishIconIDForIconURL): Style cleanup
(WebCore::IconDatabase::pruneUnreferencedIcons): DB name change
(WebCore::IconDatabase::pruneUnretainedIcons): Ditto
(WebCore::IconDatabase::hasIconForIconURL): Simpler, using a query-function
(WebCore::IconDatabase::~IconDatabase):
(WebCore::pageURLTableIsEmptyQuery): Self-explanatory SQL query
(WebCore::imageDataForIconURLQuery): Self-explanatory SQL query
(WebCore::timeStampForIconURLQuery): Self-explanatory SQL query
(WebCore::iconURLForPageURLQuery): Self-explanatory SQL query
(WebCore::forgetPageURLQuery): Self-explanatory SQL query
(WebCore::setIconIDForPageURLQuery): Self-explanatory SQL query
(WebCore::getIconIDForIconURLQuery): Self-explanatory SQL query
(WebCore::addIconForIconURLQuery): Self-explanatory SQL query
(WebCore::hasIconForIconURLQuery): Self-explanatory SQL query
* loader/icon/IconDatabase.h: Some new/changed methods, pruned methods, and new comments
(WebCore::IconDatabase::isOpen): Changed our meaning of "isOpen" to reflect the 2 databases
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 16 Aug 2006 05:19:09 +0000 (05:19 +0000)]
2006-08-15 Steve Falkenburg <sfalken@apple.com>
Reviewed by mjs.
Build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* wtf/Assertions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 16 Aug 2006 04:22:22 +0000 (04:22 +0000)]
LayoutTests:
Reviewed by Darin.
- added a test to check keyboard events fired from the ObjC API:
http://bugzilla.opendarwin.org/show_bug.cgi?id=9736
* fast/events/objc-keyboard-event-creation-expected.txt: Added.
* fast/events/objc-keyboard-event-creation.html: Added.
WebCore:
Reviewed by Darin.
- added ObjC wrappers for the KeyboardEvent and WheelEvent initializers
http://bugzilla.opendarwin.org/show_bug.cgi?id=9736
* bindings/objc/DOMEvents.mm:
(-[DOMKeyboardEvent initKeyboardEvent::::::::::]):
* bindings/objc/DOMEventsNonstandard.mm:
(-[DOMWheelEvent initWheelEvent:::::::::::]):
* bindings/objc/DOMPrivate.h:
- added an initializer for the WheelEvent
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::initWheelEvent):
* dom/WheelEvent.h:
WebKitTools:
Reviewed by Darin.
- added a function to create a few DOMKeyboardEvents and dispatch
them to a specified HTML element
http://bugzilla.opendarwin.org/show_bug.cgi?id=9736
* DumpRenderTree/EventSendingController.m:
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController fireKeyboardEventsToElement:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 16 Aug 2006 03:53:29 +0000 (03:53 +0000)]
Reviewed and tweaked by Darin.
- added DumpRenderTree support so editing delegate can be made to refuse edits
to enable tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=10129
* DumpRenderTree/DumpRenderTree.m:
(+[LayoutTestController isSelectorExcludedFromWebScript:]): Add setAcceptsEditing:
to the list of methods.
(+[LayoutTestController webScriptNameForSelector:]): Use the name setAcceptsEditing,
without the colon, for the JavaScript name.
(-[LayoutTestController setAcceptsEditing:]): Added. Calls through to the editing
delegate.
(dumpRenderTree): Set the acceptsEditing flag to YES before each test.
* DumpRenderTree/EditingDelegate.h: Added an "acceptsEditing" flag and getter and
setter methods to the class.
* DumpRenderTree/EditingDelegate.m:
(-[EditingDelegate init]): Initialize acceptsEditing to YES.
(-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): Instead of always returning YES,
return the value of acceptsEditing.
(-[EditingDelegate webView:shouldEndEditingInDOMRange:]): Ditto.
(-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): Ditto.
(-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): Ditto.
(-[EditingDelegate webView:shouldDeleteDOMRange:]): Ditto.
(-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
Ditto.
(-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): Ditto.
(-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): Ditto.
(-[EditingDelegate setAcceptsEditing:]): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 16 Aug 2006 03:53:18 +0000 (03:53 +0000)]
Reviewed by Adele (preliminary version) and later by Kevin.
- remove most WebKit dependencies from WebMainResourceLoader.
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader cannotShowMIMETypeForURL:]):
(-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
(-[WebFrameLoader isHostedByObjectElement]):
(-[WebFrameLoader isLoadingMainFrame]):
(+[WebFrameLoader _canShowMIMEType:]):
(+[WebFrameLoader _representationExistsForURLScheme:]):
(+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
* Loader/WebMainResourceLoader.h:
* Loader/WebMainResourceLoader.m:
(-[WebMainResourceLoader interruptForPolicyChangeError]):
(-[WebMainResourceLoader willSendRequest:redirectResponse:]):
(isCaseInsensitiveEqual):
(shouldLoadAsEmptyDocument):
(-[WebMainResourceLoader continueAfterContentPolicy:response:]):
(-[WebMainResourceLoader didReceiveResponse:]):
(-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
(-[WebMainResourceLoader didFinishLoading]):
(-[WebMainResourceLoader loadWithRequestNow:]):
(-[WebMainResourceLoader loadWithRequest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Wed, 16 Aug 2006 01:24:40 +0000 (01:24 +0000)]
Reviewed by Kevin Decker.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
Fixed a subtle problem with the 64-bit debug build -- as written, this would LOG() on 64-bit and do nothing on
32-bit!
* Plugins/WebPluginDatabase.m:
(-[WebPluginDatabase _scanForNewPlugins]):
Use +[NSMutableSet set] here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 15 Aug 2006 23:51:04 +0000 (23:51 +0000)]
JavaScriptCore:
Reviewed by Tim H.
Build fix: DWARF and -gfull are incompatible with symbol separation.
* JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Reviewed by Tim H.
Build fix: DWARF and -gfull are incompatible with symbol separation.
* JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Tim H.
Build fix: DWARF and -gfull are incompatible with symbol separation.
* WebCore.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Darin Adler.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])
<rdar://problem/
4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)
* Plugins/WebPluginDatabase.h:
* Plugins/WebPluginDatabase.m:
(+[WebPluginDatabase installedPlugins]):
Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit.
(-[WebPluginDatabase plugins]):
'plugins' is now a dictionary.
(-[WebPluginDatabase close]):
Call new -_removePlugin: method.
(-[WebPluginDatabase refresh]):
Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins.
(-[WebPluginDatabase _plugInPaths]):
No changes; just moved in file.
(-[WebPluginDatabase _addPlugin:]):
New method. Refactored from -refresh. Adds a plug-in to the database.
(-[WebPluginDatabase _removePlugin:]):
New method. Refactored from -refresh. Remove a plug-in from the database.
(-[WebPluginDatabase _scanForNewPlugins]):
New method. Refactored from -refresh. Returns the list of plug-in packages on disk.
(-[WebPluginDatabase _applicationWillTerminate]):
New method. Called when the application terminates. Closes the plug-in database so that all plug-ins are
removed from the DB (and unloaded if necessary).
* Plugins/WebBasePluginPackage.h:
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage initWithPath:]):
Try to create the NSBundle first, so if the file is not a valid bundle we bail out early. This
avoids some stat()s and allocations during the plug-in refresh process.
(-[WebBasePluginPackage isLoaded]):
Removed.
(-[WebBasePluginPackage load]):
Base class for plug-in packages now always loads "successfully".
(-[WebBasePluginPackage dealloc]):
Removed this assertion. The base plug-in package class has no concept of
"unloading".
(-[WebBasePluginPackage finalize]):
ditto.
(-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
Moved code to unload plug-in package to WebNetscapePluginPackage. Not all plug-in
packages can be "unloaded".
* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
Combined old -unload and -unloadWithoutShutdown methods into this new one.
(-[WebNetscapePluginPackage initWithPath:]):
Call new unload method.
(-[WebNetscapePluginPackage load]):
ditto
(-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]):
ditto
(-[WebNetscapePluginPackage open]):
New method. Called when a plug-in instance starts running.
(-[WebNetscapePluginPackage close]):
New method. Called when a plug-in instance stops running. When all plug-in instances
close the plug-in package, and the plug-in package is removed from the database, the plug-in
is unloaded.
* Plugins/WebPluginPackage.m:
(-[WebPluginPackage initWithPath:]):
(-[WebPluginPackage load]):
Made this a bit more efficient by checking if the bundle is already loaded.
(-[WebBasePluginPackage unload]):
Removed.
(-[WebBasePluginPackage isLoaded]):
Removed.
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView start]):
Open the plug-in package so it remains loaded while this instance uses it.
(-[WebBaseNetscapePluginView stop]):
Close the plug-in package when the plug-in instance is stopped.
* Plugins/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
This check is not necessary. Netscape plug-in packages are never unloaded until all their instances have
been stopped, and a Netscape plug-in instance will stop its streams when it is stopped.
(-[WebBaseNetscapePluginStream _destroyStream]):
ditto
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
ditto
(-[WebBaseNetscapePluginStream _deliverData]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Tue, 15 Aug 2006 23:38:37 +0000 (23:38 +0000)]
Reviewed by Darin Adler.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])
<rdar://problem/
4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)
* Plugins/WebPluginDatabase.h:
* Plugins/WebPluginDatabase.m:
(+[WebPluginDatabase installedPlugins]):
Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit.
(-[WebPluginDatabase plugins]):
'plugins' is now a dictionary.
(-[WebPluginDatabase close]):
Call new -_removePlugin: method.
(-[WebPluginDatabase refresh]):
Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins.
(-[WebPluginDatabase _plugInPaths]):
No changes; just moved in file.
(-[WebPluginDatabase _addPlugin:]):
New method. Refactored from -refresh. Adds a plug-in to the database.
(-[WebPluginDatabase _removePlugin:]):
New method. Refactored from -refresh. Remove a plug-in from the database.
(-[WebPluginDatabase _scanForNewPlugins]):
New method. Refactored from -refresh. Returns the list of plug-in packages on disk.
(-[WebPluginDatabase _applicationWillTerminate]):
New method. Called when the application terminates. Closes the plug-in database so that all plug-ins are
removed from the DB (and unloaded if necessary).
* Plugins/WebBasePluginPackage.h:
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage initWithPath:]):
Try to create the NSBundle first, so if the file is not a valid bundle we bail out early. This
avoids some stat()s and allocations during the plug-in refresh process.
(-[WebBasePluginPackage isLoaded]):
Removed.
(-[WebBasePluginPackage load]):
Base class for plug-in packages now always loads "successfully".
(-[WebBasePluginPackage dealloc]):
Removed this assertion. The base plug-in package class has no concept of
"unloading".
(-[WebBasePluginPackage finalize]):
ditto.
(-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
Moved code to unload plug-in package to WebNetscapePluginPackage. Not all plug-in
packages can be "unloaded".
* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
Combined old -unload and -unloadWithoutShutdown methods into this new one.
(-[WebNetscapePluginPackage initWithPath:]):
Call new unload method.
(-[WebNetscapePluginPackage load]):
ditto
(-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]):
ditto
(-[WebNetscapePluginPackage open]):
New method. Called when a plug-in instance starts running.
(-[WebNetscapePluginPackage close]):
New method. Called when a plug-in instance stops running. When all plug-in instances
close the plug-in package, and the plug-in package is removed from the database, the plug-in
is unloaded.
* Plugins/WebPluginPackage.m:
(-[WebPluginPackage initWithPath:]):
(-[WebPluginPackage load]):
Made this a bit more efficient by checking if the bundle is already loaded.
(-[WebBasePluginPackage unload]):
Removed.
(-[WebBasePluginPackage isLoaded]):
Removed.
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView start]):
Open the plug-in package so it remains loaded while this instance uses it.
(-[WebBaseNetscapePluginView stop]):
Close the plug-in package when the plug-in instance is stopped.
* Plugins/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
This check is not necessary. Netscape plug-in packages are never unloaded until all their instances have
been stopped, and a Netscape plug-in instance will stop its streams when it is stopped.
(-[WebBaseNetscapePluginStream _destroyStream]):
ditto
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
ditto
(-[WebBaseNetscapePluginStream _deliverData]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 15 Aug 2006 23:31:46 +0000 (23:31 +0000)]
JavaScriptCore:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping
* JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping
* JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping
* WebCore.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 15 Aug 2006 22:51:04 +0000 (22:51 +0000)]
LayoutTests:
Layout test for <rdar://problem/
4661982> (crash in KHTMLParser::popBlock)
* fast/parser/remove-node-stack-expected.txt: Added.
* fast/parser/remove-node-stack.html: Added.
WebCore:
Reviewed by Darin.
- This patch reworks a previous fix for <rdar://problem/
3524912> repro
crash in KHTMLParser::parseToken, due to parser's current element being
destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix
leaks.
The previous solutions caused a ~2% performance regression on iBench HTML,
due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
for a total win of ~3% vs current TOT.
We can merge this fix to the branch to fix <rdar://problem/
4661982>
(crash in KHTMLParser::popBlock).
The solution here is:
(1) Don't let the parser ref document nodes -- that causes leaks.
(2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when
moving a node between stacks or to/from 'current', rather than deref'ing
and then ref'ing again, simply move the node, along with its refcount, to
its new location, and overwrite its old location.
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLParser.cpp:
(WebCore::HTMLStackElem::HTMLStackElem):
(WebCore::HTMLStackElem::derefNode):
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::setCurrent):
(WebCore::HTMLParser::insertNode):
(WebCore::HTMLParser::popNestedHeaderTag):
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
(WebCore::HTMLParser::reopenResidualStyleTags):
(WebCore::HTMLParser::pushBlock):
(WebCore::HTMLParser::popBlock):
(WebCore::HTMLParser::popOneBlockCommon):
(WebCore::HTMLParser::popOneBlock):
(WebCore::HTMLParser::moveOneBlockToStack):
* html/HTMLParser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 15 Aug 2006 22:38:14 +0000 (22:38 +0000)]
Add system fonts layout test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 15 Aug 2006 22:37:51 +0000 (22:37 +0000)]
Fix for bug 3303, support CSS2 system fonts. This patch adds a new API
to RenderTheme for obtaining a system font. In addition to supporting
the CSS2 values, extensions have been added for the 3 control sizes on
Mac. The UA stylesheet now uses -webkit-small-control and no longer hardcodes
Lucida Grande 11px. This means that controls in Safari should now respect
haxies that modify the default fonts on controls.
Reviewed by beth
Added fast/css/css2-system-fonts.html
* WebCore.xcodeproj/project.pbxproj:
* css/CSSValueKeywords.in:
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/html4.css:
* platform/FontDescription.h:
(WebCore::FontDescription::setBold):
* platform/win/TemporaryLinkStubs.cpp:
(RenderThemeWin::systemFont):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::calcMinMaxWidth):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::minimumMenuListSize):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::minimumMenuListSize):
* rendering/RenderThemeWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 15 Aug 2006 21:40:04 +0000 (21:40 +0000)]
LayoutTests:
Reviewed by Maciej.
Test for: <rdar://problem/
4680207> REGRESSION: select-all should fire onSelect event for text fields and textareas (9518)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9518
* fast/forms/onselect-selectall-expected.txt: Added.
* fast/forms/onselect-selectall.html: Added.
WebCore:
Reviewed by Maciej.
- Fix for <rdar://problem/
4680207> REGRESSION: select-all should fire onSelect event for text fields and textareas (9518)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9518
Test: fast/forms/onselect-selectall.html
* page/Frame.cpp: (WebCore::Frame::selectAll): Call notifyRendererOfSelectionChange with userTriggered = true so that onSelect will fire.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 15 Aug 2006 20:49:22 +0000 (20:49 +0000)]
2006-08-15 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
* platform/PlatformString.h:
* platform/String.cpp:
(WebCore::String::charactersWithNullTermination):
Add new function which calls StringImpl::charactersWithNullTermination.
* platform/StringImpl.cpp:
(WebCore::StringImpl::init):
(WebCore::StringImpl::append):
(WebCore::StringImpl::insert):
(WebCore::StringImpl::truncate):
(WebCore::StringImpl::remove):
Set m_hasTerminatingNullCharacter to false;
(WebCore::StringImpl::charactersWithNullTermination):
If the string already has a terminating null character, simply return it. Otherwise,
realloc to make room for one and set m_hasTerminatingNullCharacter to true;
* platform/StringImpl.h:
(WebCore::StringImpl::StringImpl):
Add m_hasTerminatingNullCharacter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 15 Aug 2006 20:16:37 +0000 (20:16 +0000)]
Reviewed by Adam.
- Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9926
REGRESSION: pop-up looks bad because <option> respects color but not background-color
* rendering/RenderPopupMenuMac.mm:
(WebCore::RenderPopupMenuMac::addGroupLabel): Removed code to set foreground color in NSMenu.
Added a FIXME that we need to handle both foreground and background color. (9846)
(WebCore::RenderPopupMenuMac::addOption): ditto.
* rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle):
For the aqua look, set the foreground color to black.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 15 Aug 2006 19:20:09 +0000 (19:20 +0000)]
Reviewed by Anders.
- remove WebKit dependencies from WebPlugInStreamLoader via a protocol veil of ignorance
* Loader/WebNetscapePlugInStreamLoader.h:
* Loader/WebNetscapePlugInStreamLoader.m:
(-[WebNetscapePlugInStreamLoader initWithDelegate:frameLoader:]):
* Loader/WebPlugInStreamLoaderDelegate.h: Added.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 15 Aug 2006 16:08:44 +0000 (16:08 +0000)]
JavaScriptCore:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration
* JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration
* JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration
* WebCore.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Tim H.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 15 Aug 2006 15:26:42 +0000 (15:26 +0000)]
Reviewed by Hyatt.
Tweaked and landed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10399
Bug 10399: RenderTextArea is unused
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Removed RenderTextArea source files.
* html/HTMLTextAreaElement.cpp: Removed include of RenderTextArea.h.
* html/HTMLTextAreaElement.h: Removed forward declaration of RenderTextArea.
* platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Updated a comment.
* platform/TextBox.h: Removed.
* platform/mac/TextBoxMac.mm: Removed.
* platform/mac/WebCoreTextArea.h: Removed.
* platform/mac/WebCoreTextArea.mm: Removed.
* rendering/RenderTextArea.cpp: Removed.
* rendering/RenderTextArea.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 15 Aug 2006 15:14:40 +0000 (15:14 +0000)]
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10314
WebUnarchivingState archivedResourceForURL: doesn't work
* WebView/WebUnarchivingState.m:
(-[WebUnarchivingState archivedResourceForURL:]):
Fixed to get objects from the archived resources dictionary using
the URL as a string instead of as the URL itself (as this is how
the data is put into the dictionary).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 15 Aug 2006 08:04:28 +0000 (08:04 +0000)]
Reviewed by THE OTHER Maciej...
Two small fixes -
1) Renamed retain/release methods to add PageUrl in - we're being consistent and clear in the WebCore API
2) Fixed a bug where a null SiteIcon reference would be added into the pageURLToSiteIcon map causing a
null dereference later
* bridge/mac/WebCoreIconDatabaseBridge.mm:
(-[WebCoreIconDatabaseBridge retainIconForURL:]): Changed IconDatabase method name
(-[WebCoreIconDatabaseBridge releaseIconForURL:]): ditto
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::retainIconForPageURL): Name change
(WebCore::IconDatabase::releaseIconForPageURL): ditto
(WebCore::IconDatabase::setIconURLForPageURL): Added the null site-icon check when changing a PageURL's iconURL
* loader/icon/IconDatabase.h: Some renames
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 15 Aug 2006 06:40:03 +0000 (06:40 +0000)]
2006-08-14 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
<mask>, <marker>, <pattern> inside <defs> do not work
http://bugzilla.opendarwin.org/show_bug.cgi?id=6548
* ksvg2/svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement): moved to .cpp file
(WebCore::SVGDefsElement::isValid): moved to .cpp file
(WebCore::SVGDefsElement::rendererIsNeeded): Added.
(WebCore::SVGDefsElement::createRenderer): Added.
* ksvg2/svg/SVGDefsElement.h:
* ksvg2/svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement): adjusted spacing
(WebCore::SVGGElement::parseMappedAttribute): adjusted spacing
(WebCore::SVGDummyElement::SVGDummyElement): adjusted spacing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 15 Aug 2006 06:37:25 +0000 (06:37 +0000)]
2006-08-15 Eric Seidel <eric@eseidel.com>
Reviewed by TimH.
* projects/svg/status.xml: updated to reflect current SVG status
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 15 Aug 2006 06:12:39 +0000 (06:12 +0000)]
2006-08-14 Eric Seidel <eric@eseidel.com>
Reviewed by darin and mjs.
Add better SVGLoad event support.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
There will still need to be additional support added for <link> and <script> elements.
Not all of the error -> loaded -> error transition cases work yet.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchGenericEvent):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
* html/HTMLImageLoader.h:
(WebCore::HTMLImageLoader::haveFiredLoadEvent):
(WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
* ksvg2/misc/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::SVGImageLoader):
(WebCore::SVGImageLoader::dispatchLoadEvent):
* ksvg2/misc/SVGImageLoader.h:
* ksvg2/svg/SVGAElement.cpp:
(WebCore::SVGAElement::parseMappedAttribute):
* ksvg2/svg/SVGAnimatedBoolean.h:
* ksvg2/svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::parseMappedAttribute):
(WebCore::SVGElement::haveLoadedRequiredResources):
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
(WebCore::SVGElement::closeRenderer):
* ksvg2/svg/SVGElement.h:
(WebCore::SVGElement::rendererIsNeeded):
(WebCore::svg_dynamic_cast):
* ksvg2/svg/SVGExternalResourcesRequired.h:
* ksvg2/svg/SVGImageElement.cpp:
(SVGImageElement::SVGImageElement):
(SVGImageElement::haveLoadedRequiredResources):
* ksvg2/svg/SVGImageElement.h:
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseMappedAttribute):
* ksvg2/svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::parseMappedAttribute):
(WebCore::SVGScriptElement::executeScript):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 15 Aug 2006 05:38:32 +0000 (05:38 +0000)]
Reviewed by Beth.
- remove many (but not all) WebKit dependencies from WebNetscapePlugInStreamLoader (it still
depends on WebNetscapePluginStream).
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
* Loader/WebNetscapePlugInStreamLoader.h:
* Loader/WebNetscapePlugInStreamLoader.m:
(-[WebNetscapePlugInStreamLoader initWithStream:frameLoader:]):
(-[WebNetscapePlugInStreamLoader releaseResources]):
(-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
* Plugins/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 15 Aug 2006 05:18:45 +0000 (05:18 +0000)]
Missing expected results for last test.
* http/tests/plugins/interrupted-get-url-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 15 Aug 2006 03:52:34 +0000 (03:52 +0000)]
LayoutTests:
Test case not reviewed but the patch was reviewed by Tim Omernick.
- test case for REGRESSION: crash when leaving youtube page while movie is still loading
http://bugzilla.opendarwin.org/show_bug.cgi?id=10398
* http/tests/plugins/interrupted-get-url.html: Added.
* http/tests/plugins/resources/interrupted-get-url-success.html: Added.
* http/tests/plugins/resources/slow-resource.pl: Added.
WebKit:
Reviewed by Tim Omernick.
- fixed REGRESSION: crash when leaving youtube page while movie is still loading
http://bugzilla.opendarwin.org/show_bug.cgi?id=10398
* Loader/WebNetscapePlugInStreamLoader.m:
(-[WebNetscapePlugInStreamLoader initWithStream:view:]): Set the frame loader for this stream.
(-[WebNetscapePlugInStreamLoader cancelWithError:]): Make sure to destroy the stream as well;
otherwise, when we try to clean up later, we won't have the right context.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 15 Aug 2006 00:59:42 +0000 (00:59 +0000)]
2006-08-14 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10393
Autogenerate NodeIterator and TreeWalker.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
Add new files.
* bindings/js/JSNodeIteratorCustom.cpp: Added.
(WebCore::JSNodeIterator::mark):
* bindings/js/JSTreeWalkerCustom.cpp: Added.
(WebCore::JSTreeWalker::mark):
* bindings/js/kjs_traversal.cpp:
* bindings/js/kjs_traversal.h:
Remove implementations of DOMNodeIterator and DOMTreeWalker.
* bindings/scripts/CodeGeneratorJS.pm:
Add "CustomMarkFunction" attribute for classes where mark() needs to be overridden.
* bindings/objc/DOM.mm:
(-[DOMNodeIterator detach]):
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::detach):
* dom/NodeIterator.h:
Get rid of exception in detach, it isn't used at all and this function can't throw an exception according to the spec.
* dom/NodeIterator.idl: Added.
* dom/TreeWalker.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 15 Aug 2006 00:03:44 +0000 (00:03 +0000)]
Reviewed by John
The changes are plentiful, but small, mostly to improve performance
1) Add a bool flag to SiteIcon to stop it from querying the database over and over
2) Added a pageURL->iconURL hashmap to cache database results, as an optimization
3) Fix a bug in setIconURLForPageURL code where the pageURL would still point to an old icon
4) Added isIconURLRetained() to optimize the retain count check
5) Prune old, unused code
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::imageDataForIconID): Removed unused code
(WebCore::IconDatabase::imageDataForIconURL): Removed unused code
(WebCore::IconDatabase::imageDataForPageURL): Removed unused code
(WebCore::IconDatabase::isIconExpiredForIconURL): Removed LOG msg
(WebCore::IconDatabase::isIconExpiredForPageURL): Removed LOG msg
(WebCore::IconDatabase::iconURLForPageURL): Added a hashmap cache to avoid common queries
(WebCore::IconDatabase::releaseIconForURL): Changed to is isRetained() instead of retainCount()
(WebCore::IconDatabase::isIconURLRetained): Added - we don't care about the actual retain count
for an icon so much as whether or not it is retained
(WebCore::IconDatabase::setIconURLForPageURL): If the new and old iconURLs are the same, skip the
SQLite code
* loader/icon/IconDatabase.h: Added new methods/variables
* loader/icon/SiteIcon.cpp:
(SiteIcon::SiteIcon): Added a flag so it only queries the database for icon data once
(SiteIcon::getImage): Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 14 Aug 2006 23:22:28 +0000 (23:22 +0000)]
Land a wording tweak to a comment I made.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 14 Aug 2006 21:43:58 +0000 (21:43 +0000)]
Fix for bug 10385, add more support for crappy pseudo-XML-in-HTML.
Reviewed by ggaren
Added fast/parser/bad-xml-slash.html
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 14 Aug 2006 20:48:08 +0000 (20:48 +0000)]
Fix for Radar bug
4478840, Safari should not reduce null events sent to
plug-ins in windows that are inactive but visible.
With this fix you can view videos in visible background windows on YouTube
(for example) and not see any drop in frame rate.
Reviewed by timo
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView restartNullEvents]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 14 Aug 2006 19:23:46 +0000 (19:23 +0000)]
LayoutTests:
Reviewed by John Sullivan.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10204
REGRESSION: title tag parsing problem breaks Travelocity and Google Analytics pages
* fast/parser/title-error-test-expected.checksum: Added.
* fast/parser/title-error-test-expected.png: Added.
* fast/parser/title-error-test-expected.txt: Added.
* fast/parser/title-error-test.html: Added.
WebCore:
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10204
REGRESSION: title tag parsing problem breaks Travelocity and Google Analytics pages
Test: fast/parser/title-error-test.html
* html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Fixed an error
handling case that was skipping until a </style> tag in code that was shared
between both <title> and <style>. Also rearranged the code a tiny bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 14 Aug 2006 19:14:20 +0000 (19:14 +0000)]
Reviewed by Hyatt.
- fixed some storage leaks
(part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10259)
* platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
Rearrange code so that "delete this" is called any time the function returns
false -- ownership was inconsistent before.
* rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
Call deleteLineBoxWrapper even when documentBeingDestroyed() is true, because
some of what it does has to be done during destruction. A little awkward since
I preserved the order of operations. Perhaps we could structure this better later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 14 Aug 2006 17:13:34 +0000 (17:13 +0000)]
Reviewed by John Sullivan and Geoff Garen.
<rdar://problem/
3854950> AX Seed: Blackboard Learning Systems - frame names need to be put in AXDescription AXAttribute
Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...
<rdar://problem/
4256882> Need automated testing support for accessibility APIs
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityDescription]):
For a web area, return the name of the owning frame or iframe.
(-[WebCoreAXObject accessibilityAttributeNames]):
Advertize NSAccessibilityDescriptionAttribute.
(-[WebCoreAXObject rendererForView:]):
Clean up some old naming.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 14 Aug 2006 16:32:34 +0000 (16:32 +0000)]
2006-08-11 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10353
XMLSerializer and DOMParser should have real implementations
Make real implementation files for DOMParser and XMLSerializer and wrap them
using our bindings generation.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMParser.cpp: Removed.
* bindings/js/JSDOMParser.h: Removed.
* bindings/js/JSXMLSerializer.cpp: Removed.
* bindings/js/JSXMLSerializer.h: Removed.
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
* bindings/js/kjs_window.h:
(KJS::Window::):
* page/DOMWindow.idl:
* xml/DOMParser.cpp: Added.
(WebCore::DOMParser::parseFromString):
* xml/DOMParser.h: Added.
* xml/DOMParser.idl: Added.
* xml/XMLSerializer.cpp: Added.
(WebCore::XMLSerializer::serializeToString):
* xml/XMLSerializer.h: Added.
* xml/XMLSerializer.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 14 Aug 2006 09:01:01 +0000 (09:01 +0000)]
WebCore:
Reviewed by Brady.
- removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
* WebCore.exp: export new functions
* platform/mac/WebCoreSystemInterface.h: Added CFReadStream related functions
* platform/mac/WebCoreSystemInterface.mm: ditto
WebKit:
Reviewed by Brady.
- removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
* Loader/WebFormDataStream.m:
(formCanRead):
(formEventCallback):
(webSetHTTPBody):
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 14 Aug 2006 07:20:52 +0000 (07:20 +0000)]
Rubber stamped by Brady.
- move WebFormDataStream from WebView to Loader
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFormDataStream.h: Removed.
* WebView/WebFormDataStream.m: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 14 Aug 2006 07:09:26 +0000 (07:09 +0000)]
Reviewed by Brady.
- remove WebKit dependencies from WebSubresourceLoader, except WebFormDataStream
(WebFormDataStream will be moved into the Loader directory soon)
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
* Loader/WebSubresourceLoader.m:
(isConditionalRequest):
(hasCaseInsensitivePrefix):
(isFileURLString):
(setHTTPReferrer):
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 14 Aug 2006 06:50:35 +0000 (06:50 +0000)]
Reviewed by Maciej
Relocated the WebIconLoaders
* Misc/WebIconLoader.h: Moved to Loader/
* Misc/WebIconLoader.m: Moved to Loader/
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 14 Aug 2006 06:46:45 +0000 (06:46 +0000)]
Fixed my inaccurately stated Changelog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 14 Aug 2006 06:45:34 +0000 (06:45 +0000)]
Reviewed by Beth.
- removed non-Loader WebKit dependencies from WebDataProtocol for
real (whoops) and fix some typos.
* Loader/WebDataProtocol.m:
(isCaseInsensitiveEqual): Added.
(+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls.
(-[WebDataProtocol startLoading]): ditto
* Loader/WebFrameLoader.m:
(isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual.
(-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 14 Aug 2006 06:44:37 +0000 (06:44 +0000)]
Reviewed by Maciej
The way of detecting a failed icon load before was to try and construct
an image from the icon and if that image construction failed, mark the icon
as missing.
A much more efficient way is to check for a 404 response. We'll still
check for invalid image data, but most servers will correctly return 404
on a missing icon.
* Misc/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]): Added check for 404 response
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 14 Aug 2006 03:22:34 +0000 (03:22 +0000)]
Reviewed by Darin.
- remove all non-Loader dependencies from WebLoader
As part of this I moved WebDataProtocol to the loader directory
and removed dependencies on the rest of WebKit from that too.
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader setDefersCallbacks:]):
(-[WebFrameLoader stopLoading]):
(-[WebFrameLoader cancelledErrorWithRequest:]):
(-[WebFrameLoader clearArchivedResources]):
(-[WebFrameLoader deliverArchivedResources]):
(-[WebFrameLoader deliverArchivedResourcesAfterDelay]):
(isCaseSensitiveEqual):
(-[WebFrameLoader _canUseResourceForRequest:]):
(-[WebFrameLoader _canUseResourceWithResponse:]):
(-[WebFrameLoader pendingArchivedResources]):
(-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
(-[WebFrameLoader archiveLoadPendingForLoader:]):
(-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
* Loader/WebLoader.h:
* Loader/WebLoader.m:
(-[NSURLProtocol releaseResources]):
(-[NSURLProtocol loadWithRequest:]):
(-[NSURLProtocol setDefersCallbacks:]):
(-[NSURLProtocol addData:allAtOnce:]):
(-[NSURLProtocol resourceData]):
(-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
(-[NSURLProtocol connection:didReceiveData:lengthReceived:]):
(-[NSURLProtocol cancelWithError:]):
(-[NSURLProtocol cancelledError]):
* Loader/WebMainResourceLoader.m:
(-[WebMainResourceLoader addData:allAtOnce:]):
(-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
* Loader/WebNetscapePlugInStreamLoader.m:
(-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
* Loader/WebSubresourceLoader.m:
(-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDataProtocol.h: Removed.
* WebView/WebDataProtocol.m: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 14 Aug 2006 03:06:14 +0000 (03:06 +0000)]
JavaScriptCore:
Reviewed (and tweaked a little) by Maciej.
- shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting
in a 1.2% speed improvement on JS iBench (and probably overall memory savings).
This was done by removing _scope and _internalValue data members
from JSObject and moving them only to the subclasses that actually
make use of them.
* kjs/object.cpp:
(KJS::JSObject::mark): No need to mark scope or internal value here.
* kjs/object.h:
(KJS::JSObject::JSObject): Don't initialize them.
* kjs/JSWrapperObject.cpp: Added. New base class for object types that
wrap primitive values (Number, String, Boolean, Date).
(KJS::JSWrapperObject::mark):
* kjs/JSWrapperObject.h: Added.
(KJS::JSWrapperObject::JSWrapperObject):
(KJS::JSWrapperObject::internalValue):
(KJS::JSWrapperObject::setInternalValue):
* kjs/array_object.cpp:
(ArrayPrototype::ArrayPrototype): Don't set useless internal value.
* kjs/bool_object.cpp:
(BooleanInstance::BooleanInstance): Inherit from JSWrapperObject.
(BooleanProtoFunc::callAsFunction): Fixed to account for fact that not all
JSObjects have an internal value.
(BooleanObjectImp::construct): ditto.
* kjs/bool_object.h:
* kjs/collector.cpp: Lowered cell size to 48.
(KJS::Collector::allocate): meaningless whitespace change
* kjs/date_object.cpp:
(KJS::DateInstance::DateInstance): Inherit from JSWrapperObject.
(KJS::DateProtoFunc::callAsFunction): adjusted for move of internalValue
(KJS::DateObjectImp::construct): ditto
* kjs/date_object.h:
* kjs/error_object.cpp:
(ErrorPrototype::ErrorPrototype): don't set internal value
* kjs/function.cpp: move _scope and related handling here
(KJS::FunctionImp::mark): mark scope
* kjs/function.h:
(KJS::FunctionImp::scope): moved here from JSObject
(KJS::FunctionImp::setScope): ditto
* kjs/number_object.cpp:
(NumberInstance::NumberInstance): inherit from JSWrapperObject
(NumberProtoFunc::callAsFunction): adjusted
(NumberObjectImp::construct): adjusted
* kjs/number_object.h: shring RegExp-related objects a little
* kjs/regexp_object.cpp:
(RegExpPrototype::RegExpPrototype): Adjust for size tweaks
(RegExpObjectImp::RegExpObjectImp): ditto
* kjs/regexp_object.h:
* kjs/string_object.cpp:
(StringInstance::StringInstance): inherit from JSWrapperObject
(StringProtoFunc::callAsFunction): adjusted
* kjs/string_object.h:
* JavaScriptCore.exp: Exported new methods as needed.
* JavaScriptCore.xcodeproj/project.pbxproj: Added new files to build.
WebCore:
Reviewed (and tweaked a little) by Maciej.
- shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting
in a 1.2% speed improvement on JS iBench (and probably overall memory savings).
The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.
* bindings/js/kjs_events.cpp:
(KJS::JSLazyEventListener::parseCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Sun, 13 Aug 2006 01:38:46 +0000 (01:38 +0000)]
Reviewed by Darin.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/
3052546> Plugins don't work with z-index (overlapping elements, etc.)
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a
generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that
have already been drawn and are not expected to be redrawn in the same update.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 12 Aug 2006 05:59:43 +0000 (05:59 +0000)]
2006-08-12 Eric Seidel <eric@eseidel.com>
Reviewed by hyatt and mjs.
Fix two missing null checks causing layout test crashes.
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
* kcanvas/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 12 Aug 2006 05:46:11 +0000 (05:46 +0000)]
LayoutTests:
Reviewed by NOBODY (layout test fix).
Additional layout test fixes from hyatt's "Eliminate RenderImageButton" change
in r15839. See also r15840 for more layout test fixes.
* tables/mozilla/bugs/bug19599-expected.txt: Changed RenderImageButton to RenderImage.
* tables/mozilla/bugs/bug24200-expected.txt: Ditto.
* tables/mozilla/bugs/bug4527-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 12 Aug 2006 04:07:25 +0000 (04:07 +0000)]
2006-08-11 Eric Seidel <eric@eseidel.com>
Reviewed by andersca.
The outermost <svg> element needs to clip itself
http://bugzilla.opendarwin.org/show_bug.cgi?id=5358
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
* kcanvas/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG
(WebCore::RenderSVGContainer::paint):
* kcanvas/device/KRenderingDevice.h:
* kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods
(WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
* ksvg2/svg/SVGPaint.cpp: spacing changes
(WebCore::SVGPaint::SVGPaint): spacing cleanup
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
* platform/GraphicsContext.h: Added concatCTM
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::concatCTM): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 12 Aug 2006 03:22:32 +0000 (03:22 +0000)]
WebCore:
Reviewed by Maciej
Renamed a method/parameter for clarity and consistency, as well as some style
cleanups and removing some ridiculously verbose log messages.
Also added an _isEmpty method to the database and bridge for WebKit's use.
Finally, added a central way for both WebKit and WebCore to get the icon database filename
* bridge/mac/WebCoreIconDatabaseBridge.h: Added _isEmpty and defaultDatabaseFilename
* bridge/mac/WebCoreIconDatabaseBridge.mm: Removed an unnecessary semicolon off most of these methods
(-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]):
(-[WebCoreIconDatabaseBridge closeSharedDatabase]):
(-[WebCoreIconDatabaseBridge isOpen]):
(-[WebCoreIconDatabaseBridge _isEmpty]): Added
(-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
(-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
(-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
(-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
(-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
(-[WebCoreIconDatabaseBridge retainIconForURL:]):
(-[WebCoreIconDatabaseBridge releaseIconForURL:]):
(-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
(-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
(-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
(-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
(-[WebCoreIconDatabaseBridge defaultDatabaseFilename]): Added
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultDatabaseFilename): Added
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::isEmpty): Added
(WebCore::IconDatabase::retainIconForURL): Removed log message
(WebCore::IconDatabase::releaseIconForURL): Removed log message
* loader/icon/IconDatabase.h:
WebKit:
Reviewed by John, Timo, Adele, and Darin
In addition to a few style/good-practice cleanups, this patch will convert the old icon database
format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
place). After the conversion, it will delete all traces of the old format to free the unneeded space
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]):
(-[WebIconDatabase _setIconURL:forURL:]): Changed the bridge's name for this method to be more clear
(-[WebIconDatabase _createFileDatabase]):
(-[WebIconDatabase _iconDataForIconURL:]): This grabs the raw data for use in the conversion function
(-[WebIconDatabase _convertToWebCoreFormat]): This does the actual conversion
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 11 Aug 2006 23:53:05 +0000 (23:53 +0000)]
Update layout tests for removal of RenderImageButton
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 11 Aug 2006 23:52:36 +0000 (23:52 +0000)]
Eliminate RenderImageButton.
Reviewed by darin
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject isImageButton]):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createRenderer):
* rendering/RenderImage.h:
(WebCore::RenderImage::isImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 11 Aug 2006 23:49:39 +0000 (23:49 +0000)]
LayoutTests:
Reviewed by Brady.
Test case for <rdar://problem/
4656274>
REGRESSION: option elements are selected when added regardless of "selected" property
* fast/forms/option-constructor-selected-expected.txt: Added.
* fast/forms/option-constructor-selected.html: Added.
WebCore:
Reviewed by Brady.
- Fix for <rdar://problem/
4656274>
REGRESSION: option elements are selected when added regardless of "selected" property
Test: fast/forms/option-constructor-selected.html
* html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption):
When adding an option element, check that the option element is selected before calling setSelectedIndex.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 11 Aug 2006 23:06:10 +0000 (23:06 +0000)]
Reviewed by John Sullivan.
Needed for <rdar://problem/
4678070>.
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView sendEvent:]):
Changed an assertion to an early return. It should be possible to send events, especially updateEvt (for image capturing
purposes), to off-screen plug-ins. It just doesn't work right now. See <rdar://problem/
4318269>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 11 Aug 2006 22:35:26 +0000 (22:35 +0000)]
Reviewed by Darin
- fixed <rdar://problem/
4522894> Would be nice if Safari shrank pages a little if necessary
to avoid printing an almost-empty page
* WebView/WebHTMLView.m:
(-[NSArray knowsPageRange:]):
If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled
out of ... the air), then we adjust the scale factor slightly and check whether this reduces
the page count and thus eliminates the orphan.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 11 Aug 2006 21:26:15 +0000 (21:26 +0000)]
Add layout test for link bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 11 Aug 2006 21:18:47 +0000 (21:18 +0000)]
Fix for bug 10349, make sure to call setChanged when an anchor changes
from not being a link to being a link (and vice versa).
Test is in fast/dynamic/link-href-change.html
Reviewed by darin
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::parseMappedAttribute):
* html/HTMLAnchorElement.h:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseMappedAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 11 Aug 2006 20:58:09 +0000 (20:58 +0000)]
Reviewed by Darin.
Revert an over-optimization step that messed up the HashSet lookup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 11 Aug 2006 17:46:45 +0000 (17:46 +0000)]
Removing unnecessary comment from patch for bug 10346
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 11 Aug 2006 17:15:16 +0000 (17:15 +0000)]
Fix for bug #10346, fixes regression in svg image layout
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 11 Aug 2006 00:28:46 +0000 (00:28 +0000)]
2006-08-10 Anders Carlsson <acarlsson@apple.com>
Rubber-stamped by Maciej.
Move xpath to xml.
* DerivedSources.make:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* xpath/XPathEvaluator.cpp: Removed.
* xpath/XPathEvaluator.h: Removed.
* xpath/XPathEvaluator.idl: Removed.
* xpath/XPathExpression.cpp: Removed.
* xpath/XPathExpression.h: Removed.
* xpath/XPathExpression.idl: Removed.
* xpath/XPathNSResolver.cpp: Removed.
* xpath/XPathNSResolver.h: Removed.
* xpath/XPathNSResolver.idl: Removed.
* xpath/XPathNamespace.cpp: Removed.
* xpath/XPathNamespace.h: Removed.
* xpath/XPathResult.cpp: Removed.
* xpath/XPathResult.h: Removed.
* xpath/XPathResult.idl: Removed.
* xpath/impl/XPathExpressionNode.cpp: Removed.
* xpath/impl/XPathExpressionNode.h: Removed.
* xpath/impl/XPathFunctions.cpp: Removed.
* xpath/impl/XPathFunctions.h: Removed.
* xpath/impl/XPathGrammar.y: Removed.
* xpath/impl/XPathParser.cpp: Removed.
* xpath/impl/XPathParser.h: Removed.
* xpath/impl/XPathPath.cpp: Removed.
* xpath/impl/XPathPath.h: Removed.
* xpath/impl/XPathPredicate.cpp: Removed.
* xpath/impl/XPathPredicate.h: Removed.
* xpath/impl/XPathStep.cpp: Removed.
* xpath/impl/XPathStep.h: Removed.
* xpath/impl/XPathUtil.cpp: Removed.
* xpath/impl/XPathUtil.h: Removed.
* xpath/impl/XPathValue.cpp: Removed.
* xpath/impl/XPathValue.h: Removed.
* xpath/impl/XPathVariableReference.cpp: Removed.
* xpath/impl/XPathVariableReference.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 10 Aug 2006 20:37:34 +0000 (20:37 +0000)]
Reviewed by John Sullivan.
<rdar://problem/
4600112> REGRESSION: VO no longer able to review text within an edit field on web pages
Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...
<rdar://problem/
4256882> Need automated testing support for accessibility APIs
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject value]):
Add handling for text input fields.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 10 Aug 2006 05:11:25 +0000 (05:11 +0000)]
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10247
REGRESSION: Unable to build webkit without SVG/XPATH
* bindings/js/kjs_binding.cpp:
(KJS::setDOMException):
* bindings/js/kjs_dom.cpp:
(KJS::toJS):
* bindings/js/kjs_html.cpp:
(KJS::HTMLElementFunction::callAsFunction):
* bindings/js/kjs_proxy.cpp:
* bindings/js/kjs_proxy.h:
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMInternal.mm:
(raiseDOMException):
* bindings/objc/DOMXPath.mm:
* bindings/objc/DOMXPathInternal.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/mac/WebCoreFrameBridge.mm:
(+[WebCoreFrameBridge supportedNonImageMIMETypes]):
* css/CSSGrammar.y:
* css/CSSStyleDeclaration.cpp:
(WebCore::propertyID):
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* css/cssparser.h:
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::loadDefaultStyle):
(WebCore::CSSStyleSelector::applyProperty):
* css/cssstyleselector.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::createElementNS):
(WebCore::Document::implicitClose):
(WebCore::Document::recalcStyleSelector):
(WebCore::Document::createEvent):
* dom/Document.h:
* dom/Document.idl:
* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
* dom/Node.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::insertErrorMessageBlock):
* html/HTMLEmbedElement.cpp:
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.cpp:
* html/HTMLObjectElement.h:
* kcanvas/KCanvasCreator.cpp:
* kcanvas/KCanvasCreator.h:
* kcanvas/KCanvasFilters.cpp:
* kcanvas/KCanvasFilters.h:
* kcanvas/KCanvasImage.h:
* kcanvas/KCanvasMatrix.cpp:
* kcanvas/KCanvasMatrix.h:
* kcanvas/KCanvasPath.cpp:
* kcanvas/KCanvasPath.h:
* kcanvas/KCanvasResourceListener.h:
* kcanvas/KCanvasResources.cpp:
* kcanvas/KCanvasResources.h:
* kcanvas/KCanvasTreeDebug.cpp:
* kcanvas/RenderForeignObject.cpp:
* kcanvas/RenderForeignObject.h:
* kcanvas/RenderPath.cpp:
* kcanvas/RenderPath.h:
* kcanvas/RenderSVGContainer.cpp:
* kcanvas/RenderSVGContainer.h:
* kcanvas/RenderSVGImage.cpp:
* kcanvas/RenderSVGImage.h:
* kcanvas/RenderSVGText.cpp:
* kcanvas/RenderSVGText.h:
* kcanvas/device/KRenderingDevice.cpp:
* kcanvas/device/KRenderingDevice.h:
* kcanvas/device/KRenderingFillPainter.cpp:
* kcanvas/device/KRenderingFillPainter.h:
* kcanvas/device/KRenderingPaintServer.h:
* kcanvas/device/KRenderingPaintServerGradient.cpp:
* kcanvas/device/KRenderingPaintServerGradient.h:
* kcanvas/device/KRenderingPaintServerPattern.cpp:
* kcanvas/device/KRenderingPaintServerPattern.h:
* kcanvas/device/KRenderingPaintServerSolid.cpp:
* kcanvas/device/KRenderingPaintServerSolid.h:
* kcanvas/device/KRenderingStrokePainter.cpp:
* kcanvas/device/KRenderingStrokePainter.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
* kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
* kcanvas/device/quartz/KCanvasPathQuartz.mm:
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
* kcanvas/device/quartz/QuartzSupport.h:
* kcanvas/device/quartz/QuartzSupport.mm:
* ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
* ksvg2/bindings/js/JSSVGElementWrapperFactory.h:
* ksvg2/css/SVGCSSParser.cpp:
* ksvg2/css/SVGCSSStyleSelector.cpp:
* ksvg2/css/SVGRenderStyle.cpp:
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/css/SVGRenderStyleDefs.cpp:
* ksvg2/css/SVGRenderStyleDefs.h:
* ksvg2/ecma/GlobalObject.cpp:
* ksvg2/ecma/GlobalObject.h:
* ksvg2/events/JSSVGLazyEventListener.cpp:
* ksvg2/events/JSSVGLazyEventListener.h:
* ksvg2/events/SVGZoomEvent.cpp:
* ksvg2/events/SVGZoomEvent.h:
* ksvg2/ksvg.h:
* ksvg2/misc/KCanvasRenderingStyle.cpp:
* ksvg2/misc/KCanvasRenderingStyle.h:
* ksvg2/misc/KSVGTimeScheduler.cpp:
* ksvg2/misc/KSVGTimeScheduler.h:
* ksvg2/misc/SVGDocumentExtensions.cpp:
* ksvg2/misc/SVGDocumentExtensions.h:
* ksvg2/misc/SVGImageLoader.cpp:
* ksvg2/misc/SVGImageLoader.h:
* ksvg2/svg/DOMList.h:
* ksvg2/svg/SVGAElement.cpp:
* ksvg2/svg/SVGAElement.h:
* ksvg2/svg/SVGAngle.cpp:
* ksvg2/svg/SVGAngle.h:
* ksvg2/svg/SVGAnimateColorElement.cpp:
* ksvg2/svg/SVGAnimateColorElement.h:
* ksvg2/svg/SVGAnimateElement.cpp:
* ksvg2/svg/SVGAnimateElement.h:
* ksvg2/svg/SVGAnimateTransformElement.cpp:
* ksvg2/svg/SVGAnimateTransformElement.h:
* ksvg2/svg/SVGAnimatedAngle.cpp:
* ksvg2/svg/SVGAnimatedAngle.h:
* ksvg2/svg/SVGAnimatedBoolean.cpp:
* ksvg2/svg/SVGAnimatedBoolean.h:
* ksvg2/svg/SVGAnimatedColor.cpp:
* ksvg2/svg/SVGAnimatedColor.h:
* ksvg2/svg/SVGAnimatedEnumeration.cpp:
* ksvg2/svg/SVGAnimatedEnumeration.h:
* ksvg2/svg/SVGAnimatedInteger.cpp:
* ksvg2/svg/SVGAnimatedInteger.h:
* ksvg2/svg/SVGAnimatedLength.cpp:
* ksvg2/svg/SVGAnimatedLength.h:
* ksvg2/svg/SVGAnimatedLengthList.cpp:
* ksvg2/svg/SVGAnimatedLengthList.h:
* ksvg2/svg/SVGAnimatedNumber.cpp:
* ksvg2/svg/SVGAnimatedNumber.h:
* ksvg2/svg/SVGAnimatedNumberList.cpp:
* ksvg2/svg/SVGAnimatedNumberList.h:
* ksvg2/svg/SVGAnimatedPathData.cpp:
* ksvg2/svg/SVGAnimatedPathData.h:
* ksvg2/svg/SVGAnimatedPoints.cpp:
* ksvg2/svg/SVGAnimatedPoints.h:
* ksvg2/svg/SVGAnimatedPreserveAspectRatio.cpp:
* ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
* ksvg2/svg/SVGAnimatedRect.cpp:
* ksvg2/svg/SVGAnimatedRect.h:
* ksvg2/svg/SVGAnimatedString.cpp:
* ksvg2/svg/SVGAnimatedString.h:
* ksvg2/svg/SVGAnimatedTemplate.h:
* ksvg2/svg/SVGAnimatedTransformList.cpp:
* ksvg2/svg/SVGAnimatedTransformList.h:
* ksvg2/svg/SVGAnimationElement.cpp:
* ksvg2/svg/SVGAnimationElement.h:
* ksvg2/svg/SVGCircleElement.cpp:
* ksvg2/svg/SVGCircleElement.h:
* ksvg2/svg/SVGClipPathElement.cpp:
* ksvg2/svg/SVGClipPathElement.h:
* ksvg2/svg/SVGColor.cpp:
* ksvg2/svg/SVGColor.h:
* ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
* ksvg2/svg/SVGComponentTransferFunctionElement.h:
* ksvg2/svg/SVGCursorElement.cpp:
* ksvg2/svg/SVGCursorElement.h:
* ksvg2/svg/SVGDOMImplementation.cpp:
* ksvg2/svg/SVGDOMImplementation.h:
* ksvg2/svg/SVGDefsElement.cpp:
* ksvg2/svg/SVGDefsElement.h:
* ksvg2/svg/SVGDescElement.cpp:
* ksvg2/svg/SVGDescElement.h:
* ksvg2/svg/SVGDocument.cpp:
* ksvg2/svg/SVGDocument.h:
* ksvg2/svg/SVGElement.cpp:
* ksvg2/svg/SVGElement.h:
* ksvg2/svg/SVGElementInstance.cpp:
* ksvg2/svg/SVGElementInstance.h:
* ksvg2/svg/SVGElementInstanceList.cpp:
* ksvg2/svg/SVGElementInstanceList.h:
* ksvg2/svg/SVGEllipseElement.cpp:
* ksvg2/svg/SVGEllipseElement.h:
* ksvg2/svg/SVGExternalResourcesRequired.cpp:
* ksvg2/svg/SVGExternalResourcesRequired.h:
* ksvg2/svg/SVGFEBlendElement.cpp:
* ksvg2/svg/SVGFEBlendElement.h:
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
* ksvg2/svg/SVGFEColorMatrixElement.h:
* ksvg2/svg/SVGFEComponentTransferElement.cpp:
* ksvg2/svg/SVGFEComponentTransferElement.h:
* ksvg2/svg/SVGFECompositeElement.cpp:
* ksvg2/svg/SVGFECompositeElement.h:
* ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
* ksvg2/svg/SVGFEDiffuseLightingElement.h:
* ksvg2/svg/SVGFEDisplacementMapElement.cpp:
* ksvg2/svg/SVGFEDisplacementMapElement.h:
* ksvg2/svg/SVGFEDistantLightElement.cpp:
* ksvg2/svg/SVGFEDistantLightElement.h:
* ksvg2/svg/SVGFEFloodElement.cpp:
* ksvg2/svg/SVGFEFloodElement.h:
* ksvg2/svg/SVGFEFuncAElement.cpp:
* ksvg2/svg/SVGFEFuncAElement.h:
* ksvg2/svg/SVGFEFuncBElement.cpp:
* ksvg2/svg/SVGFEFuncBElement.h:
* ksvg2/svg/SVGFEFuncGElement.cpp:
* ksvg2/svg/SVGFEFuncGElement.h:
* ksvg2/svg/SVGFEFuncRElement.cpp:
* ksvg2/svg/SVGFEFuncRElement.h:
* ksvg2/svg/SVGFEGaussianBlurElement.cpp:
* ksvg2/svg/SVGFEGaussianBlurElement.h:
* ksvg2/svg/SVGFEImageElement.cpp:
* ksvg2/svg/SVGFEImageElement.h:
* ksvg2/svg/SVGFELightElement.cpp:
* ksvg2/svg/SVGFELightElement.h:
* ksvg2/svg/SVGFEMergeElement.cpp:
* ksvg2/svg/SVGFEMergeElement.h:
* ksvg2/svg/SVGFEMergeNodeElement.cpp:
* ksvg2/svg/SVGFEMergeNodeElement.h:
* ksvg2/svg/SVGFEOffsetElement.cpp:
* ksvg2/svg/SVGFEOffsetElement.h:
* ksvg2/svg/SVGFEPointLightElement.cpp:
* ksvg2/svg/SVGFEPointLightElement.h:
* ksvg2/svg/SVGFESpecularLightingElement.cpp:
* ksvg2/svg/SVGFESpecularLightingElement.h:
* ksvg2/svg/SVGFESpotLightElement.cpp:
* ksvg2/svg/SVGFESpotLightElement.h:
* ksvg2/svg/SVGFETileElement.cpp:
* ksvg2/svg/SVGFETileElement.h:
* ksvg2/svg/SVGFETurbulenceElement.cpp:
* ksvg2/svg/SVGFETurbulenceElement.h:
* ksvg2/svg/SVGFilterElement.cpp:
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
* ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
* ksvg2/svg/SVGFitToViewBox.cpp:
* ksvg2/svg/SVGFitToViewBox.h:
* ksvg2/svg/SVGForeignObjectElement.cpp:
* ksvg2/svg/SVGForeignObjectElement.h:
* ksvg2/svg/SVGGElement.cpp:
* ksvg2/svg/SVGGElement.h:
* ksvg2/svg/SVGGradientElement.cpp:
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGHelper.cpp:
* ksvg2/svg/SVGHelper.h:
* ksvg2/svg/SVGImageElement.cpp:
* ksvg2/svg/SVGImageElement.h:
* ksvg2/svg/SVGLangSpace.cpp:
* ksvg2/svg/SVGLangSpace.h:
* ksvg2/svg/SVGLength.cpp:
* ksvg2/svg/SVGLength.h:
* ksvg2/svg/SVGLengthList.cpp:
* ksvg2/svg/SVGLengthList.h:
* ksvg2/svg/SVGLineElement.cpp:
* ksvg2/svg/SVGLineElement.h:
* ksvg2/svg/SVGLinearGradientElement.cpp:
* ksvg2/svg/SVGLinearGradientElement.h:
* ksvg2/svg/SVGList.h:
* ksvg2/svg/SVGLocatable.cpp:
* ksvg2/svg/SVGLocatable.h:
* ksvg2/svg/SVGMarkerElement.cpp:
* ksvg2/svg/SVGMarkerElement.h:
* ksvg2/svg/SVGMaskElement.cpp:
* ksvg2/svg/SVGMaskElement.h:
* ksvg2/svg/SVGMatrix.cpp:
* ksvg2/svg/SVGMatrix.h:
* ksvg2/svg/SVGNumber.cpp:
* ksvg2/svg/SVGNumber.h:
* ksvg2/svg/SVGNumberList.cpp:
* ksvg2/svg/SVGNumberList.h:
* ksvg2/svg/SVGPaint.cpp:
* ksvg2/svg/SVGPaint.h:
* ksvg2/svg/SVGPathElement.cpp:
* ksvg2/svg/SVGPathElement.h:
* ksvg2/svg/SVGPathSeg.cpp:
* ksvg2/svg/SVGPathSeg.h:
* ksvg2/svg/SVGPathSegArc.cpp:
* ksvg2/svg/SVGPathSegArc.h:
* ksvg2/svg/SVGPathSegClosePath.cpp:
* ksvg2/svg/SVGPathSegClosePath.h:
* ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
* ksvg2/svg/SVGPathSegCurvetoCubic.h:
* ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
* ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
* ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
* ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
* ksvg2/svg/SVGPathSegLineto.cpp:
* ksvg2/svg/SVGPathSegLineto.h:
* ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
* ksvg2/svg/SVGPathSegLinetoHorizontal.h:
* ksvg2/svg/SVGPathSegLinetoVertical.cpp:
* ksvg2/svg/SVGPathSegLinetoVertical.h:
* ksvg2/svg/SVGPathSegList.cpp:
* ksvg2/svg/SVGPathSegList.h:
* ksvg2/svg/SVGPathSegMoveto.cpp:
* ksvg2/svg/SVGPathSegMoveto.h:
* ksvg2/svg/SVGPatternElement.cpp:
* ksvg2/svg/SVGPatternElement.h:
* ksvg2/svg/SVGPoint.cpp:
* ksvg2/svg/SVGPoint.h:
* ksvg2/svg/SVGPointList.cpp:
* ksvg2/svg/SVGPointList.h:
* ksvg2/svg/SVGPolyElement.cpp:
* ksvg2/svg/SVGPolyElement.h:
* ksvg2/svg/SVGPolygonElement.cpp:
* ksvg2/svg/SVGPolygonElement.h:
* ksvg2/svg/SVGPolylineElement.cpp:
* ksvg2/svg/SVGPolylineElement.h:
* ksvg2/svg/SVGPreserveAspectRatio.cpp:
* ksvg2/svg/SVGPreserveAspectRatio.h:
* ksvg2/svg/SVGRadialGradientElement.cpp:
* ksvg2/svg/SVGRadialGradientElement.h:
* ksvg2/svg/SVGRect.cpp:
* ksvg2/svg/SVGRect.h:
* ksvg2/svg/SVGRectElement.cpp:
* ksvg2/svg/SVGRectElement.h:
* ksvg2/svg/SVGSVGElement.cpp:
* ksvg2/svg/SVGSVGElement.h:
* ksvg2/svg/SVGScriptElement.cpp:
* ksvg2/svg/SVGScriptElement.h:
* ksvg2/svg/SVGSetElement.cpp:
* ksvg2/svg/SVGSetElement.h:
* ksvg2/svg/SVGStopElement.cpp:
* ksvg2/svg/SVGStopElement.h:
* ksvg2/svg/SVGStringList.cpp:
* ksvg2/svg/SVGStringList.h:
* ksvg2/svg/SVGStylable.cpp:
* ksvg2/svg/SVGStylable.h:
* ksvg2/svg/SVGStyleElement.cpp:
* ksvg2/svg/SVGStyleElement.h:
* ksvg2/svg/SVGStyledElement.cpp:
* ksvg2/svg/SVGStyledElement.h:
* ksvg2/svg/SVGStyledLocatableElement.cpp:
* ksvg2/svg/SVGStyledLocatableElement.h:
* ksvg2/svg/SVGStyledTransformableElement.cpp:
* ksvg2/svg/SVGStyledTransformableElement.h:
* ksvg2/svg/SVGSwitchElement.cpp:
* ksvg2/svg/SVGSwitchElement.h:
* ksvg2/svg/SVGSymbolElement.cpp:
* ksvg2/svg/SVGSymbolElement.h:
* ksvg2/svg/SVGTRefElement.cpp:
* ksvg2/svg/SVGTRefElement.h:
* ksvg2/svg/SVGTSpanElement.cpp:
* ksvg2/svg/SVGTSpanElement.h:
* ksvg2/svg/SVGTests.cpp:
* ksvg2/svg/SVGTests.h:
* ksvg2/svg/SVGTextContentElement.cpp:
* ksvg2/svg/SVGTextContentElement.h:
* ksvg2/svg/SVGTextElement.cpp:
* ksvg2/svg/SVGTextElement.h:
* ksvg2/svg/SVGTextPositioningElement.cpp:
* ksvg2/svg/SVGTextPositioningElement.h:
* ksvg2/svg/SVGTitleElement.cpp:
* ksvg2/svg/SVGTitleElement.h:
* ksvg2/svg/SVGTransform.cpp:
* ksvg2/svg/SVGTransform.h:
* ksvg2/svg/SVGTransformList.cpp:
* ksvg2/svg/SVGTransformList.h:
* ksvg2/svg/SVGTransformable.cpp:
* ksvg2/svg/SVGTransformable.h:
* ksvg2/svg/SVGURIReference.cpp:
* ksvg2/svg/SVGURIReference.h:
* ksvg2/svg/SVGUseElement.cpp:
* ksvg2/svg/SVGUseElement.h:
* ksvg2/svg/SVGViewElement.cpp:
* ksvg2/svg/SVGViewElement.h:
* ksvg2/svg/SVGZoomAndPan.cpp:
* ksvg2/svg/SVGZoomAndPan.h:
* ksvg2/svg/svgpathparser.cpp:
* ksvg2/svg/svgpathparser.h:
* page/DOMWindow.idl:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::begin):
(WebCore::Frame::pauseTimeouts):
(WebCore::Frame::resumeTimeouts):
* platform/GraphicsContext.h:
* platform/cg/GraphicsContextCG.cpp:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isTransparent):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
* rendering/RenderObject.h:
* rendering/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::inheritFrom):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::inheritedNotEqual):
(WebCore::RenderStyle::diff):
* rendering/RenderStyle.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::externalRepresentation):
* xpath/XPathEvaluator.cpp:
* xpath/XPathEvaluator.h:
* xpath/XPathExpression.cpp:
* xpath/XPathExpression.h:
* xpath/XPathNSResolver.cpp:
* xpath/XPathNSResolver.h:
* xpath/XPathNamespace.cpp:
* xpath/XPathNamespace.h:
* xpath/XPathResult.cpp:
* xpath/XPathResult.h:
* xpath/impl/XPathExpressionNode.cpp:
* xpath/impl/XPathExpressionNode.h:
* xpath/impl/XPathFunctions.cpp:
* xpath/impl/XPathFunctions.h:
* xpath/impl/XPathGrammar.y:
* xpath/impl/XPathParser.cpp:
* xpath/impl/XPathParser.h:
* xpath/impl/XPathPath.cpp:
* xpath/impl/XPathPath.h:
* xpath/impl/XPathPredicate.cpp:
* xpath/impl/XPathPredicate.h:
* xpath/impl/XPathStep.cpp:
* xpath/impl/XPathStep.h:
* xpath/impl/XPathUtil.cpp:
* xpath/impl/XPathUtil.h:
* xpath/impl/XPathValue.cpp:
* xpath/impl/XPathValue.h:
* xpath/impl/XPathVariableReference.cpp:
* xpath/impl/XPathVariableReference.h:
Change all #if SVG_SUPPORT to #ifdef SVG_SUPPORT and
#if XPATH_SUPPORT to #ifdef XPATH_SUPPORT
(except for one #if !SVG_SUPPORT to a #ifndef SVG_SUPPORT
in RenderTreeAsText.cpp)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Tue, 8 Aug 2006 19:28:37 +0000 (19:28 +0000)]
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10230
SVGDOMImplementation should die (and be rolled into DOMImplementation)
Delete SVGDOMImplementation and references to it. The
svg specific functionality is now in DOMImplementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 8 Aug 2006 07:28:51 +0000 (07:28 +0000)]
WebCore:
Reviewed by Anders and John
Icons can now refresh when new data is sent from WebKit, both on disk and in memory
* bridge/mac/WebCoreIconDatabaseBridge.h:
* bridge/mac/WebCoreIconDatabaseBridge.mm:
(WebCore::IconDatabase::loadIconFromURL): Allows WebCore/Kit to kick off a load
outside of any greater context
(-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
(-[WebCoreIconDatabaseBridge isIconExpiredForPageURL:]): Allows WebKit
to get whether or not an icon has expired
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::recreateDatabase): Changed database schema slightly
(WebCore::IconDatabase::createPrivateTables): Changed database schema slightly
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::isIconExpiredForIconURL): Get if an icon has expired
(WebCore::IconDatabase::isIconExpiredForPageURL): Get if an icon has expired
(WebCore::IconDatabase::setIconDataForIconURL): Force a refresh of the in memory
image when new icon data is loaded
(WebCore::IconDatabase::setIconURLForPageURL): added a check for null iconID
* loader/icon/IconDatabase.h: added/changed some methods
* loader/icon/SiteIcon.cpp:
(SiteIcon::getImage): simplified/removed debugging code
(SiteIcon::manuallySetImageData): allow the image data to be changed when new icon
data is loaded
WebKit:
Reviewed by Anders and John
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]):
(-[WebIconDatabase isIconExpiredForIconURL:]): Get if an icon expired
(-[WebIconDatabase isIconExpiredForPageURL:]): Ditto
(-[WebIconDatabase _setIconURL:forURL:]):
(-[WebIconDatabase _sendNotificationForURL:]): Moved to WebKitPendingPublic for use outside of WebIconDatabase
(-[WebIconDatabase loadIconFromURL:]): Allow a load outside the context of a page load
* Misc/WebIconDatabasePrivate.h:
* Misc/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]): fixed up the "flipping the switch" #defs a bit
(-[WebIconLoader willSendRequest:redirectResponse:]): override to allow a load
outside of the context of a page load
* WebCoreSupport/WebIconDatabaseBridge.h: Added.
* WebCoreSupport/WebIconDatabaseBridge.m: Added.
(-[WebIconDatabaseBridge init]):
(-[WebIconDatabaseBridge dealloc]):
(-[WebIconDatabaseBridge loadIconFromURL:]): Kick off a load on an icon outside
of the context of any page load
(-[WebIconDatabaseBridge _setIconData:forIconURL:]): WebKit side of bridge method
(-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]): WebKit side of bridge method
(-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]):
(+[WebIconDatabaseBridge sharedBridgeInstance]): Moved this from WebCore to WebKit
so both sides of the bridge get the WebKit version
* WebKit.xcodeproj/project.pbxproj: Added some files
* WebView/WebDataSource.m:
(-[WebDataSource _loadIcon]): Added check for reload/expired icon to force
a load even if we already have it
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 7 Aug 2006 06:10:29 +0000 (06:10 +0000)]
Fixing the build for the newer Bison and our new use of -Wundef. Turns off -Wundef for WebKit because <CoreGraphics/CGBase.h> causes a warning we can't fix. We can turn it back on once this radar is fixed: <rdar://problem/
4669823> CGBase.h fails to build with -Wundef enabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 5 Aug 2006 23:53:03 +0000 (23:53 +0000)]
Reviewed by Eric Seidel.
- fix a storage leak
* rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
Delete the values if we are going to exit without using the maps.
Otherwise all the values leak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 5 Aug 2006 20:14:47 +0000 (20:14 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10213
REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>
* fast/frames/iframe-option-crash-expected.checksum: Added.
* fast/frames/iframe-option-crash-expected.png: Added.
* fast/frames/iframe-option-crash-expected.txt: Added.
* fast/frames/iframe-option-crash.xhtml: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10213
REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>
Test: fast/frames/iframe-option-crash.xhtml
* rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
Check for a nil renderer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 23:27:12 +0000 (23:27 +0000)]
Fix for Radar bug #
4644045, regression where dragging selection no longer
works for floats contained inside layers. I added an optimization to
refine dirty rect checking for layers, and it incorrectly excluded floats
from the paint bounds since PaintPhaseSelection was not considered when
analyzing the floatRect().
Reviewed by beth
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 23:19:34 +0000 (23:19 +0000)]
Fix remove() so that it is equivalent to calling removeChild on the
parent. This involved moving three operations that remove did.
(1) Move the accessibility object cache removal into the destroy methods,
since this really should just happen when a render object is going away.
(2) removeFromObjectLists shifted into removeChild, which means it will
now be called more often (this is a correct change). Note that there is
also now a new guard on removeFromObjectLists so that it won't do any
work unless the document is not being destroyed.
(3) The big one. deleteLineBoxWrapper was not getting called to clean up
the line box tree. This moved right into RenderContainer's removeChildNode so
that it is now done even in the lowest level RenderContainer removal primitive.
Reviewed by beth
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::removeChildNode):
(WebCore::RenderContainer::removeChild):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::removeFromObjectLists):
(WebCore::RenderObject::destroy):
* rendering/RenderObject.h:
(WebCore::RenderObject::remove):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 4 Aug 2006 21:12:32 +0000 (21:12 +0000)]
Reviewed by Geoff's rubber stamp
Fix a build break on Intel hardware causes by adapting stricter
compiler warnings (-Wshorten-64-to-32)
* API/testapi.c:
(assertEqualsAsNumber): manually cast some doubles to floats
(main): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 21:04:35 +0000 (21:04 +0000)]
Add layout test for list marker crash
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 21:04:11 +0000 (21:04 +0000)]
Back out the fix for list marker crashes. The actual bug here is that
there is a confusing mismatch between remove() and removeChild() in the
render tree. remove() does a little bit of extra work that removeChild
should be doing instead (so that remove() can just be a shorthand for
removeChild).
This conservative fix does not solve the remove/removeChild mismatch
but instead just changes the list marker updating code to use remove
instead.
Reviewed by beth
Test Case: fast/lists/dynamic-marker-crash.html
* rendering/ListMarkerBox.cpp:
* rendering/ListMarkerBox.h:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 4 Aug 2006 18:57:40 +0000 (18:57 +0000)]
JavaScriptCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
Make WebCore (and friends) compile with -Wshorten-64-to-32
* Adds -Wshorten-64-to-32 flag to Xcode project.
* Adds explicit casts where OK.
* API/JSNodeList.c:
(JSNodeList_item):
(JSNodeList_getProperty):
* JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
Make WebCore (and friends) compile with -Wshorten-64-to-32
* Adds -Wshorten-64-to-32 flag to Xcode project.
* JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
Make WebCore (and friends) compile with -Wshorten-64-to-32
* Adds -Wshorten-64-to-32 flag to Xcode project.
* Adds 'f' to float literals where expecting a float.
* Use cosf() instead of cos() when assigning to a float.
* WebCore.xcodeproj/project.pbxproj:
* kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m:
(+[WKDiffuseLightingFilter initialize]):
* kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m:
(-[WKDiscreteTransferFilter outputImage]):
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.m:
(+[WKDisplacementMapFilter initialize]):
* kcanvas/device/quartz/filters/WKSpecularLightingFilter.m:
(+[WKSpecularLightingFilter initialize]):
* kcanvas/device/quartz/filters/WKSpotLightFilter.m:
(-[WKSpotLightFilter outputImage]):
* kcanvas/device/quartz/filters/WKTableTransferFilter.m:
(-[WKTableTransferFilter outputImage]):
WebKit:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
Make WebCore (and friends) compile with -Wshorten-64-to-32
* Adds 'f' to float literals where expecting a float.
* Use ceilf() instead of ceil() when assigning to a float.
* Adds explicit casts where OK.
NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
because there are still a few places where no error handling
is in place. The flag can be added as soon as those are worked
out.
* Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]):
* Misc/WebNSImageExtras.m:
(-[NSImage _web_scaleToMaxSize:]):
* Misc/WebNSViewExtras.h:
* Misc/WebNSViewExtras.m:
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView drawRect:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge expiresTimeForResponse:]):
* WebInspector/WebInspector.m:
(-[NSWindow window]):
(-[WebInspector treeViewScrollTo:]):
(-[WebInspector _updateSystemColors]):
(-[WebInspector webView:plugInViewWithArguments:]):
(-[WebInspector outlineView:objectValueForTableColumn:byItem:]):
* WebInspector/WebInspectorOutlineView.m:
(-[WebInspectorOutlineView _highlightRow:clipRect:]):
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight initWithBounds:andRects:forView:]):
* WebInspector/WebNodeHighlightView.m:
(-[WebNodeHighlightView roundedRect:withRadius:]):
(-[WebNodeHighlightView initWithHighlight:andRects:forView:]):
(-[WebNodeHighlightView drawRect:]):
* WebView/WebFrame.m:
(-[WebFrame _opened]):
* WebView/WebFrameView.m:
(-[WebFrameView initWithFrame:]):
* WebView/WebHTMLView.m:
(-[WebHTMLView _dragImageForLinkElement:]):
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[NSArray layout]):
(-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
(-[NSArray adjustPageHeightNew:top:bottom:limit:]):
(-[NSArray _scaleFactorForPrintOperation:]):
(-[NSArray setPageWidthForPrinting:]):
(-[NSArray _endPrintMode]):
(-[NSArray knowsPageRange:]):
(-[NSArray _originalFontA]):
(-[NSArray _originalFontB]):
(-[WebTextCompleteController _buildUI]):
(-[WebTextCompleteController _placePopupWindow:]):
* WebView/WebPDFView.m:
(-[WebPDFView _makeTextStandardSize:]):
(-[WebPDFView selectionImageForcingWhiteText:]):
(-[PDFPrefUpdatingProxy forwardInvocation:]):
* WebView/WebPreferences.m:
(-[WebPreferences _floatValueForKey:]):
* WebView/WebView.m:
(-[WebView makeTextSmaller:]):
(-[WebView canMakeTextStandardSize]):
(-[WebView makeTextStandardSize:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 4 Aug 2006 16:55:33 +0000 (16:55 +0000)]
Reviewed by Anders.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Convert
spaces to tabs
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 4 Aug 2006 11:23:37 +0000 (11:23 +0000)]
WebKit:
Reviewed by NOBODY (build fix).
* WebCoreSupport/WebSubresourceLoader.m: REALLY moved to Loader/
* WebView/WebFrameLoader.h: REALLY moved to Loader/
* WebView/WebFrameLoader.m: REALLY moved to Loader/
* WebView/WebLoader.h: REALLY moved to Loader/
* WebView/WebLoader.m: REALLY moved to Loader/
* WebView/WebMainResourceLoader.m: REALLY moved to Loader/
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 05:41:43 +0000 (05:41 +0000)]
Minor tweak to earlier patch. Use containsFloats instad.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 4 Aug 2006 05:35:47 +0000 (05:35 +0000)]
Reviewed by Darin.
- moved all loader code that is slated to be moved down to WebCore to a new Loader directory
(next step is to remove dependencies on the rest of WebKit from this directory)
* Loader/WebNetscapePlugInStreamLoader.h: Added.
* Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m
(-[WebNetscapePlugInStreamLoader initWithStream:view:]):
(-[WebNetscapePlugInStreamLoader isDone]):
(-[WebNetscapePlugInStreamLoader releaseResources]):
(-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
(-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]):
(-[WebNetscapePlugInStreamLoader didFinishLoading]):
(-[WebNetscapePlugInStreamLoader didFailWithError:]):
(-[WebNetscapePlugInStreamLoader cancelWithError:]):
* Plugins/WebNetscapePluginStream.m:
* WebKit.xcodeproj/project.pbxproj:
* WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
* WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
* WebView/WebFrameLoader.h: Moved to Loader/
* WebView/WebFrameLoader.m: Moved to Loader/
* WebView/WebLoader.h: Moved to Loader/
* WebView/WebLoader.m: Moved to Loader/
* WebView/WebMainResourceLoader.h: Moved to Loader/
* WebView/WebMainResourceLoader.m: Moved to Loader/
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 4 Aug 2006 02:08:09 +0000 (02:08 +0000)]
Reviewed by Kevin Decker.
<rdar://problem/
4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
Fixed color component swapping so that it works on both x86 and PPC. See comments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 01:38:14 +0000 (01:38 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 4 Aug 2006 01:35:07 +0000 (01:35 +0000)]
Fix for bug 10229, don't bother trying to clear when no floats are
present. I suspect there's still a bug in the math that follows, but
this fix is safer in that it just does the obvious thing (and doesn't
compute any clearance if no floats are even around).
Reviewed by maciej
* ChangeLog:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 4 Aug 2006 00:42:39 +0000 (00:42 +0000)]
LayoutTests:
Reviewed by harrison
* editing/style/non-inheritable-styles-expected.checksum: Added.
* editing/style/non-inheritable-styles-expected.png: Added.
* editing/style/non-inheritable-styles-expected.txt: Added.
* editing/style/non-inheritable-styles.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4641033/
4515463/
4052426/
4046570/
4053718/
4053724/
4060115/
4062858>
Copy/Paste fidelity was bad.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyle):
* editing/markup.cpp:
(WebCore::startMarkup): We were not adding non-inheritable styles
to the markup for an element unless they were in the elements inline
style declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 4 Aug 2006 00:37:55 +0000 (00:37 +0000)]
Cleaned up the ChangeLog from last checkin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 4 Aug 2006 00:00:48 +0000 (00:00 +0000)]
Reviewed by Tim Hatcher's rubber stamp
Fixed Intel build break caused by weinig's -W change in r15781
* WebView/WebView.m: wrapped cpu-dependent defs with defined() macro
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 3 Aug 2006 22:58:11 +0000 (22:58 +0000)]
Reviewed by John.
- fixed problem that could cause assertion failures in Safari
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't
allow a plugin to start new loads once its document is no longer the one actively loading.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 3 Aug 2006 22:33:56 +0000 (22:33 +0000)]
Reviewed by John.
- remove use of WebDataSource from WebLoader and subclasses, just have them talk to the
WebFrameLoader instead.
For now this is done by forarding all the calls.
* Misc/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]):
* Plugins/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
(-[WebNetscapePluginStream start]):
(-[WebNetscapePlugInStreamLoader didFinishLoading]):
(-[WebNetscapePlugInStreamLoader didFailWithError:]):
(-[WebNetscapePlugInStreamLoader cancelWithError:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
(-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
* WebCoreSupport/WebSubresourceLoader.h:
* WebCoreSupport/WebSubresourceLoader.m:
(-[WebSubresourceLoader initWithLoader:frameLoader:]):
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
(+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]):
(+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]):
(-[WebSubresourceLoader receivedError:]):
(-[WebSubresourceLoader signalFinish]):
(-[WebSubresourceLoader didFailWithError:]):
(-[WebSubresourceLoader cancel]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDataSource.m:
(-[WebDataSource _updateLoading]):
(-[WebDataSource textEncodingName]):
(-[WebDataSource _mainReceivedBytesSoFar:complete:]):
* WebView/WebFrameLoader.h:
* WebView/WebFrameLoader.m:
(-[WebFrameLoader loadIconWithRequest:]):
(-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
(-[WebFrameLoader clearIconLoader]):
(-[WebFrameLoader commitProvisionalLoad]):
(-[WebFrameLoader activeDataSource]):
(-[WebFrameLoader _archivedSubresourceForURL:]):
(-[WebFrameLoader _defersCallbacks]):
(-[WebFrameLoader _identifierForInitialRequest:]):
(-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
(-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didReceiveResponse:forResource:]):
(-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
(-[WebFrameLoader _didFinishLoadingForResource:]):
(-[WebFrameLoader _didFailLoadingWithError:forResource:]):
(-[WebFrameLoader _privateBrowsingEnabled]):
(-[WebFrameLoader _addPlugInStreamLoader:]):
(-[WebFrameLoader _removePlugInStreamLoader:]):
(-[WebFrameLoader _finishedLoadingResource]):
(-[WebFrameLoader _receivedError:]):
(-[WebFrameLoader _addSubresourceLoader:]):
(-[WebFrameLoader _removeSubresourceLoader:]):
(-[WebFrameLoader _originalRequest]):
(-[WebFrameLoader webFrame]):
(-[WebFrameLoader _receivedMainResourceError:complete:]):
(-[WebFrameLoader initialRequest]):
(-[WebFrameLoader _receivedData:]):
(-[WebFrameLoader _setRequest:]):
(-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
(-[WebFrameLoader _handleFallbackContent]):
(-[WebFrameLoader _isStopping]):
(-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]):
(-[WebFrameLoader _setupForReplaceByMIMEType:]):
(-[WebFrameLoader _setResponse:]):
(-[WebFrameLoader _mainReceivedError:complete:]):
(-[WebFrameLoader _finishedLoading]):
(-[WebFrameLoader _mainReceivedBytesSoFar:complete:]):
(-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
(-[WebFrameLoader _URL]):
* WebView/WebLoader.h:
* WebView/WebLoader.m:
(-[NSURLProtocol releaseResources]):
(-[NSURLProtocol loadWithRequest:]):
(-[NSURLProtocol setFrameLoader:]):
(-[NSURLProtocol frameLoader]):
(-[NSURLProtocol willSendRequest:redirectResponse:]):
(-[NSURLProtocol didReceiveAuthenticationChallenge:]):
(-[NSURLProtocol didCancelAuthenticationChallenge:]):
(-[NSURLProtocol didReceiveResponse:]):
(-[NSURLProtocol didReceiveData:lengthReceived:]):
(-[NSURLProtocol signalFinish]):
(-[NSURLProtocol didFailWithError:]):
(-[NSURLProtocol willCacheResponse:]):
(-[NSURLProtocol cancelWithError:]):
* WebView/WebMainResourceLoader.h:
* WebView/WebMainResourceLoader.m:
(-[WebMainResourceLoader initWithFrameLoader:]):
(-[WebMainResourceLoader receivedError:]):
(-[WebMainResourceLoader cancelWithError:]):
(-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]):
(-[WebMainResourceLoader addData:]):
(-[WebMainResourceLoader willSendRequest:redirectResponse:]):
(-[WebMainResourceLoader continueAfterContentPolicy:response:]):
(-[WebMainResourceLoader continueAfterContentPolicy:]):
(-[WebMainResourceLoader checkContentPolicyForResponse:]):
(-[WebMainResourceLoader didReceiveResponse:]):
(-[WebMainResourceLoader didReceiveData:lengthReceived:]):
(-[WebMainResourceLoader didFinishLoading]):
(-[WebMainResourceLoader didFailWithError:]):
(-[WebMainResourceLoader loadWithRequestNow:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 3 Aug 2006 21:55:57 +0000 (21:55 +0000)]
JavaScriptCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
Make WebCore compile with -Wundef
* Adds -Wundef flag to Xcode project
* Converts #ifs to #ifdef and #ifndefs where needed.
* Added #define YYMAXDEPTH 10000 in kjs/grammar.y
to fix a warning from within Bison.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::getSlot):
(JavaJSObject::setSlot):
* bindings/npapi.h:
* bindings/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::methodsNamed):
(KJS::Bindings::ObjcClass::fieldNamed):
* bindings/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
* bindings/objc/objc_runtime.mm:
(ObjcMethod::getMethodSignature):
(ObjcField::name):
(ObjcField::type):
* kjs/grammar.y:
* kjs/identifier.h:
JavaScriptGlue:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
Make WebCore compile with -Wundef
* Adds -Wundef flag to Xcode project
* JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
Make WebCore compile with -Wundef
* Adds -Wundef flag to Xcode project
* Converts #ifs to #ifdef and #ifndefs where needed.
* Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN)
(and in one instance in config.h with #if !COMPILER(MSVC))
* Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y
to fix a warning from within Bison.
* Cleaned up style a little in surrounding code.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
* config.h:
* css/CSSGrammar.y:
* css/MediaFeatureNames.cpp:
* css/MediaFeatureNames.h:
* css/cssparser.cpp:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::setActive):
* dom/Element.cpp:
(WebCore::Element::attach):
* dom/Element.h:
* dom/EventNames.cpp:
* dom/EventNames.h:
* dom/NamedAttrMap.h:
* dom/Position.cpp:
* dom/QualifiedName.cpp:
* dom/QualifiedName.h:
* dom/Range.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::error):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptHandler):
(WebCore::HTMLTokenizer::scriptExecution):
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::continueProcessing):
(WebCore::HTMLTokenizer::write):
(WebCore::HTMLTokenizer::timerFired):
(WebCore::HTMLTokenizer::notifyFinished):
* kcanvas/device/quartz/KCanvasFilterQuartz.h:
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/css/SVGRenderStyleDefs.h:
* ksvg2/scripts/make_names.pl:
* loader/CachedResource.h:
* loader/LoaderFunctions.h:
* loader/loader.h:
* page/Frame.cpp:
* page/FrameTree.cpp:
* page/FrameView.cpp:
(WebCore::FrameView::clear):
(WebCore::FrameView::layout):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::unscheduleRelayout):
* platform/AtomicString.cpp:
* platform/AtomicString.h:
* platform/Cursor.h:
* platform/DeprecatedArray.h:
* platform/DeprecatedString.cpp:
(WebCore::allocateHandle):
(WebCore::initializeHandleNodeBlock):
(WebCore::freeHandle):
* platform/FloatPoint.h:
* platform/FloatRect.h:
* platform/FloatSize.h:
* platform/GraphicsContext.h:
* platform/Image.h:
* platform/IntPoint.h:
* platform/IntRect.h:
(WebCore::IntRect::inflateX):
(WebCore::IntRect::inflateY):
* platform/IntSize.h:
* platform/PlatformKeyboardEvent.h:
* platform/PlatformMouseEvent.h:
* platform/PlatformString.h:
* platform/ResourceLoader.h:
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
* platform/ScrollView.h:
* platform/StaticConstructors.h:
* platform/StreamingTextDecoderICU.cpp:
(WebCore::StreamingTextDecoderICU::convert):
* platform/StringImpl.h:
* platform/Widget.h:
* platform/mac/BlockExceptions.mm:
* platform/mac/ColorMac.mm:
(+[WebCoreControlTintObserver WebCore]):
* platform/mac/FloatPointMac.mm:
* platform/mac/FloatRectMac.mm:
* platform/mac/FloatSizeMac.mm:
* platform/mac/FontMac.mm:
* platform/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
* platform/mac/IntPointMac.mm:
* platform/mac/IntRectMac.mm:
* platform/mac/IntSizeMac.mm:
* platform/mac/WebCoreSystemInterface.h:
* rendering/RenderBlock.h:
* rendering/RenderTableCell.h:
* rendering/bidi.cpp:
(WebCore::appendRun):
(WebCore::RenderBlock::layoutInlineChildren):
* xml/XSLTProcessor.cpp:
(WebCore::parseErrorFunc):
* xpath/impl/XPathGrammar.y:
WebKit:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
Make WebCore compile with -Wundef
* Adds -Wundef flag to Xcode project
* Converts #ifs to #ifdef and #ifndefs where needed.
* Carbon/CarbonUtils.m:
* Carbon/CarbonWindowAdapter.m:
* Carbon/HIViewAdapter.m:
(+[NSView bindHIViewToNSView:nsView:]):
* Carbon/HIWebView.m:
(HIWebViewEventHandler):
* Misc/WebFileDatabase.m:
(UniqueFilePathForKey):
* Misc/WebNSWindowExtras.m:
(swizzleInstanceMethod):
* Misc/WebTypesInternal.h:
* Plugins/WebNetscapeDeprecatedFunctions.c:
* Plugins/WebNetscapeDeprecatedFunctions.h:
* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage unloadWithoutShutdown]):
(-[WebNetscapePluginPackage load]):
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 3 Aug 2006 20:25:28 +0000 (20:25 +0000)]
Reviewed by darin
* fast/forms/plaintext-mode-1-expected.txt:
* fast/forms/plaintext-mode-1.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 3 Aug 2006 19:33:38 +0000 (19:33 +0000)]
2006-08-03 Anders Carlsson <acarlsson@apple.com>
Reviewed by John Sullivan.
* wtf/HashSet.h:
(WTF::::operator):
Return *this in operator=
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 3 Aug 2006 19:29:13 +0000 (19:29 +0000)]
Reviewed by Maciej and Beth.
Fix use-after-dispose heap corruption bug.
* rendering/ListMarkerBox.cpp:
(WebCore::ListMarkerBox::destroy): Only call removeChild if we're not
destroying the document
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 3 Aug 2006 19:18:11 +0000 (19:18 +0000)]
JavaScriptCore:
Reviewed by Anders.
- Fixed Windows build
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* wtf/MathExtras.h: Implement inline versions of these functions
(nextafter):
(nextafterf):
WebCore:
Reviewed by Anders.
- Fixed Windows build.
* platform/Color.cpp:
(WebCore::makeRGBAFromHSLA): Whitespace change
* platform/win/TemporaryLinkStubs.cpp: Add new method stubs
(PlatformScrollBar::PlatformScrollBar):
(PlatformScrollBar::~PlatformScrollBar):
(PlatformScrollBar::width):
(PlatformScrollBar::height):
(PlatformScrollBar::setEnabled):
(PlatformScrollBar::paint):
(PlatformScrollBar::setScrollBarValue):
(PlatformScrollBar::setKnobProportion):
(PlatformScrollBar::setRect):
(ScrollBar::ScrollBar):
(ScrollBar::scroll):
(ScrollBar::setValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 3 Aug 2006 18:04:42 +0000 (18:04 +0000)]
LayoutTests:
Reviewed by mjs
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work
* editing/execCommand/hilitecolor-expected.checksum: Added.
* editing/execCommand/hilitecolor-expected.png: Added.
* editing/execCommand/hilitecolor-expected.txt: Added.
* editing/execCommand/hilitecolor.html: Added.
WebCore:
Reviewed by mjs
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work
* editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...).
It's what GMail uses to implement text hiliting. It's just a synonym for BackColor.
* editing/SelectionController.cpp:
(WebCore::SelectionController::nodeWillBeRemoved): Moved a comment
a more appropriate place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 3 Aug 2006 15:36:13 +0000 (15:36 +0000)]
2006-08-03 Mark Rowe <opendarwin.org@bdash.net.nz>
Reviewed by Darin.
Bug 10224: [Drosera] Drosera icon should be set on DroseraLauncher so it appears in nightly builds
http://bugzilla.opendarwin.org/show_bug.cgi?id=10224
* Drosera/Drosera.xcodeproj/project.pbxproj:
* Drosera/LauncherInfo.plist:
2006-08-03 Mitz Pettel <opendarwin.org@mitzpettel.com>
- fix ASSERTION FAILURE: draggingDocumentView == nil in -[WebViewPrivate dealloc]
when a test performs an unsuccessful drag and drop operation.
* DumpRenderTree/EventSendingController.m:
(-[EventSendingController mouseUp]): Added a call to -draggingExited: if the
drag operation for the mouse release is NSDragOperationNone.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 3 Aug 2006 15:34:13 +0000 (15:34 +0000)]
LayoutTests:
Reviewed by Adele and Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10177
REGRESSION: Successfully dragging text into a disabled field
* fast/forms/textfield-drag-into-disabled-expected.checksum: Added.
* fast/forms/textfield-drag-into-disabled-expected.png: Added.
* fast/forms/textfield-drag-into-disabled-expected.txt: Added.
* fast/forms/textfield-drag-into-disabled.html: Added.
* fast/forms/input-disabled-color-expected.txt: Updated.
WebCore:
Reviewed by Adele and Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10177
REGRESSION: Successfully dragging text into a disabled field
Test: fast/forms/textfield-drag-into-disabled.html
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify
to read-only on the inner div if the control is disabled.
(WebCore::RenderTextControl::updateFromElement): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 3 Aug 2006 15:24:49 +0000 (15:24 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10198
REGRESSION: WebKit r15750 crashes while loading anthem.com
* fast/overflow/generated-content-crash-expected.txt: Added.
* fast/overflow/generated-content-crash.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10198
REGRESSION: WebKit r15750 crashes while loading anthem.com
Test: fast/overflow/generated-content-crash.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for
the renderer's element. Generated content does not have an element and
therefore does not need to maintain overflow status.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 3 Aug 2006 15:22:52 +0000 (15:22 +0000)]
LayoutTests:
Reviewed by Anders.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
REGRESSION: Repro crash when loading an empty image document
* fast/tokenizer/image-empty-crash-expected.txt: Added.
* fast/tokenizer/image-empty-crash.html: Added.
WebCore:
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
REGRESSION: Repro crash when loading an empty image document
Test: fast/tokenizer/image-empty-crash.html
* loader/ImageDocument.cpp:
(WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement.
(WebCore::ImageTokenizer::finish): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log