beidson@apple.com [Tue, 4 Jan 2011 21:35:07 +0000 (21:35 +0000)]
* storage/StorageMap.h: mesured? Really?
Reviewed by a spell checker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 21:27:04 +0000 (21:27 +0000)]
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
1. Remove entry for editing/input/ime-composition-clearpreedit.html test.
2. Improve fast/events/ime-composition-events-001.html to cover more
cases. And fix test expectations of chromium port.
https://bugs.webkit.org/show_bug.cgi?id=51693
* fast/events/ime-composition-events-001-expected.txt:
* fast/events/ime-composition-events-001.html:
* platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
* platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
* platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
Fix insertText, setMarkedText and unmarkText methods of
TextInputController to call corresponding methods of WebKit::WebView
rather than WebKit::WebFrame. This change matches the behavior of
chromium browser.
insertText corresponds to WebView::confirmComposition(text)
setMarkedText corresponds to WebView::setComposition(...)
unmarkText corresponds to WebView::confirmComposition()
https://bugs.webkit.org/show_bug.cgi?id=51693
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::insertText):
(TextInputController::setMarkedText):
(TextInputController::unmarkText):
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
Changes:
1. Add WebKit::WebWidget::confirmComposition(const WebString& text)
This new method corresponds to Editor::confirmComposition(text) and
Editor::insertText(text). It'll be used by both DumpRenderTree's
TextInputController and chromium browser.
2. Fix WebFrameImpl::insertText
It should call Editor::confirmComposition(text) rather than
Editor::insertText(text) if there is an ongoing composition.
It matches the behavior of WebKit Mac port.
3. Fix WebFrameImpl::setMarkedText
Editor::confirmComposition(text) shouldn't be called in this
method, which incorrectly inserts the text.
https://bugs.webkit.org/show_bug.cgi?id=51693
* public/WebWidget.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::insertText):
(WebKit::WebFrameImpl::setMarkedText):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::confirmComposition):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::confirmComposition):
* src/WebViewImpl.h:
* tests/PopupMenuTest.cpp:
(WebKit::TestWebWidget::confirmComposition):
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
Fix test LayoutTests/fast/events/ime-composition-events-001.html.
https://bugs.webkit.org/show_bug.cgi?id=51693
* Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to
insert the commit string when no composition text is available.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 4 Jan 2011 21:23:20 +0000 (21:23 +0000)]
Attach a radar # to this FIXME:
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
Rubberstamped by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 4 Jan 2011 21:12:53 +0000 (21:12 +0000)]
2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Build system cleanup
After r74811 special handling for the Symbian build is no longer needed.
This patch reverts r58756.
* WebKit.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 21:09:23 +0000 (21:09 +0000)]
2011-01-04 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port stock icon painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51764
Port stock icon painting for media and search input elements to
GtkStyleContext. Also create the initial machinery for accessing
style contexts for all GTK+ 3.x based widgets.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintGdkPixbuf):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintMediaButton):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::getStockIcon):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::gtkStyleChangedCallback):
(WebCore::styleContextMap):
(WebCore::getStyleContext):
(WebCore::RenderThemeGtk::paintMenuList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 4 Jan 2011 20:47:06 +0000 (20:47 +0000)]
<webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
Reviewed by Eric Carlson.
This originally broke in r61581. It is inside an
ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
build then.
* WebCoreSupport/WebFrameLoaderClient.mm: Call
(WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
use WebCore::PluginInfo.name instead of
-[WebBasePluginPackage name].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 4 Jan 2011 20:46:01 +0000 (20:46 +0000)]
WebCore: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852
Reviewed by Dave Hyatt.
Block inline script execution on pending stylesheet loads. This matches
other browsers and HTML5.
Tests: fast/tokenizer/inline-script-stylesheet-write.html
fast/tokenizer/inline-script-stylesheet.html
* dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
* dom/PendingScript.h:
(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
This fixes an unrelated bug with beforeload events that was exposed by the other
changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::sourceFromPendingScript):
(WebCore::HTMLScriptRunner::runScript):
LayoutTests: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852
Reviewed by Dave Hyatt.
New tests plus a few test with slightly changed output due to different load serialization behavior.
* fast/tokenizer/inline-script-stylesheet-expected.txt: Added.
* fast/tokenizer/inline-script-stylesheet-write-expected.txt: Added.
* fast/tokenizer/inline-script-stylesheet-write.html: Added.
* fast/tokenizer/inline-script-stylesheet.html: Added.
* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 20:43:52 +0000 (20:43 +0000)]
2011-01-04 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Darin Adler.
Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
on ARM.
https://bugs.webkit.org/show_bug.cgi?id=51861
By the way, changed other getIntXX() and setIntXX() methods to use
more precise integer types.
* bindings/js/JSDataViewCustom.cpp:
(WebCore::setDataViewMember):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::setInt8Callback):
* html/canvas/DataView.cpp:
(WebCore::DataView::getInt8):
(WebCore::DataView::setInt8):
* html/canvas/DataView.h:
* html/canvas/DataView.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 4 Jan 2011 20:34:49 +0000 (20:34 +0000)]
Unreviewed trivial fix after r74976.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 20:20:29 +0000 (20:20 +0000)]
2011-01-04 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.
https://bugs.webkit.org/show_bug.cgi?id=48077
Test case: WebCore/manual-tests/bugzilla-48077.html.
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::suspendScheduledTasks):
(WebCore::DocumentParser::resumeScheduledTasks):
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::suspendScheduledTasks):
(WebCore::HTMLDocumentParser::resumeScheduledTasks):
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::isScheduledForResume):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Jan 2011 19:49:18 +0000 (19:49 +0000)]
2011-01-04 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Add more spelling/grammar related methods
https://bugs.webkit.org/show_bug.cgi?id=51886
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
Handle more selectors.
(-[WKView showGuessPanel:]):
Add stub.
(-[WKView checkSpelling:]):
Ditto.
(-[WKView toggleAutomaticSpellingCorrection:]):
Toggle automatic spelling correction.
* UIProcess/TextChecker.h:
Add setAutomaticSpellingCorrectionEnabled and isAutomaticSpellingCorrectionEnabled.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled):
(WebKit::TextChecker::isAutomaticSpellingCorrectionEnabled):
Update the toggle.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
Add a Radar URL for the localization FIXMEs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 4 Jan 2011 19:40:29 +0000 (19:40 +0000)]
Unreviewed build fix.
* win/WebKit2.vcproj: Correct the missing $(WebKitVSPropsRedirectionDir)
variables that Visual Studio helpfully removes when making changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 4 Jan 2011 19:33:02 +0000 (19:33 +0000)]
2011-01-04 Daniel Bates <dbates@rim.com>
Fix the date recorded in the change log entry for changeset 74973 <http://trac.webkit.org/changeset/74973>.
It was recorded as "2011-01-03". Instead, it should be "2011-01-04" to correspond
with the date this changeset was committed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 4 Jan 2011 19:29:19 +0000 (19:29 +0000)]
2011-01-04 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails
https://bugs.webkit.org/show_bug.cgi?id=51860
* wtf/ThreadingWin.cpp:
(WTF::createThreadInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 4 Jan 2011 19:21:44 +0000 (19:21 +0000)]
Unreviewed build fix.
* win/WebKit2.vcproj: Disable CG-specific WKImageCG.cpp from
Debug_Cairo_CFLite/Release_Cario_CFLite builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 4 Jan 2011 19:16:38 +0000 (19:16 +0000)]
2011-01-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Ariya Hidayat.
[Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31273
On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
are included before platform headers. On all other platforms continue to use
INCLUDEPATH (as before). This is a continuation of r65877.
No new tests as there is no new functionality.
* JavaScriptCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Jan 2011 19:11:22 +0000 (19:11 +0000)]
Try to fix Windows build.
* wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing
of conditional includes.
(WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer.
(WTF::createThreadInternal): Tweaked #if to not need separate macro.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Jan 2011 19:04:07 +0000 (19:04 +0000)]
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Added editing/selection/caret-bidi-first-and-last-letters.html to Qt's skipped list.
The tracking bug 51884 (https://bugs.webkit.org/show_bug.cgi?id=51884) has been filed.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 4 Jan 2011 18:56:18 +0000 (18:56 +0000)]
2011-01-04 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android
https://bugs.webkit.org/show_bug.cgi?id=51855
Both the Apple Windows and Android ports implement a similar adapter structure,
called ThreadFunctionInvocation and ThreadData respectively, as part of
their thread creation process. Instead, we should share such an adapter
structure and remove duplicate code.
* JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h.
* wtf/ThreadFunctionInvocation.h: Added.
(WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):
* wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation.
(WTF::runThreadWithRegistration):
(WTF::createThreadInternal):
* wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that
it can be shared with the Android implementation of createThreadInternal().
(WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 4 Jan 2011 18:53:35 +0000 (18:53 +0000)]
2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Do not remove 0 byte sized files from productDir
On Symbian productDir points to the source directory. Removing all the
empty files from the productDir directory corrupts the svn repository.
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 4 Jan 2011 17:44:12 +0000 (17:44 +0000)]
2011-01-03 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Use __builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866
Derived from a patch by Dave Tapuska.
* wtf/AlwaysInline.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 4 Jan 2011 17:29:48 +0000 (17:29 +0000)]
2011-01-04 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Include glib-object.h for GObject
https://bugs.webkit.org/show_bug.cgi?id=51876
* bindings/gobject/DOMObjectCache.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Jan 2011 17:21:13 +0000 (17:21 +0000)]
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992
Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
does not match. Reused the code added by http://trac.webkit.org/changeset/73553.
Test: editing/selection/caret-bidi-first-and-last-letters.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::offsetForPosition):
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992
Added a test to ensure WebKit places the caret on the side user clicked even when text's natural direction
and the containing block's direction do not match.
* editing/selection/caret-bidi-first-and-last-letters-expected.txt: Added.
* editing/selection/caret-bidi-first-and-last-letters.html: Added.
* editing/selection/resources/caret-edge-shared.js: Avoid calling verify() outside of DRT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 4 Jan 2011 17:05:37 +0000 (17:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51856
Pass encoded back/forward tree data from the WebProcess to the UIProcess
Reviewed by Darin Adler.
Remove the WKBackForwardListItemCopyOriginalURL API as it's not needed:
* UIProcess/API/C/WKBackForwardListItem.cpp:
* UIProcess/API/C/WKBackForwardListItem.h:
* UIProcess/API/qt/qwkhistory.cpp:
* UIProcess/API/qt/qwkhistory.h:
* UIProcess/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
* UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::backForwardData):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 4 Jan 2011 16:56:17 +0000 (16:56 +0000)]
2010-12-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Remove 2 unnecessary includes from Document.h
https://bugs.webkit.org/show_bug.cgi?id=51727
No new tests because no changed functionality.
* dom/Document.cpp:
* dom/Document.h:
* editing/Editor.cpp:
* editing/SpellChecker.h:
* editing/SplitTextNodeCommand.cpp:
* editing/TextCheckingHelper.cpp:
* page/FrameView.cpp:
* page/Page.cpp:
* rendering/HitTestResult.cpp:
* rendering/InlineTextBox.cpp:
* rendering/InlineTextBox.h:
* rendering/svg/SVGInlineFlowBox.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 4 Jan 2011 15:33:17 +0000 (15:33 +0000)]
2011-01-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix.
* CMakeListsWinCE.txt: Added missing include directories, files and libraries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 4 Jan 2011 14:01:47 +0000 (14:01 +0000)]
2011-01-04 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Incomplete clean up on termination
https://bugs.webkit.org/show_bug.cgi?id=51474
Do not kill the web process to force it's termination.
Fix object destruction and cleanup logic and make the cleanup more reliable.
Do not try to cleanup on crash because it is not reliable.
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::platformInvalidate): Do not delete the socket if we
do not own it. This is the case with a server connection.
* Platform/qt/MappedMemoryPool.cpp:
Turn MappedMemoryPool into a QObject so the CleanupHandler can destruct it
in the same way as the other objects.
(WebKit::MappedMemoryPool::instance):
(WebKit::MappedMemoryPool::~MappedMemoryPool):
* Platform/qt/MappedMemoryPool.h:
(WebKit::MappedMemoryPool::MappedMemoryPool):
* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::create): No need to care about QCoreApplication::aboutToQuit.
It is handled by the CleanupHandler.
(WebKit::SharedMemory::~SharedMemory): Ditto.
* Shared/qt/CleanupHandler.cpp: Renamed from WebKit2/Shared/qt/CrashHandler.cpp.
No longer try to handle crash but just normal termination.
(WebKit::CleanupHandler::CleanupHandler): Connect deleteObjects with QCoreApplication::aboutToQuit.
Ensure appropriate thread affinity.
(WebKit::CleanupHandler::sigTermHandler): Stop the main event loop.
(WebKit::CleanupHandler::deleteObjects): Use deleteLater instead of delete since it is more reliable.
* Shared/qt/CleanupHandler.h: Renamed from WebKit2/Shared/qt/CrashHandler.h.
(WebKit::CleanupHandler::instance):
(WebKit::CleanupHandler::markForCleanup):
(WebKit::CleanupHandler::unmark):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
Do not kill the web process immidiately but give it a chance to cleanup.
Use QLocalServer::removeServer for assuring that the socket file will be removed.
(WebKit::ProcessLauncherHelper::serverName):
(WebKit::cleanupAtExit): Renamed from cleanupProcesses. Only kill the web process when it times
out terminating. Fixed the bug of changing the list while iterating it over by disconnecting
from the processStateChanged slot.
(WebKit::QtWebProcess::QtWebProcess): Added missing meta type registration of QProcess::ProcessState.
(WebKit::ProcessLauncherHelper::~ProcessLauncherHelper):
(WebKit::ProcessLauncherHelper::ProcessLauncherHelper): No need to add the the instance to the
CleanupHandler because we will remove the socket file in cleanupAtExit.
(WebKit::ProcessLauncherHelper::instance):
(WebKit::ProcessLauncher::terminateProcess):
* WebKit2.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 4 Jan 2011 13:44:29 +0000 (13:44 +0000)]
2011-01-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix.
* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::exceededDatabaseQuota): Added missing semicolon.
(WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):
* WebCoreSupport/ChromeClientWinCE.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 13:17:46 +0000 (13:17 +0000)]
2011-01-04 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133
Only video should be displayed in fullscreen when
requiresFullscreenForVideoPlayback is specified.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Tue, 4 Jan 2011 11:53:24 +0000 (11:53 +0000)]
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825
Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
platform independent menu informations.
* platform/qt/ContextMenuQt.cpp:
(WebCore::contextMenuItemVector):
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825
Implement the necessary methods to get a basic context menu working for Qt.
Only 4 basic WebAction have been added on the UIProcess side: back, forward, stop and reload.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::showContextMenu):
(QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createContextMenuProxy):
* UIProcess/API/qt/qwkpage.h:
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::webActionForContextMenuAction):
(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::hideContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 10:43:04 +0000 (10:43 +0000)]
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868
Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).
* svg/custom/recursive-use-expected.txt: Removed.
* svg/custom/recursive-use.svg: Removed.
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868
Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildInstanceTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 4 Jan 2011 09:43:36 +0000 (09:43 +0000)]
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74961.
http://trac.webkit.org/changeset/74961
https://bugs.webkit.org/show_bug.cgi?id=51867
breaks 32/64-bits debug bots build (Requested by philn-tp on
#webkit).
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::setWindowOverlay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 4 Jan 2011 09:12:49 +0000 (09:12 +0000)]
2011-01-03 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Eric Seidel.
[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810
Based on a patch by Mart Raudsepp.
No new tests, build fix only.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
introduced in same version as the xoverlay API change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 09:11:30 +0000 (09:11 +0000)]
2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
Test case for recursive svg <use>.
This test case passes if no crash occurs.
* svg/custom/recursive-use-expected.txt: Added.
* svg/custom/recursive-use.svg: Added.
2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.
Test: svg/custom/recursive-use.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildInstanceTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 4 Jan 2011 08:33:16 +0000 (08:33 +0000)]
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Try to fix Clang build.
* css/CSSParser.cpp:
(WebCore::valueFromSideKeyword):
(WebCore::CSSParser::parseLinearGradient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 4 Jan 2011 06:47:06 +0000 (06:47 +0000)]
2011-01-03 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update
Add expectations of r74954 tests for Chromium.
* platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
* platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 4 Jan 2011 06:20:17 +0000 (06:20 +0000)]
WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.
border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.
new test:fast/html/object-border.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.
* fast/html/object-border-expected.txt: Added.
* fast/html/object-border.html: Added.
* fast/html/resources/images/blue-border.png: Added.
* fast/html/resources/images/blue.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Jan 2011 05:36:26 +0000 (05:36 +0000)]
Try to fix Chromium build.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
Not sure this ever will be used with V8.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Jan 2011 05:31:52 +0000 (05:31 +0000)]
Try to fix Leopard build.
* history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
size variable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 4 Jan 2011 02:27:50 +0000 (02:27 +0000)]
2011-01-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Fixes before child calculation when adding anonymous childs to table parts.
https://bugs.webkit.org/show_bug.cgi?id=50932
Fix in r74364 was incomplete. When before child is equal to the table part(to
which the new child is getting added), it confuses the table part to add it
incorrectly as an after child. The patch fixes by passing the before child as
the table part's first child.
Tests: fast/css-generated-content/table-before-after-child-add.html
fast/css-generated-content/table-cell-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
2010-12-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that "before" and "after" childs are added to table correctly.
https://bugs.webkit.org/show_bug.cgi?id=50932
* fast/css-generated-content/table-before-after-child-add.html: Added.
* fast/css-generated-content/table-before-child-add.html: Removed.
* fast/css-generated-content/table-cell-before-after-child-add.html: Added.
* fast/css-generated-content/table-row-before-after-child-add.html: Added.
* platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
* platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
* platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
* platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed.
* platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
* platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
* platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 4 Jan 2011 02:02:22 +0000 (02:02 +0000)]
Shrink HTMLTableCellElement
https://bugs.webkit.org/show_bug.cgi?id=51858
Reviewed by Simon Fraser.
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
m_col.
* html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Jan 2011 01:57:35 +0000 (01:57 +0000)]
Fix build.
* platform/network/FormData.cpp:
(WebCore::FormData::create): Roll back uint8_t change.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward):
* platform/network/FormData.h: Ditto.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Jan 2011 01:35:09 +0000 (01:35 +0000)]
2011-01-03 Darin Adler <darin@apple.com>
Reviewed by Brady Eidson.
Add code to encode/decode the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=51853
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree): Added.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
(WebCore::HistoryItem::decodeBackForwardTree): Added.
* history/HistoryItem.h: Added functions above.
* platform/network/FormData.cpp:
(WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
Vector<char>. This type is used in our newer code for vectors of bytes.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
(WebCore::FormData::encodeForBackForward): Added.
(WebCore::FormData::decodeForBackForward): Added.
* platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
Vector<char>. Also made some single-argument constructors explicit.
Also added the new functions.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 4 Jan 2011 01:28:41 +0000 (01:28 +0000)]
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Attempt to fix GTK build.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::drawGlyphsShadow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Tue, 4 Jan 2011 00:54:46 +0000 (00:54 +0000)]
Mac build fix. Define WTF_USE_CFNETWORK for Windows build only.
* WebCoreSupport/WebInspectorClientCF.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 4 Jan 2011 00:39:13 +0000 (00:39 +0000)]
Windows build fix. Define WTF_USE_CFNETWORK in WebInspectorClientCF.
* WebCoreSupport/WebInspectorClientCF.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Jan 2011 00:21:05 +0000 (00:21 +0000)]
2011-01-03 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
ContextShadow can avoid code duplication for getting the CTM
https://bugs.webkit.org/show_bug.cgi?id=51799
ContextShadow defines its own getTransformationMatrixFromContext()
which does exactly the same as GraphicsContext::getCTM().
Existing tests: fast/canvas/canvas*shadow*html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::mustUseContextShadow):
(WebCore::ContextShadow::adjustBlurDistance):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
(WebCore::ContextShadow::drawRectShadowWithoutTiling):
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsShadow):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::drawGlyphsShadow):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Jan 2011 00:09:14 +0000 (00:09 +0000)]
2011-01-03 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
InsertTextCommand::m_charactersAdded is unused
https://bugs.webkit.org/show_bug.cgi?id=51849
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
(WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
* editing/InsertTextCommand.h: Removed charactersAdded function and
m_charactersAdded data member.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Jan 2011 23:56:16 +0000 (23:56 +0000)]
2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=51832
Method paintMenuListButton() contains code common to both gtk 2
and 3, so it can be moved to RenderThemeGtk.cpp instead of
duplicating it.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMenuListButton):
* platform/gtk/RenderThemeGtk2.cpp:
* platform/gtk/RenderThemeGtk3.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 3 Jan 2011 23:52:04 +0000 (23:52 +0000)]
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
* autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env
variable (like jhbuild).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Mon, 3 Jan 2011 23:45:12 +0000 (23:45 +0000)]
2011-01-03 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=51850
Put CFNetwork loader code inside USE(CFNETWORK)
Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
files to the WebCore Xcode project.
* WebCore.xcodeproj/project.pbxproj:
* loader/cf/ResourceLoaderCFNet.cpp:
* loader/mac/ResourceLoaderMac.mm:
* platform/network/cf/AuthenticationCF.cpp:
* platform/network/cf/AuthenticationCF.h:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/cf/CookieStorageCFNet.cpp:
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/cf/CredentialStorageCFNet.cpp:
* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/network/cf/FormDataStreamCFNet.h:
* platform/network/cf/LoaderRunLoopCF.cpp:
* platform/network/cf/LoaderRunLoopCF.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.cpp:
* platform/network/cf/ResourceRequestCFNet.h:
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/ResourceResponseCFNet.cpp:
* platform/network/mac/AuthenticationMac.h:
* platform/network/mac/AuthenticationMac.mm:
* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
* platform/network/mac/ResourceError.h:
* platform/network/mac/ResourceHandleMac.mm:
* platform/network/mac/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
* platform/network/mac/ResourceResponse.h:
* platform/network/mac/ResourceResponseMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 3 Jan 2011 23:43:40 +0000 (23:43 +0000)]
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Use autoreconf instead of calling manually all the usual commands.
* autogen.sh: call autoreconf instead of
aclocal/autoheader/autoconf/automake/libtoolize.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Jan 2011 23:42:33 +0000 (23:42 +0000)]
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Set shortcut for the SelectAll action.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::buildUI):
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagSelectAll):
* platform/LocalizedStrings.h:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
* Api/qwebpage.cpp:
(webActionForContextMenuAction):
(QWebPage::action):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::contextMenuItemTagSelectAll):
* WebCoreSupport/WebPlatformStrategies.h:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 3 Jan 2011 22:25:11 +0000 (22:25 +0000)]
Reviewed, tweaked and landed by Sam Weinig.
Patch by Chris Fleizach <cfleizach@apple.com> on 2011-01-03
WebKit2: Accessibility support (42130)
<rdar://problem/
7660629>
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 21:53:11 +0000 (21:53 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Group tests that fail on Leopard but pass on Snow Leopard (due to
stale platform/mac baselines).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 3 Jan 2011 21:42:34 +0000 (21:42 +0000)]
2011-01-03 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
[WINCE] Provide third party directory via environment variable
https://bugs.webkit.org/show_bug.cgi?id=51643
* Source/cmake/OptionsWinCE.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 3 Jan 2011 21:40:58 +0000 (21:40 +0000)]
Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847
Reviewed by Darin Adler.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
accessor.
* rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
unsigned because otherwise MSVC treats it as signed.
(WebCore::RootInlineBox::baselineType): Added a cast.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 3 Jan 2011 21:38:34 +0000 (21:38 +0000)]
* wtf/Forward.h: Added Decoder and Encoder.
Reviewed by Brady Eidson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 3 Jan 2011 21:36:45 +0000 (21:36 +0000)]
Adding files I missed in my last git add. *shame*
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 3 Jan 2011 21:21:24 +0000 (21:21 +0000)]
2011-01-03 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
https://bugs.webkit.org/show_bug.cgi?id=51842
* Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 3 Jan 2011 21:20:13 +0000 (21:20 +0000)]
WebKit/gtk
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Final patch, removing webkitprivate.{cpp,h}, and adding a
webkitglobals module to hold non-object-specific functions and
definitions that do not make sense on their own.
* GNUmakefile.am:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::createWindow):
* WebCoreSupport/ContextMenuClientGtk.cpp:
* WebCoreSupport/DocumentLoaderGtk.cpp:
(WebKit::DocumentLoader::attachToFrame):
* WebCoreSupport/DragClientGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::ignoreWordInSpellDocument):
(WebKit::EditorClient::learnWord):
(WebKit::EditorClient::checkSpellingOfString):
(WebKit::EditorClient::getGuessesForWord):
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createDocumentLoader):
* WebCoreSupport/InspectorClientGtk.cpp:
* webkit/webkit.h:
* webkit/webkitapplicationcache.cpp:
(webkit_application_cache_set_maximum_size):
* webkit/webkitdownload.cpp:
(webkit_download_class_init):
* webkit/webkitgeolocationpolicydecision.cpp:
* webkit/webkitglobals.cpp: Added.
(webkit_get_default_session):
(webkit_set_cache_model):
(webkit_get_cache_model):
(webkit_get_web_plugin_database):
(currentToplevelCallback):
(closeIconDatabaseOnExit):
(webkitInit):
(WebKit::pasteboardHelperInstance):
* webkit/webkitglobals.h: Added.
* webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h.
* webkit/webkithittestresult.cpp:
(webkit_hit_test_result_class_init):
* webkit/webkitnetworkrequest.cpp:
(webkit_network_request_class_init):
* webkit/webkitnetworkresponse.cpp:
(webkit_network_response_class_init):
* webkit/webkitprivate.cpp: Removed.
* webkit/webkitprivate.h: Removed.
* webkit/webkitsecurityorigin.cpp:
* webkit/webkitviewportattributes.cpp:
* webkit/webkitwebbackforwardlist.cpp:
(webkit_web_back_forward_list_class_init):
* webkit/webkitwebdatabase.cpp:
* webkit/webkitwebdatasource.cpp:
(webkit_web_data_source_class_init):
(webkit_web_data_source_new_with_request):
(WebKit::kitNew):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
* webkit/webkitwebframeprivate.h:
* webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_class_init):
* webkit/webkitwebinspector.cpp:
* webkit/webkitwebnavigationaction.cpp:
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_class_init):
* webkit/webkitwebplugindatabase.cpp:
(webkit_web_plugin_database_class_init):
* webkit/webkitwebpluginprivate.h:
* webkit/webkitwebpolicydecision.cpp:
* webkit/webkitwebresource.cpp:
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkitWebViewGetEnchantDicts):
(WebKit::core):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
* webkit/webkitwebview.h:
* webkit/webkitwebwindowfeatures.cpp:
(webkit_web_window_features_class_init):
(WebKit::kitNew):
WebCore
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Fix DOM bindings generation to no longer include the now-gone
webkitprivate.h header, including the appropriate replacements
instead.
* bindings/scripts/CodeGeneratorGObject.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Jan 2011 21:16:08 +0000 (21:16 +0000)]
2011-01-03 Antonio Gomes <agomes@rim.com>
Unreviewed crash fix.
Follow up of r74891: potential crash fix (bogus assertion).
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::editorCommandForKeyDownEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 21:13:37 +0000 (21:13 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Missed a few failing tests.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 3 Jan 2011 21:10:14 +0000 (21:10 +0000)]
2011-01-03 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
[WINCE] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=50523
* BuildSlaveSupport/build.webkit.org-config/config.json: Add an
entry for a release build of the WinCE port.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
flag to build the WinCE port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 21:04:52 +0000 (21:04 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove fast/, printing/, svg/, tables/ and transforms/ chromium-mac
baselines that are no longer necessary after r74892 (now that
chromium-mac scrollbars match mac ones).
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Removed.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
* platform/chromium-mac/fast/events/autoscroll-expected.checksum: Removed.
* platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
* platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Removed.
* platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
* platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Removed.
* platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png: Removed.
* platform/chromium-mac/fast/forms/basic-textareas-expected.checksum: Removed.
* platform/chromium-mac/fast/forms/basic-textareas-expected.png: Removed.
* platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.checksum: Removed.
* platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Removed.
* platform/chromium-mac/fast/forms/button-default-title-expected.checksum: Removed.
* platform/chromium-mac/fast/forms/button-default-title-expected.png: Removed.
* platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Removed.
* platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
* platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Removed.
* platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.checksum: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
* platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/lists/008-vertical-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Removed.
* platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Removed.
* platform/chromium-mac/fast/multicol/client-rects-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
* platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
* platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png: Removed.
* platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Removed.
* platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Removed.
* platform/chromium-mac/fast/table/027-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
* platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
* platform/chromium-mac/fast/table/038-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/038-vertical-expected.png: Removed.
* platform/chromium-mac/fast/table/040-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/040-vertical-expected.png: Removed.
* platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Removed.
* platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Removed.
* platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Removed.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
* platform/chromium-mac/fast/text/text-letter-spacing-expected.checksum: Removed.
* platform/chromium-mac/fast/text/text-letter-spacing-expected.png: Removed.
* platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Removed.
* platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Removed.
* platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Removed.
* platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Removed.
* platform/chromium-mac/printing/return-from-printing-mode-expected.checksum: Removed.
* platform/chromium-mac/printing/return-from-printing-mode-expected.png: Removed.
* platform/chromium-mac/svg/custom/altglyph-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/altglyph-expected.png: Removed.
* platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Removed.
* platform/chromium-mac/svg/custom/junk-data-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/junk-data-expected.png: Removed.
* platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/missing-xlink-expected.png: Removed.
* platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Removed.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Removed.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
* platform/chromium-mac/svg/in-html/circle-expected.checksum: Removed.
* platform/chromium-mac/svg/in-html/circle-expected.png: Removed.
* platform/chromium-mac/svg/text/kerning-expected.checksum: Removed.
* platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Removed.
* platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Removed.
* platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Removed.
* platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Removed.
* platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Removed.
* platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Removed.
* platform/chromium-mac/transforms/2d/transform-fixed-container-expected.checksum: Removed.
* platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 3 Jan 2011 21:04:17 +0000 (21:04 +0000)]
2011-01-03 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Add WinCE support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51642
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 3 Jan 2011 20:59:10 +0000 (20:59 +0000)]
2011-01-03 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802
I'm not the biggest fan of the test_failures or test_results classes,
but it's better to have one shared set of classes, than separate ones
for new vs. old run-webkit-test result handling.
This moves the ORWT results class "LayoutTestResults" over to using
TestResult and TestFailure classes, making it easy for us to
make all our sheriff-bot and other webkitpy code NRWT ready.
This also makes it a trivial patch to generate results.json information
from ORWT results.html files (for flaky test analysis, etc.) as well
as making it a one-liner to report test failure types when the
commit-queue sees flaky tests.
This patch tried not to add new functionality, but only to replace
the guts of LayoutTestResults, while adding unit tests and hoping
not to break anything.
I also moved callers which assumed User.prompt* were static/class methods
to using them as instance methods (since we'll eventually want to make them such).
In the process of re-writing things, I broke the rebaseline command, so I wrote
a unit test to catch my breakage were I do do so again in the future.
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
* Scripts/webkitpy/common/net/layouttestresults.py:
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_results.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 3 Jan 2011 20:57:03 +0000 (20:57 +0000)]
Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
Reviewed by Darin Adler.
Source/JavaScriptCore:
Starting out with a pure virtual interface to be implemented in WK2, but we might change that later.
* GNUmakefile.am:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/Decoder.h: Added.
* wtf/Encoder.h: Added.
WebCore:
* ForwardingHeaders/wtf/Decoder.h: Added.
* ForwardingHeaders/wtf/Encoder.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Jan 2011 20:40:19 +0000 (20:40 +0000)]
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
webkit-patch shouldn't waste time cleaning a working directory that's already clean
https://bugs.webkit.org/show_bug.cgi?id=51840
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 20:36:59 +0000 (20:36 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
New gradient tests fail on chromium-mac too.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 20:26:41 +0000 (20:26 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove editing/, fast/backgrounds, fast/block, fast/blockflow, and
fast/borders chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).
* platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Removed.
* platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Removed.
* platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Removed.
* platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Removed.
* platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Removed.
* platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Removed.
* platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Removed.
* platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Removed.
* platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Removed.
* platform/chromium-mac/editing/selection/iframe-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/iframe-expected.png: Removed.
* platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/select-all-001-expected.png: Removed.
* platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/select-all-002-expected.png: Removed.
* platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/select-all-003-expected.png: Removed.
* platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/select-all-004-expected.png: Removed.
* platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/unrendered-001-expected.png: Removed.
* platform/chromium-mac/editing/selection/unrendered-002-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
* platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/unrendered-003-expected.png: Removed.
* platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/unrendered-004-expected.png: Removed.
* platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/unrendered-005-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Removed.
* platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Removed.
* platform/chromium-mac/fast/block/basic/016-expected.checksum: Removed.
* platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Removed.
* platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Removed.
* platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 3 Jan 2011 20:08:38 +0000 (20:08 +0000)]
2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix.
[Qt] Add NullPtr.cpp introduced in r71155 to the Qt build system.
This fix is required for builds where HAVE(NULLPTR) is false
(e.g. some MSVC and Symbian builds).
* wtf/wtf.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 20:02:53 +0000 (20:02 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Add failing expectations for tests that depend on elliptical gradient
support.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 3 Jan 2011 20:01:03 +0000 (20:01 +0000)]
AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
https://bugs.webkit.org/show_bug.cgi?id=51833
Reviewed by Darin Adler.
WebCore:
Make sure the web area returns the contentsSize, not the same size as what is displayed.
Test: platform/mac/accessibility/webarea-size-equals-content-size.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
LayoutTests:
* platform/mac/accessibility/webarea-size-equals-content-size-expected.txt: Added.
* platform/mac/accessibility/webarea-size-equals-content-size.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 3 Jan 2011 19:57:45 +0000 (19:57 +0000)]
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Fix warning in 32-bit builds.
* css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::createGradient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 19:50:15 +0000 (19:50 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove css2.1/ chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).
* platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Removed.
* platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Removed.
* platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Removed.
* platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
* platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
* platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
* platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Removed.
* platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
* platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
* platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Removed.
* platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Removed.
* platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Removed.
* platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 19:43:00 +0000 (19:43 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Remove failing expectations for tests that now pass (due to r74892).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Jan 2011 19:37:39 +0000 (19:37 +0000)]
2011-01-03 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Daniel Bates.
In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
https://bugs.webkit.org/show_bug.cgi?id=51827
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 3 Jan 2011 19:36:41 +0000 (19:36 +0000)]
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for -webkit-radial-gradients.
Tests: fast/gradients/css3-radial-gradients.html
fast/gradients/css3-radial-gradients2.html
* css/CSSGradientValue.cpp:
(WebCore::blend): Used to blend colors, which is necessary when truncating
the start of radial gradients.
(WebCore::GradientStop): Small struct to aid gradient stop processing.
(WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store
the color so that we can blend it when truncating radial gradients. Changed
to handle both linear and radial gradients.
(WebCore::CSSRadialGradientValue::cssText): Update to follow the spec.
(WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change.
(WebCore::distanceToClosestCorner): New utility method.
(WebCore::distanceToFarthestCorner): Ditto.
(WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and
fill rules.
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what
kind of gradient it's dealing with, so add new isFooGradient methods.
(WebCore::CSSGradientValue::isRadialGradient): Ditto.
(WebCore::CSSLinearGradientValue::isLinearGradient):
(WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc.
(WebCore::CSSRadialGradientValue::setSizingBehavior):
(WebCore::CSSRadialGradientValue::setEndHorizontalSize):
(WebCore::CSSRadialGradientValue::setEndVerticalSize):
(WebCore::CSSRadialGradientValue::isRadialGradient):
* css/CSSParser.h:
* css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition()
so we can use parseFillPosition() when parsing a gradient function.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList*
(WebCore::CSSParser::parseFillPosition): Ditto
(WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition.
(WebCore::CSSParser::parseTransformOriginShorthand): Ditto
(WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing.
(WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition.
(WebCore::CSSParser::parsePerspectiveOrigin): Ditto
* css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
* platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients.
(WebCore::Gradient::create):
(WebCore::Gradient::startRadius): Expose radii.
(WebCore::Gradient::endRadius):
(WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops.
(WebCore::Gradient::setEndRadius):
(WebCore::Gradient::aspectRatio):
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Jan 2011 19:33:56 +0000 (19:33 +0000)]
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
webkit-patch should only hide update output if --quiet
https://bugs.webkit.org/show_bug.cgi?id=51838
As requested by smfr.
* Scripts/webkitpy/tool/steps/update.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 3 Jan 2011 19:33:10 +0000 (19:33 +0000)]
2011-01-03 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Remove the unused RenderTableCell::m_percentageHeight
https://bugs.webkit.org/show_bug.cgi?id=51837
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
* rendering/RenderTableCell.h: Removed m_percentageHeight.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 3 Jan 2011 19:31:32 +0000 (19:31 +0000)]
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
Tests: fast/gradients/css3-color-stop-units.html
fast/gradients/css3-color-stops.html
fast/gradients/css3-gradient-parsing.html
fast/gradients/css3-linear-angle-gradients.html
* css/CSSGradientValue.h:
Add subclasses of CSSGradientValue for linear and radial gradients.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache
the gradient sometimes.
(WebCore::compareStops): positions are CSSValues now.
(WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called
for old-style gradients.
(WebCore::CSSGradientValue::addStops): New method that handles the spec rules about
missing positions, ensuring that stop position is ordered, and spacing out stops
without positions. Also normalize gradients which use stops outside the 0-1 range
so that platforms can render them correctly.
(WebCore::positionFromValue): Determin the position on the gradient line for percentage,
number and length values.
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::cssText):
(WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle
given an angle.
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::cssText):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Style fix.
(WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage()
(WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage()
(WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage()
(WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient.
(WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient,
and fixed to store CSSValues for the stop position.
(WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient,
and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate.
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword): Color parsing utility.
(WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients.
(WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients.
(WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas.
(WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients
and CSS canvas.
* css/CSSParser.h:
* platform/graphics/Gradient.h:
(WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients.
(WebCore::Gradient::setP1): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 19:18:28 +0000 (19:18 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Missed a few failing tests.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Jan 2011 19:04:55 +0000 (19:04 +0000)]
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue shouldn't reject patches twice if two bots process the same patch
https://bugs.webkit.org/show_bug.cgi?id=51805
Before raising an error, we first check whether the patch is still in
the commit-queue. This check is still racy, of course, but the time
window is much smaller.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Mon, 3 Jan 2011 19:01:58 +0000 (19:01 +0000)]
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom member (qtObject) to WebCore::Widget.
Added a test to tst_qwebpage to make sure plugins created
as QGraphicsWidget are accessible through JavaScript.
* bindings/js/ScriptControllerQt.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* platform/Widget.h:
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setBindingObject):
(WebCore::Widget::bindingObject):
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom membe to WebCore::Widget.
Added a test to make sure plugins created as QGraphicsWidget are
accessible through JavaScript.
* WebCoreSupport/FrameLoaderClientQt.cpp:
* tests/qwebpage/tst_qwebpage.cpp:
(PluginPage::createPlugin):
(tst_QWebPage::graphicsWidgetPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 3 Jan 2011 18:55:03 +0000 (18:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51328
Reviewed by Simon Fraser.
WebCore:
Printing on a page with body { height: 100% } clips out the overflow contents. This happened
because the computePageRects function was never correct. It was using the layer's width and height
for the document's width and height, and the layer no longer includes overflow in its width and
height. It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
assumption in RTL or vertical text environments.
Added printing/page-count-percentage-height.html
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
LayoutTests:
Add layout test for printing clipping bug.
* printing/page-count-percentage-height-expected.txt: Added.
* printing/page-count-percentage-height.html: Added.
* printing/script-tests/page-count-percentage-height.js: Added.
(test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Jan 2011 18:41:23 +0000 (18:41 +0000)]
Unreviewed, rolling out unnecessary r74905.
[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 3 Jan 2011 18:40:55 +0000 (18:40 +0000)]
Make run-api-tests less chatty.
https://bugs.webkit.org/show_bug.cgi?id=51831
Reviewed by Anders Carlsson.
- Make script quiet by default and add --verbose option (replacing --quiet).
- When not verbose, pipe stdout and stderr to devnull.
* Scripts/run-api-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Jan 2011 18:33:42 +0000 (18:33 +0000)]
Unreviewed fix.
[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829
* platform/qt/Skipped: http/tests/misc/401-alternative-content.php added until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 18:29:00 +0000 (18:29 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Fix duplicate expectation.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 3 Jan 2011 18:26:12 +0000 (18:26 +0000)]
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Disable superfluous GNU make built-in implicit rules
https://bugs.webkit.org/show_bug.cgi?id=51826
GNU make ships some superflous built-in rules that we never use
and that end up adding up to a very significant portion of our
total Makefile processing time. Disable them completely by
defining the rule without any recipe, as suggested by the GNU make
manual (10.5.6, Cancelling Implicit Rules).
In my system the null-build goes from:
make 43.51s user 12.77s system 99% cpu 56.628 total
to:
make 31.45s user 11.59s system 99% cpu 43.227 total
* GNUmakefile.am: disable implicit built-in rules.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Mon, 3 Jan 2011 18:24:54 +0000 (18:24 +0000)]
2011-01-03 Pratik Solanki <psolanki@apple.com>
Unreviewed. Adding myself to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 3 Jan 2011 18:12:54 +0000 (18:12 +0000)]
2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix.
[Qt] Add back auth.html to the skipped list after r74896.
* platform/qt/Skipped:
Add http/tests/appcache/auth.html to the list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Jan 2011 18:10:40 +0000 (18:10 +0000)]
[Qt] Unreviewed buildfix for --minimal build after r74895.
* html/InputType.cpp: Missing include added.
* html/NumberInputType.cpp: Missing include added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 3 Jan 2011 17:59:48 +0000 (17:59 +0000)]
2011-01-03 Daniel Bates <dbates@rim.com>
Attempt to fix the Chromium Linux Release build after changeset 74895 <http://trac.webkit.org/changeset/74895>.
The portion of the patch in <https://bugs.webkit.org/show_bug.cgi?id=51791> that modified the
file src/WebSearchableFormData.cpp was not landed (why?). Although the change log entry
associated with this change was landed.
* src/WebSearchableFormData.cpp:
(HTMLNames::IsInDefaultState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 17:53:07 +0000 (17:53 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Update .gitignore with new JavaScriptCore location.
* .gitignore:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 17:48:37 +0000 (17:48 +0000)]
2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by David Levin.
[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819
* platform/qt/Skipped: Remove passing HTTP tests.
Keep timer-vs-loading.html as it is still failing.
* platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt:
Match the expected results with chromium to pass the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 3 Jan 2011 17:26:17 +0000 (17:26 +0000)]
2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by David Levin.
[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819
* platform/qt/Skipped: Remove passing HTTP tests.
Keep timer-vs-loading.html as it is still failing.
* platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt:
Match the expected results with chromium to pass the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 3 Jan 2011 17:21:43 +0000 (17:21 +0000)]
2011-01-02 Darin Adler <darin@apple.com>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
* src/WebSearchableFormData.cpp:
(HTMLNames::IsInDefaultState): Use hasAttribute(checkedAttr)
to find out whether a button should be checked by default,
rather than calling the defaultChecked function.
2011-01-02 Darin Adler <darin@apple.com>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
* dom/InputElement.h: Make sanitizeValueForTextField public so it can
be called by InputType.
* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::accessKeyAction): Added.
(WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
* html/BaseButtonInputType.h: Ditto.
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::canSetStringValue): Added.
(WebCore::BaseCheckableInputType::accessKeyAction): Added.
(WebCore::BaseCheckableInputType::fallbackValue): Added.
(WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
(WebCore::BaseCheckableInputType::isCheckable): Added.
* html/BaseCheckableInputType.h: Ditto.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
* html/BaseDateAndTimeInputType.h: Ditto.
* html/BaseTextInputType.h: Made more functions private.
* html/ButtonInputType.cpp:
(WebCore::ButtonInputType::isTextButton): Added.
* html/ButtonInputType.h: Ditto.
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick): Added.
(WebCore::CheckboxInputType::didDispatchClick): Added.
(WebCore::CheckboxInputType::isCheckbox): Added.
* html/CheckboxInputType.h: Ditto.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
typo in name of this function.
* html/DateTimeInputType.h: Ditto.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
* html/DateTimeLocalInputType.h: Ditto.
* html/EmailInputType.cpp:
(WebCore::EmailInputType::isEmailField): Added.
* html/EmailInputType.h: Ditto.
* html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType): Added.
(WebCore::FileInputType::canSetStringValue): Added.
(WebCore::FileInputType::canChangeFromAnotherType): Added.
(WebCore::FileInputType::files): Added.
(WebCore::FileInputType::canSetValue): Added.
(WebCore::FileInputType::getTypeSpecificValue): Added.
(WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
(WebCore::FileInputType::setFileList): Added.
(WebCore::FileInputType::isFileUpload): Added.
* html/FileInputType.h: Ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
renaming and removal.
(WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
instead of checking specific type numbers.
(WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
Use fastGetAttribute and fixed typo in the name of the
scaledStepValueShouldBeInteger function.
(WebCore::HTMLInputElement::isKeyboardFocusable): Call
InputType::isKeyboardFocusable; moved most of the type-specific
logic there.
(WebCore::HTMLInputElement::shouldUseInputMethod): Call
InputType::shouldUseInputMethod; moved the type-specific logic there.
(WebCore::HTMLInputElement::handleBlurEvent): Call
InputType::handleBlurEvent; moved the type-specific logic there.
(WebCore::HTMLInputElement::setType): Tweak the names and types
in this function.
(WebCore::HTMLInputElement::updateType): Removed the code that
set m_deprecatedTypeNumber. Compare types by comparing the value
from formControlType. Removed file-specific logic and instead call
InputType::canChangeFromAnotherType. Streamlined the logic for
activation callbacks.
(WebCore::HTMLInputElement::accessKeyAction): Call
InputType::accessKeyAction; moved the type-specific logic there.
(WebCore::HTMLInputElement::mapToEntry): Call
InputType::shouldRespectHeightAndWidthAttributes and
InputType::shouldRespectAlignAttribute.
(WebCore::HTMLInputElement::parseMappedAttribute): Updated
for name changes and the removal of m_defaultChecked. Changed the
alt attribute logic to be based on the class of the renderer.
Call InputType::srcAttributeChanged and moved the type-specific
logic there. Call shouldRespectAlignAttribute and
shouldRespectHeightAndWidthAttributes rather than having
type-specific logic here. Call minOrMaxAttributeChanged.
(WebCore::HTMLInputElement::rendererIsNeeded): Call
InputType::rendererIsNeeded; moved the type-specific logic there.
(WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
flag, which was redundant with the m_haveType flag. Call
InputType::attach; moved the type-specific logic there.
(WebCore::HTMLInputElement::altText): Use fastGetAttribute.
(WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
InputType::canBeSuccessfulSubmitButton; moved the type-specific
logic there.
(WebCore::HTMLInputElement::isActivatedSubmit): Updated for
name changes.
(WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
(WebCore::HTMLInputElement::reset): Updated to use
InputType::storesValueSeparateFromAttribute. Also use
hasAttribute(checkedAttr) rather than m_defaultChecked,
since both are the same. Also updated for name change.
(WebCore::HTMLInputElement::setChecked): Updated for name
changes. Also added call to
InputType::shouldSendChangeEventAfterCheckedChanged and
moved the type-specific logic there.
(WebCore::HTMLInputElement::setIndeterminate): Call
isCheckable to see if indeterminate is allowed.
Also updated for name changes.
(WebCore::HTMLInputElement::copyNonAttributeProperties):
Updated for name changes and removed data members.
(WebCore::HTMLInputElement::value): Call
InputType::getTypeSpecificValue and InputType::fallbackValue.
Moved the type-specific logic there.
(WebCore::HTMLInputElement::valueWithDefault): Call
InputType::defaultValue. Moved the type-specific logic there.
(WebCore::HTMLInputElement::setSuggestedValue): Call
InputType::canSetSuggestedValue. Moved the type-specific logic
there.
(WebCore::HTMLInputElement::setValue): Call
InputType::canSetValue. Moved the type-specific logic there.
Clear the file list if it exists rather than checking the
type explicitly. We could probably do that a more elegant way.
(WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
(WebCore::HTMLInputElement::setValueFromRenderer): Use the
isFileUpload function in the assertion.
(WebCore::HTMLInputElement::setFileListFromRenderer): Put most
of the code from this function into FileInputType::setFileList.
(WebCore::HTMLInputElement::preDispatchEventHandler): Changed
to call InputType::willDispatchClick, which does the type-specific
work. Still need to use a single struct for all types, because
the type of the element could change during the event handling.
(WebCore::HTMLInputElement::postDispatchEventHandler): Changed
to call InputType::didDispatchClick.
(WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
(WebCore::HTMLInputElement::accept): Use fastGetAttribute.
(WebCore::HTMLInputElement::alt): Use fastGetAttribute.
(WebCore::HTMLInputElement::src): Use fastGetAttribute.
(WebCore::HTMLInputElement::setAutofilled): Updated for name
changes.
(WebCore::HTMLInputElement::files): Use InputType::files.
(WebCore::HTMLInputElement::isAcceptableValue): Use
InputType::isAcceptableValue.
(WebCore::HTMLInputElement::sanitizeValue): Use
InputType::sanitizeValue.
(WebCore::HTMLInputElement::hasUnacceptableValue): Use
InputType::hasUnacceptableValue.
(WebCore::HTMLInputElement::needsActivationCallback): Use
InputType::shouldResetOnDocumentActivation.
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
InputType::willMoveToNewOwnerDocument.
(WebCore::HTMLInputElement::dataList): Use
InputType::shouldRespectListAttribute.
(WebCore::HTMLInputElement::selectedOption): Tweaked logic
and naming a bit.
(WebCore::HTMLInputElement::stepUpFromRenderer): Use
fastGetAttribute.
(WebCore::HTMLInputElement::isSpeechEnabled): Use
InputType::shouldRespectSpeechAttribute.
(WebCore::HTMLInputElement::isTextButton): No longer inline.
Calls through to InputType.
(WebCore::HTMLInputElement::isRadioButton): Ditto.
(WebCore::HTMLInputElement::isSearchField): Ditto.
(WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
(WebCore::HTMLInputElement::isPasswordField): Ditto.
(WebCore::HTMLInputElement::isCheckbox): Ditto.
(WebCore::HTMLInputElement::isText): Ditto.
(WebCore::HTMLInputElement::isEmailField): Ditto.
(WebCore::HTMLInputElement::isFileUpload): Ditto.
(WebCore::HTMLInputElement::isImageButton): Ditto.
(WebCore::HTMLInputElement::isNumberField): Ditto.
(WebCore::HTMLInputElement::isSubmitButton): Ditto.
(WebCore::HTMLInputElement::isTelephoneField): Ditto.
(WebCore::HTMLInputElement::isURLField): Ditto.
(WebCore::HTMLInputElement::isEnumeratable): Ditto.
(WebCore::HTMLInputElement::isChecked): No longer inline.
Calls InputType::isCheckable.
(WebCore::HTMLInputElement::hasSpinButton): No longer inline.
Calls through to InputType.
(WebCore::HTMLInputElement::supportsPlaceholder): No longer
inline. Calls isTextType as before, but with no special case
for ISINDEX. That special case was unneeded since it returns
true from isTextType.
(WebCore::HTMLInputElement::checkedRadioButtons): No longer
inline.
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
No longer inline.
* html/HTMLInputElement.h: Removed multiple unneeded includes.
The big one is probably InputType.h, but also HTMLFormElement.h.
Removed unneeded forward declarations. Made many functions
no longer inline since they now need to make virtual function
dispatches. Removed the unneeded defaultChecked and
webkitdirectory functions. Both are handled by HTML attribute
reflection for DOM bindings, and the callers instead can get
at the attribute. Made updateCheckedRadioButtons public so it
can be called by an InputType class. Removed
DeprecatedInputType, InputTypeMap, createTypeMap,
deprecatedInputType, allowsIndeterminate,
respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
m_imageLoader, m_fileList, m_deprecatedTypeNumber,
m_defaultChecked, and m_inited. Renamed m_checked to
m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
m_isAutofilled.
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::accessKeyAction): Added.
(WebCore::HiddenInputType::rendererIsNeeded) Added.:
(WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
(WebCore::HiddenInputType::isHiddenType): Added.
(WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
* html/HiddenInputType.h: Ditto.
* html/ImageInputType.cpp:
(WebCore::ImageInputType::ImageInputType): Moved out of the header file.
(WebCore::ImageInputType::srcAttributeChanged): Added.
(WebCore::ImageInputType::attach): Added.
(WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
(WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
(WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
(WebCore::ImageInputType::isImageButton): Added.
(WebCore::ImageInputType::isEnumeratable): Added.
(WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
* html/ImageInputType.h: Ditto.
* html/InputType.cpp:
(WebCore::InputType::create): Changed argument type to String. There
is no value in taking an AtomicString here.
(WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
this function name.
(WebCore::InputType::canSetStringValue): Added.
(WebCore::InputType::isKeyboardFocusable): Added.
(WebCore::InputType::shouldUseInputMethod): Added.
(WebCore::InputType::handleBlurEvent): Added.
(WebCore::InputType::accessKeyAction): Added.
(WebCore::InputType::attach): Added.
(WebCore::InputType::srcAttributeChanged): Added.
(WebCore::InputType::willMoveToNewOwnerDocument): Added.
(WebCore::InputType::shouldRespectAlignAttribute): Added.
(WebCore::InputType::canChangeFromAnotherType): Added.
(WebCore::InputType::minOrMaxAttributeChanged): Added.
(WebCore::InputType::canBeSuccessfulSubmitButton): Added.
(WebCore::InputType::rendererIsNeeded): Added.
(WebCore::InputType::files): Added.
(WebCore::InputType::getTypeSpecificValue): Added.
(WebCore::InputType::fallbackValue): Added.
(WebCore::InputType::defaultValue): Added.
(WebCore::InputType::canSetSuggestedValue): Added.
(WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
(WebCore::InputType::storesValueSeparateFromAttribute): Added.
(WebCore::InputType::canSetValue): Added.
(WebCore::InputType::willDispatchClick): Added.
(WebCore::InputType::didDispatchClick): Added.
(WebCore::InputType::isAcceptableValue): Added.
(WebCore::InputType::sanitizeValue): Added.
(WebCore::InputType::hasUnacceptableValue): Added.
(WebCore::InputType::setFileList): Added.
(WebCore::InputType::shouldResetOnDocumentActivation): Added.
(WebCore::InputType::shouldRespectListAttribute): Added.
(WebCore::InputType::shouldRespectSpeechAttribute): Added.
(WebCore::InputType::isTextButton): Added.
(WebCore::InputType::isRadioButton): Added.
(WebCore::InputType::isSearchField): Added.
(WebCore::InputType::isHiddenType): Added.
(WebCore::InputType::isPasswordField): Added.
(WebCore::InputType::isCheckbox): Added.
(WebCore::InputType::isEmailField): Added.
(WebCore::InputType::isFileUpload): Added.
(WebCore::InputType::isImageButton): Added.
(WebCore::InputType::isNumberField): Added.
(WebCore::InputType::isSubmitButton): Added.
(WebCore::InputType::isTelephoneField): Added.
(WebCore::InputType::isURLField): Added.
(WebCore::InputType::isEnumeratable): Added.
(WebCore::InputType::isCheckable): Added.
(WebCore::InputType::hasSpinButton): Added.
(WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
* html/InputType.h: Removed unneeded ExceptionCode.h include and
used a typedef instead as we do when we want for forward declare it.
Added includes and forward declarations needed for new functions.
Added ClickHandlingState structure. Changed the argument to create
to a String rather than AtomicString. Added many virtual functions.
* html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
* html/IsIndexInputType.h: Ditto.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::handleBlurEvent): Added.
(WebCore::NumberInputType::isAcceptableValue): Added.
(WebCore::NumberInputType::sanitizeValue): Added.
(WebCore::NumberInputType::hasUnacceptableValue): Added.
(WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
(WebCore::NumberInputType::isNumberField): Added.
(WebCore::NumberInputType::hasSpinButton): Added.
* html/NumberInputType.h: Ditto.
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::shouldUseInputMethod): Added.
(WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
(WebCore::PasswordInputType::shouldRespectListAttribute): Added.
(WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
(WebCore::PasswordInputType::isPasswordField): Added.
* html/PasswordInputType.h: Ditto.
* html/RadioInputType.cpp:
(WebCore::RadioInputType::isKeyboardFocusable): Added.
(WebCore::RadioInputType::attach): Added.
(WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
(WebCore::RadioInputType::willDispatchClick): Added.
(WebCore::RadioInputType::didDispatchClick): Added.
(WebCore::RadioInputType::isRadioButton): Added.
* html/RadioInputType.h: Ditto.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::accessKeyAction): Added.
(WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
(WebCore::RangeInputType::fallbackValue): Added.
(WebCore::RangeInputType::sanitizeValue): Added.
(WebCore::RangeInputType::shouldRespectListAttribute): Added.
* html/RangeInputType.h: Ditto.
* html/ResetInputType.cpp:
(WebCore::ResetInputType::defaultValue): Added.
(WebCore::ResetInputType::isTextButton): Added.
* html/ResetInputType.h: Ditto.
* html/SearchInputType.cpp:
(WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
(WebCore::SearchInputType::isSearchField): Added.
* html/SearchInputType.h: Ditto.
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
(WebCore::SubmitInputType::defaultValue): Added.
(WebCore::SubmitInputType::isSubmitButton): Added.
(WebCore::SubmitInputType::isTextButton): Added.
* html/SubmitInputType.h: Ditto.
* html/TelephoneInputType.cpp:
(WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
(WebCore::TelephoneInputType::isTelephoneField): Added.
* html/TelephoneInputType.h: Ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldUseInputMethod): Added.
(WebCore::TextFieldInputType::sanitizeValue): Added.
(WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
* html/TextFieldInputType.h: Ditto.
* html/TextInputType.cpp:
(WebCore::TextInputType::canSetSuggestedValue): Added.
(WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
* html/TextInputType.h: Ditto.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
typo in the name of this function.
* html/TimeInputType.h: Ditto.
* html/URLInputType.cpp:
(WebCore::URLInputType::isURLField): Added.
* html/URLInputType.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Mon, 3 Jan 2011 17:11:50 +0000 (17:11 +0000)]
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Update expectations after r74892. A bunch of previously failing tests
now pass (since they match scrollbars with the mac port). Some tests
also started to fail, they should be fixed by removing their
chromium-mac baselines.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc