WebKit-https.git
9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81705
commit-queue@webkit.org [Wed, 21 Mar 2012 11:21:24 +0000 (11:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81705
REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-21
Reviewed by Csaba Osztrogon√°c.

Source/WebCore:

No new tests.

* bindings/js/JSDOMBinding.h: Needs passing globalObject to constructArray().
(WebCore::jsArray):

LayoutTests:

* platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Reverting test as it passes now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r111477.
kkristof@inf.u-szeged.hu [Wed, 21 Mar 2012 10:16:50 +0000 (10:16 +0000)]
[Qt] Unreviewed gardening after r111477.
https://bugs.webkit.org/show_bug.cgi?id=81697
modified:   LayoutTests/ChangeLog
modified:   LayoutTests/platform/qt/Skipped

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstreaming blackberry specific css file
commit-queue@webkit.org [Wed, 21 Mar 2012 10:09:33 +0000 (10:09 +0000)]
[BlackBerry] Upstreaming blackberry specific css file
https://bugs.webkit.org/show_bug.cgi?id=81650

Ustream BlackBerry specific css files, including:
css/themeBlackBerry.css
css/mediaControlsBlackBerry.css

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-21
Reviewed by Nikolas Zimmermann.

No new tests, this is the initial upstream patch
for BlackBerry specific css files.

* css/mediaControlsBlackBerry.css: Added.
(audio):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
* css/themeBlackBerry.css: Added.
(textarea):
(input, textarea):
(input[type="color"]):
(select:focus):
(select[size][multiple]):
(select[size][multiple]:focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove Android build-fix when the proper fix rolled into WebKit
peter@chromium.org [Wed, 21 Mar 2012 10:05:57 +0000 (10:05 +0000)]
[Chromium] Remove Android build-fix when the proper fix rolled into WebKit
https://bugs.webkit.org/show_bug.cgi?id=80861

Reviewed by Tony Chang.

Source/WebKit/chromium:

No longer set the CC.target environment variable as this is no longer
required for project file generation.

* gyp_webkit:

Tools:

Remove most Android-specific logic from webkitdirs.pm in favor of
handling this during project generation time.

* Scripts/webkitdirs.pm:
(buildChromiumMakefile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Wed, 21 Mar 2012 10:00:51 +0000 (10:00 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate LayoutUnit usage in descendants of RenderReplaced
leviw@chromium.org [Wed, 21 Mar 2012 09:32:01 +0000 (09:32 +0000)]
Update LayoutUnit usage in descendants of RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=80918

Reviewed by Eric Seidel.

Replaced elements have to flow in the new sub-pixel Render Tree, but since the rendering of these
often takes place outside of WebCore (or in cases such as foreign objects, in WebCore after
passing through platform code), care must be taken to determine the final rendered size and
location before render time. This patch brings these classes up to the latest and greatest in the
subpixellayout branch.

See https://trac.webkit.org/wiki/LayoutUnit for more information.

No new tests. No change in behavior.

* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening): Build Fix.
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::createPlaceholder): Ditto.
* rendering/RenderFullScreen.h:
(RenderFullScreen): Ditto.
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged): Ditto.
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::computeLogicalHeight): Ditto.
(WebCore::RenderIFrame::computeLogicalWidth): Ditto.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Intrinsic sizes are always integers, since they
originate outside of WebCore.
(WebCore::RenderImage::paintIntoRect): Use pixel snapping to paint into an arbitrary rect.
(WebCore::RenderImage::computeReplacedLogicalWidth): Intrinsic size is always integral -- rounding
values to integers.
* rendering/RenderImage.h:
(RenderImage):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoBox):
(WebCore::RenderVideo::paintReplaced): Painting at integer boundaries.
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::roundedIntRect): Widgets are rendered outside of WebCore, so we always align them to
integer boundaries. This means we can actually round the size of our ultimate content box. This
function is implemented here specifically to prevent its misuse if we put it elsewhere.
(WebCore::RenderWidget::setWidgetGeometry): We simplify layout by taking a LayoutRect and rounding
it to its final location within this function.
(WebCore::RenderWidget::updateWidgetGeometry): We keep things in LayoutUnits until handing off to
setWidgetGeometry.
(WebCore::RenderWidget::paint): Rounding the paint location before handing painting off to the
widget itself.
* rendering/RenderWidget.h:
(RenderWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/css/resize-single-axis.html timeout
ossy@webkit.org [Wed, 21 Mar 2012 09:24:39 +0000 (09:24 +0000)]
[Qt] fast/css/resize-single-axis.html timeout
https://bugs.webkit.org/show_bug.cgi?id=80604

* platform/qt/Skipped: Unskip fast/css/resize-single-axis.html, because it works now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r111500 and skipping 2 tests.
philn@webkit.org [Wed, 21 Mar 2012 09:17:04 +0000 (09:17 +0000)]
Unreviewed, GTK rebaseline after r111500 and skipping 2 tests.

* platform/gtk/Skipped:
* platform/gtk/fast/css/text-transform-select-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: HeapProfiler: support distance column in Summary View.
loislo@chromium.org [Wed, 21 Mar 2012 09:14:01 +0000 (09:14 +0000)]
Web Inspector: HeapProfiler: support distance column in Summary View.
https://bugs.webkit.org/show_bug.cgi?id=81675

In many cases when a page leaked an object we see not only this object
but the all objects it retains. It is quite difficult to find out which
the object is the root of leak. It'd be simpler to sort the leaked
objects by Distance column and track down the first one.

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

LayoutTests:

* inspector/profiler/detailed-heapshots-summary-sorting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Allow running javascript from location bar in MiniBrowser
carlosgc@webkit.org [Wed, 21 Mar 2012 08:56:53 +0000 (08:56 +0000)]
[GTK] Allow running javascript from location bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=81331

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback): Use browser_window_load_uri().
(browser_window_load_uri): Check whether uri starts with
javascript: and run the given script, or just call
webkit_web_view_load_uri() to load the given uri.
* MiniBrowser/gtk/BrowserWindow.h:
* MiniBrowser/gtk/main.c:
(createBrowserWindow): Use browser_window_load_uri().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
carlosgc@webkit.org [Wed, 21 Mar 2012 08:44:23 +0000 (08:44 +0000)]
[GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=75543

Reviewed by Martin Robinson.

Source/WebKit2:

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitError.cpp:
(webkit_javascript_error_quark): Add new error domain for
Javascript errors.
* UIProcess/API/gtk/WebKitError.h:
* UIProcess/API/gtk/WebKitJavascriptResult.cpp: Added.
(webkitJavascriptResultCreate): Create a WebKitJavascriptResult
for the given WKSerializedScriptValueRef.
(webkit_javascript_result_ref): Increment reference count of
WebKitJavascriptResult.
(webkit_javascript_result_unref): Decrement reference count of
WebKitJavascriptResult.
(webkit_javascript_result_get_global_context): Get global
javascript context of the result.
(webkit_javascript_result_get_value): Get the JSValueRef of the
result.
* UIProcess/API/gtk/WebKitJavascriptResult.h: Added.
* UIProcess/API/gtk/WebKitJavascriptResultPrivate.h: Added.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewFinalize): Release the global javascript context.
(webkit_web_view_get_javascript_global_context): Get or create the
global javascript context.
(webkitWebViewRunJavaScriptCallback): Callback called by C API when
javascript execution finishes.
(webkit_web_view_run_javascript): Asynchronously run a given
javascript.
(webkit_web_view_run_javascript_finish): Finish async operation
started by webkit_web_view_run_javascript().
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_javascript_result_get_type().
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewRunJavaScript):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest):
(WebViewTest::~WebViewTest):
(runJavaScriptReadyCallback):
(WebViewTest::runJavaScriptAndWaitUntilFinished):
(jsValueToCString):
(WebViewTest::javascriptResultToCString):
(WebViewTest::javascriptResultToNumber):
(WebViewTest::javascriptResultToBoolean):
(WebViewTest::javascriptResultIsNull):
(WebViewTest::javascriptResultIsUndefined):
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2.h:

Tools:

* MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
MiniBrowser CPP flags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking lost-compositor-context-permanently.html on WIN as flaky.
keishi@webkit.org [Wed, 21 Mar 2012 08:24:18 +0000 (08:24 +0000)]
[chromium] Marking lost-compositor-context-permanently.html on WIN as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated Mac expected results for this test. <http://webkit.org/b/81746> tracks the...
mitz@apple.com [Wed, 21 Mar 2012 08:03:47 +0000 (08:03 +0000)]
Updated Mac expected results for this test. <webkit.org/b/81746> tracks the fact that
r111500 broke it.

* platform/mac/fast/css/text-transform-select-expected.png:
* platform/mac/fast/css/text-transform-select-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove redundant code in SocketStreamHandler
charles.wei@torchmobile.com.cn [Wed, 21 Mar 2012 07:29:59 +0000 (07:29 +0000)]
[BlackBerry] Remove redundant code in SocketStreamHandler
https://bugs.webkit.org/show_bug.cgi?id=81726

Reviewed by George Staikos.

No new tests needed. Just remove redundant code.

* platform/network/blackberry/SocketStreamHandle.h:
(SocketStreamHandle):
* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline tests after r111497.
keishi@webkit.org [Wed, 21 Mar 2012 07:26:34 +0000 (07:26 +0000)]
[chromium] Rebaseline tests after r111497.

* platform/chromium-mac-leopard/fast/css/text-transform-select-expected.png:
* platform/chromium-mac-leopard/fast/forms/select/menulist-disabled-option-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.png:
* platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-max-length-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select/menulist-disabled-option-expected.png: Added.
* platform/chromium-mac/fast/css/text-transform-select-expected.png:
* platform/chromium-mac/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium-mac/fast/forms/select/menulist-disabled-option-expected.png: Added.
* platform/chromium-win-xp/fast/forms/select-max-length-expected.txt: Added.
* platform/chromium-win/fast/css/text-transform-select-expected.png:
* platform/chromium-win/fast/css/text-transform-select-expected.txt:
* platform/chromium-win/fast/forms/select/menulist-disabled-option-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename getElementInShadowTreeStack to getNodeInShadowTreeStack
commit-queue@webkit.org [Wed, 21 Mar 2012 07:06:04 +0000 (07:06 +0000)]
Rename getElementInShadowTreeStack to getNodeInShadowTreeStack
https://bugs.webkit.org/show_bug.cgi?id=81324

Since getElementInShadowTreeStack returns ShadowRoot as well which is not an element
it should be renamed to getNodeInShadowTreeStack.

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-21
Reviewed by Hajime Morita.

* fast/dom/shadow/access-key.html:
* fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
* fast/dom/shadow/get-element-by-id-in-shadow-root.html:
* fast/dom/shadow/resources/shadow-dom.js:
(getNodeInShadowTreeStack):
* fast/dom/shadow/shadow-boundary-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
eric@webkit.org [Wed, 21 Mar 2012 05:50:30 +0000 (05:50 +0000)]
Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
https://bugs.webkit.org/show_bug.cgi?id=80911

Reviewed by Adam Barth.

.:

* CMakeLists.txt: Define WTF_DIR

Source/JavaScriptCore:

Update the various build systems to depend on Source/WTF headers
as well as remove references to Platform.h (since it's now moved).

* CMakeLists.txt:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:
 - Look for headers in Source/WTF as well.

Source/WebKit:

* CMakeLists.txt: Look for headers in Source/WTF.

Source/WebKit/qt:

Fix WTF header include paths since although
Source/WTF is included, no longer are all the
subdirectories (thus "RefPtr.h" can't work).

* Api/qwebdatabase_p.h:
* Api/qwebscriptworld_p.h:
* Api/qwebsecurityorigin_p.h:
* WebCoreSupport/InspectorClientQt.h:
* WebCoreSupport/QtFallbackWebPopup.h:
* WebCoreSupport/QtWebComboBox.h:
* declarative/experimental/experimental.pri:
* declarative/public.pri:
* tests/MIMESniffing/MIMESniffing.pro:

Source/WebKit2:

Update to not depend on "Foo.h" includes for WTF headers.

* Shared/qt/QtNetworkReplyData.h:
* Shared/qt/QtNetworkRequestData.cpp:
* Shared/qt/QtNetworkRequestData.h:

Source/WTF:

Update build systems to account for the new location of Platform.h

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.vcproj/work-around-vs-dependency-tracking-bugs.py:
(react_to_vsprops_changes):
* WTF.xcodeproj/project.pbxproj:
* config.h: I don't think this change is 100% correct (but seemed to be needed to make qt-wk2 build)
 - This dependency on JSC should be removed regardless (in a later patch).
* wtf/Platform.h: Renamed from Source/JavaScriptCore/wtf/Platform.h.

Tools:

Update include paths for Source/WTF.

* DumpRenderTree/efl/CMakeLists.txt:
* DumpRenderTree/qt/DumpRenderTree.pro:
* QtTestBrowser/QtTestBrowser.pro:
* Scripts/build-webkit: Build Source/WTF on AppleWin as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosvn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
abarth@webkit.org [Wed, 21 Mar 2012 05:45:06 +0000 (05:45 +0000)]
svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
https://bugs.webkit.org/show_bug.cgi?id=81567

Reviewed by Eric Seidel.

This temporary measure should help us avoid disrupting the folks
working on WebAudio when we move the webaudio directory to Modules.

* Scripts/VCSUtils.pm:
(adjustPathForRecentRenamings):
(parseGitDiffHeader):
(parseSvnDiffHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use origin transform to transform occlusion from surface content space...
commit-queue@webkit.org [Wed, 21 Mar 2012 05:29:01 +0000 (05:29 +0000)]
[chromium] Use origin transform to transform occlusion from surface content space to its target content space
https://bugs.webkit.org/show_bug.cgi?id=81730

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding MISSING to platform/qt for platform/qt/plugins/application-plugin-plugins...
keishi@webkit.org [Wed, 21 Mar 2012 05:26:02 +0000 (05:26 +0000)]
Adding MISSING to platform/qt for platform/qt/plugins/application-plugin-plugins-disabled.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Crash] RenderMenuList::addChild() in Shadow DOM.
shinyak@chromium.org [Wed, 21 Mar 2012 05:12:51 +0000 (05:12 +0000)]
[Crash] RenderMenuList::addChild() in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=81201

Reviewed by Dimitri Glazkov.

Source/WebCore:

<audio>, <video>, <meter>, <progress>, and <select> are implemented using
Shadow DOM having HTMLContentElement. Their renderer children basically should not
create a renderer unless they are on the upper shadow encapsulation boundary,
which means they are the direct children of the shadow root.

However, current implementation allows their renderer children to create a renderer
even if they are on a lower shadow encapsulation boundary, which means
they are distributed elements of HTMLContentElement.

This patch makes there renderer children not to create a renderer if they are on a lower shadow
encapsulation boudary.

Tests: fast/dom/shadow/content-element-in-media-element.html
       fast/dom/shadow/content-element-in-meter-element.html
       fast/dom/shadow/content-element-in-progress-element.html
       fast/dom/shadow/content-element-in-select-element.html

* dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnUpperEncapsulationBoundary):
(WebCore):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::childShouldCreateRenderer):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::childShouldCreateRenderer):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):

LayoutTests:

Skipped these tests in non-chromium port since SHADOW_DOM flag is not enabled.

Marked 2 new tests FAIL. Their behavior is affected by this patch, but this patch
won't fix them completely. They have another bugs. See Bug 81310 and Bug 81311.

* fast/dom/shadow/content-element-in-media-element-expected.txt: Added.
* fast/dom/shadow/content-element-in-media-element.html: Added.
* fast/dom/shadow/content-element-in-meter-element-expected.txt: Added.
* fast/dom/shadow/content-element-in-meter-element.html: Added.
* fast/dom/shadow/content-element-in-progress-element-expected.txt: Added.
* fast/dom/shadow/content-element-in-progress-element.html: Added.
* fast/dom/shadow/content-element-in-select-element-expected.txt: Added.
* fast/dom/shadow/content-element-in-select-element.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Store origin/screen space transforms for surface and replica in the surface
commit-queue@webkit.org [Wed, 21 Mar 2012 05:02:57 +0000 (05:02 +0000)]
[chromium] Store origin/screen space transforms for surface and replica in the surface
https://bugs.webkit.org/show_bug.cgi?id=81296

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

Compute and save a number of transforms for render surfaces. The origin
tranform for the replica into its target surface. The origin transform
for the replica into the screen. And the origin transform for the surface
into the screen.

These transforms will allow us to detect occlusion of render surfaces,
allowing us to cull (or partially-cull) the render surface quad during
drawing.

This also fixes a subtle bug in the transforms used by the damage
tracking code.

Unit test: CCLayerTreeHostCommonTest.verifyTransformsForSingleRenderSurface
           CCLayerTreeHostCommonTest.verifyTransformsForReplica
           CCLayerTreeHostCommonTest.verifyTransformsForRenderSurfaceHierarchy

* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::damageInSurfaceSpace):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(CCRenderSurface):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipped editing/selection/move-by-word-visually-crash-test-5.html in WebKit2 because of
mitz@apple.com [Wed, 21 Mar 2012 04:47:56 +0000 (04:47 +0000)]
Skipped editing/selection/move-by-word-visually-crash-test-5.html in WebKit2 because of
<http://webkit.org/b/42689> WebKitTestRunner needs layoutTestController.setEditingBehavior

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] The option element should not be form associated element.
commit-queue@webkit.org [Wed, 21 Mar 2012 04:46:00 +0000 (04:46 +0000)]
[Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-20
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLOptionELement to HTMLElement
from HTMLFormControlElement for saving memory space and iteration
time of extra "option" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

This patch changes behavior of handling of CSS pseudo classes "invalid"
and "valid". The "option" elements no longer use these CSS pseudo classes
as HTML5 specification. This bug was filed in https://bugs.webkit.org/show_bug.cgi?id=80088

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests but updated select-live-pseudo-selectors.html test.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Added checking of the "option" element and returns false as HTMLFormControlElement.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Removed isFormControlElement for PseudoDisabled and PseudoChecked.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): Removed form parameter of call site of HTMLOptionElement::create.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement): Removed form parameter which no longer needed. Changed base class in initialization list. Added m_disabled initialization.
(WebCore::HTMLOptionElement::create): Removed form parameter which no longer needed.
(WebCore::HTMLOptionElement::attach): Changeid base class.
(WebCore::HTMLOptionElement::detach): Changed base class.
(WebCore::HTMLOptionElement::parseAttribute): Changed base class. Added "disabled" attribute handling.
(WebCore::HTMLOptionElement::childrenChanged): Changed base class.
(WebCore::HTMLOptionElement::insertedIntoTree): Changed base class.
* html/HTMLOptionElement.h:
(HTMLOptionElement): Added new member variable m_disabled which was in HTMLFormControlElement.
(WebCore::HTMLOptionElement::ownElementDisabled): Changed for using m_disabled.
* html/HTMLTagNames.in: Removed constructorNeedsFormElement for the "option" element, which was used for passing form parameter to create function.

LayoutTests:

This patch fixes a bug in select-live-pseudo-selectors.js, adds
assertions to improve coverage, and updates test expectation for
behavior changes (makes the "option" element uses CSS pseudo class
":valid".)

* fast/forms/resources/select-live-pseudo-selectors.js:
(mouseDownOnSelect): Copied from listbox-selection.html for replacing broken simulateClick which used position and size of the "option" element, but these values are zero. Note: five files use mouseDownOnSelect. We'll share this function in future tracked by https://bugs.webkit.org/show_bug.cgi?id=81496.
(backgroundOf): Added String parameter support for ease of writing test case.
* fast/forms/select-live-pseudo-selectors-expected.txt: Added check fo background color of the "selection" element. Changed expected color of the "option" element because the "option" element doesn't support CSS pseudo class ":valid". This also covers bug 80088.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipped fast/selectors/selection-window-inactive.html in WebKit2 because of
mitz@apple.com [Wed, 21 Mar 2012 04:33:42 +0000 (04:33 +0000)]
Skipped fast/selectors/selection-window-inactive.html in WebKit2 because of
<http://webkit.org/b/81736> layoutTestController.setWindowIsKey() has no effect on the web process side in WebKit2

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipped fast/events/blur-focus-window-should-blur-focus-element.html in WebKit2 becau...
mitz@apple.com [Wed, 21 Mar 2012 04:23:35 +0000 (04:23 +0000)]
Skipped fast/events/blur-focus-window-should-blur-focus-element.html in WebKit2 because of
<http://webkit.org/b/81736> layoutTestController.setWindowIsKey() has no effect on the web process side in WebKit2

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking canvas-toDataURL-webp.html as crashing and timing out.
keishi@webkit.org [Wed, 21 Mar 2012 04:18:50 +0000 (04:18 +0000)]
[chromium] Marking canvas-toDataURL-webp.html as crashing and timing out.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r110780): Loading a PDF always makes the WKView layer backed
andersca@apple.com [Wed, 21 Mar 2012 04:01:54 +0000 (04:01 +0000)]
REGRESSION (r110780): Loading a PDF always makes the WKView layer backed
https://bugs.webkit.org/show_bug.cgi?id=81734
<rdar://problem/11088172>

Reviewed by Adele Peterson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]):
Don't call -[NSView setWantsLayer:], the web process already takes care of entering and exiting
accelerated compositing mode for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash introduced in r110965.
xji@chromium.org [Wed, 21 Mar 2012 03:56:05 +0000 (03:56 +0000)]
Crash introduced in r110965.
https://bugs.webkit.org/show_bug.cgi?id=81720

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since word break iterator just keeps a pointer to the UChar array given to the constructor,
we need to allocate the UChar array deeper in the stack than the iterator.

Test: editing/selection/move-by-word-visually-crash-test-5.html

* editing/visible_units.cpp:
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):

LayoutTests:

* editing/selection/move-by-word-visually-crash-test-5-expected.txt: Added.
* editing/selection/move-by-word-visually-crash-test-5.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking integer-division-neg2tothe32-by-neg1.html as crashing.
keishi@webkit.org [Wed, 21 Mar 2012 03:41:32 +0000 (03:41 +0000)]
[chromium] Marking integer-division-neg2tothe32-by-neg1.html as crashing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining font-family-pictograph.html on Mac.
keishi@webkit.org [Wed, 21 Mar 2012 02:31:47 +0000 (02:31 +0000)]
[chromium] Rebaselining font-family-pictograph.html on Mac.

* fast/css/font-family-pictograph-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.png.
* fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.txt.
* platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.txt.
* platform/gtk/fast/css/font-family-pictograph-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining for Linux 32.
keishi@webkit.org [Wed, 21 Mar 2012 02:28:55 +0000 (02:28 +0000)]
[chromium] Rebaselining for Linux 32.

* platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnskip the over one thousand dom/xhtml tests that pass
adamk@chromium.org [Wed, 21 Mar 2012 02:18:46 +0000 (02:18 +0000)]
Unskip the over one thousand dom/xhtml tests that pass
https://bugs.webkit.org/show_bug.cgi?id=81709

Reviewed by Tony Chang.

I recently ran into a case where a test in dom/xhtml caught a
regression in a patch (r111310). Seems like we should at least run
those tests that pass in this suite. I've left the other tests
skipped, though I'm open to rebaselining or running them with failing
expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control...
wjmaclean@chromium.org [Wed, 21 Mar 2012 02:06:12 +0000 (02:06 +0000)]
[chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape.
https://bugs.webkit.org/show_bug.cgi?id=81713

Reviewed by Dirk Pranke.

Source/WebCore:

Exisiting unit test revised to cover this change.

Change the fling gesture animation curve to use a 2-D Bezier to obtain greater control
over the shape of the curve. Also, change time scaling code to be logarithmic for more
natural feel.

* platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::apply):

Source/WebKit/chromium:

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoop_mod fails on many interesting corner cases
fpizlo@apple.com [Wed, 21 Mar 2012 01:29:28 +0000 (01:29 +0000)]
op_mod fails on many interesting corner cases
https://bugs.webkit.org/show_bug.cgi?id=81648

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Removed most strength reduction for op_mod, and fixed the integer handling
to do the right thing for corner cases. Oddly, this revealed bugs in OSR,
which this patch also fixes.

This patch is performance neutral on all of the major benchmarks we track.

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMod):
* jit/JIT.h:
(JIT):
* jit/JITArithmetic.cpp:
(JSC):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC):
* jit/JITStubs.h:
(TrampolineStructure):
(JSC::JITThunks::ctiNativeConstruct):
* llint/LowLevelInterpreter64.asm:
* wtf/Platform.h:
* wtf/SimpleStats.h:
(WTF::SimpleStats::variance):

LayoutTests:

Reviewed by Oliver Hunt.

* fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Added.
* fast/js/integer-division-neg2tothe32-by-neg1.html: Added.
* fast/js/script-tests/integer-division-neg2tothe32-by-neg1.js: Added.
(myDiv):
(myDivByNeg1):
(myDivNeg2ToThe31):
(myMod):
(myModByNeg1):
(myModNeg2ToThe31):
(myOtherDiv):
(myOtherDivByNeg1):
(myOtherDivNeg2ToThe31):
(myOtherMod):
(myOtherModByNeg1):
(myOtherModNeg2ToThe31):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInfinite repaint loop with SVGImageCache and deferred repaint timers
morrita@google.com [Wed, 21 Mar 2012 01:19:23 +0000 (01:19 +0000)]
Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Patch by Tim Horton <timothy_horton@apple.com> on 2012-03-18
Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):
* page/FrameView.h:
(FrameView):
(WebCore::FrameView::repaintsDisabled):
* rendering/RenderView.cpp:
(WebCore::RenderView::shouldRepaint):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):
* svg/graphics/SVGImage.h:
(WebCore):
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):
* svg/graphics/SVGImageCache.h:
(SVGImageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude fix for dom/xhtml test promised in r111449.
adamk@chromium.org [Wed, 21 Mar 2012 00:48:15 +0000 (00:48 +0000)]
Include fix for dom/xhtml test promised in r111449.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Check against next instead of
prev when deciding there's no work to do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Because we might short-circuit permission calls, some of these tests...
jonlee@apple.com [Wed, 21 Mar 2012 00:36:53 +0000 (00:36 +0000)]
Unreviewed. Because we might short-circuit permission calls, some of these tests need to be rewritten
to take that factor into account. There's no mac support of notifications right now (see 79492),
so updating test expectations for now and tracking as a regression in 81697.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestrict access to notifications for unique origins and file URLs with no local file...
jonlee@apple.com [Wed, 21 Mar 2012 00:34:59 +0000 (00:34 +0000)]
Restrict access to notifications for unique origins and file URLs with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704
<rdar://problem/10912430>

Reviewed by Adam Barth.

Source/WebCore:

Before checking or requesting permissions, we look at whether we can show notifications based on
the security context. If not, we short circuit and do not forward the request to the client.

* notifications/Notification.cpp:
(WebCore::Notification::Notification): Fix a bug where creating a notification goes through slightly
different logic for checking permissions than when checking permissions through the
notification center.
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::checkPermission): Check to see if the origin can show notifications.
(WebCore::NotificationCenter::requestPermission): If we know whether an origin can show notifications,
we asynchronously call the callback with that decision. Otherwise we ask the client.

Add new variable in the notification center to keep track of pending callbacks when we short-circuit
requestPermission().
* notifications/NotificationCenter.h:
(NotificationRequestCallback): Add new private class encapsulating the callback.
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::requestTimedOut): Remove the request from the set of pending callbacks.
(WebCore::NotificationCenter::NotificationRequest::createAndStartTimer): Because this is used when we already
know the decision, and are not asking the client to decide, we can immediately trigger a one-shot timer
to invoke the callback.
(WebCore::NotificationCenter::NotificationRequest::NotificationRequest):
(WebCore::NotificationCenter::NotificationRequest::startTimer):
(WebCore::NotificationCenter::NotificationRequest::timerFired): Invoke the callback and tell the notification
center.
* page/SecurityOrigin.h: Add new toRawString() method to return the string representation of the origin,
regardless of any restrictions that might otherwise cause toString() to return "null".
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canShowNotifications): Added to return a tri-state regarding whether we know
the origin can show notifications. If the origin is unique, we never let it show. If the origin has
universal access, we always let it show. Otherwise the client should be asked.
(WebCore::SecurityOrigin::toString): Refactor to use toRawString().
(WebCore::SecurityOrigin::toRawString):

Added FIXME's regarding the naming of enforceFilePathSeparation().
* dom/Document.cpp:
(WebCore::Document::initSecurityContext): Also, tab reformatting.

* WebCore.exp.in: Export toRawString().

Source/WebKit2:

In the specific case where a file URL has restricted file access and is denied universal access,
SecurityOrigin::canShowNotifications() returns Ask, since it is not considered a unique origin.
The cached table of permissions held by the notification manager will typically not have an entry for
the toString() representation of these file URLs, which is "null", since that can also cover unique
origins, and it is possible that the client will want different permissions between the two types.

It is reasonable, however, for there to be an entry for "file://", so we use toRawString() to do the lookup.

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::policyForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove webaudio to Modules/webaudio/
haraken@chromium.org [Wed, 21 Mar 2012 00:30:35 +0000 (00:30 +0000)]
Move webaudio to Modules/webaudio/
https://bugs.webkit.org/show_bug.cgi?id=81541

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/webaudio: Added.
* Modules/webaudio/AsyncAudioDecoder.cpp: Copied from Source/WebCore/webaudio/AsyncAudioDecoder.cpp.
* Modules/webaudio/AsyncAudioDecoder.h: Copied from Source/WebCore/webaudio/AsyncAudioDecoder.h.
* Modules/webaudio/AudioBasicProcessorNode.cpp: Copied from Source/WebCore/webaudio/AudioBasicProcessorNode.cpp.
* Modules/webaudio/AudioBasicProcessorNode.h: Copied from Source/WebCore/webaudio/AudioBasicProcessorNode.h.
* Modules/webaudio/AudioBuffer.cpp: Copied from Source/WebCore/webaudio/AudioBuffer.cpp.
* Modules/webaudio/AudioBuffer.h: Copied from Source/WebCore/webaudio/AudioBuffer.h.
* Modules/webaudio/AudioBuffer.idl: Copied from Source/WebCore/webaudio/AudioBuffer.idl.
* Modules/webaudio/AudioBufferCallback.h: Copied from Source/WebCore/webaudio/AudioBufferCallback.h.
* Modules/webaudio/AudioBufferCallback.idl: Copied from Source/WebCore/webaudio/AudioBufferCallback.idl.
* Modules/webaudio/AudioBufferSourceNode.cpp: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.cpp.
* Modules/webaudio/AudioBufferSourceNode.h: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.h.
* Modules/webaudio/AudioBufferSourceNode.idl: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.idl.
* Modules/webaudio/AudioChannelMerger.cpp: Copied from Source/WebCore/webaudio/AudioChannelMerger.cpp.
* Modules/webaudio/AudioChannelMerger.h: Copied from Source/WebCore/webaudio/AudioChannelMerger.h.
* Modules/webaudio/AudioChannelMerger.idl: Copied from Source/WebCore/webaudio/AudioChannelMerger.idl.
* Modules/webaudio/AudioChannelSplitter.cpp: Copied from Source/WebCore/webaudio/AudioChannelSplitter.cpp.
* Modules/webaudio/AudioChannelSplitter.h: Copied from Source/WebCore/webaudio/AudioChannelSplitter.h.
* Modules/webaudio/AudioChannelSplitter.idl: Copied from Source/WebCore/webaudio/AudioChannelSplitter.idl.
* Modules/webaudio/AudioContext.cpp: Copied from Source/WebCore/webaudio/AudioContext.cpp.
* Modules/webaudio/AudioContext.h: Copied from Source/WebCore/webaudio/AudioContext.h.
* Modules/webaudio/AudioContext.idl: Copied from Source/WebCore/webaudio/AudioContext.idl.
* Modules/webaudio/AudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/AudioDestinationNode.cpp.
* Modules/webaudio/AudioDestinationNode.h: Copied from Source/WebCore/webaudio/AudioDestinationNode.h.
* Modules/webaudio/AudioDestinationNode.idl: Copied from Source/WebCore/webaudio/AudioDestinationNode.idl.
* Modules/webaudio/AudioGain.h: Copied from Source/WebCore/webaudio/AudioGain.h.
* Modules/webaudio/AudioGain.idl: Copied from Source/WebCore/webaudio/AudioGain.idl.
* Modules/webaudio/AudioGainNode.cpp: Copied from Source/WebCore/webaudio/AudioGainNode.cpp.
* Modules/webaudio/AudioGainNode.h: Copied from Source/WebCore/webaudio/AudioGainNode.h.
* Modules/webaudio/AudioGainNode.idl: Copied from Source/WebCore/webaudio/AudioGainNode.idl.
* Modules/webaudio/AudioListener.cpp: Copied from Source/WebCore/webaudio/AudioListener.cpp.
* Modules/webaudio/AudioListener.h: Copied from Source/WebCore/webaudio/AudioListener.h.
* Modules/webaudio/AudioListener.idl: Copied from Source/WebCore/webaudio/AudioListener.idl.
* Modules/webaudio/AudioNode.cpp: Copied from Source/WebCore/webaudio/AudioNode.cpp.
* Modules/webaudio/AudioNode.h: Copied from Source/WebCore/webaudio/AudioNode.h.
* Modules/webaudio/AudioNode.idl: Copied from Source/WebCore/webaudio/AudioNode.idl.
* Modules/webaudio/AudioNodeInput.cpp: Copied from Source/WebCore/webaudio/AudioNodeInput.cpp.
* Modules/webaudio/AudioNodeInput.h: Copied from Source/WebCore/webaudio/AudioNodeInput.h.
* Modules/webaudio/AudioNodeOutput.cpp: Copied from Source/WebCore/webaudio/AudioNodeOutput.cpp.
* Modules/webaudio/AudioNodeOutput.h: Copied from Source/WebCore/webaudio/AudioNodeOutput.h.
* Modules/webaudio/AudioPannerNode.cpp: Copied from Source/WebCore/webaudio/AudioPannerNode.cpp.
* Modules/webaudio/AudioPannerNode.h: Copied from Source/WebCore/webaudio/AudioPannerNode.h.
* Modules/webaudio/AudioPannerNode.idl: Copied from Source/WebCore/webaudio/AudioPannerNode.idl.
* Modules/webaudio/AudioParam.cpp: Copied from Source/WebCore/webaudio/AudioParam.cpp.
* Modules/webaudio/AudioParam.h: Copied from Source/WebCore/webaudio/AudioParam.h.
* Modules/webaudio/AudioParam.idl: Copied from Source/WebCore/webaudio/AudioParam.idl.
* Modules/webaudio/AudioParamTimeline.cpp: Copied from Source/WebCore/webaudio/AudioParamTimeline.cpp.
* Modules/webaudio/AudioParamTimeline.h: Copied from Source/WebCore/webaudio/AudioParamTimeline.h.
* Modules/webaudio/AudioProcessingEvent.cpp: Copied from Source/WebCore/webaudio/AudioProcessingEvent.cpp.
* Modules/webaudio/AudioProcessingEvent.h: Copied from Source/WebCore/webaudio/AudioProcessingEvent.h.
* Modules/webaudio/AudioProcessingEvent.idl: Copied from Source/WebCore/webaudio/AudioProcessingEvent.idl.
* Modules/webaudio/AudioSourceNode.h: Copied from Source/WebCore/webaudio/AudioSourceNode.h.
* Modules/webaudio/AudioSourceNode.idl: Copied from Source/WebCore/webaudio/AudioSourceNode.idl.
* Modules/webaudio/BiquadDSPKernel.cpp: Copied from Source/WebCore/webaudio/BiquadDSPKernel.cpp.
* Modules/webaudio/BiquadDSPKernel.h: Copied from Source/WebCore/webaudio/BiquadDSPKernel.h.
* Modules/webaudio/BiquadFilterNode.cpp: Copied from Source/WebCore/webaudio/BiquadFilterNode.cpp.
* Modules/webaudio/BiquadFilterNode.h: Copied from Source/WebCore/webaudio/BiquadFilterNode.h.
* Modules/webaudio/BiquadFilterNode.idl: Copied from Source/WebCore/webaudio/BiquadFilterNode.idl.
* Modules/webaudio/BiquadProcessor.cpp: Copied from Source/WebCore/webaudio/BiquadProcessor.cpp.
* Modules/webaudio/BiquadProcessor.h: Copied from Source/WebCore/webaudio/BiquadProcessor.h.
* Modules/webaudio/ConvolverNode.cpp: Copied from Source/WebCore/webaudio/ConvolverNode.cpp.
* Modules/webaudio/ConvolverNode.h: Copied from Source/WebCore/webaudio/ConvolverNode.h.
* Modules/webaudio/ConvolverNode.idl: Copied from Source/WebCore/webaudio/ConvolverNode.idl.
* Modules/webaudio/DOMWindowWebAudio.idl: Copied from Source/WebCore/webaudio/DOMWindowWebAudio.idl.
* Modules/webaudio/DefaultAudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/DefaultAudioDestinationNode.cpp.
* Modules/webaudio/DefaultAudioDestinationNode.h: Copied from Source/WebCore/webaudio/DefaultAudioDestinationNode.h.
* Modules/webaudio/DelayDSPKernel.cpp: Copied from Source/WebCore/webaudio/DelayDSPKernel.cpp.
* Modules/webaudio/DelayDSPKernel.h: Copied from Source/WebCore/webaudio/DelayDSPKernel.h.
* Modules/webaudio/DelayNode.cpp: Copied from Source/WebCore/webaudio/DelayNode.cpp.
* Modules/webaudio/DelayNode.h: Copied from Source/WebCore/webaudio/DelayNode.h.
* Modules/webaudio/DelayNode.idl: Copied from Source/WebCore/webaudio/DelayNode.idl.
* Modules/webaudio/DelayProcessor.cpp: Copied from Source/WebCore/webaudio/DelayProcessor.cpp.
* Modules/webaudio/DelayProcessor.h: Copied from Source/WebCore/webaudio/DelayProcessor.h.
* Modules/webaudio/DynamicsCompressorNode.cpp: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.cpp.
* Modules/webaudio/DynamicsCompressorNode.h: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.h.
* Modules/webaudio/DynamicsCompressorNode.idl: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.idl.
* Modules/webaudio/HighPass2FilterNode.cpp: Copied from Source/WebCore/webaudio/HighPass2FilterNode.cpp.
* Modules/webaudio/HighPass2FilterNode.h: Copied from Source/WebCore/webaudio/HighPass2FilterNode.h.
* Modules/webaudio/HighPass2FilterNode.idl: Copied from Source/WebCore/webaudio/HighPass2FilterNode.idl.
* Modules/webaudio/JavaScriptAudioNode.cpp: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.cpp.
* Modules/webaudio/JavaScriptAudioNode.h: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.h.
* Modules/webaudio/JavaScriptAudioNode.idl: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.idl.
* Modules/webaudio/LowPass2FilterNode.cpp: Copied from Source/WebCore/webaudio/LowPass2FilterNode.cpp.
* Modules/webaudio/LowPass2FilterNode.h: Copied from Source/WebCore/webaudio/LowPass2FilterNode.h.
* Modules/webaudio/LowPass2FilterNode.idl: Copied from Source/WebCore/webaudio/LowPass2FilterNode.idl.
* Modules/webaudio/MediaElementAudioSourceNode.cpp: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp.
* Modules/webaudio/MediaElementAudioSourceNode.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.
* Modules/webaudio/MediaElementAudioSourceNode.idl: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.idl.
* Modules/webaudio/OfflineAudioCompletionEvent.cpp: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.cpp.
* Modules/webaudio/OfflineAudioCompletionEvent.h: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.h.
* Modules/webaudio/OfflineAudioCompletionEvent.idl: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.idl.
* Modules/webaudio/OfflineAudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp.
* Modules/webaudio/OfflineAudioDestinationNode.h: Copied from Source/WebCore/webaudio/OfflineAudioDestinationNode.h.
* Modules/webaudio/RealtimeAnalyser.cpp: Copied from Source/WebCore/webaudio/RealtimeAnalyser.cpp.
* Modules/webaudio/RealtimeAnalyser.h: Copied from Source/WebCore/webaudio/RealtimeAnalyser.h.
* Modules/webaudio/RealtimeAnalyserNode.cpp: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.cpp.
* Modules/webaudio/RealtimeAnalyserNode.h: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.h.
* Modules/webaudio/RealtimeAnalyserNode.idl: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.idl.
* Modules/webaudio/WaveShaperDSPKernel.cpp: Copied from Source/WebCore/webaudio/WaveShaperDSPKernel.cpp.
* Modules/webaudio/WaveShaperDSPKernel.h: Copied from Source/WebCore/webaudio/WaveShaperDSPKernel.h.
* Modules/webaudio/WaveShaperNode.cpp: Copied from Source/WebCore/webaudio/WaveShaperNode.cpp.
* Modules/webaudio/WaveShaperNode.h: Copied from Source/WebCore/webaudio/WaveShaperNode.h.
* Modules/webaudio/WaveShaperNode.idl: Copied from Source/WebCore/webaudio/WaveShaperNode.idl.
* Modules/webaudio/WaveShaperProcessor.cpp: Copied from Source/WebCore/webaudio/WaveShaperProcessor.cpp.
* Modules/webaudio/WaveShaperProcessor.h: Copied from Source/WebCore/webaudio/WaveShaperProcessor.h.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* webaudio/AsyncAudioDecoder.cpp: Removed.
* webaudio/AsyncAudioDecoder.h: Removed.
* webaudio/AudioBasicProcessorNode.cpp: Removed.
* webaudio/AudioBasicProcessorNode.h: Removed.
* webaudio/AudioBuffer.cpp: Removed.
* webaudio/AudioBuffer.h: Removed.
* webaudio/AudioBuffer.idl: Removed.
* webaudio/AudioBufferCallback.h: Removed.
* webaudio/AudioBufferCallback.idl: Removed.
* webaudio/AudioBufferSourceNode.cpp: Removed.
* webaudio/AudioBufferSourceNode.h: Removed.
* webaudio/AudioBufferSourceNode.idl: Removed.
* webaudio/AudioChannelMerger.cpp: Removed.
* webaudio/AudioChannelMerger.h: Removed.
* webaudio/AudioChannelMerger.idl: Removed.
* webaudio/AudioChannelSplitter.cpp: Removed.
* webaudio/AudioChannelSplitter.h: Removed.
* webaudio/AudioChannelSplitter.idl: Removed.
* webaudio/AudioContext.cpp: Removed.
* webaudio/AudioContext.h: Removed.
* webaudio/AudioContext.idl: Removed.
* webaudio/AudioDestinationNode.cpp: Removed.
* webaudio/AudioDestinationNode.h: Removed.
* webaudio/AudioDestinationNode.idl: Removed.
* webaudio/AudioGain.h: Removed.
* webaudio/AudioGain.idl: Removed.
* webaudio/AudioGainNode.cpp: Removed.
* webaudio/AudioGainNode.h: Removed.
* webaudio/AudioGainNode.idl: Removed.
* webaudio/AudioListener.cpp: Removed.
* webaudio/AudioListener.h: Removed.
* webaudio/AudioListener.idl: Removed.
* webaudio/AudioNode.cpp: Removed.
* webaudio/AudioNode.h: Removed.
* webaudio/AudioNode.idl: Removed.
* webaudio/AudioNodeInput.cpp: Removed.
* webaudio/AudioNodeInput.h: Removed.
* webaudio/AudioNodeOutput.cpp: Removed.
* webaudio/AudioNodeOutput.h: Removed.
* webaudio/AudioPannerNode.cpp: Removed.
* webaudio/AudioPannerNode.h: Removed.
* webaudio/AudioPannerNode.idl: Removed.
* webaudio/AudioParam.cpp: Removed.
* webaudio/AudioParam.h: Removed.
* webaudio/AudioParam.idl: Removed.
* webaudio/AudioParamTimeline.cpp: Removed.
* webaudio/AudioParamTimeline.h: Removed.
* webaudio/AudioProcessingEvent.cpp: Removed.
* webaudio/AudioProcessingEvent.h: Removed.
* webaudio/AudioProcessingEvent.idl: Removed.
* webaudio/AudioSourceNode.h: Removed.
* webaudio/AudioSourceNode.idl: Removed.
* webaudio/BiquadDSPKernel.cpp: Removed.
* webaudio/BiquadDSPKernel.h: Removed.
* webaudio/BiquadFilterNode.cpp: Removed.
* webaudio/BiquadFilterNode.h: Removed.
* webaudio/BiquadFilterNode.idl: Removed.
* webaudio/BiquadProcessor.cpp: Removed.
* webaudio/BiquadProcessor.h: Removed.
* webaudio/ConvolverNode.cpp: Removed.
* webaudio/ConvolverNode.h: Removed.
* webaudio/ConvolverNode.idl: Removed.
* webaudio/DOMWindowWebAudio.idl: Removed.
* webaudio/DefaultAudioDestinationNode.cpp: Removed.
* webaudio/DefaultAudioDestinationNode.h: Removed.
* webaudio/DelayDSPKernel.cpp: Removed.
* webaudio/DelayDSPKernel.h: Removed.
* webaudio/DelayNode.cpp: Removed.
* webaudio/DelayNode.h: Removed.
* webaudio/DelayNode.idl: Removed.
* webaudio/DelayProcessor.cpp: Removed.
* webaudio/DelayProcessor.h: Removed.
* webaudio/DynamicsCompressorNode.cpp: Removed.
* webaudio/DynamicsCompressorNode.h: Removed.
* webaudio/DynamicsCompressorNode.idl: Removed.
* webaudio/HighPass2FilterNode.cpp: Removed.
* webaudio/HighPass2FilterNode.h: Removed.
* webaudio/HighPass2FilterNode.idl: Removed.
* webaudio/JavaScriptAudioNode.cpp: Removed.
* webaudio/JavaScriptAudioNode.h: Removed.
* webaudio/JavaScriptAudioNode.idl: Removed.
* webaudio/LowPass2FilterNode.cpp: Removed.
* webaudio/LowPass2FilterNode.h: Removed.
* webaudio/LowPass2FilterNode.idl: Removed.
* webaudio/MediaElementAudioSourceNode.cpp: Removed.
* webaudio/MediaElementAudioSourceNode.h: Removed.
* webaudio/MediaElementAudioSourceNode.idl: Removed.
* webaudio/OfflineAudioCompletionEvent.cpp: Removed.
* webaudio/OfflineAudioCompletionEvent.h: Removed.
* webaudio/OfflineAudioCompletionEvent.idl: Removed.
* webaudio/OfflineAudioDestinationNode.cpp: Removed.
* webaudio/OfflineAudioDestinationNode.h: Removed.
* webaudio/RealtimeAnalyser.cpp: Removed.
* webaudio/RealtimeAnalyser.h: Removed.
* webaudio/RealtimeAnalyserNode.cpp: Removed.
* webaudio/RealtimeAnalyserNode.h: Removed.
* webaudio/RealtimeAnalyserNode.idl: Removed.
* webaudio/WaveShaperDSPKernel.cpp: Removed.
* webaudio/WaveShaperDSPKernel.h: Removed.
* webaudio/WaveShaperNode.cpp: Removed.
* webaudio/WaveShaperNode.h: Removed.
* webaudio/WaveShaperNode.idl: Removed.
* webaudio/WaveShaperProcessor.cpp: Removed.
* webaudio/WaveShaperProcessor.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerf-o-matic: don't query datastore to generate chart API urls
rniwa@webkit.org [Wed, 21 Mar 2012 00:30:28 +0000 (00:30 +0000)]
Perf-o-matic: don't query datastore to generate chart API urls
https://bugs.webkit.org/show_bug.cgi?id=81499

Reviewed by Hajime Morita.

Parse json text to extract timestamps and test values instead of iterating
through the data store.

* Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler.post):
* Websites/webkit-perf.appspot.com/models.py:
(Runs._timestamp_and_value_from_json_entry):
(Runs):
(Runs.to_json):
(Runs.chart_params):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip move-by-word-visually-crash-test-css-generated-content.html introduced in r111469
xji@chromium.org [Wed, 21 Mar 2012 00:24:49 +0000 (00:24 +0000)]
Skip move-by-word-visually-crash-test-css-generated-content.html introduced in r111469
because isWordTextBreak or setEditingBehavior is not implemented.

* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a per-ScrollableArea tile cache base class
andersca@apple.com [Wed, 21 Mar 2012 00:04:13 +0000 (00:04 +0000)]
Add a per-ScrollableArea tile cache base class
https://bugs.webkit.org/show_bug.cgi?id=81694

Reviewed by Sam Weinig.

Add an abstract base class, TiledBacking, that can be used to inform tile caches about changed
state in scrollable areas (such as the currently visible rect, whether the page is active or not, etc).

Make TileCache inherit from TiledBacking and port updating the visible rect over to this new mechanism.

* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::tiledBacking):
(WebCore):
* page/FrameView.h:
(FrameView):
* platform/ScrollableArea.h:
(WebCore):
(ScrollableArea):
(WebCore::ScrollableArea::tiledBacking):
* platform/graphics/GraphicsLayer.h:
(WebCore):
(WebCore::GraphicsLayer::tiledBacking):
* platform/graphics/TiledBacking.h: Added.
(WebCore):
(TiledBacking):
(WebCore::TiledBacking::~TiledBacking):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::tiledBacking):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/ca/PlatformCALayer.h:
(PlatformCALayer):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::tiledBacking):
* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/WebTileCacheLayer.h:
(WebCore):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer WebCore::]):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::tiledBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111453.
dpranke@chromium.org [Wed, 21 Mar 2012 00:00:07 +0000 (00:00 +0000)]
Unreviewed, rolling out r111453.
http://trac.webkit.org/changeset/111453
https://bugs.webkit.org/show_bug.cgi?id=81600

still broken

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._reset):
(ServerProcess.handle_interrupt):
(ServerProcess.write):
(ServerProcess._check_for_crash):
(ServerProcess._handle_timeout):
(ServerProcess._check_for_abort):
(ServerProcess._read):
(ServerProcess.stop):
(ServerProcess):
(ServerProcess.set_crashed):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.is_crash_reporter):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver):
(WebKitDriver._detected_crash):
(WebKitDriver._subprocess_crashed):
(WebKitDriver._crashed_process_name):
(WebKitDriver.run_test):
(WebKitDriver._read_block):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(MockServerProcess.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agovisual word movement: crashes on CSS generated content.
xji@chromium.org [Tue, 20 Mar 2012 23:49:52 +0000 (23:49 +0000)]
visual word movement: crashes on CSS generated content.
https://bugs.webkit.org/show_bug.cgi?id=81581

Reviewed by Ryosuke Niwa.

Source/WebCore:

Check for null pointer when referencing box->renderer()->node() in previousRootInlineBox and nextRootInlineBox.

Test: editing/selection/move-by-word-visually-crash-test-css-generated-content.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests:

* editing/selection/move-by-word-visually-crash-test-css-generated-content-expected.txt: Added.
* editing/selection/move-by-word-visually-crash-test-css-generated-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected results for this test after r110409.
mitz@apple.com [Tue, 20 Mar 2012 23:47:38 +0000 (23:47 +0000)]
Updated expected results for this test after r110409.

* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking full-screen-restrictions as timing out on Windows. It was previous...
leviw@chromium.org [Tue, 20 Mar 2012 23:44:46 +0000 (23:44 +0000)]
[Chromium] Marking full-screen-restrictions as timing out on Windows. It was previously marked as slow,
but all recent tests either passed or timed out.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated Mac expected results for this test. <http://webkit.org/b/81705> tracks the...
mitz@apple.com [Tue, 20 Mar 2012 23:37:38 +0000 (23:37 +0000)]
Updated Mac expected results for this test. <webkit.org/b/81705> tracks the fact that
r111416 broke it.

* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows (make based) build fix.
sfalken@apple.com [Tue, 20 Mar 2012 23:33:52 +0000 (23:33 +0000)]
Windows (make based) build fix.
<rdar://problem/11069015>

* JavaScriptCore.vcproj/JavaScriptCore.make: devenv /rebuild doesn't work with JavaScriptCore.vcproj. Use /clean and /build instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Address review comment for WebProcess side, too.
ap@apple.com [Tue, 20 Mar 2012 23:33:23 +0000 (23:33 +0000)]
    Address review comment for WebProcess side, too.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): There is no need for
        path to be in static storage, setenv will copy the value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Sandboxed PluginProcess should use private temporary and cache directories
ap@apple.com [Tue, 20 Mar 2012 23:30:39 +0000 (23:30 +0000)]
    Sandboxed PluginProcess should use private temporary and cache directories
        https://bugs.webkit.org/show_bug.cgi?id=81702
        <rdar://problem/10792047>

        Reviewed by Anders Carlsson.

        * Platform/Module.h:
        * Platform/mac/ModuleMac.mm:
        (WebKit::Module::bundleIdentifier):
        Expose plug-in's bundle identifier.

        * PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Some unerlated fixes to make
        networking functional on my testing platforms. These serveices are already allowed for
        WebProcess.

        * WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
        (readSandboxProfile): Unrelated fix - I've been made to rename the profile file, but
        didn't update where it's read from!
        (WKN_EnterSandbox): Add a suffix to user directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable LTCG on Windows to avoid out of process space errors while linking
sfalken@apple.com [Tue, 20 Mar 2012 23:27:00 +0000 (23:27 +0000)]
Disable LTCG on Windows to avoid out of process space errors while linking
https://bugs.webkit.org/show_bug.cgi?id=81714

Reviewed by Jessie Berlin.

* win/tools/vsprops/production.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Updating and coalescing test expectations for nested-fragment-parser-crash.
leviw@chromium.org [Tue, 20 Mar 2012 23:20:15 +0000 (23:20 +0000)]
[Chromium] Updating and coalescing test expectations for nested-fragment-parser-crash.

* platform/chromium-linux-x86/fast/parser: Removed.
* platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium-win-vista/fast/parser: Removed.
* platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium-win-xp/fast/parser: Removed.
* platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
* platform/chromium/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse CSSPrimitiveValue::convertToLength() to handle CSSPropertyWebkitBoxReflect and...
macpherson@chromium.org [Tue, 20 Mar 2012 23:18:52 +0000 (23:18 +0000)]
Use CSSPrimitiveValue::convertToLength() to handle CSSPropertyWebkitBoxReflect and in createGridTrackBreadth.
https://bugs.webkit.org/show_bug.cgi?id=81633

Reviewed by Andreas Kling.

No new tests / refactoring only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding additional possible test expectations for span-as-immediate-child...
leviw@chromium.org [Tue, 20 Mar 2012 23:15:11 +0000 (23:15 +0000)]
[Chromium] Adding additional possible test expectations for span-as-immediate-child-property-removal and
span-as-immediate-columns-child-removal, since the test expectations are now all over the board.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111442.
leviw@chromium.org [Tue, 20 Mar 2012 23:03:42 +0000 (23:03 +0000)]
Unreviewed, rolling out r111442.
http://trac.webkit.org/changeset/111442
https://bugs.webkit.org/show_bug.cgi?id=81711

Causes crashes and image mismatches in canvas tests (Requested
by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

Source/WebCore:

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearCopiedImage):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset):

LayoutTests:

* fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Removed.
* fast/canvas/canvas-resize-after-paint-without-layout.html: Removed.
* platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
* platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderLayerCompositor doesn't properly clip graphics layer sizes
enne@google.com [Tue, 20 Mar 2012 23:00:40 +0000 (23:00 +0000)]
RenderLayerCompositor doesn't properly clip graphics layer sizes
https://bugs.webkit.org/show_bug.cgi?id=80372

Reviewed by Simon Fraser.

Source/WebCore:

To find the bounds for a composited layer, calculateCompositedBounds
iterates through all non-composited child layers using z-order and
normal flow lists. This does not preserve clipping from ancestor
layers, because a clipping ancestor layer can end up as a sibling to
its clipped descendent because it is not a stacking context.

Fix by explicitly checking cached clip roots.

Test: compositing/clip-child-by-non-stacking-ancestor.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localClipRect):
(WebCore):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

LayoutTests:

Update several baselines due to smaller backing sizes.

* compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
* compositing/clip-child-by-non-stacking-ancestor.html: Added.
* compositing/geometry/clip-expected.txt:
* compositing/images/clip-on-directly-composited-image-expected.txt:
* compositing/overflow/clip-descendents-expected.txt:
* platform/chromium-win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
* platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111445 and r111446.
ossy@webkit.org [Tue, 20 Mar 2012 22:51:43 +0000 (22:51 +0000)]
Unreviewed, rolling out r111445 and r111446.
http://trac.webkit.org/changeset/111445
http://trac.webkit.org/changeset/111446
https://bugs.webkit.org/show_bug.cgi?id=81708

It broke Qt and GTK build intentionally (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

Source/WebCore:

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* notifications/Notification.cpp:
(WebCore::Notification::Notification):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
* notifications/NotificationCenter.h:
(NotificationCenter):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::toString):
* page/SecurityOrigin.h:
(SecurityOrigin):

Source/WebKit2:

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::policyForOrigin):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: get ServerProcess out of the reportcrash business
dpranke@chromium.org [Tue, 20 Mar 2012 22:40:08 +0000 (22:40 +0000)]
webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Unreviewed, build fix.

Re-land r111307 and r111293 with fix for crash in NRWT; I
was failing to set the crashing process name.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(MockServerProcess.__init__):
(MockServerProcess):
(MockServerProcess.has_crashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[mac] Restore color space switching code to run-webkit-tests
timothy_horton@apple.com [Tue, 20 Mar 2012 22:32:34 +0000 (22:32 +0000)]
[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.

Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
didn't exist until Lion.

* DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile):
(restoreUserColorProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnskip dom/xhtml test fixed in r111449.
adamk@chromium.org [Tue, 20 Mar 2012 22:24:25 +0000 (22:24 +0000)]
Unskip dom/xhtml test fixed in r111449.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor ContainerNode::replaceChild to match other mutation methods and share code
adamk@chromium.org [Tue, 20 Mar 2012 22:10:37 +0000 (22:10 +0000)]
Refactor ContainerNode::replaceChild to match other mutation methods and share code
https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

Originally landed as r111310, this fixes a bug in replaceChild
introduced when switching to the insert-before logic.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Use collectTargetNodes rather than walking through DocumentFragment children.
Insert before rather than inserting after. Dispatch to other methods to update parent/sibling pointers.
(WebCore::ContainerNode::appendChild): Call appendChildToContainer to update parent/sibling pointers.
(WebCore::ContainerNode::parserAddChild): Use type inference in call to appendChildToContainer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Because we might short-circuit permission calls, some of these tests...
jonlee@apple.com [Tue, 20 Mar 2012 22:04:57 +0000 (22:04 +0000)]
Unreviewed. Because we might short-circuit permission calls, some of these tests need to be rewritten
to take that factor into account. There's no mac support of notifications right now (see 79492),
so updating test expectations for now and tracking as a regression in 81697.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestrict access to notifications for unique origins and file URLs with no local file...
jonlee@apple.com [Tue, 20 Mar 2012 22:02:08 +0000 (22:02 +0000)]
Restrict access to notifications for unique origins and file URLs with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704
<rdar://problem/10912430>

Reviewed by Adam Barth.

Source/WebCore:

Before checking or requesting permissions, we look at whether we can show notifications based on
the security context. If not, we short circuit and do not forward the request to the client.

* notifications/Notification.cpp:
(WebCore::Notification::Notification): Fix a bug where creating a notification goes through slightly
different logic for checking permissions than when checking permissions through the
notification center.
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::checkPermission): Check to see if the origin can show notifications.
(WebCore::NotificationCenter::requestPermission): If we know whether an origin can show notifications,
we asynchronously call the callback with that decision. Otherwise we ask the client.

Add new variable in the notification center to keep track of pending callbacks when we short-circuit
requestPermission().
* notifications/NotificationCenter.h:
(NotificationRequestCallback): Add new private class encapsulating the callback.
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::requestTimedOut): Remove the request from the set of pending callbacks.
(WebCore::NotificationCenter::NotificationRequest::createAndStartTimer): Because this is used when we already
know the decision, and are not asking the client to decide, we can immediately trigger a one-shot timer
to invoke the callback.
(WebCore::NotificationCenter::NotificationRequest::NotificationRequest):
(WebCore::NotificationCenter::NotificationRequest::startTimer):
(WebCore::NotificationCenter::NotificationRequest::timerFired): Invoke the callback and tell the notification
center.
* page/SecurityOrigin.h: Add new toRawString() method to return the string representation of the origin,
regardless of any restrictions that might otherwise cause toString() to return "null".
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canShowNotifications): Added to return a tri-state regarding whether we know
the origin can show notifications. If the origin is unique, we never let it show. If the origin has
universal access, we always let it show. Otherwise the client should be asked.
(WebCore::SecurityOrigin::toString): Refactor to use toRawString().
(WebCore::SecurityOrigin::toRawString):

Added FIXME's regarding the naming of enforceFilePathSeparation().
* dom/Document.cpp:
(WebCore::Document::initSecurityContext): Also, tab reformatting.

* WebCore.exp.in: Export toRawString().

Source/WebKit2:

In the specific case where a file URL has restricted file access and is denied universal access,
SecurityOrigin::canShowNotifications() returns Ask, since it is not considered a unique origin.
The cached table of permissions held by the notification manager will typically not have an entry for
the toString() representation of these file URLs, which is "null", since that can also cover unique
origins, and it is possible that the client will want different permissions between the two types.

It is reasonable, however, for there to be an entry for "file://", so we use toRawString() to do the lookup.

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::policyForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused CSSPrimitiveValue constructors.
kling@webkit.org [Tue, 20 Mar 2012 21:54:15 +0000 (21:54 +0000)]
Remove unused CSSPrimitiveValue constructors.
<http://webkit.org/b/81695>

Reviewed by Antti Koivisto.

Kill off CSSPrimitiveValue constructors that aren't used anywhere.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValueBase):
(WebCore::CSSPrimitiveValueBase::CSSPrimitiveValueBase):
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the last test to use EXPECT_WK_STREQ.
adele@apple.com [Tue, 20 Mar 2012 21:42:23 +0000 (21:42 +0000)]
Update the last test to use EXPECT_WK_STREQ.

Reviewed by Dan Bernstein.

* TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReuse buffer allocation if canvas size does not change
commit-queue@webkit.org [Tue, 20 Mar 2012 21:39:27 +0000 (21:39 +0000)]
Reuse buffer allocation if canvas size does not change
https://bugs.webkit.org/show_bug.cgi?id=80871

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-20
Reviewed by Stephen White.

Source/WebCore:

If the user changes the width or height attributes of a canvas element,
the contents of the canvas should be cleared and the context state
should be reset. This has become a common idiom to clear the canvas
"efficiently" at the start of a frame.

Previously, this code path triggered a full reallocation of the image
buffer backing the canvas, leading to reduced performance. This patch
implements an optimization where we reuse the previous image buffer
allocation if the size of the canvas did not change. Also, instead of
clearing the canvas every time its dimensions are touched, we only clear
if anything has been drawn into the canvas since it was previously
cleared.

Note that for now this optimization only applies for 2D canvases,
since it is not entirely clear how touching the dimensions of a WebGL
canvas should work.

Test: fast/canvas/canvas-resize-after-paint-without-layout.html +
      existing layout tests for canvas resetting.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearImageBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::clearCopiedImage):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Save the
initial graphics context state so we can restore it without creating a
new context.
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset): No need to notify the
compositor when the context is reset, because clearing the image buffer
does the same thing. We can also skip the notification if we did not
have an image buffer at the time of the reset, because the reset will
not have any visual impact in this case. Finally, if the canvas size
did change, the notification is also unnecessary because of the call
to RenderObject::repaint() from HTMLCanvasElement::reset().

LayoutTests:

Add layout test to check canvas resizing without changing its layout size.

We also update the expected image one canvas clearing test. The test
is setting the size of a canvas and expecting it to be cleared in the process.
With the optimization to retain the underlying ImageBuffer, we no longer call
RenderReplaced::repaint() as a part of this process. This function used to
repaint both the canvas itself (100x50) as well as its local selection
rectangle (100x54).

In this case the local selection rectangle is larger than the canvas because
the canvas is contained within an anonymous RenderBlock that also has two empty
text nodes. The extra 4 pixels are needed for drawing the selection rectangle
around any descenders in the the text of those nodes.

Since clearing the canvas has no effect on the selection rectangle, we only
need to repaint the area of the canvas itself.

* fast/canvas/canvas-resize-after-paint-without-layout.html: Added.
* fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
* platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Allow us to disable overdraw metrics when tracing is off
commit-queue@webkit.org [Tue, 20 Mar 2012 21:34:10 +0000 (21:34 +0000)]
[chromium] Allow us to disable overdraw metrics when tracing is off
https://bugs.webkit.org/show_bug.cgi?id=81431

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to disable overdraw metrics conditionally in the
future with a one-line change in each LayerTreeHost class.

Unit test: CCQuadCullerTest.verifyWithoutMetrics

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCull):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
* tests/CCQuadCullerTest.cpp:
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TEST):
(WebCore):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Mac WebKit2 expected results for this test. <http://webkit.org/b/81700> tracks the
mitz@apple.com [Tue, 20 Mar 2012 21:33:55 +0000 (21:33 +0000)]
Added Mac WebKit2 expected results for this test. <webkit.org/b/81700> tracks the
difference in results between WebKit1 and WebKit2 in this test.

* platform/mac-wk2/fast/dom: Added.
* platform/mac-wk2/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse-after-free of continuation in RenderBlock::paintContinuationOutlines()
robert@webkit.org [Tue, 20 Mar 2012 21:31:46 +0000 (21:31 +0000)]
Use-after-free of continuation in RenderBlock::paintContinuationOutlines()
https://bugs.webkit.org/show_bug.cgi?id=81276

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/relative-positioned-block-crash.html

https://trac.webkit.org/changeset/108185/ allowed anonymous blocks to get their own layer (when they're
relatively positioned). This broke the dependency in addContinuationWithOutline() on the owner of the continuation
table and the renderer getting added to it always being in the same layer. When they're not in the same layer
there's no guarantee that the owner of the continuation table will get painted again and so avoid any stale pointers
in its continuation table should any of the renderers in there get destroyed.

Fix this for now by only adding renderers to the containing block's continuation table if we don't have our own layer.
This fix causes fast/inline/continuation-outlines-with-layers.html to regress as it uses blocks inside relatively positioned
inlines, so skip it on all platforms pending a medium-term fix.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):

LayoutTests:

* fast/css/relative-positioned-block-crash-expected.txt: Added.
* fast/css/relative-positioned-block-crash.html: Added.
* platform/chromium/test_expectations.txt: Skip fast/inline/continuation-outlines-with-layers.html for now.
* platform/gtk/Skipped: ditto
* platform/mac/Skipped: ditto
* platform/qt/Skipped: ditto
* platform/win/Skipped: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Move WTF-related Windows project files out of JavaScriptCore
sfalken@apple.com [Tue, 20 Mar 2012 21:25:32 +0000 (21:25 +0000)]
Source/JavaScriptCore: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

* JavaScriptCore.vcproj/JavaScriptCore.sln:
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
* JavaScriptCore.vcproj/WTF: Removed.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Removed.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFDebug.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGenerated.make: Removed.
* JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd: Removed.
* JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd: Removed.
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFRelease.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/build-generated-files.sh: Removed.
* JavaScriptCore.vcproj/WTF/copy-files.cmd: Removed.
* JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Removed.

Source/WebKit/win: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

Reviewed by Jessie Berlin.

* WebKit.vcproj/WebKit.sln:

Source/WTF: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

* WTF.vcproj: Added.
* WTF.vcproj/WTF.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj.
* WTF.vcproj/WTFCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFCommon.vsprops.
* WTF.vcproj/WTFDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebug.vsprops.
* WTF.vcproj/WTFDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops.
* WTF.vcproj/WTFDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops.
* WTF.vcproj/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.make.
* WTF.vcproj/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj.
* WTF.vcproj/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops.
* WTF.vcproj/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops.
* WTF.vcproj/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops.
* WTF.vcproj/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops.
* WTF.vcproj/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops.
* WTF.vcproj/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops.
* WTF.vcproj/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops.
* WTF.vcproj/WTFPostBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd.
* WTF.vcproj/WTFPreBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd.
* WTF.vcproj/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFProduction.vsprops.
* WTF.vcproj/WTFRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFRelease.vsprops.
* WTF.vcproj/WTFReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops.
* WTF.vcproj/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/build-generated-files.sh.
* WTF.vcproj/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/copy-files.cmd.
* WTF.vcproj/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWork around the inconsistency in test results caused by <http://webkit.org/b/81696...
mitz@apple.com [Tue, 20 Mar 2012 21:19:31 +0000 (21:19 +0000)]
Work around the inconsistency in test results caused by <webkit.org/b/81696> in a few
tests, by appending a # character to the href attributes of links to other tests. This
ensures that they are never visited.

* fast/block/margin-collapse/001.html:
* fast/block/margin-collapse/005.html:
* fast/block/margin-collapse/010.html:
* fast/block/margin-collapse/011.html:
* fast/block/margin-collapse/012.html:
* fast/block/margin-collapse/015.html:
* fast/block/margin-collapse/016.html:
* fast/block/margin-collapse/017.html:
* fast/block/margin-collapse/020.html:
* fast/block/margin-collapse/056.html:
* fast/block/margin-collapse/059.html:
* fast/block/margin-collapse/block-inside-inline/001.html:
* fast/block/margin-collapse/block-inside-inline/005.html:
* fast/block/margin-collapse/block-inside-inline/010.html:
* fast/block/margin-collapse/block-inside-inline/011.html:
* fast/block/margin-collapse/block-inside-inline/012.html:
* fast/block/margin-collapse/block-inside-inline/015.html:
* fast/block/margin-collapse/block-inside-inline/016.html:
* fast/block/margin-collapse/block-inside-inline/017.html:
* fast/block/margin-collapse/block-inside-inline/020.html:
* platform/mac/fast/block/margin-collapse/056-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: "Attempt to insert nil value " exception when calling attributed...
adele@apple.com [Tue, 20 Mar 2012 21:05:32 +0000 (21:05 +0000)]
Source/WebCore: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

Test: TestWebKitAPI/Tests/mac/AttributedString.mm

If content is using a custom font, then the platform font will be nil and needs to be nil checked.

* platform/mac/HTMLConverter.mm: (+[WebHTMLConverter editingAttributedStringFromRange:]):

Tools: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
* TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
(-[AttributedStringTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake distributeExtraLogicalHeightToRows return the consumed logical height
jchaffraix@webkit.org [Tue, 20 Mar 2012 21:02:34 +0000 (21:02 +0000)]
Make distributeExtraLogicalHeightToRows return the consumed logical height
https://bugs.webkit.org/show_bug.cgi?id=81678

Reviewed by Tony Chang.

Small refactoring, no change in behavior.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::distributeExtraLogicalHeight):
Remove the consumed logical height from the available height.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
Changed those method to not return anything but remove from the available width.

(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
Return the consumed logical height.

* rendering/RenderTableSection.h:
Updated the previous distribute functions signature and the comment about
the returned value from distributeExtraLogicalHeightToRows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
commit-queue@webkit.org [Tue, 20 Mar 2012 20:56:39 +0000 (20:56 +0000)]
[BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
https://bugs.webkit.org/show_bug.cgi?id=81686

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Source/WebCore:

HTML plugin element with an empty src caused an ASSERT failure on debug
build and a crash on release build.
When getting cookie, url can be null, so we need to check for it to
avoid the crash.

No new tests as this is covered by
LayoutTests/fast/loader/empty-embed-src-attribute.html.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

When deciding the policy for navigation action, if the url of the
request is null, ignore it to avoid the ASSERT failure in
MainResourceLoader::willSendRequest.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCache the type string of JavaScript object
benjamin@webkit.org [Tue, 20 Mar 2012 20:22:57 +0000 (20:22 +0000)]
Cache the type string of JavaScript object
https://bugs.webkit.org/show_bug.cgi?id=81446

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-20
Reviewed by Geoffrey Garen.

Instead of creating the JSString every time, we create
lazily the strings in JSGlobalData.

This avoid the construction of the StringImpl and of the JSString,
which gives some performance improvements.

* runtime/CommonIdentifiers.h:
* runtime/JSValue.cpp:
(JSC::JSValue::toStringSlowCase):
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::finalizeSmallStrings):
(JSC::SmallStrings::initialize):
(JSC):
* runtime/SmallStrings.h:
(SmallStrings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd link on queues.webkit.org to kov's fancy queue-depth graph
eric@webkit.org [Tue, 20 Mar 2012 20:07:01 +0000 (20:07 +0000)]
Add link on queues.webkit.org to kov's fancy queue-depth graph
https://bugs.webkit.org/show_bug.cgi?id=81690

Reviewed by Adam Barth.

* QueueStatusServer/templates/recentstatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow LLINT to work even when executable allocation fails.
oliver@apple.com [Tue, 20 Mar 2012 20:02:05 +0000 (20:02 +0000)]
Allow LLINT to work even when executable allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=81693

Reviewed by Gavin Barraclough.

Don't crash if executable allocation fails if we can fall back on LLINT

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Tabbed pane drop down should be sorted.
vsevik@chromium.org [Tue, 20 Mar 2012 19:58:19 +0000 (19:58 +0000)]
Web Inspector: Tabbed pane drop down should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81680

Reviewed by Pavel Feldman.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex.compareFunction):
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[mac] Restore color space switching code to run-webkit-tests
timothy_horton@apple.com [Tue, 20 Mar 2012 19:58:02 +0000 (19:58 +0000)]
[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

Make use of the layout test helper hooks to restore the Mac system-wide
color profile switching code. This makes WkTR and DRT results match, and
causes the main display's color profile to not affect results on Lion.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/LayoutTestHelper.m: Added.
(installLayoutTestColorProfile):
(restoreUserColorProfile):
(simpleSignalHandler):
(main):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.release_http_lock):
(MacPort):
(MacPort._path_to_helper):
(MacPort.start_helper):
(MacPort.stop_helper):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::windowSnapshotImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Open resource dialog scripts list should be sorted.
vsevik@chromium.org [Tue, 20 Mar 2012 19:53:36 +0000 (19:53 +0000)]
Web Inspector: Open resource dialog scripts list should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81682

Reviewed by Pavel Feldman.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Mac WebKit2 expected results for this test. <http://webkit.org/b/81679> tracks the
mitz@apple.com [Tue, 20 Mar 2012 19:52:30 +0000 (19:52 +0000)]
Added Mac WebKit2 expected results for this test. <webkit.org/b/81679> tracks the
difference in results between WebKit1 and WebKit2 in this test.

* platform/mac-wk2/compositing/geometry: Added.
* platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use opaque contents for paint culling
commit-queue@webkit.org [Tue, 20 Mar 2012 19:51:20 +0000 (19:51 +0000)]
[chromium] Use opaque contents for paint culling
https://bugs.webkit.org/show_bug.cgi?id=81676

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

UnitTest: CCLayerTreeHostTestContentLayerOcclusion

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestLayerChromium::opaqueContentsRegion):
(WTF::TestLayerChromium::setOpaqueContentsRect):
(TestLayerChromium):
(CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::afterTest):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Updating Chromium expectations following r111412.
leviw@chromium.org [Tue, 20 Mar 2012 19:47:22 +0000 (19:47 +0000)]
[Chromium] Updating Chromium expectations following r111412.

* platform/chromium-win/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r111419.
mitz@apple.com [Tue, 20 Mar 2012 19:04:16 +0000 (19:04 +0000)]
Build fix after r111419.

* dom/WebKitNamedFlow.cpp:
* dom/WebKitNamedFlow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r111229): css1/basic/inheritance.html is failing
mitz@apple.com [Tue, 20 Mar 2012 18:37:58 +0000 (18:37 +0000)]
REGRESSION (r111229): css1/basic/inheritance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81684

Reverted r111229.

Rubber-stamped by Dave Hyatt.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
(Document):
* dom/Element.cpp:
(WebCore::Element::detach):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp:
(WebCore):
* dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:

LayoutTests:

* fast/regions/webkit-named-flow-content-nodes-expected.txt: Removed.
* fast/regions/webkit-named-flow-content-nodes.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=80696
commit-queue@webkit.org [Tue, 20 Mar 2012 18:26:51 +0000 (18:26 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80696
Remove custom bindings for attribute type Array.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests.

* bindings/js/JSConsoleCustom.cpp: Removed custom function.
(WebCore):
* bindings/js/JSDOMBinding.h: Added template jsArray and toNativeArray.
(WebCore):
(WebCore::jsArray):
(WebCore::toNativeArray):
* bindings/scripts/CodeGenerator.pm: Modified codegenerators to generate appropriate code.
(GetArrayType): Added GetArrayType to get return type of attribute interface.
* bindings/scripts/CodeGeneratorGObject.pm: Modified codegenerators to generate appropriate code.
(SkipAttribute):
* bindings/scripts/CodeGeneratorJS.pm: Modified codegenerators to generate appropriate code.
(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm: Modified codegenerators to generate appropriate code.
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Updated results from running binding tests.
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
* bindings/v8/V8Binding.h: Added template v8Array and toNativeArray.
(WebCore):
(WebCore::v8Array):
(WebCore::toNativeArray):
* bindings/v8/custom/V8ConsoleCustom.cpp: Removed custom function.
(WebCore):
* page/Console.idl: Replaced attribute type Array to sequence<SriptProfile> to remove
  custom bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111310.
commit-queue@webkit.org [Tue, 20 Mar 2012 18:18:22 +0000 (18:18 +0000)]
Unreviewed, rolling out r111310.
http://trac.webkit.org/changeset/111310
https://bugs.webkit.org/show_bug.cgi?id=81683

Broke layout test
dom/xhtml/level3/core/nodereplacechild30.xhtml (Requested by
aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-24 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 20 Mar 2012 18:12:49 +0000 (18:12 +0000)]
2012-02-24  Darin Fisher  <darin@chromium.org>

        Add more Chromium WebKit API reviewers
        https://bugs.webkit.org/show_bug.cgi?id=81576

        Reviewed by Adam Barth and David Levin.

        Simplify watchlist to lump all WebKit API into one.

        * Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago WebProcess should use private temporary and cache directories
ap@apple.com [Tue, 20 Mar 2012 18:08:15 +0000 (18:08 +0000)]
    WebProcess should use private temporary and cache directories
        https://bugs.webkit.org/show_bug.cgi?id=80876

        Reviewed by Sam Weinig.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h: (WebProcessCreationParameters):
        * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess):
        Always pass uiProcessBundleIdentifier to WebProcess on Mac, it's now used for more than
        CFURL sessions.

        * WebProcess/com.apple.WebProcess.sb.in: Limit old workaround to platforms that need it.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Tell confstr to use a suffix
        on user directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected results for a test, while <http://webkit.org/b/81679> is tracking...
mitz@apple.com [Tue, 20 Mar 2012 18:02:25 +0000 (18:02 +0000)]
Updated expected results for a test, while <webkit.org/b/81679> is tracking this
possible regression.

* compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert regions parsing test to use testharness.js
commit-queue@webkit.org [Tue, 20 Mar 2012 17:56:15 +0000 (17:56 +0000)]
Convert regions parsing test to use testharness.js
https://bugs.webkit.org/show_bug.cgi?id=80709

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-03-20
Reviewed by Ryosuke Niwa.

* fast/regions/script-tests/webkit-flow-parsing.js:
(testParse):
(testComputedStyle):
(testNotInherited):
(test):
* fast/regions/webkit-flow-parsing-expected.txt:
* fast/regions/webkit-flow-parsing.html:
* resources/testharness.js: Added.
(.):
* resources/testharnessreport.js: Added.
(convertResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix and unskip.
vsevik@chromium.org [Tue, 20 Mar 2012 17:46:41 +0000 (17:46 +0000)]
Unreviewed test fix and unskip.

* inspector/debugger/snippets-model-expected.txt:
* inspector/debugger/snippets-model.html:
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding missing linux expectations for error-to-string-stack-overflow.
leviw@chromium.org [Tue, 20 Mar 2012 17:25:55 +0000 (17:25 +0000)]
[Chromium] Adding missing linux expectations for error-to-string-stack-overflow.

* platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGraphic distortion effect when launching with empty page Safari after reset
andersca@apple.com [Tue, 20 Mar 2012 17:21:00 +0000 (17:21 +0000)]
Graphic distortion effect when launching with empty page Safari after reset
https://bugs.webkit.org/show_bug.cgi?id=81677
<rdar://problem/11065904>

Reviewed by Sam Weinig.

Don't set the redraw policy to never, since that was causing the WKView layer to never be updated. Instead,
let AppKit decide which redraw policy to use.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding missing results for canvas-putImageData for Windows.
leviw@chromium.org [Tue, 20 Mar 2012 17:18:40 +0000 (17:18 +0000)]
[Chromium] Adding missing results for canvas-putImageData for Windows.

* platform/chromium-win/fast/repaint/canvas-putImageData-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert hasSpellingMarker to use Internals interface.
gyuyoung.kim@samsung.com [Tue, 20 Mar 2012 16:59:44 +0000 (16:59 +0000)]
Convert hasSpellingMarker to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=81300

Reviewed by Ryosuke Niwa.

.:

* Source/autotools/symbols.filter: Export a symbol for hasSpellingMarker.

Source/WebCore:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure
for testing a specific method.

* testing/Internals.cpp:
(WebCore::Internals::hasSpellingMarker):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/gtk:

Remove DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker support,
since it can support in the cross-port way through the Internals interface.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove hasSpellingMarker support, since it can support in the cross-port way
through the Internals interface.

* WebKit.order:
* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:

Source/WebKit/win:

Remove hasSpellingMarker interface support, since it can support in the cross-port
way through the Internals interface.

* Interfaces/IWebFramePrivate.idl:

Source/WebKit2:

* win/WebKit2.def: Export a symbol for hasSpellingMarker.

Tools:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Adjust hasSpellingMarker tests to use Internals instead of LayoutTestController
interface.

* editing/spelling/design-mode-spellcheck-off.html:
* editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
* editing/spelling/script-tests/spelling-attribute-at-child.js:
(childHasSpellingMarker):
* editing/spelling/script-tests/spelling-attribute-change.js:
(testSpellCheckingEnabled):
* editing/spelling/script-tests/spelling-backspace-between-lines.js:
(testWithDelete):
(testWithForwardDelete):
* editing/spelling/script-tests/spelling-hasspellingmarker.js:
(hasMarked):
* editing/spelling/spellcheck-attribute.html:
* editing/spelling/spelling-attribute-change-expected.txt:
* editing/spelling/spelling-backspace-between-lines-expected.txt:
* editing/spelling/spelling-hasspellingmarker-expected.txt:
* editing/spelling/spelling-linebreak.html:
* platform/chromium-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/chromium-win/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/mac/editing/spelling/delete-into-misspelled-word.html:
* platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
* platform/mac/editing/spelling/editing-word-with-marker-1.html:
* platform/mac/editing/spelling/editing-word-with-marker-2.html:
* platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
* platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
commit-queue@webkit.org [Tue, 20 Mar 2012 16:40:46 +0000 (16:40 +0000)]
[BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=81670

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

* WebCoreSupport/InspectorClientBlackBerry.h:
(WebCore::InspectorClientBlackBerry::canClearBrowserCache):
(WebCore::InspectorClientBlackBerry::canClearBrowserCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new Qt-WK2 performance tester bot to build.webkit.org
ossy@webkit.org [Tue, 20 Mar 2012 16:33:53 +0000 (16:33 +0000)]
Add new Qt-WK2 performance tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=80842

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTestsWebKit2):
(RunAndUploadPerfTestsWebKit2.start):
(BuildAndPerfTestWebKit2Factory):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestWebKit2Factory):
(DownloadAndPerfTestWebKit2Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Tue, 20 Mar 2012 16:28:29 +0000 (16:28 +0000)]
Build fix.

* history/PageCache.cpp: Fixed an unused function warning introduced in r111391.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111402 268f45cc-cd09-0410-ab3c-d52691b4dbfc