WebKit-https.git
9 years agoUnreviewed, rolling out r97954.
loislo@chromium.org [Thu, 20 Oct 2011 10:25:06 +0000 (10:25 +0000)]
Unreviewed, rolling out r97954.
http://trac.webkit.org/changeset/97954
https://bugs.webkit.org/show_bug.cgi?id=70486

clean build failed on chromium.mac: File
"../inspector/CodeGeneratorInspector.py", line 34, in <module>
import json (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-20

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/CodeGeneratorInspector.pm: Added.
(new):
(GenerateModule):
(GenerateInterface):
(generateAgentDeclaration):
(generateFrontendConstructorImpl):
(generateFunctions):
(generateFrontendFunction):
(camelCase):
(generateBackendFunction):
(generateBackendSendResponse):
(generateBackendReportProtocolError):
(generateArgumentGetters):
(generateBackendDispatcher):
(generateBackendMessageParser):
(collectBackendJSStubFunctions):
(collectBackendJSStubEvents):
(generateBackendStubJS):
(generateHeader):
(generateSource):
(typeTraits):
(paramTypeTraits):
(generateBackendAgentFieldsAndConstructor):
(finish):
* inspector/CodeGeneratorInspector.py: Removed.
* inspector/Inspector.json:
* inspector/generate-inspector-idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable geolocation client based flag for Qt5
commit-queue@webkit.org [Thu, 20 Oct 2011 10:22:05 +0000 (10:22 +0000)]
Enable geolocation client based flag for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70330

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-10-20
Reviewed by Kenneth Rohde Christiansen.

This will enable client based geolocation for Qt5.

No new tests, this enables flags for Qt5.

* features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a MessageEvent constructor for V8
haraken@chromium.org [Thu, 20 Oct 2011 09:57:28 +0000 (09:57 +0000)]
Implement a MessageEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70296

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/message-event-constructor.html

* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Returns RefPtr<DOMWindow> corresponding to a given key.
(WebCore::OptionsObject::getKeyValue): Returns MessagePortArray corresponding to a given key.
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8EventConstructors.cpp: Added a MessageEvent constructor.
* dom/MessageEvent.idl: Makes MessageEvent constructible for V8.

LayoutTests:

Enabled message-event-constructor.html for chromium,
since now V8 has the MessageEvent constructor.

* platform/chromium/test_expectations.txt:
* platform/chromium/fast/events/constructors/message-event-constructor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: reimplement protocol backend/frontend source generator
loislo@chromium.org [Thu, 20 Oct 2011 09:50:22 +0000 (09:50 +0000)]
Web Inspector: reimplement protocol backend/frontend source generator
https://bugs.webkit.org/show_bug.cgi?id=69295

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-10-20
Reviewed by Pavel Feldman.

Old 2-stage python+perf generator that uses intermediate IDL output is
being replaced with a solid python script. This is for simplicity and
as a base for the future JSON validator.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/CodeGeneratorInspector.pm: Removed.
* inspector/CodeGeneratorInspector.py: Added.
* inspector/Inspector.json:
* inspector/generate-inspector-idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip failing test in GTK.
philn@webkit.org [Thu, 20 Oct 2011 09:34:07 +0000 (09:34 +0000)]
Unreviewed, skip failing test in GTK.

* platform/gtk/Skipped: Skip fast/events/drag-selects-image.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: encode source map url as source map page url query parameter.
podivilov@chromium.org [Thu, 20 Oct 2011 09:33:02 +0000 (09:33 +0000)]
Web Inspector: encode source map url as source map page url query parameter.
https://bugs.webkit.org/show_bug.cgi?id=70327

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/CompilerSourceMappingProvider.js:
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
(WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiSourceCodeList):

LayoutTests:

* http/tests/inspector/compiler-source-mapping-provider.html:
* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=70482
fpizlo@apple.com [Thu, 20 Oct 2011 09:10:06 +0000 (09:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70482
DFG-related stubs in the old JIT should not be built if the DFG is disabled

Reviewed by Zoltan Herczeg.

Aiming for a slight code size/build time reduction if the DFG is not in
play. This should also make further DFG development slightly easier since
the bodies of these JIT stubs can now safely refer to things that are only
declared when the DFG is enabled.

* jit/JITStubs.cpp:
* jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Yet another test expectation change for platform/chromium/compositing...
yuzo@google.com [Thu, 20 Oct 2011 08:19:55 +0000 (08:19 +0000)]
[chromium] Yet another test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: The "x" in "980px x 36px" looks weird in the inspector node callout
apavlov@chromium.org [Thu, 20 Oct 2011 08:15:40 +0000 (08:15 +0000)]
Web Inspector: The "x" in "980px x 36px" looks weird in the inspector node callout
https://bugs.webkit.org/show_bug.cgi?id=69857

Reviewed by Pavel Feldman.

* inspector/DOMNodeHighlighter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Adding myself to watchlists.
philn@webkit.org [Thu, 20 Oct 2011 08:00:13 +0000 (08:00 +0000)]
Unreviewed. Adding myself to watchlists.
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r97926 and skip a failing plugin
philn@webkit.org [Thu, 20 Oct 2011 07:56:32 +0000 (07:56 +0000)]
Unreviewed, GTK rebaseline after r97926 and skip a failing plugin
test.

* platform/gtk/Skipped: Skip plugins/resize-from-plugin.html.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r97917.
loislo@chromium.org [Thu, 20 Oct 2011 07:34:48 +0000 (07:34 +0000)]
Unreviewed, rolling out r97917.
http://trac.webkit.org/changeset/97917
https://bugs.webkit.org/show_bug.cgi?id=70475

number of crashes on Snow Leopard/Lion tests bots
http://build.webkit.org/results/Lion%20Intel%20Release%20(Tests)/r97917%20(2020)/http/tests/inspector
/extensions-network-redirect-crash-log.txt (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-20

Source/WebCore:

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* dom/OptionElement.cpp:
(WebCore::OptionElement::setSelectedState):
(WebCore::OptionElement::optionIndex):
(WebCore::OptionElement::collectOptionLabelOrText):
(WebCore::OptionElement::collectOptionInnerText):
(WebCore::OptionElement::normalizeText):
(WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
(WebCore::OptionElementData::OptionElementData):
(WebCore::OptionElementData::~OptionElementData):
(WebCore::toOptionElement):
(WebCore::isOptionElement):
* dom/OptionElement.h:
(WebCore::OptionElement::~OptionElement):
(WebCore::OptionElementData::value):
(WebCore::OptionElementData::setValue):
(WebCore::OptionElementData::label):
(WebCore::OptionElementData::setLabel):
(WebCore::OptionElementData::selected):
(WebCore::OptionElementData::setSelected):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::createForJSConstructor):
(WebCore::HTMLOptionElement::text):
(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::parseMappedAttribute):
(WebCore::HTMLOptionElement::value):
(WebCore::HTMLOptionElement::selected):
(WebCore::HTMLOptionElement::setSelected):
(WebCore::HTMLOptionElement::setSelectedState):
(WebCore::HTMLOptionElement::defaultSelected):
(WebCore::HTMLOptionElement::setDefaultSelected):
(WebCore::HTMLOptionElement::label):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::insertedIntoTree):
* html/HTMLOptionElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndex):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsSelected):

Source/WebKit/chromium:

* src/WebOptionElement.cpp:
(WebKit::WebOptionElement::defaultSelected):
(WebKit::WebOptionElement::setDefaultSelected):
* src/WebSearchableFormData.cpp:
(HTMLNames::IsSelectInDefaultState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiled Backing Store does not regenerate tiles when it should
carol@webkit.org [Thu, 20 Oct 2011 07:22:49 +0000 (07:22 +0000)]
Tiled Backing Store does not regenerate tiles when it should
https://bugs.webkit.org/show_bug.cgi?id=57798

Reviewed by Darin Adler.

Source/WebCore:

Changed TiledBackingStore::adjustVisibleRect to take into account
contentsSize, the same way as it is done when tiles are generated.

This is an issue that requires a certain sequence of API calls which
may not be easily simulated from DumpRenderTree, but which is
easily reproduced with QtTest. This is why I have provided only
a Qt specific test despite this being a generic problem.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::adjustVisibleRect):
Changed to take into account ContentsSize.
(WebCore::TiledBackingStore::visibleContentsRect):
Added to return the intersection of the viewport's visible rect with
the ContentsRect.
(WebCore::TiledBackingStore::createTiles):
Changed to take into account the ContentsSize when calculating the
previously visible rect.
* platform/graphics/TiledBackingStore.h:

Source/WebKit/qt:

Provided test for this bug. Changed the name of the resource I added
for a previous test so that the name is descriptive such that it can
be shared across several tests.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::bug57798):
(tst_QGraphicsWebView::bug56929):
* tests/qgraphicswebview/tst_qgraphicswebview.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompositing/video tests time out on Lion
jer.noble@apple.com [Thu, 20 Oct 2011 07:20:55 +0000 (07:20 +0000)]
compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Eric Carlson.

Covered by existing tests.

AVFoundation will occasionally fill it's playback buffers before collecting enough
statistical information to answer YES to isLikelyToKeepUp.  In this situation, set the
ready state to HAVE_ENOUGH_DATA, on the presumption that if the playback buffers are
full, playback will probably not stall.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed morning gardning.
ossy@webkit.org [Thu, 20 Oct 2011 06:47:43 +0000 (06:47 +0000)]
[Qt] Unreviewed morning gardning.

* platform/qt/Skipped: Skip fast/dom/error-to-string-stack-overflow.html - https://bugs.webkit.org/show_bug.cgi?id=70476
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r97875.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG ConvertThis emits slow code when the source node is known to be,
fpizlo@apple.com [Thu, 20 Oct 2011 06:39:33 +0000 (06:39 +0000)]
DFG ConvertThis emits slow code when the source node is known to be,
but not predicted to be, a final object
https://bugs.webkit.org/show_bug.cgi?id=70466

Reviewed by Oliver Hunt.

Added a new case in ConvertThis compilation.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Test expectation change for platform/chromium/compositing/zoom-animator...
yuzo@google.com [Thu, 20 Oct 2011 06:36:17 +0000 (06:36 +0000)]
[chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimization triggers in the old JIT may sometimes fire repeatedly even
fpizlo@apple.com [Thu, 20 Oct 2011 06:33:33 +0000 (06:33 +0000)]
Optimization triggers in the old JIT may sometimes fire repeatedly even
though there is no optimization to be done
https://bugs.webkit.org/show_bug.cgi?id=70467

Reviewed by Oliver Hunt.

If optimize_from_ret does nothing, it delays the next optimization trigger.
This is performance-neutral.

* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMessageEvent.data can be stored as ScriptValue.
haraken@chromium.org [Thu, 20 Oct 2011 06:02:42 +0000 (06:02 +0000)]
MessageEvent.data can be stored as ScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=68978

Reviewed by Hajime Morita.

Source/WebCore:

Currently, the following test cases fail or crash:

- shouldBe("new MessageEvent('eventType', { data: test_object }).data", "test_object") -> FAIL
- new MessageEvent('eventType', { data: document }).data -> CRASH

This is because MessageEvent.data is implemented just as SerializedScriptValue
and it cannot keep ScriptValue passed by JavaScript. This patch makes the following changes:

- If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When MessageEvent.data is called, the ScriptValue is returned.
- If MessageEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point because of lack of ExecState). When MessageEvent.data is called,
the SerializedScriptValue is deserialized into the corresponding ScriptValue,
and the ScriptValue is returned.

This patch does not make a fix for ObjC bindings code, since we need to first fix
the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.

Test: fast/events/constructors/message-event-constructor.html
      fast/dom/message-port-deleted-by-accessor.html
      fast/events/init-events.html
      fast/eventsource/eventsource-attribute-listeners.html

* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::JSMessageEvent::handleInitMessageEvent): Changed SerializedScriptValue to ScriptValue. Removed a 'doTransfer' parameter.
(WebCore::JSMessageEvent::initMessageEvent): Removed a 'doTransfer' parameter.
(WebCore::JSMessageEvent::webkitInitMessageEvent): Ditto.
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
(WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
(WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
(WebCore::MessageEvent::isMessageEvent): Removed extra spaces.
* dom/MessageEvent.h: Added DataType::DataTypeScriptValue.
(WebCore::MessageEvent::create): Supported ScriptValue.
(WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
(WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
(WebCore::MessageEvent::dataAsString): Ditto.
(WebCore::MessageEvent::dataAsBlob): Ditto.
(WebCore::MessageEvent::dataAsArrayBuffer): Ditto.
* dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part. Removed [CachedAttribute] from MessageEvent.data, since it is now a DOMObject and needs not to be cached.

LayoutTests:

Removed failures and crashes.

* fast/events/constructors/message-event-constructor-expected.txt:
* fast/events/constructors/message-event-constructor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix GTK build.
abarth@webkit.org [Thu, 20 Oct 2011 05:19:48 +0000 (05:19 +0000)]
Attempt to fix GTK build.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago== Rolled over to ChangeLog-2011-10-19 ==
abarth@webkit.org [Thu, 20 Oct 2011 05:16:04 +0000 (05:16 +0000)]
== Rolled over to ChangeLog-2011-10-19 ==

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempted build fix. I managed to screw up every line of this file.
abarth@webkit.org [Thu, 20 Oct 2011 05:11:18 +0000 (05:11 +0000)]
Another attempted build fix.  I managed to screw up every line of this file.

* CodeGenerators.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Revert test expectaion change by 97932.
yuzo@google.com [Thu, 20 Oct 2011 05:03:44 +0000 (05:03 +0000)]
[chromium] Revert test expectaion change by 97932.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix the Qt build.
abarth@webkit.org [Thu, 20 Oct 2011 05:03:24 +0000 (05:03 +0000)]
Attempt to fix the Qt build.

* CodeGenerators.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDocument.cpp shouldn't need to know about every event for every feature
abarth@webkit.org [Thu, 20 Oct 2011 04:50:14 +0000 (04:50 +0000)]
Document.cpp shouldn't need to know about every event for every feature
https://bugs.webkit.org/show_bug.cgi?id=70469

Reviewed by Eric Seidel.

make_event_factory.pl generates the implementation of EventFactory
based on a simple ".in" file.

* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::createEvent):
* dom/EventFactory.h: Added.
* dom/EventFactory.in: Added.
* dom/make_event_factory.pl: Added.
(defaultEventPropertyHash):
(eventHandler):
(parametersHandler):
(readNames):
(readEvents):
(interfaceForEvent):
(printCppFile):
(printLicenseHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Test expectation change for platform/chromium/compositing/zoom-animator...
yuzo@google.com [Thu, 20 Oct 2011 04:43:44 +0000 (04:43 +0000)]
[chromium] Test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Adam Barth.
eric@webkit.org [Thu, 20 Oct 2011 04:22:20 +0000 (04:22 +0000)]
Reviewed by Adam Barth.

Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
https://bugs.webkit.org/show_bug.cgi?id=63683

* Scripts/webkitpy/common/net/layouttestresults.py:
* Scripts/webkitpy/common/net/resultsjsonparser.py:
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket layout tests are flaky on Chromium Win
yutak@chromium.org [Thu, 20 Oct 2011 04:03:22 +0000 (04:03 +0000)]
WebSocket layout tests are flaky on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=66730

Reviewed by Mihai Parparita.

Remove test expectations for WebSocket tests which have not been failing since
TcpClientSocketWin fix on Chromium (http://crrev.com/104852).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded a ConstructorMode check to all existing custom V8 constructors.
haraken@chromium.org [Thu, 20 Oct 2011 03:53:02 +0000 (03:53 +0000)]
Added a ConstructorMode check to all existing custom V8 constructors.
https://bugs.webkit.org/show_bug.cgi?id=70464

Reviewed by Adam Barth.

This patch adds the following two lines to all existing custom V8 constructors:

    if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
        return args.Holder();

This checks whether a programmer is trying to allocate an object via "new X",
or C++ is trying to allocate an object via the function template and wrap the
object with a JS flavor. (See here for more details: bug 70015) In the latter case,
a constructor callback should not be executed (i.e. should return immediately).

No new tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferCustom.cpp: Added the ConstructorMode check.
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h: Ditto.
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp: Ditto.
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Ditto.
(WebCore::V8DOMFormData::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp: Ditto.
(WebCore::V8DataView::constructorCallback):
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Ditto.
(WebCore::v8HTMLAudioElementConstructorCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Ditto.
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Ditto.
(WebCore::v8HTMLOptionElementConstructorCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp: Ditto.
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: Ditto.
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebKitPointConstructor.cpp: Ditto.
(WebCore::V8WebKitPoint::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp: Ditto.
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Ditto.
(WebCore::V8XMLHttpRequest::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT 32_64 - remove unnecessary double unboxings in fillDouble/fillSpeculateDouble
commit-queue@webkit.org [Thu, 20 Oct 2011 03:32:20 +0000 (03:32 +0000)]
DFG JIT 32_64 - remove unnecessary double unboxings in fillDouble/fillSpeculateDouble
https://bugs.webkit.org/show_bug.cgi?id=70460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-19
Reviewed by Filip Pizlo.

As pointed out by Gavin in bug #70418, when a value is already in memory
we can avoid loading it to two GPRs at first and then unboxing them to a FPR.
This gives 9% improvement on Kraken if without the change in bug #70418,
and 1% if based on the code with bug #70418 change.
Performance is neutral in V8 and SunSpider.

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS Counters have wrong values
carol@webkit.org [Thu, 20 Oct 2011 03:16:29 +0000 (03:16 +0000)]
CSS Counters have wrong values
https://bugs.webkit.org/show_bug.cgi?id=69605

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/counters/after-continuation.html

Added a new method for getting the renderer of the "after"
pseudo-element that handles continuations.
Hooked up the new method with the CSS counter code.

* rendering/RenderCounter.cpp:
(WebCore::rendererOfAfterPseudoElement):
(WebCore::previousInPreOrder):
(WebCore::nextInPreOrder):
* rendering/RenderObject.h:

LayoutTests:

This test highlights the ability of the CSS counter handling code to
find a counter attached to a continuation of a renderer.

* fast/css/counters/after-continuation-expected.txt: Added.
* fast/css/counters/after-continuation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding some IDL files for <track>.
annacc@chromium.org [Thu, 20 Oct 2011 02:53:38 +0000 (02:53 +0000)]
Adding some IDL files for <track>.
https://bugs.webkit.org/show_bug.cgi?id=62887

Reviewed by Adam Barth.

Tests:
MutableTextTrack.idl and addTrack() in HTMLMediaElement.idl are tested by:
media/track/track-mutable.html

TextTrack.idl is tested by:
media/track/track-text-track.html

TextTrackCue.idl is tested by:
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc023-markup.html

TextTrackCueList.idl is tested by:
media/track/track-text-track-cue-list.html

* CMakeLists.txt: Adding files to build systems.
* CodeGenerators.pri: Adding files to build systems.
* DerivedSources.cpp: Adding files to build systems.
* DerivedSources.make: Adding files to build systems.
* GNUmakefile.list.am: Adding files to build systems.
* WebCore.gypi: Adding files to build systems.
* WebCore.pro: Adding files to build systems.
* WebCore.xcodeproj/project.pbxproj: Adding files to build systems.
* bindings/gobject/GNUmakefile.am: Adding files to build systems.
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Adding files to build systems.
* bindings/js/JSBindingsAllInOne.cpp: Adding files to build systems.

* bindings/js/JSTextTrackCustom.cpp: Added.
(WebCore::toJS):

* bindings/scripts/CodeGeneratorV8.pm:
(HasCustomToV8Implementation): Special check for TextTrack since V8 can auto-generate
it, but JS cannot yet.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTrack): creates and returns a new MutableTextTrack.
* html/HTMLMediaElement.h: Adding addTrack() function.
* html/HTMLMediaElement.idl: Adding addTrack() function.
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::track): Adding track getter.
* html/HTMLTrackElement.h: Adding track getter.
* html/HTMLTrackElement.idl: Adding track getter.
* html/MutableTextTrack.idl: Added.
* html/TextTrack.idl: Added.
* html/TextTrackCue.idl: Added.
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item): Used for [] operator.
* html/TextTrackCueList.h: Added item() for [] operator.
* html/TextTrackCueList.idl: Added.
* page/DOMWindow.idl: Adding TextTrackCue new operator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up tests to not depend on js-test-style.css
arv@chromium.org [Thu, 20 Oct 2011 02:48:38 +0000 (02:48 +0000)]
Clean up tests to not depend on js-test-style.css
https://bugs.webkit.org/show_bug.cgi?id=70462

Reviewed by Ojan Vafai.

* fast/css/limited-vendor-prefix-behavior.html-disabled:
* fast/css/link-disabled-attr-expected.txt:
* fast/css/link-disabled-attr.html:
* fast/dom/Geolocation/page-reload-cancel-permission-requests.html:
* fast/dom/SelectorAPI/caseTagX.xhtml:
* fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html:
* fast/dom/StyleSheet/detached-style-pi.xhtml:
* fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html:
* fast/dom/StyleSheet/gc-declaration-parent-rule.html:
* fast/dom/StyleSheet/gc-parent-rule.html:
* fast/dom/StyleSheet/gc-parent-stylesheet.html:
* fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml:
* fast/dom/Window/window-resize-nan.html-disabled:
* fast/dom/dataset-xhtml.xhtml:
* fast/dom/domListEnumeration-expected.txt:
* fast/dom/domListEnumeration.html:
* fast/dom/script-tests/domListEnumeration.js:
* fast/dom/script-tests/webtiming-document-open.js:
(testTimingWithDocumentOpen):
* fast/dom/title-content-set-innerText-get.xhtml:
* fast/forms/focus-selection-input.html:
* fast/forms/focus-selection-textarea.html:
* fast/forms/option-value-trim-html-spaces.html:
* fast/js/garbage-collect-after-string-appends.html-disabled:
* fast/js/kde/Date.html-disabled:
* fast/js/string-concatenate-outofmemory.html-disabled:
* fast/mutation/observe-attributes.html:
* fast/mutation/observe-characterdata.html:
* platform/chromium/fast/dom/domListEnumeration-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix webkit style on a few files.
commit-queue@webkit.org [Thu, 20 Oct 2011 02:42:45 +0000 (02:42 +0000)]
[chromium] Fix webkit style on a few files.
https://bugs.webkit.org/show_bug.cgi?id=70441

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-19
Reviewed by James Robinson.

Tested with existing layout and unit tests.

* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsMask):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium doesn't support git branch builds, so don't add the branch to the product dir
jochen@chromium.org [Thu, 20 Oct 2011 02:28:38 +0000 (02:28 +0000)]
Chromium doesn't support git branch builds, so don't add the branch to the product dir
https://bugs.webkit.org/show_bug.cgi?id=70449

Reviewed by Eric Seidel.

* Scripts/webkitdirs.pm:
(determineBaseProductDir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Route requestAnimationFrame through CCProxy in threaded mode
nduca@chromium.org [Thu, 20 Oct 2011 02:23:32 +0000 (02:23 +0000)]
[chromium] Route requestAnimationFrame through CCProxy in threaded mode
https://bugs.webkit.org/show_bug.cgi?id=70160

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsAnimate):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::requestAnimate):
* platform/graphics/chromium/cc/CCScheduler.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsAnimate):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsAnimateOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::scheduleAnimation):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scheduleAnimation):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium/mac] Use clang as compiler!
thakis@chromium.org [Thu, 20 Oct 2011 02:15:07 +0000 (02:15 +0000)]
[chromium/mac] Use clang as compiler!
https://bugs.webkit.org/show_bug.cgi?id=70425

Reviewed by Adam Barth.

It looks like http://trac.webkit.org/changeset/97415 was all that's
needed to get this to work.

* gyp_webkit:
Don't force clang off, which means it's now on by default on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WebKit2] Allow sharing page clients between WebViews
mrobinson@webkit.org [Thu, 20 Oct 2011 02:14:56 +0000 (02:14 +0000)]
[GTK] [WebKit2] Allow sharing page clients between WebViews
https://bugs.webkit.org/show_bug.cgi?id=69814

No longer associate WebPage client wrappers with a WebKitWebView. This allows the
same client to be used with more than one WebKitWebView.

Reviewed by Xan Lopez.

* GNUmakefile.am: Add the new WebKitWebViewPrivate header.
* UIProcess/API/gtk/WebKitDefines.h: Added some forward declarations for API classes.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp: C API callbacks now convert their WKPageRef argument
into a WebKitWebView directly and pass it as a parameter to signals. Remove the web-view property.
* UIProcess/API/gtk/WebKitWebLoaderClient.h: Move the estimated-progress property to WebKitWebView.
* UIProcess/API/gtk/WebKitWebView.cpp: Add an estimated-load-progress property.
(webkitWebViewConstructed):Only allocate one default WebKitWebLoaderClient.
(webkitWebViewGetProperty): Add support for the new property.
(webkit_web_view_class_init): Ditto.
(webkitWebViewSetEstimatedLoadProgress): Added this private method so that the WebKitWebLoaderClient
can update the appropriate WebKitWebView.
(webkit_web_view_set_loader_client): Attach the C API callbacks here now.
(webkit_web_view_get_estimated_load_progress): Moved from WebKitWebLoaderClient.
* UIProcess/API/gtk/WebKitWebView.h: Added new method definition.
* UIProcess/API/gtk/WebKitWebViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitDefines.h.
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp: Updated the load tracking tests callbacks to take the new parameter.
(LoadTrackingTest::LoadTrackingTest): Listen to the WebKitWebView property now.
(LoadTrackingTest::estimatedProgressChanged):
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Added a test to verify that two WebViews share the same default client.
* UIProcess/API/gtk/webkit2marshal.list: Updated the marshallers here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Test expectation change.
yuzo@google.com [Thu, 20 Oct 2011 02:13:04 +0000 (02:13 +0000)]
[chromium] Test expectation change.

Unreviewed.

* platform/chromium-cg-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReject invalid MIME type strings for a file selection dialog parameter
tkent@chromium.org [Thu, 20 Oct 2011 02:12:28 +0000 (02:12 +0000)]
Reject invalid MIME type strings for a file selection dialog parameter
https://bugs.webkit.org/show_bug.cgi?id=70095

Reviewed by Darin Fisher and Darin Adler.

No new tests. This affect only a value passed to WebKit layer.

* html/HTMLInputElement.cpp:
(WebCore::isRFC2616TokenCharacter): Added.
(WebCore::HTMLInputElement::acceptMIMETypes):
Validate a MIME type string, and don't add invalid strings to the output Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove OptionElement (first half)
darin@apple.com [Thu, 20 Oct 2011 02:08:10 +0000 (02:08 +0000)]
Remove OptionElement (first half)
https://bugs.webkit.org/show_bug.cgi?id=70276

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring that does not require new tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Use hasTagName
and toHTMLOptionElement instead of toOptionElement.

* dom/OptionElement.cpp: Deleted contents. Remove file later.
* dom/OptionElement.h: Ditto.

* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement): Initialize m_isSelected.
(WebCore::HTMLOptionElement::createForJSConstructor): Initialize the
selected attribute rather than calling setDefaultSelected.
(WebCore::HTMLOptionElement::text): Moved the code here from
OptionElement::collectOptionLabelOrText.
(WebCore::HTMLOptionElement::index): Moved the code here from
OptionElement::optionIndex.
(WebCore::HTMLOptionElement::parseMappedAttribute): Removed unneeded
code to call setValue and setLabel. Changed the code that called
setSelected to instead set m_isSelected and added a FIXME about why
that's probably wrong, but same behavior as before.
(WebCore::HTMLOptionElement::value): Moved the code here from
OptionElement::collectOptionValue. Added a FIXME about incorrect
whitespace stripping.
(WebCore::HTMLOptionElement::selected): Use m_isSelected.
(WebCore::HTMLOptionElement::setSelected): Use m_isSelected and
call setSelectedState instead of OptionElement::setSelectedState.
(WebCore::HTMLOptionElement::setSelectedState): Moved the code
here from OptionElement::setSelectedState.
(WebCore::HTMLOptionElement::label): Streamlined the code.
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
Moved the code here from OptionElement::collectOptionTextRespectingGroupLabel.
(WebCore::HTMLOptionElement::insertedIntoTree): Use m_isSelected
and rewrote comment for clarity.
(WebCore::HTMLOptionElement::collectOptionInnerText): Moved this
here from OptionElement, and changed to use StringBuilder.
(WebCore::toHTMLOptionElement): Added.

* html/HTMLOptionElement.h: Removed OptionElement.h include.
Removed OptionElement base class. Removed unneeded friend declarations.
Made value and selected functions non-virtual. Removed unneeded
defaultSelected and setDefaultSelected functions. Made the
textIndentedToRespectGroupLabel and setSelectedState functions
be non-virtual and public. Added a collectOptionInnerText function.
Replaced m_data with m_value, m_label, and m_selected.

* html/HTMLSelectElement.cpp:
(WebCore::toOptionElement): Added. Helper to keep existing code
close to the same.
(WebCore::HTMLSelectElement::nextValidIndex): Use hasTagName
instead of isOptionElement.
(WebCore::HTMLSelectElement::saveLastSelection): Use HTMLOptionElement
type instead of OptionElement.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
(WebCore::HTMLSelectElement::recalcListItems): Ditto.
(WebCore::HTMLSelectElement::selectedIndex): Ditto.
(WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::optionToListIndex): Ditto.
(WebCore::HTMLSelectElement::listToOptionIndex): Ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
(WebCore::HTMLSelectElement::saveFormControlState): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
(WebCore::HTMLSelectElement::appendFormData): Ditto.
(WebCore::HTMLSelectElement::reset): Ditto.
(WebCore::HTMLSelectElement::updateSelectedState): Ditto.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
(WebCore::HTMLSelectElement::length): Ditto.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement): Use HTMLOptionElement,
hasTagName, and toHTMLOptionElement.
(WebCore::RenderListBox::addFocusRingRects): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
(WebCore::RenderListBox::paintItemBackground): Ditto.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
(WebCore::RenderMenuList::setTextFromOption): Ditto.
(WebCore::RenderMenuList::itemText): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.

Source/WebKit/chromium:

Update hand-written binding for option element so it does not depend on otherwise-unneeded functions.

* src/WebOptionElement.cpp:
(WebKit::WebOptionElement::defaultSelected): Call hasAttribute.
(WebKit::WebOptionElement::setDefaultSelected): Call setAttribute.

* src/WebSearchableFormData.cpp:
(HTMLNames::IsSelectInDefaultState): Call hasAttribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline layout test zoom-animator-scale-test2.html for win, mac
wjmaclean@chromium.org [Thu, 20 Oct 2011 02:06:13 +0000 (02:06 +0000)]
[chromium] Rebaseline layout test zoom-animator-scale-test2.html for win, mac
https://bugs.webkit.org/show_bug.cgi?id=69624

Mark test as SLOW and increase test's internal timeout value to attempt to
eliminate flakiness on WIN GPU.

Reviewed by Kenneth Russell.

* platform/chromium/compositing/zoom-animator-scale-test2.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Adding myself to watchlists.
ojan@chromium.org [Thu, 20 Oct 2011 02:02:52 +0000 (02:02 +0000)]
Unreviewed. Adding myself to watchlists.
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix typos on ewk_view and ewk_js.
commit-queue@webkit.org [Thu, 20 Oct 2011 02:02:26 +0000 (02:02 +0000)]
[EFL] Fix typos on ewk_view and ewk_js.
https://bugs.webkit.org/show_bug.cgi?id=70430

Unreviewed build fix.

Fixes for typos that were introduced when renaming variables to follow
webkit coding style.

Patch by Rafael Antognolli <antognolli@profusion.mobi> on 2011-10-19

* ewk/ewk_js.cpp:
(ewk_js_property_set):
(ewk_js_class_new):
(ewk_js_npobject_to_object):
(ewk_js_object_new):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
* ewk/ewk_view.cpp:
(ewk_view_js_object_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK+ build fix. Rename the INCLUDES variable so it is not picked
kov@webkit.org [Thu, 20 Oct 2011 01:54:19 +0000 (01:54 +0000)]
GTK+ build fix. Rename the INCLUDES variable so it is not picked
up by random bystanders. Also do some more cleanup on stuff we
inherited from gtk-doc.make.

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-10-19

* GNUmakefile.gtk-doc.am:
* docs/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFlush denormals to zero on Windows.
commit-queue@webkit.org [Thu, 20 Oct 2011 01:52:17 +0000 (01:52 +0000)]
Flush denormals to zero on Windows.
https://bugs.webkit.org/show_bug.cgi?id=70140

Patch by Raymond Toy <rtoy@google.com> on 2011-10-19
Reviewed by Kenneth Russell.

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::processWithGainFromMonoStereo):
Flush any denormals to zero before saving the result.  Change
double gain to float gain to match existing float operations.
* platform/audio/DenormalDisabler.h:
(WebCore::DenormalDisabler::flushDenormalFloatToZero):
New function to flush the given float to zero, if it is a denormal
number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Remove the empty paint() implementation in ScrollbarEfl.
commit-queue@webkit.org [Thu, 20 Oct 2011 01:51:13 +0000 (01:51 +0000)]
[EFL] Remove the empty paint() implementation in ScrollbarEfl.
https://bugs.webkit.org/show_bug.cgi?id=70428

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-19
Reviewed by Antonio Gomes.

Remove the empty reimplementation of Scrollbar::paint(), as this would
cause ScrollView::paintScrollbars() to paint nothing at all.

If we have mock scrollbars enabled, this will paint them; otherwise,
the code path will end up in WidgetEfl::paint(), which also does
nothing, so the behavior should not change.

No new tests, this is machinery needed to run the current ones.

* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::frameRectsChanged):
* platform/efl/ScrollbarEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
tkent@chromium.org [Thu, 20 Oct 2011 01:47:45 +0000 (01:47 +0000)]
[Chromium]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=70003

Reviewed by Darin Fisher.

* public/WebFileChooserParams.h:
Add acceptMIMETypes, and make acceptTypes deprecated.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):
- Set WebFileChooserParams::acceptMIMETypes
- Set a joined string to WebFileChooserParams::acceptTypes until we remove acceptTypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update the test expectation file for fullscreen tests.
imasaki@chromium.org [Thu, 20 Oct 2011 01:47:26 +0000 (01:47 +0000)]
[Chromium] Update the test expectation file for fullscreen tests.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Do not always consider a ScrollView will have an Evas/Evas_Object.
commit-queue@webkit.org [Thu, 20 Oct 2011 01:39:48 +0000 (01:39 +0000)]
[EFL] Do not always consider a ScrollView will have an Evas/Evas_Object.
https://bugs.webkit.org/show_bug.cgi?id=70426

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-19
Reviewed by Antonio Gomes.

After r95234 turned on a new code path for the port (we erroneously used
ENABLE_AS_IMAGE instead of ENABLE_SVG_AS_IMAGE before), some tests, such
as compositing/image/direct-svg-image.html or
fast/writing-mode/block-level-images.html started writing stderr
messages about the parent passed to ScrollbarEfl::setParent not having
an Evas.

It turns out that a FrameView can be created in places other than
ewk_frame_view_create_for_view, in which case the view will not have an
Evas or an Evas_Object. This is not an error condition, so we can just
return earlier.

No new tests, this was detected by existing ones.

* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::setParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMultiple crashes in RenderTable during layout
jchaffraix@webkit.org [Thu, 20 Oct 2011 01:36:28 +0000 (01:36 +0000)]
Multiple crashes in RenderTable during layout
https://bugs.webkit.org/show_bug.cgi?id=70392

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/table/crash-anonymous-table-computeLogicalWidth.html
       fast/table/crash-anonymous-table-layout.html

r97555 forgot to take into account anonymous tables during layout
where RenderObject::node() is NULL.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
Added a check for node() before calling Node::hasTagName.

LayoutTests:

* fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt: Added.
* fast/table/crash-anonymous-table-computeLogicalWidth.html: Added.
* fast/table/crash-anonymous-table-layout-expected.txt: Added.
* fast/table/crash-anonymous-table-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate chromium expectations after r97889.
dpranke@chromium.org [Thu, 20 Oct 2011 01:24:39 +0000 (01:24 +0000)]
Update chromium expectations after r97889.

Unreviewed, expectations change.

* platform/chromium-cg-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
* platform/chromium-linux-x86/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
* platform/chromium-linux-x86/fast/parser/entity-end-script-tag-expected.txt: Removed.
* platform/chromium-linux/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
* platform/chromium-linux/fast/parser/entity-end-script-tag-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt.
* platform/chromium-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt.
* platform/chromium-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/parser/entity-end-script-tag-expected.txt.
* platform/chromium-mac/fast/parser/entity-end-script-tag-expected.txt: Removed.
* platform/chromium-win/fast/parser/entity-end-script-tag-expected.txt: Removed.
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
* platform/chromium/fast/parser/entity-end-script-tag-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPoisoning of strict caller,arguments inappropriately poisoning "in"
barraclough@apple.com [Thu, 20 Oct 2011 01:18:03 +0000 (01:18 +0000)]
Poisoning of strict caller,arguments inappropriately poisoning "in"
https://bugs.webkit.org/show_bug.cgi?id=63398

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This fixes the problem by correctly implementing the spec -
the error should actually be being thrown from a standard JS getter/setter.
This implements spec correct behaviour for strict mode JS functions & bound
functions, I'll follow up with a patch to do the same for arguments.

* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::finishCreation):
    - Add the poisoned caller/arguments properties.
* runtime/JSBoundFunction.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):
    - If the caller/arguments are accessed on a strict mode function, lazily add the ThrowTypeError getter.
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::throwTypeErrorGetterSetter):
    - Add a ThrowTypeError type, per ES5 13.2.3.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncThrowTypeError):
* runtime/JSGlobalObjectFunctions.h:
    - Implementation of ThrowTypeError.
* runtime/JSObject.cpp:
(JSC::JSObject::initializeGetterSetterProperty):
* runtime/JSObject.h:
    - This function adds a new property (must not exist already) that is an initialized getter/setter.

LayoutTests:

* fast/js/basic-strict-mode-expected.txt:
* fast/js/script-tests/basic-strict-mode.js:
    - Add tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate MediaStream to use WebCore platform interfaces
commit-queue@webkit.org [Thu, 20 Oct 2011 00:53:21 +0000 (00:53 +0000)]
Update MediaStream to use WebCore platform interfaces
https://bugs.webkit.org/show_bug.cgi?id=68464

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-19
Reviewed by Adam Barth.

Source/WebCore:

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Tests will be provided by http://webkit.org/b/56587

* dom/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
(WebCore::LocalMediaStream::stop):
(WebCore::LocalMediaStream::stopTimerFired):
(WebCore::LocalMediaStream::~LocalMediaStream):
(WebCore::LocalMediaStream::toLocalMediaStream):
* dom/LocalMediaStream.h:
* dom/LocalMediaStream.idl:
* dom/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::readyState):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::scriptExecutionContext):
* dom/MediaStream.h:
(WebCore::MediaStream::label):
(WebCore::MediaStream::tracks):
(WebCore::MediaStream::descriptor):
* dom/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
* dom/MediaStreamTrack.h:
* dom/MediaStreamTrack.idl:
* dom/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::length):
(WebCore::MediaStreamTrackList::item):
* dom/MediaStreamTrackList.h:
* p2p/PeerConnection.cpp:
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::remoteStreamAdded):
* page/MediaStreamClient.h:
* page/MediaStreamController.cpp:
(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::streamGenerated):
* page/MediaStreamController.h:
* page/MediaStreamFrameController.cpp:
(WebCore::MediaStreamFrameController::enterDetachedState):
(WebCore::MediaStreamFrameController::disconnectFrame):
(WebCore::MediaStreamFrameController::streamGenerated):
* page/MediaStreamFrameController.h:

Source/WebKit/chromium:

Removed WebMediaStreamTrack* since they will no longer be needed.

* WebKit.gyp:
* public/WebMediaStreamTrack.h: Removed.
* public/WebMediaStreamTrackList.h: Removed.
* src/WebMediaStreamTrack.cpp: Removed.
* src/WebMediaStreamTrackList.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT 32_64 - improve double boxing/unboxing
commit-queue@webkit.org [Thu, 20 Oct 2011 00:48:22 +0000 (00:48 +0000)]
DFG JIT 32_64 - improve double boxing/unboxing
https://bugs.webkit.org/show_bug.cgi?id=70418

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-19
Reviewed by Gavin Barraclough.

Double boxing/unboxing in DFG JIT 32_64 is currently implemented inefficiently,
which tries to exchange data through memory.
On X86 some SSE instructions can help us on such operations with better performance.
This improves 32-bit DFG performance by 29% on Kraken, 7% on SunSpider,
and 2% on V8, tested on Linux X86 (Core i7 Nehalem).

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::lshiftPacked):
(JSC::MacroAssemblerX86Common::rshiftPacked):
(JSC::MacroAssemblerX86Common::orPacked):
(JSC::MacroAssemblerX86Common::moveInt32ToPacked):
(JSC::MacroAssemblerX86Common::movePackedToInt32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movd_rr):
(JSC::X86Assembler::psllq_i8r):
(JSC::X86Assembler::psrlq_i8r):
(JSC::X86Assembler::por_rr):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Shorten animation time for ZoomAnimator.
wjmaclean@chromium.org [Thu, 20 Oct 2011 00:44:28 +0000 (00:44 +0000)]
[chromium] Shorten animation time for ZoomAnimator.
https://bugs.webkit.org/show_bug.cgi?id=70419

Reviewed by Kenneth Russell.

Shorten animation time for ZoomAnimator.

Existing test coverage sufficient.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::zoom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Streamline wk1 documentation build
kov@webkit.org [Thu, 20 Oct 2011 00:35:07 +0000 (00:35 +0000)]
[GTK] Streamline wk1 documentation build
https://bugs.webkit.org/show_bug.cgi?id=70447

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: include the documentation's GNUmakefile.am;
* autogen.sh: we no longer call gtkdocize, since we now ship
  a modified gtk-doc.make;
* configure.ac: no longer generate a separate GNUmakefile for
  the documentation build.

Source/WebKit/gtk:

* GNUmakefile.am: move files pertaining to the docs build to the
  docs GNUmakefile.am;
* GNUmakefile.gtk-doc.make: incorporate the gtk-doc makefile, and customize it
  to our non-recursive build;
* docs/GNUmakefile.am: simplification and adaption to work with the
  rest of the build system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix DSO linkage of wtf_efl.
gyuyoung.kim@samsung.com [Thu, 20 Oct 2011 00:30:41 +0000 (00:30 +0000)]
[EFL] Fix DSO linkage of wtf_efl.

Unreviewed build fix.

Need to add -ldl to jsc_efl (requested by dladdr).

* wtf/CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test breakage after r97881
arv@chromium.org [Thu, 20 Oct 2011 00:11:10 +0000 (00:11 +0000)]
Fix test breakage after r97881

* fast/forms/file/file-input-change-event-expected.txt:
* fast/forms/file/file-input-change-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd win baseline for new test.
dpranke@chromium.org [Thu, 20 Oct 2011 00:08:00 +0000 (00:08 +0000)]
Add win baseline for new test.

Unreviewed, expectations change.

* platform/chromium-win/fast/multicol/flipped-blocks-border-after-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Chromium build.
bdakin@apple.com [Thu, 20 Oct 2011 00:01:10 +0000 (00:01 +0000)]
Try to fix the Chromium build.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement WEBGL_debug_shaders and WEBGL_debug_renderer_info extensions
zmo@google.com [Wed, 19 Oct 2011 23:58:55 +0000 (23:58 +0000)]
Implement WEBGL_debug_shaders and WEBGL_debug_renderer_info extensions
https://bugs.webkit.org/show_bug.cgi?id=70077

Reviewed by Kenneth Russell.

Source/WebCore:

* WebCore.gypi: added new extension class files.
* WebCore.xcodeproj/project.pbxproj: ditto.
* WebCore.pro: ditto.
* CMakeLists.txt: ditto.
* GNUmakefile.list.am: ditto.
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS): Handles two new extensions.
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object): Ditto.
* html/canvas/WebGLDebugRendererInfo.cpp: Added.
(WebCore::WebGLDebugRendererInfo::WebGLDebugRendererInfo):
(WebCore::WebGLDebugRendererInfo::~WebGLDebugRendererInfo):
(WebCore::WebGLDebugRendererInfo::getName):
(WebCore::WebGLDebugRendererInfo::create):
* html/canvas/WebGLDebugRendererInfo.h: Added.
* html/canvas/WebGLDebugRendererInfo.idl: Added.
* html/canvas/WebGLDebugShaders.cpp: Added.
(WebCore::WebGLDebugShaders::WebGLDebugShaders):
(WebCore::WebGLDebugShaders::~WebGLDebugShaders):
(WebCore::WebGLDebugShaders::getName):
(WebCore::WebGLDebugShaders::create):
(WebCore::WebGLDebugShaders::getTranslatedShaderSource):
* html/canvas/WebGLDebugShaders.h: Added.
* html/canvas/WebGLDebugShaders.idl: Added.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::allowPrivilegedExtensions): To be implemented - deciding whether the two extensions should be allowed or not.
(WebCore::WebGLRenderingContext::getExtension): Handles two new extensions.
(WebCore::WebGLRenderingContext::getParameter): Handles UNMASKED_VENDOR_WEBGL / UNMASKED_RENDERER_WEBGL
(WebCore::WebGLRenderingContext::getSupportedExtensions): Handles two new extensions.
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/Extensions3D.h: Ditto.
* platform/graphics/GraphicsTypes3D.h: Add GC3Dchar.
* platform/graphics/chromium/Extensions3DChromium.h: Handles two new extensions.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto.
(WebCore::getTranslatedShaderSourceANGLE):
* platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
* platform/graphics/qt/Extensions3DQt.cpp: Ditto.
(WebCore::Extensions3DQt::getTranslatedShaderSourceANGLE):
* platform/graphics/qt/Extensions3DQt.h: Ditto.

Source/WebKit/chromium:

* public/WebGraphicsContext3D.h: Added support for getTranslatedShaderSourceANGLE.
(WebKit::WebGraphicsContext3D::getTranslatedShaderSourceANGLE):
* src/Extensions3DChromium.cpp: Ditto.
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
* src/GraphicsContext3DChromium.cpp: Ditto.
* src/GraphicsContext3DPrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhite flash when painting a previously crashed WKView
andersca@apple.com [Wed, 19 Oct 2011 23:58:30 +0000 (23:58 +0000)]
White flash when painting a previously crashed WKView
https://bugs.webkit.org/show_bug.cgi?id=70453
<rdar://problem/10306906>

Reviewed by John Sullivan.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
Call waitForBackingStoreUpdateOnNextPaint so we'll wait for the next paint instead of painting white.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved StringImplBase, fusing it into StringImpl
ggaren@apple.com [Wed, 19 Oct 2011 23:55:48 +0000 (23:55 +0000)]
Removed StringImplBase, fusing it into StringImpl
https://bugs.webkit.org/show_bug.cgi?id=70443

Reviewed by Gavin Barraclough.

../JavaScriptCore:

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::ref):
(WTF::StringImpl::length):
* wtf/text/StringImplBase.h: Removed.
* wtf/wtf.pri: Removed!

../JavaScriptGlue:

* ForwardingHeaders/wtf/text/StringImplBase.h: Removed.

../WebCore:

* ForwardingHeaders/runtime/RopeImpl.h: Removed.
* ForwardingHeaders/wtf/text/StringImplBase.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoArrayBuffer should have slice method.
commit-queue@webkit.org [Wed, 19 Oct 2011 23:31:12 +0000 (23:31 +0000)]
ArrayBuffer should have slice method.
https://bugs.webkit.org/show_bug.cgi?id=66646

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-19
Reviewed by Kenneth Russell.

Source/WebCore:

* html/canvas/ArrayBuffer.cpp:
(WebCore::clampValue):
(WebCore::ArrayBuffer::slice):
(WebCore::ArrayBuffer::sliceImpl):
(WebCore::ArrayBuffer::clampIndex):
* html/canvas/ArrayBuffer.h: Added declaration.
* html/canvas/ArrayBuffer.idl: Added interface.

LayoutTests:

* fast/canvas/webgl/array-unit-tests.html: Aded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd getConstructData to the MethodTable
mhahnenberg@apple.com [Wed, 19 Oct 2011 23:27:47 +0000 (23:27 +0000)]
Add getConstructData to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70163

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Adding getConstructData to the MethodTable in order to be able to
remove all calls to getConstructDataVirtual soon.  Part of the process
of de-virtualizing JSCell.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:

Source/WebCore:

No new tests.

Adding getConstructData to the MethodTable in order to be able to
remove all calls to getConstructDataVirtual soon.  Part of the process
of de-virtualizing JSCell.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a suggest-nominations command to webkit-patch for computing potential committer...
commit-queue@webkit.org [Wed, 19 Oct 2011 23:25:12 +0000 (23:25 +0000)]
Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=62166

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-10-19
Reviewed by Eric Seidel.

Included options to control committer/reviewer patch count requirements,
an age-limit on patches, and verbose output for more in-depth analysis.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/tool/commands/__init__.py:
* Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
* Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r97850.
dpranke@chromium.org [Wed, 19 Oct 2011 23:02:57 +0000 (23:02 +0000)]
Unreviewed, rolling out r97850.
http://trac.webkit.org/changeset/97850
https://bugs.webkit.org/show_bug.cgi?id=70334

tests are crashing on xp debug

Source/WebKit/chromium:

* DEPS:

LayoutTests:

* http/tests/inspector/extensions-headers.html:
* http/tests/inspector/resources/extension-main.js:
():
* inspector/extensions/extensions-audits.html:
* inspector/extensions/extensions-console.html:
* inspector/extensions/extensions-resources.html:
* platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update the test expectations for r97881.
arv@chromium.org [Wed, 19 Oct 2011 22:54:44 +0000 (22:54 +0000)]
[Chromium] Update the test expectations for r97881.

* platform/chromium-cg-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Added.
* platform/chromium-linux-x86/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
* platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
* platform/chromium-linux-x86/fast/parser/entity-end-script-tag-expected.txt: Added.
* platform/chromium-linux/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
* platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
* platform/chromium-linux/fast/parser/entity-end-script-tag-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect pagination in flipped-blocks writing modes with border/padding before
mitz@apple.com [Wed, 19 Oct 2011 22:42:12 +0000 (22:42 +0000)]
Incorrect pagination in flipped-blocks writing modes with border/padding before
https://bugs.webkit.org/show_bug.cgi?id=70444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/flipped-blocks-border-after.html

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Account for flipped blocks when adjusting the page offset.

LayoutTests:

* fast/multicol/flipped-blocks-border-after-expected.png: Added.
* fast/multicol/flipped-blocks-border-after-expected.txt: Added.
* fast/multicol/flipped-blocks-border-after.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed...
eric@webkit.org [Wed, 19 Oct 2011 22:40:18 +0000 (22:40 +0000)]
new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
Make NRWT normalize directory names in Skipped files during parsing.

Unreviewed.  Very simple (tested) change.

* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=70396
bdakin@apple.com [Wed, 19 Oct 2011 22:37:17 +0000 (22:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70396
Focus rings are too thin in HiDPI in WebKit2
-and corresponding-
<rdar://problem/10086876>

Reviewed by Dan Bernstein.

Source/WebCore:

Rename wkSetPatternBaseCTM to wkSetBaseCTM
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

New CG-only function calls into wkSetBaseCTM.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setBaseCTM):

Call GraphicsContext::setBaseCTM() rather than calling into WebKitSystemInterface
directly.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

Source/WebKit/mac:

Rename wkSetPatternBaseCTM to wkSetBaseCTM
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

To create a HiDPI context in DRT, we have to set the base CTM, which currently
requires CG SPI, so we have to do it through WebKitSystemInterface.
* WebView/WebView.mm:
(-[WebView _setBaseCTM:forContext:]):
* WebView/WebViewPrivate.h:

Source/WebKit2:

Rename wkSetPatternBaseCTM to wkSetBaseCTM
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

When setting up a HiDPI context, we must also set the base CTM.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):
(WebKit::WebPage::snapshotInViewCoordinates):

WebKitLibraries:

Renamed an existing WebKitSystemInterface function.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

LayoutTests:

* fast/hidpi/focus-rings.html: Added.
* platform/mac/fast/hidpi/focus-rings-expected.png: Added.
* platform/mac/fast/hidpi/focus-rings-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowatchlist: Should be more robust to bad regex.
levin@chromium.org [Wed, 19 Oct 2011 22:33:39 +0000 (22:33 +0000)]
watchlist: Should be more robust to bad regex.
https://bugs.webkit.org/show_bug.cgi?id=69486

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/watchlist: Change the instructions due to
  watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
  patterns since they are no longer anchored on the right hand side.
* Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
* Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
* Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
* Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
* Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
* Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
filenames are no longer anchored on the right hand side.
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
don't kill everything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowatchlist: Add a stylecheck to do validity checks for the watchlist config.
levin@chromium.org [Wed, 19 Oct 2011 22:31:55 +0000 (22:31 +0000)]
watchlist: Add a stylecheck to do validity checks for the watchlist config.
https://bugs.webkit.org/show_bug.cgi?id=69487

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checker.py: Add the watchlist file type.
* Scripts/webkitpy/style/checkers/watchlist.py: Added.
* Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebVTTParser to require at least one space between timestamps and arrows,...
annacc@chromium.org [Wed, 19 Oct 2011 22:30:04 +0000 (22:30 +0000)]
Update WebVTTParser to require at least one space between timestamps and arrows, e.g.:
00:04:01.000 --> 00:03:00.500 is OK
00:04:01.000-->00:03:00.500 is not OK
https://bugs.webkit.org/show_bug.cgi?id=70274

Reviewed by Eric Carlson.

Existing tests:
media/track/track-webvtt-tc008-timings-no-hours.html
(see media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt #6)
media/track/track-webvtt-tc009-timings-hour.html
(see media/track/captions-webvtt/tc009-timings-hour-error.vtt #6)

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectTimingsAndSettings): Check that the
    character before and after the '-->' is a space character

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd skeleton of an Objective-C WebKit2 API
weinig@apple.com [Wed, 19 Oct 2011 22:03:41 +0000 (22:03 +0000)]
Add skeleton of an Objective-C WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=70438

Reviewed by Anders Carlsson.

Adds WKBrowsingContextController (WKPageRef wrapper) and WKProcessCluster
(WKContextRef wrapper) as initial files of an Objective-C WebKit2 API. Also,
hook them up so that you can get a WKBrowsingContextController from the WKView
and you can create a WKView associated with a WKProcessCluster. These names are
not final, and this work is mainly about getting the wrapper lifetimes worked
out.

* UIProcess/API/mac/WKBrowsingContextController.h: Added.
* UIProcess/API/mac/WKBrowsingContextController.mm: Added.
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController pageRef]):
(-[WKBrowsingContextController loadRequest:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController initWithPageRef:]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Added.
Add wrapper for WKPageRef.

* UIProcess/API/mac/WKProcessCluster.h: Added.
* UIProcess/API/mac/WKProcessCluster.mm: Added.
(-[WKProcessCluster init]):
(-[WKProcessCluster initWithInjectedBundleURL:]):
(-[WKProcessCluster dealloc]):
(-[WKProcessCluster contextRef]):
* UIProcess/API/mac/WKProcessClusterInternal.h: Added.
Add wrapper for WKContextRef.

* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processCluster:]):
Add new init method which takes a WKProcessCluster.

(-[WKView browsingContextController]):
Add accessor for the WKBrowsingContextController. This works by lazily creating
the wrapper and caching it in the view itself.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Insert the stylesheet dynamically
arv@chromium.org [Wed, 19 Oct 2011 21:54:38 +0000 (21:54 +0000)]
JS Test Harness: Insert the stylesheet dynamically
https://bugs.webkit.org/show_bug.cgi?id=70432

Reviewed by Ojan Vafai.

This injects the js-test-style.css file dynamically so that the test files can be simpler.
This patch also removes the markup from the existing files in LayoutTests/fast/

* fast/*.html: Remove <link rel=:"stylesheet" href="...js-test-style.css">
* fast/js/resources/js-test-pre.js: Inject the stylesheet dynamically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing expectations updates for r97878.
dcheng@chromium.org [Wed, 19 Oct 2011 21:44:22 +0000 (21:44 +0000)]
Add missing expectations updates for r97878.

* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT ServerProcess can't read lines from stderr and stdio separately
eric@webkit.org [Wed, 19 Oct 2011 21:38:25 +0000 (21:38 +0000)]
NRWT ServerProcess can't read lines from stderr and stdio separately
https://bugs.webkit.org/show_bug.cgi?id=70435

Reviewed by Adam Barth.

This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
DRT expects RWT to read one line at a time from stderr and stdout independently.
This allows DRT to communicate errors over stderr and have them responded to immediately
regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
class only exposed a read_line function which would read a line from stdout
and batch all output from stderr into an error buffer.  Callers would only be able
to respond to commands over stderr if they happened to correspond with a stdout line boundary.

* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't always select images during an image drag.
dcheng@chromium.org [Wed, 19 Oct 2011 21:38:03 +0000 (21:38 +0000)]
Don't always select images during an image drag.
https://bugs.webkit.org/show_bug.cgi?id=62998

Reviewed by Tony Chang.

Source/WebCore:

Only select an image being dragged if it is contenteditable.

Test: fast/events/drag-selects-image.html

* dom/Node.cpp:
(WebCore::Node::isContentRichlyEditable):
* dom/Node.h:
* page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):

LayoutTests:

* fast/events/drag-selects-image-expected.txt: Added.
* fast/events/drag-selects-image.html: Added.
* platform/chromium-win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/chromium-win/editing/selection/drag-to-contenteditable-iframe-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLBodyElement: Simplify link/alink/vlink attribute parsing.
andreas.kling@nokia.com [Wed, 19 Oct 2011 21:28:36 +0000 (21:28 +0000)]
HTMLBodyElement: Simplify link/alink/vlink attribute parsing.
https://bugs.webkit.org/show_bug.cgi?id=70429

Reviewed by Antonio Gomes.

Instead of carrying around a CSSMutableStyleDeclaration with the body element,
just use CSSParser::parseColor() to parse the three link color attributes.

* html/HTMLBodyElement.h:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::~HTMLBodyElement):

    Remove HTMLBodyElement::m_linkDecl and all the voodoo that went along with it.

(WebCore::HTMLBodyElement::parseMappedAttribute):

    Use CSSParser directly to parse the color values for {link,alink,vlink}Attr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport CanvasPixelArray in the DFG
oliver@apple.com [Wed, 19 Oct 2011 21:25:10 +0000 (21:25 +0000)]
Support CanvasPixelArray in the DFG
https://bugs.webkit.org/show_bug.cgi?id=70384

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add support for the old CanvasPixelArray optimisations to the
DFG.  This removes the regression seen in the DFG when using
a CPA.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::truncateDoubleToInt32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movb_rm):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isByteArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateByteArray):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::compileClampDoubleToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSByteArray.h:
(JSC::JSByteArray::offsetOfStorage):
* wtf/ByteArray.cpp:
* wtf/ByteArray.h:
(WTF::ByteArray::offsetOfSize):
(WTF::ByteArray::offsetOfData):

Source/WebCore:

Make CanvasPixelArray inherit from ByteArray's ClassInfo so
can identify it more sensibly.

* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Disable fullscreen api on Qt by default
chang.shu@nokia.com [Wed, 19 Oct 2011 21:07:42 +0000 (21:07 +0000)]
[Qt] Disable fullscreen api on Qt by default
https://bugs.webkit.org/show_bug.cgi?id=70413

Reviewed by Noam Rosenthal.

Source/WebCore:

As the WebKit side of implementation for fullscreen api feature has not been done yet,
we'd better turn off the feature on the WebCore side by default.

* features.pri:

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update the test expectation file for fullscreen related tests.
imasaki@chromium.org [Wed, 19 Oct 2011 20:34:34 +0000 (20:34 +0000)]
[Chromium] Update the test expectation file for fullscreen related tests.
https://bugs.webkit.org/show_bug.cgi?id=70378

Reviewed by David Levin.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-10-19 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 19 Oct 2011 20:22:09 +0000 (20:22 +0000)]
2011-10-19  Dirk Schulze  <krit@webkit.org>

        Unreviewed, rolling out r97867.
        http://trac.webkit.org/changeset/97863
        https://bugs.webkit.org/show_bug.cgi?id=65769

        Rollout rebaseline of RenderSVGShape patch after assertions in RenderSVGShape::createShape().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSome rope cleanup following r97827
ggaren@apple.com [Wed, 19 Oct 2011 19:45:35 +0000 (19:45 +0000)]
Some rope cleanup following r97827
https://bugs.webkit.org/show_bug.cgi?id=70398

Reviewed by Oliver Hunt.

9% speedup on date-format-xparb, neutral overall.

- Removed RopeImpl*.
- Removed JSString::m_fiberCount, since this can be deduced from other data.
- Renamed a jsString() variant to jsStringFromArguments for clarity.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.order:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Removed RopeImpl*.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadCharacterString):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::loadJSStringArgument):
* jit/ThunkGenerators.cpp:
(JSC::stringCharLoad): Use a NULL m_value to signal rope-iness, instead
of testing m_fiberCount, since m_fiberCount is gone now.

* runtime/JSString.cpp:
(JSC::JSString::RopeBuilder::expand):
(JSC::JSString::visitChildren):
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Use a NULL fiber to indicate "last fiber
in the vector" instead of testing m_fiberCount, since m_fiberCount is gone now.

* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::offsetOfLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::string): Removed m_fiberCount. Renamed
jsString => jsStringFromArguments for clarity.

* runtime/Operations.h:
(JSC::jsStringFromArguments): Renamed.

* runtime/RopeImpl.cpp: Removed.
* runtime/RopeImpl.h: Removed.

* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString): Switched to StringImpl::empty,
which is slightly faster.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncConcat): Updated for rename.

* wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase): Removed the concept of an invalid
StringImpl, since this was only used by RopeImpl, which is now gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk][Geolocation] Build guards missing in geolocation clients
kov@webkit.org [Wed, 19 Oct 2011 18:54:51 +0000 (18:54 +0000)]
[Gtk][Geolocation] Build guards missing in geolocation clients
https://bugs.webkit.org/show_bug.cgi?id=70420

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-10-19
Reviewed by Gustavo Noronha Silva.

Adds build guards that were forgotten when client-based
geolocation was introduced in r97746. This should make builds
without geolocation support succeed again.

* WebCoreSupport/GeolocationClientGtk.cpp:
* WebCoreSupport/GeolocationClientGtk.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r97863.
krit@webkit.org [Wed, 19 Oct 2011 17:44:44 +0000 (17:44 +0000)]
Unreviewed, rolling out r97863.
http://trac.webkit.org/changeset/97863
https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Rollout

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::contains):
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGPath):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/svg/RenderSVGAllInOne.cpp:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::isGraphicsElement):
* rendering/svg/RenderSVGPath.cpp:
(WebCore::BoundingRectStrokeStyleApplier::BoundingRectStrokeStyleApplier):
(WebCore::BoundingRectStrokeStyleApplier::strokeStyle):
(WebCore::RenderSVGPath::RenderSVGPath):
(WebCore::RenderSVGPath::fillContains):
(WebCore::RenderSVGPath::strokeContains):
(WebCore::RenderSVGPath::layout):
(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::zeroLengthSubpathRect):
(WebCore::RenderSVGPath::setupSquareCapPath):
(WebCore::RenderSVGPath::setupNonScalingStrokePath):
(WebCore::RenderSVGPath::fillAndStrokePath):
(WebCore::RenderSVGPath::paint):
(WebCore::RenderSVGPath::addFocusRingRects):
(WebCore::RenderSVGPath::nodeAtFloatPoint):
(WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
(WebCore::RenderSVGPath::updateCachedBoundaries):
* rendering/svg/RenderSVGPath.h:
(WebCore::RenderSVGPath::path):
(WebCore::RenderSVGPath::setNeedsPathUpdate):
(WebCore::RenderSVGPath::setNeedsBoundariesUpdate):
(WebCore::RenderSVGPath::setNeedsTransformUpdate):
(WebCore::RenderSVGPath::objectBoundingBox):
(WebCore::RenderSVGPath::strokeBoundingBox):
(WebCore::RenderSVGPath::repaintRectInLocalCoordinates):
(WebCore::RenderSVGPath::localToParentTransform):
(WebCore::RenderSVGPath::localTransform):
(WebCore::toRenderSVGPath):
* rendering/svg/RenderSVGRect.cpp: Removed.
* rendering/svg/RenderSVGRect.h: Removed.
* rendering/svg/RenderSVGResource.h:
(WebCore::RenderSVGResource::postApplyResource):
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::postApplyResource):
* rendering/svg/RenderSVGResourcePattern.h:
* rendering/svg/RenderSVGResourceSolidColor.cpp:
(WebCore::RenderSVGResourceSolidColor::postApplyResource):
* rendering/svg/RenderSVGResourceSolidColor.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
* rendering/svg/RenderSVGShape.cpp: Removed.
* rendering/svg/RenderSVGShape.h: Removed.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::releasePaintingResource):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::prepareToRenderSVGContent):
(WebCore::SVGRenderSupport::finishRenderSVGContent):
(WebCore::SVGRenderSupport::layoutChildren):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
(WebCore::operator<<):
(WebCore::write):
* rendering/svg/SVGRenderTreeAsText.h:
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
* svg/SVGPathElement.h:
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):
* svg/SVGRectElement.h:

LayoutTests:

Rollout RenderSVGShape patch after assertions in RenderSVGShape::createShape().

* svg/custom/pointer-events-on-rounded-rect-expected.txt: Removed.
* svg/custom/pointer-events-on-rounded-rect.xhtml: Removed.
* svg/custom/pointer-events-with-linecaps-and-miterlimits-expected.txt: Removed.
* svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: rebaseline remaining diffs for Chromium-Skia on
caryclark@google.com [Wed, 19 Oct 2011 17:12:27 +0000 (17:12 +0000)]
Unreviewed gardening: rebaseline remaining diffs for Chromium-Skia on
SnowLeopard.

* platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png:
* platform/chromium-gpu-mac/compositing/plugins/composited-plugin-expected.png:
* platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png:
* platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.png:
* platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/plugins: Added.
* platform/chromium-gpu-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
* platform/chromium-gpu-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
* platform/chromium-gpu-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png:
* platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: worker inspector title should contain worker URL
yurys@chromium.org [Wed, 19 Oct 2011 17:02:53 +0000 (17:02 +0000)]
Web Inspector: worker inspector title should contain worker URL
https://bugs.webkit.org/show_bug.cgi?id=70424

Worker inspector title is now evaluated when the front-end starts.

Reviewed by Pavel Feldman.

* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager._calculateWorkerInspectorTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline SVG related tests after r97863.
reni@webkit.org [Wed, 19 Oct 2011 16:29:56 +0000 (16:29 +0000)]
Unreviewed, rebaseline SVG related tests after r97863.

Patch by Renata Hodovan <reni@webkit.org> on 2011-10-19

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Support WK1-only Skipped list
chang.shu@nokia.com [Wed, 19 Oct 2011 15:37:50 +0000 (15:37 +0000)]
[Qt] Support WK1-only Skipped list
https://bugs.webkit.org/show_bug.cgi?id=70254

Reviewed by Csaba Osztrogon√°c.

Tools:

Added a new search path qt-wk1 for skipping WK1-only tests.

* Scripts/webkitpy/layout_tests/port/qt.py: NRWT
* Scripts/old-run-webkit-tests: ORWT

LayoutTests:

* platform/qt-wk1: Added.
* platform/qt-wk1/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Avoid unecessarily calling gtk_widget_size_allocate on plugin widgets
mrobinson@webkit.org [Wed, 19 Oct 2011 15:25:15 +0000 (15:25 +0000)]
[GTK] Avoid unecessarily calling gtk_widget_size_allocate on plugin widgets
https://bugs.webkit.org/show_bug.cgi?id=70190

Reviewed by Xan Lopez.

Instead of always calling gtk_widget_size_allocate on every single plugin
widget during scrolling, only call it on widgets that are both in the view
and that have moved.

No new tests. It's difficult to test scrolling performance in an
automated way.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setNPWindowIfNeeded): Reverse the if statement detecting a
clipped out plugin. It was incorrect.
(WebCore::PluginView::updateWidgetAllocationAndClip): If the current allocation of
the plugin widget has not changed or if the widget remains scrolled out, do not call
gtk_widget_size_allocate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix DSO linkage of jsc_efl.
commit-queue@webkit.org [Wed, 19 Oct 2011 15:13:49 +0000 (15:13 +0000)]
[EFL] Fix DSO linkage of jsc_efl.
https://bugs.webkit.org/show_bug.cgi?id=70412

Unreviewed build fix.

Need to add -ldl to jsc_efl (requested by dladdr).

Patch by Rafael Antognolli <antognolli@profusion.mobi> on 2011-10-19

* shell/CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new renderer for SVGRectElement.
reni@webkit.org [Wed, 19 Oct 2011 14:59:55 +0000 (14:59 +0000)]
Add new renderer for SVGRectElement.
https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Patch by Renata Hodovan <reni@webkit.org> on 2011-10-19
Reviewed by Dirk Schulze.

This patch introduces a new common base class called RenderSVGShape which
replaces the RenderSVGPath. This new base class has the same purpose
as the replaced class and has specialized descendants for common
shapes (like Rectangles and Circles), which allows faster painting
of these shapes when certain conditions are fulfilled. On some
benchmark programs we have seen 5% speedup.

The biggest motivation of this refactor is taking advantage
of faster primitive drawing in the most common and frequent
cases. However in some rare cases, like painting rounded
rects, we need to fallback to the original code path, which
is fully kept in the RenderSVGShape base class. Some other
cases, like dashed strokes, can be painted but mouse pointer
events cannot be handled by the descendant classes. A different
fallback mechanism is used in such cases which redirects
only the pointer event handling to the base class.

Tests: svg/custom/pointer-events-on-rounded-rect.xhtml
       svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::contains):
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::contains):
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGRect):
(WebCore::RenderObject::isSVGShape):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/svg/RenderSVGAllInOne.cpp:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::isGraphicsElement):
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
(WebCore::RenderSVGPath::inflateWithMarkerBounds): Unite the markerBounds with strokeBoundingBox.
* rendering/svg/RenderSVGPath.h:
* rendering/svg/RenderSVGRect.cpp: Added.
(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::~RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):
* rendering/svg/RenderSVGRect.h: Added.
(WebCore::RenderSVGRect::isSVGRect):
(WebCore::RenderSVGRect::renderName):
(WebCore::RenderSVGRect::isEmpty):
* rendering/svg/RenderSVGResource.h:
(WebCore::RenderSVGResource::postApplyResource): A new shape argument was added to allow shape specific faster painting.
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::postApplyResource):
* rendering/svg/RenderSVGResourcePattern.h:
* rendering/svg/RenderSVGResourceSolidColor.cpp:
(WebCore::RenderSVGResourceSolidColor::postApplyResource):
* rendering/svg/RenderSVGResourceSolidColor.h:
* rendering/svg/RenderSVGShape.cpp: Copied from Source/WebCore/rendering/svg/RenderSVGPath.cpp.
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::~RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):
(WebCore::RenderSVGShape::strokeShape):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
The purpose of this virtual function allows decendants to use their own fast checks.
(WebCore::RenderSVGShape::shapeDependentFillContains):
The purpose of this virtual function allows decendants to use their own fast checks.
(WebCore::RenderSVGShape::fillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::setupSquareCapPath):
(WebCore::RenderSVGShape::setupNonScalingStrokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::addFocusRingRects):
(WebCore::RenderSVGShape::nodeAtFloatPoint):
(WebCore::RenderSVGShape::calculateMarkerBoundsIfNeeded):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::strokeWidth):
* rendering/svg/RenderSVGShape.h: Copied from Source/WebCore/rendering/svg/RenderSVGPath.h.
(WebCore::BoundingRectStrokeStyleApplier::BoundingRectStrokeStyleApplier):
(WebCore::BoundingRectStrokeStyleApplier::strokeStyle):
(WebCore::RenderSVGShape::setNeedsShapeUpdate):
(WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
(WebCore::RenderSVGShape::setNeedsTransformUpdate):
(WebCore::RenderSVGShape::isPaintingFallback):
(WebCore::RenderSVGShape::path):
(WebCore::RenderSVGShape::setIsPaintingFallback):
(WebCore::RenderSVGShape::setStrokeAndMarkerBoundingBox):
(WebCore::RenderSVGShape::hasPath):
(WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
(WebCore::RenderSVGShape::localToParentTransform):
(WebCore::RenderSVGShape::localTransform):
(WebCore::RenderSVGShape::isSVGShape):
(WebCore::RenderSVGShape::renderName):
(WebCore::RenderSVGShape::isRoundedRect):
(WebCore::RenderSVGShape::inflateWithMarkerBounds):
(WebCore::toRenderSVGShape):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::releasePaintingResource):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::finishRenderSVGContent):
(WebCore::SVGRenderSupport::layoutChildren):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
(WebCore::operator<<):
(WebCore::write):
* rendering/svg/SVGRenderTreeAsText.h:
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::createRenderer):
* svg/SVGPathElement.h:
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):
(WebCore::SVGRectElement::createRenderer):
* svg/SVGRectElement.h:

LayoutTests:

Add new tests to check the new shape based rendering mechanism of SVGRectElement.

Patch by Renata Hodovan <reni@webkit.org> on 2011-10-19
Reviewed by Dirk Schulze.

* svg/custom/pointer-events-on-rounded-rect-expected.txt: Added.
* svg/custom/pointer-events-on-rounded-rect.xhtml: Added.
* svg/custom/pointer-events-with-linecaps-and-miterlimits-expected.txt: Added.
* svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinspector/cookie-parser.html is a flaky crash
kbalazs@webkit.org [Wed, 19 Oct 2011 14:50:34 +0000 (14:50 +0000)]
inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

Unreviewed gardening. Skip the next test that have became crashing after
skipping cookie-parser in the hope that the bug won't spread further.

* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline.
philn@webkit.org [Wed, 19 Oct 2011 14:33:28 +0000 (14:33 +0000)]
Unreviewed, GTK rebaseline.

* platform/gtk/fast/block/margin-collapse/010-expected.txt:
* platform/gtk/fast/block/margin-collapse/011-expected.txt:
* platform/gtk/fast/block/margin-collapse/012-expected.txt:
* platform/gtk/fast/block/margin-collapse/015-expected.txt:
* platform/gtk/fast/block/margin-collapse/016-expected.txt:
* platform/gtk/fast/block/margin-collapse/020-expected.txt:
* platform/gtk/fast/block/margin-collapse/056-expected.txt:
* platform/gtk/fast/block/margin-collapse/059-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix failing tests after migrating to refactored Qt5
ossy@webkit.org [Wed, 19 Oct 2011 14:30:44 +0000 (14:30 +0000)]
[Qt] Fix failing tests after migrating to refactored Qt5
https://bugs.webkit.org/show_bug.cgi?id=69104

Move tests from qt-wk2/Skipped to qt-5.0, because these
fails are related to Qt 5, not to Qt-WK2.

Unreviewed gardening.

* platform/qt-5.0/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2 inspector/extensions tests times out on Mac after r97850 https://bugs.webkit.org...
kbalazs@webkit.org [Wed, 19 Oct 2011 14:12:33 +0000 (14:12 +0000)]
2 inspector/extensions tests times out on Mac after r97850 https://bugs.webkit.org/show_bug.cgi?id=70414

Unreviewed gardening.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Skipping test permanently because it is out of date to the current spec.
ossy@webkit.org [Wed, 19 Oct 2011 14:09:49 +0000 (14:09 +0000)]
[Qt] Skipping test permanently because it is out of date to the current spec.
https://bugs.webkit.org/show_bug.cgi?id=68796

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-19
Reviewed by Csaba Osztrogon√°c.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97858 268f45cc-cd09-0410-ab3c-d52691b4dbfc