15 years agoRemove redundant line.
staikos [Thu, 29 Mar 2007 18:44:02 +0000 (18:44 +0000)]
Remove redundant line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agocorrect the changelog entry for the patch author.
staikos [Thu, 29 Mar 2007 17:07:25 +0000 (17:07 +0000)]
correct the changelog entry for the patch author.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Take into account the entire run length to get a proper selection.
staikos [Thu, 29 Mar 2007 17:05:28 +0000 (17:05 +0000)]
    Take into account the entire run length to get a proper selection.
        Doesn't seem to affect the Mac build but is a problem for Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Beth Dakin.
ggaren [Thu, 29 Mar 2007 17:01:21 +0000 (17:01 +0000)]
    Rubber stamped by Beth Dakin.

        WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
        it's ObjC++ now.

        * Plugins/WebBaseNetscapePluginStream.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Layout test for <rdar://problem/4545060>, technorati and arstechnica fail
darin [Thu, 29 Mar 2007 16:59:01 +0000 (16:59 +0000)]
    Layout test for <rdar://problem/4545060>, technorati and arstechnica fail
        because of getComputedStyle not reporting display:none.

        * fast/css/computed-style-display-none.html: Added.
        * fast/css/computed-style-display-none-expected.txt: Added.

        * fast/css/computed-style-negative-top.html: Updated to work with Gecko.
        * fast/css/computed-style-negative-top-expected.txt: Newline change needed
        because of change above.

        * fast/css/computed-style.html: Updated to work with Gecko.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reluctantly tolerated by Darin Adler.
ggaren [Thu, 29 Mar 2007 15:18:35 +0000 (15:18 +0000)]
    Reluctantly tolerated by Darin Adler.

        Fixed <rdar://problem/5091330> REGRESSION: Repro crash in
        -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
        navigating away from page with DivX movie plug-in (13203)

        The problem was that the DivX plug-in would ask us to destroy an NPStream
        that had already been destroyed, causing us to wander off into freed
        memory. (I believe the reason this was a regression was that we never used
        to destroy plug-in streams, period.)

        The solution here is to track the NPStreams belonging to a plug-in, and
        guard against plug-ins making calls with NPStreams that don't belong to
        them. (It turns out that NPN_DestroyStream is the only stream-based
        plug-in call we support.)

        (CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix.
        Use helper method to guard against a plug-in using an NPStream that doesn't
        belong to it.
        * WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++
        so I could use HashMap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/4545060>, technorati and arstechnica fail because...
hyatt [Thu, 29 Mar 2007 08:41:22 +0000 (08:41 +0000)]
    Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
        reporting display:none properly when it is set.  This is bugzilla bug 13103.

        Reviewed by mitz

        * css/CSSComputedStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
dsmith [Thu, 29 Mar 2007 06:20:38 +0000 (06:20 +0000)]

        Reviewed by Darin.

        Fix some inconsistencies in the Mozilla JS Array extras implementations
        with respect to the Mozilla implementation:

          - holes in arrays should be skipped, not treated as undefined,
            by all such methods
          - an element with value undefined is not a hole
          - Array.prototype.forEach should return undefined

        * kjs/array_object.cpp:


        Reviewed by Darin.

         Fix some inconsistencies in the Mozilla JS Array extras implementations
         with respect to the Mozilla implementation:

           - holes in arrays should be skipped, not treated as undefined,
             by all such methods
           - an element with value undefined is not a hole
           - Array.prototype.forEach should return undefined

        * fast/js/array-every-expected.txt:
        * fast/js/array-filter-expected.txt: Added.
        * fast/js/array-filter.html: Added.
        * fast/js/array-foreach-expected.txt:
        * fast/js/array-foreach.html:
        * fast/js/array-indexof-expected.txt:
        * fast/js/array-indexof.html:
        * fast/js/array-lastIndexOf-expected.txt:
        * fast/js/array-map-expected.txt: Added.
        * fast/js/array-map.html: Added.
        * fast/js/array-some-expected.txt:
        * fast/js/array-some.html:
        * fast/js/resources/array-every.js:
        * fast/js/resources/array-lastIndexOf.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-28 Oliver Hunt <oliver@apple.com>
oliver [Thu, 29 Mar 2007 06:15:27 +0000 (06:15 +0000)]
2007-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Hyatt.

        Rename DocLoader::setPasteInProgress, etc to more generic
        setAllowStaleResources, etc

        * editing/Editor.cpp:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * page/DragController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-28 Oliver Hunt <oliver@apple.com>
oliver [Thu, 29 Mar 2007 04:59:45 +0000 (04:59 +0000)]
2007-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Anders and Steve.

        Add a flag to DocLoader to prevent it from reloading
        when performing a paste or drop operation.

        Remove m_cachePolicy from CachedResource as it is never used

        Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures
        dragging image into GMail message in _web_writeImage and

        * editing/Editor.cpp:
          prevent the docloader from reloading resources on paste
        * html/HTMLImageLoader.cpp:
        * loader/Cache.cpp:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
           Tidy up constructor initialise new field
           Prevent reload when pasting
        * loader/DocLoader.h:
          new field and setter
        * page/DragController.cpp:
          prevent the docloader from reloading resources on drop

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed - fix typo in gdk build.
kjk [Thu, 29 Mar 2007 01:45:00 +0000 (01:45 +0000)]
    Not reviewed - fix typo in gdk build.

        * platform/gdk/ScrollViewGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Thu, 29 Mar 2007 01:17:07 +0000 (01:17 +0000)]

        Reviewed by Darin.

        - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

        * fast/overflow/scrollRevealButton-expected.checksum:
        * fast/overflow/scrollRevealButton-expected.png:
        * fast/overflow/scrollRevealButton-expected.txt:


        Reviewed by Darin.

        - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

        Handle scrolling external scrollviews around the webview during
        autoscroll or when scrolling into view.

        This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/gdk/ScrollViewGdk.cpp:
        * platform/mac/ScrollViewMac.mm:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/ScrollViewWin.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
adele [Wed, 28 Mar 2007 22:18:31 +0000 (22:18 +0000)]
    Reviewed by Brady.

        Update to last fix.

        * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
        Added check to only use the VitalSource workaround if the app is not linked on or after
        the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin
darin [Wed, 28 Mar 2007 21:52:54 +0000 (21:52 +0000)]
    Reviewed  and landed by Darin

        Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.

        * platform/StringImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
antti [Wed, 28 Mar 2007 21:28:17 +0000 (21:28 +0000)]
    Reviewed by Hyatt.

        Fix <rdar://problem/5092653>
        REGRESSION: Image decoding making scrolling slow

        If decoder gave back a null frame (which I think happens regularly if you don't have full frame
        data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
        led to massive growth in calculated image size and eventually made cache prune constantly.

        No test, I don't know how to make one for this.

        * platform/graphics/BitmapImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Wed, 28 Mar 2007 20:59:59 +0000 (20:59 +0000)]

        Reviewed by Kevin M.

        WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

        * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        Convert return value to a string.  This matches the behavior in Safari 2.0.


        Reviewed by Kevin M.

        WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

        Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings.  We used to allow this
        but now we throw a JavaScript exception for return statements that aren't in functions.

        Filed this evangelism bug so we can notify VitalSource of the problem:
        <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

        * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Wed, 28 Mar 2007 16:48:16 +0000 (16:48 +0000)]
    Reviewed by Darin.

        XPath incorrectly handles namespaces on attributes

        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but
        measurable performance improvement for bug 13021.
        (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.

        * xml/XPathStep.h:
        Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).

        * xml/XPathGrammar.y:
        * xml/XPathPath.cpp:
        Accounted for the above change.

        * fast/xpath/attr-namespace-expected.txt: Added.
        * fast/xpath/attr-namespace.html: Added.

        * fast/xpath/xpath-namespaces-expected.txt:
        * fast/xpath/xpath-namespaces.html:
        Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Update libWebKitSystemInterface, previous version was out of date.
antti [Wed, 28 Mar 2007 11:31:45 +0000 (11:31 +0000)]
    Update libWebKitSystemInterface, previous version was out of date.

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-28 Oliver Hunt <oliver@apple.com>
oliver [Wed, 28 Mar 2007 08:41:04 +0000 (08:41 +0000)]
2007-03-28  Oliver Hunt  <oliver@apple.com>


        Rollout local changes :-/

        * loader/Cache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-28 Oliver Hunt <oliver@apple.com>
oliver [Wed, 28 Mar 2007 08:38:05 +0000 (08:38 +0000)]
2007-03-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Hyatt.

        Roll out r20511 due to incredible badness

        * loader/Cache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * svg/hixie/text/003-expected.txt: Updated results for this one test that...
darin [Wed, 28 Mar 2007 05:05:49 +0000 (05:05 +0000)]
    * svg/hixie/text/003-expected.txt: Updated results for this one test that now has
        different results due to the painting Adele added to DumpRenderTree. Long term,
        we just have to fix SVG so that painting doesn't cause changes to the render tree!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-27 Oliver Hunt <oliver@apple.com>
oliver [Wed, 28 Mar 2007 04:22:34 +0000 (04:22 +0000)]
2007-03-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Don't enforce text-selection drag delay when we are
        going to drag an image anyway.

        Fixes rdar://problem/4668935

        * page/EventHandler.cpp:
Layout tests:
        Test to ensure there is no delay forced when dragging a selected image

        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
        * editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andersca [Tue, 27 Mar 2007 23:38:23 +0000 (23:38 +0000)]

        Reviewed by Geoff.

        * bindings/NP_jsobject.cpp:
        Call JSObject:call for native JavaScript objects.


        Reviewed by Geoff.

        Add NPN_InvokeDefault test.

        * plugins/netscape-invoke-default-expected.txt: Added.
        * plugins/netscape-invoke-default.html: Added.


        Reviewed by Geoff.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        Add new function which takes a function and calls it using NPN_InvokeDefault.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix
justing [Tue, 27 Mar 2007 23:29:43 +0000 (23:29 +0000)]
    Build fix

        * editing/markup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 27 Mar 2007 22:55:03 +0000 (22:55 +0000)]

        Reviewed by darin

        <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

        Demonstrates the bug fixed:
        * editing/style/5091898-expected.checksum: Added.
        * editing/style/5091898-expected.png: Added.
        * editing/style/5091898-expected.txt: Added.
        * editing/style/5091898.html: Added.
        Demonstrates a related bug fixed (deleting
        the line break before a paragraph could remove
        its underlining):
        * editing/deleting/5091898-expected.checksum: Added.
        * editing/deleting/5091898-expected.png: Added.
        * editing/deleting/5091898-expected.txt: Added.
        * editing/deleting/5091898.html: Added.
        Demonstrates that a link now (correctly) exists,
        instead of just underlined text:
        * editing/pasteboard/4840662-expected.txt:


        Reviewed by darin

        <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

        createMarkup skipped elements if they were blocks
        when called from moveParagraphs (because that function
        must receive only inline content).  This patch adds
        code to inline these blocks instead of skipping them
        so that we don't lose any of the style that they
        contribute to the copied markup.

        * editing/markup.cpp:
        (WebCore::startMarkup): Add an inlineBlocks option.
        Make sure to overwrite display:block coming from
        a style sheet or the inline style declaration.
        (WebCore::createMarkup): Don't refuse to include a
        specialCommonAncestor that's a block if we were asked
        to include only inline content, since we can now inline
        block elements in startMarkup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOops- my comment was missing a word.
adele [Tue, 27 Mar 2007 22:53:53 +0000 (22:53 +0000)]
Oops- my comment was missing a word.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Adding comment.
adele [Tue, 27 Mar 2007 22:50:26 +0000 (22:50 +0000)]
    Adding comment.

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix svg tests by calling displayIfNeeded.
adele [Tue, 27 Mar 2007 22:41:20 +0000 (22:41 +0000)]
    Fix svg tests by calling displayIfNeeded.

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim
sullivan [Tue, 27 Mar 2007 22:10:08 +0000 (22:10 +0000)]
    Reviewed by Tim

        - fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not
        be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
adele [Tue, 27 Mar 2007 21:58:28 +0000 (21:58 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

        This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
        move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.

        * dom/Document.cpp: (WebCore::Document::implicitClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 27 Mar 2007 20:09:21 +0000 (20:09 +0000)]

        Reviewed by darin

        <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
        <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
        <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
        <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

        * editing/pasteboard/5065605-expected.checksum: Added.
        * editing/pasteboard/5065605-expected.png: Added.
        * editing/pasteboard/5065605-expected.txt: Added.
        * editing/pasteboard/5065605.html: Added.
        * editing/style/4916887-expected.checksum: Added.
        * editing/style/4916887-expected.png: Added.
        * editing/style/4916887-expected.txt: Added.
        * editing/style/4916887.html: Added.
        * editing/style/5065910-expected.checksum: Added.
        * editing/style/5065910-expected.png: Added.
        * editing/style/5065910-expected.txt: Added.
        * editing/style/5065910.html: Added.
        * editing/style/5084241-expected.checksum: Added.
        * editing/style/5084241-expected.png: Added.
        * editing/style/5084241-expected.txt: Added.
        * editing/style/5084241.html: Added.


        Reviewed by darin

        <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
        <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
        <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
        <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

        * css/CSSComputedStyleDeclaration.cpp:
        If a node's text fill color is invalid, then its children use
        their font-color as their text fill color (they don't inherit
        it).  Likewise for stroke color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/ScrollBar.h:
andersca [Tue, 27 Mar 2007 16:40:11 +0000 (16:40 +0000)]
    * platform/ScrollBar.h:
        Use wtf/MathExtras.h instead of math.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-27 Mark Rowe <mrowe@apple.com>
bdash [Tue, 27 Mar 2007 12:49:41 +0000 (12:49 +0000)]
2007-03-27  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Harrison.

        * Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the build
zack [Tue, 27 Mar 2007 11:08:12 +0000 (11:08 +0000)]
Fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-27 Oliver Hunt <oliver@apple.com>
oliver [Tue, 27 Mar 2007 10:02:45 +0000 (10:02 +0000)]
2007-03-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        The WebArchiver needs all the subresources of a document to be accessible
        through the DocLoader, so we can't remove a CachedResource simultaneously
        from the global Cache and all DocLoaders, just because it needs to be
        reloaded in one.

        Fixes rdar://problem/5044366

        * loader/Cache.cpp:
           Don't evict the resource from all DocLoaders
        * manual-tests/test-iframes-loading-the-same-resource.html: Added.
           Alas it wasn't possible to make a nice layout test, even this manual test
           is not entirely deterministic

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-27 Mark Rowe <mrowe@apple.com>
bdash [Tue, 27 Mar 2007 09:14:33 +0000 (09:14 +0000)]
2007-03-27  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * platform/GlyphBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the rendering crashes due to triggered
zack [Tue, 27 Mar 2007 09:04:22 +0000 (09:04 +0000)]
Fix the rendering crashes due to triggered
asserts and improve a bit the layout scheduling in the
Qt port

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd support for glyph offsets to the GlyphBuffer.
hyatt [Tue, 27 Mar 2007 08:52:54 +0000 (08:52 +0000)]
Add support for glyph offsets to the GlyphBuffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Keep buildbot happy.
antti [Tue, 27 Mar 2007 08:32:01 +0000 (08:32 +0000)]
    Keep buildbot happy.

        * platform/mac/PlatformScrollBarMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti [Tue, 27 Mar 2007 08:03:58 +0000 (08:03 +0000)]

        Reviewed by Darin.

        On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.

        * WebCore.exp:
            Export _wkGetWheelEventDeltas
        * page/EventHandler.cpp:
            Remove (0, 0) scroll event hack, it is not needed anymore.
            Do per-pixel scrolling for fine grained events.
        * platform/PlatformWheelEvent.h:
            Add new m_isContinuous boolean to indicate fine grained wheel events.
        * platform/ScrollBar.cpp:
        * platform/ScrollBar.h:
            Use float to represent current position to support finer grained scrolling.
            Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)
        * platform/ScrollTypes.h:
        * platform/gdk/WheelEventGdk.cpp:
            Initalize m_isContinuous
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
            Add wkGetWheelEventDeltas for getting fine grained wheel events
        * platform/mac/WheelEventMac.mm:
            Get the wheel deltas using new wkGetWheelEventDeltas interface
        * platform/qt/WheelEventQt.cpp:
            Initalize m_isContinuous
        * rendering/RenderListBox.cpp:
            Pass item height to scrollbar


        Reviewed by Darin.

        On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()


        Reviewed by Darin.

        Added wkGetWheelEventDeltas

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded Radar references.
ddkilzer [Tue, 27 Mar 2007 03:49:17 +0000 (03:49 +0000)]
Added Radar references.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofixed up order of ChangeLog entries
ggaren [Tue, 27 Mar 2007 02:46:48 +0000 (02:46 +0000)]
fixed up order of ChangeLog entries

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Tue, 27 Mar 2007 02:36:38 +0000 (02:36 +0000)]

        Reviewed by Darin Adler.

        Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at
        WebCore::Node::createRendererIfNeeded() when changing map views with MS
        Virtual Earth (http://www.ziprealty.com/)

        * fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
        * fast/dom/mutation-event-remove-inserted-node.html: Added.
        * fast/dom/script-element-remove-self-expected.txt: Added.
        * fast/dom/script-element-remove-self.html: Added.


        Reviewed by Darin, landed by Anders.

        Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

        * manual-tests/liveconnect-applet-get-boolean.html: Added.
        * manual-tests/resources/CheckerApplet.class: Added.
        * manual-tests/resources/CheckerApplet.java: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andersca [Tue, 27 Mar 2007 01:57:55 +0000 (01:57 +0000)]

        Reviewed by Darin, landed by Anders.

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=13142

        The previous fix http://bugs.webkit.org/show_bug.cgi?id=12636
        introduced new JNIType to enum in jni_utility.h This is a
        problem on the Mac as it seems that the JNIType enum is also
        used in the JVM, it is used to specify the return type in
        Corrected the fix by moving type to the end, and changing
        jni_objc.mm to convert the new type to an old compatible

        * bindings/jni/jni_objc.mm:
        * bindings/jni/jni_utility.h:


        Reviewed by Darin, landed by Anders.

        Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

        * manual-tests/liveconnect-applet-get-boolean.html: Added.
        * manual-tests/resources/CheckerApplet.class: Added.
        * manual-tests/resources/CheckerApplet.java: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed/landed by Adam.
aroben [Tue, 27 Mar 2007 01:11:29 +0000 (01:11 +0000)]
    Reviewed/landed by Adam.

        Bug 13198: Move build settings from project file to xcconfig file for apollo
        port JSCore

        - Moving build settings from xcode project file to xcconfig files.

        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubberstamped by Anders and Maciej aand Geoff (oh my!)
beidson [Mon, 26 Mar 2007 23:52:40 +0000 (23:52 +0000)]
    Rubberstamped by Anders and Maciej aand Geoff (oh my!)

        Since CFTypeRef is really void*, a RetainPtr couldn't be used.
        RefType was "void", which doesn't actually exist as a type.
        Since RefType only existed for operator*(), and since that operator
        doesn't make any sense for RetainPtr, I removed them!

        * kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the
          compiler with dependencies
        * wtf/RetainPtr.h: Nuke RefType and operator*()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Mon, 26 Mar 2007 23:46:55 +0000 (23:46 +0000)]

        Reviewed and landed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13194
          REGRESSION: Selection rects are wrong for images in search results from images.google.com

        * fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
        * fast/replaced/selection-rect-in-table-cell-expected.png: Added.
        * fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
        * fast/replaced/selection-rect-in-table-cell.html: Added.


        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13194
          REGRESSION: Selection rects are wrong for images in search results from images.google.com

        Test: fast/replaced/selection-rect-in-table-cell.html

        * rendering/RenderReplaced.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Harrison
sullivan [Mon, 26 Mar 2007 22:09:11 +0000 (22:09 +0000)]
    Reviewed by Dave Harrison

        - fixed <rdar://problem/4769772> Problem with Find on certain PDF page

        * WebView/WebPDFView.mm:
        (-[WebPDFView _scaledAttributedString:]):
        We were hitting an exception trying to set the font attribute to nil, which was happening because
        the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now
        filed separately, but this works around the exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Touched a file to (hopefully) help the compiler with RetainPtr dependencies.
ggaren [Mon, 26 Mar 2007 20:32:49 +0000 (20:32 +0000)]
    Touched a file to (hopefully) help the compiler with RetainPtr dependencies.

        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removed now-stale #includes of <assert.h>.
ggaren [Mon, 26 Mar 2007 20:31:39 +0000 (20:31 +0000)]
    Removed now-stale #includes of <assert.h>.

        * WebCorePrefix.h:
        * config.h:
        * css/CSSGrammar.y:
        * platform/Arena.cpp:
        * platform/KURL.cpp:
        * platform/SegmentedString.h:
        * rendering/DataRef.h:
        * rendering/RenderArena.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCulough.
ggaren [Mon, 26 Mar 2007 20:08:53 +0000 (20:08 +0000)]
    Reviewed by Kevin McCulough.

        Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
        one instance of commented-out code containing "assert(" instead of replacing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/coding-style.html: Let's misquote George Orwell: "Wrong is right...
darin [Mon, 26 Mar 2007 16:57:39 +0000 (16:57 +0000)]
    * coding/coding-style.html: Let's misquote George Orwell: "Wrong is right. Right is wrong."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/coding-style.html: Put !important on right/wrong colors so they...
darin [Mon, 26 Mar 2007 04:10:00 +0000 (04:10 +0000)]
    * coding/coding-style.html: Put !important on right/wrong colors so they override the
        green color that comes from the green.css stylesheet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: A couple minor wording tweaks.
darin [Mon, 26 Mar 2007 04:07:20 +0000 (04:07 +0000)]
    * coding/RefPtr.html: A couple minor wording tweaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: Put the operator name "new" in the oblique style as...
darin [Mon, 26 Mar 2007 04:05:56 +0000 (04:05 +0000)]
    * coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Sun, 25 Mar 2007 22:42:31 +0000 (22:42 +0000)]

        Reviewed by Adam.

        Test for <rdar://problem/5049842>
        Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

        * editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added.
        * editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
        * editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
        * editing/pasteboard/drag-drop-dead-frame.html: Added.


        Reviewed by Adam.

        Fix <rdar://problem/5049842>
        Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

        Null check frame in m_dragTarget, it might be gone already.

        * page/EventHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-26 Mark Rowe <mrowe@apple.com>
bdash [Sun, 25 Mar 2007 15:10:10 +0000 (15:10 +0000)]
2007-03-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Upload crash logs from DumpRenderTree as part of the test results to ease debugging
        of hard-to-reproduce crashes.

        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-25 Mark Rowe <mrowe@apple.com>
bdash [Sun, 25 Mar 2007 10:33:07 +0000 (10:33 +0000)]
2007-03-25  Mark Rowe  <mrowe@apple.com>

        Fix grammar error that Mitz pointed out.  Replace raw ampersands in hyperlink URL with named entity.

        * coding/RefPtr.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sun, 25 Mar 2007 08:39:27 +0000 (08:39 +0000)]
    Reviewed by Darin.

        A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021
        XPath can be very slow

        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document
        from being destroyed in time.

        * dom/Attr.cpp:
        (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
        * dom/ContainerNode.h:
        Added operations that let Attr hack internal ContainerNode data (evil, but fast!).

        * xml/XPathStep.cpp:
        * xml/XPathStep.h:
        Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future
        optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: A couple wording tweaks.
darin [Sun, 25 Mar 2007 07:43:51 +0000 (07:43 +0000)]
    * coding/RefPtr.html: A couple wording tweaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: More formatting tweaks. Added a possible new topic...
darin [Sun, 25 Mar 2007 07:11:36 +0000 (07:11 +0000)]
    * coding/RefPtr.html: More formatting tweaks. Added a possible new topic for the document,
        suggested by Anders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * css/main.css: Try tighter spacing for code examples.
darin [Sun, 25 Mar 2007 06:52:22 +0000 (06:52 +0000)]
    * css/main.css: Try tighter spacing for code examples.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: <span> -> </span>
darin [Sun, 25 Mar 2007 06:48:17 +0000 (06:48 +0000)]
    * coding/RefPtr.html: <span> -> </span>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: "smart pointer" -> "smart pointers"
darin [Sun, 25 Mar 2007 06:44:30 +0000 (06:44 +0000)]
    * coding/RefPtr.html: "smart pointer" -> "smart pointers"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * coding/RefPtr.html: Added. First draft of a document about RefPtr.
darin [Sun, 25 Mar 2007 06:38:56 +0000 (06:38 +0000)]
    * coding/RefPtr.html: Added. First draft of a document about RefPtr.

        Also tweaked the MIME types of a few files and removed a stray executable bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Amend the statistics reporting for the WebCore cache to include XSL and to...
hyatt [Sun, 25 Mar 2007 06:37:55 +0000 (06:37 +0000)]
    Amend the statistics reporting for the WebCore cache to include XSL and to report live/decoded sizes.

        * Misc/WebCache.mm:
        (+[WebCache statistics]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ddkilzer [Sun, 25 Mar 2007 06:28:19 +0000 (06:28 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13156
          REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar

        * fast/text/midword-break-after-breakable-char-expected.checksum: Added.
        * fast/text/midword-break-after-breakable-char-expected.png: Added.
        * fast/text/midword-break-after-breakable-char-expected.txt: Added.
        * fast/text/midword-break-after-breakable-char.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13156
          REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar

        Test: fast/text/midword-break-after-breakable-char.html

        Breaking in the middle of the word
        is allowed only if no breaking opportunity between words has occurred yet. The
        first position on the line should not be considered "between words" even if
        it is a breaking opportunity.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also
        cleaned up a couple of lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data...
hyatt [Sun, 25 Mar 2007 05:53:42 +0000 (05:53 +0000)]
    Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
        around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
        Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be

        Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
        than to all the lists at once.  This allows the cache to evict large encoded resources before flushing small
        or frequently accessed decoded onces.

        Added information on live/decoded data to the cache statistics.

        Reviewed by darin

        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * platform/graphics/BitmapImage.cpp:
        * platform/graphics/ImageObserver.h:
        * rendering/RenderBox.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderListMarker.cpp:
        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sun, 25 Mar 2007 02:48:31 +0000 (02:48 +0000)]

        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13123
          CSS selectors that use :lang, :not, and namespaces do not serialize correctly

        * fast/css/css-selector-text-expected.txt: Added.
        * fast/css/css-selector-text.html: Added.


        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13123
          CSS selectors that use :lang, :not, and namespaces do not serialize correctly

        Test: fast/css/css-selector-text.html

        * css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace
        prefix for tag or attribute names, the sub-selector for :not, and the argument
        for :lang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
beidson [Sun, 25 Mar 2007 01:22:28 +0000 (01:22 +0000)]

        Reviewed by Adam

        Whoops, RetainPtr should be in the WTF namespace

        * wtf/RetainPtr.h:


        Reviewed by Adam

        RetainPtr is no longer in the WebCore namespace

        * History/WebBackForwardList.mm:
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebView/WebDocumentLoaderMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
beidson [Sat, 24 Mar 2007 23:21:50 +0000 (23:21 +0000)]

        Reviewed by Adam

        <rdar://problem/5086210> - Move RetainPtr to WTF

        * wtf/RetainPtr.h: Added
        * JavaScriptCore.xcodeproj/project.pbxproj: Add it to the project file
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto


        Reviewed by Adam

        <rdar://problem/5086210> - Move RetainPtr to WTF

        * ForwardingHeaders/wtf/RetainPtr.h: Added.
        * WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h

        * history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
        * history/PageCache.h: Ditto
        * page/mac/WebCoreFrameBridge.mm: Ditto
        * platform/ContextMenu.h: Ditto
        * platform/ContextMenuItem.h: Ditto
        * platform/DragImage.h: Ditto
        * platform/FileChooser.h: Ditto
        * platform/PlatformKeyboardEvent.h: Ditto
        * platform/PopupMenu.h: Ditto
        * platform/SharedBuffer.h: Ditto
        * platform/cf/RetainPtr.h: Removed.
        * platform/graphics/Icon.h: Changed #include
        * platform/mac/ClipboardMac.h: Ditto
        * platform/mac/PasteboardMac.mm: Ditto
        * platform/mac/WidgetMac.mm: Ditto
        * platform/network/AuthenticationChallenge.h: Ditto
        * platform/network/ResourceError.h: Ditto
        * platform/network/ResourceHandle.h: Ditto
        * platform/network/ResourceRequest.h: Ditto
        * platform/network/ResourceResponse.h: Ditto
        * rendering/RenderThemeMac.mm: Ditto


        Reviewed by Adam

        <rdar://problem/5086210> - Move RetainPtr to WTF

        * ForwardingHeaders/wtf/RetainPtr.h: Added.
        * History/WebBackForwardList.mm: Changed #import to <wtf/RetainPtr.h>
        * WebCoreSupport/WebEditorClient.h: Ditto
        * WebCoreSupport/WebFrameLoaderClient.h: Ditto
        * WebView/WebDocumentLoaderMac.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect...
hyatt [Sat, 24 Mar 2007 23:15:02 +0000 (23:15 +0000)]
    Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect results, which will lead
        to all sorts of layout issues.  This is in bugzilla as 13179.

        Reviewed by hyatt

        - fix http://bugs.webkit.org/show_bug.cgi?id=13179
          REGRESSION (r20410): In debug builds, loading a certain page is suspended until redisplay is forced

        Moved the root->needsLayout() check from layoutPending() to needsLayout()
        to restore the behavior before r20324.

        * page/FrameView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Sat, 24 Mar 2007 22:13:04 +0000 (22:13 +0000)]

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13180
          Another debug build crash from ASSERTION FAILED: !needsLayout()

        No test possible because updateRendering() is always called after script

        * page/FrameView.cpp:
        (WebCore::FrameView::layout): Get the layout root after calling recalcStyle()
        since a style recalc may result in needing to do start layout at the root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNot reviewed. Build fix.
zimmermann [Sat, 24 Mar 2007 21:53:03 +0000 (21:53 +0000)]
Not reviewed. Build fix.
Fix FloatRect vs. IntRect confusion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele
sullivan [Sat, 24 Mar 2007 17:25:09 +0000 (17:25 +0000)]
    Reviewed by Adele

        - fixed <rdar://problem/5084872> Need to add flickr to spoof list in WebKit
        - only do site-specific spoofing if a preference is set

        * WebView/WebPreferenceKeysPrivate.h:
        added WebKitUseSiteSpecificSpoofingPreferenceKey

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        initialize WebKitUseSiteSpecificSpoofingPreferenceKey to false
        (-[WebPreferences _useSiteSpecificSpoofing]):
        get value of WebKitUseSiteSpecificSpoofingPreferenceKey
        (-[WebPreferences _setUseSiteSpecificSpoofing:]):
        set value of WebKitUseSiteSpecificSpoofingPreferenceKey

        * WebView/WebPreferencesPrivate.h:
        declare _useSiteSpecificSpoofing and _setUseSiteSpecificSpoofing

        * WebView/WebView.mm:
        cache the value of WebKitUseSiteSpecificSpoofingPreferenceKey in a bool in _private
        (-[WebView _preferencesChangedNotification:]):
        update the cached value
        (-[WebView setPreferences:]):
        (-[WebView WebCore::_userAgentForURL:WebCore::]):
        Only spoof here if the new site-specific spoofing preference is enabled. If it is, pass
        Safari 2.0.4's user agent string for flickr.com. We can remove this case when 5081617 is addressed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix incorrect radar number.
bdash [Sat, 24 Mar 2007 13:26:13 +0000 (13:26 +0000)]
Fix incorrect radar number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Oliver.
zimmermann [Sat, 24 Mar 2007 12:27:34 +0000 (12:27 +0000)]
Reviewed by Oliver.

Fix all known RenderSVGImage problems.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)
Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-24 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 24 Mar 2007 10:25:31 +0000 (10:25 +0000)]
2007-03-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - http://bugs.webkit.org/show_bug.cgi?id=13177
          Suppress control characters in the ATSUI code path

        * platform/mac/FontMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5086400>, images scrolled offscreen continue to anima...
hyatt [Sat, 24 Mar 2007 10:16:11 +0000 (10:16 +0000)]
    Fix for <rdar://problem/5086400>, images scrolled offscreen continue to animate.  Safari 2 would
        halt animations when images were no longer visible.

        Reviewed by mjs, olliej

        * platform/graphics/BitmapImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-24 Mark Rowe <mrowe@apple.com>
bdash [Sat, 24 Mar 2007 09:20:33 +0000 (09:20 +0000)]
2007-03-24  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        * JavaScriptGlue.xcodeproj/project.pbxproj: Use GCC 4.0 for testjsglue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/508328>, sluggish text entry in search field. Make...
hyatt [Sat, 24 Mar 2007 07:07:24 +0000 (07:07 +0000)]
    Fix for <rdar://problem/508328>, sluggish text entry in search field.  Make sure
        our size actually changed before we decide to do a full repaint because of background/border

        Reviewed by aroben

        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Gmail spurious glyphs issue.
hyatt [Sat, 24 Mar 2007 06:24:59 +0000 (06:24 +0000)]
Fix Gmail spurious glyphs issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sat, 24 Mar 2007 04:38:54 +0000 (04:38 +0000)]

        Reviewed by Adele.

        - pixel test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13153
          REGRESSION: Visual highlighting of pre-populated blank line in textarea is broken

        * editing/selection/doubleclick-crash-expected.checksum:
        * editing/selection/doubleclick-crash-expected.png:
        * fast/text/selection-hard-linebreak-expected.checksum: Added.
        * fast/text/selection-hard-linebreak-expected.png: Added.
        * fast/text/selection-hard-linebreak-expected.txt: Added.
        * fast/text/selection-hard-linebreak.html: Added.


        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13153
          REGRESSION: Visual highlighting of pre-populated blank line in textarea is broken

        - fix a bug where selecting across a soft line break did not highlight to
          the end of the first line if it contained skipped whitespace

        Test: fast/text/selection-hard-linebreak.html

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the
        end of a hard line break as if it ends after the line break. Fixed the case of a selection
        that starts and ends in the same text object as the box but does not intersect it
        to return SelectionNone instead of selectionBoth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sat, 24 Mar 2007 04:05:04 +0000 (04:05 +0000)]

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13124
          REGRESSION: Reproducible crash in Widget::getView

        * fast/frames/hover-timer-crash-expected.txt: Added.
        * fast/frames/hover-timer-crash.html: Added.


        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13124
          REGRESSION: Reproducible crash in Widget::getView

        Test: fast/frames/hover-timer-crash.html

        * page/Frame.cpp:
        (WebCore::Frame::setView): Added a call to EventHandler::clear().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to include these nil checks in my previous checkin.
justing [Sat, 24 Mar 2007 01:18:25 +0000 (01:18 +0000)]
Forgot to include these nil checks in my previous checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Sat, 24 Mar 2007 00:58:09 +0000 (00:58 +0000)]

        Reviewed by adele

        Crash in in ReplaceSelectionCommand if the fragment contains only a style span

        * editing/pasteboard/5078739-expected.txt: Added.
        * editing/pasteboard/5078739.html: Added.


        Reviewed by adele

        Crash in in ReplaceSelectionCommand if the fragment contains only a style span

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Check
        for an empty fragment after removing a redundant
        style span instead of before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed/landed by Adam.
aroben [Fri, 23 Mar 2007 22:26:42 +0000 (22:26 +0000)]
    Reviewed/landed by Adam.

        Bug 13175: Make apollo mac project files for JavaScriptCore actually
        build something

        - Changing apollo mac project files for JavaScriptCore such that they actually build
        JavaScriptCore source code.

        * JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp: Added.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5085063>
hyatt [Fri, 23 Mar 2007 21:48:50 +0000 (21:48 +0000)]

        Fix non-looping animation on cuteoverload.com. Just always flush
        decoded data for large animated images to avoid our cache getting
        out of sync with the image source.

        Reviewed by ggaren

        * platform/graphics/BitmapImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele [Fri, 23 Mar 2007 21:09:40 +0000 (21:09 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
        http://bugs.webkit.org/show_bug.cgi?id= 13020

        No known way to add a layout test for this.  We would need a way to know exactly how the event was consumed.

        * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler):
          If the keypress event has its default behavior prevented, then we should consider the keydown event handled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 23 Mar 2007 20:42:15 +0000 (20:42 +0000)]

        Reviewed by darin

        Fixed (was missing a newline):
        * editing/execCommand/4917055-expected.txt:
        Tests setting a caet before the image and changing its alignment:
        * editing/execCommand/5080333-1-expected.checksum: Added.
        * editing/execCommand/5080333-1-expected.png: Added.
        * editing/execCommand/5080333-1-expected.txt: Added.
        * editing/execCommand/5080333-1.html: Added.
        Tests selecting the image and changing its alignment:
        * editing/execCommand/5080333-2-expected.checksum: Added.
        * editing/execCommand/5080333-2-expected.png: Added.
        * editing/execCommand/5080333-2-expected.txt: Added.
        * editing/execCommand/5080333-2.html: Added.


        Reviewed by darin

        REGRESSION: Selection changes when changing the alignment of an image

        Regression occurred when we started using moveParagraphs
        to move content in applyBlockStyle.  moveParagraphs
        moves by copying, deleting and reinserting content, and
        so must be accompanied by selection preservation code.
        That code uses rangeFromLocationAndLength and rangeLength,
        which use TextIterators, which don't emit anything for images
        and other replaced elements, causing this bug.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength
        and rangeFromLocationAndLength to request that their
        TextIterators emit spaces for replaced elements.
        Use rangeCompliantEquivalent()s when creating a Range from
        VisiblePositions, since some VisiblePositions have illegal
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleReplacedElement): Emit
        a space if requested.
        (WebCore::TextIterator::representNodeOffsetZero): Emit
        ranges before m_node, not around m_lastTextNode.  These
        ranges should represent the part of the document associated
        with the emitted character.
        (WebCore::TextIterator::rangeLength): Take in the new bool.
        (WebCore::TextIterator::rangeFromLocationAndLength): Ditto.
        Also, don't loop an extra time after finding the end of the
        range when we're looking for zero length ranges.  This appeared
        to be a workaround for the bugs fixed in representNodeOffsetZero
        in this patch.
        * editing/TextIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-24 Mark Rowe <mrowe@apple.com>
bdash [Fri, 23 Mar 2007 19:51:59 +0000 (19:51 +0000)]
2007-03-24  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Darin.

        * Configurations/JavaScriptCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Darin.

        * Configurations/JavaScriptGlue.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Darin.

        * Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Darin.

        * Configurations/WebKit.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * html/HTMLBodyElement.cpp: Fix comment typo.
darin [Fri, 23 Mar 2007 18:39:43 +0000 (18:39 +0000)]
    * html/HTMLBodyElement.cpp: Fix comment typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPatch from Adam Treat to make the Qt build work without SVG and XSLT as well as
staikos [Fri, 23 Mar 2007 18:38:00 +0000 (18:38 +0000)]
Patch from Adam Treat to make the Qt build work without SVG and XSLT as well as

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Fri, 23 Mar 2007 18:25:44 +0000 (18:25 +0000)]
    Reviewed by Hyatt.

        - <rdar://problem/5074439> handle margins on frame and iframe elements
          without involving FrameView, FrameLoader, etc.

        * html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
        Grab the margin from the frame directly here. There was no real benefit
        to doing this via FrameView. Later we can delete quite a bit of unneeded code
        here and in WebKit that exists only to set up the margin values in FrameView,
        which are now unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Fri, 23 Mar 2007 18:24:30 +0000 (18:24 +0000)]

        Reviewed by Darin.

        Tests for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866

        * fast/dom/HTMLInputElement/input-hidden-value-expected.txt: Added.
        * fast/dom/HTMLInputElement/input-hidden-value.html: Added.
        * fast/forms/input-value-expected.txt:


        Reviewed by Darin.

        Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866

        Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
        Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer).  In reset,
        use the m_originalValue for hidden input elements.

        * html/HTMLInputElement.cpp:
        * html/HTMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Patch by Adam Treat. Removes hardcoded path to .pro file.
staikos [Fri, 23 Mar 2007 18:01:37 +0000 (18:01 +0000)]
    Patch by Adam Treat.  Removes hardcoded path to .pro file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd radar reference.
bdash [Fri, 23 Mar 2007 11:41:07 +0000 (11:41 +0000)]
Add radar reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-23 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 23 Mar 2007 11:37:57 +0000 (11:37 +0000)]
2007-03-23  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13157
          List markers positioned incorrectly and don't repaint properly on Oxford homepage

        Test: fast/lists/marker-image-error.html

        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if
        the image failed to load, since that means we will use a bullet instead.

2007-03-23  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13157
          List markers positioned incorrectly and don't repaint properly on Oxford homepage

        * fast/lists/marker-image-error-expected.checksum: Added.
        * fast/lists/marker-image-error-expected.png: Added.
        * fast/lists/marker-image-error-expected.txt: Added.
        * fast/lists/marker-image-error.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the compile
zack [Fri, 23 Mar 2007 11:23:01 +0000 (11:23 +0000)]
Fix the compile

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-23 Mark Rowe <mrowe@apple.com>
bdash [Fri, 23 Mar 2007 09:25:58 +0000 (09:25 +0000)]
2007-03-23  Mark Rowe  <mrowe@apple.com>

        Build fix for when BUILDING_ON_TIGER is not defined.

        * Misc/WebTypesInternal.h:
        * WebView/WebHTMLView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20427 268f45cc-cd09-0410-ab3c-d52691b4dbfc