14 years agoWebCore:
aliceli1 [Fri, 31 Aug 2007 23:02:33 +0000 (23:02 +0000)]

        Reviewed by Tim Hatcher.

        Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

        * editing/DeleteButtonController.cpp:
        Factored out the code in ::show() that created and styled the elements of the Deletion UI

        Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
        of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a
        bloated table deletion UI which was slow to show and hide.

        * editing/DeleteButtonController.h:
        Restore this function to how it used to be pre-r25305, sans asserts

        * editing/EditCommand.cpp:
        Add disable/enable sandwich when undoing/redoing commands too


        Reviewed by Tim Hatcher.

        Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

        * editing/deleting/deletionUI-single-instance.html: Added.
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
antti [Fri, 31 Aug 2007 22:09:03 +0000 (22:09 +0000)]
    Reviewed by Anders.

        Fix <rdar://problem/5452943>
        REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc

        Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
        no RenderObjects can be cached over it.

        * html/HTMLEmbedElement.cpp:
        * html/HTMLObjectElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
andersca [Fri, 31 Aug 2007 21:57:44 +0000 (21:57 +0000)]
    Reviewed by Mitz.

        Crash after QT movie completes playback at apple.com/imac

        If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus,
        which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Fri, 31 Aug 2007 18:51:05 +0000 (18:51 +0000)]

        Reviewed by Justin.

        Fix for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

        Test: editing/pasteboard/paste-plaintext-user-select-none.html

        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering):
          Copy the user-select style from the current selection node and apply it so it is considered during the test rendering.
          This is important since we recently changed user-select to be inherited.  When we consider valid VisiblePositions for the test rendering,
          we need to have the correct user-select value that will actually be used for the real insertion.


        Reviewed by Justin.

        Test for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

        * editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Added.
        * editing/pasteboard/paste-plaintext-user-select-none.html: Added.
        * fast/forms/textarea-paste-newline.html: Updated to escape '\n' in failure description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
andersca [Fri, 31 Aug 2007 18:16:54 +0000 (18:16 +0000)]
    Reviewed by Oliver.

        ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows

        Protect the stream in case it's destroyed by the plug-in.

        * plugins/win/PluginStreamWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Fri, 31 Aug 2007 16:13:54 +0000 (16:13 +0000)]
    Reviewed by Anders.

        - http://bugs.webkit.org/show_bug.cgi?id=15122

        * editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
        Change assertion so that it only fires when actually modifying the selection.
        This isn't nearly as helpful, because the old assertion could catch potential
        problems in more cases, but it's not obvious how to do better.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
oliver [Fri, 31 Aug 2007 04:33:05 +0000 (04:33 +0000)]

        Reviewed by Adam.

        <rdar://problem/5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com

        VC++ treats bitfields as signed members, so Node::m_styleChange would be
        sign extended if it was assigned the value FullStyleChange.  This caused
        style recalculation to stop propagating.

        We work around this VC++ oddity by storing the enum as an unsigned, and
        casting back to StyleChangeType in the getter.

        Test: fast/css/hover-affects-child.html

        * dom/Node.h:


        Reviewed by Adam.

        Simple test case to ensure that hover affects are correctly propagated

        * fast/css/hover-affects-child-expected.txt: Added.
        * fast/css/hover-affects-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixing comma placement.
justing [Fri, 31 Aug 2007 01:40:25 +0000 (01:40 +0000)]
Fixing comma placement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Fri, 31 Aug 2007 01:36:55 +0000 (01:36 +0000)]

        Reviewed by Darin.

        REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertParagraphSeparator): Added an option for
        using a plain div to hold the new paragraph, instead of a clone of the previous
        * editing/CompositeEditCommand.h:
        * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
        (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Ditto.
        (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
        * editing/InsertParagraphSeparatorCommand.h:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Use a default block element when creating
        new paragraphs, so that empty paragraphs don't contain the block style of the previous
        Don't expand collapsed brs at the end of inserted content, this was the root of the bug.
        We'd copy <blockquote>hello<br></blockquote><br class="Apple-interchange-newline">
        and get an extra paragraph.  The removed code used to make sure that if the copied
        selection ends with a paragraph break that is represented in the copied markup by a
        regular br (not an interchange newline br), that that paragraph break appears in the
        pasted content, but shouldMergeEnd, which was introduced after this code was written,
        now takes care of that.
        (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Inserted content should always
        displace placeholder brs, even if that inserted content ends with a br.
        * editing/markup.cpp:
        (WebCore::needInterchangeNewlineAfter): This code failed to add an interchange newline
        if the user copied <div>hello</div><br>, only don't add an interchange newline when
        copying ^hello<br>^<br>, because then the copied paragraph break will already be
        represented in the copied markup by a br.


        Reviewed by Darin.

        REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line

        Tested for behavior that we no longer want to have:
        * editing/pasteboard/quirks-mode-br-2-expected.checksum: Removed.
        * editing/pasteboard/quirks-mode-br-2-expected.png: Removed.
        * editing/pasteboard/quirks-mode-br-2-expected.txt: Removed.
        * editing/pasteboard/quirks-mode-br-2.html: Removed.

        * platform/mac/editing/pasteboard: Added.

        Demonstrates bug:
        * editing/pasteboard/5368833.html: Added.
        * platform/mac/editing/pasteboard/5368833-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5368833-expected.png: Added.
        * platform/mac/editing/pasteboard/5368833-expected.txt: Added.

        Regenerated these expected results to reflect new behavior:
        * editing/pasteboard/paste-text-012-expected.checksum: Removed.
        * editing/pasteboard/paste-text-012-expected.png: Removed.
        * editing/pasteboard/paste-text-012-expected.txt: Removed.
        * editing/pasteboard/paste-text-013-expected.checksum: Removed.
        * editing/pasteboard/paste-text-016-expected.checksum: Removed.
        * editing/pasteboard/paste-text-016-expected.png: Removed.
        * editing/pasteboard/paste-text-016-expected.txt: Removed.
        * platform/mac/editing/pasteboard/paste-text-012-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-text-012-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt: Added.
        * platform/mac/editing/pasteboard/paste-text-013-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-text-013-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-text-013-expected.txt: Added.
        * platform/mac/editing/pasteboard/paste-text-016-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-text-016-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-text-016-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
bdash [Fri, 31 Aug 2007 00:58:57 +0000 (00:58 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 31 Aug 2007 00:10:48 +0000 (00:10 +0000)]
    Reviewed by Darin.

        <rdar://problem/5423900> Seed: safari crashes on submit feedback page in -[WebCoreAXObject isAttachment]

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject isAttachment]):
        Add nil check since element could be detached.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-30 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 30 Aug 2007 22:38:20 +0000 (22:38 +0000)]
2007-08-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13282
          <rdar://problem/5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateOptionsWidth): When measuring option text, use
        the same WebCore run rounding behavior that is used to draw it in the popup button.

2007-08-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - updated test results for http://bugs.webkit.org/show_bug.cgi?id=13282
          <rdar://problem/5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu

        * editing/pasteboard/4641033-expected.checksum:
        * editing/pasteboard/4641033-expected.png:
        * editing/pasteboard/4641033-expected.txt:
        * fast/forms/HTMLOptionElement_label02-expected.checksum:
        * fast/forms/HTMLOptionElement_label02-expected.png:
        * fast/forms/HTMLOptionElement_label02-expected.txt:
        * fast/forms/HTMLOptionElement_label03-expected.checksum:
        * fast/forms/HTMLOptionElement_label03-expected.png:
        * fast/forms/HTMLOptionElement_label03-expected.txt:
        * fast/forms/control-restrict-line-height-expected.checksum:
        * fast/forms/control-restrict-line-height-expected.png:
        * fast/forms/control-restrict-line-height-expected.txt:
        * fast/forms/menulist-restrict-line-height-expected.checksum:
        * fast/forms/menulist-restrict-line-height-expected.png:
        * fast/forms/menulist-restrict-line-height-expected.txt:
        * fast/forms/menulist-width-change-expected.checksum:
        * fast/forms/menulist-width-change-expected.png:
        * fast/forms/menulist-width-change-expected.txt:
        * fast/forms/select-change-listbox-to-popup-expected.checksum:
        * fast/forms/select-change-listbox-to-popup-expected.png:
        * fast/forms/select-change-listbox-to-popup-expected.txt:
        * fast/forms/select-disabled-appearance-expected.checksum:
        * fast/forms/select-disabled-appearance-expected.png:
        * fast/forms/select-disabled-appearance-expected.txt:
        * fast/forms/stuff-on-my-optgroup-expected.checksum:
        * fast/forms/stuff-on-my-optgroup-expected.png:
        * fast/forms/stuff-on-my-optgroup-expected.txt:
        * fast/parser/document-write-option-expected.checksum:
        * fast/parser/document-write-option-expected.png:
        * fast/parser/document-write-option-expected.txt:
        * http/tests/navigation/anchor-basic-expected.txt:
        * http/tests/navigation/anchor-frames-expected.txt:
        * http/tests/navigation/anchor-goback-expected.checksum:
        * http/tests/navigation/anchor-goback-expected.png:
        * http/tests/navigation/anchor-goback-expected.txt:
        * http/tests/navigation/anchor-subframeload-expected.txt:
        * http/tests/navigation/javascriptlink-basic-expected.checksum:
        * http/tests/navigation/javascriptlink-basic-expected.png:
        * http/tests/navigation/javascriptlink-basic-expected.txt:
        * http/tests/navigation/javascriptlink-frames-expected.txt:
        * http/tests/navigation/javascriptlink-goback-expected.checksum:
        * http/tests/navigation/javascriptlink-goback-expected.png:
        * http/tests/navigation/javascriptlink-goback-expected.txt:
        * http/tests/navigation/javascriptlink-subframeload-expected.txt:
        * http/tests/navigation/metaredirect-basic-expected.checksum:
        * http/tests/navigation/metaredirect-basic-expected.png:
        * http/tests/navigation/metaredirect-basic-expected.txt:
        * http/tests/navigation/metaredirect-frames-expected.txt:
        * http/tests/navigation/metaredirect-goback-expected.checksum:
        * http/tests/navigation/metaredirect-goback-expected.png:
        * http/tests/navigation/metaredirect-goback-expected.txt:
        * http/tests/navigation/metaredirect-subframeload-expected.txt:
        * http/tests/navigation/post-goback2-expected.checksum:
        * http/tests/navigation/post-goback2-expected.png:
        * http/tests/navigation/post-goback2-expected.txt:
        * http/tests/navigation/postredirect-goback2-expected.checksum:
        * http/tests/navigation/postredirect-goback2-expected.png:
        * http/tests/navigation/postredirect-goback2-expected.txt:
        * http/tests/navigation/redirect302-basic-expected.checksum:
        * http/tests/navigation/redirect302-basic-expected.png:
        * http/tests/navigation/redirect302-basic-expected.txt:
        * http/tests/navigation/redirect302-frames-expected.txt:
        * http/tests/navigation/redirect302-goback-expected.checksum:
        * http/tests/navigation/redirect302-goback-expected.png:
        * http/tests/navigation/redirect302-goback-expected.txt:
        * http/tests/navigation/redirect302-subframeload-expected.txt:
        * http/tests/navigation/relativeanchor-basic-expected.txt:
        * http/tests/navigation/relativeanchor-frames-expected.txt:
        * http/tests/navigation/relativeanchor-goback-expected.txt:
        * http/tests/navigation/slowmetaredirect-basic-expected.checksum:
        * http/tests/navigation/slowmetaredirect-basic-expected.png:
        * http/tests/navigation/slowmetaredirect-basic-expected.txt:
        * http/tests/navigation/slowtimerredirect-basic-expected.checksum:
        * http/tests/navigation/slowtimerredirect-basic-expected.png:
        * http/tests/navigation/slowtimerredirect-basic-expected.txt:
        * http/tests/navigation/success200-basic-expected.checksum:
        * http/tests/navigation/success200-basic-expected.png:
        * http/tests/navigation/success200-basic-expected.txt:
        * http/tests/navigation/success200-frames-expected.txt:
        * http/tests/navigation/success200-frames-loadsame-expected.txt:
        * http/tests/navigation/success200-goback-expected.checksum:
        * http/tests/navigation/success200-goback-expected.png:
        * http/tests/navigation/success200-goback-expected.txt:
        * http/tests/navigation/success200-loadsame-expected.checksum:
        * http/tests/navigation/success200-loadsame-expected.png:
        * http/tests/navigation/success200-loadsame-expected.txt:
        * http/tests/navigation/success200-reload-expected.checksum:
        * http/tests/navigation/success200-reload-expected.png:
        * http/tests/navigation/success200-reload-expected.txt:
        * http/tests/navigation/success200-subframeload-expected.txt:
        * http/tests/navigation/timerredirect-basic-expected.checksum:
        * http/tests/navigation/timerredirect-basic-expected.png:
        * http/tests/navigation/timerredirect-basic-expected.txt:
        * http/tests/navigation/timerredirect-frames-expected.txt:
        * http/tests/navigation/timerredirect-goback-expected.checksum:
        * http/tests/navigation/timerredirect-goback-expected.png:
        * http/tests/navigation/timerredirect-goback-expected.txt:
        * http/tests/navigation/timerredirect-subframeload-expected.txt:
        * tables/mozilla/bugs/bug33855-expected.checksum:
        * tables/mozilla/bugs/bug33855-expected.png:
        * tables/mozilla/bugs/bug33855-expected.txt:
        * tables/mozilla/dom/tableDom-expected.checksum:
        * tables/mozilla/dom/tableDom-expected.png:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-30 Riku Voipio <riku.voipio@iki.fi>
bdash [Thu, 30 Aug 2007 22:33:39 +0000 (22:33 +0000)]
2007-08-30  Riku Voipio  <riku.voipio@iki.fi>

        Reviewed by Dave Kilzer.

        Better ARM defines.

        * kjs/ustring.h: Update comments to reflect the change and update test
        to fit changes to Platform.h.
        * wtf/Platform.h: Forced packing is only needed on oldabi ARM.
        Set middle-endian floats only for little-endian oldabi ARM.
        Set big-endian define for big-endian ARM.

2007-08-30  Riku Voipio  <riku.voipio@iki.fi>

        Reviewed by Dave Kilzer.

        Better ARM defines.

        * platform/DeprecatedString.h: Update comments to reflect the
        change and update test to fit changes to Platform.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim.
mjs [Thu, 30 Aug 2007 21:14:08 +0000 (21:14 +0000)]
    Reviewed by Tim.

        <rdar://problem/5439953> REGRESSION: Cannot load feeds in widgets in Dashcode due to change in WebKit delegate methods

        * WebView/WebFrame.mm:
        (-[WebFrame _attachScriptDebugger]): Don't create the debugger object if the frame has not yet
        created its script interpreter, to avoid premature dispatch of windowScriptObjectAvailable/Cleared
        delegate methods. The script debugger will be created in any case when the window object does appear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
darin [Thu, 30 Aug 2007 18:06:06 +0000 (18:06 +0000)]
    Reviewed by Tim Hatcher.

        - fix http://bugs.webkig.org/show_bug.cgi?id=14981
          DEBUG builds of WebKit hang videwing Yahoo! Mail messages
          with ~5 MB text attachment

        * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::checkConsistency):
        * rendering/RenderFlow.cpp: (WebCore::RenderFlow::checkConsistency):
        * rendering/RenderText.cpp: (WebCore::RenderText::checkConsistency):
        Put the actual consistency check inside an ifdef. If you need it you can
        turn it on. There's still some function call overhead in builds that don't
        have NDEBUG defined, but that's worth it so we can turn this on and off
        without recompiling the world.

        - small code style improvement to recently changed function

        * editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
        Use a typedef and make_pair to make the code dealing with the pair simpler to read.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse QKeySequence::StandardKey for the page wise scrolling shortcuts.
hausmann [Thu, 30 Aug 2007 14:44:54 +0000 (14:44 +0000)]
Use QKeySequence::StandardKey for the page wise scrolling shortcuts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWhen scrolling with the keyboard don't call update() on the entire widget.
hausmann [Thu, 30 Aug 2007 14:44:52 +0000 (14:44 +0000)]
When scrolling with the keyboard don't call update() on the entire widget.
The scrollbar/scrollview implementation is already smart enough to scroll with bitblt
on a value change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix scrolling with the keyboard if only one of the two scrollbars is visible.
hausmann [Thu, 30 Aug 2007 14:44:49 +0000 (14:44 +0000)]
Fix scrolling with the keyboard if only one of the two scrollbars is visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt/Gdk build.
hausmann [Thu, 30 Aug 2007 14:26:02 +0000 (14:26 +0000)]
Fix Qt/Gdk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Antti.
antti [Thu, 30 Aug 2007 13:12:46 +0000 (13:12 +0000)]
    Reviewed by Antti.

        - fix <rdar://problem/5423270> CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore:
          WebCore::plainTextToMallocAllocatedBuffer + 762

        * editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
        Check for a malloc failure and exit the function if it failed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
andersca [Thu, 30 Aug 2007 01:32:14 +0000 (01:32 +0000)]
    Reviewed by Oliver.

        Plugin content starves WM_TIMER events on UI thread (affects idle behavior of app) on http://www.vincent-vella.com/, http://www.sagmeister.com/

        Add a tiny delay to invalidation timer to prevent it from starving other timers.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
darin [Thu, 30 Aug 2007 00:45:52 +0000 (00:45 +0000)]
    Reviewed by Tim Hatcher.

        - fix <rdar://problem/4582212> WebKit inappropriately adds +initialize to
          NSPasteboard via a category, prevents AppKit initialize

        * Misc/WebNSPasteboardExtras.h: Got rid of the global data objects and replaced
        them with global functions.

        * Misc/WebNSPasteboardExtras.mm:
        (initializePasteboardTypes): Changed the initialize method to be this function.
        (WebURLPasteboardType): Added, calls the initialize function and then returns
        the value of the global.
        (WebURLNamePasteboardType): Ditto.
        (+[NSPasteboard _web_writableTypesForURL]): Changed to call the new function instead
        of getting at the global directly.
        (+[NSPasteboard _web_dragTypesForURL]): Ditto.
        (-[NSPasteboard _web_writeURL:andTitle:types:]): Ditto.
        * WebCoreSupport/WebPasteboardHelper.mm:
        (WebPasteboardHelper::urlFromPasteboard): Ditto.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.

        * WebView/WebView.mm:
        (+[WebView initialize]): Added a call to one of the functions to take advantage
        of the side effect that initializes the globals; this is to help out old versions
        of Safari.
        (+[WebView URLTitleFromPasteboard:]): Changed to call the new function instead
        of getting at the global directly.

        * WebKit.exp: Add exports of the new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
darin [Thu, 30 Aug 2007 00:32:10 +0000 (00:32 +0000)]
    Reviewed by Adele.

        * editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
        Fix an assert that was firing for me all the time when doing editing operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca [Thu, 30 Aug 2007 00:23:37 +0000 (00:23 +0000)]
    Reviewed by Adam.

        Repro hang with some Flash plugin content (http://dougmccune.com/blog/2007/07/25/coming-to-flexcamp-at-adobe/)

        In some cases, Flash ends up starving the main loop by sending a lot of WM_USER + 1 messages. Throttle these
        messages so they won't end up hanging the web browser.

        * plugins/win/PluginViewWin.cpp:
        * plugins/win/PluginViewWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Wed, 29 Aug 2007 23:15:08 +0000 (23:15 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5436800> REGRESSION: PLT is 1.5% slower due
        to r24593 and r25098

        In r25098, we only called setCreatedByParser for XML! This patch
        calls it for HTML too, and takes care of the performance

        * html/HTMLElementFactory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Wed, 29 Aug 2007 22:46:41 +0000 (22:46 +0000)]

        Reviewed by Mitz.

        Fix <rdar://problem/5425951>
        REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong

        If new nodes have been added or style recalc has been done with style sheets still pending, some nodes
        may not have had their real style calculated yet. Normally this state gets cleaned when style sheets arrive
        but in updateLayoutIgnorePendingStylesheets() we need to do full style recalc to get up-to-date style immediatly.

        Added a document flag to track if there are any nodes that did not have their real style calculated due to
        pending stylesheets.

        Test: fast/dynamic/style-access-late-stylesheet-load.html

        * css/CSSStyleSelector.cpp:
        * dom/Document.cpp:
        * dom/Document.h:


        Reviewed by Mitz.

        Test for <rdar://problem/5425951>
        REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong

        * fast/dynamic/style-access-late-stylesheet-load-expected.txt: Added.
        * fast/dynamic/style-access-late-stylesheet-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele [Wed, 29 Aug 2007 22:05:24 +0000 (22:05 +0000)]
    Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15098
        <rdar://problem/5440319> REGRESSION (9A530-9A534): Double scroll bar on pdfs

        * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView):
         Don't suppress scrollbars before the view creation if we're making the view for a non-html view

        * WebView/WebFrameViewInternal.h: Make _scrollView return a WebDynamicScrollBarsView since so many clients were relying on it being that type anyway.
        * WebView/WebFrameView.mm:
        (-[WebFrameView _setDocumentView:]):
        (-[WebFrameView _scrollView]):
        (-[WebFrameView setAllowsScrolling:]):
        (-[WebFrameView allowsScrolling]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView alwaysShowVerticalScroller]):
        (-[WebView setAlwaysShowHorizontalScroller:]):
        (-[WebView alwaysShowHorizontalScroller]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
aliceli1 [Wed, 29 Aug 2007 21:29:26 +0000 (21:29 +0000)]
    Reviewed by Maciej.

        We disable the DeleteButton UI before applying any editing commands.
        This patch simply moves those disable/enable calls to a more correct place, closer to the actual application of the editing command.

        * editing/EditCommand.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakComman...
aliceli1 [Wed, 29 Aug 2007 21:27:42 +0000 (21:27 +0000)]
    fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply()
                                       after dropping a selected image over container's close box

        Reviewed by Darin and Maciej.

        * editing/DeleteButtonController.cpp:
        * editing/DeleteButtonController.h:
        General changes made to DeleteButtonController: when hiding, it's not necessary to clear out
        the m_containerElement and m_target, especially since to fix this bug we need to keep
        their values around.  It's sufficient to just detach the container from target.

        * editing/EditCommand.cpp:
        Move the selection out of the deletion UI since we don't want to expose the deletion UI to any editing.

        * editing/Editor.cpp:
        Move the range out of the deletion UI since we don't want to expose the deletion UI to any editing.

        * editing/htmlediting.cpp:
        * editing/htmlediting.h:
        Moved function that operates on Range from markup.cpp to here
        Added new implementation for function that operates on Selection

        * editing/markup.cpp:
        Moved function out of this file to htmlediting.cpp, and renamed to avoidIntersectionWithNode

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTiger build fix.
hyatt [Wed, 29 Aug 2007 21:27:27 +0000 (21:27 +0000)]
Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTiger build fix.
hyatt [Wed, 29 Aug 2007 21:25:10 +0000 (21:25 +0000)]
Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Wed, 29 Aug 2007 21:25:00 +0000 (21:25 +0000)]

        Reviewed by Adam.

        Added case-insensitivity to checks for adding regression tests.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago The method that was swizzled to fix 5441281 does not exist on Tiger.
hyatt [Wed, 29 Aug 2007 21:17:25 +0000 (21:17 +0000)]
    The method that was swizzled to fix 5441281 does not exist on Tiger.
        Tiger has to do a double swizzle instead (of resetCursorRects and NSCursor's
        set method) in order to roughly achieve the same effect.

        Reviewed by darin

        * WebView/WebHTMLView.mm:
        (+[WebHTMLViewPrivate initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix 64-bit build.
andersca [Wed, 29 Aug 2007 20:39:03 +0000 (20:39 +0000)]
    Fix 64-bit build.

        * WebCoreSupport/WebFrameBridge.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5074612> Added SPI to retrieve certificate info from a WebError.
adachan [Wed, 29 Aug 2007 19:58:22 +0000 (19:58 +0000)]
    <rdar://problem/5074612> Added SPI to retrieve certificate info from a WebError.

        Reviewed by Steve.

        * Interfaces/IWebErrorPrivate.idl: Added IWebErrorPrivate
        * WebError.cpp:
        (WebError::QueryInterface): WebError now also implements IWebErrorPrivate
        (WebError::sslPeerCertificate): retrieves certificate info from CFError's user info.
        * WebError.h:
        * WebKit.vcproj/WebKitGUID.vcproj: Added IWebErrorPrivate_i.c

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hyatt [Wed, 29 Aug 2007 19:48:51 +0000 (19:48 +0000)]

        Fix for 5441281, remove our dependency on cursor rects and drag margins
        in AppKit for a large performance boost on the PLT and iBench.

        Reviewed by darin

        * platform/mac/WidgetMac.mm:
        Suppress the resetting of drag margins when views are added and removed.

        Just use NSCursor's set method to immediately set the cursor.  We no longer
        rely on NSScrollView/NSClipView setDocumentCursor, since that is implemented
        using cursor rects.


        Fix for 5441281, remove our dependency on cursor rects and drag margins
        in AppKit for a large performance boost on the PLT and iBench.

        Reviewed by darin

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendNullEvent]):
        (-[WebBaseNetscapePluginView mouseEntered:]):
        (-[WebBaseNetscapePluginView mouseExited:]):
        (-[WebBaseNetscapePluginView stop]):
        Clean up cursor setting from Netscape plugins.  Don't unconditionally mutate
        the cursor when a plugin stops.

        * WebView/WebFrameView.mm:
        (-[WebFrameView _setDocumentView:]):
        Suppress the resetting of drag margins while the new document view is being
        added to the view hierarchy.

        * WebView/WebHTMLView.mm:
        (-[NSWindow _web_borderView]):
        Expose the border view of the NSWindow so that it can be hit tested.

        Apply a method swizzle to override the private AppKit method, _setCursorForMouseLocation.
        We have to do this to suppress the cursor rect invalidation handling from resetting
        the cursor for no reason.

        The swizzle will do a hit test and allow the cursor set to occur if the mouse ends up
        being over a plugin or over a view other than a WebHTMLView.

        (+[WebHTMLViewPrivate initialize]):
        The swizzle for setCursorForMouseLocation is set up here.

        (-[WebHTMLView _frameOrBoundsChanged]):
        Add a 100ms delay to the fake mouse moved event that fires when the view moves
        under the mouse (without the mouse moving).  This happens on iBench when the
        pages get scrolled.  By adding a delay we ensure that even with the mouse inside
        the window, we don't experience cursor thrashing when pages are updating and
        scrolling rapidly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-29 Rick <rick@writhe.org.uk>
bdash [Wed, 29 Aug 2007 17:39:03 +0000 (17:39 +0000)]
2007-08-29  Rick  <rick@writhe.org.uk>

        Reviewed by Tim Hatcher.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14853
        Bug 14853: Incorrect implementation of ArrayImpl's equality operator

        * platform/ArrayImpl.cpp:
        Fixed typo so that correct variable is used in equality comparison.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-29 Ryan Leavengood <leavengood@gmail.com>
bdash [Wed, 29 Aug 2007 17:35:50 +0000 (17:35 +0000)]
2007-08-29  Ryan Leavengood <leavengood@gmail.com>

        Reviewed by Maciej.

        - posix_memalign takes a void** as its first parameter. My port makes use of this function call.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-29 Peter Kasting <zerodpx@gmail.com>
bdash [Wed, 29 Aug 2007 17:34:01 +0000 (17:34 +0000)]
2007-08-29  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15096
        Move the GIF frame duration minimum check into the various
        ImageSource*.cpp backends and use the same values as

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        * platform/graphics/qt/ImageSourceQt.cpp:
        * platform/image-decoders/gif/GIFImageReader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-29 Peter Kasting <zerodpx@gmail.com>
bdash [Wed, 29 Aug 2007 17:31:22 +0000 (17:31 +0000)]
2007-08-29  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15097
        Make PNGImageDecoder.cpp size its frame buffer vector in its
        constructor, so it never throws decoded image data away no matter
        what order its functions are called in.

        * platform/image-decoders/png/PNGImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-29 Peter Kasting <zerodpx@gmail.com>
bdash [Wed, 29 Aug 2007 17:29:56 +0000 (17:29 +0000)]
2007-08-29  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15104
        Don't double-compensate for sizeof(unsigned) when making a buffer
        overflow check in the GIF decoder.  Now interlaced GIFs don't
        sometimes get nothing/garbage in some of the bottom rows.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump version for submit
sfalken [Wed, 29 Aug 2007 15:53:54 +0000 (15:53 +0000)]
Bump version for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix build.
sfalken [Wed, 29 Aug 2007 08:32:12 +0000 (08:32 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix compilation
hausmann [Wed, 29 Aug 2007 07:56:58 +0000 (07:56 +0000)]
Fix compilation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5079253> Cannot set different margins for the page
sfalken [Wed, 29 Aug 2007 07:46:03 +0000 (07:46 +0000)]
    <rdar://problem/5079253> Cannot set different margins for the page

        Added support for setting margins via page setup for Windows printing.

        Reviewed by Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-28 Mark Rowe <mrowe@apple.com>
bdash [Wed, 29 Aug 2007 07:04:11 +0000 (07:04 +0000)]
2007-08-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej Stachowiak.

        Fix fallout from the fix for <rdar://problem/5437983> (Loading history containing 100,000 entries adds 20s to Safari's startup)
        in r25275.  The array of entries for each day was being maintained in the reverse of the order that was expected.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate insertItem:forDateKey:]): Maintain the array of entries in descending order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved test files in /resources/ subdirectories.
ddkilzer [Wed, 29 Aug 2007 02:51:38 +0000 (02:51 +0000)]
Removed test files in /resources/ subdirectories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Wed, 29 Aug 2007 02:49:48 +0000 (02:49 +0000)]

        Reviewed by Maciej.

        Ignore files in /resources/ subdirectories when creating a list of added tests.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Wed, 29 Aug 2007 00:32:53 +0000 (00:32 +0000)]

        Reviewed by Darin.

        Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.

        Tests: http/tests/security/listener/resources/childWithXMLHttpRequest.html

        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window.
        (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.


        Reviewed by Darin.

        Additional tests for <rdar://problem/5426142>

        * http/tests/security/listener/resources/childWithXMLHttpRequest.html: Added.
        * http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html: Added.
        * http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html: Added.
        * http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
        * http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html: Added.
        * http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
        * http/tests/security/listener/xss-XMLHttpRequest-shortcut.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Wed, 29 Aug 2007 00:15:36 +0000 (00:15 +0000)]

        Reviewed by Darin.

        <rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

        Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
        are still created during the first layout.

        * html/HTMLEmbedElement.cpp:
        Only call layout if the renderer doesn't have a widget.

        * html/HTMLObjectElement.cpp:

        * loader/FrameLoader.cpp:
        Update for enum change.

        * loader/FrameLoaderTypes.h:
        Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.

        * page/mac/WebCoreFrameBridge.h:
        Get rid of the enum here, we can use the one in FrameLoaderTypes.h

        * rendering/RenderPartObject.cpp:
        Only create the plug-in if it's not a Netscape plug-in.

        Fix indentation.


        Reviewed by Darin.

        <rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

        * WebCoreSupport/WebFrameBridge.mm:
        Use the enum from FrameLoaderTypes.h.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-28 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Tue, 28 Aug 2007 23:36:07 +0000 (23:36 +0000)]
2007-08-28  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        <rdar://problem/5444457>: Content is cut when page orientation changed
        in print preview
        Fix: Don't return WebFrame::m_pageRects if it exists; let
        computePageRectsForFrame clear and rewrite it.

        * WebFrame.cpp:
        (WebFrame::computePageRects): Removed an early-return case. Added a

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Tue, 28 Aug 2007 22:08:06 +0000 (22:08 +0000)]
    Reviewed by Darin.

        <rdar://problem/5415006> Command Left in a To Do causes caret to disappear

        * editing/selection/mixed-editability-8.html: Added.
        * editing/selection/mixed-editability-9.html: Added.
        * platform/mac/editing/selection: Added.
        * platform/mac/editing/selection/mixed-editability-8-expected.checksum: Added.
        * platform/mac/editing/selection/mixed-editability-8-expected.png: Added.
        * platform/mac/editing/selection/mixed-editability-8-expected.txt: Added.
        * platform/mac/editing/selection/mixed-editability-9-expected.checksum: Added.
        * platform/mac/editing/selection/mixed-editability-9-expected.png: Added.
        * platform/mac/editing/selection/mixed-editability-9-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Tue, 28 Aug 2007 22:06:52 +0000 (22:06 +0000)]
    Reviewed by Darin.

        <rdar://problem/5415006> Command Left in a To Do causes caret to disappear

        The selection was ending up inside non-editable content at the To Do Options
        arrow image, rather then at the editable position just to the left of that image.
        The problem was that startPositionForLine looked only at line boxes, and there
        is no linebox for the editable position at the far left of a To Do, which is
        a table. Addressed by having startPositionForLine use table offset 0 instead
        of the first VisiblePosition inside the table.

        Found and fixed the similar case with option-left (move by word position).

        Test cases:
        * editing/selection/mixed-editability-8.html: Added.
        * editing/selection/mixed-editability-9.html: Added.

        Source changes:
        * editing/SelectionController.cpp:

        * editing/VisiblePosition.cpp:
        Factored stayInEditableContentLeft() and stayInEditableContentRight()
        out of previous() and next().

        * editing/VisiblePosition.h:
        Declare stayInEditableContentLeft() and stayInEditableContentRight().

        * editing/visible_units.cpp:
        Call stayInEditableContentLeft() or stayInEditableContentRight(), as
        appropriate, so prevent crossing from editable content into
        uneditable content.

        Use table offset 0 instead of the first VisiblePosition in the table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-28 Mark Rowe <mrowe@apple.com>
bdash [Tue, 28 Aug 2007 20:24:26 +0000 (20:24 +0000)]
2007-08-28  Mark Rowe  <mrowe@apple.com>

        Fix the buildbot build.

        * History/WebHistory.mm:
        (timeIntervalForBeginningOfDay):  Explicitly cast to silence compiler warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-28 Mark Rowe <mrowe@apple.com>
bdash [Tue, 28 Aug 2007 20:12:29 +0000 (20:12 +0000)]
2007-08-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5443453> Decreasing history expiration time from 1 year to 1 week can lead to long hang while icon database syncs

        Perform the sync inside a SQLite transaction.  This drops the time taken for the sync from over 90s to under half a second in the
        extreme case of over 90,000 URLs being pruned.

        * loader/icon/IconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Use the correct test paths.
andersca [Tue, 28 Aug 2007 20:06:26 +0000 (20:06 +0000)]
    Use the correct test paths.

        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPut ChangeLog back to UTF-8 after FileMerge went and mangled it for my last commit.
bdash [Tue, 28 Aug 2007 19:55:43 +0000 (19:55 +0000)]
Put ChangeLog back to UTF-8 after FileMerge went and mangled it for my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-28 Mark Rowe <mrowe@apple.com>
bdash [Tue, 28 Aug 2007 19:48:17 +0000 (19:48 +0000)]
2007-08-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

        Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays
        of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems.  NSTimeInterval
        uses less memory and is substantially cheaper during comparisons than NSCalendarDate.  The use of the HashMap
        avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days
        history items.

        The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s.  Loading
        100 items drops from 0.003s to 0.002s.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate init]):
        (-[WebHistoryPrivate dealloc]):
        (timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day.
        (-[WebHistoryPrivate findKey:forDay:]):
        (-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search.
        (-[WebHistoryPrivate _removeItemFromDateCaches:]):
        (-[WebHistoryPrivate _addItemToDateCaches:]):
        (-[WebHistoryPrivate removeAllItems]):
        (-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API.
        This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed.
        (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]):
        (-[WebHistoryPrivate arrayRepresentation]):
        (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the
        number of live autoreleased objects generated to a reasonable level.
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title
        rather than setting it after construction.  This prevents a modification notification from being sent for each WebHistoryItem that is loaded.
        * History/WebHistoryItemInternal.h:
        * History/WebHistoryPrivate.h:
        * Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.
        * Misc/WebNSCalendarDateExtras.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:

2007-08-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

        Add a new constructor for HistoryItem that initializes the alternate title.  This prevents WebHistoryItem
        in WebKit from having explicitly set the display title, which triggers a history item changed notification
        to be posted, for each history item loaded.

        * WebCore.exp:
        * history/HistoryItem.cpp:
        * history/HistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 28 Aug 2007 19:05:56 +0000 (19:05 +0000)]

        Reviewed by Darin.

        <rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues

        Add a shouldContentSniff flag to ResourceLoader and ResourceHandle and have XMLHttpRequest
        pass in false when creating its subresource loader.

        * WebCore.exp:
        * loader/MainResourceLoader.cpp:
        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        * loader/SubresourceLoader.h:
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * platform/network/ResourceHandle.cpp:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        * platform/network/mac/ResourceHandleMac.mm:
        * xml/XMLHttpRequest.cpp:


        Reviewed by Darin.

        <rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues

        Expose WKSetNSURLRequestShouldContentSniff to WebCore.

        * WebCoreSupport/WebSystemInterface.m:


        Reviewed by Darin.

        <rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues

        * http/tests/xmlhttprequest/resources/small-chunks.cgi: Added.
        * http/tests/xmlhttprequest/small-chunks-response-text-expected.txt: Added.
        * http/tests/xmlhttprequest/small-chunks-response-text.html: Added.
        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add WKSetNSURLRequestShouldContentSniff.
andersca [Tue, 28 Aug 2007 19:03:40 +0000 (19:03 +0000)]
    Add WKSetNSURLRequestShouldContentSniff.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4876242> Added SPI to fetch SSL certificate information.
adachan [Tue, 28 Aug 2007 17:23:34 +0000 (17:23 +0000)]
    <rdar://problem/4876242> Added SPI to fetch SSL certificate information.

        Reviewed by Adam and Steve.

        * Interfaces/IWebURLResponsePrivate.idl: Added.
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebURLResponse.cpp:
        (WebURLResponse::sslPeerCertificate): gets peer certificate context from CFNetwork
        (WebURLResponse::certificateDictionary): gets the dictionary that contains SSL certificate
        info from CFNetwork.  We retain the dictionary to ensure the certificate context is valid
        throughout the lifetime of the WebURLResponse.
        * WebURLResponse.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4876242> Added SPI to fetch SSL certificate information.
adachan [Tue, 28 Aug 2007 17:20:49 +0000 (17:20 +0000)]
    <rdar://problem/4876242> Added SPI to fetch SSL certificate information.
        Updated libraries.

        Reviewed by Adam.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn...
sfalken [Tue, 28 Aug 2007 16:29:08 +0000 (16:29 +0000)]
    <rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn't redraw if page isn't loaded

        Don't bypass WebView WM_PAINT if the WebView has never committed a page.
        Added getter for committedFirstRealDocumentLoad.

        Reviewed by Maciej.

        * WebView.cpp:
        (WebViewWndProc): Don't skip painting if we haven't committed any pages in this view.
        * loader/FrameLoader.h: Added committedFirstRealDocumentLoad.
        (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by NOBODY (layout test result fix).
oliver [Tue, 28 Aug 2007 06:35:23 +0000 (06:35 +0000)]
    Reviewed by NOBODY (layout test result fix).

        Output of layoutTestController.dumpChildFramesAsText changes in non-relevant way
        when running this test on its own vs. running as part of the full suite.

        Correcting test result for the output produced while running the full suite.

        * fast/encoding/frame-default-enc-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago rs=brady
oliver [Tue, 28 Aug 2007 05:59:26 +0000 (05:59 +0000)]

        Convert all the encoding tests to plain text dumps.

        * fast/encoding/char-decoding-expected.txt:
        * fast/encoding/char-decoding-mac-expected.txt: Added.
        * fast/encoding/char-decoding-mac.html: Added.
          char-decoding-mac tests the ability to decode the mac specific legacy x-nextstep charset.
        * fast/encoding/char-decoding.html:
        * fast/encoding/frame-default-enc-expected.checksum: Removed.
        * fast/encoding/frame-default-enc-expected.png: Removed.
        * fast/encoding/frame-default-enc-expected.txt:
        * fast/encoding/frame-default-enc.html:
        * fast/encoding/mispositioned-meta-expected.checksum: Removed.
        * fast/encoding/mispositioned-meta-expected.png: Removed.
        * fast/encoding/mispositioned-meta-expected.txt:
        * fast/encoding/mispositioned-meta.html:
        * fast/encoding/tag-in-title-expected.checksum: Removed.
        * fast/encoding/tag-in-title-expected.png: Removed.
        * fast/encoding/tag-in-title-expected.txt:
        * fast/encoding/tag-in-title.html:
        * platform/win/Skipped:
          Skip char-decoding-mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Mon, 27 Aug 2007 23:09:39 +0000 (23:09 +0000)]

        Reviewed by Maciej.

        Fix <rdar://problem/5433144>
        REGRESSION: Unable to click "Select" link at Expedia for car rentals

        javascript: URLs need special handling when serializing. Escaping them like
        normal attribute values can do bad things. Try hard to not escape anything,
        escape quote characters only if really necessary. Try to match Firefox.

        Test: fast/innerHTML/javascript-url.html

        * editing/markup.cpp:


        Reviewed by Maciej.

        Test for <rdar://problem/5433144>
        REGRESSION: Unable to click "Select" link at Expedia for car rentals

        * fast/innerHTML/javascript-url-expected.txt: Added.
        * fast/innerHTML/javascript-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago rs=adam
oliver [Mon, 27 Aug 2007 22:46:39 +0000 (22:46 +0000)]

        Remove tests effected by <rdar://problem/5317287> from the windows skiplist

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@25265 268f45cc-cd09-0410...
hyatt [Mon, 27 Aug 2007 21:57:32 +0000 (21:57 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for 5441224, micro-optimizations to improve the PLT by 1%.
hyatt [Mon, 27 Aug 2007 21:57:02 +0000 (21:57 +0000)]
    Fix for 5441224, micro-optimizations to improve the PLT by 1%.

        Reviewed by Darin

        * css/CSSStyleSelector.cpp:
        * platform/mac/FontMac.mm:
        * rendering/RenderInline.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
kmccullo [Mon, 27 Aug 2007 20:43:29 +0000 (20:43 +0000)]
    Reviewed by John.

        - Removed Leopard leaks list since all of those radars were fixed.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-27 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 27 Aug 2007 17:57:10 +0000 (17:57 +0000)]
2007-08-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15091
          Crash in RenderBlock::skipWhitespace during layout <rdar://problem/5439631>

        Test: fast/replaced/applet-disabled-positioned.html

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer): Changed to call
        RenderObject::createObject(), which accounts for style.

2007-08-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15091
          Crash in RenderBlock::skipWhitespace during layout <rdar://problem/5439631>

        * fast/replaced/applet-disabled-positioned.html: Added.
        * platform/mac/fast/replaced: Added.
        * platform/mac/fast/replaced/applet-disabled-positioned-expected.checksum: Added.
        * platform/mac/fast/replaced/applet-disabled-positioned-expected.png: Added.
        * platform/mac/fast/replaced/applet-disabled-positioned-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Mark.
aroben [Mon, 27 Aug 2007 08:13:27 +0000 (08:13 +0000)]
 Rubberstamped by Mark.

        * Scripts/pdevenv: Pass arguments along to devenv.com.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - quick follow on to that last check-in
darin [Mon, 27 Aug 2007 06:40:16 +0000 (06:40 +0000)]
    - quick follow on to that last check-in

        * API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject):
        Need to initialize m_class to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-26 Mark Rowe <mrowe@apple.com>
bdash [Mon, 27 Aug 2007 06:17:48 +0000 (06:17 +0000)]
2007-08-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/4949002> JSGlobalContextCreate can cause crashes because it passes a NULL JSContextRef to the globalObjectClass's initialize callback

        JSCallbackObject now tracks whether it was constructed with a null ExecState.  This will happen when the object is being used as the global object,
        as the Interpreter needs to be created after the global object.  In this situation the initialization is deferred until after the Interpreter's
        ExecState is available to be passed down to the initialize callbacks.

        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::init): Track whether we successfully initialized.
        (KJS::JSCallbackObject::initializeIfNeeded): Attempt to initialize with the new ExecState.
        * API/JSCallbackObject.h:
        * API/JSContextRef.cpp:
        (JSGlobalContextCreate): Initialize the JSCallbackObject with the Interpreter's ExecState.
        * API/testapi.c:
        (main): Verify that the context passed to the initialize callback is non-null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-26 Mark Rowe <mrowe@apple.com>
bdash [Mon, 27 Aug 2007 06:02:50 +0000 (06:02 +0000)]
2007-08-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5438496> JSGlobalContextCreate crashes when passed a custom class

        * API/JSContextRef.cpp:
        (JSGlobalContextCreate): Specify jsNull() as the prototype and let Interpreter's constructor fix it up to point at builtinObjectPrototype().
        * API/testapi.c:
        (main): Use an instance of a custom class as the global object to ensure the code path is exercised in the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Mon, 27 Aug 2007 00:11:58 +0000 (00:11 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5433726>
        Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (http://www.yahoo.com/)

        Test: editing/style/temporary-span-crash.html

        * page/Frame.cpp:
        Temporary span created here might not have renderer if document has style sheet that makes it display:none.
        Set display:inline explicitly in spans style attribute. This temporary span does not need to get its display
        value from actual document style sheets. Null check the renderer too to be sure.


        Reviewed by Darin.

        Test for <rdar://problem/5433726>
        Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (http://www.yahoo.com/)

        * editing/style/temporary-span-crash-expected.txt: Added.
        * editing/style/temporary-span-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 26 Aug 2007 13:39:57 +0000 (13:39 +0000)]

        Reviewed by Mark Rowe.

        Update prepare-ChangeLog to generate the datestamp in the correct timezone.

        * Scripts/prepare-ChangeLog:
        (changeLogDate): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer [Sun, 26 Aug 2007 13:20:31 +0000 (13:20 +0000)]

        Reviewed by Mark Rowe and David Kilzer.

        Fix build failure on arm.

        * wtf/Platform.h: Also test if __arm__ is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam and Sam
oliver [Sun, 26 Aug 2007 02:16:42 +0000 (02:16 +0000)]
    Reviewed by Adam and Sam

        <rdar://problem/5269732> Safari 3.0 for Windows cuts off text in textarea boxes during sending forms (14562)
        <http://bugs.webkit.org/show_bug.cgi?id=14562> [Win] Textarea contents partially eaten on submit/copy

        WebView::handleEditingKeyboardEvent assumed all keycodes that did not trigger a named command were
        to be inserted.  This could cause unexpected behaviour when control characters (eg. escape) are sent,
        or could cause data loss when sent a null character (as happens when dead keys are used for international

        This patch corrects WebView::handleEditingKeyboardEvent to prevent such characters from being sent
        to Editor::insertText.  This behaviour matches Firefox.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sat, 25 Aug 2007 20:42:23 +0000 (20:42 +0000)]

        Reviewed by NOBODY (fixes layout tests).

        Don't pass any options to window.open() in target-frame-from-window.html, specifically
        those that cause the window to be resized.  This caused a downstream failure in
        cross-frame-access-put.html because the window.outerHeight and window.outerWidth
        properties were sometimes affected by the new window size used in the popup window.

        * http/tests/navigation/target-frame-from-window.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Sat, 25 Aug 2007 19:08:21 +0000 (19:08 +0000)]

        Reviewed by Adele.

        Fix for <rdar://problem/5426142>

        Use the EventTarget's frame when creating the EventListener.

        Tests: http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html

        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/kjs_window.cpp:


        Reviewed by Adele.

        Tests for <rdar://problem/5426142>

        * http/tests/security/listener: Added.
        * http/tests/security/listener/resources: Added.
        * http/tests/security/listener/resources/childWindow.html: Added.
        * http/tests/security/listener/resources/childWithButton.html: Added.
        * http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-addEventListener.html: Added.
        * http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-shortcut.html: Added.
        * http/tests/security/listener/resources/targetChild-window-onclick-addEventListener.html: Added.
        * http/tests/security/listener/resources/targetChild-window-onclick-shortcut.html: Added.
        * http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
        * http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html: Added.
        * http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
        * http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html: Added.
        * http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
        * http/tests/security/listener/xss-window-onclick-addEventListener.html: Added.
        * http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
        * http/tests/security/listener/xss-window-onclick-shortcut.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 25 Aug 2007 19:02:35 +0000 (19:02 +0000)]
2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15077
          REGRESSION: Cannot drag selected text out of a background window

        * manual-tests/drag-out-of-background-window.html: Added.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
rwlbuis [Sat, 25 Aug 2007 16:57:13 +0000 (16:57 +0000)]
    Reviewed by Darin.

        DOM table rules are not updated when changed

        On a dynamic rules attr change, mark the table cells and
        their ancestors (up to and including the table tag) as

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Sat, 25 Aug 2007 16:35:02 +0000 (16:35 +0000)]

        Reviewed by Mitz.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15073
        <rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas

        Test: fast/forms/drag-out-of-textarea.html

        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
          Only restricts hit testing if the placeholder text is visible.
        * rendering/RenderTextControl.h: (WebCore::RenderTextControl::placeholderIsVisible): Added.


        Reviewed by Mitz.

        Test for http://bugs.webkit.org/show_bug.cgi?id=15073
        <rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas

        * fast/forms/drag-out-of-textarea-expected.txt: Added.
        * fast/forms/drag-out-of-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
bdash [Sat, 25 Aug 2007 15:49:12 +0000 (15:49 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Peter Kasting <zerodpx@gmail.org>
bdash [Sat, 25 Aug 2007 14:03:16 +0000 (14:03 +0000)]
2007-08-25  Peter Kasting <zerodpx@gmail.org>

        Reviewed by Maciej Stachowiak.

        Part 3 of http://bugs.webkit.org/show_bug.cgi?id=14967
        Bug 14967: Reduce wtf::Vector::operator[]() overloads

        * wtf/Vector.h:
        (WTF::Vector::operator[]): Only provide versions of operator[] that takes a size_t argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Peter Kasting <zerodpx@gmail.org>
bdash [Sat, 25 Aug 2007 14:00:03 +0000 (14:00 +0000)]
2007-08-25  Peter Kasting <zerodpx@gmail.org>

        Reviewed by Sam Weinig.

        Part 2 of http://bugs.webkit.org/show_bug.cgi?id=14967.
        Eliminate all remaining implicit conversions of wtf::Vector<T> to T*.  Where code was
        previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()

        * wtf/Vector.h:

2007-08-25  Peter Kasting <zerodpx@gmail.org>

        Reviewed by Sam Weinig.

        Part 2 of http://bugs.webkit.org/show_bug.cgi?id=14967.
        Eliminate all remaining implicit conversions of wtf::Vector<T> to T*.  Where code was
        previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()

        * bindings/js/kjs_navigator.cpp:
        * loader/mac/LoaderNSURLExtras.m:
        * page/FrameView.cpp:
        * platform/mac/PlugInInfoStoreMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Mark Rowe <mrowe@apple.com>
bdash [Sat, 25 Aug 2007 12:58:05 +0000 (12:58 +0000)]
2007-08-25  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Mitz.

        Disable fast/js/string-concatenate-outofmemory.html until <http://bugs.webkit.org/show_bug.cgi?id=15046> is resolved.

        * fast/js/string-concatenate-outofmemory.html: Removed.
        * fast/js/string-concatenate-outofmemory.html-disabled: Copied from LayoutTests/fast/js/string-concatenate-outofmemory.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 25 Aug 2007 12:37:57 +0000 (12:37 +0000)]
2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Rubber-stamped by Adam Roben

        - remove unused file

        * platform/win/MouseEventWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Jasper Bryant-Greene <m@ni.ac.nz>
bdash [Sat, 25 Aug 2007 12:35:44 +0000 (12:35 +0000)]
2007-08-25  Jasper Bryant-Greene  <m@ni.ac.nz>

        Reviewed by Oliver Hunt.

        Set paintingDisabled to true in Cairo's GraphicsContext constructor
        when passed a null PlatformGraphicsContext.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 25 Aug 2007 12:30:19 +0000 (12:30 +0000)]
2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15056
          REGRESSION (r21472): Digg Podcasts Episodes Render "Digg" counter incorrectly

        Covered by fast/parser/residual-style-close-across-n-blocks.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the
        residual style was closed before anything else in the block (so it does
        not apply to anything inside the block) avoid creating an empty element for
        it inside the block.

2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - updated test and results for http://bugs.webkit.org/show_bug.cgi?id=15056
          REGRESSION (r21472): Digg Podcasts Episodes Render "Digg" counter incorrectly

        * fast/parser/residual-style-close-across-n-blocks-expected.txt:
        * fast/parser/residual-style-close-across-n-blocks.html:
        * tables/mozilla/other/wa_table_tr_align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 25 Aug 2007 12:26:19 +0000 (12:26 +0000)]
2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14972
          Moving cursor down in contentEditable section fails if styled line-height:1em

        Test: editing/selection/move-by-line-003.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each
        line is tested for hits between its overflow top and the next line's overflow top.
        This matches RenderBlock::positionForCoordinates.

2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14972
          Moving cursor down in contentEditable section fails if styled line-height:1em

        * editing/selection/move-by-line-003-expected.txt: Added.
        * editing/selection/move-by-line-003.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-08-25 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 25 Aug 2007 12:21:02 +0000 (12:21 +0000)]
2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Justin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14792
          <rdar://problem/5367763> REGRESSION: Copy inserts carriage return in middle of selection

        Test: editing/pasteboard/newlines-around-floating-or-positioned.html

        * editing/TextIterator.cpp:
        (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around
        floating or positioned blocks. This behavior seems to match WinIE's.

2007-08-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Justin.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14792
          <rdar://problem/5367763> REGRESSION: Copy inserts carriage return in middle of selection

        * editing/pasteboard/newlines-around-floating-or-positioned-expected.txt: Added.
        * editing/pasteboard/newlines-around-floating-or-positioned.html: Added.
        * fast/events/capture-on-target-expected.txt:
        * fast/events/mouseclick-target-and-positioning-expected.txt:
        * fast/events/mouseover-mouseout-expected.txt:
        * fast/events/mouseover-mouseout2-expected.txt:
        * fast/events/window-events-bubble-expected.txt:
        * fast/events/window-events-bubble2-expected.txt:
        * fast/events/window-events-capture-expected.txt:
        * fast/forms/input-appearance-elementFromPoint-expected.txt:
        * fast/forms/onselect-textarea-expected.txt:
        * fast/forms/onselect-textfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump version for submit
sfalken [Sat, 25 Aug 2007 05:52:45 +0000 (05:52 +0000)]
Bump version for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
weinig [Sat, 25 Aug 2007 04:12:18 +0000 (04:12 +0000)]

        Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.


        Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@25230 268f45cc-cd09-0410...
justing [Sat, 25 Aug 2007 01:23:13 +0000 (01:23 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Sat, 25 Aug 2007 01:20:33 +0000 (01:20 +0000)]

        Reviewed by Darin.

        <rdar://problem/5432254> GoogleDocs: A hang occurs when applying list style to selected table

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the position
        that marked the start of the range to delete has been removed from the
        document, and it was inside the node that holds the position that marks
        the end of the range to delete, don't remove any children of that node,
        because we don't know how many to remove.  For example, if the end is
        [a, 5] and the start was in some descendant of a and was removed, don't
        remove any of the children of a.  We will now refuse to remove some content
        incorrectly, but that's less dangerous than removing content incorrectly.
        Long term we need to update these positions as we remove content from the
        document, but that seems like a more risky change.  Added a testcase.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::modifyRange): If the end of the selection to
        modify is just after a table, and if the start of the selection is inside
        that table, the last paragraph that we'll want modify is the last one inside
        the table, not the paragraph that contains the table itself. Adjust
        startOfLastParagraph here to avoid infinite recursion.


        Reviewed by Darin.

        <rdar://problem/5432254> GoogleDocs: A hang occurs when applying list style to selected table

        * editing/execCommand/5432254-1.html: Added.
        * editing/execCommand/5432254-2.html: Added.
        * platform/mac/editing/execCommand: Added.
        * platform/mac/editing/execCommand/5432254-1-expected.checksum: Added.
        * platform/mac/editing/execCommand/5432254-1-expected.png: Added.
        * platform/mac/editing/execCommand/5432254-1-expected.txt: Added.
        * platform/mac/editing/execCommand/5432254-2-expected.checksum: Added.
        * platform/mac/editing/execCommand/5432254-2-expected.png: Added.
        * platform/mac/editing/execCommand/5432254-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove conflict marker.
andersca [Sat, 25 Aug 2007 00:49:21 +0000 (00:49 +0000)]
Remove conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Sat, 25 Aug 2007 00:47:11 +0000 (00:47 +0000)]

        Reviewed by Geoff.

        REGRESSION: Dynamically loaded images fail to load

        * html/HTMLImageLoader.cpp:
        Initialize the m_elementIsProtected member.

        Assert that the element is not protected.

        If the image is not null, protect the element. Otherwise, unprotect it.

        Unprotect the element here.

        New methods which protect and unprotect the element.

        * html/HTMLImageLoader.h:


        Reviewed by Geoff.

        REGRESSION: Dynamically loaded images fail to load

        * fast/dom/HTMLImageElement/image-loading-gc-expected.txt: Added.
        * fast/dom/HTMLImageElement/image-loading-gc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kmccullo [Sat, 25 Aug 2007 00:33:24 +0000 (00:33 +0000)]
    Reviewed by Darin.

        <rdar://problem/5437038> 1 credential object leaked for each call to credentialWithUser:password:persistence
        - Use initWithUser instead of credentialWithUser because credentialWithUser leaks.

        * Panels/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
        (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25226 268f45cc-cd09-0410-ab3c-d52691b4dbfc