WebKit-https.git
11 years ago2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 29 Apr 2010 11:02:36 +0000 (11:02 +0000)]
2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Maciej Stachowiak.

        Add missing pixel test results for several tests on Mac. Now doesn't create any new files anymore, when running run-webkit-tests -p.

        * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.checksum: Added.
        * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.checksum: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Added.
        * platform/mac/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/mac/fast/media/media-query-invalid-value-expected.png: Added.
        * platform/mac/fast/runin/generated2-expected.checksum: Added.
        * platform/mac/fast/runin/generated2-expected.png: Added.
        * platform/mac/fast/runin/generated3-expected.checksum: Added.
        * platform/mac/fast/runin/generated3-expected.png: Added.
        * platform/mac/fast/runin/generated4-expected.checksum: Added.
        * platform/mac/fast/runin/generated4-expected.png: Added.
        * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 10:55:22 +0000 (10:55 +0000)]
2010-04-29  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Darin Fisher.

        Include WindowFeatures in call to WebViewClient::createView.

        https://bugs.webkit.org/show_bug.cgi?id=38301

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove unnecessary call to FrameView::forceLayout() in setViewportSize()
hausmann@webkit.org [Thu, 29 Apr 2010 10:42:59 +0000 (10:42 +0000)]
Remove unnecessary call to FrameView::forceLayout() in setViewportSize()
This prevents a double relayout on resize.

Patch by Andreas Kling <andreas.kling@nokia.com> on 2010-04-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=38179

Thanks to Nate Whetsell <nathan.whetsell@gmail.com> for spotting this.

* Api/qwebpage.cpp:
(QWebPage::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 10:35:11 +0000 (10:35 +0000)]
2010-04-29  Garret Kelly  <gdk@chromium.org>

        Reviewed by Darin Fisher.

        Expose the RuntimeFeature for touch events through the
        WebRuntimeFeatures mechanism.
        https://bugs.webkit.org/show_bug.cgi?id=37486

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableTouch):
        (WebKit::WebRuntimeFeatures::isTouchEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRefactored svn-apply and svn-unapply to use the new
cjerdonek@webkit.org [Thu, 29 Apr 2010 10:33:18 +0000 (10:33 +0000)]
Refactored svn-apply and svn-unapply to use the new
parsePatch() subroutine.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34033

* Scripts/VCSUtils.pm:
  - Consolidated %diffHash documentation.
  - Added prepareParsedPatch().

* Scripts/svn-apply:
  - Replaced main while loop with calls to parsePatch() and
    prepareParsedPatch().

* Scripts/svn-unapply:
  - Replaced main while loop with calls to parsePatch() and
    prepareParsedPatch().

* Scripts/test-webkitperl:
  - Changed to render relative test paths rather than absolute
    test paths.

* Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
  - Added unit tests for prepareParsedPatch().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 10:25:16 +0000 (10:25 +0000)]
2010-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Refactor qtscriptglobal.h
        https://bugs.webkit.org/show_bug.cgi?id=37953

        Use the same pattern in qtscriptglobal.h as in
        qwebkitglobal.h without checking for specific OSs.

        * qt/api/qtscriptglobal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
hausmann@webkit.org [Thu, 29 Apr 2010 10:20:29 +0000 (10:20 +0000)]
[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
https://bugs.webkit.org/show_bug.cgi?id=38316

Reviewed by Tor Arne Vestbø.

Accessing properties of a deleted objects doesn't throw an exception
anymore.

Continue to expose the QObject class wrapper for objects that
previously existed but don't exist anymore. QtClass is safe to
use with a deleted QObject.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getClass): Return null only if m_class
doesn't exist yet and there's no m_object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 10:04:47 +0000 (10:04 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        Reverse animations don't work in some use cases
        https://bugs.webkit.org/show_bug.cgi?id=38075

        This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
        with the CA implementation. That special case code path is now a bug - and this patch removes it.

        http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
        animation correctly.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::TransformAnimationQt::applyFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, test expectations update.
ukai@chromium.org [Thu, 29 Apr 2010 09:42:46 +0000 (09:42 +0000)]
Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt: fast/media/media-query-invalid-value.html should be MISSING, not IMAGE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>
eric@webkit.org [Thu, 29 Apr 2010 09:33:42 +0000 (09:33 +0000)]
2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>

        Reviewed by Adam Barth.

        Test whether HTMLOptionElement::ownerSelectElement() is considering the keygen element.
        https://bugs.webkit.org/show_bug.cgi?id=26016

        * fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
        * fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.
2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>

        Reviewed by Adam Barth.

        HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
        https://bugs.webkit.org/show_bug.cgi?id=26016

        Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.

        Test: fast/dom/HTMLKeygenElement/keygen-option-select.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::ownerSelectElement):
        Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 29 Apr 2010 09:07:01 +0000 (09:07 +0000)]
2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
        https://bugs.webkit.org/show_bug.cgi?id=38307

        balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
        We now properly ignored the subtree. s/def/defs/ and the testcase works again.

        fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
        Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.

        Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
        I can now run those tests with --tolerance 0 without a problem.

        * fast/backgrounds/resources/balloon.svg: s/def/defs/
        * fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
        * fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
        * platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
        * platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, test expectations update.
ukai@chromium.org [Thu, 29 Apr 2010 08:57:36 +0000 (08:57 +0000)]
Unreviewed, test expectations update.

r58479 add fast/media/media-query-invalid-value.html, but it misses
image expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Thu, 29 Apr 2010 08:46:29 +0000 (08:46 +0000)]
2010-04-29  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Eric Seidel.

        Add EFL-specific code to Widget.h and move the empty
        frameRectsChanged() definition to Widget.cpp, since the EFL port
        needs to override that.
        http://webkit.org/b/36317

        No new tests required.

        * WebCore.base.exp:
        * platform/Widget.cpp:
        (WebCore::Widget::frameRectsChanged):
        * platform/Widget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 29 Apr 2010 08:44:12 +0000 (08:44 +0000)]
2010-04-29  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        wrong filename: LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt
        https://bugs.webkit.org/show_bug.cgi?id=38310

        * platform/win/fast/text/international/bold-bengali-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
hausmann@webkit.org [Thu, 29 Apr 2010 08:41:53 +0000 (08:41 +0000)]
[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
https://bugs.webkit.org/show_bug.cgi?id=38314

Reviewed by Tor Arne Vestbø.

Make sure that there's always a main frame when returning from createWindow()
to the caller in WebCore.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 29 Apr 2010 08:25:56 +0000 (08:25 +0000)]
2010-04-29  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
        https://bugs.webkit.org/show_bug.cgi?id=38216

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 08:14:50 +0000 (08:14 +0000)]
2010-04-29  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Small cleanup.

        QScriptValuePrivate constructor shouldn't take QScriptEngine pointer
        as a parameter, because it breaks a private / public separation rule.
        QScriptEnginePrivate::get(QScriptEngine*) should return
        a QScriptEnginePrivate pointer instead of a QScriptEnginePtr, it simplifies
        implementation.

        [Qt] QScriptValuePrivate class needs some cleanup.
        https://bugs.webkit.org/show_bug.cgi?id=37729

        * qt/api/qscriptengine_p.h:
        (QScriptEnginePrivate::get):
        * qt/api/qscriptvalue.cpp:
        (QScriptValue::QScriptValue):
        * qt/api/qscriptvalue_p.h:
        (QScriptValuePrivate::QScriptValuePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 29 Apr 2010 07:52:37 +0000 (07:52 +0000)]
2010-04-29  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Simon Hausmann.

        [WINCE] Export g_stackBase with JS_EXPORTDATA
        https://bugs.webkit.org/show_bug.cgi?id=37437

        Export g_stackBase with JS_EXPORTDATA as it is used by SharedTimerWince.cpp.

        * runtime/Collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 29 Apr 2010 07:42:12 +0000 (07:42 +0000)]
2010-04-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=38235

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input.
        (WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D.
        (WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input.
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
        * html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
        * platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input.
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):
2010-04-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=38235

        * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 07:15:15 +0000 (07:15 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
        https://bugs.webkit.org/show_bug.cgi?id=38076

        This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
        animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
        is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
        upon stop (updateState) and not upon the object's destruction.

        http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
        the animation is toggled frequently.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::TransformAnimationQt::~TransformAnimationQt):
        (WebCore::TransformAnimationQt::applyFrame):
        (WebCore::TransformAnimationQt::updateState):
        (WebCore::OpacityAnimationQt::~OpacityAnimationQt):
        (WebCore::OpacityAnimationQt::updateState):
        (WebCore::GraphicsLayerQt::removeAnimationsForProperty):
        (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Thu, 29 Apr 2010 07:05:32 +0000 (07:05 +0000)]
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Fraser.

        Media queries empty values
        https://bugs.webkit.org/show_bug.cgi?id=38116

        Adding isValid() method to MediaQueryExp to make it possible to differentiate
        between queries with empty values and queries with invalid values.

        * fast/media/media-query-invalid-value-expected.txt: Added.
        * fast/media/media-query-invalid-value.html: Added.
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Fraser.

        Media queries empty values
        https://bugs.webkit.org/show_bug.cgi?id=38116

        Adding isValid() method to MediaQueryExp to make it possible to differentiate
        between queries with empty values and queries with invalid values.

        Test: fast/media/media-query-invalid-value.html

        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::MediaQueryExp):
        * css/MediaQueryExp.h:
        (WebCore::MediaQueryExp::isValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Thu, 29 Apr 2010 06:19:24 +0000 (06:19 +0000)]
2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Added to VCSUtils's parseDiffHeader() support for binary patches.

        https://bugs.webkit.org/show_bug.cgi?id=38094

        The parseDiffHeader() function is part of new patch-parsing code
        for svn-apply and svn-unapply that will go live in a subsequent
        revision.

        * Scripts/VCSUtils.pm:
          - Added logic to parseDiffHeader() to recognize the ending of
            the header portion of a binary diff.

        * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
          - Added unit test cases for SVN and Git binary diffs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 06:10:03 +0000 (06:10 +0000)]
2010-04-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Allow editing script resources when resource tracking is enabled.

        https://bugs.webkit.org/show_bug.cgi?id=38269

        * inspector/front-end/ScriptView.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.canEditScripts):
        (WebInspector.ScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.get textModel):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        (WebInspector.SourceView.prototype._addBreakpoint):
        (WebInspector.SourceView.prototype._editLine):
        (WebInspector.SourceView.prototype._editLineComplete):
        (WebInspector.SourceView.prototype._sourceIDForLine):
2010-04-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Allow editing script resources when resource tracking is enabled.

        http://bugs.webkit.org/show_bug.cgi?id=38269

        * src/js/DebuggerAgent.js:
        * src/js/InspectorControllerImpl.js:
        (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
        (.devtools.InspectorBackendImpl.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-25 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 29 Apr 2010 04:45:17 +0000 (04:45 +0000)]
2010-04-25  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Darin Adler.

        Clicking a scrollbar blurs the currently focused element
        https://bugs.webkit.org/show_bug.cgi?id=16809

        WebKit ports that do not use native (platform) widgets for rendering the scrollbars
        are currently mismatching a common behaviour of other browser vendors (including
        Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
        WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
        instance, can observe the opposite behaviour.

        Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
        If that is the case, it bails out and do not change focus behavior at all.

        It is important to note that the given way this is implemented by this patch, non-frame
        scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
        in the same way as it works currently.

        Tests: scrollbars/scrollbar-click-does-not-blur-content.html
               scrollbars/scrollbar-iframe-click-does-not-blur-content.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchMouseEve

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo an unordered compare so that we don't treat NaN incorrectly.
oliver@apple.com [Thu, 29 Apr 2010 04:34:50 +0000 (04:34 +0000)]
Do an unordered compare so that we don't treat NaN incorrectly.

RS=Gavin Barraclough

* jit/ThunkGenerators.cpp:
(JSC::powThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix test failures seen on the Leopard build bot after r58467
mitz@apple.com [Thu, 29 Apr 2010 04:23:52 +0000 (04:23 +0000)]
Try to fix test failures seen on the Leopard build bot after r58467

Rubber-stamped by Maciej Stachowiak.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_zeroWidthSpaceGlyph before
calling widthForGlyph(), as the latter uses the former.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 04:20:36 +0000 (04:20 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Document that subprocess.poll/wait are not threadsafe
        https://bugs.webkit.org/show_bug.cgi?id=38289

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 29 Apr 2010 04:16:29 +0000 (04:16 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Thu, 29 Apr 2010 04:13:23 +0000 (04:13 +0000)]
2010-04-28  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Make ClipboardGtk a "live" DataTransfer object, able to modify
        the clipboard when setData(...) is called.

        * platform/gtk/Skipped: Uncomment tests that are now passing.
2010-04-28  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Make ClipboardGtk a "live" DataTransfer object, able to modify
        the clipboard when setData(...) is called.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method.
        (WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data.
        (WebCore::dataObjectTypeFromHTMLClipboardType): Added.
        (WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard.
        (WebCore::ClipboardGtk::clearAllData): Ditto.
        (WebCore::joinURIList): Added.
        (WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible.
        (WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard.
        (WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types.
        (WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files.
        (WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard.
        (WebCore::ClipboardGtk::writeRange): Ditto.
        (WebCore::ClipboardGtk::writePlainText): Ditto.
        (WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
        * platform/gtk/ClipboardGtk.h:
        (WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
        * platform/gtk/DataObjectGtk.cpp:
        (WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean &nbsp; from plain text.
        (WebCore::DataObjectGtk::markup): Actually return the range if it's set.
        (WebCore::DataObjectGtk::setText): Clean &nbsp; from plain text.
        (WebCore::DataObjectGtk::clearText): Added.
        (WebCore::DataObjectGtk::clearMarkup): Added.
        * platform/gtk/DataObjectGtk.h:
        (WebCore::DataObjectGtk::clearURIList): Added.
        (WebCore::DataObjectGtk::clearImage): Added.
        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets.
        (WebCore::urisToKURLVector): Added.
        (WebCore::PasteboardHelper::getClipboardContents): Added.
        (WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs.
        (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
        * platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 29 Apr 2010 03:57:16 +0000 (03:57 +0000)]
2010-04-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add fast paths for Math.pow and Math.sqrt
        https://bugs.webkit.org/show_bug.cgi?id=38294

        Add specialized thunks for Math.pow and Math.sqrt.
        This requires adding a sqrtDouble function to the MacroAssembler
        and sqrtsd to the x86 assembler.

        Math.pow is slightly more complicated, in that we have
        to implement exponentiation ourselves rather than relying
        on hardware support.  The inline exponentiation is restricted
        to positive integer exponents on a numeric base.  Exponentiation
        is finally performed through the "Exponentiation by Squaring"
        algorithm.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
        (JSC::MacroAssemblerARM::loadDouble):
        (JSC::MacroAssemblerARM::sqrtDouble):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
        (JSC::MacroAssemblerARMv7::sqrtDouble):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::loadDouble):
        (JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::sqrtDouble):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::loadDouble):
        (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::movsd_mr):
        (JSC::X86Assembler::sqrtsd_rr):
        (JSC::X86Assembler::X86InstructionFormatter::twoByteOp):
        (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
        * create_hash_table:
        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        * jit/JITOpcodes.cpp:
        * jit/JITStubs.h:
        (JSC::JITThunks::ctiNativeCallThunk):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitLoadDouble):
        (JSC::JSInterfaceJIT::emitJumpIfImmediateNumber):
        (JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber):
        (JSC::JSInterfaceJIT::emitLoadInt32):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::loadDoubleArgument):
        (JSC::SpecializedThunkJIT::loadInt32Argument):
        (JSC::SpecializedThunkJIT::returnJSValue):
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::finalize):
        * jit/ThunkGenerators.cpp:
        (JSC::sqrtThunkGenerator):
        (JSC::powThunkGenerator):
        * jit/ThunkGenerators.h:
        * runtime/Executable.h:
        (JSC::NativeExecutable::NativeExecutable):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Thu, 29 Apr 2010 03:46:50 +0000 (03:46 +0000)]
2010-04-28  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.

        No new tests, because pasteboard DataTransfer tests will be enabled
        with the completion of the GTK+ DataTransfer object.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing...
mitz@apple.com [Thu, 29 Apr 2010 03:11:37 +0000 (03:11 +0000)]
More of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Adele Peterson.

Assigning zero width and empty bounds to the ZERO WIDTH SPACE glyph often allocates a width map
page and a bounds map page for the glyph, each of which pages contains 255 unused entries. Save
this space by not storing the zero width and empty bounds in the metrics maps.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData): Initialize m_zeroWidthSpaceGlyph.
(WebCore::SimpleFontData::platformGlyphInit): Set m_zeroWidthSpaceGlyph. Don’t create entries
for the ZERO WIDTH SPACE glyph in the width map and in the bounds map.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::boundsForGlyph): Return empty bounds for the ZERO WIDTH SPACE glyph
without consulting the bounds map.
(WebCore::SimpleFontData::widthForGlyph): Return zero for the ZERO WIDTH SPACE glyph without
consulting the width map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page...
mrowe@apple.com [Thu, 29 Apr 2010 03:05:03 +0000 (03:05 +0000)]
<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page load

Reviewed by Adele Peterson.

The Safari welcome page runs afoul of the same-origin restriction on access to stylesheet rules
that was added to address <https://bugs.webkit.org/show_bug.cgi?id=20527>. To work around this we're
adding a temporary site-specific quirk that relaxes this restriction for the particular cross-origin
access that occurs on the Safari welcome page.

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix, not reviewed.
mthole@apple.com [Thu, 29 Apr 2010 03:00:07 +0000 (03:00 +0000)]
Build fix, not reviewed.

Fix WebKit2 build by stubbing out WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace().

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemoved the dividing line (i.e. "====...") logic from the code
cjerdonek@webkit.org [Thu, 29 Apr 2010 02:30:20 +0000 (02:30 +0000)]
Removed the dividing line (i.e. "====...") logic from the code
called by svn-apply and svn-unapply.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38093

The dividing line logic is unnecessary.  Removing it simplifies the
code and makes some subsequent changes easier.

* Scripts/VCSUtils.pm:
  - Removed the logic in gitdiff2svndiff() to convert the git
    "index" line to an SVN dividing line.
  - Adjusted the logic similarly in parseDiffHeader().

* Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
  - Updated the unit tests as necessary.

* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
  - Updated the unit tests as necessary.
  - Corrected an error in the unit tests whereby all elements
    of an array were referencing the same element rather than
    distinct elements -- causing unit test failures to be masked.

* Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
  - Updated the unit tests as necessary.
  - Made the same unit test correction as above for parseDiff.pl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 29 Apr 2010 02:22:17 +0000 (02:22 +0000)]
2010-04-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, Qt build fix.

        [Qt] Guard the body of the function instead of the function for
        exported functions.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::webInspectorExecuteScript):
        (DumpRenderTreeSupportQt::webInspectorClose):
        (DumpRenderTreeSupportQt::webInspectorShow):
        (DumpRenderTreeSupportQt::setTimelineProfilingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Unreviewed.
estade@chromium.org [Thu, 29 Apr 2010 01:50:53 +0000 (01:50 +0000)]
    Unreviewed.

        * Scripts/webkitpy/common/config/committers.py: adding myself as a committer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
mthole@apple.com [Thu, 29 Apr 2010 00:54:57 +0000 (00:54 +0000)]
JavaScriptCore: Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
exports file for it has been added.

Reviewed by Mark Rowe.

* wtf/Platform.h:

WebCore: Add separate exports file for symbols dependent on WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK.

Reviewed by Mark Rowe.

* DerivedSources.make: Updated for WebCore.ProtectionSpaceAuthCallback.exp.
* WebCore.ProtectionSpaceAuthCallback.exp: Added.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 29 Apr 2010 00:38:40 +0000 (00:38 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] revert getFontDataForCharacters change in r58341
        https://bugs.webkit.org/show_bug.cgi?id=38288

        * platform/chromium/test_expectations.txt: add the test to the now-failing list.
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] revert getFontDataForCharacters change in r58341
        https://bugs.webkit.org/show_bug.cgi?id=38288

        It caused a performance regression.

        * platform/chromium/ChromiumBridge.h:
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 00:34:25 +0000 (00:34 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58441.
        http://trac.webkit.org/changeset/58441
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Broke 3 test on Qt.

        * editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Removed.
        * editing/pasteboard/drag-drop-iframe-refresh-crash.html: Removed.
        * editing/resources/drag-drop.html: Removed.
2010-04-28  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58441.
        http://trac.webkit.org/changeset/58441
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Broke 3 test on Qt.

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::concludeEditDrag):
        * page/DragController.h:
        (WebCore::DragController::setDragInitiator):
        (WebCore::DragController::dragInitiator):
        (WebCore::DragController::documentUnderMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 29 Apr 2010 00:22:16 +0000 (00:22 +0000)]
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Remove some obsolete scrolling code
        https://bugs.webkit.org/show_bug.cgi?id=38293

        * page/Chrome.cpp:
        (WebCore::Chrome::scrollRectIntoView): Removed ScrollView* argument.
        * page/Chrome.h: Made scrollRectIntoView non-virtual, and removed ScrollView* argument.

        * page/FrameView.cpp: Removed scrollRectIntoViewRecursively.
        * page/FrameView.h: Removed scrollRectIntoViewRecursively and made
        setScrollPosition non-virtual, since there is no class derived from
        this class, and ScrollView's setScrollPosition is non-virtual.

        * platform/HostWindow.h: Removed scrollRectIntoView.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively): Updated comment
        since I was able to do most of the tasks listed here.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Removed 0 passed for
        ScrollView* argument to Chrome::scrollRectIntoView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix, not reviewed.
mthole@apple.com [Thu, 29 Apr 2010 00:14:21 +0000 (00:14 +0000)]
Build fix, not reviewed.

* wtf/Platform.h:
Disable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK until an exports file is created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.: Add WebKit2 to the lists of modules to build.
weinig@apple.com [Wed, 28 Apr 2010 23:58:33 +0000 (23:58 +0000)]
.: Add WebKit2 to the lists of modules to build.

Reviewed by Mark Rowe.

* Makefile:

WebKit2: Only build on SnowLeopard and later when using the Makefile.

Reviewed by Mark Rowe.

* Makefile:

WebKitTools: Add MiniBrowser to the lists of modules to build and only build it on
SnowLeopard and later.

Reviewed by Mark Rowe.

* Makefile:
* MiniBrowser/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd canAuthenticateAgainstProtectionSpace() to frame loader so that a protection...
mthole@apple.com [Wed, 28 Apr 2010 23:16:41 +0000 (23:16 +0000)]
Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
https://bugs.webkit.org/show_bug.cgi?id=38271

Reviewed by David Kilzer.

JavaScriptCore:

* wtf/Platform.h: Add WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK define.

WebCore:

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/ProtectionSpace.h:
(WebCore::):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
ProtectionSpaceAuthenticationSchemeClientCertificateRequested.  Guarded with the
#if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
exist prior to Mac OS X 10.6.
(WebCore::core): Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.

WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
Added.  If the resource load delegate implements the callback, use its answer.  If it does
not, then only send authentication challenges for pre-10.6 protection spaces, which matches
CFNetwork's default behavior.
* WebView/WebDelegateImplementationCaching.h:
* WebView/WebDelegateImplementationCaching.mm:
(CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
* WebView/WebResourceLoadDelegatePrivate.h:
Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
* WebView/WebView.mm:
(-[WebView _cacheResourceLoadDelegateImplementations]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Abhishek Arya <inferno@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 22:48:23 +0000 (22:48 +0000)]
2010-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
        https://bugs.webkit.org/show_bug.cgi?id=37618

        * editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
        * editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
        * editing/resources/drag-drop.html: Added.
2010-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
        Eliminated unused m_dragInitiator accessor to prevent dereferencing.
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::concludeEditDrag):
        * page/DragController.h:
        (WebCore::DragController::draggingImageURL):
        (WebCore::DragController::documentUnderMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, fixing a build problem introduced by the previous patch.
dumi@chromium.org [Wed, 28 Apr 2010 22:33:15 +0000 (22:33 +0000)]
Unreviewed, fixing a build problem introduced by the previous patch.

* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 28 Apr 2010 22:28:25 +0000 (22:28 +0000)]
2010-04-28  Adam Langley  <agl@chromium.org>

        Unreviewed, expectations update.

        These results are no longer specific to chromium-win. I believe that
        they should have been deleted in r58182, but I didn't notice the
        deletions, only the modified files.

        * platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.checksum: Removed.
        * platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
weinig@apple.com [Wed, 28 Apr 2010 22:17:48 +0000 (22:17 +0000)]
Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.

Reviewed by Mark Rowe.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/make-launchable.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding some required classes for the sync WebSQLDatabases API.
dumi@chromium.org [Wed, 28 Apr 2010 22:17:23 +0000 (22:17 +0000)]
Adding some required classes for the sync WebSQLDatabases API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Jeremy Orlow.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/DatabaseSync.cpp: Added.
(WebCore::DatabaseSync::databaseInfoTableName):
(WebCore::DatabaseSync::setIsAvailable):
(WebCore::DatabaseSync::isAvailable):
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::version):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
* storage/DatabaseSync.h: Added.
(WebCore::DatabaseSync::databaseDebugName):
* storage/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
* storage/SQLTransactionSync.h: Added.
(WebCore::SQLTransactionSync::database):
(WebCore::SQLTransactionSync::isReadOnly):
* storage/SQLTransactionSyncCallback.h: Added.
(WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 İsmail Dönmez <ismail@namtrac.org>
eric@webkit.org [Wed, 28 Apr 2010 22:05:32 +0000 (22:05 +0000)]
2010-04-28  İsmail Dönmez  <ismail@namtrac.org>

        Reviewed by Simon Hausmann.

        Fix compilation with QT_NO_CURSOR defined.

        * platform/qt/QWebPageClient.h:
        (QWebPageClient::resetCursor):
        (QWebPageClient::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 28 Apr 2010 21:53:53 +0000 (21:53 +0000)]
2010-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        fix linux expected result for fast/text/line-breaks.html
        https://bugs.webkit.org/show_bug.cgi?id=38283

        This is needed after r58426. See http://trac.webkit.org/changeset/57242
        for more details.

        * platform/chromium-linux/fast/text/line-breaks-expected.checksum:
        * platform/chromium-linux/fast/text/line-breaks-expected.png:
        * platform/chromium-linux/fast/text/line-breaks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 21:51:34 +0000 (21:51 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Audit all uses of subprocess in webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=38284

        After further discussions with Jeffrey Yasskin
        about http://bugs.python.org/issue2320
        and related issues of using subprocess from
        multiple threads, I have learned that subprocess
        is known to be non-threadsafe through recent
        Python 2.7 builds.

        I'm attempting to lessen our exposure to these
        subprocess bugs by auditing each use of subprocess
        in webkitpy.  I did not find any unsafe calls
        in my audit, but I did remove numerous unneeded
        import subprocess lines.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
        * Scripts/webkitpy/common/system/user.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Alexey Proskuryakov.
ap@apple.com [Wed, 28 Apr 2010 21:42:18 +0000 (21:42 +0000)]
    Reviewed by Alexey Proskuryakov.

        Added a check to make sure that resources from a different https origin are not cached.
        https://bugs.webkit.org/show_bug.cgi?id=33456

        Test: http/tests/appcache/different-https-origin-resource-main.html

        * loader/appcache/ManifestParser.cpp:
        (WebCore::parseManifest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 28 Apr 2010 21:23:19 +0000 (21:23 +0000)]
2010-04-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()

        Ensure that the WebView +initialize method initializes threading, so that things are correctly
        initialized when the first call into the WebKit framework is via a WebView class method.

        * WebView/WebView.mm:
        (+[WebView initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOnly set -allowable_client WebKit2 for engineering builds on SnowLeopard
weinig@apple.com [Wed, 28 Apr 2010 21:19:58 +0000 (21:19 +0000)]
Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
and later.

Reviewed by Mark Rowe.

* Configurations/WebCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 21:04:24 +0000 (21:04 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Roben.

        rebaseline for fast/text/international/bold-bengali
        https://bugs.webkit.org/show_bug.cgi?id=38281

        * platform/win/fast/text/international/bold-bengali-actual.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
darin@apple.com [Wed, 28 Apr 2010 21:02:13 +0000 (21:02 +0000)]
Don't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
for gettimeofday anyway.

Reviewed by Sam Weinig.

* wtf/CurrentTime.cpp:
(WTF::currentTime): Remove the CF version of this. Change the "other POSIX"
version to pass 0 for the time zone instead of ignoring a return value.
Also get rid of unneeded type casts, since operations involving both
integers and doubles are always evaluated as doubles in C without explicit
type casting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 28 Apr 2010 20:57:02 +0000 (20:57 +0000)]
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION: Autoscroll does not work in Mail messages
        https://bugs.webkit.org/show_bug.cgi?id=38267
        rdar://problem/7559799

        The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
        view had gotten broken in multiple ways. For some reason, a combination of bugs made it
        partly work until around r48064. This brings it back.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
        rather than the WebView itself. This logic may not be correct for the case where
        usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION: Autoscroll does not work in Mail messages
        https://bugs.webkit.org/show_bug.cgi?id=38267
        rdar://problem/7559799

        Still haven't figured out a good way to test this with DumpRenderTree
        or with Safari. Testing has to be done with Mail for now.

        The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
        view had gotten broken in multiple ways. For some reason, a combination of bugs made it
        partly work until around r48064. This brings it back.

        There were three problems:

            1) Code in EventHandler decided there was nothing to scroll, so didn't start
               the autoscroll timer.
            2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
            3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect
               coordinate conversion.

        I verified that none of these have any effect on regression tests, or behavior in
        web browsers, or behavior on platforms other than Mac.

        * page/EventHandler.cpp:
        (WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly
        and for the top level box of the top frame.
        (WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll.
        (WebCore::EventHandler::updateAutoscrollRenderer): Ditto.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToAnchor): Fixed comment.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this
        now-unused function along with some comments about removing some obsolete code.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively
        since from the WebKit point of view this is the topmost scroll view anyway. Instead call
        setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs
        to use a different rectangle anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] tst_QWebHistoryInterface::visitedLinks() fails
tonikitoo@webkit.org [Wed, 28 Apr 2010 20:50:23 +0000 (20:50 +0000)]
[Qt] tst_QWebHistoryInterface::visitedLinks() fails
https://bugs.webkit.org/show_bug.cgi?id=37323

Patch by Antonio Gomes  <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com> on 2010-04-28
Reviewed by NOBODY Simon Hausmann.

Patch fixes styleProperty method of QWebElement to make use of
CSSComputedStyleDeclaration::computedStyle 'allowVisitedStyle' parameter
and the corresponding failing QWebHistoryInterface::visitedLinks method.

* Api/qwebelement.cpp:
(QWebElement::styleProperty):
* tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:
(tst_QWebHistoryInterface::visitedLinks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 28 Apr 2010 20:50:17 +0000 (20:50 +0000)]
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
        * platform/mac/fast/repaint/stacked-diacritics-expected.png:
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::canUseGlyphCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 28 Apr 2010 20:35:17 +0000 (20:35 +0000)]
2010-04-28  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] callOnMainThread should equate to MessageLoop::PostTask
        https://bugs.webkit.org/show_bug.cgi?id=38276

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * wtf/MainThread.cpp:
        * wtf/chromium/ChromiumThreading.h:
        * wtf/chromium/MainThreadChromium.cpp:
        (WTF::initializeMainThread):
        (WTF::callOnMainThread):
        (WTF::callOnMainThreadAndWait):
        (WTF::setMainThreadCallbacksPaused):
        (WTF::isMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Kilzer.
ap@apple.com [Wed, 28 Apr 2010 20:30:16 +0000 (20:30 +0000)]
    Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=38278
        https://localhost:8443 doesn't work in WebKit tests

        We only had a VirtualHost for 127.0.0.1:8443. Changed that to *:8443.

        * http/conf/apache2-debian-httpd.conf:
        * http/conf/apache2-httpd.conf:
        * http/conf/fedora-httpd.conf:
        * http/conf/httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for <rdar://problem/7474349>
bdakin@apple.com [Wed, 28 Apr 2010 19:48:30 +0000 (19:48 +0000)]
Fix for <rdar://problem/7474349>

Reviewed by Darin Adler.

Add a synchronous display mechanism for WKCACFLayerRenderer.

WebCore:

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setRootContentsAndDisplay): This is
just like setRootContents(), but it calls paint() instead of
renderSoon().
* platform/graphics/win/WKCACFLayerRenderer.h:

WebKit/win:

* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebView.cpp:
(WebView::WebView):
(WebView::updateRootLayerContents):
(WebView::nextDisplayIsSynchronous):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-27 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 28 Apr 2010 19:42:43 +0000 (19:42 +0000)]
2010-04-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        Make WebThemeEngine::paint take a const ref of ExtraParams
        https://bugs.webkit.org/show_bug.cgi?id=38242

        * public/WebThemeEngine.h:
        (WebKit::WebThemeEngine::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
dimich@chromium.org [Wed, 28 Apr 2010 19:39:54 +0000 (19:39 +0000)]
REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=37554

Reviewed by Geoffrey Garen.

The flaky fast/workers/wrapper-map-gc.html will stop being flaky.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
check if JS execution was terminated, as in cases of Worker.terminate() or WorkerGlobalScope.close().
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::toJS): ASSERT the value of workerContextWrapper, it should never be 0.
* bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContextWrapper): remove returning 0 if JS execution was forbidden.
(WebCore::WorkerScriptController::isExecutionForbidden):
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::isExecutionForbidden):

Add ScriptExecutionContext::isJSExecutionTerminated(), it is always 'false' for Document
and 'true' for WorkerContext when script is terminated.
* dom/ScriptExecutionContext.h:
* dom/Document.h:
(WebCore::Document::isJSExecutionTerminated):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::isJSExecutionTerminated):
* workers/WorkerContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 19:24:20 +0000 (19:24 +0000)]
2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: Multiple Main Resource Content Loaded marks appear in Resource panel.
        https://bugs.webkit.org/show_bug.cgi?id=38270

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 19:15:03 +0000 (19:15 +0000)]
2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
        https://bugs.webkit.org/show_bug.cgi?id=38264

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 28 Apr 2010 18:35:37 +0000 (18:35 +0000)]
2010-04-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Failing test http/tests/misc/isindex-with-no-form.html
        https://bugs.webkit.org/show_bug.cgi?id=30815

        The test currently works, removing from Skipped.

        * platform/gtk/Skipped:

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 18:25:44 +0000 (18:25 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        fast/text/international/bold-bengali needs baselines
        https://bugs.webkit.org/show_bug.cgi?id=38273

        * platform/chromium-win/fast/text/international/bold-bengali-expected.checksum: Added.
        * platform/chromium-win/fast/text/international/bold-bengali-expected.png: Added.
        * platform/mac/fast/text/international/bold-bengali-expected.checksum: Added.
        * platform/mac/fast/text/international/bold-bengali-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 28 Apr 2010 17:54:22 +0000 (17:54 +0000)]
2010-04-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dimitri Glazkov

        Rebaseline Webkit Mac pixel results and chromium pixel results
        caused by http://trac.webkit.org/changeset/58191
        Webkit Mac pixel results failed with --tolerance=0
        https://bugs.webkit.org/show_bug.cgi?id=38104

        * platform/chromium-linux/editing/deleting/4845371-expected.checksum:
        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-linux/editing/deleting/5126166-expected.checksum:
        * platform/chromium-linux/editing/deleting/5126166-expected.png:
        * platform/chromium-linux/editing/deleting/5483370-expected.checksum:
        * platform/chromium-linux/editing/deleting/5483370-expected.png:
        * platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/4875189-2-expected.png:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
        * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
        * platform/chromium-win/editing/deleting/4845371-expected.checksum:
        * platform/chromium-win/editing/deleting/4845371-expected.png:
        * platform/chromium-win/editing/deleting/5126166-expected.checksum:
        * platform/chromium-win/editing/deleting/5126166-expected.png:
        * platform/chromium-win/editing/deleting/5483370-expected.checksum:
        * platform/chromium-win/editing/deleting/5483370-expected.png:
        * platform/chromium-win/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-win/editing/deleting/table-cells-expected.png:
        * platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-win/editing/inserting/4875189-2-expected.png:
        * platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-win/editing/pasteboard/5387578-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/editing/deleting/4845371-expected.png:
        * platform/mac/editing/deleting/5126166-expected.png:
        * platform/mac/editing/deleting/5483370-expected.png:
        * platform/mac/editing/deleting/table-cells-expected.png:
        * platform/mac/editing/inserting/4875189-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.png:
        * platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-cells-expected.png:
        * platform/mac/editing/selection/move-past-trailing-space-expected.png:
        * platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/mac/fast/repaint/caret-outside-block-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 28 Apr 2010 17:53:39 +0000 (17:53 +0000)]
2010-04-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dimitri Glazkov

        Rebaseline Webkit Mac pixel results and chromium pixel results
        caused by http://trac.webkit.org/changeset/58191
        Webkit Mac pixel results failed with --tolerance=0

        * platform/chromium-linux/editing/deleting/4845371-expected.checksum:
        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-linux/editing/deleting/5126166-expected.checksum:
        * platform/chromium-linux/editing/deleting/5126166-expected.png:
        * platform/chromium-linux/editing/deleting/5483370-expected.checksum:
        * platform/chromium-linux/editing/deleting/5483370-expected.png:
        * platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/4875189-2-expected.png:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
        * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
        * platform/chromium-win/editing/deleting/4845371-expected.checksum:
        * platform/chromium-win/editing/deleting/4845371-expected.png:
        * platform/chromium-win/editing/deleting/5126166-expected.checksum:
        * platform/chromium-win/editing/deleting/5126166-expected.png:
        * platform/chromium-win/editing/deleting/5483370-expected.checksum:
        * platform/chromium-win/editing/deleting/5483370-expected.png:
        * platform/chromium-win/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-win/editing/deleting/table-cells-expected.png:
        * platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-win/editing/inserting/4875189-2-expected.png:
        * platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-win/editing/pasteboard/5387578-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/editing/deleting/4845371-expected.png:
        * platform/mac/editing/deleting/5126166-expected.png:
        * platform/mac/editing/deleting/5483370-expected.png:
        * platform/mac/editing/deleting/table-cells-expected.png:
        * platform/mac/editing/inserting/4875189-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.png:
        * platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-cells-expected.png:
        * platform/mac/editing/selection/move-past-trailing-space-expected.png:
        * platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/mac/fast/repaint/caret-outside-block-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Andrey Kosyakov <caseq@chromium.org>
pfeldman@chromium.org [Wed, 28 Apr 2010 17:14:46 +0000 (17:14 +0000)]
2010-04-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Fixed passing breakpoints to V8.
        https://bugs.webkit.org/show_bug.cgi?id=38266

        * src/js/InspectorControllerImpl.js:
        (.devtools.InspectorBackendImpl.prototype.setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 28 Apr 2010 17:10:01 +0000 (17:10 +0000)]
2010-04-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Linkify node and function in the event listeners panel.

        https://bugs.webkit.org/show_bug.cgi?id=38251

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerBody):
        (WebCore::eventListenerHandlerLocation):
        * bindings/js/ScriptEventListener.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerBody):
        (WebCore::eventListenerHandlerLocation):
        * bindings/v8/ScriptEventListener.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
        (WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault):
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update.callback):
        (WebInspector.EventListenersSidebarPane.prototype.update):
        ():
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
        * inspector/front-end/inspector.css:
        (.node-link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIgnore a directory the Python tools creates.
darin@apple.com [Wed, 28 Apr 2010 16:56:34 +0000 (16:56 +0000)]
Ignore a directory the Python tools creates.

* Scripts/webkitpy/style: Modified property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* Scripts/extract-localizable-strings: Fix minor mistake in
darin@apple.com [Wed, 28 Apr 2010 16:44:56 +0000 (16:44 +0000)]
* Scripts/extract-localizable-strings: Fix minor mistake in
argument checking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
jchaffraix@webkit.org [Wed, 28 Apr 2010 16:29:22 +0000 (16:29 +0000)]
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
       http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

Rolling the patch in as I could not reproduce Qt results locally.

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.

* platform/mac-tiger/Skipped:
* platform/qt/Skipped:
Added those 2 tests to the Skipped lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Wed, 28 Apr 2010 14:23:22 +0000 (14:23 +0000)]
2010-04-28  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: preserves-3d and backface visibility
        https://bugs.webkit.org/show_bug.cgi?id=35312

        Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating
        the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change.

        WebKitSite/blog-files/3d-transforms test now work with Qt.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::updateTransform):
        (WebCore::GraphicsLayerQtImpl::opaqueArea):
        (WebCore::GraphicsLayerQtImpl::boundingRect):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 13:58:42 +0000 (13:58 +0000)]
2010-04-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] Rebaseline svg-background-partial-redraw, node-iterator-prototype, and upstream test expectations for fast/text/international/bold-bengali.html
        https://bugs.webkit.org/show_bug.cgi?id=38259

        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-mac/fast/images: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-mac/traversal: Added.
        * platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
        * platform/chromium-win/traversal: Added.
        * platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 13:49:08 +0000 (13:49 +0000)]
2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: View frame selector for Timeline overview panel is redesigned a bit.
        Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane.
        https://bugs.webkit.org/show_bug.cgi?id=38251

        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewPane):
        (WebInspector.TimelineOverviewPane.prototype.reset):
        (WebInspector.TimelineOverviewPane.prototype._dragWindow):
        (WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging):
        (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
        (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
        (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
        (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
        (WebInspector.TimelinePanel.WindowSelector):
        (WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement):
        (WebInspector.TimelinePanel.WindowSelector.prototype._close):
        (WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition):
        * inspector/front-end/inspector.css:
        (#timeline-overview-grid):
        (.timeline-window-selector):
        (#timeline-overview-window):
        (.timeline-overview-dividers-background):
        (.timeline-overview-window-rulers):
        (.timeline-window-resizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 28 Apr 2010 12:58:19 +0000 (12:58 +0000)]
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage viewMode property
        https://bugs.webkit.org/show_bug.cgi?id=38119

        Replacing method qt_wrt_setViewMode by wrt_viewMode property.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):
        (QWebPage::event):
        * Api/qwebpage_p.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::wrt_viewModes):
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage viewMode property
        https://bugs.webkit.org/show_bug.cgi?id=38119

        Replacing method qt_wrt_setViewMode by wrt_viewMode property.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setViewModeMediaFeature):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 11:58:45 +0000 (11:58 +0000)]
2010-04-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html
        https://bugs.webkit.org/show_bug.cgi?id=38254

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::adjustTextRenderMode):
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getOutlinePoint):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::isCoordinateSkiaSafe):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::strokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 11:49:05 +0000 (11:49 +0000)]
2010-04-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Log error message to inspector console if a resource fails to load.
        Moved console-tests.js to http tests. Added support for sorting
        console messages, in case order may vary.
        https://bugs.webkit.org/show_bug.cgi?id=37215

        * http/tests/inspector/console-resource-errors-expected.txt: Added.
        * http/tests/inspector/console-resource-errors.html: Added.
        * http/tests/inspector/console-tests.js: Added.
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):
        (dumpConsoleMessagesWithClasses.callback):
        (dumpConsoleMessagesWithClasses):
        (frontend_dumpConsoleMessages):
        * inspector/console-clear.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-tests.html:
        * inspector/console-tests.js: Removed.
        * platform/mac-tiger/http/tests/inspector: Added.
        * platform/mac-tiger/http/tests/inspector/console-resource-errors-expected.txt: Added.
2010-04-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Log error message to inspector console if a resource fails to load.
        Disable checking of mime-type consistency for failed resources.
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Test: http/tests/inspector/console-resource-errors.html

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 11:39:03 +0000 (11:39 +0000)]
2010-04-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Support pause on exceptions in v8 implementation of ScriptDebugServer.

        https://bugs.webkit.org/show_bug.cgi?id=38205

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::addListener):
        (WebCore::ScriptDebugServer::pauseOnExceptionsState):
        (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
        (WebCore::ScriptDebugServer::currentCallFrame):
        (WebCore::ScriptDebugServer::handleV8DebugMessage):
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        * bindings/v8/ScriptDebugServer.h:
2010-04-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Support pause on exceptions in v8 implementation of ScriptDebugServer.

        https://bugs.webkit.org/show_bug.cgi?id=38205

        * src/js/DebuggerScript.js:
        (debuggerScriptConstructor.DebuggerScript.getScripts):
        (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState):
        (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState):
        (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber):
        (debuggerScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 11:19:41 +0000 (11:19 +0000)]
2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Adjusted check-webkit-style so that files with file type NONE
        are automatically skipped without warning.

        https://bugs.webkit.org/show_bug.cgi?id=38197

        This change simplifies configuring which files to skip.  It also
        addresses an issue whereby check-webkit-style was unintentionally
        checking .vcproj files for carriage returns.

        * Scripts/webkitpy/style/checker.py:
          - Moved the C++, Python, and text file extensions to new
            module-level configuration variables.
          - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
            variable.
          - Changed the numeric values of the FileType enum so that
            FileType.NONE evaluates to False.
          - For ProcessorDispatcher.should_skip_without_warning():
            - Changed the method to return True for FileType.NONE files.
            - Made ChangeLog files an exception to getting skipped.
          - Changed the StyleProcessor.process() method to raise an
            exception if given a file path that should not be processed.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Updated the unit tests and added more test cases as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
jorlow@chromium.org [Wed, 28 Apr 2010 10:57:20 +0000 (10:57 +0000)]
2010-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58313.
        http://trac.webkit.org/changeset/58313
        https://bugs.webkit.org/show_bug.cgi?id=38253

        Regression evident in pixel tests: the search icon is always
        clipped at the bottom. (Requested by jorlow on #webkit).

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::controlClipRect):
        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::hasControlClip):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint):
        * rendering/RenderTextControlSingleLine.h:
2010-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58313.
        http://trac.webkit.org/changeset/58313
        https://bugs.webkit.org/show_bug.cgi?id=38253

        Regression evident in pixel tests: the search icon is always
        clipped at the bottom. (Requested by jorlow on #webkit).

        * fast/css/input-search-padding.html: Removed.
        * platform/mac/fast/css/input-search-padding-expected.checksum: Removed.
        * platform/mac/fast/css/input-search-padding-expected.png: Removed.
        * platform/mac/fast/css/input-search-padding-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemoved execute permissions from WebCore/inspector/InspectorFrontend.cpp
hausmann@webkit.org [Wed, 28 Apr 2010 10:32:46 +0000 (10:32 +0000)]
Removed execute permissions from WebCore/inspector/InspectorFrontend.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 10:29:33 +0000 (10:29 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed.  Disable printing/media-queries-print for now.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Eric Seidel <eric@webkit.org>
ukai@chromium.org [Wed, 28 Apr 2010 10:09:09 +0000 (10:09 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Jeremy Orlow.

        webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
        https://bugs.webkit.org/show_bug.cgi?id=38248

        The previous code did not check the return code of taskkill.
        When I moved that callsite from using subprocess.call to
        Executive.run_command having a non-zero return code became an error.

        In this change I've centralized our killall handling in executive,
        and added tests for it to make sure it works.

        Currently kill_process and kill_all swallow exceptions in the cases
        where the process(es) to be killed do(es) not exist.

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 09:58:03 +0000 (09:58 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed.  Added missing expectation files missed in r58386.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * platform/mac/printing/media-queries-print-expected.checksum: Added.
        * platform/mac/printing/media-queries-print-expected.png: Added.
        * platform/mac/printing/media-queries-print-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 09:44:42 +0000 (09:44 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Shinichiro Hamaji.

        wdiff_text throws ScriptError because wdiff returns non-zero when files differ
        https://bugs.webkit.org/show_bug.cgi?id=38246

        wdiff returns 0 when files are the same, 1 when they differ.
        run_command by default raises ScriptError if the return code is non-zero.
        Fixed this by adding a custom error handler which only raises if the
        return code is not 1.

        I broke up the huge wdiff_text() method into little pieces
        for easier unit testing.  There is only one functional change here
        and that is the addition of the custom error handler.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix.
ukai@chromium.org [Wed, 28 Apr 2010 09:21:59 +0000 (09:21 +0000)]
Unreviewed build fix.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest): too few arguments for format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJSC's currentThreadStackBase is not reentrant on some platforms
hausmann@webkit.org [Wed, 28 Apr 2010 09:06:20 +0000 (09:06 +0000)]
JSC's currentThreadStackBase is not reentrant on some platforms
https://bugs.webkit.org/show_bug.cgi?id=37195

Patch by Simon Hausmann  <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com> on 2010-04-28
Reviewed by Darin Adler.

This function needs to be reentrant to avoid memory corruption on platforms where
the implementation uses global variables.

This patch adds a mutex lock where necessary and makes the Symbian implementation
reentrant.

* runtime/Collector.cpp:
(JSC::currentThreadStackBaseMutex):
(JSC::currentThreadStackBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix compilation with gcc 3.4.
hausmann@webkit.org [Wed, 28 Apr 2010 08:55:07 +0000 (08:55 +0000)]
Fix compilation with gcc 3.4.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
non-default constructor in class without a constructor

* wtf/text/AtomicStringImpl.h:
(WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.
* wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] WINS DEF file freeze
hausmann@webkit.org [Wed, 28 Apr 2010 08:31:59 +0000 (08:31 +0000)]
[Qt] WINS DEF file freeze

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-28
Reviewed by Simon Hausmann <simon.hausmann@nokia.com>

Updated WINSCW def file with added and removed symbols.

* symbian/bwins/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix detection of Qt 4.7's multimedia libraries
hausmann@webkit.org [Wed, 28 Apr 2010 08:29:03 +0000 (08:29 +0000)]
[Qt] Fix detection of Qt 4.7's multimedia libraries

Patch by Justin McPherson <justin.mcpherson@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

QtMultimedia has been split into an additional media services library, which
we're using. mediaservices depends on multimedia.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 07:49:12 +0000 (07:49 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed attempt to fix the chromium build.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-28 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Apr 2010 07:47:12 +0000 (07:47 +0000)]
2010-04-28  Daniel Bates  <dbates@rim.com>

        Unreviewed, rebase expected result of failing test.

        Rebasing Qt expected result for selection-gap-overflow-scroll-2.html.
        Following the landing of bug #37686, this test started failing despite
        being unrelated to this bug. From looking at the diff of the result,
        which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's
        comment, we have decided to rebase this result.

        * platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebView drawing code may access null backing store dirty region
sfalken@apple.com [Wed, 28 Apr 2010 07:33:09 +0000 (07:33 +0000)]
WebView drawing code may access null backing store dirty region
https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)

Reviewed by Maciej Stachowiak.

* WebView.cpp:
(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 07:30:16 +0000 (07:30 +0000)]
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Now we can test media queries with the new function because the
        render tree has the color information of the box.

        Note that the pixel test is currently failing. We'll need another
        patch to enable printing mode for pixel tests.

        * platform/mac/Skipped:
        * platform/mac/printing/media-queries-print-expected.checksum: Added.
        * platform/mac/printing/media-queries-print-expected.png: Added.
        * platform/mac/printing/media-queries-print-expected.txt: Added.
        * printing/media-queries-print.html:
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Added RenderAsTextPrintingMode as a behavior of externalRepresentation.

        Now ~PrintContext() calls end() automatically.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::~PrintContext):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation):
        * rendering/RenderTreeAsText.h:
        (WebCore::):
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setPrintingCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::isPrinting):
        (LayoutTestController::setIsPrinting):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 07:09:09 +0000 (07:09 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 4)
        Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
        https://bugs.webkit.org/show_bug.cgi?id=35853

        * printing/page-rule-css-text-expected.txt:
        * printing/page-rule-css-text.html:
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 4)
        Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
        https://bugs.webkit.org/show_bug.cgi?id=35853

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parsePage):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58385 268f45cc-cd09-0410-ab3c-d52691b4dbfc