WebKit-https.git
12 years ago2009-03-12 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Thu, 12 Mar 2009 22:47:32 +0000 (22:47 +0000)]
2009-03-12  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24563
        Change ResourceRequest to be a struct rather then a class to match other declarations.

        * platform/network/chromium/ResourceRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Mark.
andersca@apple.com [Thu, 12 Mar 2009 22:15:21 +0000 (22:15 +0000)]
Add Mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 12 Mar 2009 22:13:39 +0000 (22:13 +0000)]
2009-03-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mike Thole.

        Fix <rdar://problem/6624105>.

        Make sure to process incoming messages for the NSEventTrackingRunLoopMode as well.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Aaron Boodman <aa@chromium.org>
levin@chromium.org [Thu, 12 Mar 2009 22:05:33 +0000 (22:05 +0000)]
2009-03-12  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        Bug 16348: @font-face does not affect the default style
        <https://bugs.webkit.org/show_bug.cgi?id=16348>

        * fast/css/font-face-default-font.html:
        Handle the default font being either 'Times' or 'Times New Roman'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 12 Mar 2009 22:05:25 +0000 (22:05 +0000)]
2009-03-12  David Levin  <levin@chromium.org>

        Reviewed by  Darin Fisher.

        Bug 24530: width100percent-searchfield.html should be fixed for chromium.
        <https://bugs.webkit.org/show_bug.cgi?id=24530>

        Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html

        * css/themeChromiumWin.css: Added.
        Overrides the changes to start supporting input[type="search"] on Windows (since
        Chromium doesn't do anything special for this).

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::supportsFocus):
        (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
        (WebCore::RenderThemeChromiumWin::determineState):
        (WebCore::RenderThemeChromiumWin::getThemeData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 12 Mar 2009 22:01:49 +0000 (22:01 +0000)]
2009-03-12  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add a test to check that an invalid second argument of
        window.postMessage is ignored. Note that this is probably not the
        correct behavior according to the HTML5 spec, so this test will
        need to be changed once we support that.

        https://bugs.webkit.org/show_bug.cgi?id=24523

        * fast/dom/Window/window-postmessage-args-expected.txt: Added.
        * fast/dom/Window/window-postmessage-args.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Thu, 12 Mar 2009 21:21:21 +0000 (21:21 +0000)]
2009-03-12  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=24506
        Geolocation in Safari differs from the spec, no Coordinates attribute on Position

        Get up to date.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::createPositionOptions):
        * page/Coordinates.cpp: Added.
        (WebCore::Coordinates::toString):
        * page/Coordinates.h: Added.
        (WebCore::Coordinates::create):
        (WebCore::Coordinates::latitude):
        (WebCore::Coordinates::longitude):
        (WebCore::Coordinates::altitude):
        (WebCore::Coordinates::accuracy):
        (WebCore::Coordinates::altitudeAccuracy):
        (WebCore::Coordinates::heading):
        (WebCore::Coordinates::speed):
        (WebCore::Coordinates::Coordinates):
        * page/Coordinates.idl: Added.
        * page/Geoposition.cpp:
        (WebCore::Geoposition::toString):
        * page/Geoposition.h:
        (WebCore::Geoposition::create):
        (WebCore::Geoposition::coords):
        (WebCore::Geoposition::Geoposition):
        * page/Geoposition.idl:
        * page/PositionOptions.h:
        (WebCore::PositionOptions::create):
        (WebCore::PositionOptions::maximumAge):
        (WebCore::PositionOptions::setMaximumAge):
        (WebCore::PositionOptions::PositionOptions):
        * platform/mac/GeolocationServiceMac.mm:
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 12 Mar 2009 21:10:54 +0000 (21:10 +0000)]
2009-03-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24496
        Fix console logging of non-string values by coercing the argument to
        a string, for V8 bindings.

        Test: fast/js/console-non-string-values.html

        * bindings/v8/ScriptValue.cpp: Added toString method.
        (WebCore::ScriptValue::toString):
        * bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes
            and toString declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 12 Mar 2009 21:08:51 +0000 (21:08 +0000)]
2009-03-12  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Eliminate ChromiumBridge::uiResourceProtocol
        https://bugs.webkit.org/show_bug.cgi?id=24558

        * platform/chromium/ChromiumBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Thu, 12 Mar 2009 20:44:12 +0000 (20:44 +0000)]
2009-03-12  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        Missing breaks in switch statement
        https://bugs.webkit.org/show_bug.cgi?id=24556

        * platform/mac/GeolocationServiceMac.mm:
        (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 12 Mar 2009 20:39:01 +0000 (20:39 +0000)]
2009-03-12  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24554
        Remove some unused functions from ChromiumBridge.

        * platform/chromium/ChromiumBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Fisher and Justin Garcia.
eric@webkit.org [Thu, 12 Mar 2009 20:29:30 +0000 (20:29 +0000)]
    Reviewed by Darin Fisher and Justin Garcia.

        Safari crashes during drag and drop in Google presentations
        due to mutation event handlers removing DOM content during insertNode
        https://bugs.webkit.org/show_bug.cgi?id=22634

        Added a bunch of "null" checks to make sure nodes are still
        in the document before we operate on them.  This is an
        inelegant solution, but it's the best we have for now.

        Test: editing/selection/crash-on-drag-with-mutation-events.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Mar 2009 20:11:55 +0000 (20:11 +0000)]
2009-03-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=24508

        Fix updating of text field with placeholder text when value is set
        by ensuring that updatePlaceholderVisibility() is called after
        the value has been updated, not before.

        Test: fast/forms/placeholder-set-value.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 12 Mar 2009 19:52:54 +0000 (19:52 +0000)]
2009-03-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=24525
        REGRESSION: Inspector window doesn't close when inspected page is
        destroyed. This is a revert of r41158, which became unnecessary when
        InspectorController became ref-counted in r41462.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage
            after calling close().
        (WebCore::InspectorController::stopUserInitiatedProfiling): Remove
            m_inspectedPage check guard around profile logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
pkasting@chromium.org [Thu, 12 Mar 2009 19:41:38 +0000 (19:41 +0000)]
WebCore:

2009-03-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24502
        Make horizontal scrolling on Windows always go the correct direction.

        * platform/PlatformWheelEvent.h:
        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/win:

2009-03-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24502
        Make horizontal scrolling on Windows always go the correct direction.

        * WebView.cpp:
        (WebView::mouseWheel):
        (WebViewWndProc):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 12 Mar 2009 19:36:15 +0000 (19:36 +0000)]
2009-03-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        WebKit side of <rdar://problem/6607801>

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):
        Pass a requestID to _WKPCDestroyPluginInstance and wait until we get a reply back.

        * Plugins/Hosted/WebKitPluginHost.defs:
        Add requestID parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Thu, 12 Mar 2009 19:34:02 +0000 (19:34 +0000)]
WebCore:

2009-03-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24496
        Fix console logging of non-string values by coercing the argument to
        a string.

        Test: fast/js/console-non-string-values.html

        * bindings/js/ScriptValue.cpp: Removed PlatformString include.
        * bindings/js/ScriptValue.h: Added toString method.
        (WebCore::ScriptValue::toString):
        * page/Console.cpp:
        (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use
            ScriptValue::toString.
        (WebCore::Console::addMessage): added extra ScriptState argument to callsite.
        (WebCore::Console::count): Ditto.

LayoutTests:

2009-03-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24496
        Test for logging non-string values.

        * fast/js/console-non-string-values-expected.txt: Added.
        * fast/js/console-non-string-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 19:32:25 +0000 (19:32 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey  Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24553
        [GTK] Improvements to WebKitDownload

        Rename 'state' to 'status' to match the naming in the frame
        loader rework that we plan to land soonish, and make it a
        property, for the same reason.

        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::):
        (_WebKitDownloadPrivate::webkit_download_finalize):
        (_WebKitDownloadPrivate::webkit_download_get_property):
        (_WebKitDownloadPrivate::webkit_download_set_property):
        (_WebKitDownloadPrivate::webkit_download_class_init):
        (_WebKitDownloadPrivate::webkit_download_init):
        (_WebKitDownloadPrivate::webkit_download_start):
        (_WebKitDownloadPrivate::webkit_download_cancel):
        (_WebKitDownloadPrivate::webkit_download_set_destination_uri):
        (_WebKitDownloadPrivate::webkit_download_get_status):
        (_WebKitDownloadPrivate::webkit_download_set_status):
        (_WebKitDownloadPrivate::webkit_download_received_data):
        (_WebKitDownloadPrivate::webkit_download_finished_loading):
        (_WebKitDownloadPrivate::webkit_download_error):
        * webkit/webkitdownload.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 19:32:06 +0000 (19:32 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey  Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24553
        [GTK] Improvements to WebKitDownload

        Improved documentation for the download-requested signal, to make
        its usage clear.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Mar 2009 19:27:41 +0000 (19:27 +0000)]
2009-03-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24552

        Hit testing involving normal flow, self-painting layers (e.g. reflections)
        was broken because it was not null-testing the result of hitTestLayer(),
        so bailing early with a nil hit layer.

        Test: fast/layers/normal-flow-hit-test.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 12 Mar 2009 18:33:07 +0000 (18:33 +0000)]
2009-03-12  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add test cases to make sure window.location and window.navigator
        have higher lookup precedence than a DOM element with that ID.

        https://bugs.webkit.org/show_bug.cgi?id=24522

        * fast/dom/Window/window-special-properties-expected.txt:
        * fast/dom/Window/window-special-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Thu, 12 Mar 2009 18:30:11 +0000 (18:30 +0000)]
    Reviewed by Anders Carlsson.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _unloadWithShutdown:]): Simply a small SUPPORT_CFM code block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Thu, 12 Mar 2009 18:20:07 +0000 (18:20 +0000)]
    Reviewed by Anders Carlsson.

        Fixed: <rdar://problem/5815862> Opening a subclassed NSWindow from a Safari plugin causes Safari to crash on Quit

        This fix addresses crashes in both Silverlight and ChemDraw.  This type of crash would occur because AppKit still
        had a reference to open windows that the plugin created (which no longer exist).

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _unloadWithShutdown:]): Do not unload the plug-in bundle on browser shutdown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 12 Mar 2009 18:08:08 +0000 (18:08 +0000)]
2009-03-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Cameron Zwarich.

        Removed zero-sized files, left over from improperly applied patch.

        * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
        * platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Thu, 12 Mar 2009 18:04:05 +0000 (18:04 +0000)]
2009-03-12  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by NOBODY (Build fix).

        Include string.h for strlen usage.

        * wtf/Threading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 12 Mar 2009 17:24:55 +0000 (17:24 +0000)]
2009-03-12  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Add a test to make sure GC doesn't drop XHR wrappers too soon.
        https://bugs.webkit.org/show_bug.cgi?id=24528

        * fast/dom/xmlhttprequest-gc-expected.txt: Added.
        * fast/dom/xmlhttprequest-gc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Thu, 12 Mar 2009 16:35:29 +0000 (16:35 +0000)]
2009-03-12  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        Do not ignore alpha color in optimization.  Hard to believe, but there
        are websites that fill the entire page with a tiled image consisting of
        nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Implement DOMHTMLDocument::title
aroben@apple.com [Thu, 12 Mar 2009 16:22:30 +0000 (16:22 +0000)]
    Implement DOMHTMLDocument::title

        Reviewed by Dan Bernstein.

        * DOMHTMLClasses.cpp:
        (DOMHTMLDocument::title): Call through to WebCore::Document (with
        obligatory COM error checking/type conversions).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed ChangeLog date.
ddkilzer@apple.com [Thu, 12 Mar 2009 15:28:04 +0000 (15:28 +0000)]
Fixed ChangeLog date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add NO_RETURN attribute to runInteractive() when not using readline
ddkilzer@apple.com [Thu, 12 Mar 2009 15:26:20 +0000 (15:26 +0000)]
    Add NO_RETURN attribute to runInteractive() when not using readline

        Reviewed by Darin Adler.

        * jsc.cpp:
        (runInteractive): If the readline library is not used, this method
        will never return, thus the NO_RETURN attribute is needed to prevent
        a gcc warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adopt setThreadNameInternal on Windows
aroben@apple.com [Thu, 12 Mar 2009 15:01:46 +0000 (15:01 +0000)]
    Adopt setThreadNameInternal on Windows

        Also changed a Windows-only assertion about thread name length to an
        all-platform log message.

        Reviewed by Adam Treat.

        * wtf/Threading.cpp:
        (WTF::createThread): Warn if the thread name is longer than 31
        characters, as Visual Studio will truncate names longer than that
        length.

        * wtf/ThreadingWin.cpp:
        (WTF::setThreadNameInternal): Renamed from setThreadName and changed
        to always operate on the current thread.
        (WTF::initializeThreading): Changed to use setThreadNameInternal.
        (WTF::createThreadInternal): Removed call to setThreadName. This is
        now handled by threadEntryPoint and setThreadNameInternal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 15:00:25 +0000 (15:00 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=24541
        Scrolling with home and end keys not always works

        Also make page up and page down keys be handled by the webview key
        event code, so that they also work in cases where the GTK+
        scrollbars don't handle them directly, like in the bugzill's patch
        review page.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 15:00:11 +0000 (15:00 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=24541
        Scrolling with home and end keys not always works

        Make home and end keys behave more consistently for scrolling the
        view.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 24378: resolve-ChangeLogs should use git status or svn status to find...
ddkilzer@apple.com [Thu, 12 Mar 2009 14:46:05 +0000 (14:46 +0000)]
    Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs

        <https://bugs.webkit.org/show_bug.cgi?id=24378>

        Reviewed by Adam Roben.

        * Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
        and no file or directory names are specified on the command-line
        then try to find unmerged ChangeLog files based on 'svn stat' or
        'git diff'.  Added global $isGit and $isSVN variables so that
        isGit() and isSVN() only have to be called once.
        (findUnmergedChangeLogs): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 13:18:42 +0000 (13:18 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=24254
        [GTK] spacebar doesn't scroll down

        Make spacebar and shift+spacebar scroll like page up and down
        respectively would.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 12 Mar 2009 12:42:09 +0000 (12:42 +0000)]
2009-03-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 24110: cloneNode should call cloneElement and not the reverse

        - Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren.
          Now cloneNode calls one of the 2 previous methods.

        - Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.

        - Moved cloneNode to the Element private section so that WebCore callers cannot use it.

        - Removed Element::cloneNode usage through WebCore.

        * dom/Element.cpp:
        (WebCore::Element::cloneNode): Moved to Element's private section and it
        now calls the two next methods.
        (WebCore::Element::cloneElementWithChildren): Added.
        (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement
        to avoid ambiguity.
        * dom/Element.h:

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement
        to call to cloneElementWithoutChildren.
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply): Ditto.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Ditto.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::doApply): Ditto.
        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Ditto.
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildShadowTree): Ditto.
        (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 12 Mar 2009 11:08:22 +0000 (11:08 +0000)]
2009-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        Fixed a crash on the 1x1 pixel check for background image in gtk.
        We need to load the image first and need to be sure that the image
        is not null before checking the type.

        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 12 Mar 2009 08:46:07 +0000 (08:46 +0000)]
2009-03-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24544
        Rename setUrl to setURL

        Use proper case for setUrl method, rename it to setURL.

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        * platform/network/ResourceResponseBase.h:
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::writeCallback):
        (WebCore::headerCallback):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 12 Mar 2009 07:58:03 +0000 (07:58 +0000)]
2009-03-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24519
        [GTK] Use two argument KURL ctor in ResourceHandleSoup

        Use two argument KURL ctor, the single argument ctor expects its
        input to be the output of a previous KURL::parse call, which is
        not the case here.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 12 Mar 2009 07:41:33 +0000 (07:41 +0000)]
2009-03-11  Jon Honeycutt  <jhoneycutt@apple.com>

        Fix for <rdar://6418681>
        https://bugs.webkit.org/show_bug.cgi?id=22644

        Reviewed by Steve Falkenburg.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA
        Client plug-in to the blacklist; it requires a Mozilla-based browser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix
oliver@apple.com [Thu, 12 Mar 2009 07:26:43 +0000 (07:26 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4
oliver@apple.com [Thu, 12 Mar 2009 06:39:38 +0000 (06:39 +0000)]
<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4

Reviewed by Adele Peterson.

A number of dashboard widgets rely on canvas failing silently when given invalid
colors for gradient stops, but both the spec and firefox throw exceptions here.
So we work around this by creating a dashboard quirk that will only suppress the
exception in dashboard compatibility mode.

Test: fast/canvas/canvas-gradient-addStop-error.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove duplicate header include
ddkilzer@apple.com [Thu, 12 Mar 2009 06:02:10 +0000 (06:02 +0000)]
    Remove duplicate header include

        Rubber-stamped by Mark Rowe.

        * WebView/WebView.mm: Remove duplicate #include <runtime/InitializeThreading.h>.
        Also realphabetized lowercase #include statements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Clarify comments regarding order of FEATURE_DEFINES
ddkilzer@apple.com [Thu, 12 Mar 2009 05:14:55 +0000 (05:14 +0000)]
    Clarify comments regarding order of FEATURE_DEFINES

        Rubber-stamped by Mark Rowe.

JavaScriptCore:

        * Configurations/JavaScriptCore.xcconfig: Added warning about
        the consequences when FEATURE_DEFINES are not kept in sync.

WebCore:

        * Configurations/WebCore.xcconfig: Added warning about the
        consequences when FEATURE_DEFINES are not kept in sync.

WebKit/mac:

        * Configurations/WebKit.xcconfig: Added warning about the
        consequences when FEATURE_DEFINES are not kept in sync.

WebKitTools:

        * Scripts/build-webkit: Added warning about keeping
        FEATURE_DEFINES in order and the consequences when they are not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 04:27:42 +0000 (04:27 +0000)]
2009-03-11  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24515
        [GTK] soup backend should use GMappedFile instead of mmap directly

        Rewrite mmap code used to upload files to use GMappedFile, so that
        it is platform-independent.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Thu, 12 Mar 2009 04:06:24 +0000 (04:06 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
mitz@apple.com [Thu, 12 Mar 2009 03:39:14 +0000 (03:39 +0000)]
JavaScriptCore:

        Reviewed by Darin Adler.

        - WTF support for fixing <rdar://problem/3919124> Thai text selection
          in Safari is incorrect

        * wtf/unicode/icu/UnicodeIcu.h:
        (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns
        whether the character has Unicode line breaking property value SA
        ("Complex Context").
        * wtf/unicode/qt4/UnicodeQt4.h:
        (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an
        implementation that always returns false.

WebCore:

        Reviewed by Darin Adler.

        - WebCore part of fixing <rdar://problem/3919124> Thai text selection
          in Safari is incorrect

        Test: platform/mac/editing/selection/word-thai.html

        Tested on Mac, but should work on all ICU platforms (or more precisely
        on all platforms that implement
        WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).

        * editing/TextIterator.cpp:
        (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
        Added.
        (WebCore::BackwardsCharacterIterator::range): Added.
        (WebCore::BackwardsCharacterIterator::advance): Added.

        * editing/TextIterator.h: Added BackwardsCharacterIterator with the
        minimal functionality required for this patch.
        (WebCore::BackwardsCharacterIterator::atEnd): Added.

        * editing/visible_units.cpp:
        (WebCore::firstNonComplexContextLineBreak): Added this helper function
        that returns the index of the first character in the string whose
        Unicode line breaking property value is not SA ("Complex Context"), or
        the length of the string if there is no such character.
        (WebCore::lastNonComplexContextLineBreak): Added this helper function
        that returns the index of the last character in the string whose
        Unicode line breaking property value is not SA ("Complex Context"), or
        -1 if there is no such character.
        (WebCore::previousBoundary): Changed the signature of the search
        function to include an offset parameter. Renamed the 'exception' local
        variable to 'ec' and changed its type to ExceptionCode. Extend the
        string forwards until the first character with Unicode line breaking
        property value other than SA. This gives the boundary search function
        enough context in the forward direction. Changed to use a
        BackwardsCharacterIterator for translating the backwards offset into
        a position.
        (WebCore::nextBoundary): Changed the signature of the search
        function to include an offset parameter. Extend the string backwards
        until the first character with Unicode line breaking property value
        other than SA. This gives the boundary search function enough context in
        the backwards direction. Restricted the workaround for <rdar://5192593>
        only to the line break case, because it was causing an extra character
        to be selected following a word that ended with a combining mark.
        (WebCore::startWordBoundary): Added an offset parameter. Check that
        going backwards from the given offset, there is a character with Unicode
        line breaking property value other than SA, and otherwise return 0 to
        request more context.
        (WebCore::endWordBoundary): Similar, but in reverse.
        (WebCore::previousWordPositionBoundary): Similar.
        (WebCore::nextWordPositionBoundary): Similar.
        (WebCore::startSentenceBoundary): Updated for the new search function
        signature.
        (WebCore::endSentenceBoundary): Ditto.
        (WebCore::previousSentencePositionBoundary): Ditto.
        (WebCore::nextSentencePositionBoundary): Ditto.

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/3919124> Thai text selection in Safari is
          incorrect

        * platform/mac/editing/selection/word-thai-expected.txt: Added.
        * platform/mac/editing/selection/word-thai.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 12 Mar 2009 01:29:07 +0000 (01:29 +0000)]
2009-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Don't use "::" in thread names because it is ugly!

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make
        it clear this is a WebCore-created thread.
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 12 Mar 2009 01:26:55 +0000 (01:26 +0000)]
2009-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Give threads names on platforms with pthread_setname_np.

        * wtf/Threading.cpp:
        (WTF::NewThreadContext::NewThreadContext): Initialize thread name.
        (WTF::threadEntryPoint): Call setThreadNameInternal.
        (WTF::createThread): Pass thread name.

        * wtf/Threading.h: Added new comments, setThreadNameInternal.

        * wtf/ThreadingGtk.cpp:
        (WTF::setThreadNameInternal): Added. Empty.
        * wtf/ThreadingNone.cpp:
        (WTF::setThreadNameInternal): Added. Empty.
        * wtf/ThreadingPthreads.cpp:
        (WTF::setThreadNameInternal): Call pthread_setname_np when available.
        * wtf/ThreadingQt.cpp:
        (WTF::setThreadNameInternal): Added. Empty.
        * wtf/ThreadingWin.cpp:
        (WTF::setThreadNameInternal): Added. Empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly...
mrowe@apple.com [Thu, 12 Mar 2009 00:53:21 +0000 (00:53 +0000)]
<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex

Rubber-stamped by Darin Adler.

* platform/mac/PlatformScreenMac.mm:
(WebCore::screenIsMonochrome): Return false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Mar 2009 00:51:45 +0000 (00:51 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24531

        Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
        returns a null style if it has a valid renderer, which could happen if a
        CompositeAnimation existed, but wasn't running any animations or transitions.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Wed, 11 Mar 2009 23:25:32 +0000 (23:25 +0000)]
WebCore:

2009-03-11  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
        top value on position:relative child not calculated correctly if
        parent has percentage height
        - and corresponding -
        <rdar://problem/6172925>

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests:

2009-03-11  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Test for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
        top value on position:relative child not calculated correctly if
        parent has percentage height
        - and corresponding -
        <rdar://problem/6172925>

        * fast/css/percent-top-value-with-relative-position.html: Added.
        * platform/mac/fast/css/percent-top-value-with-relative-position-expected.checksum: Added.
        * platform/mac/fast/css/percent-top-value-with-relative-position-expected.png: Added.
        * platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Jian Li <jianli@chromium.org>
levin@chromium.org [Wed, 11 Mar 2009 21:54:23 +0000 (21:54 +0000)]
2009-03-11  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement ScriptValue::hasNoValue for V8.
        https://bugs.webkit.org/show_bug.cgi?id=24507

        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::hasNoValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 11 Mar 2009 21:54:17 +0000 (21:54 +0000)]
2009-03-11  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 24459: Add v8 bindings for event.
        <https://bugs.webkit.org/show_bug.cgi?id=24459>

        Adding custom event bindings.

        * bindings/v8/custom/V8AbstractEventListener.cpp: Added.
        * bindings/v8/custom/V8AbstractEventListener.h: Added.
        * bindings/v8/custom/V8AttrCustom.cpp:
        Fixed messed up copyright header.
        * bindings/v8/custom/V8CustomEventListener.cpp: Added.
        * bindings/v8/custom/V8CustomEventListener.h:
        Replaced forwarding header with the real implementation.
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8LazyEventListener.cpp: Added.
        * bindings/v8/custom/V8LazyEventListener.h: Added.
        * bindings/v8/custom/V8ObjectEventListener.cpp: Added.
        * bindings/v8/custom/V8ObjectEventListener.h: Added.
        * bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
        * bindings/v8/custom/V8WorkerContextEventListener.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 11 Mar 2009 21:40:49 +0000 (21:40 +0000)]
2009-03-11  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24521
        Add some missing includes for the non-JSC build.

        * platform/text/PlatformString.h: added OwnPtr.h
        * xml/XMLHttpRequest.cpp: added SecurityOrigin.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Pamela Greene <pam@chromium.org>
pam@chromium.org [Wed, 11 Mar 2009 21:17:03 +0000 (21:17 +0000)]
2009-03-11  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add test for potential crash in window.frames.length
        These files were accidentally left out of r41459.

        https://bugs.webkit.org/show_bug.cgi?id=24339

        * fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
        * fast/dom/Window/window-collection-length-no-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 11 Mar 2009 20:58:54 +0000 (20:58 +0000)]
2009-03-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6656147>.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Pass the requestID to _WKPHInstantiatePlugin.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        Pass the requestID to setCurrentReply.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
        Store the reply in a map with the requestID as the key.

        (WebKit::NetscapePluginInstanceProxy::waitForReply):
        Wait for a reply that matches the given requestID.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Initialize member variables.

        (WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
        Delete all requests.

        (WebKit::NetscapePluginInstanceProxy::print):
        Pass the requestID to _WKPHPluginInstancePrint.

        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        Rename m_currentRequestID to m_currentURLRequestID.

        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        Process requests until we find a reply with the right requestID.

        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Pass a requestID to the _WKPH function.

        (WebKit::NetscapePluginInstanceProxy::nextRequestID):
        Ditto.

        * Plugins/Hosted/ProxyInstance.mm:
        Pass a requestID to the _WKPH functions.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add requestID parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 20:41:29 +0000 (20:41 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Fix Scons build. Patch from Alexander Guy.

        * WebCore.scons:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Export functions needed by ThreadSpecific from WebKit
aroben@apple.com [Wed, 11 Mar 2009 20:39:34 +0000 (20:39 +0000)]
    Export functions needed by ThreadSpecific from WebKit

        Reviewed by John Sullivan.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        Export WTF::tlsKeyCount and WTF::tlsKeys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Change the Windows implementation of ThreadSpecific to use functions instead...
aroben@apple.com [Wed, 11 Mar 2009 20:39:21 +0000 (20:39 +0000)]
    Change the Windows implementation of ThreadSpecific to use functions instead of extern globals

        This will make it easier to export ThreadSpecific from WebKit.

        Reviewed by John Sullivan.

        * API/JSBase.cpp:
        (JSEvaluateScript):
        Touched this file to force ThreadSpecific.h to be copied into
        $WebKitOutputDir.

        * wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount()
        and g_tls_keys with tlsKeys().

        (WTF::::ThreadSpecific):
        (WTF::::~ThreadSpecific):
        (WTF::::get):
        (WTF::::set):
        (WTF::::destroy):
        Updated to use the new functions.

        * wtf/ThreadSpecificWin.cpp:
        (WTF::tlsKeyCount):
        (WTF::tlsKeys):
        Added.

        (WTF::ThreadSpecificThreadExit): Changed to use the new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 19:45:18 +0000 (19:45 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24366

        Make this test more reliable by only calling runAnimationTest() once
        the animation starts, not before some setTimeout().

        * animations/change-keyframes-name-expected.txt:
        * animations/change-keyframes-name.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 11 Mar 2009 19:09:14 +0000 (19:09 +0000)]
2009-03-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6620064>.

        * Plugins/WebPluginContainerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 19:04:31 +0000 (19:04 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24266

        Land new expected results for transform-absolute-in-positioned-container.html,
        and new pixel results for reflection-masks.html. Both are progressions.

        * platform/mac/fast/reflections/reflection-masks-expected.checksum:
        * platform/mac/fast/reflections/reflection-masks-expected.png:
        * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
        * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
        * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 19:00:13 +0000 (19:00 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23093

        When the cancel button in the search field is shown or hidden,
        we need to explicitly setStyle() on the cancel button's renderer,
        to ensure that repaint happens. Changing the style without telling
        the renderer won't work.

        Test: fast/repaint/search-field-cancel.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
        (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
        (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Marc-André Decoste <mad@chromium.org>
pam@chromium.org [Wed, 11 Mar 2009 17:58:06 +0000 (17:58 +0000)]
2009-03-11  Marc-AndrĂ© Decoste  <mad@chromium.org>

        Reviewed by Eric Seidel.

        Fixed the positions of the list boxes so that the size of their
        rendering doesn't affect the test coordinates.
        https://bugs.webkit.org/show_bug.cgi?id=24006

        * fast/forms/option-mouseevents-expected.txt:
        * fast/forms/option-mouseevents.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Hironori Bono <hbono@chromium.org>
ap@webkit.org [Wed, 11 Mar 2009 16:05:04 +0000 (16:05 +0000)]
2009-03-11  Hironori Bono  <hbono@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=15790
        Ligatures aren't accounted for when manipulating VisiblePositions

        Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
        Indic ligature which uses a virama sign.

        Test: editing/deleting/skip-virama-001.html

        * platform/text/TextBreakIteratorICU.cpp:
        (WebCore::cursorMovementIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by George Staikos.
ap@webkit.org [Wed, 11 Mar 2009 15:46:38 +0000 (15:46 +0000)]
    Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24513
        REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)

        Fixes existing tests on Tiger.

        * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
        Use characterBreakIterator on Tiger (like we used to do).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 11 Mar 2009 14:53:11 +0000 (14:53 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Only run code in dispose once per instance.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 11 Mar 2009 14:53:01 +0000 (14:53 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Call deref() on our internal HistoryItem on dispose, as we always
        acquire it with a releaseRef() call to a PassRefPtr, which passes
        ownership.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 11 Mar 2009 14:52:49 +0000 (14:52 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        return foo? foo : NULL == return foo

        * webkit/webkitwebhistoryitem.cpp:
        (WebKit::core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 12:27:42 +0000 (12:27 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Enable http/tests/security/cross-frame-access-private-browsing.html test.

        * platform/gtk/Skipped:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Add private browsing option "enable-private-browsing" to WebKitWebSettings.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Also reset WebSettings to its default state for JavaScript
        profiling, Developer Extras and Private Browsing before running
        the test (can be after each test but we want to be consistent with
        other ports in this regard)

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        (runTest):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setPrivateBrowsingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 12:06:06 +0000 (12:06 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK] BackForward history leak?
        https://bugs.webkit.org/show_bug.cgi?id=19528

        Don't ref the history items when returning the back/forward list
        Added test_webkit_web_history_item_lifetime test case for this.

        * tests/main.c:
        (test_webkit_web_history_item_lifetime):
        (test_webkit_web_back_forward_list_order): Style fix.
        (test_webkit_web_back_forward_list_add_item): Style fix.
        (main):
        * webkit/webkitwebbackforwardlist.cpp:
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Wed, 11 Mar 2009 11:58:20 +0000 (11:58 +0000)]
    Reviewed by Oliver Hunt.

        <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name
        in instancesRespondToSelector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 11:57:43 +0000 (11:57 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] Fix make clean targets
        https://bugs.webkit.org/show_bug.cgi?id=24450

        Fix 'make' clean targets. We shouldn't be removing DerivedSources
        if it's only clean. Only remove it if it's distclean or
        maintainer-clean. Also remove build-related auxillary files on
        dist/maintainer clean.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 11:52:44 +0000 (11:52 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther

        [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
        https://bugs.webkit.org/show_bug.cgi?id=2260

        pangoft2 is also used in directfb builds so use it for all targets

        * configure.ac:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther

        [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
        https://bugs.webkit.org/show_bug.cgi?id=2260

        Add missing stdio.h include to get the build going

        * plugins/gtk/PluginPackageGtk.cpp:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
        https://bugs.webkit.org/show_bug.cgi?id=2260

        Add plugin support only for X11 builds

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (setDefaultsToConsistentStateValuesForTesting):
        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Wed, 11 Mar 2009 06:46:05 +0000 (06:46 +0000)]
2009-03-10  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Ken Kocienda.

        * dom/Range.cpp:
        (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects
        would include rects for the divs contents.  Set the correct RenderObject to stop at.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 11 Mar 2009 06:28:33 +0000 (06:28 +0000)]
    Reviewed by Sam Weinig.

        <rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR

WebCore:
        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect
        comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and
        there are security concerns with exposing them for cross-origin requests, so it's not clear
        if we want to change anything here.

LayoutTests:
        * http/tests/security/cookies/xmlhttprequest.html: We don't expose cookies for documents
        retrieved via XMLHttpRequest. Added a check to make sure that we don't forget about cross-
        origin restrictions if we ever decide to change that.

        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi: While at it, fixed a broken check
        for Set-Cookie2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 05:43:58 +0000 (05:43 +0000)]
2009-03-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24503

        Fix hit testing of absolutely positioned single line text controls by
        ensuring that we set result.innerNode() correctly. If the hit node is
        a descendant of the inner text element or if it is the <input> itself,
        then we say we hit the innerTextElement.

        Rename hitInnerTextBlock() to hitInnerTextElement() to match the
        'innerTextElement' terminology used elsewhere.

        Assert that if renderer()->hitTest() returns false, no-one set
        result.innerNode().

        Test: fast/forms/search-abs-pos-cancel-button.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestContents):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 11 Mar 2009 02:20:32 +0000 (02:20 +0000)]
2009-03-10  Antti Koivisto  <antti@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

        Another case where we would trigger extended encoding loading needlessly.

        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::isNonByteBasedEncoding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build.
justin.garcia@apple.com [Wed, 11 Mar 2009 00:08:32 +0000 (00:08 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Wed, 11 Mar 2009 00:05:24 +0000 (00:05 +0000)]
WebCore:

2009-03-10  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
        scroll bar appears for long line of text with NOWRAP set

        This is a regression from http://trac.webkit.org/changeset/32226
        I talked with Dan about the original change, and we decided that
        the best fix was to remove his small potential-optimization that
        only created a separate line box for whitespace under certain
        circumstances. This new code will always create a separate line
        box.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

2009-03-10  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB):
        No scroll bar appears for long line of text with NOWRAP set

        New test:
        * fast/inline/long-wrapped-line.html: Added.
        * platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
        * platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
        * platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.

        These tests all have changed results from the patch. Now trailing
        whitespace always has its own linebox instead of sometimes sharing
        a linebox with text.
        * platform/mac/editing/deleting/5206311-1-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
        * platform/mac/editing/deleting/forward-delete-expected.txt:
        * platform/mac/editing/execCommand/5482023-expected.txt:
        * platform/mac/editing/execCommand/boldSelection-expected.txt:
        * platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
        * platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * platform/mac/editing/execCommand/print-expected.txt:
        * platform/mac/editing/execCommand/selectAll-expected.txt:
        * platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
        * platform/mac/editing/input/emacs-ctrl-o-expected.txt:
        * platform/mac/editing/inserting/12882-expected.txt:
        * platform/mac/editing/inserting/editable-html-element-expected.txt:
        * platform/mac/editing/inserting/insert-div-019-expected.txt:
        * platform/mac/editing/inserting/insert-div-020-expected.txt:
        * platform/mac/editing/inserting/insert-div-021-expected.txt:
        * platform/mac/editing/inserting/insert-div-022-expected.txt:
        * platform/mac/editing/inserting/insert-div-023-expected.txt:
        * platform/mac/editing/inserting/insert-div-024-expected.txt:
        * platform/mac/editing/inserting/insert-div-025-expected.txt:
        * platform/mac/editing/inserting/insert-div-027-expected.txt:
        * platform/mac/editing/inserting/typing-003-expected.txt:
        * platform/mac/editing/pasteboard/4989774-expected.txt:
        * platform/mac/editing/pasteboard/5028447-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-3-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-014-expected.txt:
        * platform/mac/editing/selection/4947387-expected.txt:
        * platform/mac/editing/selection/4983858-expected.txt:
        * platform/mac/editing/selection/5081257-1-expected.txt:
        * platform/mac/editing/selection/5081257-2-expected.txt:
        * platform/mac/editing/selection/5136696-expected.txt:
        * platform/mac/editing/selection/5234383-1-expected.txt:
        * platform/mac/editing/selection/5234383-2-expected.txt:
        * platform/mac/editing/selection/7152-1-expected.txt:
        * platform/mac/editing/selection/7152-2-expected.txt:
        * platform/mac/editing/selection/after-line-wrap-expected.txt:
        * platform/mac/editing/selection/click-start-of-line-expected.txt:
        * platform/mac/editing/selection/drag-in-iframe-expected.txt:
        * platform/mac/editing/selection/editable-html-element-expected.txt:
        * platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
        * platform/mac/editing/selection/end-of-document-expected.txt:
        * platform/mac/editing/selection/extend-by-character-003-expected.txt:
        * platform/mac/editing/selection/extend-by-character-005-expected.txt:
        * platform/mac/editing/selection/extend-by-word-002-expected.txt:
        * platform/mac/editing/selection/mixed-editability-1-expected.txt:
        * platform/mac/editing/selection/move-by-character-003-expected.txt:
        * platform/mac/editing/selection/move-by-character-005-expected.txt:
        * platform/mac/editing/selection/select-all-001-expected.txt:
        * platform/mac/editing/selection/select-all-002-expected.txt:
        * platform/mac/editing/selection/select-all-003-expected.txt:
        * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
        * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
        * platform/mac/editing/style/apple-style-editable-mix-expected.txt:
        * platform/mac/editing/style/create-block-for-style-001-expected.txt:
        * platform/mac/editing/style/create-block-for-style-002-expected.txt:
        * platform/mac/editing/style/create-block-for-style-003-expected.txt:
        * platform/mac/editing/style/create-block-for-style-004-expected.txt:
        * platform/mac/editing/style/create-block-for-style-005-expected.txt:
        * platform/mac/editing/style/create-block-for-style-006-expected.txt:
        * platform/mac/editing/style/create-block-for-style-007-expected.txt:
        * platform/mac/editing/style/create-block-for-style-008-expected.txt:
        * platform/mac/editing/style/create-block-for-style-009-expected.txt:
        * platform/mac/editing/style/create-block-for-style-010-expected.txt:
        * platform/mac/editing/style/create-block-for-style-011-expected.txt:
        * platform/mac/editing/style/create-block-for-style-012-expected.txt:
        * platform/mac/editing/style/create-block-for-style-013-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-001-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-002-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-003-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-004-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-expected.txt:
        * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-delete-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-expected.txt:
        * platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
        * platform/mac/fast/clip/outline-overflowClip-expected.txt:
        * platform/mac/fast/forms/negativeLineHeight-expected.txt:
        * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
        * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
        * platform/mac/fast/lists/drag-into-marker-expected.txt:
        * platform/mac/fast/parser/comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
        * platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
        * platform/mac/fast/repaint/selection-after-delete-expected.txt:
        * platform/mac/fast/repaint/selection-after-remove-expected.txt:
        * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
        * platform/mac/fast/text/trailing-white-space-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
        * platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
        * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
        * platform/mac/http/tests/navigation/post-goback2-expected.txt:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
        * platform/mac/http/tests/navigation/success200-goback-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 10 Mar 2009 23:57:14 +0000 (23:57 +0000)]
2009-03-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6166844>
        https://bugs.webkit.org/show_bug.cgi?id=24495

        Use same rule for loading java applets as we do for images.

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build.
justin.garcia@apple.com [Tue, 10 Mar 2009 23:23:48 +0000 (23:23 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Tue, 10 Mar 2009 22:59:07 +0000 (22:59 +0000)]
2009-03-10  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by David Kilzer.

        Get rid of revealCaret and use revealSelection instead.

        * WebCore.base.exp:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 10 Mar 2009 22:48:46 +0000 (22:48 +0000)]
2009-03-10  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Geoff Garen.

        Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
        <https://bugs.webkit.org/show_bug.cgi?id=24291>
        <rdar://problem/6663472>

        Add an extra newline to the end of the body of the program text constructed
        by the Function constructor for parsing. This allows single line comments to
        be handled correctly by the parser.

        JavaScriptCore:

        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):

        LayoutTests:

        * fast/events/onload-single-line-comment-expected.txt: Added.
        * fast/events/onload-single-line-comment.html: Added.
        * fast/js/function-constructor-single-line-comment-expected.txt: Added.
        * fast/js/function-constructor-single-line-comment.html: Added.
        * fast/js/resources/function-constructor-single-line-comment.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory...
sfalken@apple.com [Tue, 10 Mar 2009 21:46:32 +0000 (21:46 +0000)]
    <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults

        Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.

        This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
        The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
        saying there was browsing history for a particular day, and then return no history items when we requested a
        list of sites visited that day.

        Reviewed by Ada Chan.

        * MarshallingHelpers.cpp:
        (MarshallingHelpers::DATEToCFAbsoluteTime):
        (MarshallingHelpers::CFAbsoluteTimeToDATE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 10 Mar 2009 19:49:47 +0000 (19:49 +0000)]
2009-03-10  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Geoff Garen.

        Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
        <https://bugs.webkit.org/show_bug.cgi?id=23736>
        <rdar://problem/6560278>

        Before replacing the document, FrameLoader::executeIfJavaScriptURL()
        should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().

        WebCore:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):

        LayoutTests:

        * http/tests/misc/javascript-url-stop-loaders-expected.txt: Added.
        * http/tests/misc/javascript-url-stop-loaders.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Tue, 10 Mar 2009 19:31:22 +0000 (19:31 +0000)]
WebCore:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 24494: crash when deleting at end of document and merging paragraphs
        https://bugs.webkit.org/show_bug.cgi?id=24494
        rdar://problem/6571537

        Test: editing/deleting/merge-at-end-of-document.html

        * dom/Range.cpp:
        (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to
        use && in assertions since we'd like to know which condition is failing.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before
        calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the
        function doesn't know which value to return.

LayoutTests:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 24494: crash when deleting at end of document and merging paragraphs
        https://bugs.webkit.org/show_bug.cgi?id=24494
        rdar://problem/6571537

        * editing/deleting/merge-at-end-of-document-expected.txt: Added.
        * editing/deleting/merge-at-end-of-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 10 Mar 2009 18:46:50 +0000 (18:46 +0000)]
2009-03-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel. Math checked by Oliver Hunt.

        Implement the Cairo version of the checkForSolidColor() method. This halfes the
        time to draw on 1x1 px background images.
        I added two new calls to Color for the pixel manipulation on cairo_surface's.
        They are neede to premultiply/unpremultiply the colors of the surface.

        [CAIRO] Introduce single-pixel image optimizations
        https://bugs.webkit.org/show_bug.cgi?id=17284

        * platform/graphics/Color.cpp:
        (WebCore::colorFromPremultipliedARGB):
        (WebCore::premultipliedARGBFromColor):
        * platform/graphics/Color.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 10 Mar 2009 18:38:02 +0000 (18:38 +0000)]
2009-03-10  Adam Treat  <adam.treat@torchmobile.com>

        Build fix for Qt after r41555.

        * Api/qwebpage.cpp:
        (QWebPage::acceptNavigationRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 18:22:12 +0000 (18:22 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Use g_hash_table_new_full so we can save the manual unref on the
        values when removing them from the table.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 17:34:32 +0000 (17:34 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
        guidelines.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
xan@webkit.org [Tue, 10 Mar 2009 17:00:57 +0000 (17:00 +0000)]
WebKit/mac:

2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Build fix, no review.

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]):

WebKit/qt:

2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Build fix, no review.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 16:38:53 +0000 (16:38 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        Correct return value to false instead of NULL.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 10 Mar 2009 16:23:33 +0000 (16:23 +0000)]
2009-03-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=24437

        Add support for registering noAccess URL schemes:
        1-  Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
        that list upon construction (similar to how isLocal is implemented).
        2-  Make InspectorController call grantUniversalAccess on its Document's
        SecurityOrigin at the time when windowScriptObjectAvailable is called.

        This enables content such as the inspector to be loaded from a custom (non-file)
        URL, which is how Chromium loads the inspector.  It also allows other URL schemes
        to be treated like data: URLs, which Chromium utilizes for its various HTML-based
        UI panels.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * loader/FrameLoader.cpp:
        (WebCore::localSchemes):
        (WebCore::noAccessSchemes):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::isLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 16:19:27 +0000 (16:19 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Build fix, no review

        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerForVisiblePosition):
        (visiblePositionForTextMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 16:10:24 +0000 (16:10 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24491
        Rename posOffset to m_offset, get rid of accessor

        As suggested in dom/Position.h, this patch gets rid of the
        'offset()' accessor and renames posOffset to m_offset. I've used
        m_offset instead of offset to follow the style guide lines, since
        Position is still a class and not a structure. If the long term
        plan is still to make it a structure it would be pretty easy to
        just s/m_offset/offset/ globally when that is achieved.

        * dom/Position.cpp:
        (WebCore::Position::previous):
        (WebCore::Position::next):
        (WebCore::Position::atStart):
        (WebCore::Position::atEnd):
        (WebCore::Position::renderedOffset):
        (WebCore::Position::isCandidate):
        (WebCore::Position::inRenderedText):
        (WebCore::Position::isRenderedCharacter):
        (WebCore::Position::rendersInDifferentPosition):
        (WebCore::Position::leadingWhitespacePosition):
        (WebCore::Position::debugPosition):
        (WebCore::Position::formatForDebugger):
        * dom/Position.h:
        (WebCore::Position::Position):
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator):
        * dom/Range.cpp:
        * dom/RangeBoundaryPoint.h:
        (WebCore::RangeBoundaryPoint::position):
        (WebCore::RangeBoundaryPoint::set):
        (WebCore::RangeBoundaryPoint::setOffset):
        (WebCore::RangeBoundaryPoint::setToChild):
        (WebCore::RangeBoundaryPoint::setToStart):
        (WebCore::RangeBoundaryPoint::setToEnd):
        (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::nodeFullySelected):
        (WebCore::ApplyStyleCommand::nodeFullyUnselected):
        (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
        (WebCore::ApplyStyleCommand::joinChildTextNodes):
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
        (WebCore::CompositeEditCommand::deleteInsignificantText):
        (WebCore::CompositeEditCommand::removePlaceholderAt):
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::updatePositionForTextRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace):
        * editing/Editor.cpp:
        (WebCore::Editor::setComposition):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::getCompositionSelection):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace):
        (WebCore::InsertTextCommand::input):
        (WebCore::InsertTextCommand::insertTab):
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::debugPosition):
        (WebCore::makeRange):
        (WebCore::setStart):
        (WebCore::setEnd):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::toNormalizedRange):
        (WebCore::makeSearchRange):
        (WebCore::VisibleSelection::debugPosition):
        (WebCore::VisibleSelection::showTreeForThis):
        * editing/htmlediting.cpp:
        (WebCore::comparePositions):
        (WebCore::rangeCompliantEquivalent):
        (WebCore::isFirstPositionAfterTable):
        (WebCore::isLastPositionBeforeTable):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        (WebCore::startPositionForLine):
        (WebCore::startOfLine):
        (WebCore::endPositionForLine):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        * page/AccessibilityObject.cpp:
        (WebCore::updateAXLineStartForVisiblePosition):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::anchorOffset):
        (WebCore::DOMSelection::baseOffset):
        (WebCore::DOMSelection::focusOffset):
        (WebCore::DOMSelection::extentOffset):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * page/Frame.cpp:
        (WebCore::Frame::selectionLayoutChanged):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::indexForVisiblePosition):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Tue, 10 Mar 2009 14:46:42 +0000 (14:46 +0000)]
WebCore:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
        https://bugs.webkit.org/show_bug.cgi?id=23564
        rdar://problem/6537238

        Test: fast/dom/HTMLElement/innerHTML-selection-crash.html

        * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
        call to the one of the two overloads of this function that wasn't calling it. This fixes
        this crash and other possible crashes inside innerHTML.

LayoutTests:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
        https://bugs.webkit.org/show_bug.cgi?id=23564
        rdar://problem/6537238

        * fast/dom/HTMLElement/innerHTML-selection-crash-expected.txt: Added.
        * fast/dom/HTMLElement/innerHTML-selection-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 14:10:56 +0000 (14:10 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24285
        Text resource loading checks for BOM twice

        This removes TextDecoder class, since its only purpose was to check for BOM, which is
        already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
        BOM checked, but I didn't find any cases where it would significantly change behavior.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Remove TextDecoder.{h,cpp}.

        * platform/text/TextDecoder.cpp: Removed.
        * platform/text/TextDecoder.h: Removed.

        * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
        TextCodec separately.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
        (WebCore::TextResourceDecoder::setEncoding): Ditto.
        (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
        even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
        BOM again. Made this function return the detected BOM length.
        (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
        a text resource.
        (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
        resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.

        * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
        Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
        checks for BOM, which was a counter-intuitive feature.

        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::setEncoding):
        (WebCore::CachedScript::encoding):
        (WebCore::CachedScript::script):
        * loader/CachedScript.h:
        * loader/appcache/ManifestParser.cpp:
        (WebCore::parseManifest):
        Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
        A side effect of this is that these resources will now be subject to encoding auto-detection.

        * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
        * page/Page.cpp: (WebCore::Page::userStyleSheet):
        Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
        re-usable (for repeated decoding of the same resource).

        * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 12:58:05 +0000 (12:58 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24488
        An assertion failure when updating an offline application cache after emptying caches

        Emptying appcache cannot be performed automatically, so no test.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
        storage, even if the application wasn't updated server side.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41550 268f45cc-cd09-0410-ab3c-d52691b4dbfc