WebKit-https.git
12 years ago2009-06-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 15 Jun 2009 18:39:36 +0000 (18:39 +0000)]
2009-06-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Add Core Animation movie plug-in example.

        * NetscapeCoreAnimationMoviePlugin: Added.
        * NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
        * NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
        * NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
        * NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
        * NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added.
        (createImageNamed):
        (-[MovieControllerLayer init]):
        (-[MovieControllerLayer dealloc]):
        (-[MovieControllerLayer _playPauseButtonRect]):
        (-[MovieControllerLayer _sliderRect]):
        (-[MovieControllerLayer _sliderThumbRect]):
        (-[MovieControllerLayer _innerSliderRect]):
        (-[MovieControllerLayer _drawPlayPauseButtonInContext:]):
        (-[MovieControllerLayer _drawSliderInContext:]):
        (-[MovieControllerLayer drawInContext:]):
        (-[MovieControllerLayer _currentTime]):
        (-[MovieControllerLayer _duration]):
        (-[MovieControllerLayer _isPlaying]):
        (-[MovieControllerLayer _updateTime:]):
        (-[MovieControllerLayer _rateDidChange:]):
        (-[MovieControllerLayer _timeDidChange:]):
        (-[MovieControllerLayer actionForKey:]):
        (-[MovieControllerLayer setMovie:]):
        (-[MovieControllerLayer _setNewTimeForThumbCenterX:]):
        (-[MovieControllerLayer handleMouseDown:]):
        (-[MovieControllerLayer handleMouseUp:]):
        (-[MovieControllerLayer handleMouseDragged:]):
        * NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
        * NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
        * NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
        * NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
        * NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
        * NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
        * NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
        * NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
        * NetscapeCoreAnimationMoviePlugin/main.m: Added.
        (NP_Initialize):
        (NP_GetEntryPoints):
        (NP_Shutdown):
        (NPP_New):
        (NPP_Destroy):
        (NPP_SetWindow):
        (NPP_NewStream):
        (NPP_DestroyStream):
        (NPP_WriteReady):
        (NPP_Write):
        (NPP_StreamAsFile):
        (NPP_Print):
        (handleMouseDown):
        (togglePlayPause):
        (handleMouseUp):
        (handleMouseDragged):
        (handleMouseEntered):
        (handleMouseExited):
        (handleKeyDown):
        (handleScrollEvent):
        (NPP_HandleEvent):
        (NPP_URLNotify):
        (NPP_GetValue):
        (NPP_SetValue):
        * NetscapeCoreAnimationMoviePlugin/test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 15 Jun 2009 15:40:04 +0000 (15:40 +0000)]
2009-06-15  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Add new symbols list for 1.1.10 release.

        * docs/webkitgtk-docs.sgml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 15 Jun 2009 15:39:39 +0000 (15:39 +0000)]
2009-06-15  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Fix Since tags for the new uri and message properties.

        * webkit/webkitnetworkrequest.cpp:
        (webkit_network_request_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 15 Jun 2009 15:38:14 +0000 (15:38 +0000)]
2009-06-15  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by and done with Tor Arne Vestbø.

        Fix initialization of uninitialized members in FontFallbackListQt, leading
        to random crashes when rendering text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 15 Jun 2009 15:30:41 +0000 (15:30 +0000)]
2009-06-15  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Adding new documented API to the generated
        documentation.

        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 15 Jun 2009 14:38:22 +0000 (14:38 +0000)]
2009-06-15  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Adam Treat.

        Fix the logic for disabling the fixed layout feature, when an invalid
        QSize is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 15 Jun 2009 14:31:33 +0000 (14:31 +0000)]
2009-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Version bump in preparation for 1.1.10 release.

        * configure.ac:

WebKit/gtk:

2009-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update NEWS for 1.1.10 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 15 Jun 2009 14:17:15 +0000 (14:17 +0000)]
2009-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25895
        [Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled

        Use computeOffsetInContainerNode instead of the inline
        offsetInContainerNode to return the caret offset, since the former
        can handle all types of anchoring. Otherwise we'll hit an ASSERT
        in some situations in debug builds, and crash.

        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
hausmann@webkit.org [Mon, 15 Jun 2009 11:53:05 +0000 (11:53 +0000)]
2009-06-15  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix build break
        Rename JSONObject to InspectorJSONObject

        https://bugs.webkit.org/show_bug.cgi?id=26340

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Mon, 15 Jun 2009 08:39:27 +0000 (08:39 +0000)]
2009-06-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Mark Rowe.
        Reviewed by Simon Hausmann.
        Reviewed by Xan Lopez.

        Refactor handling of options in the build-webkit script

        Options are now defined in one place, and then reused when creating
        the usage help text, the arguments to GetOptions(), and when passing
        the options on to the underlying port-dependent build systems.

        This allows the Qt port to read the defaults for the options from the
        pro file (dynamically), and to pass the options on to qmake at build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
mrowe@apple.com [Mon, 15 Jun 2009 07:37:38 +0000 (07:37 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3

Reviewed by Cameron Zwarich.

Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run.  This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.

* WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Qt build break after r44672
vestbo@webkit.org [Mon, 15 Jun 2009 07:02:23 +0000 (07:02 +0000)]
Fix Qt build break after r44672

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 26399: REGRESSION: java applet accessibility broken
cfleizach@apple.com [Mon, 15 Jun 2009 06:11:33 +0000 (06:11 +0000)]
Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 15 Jun 2009 04:46:23 +0000 (04:46 +0000)]
2009-06-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
        to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
        their functionality (customGetOwnPropertySlot and customPut member functions have
        been renamed getOwnPropertySlotDelegate and putDelegate).  CustomGetOwnPropertySlot
        and CustomPutFunction have been repurposed to mean a complete custom implementation
        of the function which is inline with other extended attributes prefixed with Custom.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::putDelegate):
        * bindings/js/JSDOMWindowCustom.h:
        (WebCore::JSDOMWindow::getOwnPropertySlotDelegate):
        (WebCore::JSDOMWindow::putDelegate):
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
        (WebCore::JSHTMLAppletElement::putDelegate):
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
        (WebCore::JSHTMLEmbedElement::putDelegate):
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
        (WebCore::JSHTMLObjectElement::putDelegate):
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::getOwnPropertySlotDelegate):
        (WebCore::JSHistory::putDelegate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::getOwnPropertySlotDelegate):
        (WebCore::JSLocation::putDelegate):
        (WebCore::JSLocationPrototype::putDelegate):
        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::putDelegate):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSStyleDeclaration.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLObjectElement.idl:
        * page/DOMWindow.idl:
        * page/History.idl:
        * page/Location.idl:
        * storage/Storage.idl:
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 15 Jun 2009 04:36:59 +0000 (04:36 +0000)]
    Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=26395
          <rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after
          going back/forward to page with focused text field

        No test, since the back/forward cache is disabled in DumpRenderTree

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::open): Added a call to CachedPage::restore(),
        which was removed in r40870.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-14 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 15 Jun 2009 03:07:51 +0000 (03:07 +0000)]
2009-06-14  Darin Adler  <darin@apple.com>

        * editing/TextIterator.cpp:
        (WebCore::BitStack::push): Use named constant instead of hardcoded numbers.
        (WebCore::BitStack::top): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Mon, 15 Jun 2009 02:39:09 +0000 (02:39 +0000)]
WebCore:

2009-06-14  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 26364: Search can find text that's hidden by overflow:hidden
        https://bugs.webkit.org/show_bug.cgi?id=26364
        <rdar://problem/6952081>

        Test: fast/text/find-hidden-text.html

        * editing/TextIterator.cpp:
        (WebCore::BitStack::BitStack): Added.
        (WebCore::BitStack::push): Added.
        (WebCore::BitStack::pop): Added.
        (WebCore::BitStack::top): Added.
        (WebCore::BitStack::size): Added.
        (WebCore::parentOrShadowParent): Added. Helper function for walking up
        the parent node chain, crossing shadow tree boundaries.
        (WebCore::depthCrossingShadowBoundaries): Added for use in assertions.
        Counts the depth of a node using the parentOrShadowParent function.
        (WebCore::fullyClipsContents): Added. Returns true for an element that
        fully clips its contents, currently defined as a box that has zero width
        or height and hides overflow. We can add other cases here later.
        (WebCore::ignoresContainerClip): Added. Returns true for an element that
        ignores its container clip, currently defined as an element with absolute
        or fixed positioning.
        (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating
        if the node in question fully clips its contents.
        (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of
        a node. Used when creating an iterator.
        (WebCore::TextIterator::TextIterator): Removed code to initialize
        m_inShadowContent. Call setUpFullyClippedStack.
        (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving
        up to a parent node, and also one extra time when moving to a sibling node.
        Call pushFullyClippedState when moving to a child node, or when moving to a
        sibling node after the aforementioned call to pop.
        (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped.
        (WebCore::TextIterator::handleReplacedElement): Ditto.
        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        Call setUpFullyClippedStack.
        (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as
        TextIterator::advance above.

        * editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both
        TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.

LayoutTests:

2009-06-14  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 26364: Search can find text that's hidden by overflow:hidden
        https://bugs.webkit.org/show_bug.cgi?id=26364
        <rdar://problem/6952081>

        * fast/text/find-hidden-text-expected.txt: Added.
        * fast/text/find-hidden-text.html: Added.

        * fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
        * fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
        * fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
        * fast/parser/badentity-expected.txt: Removed a blank line.
        * http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 14 Jun 2009 23:52:38 +0000 (23:52 +0000)]
2009-06-14  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=26362

        Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
        Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
        changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):
        * dom/Node.cpp:
        (WebCore::Node::diff):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setChildIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 14 Jun 2009 21:57:49 +0000 (21:57 +0000)]
2009-06-14  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        Move all of the mutable member variables from Font into the refcounted FontFallbackList.  This makes
        copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
        inside the FontFallbackList.

        * WebCore.base.exp:
        * platform/graphics/Font.cpp:
        (WebCore::Font::Font):
        (WebCore::Font::operator=):
        (WebCore::Font::primaryFont):
        (WebCore::Font::update):
        * platform/graphics/Font.h:
        (WebCore::Font::setWordSpacing):
        (WebCore::Font::setLetterSpacing):
        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList):
        (WebCore::FontFallbackList::invalidate):
        (WebCore::FontFallbackList::determinePitch):
        * platform/graphics/FontFallbackList.h:
        (WebCore::FontFallbackList::primarySimpleFontData):
        (WebCore::FontFallbackList::primaryFontData):
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 14 Jun 2009 21:27:10 +0000 (21:27 +0000)]
2009-06-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=26362

        Fix an issue noted on quirksmode.com where dynamically adding siblings does not
        update :nth-child style correctly.

        Test: fast/css/nth-child-dynamic.html

        * dom/Node.h:
        Change diff() to take const RenderStyle*
        * dom/Node.cpp:
        (WebCore::Node::diff):
        When comparing styles to decide whether to detach and reattach, we
        need to look at whether the pseudoclass-related data in the style
        changed (since RenderStyle::diff doesn't check this).

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::getCachedPseudoStyle):
        (WebCore::RenderStyle::inheritedNotEqual):
        Make these methods const.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::styleType):
        (WebCore::InheritedFlags::pseudoClassStateEquivalent):
        Make methods const.
        Add new method that compares the pseudoclass-related members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update V8 benchmark to version 4.
sfalken@apple.com [Sun, 14 Jun 2009 07:03:12 +0000 (07:03 +0000)]
    Update V8 benchmark to version 4.

        Reviewed by Cameron Zwarich.

        * tests/LIST-V8:
        * tests/v8-crypto.js:
        * tests/v8-deltablue.js:
        * tests/v8-earley-boyer.js:
        * tests/v8-raytrace.js:
        * tests/v8-regexp.js: Added.
        * tests/v8-richards.js:
        * tests/v8-splay.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sun, 14 Jun 2009 06:44:08 +0000 (06:44 +0000)]
2009-06-13  Peter Kasting  <pkasting@google.com>

        Reviewed by Kevin Ollivier.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
        Write a wx implementation so the wx port can compile.  For now this is
        mostly a copy of the Cairo port, but in the future it can be changed to
        use a wxBitmap as the storage type everywhere (just as Cairo can
        probably be changed).

        Also ASSERT for any other ports who call getAddr() (I don't think there
        are any, and besides, they probably won't link, but this doesn't hurt).

        Also fixes a dumb Cairo build bustage typo introduced in part ten.

        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::ImageSource::createFrameAtIndex):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
        (WebCore::RGBA32Buffer::setStatus):
        * platform/image-decoders/wx: Added.
        * platform/image-decoders/wx/ImageDecoderWx.cpp: Added.
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::zeroFill):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        * webcore-wx.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-09 Justin Garcia <justin.garcia@apple.com>
abarth@webkit.org [Sun, 14 Jun 2009 05:06:17 +0000 (05:06 +0000)]
2009-06-09  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric Seidel.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26281

        REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable
        region loses images

        Prefer RTFD (RTF with inline images) over RTF.  In
        http://trac.webkit.org/changeset/19745 I accidently reversed their
        order.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Stephen White <senorblanco@chromium.org>
abarth@webkit.org [Sun, 14 Jun 2009 04:53:09 +0000 (04:53 +0000)]
2009-06-13  Stephen White  <senorblanco@chromium.org>

        Reviewed by Dimitri Glazkov.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26320

        Some minor code cleanup for chromium/skia port.  Removed #ifdef's
        around skia API changes, since the new version seems solid and we
        don't need to go back.  Added some comments to
        TransparencyWin.h, as requested by Brett in
        https://bugs.webkit.org/show_bug.cgi?id=24584.

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/TransparencyWin.h:
        * platform/graphics/skia/PathSkia.cpp:
        (WebCore::Path::boundingRect):
        (WebCore::boundingBoxForCurrentStroke):
        * platform/graphics/skia/SkiaUtils.cpp:
        (WebCore::SkPathContainsPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix: Another missing header. Arg.
abarth@webkit.org [Sun, 14 Jun 2009 04:29:52 +0000 (04:29 +0000)]
Build fix: Another missing header.  Arg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix: add missing header.
abarth@webkit.org [Sun, 14 Jun 2009 04:24:28 +0000 (04:24 +0000)]
Build fix: add missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Sun, 14 Jun 2009 04:14:47 +0000 (04:14 +0000)]
WebCore:

2009-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24492

        Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
        FrameLoader to SecurityOrigin.

        * WebCore.base.exp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadFrameRequest):
        (WebCore::FrameLoader::canLoad):
        * loader/FrameLoader.h:
        * page/SecurityOrigin.cpp:
        (WebCore::localSchemes):
        (WebCore::noAccessSchemes):
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::isLocal):
        (WebCore::SecurityOrigin::registerURLSchemeAsLocal):
        (WebCore::SecurityOrigin::shouldTreatURLAsLocal):
        (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal):
        (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
        (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
        * page/SecurityOrigin.h:

WebKit/mac:

2009-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24492

        Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin

        * WebView/WebView.mm:
        (+[WebView registerURLSchemeAsLocal:]):

WebKit/qt:

2009-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24492

        Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.

        * Api/qwebpage.cpp:
        (QWebPage::acceptNavigationRequest):

WebKit/win:

2009-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24492

        Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.

        * WebView.cpp:
        (WebView::registerURLSchemeAsLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Ben Murdoch <benm@google.com>
abarth@webkit.org [Sun, 14 Jun 2009 03:47:32 +0000 (03:47 +0000)]
2009-06-13  Ben Murdoch  <benm@google.com>

        Reviewed by David Kilzer.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26189

        This patch changes the way PageGroups create their localStorage
        objects. Rather than creating a local storage object for the page group
        when a page is added to the group, the local storage object is now
        created lazily when the local storage object is requested by the
        DOMWindow.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created.
        (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group.
        (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
        * page/PageGroup.h: Add private hasLocalStorage method to PageGroup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Ben Murdoch <benm@google.com>
abarth@webkit.org [Sun, 14 Jun 2009 03:44:36 +0000 (03:44 +0000)]
2009-06-13  Ben Murdoch  <benm@google.com>

        Reviewed by Eric Seidel.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26189

        Add ENABLE(DOM_STORAGE) guards to the dom storage source files.

        * storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
        * storage/LocalStorage.h: Ditto
        * storage/LocalStorageArea.cpp: Ditto
        * storage/LocalStorageArea.h: Ditto
        * storage/LocalStorageTask.cpp: Ditto
        * storage/LocalStorageTask.h: Ditto
        * storage/LocalStorageThread.cpp: Ditto
        * storage/LocalStorageThread.h: Ditto
        * storage/SessionStorage.cpp: Ditto
        * storage/SessionStorage.h: Ditto
        * storage/SessionStorageArea.cpp: Ditto
        * storage/SessionStorageArea.h: Ditto
        * storage/Storage.cpp: Ditto
        * storage/Storage.h: Ditto
        * storage/StorageArea.cpp: Ditto
        * storage/StorageArea.h: Ditto
        * storage/StorageEvent.cpp: Ditto
        * storage/StorageEvent.h: Ditto
        * storage/StorageMap.cpp: Ditto
        * storage/StorageMap.h: Ditto
        * storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
        * storage/Storage.idl: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sun, 14 Jun 2009 01:00:20 +0000 (01:00 +0000)]
2009-06-13  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
        Make Skia use the root directory ImageDecoder.h and factor out most
        Skia-specific bits into skia/ImageDecoderSkia.cpp.  Also fix a pair of
        style violations in ImageDecoderCairo.cpp.  This is the last patch for
        this bug, everything beyond this is an enhancement rather than
        unforking.

        * platform/image-decoders/ImageDecoder.h:
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::setStatus):
        * platform/image-decoders/skia/ImageDecoder.h: Removed.
        * platform/image-decoders/skia/ImageDecoderSkia.cpp: Added.
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::zeroFill):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 13 Jun 2009 23:11:32 +0000 (23:11 +0000)]
2009-06-13  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark "Snowy" Rowe.

        Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.

        * iExploder/htdocs/cssproperties.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Victor Wang <victorw@chromium.org>
abarth@webkit.org [Sat, 13 Jun 2009 21:35:02 +0000 (21:35 +0000)]
2009-06-13  Victor Wang <victorw@chromium.org>

        Reviewed by Eric Seidel.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26333
        Alert during a dragenter event handler will crash the renderer

        This crash is casued by calling NULL pointer m_documentUnderMouse in
        DragController::tryDocumentDrag()

        tryDHTMLDrag fires dragenter event. The event listener that listens
        to this event may create a nested message loop (open a modal dialog),
        which could process dragleave event and reset m_documentUnderMouse in
        dragExited.

        Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
        do not continue if the pointer has been set to NULL.

        Test: DRT does not show alerts so add a manual test:
              manual-tests/drag-enter-alert.html

        * manual-tests/drag-enter-alert.html: Added.
        * manual-tests/resources/drag-image.png: Added.
        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Nate Chapin <japhet@google.com>
abarth@webkit.org [Sat, 13 Jun 2009 21:27:56 +0000 (21:27 +0000)]
2009-06-13  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.  Landed by Adam Barth.

        Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.

        https://bugs.webkit.org/show_bug.cgi?id=26227

        * bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added.
        (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org.
        (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org.
        (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
        * bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
        * bindings/v8/custom/V8DocumentCustom.cpp: Updated includes.
        (WebCore::CALLBACK_FUNC_DECL): Updated class name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 John Abd-El-Malek <jam@chromium.org>
abarth@webkit.org [Sat, 13 Jun 2009 21:23:46 +0000 (21:23 +0000)]
2009-06-13  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Eric Seidel.  Landed by Adam Barth.

        Removed dead file.
        https://bugs.webkit.org/show_bug.cgi?id=26308

        * DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
abarth@webkit.org [Sat, 13 Jun 2009 21:19:18 +0000 (21:19 +0000)]
2009-06-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Mark Rowe.  Landed by Adam Barth.

        Remove obsolete declarations for old Symbian port
        https://bugs.webkit.org/show_bug.cgi?id=26339

        * platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
        * platform/graphics/FloatRect.h: Ditto.
        * platform/graphics/IntPoint.h: Ditto.
        * platform/graphics/IntRect.h: Ditto.
        * platform/graphics/IntSize.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 13 Jun 2009 19:54:11 +0000 (19:54 +0000)]
2009-06-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        Added subRegion calculation to SVG filter. Every filter effect is
        clipped to the filter region (according to the spec). This makes
        ImageBuffers for filter effects smaller and we just need to take
        care about big filter regions.
        SVGFEImage needed a correction, to avoid an ASSERT. The two filter
        effects feOffset and feFlood help to test the new subRegion code.

        Tests: svg/filters/subRegion-one-effect.svg
               svg/filters/subRegion-two-effects.svg

        Added tests for the new subRgion-code on SVG filters.

        * platform/mac/svg/filters: Added.
        * platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
        * platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
        * platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
        * platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
        * svg/filters: Added.
        * svg/filters/subRegion-one-effect.svg: Added.
        * svg/filters/subRegion-two-effects.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 13 Jun 2009 19:36:30 +0000 (19:36 +0000)]
2009-06-13  Peter Kasting  <pkasting@google.com>

        Bustage: Fix broken GIFs on Cairo due to subtle typo.  Fix a warning.

        * platform/image-decoders/ImageDecoder.h:
        (WebCore::RGBA32Buffer::copyRowNTimes):
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::processBitmasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 13 Jun 2009 19:10:07 +0000 (19:10 +0000)]
2009-06-13  Peter Kasting  <pkasting@google.com>

        GTK bustage fix.  "inline" is handled differently by different compilers.

        * platform/image-decoders/ImageDecoder.h:
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/cairo/ImageDecoderCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 13 Jun 2009 18:55:41 +0000 (18:55 +0000)]
2009-06-13  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
        Factor Cairo-specific implementation out of ImageDecoder.h into
        ImageDecoderCairo.cpp.  Add some comments to functions declared
        in ImageDecoder.h.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/image-decoders/ImageDecoder.h:
        * platform/image-decoders/cairo: Added.
        * platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added.
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::zeroFill):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Dave Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 13 Jun 2009 17:52:44 +0000 (17:52 +0000)]
2009-06-12  Dave Hyatt  <hyatt@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=26373

        Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
        Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
        on Snow Leopard at first.

        * wtf/Threading.h:
        (WTF::ReadWriteLock::impl):
        * wtf/ThreadingPthreads.cpp:
        (WTF::ReadWriteLock::ReadWriteLock):
        (WTF::ReadWriteLock::~ReadWriteLock):
        (WTF::ReadWriteLock::readLock):
        (WTF::ReadWriteLock::tryReadLock):
        (WTF::ReadWriteLock::writeLock):
        (WTF::ReadWriteLock::tryWriteLock):
        (WTF::ReadWriteLock::unlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-13 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 13 Jun 2009 17:20:30 +0000 (17:20 +0000)]
2009-06-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler.

        Cleanup of the new MidpointState class.  Turn it into a struct instead.  Fix a mistaken
        assertion removal and some unintentional whitespace changes.

        * platform/text/BidiResolver.h:
        (WebCore::MidpointState::reset):
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::BidiRun::operator delete):
        (WebCore::chopMidpointsAt):
        (WebCore::checkMidpoints):
        (WebCore::addMidpoint):
        (WebCore::appendRunsForObject):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 13 Jun 2009 06:04:40 +0000 (06:04 +0000)]
2009-06-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=26367

        Remove the global variables in bidi.cpp.  Make a new struct, MidpointState, that holds all of the
        midpoint information.  Add the remaining global variables as arguments passed down through functions
        as needed.

        * platform/text/BidiResolver.h:
        (WebCore::MidpointState::MidpointState):
        (WebCore::MidpointState::reset):
        (WebCore::BidiResolver::midpointState):
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::BidiRun::operator delete):
        (WebCore::chopMidpointsAt):
        (WebCore::checkMidpoints):
        (WebCore::addMidpoint):
        (WebCore::appendRunsForObject):
        (WebCore::RenderBlock::bidiReorderLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::skipNonBreakingSpace):
        (WebCore::shouldCollapseWhiteSpace):
        (WebCore::requiresLineBox):
        (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::shouldSkipWhitespaceAfterStartObject):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Qt. After recent ImageDeocder.h changes.
zecke@webkit.org [Sat, 13 Jun 2009 05:03:16 +0000 (05:03 +0000)]
Build fix for Qt. After recent ImageDeocder.h changes.

I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.

https://bugs.webkit.org/show_bug.cgi?id=25709.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 13 Jun 2009 02:41:47 +0000 (02:41 +0000)]
2009-06-12  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [Gtk] Enable more http/tests/navigation tests

        * platform/gtk/Skipped:

        [Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 13 Jun 2009 02:31:14 +0000 (02:31 +0000)]
2009-06-12  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix: include cstdio so we can use sscanf

        Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
        Suggested by Brent Fulgham

        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        (WebCore::XBMImageDecoder::decodeDatum):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 13 Jun 2009 01:23:48 +0000 (01:23 +0000)]
2009-06-12  Peter Kasting  <pkasting@google.com>

        Yet another Skia bustage fix.

        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash.  The better fix is to take an IntSize(); I'll do that later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake LiteralParser non-recursive
oliver@apple.com [Sat, 13 Jun 2009 01:18:57 +0000 (01:18 +0000)]
Make LiteralParser non-recursive

Reviewed by Geoff Garen.

Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA.  Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector.   I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 13 Jun 2009 00:56:11 +0000 (00:56 +0000)]
2009-06-12  Peter Kasting  <pkasting@google.com>

        Fix remaining Cairo build bustage from
        https://bugs.webkit.org/show_bug.cgi?id=25709 changes.  Use
        Vector<char> in place of std::string.

        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        (WebCore::XBMImageDecoder::setData):
        (WebCore::XBMImageDecoder::decodeHeader):
        (WebCore::XBMImageDecoder::decodeDatum):
        * platform/image-decoders/xbm/XBMImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 David Levin <levin@chromium.org>
levin@chromium.org [Sat, 13 Jun 2009 00:47:49 +0000 (00:47 +0000)]
2009-06-12  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (build fix for windows).

        Adjust the exports for JSC on Windows like what was done for OSX in
        the previous commit.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
levin@chromium.org [Sat, 13 Jun 2009 00:41:03 +0000 (00:41 +0000)]
JavaScriptCore:

2009-06-12  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        UString shouldn't create sharedBuffer for SmallStrings.
        https://bugs.webkit.org/show_bug.cgi?id=26360

        The methods changed are not used by JSC, so there is no JS perf impact.  However,
        there is a potential DOM perf impact, so I re-ran several of the tests that
        I ran previously and ensured that the perf stay the same which caused me to
        adjust the minLengthToShare.

        * JavaScriptCore.exp:
        * runtime/UString.cpp:
        (JSC::UString::Rep::sharedBuffer):
            Determines if the buffer being shared is big enough before doing so.
            Previously, BaseString::sharedBuffer was called but it would only know
            the length of the base string (BaseString::len) which may not be the same
            as the string being shared (Rep::len).
        (JSC::UString::BaseString::sharedBuffer):
            This is now only be used by Rep::sharedBuffer. which does the length check.
        * runtime/UString.h:

WebCore:

2009-06-12  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        UString shouldn't create sharedBuffer for SmallStrings.
        https://bugs.webkit.org/show_bug.cgi?id=26347

        Change the call to use the method UString::Rep::sharedBuffer due
        to changes in UString.

        No noticable change in behavior, so no test.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 13 Jun 2009 00:11:38 +0000 (00:11 +0000)]
2009-06-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=26095

        Fix crash when a renderer for an anonymous node is composited
        by null-checking renderer()->node().

        Test: compositing/generated-content.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createGraphicsLayer):
        (WebCore::RenderLayerBacking::rendererHasBackground):
        (WebCore::RenderLayerBacking::rendererBackgroundColor):
        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 13 Jun 2009 00:04:13 +0000 (00:04 +0000)]
2009-06-12  Peter Kasting  <pkasting@google.com>

        Fix Chromium and some of Cairo build bustage, fallout from
        https://bugs.webkit.org/show_bug.cgi?id=25709 changes.

        * WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 12 Jun 2009 23:39:04 +0000 (23:39 +0000)]
2009-06-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Oliver Hunt

        Add a page indexing the various demo applications we have posted.

        * demos/index.html: Added.
        * nav.inc: Add a link to the demos page on the side bar
        * css/main.css:  Add a style for date stamps based on the blog.

        * demos/calendar/index.html: Added to redirect to Calendar.html.  I'm not moving Calendar.html to
          index.html as the Calendar.html url has already been published and we should keep it working.

        Move the drosera test code to /misc, as it is no longer a meaningful demo:
        * demos/drosera: Removed.
        * demos/drosera/demo.js: Removed.
        * demos/drosera/drosera.png: Removed.
        * demos/drosera/index.html: Removed.
        * misc/drosera: Copied from demos/drosera.

        Move the sticky notes example into /demos:
        * demos/sticky-notes: Added.
        * demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
        * demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
        * demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
        * demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
        * misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html.  I'm not removing
          it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
        * misc/DatabaseExample.manifest: Removed.
        * misc/deleteButton.png: Removed.
        * misc/deleteButtonPressed.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 12 Jun 2009 23:38:39 +0000 (23:38 +0000)]
2009-06-12  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is defined.

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::attachRootGraphicsLayer):
        (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization):
        (WebCore::EmptyChromeClient::scheduleViewUpdate):
        Add stubs for the compositing-related ChromeClient methods.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateRootLayerPosition):
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
        docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which
        matches what is used to size the WebHTMLView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 jorlow <jorlow@chromium.org>
dimich@chromium.org [Fri, 12 Jun 2009 23:20:35 +0000 (23:20 +0000)]
2009-06-12  jorlow  <jorlow@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26356
        http://crbug.com/14006
        Create custom bindings for v8.  The rest of these files are still
        forked (so the review is happening on the chromium review site).
        These bindings have been tested on a hacked up Chromium instance
        (also running --single-process) and Android.

        * bindings/v8/custom/V8StorageCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Fri, 12 Jun 2009 23:20:28 +0000 (23:20 +0000)]
2009-06-12  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26359
        [v8] Add XMLHttpRequest to WorkerContextExecutionProxy.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types.
        (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
        * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 12 Jun 2009 22:55:46 +0000 (22:55 +0000)]
2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
        Replace placeholder Cairo BMP, ICO, XBM decoders with real ones.  Remove
        all the decoders from skia/ since they are now just mirrors of the Cairo
        ones.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:
        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.  Enable XBM decoding on Windows.
        * platform/graphics/skia/ImageSourceSkia.cpp:
        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
        * platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
        * platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
        * platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
        * platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
        * platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
        * platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
        * platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/BMPImageDecoder.h: Removed.
        * platform/image-decoders/skia/BMPImageReader.cpp: Removed.
        * platform/image-decoders/skia/BMPImageReader.h: Removed.
        * platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/GIFImageDecoder.h: Removed.
        * platform/image-decoders/skia/GIFImageReader.cpp: Removed.
        * platform/image-decoders/skia/GIFImageReader.h: Removed.
        * platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/ICOImageDecoder.h: Removed.
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
        * platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/PNGImageDecoder.h: Removed.
        * platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/XBMImageDecoder.h: Removed.
        * platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
        * platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Fri, 12 Jun 2009 22:41:49 +0000 (22:41 +0000)]
2009-06-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26191
        Remove xmath include in MathExtras.h, because it is not needed and also
        breaks VS2008 builds with TR1 turned on.

        * wtf/MathExtras.h: Removed xmath include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 12 Jun 2009 22:24:28 +0000 (22:24 +0000)]
2009-06-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25599
        [GTK] Enable more tests

        Implement dumping of status callback.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 12 Jun 2009 22:06:50 +0000 (22:06 +0000)]
2009-06-11  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
        Update Skia's ImageDecoder.h with a few changes designed to reduce the
        delta between specific implementations of ImageDecoder.h.  Update
        Cairo's ImageDecoder.h to sync up with the API changes in the Skia
        version in the last two chage sets.  Update Cairo's PNG/JPEG/GIF
        decoders to use the APIs as well.  All the Cairo image decoder changes
        are direct copies of the Skia versions except ImageDecoder.h, which is
        modified in the necessary ways for the differences between Cairo and
        Skia.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
        * platform/image-decoders/ImageDecoder.h: Sync up with Skia version.
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::zeroFill):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::copyRowNTimes):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version.
        (WebCore::GIFImageDecoder::initFrameBuffer):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version.
        (WebCore::JPEGImageDecoder::outputScanlines):
        * platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version.
        (WebCore::PNGImageDecoder::rowAvailable):
        * platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version.  Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability.
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::copyRowNTimes):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 12 Jun 2009 21:36:08 +0000 (21:36 +0000)]
2009-06-12  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed build correction.

        Revert accidental configuration checkin.  Was not meant to
        be part of the last changeset.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago(Accidentally missed a couple email addresses in the last patch)
pkasting@chromium.org [Fri, 12 Jun 2009 21:34:25 +0000 (21:34 +0000)]
(Accidentally missed a couple email addresses in the last patch)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Fri, 12 Jun 2009 21:25:51 +0000 (21:25 +0000)]
2009-06-12  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26353
        Corrects handling of Cairo fonts that were getting out of
        sync due to default copy construction.  Also refactors
        some incorrect platform font destruction code that belongs
        in the font object's destructor.

        * platform/graphics/win/FontPlatformData.h:
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/win/FontPlatformDataCairoWin.cpp:
        (WebCore::FontPlatformData::platformDataInit):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::setFont):
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/win/SimpleFontDataWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
pkasting@chromium.org [Fri, 12 Jun 2009 21:19:28 +0000 (21:19 +0000)]
JavaScriptCore:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebCore:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Update my email address.
        * ChangeLog-2008-08-10: Update my email address.

WebKit/mac:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebKit/win:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog: Update my email address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Nate Chapin <japhet@google.com>
levin@chromium.org [Fri, 12 Jun 2009 18:02:59 +0000 (18:02 +0000)]
2009-06-12  Nate Chapin  <japhet@google.com>

        Reviewed by David Levin.

        Upstream V8Helpers.

        https://bugs.webkit.org/show_bug.cgi?id=26332

        * bindings/v8/V8Helpers.cpp: Added.
        (wrapNPObject): Moved from v8_helpers.cpp.
        (toV8Context): Moved from v8_helpers.cpp.
        (toV8Proxy): Moved from v8_helpers.cpp.
        * bindings/v8/V8Helpers.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Adding JSONObject.cpp to the build.
kevino@webkit.org [Fri, 12 Jun 2009 16:15:21 +0000 (16:15 +0000)]
wx build fix. Adding JSONObject.cpp to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndex: WebCore/ChangeLog
jberlin@apple.com [Fri, 12 Jun 2009 15:55:18 +0000 (15:55 +0000)]
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 44622)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2009-06-12  Jessie Berlin  <jberlin@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24792
+        rdar://problem/6933055
+
+        Changes the radius in which cursor movement around the 4 arrow icon
+        while pan-scrolling does not cause scrolling from around 10 pixels to
+        15 pixels, similar to what is found in IE and Firefox.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::setPanScrollCursor):
+        Factor out the no-pan-scroll radius.
+        * platform/ScrollView.h:
+        Create a constant for the no-pan-scroll radius.
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::panScrollFromPoint):
+        Factor out the no-pan-scroll radius.
+
 2009-06-12  Xan Lopez  <xlopez@igalia.com>

         Reviewed by Gustavo Noronha.
Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp (revision 44622)
+++ WebCore/page/EventHandler.cpp (working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()

     // At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
     // So we don't want to change the cursor over this area
-    const int noScrollRadius = 9;
-    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
-    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
-    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
-    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
+    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);

     if (north) {
         if (east)
Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h (revision 44622)
+++ WebCore/platform/ScrollView.h (working copy)
@@ -214,7 +214,8 @@ public:
     virtual void hide();
     virtual void setParentVisible(bool);

-    // Pan scrolling methods.
+    // Pan scrolling.
+    static const int noPanScrollRadius = 15;
     void addPanScrollIcon(const IntPoint&);
     void removePanScrollIcon();

Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp (revision 44622)
+++ WebCore/rendering/RenderLayer.cpp (working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
     const int shortDistanceLimit = 100;  // We delimit a 200 pixels long square enclosing the original point
     const int speedReducer = 2;          // Within this square we divide the scrolling speed by 2

-    const int iconRadius = 10;
     Frame* frame = renderer()->document()->frame();
     if (!frame)
         return;
@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
     int xDelta = currentMousePosition.x() - sourcePoint.x();
     int yDelta = currentMousePosition.y() - sourcePoint.y();

-    if (abs(xDelta) < iconRadius) // at the center we let the space for the icon
+    if (abs(xDelta) < ScrollView::noPanScrollRadius) // at the center we let the space for the icon
         xDelta = 0;
-    if (abs(yDelta) < iconRadius)
+    if (abs(yDelta) < ScrollView::noPanScrollRadius)
         yDelta = 0;

     // Let's attenuate the speed for the short distances

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>
ariya@webkit.org [Fri, 12 Jun 2009 14:44:37 +0000 (14:44 +0000)]
2009-06-12  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Jan Michael Alonzo.

        [Qt] Fix build break
        https://bugs.webkit.org/show_bug.cgi?id=26340

        * JavaScriptCore.pri: Add JSONObject.cpp to LUT files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 12 Jun 2009 06:46:17 +0000 (06:46 +0000)]
2009-06-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25609
        [GTK] Implement support for get_selection and get_n_selections

        Only use the VisibleSelection object if it actually belongs to the
        object we are using.

        This is pretty hacky-ish, but I can't seem to find a direct API to
        get the VisibleSelection for a given object, only the global one.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (selectionBelongsToObject):
        (webkit_accessible_text_get_n_selections):
        (webkit_accessible_text_get_selection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Ryosuke Niwa <rniwa@google.com>
jparent@chromium.org [Fri, 12 Jun 2009 00:58:48 +0000 (00:58 +0000)]
2009-06-11  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=2628i
        Converted LayoutTests\editing\deleting\4875189.html from a pixel test t
 dumpAsText test
        since it only checks whether the result contains exactly two paragraphs
or not.

        * editing/deleting/4875189-expected.txt: Added.
        * editing/deleting/4875189.html:
        * platform/mac/editing/deleting/4875189-expected.checksum: Removed.
        * platform/mac/editing/deleting/4875189-expected.png: Removed.
        * platform/mac/editing/deleting/4875189-expected.txt: Removed.
        * platform/qt/editing/deleting/4875189-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 11 Jun 2009 23:47:09 +0000 (23:47 +0000)]
2009-06-11  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        Add a test to perform an actual download.

        * tests/testdownload.c:
        (navigation_policy_decision_requested_cb):
        (notify_status_cb):
        (download_requested_cb):
        (test_webkit_download_perform):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 11 Jun 2009 22:38:42 +0000 (22:38 +0000)]
2009-06-11  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        Fix crash when downloading, caused by assuming SoupMessage would
        be there. This change factors the logic required to create a
        ResourceRequest from a WebKitNetworkRequest into a core()
        function, like we have for some other classes.

        * webkit/webkitdownload.cpp:
        (webkit_download_start):
        * webkit/webkitprivate.cpp:
        (WebKit::core):
        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_load_request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 11 Jun 2009 22:17:17 +0000 (22:17 +0000)]
2009-06-11  Eric Seidel  <eric@webkit.org>

        Rubber stamped by Dave Levin.

        Add missing pixel results

        * platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
        * platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
        * platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
        * platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
        * platform/mac/fast/css/compare-content-style-expected.checksum: Added.
        * platform/mac/fast/css/compare-content-style-expected.png: Added.
        * platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
        * platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
        * platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
        * platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
        * platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
        * platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative fix
eric@webkit.org [Thu, 11 Jun 2009 21:20:01 +0000 (21:20 +0000)]
Speculative fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLower stringify recursion limit to deal with small windows stack.
oliver@apple.com [Thu, 11 Jun 2009 18:47:13 +0000 (18:47 +0000)]
Lower stringify recursion limit to deal with small windows stack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 John Abd-El-Malek <jam@chromium.org>
bfulgham@webkit.org [Thu, 11 Jun 2009 18:20:01 +0000 (18:20 +0000)]
2009-06-11  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=26306

        Revert 42565 as it leads to DumpRenderTree crashing on startup because
        Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.

        * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>
bfulgham@webkit.org [Thu, 11 Jun 2009 18:15:05 +0000 (18:15 +0000)]
2009-06-11  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=25512
        Handle texts after unfinished special tags (i.e., script, style, textarea,
        title, xmp, and iframe) as the text node under the tags in view-source mode.
        Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
ariya@webkit.org [Thu, 11 Jun 2009 17:57:50 +0000 (17:57 +0000)]
2009-06-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        Fix compilation warnings
        <https://bugs.webkit.org/show_bug.cgi?id=26015>

        * wtf/ThreadingNone.cpp:
        (WTF::ThreadCondition::wait): Fix compilation warning.
        (WTF::ThreadCondition::timedWait): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
ariya@webkit.org [Thu, 11 Jun 2009 17:39:21 +0000 (17:39 +0000)]
2009-06-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Fix release build detection
        https://bugs.webkit.org/show_bug.cgi?id=26267

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>
ariya@webkit.org [Thu, 11 Jun 2009 17:28:36 +0000 (17:28 +0000)]
2009-06-11  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=26291

        [Qt] build break in ImageDecoderQt.cpp.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::reset):
        (WebCore::ImageDecoderQt::setData):
        (WebCore::ImageDecoderQt::isSizeAvailable):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 11 Jun 2009 16:34:05 +0000 (16:34 +0000)]
2009-06-10  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Eric Seidel.

        Fixes https://bugs.webkit.org/show_bug.cgi?id=26309.
        Update a few items in the testing language to:
        (1) Reflect results are now generated with Leopard (not Tiger)
        (2) Explain how to generate pixel-level layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 11 Jun 2009 13:57:23 +0000 (13:57 +0000)]
2009-06-11  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        Removed obsolete and unmaintained files from the old Symbian port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Brent Fulgham <bfulgham@gmail.com>
bfulgham@webkit.org [Thu, 11 Jun 2009 05:31:04 +0000 (05:31 +0000)]
2009-06-10  Brent Fulgham  <bfulgham@gmail.com>

        Unreviewed build fix.
        Reverted change to skip file, as Windows build is
        still failing.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-05 Pierre d'Herbemont <pdherbemont@apple.com>
bfulgham@webkit.org [Thu, 11 Jun 2009 04:59:30 +0000 (04:59 +0000)]
2009-06-05 Pierre d'Herbemont <pdherbemont@apple.com>

        Reviewed by Eric Seidel.

        Re-enable the video-zoom-controls test on Windows.

        https://bugs.webkit.org/show_bug.cgi?id=25465

        * platform/win/Skipped:
        * platform/win/media: Added.
        * platform/win/media/video-zoom-controls-expected.checksum: Added.
        * platform/win/media/video-zoom-controls-expected.png: Added.
        * platform/win/media/video-zoom-controls-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Holger Hans Peter Freyther <zecke@selfish.org>
bfulgham@webkit.org [Thu, 11 Jun 2009 04:44:10 +0000 (04:44 +0000)]
2009-06-10  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Jan Alonzo.

        [gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed

        Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
        to pass more tests. Make sure the content is bigger than a thumbnail.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 11 Jun 2009 03:14:34 +0000 (03:14 +0000)]
2009-06-10  Gustavo Noronha Silva  <gns@gnome.org>

        Disabling new tests, and tests that use features of DRT we don't
        currently implement.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 11 Jun 2009 02:48:29 +0000 (02:48 +0000)]
2009-06-10  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        Add unit tests for our WebKitNetworkRequest object.

        * GNUmakefile.am:

WebKit/gtk

2009-06-10  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        Make WebKitNetworkRequest a proper GObject, making URI and
        SoupMessage properties. Also adding unit tests for creation and
        destruction.

        * tests/testnetworkrequest.c: Added.
        (test_network_request_create_destroy):
        (test_network_request_properties):
        (main):
        * webkit/webkitnetworkrequest.cpp:
        (webkit_network_request_get_property):
        (webkit_network_request_set_property):
        (webkit_network_request_class_init):
        (webkit_network_request_init):
        (webkit_network_request_constructor):
        (webkit_network_request_new_with_core_request):
        (webkit_network_request_new):
        (webkit_network_request_set_uri):
        (webkit_network_request_get_uri):
        * webkit/webkitnetworkrequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Thu, 11 Jun 2009 00:31:20 +0000 (00:31 +0000)]
2009-06-10  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part six
        Miscellaneous tiny changes.  The important bits here are the ANSI C++
        compliance fix in skia/ImageDecoders.h (needed to compile this file on
        non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
        unit tests partly exposed.  Other changes are mostly cosmetic.

        * platform/image-decoders/ImageDecoder.h: Make some variables private again.  This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
        (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
        * platform/image-decoders/skia/BMPImageReader.cpp:
        (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity.
        (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity.
        (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
        * platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0).
        (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
        (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
        * platform/image-decoders/skia/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
        * platform/image-decoders/skia/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
        * platform/image-decoders/skia/XBMImageDecoder.cpp:
        (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 11 Jun 2009 00:16:20 +0000 (00:16 +0000)]
2009-06-10  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed build correction.

        Clean up some stupid test mistakes, add pixel-level Mac tests
        for the new zero-radius gradient test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild correction for @r44574 (missing expected results).
bfulgham@webkit.org [Wed, 10 Jun 2009 23:22:58 +0000 (23:22 +0000)]
Build correction for @r44574 (missing expected results).
See https://bugs.webkit.org/show_bug.cgi?id=26059.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
kov@webkit.org [Wed, 10 Jun 2009 22:47:26 +0000 (22:47 +0000)]
2009-06-10  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        Clear the frame name before we run each tests so we don't get
        "someFloaString" or "3" in the target frame name.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix collapsing empty shadow nodes in textareas.
ojan@chromium.org [Wed, 10 Jun 2009 21:54:57 +0000 (21:54 +0000)]
Fix collapsing empty shadow nodes in textareas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 10 Jun 2009 20:55:25 +0000 (20:55 +0000)]
2009-06-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25609
        [GTK] Implement support for get_selection and get_n_selections

        Implement atk_text_get_n_selections.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_text_get_n_selections):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 10 Jun 2009 20:37:47 +0000 (20:37 +0000)]
WebCore:

        Reviewed by Anders Carlsson.

        - fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a
          Google map in iPhoto Places, it drags a map tile instead

        Calling stopLoadRequest() from notifyFinished() removed the
        ScriptElementData from the CachedScript's client set, which could make
        it eligible for purging. The fix is to call removeClient() only after
        executing the script, which protects it from being purged while it is
        in the document's queue of scripts to execute soon.

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::execute): Call removeClient() here.
        (WebCore::ScriptElementData::notifyFinished): Instead of calling
        stopLoadRequest(), which calls removeClient(), just reset
        m_cachedScript.

WebKitTools:

        Reviewed by Adele Peterson.

        - add a LayoutTestController method for temporarily changing the WebKit
          cache model

        * DumpRenderTree/LayoutTestController.cpp:
        (setCacheModelCallback): Added. Calls
        LayoutTestController::setCacheModel() with the first argument as an
        integer.
        (LayoutTestController::staticFunctions): Added setCacheModel.
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setCacheModel):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting): Reset the cache model to
        WebCacheModelDocumentBrowser.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences
        setCacheModel:].
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setCacheModel):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setCacheModel):

LayoutTests:

        Reviewed by Adele Peterson.

        - updated test to cover <rdar://problem/6958664> REGRESSION (r42665):
          When I drag to pan a Google map in iPhoto Places, it drags a map tile
          instead

        * fast/dom/HTMLScriptElement/nested-execution.html:
        * fast/dom/HTMLScriptElement/resources/nested-execution.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 10 Jun 2009 20:36:02 +0000 (20:36 +0000)]
2009-06-10  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe and Eric Seidel.

        Update WebInspector localizedStrings.js with new resource tracking strings
        https://bugs.webkit.org/show_bug.cgi?id=26247

        * English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Wed, 10 Jun 2009 19:22:49 +0000 (19:22 +0000)]
2009-06-10  Feng Qian  <feng@chromium.org>

        Reviewed by Eric Seidel.

        Add Android specific files.
        https://bugs.webkit.org/show_bug.cgi?id=26280

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Wed, 10 Jun 2009 19:21:20 +0000 (19:21 +0000)]
2009-06-10  Feng Qian  <feng@chromium.org>

        Reviewed by Eric Seidel.

        Add Android specific file to WebCore/platform/android (part 9).
        https://bugs.webkit.org/show_bug.cgi?id=26266

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Wed, 10 Jun 2009 19:19:48 +0000 (19:19 +0000)]
2009-06-10  Feng Qian  <feng@chromium.org>

        Reviewed by Eric Seidel.

        Add Android platform specific files.
        https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Wed, 10 Jun 2009 19:18:07 +0000 (19:18 +0000)]
2009-06-10  Feng Qian  <feng@chromium.org>

        Reviewed by Eric Seidel.

        Add Android port files to WebCore/platform. (part 6).
        https://bugs.webkit.org/show_bug.cgi?id=26264

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-06-10 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Wed, 10 Jun 2009 19:11:51 +0000 (19:11 +0000)]
2009-06-10  Feng Qian  <feng@chromium.org>

        Reviewed by Eric Seidel.

        Add Android port files to WebCore/platform (part 7).
        https://bugs.webkit.org/show_bug.cgi?id=23296

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44584 268f45cc-cd09-0410-ab3c-d52691b4dbfc