Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905

Reviewed by Darin Adler.

* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-18  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
        https://bugs.webkit.org/show_bug.cgi?id=54771

        Now that video is accelerated, we no longer need to special case
        video playing within a media document.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
        (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix linker warning on Windows

r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.

Rubber-stamped by Anders Carlsson.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Ami Fischman  <fischman@chromium.org>

        Reviewed by Eric Carlson.

        Add regression test for clean shutdown during video playback.
        DumpRenderTree used to crash if the test was ended while a video
        was still playing.  (http://crbug.com/72730).
        https://bugs.webkit.org/show_bug.cgi?id=54888

        * media/video-plays-past-end-of-test-expected.txt: Added.
        * media/video-plays-past-end-of-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Initialize DrawingAreaProxy::m_size
        https://bugs.webkit.org/show_bug.cgi?id=54913

        This was removed in r76962 since it caused flashes when switching drawing areas due to
        entering and exiting composited mode, but since we no longer switch drawing areas we can
        put it back.

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add some assertions about the state IDs we receive from the web process

Rubber-stamped by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".

As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.

This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:
  - Messages::DrawingArea::SetSize -> UpdateState
  - Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
  - DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
  - DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
  - DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
  - DrawingAreaImpl::m_inSetSize -> m_inUpdateState
  - generateSequenceNumber -> generateStateID
  - sequenceNumber -> stateID

Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Performed the renames described above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adam Roben.

        REGRESSION (WebKit2): HTTP requests time out after 60 seconds
        https://bugs.webkit.org/show_bug.cgi?id=54755
        <rdar://problem/9006592>

WebCore:
        It's now possible to set a default timeout to be used at ResourceRequest creation. If one
        hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
        or use INT_MAX on other platforms).

        * WebCore.exp.in:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of
        default timeout interval (may be 0 if using NSURLRequest default).
        (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable.
        (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource
        request is updated. Plaform code often calls updateResourceRequest() indirectly from this
        function, and that must obviously be a no-op.
        (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite
        direction.
        * platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to
        "defaultTimeoutInterval". It has been used as default by most platforms anyway.
        (WebCore::ResourceRequestBase::ResourceRequestBase):

        * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
        Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither
        setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.

WebKit2:
        * Shared/API/c/WKURLRequest.cpp:
        (WKURLRequestSetDefaultTimeoutInterval):
        * Shared/API/c/WKURLRequest.h:
        Added an API to set a default timeout interval for requests created from URLs. The API
        affects both the UI process and requests created internally by the Web process. Requests
        created from NSURLRequest or CFURLRequest take timeout from those.

        * Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
        * Shared/WebURLRequest.h:
        Pipe the default timeout interval from WKURLRequest down to actual implementation. Since
        WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects
        NSURLRequest default timeout interval.

        * UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
        * UIProcess/WebProcessManager.h:
        Added a way to enumerate all contexts running in separate processes.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        (WebKit::WebContext::ensureWebProcess):
        (WebKit::WebContext::setDefaultRequestTimeoutInterval):
        * UIProcess/WebContext.h:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initializeWebProcess):
        (WebKit::WebProcess::setDefaultRequestTimeoutInterval):
        * WebProcess/WebProcess.h:
        * WebProcess/WebProcess.messages.in:
        Use UI process default timeout interval in separate process contexts, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Add a new use flag for using the CFURLCache.

* wtf/Platform.h:

Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add
    create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.
(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for
    the origin's hostname.
* WebProcess/ResourceCache/WebResourceCacheManager.h:

* WebProcess/ResourceCache/cf: Added.
* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.

* win/WebKit2.vcproj: Added new file.
* WebKit2.xcodeproj/project.pbxproj: Ditto.

WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Update WebKitSystemInterface headers and libraries with new functions.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl

DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.

Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.

When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.

The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.

This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.

This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).

Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.

* WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.

* WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to
match the base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.

Rubber-stamped by Dan Bernstein.

* WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
        https://bugs.webkit.org/show_bug.cgi?id=54895

        Update the results for this test which now includes a few more passing
        lines. We maintain separate results, because we seem to pass more tests
        than other platforms.

        * platform/gtk/Skipped: Unskip a test which is now passing.
        * platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
        https://bugs.webkit.org/show_bug.cgi?id=54895

        Correct the GTK+ clipboard implementation to know that "text" is an alias
        for "text/html" data. This corrects the failing test.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text".
        (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        nrwt: fix typo causing us to try and repeatedly shut down the servers
        https://bugs.webkit.org/show_bug.cgi?id=54904

        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gavin Barraclough.

        Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
        https://bugs.webkit.org/show_bug.cgi?id=54901

        * jit/JIT.h: swap actual and expected values in message, they were
        reversed.
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of
        a simple ASSERT.
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_method_check): ditto.
        (JSC::JIT::compileGetByIdHotPath): ditto.
        (JSC::JIT::compileGetByIdSlowCase): ditto.
        (JSC::JIT::emit_op_put_by_id): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Ruber stamped by Sam Weinig

Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.

Source/JavaScriptCore:

* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):

LayoutTests:

* fast/js/kde/math-expected.txt:
* fast/js/kde/script-tests/math.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Anna Cavender  <annacc@timberline.sea.corp.google.com>

        Reviewed by Eric Carlson.

        new baselines for video-transformed.html on mac
        https://bugs.webkit.org/show_bug.cgi?id=54765

        * platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
        * platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
        * platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
        * platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        ProcessingInstruction should provide a way to know if it is of CSS type.
        https://bugs.webkit.org/show_bug.cgi?id=54868

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        * dom/ProcessingInstruction.h:
        (WebCore::ProcessingInstruction::isCSS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Simon Fraser  <simon.fraser@apple.com>

        Put JSDOMImplementationCustom.cpp where it belongs in the project.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skip
        editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
        https://bugs.webkit.org/show_bug.cgi?id=54895

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.

Reviewed by Sam Weinig.

The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.

Source/JavaScriptCore:

* API/JSCallbackConstructor.cpp:
* API/JSCallbackFunction.cpp:
* API/JSCallbackObjectFunctions.h:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
* runtime/BooleanObject.cpp:
* runtime/DateInstance.cpp:
* runtime/DatePrototype.cpp:
* runtime/ErrorInstance.cpp:
* runtime/InternalFunction.cpp:
* runtime/JSActivation.cpp:
* runtime/JSArray.cpp:
* runtime/JSFunction.cpp:
* runtime/JSONObject.cpp:
* runtime/JSObject.h:
* runtime/JSZombie.h:
* runtime/MathObject.cpp:
* runtime/NativeErrorConstructor.cpp:
* runtime/NumberConstructor.cpp:
* runtime/NumberObject.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.cpp:
* runtime/StringObject.cpp:
* runtime/StringPrototype.cpp:

Source/WebCore:

* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_object.cpp:

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skip new inspector test on wk2.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix radar url.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Csaba Osztrogonác.

        REGRESSION(r79157):
        plugins/get-url-with-javascript-destroying-plugin.html make the
        next test crash
        https://bugs.webkit.org/show_bug.cgi?id=54863

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Skip WebKit2 tests that need EventSender
        https://bugs.webkit.org/show_bug.cgi?id=54890

        These tests fail because EventSender is missing.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

Bug was fixed by http://trac.webkit.org/changeset/79231.

* platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: navigation does not work after reopening frontend.
        https://bugs.webkit.org/show_bug.cgi?id=54879

        Test: http/tests/inspector-enabled/open-close-open.html

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::unmute):
        * inspector/InspectorState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Add results for tests missing results and unskip a test that
        is passing locally and when run manually on the bots.

        * platform/gtk/Skipped: Unskip tests that are now passing.
        * platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
        * platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
        * platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
        * platform/gtk/fast/runin/generated2-expected.checksum: Added.
        * platform/gtk/fast/runin/generated2-expected.png: Added.
        * platform/gtk/fast/runin/generated2-expected.txt: Added.
        * platform/gtk/fast/runin/generated3-expected.checksum: Added.
        * platform/gtk/fast/runin/generated3-expected.png: Added.
        * platform/gtk/fast/runin/generated3-expected.txt: Added.
        * platform/gtk/fast/runin/generated4-expected.checksum: Added.
        * platform/gtk/fast/runin/generated4-expected.png: Added.
        * platform/gtk/fast/runin/generated4-expected.txt: Added.
        * platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
        * platform/gtk/media/video-aspect-ratio-expected.png: Added.
        * platform/gtk/media/video-aspect-ratio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed added more tests with pixel differences between bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Protect the PluginView when evaluating javascript: URLs

Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added

Reviewed by Sam Weinig.

* plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Fix GTK+ build after r79223.

        * GNUmakefile.am: Add file missing from the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-14  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: audits should not warn about gzip compression for 304s
        https://bugs.webkit.org/show_bug.cgi?id=54343

        Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.GzipRule.prototype._isCompressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed expectations change to mark tests as timing out.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.

Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Another followup to 79223: correct QT project file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Followup to 79223: forgotten file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement WorkQueue::sheduleWorkAfterDelay
        https://bugs.webkit.org/show_bug.cgi?id=54878

        * Platform/qt/WorkQueueQt.cpp:
        (WorkQueue::scheduleWorkAfterDelay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-08  Anton Muhin  <antonm@chromium.org>

       Reviewed by Adam Barth and Alexey Proskuryakov.

       Propagate security origin of parent document into HTML documents created with DOMImplementation
       https://bugs.webkit.org/show_bug.cgi?id=53611

       This restores invariant that JS wrappers residing in the same JS context should come
       from the same security origin.

       Absence of regressions is covered by the current tests.  Different security origin of
       DOMImplementation is difficult to check with layout tests as DOMImplementation
       resides in the same JS context as parent document and therefore there are no security origin checks.
       This is observable however in C++.

       * Android.jscbindings.mk:
       * CMakeLists.txt:
       * WebCore.gypi:
       * WebCore.pro:
       * WebCore.vcproj/WebCore.vcproj:
       * WebCore.xcodeproj/project.pbxproj:
       * bindings/v8/V8GCController.cpp:
       (WebCore::NodeGrouperVisitor::visitDOMWrapper):
       * dom/DOMImplementation.cpp:
       (WebCore::DOMImplementation::DOMImplementation):
       (WebCore::DOMImplementation::createDocument):
       * dom/DOMImplementation.h:
       (WebCore::DOMImplementation::create):
       (WebCore::DOMImplementation::documentDestroyed):
       (WebCore::DOMImplementation::parentDocument):
       * dom/DOMImplementation.idl:
       * dom/Document.cpp:
       (WebCore::Document::~Document):
       (WebCore::Document::implementation):
       * dom/Document.h:
2011-02-21  Anton Muhin  <antonm@chromium.org>

       Reviewed by Adam Barth and Alexey Proskuryakov.

       Propagate security origin of parent document into HTML documents created with DOMImplementation
       https://bugs.webkit.org/show_bug.cgi?id=53611

       Additional test which checks case when parent document can be collected while
       its implementation is alive.

       * fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Export JSObject::s_info from JavaScriptCore.dll

This matches what we do for all other ClassInfo objects that WebCore needs access to.

Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows

Reviewed by Sam Weinig.

* runtime/JSObject.h: Added JS_EXPORTDATA to s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Optimize editing updates in gutter panel
        https://bugs.webkit.org/show_bug.cgi?id=54866

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.set startEditingListener):
        (WebInspector.TextViewer.prototype.set endEditingListener):
        (WebInspector.TextViewer.prototype.endUpdates):
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
        (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixed the change log entry for r79219.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/audits/audits-panel-functional-expected.txt:
        * inspector/audits/audits-panel-functional.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/audits/audits-panel-functional-expected.txt:
        * inspector/audits/audits-panel-functional.html:
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: create and destroy DOM agent along with InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=54875

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve
        on this object.
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::~InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
        (WebCore::InstrumentingAgents::inspectorConsoleAgent):
        (WebCore::InstrumentingAgents::setInspectorConsoleAgent):
        (WebCore::InstrumentingAgents::inspectorDOMAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMAgent):
        (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
        (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
        (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
        (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
        (WebCore::InstrumentingAgents::inspectorProfilerAgent):
        (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
        (WebCore::InstrumentingAgents::inspectorResourceAgent):
        (WebCore::InstrumentingAgents::setInspectorResourceAgent):
        (WebCore::InstrumentingAgents::inspectorRuntimeAgent):
        (WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
        (WebCore::InstrumentingAgents::inspectorStorageAgent):
        (WebCore::InstrumentingAgents::setInspectorStorageAgent):
        (WebCore::InstrumentingAgents::inspectorTimelineAgent):
        (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        (WebCore::InspectorAgent::loadEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::InspectorCSSAgent):
        (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::clearFrontend):
        (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached.
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end
        is attached.
        (WebCore::InspectorDOMAgent::clearFrontend):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79029.
        http://trac.webkit.org/changeset/79029
        https://bugs.webkit.org/show_bug.cgi?id=54869

        Revert unnecessary Chromium rebaseline (Requested by apavlov
        on #webkit).

        * platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [REGRESSION] After r79130, spell tests did not work
        https://bugs.webkit.org/show_bug.cgi?id=54860

        * WebCoreSupport/TextCheckerClientEnchant.cpp:
        (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided
        freeing the default PangoLanguage.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings): Initialized list of dictionaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Remove incorrect Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Switched to compiler based detection, where the error actually is.

        It is not the platform that needs the workaround, it is the compiler.

        QtWebKit fails to compile on Windows XP with msvc-2008
        https://bugs.webkit.org/show_bug.cgi?id=54746

        * bytecode/CodeBlock.h:
        * runtime/RegExpObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871

Reviewed by Andreas Kling.

* bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Mihai Parparita.

        [V8] SerializedScriptValue: fix JS exception handling.
        https://bugs.webkit.org/show_bug.cgi?id=54555

        Added checks for exceptions and empty handles:
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::Serializer::Serializer):
        (WebCore::Serializer::serialize):
        (WebCore::Serializer::checkException):
        (WebCore::Serializer::reportFailure):
        (WebCore::Serializer::ArrayState::advance):
        (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
        (WebCore::Serializer::AbstractObjectState::advance):
        (WebCore::Serializer::push):
        (WebCore::Serializer::handleError):
        (WebCore::Serializer::newObjectState):
        (WebCore::Serializer::doSerialize):
        (WebCore::SerializedScriptValue::SerializedScriptValue):

2011-02-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Mihai Parparita.

        [V8] SerializedScriptValue: fix JS exception handling.
        https://bugs.webkit.org/show_bug.cgi?id=54555

        Added an exception throwing test case:
        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Add selectionchange event
        https://bugs.webkit.org/show_bug.cgi?id=45712

        Added a test to ensure WebKit fires selectionchange event for the correct document
        when the document has an iframe, and a test to ensure selectionchange events are fired
        on user-initiated events.

        * fast/events/selectionchange-iframe-expected.txt: Added.
        * fast/events/selectionchange-iframe.html: Added.
        * fast/events/selectionchange-user-initiated-expected.txt: Added.
        * fast/events/selectionchange-user-initiated.html: Added.
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Add selectionchange event
        https://bugs.webkit.org/show_bug.cgi?id=45712

        Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
        This event is not cancelable and does not bubble. An event listener can be attached to a document by
        body element's onselectionchange attribute or via document's onselectionchange property.

        Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
        fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
        will not observe the event before the control returns to JavaScript.

        See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx

        Tests: fast/events/selectionchange-iframe.html
               fast/events/selectionchange-user-initiated.html

        * dom/Document.cpp:
        (WebCore::Document::enqueueDocumentEvent): Added.
        * dom/Document.h: Added selectionchange event listener.
        * dom/Document.idl: Added onselectionchagne attribute.
        * dom/EventNames.h: Added selectionchange
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Fires selectionchange event.
        * html/HTMLAttributeNames.in: Added onselectionchange.
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

* platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html
and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=54859

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
        https://bugs.webkit.org/show_bug.cgi?id=54638

        * http/tests/inspector/change-iframe-src.html:
        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
        (initialize_DebuggerTest.InspectorTest.waitUntilPaused):
        (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1):
        (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack):
        (initialize_DebuggerTest.InspectorTest.waitUntilResumed):
        (initialize_DebuggerTest.InspectorTest.resumeExecution):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        (initialize_DebuggerTest.InspectorTest._showScriptSource):
        (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath):
        (initialize_DebuggerTest.InspectorTest.expandProperties):
        * http/tests/inspector/elements-test.js:
        (initialize_ElementTest.InspectorTest.nodeWithId.processChildren):
        (initialize_ElementTest.InspectorTest.nodeWithId):
        (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback):
        (initialize_ElementTest.InspectorTest.selectNodeWithId):
        (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback):
        (initialize_ElementTest.InspectorTest.expandElementsTree):
        (initialize_ElementTest):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
        (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInPage):
        (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
        (initialize_InspectorTest.InspectorTest.reloadPage):
        (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):
        (initialize_InspectorTest.InspectorTest.runTestSuite.runner):
        (initialize_InspectorTest.InspectorTest.runTestSuite):
        (initialize_InspectorTest.InspectorTest.safeWrap):
        * http/tests/inspector/resource-parameters.html:
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/debugger/dom-breakpoints-expected.txt:
        * inspector/debugger/dom-breakpoints.html:
        * inspector/extensions/extensions-audits-tests.js:
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
        (initialize_ExtensionsAuditsTest):
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: generate protocol documentation based on IDL.
        https://bugs.webkit.org/show_bug.cgi?id=54822

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Fixed typo in gtk Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
https://bugs.webkit.org/show_bug.cgi?id=54863

Paper over one more regression to make Qt buildbot happy and green.

* platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-18  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
        https://bugs.webkit.org/show_bug.cgi?id=54747

        * media/audio-delete-while-slider-thumb-clicked.html: Autoplay the
        media element and trigger the seek after playback started.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Andoni Morales Alastruey  <amorales@flumotion.com>

        Reviewed by Martin Robinson.

        [GStreamer] Add URI queries support in webkitwebsrc
        https://bugs.webkit.org/show_bug.cgi?id=54627

        This allow replying to URI queries from downstream elements
        with the uri currently set in the source element.

        No new tests, this feature is dedicated to internal GStreamer use,
        such as the upcoming HTTP Live Streaming element.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.

* platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
* platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
* platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
* platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  Andoni Morales Alastruey  <amorales@flumotion.com>

        Reviewed by Martin Robinson.

        [GStreamer] Add 'location' property in webkitwebsrc
        https://bugs.webkit.org/show_bug.cgi?id=54628

        No new tests, this feature is dedicated to internal GStreamer use,
        such as the upcoming HTTP Live Streaming element.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webkit_web_src_class_init):
        (webKitWebSrcSetProperty):
        (webKitWebSrcGetProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode().

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node().
        (WebKit::WebViewImpl::confirmComposition): Ditto.
        (WebKit::WebViewImpl::textInputType):
        (WebKit::WebViewImpl::caretOrSelectionBounds):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Replaced the call to node() by a call to containerNode() because the returned node is
        used to determine whether or not the selected contents are editable and such a check
        must be done against the container node.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode().

        * webkit/webkitwebview.cpp:
        (webkit_web_view_popup_menu_handler):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Replaced the call to node() by a call to containerNode() because the returned node is
        used to determine whether or not the selected contents are editable and such a check
        must be done against the container node.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
        calls were of the form node()->document() and node()->inDocument() in which case they were
        replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.

        * WebCore.exp.in: Added Position::containerNode.

        The rest abbreviated for simplicity. Please see svn log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21 MORITA Hajime  <morrita@google.com>

        Another unreviewed attempt to expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add WebResourceCacheDataManager to the compilation after r78848
        https://bugs.webkit.org/show_bug.cgi?id=54732

        Added resource cache manager API to GTK+ compilation after r78848.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update. (Removes invalid lines.)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20 MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-16  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        keyboard support for extending/shrinking comment context
        https://bugs.webkit.org/show_bug.cgi?id=54612

        ctrl+shift+up/down will extend/shrink the comment context when
        a comment is focused or when one is being edited.

        Also, switch over to using keydown instead of keypress events.
        This lets us share code for handling escape and other key events.
        Also, keypress is evil and should die.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Recommit accidental revert.
        r79180 accidentally revereted r79178.
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] add more help information
        https://bugs.webkit.org/show_bug.cgi?id=54847

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] use 'r' to focus the review select element
        https://bugs.webkit.org/show_bug.cgi?id=54845

        This allows for quick keyboard access to the toolbar items.
        Hit r to get to the review select element. Then you can
        tab to the cq/preview/publish elements.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] don't let lines/diffblocks be mouse focusable
        https://bugs.webkit.org/show_bug.cgi?id=54851

        Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
        is committed. In the interim, it won't break anything.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] use keydown instead of keypress
        https://bugs.webkit.org/show_bug.cgi?id=54849

        There is no functional change. This is just a cleanup
        to make future patches (e.g. https://bugs.webkit.org/show_bug.cgi?id=54612)
        cleaner.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] fix layout nit
        https://bugs.webkit.org/show_bug.cgi?id=54848

        There is occasionally an off-by-one in the 50% width
        calculation. This ensures that the add lines always
        line up with the shared context lines.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        test-webkitpy: stop skipping a bunch of tests on win32
        https://bugs.webkit.org/show_bug.cgi?id=54788

        * Scripts/webkitpy/common/net/testoutputset_unittest.py:
        * Scripts/webkitpy/test/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] make escape hide the preview form
        https://bugs.webkit.org/show_bug.cgi?id=54844

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Build fix (remove includes).

* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSLocationCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] make enter work when an individual line is focused
        https://bugs.webkit.org/show_bug.cgi?id=54843

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.

Reviewed by Oliver Hunt.

Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.

NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.

GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.

Source/JavaScriptCore:

* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
    Removed symbols / references to files.

* runtime/GlobalEvalFunction.cpp: Removed.
* runtime/GlobalEvalFunction.h: Removed.
* runtime/NativeFunctionWrapper.h: Removed.
* runtime/PrototypeFunction.cpp: Removed.
* runtime/PrototypeFunction.h: Removed.
    Removed.

* runtime/Executable.cpp:
(JSC::NativeExecutable::~NativeExecutable):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):
* runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
    Added interpreter-friendly constructors for NativeExecutables.

* bytecompiler/BytecodeGenerator.cpp:
* interpreter/Interpreter.cpp:
* jit/JITStubs.cpp:
* jsc.cpp:
* runtime/ArrayConstructor.cpp:
* runtime/BooleanPrototype.cpp:
* runtime/BooleanPrototype.h:
* runtime/CallData.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/ErrorPrototype.cpp:
* runtime/ErrorPrototype.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/Lookup.cpp:
* runtime/NumberPrototype.cpp:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpPrototype.cpp:
* runtime/RegExpPrototype.h:
* runtime/SmallStrings.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
    Removed use of redundant classes.

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
    Removed use of redundant classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Fix various bugs related to handling of dir separators and real
        vs. fake filesystems that were causing test-webkitpy to fail
        tests on win32. These bugs have a variety of causes but are
        lumped together because they should be easy to review.

        https://bugs.webkit.org/show_bug.cgi?id=54700

        * Scripts/webkitpy/common/net/testoutput.py:
          Here we were using os.path.sep but not escaping it prior to
          using in a regexp, which  caused bad things on win32.
        * Scripts/webkitpy/common/net/testoutput_unittest.py:
          Same here.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
          Here we were using the native filesystem instead of the mock
          filesystem, making some tests unnecessarily platform dependent.
          Also we weren't setting the default configuration for the
          TestChromiumWinPort.
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
          Here we *shouldn't* use os.path.join(), just so the code becomes
          less platform dependent.
        * Scripts/webkitpy/style/checker.py:
          Here we should be using os.path.sep instead of "/"; the tests
          require the native filesystem.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
          Here the underlying code is using os.path.sep, so we probably
          should as well.
        * Scripts/webkitpy/style/test_expectations_unittest.py:
          Here we should be using the filesystem hanging of the port
          object (which is the mocked filesystem) rather than the native
          one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79169.
        http://trac.webkit.org/changeset/79169
        https://bugs.webkit.org/show_bug.cgi?id=54846

        Made unexpected results for tests without CJK characters
        (Requested by tkent on #webkit).

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
        (WebCore::FontPlatformData::orientation):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
        https://bugs.webkit.org/show_bug.cgi?id=54842

        Fix style errors in ewk files.

        * ewk/ewk_tiled_backing_store.h:
        * ewk/ewk_tiled_matrix.h:
        * ewk/ewk_tiled_model.h:
        * ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>

Reviewed by Dan Bernstein.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Chun-Lung Huang  <alvincl.huang@gmail.com>

        Reviewed by Kent Tamura.

        On Chromium Windows, glyphs in vertical text tests are rotated 90
        degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450

        This platform dependent patch makes Chromium Windows show the
        vertical writing text correctly. Job was done by adding a prefix '@'
        in front of the font family name (Windows Only). No new tests added.

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
        (WebCore::FontPlatformData::orientation):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dirk Schulze.

        REGRESSION (r73369-r73405): transform animation interpolates incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=54793

        After the refactoring in r73380, the ending state for some types of
        accelerated animations was computed incorrectly, because the TransformationMatrix
        wasn't reset to identity before the ending value transformations were applied.

        Fix by cleaning up the code to use explicit, separate values for
        starting and ending values. Only matrix-type animations had this
        issue, but cleaned up other clauses similarly.

        Test: animations/3d/matrix-transform-type-animation.html

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/frames/iframe-scale-applied-twice.html

* page/FrameView.cpp:
(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.
* platform/ScrollView.h:
(WebCore::ScrollView::boundsSize): Added this getter.
* platform/Widget.h:
(WebCore::Widget::resize): Set the bounds size to the frame size.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.

LayoutTests:

* fast/frames/iframe-scale-applied-twice-expected.txt: Added.
* fast/frames/iframe-scale-applied-twice.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        use shift+j/k to focus next/previous line
        https://bugs.webkit.org/show_bug.cgi?id=54723

        Tested on a large Hyatt change to confirm it performed fine.
        (https://bugs.webkit.org/attachment.cgi?id=82533&action=review)

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix escape handling in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54722

        This broke with http://trac.webkit.org/changeset/78948.
        Apparently jquery events get a wrapped object that
        does not expose keyIdentifier.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        create comments when hitting enter with a focused diff
        https://bugs.webkit.org/show_bug.cgi?id=54719

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        use actual browser focus in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54726

        This makes keyboard handling play better with focusable element
        (i.e. links/textareas/buttons). Also, in theory, this makes
        the review tool more amenable to screen readers (I think).

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Ami Fischman  <fischman@chromium.org>

        Reviewed by Kent Tamura.

        Remove flakiness from media/video-poster.html by using event callbacks
        instead of 100ms timeouts and hoping that states have transitioned in
        time (!).
        Removed seemingly-outdated BUG_DRT annotation from test_expectation.

        https://bugs.webkit.org/show_bug.cgi?id=54685
        http://crbug.com/60845

        * media/video-poster.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-21 Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Make editing/selection/extend-selection tests more human readable and hand-runnable
        https://bugs.webkit.org/show_bug.cgi?id=54712

        Three changes to achieve this:
          - Column-align the "right:", "left:", "forward:", and "backward:" labels in the output.
          - Add buttons to switch between LTR and RTL (the test will switch everything to RTL but LTR is useful).
          - Fix typo causing failing tests to have a js error (rather than layout error).

        Expected results need to change due to column alignment.

        * editing/selection/extend-selection-character-expected.txt:
        * editing/selection/extend-selection-word-expected.txt:
        * editing/selection/resources/extend-selection.js:
        (logMismatchingPositions):
        (runSelectionTestsWithGranularity):
        (getTestNodeContainer.createButton.button.onmousedown):
        (getTestNodeContainer.createButton):
        (getTestNodeContainer.createButtonToSwitchDirection):
        (getTestNodeContainer):
        (createNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Eric Seidel.

        Tighten up access permissions by using libxslt API
        https://bugs.webkit.org/show_bug.cgi?id=52688
        <rdar://problem/8909191>

        * xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only
        interested in a string result, so let libxslt know about that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79104.
        http://trac.webkit.org/changeset/79104
        https://bugs.webkit.org/show_bug.cgi?id=54835

        Might have caused flaky canaries (Requested by tonyg-cr on
        #webkit).

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::canTakeNextToken):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::isLayoutTimerActive):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash when a plug-in requests a javascript: url that destroys the plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54837
        <rdar://problem/9005475>

        Add new plug-in test.

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
        (PluginTest::NPN_GetURL):
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
        * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
        (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
        (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash when a plug-in requests a javascript: url that destroys the plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54837
        <rdar://problem/9005475>

        Add test.

        * plugins/get-url-with-javascript-destroying-plugin-expected.txt: Added.
        * plugins/get-url-with-javascript-destroying-plugin.html: Added.
2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash when a plug-in requests a javascript: url that destroys the plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54837
        <rdar://problem/9005475>

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::destroy):
        Null out m_pluginController.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performJavaScriptURLRequest):
        Don't access the frame through m_pluginElement since it will be nulled out
        when the plug-in is destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix another crash when a plug-in is destroyed when evaluating JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=54834
        <rdar://problem/9013384>

        This contains three separate fixes:

        - In unprotectPluginFromDestruction we can't just destroy the plug-in once
          the count reaches zero, because the plug-in might still have code executing
          on the stack. To fix this we use a zero-delay timer to defer destruction
          of the plug-in.

        - Trying to get the NPObject for the window using NPN_GetValue would return
          NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return
          NPERR_GENERIC_ERROR instead.

        - Protect the plug-in from destruction anytime an NPAPI call that sends a
          synchronous IPC message is made.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::PluginControllerProxy):
        (WebKit::PluginControllerProxy::destroy):
        (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
        * PluginProcess/PluginControllerProxy.h:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::PluginDestructionProtector::PluginDestructionProtector):
        (WebKit::NPN_GetValue):
        (WebKit::NPN_Evaluate):
        (WebKit::NPN_GetProperty):
        (WebKit::NPN_SetProperty):
        (WebKit::NPN_RemoveProperty):
        (WebKit::NPN_HasProperty):
        (WebKit::NPN_HasMethod):
        (WebKit::NPN_Enumerate):
        (WebKit::NPN_Construct):
        (WebKit::NPN_GetValueForURL):
        (WebKit::NPN_SetValueForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79156 268f45cc-cd09-0410-ab3c-d52691b4dbfc