zecke@webkit.org [Mon, 3 Dec 2007 10:33:20 +0000 (10:33 +0000)]
2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Rubber stamped by Sam Weinig.
Fix a typo. It is contains and not containts
* loader/FrameLoader.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 3 Dec 2007 09:25:45 +0000 (09:25 +0000)]
2007-12-03 Mark Rowe <mrowe@apple.com>
Speculative Windows build fix.
* WebScriptCallFrame.cpp:
(WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 3 Dec 2007 09:19:26 +0000 (09:19 +0000)]
2007-12-03 Mark Rowe <mrowe@apple.com>
wx build fix.
* WebView.cpp:
(wxWebView::RunScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 3 Dec 2007 09:10:04 +0000 (09:10 +0000)]
Reviewed by Oliver.
Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
in a more fine-grained manner than eventSender.keyDown().
* DumpRenderTree/win/EventSender.cpp:
(getConstantCallback):
(dispatchMessageCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 3 Dec 2007 09:05:06 +0000 (09:05 +0000)]
Another speculative Windows build fix
* WebScriptCallFrame.cpp:
(WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 3 Dec 2007 08:58:06 +0000 (08:58 +0000)]
2007-12-03 Alp Toker <alp@atoker.com>
Add another missing DEPENDPATH.
Noticed when fixing the build.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 3 Dec 2007 08:52:44 +0000 (08:52 +0000)]
Speculative Windows build fix
* plugins/win/PluginViewWin.cpp:
(WebCore::getString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 3 Dec 2007 08:43:56 +0000 (08:43 +0000)]
Speculative Windows build fix
* WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
* WebScriptDebugger.cpp:
(WebScriptDebugger::WebScriptDebugger):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 3 Dec 2007 08:13:00 +0000 (08:13 +0000)]
Removed unnecessary and possibly incorrect #include from my last
check-in.
* Api/qwebframe.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 3 Dec 2007 08:10:06 +0000 (08:10 +0000)]
GTK Build fix: get globalExec from the right place.
* WebView/webkitwebframe.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 3 Dec 2007 08:06:50 +0000 (08:06 +0000)]
Qt build fix: Get globalExec() from the right place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 3 Dec 2007 08:02:04 +0000 (08:02 +0000)]
Build fix: added symbols to the right .exp file.
* WebCore.base.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 3 Dec 2007 07:53:03 +0000 (07:53 +0000)]
Build fix: added an #include.
* kjs/collector.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 3 Dec 2007 07:43:29 +0000 (07:43 +0000)]
JavaScriptCore:
Reviewed by Eric Seidel.
Second step in refactoring JSGlobalObject: moved virtual functions from
Interpreter to JSGlobalObject.
Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
believe his lies.
JavaScriptGlue:
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
* JSRun.cpp:
* JSRun.h:
* JSValueWrapper.cpp:
(getThreadGlobalExecState):
* JavaScriptGlue.cpp:
(JSRunCopyGlobalObject):
(JSRunEvaluate):
WebCore:
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
Moved virtual ScriptInterpreter functions to Window.
WebKit/mac:
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
* WebView/WebFrame.mm:
(-[WebFrame globalContext]): Use the toRef function instead of manually
casting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 3 Dec 2007 04:57:59 +0000 (04:57 +0000)]
WebCore:
Reviewed by Mitz.
- fix <rdar://problem/
5601995> Hang/crash on http://ebay-uk.custhelp.com/
There were two problems here:
1) Incorrect HTMLCollection behavior led to us trying to insert a
new row inside an existing row instead of next to it. The fix for
this is to make HTMLCollection work better for table-related
collections.
2) HTMLTableRowElement::insertCell would return a bad pointer if
the insertion failed. The code should have failed, but not crashed,
so it's worth fixing that too.
While fixing the HTMLCollection issues, I did some clean-up of that
class and its derived classes.
Test: fast/dom/HTMLTableElement/rows.html
Test: fast/dom/HTMLTableElement/tBodies.html
Test: fast/dom/HTMLTableRowElement/cells.html
Test: fast/dom/HTMLTableRowElement/insertCell.html
Test: fast/dom/HTMLTableSectionElement/rows.html
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS): Updated because collectionType() was renamed to type().
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection): Updated for data member name
changes. Also added a protected constructor for use by derived classes
that pass in a CollectionInfo.
(WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of
the header.
(WebCore::isTableSection): Added.
(WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem,
because the old name was grammatically incorrect and thus a bit confusing.
Changed to operate on Element* instead of Node*, and use 0 to start
rather than passing in the base node (required since the base node can be
a document, which is not an element). Generalized the code that made
NodeChildren not descend into deeper descendants so it can be used for
TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the
switch statement and got rid of the "found" boolean since we can just
return when we find something. Got rid of the default case, and instead
listed all the enum values. Also changed to use a for loop for clarity.
(WebCore::HTMLCollection::calcLength): Updated for itemAfter changes.
(WebCore::HTMLCollection::item): Ditto.
(WebCore::HTMLCollection::nextItem): Ditto.
(WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element
instead of a Node pointer.
(WebCore::HTMLCollection::namedItem): More of the same.
(WebCore::HTMLCollection::updateNameCache): Ditto.
(WebCore::HTMLCollection::namedItems): Ditto.
(WebCore::HTMLCollection::nextNamedItem): Ditto.
(WebCore::HTMLCollection::tags): Ditto.
* html/HTMLCollection.h: Added a type FormElements, so that the
HTMLFormCollection would not have a type of DocImages, which is what
it previously did. Changed the base parameter to be a PassRefPtr to
make it clear we take ownership of it. Added a comment explaining
why we should change the name CollectionInfo. Made a lot more members
private instead of protected. Renamed traverseNextItem to itemAfter.
Changed most functions to take Element* instead of Node*.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::formCollectionInfo): Added.
(WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass
collection info into the base class.
(WebCore::HTMLFormCollection::calcLength): Updated to use base() so we
don't need to get at m_base directly.
(WebCore::HTMLFormCollection::item): Same, but for info().
(WebCore::HTMLFormCollection::getNamedItem): Removed unused first
argument.
(WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded
checks that the base is still an element and still a form, since that's
guaranteed.
(WebCore::HTMLFormCollection::nextItem): Use info().
(WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of
Element, some name changes.
(WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere.
(WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop
to be much simpler.
(WebCore::HTMLFormCollection::updateNameCache): More of the same.
* html/HTMLFormCollection.h: Changed constructor to take an
HTMLFormElement, using a PassRefPtr to communicate transfer of
ownership. Made everything private instead of protected. Removed
unneeded override of firstItem. Made getNamedItem and
nextNamedItemInternal non-virtual. Removed unused first argument of
getNamedItem. Added declaration of formCollectionInfo.
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass
collection info into the base class.
(WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and
changed into a for loop.
* html/HTMLNameCollection.h: Updated for name changes. Made function
private instead of public. Used PassRefPtr in constructor.
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to
pass collection info into the base class.
(WebCore::HTMLOptionsCollection::add): Updated for public/private
changes in the base class.
(WebCore::HTMLOptionsCollection::selectedIndex): Ditto.
(WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto.
(WebCore::HTMLOptionsCollection::setLength): Ditto.
* html/HTMLOptionsCollection.h: Changed constructor parameter to be a
PassRefPtr.
* html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr
and PassRefPtr since this creates a new object. This alone fixed the
crash. Also cleaned up logic a bit to be more readable.
* html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr.
Also reordered functions a bit to make things a little more logical and
removed the unused ncols data member.
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not
TableRows. This mistake was harmless before because TableRows and
TSectionRows were handled identically inside HTMLCollection, but that is
no longer the case with this fix.
* bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the
fact that HTMLOptionsCollection no longer includes HTMLOptionElement.
I don't think this really should be a special case -- might be worth
returning later to see if this can be optimized.
LayoutTests:
Reviewed by Mitz.
- tests for table-related HTMLCollection classes for misnested
tables and for <rdar://problem/
5601995> Hang/crash on http://ebay-uk.custhelp.com/
* fast/dom/HTMLTableElement/resources: Added.
* fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
* fast/dom/HTMLTableElement/resources/rows.js: Added.
* fast/dom/HTMLTableElement/resources/tBodies.js: Added.
* fast/dom/HTMLTableElement/rows-expected.txt: Added.
* fast/dom/HTMLTableElement/rows.html: Added.
* fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
* fast/dom/HTMLTableElement/tBodies.html: Added.
* fast/dom/HTMLTableRowElement: Added.
* fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
* fast/dom/HTMLTableRowElement/cells.html: Added.
* fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
* fast/dom/HTMLTableRowElement/insertCell.html: Added.
* fast/dom/HTMLTableRowElement/resources: Added.
* fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
* fast/dom/HTMLTableRowElement/resources/cells.js: Added.
* fast/dom/HTMLTableSectionElement: Added.
* fast/dom/HTMLTableSectionElement/resources: Added.
* fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
* fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
* fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
* fast/dom/HTMLTableSectionElement/rows.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 3 Dec 2007 04:41:08 +0000 (04:41 +0000)]
* Scripts/do-webcore-rename: More planned renaming.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 3 Dec 2007 01:05:25 +0000 (01:05 +0000)]
Reviewed by Adam.
RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.
Fixes:
- svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
- svg/custom/deep-dynamic-updates.svg
- svg/custom/use-clipped-hit.svg
- svg/custom/image-clipped-hit.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 2 Dec 2007 23:40:21 +0000 (23:40 +0000)]
Rubber stamped by Anders.
Use [NSURL absoluteString] instead of [NSURL description] in order to get
more uniform results cross platform.
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSURL _drt_descriptionSuitableForTestResult]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 2 Dec 2007 23:32:42 +0000 (23:32 +0000)]
Rubber stamped by Niko.
Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
* DumpRenderTree/win/DumpRenderTree.cpp:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
* DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
* DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
* DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sun, 2 Dec 2007 20:20:07 +0000 (20:20 +0000)]
Reviewed by Darin
databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
like all other notifications we send out!
* platform/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
* platform/SecurityOriginData.h:
* storage/DatabaseTracker.cpp:
(WebCore::notificationMutex):
(WebCore::notificationQueue):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue
(WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications
on the main thread
(WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
* storage/DatabaseTracker.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!"
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sun, 2 Dec 2007 19:32:59 +0000 (19:32 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16002
Load SVG (and other) UA StyleSheets dynamically when needed
Load svg sheet when needed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 2 Dec 2007 12:59:21 +0000 (12:59 +0000)]
Speculative Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sun, 2 Dec 2007 12:02:50 +0000 (12:02 +0000)]
Rubber stamped by Eric.
Move platform/graphics/svg to graphics/svg as discussed on webkit-dev.
Updated all project files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sun, 2 Dec 2007 11:22:34 +0000 (11:22 +0000)]
Reviewed by Maciej.
Fix IDL lookup in subdirectories. Missing 'my' prefix for the 'thisDir' variable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sun, 2 Dec 2007 08:32:09 +0000 (08:32 +0000)]
Add another screenshot
* blog-files/InspectElementMenu.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 2 Dec 2007 08:16:48 +0000 (08:16 +0000)]
2007-12-01 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which
takes care of extern "C".
Introduce a webkit.h convenience header.
Remove another left-over from the old API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sun, 2 Dec 2007 08:07:22 +0000 (08:07 +0000)]
Add some Inspector screenshots for an upcoming blog post
Rubberstamped by Mark Rowe.
* blog-files/InspectorCSSEditing.png: Added.
* blog-files/InspectorFonts.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sun, 2 Dec 2007 07:56:42 +0000 (07:56 +0000)]
Reviewed by Tim
Added a default database quota of 5mb to the default WebPreferences
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 2 Dec 2007 06:43:36 +0000 (06:43 +0000)]
2007-12-01 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15687
[Gtk] Allow API clients to interact with JavaScript in web pages
Include the necessary JavaScriptCore headers directly in the public
API headers.
This is the last of a series of changes needed to allow GTK+
applications to access the JS API.
Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
developers will still have to include the individual JS API headers
individually if they want to use it in their applications.
Patch also removes some old legacy use of GDK that was in
WebKitWebFrame. No ABI change.
* WebView/webkitdefines.h:
* WebView/webkitwebframe.h:
* WebView/webkitwebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 2 Dec 2007 06:14:18 +0000 (06:14 +0000)]
WebCore:
Reviewed by Adam.
- Fix a crash when removing a loading media element from the tree.
- Follow the spec by invoking pause() when element is removed from the tree instead of unloading.
Tests: http/tests/media/remove-while-loading.html
media/remove-from-document.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFromDocument):
LayoutTests:
Reviewed by Adam.
Test that removing a media element when it is loading does not crash.
Test that media is paused when it is removed from the tree.
* http/tests/media/remove-while-loading-expected.txt: Added.
* http/tests/media/remove-while-loading.html: Added.
* media/remove-from-document-expected.txt: Added.
* media/remove-from-document.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 2 Dec 2007 05:24:25 +0000 (05:24 +0000)]
2007-12-01 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT
Add JS_EXPORT to kJSClassDefinitionEmpty.
Make the gcc compiler check take precedence over the WIN32||_WIN32
check to ensure that symbols are exported on Windows when using gcc.
Add a TODO referencing the bug about JS_EXPORT in the Win build
(http://bugs.webkit.org/show_bug.cgi?id=16227)
Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:
extern extern const JSClassDefinition kJSClassDefinitionEmpty;
(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)
* API/JSBase.h:
* API/JSObjectRef.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 1 Dec 2007 23:59:11 +0000 (23:59 +0000)]
Reviewed by Beth Dakin.
Restored the test string in this test.
* manual-tests/window-open-features-parsing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 1 Dec 2007 23:56:56 +0000 (23:56 +0000)]
JavaScriptCore:
Reviewed by Beth Dakin.
Reversed the ownership relationship between Interpreter and JSGlobalObject.
Now, the JSGlobalObject owns the Interpreter, and top-level objects
that need the two to persist just protect the JSGlobalObject from GC.
Global object bootstrapping looks a little odd right now, but it will
make much more sense soon, after further rounds of refactoring.
* bindings/runtime_root.h: Made this class inherit from RefCounted,
to avoid code duplication.
* kjs/collector.cpp:
(KJS::Collector::collect): No need to give special GC treatment to
Interpreters, since we mark their global objects, which mark them.
* kjs/interpreter.cpp:
(KJS::Interpreter::mark): No need to mark our global object, since it
marks us.
* kjs/interpreter.h: Don't inherit from RefCounted -- JSGlobalObject
owns us directly.
* kjs/testkjs.cpp: Modified to follow the new rules.
(createGlobalObject):
(runWithScripts):
JavaScriptGlue:
Reviewed by Beth Dakin.
Modified to follow new JSGlobalObject/Interpreter ownership rules
in JavaScriptCore.
* JSRun.cpp:
(JSRun::JSRun):
(JSRun::GetInterpreter):
(JSRun::Evaluate):
(JSRun::CheckSyntax):
* JSRun.h:
* JSValueWrapper.cpp:
(unprotectGlobalObject):
(initializeGlobalObjectKey):
(getThreadGlobalExecState):
WebCore:
Reviewed by Beth Dakin.
Modified WebCore to follow the new JSGlobalObject/Interpreter ownership
rules in JavaScriptCore.
* bindings/js/kjs_binding.cpp:
* bindings/js/kjs_binding.h: Removed stale, unused
interpreterForGlobalObject().
* bindings/js/kjs_proxy.cpp: Changed to store a global object, rather
than an interpreter.
(WebCore::KJSProxy::finishedWithEvent): Need to NULL check
m_globalObject here because we no longer unnecessarily instantiate it.
* bindings/js/kjs_window.cpp:
(KJS::ScheduledAction::execute):
* bindings/js/kjs_window.h: Removed redundant and less efficient
interpreter() function -- global objects have direct access to their
interpreters now.
Changed these functions to pass around JSGlobalObjects instead of
Interpreters:
* page/Frame.cpp:
(WebCore::Frame::bindingRootObject):
(WebCore::Frame::createRootObject):
* page/Frame.h:
* page/mac/WebCoreFrameBridge.mm:
(createRootObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 1 Dec 2007 23:35:19 +0000 (23:35 +0000)]
* Check to see if the directory exists and exit if not.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 1 Dec 2007 22:29:46 +0000 (22:29 +0000)]
Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.
Rubber stamped by Adam Roben.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::selectionRect):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 1 Dec 2007 22:15:54 +0000 (22:15 +0000)]
Reviewed by Mark Rowe.
* config.ini: Correct blog name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 1 Dec 2007 21:08:46 +0000 (21:08 +0000)]
Update StringsNotToBeLocalized.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 1 Dec 2007 19:04:15 +0000 (19:04 +0000)]
Reviewed by Mitz.
- fix problem tracked by these bugs:
http://bugs.webkit.org/show_bug.cgi?id=16097
<rdar://problem/
5619305> Safari crashes during load of LexisNexis search results
<rdar://problem/
5510779> CrashTracer: [USER] 25 crashes in Safari at
WebCore::DocumentLoader::isLoadingMultipartContent const
* loader/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure): Create an ImageDocumentElement
instead of an HTMLImageElement.
(WebCore::ImageDocument::scale): Added a null check for m_imageElement.
(WebCore::ImageDocument::resizeImageToFit): Ditto.
(WebCore::ImageDocument::restoreImageSize): Ditto.
(WebCore::ImageDocument::imageFitsInWindow): Ditto.
(WebCore::ImageDocument::windowSizeChanged): Ditto.
(WebCore::ImageDocumentElement::~ImageDocumentElement): Call
disconnectImageElement so m_imageElement will be set to 0
if we're still connected to the document.
(WebCore::ImageDocumentElement::willMoveToNewOwnerDocument): Ditto.
* loader/ImageDocument.h: Changed image element type to be
ImageDocumentElement instead of HTMLImageElement. Also added
a disconnectImageElement function that sets m_imageElement to 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 1 Dec 2007 18:44:08 +0000 (18:44 +0000)]
- remove the empty directories
* ksvg2: Removed.
* ksvg2/css: Removed.
* ksvg2/events: Removed.
* ksvg2/misc: Removed.
* ksvg2/scripts: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 1 Dec 2007 18:09:49 +0000 (18:09 +0000)]
Ignore another file that's now part of hosted SunSpider.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 1 Dec 2007 16:51:00 +0000 (16:51 +0000)]
2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>
Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers
Reviewed by Darin Adler.
* xml/XMLHttpRequest.cpp:
(WebCore::canSetRequestHeader):
Test: http/tests/xmlhttprequest/set-dangerous-headers.html
2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>
Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers
Reviewed by Darin Adler.
* http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
* http/tests/xmlhttprequest/set-dangerous-headers.html: Added tests for new headers
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 1 Dec 2007 16:41:55 +0000 (16:41 +0000)]
2007-12-01 Rahul Abrol <ra5ul@comcast.net>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16128
Ignore resizable=no for window.open().
* bindings/js/kjs_window.cpp:
(KJS::setWindowFeature):
(KJS::parseWindowFeatures):
* manual-tests/window-open-features-parsing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 1 Dec 2007 16:33:40 +0000 (16:33 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/
5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)
Test: fast/dynamic/subtree-common-root.html
* page/FrameView.cpp:
(WebCore::FrameView::layoutRoot): Added a parameter to let this method
return the layout root for a pending layout as well.
(WebCore::FrameView::scheduleRelayoutOfSubtree): Pass the new root
to markContainingBlocksForLayout(). Otherwise,
markContainingBlocksForLayout() could mark past the new root, if it had
previously been marked as having a normal child needing layout and then
was reached via a positioned child.
* page/FrameView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcWidth):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::~RenderObject): Fixed the ASSERT so that
it would really catch deletion of the layout root.
(WebCore::RenderObject::markContainingBlocksForLayout): Added the
newRoot parameter, which tells this method where to stop marking.
* rendering/RenderObject.h:
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/
5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)
* fast/dynamic/subtree-common-root-expected.txt: Added.
* fast/dynamic/subtree-common-root.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 1 Dec 2007 16:28:57 +0000 (16:28 +0000)]
Reviewed by Darin Adler.
- fold FontStyle into TextRun
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Font.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):
(WebCore::Font::width):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawText):
(WebCore::Font::floatWidth):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::selectionRectForText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPosition):
(WebCore::Font::offsetForPositionForSimpleText):
* platform/graphics/Font.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::setText):
(WebCore::TextRun::allowTabs):
(WebCore::TextRun::xPos):
(WebCore::TextRun::padding):
(WebCore::TextRun::rtl):
(WebCore::TextRun::ltr):
(WebCore::TextRun::directionalOverride):
(WebCore::TextRun::applyRunRounding):
(WebCore::TextRun::applyWordRounding):
(WebCore::TextRun::spacingDisabled):
(WebCore::TextRun::disableSpacing):
(WebCore::TextRun::disableRoundingHacks):
(WebCore::TextRun::setRTL):
(WebCore::TextRun::setDirectionalOverride):
* platform/graphics/FontStyle.h: Removed.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawBidiText):
(WebCore::GraphicsContext::drawHighlightForText):
* platform/graphics/GraphicsContext.h:
* platform/graphics/StringTruncator.cpp:
(WebCore::stringWidth):
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/mac/FontMac.mm:
(WebCore::ATSULayoutParameters::ATSULayoutParameters):
(WebCore::addDirectionalOverride):
(WebCore::overrideLayoutOperation):
(WebCore::ATSULayoutParameters::initialize):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/qt/FontQt.cpp:
(WebCore::generateComponents):
(WebCore::Font::drawText):
(WebCore::Font::width):
(WebCore::Font::offsetForPosition):
(WebCore::cursorToX):
(WebCore::Font::selectionRectForText):
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreDrawTextAtPoint):
(WebCoreTextFloatWidth):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::paint):
* platform/win/UniscribeController.cpp:
(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::offsetForPosition):
(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::itemizeShapeAndPlace):
(WebCore::UniscribeController::resetControlAndState):
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/win/UniscribeController.h:
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::calcPrefWidths):
* rendering/RenderImage.cpp:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::width):
* rendering/RenderText.h:
(WebCore::RenderText::allowTabs):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcPrefWidths):
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateGlyphWidth):
(WebCore::SVGInlineTextBox::paintCharacters):
(WebCore::SVGInlineTextBox::paintSelection):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
(WebCore::cummulatedWidthOfInlineBoxCharacterRange):
(WebCore::svgTextRunForInlineTextBox):
* rendering/SVGRootInlineBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 1 Dec 2007 06:56:29 +0000 (06:56 +0000)]
Add another feed
* config.ini:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 1 Dec 2007 06:48:33 +0000 (06:48 +0000)]
Add a simple script to update the site
* update.pl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 1 Dec 2007 06:34:18 +0000 (06:34 +0000)]
Include all WebKit posts from Trolltech Labs
* config.ini:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sat, 1 Dec 2007 05:46:20 +0000 (05:46 +0000)]
* Don't hide symbols when in Debug mode
* On Linux (glibc) provide a backtrace in the test output for debugging purposes
Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 1 Dec 2007 05:29:05 +0000 (05:29 +0000)]
2007-11-30 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Fix for GTK+ Debug build breakage introduced in r28273.
* WebView/webkitprivate.cpp:
(WebKit::kit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 1 Dec 2007 04:24:09 +0000 (04:24 +0000)]
2007-11-30 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions
Refactor the WebKit/GTK+ public API. Changes:
WebKitPage -> WebKitWebView
WebKitFrame -> WebKitWebFrame
Public API source and header names have been updated to mirror the API
changes.
The API is now kept in WebKit/gtk/WebView to match other ports in the
same class such as Mac and Win.
API/ABI-breaking change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 1 Dec 2007 02:25:07 +0000 (02:25 +0000)]
Reviewed by Eric.
* ChangeLog:
* pcre/pcre_compile.cpp:
(compile_branch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Sat, 1 Dec 2007 01:57:07 +0000 (01:57 +0000)]
Reviewed by Adam.
Link to the commit and review policy.
* coding/contributing.html:
* nav.inc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 1 Dec 2007 01:47:24 +0000 (01:47 +0000)]
* coding/commit-review-policy.html: A couple more typos and very
minor grammatical stuff. No substantive change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 1 Dec 2007 01:42:36 +0000 (01:42 +0000)]
* coding/commit-review-policy.html: Fixed a typo, added a footer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 1 Dec 2007 01:37:47 +0000 (01:37 +0000)]
Initial checkin of Planet WebKit
Rubberstamped by Sam.
* README: Added.
* config.ini: Added.
* planet/AUTHORS: Added.
* planet/INSTALL: Added.
* planet/LICENCE: Added.
* planet/NEWS: Added.
* planet/PKG-INFO: Added.
* planet/README: Added.
* planet/THANKS: Added.
* planet/TODO: Added.
* planet/examples/atom.xml.tmpl: Added.
* planet/examples/basic/config.ini: Added.
* planet/examples/basic/index.html.tmpl: Added.
* planet/examples/fancy/config.ini: Added.
* planet/examples/fancy/index.html.tmpl: Added.
* planet/examples/foafroll.xml.tmpl: Added.
* planet/examples/opml.xml.tmpl: Added.
* planet/examples/output/images/edd.png: Added.
* planet/examples/output/images/evolution.png: Added.
* planet/examples/output/images/feed-icon-10x10.png: Added.
* planet/examples/output/images/jdub.png: Added.
* planet/examples/output/images/keybuk.png: Added.
* planet/examples/output/images/logo.png: Added.
* planet/examples/output/images/opml.png: Added.
* planet/examples/output/images/planet.png: Added.
* planet/examples/output/images/thom.png: Added.
* planet/examples/output/planet.css: Added.
* planet/examples/rss10.xml.tmpl: Added.
* planet/examples/rss20.xml.tmpl: Added.
* planet/planet-cache.py: Added.
* planet/planet.py: Added.
* planet/planet/__init__.py: Added.
* planet/planet/atomstyler.py: Added.
* planet/planet/cache.py: Added.
* planet/planet/compat_logging/__init__.py: Added.
* planet/planet/compat_logging/config.py: Added.
* planet/planet/compat_logging/handlers.py: Added.
* planet/planet/feedparser.py: Added.
* planet/planet/htmltmpl.py: Added.
* planet/planet/sanitize.py: Added.
* planet/planet/tests/__init__.py: Added.
* planet/planet/tests/data/simple.tmpl: Added.
* planet/planet/tests/data/simple2.tmpl: Added.
* planet/planet/tests/test_channel.py: Added.
* planet/planet/tests/test_main.py: Added.
* planet/planet/tests/test_sanitize.py: Added.
* planet/planet/tests/test_sub.py: Added.
* planet/planet/timeoutsocket.py: Added.
* planet/runtests.py: Added.
* planet/setup.py: Added.
* templates/atom.xml.tmpl: Added.
* templates/foafroll.xml.tmpl: Added.
* templates/index.html.tmpl: Added.
* templates/opml.xml.tmpl: Added.
* templates/rss10.xml.tmpl: Added.
* templates/rss20.xml.tmpl: Added.
* wwwroot/images/feed-icon-10x10.png: Added.
* wwwroot/images/planet.png: Added.
* wwwroot/planet.css: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Sat, 1 Dec 2007 00:48:42 +0000 (00:48 +0000)]
Reviewed by Maciej.
Clean up a couple of typos from Maciej's last patch.
* coding/commit-review-policy.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Sat, 1 Dec 2007 00:47:47 +0000 (00:47 +0000)]
<rdar://problem/
5621373> Added a way for the client to clear undo/redo
operations from a WebView.
Reviewed by Steve.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::clearUndoRedoOperations):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 1 Dec 2007 00:27:55 +0000 (00:27 +0000)]
Reviewed by Bertrand.
New commit and review policy.
* coding/commit-review-policy.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 1 Dec 2007 00:18:25 +0000 (00:18 +0000)]
Add platform/text project group.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 1 Dec 2007 00:05:11 +0000 (00:05 +0000)]
2007-11-30 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix uninitialized var warnings in release build.
* JavaScriptCore.xcodeproj/project.pbxproj:
* pcre/pcre_compile.cpp:
(compile_regex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Nov 2007 23:57:44 +0000 (23:57 +0000)]
Remove extra </Filter> tag which prevented the vcproj from being parsed correctly.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 30 Nov 2007 23:47:20 +0000 (23:47 +0000)]
Reviewed by Geoff Garen
Added another symbol for WebDatabaseManager clients
* WebKit.exp:
added .objc_class_name_WebSecurityOrigin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 30 Nov 2007 23:43:45 +0000 (23:43 +0000)]
2007-11-30 Eric Seidel <eric@webkit.org>
Reviewed by darin.
PCRE crashes under GuardMalloc
http://bugs.webkit.org/show_bug.cgi?id=16127
check against patternEnd to make sure we don't walk off the end of the string
* pcre/pcre_compile.cpp:
(compile_branch):
(calculateCompiledPatternLengthAndFlags):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 23:25:30 +0000 (23:25 +0000)]
Not reviewed. Try to fix qt/gtk build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 23:19:53 +0000 (23:19 +0000)]
Rubber stamped by Eric.
Final integration of ksvg2 in WebKit. Moving ksvg2/ to svg/ and killing all it's subdirectories,
by moving the files into approriate locations (css, rendering, ...) - as dicsussed on the
mailing list and on IRC with David/Darin & Eric.
Updated all build files - though I can't guarantee it builds on non-mac. Need buildbot to verify.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 30 Nov 2007 22:22:36 +0000 (22:22 +0000)]
wx build fix. Add WebCore/platform/graphics/wx to includes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 30 Nov 2007 22:08:06 +0000 (22:08 +0000)]
Reviewed by Geoff
Further hookup of Database API
With this change, any database operation that writes to the database (UPDATE, INSERT, CREATE, etc) will
result in a didModifyDatabase notification when the transaction is successfully committed
* storage/DatabaseAuthorizer.cpp: Global rename of "m_lastActionIncreasedSize" to "m_lastActionChangedDatabase"
(WebCore::DatabaseAuthorizer::reset):
(WebCore::DatabaseAuthorizer::createTable):
(WebCore::DatabaseAuthorizer::allowAlterTable):
(WebCore::DatabaseAuthorizer::createIndex):
(WebCore::DatabaseAuthorizer::createTrigger):
(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::allowInsert):
(WebCore::DatabaseAuthorizer::allowUpdate):
* storage/DatabaseAuthorizer.h:
(WebCore::DatabaseAuthorizer::lastActionChangedDatabase):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::notifyDatabaseChanged): Added. Allow external entities (SQLTransaction) to be able
to request a didModifyDatabase notification to the delegate
* storage/DatabaseTracker.h:
* storage/SQLTransaction.cpp: Added m_modifiedDatabase flag which tracks if any statement over the course of
a transaction resulted in a change to the database.
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runCurrentStatement): Set m_modifiedDatabase to true if the authorizer reports a mutation
statement occurred
(WebCore::SQLTransaction::postflightAndCommit): If the transaction successfully commits, call DatabaseTracker::notifyDatabaseChanged
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
* storage/SQLTransaction.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 30 Nov 2007 22:04:30 +0000 (22:04 +0000)]
Reviewed by Geoff
Add isEqual operator to WebSecurityOrigin
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin isEqual:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 30 Nov 2007 21:55:52 +0000 (21:55 +0000)]
Hopefully the final build fix
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
pull in WTF's assertion/logging functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 30 Nov 2007 21:44:05 +0000 (21:44 +0000)]
Another build fix
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
WebKit.lib.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 30 Nov 2007 21:27:36 +0000 (21:27 +0000)]
Debug build fix
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
configuration.
* Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
projects.
* Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
* Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 20:35:24 +0000 (20:35 +0000)]
Rubber stamped by David.
Next round of moves - platform reorganization.
Move text/font/glyph related files from the individual port directories
into platform/text/<port> or platform/graphics/<port>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 30 Nov 2007 20:15:11 +0000 (20:15 +0000)]
Other wx port fixes needed to restore the build bot.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 30 Nov 2007 20:11:07 +0000 (20:11 +0000)]
Reviewed by Adam Roben.
Fix drawSelectionRect to actually draw the selection rect.
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(drawSelectionRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 30 Nov 2007 19:33:32 +0000 (19:33 +0000)]
Fix the build with DATABASE=0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 30 Nov 2007 19:32:17 +0000 (19:32 +0000)]
Copy some cross-platform results into platform/win to avoid picking up the platform/mac versions
* platform/win/fast/dom/Window/window-resize-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-expected.txt.
* platform/win/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/fast/dom/wrapper-classes-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 19:21:54 +0000 (19:21 +0000)]
Rubber stamped by Darin.
Fix misplaced file. The name "FontStyle" is not correct though - it probably
needs yet another move - but this time inside platform/graphics - as soon
as we agree on a better name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 30 Nov 2007 19:04:56 +0000 (19:04 +0000)]
Reviewed by Darin
Tweaks to newly-declared NSString * constants to make them usable from clients
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebDatabaseManager.mm:
removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
* WebKit.exp:
export new NSNotification names and userInfo keys so clients can use them
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 30 Nov 2007 18:54:34 +0000 (18:54 +0000)]
JavaScriptCore:
Reviewed by Adam Roben.
- fix http://bugs.webkit.org/show_bug.cgi?id=16207
JavaScript regular expressions should match UTF-16 code units rather than characters
SunSpider says this is 5.5% faster on the regexp test, 0.4% faste overall.
Test: fast/js/regexp-non-bmp.html
Renamed ANY_CHAR to NOT_NEWLINE to more-accurately reflect its meaning.
* pcre/pcre_compile.cpp:
(compile_branch): Removed calls to the UTF-16 character accessor functions, replacing
them with simple pointer dereferences in some cases, and no code at all in others.
(calculateCompiledPatternLengthAndFlags): Ditto.
* pcre/pcre_exec.cpp:
(match): Fixed indentation of some case labels (including all the BEGIN_OPCODE).
Removed calls to the UTF-16 character accessor functions, replacing them with simple
pointer dereferences in some cases, and no code at all in others. Also removed some
explicit UTF-16 support code in a few cases. Removed the unneeded "UTF-8" code path
in the ANY_CHAR repeat code, and in another case, eliminated the code to check against
end_subject in because it is already done outside the loop.
(jsRegExpExecute):
* pcre/pcre_internal.h: Removed all the UTF-16 helper functions.
LayoutTests:
Reviewed by Adam Roben.
- test for http://bugs.webkit.org/show_bug.cgi?id=16207
JavaScript regular expressions should match UTF-16 code units rather than characters
* fast/js/regexp-non-bmp-expected.txt: Added.
* fast/js/regexp-non-bmp.html: Added.
* fast/js/resources/regexp-non-bmp.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 30 Nov 2007 18:47:34 +0000 (18:47 +0000)]
* Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 30 Nov 2007 18:44:26 +0000 (18:44 +0000)]
Build fix after platform/text changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 18:43:37 +0000 (18:43 +0000)]
Reviewed by Sam.
Rename "FontStyle FontStyle(...)" to "FontStyle fontStyle(...)".
I scripted a bit too much while doing the TextStyle -> FontStyle change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 30 Nov 2007 18:38:58 +0000 (18:38 +0000)]
2007-11-30 Alp Toker <alp@atoker.com>
GTK+ build fix following the recent text reorganization.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 30 Nov 2007 18:08:26 +0000 (18:08 +0000)]
2007-11-29 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Adam.
Part of <rdar://problem/
5506522> Seed: cannot type into text box in
Facebook, don't see plugin content (Adobe Flash)
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::handleMouseEvent): Focus the plugin's parent
frame
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 30 Nov 2007 18:06:04 +0000 (18:06 +0000)]
* Scripts/do-webcore-rename: Get ready for some future renaming.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Fri, 30 Nov 2007 18:03:24 +0000 (18:03 +0000)]
Reviewed by Adam.
- Removed some unnecessary functions and changed an unused return type.
* Drosera/win/DebuggerClient.cpp:
(registerConsoleClass):
* Drosera/win/DebuggerClient.h:
* Drosera/win/Drosera.cpp:
(registerDroseraClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 17:54:05 +0000 (17:54 +0000)]
Not reviewed. Trying to fix gtk/qt/wx build. (I expected problems because of the moves)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 30 Nov 2007 17:41:22 +0000 (17:41 +0000)]
Rubber stamped by Brady.
Started platform reorganization (platform/text addition).
Moving string/text/font related classes into new places - as discussed on webkit-dev.
In a follow-up commit I'll move classes out of platform/{mac,win,...} into
platform/text/{mac,win,...}, and also do the ksvg2/ -> svg/ move.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 30 Nov 2007 17:02:48 +0000 (17:02 +0000)]
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/
5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)
Test: fast/events/mousemove-after-drag-over-scrollbar.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse.
We should only need to show the hover effect when the mouse isn't pressed.
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/
5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button
* fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
* fast/events/mousemove-after-drag-over-scrollbar.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 30 Nov 2007 14:12:24 +0000 (14:12 +0000)]
* platform/win/Skipped: Added editing/selection/
5241148.html, which crashes for me.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 30 Nov 2007 12:40:29 +0000 (12:40 +0000)]
2007-11-28 Alp Toker <alp@atoker.com>
Reviewed by Timothy Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=16174
[GTK] Use "URI" not "URL" in public API
Replace use of the term "URL" with "URI" in public headers,
documentation and some internal code to match GLib/GTK+ convention.
This is now mentioned in the API guidelines:
http://trac.webkit.org/projects/webkit/wiki/HackingGtk
API/ABI-breaking change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 30 Nov 2007 09:34:45 +0000 (09:34 +0000)]
* Self destruct the clients like the ohter ports do
Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 30 Nov 2007 08:49:16 +0000 (08:49 +0000)]
2007-11-30 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Fix layout test regressions caused by r28186
http://bugs.webkit.org/show_bug.cgi?id=16195
change first_byte and req_byte back to shorts instead of chars
(I think PCRE stuffs information in the high bits)
* pcre/pcre_internal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 30 Nov 2007 07:01:25 +0000 (07:01 +0000)]
Reviewed by Tim
Part of <rdar://problem/
5556377> - Need to accurately track and enforce database quota
SQLite has the ability to enforce the page usage for databases. This gives us bulletproof
enforcement of the database size limit with reasonable granularity (within 1023 bytes by
default on OS X with SQLite 3.4.0)
This also involved enhancing the ability to install/remove the authorizer to run the PRAGMA
statements involved
Note this patch does not actually use the new maximumSize() functionality of the
SQLiteDatabase class - that can be reviewed/landed seperately
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::maximumSize): Return the current maximum size in bytes
(WebCore::SQLiteDatabase::setMaximumSize): Based on m_pageSize, set the maximum page count
to enforce the maximum size in bytes
(WebCore::SQLiteDatabase::pageSize): Fetch m_pageSize if it hasn't been fetched, or return
the cached value
(WebCore::SQLiteDatabase::setAuthorizer): Use enableAuthorizer for the sqlite_* level
authorizer setup
(WebCore::SQLiteDatabase::enableAuthorizer): Install or remove the sqlite authorizer handler
* platform/sql/SQLiteDatabase.h: Add the m_pageSize member so we only have to fetch it once
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 30 Nov 2007 05:50:15 +0000 (05:50 +0000)]
* Fix fast/events/mousedown_in_scrollbar.html
* This test used to crash in PlatformScrollbarQt::mouse*Event due parent() returning 0.
* Extend the current check that the scrollbar in the mev can be go away.
This happens if we destroy a RenderLayer as the result of a click. In the
case of Qt we can have this scrollbar in m_lastScrollbarUnderMouse. The RenderLayer
is the ScrollbarClient, m_lastScrollbarUnderMouse is a RefPtr and keeps the
last reference. When calling into this scrollbar the m_client pointer is a dangling pointer.
We extend the check to set m_lastScrollbarUnderMouse back to zero when it was the
scrollbar in the old mev and is gone in the new one.
* This happens only on the Qt port because we send more/different move events.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 30 Nov 2007 05:25:25 +0000 (05:25 +0000)]
WebCore:
Reviewed by Mitz.
Fix aspect ratio calculation of video.
Video should always be treated as a replaced element in size calculation.
Test: media/video-aspect-ratio.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcWidth):
(WebCore::RenderBox::calcHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::shouldCalculateSizeAsReplaced):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::shouldCalculateSizeAsReplaced):
LayoutTests:
Reviewed by Mitz.
Test for video aspect ratio calculation.
* media/video-aspect-ratio.html: Added.
* platform/mac/media: Added.
* platform/mac/media/video-aspect-ratio-expected.checksum: Added.
* platform/mac/media/video-aspect-ratio-expected.png: Added.
* platform/mac/media/video-aspect-ratio-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 30 Nov 2007 05:20:39 +0000 (05:20 +0000)]
Reviewed by Oliver.
Additional fix for <rdar://problem/
5592988> / http://bugs.webkit.org/show_bug.cgi?id=15936
- More closely match IE's policy for frame navigation.
* bindings/js/kjs_window.cpp:
(KJS::WindowProtoFuncOpen::callAsFunction):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldAllowNavigation):
* page/FrameTree.cpp:
(WebCore::FrameTree::top):
* page/FrameTree.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 30 Nov 2007 04:34:38 +0000 (04:34 +0000)]
Reviewed by Adam Roben and John Sullivan.
- make the recent searches popup extend only along the straight part of
the search field (unless it needs to be wider).
* platform/PopupMenuClient.h:
Added clientInsetLeft() and clientInsetRight() for clients to
specify desired horizontal insets for the menu.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::paint):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::clientInsetLeft): Added. Returns 0.
(WebCore::RenderMenuList::clientInsetRight): Ditto.
* rendering/RenderMenuList.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::clientInsetLeft): Added. Returns half the
control's height, which is the radius of the cap on the left.
(WebCore::RenderTextControl::clientInsetRight): Added.
* rendering/RenderTextControl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 30 Nov 2007 03:02:08 +0000 (03:02 +0000)]
Make the JS collector work with multiple threads
Reviewed by Maciej and Darin.
Under heavy contention it was possible the GC to suspend other
threads inside the pthread spinlock, which could lead to the GC
thread blocking on the pthread spinlock itself.
We now determine and store each thread's stack base when it is
registered, thus removing the need for any calls to pthread_get_stackaddr_np
that needed the pthread spinlock.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Nov 2007 02:42:32 +0000 (02:42 +0000)]
WebKitTools:
Reviewed by Sam.
<rdar://problem/
5230478>
FrameLoadDelegate callbacks are not dumped in DRT.
* DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogFrameLoadDelegates):
(runTest):
(main):
* DumpRenderTree/win/FrameLoaderDelegate.cpp:
(BSTRtoString):
(descriptionSuitableForTestResult):
(FrameLoadDelegate::QueryInterface):
(FrameLoadDelegate::didStartProvisionalLoadForFrame):
(FrameLoadDelegate::didFailProvisionalLoadWithError):
(FrameLoadDelegate::didCommitLoadForFrame):
(FrameLoadDelegate::didFinishLoadForFrame):
(FrameLoadDelegate::willCloseFrame):
(FrameLoadDelegate::didClearWindowObject):
(FrameLoadDelegate::didFinishDocumentLoadForFrame):
(FrameLoadDelegate::didHandleOnloadEventsForFrame):
* DumpRenderTree/win/FrameLoaderDelegate.h:
(FrameLoadDelegate::windowScriptObjectAvailable):
(FrameLoadDelegate::didFirstLayoutInFrame):
LayoutTests:
Reviewed by Sam.
<rdar://problem/
5230478>
FrameLoadDelegate callbacks are not dumped in DRT.
Remove now passing tests.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc