WebKit-https.git
10 years agowebkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
kubo@profusion.mobi [Tue, 6 Dec 2011 02:07:23 +0000 (02:07 +0000)]
webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
https://bugs.webkit.org/show_bug.cgi?id=73878

Reviewed by Tony Chang.

r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
r98785 made webkit.py always use m_data16, which does not work when
the string is an 8-bit string (such as KURL::string()).

I was not able to directly call StringImpl::is8Bit() in the Python
code, so I just reproduced the implementation there.

* gdb/webkit.py:
(WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(WTFStringPrinter.to_string):
(JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(JSCUStringPrinter.to_string):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCreate StringImpl::empty() as an 8 bit string
msaboff@apple.com [Tue, 6 Dec 2011 02:06:48 +0000 (02:06 +0000)]
Create StringImpl::empty() as an 8 bit string
https://bugs.webkit.org/show_bug.cgi?id=73871

Reviewed by Oliver Hunt.

* wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty): Changed to be an 8 bit string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome small improvements to ContainerNode.h
darin@apple.com [Tue, 6 Dec 2011 02:04:16 +0000 (02:04 +0000)]
Some small improvements to ContainerNode.h
https://bugs.webkit.org/show_bug.cgi?id=73786

Reviewed by Alexey Proskuryakov.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
peculiar behavior of this function. Somehow the post-attach suspend state is both
global and specific to a certain Page object. That can't be right. If it was truly
global then this would be a static member function. If it was truly per-page, then
the related functions could not be static.

* dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes
function up with the other basic getters. Put the other getters, childNodeCount and
childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
mutation functions so they can be used in a cleaner fashion in C++ code where we have
some reason to know an exception won't occur. Grouped all the overrides of functions
from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.

* dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.

* dom/Node.cpp:
(WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
(WebCore::Node::isDescendantOf): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of KURL::KURL(ParsedURLStringTag, const char*);
benjamin@webkit.org [Tue, 6 Dec 2011 01:51:27 +0000 (01:51 +0000)]
Get rid of KURL::KURL(ParsedURLStringTag, const char*);
https://bugs.webkit.org/show_bug.cgi?id=73792

Reviewed by Andreas Kling.

In all cases where the constructor is used, the constructor
taking a String is as effective because the string is valid and converted
to String for m_string.

This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
and change the call sites that were using that constructor to build
empty URLs.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
* platform/KURL.cpp:
* platform/KURL.h:
* platform/KURLGoogle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed extremely minor SVG filter pixel rebaselines for Lion.
timothy_horton@apple.com [Tue, 6 Dec 2011 01:41:16 +0000 (01:41 +0000)]
Unreviewed extremely minor SVG filter pixel rebaselines for Lion.

Mostly text antialiasing differences, all only noticeable at tolerances very near 0.

* platform/mac-snowleopard/svg/filters/feComposite-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feComposite-expected.png.
* platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png.
* platform/mac-snowleopard/svg/filters/feOffset-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feOffset-expected.png.
* platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png.
* platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png.
* platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Copied from LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png.
* platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png.
* platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-two-effects-expected.png.
* platform/mac/svg/filters/feComposite-expected.png:
* platform/mac/svg/filters/feLighting-crash-expected.png:
* platform/mac/svg/filters/feOffset-expected.png:
* platform/mac/svg/filters/filter-on-tspan-expected.png:
* platform/mac/svg/filters/filter-width-update-expected.png:
* platform/mac/svg/filters/sourceAlpha-expected.png:
* platform/mac/svg/filters/subRegion-one-effect-expected.png:
* platform/mac/svg/filters/subRegion-two-effects-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
abarth@webkit.org [Tue, 6 Dec 2011 01:35:50 +0000 (01:35 +0000)]
[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=73881

This patch adds a forwarding header to fix the downstream Windows build:
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/12955/steps/compile/logs/stdio

* public/WebContentLayerClient.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed feGaussianBlur rebaseline for Mac after r101638.
timothy_horton@apple.com [Tue, 6 Dec 2011 01:30:21 +0000 (01:30 +0000)]
Unreviewed feGaussianBlur rebaseline for Mac after r101638.

* platform/mac/svg/filters/feGaussianBlur-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a shim to fix the downstream Chromium compile. The real fix should
abarth@webkit.org [Tue, 6 Dec 2011 01:29:25 +0000 (01:29 +0000)]
Add a shim to fix the downstream Chromium compile.  The real fix should
be made downstream via http://codereview.chromium.org/8801036/, but the
Chromium tree is closed at the moment.

* public/WebRect.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove methods declared but never implemented with GOOGLEURL
benjamin@webkit.org [Tue, 6 Dec 2011 01:10:13 +0000 (01:10 +0000)]
Remove methods declared but never implemented with GOOGLEURL
https://bugs.webkit.org/show_bug.cgi?id=73795

Reviewed by Adam Barth.

* platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUp the "expected ram for each DRT instance" to 400MB instead of 300MB
eric@webkit.org [Tue, 6 Dec 2011 01:08:04 +0000 (01:08 +0000)]
Up the "expected ram for each DRT instance" to 400MB instead of 300MB
in hopes of making the Snow Leopard bot stop timing out.

Unreviewed.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange CSSFontSelector to use HashMap<OwnPtr>
darin@apple.com [Tue, 6 Dec 2011 01:03:53 +0000 (01:03 +0000)]
Change CSSFontSelector to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73781

Reviewed by Dan Bernstein.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
(WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
(WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.

* css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts
be HashMap<OwnPtr>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoV8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
adamk@chromium.org [Tue, 6 Dec 2011 00:33:28 +0000 (00:33 +0000)]
V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
https://bugs.webkit.org/show_bug.cgi?id=73867

Reviewed by Adam Barth.

Moved V8RecursionScope into its own file, and moved
V8Proxy::didLeaveScriptContext into that file, along with a static
recursionLevel accessor, hiding the V8BindingPerIsolateData methods
from V8Proxy.

This will make it easy and less error-prone to use V8RecursionScope
properly. I plan to make use of it in V8LazyEventListener to fix
https://bugs.webkit.org/show_bug.cgi?id=73492.

No new tests, refactoring only.

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.
* bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.
(WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
(WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.
* bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
* bindings/v8/V8RecursionScope.cpp: Added.
(WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.
* bindings/v8/V8RecursionScope.h: Added.
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
(WebCore::V8RecursionScope::recursionLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert JSClassRef to use HashMap<OwnPtr>
darin@apple.com [Tue, 6 Dec 2011 00:17:34 +0000 (00:17 +0000)]
Convert JSClassRef to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73780

Reviewed by Andreas Kling.

* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::getOwnPropertyNames): Use get() on the hash map
entries because the hash map now has an OwnPtr instead of a raw pointer.

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): No need to initialize m_staticValues and
m_staticFunctions since they are now OwnPtr. Use adoptPtr when allocating.
Removed the code that gets and deletes existing entries, and just use set,
which now handles deletion automatically due to it being OwnPtr.
(OpaqueJSClass::~OpaqueJSClass): Replaced code to do all the deletion
with assertion-only NDEBUG-only code.
(OpaqueJSClassContextData::OpaqueJSClassContextData): Use adoptPtr when
allocating. Use OwnPtr when adding. Removed unneeded code to set
staticValues and staticFunctions to 0. Removed unneeded destructor.
(OpaqueJSClass::staticValues): Added get call. Also removed unneeded local.
(OpaqueJSClass::staticFunctions): Ditto.
(OpaqueJSClass::prototype): Added use of adoptPtr.

* API/JSClassRef.h: Made the static values and static functions tables
use OwnPtr for the entries. Also used OwnPtr for the pointers to the
tables themselves. Also removed ~OpaqueJSClassContextData(), letting
the compiler generate it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined
benjamin@webkit.org [Tue, 6 Dec 2011 00:17:13 +0000 (00:17 +0000)]
Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.

* page/SecurityOrigin.cpp:
(WebCore::shouldUseInnerURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange RuleSet to use HashMap<OwnPtr>
darin@apple.com [Tue, 6 Dec 2011 00:15:16 +0000 (00:15 +0000)]
Change RuleSet to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73783

Reviewed by Andreas Kling.

* css/CSSStyleSelector.cpp: Make RuleSet::AtomRuleMap use OwnPtr for the mapped values.
(WebCore::RuleSet::addToRuleSet): Use add instead of get/set to set up a new entry in the
map or find the old entry in the map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Move emissions of AtkDocument signals down to WebCore
mario@webkit.org [Tue, 6 Dec 2011 00:10:55 +0000 (00:10 +0000)]
[GTK] Move emissions of AtkDocument signals down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=73750

Reviewed by Chris Fleizach.

Source/WebCore:

Implement the needed infrastructure to allow notifying
accessibility, in a cross-platform way, when a event related to
the load of a document happens. Added a generic method, which will
be called from the FrameLoader, and platform specific versions of
it so every port has a chance to decide what to do with those
notifications.

This patch doesn't include a new test because the one testing this
functionality is the GTK-specific unit test added along with patch
for bug 73746: testWebkitAtkDocumentLoadingEvents.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::frameLoadingEventNotification): New, called
from the FrameLoader to notify accessibility when an event happens.
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): New,
platform specific function to let ports decide what to do.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::frameLoadingEventNotification): New.
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for chromium.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for the Mac.
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for Windows.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart): Notify accessibility
by calling the new frameLoadingEventNotification() function.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.

Source/WebKit/gtk:

Removed code for emission of AtkDocument signals.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::notifyStatus): Removed no longer used code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand uncommitted bit of float array support
oliver@apple.com [Tue, 6 Dec 2011 00:06:21 +0000 (00:06 +0000)]
Land uncommitted bit of float array support
https://bugs.webkit.org/show_bug.cgi?id=73873

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r101949): css3/bdi-element.html fails on Lion
rniwa@webkit.org [Mon, 5 Dec 2011 23:57:28 +0000 (23:57 +0000)]
REGRESSION(r101949): css3/bdi-element.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73859

Reviewed by Dan Bernstein.

The failure was caused by span that contains the text inside bdi in the reference file
was using display: inline-block. Because the width of an inline-block is always rounded up
like any other inline element, it causes the text in the reference file to be one pixel
longer than the one in the test file in certain cases.

Fixed the bug by using unicode-bidi: override instead of display: inline-block in
the reference file.

* css3/bdi-element-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate String::containsOnlyASCII() to handle 8 bits strings
benjamin@webkit.org [Mon, 5 Dec 2011 23:56:49 +0000 (23:56 +0000)]
Update String::containsOnlyASCII() to handle 8 bits strings
https://bugs.webkit.org/show_bug.cgi?id=73799

Reviewed by Darin Adler.

Source/JavaScriptCore:

Implement String::containsOnlyASCII() so that it does not
call String::characters().

* wtf/text/WTFString.h:
(WTF::String::containsOnlyASCII):

Source/WebCore:

When possible, change the call sites from charactersAreAllASCII()
to the optimized version String::containsOnlyASCII().

* platform/KURL.cpp:
(WebCore::KURL::init):
* platform/cf/BinaryPropertyList.cpp:
(WebCore::BinaryPropertyListPlan::writeStringObject):
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCodepage::if):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMark this test as flaky.
abarth@webkit.org [Mon, 5 Dec 2011 23:54:02 +0000 (23:54 +0000)]
Mark this test as flaky.
See https://bugs.webkit.org/show_bug.cgi?id=73872

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for non-DFG platforms.
fpizlo@apple.com [Mon, 5 Dec 2011 23:50:15 +0000 (23:50 +0000)]
Unreviewed build fix for non-DFG platforms.

* dfg/DFGRepatch.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNRWT creates too many workers on RAM-limited machines
eric@webkit.org [Mon, 5 Dec 2011 23:48:47 +0000 (23:48 +0000)]
NRWT creates too many workers on RAM-limited machines
https://bugs.webkit.org/show_bug.cgi?id=73847

Reviewed by Dirk Pranke.

Make NRWT restrict its number of workers when there isn't enough
RAM to support them.
Also re-enable parallel testing on the Mac bots which were
failing due to not enough ram.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):
* Scripts/webkitpy/common/host.py:
(Host.__init__):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.cpu_count):
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.__init__):
(PlatformInfo.display_name):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.display_name):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):
(PortTest.test_pretty_patch_os_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: [chromium] Use ANGLE's texture_usage and texture_storage extensions...
vangelis@chromium.org [Mon, 5 Dec 2011 23:43:15 +0000 (23:43 +0000)]
Source/WebCore: [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures
https://bugs.webkit.org/show_bug.cgi?id=73621

When the extensions are available, compositor textures are allocated via
glTexStorage2DEXT instead of glTexImage2D to eliminate creation of unnecessary
mip levels on the service side. In addition, the GL_FRAMEBUFFER_ATTACHMENT_ANGLE
is specified for all textures used by RenderSurfaces to eliminate the need for
a system memory bitmap allocation.

Reviewed by Kenneth Russell.

* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/TrackingTextureAllocator.cpp:
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::textureToStorageFormat):
(WebCore::isTextureFormatSupportedForStorage):
(WebCore::TrackingTextureAllocator::createTexture):
* platform/graphics/chromium/TrackingTextureAllocator.h:
(WebCore::TrackingTextureAllocator::setTextureUsageHint):
(WebCore::TrackingTextureAllocator::setUseTextureStorageExt):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium: Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures.
https://bugs.webkit.org/show_bug.cgi?id=73621

Add the necessary entry points and enums to GraphicsContext3D.

Reviewed by Kenneth Russell.

* public/platform/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::texStorage2DEXT):
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* tests/MockWebGraphicsContext3D.h:
(WebKit::MockWebGraphicsContext3D::texStorage2DEXT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: WK2: AX hierarchy is not restored after web process crash
cfleizach@apple.com [Mon, 5 Dec 2011 23:34:41 +0000 (23:34 +0000)]
AX: WK2: AX hierarchy is not restored after web process crash
https://bugs.webkit.org/show_bug.cgi?id=73870

The accessibility tokens that need to be sent between UI and Web process
were not being sent by the UI process -> the web process when the web
process crashed.

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _accessibilityRegisterUIProcessTokens]):
(-[WKView _didRelaunchProcess]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTD width in precentage doesn't work.
jchaffraix@webkit.org [Mon, 5 Dec 2011 23:02:34 +0000 (23:02 +0000)]
TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Unreviewed rebaselining on Chromium after r102040.

* platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
* platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png: Removed.
* platform/chromium-win/fast/table/027-expected.png:
* platform/chromium-win/fast/table/027-vertical-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium/tables/mozilla/bugs/bug14929-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: aria-hidden doesn't work on iframe elements
cfleizach@apple.com [Mon, 5 Dec 2011 22:44:28 +0000 (22:44 +0000)]
AX: aria-hidden doesn't work on iframe elements
https://bugs.webkit.org/show_bug.cgi?id=73857

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/iframe-aria-hidden.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addAttachmentChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::addChildren):
* accessibility/AccessibilityScrollView.h:

LayoutTests:

* platform/mac/accessibility/iframe-aria-hidden-expected.txt: Added.
* platform/mac/accessibility/iframe-aria-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother attempted build fix.
abarth@webkit.org [Mon, 5 Dec 2011 22:43:24 +0000 (22:43 +0000)]
Another attempted build fix.

* src/linux/WebFontInfo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: web search mechanism does not work with frames
cfleizach@apple.com [Mon, 5 Dec 2011 22:41:52 +0000 (22:41 +0000)]
AX: web search mechanism does not work with frames
https://bugs.webkit.org/show_bug.cgi?id=73836

Reviewed by Beth Dakin.

Source/WebCore:

This allows searching for, and within, frames for elements using the accessibility
search mechanism.

Test: platform/mac/accessibility/search-with-frames.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::appendAccessibilityObject):
(WebCore::appendChildrenToArray):

LayoutTests:

* platform/mac/accessibility/search-with-frames-expected.txt: Added.
* platform/mac/accessibility/search-with-frames.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLast mouse event could be lost if a JS call to eventSender.leapForward is made
commit-queue@webkit.org [Mon, 5 Dec 2011 22:33:18 +0000 (22:33 +0000)]
Last mouse event could be lost if a JS call to eventSender.leapForward is made
https://bugs.webkit.org/show_bug.cgi?id=73366

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

LayoutTests:

Add test to check if the test driver doesn't eat mouse events when
a JS call to eventSender.leapForward was made. This bug happened at
least on Qt version of WebKitTestRunner.

* fast/events/dont-loose-last-event-expected.txt: Added.
* fast/events/dont-loose-last-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Linux build.
abarth@webkit.org [Mon, 5 Dec 2011 22:27:59 +0000 (22:27 +0000)]
Fix Linux build.

* public/linux/WebFontInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago REGRESSION: Full keyboard access doesn't work if enabled before Safari started
ap@apple.com [Mon, 5 Dec 2011 22:16:48 +0000 (22:16 +0000)]
    REGRESSION: Full keyboard access doesn't work if enabled before Safari started
        https://bugs.webkit.org/show_bug.cgi?id=73864

        Reviewed by Darin Adler.

        * WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Actually use the
        parameter passed at process creation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful...
andersca@apple.com [Mon, 5 Dec 2011 22:13:56 +0000 (22:13 +0000)]
Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
https://bugs.webkit.org/show_bug.cgi?id=73862

Reviewed by Andy Estes.

Source/WebCore:

Change LayerFlushSchedulerClient::flushLayers to return a boolean. If it returns true, the flush was
successful and the run loop observer will be invalidated.

* platform/graphics/ca/LayerFlushScheduler.h:
* platform/graphics/ca/LayerFlushSchedulerClient.h:
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::runLoopObserverCallback):

Source/WebKit/mac:

Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
where we don't want the layer flush scheduler to be invalidated.

* WebView/WebView.mm:
(LayerFlushController::flushLayers):
* WebView/WebViewData.h:

Source/WebKit2:

Change LayerTreeHostCAMac::flushLayers to always return true and remove the call to LayerFlushScheduler::invalidate.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::flushLayers):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove no-longer-used forwarding headers in the WebKit API
abarth@webkit.org [Mon, 5 Dec 2011 22:07:37 +0000 (22:07 +0000)]
[Chromium] Remove no-longer-used forwarding headers in the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=73845

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Delete unused forwarding headers and update includes to the new header
locations.

* WebKit.gyp:
* bridge/PeerConnectionHandlerInternal.cpp:
* bridge/PeerConnectionHandlerInternal.h:
* public/WebArrayBuffer.h:
* public/WebArrayBufferView.h: Removed.
* public/WebAudioBus.h: Removed.
* public/WebAudioDevice.h: Removed.
* public/WebBlobData.h: Removed.
* public/WebBlobRegistry.h: Removed.
* public/WebCString.h: Removed.
* public/WebCanvas.h: Removed.
* public/WebClipboard.h: Removed.
* public/WebColor.h: Removed.
* public/WebColorName.h: Removed.
* public/WebCommon.h: Removed.
* public/WebCompositorInputHandler.h:
* public/WebCookie.h: Removed.
* public/WebCookieJar.h: Removed.
* public/WebData.h: Removed.
* public/WebDragData.h: Removed.
* public/WebFileSystem.h: Removed.
* public/WebFloatPoint.h: Removed.
* public/WebFloatQuad.h: Removed.
* public/WebFloatRect.h: Removed.
* public/WebGamepad.h: Removed.
* public/WebGamepads.h: Removed.
* public/WebGraphicsContext3D.h: Removed.
* public/WebHTTPBody.h: Removed.
* public/WebHTTPHeaderVisitor.h: Removed.
* public/WebHTTPLoadInfo.h: Removed.
* public/WebIDBCallbacks.h:
* public/WebImage.h: Removed.
* public/WebIntent.h:
* public/WebIntentServiceInfo.h:
* public/WebKitPlatformSupport.h: Removed.
* public/WebLocalizedString.h: Removed.
* public/WebMediaStreamDescriptor.h: Removed.
* public/WebMimeRegistry.h: Removed.
* public/WebNonCopyable.h: Removed.
* public/WebPageOverlay.h:
* public/WebPeerConnectionHandler.h: Removed.
* public/WebPeerConnectionHandlerClient.h: Removed.
* public/WebPoint.h: Removed.
* public/WebPrivateOwnPtr.h: Removed.
* public/WebPrivatePtr.h: Removed.
* public/WebRect.h: Removed.
* public/WebSerializedScriptValue.h: Removed.
* public/WebSize.h: Removed.
* public/WebSocketStreamError.h: Removed.
* public/WebSocketStreamHandle.h: Removed.
* public/WebSocketStreamHandleClient.h: Removed.
* public/WebString.h: Removed.
* public/WebThread.h: Removed.
* public/WebThreadSafeData.h: Removed.
* public/WebURL.h: Removed.
* public/WebURLError.h: Removed.
* public/WebURLLoadTiming.h: Removed.
* public/WebURLLoader.h: Removed.
* public/WebURLLoaderClient.h: Removed.
* public/WebURLRequest.h: Removed.
* public/WebURLResponse.h: Removed.
* public/WebVector.h: Removed.
* public/WebWorkerRunLoop.h:
* public/android/WebThemeEngine.h: Removed.
* public/linux/WebFontFamily.h: Removed.
* public/linux/WebThemeEngine.h: Removed.
* public/mac/WebThemeEngine.h: Removed.
* public/win/WebThemeEngine.h: Removed.
* src/ApplicationCacheHost.cpp:
* src/ApplicationCacheHostInternal.h:
* src/AssertMatchingEnums.cpp:
* src/AssociatedURLLoader.cpp:
* src/AssociatedURLLoader.h:
* src/AsyncFileSystemChromium.cpp:
* src/AsyncFileWriterChromium.cpp:
* src/AudioDestinationChromium.cpp:
* src/AudioDestinationChromium.h:
* src/AutofillPopupMenuClient.cpp:
* src/BlobRegistryProxy.cpp:
* src/CCThreadImpl.cpp:
* src/ChromeClientImpl.cpp:
* src/ChromiumCurrentTime.cpp:
* src/ChromiumOSRandomSource.cpp:
* src/ChromiumThreading.cpp:
* src/CompositionUnderlineBuilder.h:
* src/CompositionUnderlineVectorBuilder.h:
* src/ContextMenuClientImpl.cpp:
* src/DragClientImpl.cpp:
* src/DragScrollTimer.h:
* src/ExternalPopupMenu.cpp:
* src/FrameLoaderClientImpl.cpp:
* src/GraphicsContext3DChromium.cpp:
* src/IDBCallbacksProxy.cpp:
* src/IDBCursorBackendProxy.cpp:
* src/IDBFactoryBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.cpp:
* src/InspectorClientImpl.cpp:
* src/InspectorFrontendClientImpl.cpp:
* src/LocalFileSystemChromium.cpp:
* src/LocalizedStrings.cpp:
* src/NotificationPresenterImpl.cpp:
* src/PlatformMessagePortChannel.cpp:
* src/PlatformSupport.cpp:
* src/ResourceHandle.cpp:
* src/ResourceHandleInternal.h:
* src/ScrollbarGroup.cpp:
* src/SharedWorkerRepository.cpp:
* src/SocketStreamHandle.cpp:
* src/SpeechInputClientImpl.cpp:
* src/StorageAreaProxy.cpp:
* src/StorageEventDispatcherChromium.cpp:
* src/StorageNamespaceProxy.cpp:
* src/WebAccessibilityObject.cpp:
* src/WebAnimationControllerImpl.cpp:
* src/WebArrayBufferView.cpp:
* src/WebAttribute.cpp:
* src/WebAudioBus.cpp:
* src/WebBindings.cpp:
* src/WebBlobData.cpp:
* src/WebCString.cpp:
* src/WebColor.cpp:
* src/WebCommon.cpp:
* src/WebCompositorImpl.cpp:
* src/WebCompositorInputHandlerImpl.cpp:
* src/WebContentLayerImpl.cpp:
* src/WebDOMEventListenerPrivate.h:
* src/WebDOMMessageEvent.cpp:
* src/WebDOMStringList.cpp:
* src/WebData.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebDatabase.cpp:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDocument.cpp:
* src/WebDocumentType.cpp:
* src/WebDragData.cpp:
* src/WebEntities.cpp:
* src/WebExternalTextureLayerImpl.cpp:
* src/WebFileChooserCompletionImpl.h:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebFileSystemCallbacksImpl.h:
* src/WebFloatQuad.cpp:
* src/WebFontImpl.cpp:
* src/WebFormElement.cpp:
* src/WebFrameImpl.cpp:
* src/WebGeolocationError.cpp:
* src/WebGeolocationPermissionRequest.cpp:
* src/WebGraphicsContext3D.cpp:
* src/WebHTTPBody.cpp:
* src/WebHTTPLoadInfo.cpp:
* src/WebHistoryItem.cpp:
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBCursorImpl.h:
* src/WebIDBDatabaseCallbacksImpl.cpp:
* src/WebIDBDatabaseCallbacksImpl.h:
* src/WebIDBDatabaseError.cpp:
* src/WebIDBDatabaseImpl.h:
* src/WebIDBIndexImpl.h:
* src/WebIDBKey.cpp:
* src/WebIDBKeyPath.cpp:
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
* src/WebIDBTransactionImpl.h:
* src/WebIconLoadingCompletionImpl.h:
* src/WebImageCG.cpp:
* src/WebImageDecoder.cpp:
* src/WebImageSkia.cpp:
* src/WebInputElement.cpp:
* src/WebKit.cpp:
* src/WebLabelElement.cpp:
* src/WebLayer.cpp:
* src/WebLayerTreeView.cpp:
* src/WebLayerTreeViewImpl.cpp:
* src/WebMediaPlayerClientImpl.cpp:
* src/WebMediaStreamDescriptor.cpp:
* src/WebMediaStreamRegistry.cpp:
* src/WebMediaStreamSource.cpp:
* src/WebNode.cpp:
* src/WebNotification.cpp:
* src/WebOptionElement.cpp:
* src/WebPageSerializer.cpp:
* src/WebPageSerializerImpl.cpp:
* src/WebPageSerializerImpl.h:
* src/WebPluginContainerImpl.cpp:
* src/WebPluginListBuilderImpl.cpp:
* src/WebPluginLoadObserver.h:
* src/WebPopupMenuImpl.cpp:
* src/WebPopupMenuImpl.h:
* src/WebRange.cpp:
* src/WebRegularExpression.cpp:
* src/WebScriptController.cpp:
* src/WebScrollbarImpl.cpp:
* src/WebSecurityOrigin.cpp:
* src/WebSecurityPolicy.cpp:
* src/WebSelectElement.cpp:
* src/WebSerializedScriptValue.cpp:
* src/WebSettingsImpl.cpp:
* src/WebSharedWorkerImpl.cpp:
* src/WebSocketImpl.cpp:
* src/WebSocketImpl.h:
* src/WebSpeechInputControllerMockImpl.cpp:
* src/WebSpeechInputControllerMockImpl.h:
* src/WebStorageAreaImpl.cpp:
* src/WebStorageEventDispatcherImpl.cpp:
* src/WebStorageNamespaceImpl.cpp:
* src/WebString.cpp:
* src/WebTextCheckingCompletionImpl.cpp:
* src/WebThreadSafeData.cpp:
* src/WebURL.cpp:
* src/WebURLError.cpp:
* src/WebURLLoadTiming.cpp:
* src/WebURLRequest.cpp:
* src/WebURLResponse.cpp:
* src/WebURLResponsePrivate.h:
* src/WebUserMediaRequest.cpp:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerClientImpl.h:
* src/WebWorkerImpl.cpp:
* src/WorkerAsyncFileSystemChromium.cpp:
* src/WorkerAsyncFileWriterChromium.cpp:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
* src/WorkerFileWriterCallbacksBridge.cpp:
* src/WrappedResourceRequest.h:
* src/WrappedResourceResponse.h:
* src/mac/WebSubstringUtil.mm:
* tests/AssociatedURLLoaderTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/FrameTestHelpers.cpp:
* tests/MockWebGraphicsContext3D.h:
* tests/PopupMenuTest.cpp:
* tests/RunAllTests.cpp:
* tests/WebLayerTest.cpp:
* tests/WebPageNewSerializerTest.cpp:
* tests/WebPageSerializerTest.cpp:
* tests/WebURLRequestTest.cpp:
* tests/WebUnitTests.h:
* tests/WebViewTest.cpp:

Tools:

Update includes to point to the new header locations.

* DumpRenderTree/chromium/AccessibilityController.cpp:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
* DumpRenderTree/chromium/CppBoundClass.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsClient.h:
* DumpRenderTree/chromium/EventSender.cpp:
* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/chromium/GamepadController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/MockSpellCheck.cpp:
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/PlainTextController.cpp:
* DumpRenderTree/chromium/Task.cpp:
* DumpRenderTree/chromium/TestNavigationController.h:
* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/TestWebPlugin.cpp:
* DumpRenderTree/chromium/TestWebPlugin.h:
* DumpRenderTree/chromium/TextInputController.cpp:
* DumpRenderTree/chromium/WebPermissions.cpp:
* DumpRenderTree/chromium/WebPreferences.h:
* DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
* DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
* DumpRenderTree/chromium/WebViewHost.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Set opaque flag for ImageLayerChromium
commit-queue@webkit.org [Mon, 5 Dec 2011 21:55:56 +0000 (21:55 +0000)]
[chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/ImageLayerChromiumTest.cpp.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/ImageLayerChromiumTest.cpp: Added.
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::~TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOld JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
fpizlo@apple.com [Mon, 5 Dec 2011 21:45:30 +0000 (21:45 +0000)]
Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
were compact offsets
https://bugs.webkit.org/show_bug.cgi?id=73861

Reviewed by Gavin Barraclough.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchPutById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Aharon Lanin to the contributors list.
rniwa@webkit.org [Mon, 5 Dec 2011 21:44:23 +0000 (21:44 +0000)]
Add Aharon Lanin to the contributors list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTD width in precentage doesn't work.
jchaffraix@webkit.org [Mon, 5 Dec 2011 21:38:50 +0000 (21:38 +0000)]
TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/colspan-with-all-percent-cells.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
In the case where all our columns have percent lengths, split the colspan
logical width using the percentages from the lengths. This should be properly
handled by the massive 'else' case but it is not and I did not feel like refactor
that due to massive compatibility issues that would arise.

LayoutTests:

* fast/table/colspan-with-all-percent-cells-expected.png: Added.
* fast/table/colspan-with-all-percent-cells-expected.txt: Added.
* fast/table/colspan-with-all-percent-cells.html: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-linux/fast/table/027-expected.png:
* platform/chromium-linux/fast/table/027-vertical-expected.png:
* platform/chromium-mac/fast/table/027-vertical-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-win/fast/table/027-expected.txt:
* platform/chromium-win/fast/table/027-vertical-expected.txt:
* platform/mac/fast/table/027-expected.png:
* platform/mac/fast/table/027-expected.txt:
* platform/mac/fast/table/027-vertical-expected.png:
* platform/mac/fast/table/027-vertical-expected.txt:
* platform/mac/tables/mozilla/bugs/bug14929-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2947-expected.png:
* platform/mac/tables/mozilla/bugs/bug2947-expected.txt:
Those changes are just rebaselines which now matches Firefox Nighly
more closely (thus progressions).

* platform/chromium/test_expectations.txt: Skipped Windows that needs a new baseline.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:
Skipped the previous tests as they need a rebaseline on those platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests rebaseline.
alokp@chromium.org [Mon, 5 Dec 2011 21:27:38 +0000 (21:27 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium/compositing/scaling: Added.
* platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fixes for ARM.
fpizlo@apple.com [Mon, 5 Dec 2011 21:25:18 +0000 (21:25 +0000)]
Unreviewed, build fixes for ARM.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::unreachableForPlatform):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoving myself from contributors to committers.
jarred@sencha.com [Mon, 5 Dec 2011 21:23:54 +0000 (21:23 +0000)]
Moving myself from contributors to committers.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd myself as a committer.
kubo@profusion.mobi [Mon, 5 Dec 2011 21:22:10 +0000 (21:22 +0000)]
Add myself as a committer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Rename QQuickWebView::canStop property to just loading
commit-queue@webkit.org [Mon, 5 Dec 2011 21:16:02 +0000 (21:16 +0000)]
[Qt] Rename QQuickWebView::canStop property to just loading
https://bugs.webkit.org/show_bug.cgi?id=73813

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Renamed canStop property of QQuickWebView and QtWebPageProxy
to loading and updated tests.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::loading):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loading):
* UIProcess/qt/QtWebPageProxy.h:

Tools:

Replaced references to WebView.canStop with WebView.loading.

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
alokp@chromium.org [Mon, 5 Dec 2011 21:13:36 +0000 (21:13 +0000)]
[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062

Unreviewed chromium rebaseline.

* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoplatform/mac/accessibility/search-when-element-starts-in-table.html is failing
cfleizach@apple.com [Mon, 5 Dec 2011 20:59:24 +0000 (20:59 +0000)]
platform/mac/accessibility/search-when-element-starts-in-table.html is failing
https://bugs.webkit.org/show_bug.cgi?id=73751

Source/WebCore:

When encountering a table, the rows() and not the cells() should be queried (otherwise
we can end up finding the element we started with).

When searching in reverse, we also need to account for searching elements within the
parent hierarchy. because technically it is "behind" the start element.

Reviewed by Darin Adler.

* accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::objectMatchesSearchCriteriaWithResultLimit):
(WebCore::AccessibilityObject::findMatchingObjects):
* accessibility/AccessibilityObject.h:

LayoutTests:

Updated tests to be more comprehensive.

Reviewed by Darin Adler.

* platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
* platform/mac/accessibility/search-when-element-starts-in-table.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agorun-webkit-tests: limit --child-processes properly on apple mac
dpranke@chromium.org [Mon, 5 Dec 2011 20:47:59 +0000 (20:47 +0000)]
run-webkit-tests: limit --child-processes properly on apple mac
https://bugs.webkit.org/show_bug.cgi?id=73856

Reviewed by Adam Roben.

Fix typos in r102013 so that we correctly pass --child-processes=1 on
the apple mac bots temporarily.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate String::containsOnlyLatin1() to avoid converting to 16 bits
benjamin@webkit.org [Mon, 5 Dec 2011 20:27:47 +0000 (20:27 +0000)]
Update String::containsOnlyLatin1() to avoid converting to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=73797

Reviewed by Andreas Kling.

When the String use 8bits StringImpl, there is no need to iterate
over the string.

The function charactersAreAllLatin1() is removed because it is not
used anywhere.

* wtf/text/WTFString.h:
(WTF::String::containsOnlyLatin1):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline tests after the patch for BUGWK73247
alokp@chromium.org [Mon, 5 Dec 2011 20:03:59 +0000 (20:03 +0000)]
Rebaseline tests after the patch for BUGWK73247
https://bugs.webkit.org/show_bug.cgi?id=73848

Unreviewed chromium rebaseline.

* platform/chromium-cg-mac-leopard/compositing/color-matching: Added.
* platform/chromium-cg-mac-leopard/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/direct-image-compositing-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/iframes: Added.
* platform/chromium-cg-mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/reflections: Added.
* platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/scaling: Removed.
* platform/chromium-cg-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
* platform/chromium-cg-mac-leopard/compositing/shadows: Added.
* platform/chromium-cg-mac-leopard/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-cg-mac-leopard/platform/chromium/compositing: Added.
* platform/chromium-cg-mac-leopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac-leopard/platform/chromium/compositing/layout-width-change-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/color-matching: Added.
* platform/chromium-cg-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-cg-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/iframes: Added.
* platform/chromium-cg-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/reflections: Added.
* platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/scaling: Removed.
* platform/chromium-cg-mac-snowleopard/compositing/shadows: Added.
* platform/chromium-cg-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/media/video-layer-crash-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/media/video-transformed-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-cg-mac/compositing/color-matching: Removed.
* platform/chromium-cg-mac/compositing/color-matching/image-color-matching-expected.png: Removed.
* platform/chromium-cg-mac/compositing/direct-image-compositing-expected.png: Removed.
* platform/chromium-cg-mac/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
* platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
* platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
* platform/chromium-cg-mac/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
* platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
* platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
* platform/chromium-cg-mac/compositing/reflections/nested-reflection-transition-expected.png: Removed.
* platform/chromium-cg-mac/compositing/reflections/reflection-in-composited-expected.png: Removed.
* platform/chromium-cg-mac/compositing/shadows: Removed.
* platform/chromium-cg-mac/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-cg-mac/media/video-layer-crash-expected.png: Removed.
* platform/chromium-cg-mac/media/video-transformed-expected.png: Removed.
* platform/chromium-gpu-cg-mac/media/video-layer-crash-expected.png:
* platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
* platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
* platform/chromium-gpu-mac/media/video-transformed-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-win/media/video-layer-crash-expected.png:
* platform/chromium-gpu-win/media/video-layer-crash-expected.txt: Added.
* platform/chromium-gpu-win/media/video-transformed-expected.png:
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
* platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-transformed-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png:
* platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-mac-leopard/compositing/color-matching: Added.
* platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png: Added.
* platform/chromium-mac-leopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
* platform/chromium-mac-leopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
* platform/chromium-mac-leopard/compositing/iframes: Added.
* platform/chromium-mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-mac-leopard/compositing/reflections: Added.
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/chromium-mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
* platform/chromium-mac-leopard/compositing/shadows: Added.
* platform/chromium-mac-leopard/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-mac-leopard/platform/chromium/compositing: Added.
* platform/chromium-mac-leopard/platform/chromium/compositing/layout-width-change-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/color-matching: Added.
* platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/iframes: Added.
* platform/chromium-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/shadows: Added.
* platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/visibility: Added.
* platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png: Removed.
* platform/chromium-mac/compositing/direct-image-compositing-expected.png: Removed.
* platform/chromium-mac/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
* platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
* platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
* platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
* platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
* platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
* platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Removed.
* platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png: Removed.
* platform/chromium-mac/compositing/shadows: Removed.
* platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-mac/compositing/visibility: Removed.
* platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Removed.
* platform/chromium-mac/media/video-layer-crash-expected.png: Removed.
* platform/chromium-mac/media/video-transformed-expected.png: Removed.
* platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-win/compositing/direct-image-compositing-expected.png:
* platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-win/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-transformed-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-transformed2-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
* platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png:
* platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png: Added.
* platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Replaced.
* platform/chromium/compositing/scaling: Removed.
* platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
* platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Replaced.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<video> elements should disable the system and display sleep when playing on OS X.
jer.noble@apple.com [Mon, 5 Dec 2011 19:47:19 +0000 (19:47 +0000)]
<video> elements should disable the system and display sleep when playing on OS X.
https://bugs.webkit.org/show_bug.cgi?id=73730
<rdar://problem/9502155>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests; platform specific system behavior only.

Create a new DisplaySleepDisabler object when the playback rate becomes non-zero, and destroy
that object when the playback rate drops back to zero.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
* html/HTMLMediaElement.h:

Source/WebKit2:

Allow the WebProcess to make connections to the PowerManagement control mach server.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rebaseline of test added in r101537 for Lion.
timothy_horton@apple.com [Mon, 5 Dec 2011 19:33:12 +0000 (19:33 +0000)]
Unreviewed rebaseline of test added in r101537 for Lion.

* platform/mac/svg/text/non-bmp-positioning-lists-expected.png:
* platform/mac/svg/text/non-bmp-positioning-lists-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove forwarding headers for WebLayer APIs
jamesr@google.com [Mon, 5 Dec 2011 19:12:26 +0000 (19:12 +0000)]
[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

* WebKit.gyp:
* public/WebContentLayer.h: Removed.
* public/WebContentLayerClient.h: Removed.
* public/WebExternalTextureLayer.h: Removed.
* public/WebLayer.h: Removed.
* public/WebLayerClient.h: Removed.
* public/WebLayerTreeView.h: Removed.
* public/WebLayerTreeViewClient.h: Removed.
* src/WebLayerTreeView.cpp:
* src/WebLayerTreeViewImpl.cpp:
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
peter@chromium.org [Mon, 5 Dec 2011 19:10:21 +0000 (19:10 +0000)]
[Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
https://bugs.webkit.org/show_bug.cgi?id=73672

Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land
of an older file from the Android port:
http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704

Add IconChromiumAndroid.cpp which nullifies the rendering of icons in
file upload boxes, which is not something we want to support now. Also
include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp
as their functionality can be re-used for Android.

Reviewed by Adam Barth.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/KeyCodeConversionAndroid.cpp: Added.
(WebCore::windowsKeyCodeForKeyEvent):
* platform/graphics/chromium/IconChromiumAndroid.cpp: Added.
(WebCore::Icon::Icon):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago8 bit string work slows down Kraken json-stringify-tinderbox
msaboff@apple.com [Mon, 5 Dec 2011 19:08:44 +0000 (19:08 +0000)]
8 bit string work slows down Kraken json-stringify-tinderbox
https://bugs.webkit.org/show_bug.cgi?id=73457

Added 8 bit path to StringBuilder.  StringBuilder starts
assuming 8 bit contents and gets converted to 16 bit upon
seeing the first 16 bit character or string.  Split
appendUninitialiezed into an inlined fast and function call
slow case.

Factored out the processing of the UString argument from
Stringifier::appendQuotedString() to a static templated function
based on character size.

This change eliminates 5% of the 7% slowdown to json-stringify-tinderbox.
This change introduces a 4.8% slowdown to json-parse-financial.
This slowdown will be addressed in a subsequent patch to StringImpl::equal.

Reviewed by Oliver Hunt.

* runtime/JSONObject.cpp:
(JSC::appendStringToUStringBuilder):
(JSC::Stringifier::appendQuotedString):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::LChar):
(WTF::UChar):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters8):
(WTF::StringBuilder::characters16):
(WTF::StringBuilder::charactersBlah):
(WTF::LChar):
(WTF::UChar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-12-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 5 Dec 2011 18:46:55 +0000 (18:46 +0000)]
2011-12-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Sam Weinig.

        On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
        https://bugs.webkit.org/show_bug.cgi?id=73841
        <rdar://problem/10521879>

        No test since repro case involves dropping a file onto the WebView.

        Calling characters() explicitly causes a non-terminated string buffer to get passed back
        to the String() constructor that expects a terminated buffer. The characters() call isn't
        necessary at all, since we have a String and the method we're calling expects a String.

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[regions] Need to verify the correctness of Win/Linux on overflow break tests
mihnea@adobe.com [Mon, 5 Dec 2011 18:45:30 +0000 (18:45 +0000)]
[regions] Need to verify the correctness of Win/Linux on overflow break tests
https://bugs.webkit.org/show_bug.cgi?id=73332

Reviewed by Tony Chang.

Using a monospace font (instead of Times) provides closer rendering results on several platforms
when used with text-align:justify.

* fast/regions/region-overflow-auto-overflow-hidden.html:
* fast/regions/region-overflow-auto-overflow-visible.html:
* fast/regions/region-overflow-break.html:
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
* platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-break-expected.png: Removed.
* platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove code for connections to/from the UIProcess/WebProcess into WebConnection subclasses
weinig@apple.com [Mon, 5 Dec 2011 18:41:53 +0000 (18:41 +0000)]
Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses
https://bugs.webkit.org/show_bug.cgi?id=73779

Reviewed by Anders Carlsson.

To allow for API objects representing the connection going to/from the UIProcess/WebProcess,
this patch separates out the connections into WebConnection subclasses.  It does not yet
expose a way to access these connections, and is therefore not yet testable.

* GNUmakefile.am:
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

* Platform/CoreIPC/MessageID.h:
* Shared/CoreIPCSupport/WebConnectionMessageKinds.h: Added.
Add a new message type for communicating between WebConnections.

* Shared/ChildProcess.h:
Make helper public so that WebConnectionToWebProcess can use it.

* UIProcess/WebConnectionToWebProcess.cpp: Added.
(WebKit::WebConnectionToWebProcess::create):
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
(WebKit::WebConnectionToWebProcess::invalidate):
(WebKit::WebConnectionToWebProcess::postMessage):
(WebKit::WebConnectionToWebProcess::didReceiveMessage):
(WebKit::WebConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::WebConnectionToWebProcess::didClose):
(WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
(WebKit::WebConnectionToWebProcess::syncMessageSendTimedOut):
(WebKit::WebConnectionToWebProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply):
* UIProcess/WebConnectionToWebProcess.h: Added.
(WebKit::WebConnectionToWebProcess::connection):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendMessage):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::didFinishLaunching):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::connection):
(WebKit::WebProcessProxy::webConnection):
(WebKit::WebProcessProxy::sendSync):
Thread connection code through WebConnectionToWebProcess.

* WebProcess/WebConnectionToUIProcess.cpp: Added.
(WebKit::WebConnectionToUIProcess::create):
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
(WebKit::WebConnectionToUIProcess::invalidate):
(WebKit::WebConnectionToUIProcess::postMessage):
(WebKit::WebConnectionToUIProcess::didReceiveMessage):
(WebKit::WebConnectionToUIProcess::didReceiveSyncMessage):
(WebKit::WebConnectionToUIProcess::didClose):
(WebKit::WebConnectionToUIProcess::didReceiveInvalidMessage):
(WebKit::WebConnectionToUIProcess::syncMessageSendTimedOut):
(WebKit::WebConnectionToUIProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply):
(WebKit::WebConnectionToUIProcess::willProcessMessageOnClientRunLoop):
* WebProcess/WebConnectionToUIProcess.h: Added.
(WebKit::WebConnectionToUIProcess::connection):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initialize):
(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::removeWebFrame):
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
(WebKit::WebProcess::getWebCoreStatistics):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::connection):
Thread connection code through WebConnectionToUIProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTemporarily set --child-process=1 on Mac because 20+ tests are timing out
rniwa@webkit.org [Mon, 5 Dec 2011 18:40:15 +0000 (18:40 +0000)]
Temporarily set --child-process=1 on Mac because 20+ tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=73840

Reviewed by Simon Fraser.

Temporarily go back to single process mode on Mac.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoKeep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
timothy@apple.com [Mon, 5 Dec 2011 18:40:06 +0000 (18:40 +0000)]
Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
they have been combined into inspector.js.

The InspectorBackend.js file split out of the generated InspectorBackendStub.js
in r101670, and both files are needed to be useful.

https://webkit.org/b/73839

Reviewed by Joseph Pecoraro and Brian Weinstein.

* WebCore.xcodeproj/project.pbxproj: Pass -not -name "InspectorBackend*.js" to find
instead of -not -name InspectorBackendStub.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=73624
barraclough@apple.com [Mon, 5 Dec 2011 18:25:45 +0000 (18:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73624
JIT + INTERPRETER builds are broken

Reviewed by Geoff Garen, Sam Weinig.

These don't fallback to the interpreter correctly.
Thunk creation assumes that is the JIT is compiled in, then it is enabled.

* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Marking animations/animation-add-events-in-handler CRASH in test_expectations
scheib@chromium.org [Mon, 5 Dec 2011 18:13:13 +0000 (18:13 +0000)]
[Chromium] Marking animations/animation-add-events-in-handler CRASH in test_expectations

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Rebaselining aria-checkbox-sends-notification-expected
scheib@chromium.org [Mon, 5 Dec 2011 17:59:01 +0000 (17:59 +0000)]
[Chromium] Rebaselining aria-checkbox-sends-notification-expected

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Expected flakey tests after fix for 73021 is committed
scheib@chromium.org [Mon, 5 Dec 2011 17:47:57 +0000 (17:47 +0000)]
[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-05

* platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke: Added.
* platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Expected flakey tests after fix for 65796 is committed
scheib@chromium.org [Mon, 5 Dec 2011 17:42:21 +0000 (17:42 +0000)]
[Chromium] Expected flakey tests after fix for 65796 is committed
https://bugs.webkit.org/show_bug.cgi?id=73587

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-05

* platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/chromium/test_expectations.txt: Removed redundant flakey

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [Chromium] Heap profiler should designate weak references.
mnaganov@chromium.org [Mon, 5 Dec 2011 17:29:50 +0000 (17:29 +0000)]
Web Inspector: [Chromium] Heap profiler should designate weak references.
https://bugs.webkit.org/show_bug.cgi?id=69948

Weak references are now ignored when tracing paths to GC roots.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdge.prototype.get isWeak):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotEdge.prototype.get _hasStringName):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
(WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r102004.
vsevik@chromium.org [Mon, 5 Dec 2011 17:07:30 +0000 (17:07 +0000)]
Unreviewed, rolling out r102004.
http://trac.webkit.org/changeset/102004
https://bugs.webkit.org/show_bug.cgi?id=73835

Breaks qt minimal release compilation (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

* inspector/CodeGeneratorInspector.py:
(Capitalizer.upper_camel_case_to_lower):
(RawTypes.get):
(RawTypes.String.get_c_param_type):
(RawTypes.Object.get_c_param_type):
(RawTypes.Object):
(ParamType):
(TypeData.__init__):
(TypeData.get_raw_type):
(TypeMap.__init__):
(InspectorFrontend_h):
(InspectorArray):
(InspectorObject):
(String):
(InspectorBackendDispatcher_h):
(Generator.process_command):
* inspector/InspectorValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [protocol] generate C++ classes for protocol JSON named types
commit-queue@webkit.org [Mon, 5 Dec 2011 16:56:01 +0000 (16:56 +0000)]
Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-05
Reviewed by Yury Semikhatsky.

Extends python generator functionality.
Makes constructor in InspectorObject public.

* inspector/CodeGeneratorInspector.py:
* inspector/InspectorValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: fix fronted compilation.
podivilov@chromium.org [Mon, 5 Dec 2011 16:24:52 +0000 (16:24 +0000)]
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=73831

Reviewed by Yury Semikhatsky.

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMappingPayload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove viewModeChanged() from QQuickWebView
laszlo.1.gombos@nokia.com [Mon, 5 Dec 2011 16:17:51 +0000 (16:17 +0000)]
[Qt] Remove viewModeChanged() from QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=73828

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview_p.h: viewModeChanged is not used
and we should not expose it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add Source/qtwebkitversion.h to .gitignore
commit-queue@webkit.org [Mon, 5 Dec 2011 15:53:02 +0000 (15:53 +0000)]
[Qt] Add Source/qtwebkitversion.h to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=73823

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Tor Arne Vestbø.

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRedeploy apple-macpro-7 and apple-xserve-1
aroben@apple.com [Mon, 5 Dec 2011 15:52:21 +0000 (15:52 +0000)]
Redeploy apple-macpro-7 and apple-xserve-1

These slaves have been sitting idle since we removed our Leopard builders in r97496.

Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
sitting idle

Reviewed by Sam Weinig.

* BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
(WebKit2 Tests)".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOut-of-band text tracks may only load from same origin as the media element's Documen...
eric.carlson@apple.com [Mon, 5 Dec 2011 15:38:11 +0000 (15:38 +0000)]
Out-of-band text tracks may only load from same origin as the media element's Document's origin
https://bugs.webkit.org/show_bug.cgi?id=73184

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/security/text-track-crossorigin.html

* html/HTMLTrackElement.cpp:
(WebCore::urlForLogging): Debug-only function for logging urls.
(WebCore::HTMLTrackElement::scheduleLoad): Call canLoadUrl() before passing control off to
    the Track.
(WebCore::HTMLTrackElement::canLoadUrl): Don't ask HTMLMediaElement to validate the url, the
    requirements for <track> are different from <video>.
(WebCore::HTMLTrackElement::didCompleteLoad): Change bool param to enum.
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute): New, return parent 'crossorigin'
    attribute value.
* html/HTMLTrackElement.h:

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::scheduleLoad): Add comments from the spec.
(WebCore::LoadableTextTrack::loadTimerFired): Always cancel pending loads. Let the caller know
    if the loader refuses the url immediately.
(WebCore::LoadableTextTrack::cueLoadingStarted): The <track> deals with readyState.
(WebCore::LoadableTextTrack::cueLoadingCompleted): HTMLTrackElement::didCompleteLoad takes
    an enum, not a bool.

* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad): New, log the error and set m_state.
(WebCore::TextTrackLoader::notifyFinished): Check for CORS failure.
(WebCore::TextTrackLoader::load): Take media element cross-origin attribute as a param so we
    can make the correct checks.
* loader/TextTrackLoader.h:

LayoutTests:

* http/tests/security/resources/captions-with-access-control-headers.php: Added
* http/tests/security/resources/captions.vtt: Added.
* http/tests/security/text-track-crossorigin-expected.txt: Added.
* http/tests/security/text-track-crossorigin.html: Added.
* media/track/track-add-track-expected.txt: Updated results.
* media/track/track-add-track.html: readyState changes as soon as the track url is set.
* platform/efl/Skipped: Skip new test.
* platform/gtk/Skipped: Ditto.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
* platform/wincairo/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago"Raw" pseudo selectors don't match if immediately after a child or descendant combinator
rolandsteiner@chromium.org [Mon, 5 Dec 2011 15:30:38 +0000 (15:30 +0000)]
"Raw" pseudo selectors don't match if immediately after a child or descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Source/WebCore:

Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements.

Reviewed by Antti Koivisto.

* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):

LayoutTests:

Add tests cases for "raw" shadow pseudo-element selectors with various combinators.
Also add cases with explicit universal '*' selector.

Reviewed by Antti Koivisto.

* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:
* fast/css/unknown-pseudo-element-matching-expected.txt:
* fast/css/unknown-pseudo-element-matching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 15:21:18 +0000 (15:21 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make the UI of the MiniBrowser slightly nicer
kenneth@webkit.org [Mon, 5 Dec 2011 14:47:46 +0000 (14:47 +0000)]
[Qt] Make the UI of the MiniBrowser slightly nicer

Rubberstamped by Simon Hausmann.

- Add proper padding
- Show feedback when pressing on the toolbar icons
- Make the text entry better looking

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r101983.
commit-queue@webkit.org [Mon, 5 Dec 2011 14:46:36 +0000 (14:46 +0000)]
Unreviewed, rolling out r101983.
http://trac.webkit.org/changeset/101983
https://bugs.webkit.org/show_bug.cgi?id=73827

It broke all tests on GTK and on Qt in debug mode (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::inDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 14:32:31 +0000 (14:32 +0000)]
Unreviewed chromium tests expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixed chromium DEPS syntax.
vsevik@chromium.org [Mon, 5 Dec 2011 14:16:56 +0000 (14:16 +0000)]
Unreviewed, fixed chromium DEPS syntax.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
vsevik@chromium.org [Mon, 5 Dec 2011 13:50:49 +0000 (13:50 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 13:44:40 +0000 (13:44 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chrmoium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 13:35:05 +0000 (13:35 +0000)]
Unreviewed chrmoium tests rebaseline.

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 12:24:19 +0000 (12:24 +0000)]
Unreviewed chromium tests expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 11:54:02 +0000 (11:54 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<style scoped>: Add 'scoped' attribute
rolandsteiner@chromium.org [Mon, 5 Dec 2011 11:48:28 +0000 (11:48 +0000)]
<style scoped>: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/basic-attribute.html

* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.
Disable test directory, since STYLE_SCOPED is not enabled by default.

Reviewed by Antti Koivisto.

* fast/css/style-scoped/basic-attribute-expected.txt: Added.
* fast/css/style-scoped/basic-attribute.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 11:38:44 +0000 (11:38 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert input-appearance-spinbutton-visibility.html to a reftest
tkent@chromium.org [Mon, 5 Dec 2011 11:26:23 +0000 (11:26 +0000)]
Convert input-appearance-spinbutton-visibility.html to a reftest
https://bugs.webkit.org/show_bug.cgi?id=73807

Reviewed by Hajime Morita.

* fast/forms/input-appearance-spinbutton-visibility-expected.html: Added.
* platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 11:20:10 +0000 (11:20 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Refactoring] Accessing Node::m_document should be minimized.
morrita@google.com [Mon, 5 Dec 2011 11:15:19 +0000 (11:15 +0000)]
[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::inDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening. Add platform specific results.
ossy@webkit.org [Mon, 5 Dec 2011 10:00:11 +0000 (10:00 +0000)]
[Qt] Unreviewed gardening. Add platform specific results.

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2011-12-05

* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png: Added.
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png: Added.
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
* platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 09:50:27 +0000 (09:50 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMacroAssemblerSH4 does not implement readCallTarget
ossy@webkit.org [Mon, 5 Dec 2011 09:41:04 +0000 (09:41 +0000)]
MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-05
Reviewed by Csaba Osztrogonác.

* assembler/MacroAssemblerSH4.h: Support for SH4.
(JSC::MacroAssemblerSH4::readCallTarget):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readCallTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNRWT should handle duplicated expectations
kkristof@inf.u-szeged.hu [Mon, 5 Dec 2011 09:28:10 +0000 (09:28 +0000)]
NRWT should handle duplicated expectations
https://bugs.webkit.org/show_bug.cgi?id=69750

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAsynchronous SpellChecker should consider multiple requests.
commit-queue@webkit.org [Mon, 5 Dec 2011 08:47:33 +0000 (08:47 +0000)]
Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-05
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request

Test: editing/spelling/spellcheck-queue.html

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):
  A structure to have spell check request.
(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):
  When timer is fired, queued request is processed if any.
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):
  When the spellchecker is processing another request, the latest request is queued.
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):
  Enqueues a request. If there is an older request whose root editable element is the same as the request,
  it will be replaced.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

* editing/spelling/spellcheck-queue-expected.txt: Added.
* editing/spelling/spellcheck-queue.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WebCore part of: Add WebKit preferences for text track settings
eric.carlson@apple.com [Mon, 5 Dec 2011 08:42:27 +0000 (08:42 +0000)]
Source/WebCore: WebCore part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

No new tests yet, still nothing to test.

* page/Settings.cpp:
(WebCore::Settings::setShouldDisplaySubtitles): Move the setters to the .cpp file so they
    aren't inlined.
(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.
* page/Settings.h:

Source/WebKit/chromium: WebKit/chromium part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::shouldDisplaySubtitles): Added.
(WebKit::WebSettingsImpl::shouldDisplayCaptions): Ditto.
(WebKit::WebSettingsImpl::shouldDisplayTextDescriptions): Ditto.
* src/WebSettingsImpl.h:

Source/WebKit/mac: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize new preferences to NO.
(-[WebPreferences setShouldDisplaySubtitles:]): Added.
(-[WebPreferences shouldDisplaySubtitles]): Ditto.
(-[WebPreferences setShouldDisplayCaptions:]): Ditto.
(-[WebPreferences shouldDisplayCaptions]): Ditto.
(-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
(-[WebPreferences shouldDisplayTextDescriptions]): Ditto.
* WebView/WebPreferencesPrivate.h:

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.

Source/WebKit/win: WebKit/mac part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.

* WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.

* WebPreferences.cpp:
(WebPreferences::setShouldDisplaySubtitles): Added.
(WebPreferences::shouldDisplaySubtitles): Ditto.
(WebPreferences::setShouldDisplayCaptions): Ditto.
(WebPreferences::shouldDisplayCaptions): Ditto.
(WebPreferences::setShouldDisplayTextDescriptions): Ditto.
(WebPreferences::shouldDisplayTextDescriptions): Ditto.
* WebPreferences.h: Declare new methods.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* Shared/WebPreferencesStore.h: Declared shouldDisplaySubtitles, shouldDisplayCaptions, and
shouldDisplayTextDescriptions properties with macros. All default to false.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShouldDisplaySubtitles): Added.
(WKPreferencesGetShouldDisplaySubtitles): Ditto.
(WKPreferencesSetShouldDisplayCaptions): Ditto.
(WKPreferencesGetShouldDisplayCaptions): Ditto.
(WKPreferencesSetShouldDisplayTextDescriptions): Ditto.
(WKPreferencesGetShouldDisplayTextDescriptions): Ditto.
* UIProcess/API/C/WKPreferences.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Updates WebCore settings from WebKit2 prefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
ossy@webkit.org [Mon, 5 Dec 2011 08:19:46 +0000 (08:19 +0000)]
[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

* platform/qt/Skipped: Skip the failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImageDecoder setSize() should check for backing store allocation failure
noel.gordon@gmail.com [Mon, 5 Dec 2011 07:58:18 +0000 (07:58 +0000)]
ImageDecoder setSize() should check for backing store allocation failure
https://bugs.webkit.org/show_bug.cgi?id=72864

Reviewed by Adam Barth.

The backing store of a decoded image is a Vector<PixelData> on the affected
ports. And Vector<> provides a resize capacity member that returns false if
memory allocation fails.

setSize() should be called once only during an image decode - add an ASSERT
for that. Resize the backing store capacity to the requested image size and
return false if memory allocation fails.

ImageDecoder::isOverSize(width, height) is called to check that the decoded
width and height won't overflow 'width x height x sizeof(PixelData)' before
calls to setSize(). Refer to http://webkit.org/b/48634

No new tests. Covered by fast/images/size-failure.html

* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd binary support in WebSocket test server's echo handler.
commit-queue@webkit.org [Mon, 5 Dec 2011 07:42:19 +0000 (07:42 +0000)]
Add binary support in WebSocket test server's echo handler.
https://bugs.webkit.org/show_bug.cgi?id=73649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-04
Reviewed by Eric Seidel.

* http/tests/websocket/tests/hybi/echo_wsh.py: Support binary frames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAfter success with Mac, Win and Gtk, turning on parallel testing
eric@webkit.org [Mon, 5 Dec 2011 06:52:20 +0000 (06:52 +0000)]
After success with Mac, Win and Gtk, turning on parallel testing
by default for all platforms (except Qt).

We'll add more platforms to the blacklist if we see problems.

Unreviewed.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSStyleSheet can't be reparented, enforce this at compile time.
kling@webkit.org [Mon, 5 Dec 2011 05:44:02 +0000 (05:44 +0000)]
CSSStyleSheet can't be reparented, enforce this at compile time.
<http://webkit.org/b/73793>

Reviewed by Benjamin Poulain.

* css/StyleSheet.h:
(WebCore::StyleSheet::clearOwnerRule):

    Changed setParentRule(CSSImportRule*) to clearOwnerRule() to document and
    enforce the fact that style sheets should never be reparented after creation.

(WebCore::StyleSheet::ownerRule):

    Renamed parentRule() to ownerRule() to match the CSSOM name.

(WebCore::StyleSheet::ownerNode):
(WebCore::StyleSheet::clearOwnerNode):

    Also renamed StyleSheet::m_parentNode to m_ownerNode to match its accessors.

* css/CSSStyleSheet.h:

    Removed ownerRule() as we now inherit it from StyleSheet.

* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):

    Update call sites to use the new names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Rebaseline of placeholder tests for r101742 and r101848.
tkent@chromium.org [Mon, 5 Dec 2011 05:24:38 +0000 (05:24 +0000)]
[Chromium] Rebaseline of placeholder tests for r101742 and r101848.

* platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/placeholder-position-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-position-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/search-styled-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png: Removed.
* platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png: Removed.
* platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png: Removed.
* platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png: Removed.
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoborder-width: initial and border-color: initial cannot be removed via CSSOM.
kling@webkit.org [Mon, 5 Dec 2011 02:29:33 +0000 (02:29 +0000)]
border-width: initial and border-color: initial cannot be removed via CSSOM.
<http://webkit.org/b/68551>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/cssom-remove-shorthand-property.html

When asked to remove a shorthand property, we should toss out both the
sub-properties of that shorthand as well as the shorthand itself, should the
declaration contain it. The latter part was missing in our implementation.

* css/CSSMutableStyleDeclaration.h:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
(WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):

    Changed to return true only if something was actually removed.

LayoutTests:

Add a test verifying that shorthand properties can be added/removed
via CSSOM'S CSSStyleDeclaration interface.

* fast/css/cssom-remove-shorthand-property-expected.txt: Added.
* fast/css/cssom-remove-shorthand-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Sun, 4 Dec 2011 23:09:33 +0000 (23:09 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-04

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101969 268f45cc-cd09-0410-ab3c-d52691b4dbfc