WebKit-https.git
9 years agobuild-webkit: make ninja work with chromium linux
dpranke@chromium.org [Wed, 18 Apr 2012 00:29:24 +0000 (00:29 +0000)]
build-webkit: make ninja work with chromium linux
https://bugs.webkit.org/show_bug.cgi?id=84213

Reviewed by Eric Seidel.

Fix typos so that build-webkit will use ninja to
build chromium if a build.ninja file exists and is up-to-date.

* Scripts/webkitdirs.pm:
(determineIsChromiumNinja):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure CSSParser member variables are initialized.
macpherson@chromium.org [Wed, 18 Apr 2012 00:24:06 +0000 (00:24 +0000)]
Ensure CSSParser member variables are initialized.
https://bugs.webkit.org/show_bug.cgi?id=84205

Reviewed by Andreas Kling.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression(114172): Use after free in CustomFilterProgram::notifyClients
achicu@adobe.com [Wed, 18 Apr 2012 00:19:40 +0000 (00:19 +0000)]
Regression(114172): Use after free in CustomFilterProgram::notifyClients
https://bugs.webkit.org/show_bug.cgi?id=84000

Reviewed by Dean Jackson.

The function returned early and the shaders didn't have a chance to be saved. Moving
those two lines before the return false just to make sure that FilterEffectRenderer never adds
itself as a client for a shader without keeping track of that.

No new tests. The problem reproduces with existing tests.
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/effect-custom-combined-missing.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-enable W3C canPlayType() tests on Chromium
commit-queue@webkit.org [Tue, 17 Apr 2012 23:44:22 +0000 (23:44 +0000)]
Re-enable W3C canPlayType() tests on Chromium
https://bugs.webkit.org/show_bug.cgi?id=84164

They use the new expectations override from changeset 112937 and pass after http://crrev.com/132463.

Unreviewed, layout test expectations update.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-17

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug...
jer.noble@apple.com [Tue, 17 Apr 2012 23:26:58 +0000 (23:26 +0000)]
REGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84206

Remove expected failing test results for fast/harness/use-page-cache.html.

* platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
commit-queue@webkit.org [Tue, 17 Apr 2012 23:26:02 +0000 (23:26 +0000)]
IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
https://bugs.webkit.org/show_bug.cgi?id=60746

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Ojan Vafai.

Source/WebCore:

When iterating backwards with PREV_NO_DUPLICATE, keep walking past
the 'prev' key until it changes, then walk forward one time. This
covers the object store and index cases.

Test: storage/indexeddb/mozilla/index-prev-no-duplicate.html

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):

LayoutTests:

Test for PREV_NO_DUPLICATE.

* storage/indexeddb/cursor-prev-no-duplicate.html: Added.
* storage/indexeddb/cursor-prev-no-duplicate.txt: Added.
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: Added.
* storage/indexeddb/mozilla/index-prev-no-duplicate.html: Added.
* storage/indexeddb/resources/cursor-prev-no-duplicate.js: Added.
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(runAllTests):
(waitFor):
(complete.fireCallback):
(complete):
(testFarRangeCursor):
(makeOpenKeyCursor):
(runTest.trans.oncomplete):
(runTest.testFunction):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, unskip some WebSocket worker tests that should not be skipped.
yutak@chromium.org [Tue, 17 Apr 2012 23:20:45 +0000 (23:20 +0000)]
Unreviewed, unskip some WebSocket worker tests that should not be skipped.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoneed to rebaseline after skia 3695 lands
reed@google.com [Tue, 17 Apr 2012 23:17:49 +0000 (23:17 +0000)]
need to rebaseline after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84184

Unreviewed. expectations change only.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCaret is not rendered properly inside an input element with text-indent
yi.4.shen@nokia.com [Tue, 17 Apr 2012 23:10:21 +0000 (23:10 +0000)]
Caret is not rendered properly inside an input element with text-indent
https://bugs.webkit.org/show_bug.cgi?id=82688

Reviewed by Ryosuke Niwa.

For an empty input element, there is no RenderText. Instead, RenderBlock::localCaretRect provides
the caret position for rendering the caret in the empty input element. To get correct caret rect,
textIndentOffset() should be used to adjust the caret's position.

Source/WebCore:

Test: editing/style/text-indent.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):

LayoutTests:

* editing/style/text-indent-expected.txt: Added.
* editing/style/text-indent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd caching to the flakiness dashboard json files
ojan@chromium.org [Tue, 17 Apr 2012 23:08:05 +0000 (23:08 +0000)]
Add caching to the flakiness dashboard json files
https://bugs.webkit.org/show_bug.cgi?id=84198

Reviewed by Dirk Pranke.

* TestResultServer/handlers/testfilehandler.py:
(GetFile._get_file_list):
(GetFile._get_file_content):
(GetFile._get_file_content_from_key):
(GetFile._get_test_list_json):
(GetFile._serve_json):
Add a Last-Modified header and handle If-Modified-Since headers.
(GetFile.get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix Windows build.
fpizlo@apple.com [Tue, 17 Apr 2012 23:03:40 +0000 (23:03 +0000)]
Attempt to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] enable V8RecursionScope debug ASSERT()
rafaelw@chromium.org [Tue, 17 Apr 2012 23:02:44 +0000 (23:02 +0000)]
[MutationObservers] enable V8RecursionScope debug ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=84094

Reviewed by Ojan Vafai.

This patch enables the ASSERT() which enforces usage of
V8RecursionScope.

* src/WebKit.cpp:
(WebKit::assertV8RecursionScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt should be possible to create an inheritorID for the global this object without...
fpizlo@apple.com [Tue, 17 Apr 2012 23:01:14 +0000 (23:01 +0000)]
It should be possible to create an inheritorID for the global this object without crashing
https://bugs.webkit.org/show_bug.cgi?id=84200
<rdar://problem/11251082>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
* runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::unwrappedObject):
(JSGlobalThis):
* runtime/JSObject.cpp:
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID):

Source/WebCore:

No new tests, because the circumstances necessary to make this happen are rather hairy.

* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
macpherson@chromium.org [Tue, 17 Apr 2012 22:56:23 +0000 (22:56 +0000)]
Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
https://bugs.webkit.org/show_bug.cgi?id=83544

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

The code as it stands appears to be correct, but static analysis was concerned that value could become null.
This patch adds a null check and ASSERT_NOT_REACHED() to make the code more obviously correct.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
danakj@chromium.org [Tue, 17 Apr 2012 22:48:21 +0000 (22:48 +0000)]
[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
https://bugs.webkit.org/show_bug.cgi?id=84182

Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:

Source/WebKit/chromium:

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit2: Need a client callback for when the user tires to interact with an...
andersca@apple.com [Tue, 17 Apr 2012 22:43:44 +0000 (22:43 +0000)]
Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
fires while it's already unresponsive.

* UIProcess/API/C/WKPage.h:
* UIProcess/ResponsivenessTimer.cpp:
(WebKit):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
* UIProcess/ResponsivenessTimer.h:
(Client):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit):
* UIProcess/WebProcessProxy.h:
(WebProcessProxy):

Tools: Need a client callback for when the user tries to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add new client functions.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add TextureUploader which allows us to use persistent GC3D state for textu...
commit-queue@webkit.org [Tue, 17 Apr 2012 22:42:11 +0000 (22:42 +0000)]
[Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=83972

Patch by David Reveman <reveman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

Source/WebCore:

Add TextureUploader class that allows us to add persistent GC3D state to the upload machinery.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::textureUploader):
(LayerRendererChromium):
* platform/graphics/chromium/TextureUploader.cpp: Added.
(WebCore):
(WebCore::AcceleratedTextureUploader::AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::~AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::uploadTexture):
* platform/graphics/chromium/TextureUploader.h: Added.
(WebCore):
(TextureUploader):
(WebCore::TextureUploader::~TextureUploader):
(AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::create):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(WebCore):
(CCTextureUpdater):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

* tests/CCTiledLayerTestCommon.h:
(FakeTextureUploader):
(WebKitTests::FakeTextureUploader::uploadTexture):
(WebKitTests):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property...
scheib@chromium.org [Tue, 17 Apr 2012 22:37:28 +0000 (22:37 +0000)]
[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property.xhtml

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up CSSParser::parseFillRepeat().
macpherson@chromium.org [Tue, 17 Apr 2012 22:16:55 +0000 (22:16 +0000)]
Clean up CSSParser::parseFillRepeat().
https://bugs.webkit.org/show_bug.cgi?id=83547

Reviewed by Kentaro Hara.

Removed multiple unnecessary calls to m_valueList->current().
Restructured logic for parsing second value to make it clearer.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillRepeat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
dpranke@chromium.org [Tue, 17 Apr 2012 22:09:26 +0000 (22:09 +0000)]
nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84190

Reviewed by Ojan Vafai.

LayoutTestHelper would exit when the user typed ctrl-c, but we
would attempt to write to it to shut it down, generating an
IOError.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.stop_helper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorename --experimental-fully-parallel
dpranke@chromium.org [Tue, 17 Apr 2012 22:04:30 +0000 (22:04 +0000)]
rename --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=84188

Reviewed by Ojan Vafai.

I thought this was done long ago; rename
--experimental-fully-parallel to just --fully-parallel and
remove the --no- switch that AFAIK no one uses.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Pass Isolate to toV8Slow()
haraken@chromium.org [Tue, 17 Apr 2012 22:03:45 +0000 (22:03 +0000)]
[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
jchaffraix@webkit.org [Tue, 17 Apr 2012 21:51:22 +0000 (21:51 +0000)]
Fix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83816

Reviewed by James Robinson.

No change in behavior expected.

This code adds several functions on RenderBoxModelObject to forward
to the associated layer. This removes the RenderLayer dependencies
at the call sites.

Currently only RenderBoxModelObject can be hardware accelerated as
we need a RenderLayer, this looks like the best place to put those
new functions.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::contentChanged):
(WebCore::RenderBoxModelObject::hasAcceleratedCompositing):
(WebCore::RenderBoxModelObject::startTransition):
(WebCore::RenderBoxModelObject::transitionPaused):
(WebCore::RenderBoxModelObject::transitionFinished):
(WebCore::RenderBoxModelObject::startAnimation):
(WebCore::RenderBoxModelObject::animationPaused):
(WebCore::RenderBoxModelObject::animationFinished):
(WebCore::RenderBoxModelObject::suspendAnimations):
* rendering/RenderBoxModelObject.h:
Added the previous functions to hide the layer need.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasAcceleratedCompositing):
* rendering/RenderLayer.h:
Removed the previous method as it was superseeded by the
one on RenderBoxModelObject. Also moved the ContentChangeType
enumaration.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentChanged):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
Updated after the ContentChangeType enumaration move.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::reshape):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::freezeAtTime):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::startAnimation):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::endAnimation):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::imageChanged):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
Updated all those call sites to use the new functions. Also
removed unneeded RenderLayer.h include as we went.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG and LLInt should not clobber the frame pointer on ARMv7
fpizlo@apple.com [Tue, 17 Apr 2012 21:41:17 +0000 (21:41 +0000)]
DFG and LLInt should not clobber the frame pointer on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84185
<rdar://problem/10767252>

Reviewed by Gavin Barraclough.

Changed LLInt to use a different register. Changed DFG to use one fewer
registers. We should revisit this and switch the DFG to use a different
register instead of r7, but we can do that in a subsequent step since
the performance effect is tiny.

* dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
* offlineasm/armv7.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago-webkit-mask-box-image does not draw when layer tree flattening is enabled
aestes@apple.com [Tue, 17 Apr 2012 21:32:37 +0000 (21:32 +0000)]
-webkit-mask-box-image does not draw when layer tree flattening is enabled
https://bugs.webkit.org/show_bug.cgi?id=84111

Reviewed by Simon Fraser.

No new tests since taking pixel test results with
PaintBehaviorFlattenCompositingLayers set is not currently supported.
<https://bugs.webkit.org/show_bug.cgi?id=84110> tracks fixing this.

When painting mask images, we should take the non-composited path if
layers are being flattened.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintMask):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintMaskImages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRollout r114404 as it broke a couple of chromium builds.
eae@chromium.org [Tue, 17 Apr 2012 20:56:12 +0000 (20:56 +0000)]
Rollout r114404 as it broke a couple of chromium builds.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago`localStorage.setItem` can overwrite `localStorage` methods
benm@google.com [Tue, 17 Apr 2012 20:32:22 +0000 (20:32 +0000)]
`localStorage.setItem` can overwrite `localStorage` methods
https://bugs.webkit.org/show_bug.cgi?id=30996

Source/WebCore:

Update the JSC and V8 bindings such that if the name of the DOM
Storage property being retrieved is a match for a property in the
prototype, always return the prototype version. If there is a DOM
Storage key of the same name, it can still be retrieved via the
getItem method. This prevents storage methods from being
accidentally hidden. This brings WebKit behavior in line with the
de facto standard implemented by FireFox and IE.

Reviewed by Kentaro Hara.

Test: storage/domstorage/storage-functions-not-overwritten.html

* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::nameGetter):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyGetter):

LayoutTests:

Add a test to verify that setting a DOM Storage key with the same name
as a function on the Storage object does not prevent that function
being called, but also that it can still be retrieved via the getItem
function.

Reviewed by Kentaro Hara.

* storage/domstorage/script-tests/storage-functions-not-overwritten.js: Added.
(doWedgeThySelf):
(testStorage):
(runTest):
* storage/domstorage/storage-functions-not-overwritten-expected.txt: Added.
* storage/domstorage/storage-functions-not-overwritten.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.
scheib@chromium.org [Tue, 17 Apr 2012 20:25:30 +0000 (20:25 +0000)]
[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.

Unreviewed.

* platform/chromium-mac-leopard/fast/text/international/bidi-menulist-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium/Windows build broken by r114404.
eae@chromium.org [Tue, 17 Apr 2012 20:21:53 +0000 (20:21 +0000)]
Fix Chromium/Windows build broken by r114404.

* platform/FractionalLayoutUnit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReorganise Chromium test_expectations to group SVG expectations.
schenney@chromium.org [Tue, 17 Apr 2012 20:08:11 +0000 (20:08 +0000)]
Reorganise Chromium test_expectations to group SVG expectations.

Unreviewed Chromium expectations change.

This is done to make future maintenance easier.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEFL's LayoutTestController does not implement callShouldCloseOnWebView
commit-queue@webkit.org [Tue, 17 Apr 2012 20:05:57 +0000 (20:05 +0000)]
EFL's LayoutTestController does not implement callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Martin Robinson.

Source/WebKit/efl:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related
test to be removed from the skip list.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::callShouldCloseOnWebView):

LayoutTests:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Performance][V8] Skip Isolate look-up to find StringCache
haraken@chromium.org [Tue, 17 Apr 2012 20:05:22 +0000 (20:05 +0000)]
[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103

Reviewed by Nate Chapin.

This patch improves the performance of a lot of DOM attribute
getters that return a string.

- Improves the performance of Dromaeo/dom-attr.html(element.property)
  by 27.7%.
- Improves the performance of Dromaeo/dom-attr.html(getAttribute)
  by 10.6%.
- Improves the performance of div.id, div.className,
  div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.

The followings are the test results in my Linux desktop.

Performance test: Dromaeo/dom-attr.html
Total:                     674.64runs/s ->  707.03runs/s (+ 4.8%)
getAttribute:             1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property:         1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute:              538.88runs/s ->  548.87runs/s (+ 1.9%)
element.property = value:  644.07runs/s ->  656.67runs/s (+ 2.0%)
element.expando = value:   219.76runs/s ->  207.14runs/s (- 6.8%)
element.expando:           578.77runs/s ->  554.67runs/s (- 4.2%)

Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id:           30.70ns -> 26.70ns (+15%)
div.className:    31.10ns -> 26.40ns (+18%)
div.nodeName:     37.70ns -> 33.00ns (+14%)
text.nodeValue:   31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)

Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
* bindings/v8/V8Binding.h:
(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.

* bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just...
commit-queue@webkit.org [Tue, 17 Apr 2012 20:01:15 +0000 (20:01 +0000)]
[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
postProgressFinishedNotification() in order to send notifications all frames,
not just the main one.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

LayoutTests:

Unskip EFL test cases which rely on the DumpRenderTree support for
LayoutTestController's dumpFrameLoadCallbacks() and expect notifications for other
frame than the main one.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add setting API to enable/disable XSSAuditor
commit-queue@webkit.org [Tue, 17 Apr 2012 19:56:47 +0000 (19:56 +0000)]
[EFL] Add setting API to enable/disable XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=83281

Source/WebKit/efl:

Add setting API to enable or disable WebKit's XSSAuditor to protect
from reflective cross-site scripting attacks. Also, emit the signal
'xss,detected' and provide addition information received from
XSSAuditor when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didDetectXSS):
* ewk/ewk_frame.cpp:
(ewk_frame_xss_detected):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_xss_auditor_get):
(ewk_view_setting_enable_xss_auditor_set):
* ewk/ewk_view.h:

Tools:

Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
'xss,detected' in DRT to enable a test, which is expecting a line containing
'didDetectXSS' in the output when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onDidDetectXSS):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

Unskip tests in http/tests/security/xssAuditor

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in invalid index for _textMarkerForIndex
cfleizach@apple.com [Tue, 17 Apr 2012 19:48:15 +0000 (19:48 +0000)]
Crash in invalid index for _textMarkerForIndex
https://bugs.webkit.org/show_bug.cgi?id=84104

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):

LayoutTests:

* platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Added.
* platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTML5 Video Full Screen button broken (looks like white square)
jer.noble@apple.com [Tue, 17 Apr 2012 19:44:08 +0000 (19:44 +0000)]
HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests; updated platform results which were previously rebaselined.

Use the correct CSS keyword for the -webkit-appearance of the full screen button.

* css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

* platform/mac/media/controls-after-reload-expected.png:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.png:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG should support transform-origin and relative values
schenney@chromium.org [Tue, 17 Apr 2012 19:33:51 +0000 (19:33 +0000)]
SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Unreviewed Chromium expectations update.

* platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Added.
* platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPaddings and borders on root SVG element with viewbox causes child SVG elements to...
schenney@chromium.org [Tue, 17 Apr 2012 19:30:21 +0000 (19:30 +0000)]
Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac/svg/custom/circle-move-invalidation-expected.png: Added.
* platform/chromium-win/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake sure that the layer hosting mode is kept up to date if it changes before the...
andersca@apple.com [Tue, 17 Apr 2012 19:24:33 +0000 (19:24 +0000)]
Make sure that the layer hosting mode is kept up to date if it changes before the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=84180
<rdar://problem/11265113>

Reviewed by Andreas Kling.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoonclick is not reliable for transformed SVG elements
schenney@chromium.org [Tue, 17 Apr 2012 19:23:35 +0000 (19:23 +0000)]
onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
* platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agouse after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
fpizlo@apple.com [Tue, 17 Apr 2012 19:22:29 +0000 (19:22 +0000)]
use after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
https://bugs.webkit.org/show_bug.cgi?id=83942
<rdar://problem/11247370>

Reviewed by Gavin Barraclough.

Don't use references to the graph after resizing the graph.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushArgument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetCTM() on SVG root element with borders, paddings, and viewbox returns incorrect...
schenney@chromium.org [Tue, 17 Apr 2012 19:19:13 +0000 (19:19 +0000)]
getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
* platform/chromium-mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-win/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Cleanup of outdated test expectations
schenney@chromium.org [Tue, 17 Apr 2012 19:15:30 +0000 (19:15 +0000)]
[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed Chromium expectations update.

* platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: stub getKey/getObject interfaces for IDBKeyRange
commit-queue@webkit.org [Tue, 17 Apr 2012 19:11:41 +0000 (19:11 +0000)]
IndexedDB: stub getKey/getObject interfaces for IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=84089

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Dimitri Glazkov.

Added stub methods on WebIDBIndex.h to cleanly land
https://bugs.webkit.org/show_bug.cgi?id=83638

* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::getKey):
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit):
(WebKit::WebIDBIndexImpl::getKey):
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
schenney@chromium.org [Tue, 17 Apr 2012 19:09:35 +0000 (19:09 +0000)]
[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=53378

Unreviewed expectations update after the fix went in.

* platform/chromium-linux-x86/svg/zoom: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-win-xp/svg/zoom: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFramesniffing defense is too aggressive.
tsepez@chromium.org [Tue, 17 Apr 2012 19:03:42 +0000 (19:03 +0000)]
Framesniffing defense is too aggressive.
https://bugs.webkit.org/show_bug.cgi?id=83721

Reviewed by James Robinson.

Source/WebCore:

The RenderLayer code currently propagates scroll position to parent frames
without any cross-origin checks.  This gives it a quick origin boundary check
that is set by FrameLoader only when performing a fragment navigation.  This
allows us to safely relax the restriction on not scrolling at load time in
FrameLoader since the safe thing will happen later on at scroll time.

Test: http/tests/navigation/anchor-frames-same-origin.html

* dom/Document.cpp:
(WebCore::Document::findUnsafeParentScrollPropagationBoundary):
* dom/Document.h:
(Document):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):
* loader/FrameLoader.h:
(FrameLoader):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
* page/FrameView.h:
(WebCore::FrameView::safeToPropagateScrollToParent):
(WebCore::FrameView::setSafeToPropagateScrollToParent):
(FrameView):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests:

* http/tests/inspector/resource-parameters-expected.txt:
* http/tests/navigation/anchor-frames-cross-origin-expected.txt:
* http/tests/navigation/anchor-frames-cross-origin.html:
* http/tests/navigation/anchor-frames-same-origin-expected.txt: Added.
* http/tests/navigation/anchor-frames-same-origin.html: Added.
* http/tests/navigation/resources/frame-with-anchor-cross-origin.html:
* http/tests/navigation/resources/frame-with-anchor-same-origin.html: Added.
* http/tests/navigation/resources/grandchild-with-anchor.html: Added.
* http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
* http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoArray.prototype.toString should be generic
barraclough@apple.com [Tue, 17 Apr 2012 18:58:26 +0000 (18:58 +0000)]
Array.prototype.toString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
    - check for join function, use fast case if base object is array & join is present & default.
* runtime/CommonIdentifiers.h:
    - added 'join'.

LayoutTests:

* fast/js/array-functions-non-arrays-expected.txt:
    - check in new results
* fast/js/array-prototype-properties-expected.txt:
    - new more detailed error message.
* fast/js/script-tests/array-functions-non-arrays.js:
    - added new test cases, fix incorrect one.
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.2_Array_prototype_toString/S15.4.4.2_A2_T1-expected.txt:
    - check in failing result (test is wrong)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd size_t versions of multiplication and division operators to FractionalLayoutUnit
eae@chromium.org [Tue, 17 Apr 2012 18:51:50 +0000 (18:51 +0000)]
Add size_t versions of multiplication and division operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848

Reviewed by Julien Chaffraix.

Add size_t versions of operator* and operator/ for platforms where there
is no ambiguity between unsigned int and size_t.

No new tests, no new functionality.

* platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):
(WebCore::operator*):
(WebCore::operator/):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate long-failing Chromium expectations.
schenney@chromium.org [Tue, 17 Apr 2012 18:45:47 +0000 (18:45 +0000)]
Update long-failing Chromium expectations.

Unreviewed Chromium expectation update.

There is some chance that the background test is flaky, as many others are.

* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExiting full screen video brings the wrong Safari window to the foreground
jer.noble@apple.com [Tue, 17 Apr 2012 18:35:48 +0000 (18:35 +0000)]
Exiting full screen video brings the wrong Safari window to the foreground
https://bugs.webkit.org/show_bug.cgi?id=83936

Reviewed by Adele Peterson.

Tell the original webView's window to makeKeyAndOrderFront once the exit
animation completes.

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController finishedExitFullScreenAnimation:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Add an optional Isolate argument to toV8().
haraken@chromium.org [Tue, 17 Apr 2012 18:21:28 +0000 (18:21 +0000)]
[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
Modified as described above.
(GenerateHeader):
(NativeToJSValue):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):

* bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Chromium test expectations for long failing tests.
schenney@chromium.org [Tue, 17 Apr 2012 18:20:54 +0000 (18:20 +0000)]
Update Chromium test expectations for long failing tests.

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/chromium-linux/svg/carto.net/combobox-expected.png: Added.
* platform/chromium-linux/svg/carto.net/combobox-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Create baselines for tests related to caret behaviour
commit-queue@webkit.org [Tue, 17 Apr 2012 18:19:25 +0000 (18:19 +0000)]
[EFL] Create baselines for tests related to caret behaviour
https://bugs.webkit.org/show_bug.cgi?id=83277

Unreviewed, EFL baselines for tests related to cursor
positioning behaviour.

Adding baselines and unskipping tests related to cursor
positioning behaviour after r114250.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17

* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
* platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofill-opacity does not render properly on chromium mac
schenney@chromium.org [Tue, 17 Apr 2012 18:11:20 +0000 (18:11 +0000)]
fill-opacity does not render properly on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=78624

Unreviewed expectations update after this change.

* platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Removed.
* platform/chromium-mac/svg/text/text-fill-opacity-expected.png: Added.
* platform/chromium-win/svg/text/text-fill-opacity-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
commit-queue@webkit.org [Tue, 17 Apr 2012 18:01:42 +0000 (18:01 +0000)]
[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
https://bugs.webkit.org/show_bug.cgi?id=84142

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-04-17
Reviewed by Martin Robinson.

Create a cpp file needed to build EFL port with FULLSCREEN_API.

* PlatformEfl.cmake: Added WebFullScreenManagerProxyEfl.cpp to build list.
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit):
* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp: Added.
(WebKit):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
dglazkov@chromium.org [Tue, 17 Apr 2012 17:59:18 +0000 (17:59 +0000)]
[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
because it was fixed in r113808.

* platform/chromium/test_expectations.txt: Removed flaky expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline after Skia changes (CR105305)
schenney@chromium.org [Tue, 17 Apr 2012 17:57:23 +0000 (17:57 +0000)]
[Chromium] Rebaseline after Skia changes (CR105305)
https://bugs.webkit.org/show_bug.cgi?id=84165

Unreviewed Chromium expectations update.

* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/chromium-linux/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
* platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-linux/svg/text/selection-background-color-expected.png:
* platform/chromium-linux/svg/text/selection-styles-expected.png:
* platform/chromium-linux/svg/text/text-gradient-positioning-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/chromium-mac-leopard/svg/css/composite-shadow-text-expected.png:
* platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/text/selection-styles-expected.png:
* platform/chromium-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
* platform/chromium-mac/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-mac/svg/css/text-gradient-shadow-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/text/selection-styles-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/text/text-gradient-positioning-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Added.
* platform/chromium-win/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew baselines for crbug 104128
schenney@chromium.org [Tue, 17 Apr 2012 17:24:58 +0000 (17:24 +0000)]
new baselines for crbug 104128
https://bugs.webkit.org/show_bug.cgi?id=72746

Unreviewed Chromium expectations update, just for SVG files.

* platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
* platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* platform/mac/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* platform/qt/svg/css/shadow-with-large-radius-expected.txt: Removed.
* platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Removed.
* svg/css/shadow-with-large-radius-expected.txt: Added.
* svg/css/shadow-with-negative-offset-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: move heap snapshot data grids into their own file
yurys@chromium.org [Tue, 17 Apr 2012 17:17:59 +0000 (17:17 +0000)]
Web Inspector: move heap snapshot data grids into their own file
https://bugs.webkit.org/show_bug.cgi?id=84160

Moved heap snapshot data grids into a separate file.

Reviewed by Pavel Feldman.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DataGrid.js:
* inspector/front-end/HeapSnapshotDataGrids.js: Added.
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
* inspector/front-end/HeapSnapshotView.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScript make_names.pl should generate consistent .h & .cpp files
commit-queue@webkit.org [Tue, 17 Apr 2012 17:12:19 +0000 (17:12 +0000)]
Script make_names.pl should generate consistent .h & .cpp files
https://bugs.webkit.org/show_bug.cgi?id=84140

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-17
Reviewed by Kentaro Hara.

Added a newline character and removed ';' after the DEFINE_GLOBAL

No test cases required for this change.

* dom/make_names.pl:
(printNamesCppFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
commit-queue@webkit.org [Tue, 17 Apr 2012 17:09:40 +0000 (17:09 +0000)]
Source/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
and propagate calls to the MediaPlayerPrivate interface.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

Test: http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html

* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::setSourceState):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::sourceAddId):
(WebCore::NullMediaPlayerPrivate::sourceRemoveId):
(WebCore):
(WebCore::MediaPlayer::sourceAddId):
(WebCore::MediaPlayer::sourceRemoveId):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::sourceAddId):
(WebCore::MediaPlayerPrivateInterface::sourceRemoveId):

Source/WebKit/chromium: Add sourceAddId() & sourceRemoveId() stubs for Chromium.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::sourceAddId):
(WebKit::WebMediaPlayer::sourceRemoveId):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::sourceAddId):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceRemoveId):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

LayoutTests: Add LayoutTests for new webkitSourceAddId() & webkitSourceRemoveId() methods.
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

* http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
* http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Refactor the gesture recognizers
abecsi@webkit.org [Tue, 17 Apr 2012 16:41:29 +0000 (16:41 +0000)]
[Qt][WK2] Refactor the gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=83044

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

This patch implements a simple decision tree in the web page event handler
on the basis of how many active touch points the current touch event has.

Active touch points are pressed, moved or stationary and the number of these
fully determine which gesture recognizer should be updated, cancelled or
finished.

This new structure makes the internal states of the pinch and pan gesture
recognizers independent from the event type, thus makes it possible to handle
the transitions between these gestures in one centralized place which reduces
code duplication and complexity and fixes some issues regarding incorrectly
handled transitions.

* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit):
(WebKit::QtPanGestureRecognizer::cancel):
* UIProcess/qt/QtPanGestureRecognizer.h:
(QtPanGestureRecognizer):
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit):
(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
* UIProcess/qt/QtPinchGestureRecognizer.h:
(QtPinchGestureRecognizer):
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
* UIProcess/qt/QtTapGestureRecognizer.h:
(QtTapGestureRecognizer):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with...
apavlov@chromium.org [Tue, 17 Apr 2012 16:31:01 +0000 (16:31 +0000)]
Web Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with open Inspector
https://bugs.webkit.org/show_bug.cgi?id=84154

Source/WebCore:

Check that a node inserted actually has a parent.

Reviewed by Yury Semikhatsky.

Test: inspector/elements/elements-panel-reload-assert.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didInsertDOMNode):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/elements/elements-panel-reload-assert-expected.txt: Added.
* inspector/elements/elements-panel-reload-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
commit-queue@webkit.org [Tue, 17 Apr 2012 16:26:48 +0000 (16:26 +0000)]
[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
https://bugs.webkit.org/show_bug.cgi?id=77533

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-17
Reviewed by Simon Hausmann.

Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
the corresponding parameter to the buildQMakeProjects function.

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
commit-queue@webkit.org [Tue, 17 Apr 2012 16:13:19 +0000 (16:13 +0000)]
[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit "load,started" and "onload,event" signals needed to support
LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
* ewk/ewk_frame.cpp:
(ewk_frame_load_committed):
(ewk_frame_load_started):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_load_started):
(ewk_view_onload_event):
* ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. Make use of the new frame argument passed to
the "load,started" and "load,finished" signals.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Enable back double buffering on WebKitWebView to fix flickering
commit-queue@webkit.org [Tue, 17 Apr 2012 16:12:25 +0000 (16:12 +0000)]
[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149

Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.

Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.

Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.

* webkit/webkitwebview.cpp:
(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r113172) Wheel events are scrolling inversed.
commit-queue@webkit.org [Tue, 17 Apr 2012 16:10:38 +0000 (16:10 +0000)]
REGRESSION(r113172) Wheel events are scrolling inversed.
https://bugs.webkit.org/show_bug.cgi?id=84156

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Consistent checking for clipped rects when we need the computed result...
danakj@chromium.org [Tue, 17 Apr 2012 15:50:20 +0000 (15:50 +0000)]
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Suggest box appears after the command was executed in console sometimes.
vsevik@chromium.org [Tue, 17 Apr 2012 15:38:40 +0000 (15:38 +0000)]
Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148

Reviewed by Pavel Feldman.

TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114376.
commit-queue@webkit.org [Tue, 17 Apr 2012 15:37:03 +0000 (15:37 +0000)]
Unreviewed, rolling out r114376.
http://trac.webkit.org/changeset/114376
https://bugs.webkit.org/show_bug.cgi?id=84155

Wrong patch version committed, asked by the patch author.
(Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-17

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
* ewk/ewk_frame.cpp:
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
* ewk/ewk_view.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onWillSendRequest):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Pattern matching should be applied to numbers
mifenton@rim.com [Tue, 17 Apr 2012 15:20:29 +0000 (15:20 +0000)]
[BlackBerry] Pattern matching should be applied to numbers
https://bugs.webkit.org/show_bug.cgi?id=84152

Reviewed by Antonio Gomes.

PR 148906.

Add pattern matching for number based on [0-9] to trigger
input help matching number fields.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
(BlackBerry::WebKit::DOMSupport::elementPatternMatches):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r105453): Crash when handling touch events
commit-queue@webkit.org [Tue, 17 Apr 2012 15:20:01 +0000 (15:20 +0000)]
REGRESSION (r105453): Crash when handling touch events
https://bugs.webkit.org/show_bug.cgi?id=81958

Patch by Yong Li <yoli@rim.com> on 2012-04-17
Reviewed by Antonio Gomes.

.:

Add a manual test for this issue because DumpRenderTree
currently cannot send a group of touch points with
different touch states in one shot.

* ManualTests/resources/iframe-reloaded-on-touch.html: Added.
* ManualTests/touch-stale-iframe-crash.html: Added.

Source/WebCore:

Always perform sanity checks when handling every touch point
because the node and document may have been destroyed or detached.

ManualTests/touch-stale-iframe-crash.html added.
(DumpRenderTree doesn't support transiting touch states in one shot yet)

* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline svg/carto.net/colourpicker.svg
schenney@chromium.org [Tue, 17 Apr 2012 15:18:37 +0000 (15:18 +0000)]
[Chromium] Rebaseline svg/carto.net/colourpicker.svg

Unreviewed Chromium test expectations update.

This test has been marked as failing for so long that its result is
always wrong. Rebaselining to review flakiness.

* platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
* platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
schenney@chromium.org [Tue, 17 Apr 2012 15:06:37 +0000 (15:06 +0000)]
[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
https://bugs.webkit.org/show_bug.cgi?id=84150

Unreviewed Chromium test expectations update.

* fast/repaint/background-misaligned-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
* platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win-vista/fast/repaint: Added.
* platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
* platform/chromium-win-xp/svg/as-border-image: Removed.
* platform/chromium-win/fast/repaint/background-misaligned-expected.png:
* platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
* platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
commit-queue@webkit.org [Tue, 17 Apr 2012 15:02:36 +0000 (15:02 +0000)]
[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
from postProgressFinishedNotification() since it is already emitted
from dispatchDidFinishLoad(). This avoids unwanted extra signals we
prevent some tests from passing (e.g.
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
* ewk/ewk_frame.cpp:
(ewk_frame_load_committed):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_onload_event):
* ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed ARM build fix
kbalazs@webkit.org [Tue, 17 Apr 2012 14:15:38 +0000 (14:15 +0000)]
[Qt] Unreviewed ARM build fix

* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain): Export this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAsserts in XMLHttpRequestProgressEventThrottle
commit-queue@webkit.org [Tue, 17 Apr 2012 14:02:07 +0000 (14:02 +0000)]
Asserts in XMLHttpRequestProgressEventThrottle
https://bugs.webkit.org/show_bug.cgi?id=81506

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Julien Chaffraix.

Source/WebCore:

The asserts were incorrectly triggered because suspending active DOM objects
(which suspends the XMLHttpRequestProgressEventThrottle) doesn't stop JavaScript
from running or suspend any running loader we may have. The previous code would
assume those 2 cases were impossible.

When XmlHttpRequest::open is called or data is received while the XmlHttpRequest object
is suspended the object may attempt to dispatch events. This patch defers these events
until the object is resumed.

Progress events are coalesced similar to normal throttling, and readystate-change events
are coalesced to avoid identical events emitted right after eachother.

On resume the events are dispatched after a timer to avoid interfering with
ScriptExecutionContext which is iterating over suspended objects.

Test: fast/events/pagehide-xhr-open.html

* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
(WebCore::XMLHttpRequestProgressEventThrottle::resume):
* xml/XMLHttpRequestProgressEventThrottle.h:
(XMLHttpRequestProgressEventThrottle):

LayoutTests:

Tests that xmlhttprequest.open does not assert in when called from onpagehide.

* fast/events/pagehide-xhr-open-expected.txt: Added.
* fast/events/pagehide-xhr-open.html: Added.
* fast/events/resources/subframe-xmlhttprequest.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
vsevik@chromium.org [Tue, 17 Apr 2012 13:44:43 +0000 (13:44 +0000)]
Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035

Reviewed by Pavel Feldman.

Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.

* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: the fix for test after massive rename in r114271.
loislo@chromium.org [Tue, 17 Apr 2012 13:35:32 +0000 (13:35 +0000)]
Web Inspector: the fix for test after massive rename in r114271.
https://bugs.webkit.org/show_bug.cgi?id=84147

Drive by fix. The test was renamed to heap-snapshot.html

Reviewed by Yury Semikhatsky.

* inspector/heap-snapshot.html: Renamed from PerformanceTests/inspector/detailed-heapshots-smoke-test.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
commit-queue@webkit.org [Tue, 17 Apr 2012 13:29:23 +0000 (13:29 +0000)]
[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
https://bugs.webkit.org/show_bug.cgi?id=83035

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

The force_static_libs_as_shared feature for the Qt port will remove
hide_symbols from Qt's CONFIG in order to make them visible to other
libraries again.

Due to an evaluation order problem in qmake, the flags for the C++ compiler
that are set by adding hide_symbols to the CONFIG variables get applied
to qmake's C++ compiler flags directly and hence trying to remove these
later will not work and cause build failures when using the force_static_libs_as_shared
feature of the Qt port.

This is fixed by removing the flags that hide the exports from the compiler flags directly.

* qmake/mkspecs/features/force_static_libs_as_shared.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Zoom out on second double-tap.
commit-queue@webkit.org [Tue, 17 Apr 2012 13:14:50 +0000 (13:14 +0000)]
[Qt] Zoom out on second double-tap.
https://bugs.webkit.org/show_bug.cgi?id=84145

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to rebaseline these images after skia 3695 lands
reed@google.com [Tue, 17 Apr 2012 13:10:45 +0000 (13:10 +0000)]
Need to rebaseline these images after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84144

Unreviewed. Expectations change only

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [regression r112413]content scripts tree outline is not added to the...
pfeldman@chromium.org [Tue, 17 Apr 2012 13:03:55 +0000 (13:03 +0000)]
Web Inspector: [regression r112413]content scripts tree outline is not added to the tab.
https://bugs.webkit.org/show_bug.cgi?id=84146

Reviewed by Vsevolod Vlasov.

Adding the tree to the container.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
commit-queue@webkit.org [Tue, 17 Apr 2012 11:56:19 +0000 (11:56 +0000)]
[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=83285

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

* platform/ContextMenuItem.h: Remove macro around enums - needed by InjectedBundle.
(WebCore):
* platform/Widget.h: Remove namespace WebCore for PlatformPageClient typedef.

Source/WebKit/efl:

Remove WebCore namespace from PageClientEfl.

* WebCoreSupport/PageClientEfl.cpp:
(WebCore):
* WebCoreSupport/PageClientEfl.h:
* ewk/ewk_private.h:
(EWKPrivate):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(EWKPrivate::corePageClient):

Source/WebKit2:

Surround code related to context menu with ENABLE(CONTEXT_MENUS) macro.
Add dummy functions for public API implementation related to context menu.

* Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):
* Shared/WebContextMenuItem.cpp:
* Shared/WebContextMenuItem.h:
* Shared/WebContextMenuItemData.cpp:
* Shared/WebContextMenuItemData.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
* UIProcess/WebPageContextMenuClient.cpp:
* UIProcess/WebPageContextMenuClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient):
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.h:
* WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:
* WebProcess/WebPage/WebContextMenu.cpp:
* WebProcess/WebPage/WebContextMenu.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fix wrong paths to JS resources in GTK tests.
mario@webkit.org [Tue, 17 Apr 2012 11:53:51 +0000 (11:53 +0000)]
Unreviewed, fix wrong paths to JS resources in GTK tests.

* platform/gtk/accessibility/aria-list-and-listitem.html:
* platform/gtk/accessibility/aria-option-role.html:
* platform/gtk/accessibility/aria-option-role-expected.txt: Fixed
typo in the expected output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.
ossy@webkit.org [Tue, 17 Apr 2012 11:36:57 +0000 (11:36 +0000)]
[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-17

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Rebaseline and add platform specific expectations, after r114283.
ossy@webkit.org [Tue, 17 Apr 2012 11:35:45 +0000 (11:35 +0000)]
[Qt] Rebaseline and add platform specific expectations, after r114283.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-17
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update expectations for worker WebSocket tests
toyoshim@chromium.org [Tue, 17 Apr 2012 11:05:08 +0000 (11:05 +0000)]
Unreviewed, update expectations for worker WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=84125

Add BUGWK84125 and mark as CRASH.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r113981.
mario@webkit.org [Tue, 17 Apr 2012 10:58:40 +0000 (10:58 +0000)]
Unreviewed, GTK rebaseline after r113981.

* accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt.
* accessibility/aria-labelledby-stay-within-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-stay-within-expected.txt.
* platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Added.
* platform/gtk/accessibility/aria-list-and-listitem.html: Added.
* platform/gtk/accessibility/aria-option-role-expected.txt: Added.
* platform/gtk/accessibility/aria-option-role.html: Added.
* platform/gtk/accessibility/lists-expected.txt: Added.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExport the initialization function so it can be called earlier.
staikos@webkit.org [Tue, 17 Apr 2012 09:48:15 +0000 (09:48 +0000)]
Export the initialization function so it can be called earlier.
https://bugs.webkit.org/show_bug.cgi?id=84134

Reviewed by Nikolas Zimmermann.

* Api/BlackBerryGlobal.h: export globalInitialize()
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce an internal feature for a fixed placeholder
tkent@chromium.org [Tue, 17 Apr 2012 08:36:38 +0000 (08:36 +0000)]
Introduce an internal feature for a fixed placeholder
https://bugs.webkit.org/show_bug.cgi?id=84009

Reviewed by Hajime Morita.

This change adds a framework to support fixed placeholder string for
textfield-like <input> without the palceholder attribute support. This
doesn't change any behavior of input types which support the
'placeholder' attribute.

According to the standard, <input type=date> doesn't support the
'placeholder' attribute. However it is a kind of text field in WebKit
platforms with ENABLE_CALENDAR_PICKER, and we may show something useful
information as the default placeholder.

No new tests because of no behavior changes.

* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement): Make isPlaceholderEmpty() virtual.
* html/HTMLInputElement.h:
(HTMLInputElement): Overrides isPlaceholderEmpty().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPlaceholderEmpty):
Check InputType::defaultPlaceholder() if InputType::usesFixedPlaceholder().
* html/InputType.cpp:
(WebCore::InputType::usesFixedPlaceholder): Added. Returns false.
(WebCore::InputType::fixedPlaceholder): Added. Returns a null string.
* html/InputType.h:
(InputType): Add usesFixedPlaceholder() and fixedPlaceholder().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
Uses fixedPlaceholder() instead of strippedPlaceholder() if usesFixedPlaceholder().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove some code of LocalizedNumberICU.cpp to ICULocale.cpp
tkent@chromium.org [Tue, 17 Apr 2012 08:20:38 +0000 (08:20 +0000)]
Move some code of LocalizedNumberICU.cpp to ICULocale.cpp
https://bugs.webkit.org/show_bug.cgi?id=84128

Reviewed by Hajime Morita.

No new tests. No behavior change.

* WebCore.gypi: Add ICULocale.cpp
* platform/text/ICULocale.cpp:
Added. Move some code from LocalizedNumberICU.cpp
* platform/text/ICULocale.h:
(ICULocale): Add currentLocale().
* platform/text/LocalizedNumberICU.cpp:
(WebCore::convertToLocalizedNumber): Use ICULocale::currentLocale().
(WebCore::convertFromLocalizedNumber): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Plugins] delete ws_info regardless of window mode.
hausmann@webkit.org [Tue, 17 Apr 2012 07:47:28 +0000 (07:47 +0000)]
[Plugins] delete ws_info regardless of window mode.
https://bugs.webkit.org/show_bug.cgi?id=83004

Patch by Bang Kwang min <justine.bang@samsung.com> on 2012-04-17
Reviewed by Simon Hausmann.

m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
Every plugin works well after this patch without any crash.
Additionally, change casting syntax to C++ style.

* plugins/PluginView.cpp:
(WebCore::PluginView::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Calendar Picker: Popup position is wrong when there are
tkent@chromium.org [Tue, 17 Apr 2012 07:40:30 +0000 (07:40 +0000)]
[Chromium] Calendar Picker: Popup position is wrong when there are
no enough space below the target date field
https://bugs.webkit.org/show_bug.cgi?id=84007

Reviewed by Hajime Morita.

The popup was detached from the origin element because
calendarPicker.js resizes its window. To fix this bug, we move the
window position vertically when it is resized.

No new tests. This is not testable in WebKit.

* src/WebPagePopupImpl.cpp:
(WebKit::PagePopupChromeClient::setWindowRect):
If this request is just a resize and m_isPutAboveOrigin is true,
update the vertical position so that the popup attaches to the
origin rectangle.
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_isPutAboveOrigin with false.
(WebKit::WebPagePopupImpl::init): Set m_isPutAboveOrigin true.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Add m_isPutAboveOrigin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCalendar Picker: Support RTL layout
tkent@chromium.org [Tue, 17 Apr 2012 07:30:46 +0000 (07:30 +0000)]
Calendar Picker: Support RTL layout
https://bugs.webkit.org/show_bug.cgi?id=83668

Reviewed by Hajime Morita.

.:

* ManualTests/forms/calendar-picker.html:
Add Arabic parameters.
Add <select> to select a locale.

Source/WebCore:

Manual test: ManualTests/forms/calendar-picker.html

* Resources/calendarPicker.js:
(layout): If params.isRTL, add dir=rtl to the body.
(DaysTable.prototype._handleKey): Reverse Left and Right cursor keys if RTL.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::addProperty): Add addProperty() with a bool value.
(WebCore::CalendarPickerElement::writeDocument):
Check the direction of the first character of localized January label,
and pass it as isRTL property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.
ossy@webkit.org [Tue, 17 Apr 2012 07:21:42 +0000 (07:21 +0000)]
[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium expectations.
toyoshim@chromium.org [Tue, 17 Apr 2012 07:18:46 +0000 (07:18 +0000)]
Unreviewed, update chromium expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
rniwa@webkit.org [Tue, 17 Apr 2012 07:18:44 +0000 (07:18 +0000)]
Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
https://bugs.webkit.org/show_bug.cgi?id=84068

Reviewed by Eric Seidel.

Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
automatically creates the build directory if needed.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadAndPerfTestFactory.__init__):
(DownloadAndPerfTestWebKit2Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix make distcheck issues.
carlosgc@webkit.org [Tue, 17 Apr 2012 06:45:27 +0000 (06:45 +0000)]
Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.list.am: Add missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinsertedIntoDocument and insertedIntoTree should be unitifed.
commit-queue@webkit.org [Tue, 17 Apr 2012 06:40:55 +0000 (06:40 +0000)]
insertedIntoDocument and insertedIntoTree should be unitifed.
https://bugs.webkit.org/show_bug.cgi?id=82701

Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
served as lifecycle callbacks which are invoked when a node is
inserted into its new parent. There are also removedFromTree()
and removedFromDocument() respectively. Considering that this pair
of virtual functions are laid onto the hot path, it's worth
merging them into one, to gain some speedup. Such
unification could clarify the semantics as well.

This change makes following change to merge these functions.

- pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
- letting new Node::insertInto() do the job for its own, but not
  for its children and
- Pass the parent of each insertion root as a parameter of insertedInto().
  This root node can tell inserted node where it is inserted,
  specifically whetehr the insertion is to the document or not.

Same pattern is also applied to Node::removedFromDocument() and
Node::removedFromTree(), which are factored to Node::removedFrom()
and ChildNodeRemovalNotifier respectively.

Speed up on Dromaeo/dom-modify.html is about 2%.
Further speed-up by de-virtulization would be possible.

Caveat:

There is possible situation where a node need to invoke
insertedInto() after its children is nofitied, instead of before
that.  It was represented naturally with previous
traversal-by-ContainerNode pattern, but is no longer simple with
this new external traversal. To support this scenario, we
introduced the InsertionNotificationRequest as a return value of insertedInto()
and a supplemental hook Node::didNotifyDescendantInseretions(). See for
example HTMLFormElement.cpp to learn how it works.

No new tests. Covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
(WebCore::updateTreeAfterInsertion):
* dom/ContainerNode.h:
(ContainerNode):
(WebCore::Node::highestAncestor):
(WebCore):
* dom/ContainerNodeAlgorithms.cpp: Added.
(WebCore):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
* dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
(WebCore):
(ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(Private):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
(WebCore::ChildNodeRemovalNotifier::notify):
* dom/DOMAllInOne.cpp:
* dom/DocumentType.cpp:
(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):
* dom/DocumentType.h:
(DocumentType):
* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(Element):
* dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):
* dom/Node.h:
(Node):
(WebCore::Node::didNotifyDescendantInseretions):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* dom/ProcessingInstruction.h:
(ProcessingInstruction):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::insertedInto):
* dom/ScriptElement.h:
(WebCore):
(ScriptElement):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
* dom/ShadowTree.h:
(ShadowTree):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):
* html/HTMLBaseElement.h:
(HTMLBaseElement):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):
* html/HTMLBodyElement.h:
(HTMLBodyElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInseretions):
(WebCore::HTMLFormElement::removedFrom):
* html/HTMLFormElement.h:
(HTMLFormElement):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):
* html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):
* html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):
* html/HTMLIFrameElement.h:
(HTMLIFrameElement):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
* html/HTMLImageElement.h:
(HTMLImageElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):
* html/HTMLInputElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
* html/HTMLLinkElement.h:
(HTMLLinkElement):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
* html/HTMLMapElement.h:
(HTMLMapElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::insertedInto):
* html/HTMLMetaElement.h:
(HTMLMetaElement):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):
* html/HTMLObjectElement.h:
(HTMLObjectElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedInto):
* html/HTMLOptionElement.h:
(HTMLOptionElement):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
* html/HTMLQuoteElement.h:
(HTMLQuoteElement):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
* html/HTMLScriptElement.h:
(HTMLScriptElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto):
* html/HTMLSelectElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
* html/HTMLSourceElement.h:
(HTMLSourceElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
* html/HTMLStyleElement.h:
(HTMLStyleElement):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto):
* html/HTMLTextFormControlElement.h:
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):
* html/HTMLTitleElement.h:
(HTMLTitleElement):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto):
* html/HTMLTrackElement.h:
(HTMLTrackElement):
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
* mathml/MathMLMathElement.h:
(MathMLMathElement):
* svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):
* svg/SVGFEImageElement.h:
(SVGFEImageElement):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):
* svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::insertedInto):
* svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):
* svg/SVGGlyphElement.h:
(SVGGlyphElement):
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
* svg/SVGHKernElement.h:
(SVGHKernElement):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::insertedInto):
* svg/SVGImageElement.h:
(SVGImageElement):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
* svg/SVGSVGElement.h:
(SVGSVGElement):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
* svg/SVGScriptElement.h:
(SVGScriptElement):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):
* svg/SVGStyleElement.h:
(SVGStyleElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
* svg/SVGStyledElement.h:
(SVGStyledElement):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):
* svg/SVGTRefElement.h:
(SVGTRefElement):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
* svg/SVGTextPathElement.h:
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):
* svg/SVGTitleElement.h:
(SVGTitleElement):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
* svg/SVGUseElement.h:
(SVGUseElement):
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
* svg/SVGVKernElement.h:
(SVGVKernElement):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114351 268f45cc-cd09-0410-ab3c-d52691b4dbfc