eric@webkit.org [Fri, 20 Nov 2009 06:03:15 +0000 (06:03 +0000)]
2009-11-19 Steve Block <steveblock@google.com>
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
* wtf/Platform.h: Modified. Added Android-specific configuration.
2009-11-19 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
Build change only. No new tests possible.
* config.h: Modified. Added Android-specific configuration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Fri, 20 Nov 2009 05:44:06 +0000 (05:44 +0000)]
2009-11-20 Roland Steiner <rolandsteiner@chromium.org>
WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
Test: fast/ruby/ruby-text-indent.html
* css/html.css: reset text-indent on <ruby> and <rt> elements
LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
* fast/ruby/ruby-text-indent-expected.txt: Added.
* fast/ruby/ruby-text-indent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 02:18:44 +0000 (02:18 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs per-command help
https://bugs.webkit.org/show_bug.cgi?id=31697
Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.
* Scripts/modules/multicommandtool.py:
* Scripts/modules/multicommandtool_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 02:12:21 +0000 (02:12 +0000)]
Fixes <http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.
Reviewed by Darin Adler.
Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 01:09:49 +0000 (01:09 +0000)]
2009-11-19 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Make chromium/webkit/glue/FormFieldValues use the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31650
* public/WebElement.h:
* public/WebFormElement.h:
* public/WebInputElement.h:
(WebKit::WebInputElement::):
* public/WebNode.h:
* src/AssertMatchingEnums.cpp:
* src/DOMUtilitiesPrivate.cpp:
(WebKit::nameOfInputElement):
* src/DOMUtilitiesPrivate.h:
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::autofill):
(WebKit::EditorClientImpl::doAutofill):
* src/WebFormElement.cpp:
(WebKit::WebFormElement::name):
(WebKit::WebFormElement::method):
(WebKit::WebFormElement::getNamedElements):
(WebKit::WebFormElement::getInputElements):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isEnabledFormControl):
(WebKit::WebInputElement::inputType):
(WebKit::WebInputElement::formControlType):
(WebKit::WebInputElement::value):
(WebKit::WebInputElement::dispatchFormControlChangeEvent):
(WebKit::WebInputElement::setSelectionRange):
(WebKit::WebInputElement::name):
(WebKit::WebInputElement::nameForAutofill):
* src/WebNode.cpp:
(WebKit::WebNode::frame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 00:55:19 +0000 (00:55 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move MultiCommandTool and Command into a separate file and add some basic unit tests
https://bugs.webkit.org/show_bug.cgi?id=31695
* Scripts/bugzilla-tool:
* Scripts/modules/multicommandtool.py: Added.
* Scripts/modules/multicommandtool_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 00:53:38 +0000 (00:53 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows
* WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
* platform/network/ResourceHandle.h: Removed loaderRunLoop().
* platform/network/cf/LoaderRunLoopCF.cpp: Added.
(WebCore::emptyPerform):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):
* platform/network/cf/LoaderRunLoopCF.h: Added.
Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
it's needed for more than just resource loading.
* platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
* platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
* platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
main thread.
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
inoperable main run loop.
(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 00:47:08 +0000 (00:47 +0000)]
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Quick style fix.
https://bugs.webkit.org/show_bug.cgi?id=27777
* platform/graphics/cg/PDFDocumentImage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 00:30:34 +0000 (00:30 +0000)]
Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 20 Nov 2009 00:25:38 +0000 (00:25 +0000)]
Build fix. No review needed.
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 20 Nov 2009 00:02:16 +0000 (00:02 +0000)]
Build fix. No review needed.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:58:41 +0000 (23:58 +0000)]
Build fix. No review needed.
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
* platform/graphics/qt/StillImageQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:53:33 +0000 (23:53 +0000)]
Build fix. No review needed.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:50:18 +0000 (23:50 +0000)]
Build fix. No review needed.
* plugins/PluginView.cpp:
(WebCore::PluginView::paintMissingPluginIcon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:46:49 +0000 (23:46 +0000)]
Build fix. No review needed.
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:38:24 +0000 (23:38 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
No review, just adding a FIXME.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
* Scripts/bugzilla-tool: Add an extra comment about current design failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:36:58 +0000 (23:36 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
color-correction work with untagged images
Reviewed by Darin Adler.
Image's draw(), drawPattern(), and fillWithSolidColor() functions
now take a ColorSpace. A bunch of classes inherit from Image, so
draw() and drawPattern() functions there must also take a
ColorSpace.
* platform/graphics/Image.cpp:
(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
* platform/graphics/BitmapImage.h:
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::draw):
(WebCore::GeneratedImage::drawPattern):
* platform/graphics/GeneratedImage.h:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::draw):
* platform/graphics/cg/PDFDocumentImage.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
* svg/graphics/SVGImage.h:
All of the drawImage() functions and drawTiled() functions of
GraphicsContext now take a ColorSpace.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
This is where the actual work is done.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::imageWithColorSpace): New static function that returns a
copy of the given image in the given ColorSpace *IF* we should use
the given ColorSpace. We will ignore the color space if the image
is tagged and return 0.
(WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
call imageWithColorSpace().
(WebCore::Image::drawPattern): Same.
Attempt to keep all ports building.
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/haiku/ImageHaiku.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::drawPattern):
Callers of GraphicsContext's drawImage() and drawTiled() functions
now need to send a ColorSpace.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintResizer):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* svg/graphics/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::applyFilter):
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31321 Make
-webkit-color-correction work with untagged images
Reviewed by Darin Adler.
* fast/css/color-correction-on-background-image.html: Added.
* fast/css/color-correction-untagged-images.html: Added.
* fast/css/resources/purple-noprofile.png: Added.
* platform/mac/fast/css/color-correction-on-background-image-expected.checksum: Added.
* platform/mac/fast/css/color-correction-on-background-image-expected.png: Added.
* platform/mac/fast/css/color-correction-on-background-image-expected.txt: Added.
* platform/mac/fast/css/color-correction-untagged-images-expected.checksum: Added.
* platform/mac/fast/css/color-correction-untagged-images-expected.png: Added.
* platform/mac/fast/css/color-correction-untagged-images-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 19 Nov 2009 23:32:05 +0000 (23:32 +0000)]
isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
https://bugs.webkit.org/show_bug.cgi?id=31693
Reviewed by David Levin.
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michelangelo@webkit.org [Thu, 19 Nov 2009 23:30:56 +0000 (23:30 +0000)]
2009-11-19 Michelangelo De Simone <michelangelo@webkit.org>
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>
Files missed when landing patch.
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:28:59 +0000 (23:28 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
* Scripts/bugzilla-tool:
- Add new MultiCommandTool class to contain option parsing and help printing logic.
- Rename private methods to use _ pattern.
- MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
-
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:21:03 +0000 (23:21 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Re-factor help printing to use modern python idioms
https://bugs.webkit.org/show_bug.cgi?id=31685
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:12:56 +0000 (23:12 +0000)]
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Properly create a CGImageRef on non-PLATFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=27777
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::sharedBufferGetBytesAtPosition):
(WebCore::sharedBufferRelease):
(WebCore::ImageSource::setData):
* platform/graphics/cg/ImageSourceCG.h:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::dataChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Nov 2009 22:16:50 +0000 (22:16 +0000)]
Trying to enable WebSocket tests on Tiger again, as the bot seems to behave now.
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 19 Nov 2009 22:04:51 +0000 (22:04 +0000)]
-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
https://bugs.webkit.org/show_bug.cgi?id=31656
Reviewed Dave Hyatt
Make sure we're a child of the painting root before drawing overflow features.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 19 Nov 2009 21:29:47 +0000 (21:29 +0000)]
Not reviewed, attempt to fix Chromium build.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 21:02:30 +0000 (21:02 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
commit-queue empty queue logs twice
https://bugs.webkit.org/show_bug.cgi?id=31679
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 20:28:09 +0000 (20:28 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
bugzilla-tool's reviewer/committer rejection message should be clearer
https://bugs.webkit.org/show_bug.cgi?id=31126
Add more explanatory prose to bugzilla-tool's flag permission rejection message.
* Scripts/modules/bugzilla.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 20:25:19 +0000 (20:25 +0000)]
2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Darin Adler.
Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652
* fast/lists/ol-start-roman.html: Added.
* platform/mac/fast/lists/ol-start-roman-expected.txt: Added.
2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Darin Adler.
Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652
Test: fast/lists/ol-start-roman.html
* rendering/RenderListMarker.cpp:
(WebCore::toRoman): Increase the char array size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 19 Nov 2009 20:14:52 +0000 (20:14 +0000)]
Rubber-stamped by Oliver Hunt.
Add translatable strings to cover validationMessage, after
r51172. Already covered by existing test.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 20:12:40 +0000 (20:12 +0000)]
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(STRING_H) guard from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31668
* config.h:
* runtime/UString.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 19 Nov 2009 19:59:38 +0000 (19:59 +0000)]
Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=31657
* wtf/MessageQueue.h:
(WTF::MessageQueue::removeIf):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 19:54:50 +0000 (19:54 +0000)]
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.
* runtime/DatePrototype.cpp: Remove include directive
for float.h as it is included in MathExtras.h already.
* runtime/Operations.cpp: Ditto.
* runtime/UString.cpp: Ditto.
* wtf/dtoa.cpp: Ditto.
* wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
* wtf/Platform.h: Ditto.
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
WebCore has a dependency on float.h, there is
no need to guard float.h.
No new tests as there is no functional change.
* html/HTMLInputElement.cpp: Remove include directive
for float.h as it is included in MathExtras.h already.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 19:41:16 +0000 (19:41 +0000)]
2009-11-19 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Updated timeline paint test to ignore width and height. GTK+ testing
uses a different top level window size than other platforms.
https://bugs.webkit.org/show_bug.cgi?id=31402
* inspector/timeline-paint-expected.txt:
* inspector/timeline-test.js:
* platform/win/Skipped:
2009-11-19 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Forces a WM_PAINT event on calling layoutTestController.display()
in order to enable the timeline-paint.html test on Windows.
::UpdateWindow() does not force an event becaue the window is
not visible.
https://bugs.webkit.org/show_bug.cgi?id=31402
* DumpRenderTree/win/DumpRenderTree.cpp:
(displayWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 19:28:24 +0000 (19:28 +0000)]
2009-11-19 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
WAI-ARIA roles not supported on image map <area>
https://bugs.webkit.org/show_bug.cgi?id=31525
* accessibility/aria-used-on-image-maps-expected.txt: Added.
* accessibility/aria-used-on-image-maps.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 19 Nov 2009 19:03:02 +0000 (19:03 +0000)]
2009-11-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Pavel Feldman.
Instrumentation should account for painting in compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31674
Add calls to InspectorTimelineAgent for painting into compositing layers,
which is not accounted for in FrameView::paintContents().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
Avoid fetching the FrameView multiple times.
(WebCore::inspectorTimelineAgent):
(WebCore::RenderLayerBacking::paintContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michelangelo@webkit.org [Thu, 19 Nov 2009 18:21:46 +0000 (18:21 +0000)]
2009-11-19 Michelangelo De Simone <michelangelo@webkit.org>
No review needed.
Added myself to committers list.
* Scripts/modules/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 18:16:51 +0000 (18:16 +0000)]
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bugzilla-tool command classes should match command names
https://bugs.webkit.org/show_bug.cgi?id=31666
I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 19 Nov 2009 18:14:01 +0000 (18:14 +0000)]
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
Test: media/media-captions.html
* WebCore.base.exp:
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlTypeName):
Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Add MediaToggleClosedCaptionsButtonPart.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
Define and match mediaControlsToggleClosedCaptionsButton.
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Define and match PseudoMediaControlsToggleClosedCaptions.
* css/CSSValueKeywords.in:
Define and use media-toggle-closed-captions-button.
* css/mediaControls.css:
* css/mediaControlsQuickTime.css:
Add webkit-media-controls-toggle-closed-captions-button.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
Initialize m_closedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal):
Set m_closedCaptionsVisible to false.
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::closedCaptionsVisible):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
New, captions internal methods.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitHasClosedCaptions):
New, captions DOM API.
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
Declare methods needed for captions API.
* platform/ThemeTypes.h:
Add MediaToggleClosedCaptionsButtonPart.
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
Add empty implmentations.
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
(WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
New, empty implementations of media engine closed caption functions.
(WebCore::MediaPlayer::hasClosedCaptions):
(WebCore::MediaPlayer::setClosedCaptionsVisible):
New, call media engine closed caption functions.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
(WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
Declare new media engine methods.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::hasClosedCaptions):
(WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
New, QTKit implementation of closed caption methods.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement):
Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
New, implement the closed caption toggle button,
* rendering/MediaControlElements.h:
Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
declare MediaControlToggleClosedCaptionsButtonElement.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::styleDidChange):
(WebCore::RenderMedia::createToggleClosedCaptionsButton):
(WebCore::RenderMedia::createStatusDisplay):
(WebCore::RenderMedia::updateControls):
(WebCore::RenderMedia::forwardEvent):
* rendering/RenderMedia.h:
Deal with m_toggleClosedCaptionsButton.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
Deal with MediaToggleClosedCaptionsButtonPart.
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
Declare paintMediaToggleClosedCaptionsButton.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
New.
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't render captions toggle button unless we are using the new theme, the
movie has captions, and the movie is in a <video> element since we currently
rely on QTKit to render the captions.
* rendering/style/RenderStyleConstants.h:
Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* media/media-captions-expected.txt: Added.
* media/media-captions.html: Added.
* media/content/counting-captioned.mov: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/win/Skipped:
Skipped on platforms that don't support closed captions yet.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* English.lproj/Localizable.strings:
Add strings for toggle captions button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
Add QTMovieHasClosedCaptions and QTMovieSetShowClosedCaptions.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory localizedMediaControlElementString:]):
(-[WebViewFactory localizedMediaControlElementHelpText:]):
Add accessibility help strings for media controller closed caption button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* WebCoreLocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
Add accessibility help strings for media controller closed caption button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* WebKitSystemInterface.h:
Add prototypes for WKQTMovieHasClosedCaptions and WKQTMovieSetShowClosedCaptions,
define WKMediaUIPartToggleClosedCaptionsButton.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 19 Nov 2009 18:10:05 +0000 (18:10 +0000)]
wx build fix. Add missing header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Nov 2009 17:43:30 +0000 (17:43 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31634
Ignore realm for proxy protection spaces
Only affects WebSocket proxy authentication, cannot be tested in DRT.
* platform/network/ProtectionSpace.cpp:
(WebCore::operator==):
* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 17:42:38 +0000 (17:42 +0000)]
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
https://bugs.webkit.org/show_bug.cgi?id=31669
* platform/gtk/Skipped:
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
https://bugs.webkit.org/show_bug.cgi?id=31669
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_show):
* webkit/webkitwebinspector.h:
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
https://bugs.webkit.org/show_bug.cgi?id=31669
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::showWebInspector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 19 Nov 2009 14:23:35 +0000 (14:23 +0000)]
Minor refactoring + more documentation.
Reviewed by Simon Hausmann.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::clearHistory):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 14:12:05 +0000 (14:12 +0000)]
2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add instantiation tests for QWebInspector.
* tests/qwebinspector/qwebinspector.pro: Added.
* tests/qwebinspector/tst_qwebinspector.cpp: Added.
(tst_QWebInspector::attachAndDestroy):
* tests/tests.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 14:04:26 +0000 (14:04 +0000)]
2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix QWebInspector destruction problem.
https://bugs.webkit.org/show_bug.cgi?id=31664
* Api/qwebpage.cpp:
(QWebPage::~QWebPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 19 Nov 2009 13:47:01 +0000 (13:47 +0000)]
[Qt] Normalize signal and slot signatures.
Patch by Olivier Goffart <ogoffart@trolltech.com> on 2009-11-19
Reviewed by Simon Hausmann.
WebCore:
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
WebKit/qt:
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
* Api/qwebview.cpp:
(QWebView::setPage):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setFrame):
* docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:
(wrapInFunction):
* tests/qwebframe/tst_qwebframe.cpp:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::modified):
(tst_QWebPage::database):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 19 Nov 2009 13:46:38 +0000 (13:46 +0000)]
Build fix for 32-bit Sparc machines: these machines are big-endian.
Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-11-19
Reviewed by Simon Hausmann.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 13:03:10 +0000 (13:03 +0000)]
2009-11-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Store cookie domains in the WebInspector object
The cookie domains have been moved from StoragePanel into WebInspector.
Also, the document URLs are now passed inside the WebInspector.addResource()
payload rather than pushed directly from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=31627
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::didFinishLoading):
* inspector/InspectorFrontend.cpp:
* inspector/InspectorFrontend.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::createScriptObject):
(WebCore::InspectorResource::updateScriptObject):
* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel.prototype.reset):
(WebInspector.StoragePanel.prototype.addCookieDomain):
* inspector/front-end/inspector.js:
(WebInspector.addResource):
(WebInspector.addCookieDomain):
(WebInspector.reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 19 Nov 2009 12:32:37 +0000 (12:32 +0000)]
2009-11-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Some tests in fast/css-generated-content can be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=31663
* fast/css-generated-content/absolute-position-inside-inline-expected.txt: Added.
* fast/css-generated-content/absolute-position-inside-inline.html:
* fast/css-generated-content/hit-test-generated-content-expected.txt: Added.
* fast/css-generated-content/hit-test-generated-content.html:
* fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Added.
* fast/css-generated-content/positioned-background-hit-test-crash.html:
* fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
* fast/css-generated-content/spellingToolTip-assert.html:
* platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.checksum: Removed.
* platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.png: Removed.
* platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
* platform/mac/fast/css-generated-content/hit-test-generated-content-expected.checksum: Removed.
* platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png: Removed.
* platform/mac/fast/css-generated-content/hit-test-generated-content-expected.txt: Removed.
* platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.checksum: Removed.
* platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.png: Removed.
* platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
* platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.checksum: Removed.
* platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.png: Removed.
* platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
* platform/qt/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
* platform/qt/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
* platform/qt/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Thu, 19 Nov 2009 10:41:18 +0000 (10:41 +0000)]
2009-11-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Ignore websocket tests when --no-http is specified.
https://bugs.webkit.org/show_bug.cgi?id=31662
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Thu, 19 Nov 2009 09:34:17 +0000 (09:34 +0000)]
Allow custom memory allocation control for the other part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31585
Reviewed by Darin Adler.
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class RegularExpression - instantiated at: WebCore/page/Frame.cpp:415
class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
class Path - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
class FontPlatformData - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class Cursors - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
class NetworkStateNotifier - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
* platform/graphics/MediaPlayerPrivate.h:
* platform/graphics/Path.h:
* platform/graphics/qt/FontPlatformData.h:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/image-decoders/ImageDecoder.h:
* platform/network/NetworkStateNotifier.h:
* platform/network/ResourceRequestBase.h:
* platform/qt/CursorQt.cpp:
* platform/text/RegularExpression.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 19 Nov 2009 08:15:42 +0000 (08:15 +0000)]
Update the test fast/overflow/004.html to make it match the test
description and expected results.
https://bugs.webkit.org/show_bug.cgi?id=31455
Patch by Kinuko Yasuda <kinuko@google.com> on 2009-11-19
Reviewed by Dan Bernstein.
* fast/overflow/004.html:
* platform/mac/fast/overflow/004-expected.checksum:
* platform/mac/fast/overflow/004-expected.png:
* platform/mac/fast/overflow/004-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 19 Nov 2009 07:18:28 +0000 (07:18 +0000)]
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
[Qt] Build fix for QtWebKit after r51172.
* platform/qt/Localizations.cpp:
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 06:18:59 +0000 (06:18 +0000)]
2009-11-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Normalize ' and " in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31655
We decided " is better than ' and we should be consistent.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 19 Nov 2009 06:17:07 +0000 (06:17 +0000)]
WebCore: Fixed <rdar://problem/
7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer
Reviewed by Simon Fraser.
Tests: fast/layers/clip-rects-transformed-2.html
fast/layers/clip-rects-transformed.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
that is either transformed or composited. During painting and hit
testing, when a transformed or composited layer is hit, it becomes the
new root layer, which ultimately gets passed to calculateRects().
(WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
root layer to calculateRects(), and return the bounding box of the
transformed rectangle.
(WebCore::RenderLayer::selfClipRect): Ditto.
* rendering/RenderLayer.h:
LayoutTests: Test for <rdar://problem/
7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer
Reviewed by Simon Fraser.
* fast/layers/clip-rects-transformed-2-expected.txt: Added.
* fast/layers/clip-rects-transformed-2.html: Added.
* fast/layers/clip-rects-transformed-expected.txt: Added.
* fast/layers/clip-rects-transformed.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 19 Nov 2009 06:03:01 +0000 (06:03 +0000)]
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
* JavaScriptCore.pro:
* jsc.pro:
* wtf/unicode/qt4/UnicodeQt4.h:
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
* Api/qcookiejar.cpp: Removed.
* Api/qcookiejar.h: Removed.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
* Api/qwebframe.cpp:
(QWebFrame::load):
* Api/qwebframe.h:
* Api/qwebkitglobal.h:
* Api/qwebnetworkinterface.cpp: Removed.
* Api/qwebnetworkinterface.h: Removed.
* Api/qwebnetworkinterface_p.h: Removed.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::acceptNavigationRequest):
(QWebPage::acceptNavigationRequest):
(QWebPage::action):
(QWebPage::userAgentForUrl):
* Api/qwebpage.h:
* Api/qwebpage_p.h:
* Api/qwebview.cpp:
(QWebView::load):
(QWebView::event):
* Api/qwebview.h:
* QtLauncher/main.cpp:
(MainWindow::print):
(MainWindow::setupUI):
(main):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::download):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):
(WebCore::FrameLoaderClientQt::createPlugin):
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
No new tests as there is no change if compiled with
Qt v4.4 or later version.
* WebCore.pro:
* dom/XMLTokenizerQt.cpp:
(WebCore::EntityResolver::resolveUndeclaredEntity):
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::XMLTokenizer::~XMLTokenizer):
(WebCore::XMLTokenizer::doWrite):
(WebCore::XMLTokenizer::startDocument):
(WebCore::XMLTokenizer::parseDtd):
* platform/graphics/qt/FontQt.cpp:
* platform/graphics/qt/FontQt43.cpp: Removed.
* platform/graphics/qt/ImageQt.cpp:
* platform/network/ResourceHandleInternal.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::setDefersLoading):
* platform/network/qt/ResourceRequest.h:
* platform/network/qt/ResourceRequestQt.cpp:
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::clearData):
* platform/qt/CookieJarQt.cpp:
(WebCore::cookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookiesEnabled):
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::keyIdentifierForQtKeyCode):
(WebCore::windowsKeyCodeForKeyEvent):
* platform/text/qt/TextBoundaries.cpp:
* platform/text/qt/TextBreakIteratorQt.cpp:
* plugins/qt/PluginDataQt.cpp:
(WebCore::PluginData::initPlugins):
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/ImageDiff.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 19 Nov 2009 05:47:27 +0000 (05:47 +0000)]
2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
GitTest.test_create_binary_patch fails if /tmp is symlink
https://bugs.webkit.org/show_bug.cgi?id=31536
* Scripts/modules/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 19 Nov 2009 05:38:59 +0000 (05:38 +0000)]
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
* fast/dom/domListEnumeration-expected.txt: updated with new property
* fast/dom/script-tests/domListEnumeration.js: ditto
* fast/forms/script-tests/validationMessage.js: Added.
* fast/forms/validationMessage-expected.txt: Added.
* fast/forms/validationMessage.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
Test: fast/forms/validationMessage.html
* html/HTMLButtonElement.idl: validationMessage attribute
* html/HTMLFieldSetElement.idl: validationMessage attribute
* html/HTMLFormControlElement.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLInputElement.idl: validationMessage attribute
* html/HTMLSelectElement.idl: validationMessage attribute
* html/HTMLTextAreaElement.idl: validationMessage attribute
* html/ValidityState.cpp: new method to retrieve pertinent localized text
* html/ValidityState.h:
* page/mac/WebCoreViewFactory.h:
* platform/LocalizedStrings.h:
* platform/android/LocalizedStringsAndroid.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/haiku/LocalizedStringsHaiku.cpp:
* platform/mac/LocalizedStringsMac.mm:
* platform/wx/LocalizedStringsWx.cpp:
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
* English.lproj/Localizable.strings: new localizable strings
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
* src/LocalizedStrings.cpp:
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory validationMessageValueMissingText]):
(-[WebViewFactory validationMessageTypeMismatchText]):
(-[WebViewFactory validationMessagePatternMismatchText]):
(-[WebViewFactory validationMessageTooLongText]):
(-[WebViewFactory validationMessageRangeUnderflowText]):
(-[WebViewFactory validationMessageRangeOverflowText]):
(-[WebViewFactory validationMessageStepMismatchText]):
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
* WebCoreLocalizedStrings.cpp:
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 19 Nov 2009 05:09:22 +0000 (05:09 +0000)]
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
Fix a typo. Remove the trailing semicolon
from an include directive after r51137.
No new tests as there is no functional change.
* platform/qt/QWebPageClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 19 Nov 2009 04:52:35 +0000 (04:52 +0000)]
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
[Qt] Build fix for QtWebKit after r51159.
Include float.h for DBL_MANT_DIG. Not sure why this
is not a problem for other ports.
* html/HTMLInputElement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Thu, 19 Nov 2009 03:15:49 +0000 (03:15 +0000)]
WebCore: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)
Reviewed by Darin Adler.
Cause of the bug:
1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
4.) this triggers the special handling of child removal in RenderRubyRun that
causes it to destroy itself
5.) On returning from all this the renderer crashes when accessing a member
or virtual function on this now illegal object.
I therefore added a flag that tracks if the ruby run is being destroyed.
If so, avoid doing the special handling in removeChild that caused this.
It's not the most elegant solution, but the easiest to implement without
touching unrelated code. Also, it's self-documenting.
Test: fast/ruby/ruby-remove.html
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::destroy):
(WebCore::RenderRubyRun::removeChild):
* rendering/RenderRubyRun.h:
LayoutTests: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)
Reviewed by Darin Adler.
Layout test to verify it no longer crashes when the <ruby> element
is being removed.
* fast/ruby/ruby-remove-expected.txt: Added.
* fast/ruby/ruby-remove.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 19 Nov 2009 03:12:50 +0000 (03:12 +0000)]
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
https://bugs.webkit.org/show_bug.cgi?id=31330
- Introduce new function createRep(const char*, unsigned) and
UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
- Fix a bug that dtoa() doesn't update *rve if the input value is NaN
or Infinity.
No new tests because this doesn't change the behavior.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/UString.cpp:
(JSC::createRep):
(JSC::UString::UString):
(JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
* runtime/UString.h:
* wtf/dtoa.cpp:
(WTF::dtoa): Fix a bug about rve.
(WTF::append): A helper for doubleToStringInJavaScriptFormat().
(WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
* wtf/dtoa.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 02:53:55 +0000 (02:53 +0000)]
2009-11-18 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Adler.
Configuration for Chromium Build Slaves.
https://bugs.webkit.org/show_bug.cgi?id=31442
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 02:46:13 +0000 (02:46 +0000)]
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643
* JavaScriptCore.pro:
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643
No new tests as there is no functional change.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 02:38:15 +0000 (02:38 +0000)]
2009-11-18 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
Implement TextBoundaries for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371
* platform/text/wince/TextBoundariesWince.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 02:30:06 +0000 (02:30 +0000)]
2009-11-18 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
Implement TextBreakIterator for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371
* platform/text/wince/TextBreakIteratorWince.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 19 Nov 2009 02:15:17 +0000 (02:15 +0000)]
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Tests for ValidityState.typeMismatch for the following types of INPUT element:
date, datetime, datetime-local, month, time and week
https://bugs.webkit.org/show_bug.cgi?id=31342
* fast/forms/ValidityState-typeMismatch-date-expected.txt: Added.
* fast/forms/ValidityState-typeMismatch-date.html: Added.
* fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Added.
* fast/forms/ValidityState-typeMismatch-datetime.html: Added.
* fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Added.
* fast/forms/ValidityState-typeMismatch-datetimelocal.html: Added.
* fast/forms/ValidityState-typeMismatch-month-expected.txt: Added.
* fast/forms/ValidityState-typeMismatch-month.html: Added.
* fast/forms/ValidityState-typeMismatch-time-expected.txt: Added.
* fast/forms/ValidityState-typeMismatch-time.html: Added.
* fast/forms/ValidityState-typeMismatch-week-expected.txt: Added.
* fast/forms/ValidityState-typeMismatch-week.html: Added.
* fast/forms/script-tests/ValidityState-typeMismatch-date.js: Added.
* fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Added.
* fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Added.
* fast/forms/script-tests/ValidityState-typeMismatch-month.js: Added.
* fast/forms/script-tests/ValidityState-typeMismatch-time.js: Added.
* fast/forms/script-tests/ValidityState-typeMismatch-week.js: Added.
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add support for ValidityState.typeMismatch for the following INPUT types:
date datetime datetime-local month time week
https://bugs.webkit.org/show_bug.cgi?id=31342
Tests: fast/forms/ValidityState-typeMismatch-date.html
fast/forms/ValidityState-typeMismatch-datetime.html
fast/forms/ValidityState-typeMismatch-datetimelocal.html
fast/forms/ValidityState-typeMismatch-month.html
fast/forms/ValidityState-typeMismatch-time.html
fast/forms/ValidityState-typeMismatch-week.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::formStringToISODateTime): Check the type
validity of the specified type and string using the ISODateTime class.
* html/HTMLInputElement.h:
* html/ValidityState.cpp:
(WebCore::ValidityState::typeMismatch): Check the type validity
for date, datetime, datetime-local, month, time and week with
HTMLInputElemtn::formStringToISODateTime()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 19 Nov 2009 02:13:20 +0000 (02:13 +0000)]
2009-11-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
https://bugs.webkit.org/show_bug.cgi?id=31237
Also speeds up Dromaeo DOM Core tests by 1.31x.
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
mark bit was no longer effective; instead I changed things so only a node that has no ancestors
with wrappers would do marking; there should be only one in the typical case (the root of the
detached subtree).
* dom/Node.cpp:
(WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
* dom/Node.h: ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 19 Nov 2009 02:07:23 +0000 (02:07 +0000)]
Get rid of the redundant strokeType and fillType data members on
a GraphicsContext as well as the FillOrStrokeType enum. Use
null pointers instead.
Reviewed by Sam Weinig.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokeColor): Null out the pattern
and gradient.
(WebCore::GraphicsContext::setFillColor): Ditto.
(WebCore::GraphicsContext::setStrokePattern): Null out the graident.
(WebCore::GraphicsContext::setFillPattern): Ditto.
(WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
(WebCore::GraphicsContext::setFillGradient): Ditto.
* platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::setPlatformStroke): Ditto.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
(WebCore::GraphicsContext::applyFillPattern): Ditto.
(WebCore::calculateDrawingMode): Use fillPattern and strokePattern
to see if there is a pattern instead of fillType and strokeType.
(WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
fillPattern, and strokePattern instead of fillType and strokeType.
(WebCore::GraphicsContext::fillPath): Added FIXME about color space that
is used in the pattern and gradient case probably erroneously. Moved
gradient code inside an if statement. Streamlined pattern code and
use an if statement. No switch any more.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
(WebCore::GraphicsContext::strokeRect): Ditto.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
(WebCore::GraphicsContext::fillRect): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 02:01:59 +0000 (02:01 +0000)]
2009-11-18 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
workqueue.py results in totally broken commit-queue UI
https://bugs.webkit.org/show_bug.cgi?id=31645
* Scripts/bugzilla-tool:
- Remove unneeded use of PatchCollection.
- Grab a new copy of the cq'd patches every run of the queue.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 01:48:52 +0000 (01:48 +0000)]
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add tests for ValidityState.stepMismatch.
https://bugs.webkit.org/show_bug.cgi?id=31331
* fast/forms/ValidityState-stepMismatch-number-expected.txt: Added.
* fast/forms/ValidityState-stepMismatch-number.html: Added.
* fast/forms/ValidityState-stepMismatch-range-expected.txt: Added.
* fast/forms/ValidityState-stepMismatch-range.html: Added.
* fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Added.
* fast/forms/ValidityState-stepMismatch-unsupported.html: Added.
* fast/forms/input-step-expected.txt: Added.
* fast/forms/input-step.html: Added.
* fast/forms/script-tests/ValidityState-stepMismatch-number.js: Added.
* fast/forms/script-tests/ValidityState-stepMismatch-range.js: Added.
* fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Added.
* fast/forms/script-tests/input-step.js: Added.
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Support for step attribute and ValidityStae.stepMismatch for
type=number and range. stepMismatch will be false if the
difference between the current value and a multiple of the step
value is very small.
Change the behavior of RenderSlider so that it always has a value
rounded to the step attribute value.
https://bugs.webkit.org/show_bug.cgi?id=31331
Tests: fast/forms/ValidityState-stepMismatch-number.html
fast/forms/ValidityState-stepMismatch-range.html
fast/forms/ValidityState-stepMismatch-unsupported.html
fast/forms/input-step.html
* html/HTMLAttributeNames.in: Add "step".
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::getStepParameters):
(WebCore::HTMLInputElement::getAllowedValueStep):
* html/HTMLInputElement.h:
* html/HTMLInputElement.idl: Add "step".
* html/ValidityState.cpp:
(WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
* html/ValidityState.h:
* rendering/RenderSlider.cpp:
(WebCore::SliderRange::SliderRange):
(WebCore::SliderRange::clampValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 19 Nov 2009 01:27:44 +0000 (01:27 +0000)]
Need to ASSERT(isMainThread()) in ThreadShared methods.
https://bugs.webkit.org/show_bug.cgi?id=31637
Reviewed by Darin Adler.
Added ASSERT(IsMainThread()) to all following methods:
* platform/TreeShared.h:
(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::~TreeShared):
(WebCore::TreeShared::ref):
(WebCore::TreeShared::deref):
(WebCore::TreeShared::setParent):
(WebCore::TreeShared::parent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 01:00:36 +0000 (01:00 +0000)]
2009-11-18 Girish Ramakrishnan <girish@forwardbias.in>
Reviewed by Eric Seidel.
Add plugin visibility manual test
https://bugs.webkit.org/show_bug.cgi?id=31542
* manual-tests/plugins/windowed.html:
* manual-tests/plugins/windowless.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 00:52:47 +0000 (00:52 +0000)]
2009-11-18 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Pavel Feldman.
Web Inspector - remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552
Manual test added
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showScript):
(WebInspector.ScriptsPanel.prototype.showResource):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
(WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._goBack):
(WebInspector.ScriptsPanel.prototype._goForward):
* manual-tests/inspector/remember-last-script.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 00:43:58 +0000 (00:43 +0000)]
2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
Win chromium is slow to draw transparent texts
https://bugs.webkit.org/show_bug.cgi?id=31258
Create bounded transparency layers instead of just clipping.
No new tests because this is just a performance improvement.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 00:35:04 +0000 (00:35 +0000)]
2009-11-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Update expected result after Qt4.6 upgrade.
https://bugs.webkit.org/show_bug.cgi?id=31560
Test: LayoutTests/editing/deleting/
5408255.html
* platform/qt/editing/deleting/
5408255-expected.txt:
2009-11-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560
Test: LayoutTests/editing/deleting/
5408255.html
* WebCore.qrc:
* platform/graphics/qt/ImageQt.cpp:
(loadResourcePixmap):
2009-11-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560
Test: LayoutTests/editing/deleting/
5408255.html
* Api/qwebsettings.cpp:
(graphics):
* Api/qwebsettings.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 00:26:58 +0000 (00:26 +0000)]
2009-11-18 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Eric Seidel.
Fix Qt build without JavaScript debugger.
https://bugs.webkit.org/show_bug.cgi?id=31575
* page/Console.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 00:18:01 +0000 (00:18 +0000)]
2009-11-18 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
Make 80 patches a formal requirement for reviewership
https://bugs.webkit.org/show_bug.cgi?id=31313
Per discussion on the webkit-reviewers list:
http://lists.webkit.org/mailman/private.cgi/webkit-reviewers/2009-November/000795.html
* coding/commit-review-policy.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 19 Nov 2009 00:05:57 +0000 (00:05 +0000)]
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/
7138265>
Fixes an issue where setting the height of a table row programmatically
(via JavaScript) causes the table to be improperly rendered because the
height of each row in the table is not recalculated with respect to the
CSS height property.
In particular, programmatically setting the height of some table row causes
the rows of that table to be rendered with a height equal to the minimum
height required by the cells in that row, regardless of any specified cell
heights. Instead, when RenderTableSection::recalcCells is called, the height
of each row should be set to the CSS height property just as we do in
RenderTableSection::addChild.
Test: fast/table/row-height-recalc2.html
* rendering/RenderTableSection.cpp:
(WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
(WebCore::RenderTableSection::addChild): Moved code that set row height into
method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
(WebCore::RenderTableSection::recalcCells): Modified to call
WebCore::setRowHeightToRowStyleHeightIfNotRelative.
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/
7138265>
Tests that setting the height of a table row programmatically (via JavaScript)
recalculates the height of the rows in the table.
* fast/table/row-height-recalc2.html: Added.
* platform/mac/fast/table/row-height-recalc2-expected.checksum: Added.
* platform/mac/fast/table/row-height-recalc2-expected.png: Added.
* platform/mac/fast/table/row-height-recalc2-expected.txt: Added.
* platform/qt/fast/table/row-height-recalc2-expected.checksum: Added.
* platform/qt/fast/table/row-height-recalc2-expected.png: Added.
* platform/qt/fast/table/row-height-recalc2-expected.txt: Added.
* platform/win/fast/table/row-height-recalc2-expected.checksum: Added.
* platform/win/fast/table/row-height-recalc2-expected.png: Added.
* platform/win/fast/table/row-height-recalc2-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Wed, 18 Nov 2009 23:57:53 +0000 (23:57 +0000)]
Reduce flakiness in zero-duration-with-non-zero-delay-end.html by
increasing a timeout.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31646
* transitions/zero-duration-with-non-zero-delay-end.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Wed, 18 Nov 2009 23:47:29 +0000 (23:47 +0000)]
Allow custom memory allocation control for the part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31473
Reviewed by Darin Adler.
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
struct Length - instantiated at WebCore/platform/Length.cpp:103
class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
* platform/ContextMenuItem.h:
* platform/DeprecatedPtrList.h:
* platform/DeprecatedPtrListImpl.cpp:
* platform/Length.h:
* platform/PlatformKeyboardEvent.h:
* platform/animation/AnimationList.h:
* platform/graphics/Color.h:
* platform/graphics/FontCache.h:
* platform/graphics/GraphicsContextPrivate.h:
* platform/graphics/MediaPlayer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 23:46:06 +0000 (23:46 +0000)]
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31186
Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.
No functionality was changed. So, no tests were included.
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::setInnerTextValue):
(WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
(WebCore::RenderTextControl::subtreeHasChanged):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
(WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
(WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::defaultEventHandler):
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31186
Changes associated with renaming RenderTextControl::isUserEdited.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited.
(DOMHTMLTextAreaElement::isUserEdited): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 18 Nov 2009 23:44:45 +0000 (23:44 +0000)]
Make the Mac Geolocation API async.
Reviewed by Anders Carlsson.
WebKit:
* WebKit.xcodeproj/project.pbxproj: Remove WebGeolocation.
WebKit/mac:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestGeolocationPermissionForFrame):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
Add WebGeolocationPolicyListener implementation of the new WebGeolocationPolicyListener
protocol and use if to implement requestGeolocationPermissionForFrame using the new async
API.
* WebCoreSupport/WebGeolocation.mm: Removed.
* WebCoreSupport/WebGeolocationInternal.h: Removed.
* WebCoreSupport/WebGeolocationMock.mm: Remove bogus include.
* WebCoreSupport/WebGeolocationPrivate.h: Removed.
* WebView/WebUIDelegatePrivate.h: Remove requestGeolocationPermission and add
WebGeolocationPolicyListener protocol and decidePolicyForGeolocationRequestFromOrigin delegate
method.
WebKitTools:
Update DRT to use the new async Mac Geolocation API.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 23:36:54 +0000 (23:36 +0000)]
2009-11-18 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
https://bugs.webkit.org/show_bug.cgi?id=31499
No new tests, just a build cleanup.
* WebCore.gypi:
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
* bindings/v8/custom/V8CustomBinding.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 23:29:00 +0000 (23:29 +0000)]
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add and option to toggle HTML5 datalist support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31599
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Wed, 18 Nov 2009 23:25:37 +0000 (23:25 +0000)]
2009-11-18 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Remove Chromium's unnecessary dependency on wtf's tcmalloc files.
https://bugs.webkit.org/show_bug.cgi?id=31648
* JavaScriptCore.gyp/JavaScriptCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 18 Nov 2009 23:18:33 +0000 (23:18 +0000)]
Reviewed by Kevin Ollivier.
Enable wx plugin support using the Windows implementation as a base.
https://bugs.webkit.org/show_bug.cgi?id=31636
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 23:10:54 +0000 (23:10 +0000)]
2009-11-18 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
Menu button shows wrong content in Chromium
https://bugs.webkit.org/show_bug.cgi?id=31448
Make context menu button (VK_APPS) show context menu for node that has
keyboard focus. This affects both the content and the positioning.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sendContextMenuEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 23:02:19 +0000 (23:02 +0000)]
2009-11-18 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Gavin Barraclough.
[Qt] Implement symbol hiding for JSC's JIT functions.
These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
https://bugs.webkit.org/show_bug.cgi?id=30864
* jit/JITStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 22:49:34 +0000 (22:49 +0000)]
2009-11-18 Andrei Popescu <andreip@google.com>
Reviewed by Dimitri Glazkov.
[Android] Add shared timer and sound utilities to platform/android
https://bugs.webkit.org/show_bug.cgi?id=31584
No new tests required, this is platform specific code.
* platform/android/SharedTimerAndroid.cpp: Added.
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireTime):
(WebCore::stopSharedTimer):
* platform/android/SoundAndroid.cpp: Added.
(WebCore::systemBeep):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 22:41:31 +0000 (22:41 +0000)]
2009-11-18 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Fix profile tree nodes loss after focus / restore actions.
Focusing on a node is currently implemented via nodes reattaching
with some caching involved. It seems that not all code was updated
to handle this scenario correctly.
https://bugs.webkit.org/show_bug.cgi?id=31553
* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode):
(WebInspector.BottomUpProfileDataGridNode.prototype._restore):
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.insertChild):
(WebInspector.DataGridNode.prototype._detach):
(WebInspector.DataGridNode.prototype.savePosition):
(WebInspector.DataGridNode.prototype.restorePosition):
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridTree.prototype.focus):
(WebInspector.TopDownProfileDataGridTree.prototype.restore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 18 Nov 2009 22:37:36 +0000 (22:37 +0000)]
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31610
Adds property "min-width" to #title so that the width of the title
element on each page is at least 790px. In particular, this makes
the page <http://webkit.org/security/security-group-members.html>
consistent, in appearance, to the rest of the site.
* css/main.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 22:33:47 +0000 (22:33 +0000)]
2009-11-18 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPageClient.h needs in some cases QCursor, but it does not
include it
https://bugs.webkit.org/show_bug.cgi?id=31527
No new tests as this is just a coding style fix that affects the
build of some not yet submitted patches (i.e. for bug 30173).
* platform/qt/QWebPageClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 18 Nov 2009 22:25:39 +0000 (22:25 +0000)]
2009-11-18 Nicolas Roard <nicolas@roard.com>
Reviewed by Dimitri Glazkov.
InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=31504
* inspector/InspectorTimelineAgent.h:Added the guard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
snej@chromium.org [Wed, 18 Nov 2009 22:08:13 +0000 (22:08 +0000)]
Build fix to my previous checkin, for Windows Chromium
* svg/SVGAnimatedProperty.h:
(WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Wed, 18 Nov 2009 22:05:46 +0000 (22:05 +0000)]
2009-11-18 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Directly Access <head> Instead of Searching for It
https://bugs.webkit.org/show_bug.cgi?id=31641
Changed old access of the head element (document.getElementsByTagName)
to just use the document.head accessor.
* inspector/front-end/FontView.js:
(WebInspector.FontView):
* inspector/front-end/InjectedScript.js:
(InjectedScript.addStyleSelector):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
* inspector/front-end/inspector.js:
(windowLoaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 18 Nov 2009 22:04:29 +0000 (22:04 +0000)]
Fix two Geolocation assertions.
Reviewed by Anders Carlsson.
* page/Chrome.cpp:
(WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
is not called from JS.
* page/Geolocation.cpp:
(WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
a RefPtr first.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 18 Nov 2009 22:02:32 +0000 (22:02 +0000)]
Case sensitive file system build fix.
* platform/network/Credential.h: It's not WTF, just wtf.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
agolden@apple.com [Wed, 18 Nov 2009 21:54:55 +0000 (21:54 +0000)]
Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
objects and WebCore::Credential objects without losing certificate information.
Reviewed by Alexey Proskuryakov
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 18 Nov 2009 21:49:10 +0000 (21:49 +0000)]
2009-11-17 Darin Fisher <darin@chromium.org>
Reviewed by Dmitry Titov.
Minor cleanup in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31616
* public/WebFormElement.h: Add missing WEBKIT_API prefix.
* public/WebNode.h: Add missing WEBKIT_API prefix.
* src/WebFormElement.cpp:
(WebKit::WebFormElement::action): Make action getter const.
* src/WebNode.cpp:
(WebKit::WebNode::frame): Utilize WebFrameImpl::fromFrame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 18 Nov 2009 21:31:13 +0000 (21:31 +0000)]
Update expected results of fixed test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log