WebKit-https.git
12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:39:59 +0000 (23:39 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-queue should only process each patch once
        https://bugs.webkit.org/show_bug.cgi?id=31939

        Actually address reviewer comments!

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:36:20 +0000 (23:36 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue fails to apply a bunch of patches for no reason
        https://bugs.webkit.org/show_bug.cgi?id=31942

        By passing --non-interactive to check-style, we convince check-style
        to pass --force to svn-apply, which lets it apply more patches.

        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:35:18 +0000 (23:35 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Support --status-host in style-queue
        https://bugs.webkit.org/show_bug.cgi?id=31941

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/statusbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:34:44 +0000 (23:34 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-queue should only process each patch once
        https://bugs.webkit.org/show_bug.cgi?id=31939

        Before processing a patch, the try-queues now ask the web service
        whether they have already processed the patch.  This is an initial cut
        of this functionality.  I expect we're make it richer over time.

        * Scripts/bugzilla-tool:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:34:04 +0000 (23:34 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        PatchStatus does not return status
        https://bugs.webkit.org/show_bug.cgi?id=31938

        We need to parse attachment_id as an int.  Otherwise, we can't find
        anything in the datastore.

        * CommitQueueStatus/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 27 Nov 2009 23:04:50 +0000 (23:04 +0000)]
2009-11-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31940

        Makes the error messages more descriptive when we refuse to load an object/embed or
        refuse to load from the document base URL.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive.
        (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2009-11-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31940

        Rebased results because of new error messages.

        * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-expected.txt:
        * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-src-inject-expected.txt:
        * http/tests/security/xssAuditor/object-tag-expected.txt:
        * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 27 Nov 2009 18:49:01 +0000 (18:49 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make commit-queue status not throw an exception where there is not
        status
        https://bugs.webkit.org/show_bug.cgi?id=31936

        We need to actually fetch the results of the query to see what's in the
        datastore.

        * CommitQueueStatus/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 18:09:36 +0000 (18:09 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] unit test ApplyPatches and ApplyAttachment
        https://bugs.webkit.org/show_bug.cgi?id=31935

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/download_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 17:37:46 +0000 (17:37 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Unit test download commands
        https://bugs.webkit.org/show_bug.cgi?id=31923

        Adds download_unittest and fixes a bug found while testing.

        * Scripts/modules/commands/commandtest.py:
        * Scripts/modules/commands/download.py:
            Fixed a bug where we'd throw an error because [].append returns
            None.
        * Scripts/modules/commands/download_unittest.py: Added.
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Kenneth Russell <kbr@google.com>
eric@webkit.org [Fri, 27 Nov 2009 16:21:00 +0000 (16:21 +0000)]
2009-11-27  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot
        https://bugs.webkit.org/show_bug.cgi?id=31919

        Temporarily disabled portion of test which is failing on some
        machines but not others. Root cause will be investigated under
        https://bugs.webkit.org/show_bug.cgi?id=31843 .

        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/script-tests/gl-object-get-calls.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 27 Nov 2009 13:07:06 +0000 (13:07 +0000)]
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        This is a WebCore part of the fix that allows to view plugin
        resources loaded by plugins.

        https://bugs.webkit.org/show_bug.cgi?id=31832

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::addLength):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didFailToLoad):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        WebCore part of the fix that allows to view plugin
        resources loaded by plugins. Methods that for resource
        loading notifications are exposed through WebDevToolsAgent
        interface to the glue code to allow Chromium's plugin
        implementation to notify InspectorController about resource
        loading in plugins.

        https://bugs.webkit.org/show_bug.cgi?id=31832

        * public/WebDevToolsAgent.h:
        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 27 Nov 2009 11:12:44 +0000 (11:12 +0000)]
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Instead of generating negative identifiers for cached resources in
        InspectorController and extending identifier type from 'unsigned long' to 'long
        long' reuse progress tracker from the inspected page to generate those
        identifiers. It guarantees that InspectorResources have unique ids since
        all of them are generated by that progress tracker.

        Added a couple new overloaded methods to Script* objects that accept
        long and unsigned long arguments. These types of argumens have already
        been passed as long long.

        https://bugs.webkit.org/show_bug.cgi?id=31921

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/js/ScriptFunctionCall.h:
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptObject.h:
        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/v8/ScriptFunctionCall.h:
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/v8/ScriptObject.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::getTrackedResource):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache): Use inspected page's ProgressTracker to generate unique identifiers for cached resources in InspectorController.
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addResource):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::removeResource):
        (WebCore::InspectorFrontend::updateFocusedNode):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::createCached):
        * inspector/InspectorResource.h: Change InspectorResource identifier type from 'long long' to 'unsigned long'.
        (WebCore::InspectorResource::create):
        (WebCore::InspectorResource::identifier):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
        (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
        (WebCore::TimelineRecordFactory::createResourceFinishRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 08:45:15 +0000 (08:45 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix found while writing unit tests.

        * Scripts/modules/commands/download.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 08:04:38 +0000 (08:04 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 6: Kill the rest.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/scm.py:
        * Scripts/modules/webkitlandingscripts.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 08:02:05 +0000 (08:02 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Unit test upload commands
        https://bugs.webkit.org/show_bug.cgi?id=31903

        Adds unit tests for all but two of the upload commands.  The two
        remaining ones are more difficult.  I'll return to them later.  The
        goal of these tests is just to run the commands.  We can test more
        detailed behavior later.

        * Scripts/modules/commands/commandtest.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/commands/upload_unittest.py:
        * Scripts/modules/mock.py: Added.
        * Scripts/modules/mock_bugzillatool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:56:51 +0000 (07:56 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 5: Kill run_and_throw_if_fail.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/processutils.py: Added.
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:56:24 +0000 (07:56 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 4: Kill run_webkit_script.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:55:57 +0000 (07:55 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 3: Kill build_webkit.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:55:31 +0000 (07:55 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 2: Kill ensure_builders_are_green.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:54:57 +0000 (07:54 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 1: Kill prepare_clean_working_directory and run_webkit_tests.

        * Scripts/bugzilla-tool:
        * Scripts/modules/buildsteps.py: Added.
        * Scripts/modules/commands/download.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 27 Nov 2009 07:51:38 +0000 (07:51 +0000)]
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed red bot fix.

        Skip tests introduced by the previous change as it seems to be failing.

        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 27 Nov 2009 06:11:25 +0000 (06:11 +0000)]
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
        https://bugs.webkit.org/show_bug.cgi?id=29966

        A test case where a user drags the mouse from an empty inline
        element to above texts.

        * editing/selection/last-empty-inline-expected.txt: Added.
        * editing/selection/last-empty-inline.html: Added.
        * platform/win/Skipped:
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
        https://bugs.webkit.org/show_bug.cgi?id=29966

        When an empty inline element is clicked, the root inline box has
        no leaf children. Use the renderer of a normal child instead.

        This change resolves Windows port's assertion failure in a layout test.
        Also, this fixes the behavior when a user drags the mouse from an
        empty inline element to above texts.

        Test: editing/selection/last-empty-inline.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPointWithInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Fri, 27 Nov 2009 05:59:55 +0000 (05:59 +0000)]
2009-11-26  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Ignore line-height CSS property specified to push buttons on
        Windows and Linux.
        https://bugs.webkit.org/show_bug.cgi?id=31712

        LayoutTests/fast/forms/control-restrict-line-height.html checks that the
        following controls should ignore line-height CSS property.
         - <select>
         - <input type=button>
         - <input type=search>
        This change addresses the <input type=button> issue with Chromium/Windows
        and Chromium/Linux.

        * rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
        * rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
eric@webkit.org [Fri, 27 Nov 2009 05:53:00 +0000 (05:53 +0000)]
2009-11-26  Kinuko Yasuda  <kinuko@chromium.com>

        Reviewed by Eric Seidel.

        Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
        so that the expected results can be independent of platform differences.
        https://bugs.webkit.org/show_bug.cgi?id=31580

        * fast/parser/comment-in-textarea-expected.txt: Added.
        * fast/parser/comment-in-textarea.html:
        * fast/parser/script-tests/comment-in-textarea.js: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
        * platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
        * platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
        * platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
eric@webkit.org [Fri, 27 Nov 2009 05:46:06 +0000 (05:46 +0000)]
2009-11-26  Kinuko Yasuda  <kinuko@chromium.com>

        Reviewed by Eric Seidel.

        Remove the special charset meta tag in the clipboard so that
        copy-and-paste with interchange breaklines/spaces works correctly
        within WebKit.

        No new tests.  Layout tests that involve copy-and-paste with
        interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
        should pass on Mac/Chromium with this fix.

        * platform/chromium/ClipboardChromium.cpp:
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 İsmail Dönmez <ismail@namtrac.org>
eric@webkit.org [Fri, 27 Nov 2009 05:33:58 +0000 (05:33 +0000)]
2009-11-26  İsmail Dönmez  <ismail@namtrac.org>

        Reviewed by Eric Seidel.

        Compile with QT_NO_WHEELEVENT defined.

        * platform/qt/WheelEventQt.cpp:
        (WebCore::PlatformWheelEvent::applyDelta):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIncorrect behaviour of jneq_null in the interpreter
oliver@apple.com [Fri, 27 Nov 2009 05:20:37 +0000 (05:20 +0000)]
Incorrect behaviour of jneq_null in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=31901

Reviewed by Gavin Barraclough.

Correct the logic of jneq_null.  This is already covered by existing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 27 Nov 2009 04:06:37 +0000 (04:06 +0000)]
2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Oliver Hunt.

        Move GOwnPtr* from wtf to wtf/gtk
        https://bugs.webkit.org/show_bug.cgi?id=31793

        * GNUmakefile.am: Change the path for GOwnPtr.*.
        * JavaScriptCore.gyp/JavaScriptCore.gyp: Remove
          GOwnPtr.cpp from the exclude list.
        * JavaScriptCore.gypi: Change the path for GOwnPtr.*.
        * wscript: Remove GOwnPtr.cpp from the exclude list.
        * wtf/GOwnPtr.cpp: Removed.
        * wtf/GOwnPtr.h: Removed.
        * wtf/Threading.h: Change the path for GOwnPtr.h.
        * wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
        * wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
        * wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.

2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Oliver Hunt.

        Move GOwnPtr* from wtf to wtf/gtk
        https://bugs.webkit.org/show_bug.cgi?id=31793

        * webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.

2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Oliver Hunt.

        Move GOwnPtr* from wtf to wtf/gtk
        https://bugs.webkit.org/show_bug.cgi?id=31793

        No new tests as there is no functional change.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the
          path for GOwnPtr.h.
        * platform/text/TextEncoding.cpp: Ditto.
        * platform/text/gtk/TextCodecGtk.cpp: Ditto.

2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Oliver Hunt.

        Move GOwnPtr* from wtf to wtf/gtk
        https://bugs.webkit.org/show_bug.cgi?id=31793

        * GNUmakefile.am: Add JavaScriptCore/wtf/gtk to
          the include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 26 Nov 2009 21:22:37 +0000 (21:22 +0000)]
2009-11-26  Yury Semikhatsky  <yurys@chromium.org>

        Not reviewed. Build fix: revert r51421.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::addLength):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didFailToLoad):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-26  Yury Semikhatsky  <yurys@chromium.org>

        Not reviewed. Build fix: revert r51421.

        * public/WebDevToolsAgent.h:
        * public/WebView.h:
        * src/WebViewImpl.cpp:
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 26 Nov 2009 20:59:33 +0000 (20:59 +0000)]
2009-11-26  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        This is a WebCore part of the fix that allows to view plugin
        resources loaded by plugins.

        https://bugs.webkit.org/show_bug.cgi?id=31832

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure.
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-26  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        WebCore part of the fix that allows to view plugin
        resources loaded by plugins. Methods that for resource
        loading notifications are exposed through WebDevToolsAgent
        interface to the glue code to allow Chromium's plugin
        implementation to notify InspectorController about resource
        loading in plugins.

        https://bugs.webkit.org/show_bug.cgi?id=31832

        * public/WebDevToolsAgent.h:
        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Daniel Bates <dbates@webkit.org>
eric@webkit.org [Thu, 26 Nov 2009 20:27:53 +0000 (20:27 +0000)]
2009-11-26  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=21554

        Tests that the tooltip text for an image is its dimensions.

        * inspector/elements-img-tooltip-expected.txt: Added.
        * inspector/elements-img-tooltip.html: Added.
2009-11-26  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=21554

        Implements support for hovering over <img> src to display the height and width of that image
        in a tooltip. Displays both the displayable and natural dimensions of the image.

        Test: inspector/elements-img-tooltip.html

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added.
        (WebInspector.ElementsTreeElement.prototype._updateTitle.callback):
        (WebInspector.ElementsTreeElement.prototype._updateTitle):
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectProxy.getPropertiesAsync): Added.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode): Added tooltipText argument.
        (WebInspector.linkifyURL): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix after drawPattern API change.
kevino@webkit.org [Thu, 26 Nov 2009 18:06:11 +0000 (18:06 +0000)]
wx build fix after drawPattern API change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMissed checking in these files from https://bugs.webkit.org/show_bug.cgi?id=30091
cmarrin@apple.com [Thu, 26 Nov 2009 16:50:46 +0000 (16:50 +0000)]
Missed checking in these files from https://bugs.webkit.org/show_bug.cgi?id=30091

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 26 Nov 2009 16:50:34 +0000 (16:50 +0000)]
2009-11-26  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Adam Barth.

        Remove directory prefixes from linux commands

        SCM unittests can cause errors on some systems if we use absolute reference to
        the commands, so directory prefixes have been removed.

        * Scripts/modules/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 26 Nov 2009 15:59:46 +0000 (15:59 +0000)]
2009-11-26  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Use an internal field instead of hidden property to speedup lookup
        of entered isolated world.

        Plus some inlinings.
        https://bugs.webkit.org/show_bug.cgi?id=31884

        Covered by layout tests + manual running of some benchmarks as
        content scripts.

        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::setDOMWrapper):
        * bindings/v8/V8HiddenPropertyName.h:
        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        * bindings/v8/V8IsolatedWorld.h:
        (WebCore::V8IsolatedWorld::getEntered):
        (WebCore::V8IsolatedWorld::getGlobalObject):
        * bindings/v8/custom/V8CustomBinding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Holger Freyther.
hausmann@webkit.org [Thu, 26 Nov 2009 15:06:58 +0000 (15:06 +0000)]
Rubber-stamped by Holger Freyther.

Removed unused ICO image plugin handler.

* Plugins/ICOHandler.cpp: Removed.
* Plugins/ICOHandler.h: Removed.
* Plugins/Plugins.pro: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 26 Nov 2009 14:34:56 +0000 (14:34 +0000)]
2009-11-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Corrects build break on Windows.

        Rename platform/text/qt/TextBoundaries.cpp to TextBoundariesQt.cpp since
        platform/text/TextBoundaries.cpp was compiled instead when compiling with nmake.

        * WebCore.pro:
        * platform/text/qt/TextBoundariesQt.cpp: Renamed from WebCore/platform/text/qt/TextBoundaries.cpp.
        (WebCore::findNextWordFromIndex):
        (WebCore::findWordBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 26 Nov 2009 13:20:26 +0000 (13:20 +0000)]
2009-11-26  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Do not check if the thread is main or not when accessing DOMDataStore as currently in Chromium WebKit is used in main thread only.
        https://bugs.webkit.org/show_bug.cgi?id=31877

        Covered by layout tests and buildbots.

        * bindings/v8/V8DOMMap.cpp:
        (WebCore::getDOMNodeMap):
        (WebCore::getDOMObjectMap):
        (WebCore::getActiveDOMObjectMap):
        (WebCore::getDOMSVGElementInstanceMap):
        (WebCore::getDOMSVGObjectWithContextMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Mac Plugins : Pass mouse position relative to the fake window
girish@forwardbias.in [Thu, 26 Nov 2009 13:04:06 +0000 (13:04 +0000)]
[Qt] Mac Plugins : Pass mouse position relative to the fake window

Reviewed by Holger Freyther.

When using off-screen rendering, we need to pass mouse events relative
to the fake window instead of the global position.

https://bugs.webkit.org/show_bug.cgi?id=31794

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Use QNetworkReply::rawHeaderPairs
zecke@webkit.org [Thu, 26 Nov 2009 11:16:23 +0000 (11:16 +0000)]
[Qt] Use QNetworkReply::rawHeaderPairs

https://bugs.webkit.org/show_bug.cgi?id=31826

The QNetworkReply is internally storing the HTTP headers
as a list of pairs. Currently we have to ask the QNetworkReply
to put all header names into a QStringList. Afterwards we will
iterate over this QStringList and ask the QNetworkReply to
give us the value for this header name. The current Qt implementation
is doing a linear to find the header value.

Use a new API to directly access the list of pairs and push
this into WebCore. This avoids doing some allocations and doing
linear searches from within a loop.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Add automatic test case for plugins that use QWidget
zecke@webkit.org [Thu, 26 Nov 2009 10:34:50 +0000 (10:34 +0000)]
[Qt] Add automatic test case for plugins that use QWidget

https://bugs.webkit.org/show_bug.cgi?id=31203

Change the RenderTreeAsText to look into the WebCore::Widget
and print the state of the platformWidget. Change the DRT to
use QtUiTools to be able to initiate QProgressBar and such
as a plugin. Add the test case, add the result, update the
other results due the new test.

WebCore:
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<): Add special case for RenderPart

WebKitTools:
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::createPlugin):
* DumpRenderTree/qt/DumpRenderTree.h:
* DumpRenderTree/qt/DumpRenderTree.pro:

LayoutTest:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/plugins/netscape-dom-access-expected.txt: Added
* platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
* platform/win/Skipped:
* plugins/qt-qwidget-plugin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Call Widget::setSelfVisible from hide/show
zecke@webkit.org [Thu, 26 Nov 2009 10:31:31 +0000 (10:31 +0000)]
[Qt] Call Widget::setSelfVisible from hide/show

https://bugs.webkit.org/show_bug.cgi?id=31203

Call Widget::setSelfVisible from Widget::show and
Widget::hide and use isParentVisible to decide
if the widget should be shown. This way client
code can rely on isVisible.

Change PluginViewQt::show, PluginViewQt::hide to
call the base class as it is doing the right thing
now. Add an assert verify that platfomWidget and
platformPluginWidget are the same.

* manual-tests/qt/qtplugin.html: Modify manual test
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::show):
(WebCore::Widget::hide):

[Qt] Do not show the QWidget when the WebCore::Widget is hidden

https://bugs.webkit.org/show_bug.cgi?id=31203

The clipping code was making a QWidget visible even if the
WebCore::Widget was hidden. Fix the bug by calling setVisible
only if the WebCore::Widget Widget::isSelfVisible.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::QtPluginWidget::show): Override WebCore::Widget::show to call handleVisibility
(WebCore::QtPluginWidget::handleVisibility): New method to call setVisible when we are visible
(FrameLoaderClientQt::createPlugin): Hide the QWidget by default

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation of REQUEST_DEBUG debug code
zecke@webkit.org [Thu, 26 Nov 2009 10:31:16 +0000 (10:31 +0000)]
Fix compilation of REQUEST_DEBUG debug code

https://bugs.webkit.org/show_bug.cgi?id=31850

In r47907 the single parameter KURL constructor to parse
from a WebCore::String was replaced with a two parameter
constructor. I think in this debug case parsing the urls
again is no problem and I have changed the code to use the
two parameter version.

* loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Søren Gjesse <sgjesse@chromium.org>
eric@webkit.org [Thu, 26 Nov 2009 08:43:41 +0000 (08:43 +0000)]
2009-11-26  Søren Gjesse  <sgjesse@chromium.org>

        Reviewed by Pavel Feldman.

        [V8] Avoid using JavaScript objects as context data
        https://bugs.webkit.org/show_bug.cgi?id=31873

        Change the context "data" from a JavaScript object holding the two properties type and value to
        a string holding type and value separated by a comma.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setInjectedScriptContextDebugId):
        (WebCore::V8Proxy::setContextDebugId):
        (WebCore::V8Proxy::contextDebugId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Thu, 26 Nov 2009 06:16:09 +0000 (06:16 +0000)]
2009-11-25  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Update pywebsocket to 0.4.2

        Update pywebsocket to 0.4.2
        https://bugs.webkit.org/show_bug.cgi?id=31861

        * pywebsocket/example/echo_client.py:
        * pywebsocket/example/echo_wsh.py:
        * pywebsocket/mod_pywebsocket/__init__.py:
        * pywebsocket/mod_pywebsocket/dispatch.py:
        * pywebsocket/mod_pywebsocket/msgutil.py:
        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:
        * pywebsocket/test/test_dispatch.py:
        * pywebsocket/test/test_msgutil.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 26 Nov 2009 03:02:48 +0000 (03:02 +0000)]
2009-11-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add unit test for mark-fixed
        https://bugs.webkit.org/show_bug.cgi?id=31896

        * Scripts/modules/commands/commandtest.py: Added.
        * Scripts/modules/commands/queries_unittest.py:
        * Scripts/modules/commands/upload_unittest.py: Added.
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 26 Nov 2009 02:25:31 +0000 (02:25 +0000)]
2009-11-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool should have a mark-fixed command
        https://bugs.webkit.org/show_bug.cgi?id=31853

        Pretty simple stuff.

        * Scripts/modules/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 26 Nov 2009 02:22:27 +0000 (02:22 +0000)]
2009-11-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        'bugzilla-tool help' should only show common commands like how 'git help' does
        https://bugs.webkit.org/show_bug.cgi?id=31772

        I also took this opportunity to make 'help' a real Command.
        Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).

        * Scripts/bugzilla-tool:
         - change should_show_command_help to should_show_in_main_help
        * Scripts/modules/commands/download.py:
         - Mark commands as being shown in main help or not.
         - show_in_main_help = False is not required (default is false),
           but it seemed to make the commands more self-documenting.
        * Scripts/modules/commands/queries.py: ditto
        * Scripts/modules/commands/queues.py: ditto
        * Scripts/modules/commands/upload.py: ditto
        * Scripts/modules/multicommandtool.py:
         - Make Command hold a pointer to tool in self.tool.  Most Command
           subclasses do not take advantage of this yet, but it was required
           for HelpCommand to be able to reach the tool from _help_epilog().
         - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
         - Move MultiCommandTool._help_epilog to Command._help_epilog
         - Move "help" logic into HelpCommand.execute()
         - Change should_show_command_help to should_show_in_main_help and add a default implementation.
        * Scripts/modules/multicommandtool_unittest.py:
         - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Thu, 26 Nov 2009 00:57:22 +0000 (00:57 +0000)]
WebCore:

2009-11-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        [Chromium] Implement canSetValueAttribute in the API, the clean-up part.
        https://bugs.webkit.org/show_bug.cgi?id=31894

        * accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl.
        (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.

WebKit/chromium:

2009-11-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        [Chromium] Implement canSetValueAttribute in the API.
        https://bugs.webkit.org/show_bug.cgi?id=31894

        * public/WebAccessibilityObject.h: Added decl.
        * src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Audio related layout tests are failing on the buildbot
ossy@webkit.org [Thu, 26 Nov 2009 00:51:30 +0000 (00:51 +0000)]
[Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910

* platform/qt/Skipped: fast/js/global-constructors.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Kenneth Russell <kbr@google.com>
eric@webkit.org [Thu, 26 Nov 2009 00:44:39 +0000 (00:44 +0000)]
2009-11-25  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Off-by-one error in index validation for drawElements and drawArrays
        https://bugs.webkit.org/show_bug.cgi?id=31891

        Fixed computation of number of elements for bound array objects.

        Test: fast/canvas/webgl/index-validation.html

        * fast/canvas/webgl/index-validation-expected.txt: Added.
        * fast/canvas/webgl/index-validation.html: Added.
        * fast/canvas/webgl/script-tests/index-validation.js: Added.
2009-11-25  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Off-by-one error in index validation for drawElements and drawArrays
        https://bugs.webkit.org/show_bug.cgi?id=31891

        Fixed computation of number of elements for bound array objects.

        Test: fast/canvas/webgl/index-validation.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::vertexAttribPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPatch by Mark Rowe.
bweinstein@apple.com [Thu, 26 Nov 2009 00:41:23 +0000 (00:41 +0000)]
Patch by Mark Rowe.

Reviewed by Dan Bernstein.

The buildbots are failing on Windows because when they were upgraded
to 4.0.4, Apple Application Support was not in their path. Add it to
the path to fix the buildots.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Remove a bunch of now passing fast tests from skiplist.
ossy@webkit.org [Thu, 26 Nov 2009 00:29:41 +0000 (00:29 +0000)]
[Qt] Remove a bunch of now passing fast tests from skiplist.
And add a crasher/crashed pair into skiplist.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate SharedScript to use eventNames() instead of EventNames()
dimich@chromium.org [Wed, 25 Nov 2009 23:44:13 +0000 (23:44 +0000)]
Update SharedScript to use eventNames() instead of EventNames()
https://bugs.webkit.org/show_bug.cgi?id=31890

Reviewed by David Levin.

* SharedScript/WebKitSharedScript.cpp:
(WebCore::LoadEventTask::performTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Put tests into skiplist because of missing layoutTestController feature.
ossy@webkit.org [Wed, 25 Nov 2009 23:29:06 +0000 (23:29 +0000)]
[Qt] Put tests into skiplist because of missing layoutTestController feature.

* platform/qt/Skipped:
- http/tests/cache/subresource-failover-to-network.html added.
- fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html added.

- "3D_RENDERING and ACCELERATED_COMPOSITING" block moved to good place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorun-webkit-tests doesn't accept directories/files with --skipped=only parameter
ossy@webkit.org [Wed, 25 Nov 2009 22:26:15 +0000 (22:26 +0000)]
run-webkit-tests doesn't accept directories/files with --skipped=only parameter
https://bugs.webkit.org/show_bug.cgi?id=31799

Reviewed by David Kilzer.

* Scripts/run-webkit-tests: Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 25 Nov 2009 21:09:42 +0000 (21:09 +0000)]
2009-11-25  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Unable to repost form data by hitting reload
        https://bugs.webkit.org/show_bug.cgi?id=31882

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::loadData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 25 Nov 2009 21:08:38 +0000 (21:08 +0000)]
2009-11-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7409331> Windows: Support closed caption in <video> element

        Enable closed captions in QuickTime/Windows media engine.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::hasClosedCaptions):
        (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
            New, all through to m_qtMovie.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
            Make all but the destructor private since MediaPlayer call through the media
            engine interface.

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::disableUnsupportedTracks):
            Use handy new constants for QuickTime track types.
        (QTMovieWin::hasClosedCaptions):
        (QTMovieWin::setClosedCaptionsVisible):
            New, closed caption support.
        * platform/graphics/win/QTMovieWin.h:

        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart):
            Deal with closed caption buttons.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::shouldRenderMediaControlPart):
            New, don't ask the media engine if it has closed captions unless the Safari theme will
            be able to render the button.
        (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
            New.
        * rendering/RenderThemeWin.h:

2009-11-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7409331> Windows: Support closed caption in <video> element

        * platform/win/Skipped:
            Enable the closed caption test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Wed, 25 Nov 2009 20:04:19 +0000 (20:04 +0000)]
2009-11-25  Drew Wilson  <atwilson@chromium.org>

        Reviewed by David Levin.

        MessagePorts always look remotely entangled even when closed.
        https://bugs.webkit.org/show_bug.cgi?id=31698

        Tests: Existing tests suffice, Chromium soak test passes now.

        * bindings/v8/custom/V8CustomBinding.h:
        Removed kMessagePortEntangledPortIndex which is no longer used.
        * bindings/v8/V8GCController.cpp:
        (WebCore::GCPrologueVisitor::visitDOMWrapper):
        Simplified GC code to reflect the Chromium MessagePort implementation
        (locallyEntangledPort() always returns false).
        (WebCore::GCEpilogueVisitor::visitDOMWrapper):
        Cleaned up epilogue code to handle the case where the port gets closed
        in mid-GC (due to the parent context being freed).
        * dom/MessagePort.cpp:
        (WebCore::MessagePort::MessagePort):
        (WebCore::MessagePort::close):
        Now sets the closed flag.
        (WebCore::MessagePort::disentanglePorts):
        Updated to use new isCloned() API instead of relying on isEntangled(), which was incorrect.
        * dom/MessagePort.h:
        Added a m_closed flag and updated isEntangled() to check it.
        (WebCore::MessagePort::isEntangled):
        Now returns false if the port has been closed.
        (WebCore::MessagePort::isCloned):
        Added new API to differentiate between cloned and closed ports (closed ports can still be passed to postMessage).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Wed, 25 Nov 2009 20:02:12 +0000 (20:02 +0000)]
2009-11-25  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        Change run_command to give back stderr by default
        https://bugs.webkit.org/show_bug.cgi?id=31734

        Change run_command to give back stderr by default.
        Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
        Change the related unittest call.

        * Scripts/modules/scm.py:
        * Scripts/modules/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkip test that needs structure we do not provide yet
kov@webkit.org [Wed, 25 Nov 2009 18:22:19 +0000 (18:22 +0000)]
Skip test that needs structure we do not provide yet

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 25 Nov 2009 18:03:47 +0000 (18:03 +0000)]
2009-11-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Plumb setNeedsSiteSpecificQuirks throught WebKit API.
        https://bugs.webkit.org/show_bug.cgi?id=31878

        * public/WebSettings.h: Added decl.
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setNeedsSiteSpecificQuirks): Added impl.
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.
hausmann@webkit.org [Wed, 25 Nov 2009 17:12:59 +0000 (17:12 +0000)]
[Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-25
Reviewed by Simon Hausmann.

Fix inline assembly, don't dereference the function pointer twice.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Remove the Referer header when redirecting to a non-secure site
hausmann@webkit.org [Wed, 25 Nov 2009 17:02:34 +0000 (17:02 +0000)]
[Qt] Remove the Referer header when redirecting to a non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31785

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-11-22
Reviewed by Adam Barth.

This makes Qt pass two tests introduced in r50226.

WebCore:

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThe select elements do not reflect the actual choice the user makes.
benm@google.com [Wed, 25 Nov 2009 16:50:38 +0000 (16:50 +0000)]
The select elements do not reflect the actual choice the user makes.
https://bugs.webkit.org/show_bug.cgi?id=31831

Patch by Andrei Popescu <andreip@google.com> on 2009-11-25
Reviewed by Dimitri Glazkov.

Handle the drawing of the listboxes in Android code.

No new features, just fixing an Android problem. Existing layout tests are sufficient.

* platform/android/RenderThemeAndroid.cpp:
(WebCore::theme):
(WebCore::RenderThemeAndroid::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::adjustButtonStyle):
(WebCore::RenderThemeAndroid::paintTextArea):
(WebCore::RenderThemeAndroid::adjustListboxStyle):
* platform/android/RenderThemeAndroid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Wed, 25 Nov 2009 16:15:39 +0000 (16:15 +0000)]
2009-11-25  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Load InspectorResource mime type from CachedResource for 304 responses

        For network libraries that do not merge cache data into 304 ResourceResponses,
        the mime type for cached resources is unknown.
        https://bugs.webkit.org/show_bug.cgi?id=31868

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateResponse):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Andrei Popescu <andreip@google.com>
eric@webkit.org [Wed, 25 Nov 2009 16:06:57 +0000 (16:06 +0000)]
2009-11-25  Andrei Popescu  <andreip@google.com>

        Reviewed by Eric Seidel.

        Android is missing implementation of SSL Key generator functions.
        https://bugs.webkit.org/show_bug.cgi?id=31825

        This change adds the PlatformBridge class to platform/android.
        PlarformBridge is used to access the embedding layer for things
        such as key generator, cookies, plugins, etc.

        No new tests required, this is platform code.

        * platform/android/PlatformBridge.h: Added.
        * platform/android/SSLKeyGeneratorAndroid.cpp: Added.
        (WebCore::getSupportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Nov 2009 16:05:31 +0000 (16:05 +0000)]
2009-11-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Centralize required argument parsing in Command
        https://bugs.webkit.org/show_bug.cgi?id=31872

        * Scripts/modules/commands/download.py: remove custom required arg message.
        * Scripts/modules/commands/upload.py: ditto.
        * Scripts/modules/multicommandtool.py:
         - Add _parse_required_arguments.
         - Pass program name off to OptionParser.
         - Add name() for access to tool name.
         - Add check_arguments_and_execute and make it return a return code.
         - Replace a couple uses of + with %.
        * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Wed, 25 Nov 2009 15:59:05 +0000 (15:59 +0000)]
2009-11-25  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] use gst_init_check() instead of gst_init()
        https://bugs.webkit.org/show_bug.cgi?id=31864

        Use gst_init_check() instead of gst_init() to prevent eventual
        unexpected exit of the application.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::do_gst_init):
        (WebCore::MediaPlayerPrivate::isAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Nov 2009 15:46:04 +0000 (15:46 +0000)]
2009-11-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
        https://bugs.webkit.org/show_bug.cgi?id=31870

        * Scripts/modules/commands/queries_unittest.py: Use the new class.
        * Scripts/modules/multicommandtool_unittest.py: Ditto.
        * Scripts/modules/outputcapture.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Xan Lopez.
kov@webkit.org [Wed, 25 Nov 2009 13:01:00 +0000 (13:01 +0000)]
    Reviewed by Xan Lopez.

        Some tests are crashing from time to time
        https://bugs.webkit.org/show_bug.cgi?id=31866

        Make sure we do not notify the client of a finished load, if the
        load has been cancelled, or the client is gone.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Android] Upstream Android changes to WebCore/bridge/jni
benm@google.com [Wed, 25 Nov 2009 11:02:18 +0000 (11:02 +0000)]
[Android] Upstream Android changes to WebCore/bridge/jni
https://bugs.webkit.org/show_bug.cgi?id=31824

Reviewed by Eric Seidel.

No new tests required as no new functionality.

* bridge/jni/jni_class.cpp:
(JavaClass::JavaClass): Add calls to delete allocated references, to avoid potential leaks.
* bridge/jni/jni_instance.cpp: Add an Android include path.
* bridge/jni/jni_instance.h: Add getter/setter for JObjectWrapper::_instance and make the JavaInstance ctor and member variables protected. Both needed for the Android port, see bug for discussion.
(JSC::Bindings::JObjectWrapper::instance): Added.
(JSC::Bindings::JObjectWrapper::setInstance): Added.
* bridge/jni/jni_runtime.cpp:
(JavaMethod::JavaMethod): Delete an allocated reference to avoid a potential leak.
* bridge/jni/jni_utility.h:
(JSC::Bindings::callJNIMethodV): Delete an allocated reference to avoid a potential leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for classes of the plugins and rendering direc...
zoltan@webkit.org [Wed, 25 Nov 2009 08:25:57 +0000 (08:25 +0000)]
Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31827

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name               - instantiated at: WebCore/'location'

class PluginRequest             - plugins/PluginView.cpp:521
class PluginMainThreadScheduler - plugins/PluginMainThreadScheduler.cpp:34
class PluginDatabase            - plugins/PluginDatabase.cpp:50
struct MimeClassInfo            - plugins/PluginInfoStore.cpp:50
struct PluginInfo               - plugins/PluginInfoStore.cpp:40
class RenderArena               - dom/Document.cpp:1401
class RenderImageScaleData      - rendering/RenderImage.cpp:149
class TableLayout               - (its child class) rendering/RenderTable.cpp:82
struct ColumnInfo               - rendering/RenderBlock.cpp:3590
struct FloatingObject           - rendering/RenderBlock.cpp:2300
struct MaxMargin                - rendering/RenderBlock.cpp:4794
class RenderMarquee             - rendering/RenderLayer.cpp:3277

* plugins/PluginData.h:
* plugins/PluginDatabase.h:
* plugins/PluginMainThreadScheduler.h:
* plugins/PluginView.h:
* rendering/RenderArena.h:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderImage.cpp:
* rendering/RenderMarquee.h:
* rendering/TableLayout.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUn-roll out the roll out that was committed in r51376 because it didn't help the...
bweinstein@apple.com [Wed, 25 Nov 2009 07:32:53 +0000 (07:32 +0000)]
Un-roll out the roll out that was committed in r51376 because it didn't help the Windows bots,
even though it seemed to in my testing. Sorry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r51354, r51460, and r51461 to see if removing them will fix
bweinstein@apple.com [Wed, 25 Nov 2009 07:04:44 +0000 (07:04 +0000)]
Roll out r51354, r51460, and r51461 to see if removing them will fix
the Windows test bots, which are currently not very happy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Another Windows build fix
cmarrin@apple.com [Wed, 25 Nov 2009 06:04:56 +0000 (06:04 +0000)]
    Another Windows build fix

        Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
        we turn on ACCELERATED_COMPOSITING

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInitial implementation of WebKitSharedScript and SharedScriptContext
dimich@chromium.org [Wed, 25 Nov 2009 06:01:46 +0000 (06:01 +0000)]
Initial implementation of WebKitSharedScript and SharedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=31569

Reviewed by David Levin.

No new tests since there are no bindings yet (soon to come).

* DerivedSources.make: Add WebKitSharedScript and SharedScriptContext to a list of idl files.
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::detach): Notify WebKitSharedScriptRepository that document is detaching.
* dom/EventTarget.cpp: Add new casting methods, since the new types are EventTargets.
(WebCore::EventTarget::toWebKitSharedScript):
(WebCore::EventTarget::toSharedScriptContext):
* dom/EventTarget.h: Ditto
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isSharedScriptContext): New virtual method, since there is a new type of context.

* SharedScript/SharedScriptContext.cpp: Added. Similar to WorkerContext, but w/o threading.
(WebCore::SharedScriptContext::SharedScriptContext):
(WebCore::SharedScriptContext::~SharedScriptContext):
(WebCore::SharedScriptContext::clearScript):
(WebCore::SharedScriptContext::virtualURL):
(WebCore::SharedScriptContext::virtualCompleteURL):
(WebCore::SharedScriptContext::reportException):
(WebCore::SharedScriptContext::addMessage):
(WebCore::SharedScriptContext::resourceRetrievedByXMLHttpRequest):
(WebCore::SharedScriptContext::scriptImported):
(WebCore::SharedScriptContext::matches):
(WebCore::SharedScriptContext::addToDocumentsList):
(WebCore::SharedScriptContext::destructionTimerFired):
(WebCore::SharedScriptContext::removeFromDocumentList):
(WebCore::SharedScriptContext::load):
(WebCore::SharedScriptContext::postTask):
(WebCore::SharedScriptContext::eventTargetData):
(WebCore::SharedScriptContext::ensureEventTargetData):
(WebCore::SharedScriptContext::scriptExecutionContext):
* SharedScript/SharedScriptContext.h: Added.
(WebCore::SharedScriptContext::create):
(WebCore::SharedScriptContext::isSharedScriptContext):
(WebCore::SharedScriptContext::userAgent):
(WebCore::SharedScriptContext::toSharedScriptContext):
(WebCore::SharedScriptContext::self):
(WebCore::SharedScriptContext::script):
(WebCore::SharedScriptContext::loaded):
(WebCore::SharedScriptContext::name):
(WebCore::SharedScriptContext::refEventTarget):
(WebCore::SharedScriptContext::derefEventTarget):
(WebCore::SharedScriptContext::refScriptExecutionContext):
(WebCore::SharedScriptContext::derefScriptExecutionContext):
* SharedScript/SharedScriptContext.idl: Added.

* SharedScript/SharedScriptController.h:
Added. Empty implementation of a ScriptController, will come later as part of bindings. Needed to compile.

* SharedScript/WebKitSharedScript.cpp: Added. EventTarget-based DOM object.
(WebCore::WebKitSharedScript::WebKitSharedScript):
(WebCore::WebKitSharedScript::~WebKitSharedScript):
(WebCore::WebKitSharedScript::setContext):
(WebCore::LoadEventTask::create): Fires asynchronous 'load' event when underlying SharedScriptContext is initialized.
(WebCore::LoadEventTask::performTask):
(WebCore::LoadEventTask::LoadEventTask):
(WebCore::WebKitSharedScript::scheduleLoadEvent):
* SharedScript/WebKitSharedScript.h: Added.
(WebCore::WebKitSharedScript::create):
(WebCore::WebKitSharedScript::scriptExecutionContext):
(WebCore::WebKitSharedScript::toWebKitSharedScript):
(WebCore::WebKitSharedScript::context):
(WebCore::WebKitSharedScript::refEventTarget):
(WebCore::WebKitSharedScript::derefEventTarget):
(WebCore::WebKitSharedScript::eventTargetData):
(WebCore::WebKitSharedScript::ensureEventTargetData):
* SharedScript/WebKitSharedScript.idl: Added.

* SharedScript/WebKitSharedScriptRepository.cpp: Added. Implements a list of running SharedScriptContexts.
(WebCore::ScriptLoader::ScriptLoader): The helper class to load an initial script of SharedScriptContext.
(WebCore::ScriptLoader::load):
(WebCore::ScriptLoader::notifyFinished):
(WebCore::WebKitSharedScriptRepository::instance): Repository has a static global instance.
(WebCore::WebKitSharedScriptRepository::connect):
(WebCore::WebKitSharedScriptRepository::documentDetached): Called from Document::detach().
(WebCore::WebKitSharedScriptRepository::removeSharedScriptContext): Called from ~SharedScriptContext().
(WebCore::WebKitSharedScriptRepository::connectToSharedScript):
(WebCore::WebKitSharedScriptRepository::getSharedScriptContext):
* SharedScript/WebKitSharedScriptRepository.h: Added.
(WebCore::WebKitSharedScriptRepository::WebKitSharedScriptRepository):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
dimich@chromium.org [Wed, 25 Nov 2009 05:38:48 +0000 (05:38 +0000)]
Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31444

Reviewed by Eric Seidel.

* configure.ac:

JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

WebCore:

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* WebCore.pro:

WebKit:

* chromium/features.gypi:

WebKit/chromium:

* features.gypi:

WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

WebKitTools:

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixed Windows build
cmarrin@apple.com [Wed, 25 Nov 2009 05:22:14 +0000 (05:22 +0000)]
    Fixed Windows build

        Got rid of QuartzCore.lib dependency. Not needed until
        we turn on ACCELERATED_COMPOSITING

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement accelerated compositing
cmarrin@apple.com [Wed, 25 Nov 2009 04:29:42 +0000 (04:29 +0000)]
Implement accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=27314

Initial implementation, but disabled in this checkin.
To enable ENABLE_3D_RENDERING and USE_ACCELERATED_COMPOSITING
must be turned on. Also d3d9.lib and d3d9x.lib must be added
to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Do error checking of parameter to createShader
cmarrin@apple.com [Wed, 25 Nov 2009 03:13:06 +0000 (03:13 +0000)]
    Do error checking of parameter to createShader
        https://bugs.webkit.org/show_bug.cgi?id=31808

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Jason Smith <dark.panda@gmail.com>
eric@webkit.org [Wed, 25 Nov 2009 02:45:02 +0000 (02:45 +0000)]
2009-11-24  Jason Smith  <dark.panda@gmail.com>

        Reviewed by Alexey Proskuryakov.

        RegExp#exec's returned Array-like object behaves differently from
        regular Arrays
        https://bugs.webkit.org/show_bug.cgi?id=31689

        * LayoutTests/fast/js/regexp-in-and-foreach-handling.html: Added.
        * LayoutTests/fast/js/script-tests/regexp-in-and-foreach-handling.js: Added.
        * LayoutTests/fast/js/regexp-in-and-foreach-handling-expected.txt: Added.
2009-11-24  Jason Smith  <dark.panda@gmail.com>

        Reviewed by Alexey Proskuryakov.

        RegExp#exec's returned Array-like object behaves differently from
        regular Arrays
        https://bugs.webkit.org/show_bug.cgi?id=31689

        * JavaScriptCore/runtime/RegExpConstructor.cpp: ensure that undefined
        values are added to the returned RegExpMatchesArray

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Wed, 25 Nov 2009 02:16:38 +0000 (02:16 +0000)]
2009-11-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Ignore line-height CSS property specified to a search field on
        Windows and Linux.
        https://bugs.webkit.org/show_bug.cgi?id=31820

        LayoutTests/fast/forms/control-restrict-line-height.html checks that the
        following controls should ignore line-height CSS property.
         - <select>
         - <input type=button>
         - <input type=search>
        This change addresses the <input type=search> issue with Chromium/Windows
        and Chromium/Linux.

        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle): Implement this to ignore line-height.
        * rendering/RenderThemeChromiumSkia.h: Declare adjustSearchFieldStyle().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Nov 2009 01:22:56 +0000 (01:22 +0000)]
2009-11-24  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Stylistic fix: indent the member var initialisation.

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::GraphicsLayerCA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Nov 2009 00:24:57 +0000 (00:24 +0000)]
2009-11-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt.

        SVGUseElement::toClipPath can crash
        <rdar://problem/7385270>

        Null-test m_shadowTreeRootElement again, because the call to buildPendingResource() may not
        actually initialize it.

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::toClipPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Chromium's gyp-generated Xcode projects to the .gitignore file.
snej@chromium.org [Wed, 25 Nov 2009 00:06:17 +0000 (00:06 +0000)]
Add Chromium's gyp-generated Xcode projects to the .gitignore file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Evan Stade <estade@chromium.org>
eric@webkit.org [Tue, 24 Nov 2009 23:46:21 +0000 (23:46 +0000)]
2009-11-24  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin.

        Linux Chromium sends too many click events
        https://bugs.webkit.org/show_bug.cgi?id=31841

        Manually count number of clicks for double/triple click events. This
        makes us match Firefox on http://www.quirksmode.org/js/events_mouse.html
        Chromium side of this patch is here:
        http://codereview.chromium.org/431031/show

        * src/gtk/WebInputEventFactory.cpp:
        (WebKit::WebInputEventFactory::mouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 31848 - Remove uses of mainThreadCurrentWorld, and of currentWorld using a global...
barraclough@apple.com [Tue, 24 Nov 2009 23:43:04 +0000 (23:43 +0000)]
Bug 31848 - Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.

Reviewed by Geoff Garen.

These methods get the world from the global data rather than from an execstate.
If the current world is always read from an exec state then it can be read
from the global object, and world entry can become automagical, rather than
being explicitly set by an EnterDOMWrapperWorld.

* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::DOMObjectWrapperMapFor):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapper):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::cacheDOMNodeWrapper):
* bindings/js/JSDOMBinding.h:
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
(WebCore::createWrapper):
(WebCore::toJS):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 24 Nov 2009 23:19:28 +0000 (23:19 +0000)]
2009-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queries_unittest.py should test command output
        https://bugs.webkit.org/show_bug.cgi?id=31845

        * Scripts/modules/commands/queries_unittest.py:
         - Capture stdout and stderr and compare with expected strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
ap@apple.com [Tue, 24 Nov 2009 22:41:11 +0000 (22:41 +0000)]
    Windows build fix.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: Also, don't include the wrong one!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
ap@apple.com [Tue, 24 Nov 2009 22:34:15 +0000 (22:34 +0000)]
    Windows build fix.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: Include the proper WKSI header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Nov 2009 22:32:08 +0000 (22:32 +0000)]
2009-11-24  Simon Fraser  <simon.fraser@apple.com>

        Windows build fix.

        * page/win/FrameCGWin.cpp:
        (WebCore::imageFromRect):
        (WebCore::imageFromSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 24 Nov 2009 22:21:06 +0000 (22:21 +0000)]
2009-11-24  Eric Carlson  <eric.carlson@apple.com>

        Not reviewed. Revert r51351 until a new WebKitSupportLibrary is available.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
        * platform/graphics/win/QTMovieWin.cpp:
        * platform/graphics/win/QTMovieWin.h:
        * rendering/RenderMediaControls.cpp:
        * rendering/RenderThemeWin.cpp:
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Nov 2009 22:16:29 +0000 (22:16 +0000)]
2009-11-24  Simon Fraser  <simon.fraser@apple.com>

        No Review.

        Fix spelling error ("depenedencies").

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand the configuration that includes the two debug GTK Linux builders.
mrowe@apple.com [Tue, 24 Nov 2009 22:05:40 +0000 (22:05 +0000)]
Land the configuration that includes the two debug GTK Linux builders.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Nov 2009 21:54:22 +0000 (21:54 +0000)]
2009-11-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Find highlight is drawn incorrectly on pages with compositing layers
        <rdar://problem/7413925>

        Part 2: Add a new bit to the PaintBehavior flags, PaintBehaviorFlattenCompositingLayers,
        and pass that down when painting into an image.

        When set, it forces painting of compositing layers to go down a software paint path
        when all layers are painted, irrespective of compositing status, and where
        3d transforms are flattened to 2d. When doing this, we also need to use temporary
        clip rects for layers which are normally composited.

        * page/FrameView.h:
        (WebCore::FrameView::paintBehavior):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::imageFromRect):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::renderableTransform):
        (WebCore::expandClipRectForDescendantsAndReflection):
        (WebCore::transparencyClipBox):
        (WebCore::RenderLayer::beginTransparencyLayers):
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::paintsWithTransparency):
        (WebCore::RenderLayer::paintsWithTransform):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 24 Nov 2009 21:50:55 +0000 (21:50 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=31844
        SocketStreamHandleCFNet should support CONNECT proxy credentials

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/CredentialStorage.h:
        * platform/network/mac/CredentialStorageMac.mm: Added.
        (WebCore::CredentialStorage::getFromPersistentStorage):
        * platform/network/cf/CredentialStorageCFNet.cpp: Added.
        (WebCore::CredentialStorage::getFromPersistentStorage):
        Add support for fetching credentials from persistent storage (CFNet version is currently
        a stub).

        * bindings/js/JSWebSocketCustom.cpp: Removed an unneeded include.

        * platform/network/cf/SocketStreamHandle.h:
        * platform/network/cf/SocketStreamHandleCFNet.cpp:
        (WebCore::SocketStreamHandle::SocketStreamHandle):
        (WebCore::SocketStreamHandle::createStreams):
        (WebCore::getStoredCONNECTProxyCredentials):
        (WebCore::authenticationSchemeFromAuthenticationMethod):
        (WebCore::SocketStreamHandle::addCONNECTCredentials):
        (WebCore::SocketStreamHandle::readStreamCallback):
        Check if connection attempt was resulted in 407, and try stored credentials if it did.

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * WebCore.base.exp:
        Updated WKSI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Nov 2009 21:44:41 +0000 (21:44 +0000)]
2009-11-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Find highlight is drawn incorrectly on pages with compositing layers
        <rdar://problem/7413925>

        Part 1: Rename PaintRestriction to PaintBehavior, and make it a bitmask, in
        preparation for adding a new flag related to painting into an image.

        PaintBehaviorSelectionOnly and PaintBehaviorForceBlackText are now separate flags.

        * page/FrameView.cpp:
        (WebCore::FrameView::reset):
        (WebCore::FrameView::paintContents):
        (WebCore::FrameView::setPaintBehavior):
        * page/FrameView.h:
        * page/mac/FrameMac.mm:
        (WebCore::Frame::selectionImage):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint):
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerBacking.h:
        * rendering/RenderObject.h:
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSON.stringify performance on undefined is very poor
oliver@apple.com [Tue, 24 Nov 2009 21:41:53 +0000 (21:41 +0000)]
JSON.stringify performance on undefined is very poor
https://bugs.webkit.org/show_bug.cgi?id=31839

Reviewed by Alexey Proskuryakov.

Switch from a UString to a Vector<UChar> when building
the JSON string, allowing us to safely remove the substr-copy
we otherwise did when unwinding an undefined property.

Also turns out to be a ~5% speedup on stringification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-24 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 24 Nov 2009 21:31:35 +0000 (21:31 +0000)]
2009-11-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7409331> Windows: Support closed caption in <video> element

        Enable closed captions in QuickTime/Windows media engine.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::hasClosedCaptions):
        (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::hasClosedCaptions):
        (QTMovieWin::setClosedCaptionsVisible):
        * platform/graphics/win/QTMovieWin.h:
        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51351 268f45cc-cd09-0410-ab3c-d52691b4dbfc