WebKit-https.git
14 years agoMoved QWebFrame::selectedText() to QWebPage::selectedText().
hausmann [Wed, 7 Nov 2007 14:31:16 +0000 (14:31 +0000)]
Moved QWebFrame::selectedText() to QWebPage::selectedText().

The currently selected text is a property of the page as a whole.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented support for settings propagation.
hausmann [Wed, 7 Nov 2007 14:31:11 +0000 (14:31 +0000)]
Implemented support for settings propagation.

If an individual setting is not set in a page's QWebSettings then it is inherited from the default settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReworked the QWebSettings API.
hausmann [Wed, 7 Nov 2007 14:31:04 +0000 (14:31 +0000)]
Reworked the QWebSettings API.
QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMade the QWebSettings::webGraphic functions static. The implementation was using...
hausmann [Wed, 7 Nov 2007 14:30:57 +0000 (14:30 +0000)]
Made the QWebSettings::webGraphic functions static. The implementation was using QWebSettings::global() anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp...
hausmann [Wed, 7 Nov 2007 14:30:50 +0000 (14:30 +0000)]
Moved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp to ImageQt.cpp and made it static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the icondatabase accessor to be a static function because it doesn't change...
hausmann [Wed, 7 Nov 2007 14:30:43 +0000 (14:30 +0000)]
Changed the icondatabase accessor to be a static function because it doesn't change the QWebSettings object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the webAction() accessor to not be a slot but just a public function.
hausmann [Wed, 7 Nov 2007 14:30:38 +0000 (14:30 +0000)]
Changed the webAction() accessor to not be a slot but just a public function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented createWindow() in QtLauncher.
hausmann [Wed, 7 Nov 2007 14:30:34 +0000 (14:30 +0000)]
Implemented createWindow() in QtLauncher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented opening links in new windows
hausmann [Wed, 7 Nov 2007 14:30:28 +0000 (14:30 +0000)]
Implemented opening links in new windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded and implemented the "OpenLink" action.
hausmann [Wed, 7 Nov 2007 14:30:22 +0000 (14:30 +0000)]
Added and implemented the "OpenLink" action.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdjust the state of the reload action correctly.
hausmann [Wed, 7 Nov 2007 14:30:17 +0000 (14:30 +0000)]
Adjust the state of the reload action correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoInitialize the undo/redo actions from QUndoStack. That automatically takes care of...
hausmann [Wed, 7 Nov 2007 14:30:11 +0000 (14:30 +0000)]
Initialize the undo/redo actions from QUndoStack. That automatically takes care of enabling/disabling them as well as the activation/trigger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded undo/redo toolbar buttons, moved the location line edit into a separate toolbar.
hausmann [Wed, 7 Nov 2007 14:30:05 +0000 (14:30 +0000)]
Added undo/redo toolbar buttons, moved the location line edit into a separate toolbar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate the editor actions when the selection changes.
hausmann [Wed, 7 Nov 2007 14:30:00 +0000 (14:30 +0000)]
Update the editor actions when the selection changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded cut/copy/paste actions to the toolbar of QtLauncher
hausmann [Wed, 7 Nov 2007 14:29:54 +0000 (14:29 +0000)]
Added cut/copy/paste actions to the toolbar of QtLauncher

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoStarted working on keeping the state of the navigation actions up-to-date.
hausmann [Wed, 7 Nov 2007 14:29:48 +0000 (14:29 +0000)]
Started working on keeping the state of the navigation actions up-to-date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse the navigational web actions in the toolbar
hausmann [Wed, 7 Nov 2007 14:29:42 +0000 (14:29 +0000)]
Use the navigational web actions in the toolbar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoStore a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
hausmann [Wed, 7 Nov 2007 14:29:37 +0000 (14:29 +0000)]
Store a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
Added QWebPageContext to hold context sensitive information (for example used by the context menu).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved the editing actions implemented in keyPressEvent into webActionTriggered.
hausmann [Wed, 7 Nov 2007 14:29:31 +0000 (14:29 +0000)]
Moved the editing actions implemented in keyPressEvent into webActionTriggered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoIntroduced a central virtual void webActionTriggered(WebAction action) method that...
hausmann [Wed, 7 Nov 2007 14:29:25 +0000 (14:29 +0000)]
Introduced a central virtual void webActionTriggered(WebAction action) method that is called from various
convenience methods such as cut()/copy()/paste().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRestructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem...
hausmann [Wed, 7 Nov 2007 14:29:19 +0000 (14:29 +0000)]
Restructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem don't store
QActions/QMenus anymore but just store the action type, tag, title and optionally submenu as created
in ContextMenu::populate().
For the actual Qt context menu we traverse this structure after sendContextMenuEvent and create a QMenu
out of it. That menu is currently not functional anymore though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged ContextMenu::setPlatformDescription for the Qt port to not show the qmenu...
hausmann [Wed, 7 Nov 2007 14:29:11 +0000 (14:29 +0000)]
Changed ContextMenu::setPlatformDescription for the Qt port to not show the qmenu right away
but instead just behave as a normal setter that takes ownership of the platform menu description (the qmenu).
Instead now QWebPage::contextMenuEvent() retrieves the QMenu after calling sendContextMenuEvent and calls exec()
on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
hausmann [Wed, 7 Nov 2007 14:29:03 +0000 (14:29 +0000)]
Changed to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
Call sendContextMenuEvent on the event handler from a QWidget::contextMenuEvent re-implementation instead of in mousePressEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTurned onLoadProgressChanged into a real private slot.
hausmann [Wed, 7 Nov 2007 14:28:56 +0000 (14:28 +0000)]
Turned onLoadProgressChanged into a real private slot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake QWebHistory an explicitly shared object, returned as a pointer by QWebPage:...
hausmann [Wed, 7 Nov 2007 14:28:33 +0000 (14:28 +0000)]
Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agocomments on API changes that we'd like to do.
hausmann [Wed, 7 Nov 2007 14:23:14 +0000 (14:23 +0000)]
comments on API changes that we'd like to do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd a QWebPage::frameCreated() signal and fix DRT
hausmann [Wed, 7 Nov 2007 14:21:48 +0000 (14:21 +0000)]
Add a QWebPage::frameCreated() signal and fix DRT

The removal of createFrame in QWebPage broke the re-implementation
in DumpRenderTree. Instead emit a frameCreated() signal and
connect to it in DumpRenderTree.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove QWebPage::createFrame()
hausmann [Wed, 7 Nov 2007 14:19:53 +0000 (14:19 +0000)]
Remove QWebPage::createFrame()

now that QWebFrame doesn't have virtual methods anymore, there
is no need for a createFrame() factory method in QWebpage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMoved all the event handlers from QWebFrame into QWebPage.
hausmann [Wed, 7 Nov 2007 14:17:54 +0000 (14:17 +0000)]
Moved all the event handlers from QWebFrame into QWebPage.

This cleans up the public API and allows us to remove the
HackWebFrame hack in DumpRenderTree.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agodon't put nbsp's into the plan text paste
hausmann [Wed, 7 Nov 2007 14:01:41 +0000 (14:01 +0000)]
don't put nbsp's into the plan text paste

Fix both ClipboardQt and PasteboardQt to replace
nbsp's with spaces before putting the text onto the
native clipboard. This is consistent with Mac and Win
and fixes at least editing/pasteboard/4076267-3.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd now passing tests
hausmann [Wed, 7 Nov 2007 14:01:31 +0000 (14:01 +0000)]
Add now passing tests

The fix of umemcasecmp in UnicodeQt4.h fixed quite a lot
of test falures. Add these to our regression tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate test results after the last commit.
hausmann [Wed, 7 Nov 2007 14:01:15 +0000 (14:01 +0000)]
update test results after the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix umemcasecmp
hausmann [Wed, 7 Nov 2007 14:01:03 +0000 (14:01 +0000)]
fix umemcasecmp

Pretty embarrassing bug. Has the potential to fix quite a few test failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate the list of skipped tests.
hausmann [Wed, 7 Nov 2007 14:00:51 +0000 (14:00 +0000)]
Update the list of skipped tests.

Three more tests are passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement Pasteboard::writeImage()
hausmann [Wed, 7 Nov 2007 13:45:55 +0000 (13:45 +0000)]
Implement Pasteboard::writeImage()

* Pasteboard is now fully implemented. Copying of Images into the Clipboard
  is now supported.
* As with URLs we only copy into the Clipboard (and not additionally to the
  Selection)

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoApple CodingStyle fixes
hausmann [Wed, 7 Nov 2007 13:45:49 +0000 (13:45 +0000)]
Apple CodingStyle fixes

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement Pasteboard::writeURL()
hausmann [Wed, 7 Nov 2007 13:45:44 +0000 (13:45 +0000)]
Implement Pasteboard::writeURL()
* The URL currently gets written as text/plain and text/uri-list.
  The win and mac port have some more types which we currently do
  not support. When supporting them we can use the 'titleString'
  as well.
* As with writeSelection we only copy into the Clipboard. We could
  consider copying into the Selection as well.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoKill whitespace
hausmann [Wed, 7 Nov 2007 13:45:37 +0000 (13:45 +0000)]
Kill whitespace

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse correct UserAgent string.
hausmann [Wed, 7 Nov 2007 13:45:19 +0000 (13:45 +0000)]
Use correct UserAgent string.

* Only have one User Agent String and this place is QWebPage
* QWebPage::open -> QWebNetworkRequest -> QWebPage::open ->
  ResourceRequest -> FrameLoader::load -> QWebNetworkRequest
* ResourceRequest is != 0 when getting called from WebCore, we
  will only do requests when coming from WebCore and then we can
  use the User-Agent set with the help of the FrameLoaderClient
* We might want to change QWebNetworkRequest a bit

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplemented the two Javascript prompt callbacks in qt/DumpRenderTree
hausmann [Wed, 7 Nov 2007 13:18:13 +0000 (13:18 +0000)]
Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
to prevent the default implementation from popping up messageboxes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd more passing test cases.
hausmann [Wed, 7 Nov 2007 12:47:58 +0000 (12:47 +0000)]
add more passing test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse the correct function calls to convert a selection to
hausmann [Wed, 7 Nov 2007 12:47:47 +0000 (12:47 +0000)]
Use the correct function calls to convert a selection to
HTML or plain text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove two notImplemented() warnings, as I believe we don't
hausmann [Wed, 7 Nov 2007 12:47:39 +0000 (12:47 +0000)]
remove two notImplemented() warnings, as I believe we don't
have to implement these methods. Add some (commented out)
debug code in one place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
hausmann [Wed, 7 Nov 2007 12:44:20 +0000 (12:44 +0000)]
Add WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
That means that changes to the public API of the Qt port also trigger a rebuild of the tools.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSome more clipboard fixes.
hausmann [Wed, 7 Nov 2007 12:33:08 +0000 (12:33 +0000)]
Some more clipboard fixes.

We have to set things immediately on the QClipBoard if the
Clipboard object is not for dragging.

This is due to the fact that the Clipboard object might be
rather long lived if accessed through javascript (it'll only
get deleted by JS garbage collection). We have to transfer
the data over to the QClipboard before that to make things work.

Fixes editing/execCommand/copy-without-selection.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix compilation on Windows with non-cygwin perl.
hausmann [Wed, 7 Nov 2007 10:32:07 +0000 (10:32 +0000)]
Fix compilation on Windows with non-cygwin perl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove conflict marker.
mrowe@apple.com [Wed, 7 Nov 2007 10:14:50 +0000 (10:14 +0000)]
Remove conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrected ChangeLog grammar.
ap@webkit.org [Wed, 7 Nov 2007 09:53:29 +0000 (09:53 +0000)]
Corrected ChangeLog grammar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Finished moving editing/pasteboard/5583362.html to platform/mac (this test...
ap@webkit.org [Wed, 7 Nov 2007 09:52:20 +0000 (09:52 +0000)]
    Finished moving editing/pasteboard/5583362.html to platform/mac (this test was crashing in ObjC test plugin,
        because it couldn't find its resources.

        * editing/resources/plaintext-pasteboard-data.dat: Removed.
        * platform/mac/editing/resources: Added.
        * platform/mac/editing/resources/plaintext-pasteboard-data.dat: Copied from editing/resources/plaintext-pasteboard-data.dat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 7 Nov 2007 08:11:58 +0000 (08:11 +0000)]
WebCore:

        Reviewed by Brady Eidson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15877
          REGRESSION: r27486 caused a layout regression at my bank's website

        Test: fast/block/float/overhanging-after-height-decrease-offsets.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):

LayoutTests:

        Reviewed by Brady Eidson.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15877
          REGRESSION: r27486 caused a layout regression at my bank's website

        * fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Wed, 7 Nov 2007 07:23:25 +0000 (07:23 +0000)]
    Reviewed by Eric.

        - only collect when the heap is full, unless we have lots of extra cost garbage

        1.1% SunSpider speedup.

        This shouldn't hit memory use much since the extra space in those
        blocks hangs around either way.

        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate):
        (KJS::Collector::collect): Fix logic error that reversed the sense of collect's
        return value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move a Mac-specific test to platform/mac
aroben [Wed, 7 Nov 2007 07:00:14 +0000 (07:00 +0000)]
    Move a Mac-specific test to platform/mac

        * editing/pasteboard/5583362.html: Removed.
        * platform/mac/editing/pasteboard/5583362.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAvoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider
oliver [Wed, 7 Nov 2007 06:03:20 +0000 (06:03 +0000)]
Avoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider

Reviewed by Maciej

We now convert the common 'for (...; ...; <var>++) ...' to the semantically identical
'for (...; ...; ++<var>) ...'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Nov 2007 05:41:21 +0000 (05:41 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        * Scripts/build-testkjs: build fix... too many $$

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin [Wed, 7 Nov 2007 05:31:10 +0000 (05:31 +0000)]
WebCore:

        Reviewed by Sam.

        <rdar://problem/5575812> REGRESSION:When using absolute positioning
        with overflow:auto div, WebKit seems to add an additional 15px

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidthForPositioned): We need to
        subtract off the vertical scrollbar width too.

LayoutTests:

        Reviewed by Sam.

        New test for <rdar://problem/5575812> REGRESSION:When using
        absolute positioning with overflow:auto div, WebKit seems to add an
        additional 15px
        * fast/overflow/overflow-auto-position-absolute.html: Added.
        * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
        * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
        * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.

        Test with changed results. The measurements in the rtl example now
        more closely mirror the ltr example.
        * platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Change WebLocalizableStrings to take UTF-8 C strings
aroben [Wed, 7 Nov 2007 05:29:02 +0000 (05:29 +0000)]
     Change WebLocalizableStrings to take UTF-8 C strings

         This matches the way things work on the Mac, and will allow source
         files containing localizable strings to be shared between Mac and
         Windows. The old functions have not been removed for compatibility
         reasons, but are now just wrappers around the new UTF-8 functions.

         Reviewed by Ada.

         * WebKit.vcproj/WebKit.def: Added new functions.
         * WebKit.vcproj/WebKit_debug.def: Ditto.
         * WebLocalizableStrings.cpp:
         (copyLocalizedStringFromBundle): Changed to take a WebCore::String
         representing the key.
         (localizedString): Refactored from WebLocalizedString. Takes a
         WebCore::String representing the key.
         (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR.
         (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key.
         (WebLocalizedLPCTSTRUTF8): Ditto.
         (WebLocalizedString): Changed to call localizedString.
         (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
         * WebLocalizableStrings.h: Changed macros to use the new UTF-8
         functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Nov 2007 05:24:17 +0000 (05:24 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMove Mac files from WebKit into WebKit/mac.
mrowe@apple.com [Wed, 7 Nov 2007 03:01:16 +0000 (03:01 +0000)]
Move Mac files from WebKit into WebKit/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Wed, 7 Nov 2007 01:13:47 +0000 (01:13 +0000)]
WebCore:

        Reviewed by Dan Bernstein.

        <rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
        <rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block
        that encloses the input context, unless that block is the body, which shouldn't
        be cloned.  In that case, use regular divs, as we did before r27369.

LayoutTests:

        Reviewed by Dan Bernstein.

        <rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
        <rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

        * editing/pasteboard/5583362.html: Added.
        * editing/resources/plaintext-pasteboard-data.dat: Added.
        * platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5583362-expected.png: Added.
        * platform/mac/editing/pasteboard/5583362-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eseidel [Wed, 7 Nov 2007 01:03:26 +0000 (01:03 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        This fixes a regressed layout test for string + object

        SunSpider claims this was an overall 0.3% speedup, although some individual tests were slower.

        * kjs/nodes.cpp:
        (KJS::add): remove erroneous "fast path" for string + *

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric Seidel.
ggaren@apple.com [Wed, 7 Nov 2007 00:06:43 +0000 (00:06 +0000)]
    Reviewed by Eric Seidel.

        Added toJSNumber, a fast path for converting a JSValue to a JS number,
        and deployed it in postfix expressions. In the fast case this
        eliminates a call to jsNumber.

        0.4% speedup on SunSpider.

        * ChangeLog:
        * kjs/nodes.cpp:
        (KJS::PostIncResolveNode::evaluate):
        (KJS::PostIncLocalVarNode::evaluate):
        (KJS::PostDecResolveNode::evaluate):
        (KJS::PostDecLocalVarNode::evaluate):
        (KJS::PostIncBracketNode::evaluate):
        (KJS::PostDecBracketNode::evaluate):
        (KJS::PostIncDotNode::evaluate):
        (KJS::PostDecDotNode::evaluate):
        (KJS::UnaryPlusNode::evaluate):
        * kjs/value.h:
        (KJS::JSValue::toJSNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Christian Dywan <christian@twotoasts.de>
mrowe@apple.com [Wed, 7 Nov 2007 00:04:38 +0000 (00:04 +0000)]
2007-11-06  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=15828
        Bug 15828: WebKit GTK include and lib directory is installed in qt4-named directory

        * WebCore.pro: Use sane default install paths for the gtk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Wed, 7 Nov 2007 00:02:04 +0000 (00:02 +0000)]
2007-11-06  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix http://bugs.webkit.org/attachment.cgi?id=17043&action=view
        Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes

        FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
        to determine whether the given MIME type is displayable as an image or non-image.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (FrameLoaderClient::objectContentType): Change logic to match that in
        the Windows and Mac ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Correct test results.
antti [Tue, 6 Nov 2007 23:19:02 +0000 (23:19 +0000)]
    Correct test results.

        * platform/mac/fast/layers/layer-visibility-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
antti [Tue, 6 Nov 2007 23:00:27 +0000 (23:00 +0000)]
    Reviewed by Hyatt.

        Update test to cover
        <rdar://problem/5521068>
        Visibility not propagated correctly for children of a layer with z-index

        The fix for this was (accidentally) already checked in with r27277,
        with retroactive r=hyatt.

        * fast/layers/layer-visibility.html:
        * platform/mac/fast/layers/layer-visibility-expected.checksum:
        * platform/mac/fast/layers/layer-visibility-expected.png:
        * platform/mac/fast/layers/layer-visibility-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Tue, 6 Nov 2007 22:28:59 +0000 (22:28 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5576619>
        REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including
        both of the other deletion commands, call typingAddedToOpenCommand(), which takes
        the command's endingSelection and sets it as selection.

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

        * platform/mac/editing/input/5576619-expected.checksum: Added.
        * platform/mac/editing/input/5576619-expected.png: Added.
        * platform/mac/editing/input/5576619-expected.txt: Added.
        * platform/mac/editing/input/5576619.html: Added.
        * platform/mac/editing/input/text-input-controller-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin@apple.com [Tue, 6 Nov 2007 21:37:40 +0000 (21:37 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15846
          REGRESSION (r27387): Memory corruption when running fast/js/kde/delete.html

        There was a mistake in the algorithm used to find an empty slot in the property
        map entries vector; when we were putting in a new property value and not overwriting
        an existing deleted sentinel, we would enlarge the entries vector, but would not
        overwrite the stale data that's in the new part. It was easy to pin this down by
        turning on property map consistency checks -- I never would have landed with this
        bug if I had run the regression tests once with consistency checks on!

        * kjs/property_map.cpp: (KJS::PropertyMap::put): Changed logic for the case where
        foundDeletedElement is false to always use the item at the end of the entries vector.
        Also allowed me to merge with the logic for the "no deleted sentinels at all" case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Tue, 6 Nov 2007 21:03:35 +0000 (21:03 +0000)]
WebCore:

        Reviewed by Antti Koivisto and Dave Hyatt.

        - fix <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height

        Test: fast/block/float/overhanging-after-height-decrease.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): If after calculating the height
        it turns out that there are overhanging floats that were not overhanging
        before, rescan children with overhanging floats and add them.
        (WebCore::RenderBlock::layoutBlockChildren): Added a parameter that
        returns the lowest float bottom of any of the children.
        (WebCore::RenderBlock::addOverhangingFloats): Changed to return the
        lowest float bottom.
        * rendering/RenderBlock.h:

LayoutTests:

        Reviewed by Antti Koivisto and Dave Hyatt.

        - test for <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height

        * fast/block/float/overhanging-after-height-decrease.html: Added.
        * platform/mac-leopard/fast/block: Added.
        * platform/mac-leopard/fast/block/float: Added.
        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.checksum: Added.
        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-after-height-decrease-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Tue, 6 Nov 2007 19:53:18 +0000 (19:53 +0000)]
WebCore:

        Reviewed by Darin.

        Switched all uses of HTMLImageLoader to use OwnPtrs.

        * html/HTMLInputElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::init):
        (WebCore::HTMLInputElement::~HTMLInputElement):
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::attach):
        * html/HTMLObjectElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        (WebCore::HTMLObjectElement::attach):
        * html/HTMLVideoElement.h:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement):
        (WebCore::HTMLVideoElement::attach):
        (WebCore::HTMLVideoElement::detach):
        (WebCore::HTMLVideoElement::parseMappedAttribute):

LayoutTests:

        Reviewed by Darin.

        Added test for poster attribute.

        * media/content/abe.png: Added.
        * media/content/greenbox.png: Added.
        * media/video-poster-expected.txt: Added.
        * media/video-poster.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix previous patch to use a 3 bit shift, a 16 bit shift causes a regression in sunspider.
oliver [Tue, 6 Nov 2007 19:49:39 +0000 (19:49 +0000)]
Fix previous patch to use a 3 bit shift, a 16 bit shift causes a regression in sunspider.

RS=Darin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReplace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement...
oliver [Tue, 6 Nov 2007 19:34:41 +0000 (19:34 +0000)]
Replace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement in sunspider.

Reviewed by Darin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eseidel [Tue, 6 Nov 2007 18:56:05 +0000 (18:56 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        SunSpider claims this is a 1.1% speedup.

        * kjs/nodes.cpp:
        (KJS::throwOutOfMemoryError): Added, non inline.
        (KJS::addSlowCase): renamed from add(), non inline.
        (KJS::add): add fast path for String + String, Number + Number and String + *

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam and Steve.
darin@apple.com [Tue, 6 Nov 2007 18:43:38 +0000 (18:43 +0000)]
    Reviewed by Adam and Steve.

        - added hooks needed to implement showModalDialog on Windows

        * Interfaces/IWebUIDelegate.idl: Added canRunModal, createModalDialog,
        and runModal functions to the end of IWebUIDelegate3.

        * WebChromeClient.h: Added uiDelegate and uiDelegate2 helper functions,
        so it's easier to write client functions.
        * WebChromeClient.cpp:
        (WebChromeClient::createWindow): Implemented dialog case. Calls IWebUIDelegate3.
        (WebChromeClient::canRunModal): Implemented. Calls IWebUIDelegate3.
        (WebChromeClient::runModal): Ditto.
        (WebChromeClient::uiDelegate): Added.
        (WebChromeClient::uiDelegate2): Added.
        (WebChromeClient::uiDelegate3): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Tue, 6 Nov 2007 18:11:06 +0000 (18:11 +0000)]
WebCore:

        Reviewed by Darin.

        Trigger media load on on src attribute changes as specified in new HTML5 draft.

        Tests: media/video-src-change.html
               media/video-src-remove.html
               media/video-src-set.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged):
        * html/HTMLMediaElement.h:

LayoutTests:

        Reviewed by Darin.

        Tests for media src attribute changes.

        * media/video-src-change-expected.txt: Added.
        * media/video-src-change.html: Added.
        * media/video-src-remove-expected.txt: Added.
        * media/video-src-remove.html: Added.
        * media/video-src-set-expected.txt: Added.
        * media/video-src-set.html: Added.
        * media/video-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
ap [Tue, 6 Nov 2007 18:10:22 +0000 (18:10 +0000)]
    Rubber-stamped by Adam Roben.

        Windows build fix.

        * WebFrame.cpp:
        (WebFrame::string): plainText() returns a String now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Tue, 6 Nov 2007 17:48:56 +0000 (17:48 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15838
          Incomplete repaint toggling "How you know this person" on Facebook

        Test: fast/repaint/make-children-non-inline.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This
        is needed because the inline children may be repositioned as they move
        into new anonymous blocks, but those blocks have no knowledge of where
        their children used to be, so they cannot invalidate those areas.

LayoutTests:

        Reviewed by Darin Adler.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15838
          Incomplete repaint toggling "How you know this person" on Facebook

        * fast/repaint/make-children-non-inline.html: Added.
        * platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
        * platform/mac-leopard/fast/repaint: Added.
        * platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
        * platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Tue, 6 Nov 2007 16:07:38 +0000 (16:07 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=15847
        Some editing cleanup

        No change in functionality.

WebCore:
        * editing/TextIterator.cpp:
        (WebCore::plainText):
        * editing/TextIterator.h:
        Made WebCore::plainText() return String instead of DeprecatedString.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject textUnderElement]):
        (-[WebCoreAXObject value]):
        (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
        (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]):
        (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
        Updated for the above change. There is no need to explicitly convert to NSString now.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand): m_startingSelection and m_endingSelection are actually
        initialized in constructor body, so the work done in initializer list was wasted.

        (WebCore::EditCommand::apply): Moved some stars.
        (WebCore::EditCommand::unapply): Ditto.
        (WebCore::EditCommand::reapply): Ditto.
        (WebCore::EditCommand::setStartingSelection): The loop exit condition was evaluated twice,
        removed one of the checks.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::toString): plainText() result type now matches what we need here.

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        Removed unused -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] and
        -[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:].

WebKit:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView deleteToEndOfLine:]):
        (-[WebHTMLView deleteToEndOfParagraph:]):
        WebCore had a duplicate of the same logic already. We are passing a boundary value to
        a function that expects granularity, this may need to be straightened out in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-06 Eric Seidel <eric@webkit.org>
eseidel [Tue, 6 Nov 2007 09:08:56 +0000 (09:08 +0000)]
2007-11-06  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Avoid more UString creation.

        SunSpider claims this is a 0.4% speedup.

        * kjs/regexp_object.cpp:
        (KJS::RegExpObjectImp::construct): use UString::find(UChar)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 6 Nov 2007 07:47:29 +0000 (07:47 +0000)]
2007-11-05  Mark Rowe  <mrowe@apple.com>

        Mac build fix.

        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::writeHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 6 Nov 2007 07:30:22 +0000 (07:30 +0000)]
2007-11-05  Mark Rowe  <mrowe@apple.com>

        Mac build fix.

        * kjs/array_object.cpp:
        (KJS::ArrayProtoFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Don't crash if SafariTheme can't be loaded
aroben [Tue, 6 Nov 2007 07:20:24 +0000 (07:20 +0000)]
     Don't crash if SafariTheme can't be loaded

         PlatformScrollBarSafari and RenderThemeSafari were not checking
         whether SafariTheme was successfully loaded. All other uses of
         SafariTheme already check this.

         Reviewed by Steve.

         * platform/win/PlatformScrollBarSafari.cpp:
         (WebCore::PlatformScrollbar::paintButton):
         (WebCore::PlatformScrollbar::paintTrack):
         (WebCore::PlatformScrollbar::paintThumb):
         * rendering/RenderThemeSafari.cpp:
         (WebCore::RenderThemeSafari::isControlStyled):
         (WebCore::RenderThemeSafari::paintCheckbox):
         (WebCore::RenderThemeSafari::paintRadio):
         (WebCore::RenderThemeSafari::paintButton):
         (WebCore::RenderThemeSafari::paintTextField):
         (WebCore::RenderThemeSafari::paintCapsLockIndicator):
         (WebCore::RenderThemeSafari::paintTextArea):
         (WebCore::RenderThemeSafari::paintMenuList):
         (WebCore::RenderThemeSafari::paintSliderThumb):
         (WebCore::RenderThemeSafari::paintSearchField):
         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben [Tue, 6 Nov 2007 07:20:06 +0000 (07:20 +0000)]
    Windows build fix

        * kjs/list.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 6 Nov 2007 07:09:25 +0000 (07:09 +0000)]
2007-11-05  Mark Rowe  <mrowe@apple.com>

        Build fix.  Add missing #include.

        * kjs/operations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Eric Seidel <eric@webkit.org>
eseidel [Tue, 6 Nov 2007 06:48:10 +0000 (06:48 +0000)]
2007-11-05  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Remove another call to toString(exec)

        SunSpider claims this is a 0.5% speedup.

        * kjs/operations.cpp:
        (KJS::equal): remove another toString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdding the rest of wx port's graphics impl.
kevino [Tue, 6 Nov 2007 06:39:22 +0000 (06:39 +0000)]
Adding the rest of wx port's graphics impl.

Rubber-stamped by Maciej Stachowiak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Eric Seidel <eric@webkit.org>
eseidel [Tue, 6 Nov 2007 06:24:03 +0000 (06:24 +0000)]
2007-11-05  Eric Seidel  <eric@webkit.org>

        * kjs/operations.cpp:
        (KJS::equal): correct broken change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Eric Seidel <eric@webkit.org>
eseidel [Tue, 6 Nov 2007 06:17:22 +0000 (06:17 +0000)]
2007-11-05  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Remove one more call to toString(exec).

        SunSpider claims this is a 0.7% speedup.

        * kjs/operations.cpp:
        (KJS::equal): remove a call to toString()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx port bug fixes and new files to get platform/wx building on trunk.
kevino [Tue, 6 Nov 2007 05:52:06 +0000 (05:52 +0000)]
wx port bug fixes and new files to get platform/wx building on trunk.

Rubber-stamped by Maciej Stachowiak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
adele [Tue, 6 Nov 2007 05:43:16 +0000 (05:43 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/5579999> Add poster attribute for video element

        * html/HTMLAttributeNames.in: Added poster attribute.

        * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
          Calls imageSourceAttributeName instead of having special cases for the different kinds of elements.
        * dom/Element.cpp: (WebCore::Element::imageSourceAttributeName): Added.
        * dom/Element.h:
        * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::imageSourceAttributeName): Added.
        * html/HTMLObjectElement.h:

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieNetworkStateChanged):
          Calls updatePosterImage when the network state is empty and when the first frame has been loaded.
        * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::rendererIsNeeded): Made this inline.  HTMLVideoElement now also implements this.

        * html/HTMLVideoElement.idl: Added case for poster attribute.
        * html/HTMLVideoElement.h: Added image loader and flag to keep track of whether or not the poster image should be shown.
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement): Initialize m_imageLoader and m_shouldShowPosterImage.
        (WebCore::HTMLVideoElement::rendererIsNeeded): Calls HTMLElement::rendererIsNeeded since HTMLMediaElements have renderer by default.
        (WebCore::HTMLVideoElement::createRenderer): Create a RenderImage or RenderVideo depending on whether or not the poster image should be shown.
        (WebCore::HTMLVideoElement::attach): Set up image loader and RenderImage if necessary.
        (WebCore::HTMLVideoElement::detach): Delete image loader if its no longer needed.
        (WebCore::HTMLVideoElement::parseMappedAttribute): Added case to process poster attribute.
        (WebCore::HTMLVideoElement::poster): Added getter for poster attribute.
        (WebCore::HTMLVideoElement::setPoster): Added setter for poster attribute.
        (WebCore::HTMLVideoElement::isURLAttribute): Added.
        (WebCore::HTMLVideoElement::imageSourceAttributeName): Added.
        (WebCore::HTMLVideoElement::updatePosterImage): Added.  Updates m_shouldShowPosterImage and if its changed, detaches and attaches so the renderer is correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix <rdar://5563572> SVG image support is turned off
aroben [Tue, 6 Nov 2007 05:25:37 +0000 (05:25 +0000)]
Fix <rdar://5563572> SVG image support is turned off

WebCore:

        Fix <rdar://5563572> SVG image support is turned off

        Turned on SVG images for all platforms.

        Reviewed by Eric.

        * WebCore.vcproj/WebCore.vcproj: Added SVGImage.{cpp,h}
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage): Removed platform checks for
        SVGImage.

LayoutTests:

        Remove a now-passing test from the Windows Skipped file

        Reviewed by Eric.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix spelling errors in ChangeLogs, no review
eseidel [Tue, 6 Nov 2007 04:55:25 +0000 (04:55 +0000)]
Fix spelling errors in ChangeLogs, no review

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti [Tue, 6 Nov 2007 04:43:08 +0000 (04:43 +0000)]
    Reviewed by Darin.

        QTMovieView can generate callbacks during paint. This can lead to crashes.

        Delay callbacks so they get handled after painting is completed. No test case,
        I don't know how to reliably reproduce this.

        * platform/graphics/mac/MoviePrivateQTKit.mm:
        (WebCore::MoviePrivate::MoviePrivate):
        (WebCore::MoviePrivate::~MoviePrivate):
        (WebCore::MoviePrivate::paint):
        (-[WebCoreMovieObserver initWithCallback:WebCore::]):
        (-[WebCoreMovieObserver disconnect]):
        (-[WebCoreMovieObserver loadStateChanged:]):
        (-[WebCoreMovieObserver rateChanged:]):
        (-[WebCoreMovieObserver sizeChanged:]):
        (-[WebCoreMovieObserver timeChanged:]):
        (-[WebCoreMovieObserver volumeChanged:]):
        (-[WebCoreMovieObserver didEnd:]):
        (-[WebCoreMovieObserver setDelayCallbacks:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
antti [Tue, 6 Nov 2007 04:12:23 +0000 (04:12 +0000)]
    Reviewed by Adam.

        Add some missing WebCore* prefixes to ObjC classes

        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::FileChooser):
        * platform/mac/SharedBufferMac.mm:
        (WebCore::SharedBuffer::createNSData):
        (WebCore::SharedBuffer::createCFData):
        * platform/mac/SharedTimerMac.cpp:
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Christian Dywan <christian@twotoasts.de>
alp [Tue, 6 Nov 2007 02:53:16 +0000 (02:53 +0000)]
2007-11-05  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=15409
        FrameLoaderClientGtk hardcodes data, including platform to Linux i686

        Compute a proper user agent string.

        Patch includes fixes by Alp.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::agentPlatform):
        (WebKit::agentOS):
        (WebKit::composeUserAgent):
        (WebKit::FrameLoaderClient::userAgent):
        * WebCoreSupport/FrameLoaderClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5579772> Regression: AltGr does not work
adachan [Tue, 6 Nov 2007 02:10:05 +0000 (02:10 +0000)]
    <rdar://problem/5579772> Regression: AltGr does not work
        Testing whether alt-key is down is not the right test for system key event.
        Added a m_isSystemKey flag in PlatformKeyboardEvent to keep track of whether
        this is a system key event, check that flag instead in handleEditingKeyboardEvent().

        Reviewed by Oliver.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-05 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 6 Nov 2007 00:35:47 +0000 (00:35 +0000)]
2007-11-05  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * pcre/pcre.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
adachan [Tue, 6 Nov 2007 00:02:50 +0000 (00:02 +0000)]
    Build fix.

        Reviewed by Tristan.

        * WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
antti [Mon, 5 Nov 2007 23:56:01 +0000 (23:56 +0000)]
    Reviewed by Sam.

        Update WKQTMovieViewSetDrawSynchronously.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebView/WebView.mm:
sullivan@apple.com [Mon, 5 Nov 2007 23:21:10 +0000 (23:21 +0000)]
    * WebView/WebView.mm:
        (-[WebView _searchWithSpotlightFromMenu:]):

        Teeny style tweak to test svn access on other machine

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebView/WebView.mm:
sullivan@apple.com [Mon, 5 Nov 2007 23:12:58 +0000 (23:12 +0000)]
    * WebView/WebView.mm:
        (-[WebView computedStyleForElement:pseudoElement:]):

        Teeny style tweak to test svn access

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27454 268f45cc-cd09-0410-ab3c-d52691b4dbfc