14 years ago Rubber-stamped by Sam Weinig.
mitz [Fri, 19 Oct 2007 17:33:38 +0000 (17:33 +0000)]
    Rubber-stamped by Sam Weinig.

        removing a commented-out test and a test that no longer fails

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Fri, 19 Oct 2007 17:14:26 +0000 (17:14 +0000)]

        Reviewed by Darin.

        Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().

        * fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
        * fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
        Modified to create isSuccessfullyParsed() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclu...
hausmann [Fri, 19 Oct 2007 15:13:28 +0000 (15:13 +0000)]
Fix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclusion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoQt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.
hausmann [Fri, 19 Oct 2007 14:46:28 +0000 (14:46 +0000)]
Qt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix compilation on Windows when wchar_t is a typedef instead of a native type (trigge...
hausmann [Fri, 19 Oct 2007 14:14:13 +0000 (14:14 +0000)]
Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAnother build fix for the windows/qt build: Apply the same fix as in revision 26686...
hausmann [Fri, 19 Oct 2007 11:28:58 +0000 (11:28 +0000)]
Another build fix for the windows/qt build: Apply the same fix as in revision 26686 also to kjs/config.h to disable the disallowctype feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the windows/qt build by including config.h first to fix wtf/MathExtras.h inclusion.
hausmann [Fri, 19 Oct 2007 11:12:18 +0000 (11:12 +0000)]
Fix the windows/qt build by including config.h first to fix wtf/MathExtras.h inclusion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the qt/windows build.
hausmann [Fri, 19 Oct 2007 10:38:45 +0000 (10:38 +0000)]
Fix the qt/windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Oct 2007 08:58:14 +0000 (08:58 +0000)]
2007-10-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        Make the GtkLauncher code slightly more readable.

        * GtkLauncher/main.cpp:
        (setupMainMenu): Added.
        (setupMainWindowUI): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Adam.
mjs [Fri, 19 Oct 2007 08:01:39 +0000 (08:01 +0000)]
    Rubber stamped by Adam.

        - don't delay-load WebKit in DumpRenderTree.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Mark Rowe.
mitz [Fri, 19 Oct 2007 02:45:24 +0000 (02:45 +0000)]
    Rubber-stamped by Mark Rowe.

        removing tests that no longer fail

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Fri, 19 Oct 2007 02:19:44 +0000 (02:19 +0000)]

        Reviewed by Kevin McCullough.

        GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::exitNode): For selection preservation, we must emit a character
        between every VisiblePosition.  We weren't emitting a space after some tables, because
        we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline
        was emitted.


        Reviewed by Kevin McCullough.

        GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks

        Demonstrates fix for the hang:
        * editing/execCommand/5483526-expected.txt: Added.
        * editing/execCommand/5483526.html: Added.

        Fixed selection endpoint (problems with selection painting prevent this
        from being reflected in the pixel test results):
        * platform/mac/editing/execCommand/5432254-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
mjs [Fri, 19 Oct 2007 02:14:09 +0000 (02:14 +0000)]
    Reviewed by Adam.

        - use __declspec(thread) for fast thread-local storage on Windows

        - 2.2% speedup on sunspider (on Windows)
        - 7% speedup on the string section
        - 6% speedup on JS iBench

        - fixed <rdar://problem/5473084> PLT on Windows got 2.5% slower between r25406 and r25422
        - fixed at least some of <rdar://5527965? i-Bench JS was 14% slower in 310A11 than 310A10

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Tiger build fix.
mitz [Fri, 19 Oct 2007 00:49:23 +0000 (00:49 +0000)]
    Tiger build fix.

        * WebView/WebDataSource.mm:
        (-[WebDataSource _MIMETypeOfResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Fri, 19 Oct 2007 00:33:19 +0000 (00:33 +0000)]

        Reviewed by Adam Roben.

        - fix <rdar://problem/5313523>
        REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard

        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::doUpdateResourceResponse): Work around
        <rdar://problem/5321972> by testing for the case of a response
        with a MIME type of application/octet-stream and a Content-Type header
        starting with text/plain and setting the MIME type to text/plain in
        that case.


        Reviewed by Adam Roben.

        - fix <rdar://problem/5313523>
        REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
        * WebView/WebDataSource.mm:
        (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
        <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse
        with a MIMEType of application/octet-stream and a Content-Type header
        starting with text/plain and returning text/plain as the MIME type in
        that case.
        (-[WebDataSource _responseMIMEType]): Added. Used to get the correct
        response MIME type.
        (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
        (-[WebDataSource _makeRepresentation]): Ditto.
        (-[WebDataSource mainResource]): Ditto.
        (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
        pass the MIME type explicitly.
        (-[WebDataSource subresourceForURL:]): Ditto.
        * WebView/WebDataSourcePrivate.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
        * WebView/WebResource.mm:
        (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
        method to take a MIME type instead of extracting it from the response,
        so that WebDataSource could pass the correct MIME type.
        * WebView/WebResourcePrivate.h:


        Reviewed by Adam Roben.

        - fix <rdar://problem/5313523>
        REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dump): Changed to use _responseMIMEType.


        Reviewed by Adam Roben.

        - removing fixed test

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-18 Mark Rowe <mrowe@apple.com>
bdash [Thu, 18 Oct 2007 23:11:34 +0000 (23:11 +0000)]
2007-10-18  Mark Rowe  <mrowe@apple.com>

        Fix the no-SVG build.

        * css/CSSPrimitiveValueMappings.h: Move the CSSPrimitiveValue implementations for
        LineCap, LineJoin and WindRule inside #if ENABLE(SVG).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Thu, 18 Oct 2007 21:59:23 +0000 (21:59 +0000)]
    Reviewed by Anders.

        - some small tweaks to the threading implementation

        I had trouble building on Windows. Either the problem went away by itself
        or one of these changes fixed it.

        * platform/Threading.h: Eliminated the use of friend, and shared a single
        declaration for the initializeThreading function.

        * platform/pthreads/ThreadingPthreads.cpp: (WebCore::ThreadCondition::wait):
        Call impl() here.

        * platform/win/ThreadingWin.cpp: Got rid of two globals here with static
        constructors. Also added a typedef for the type of the function queue.
        (WebCore::functionQueueMutex): Added function.
        (WebCore::functionQueue): Ditto.
        (WebCore::callFunctionsOnMainThread): Use functions instead of using the
        globals directly.
        (WebCore::callOnMainThread): Ditto.

        * css/CSSParser.cpp: Had to touch this file to make things build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5547784> ProgIDMacros.h should explicitly use wide strings
aroben [Thu, 18 Oct 2007 21:35:32 +0000 (21:35 +0000)]
     Fix <rdar://5547784> ProgIDMacros.h should explicitly use wide strings

         Reviewed by Adele.

         * ProgIDMacros.h: Always use wide strings instead of relying on the
         TEXT macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5547462> Need to copy Inspector resources in Production builds
aroben [Thu, 18 Oct 2007 20:26:43 +0000 (20:26 +0000)]
     Fix <rdar://5547462> Need to copy Inspector resources in Production builds

         I also added an excludes file for the xcopy command to avoid copying
         .svn folders.

         Reviewed by Geoff.

         * WebCore.vcproj/WebCore.make: Make sure we copy the Inspector
         * WebCore.vcproj/WebCore.vcproj: Pass /exclude:xcopy.excludes to
         * WebCore.vcproj/xcopy.excludes: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Thu, 18 Oct 2007 17:00:19 +0000 (17:00 +0000)]

        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15541
          REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply

        * page/DOMWindow.idl: Add ConvertUndefinedOrNullToNullString back for defaultValue.


        Reviewed by Sam.

        - test update for http://bugs.webkit.org/show_bug.cgi?id=15541
          REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply

        * fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix. Not reviewed.
zimmermann [Thu, 18 Oct 2007 16:44:04 +0000 (16:44 +0000)]
Build fix. Not reviewed.
Hopefully fix win build by including wtf/MathExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Thu, 18 Oct 2007 16:21:34 +0000 (16:21 +0000)]

        Reviewed by Nikolas Zimmermann.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15367
          Assertion failure inspecting a document including soft hyphen code (0xad)

        Test: fast/text/word-break-soft-hyphen.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::calcPrefWidths): Changed to treat soft hyphens as
        word boundaries. This fixes the bug and is consistent with the fact that
        run rounding does occur at soft hyphens.


        Reviewed by Nikolas Zimmermann.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15367
          Assertion failure inspecting a document including soft hyphen code (0xad)

        * fast/text/word-break-soft-hyphen.html: Added.
        * platform/mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
        * platform/mac/fast/text/word-break-soft-hyphen-expected.png: Added.
        * platform/mac/fast/text/word-break-soft-hyphen-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Anders.
zimmermann [Thu, 18 Oct 2007 15:19:40 +0000 (15:19 +0000)]
Reviewed by Anders.

Fix last layout test failure seen on buildbot "trunk-mac-ppc-release".
Problem: "svg/custom/mask-excessive-malloc.svg -> crashed"

Clamp any ImageBuffer allocation within SVG to the RenderView's visibleSize
to avoid excessive mallocs (in the testcase above 1000000x1000000)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix.
ap [Thu, 18 Oct 2007 09:57:20 +0000 (09:57 +0000)]
    Windows build fix.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Add braces around cases that have local variables now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Release build fix.
ap [Thu, 18 Oct 2007 08:57:30 +0000 (08:57 +0000)]
    Release build fix.

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Thu, 18 Oct 2007 08:39:44 +0000 (08:39 +0000)]
    Reviewed by Darin.

        Split most of CSSPrimitiveValue enum mapping out of CSSComputedStyleDeclaration::getPropertyCSSValue()
        and CSSStyleSelector::applyProperty() (and their SVG counterparts). This should make the code more readable.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSPrimitiveValue.cpp:
        * css/CSSPrimitiveValue.h:
        * css/CSSPrimitiveValueMappings.h: Added.
        (WebCore::CSSPrimitiveValue::operator EBorderStyle):
        (WebCore::CSSPrimitiveValue::operator CompositeOperator):
        (WebCore::CSSPrimitiveValue::operator EAppearance):
        (WebCore::CSSPrimitiveValue::operator EBackgroundBox):
        (WebCore::CSSPrimitiveValue::operator EBackgroundRepeat):
        (WebCore::CSSPrimitiveValue::operator EBoxAlignment):
        (WebCore::CSSPrimitiveValue::operator EBoxDirection):
        (WebCore::CSSPrimitiveValue::operator EBoxLines):
        (WebCore::CSSPrimitiveValue::operator EBoxOrient):
        (WebCore::CSSPrimitiveValue::operator ECaptionSide):
        (WebCore::CSSPrimitiveValue::operator EClear):
        (WebCore::CSSPrimitiveValue::operator ECursor):
        (WebCore::CSSPrimitiveValue::operator EDisplay):
        (WebCore::CSSPrimitiveValue::operator EEmptyCell):
        (WebCore::CSSPrimitiveValue::operator EFloat):
        (WebCore::CSSPrimitiveValue::operator EKHTMLLineBreak):
        (WebCore::CSSPrimitiveValue::operator EListStylePosition):
        (WebCore::CSSPrimitiveValue::operator EListStyleType):
        (WebCore::CSSPrimitiveValue::operator EMarginCollapse):
        (WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
        (WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
        (WebCore::CSSPrimitiveValue::operator EMatchNearestMailBlockquoteColor):
        (WebCore::CSSPrimitiveValue::operator ENBSPMode):
        (WebCore::CSSPrimitiveValue::operator EOverflow):
        (WebCore::CSSPrimitiveValue::operator EPageBreak):
        (WebCore::CSSPrimitiveValue::operator EPosition):
        (WebCore::CSSPrimitiveValue::operator EResize):
        (WebCore::CSSPrimitiveValue::operator ETableLayout):
        (WebCore::CSSPrimitiveValue::operator ETextAlign):
        (WebCore::CSSPrimitiveValue::operator ETextSecurity):
        (WebCore::CSSPrimitiveValue::operator ETextTransform):
        (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
        (WebCore::CSSPrimitiveValue::operator EUserDrag):
        (WebCore::CSSPrimitiveValue::operator EUserModify):
        (WebCore::CSSPrimitiveValue::operator EUserSelect):
        (WebCore::CSSPrimitiveValue::operator EVisibility):
        (WebCore::CSSPrimitiveValue::operator EWhiteSpace):
        (WebCore::CSSPrimitiveValue::operator EWordBreak):
        (WebCore::CSSPrimitiveValue::operator EWordWrap):
        (WebCore::CSSPrimitiveValue::operator LineCap):
        (WebCore::CSSPrimitiveValue::operator LineJoin):
        (WebCore::CSSPrimitiveValue::operator TextDirection):
        (WebCore::CSSPrimitiveValue::operator WindRule):
        (WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
        (WebCore::CSSPrimitiveValue::operator EColorInterpolation):
        (WebCore::CSSPrimitiveValue::operator EColorRendering):
        (WebCore::CSSPrimitiveValue::operator EDominantBaseline):
        (WebCore::CSSPrimitiveValue::operator EImageRendering):
        (WebCore::CSSPrimitiveValue::operator EPointerEvents):
        (WebCore::CSSPrimitiveValue::operator EShapeRendering):
        (WebCore::CSSPrimitiveValue::operator ETextAnchor):
        (WebCore::CSSPrimitiveValue::operator ETextRendering):
        (WebCore::CSSPrimitiveValue::operator EWritingMode):
        * css/CSSStyleSelector.cpp:
        * ksvg2/css/SVGCSSComputedStyleDeclaration.cpp:
        * ksvg2/css/SVGCSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Thu, 18 Oct 2007 08:01:51 +0000 (08:01 +0000)]
    Reviewed by Eric.

        - Support Windows and Windows browsers.

        * hosted/sunspider-results.html: Display results correctly in IE.
        * sunspider: tweaks to work on Windows, and with spaces in the path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-18 Eric Seidel <eric@webkit.org>
eseidel [Thu, 18 Oct 2007 07:30:13 +0000 (07:30 +0000)]
2007-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Fix crashers in SVGViewSpec::parseViewSpec

        Test is blocked by bug 15503, landed as:
        * svg/dom/viewspec-parser.html-disabled

        * bindings/scripts/CodeGeneratorObjC.pm: support classes where all parents are interfaces
        * ksvg2/svg/SVGViewSpec.cpp:
        * ksvg2/svg/SVGViewSpec.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Oliver.
mjs [Thu, 18 Oct 2007 07:27:04 +0000 (07:27 +0000)]
    Rubber stamped by Oliver.

        * tests/string-tagcloud.js: Remove stray print()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Thu, 18 Oct 2007 07:17:41 +0000 (07:17 +0000)]
    Reviewed by Oliver.

        Add some string test cases.

        * tests/string-base64.js: Added. Does base64 encoding and decoding.
        * tests/string-tagcloud.js: Added. Parses a JSON string and
        generates tagcloud HTML markup based on the data.
        * tests/string-unpack-code.js: Added. Unpack compressed versions of
        four of the most popular JavaScript libraries.
        * tests/LIST: Added the new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make it possible to have Windows-specific tests and results
aroben [Thu, 18 Oct 2007 03:56:34 +0000 (03:56 +0000)]
     Make it possible to have Windows-specific tests and results

         When searching for tests to run and the Skipped file, we will only
         look in platform/win and the cross-platform directory. When looking
         for expected results, we will look in platform/win, then
         platform/mac-leopard, then platform/mac, then finally the
         cross-platform directory.

         Reviewed by Sam.

         * Scripts/run-webkit-tests:
         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
         searching in the cross-platform directory.
         (sub buildPlatformHierarchy): Removed some unneeded calls to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add back the call to register WebKit that we had before WebKitInitializer...
aroben [Thu, 18 Oct 2007 03:53:00 +0000 (03:53 +0000)]
     Add back the call to register WebKit that we had before WebKitInitializer existed

         This is needed to ensure that the right WebKit is used when
         instantiating COM objects.

         Reviewed by Oliver.

         * DumpRenderTree/win/debug_internal.vsprops: Define
         * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Thu, 18 Oct 2007 03:28:22 +0000 (03:28 +0000)]

        Reviewed by Darin, Adam, and Maciej.

        First element (in document order) is not returned when other duplicate ID-ed elements were created first

        Reset the element id cache when an id is added and there is a duplicate for that id.

        * dom/Document.cpp:


        Reviewed by Darin, Adam, and Maciej.

        Testcase for:
        First element (in document order) is not returned when other duplicate ID-ed elements were created first

        * fast/dom/duplicate-ids-document-order.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Import File::Basename in webkitdirs since we use it
aroben [Thu, 18 Oct 2007 03:17:36 +0000 (03:17 +0000)]
    Import File::Basename in webkitdirs since we use it

        Reviewed by NOBODY.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Updated the tiger leaks list to make the internal bots green.
kmccullo [Thu, 18 Oct 2007 01:07:54 +0000 (01:07 +0000)]
    - Updated the tiger leaks list to make the internal bots green.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix for VC++ Express
aroben [Thu, 18 Oct 2007 00:15:29 +0000 (00:15 +0000)]
    Build fix for VC++ Express

        Reviewed by NOBODY.

        * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
        and ole32.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix an ASSERT on launch on Windows
aroben [Thu, 18 Oct 2007 00:10:18 +0000 (00:10 +0000)]
    Fix an ASSERT on launch on Windows

        Fix dictated to me by Brady.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::syncThreadMainLoop): Make sure we hold
        m_syncLock before going into the loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-17 Mark Rowe <mrowe@apple.com>
bdash [Wed, 17 Oct 2007 23:51:34 +0000 (23:51 +0000)]
2007-10-17  Mark Rowe  <mrowe@apple.com>

        Mac build fix.

        * Configurations/WebCore.xcconfig:  Make it possible to include CoreGraphics header files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for clean builds needed after r26683
aroben [Wed, 17 Oct 2007 23:39:15 +0000 (23:39 +0000)]
    Fix for clean builds needed after r26683

        Reviewed by NOBODY.

        * WebView.cpp: Remove #include of non-existant file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben [Wed, 17 Oct 2007 23:10:09 +0000 (23:10 +0000)]
    Windows build fix

        Reviewed by NOBODY.

        * platform/graphics/AffineTransform.h: Don't #include
        * platform/graphics/cg/GraphicsContextCG.cpp: Add an #include that's
        needed now that we're not #including ApplicationServices.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-17 Mark Rowe <mrowe@apple.com>
bdash [Wed, 17 Oct 2007 22:57:12 +0000 (22:57 +0000)]
2007-10-17 Mark Rowe <mrowe@apple.com>

        Gtk build fix.  Move non-pthread stubs from Threading.h to ThreadingNone.cpp to prevent
        multiple-definition link errors.

        * WebCore.pro:
        * platform/Threading.h:
        * platform/ThreadingNone.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adele.
aliceli1 [Wed, 17 Oct 2007 22:37:23 +0000 (22:37 +0000)]
    Rubber-stamped by Adele.

        Correct uses of initKeyboardEvent for tests that test accesskey.
        Accesskey modifier is ctrl for mac and alt for other platforms.

        * fast/events/access-key-self-destruct.html:
        * fast/forms/access-key.html:
        * fast/forms/legend-access-key.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Wed, 17 Oct 2007 21:25:59 +0000 (21:25 +0000)]

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15543
          <rdar://problem/5545639> REGRESSION (r26697):
          GoogleDocs: Can't create new documents or open existing ones

        Test: fast/js/regexp-non-character.html

        * pcre/pcre_compile.c: (check_escape): Take out the checks for valid characters
        in the \u sequences -- not needed and actively harmful.


        Reviewed by Mark Rowe.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15543
          <rdar://problem/5545639> REGRESSION (r26697):
          GoogleDocs: Can't create new documents or open existing ones

        * fast/js/regexp-non-character-expected.txt: Added.
        * fast/js/regexp-non-character.html: Added.
        * fast/js/resources/regexp-non-character.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove stray change marker.
darin [Wed, 17 Oct 2007 21:15:16 +0000 (21:15 +0000)]
Remove stray change marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove stray merge marker.
darin [Wed, 17 Oct 2007 21:13:59 +0000 (21:13 +0000)]
Remove stray merge marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca [Wed, 17 Oct 2007 21:05:38 +0000 (21:05 +0000)]

        Reviewed by Oliver.

        * wtf/Platform.h:
        #define USE_PTHREADS on Mac.


        Reviewed by Oliver.

        * WebCore.xcodeproj/project.pbxproj:
        * WebCore.vcproj/WebCore.vcproj:

        * config.h:
        #define USE_PTHREADS on Windows.

        * loader/icon/IconDatabase.cpp:
        Update for mutex changes.

        * platform/Threading.h:
        Add a new Shared base class that uses a mutex to manage its refcount.

        New functions for thread creation.

        Move the definitions to ThreadingPthreads.cpp

        Move the definitions to ThreadingPthreads.cpp

        * platform/pthreads: Added.
        * platform/pthreads/ThreadingPthreads.cpp: Added.
        Add pthread specific implementation of the thread creation functions, Mutex and ThreadCondition.


        Update for locking primitive changes.

        * WebIconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Wed, 17 Oct 2007 21:01:27 +0000 (21:01 +0000)]
    Reviewed by Darin Adler.

        Merged DeclaredFunctionImp into FunctionImp (the base class) because
        the distinction between the two was unused.

        Removed codeType() from FunctionImp because FunctionImp and its
        subclasses all returned FunctionCode, so it was unused, practically

        Removed a different codeType() from GlobalFuncImp because it was unused.
        (Perhaps it was vestigial from a time when GlobalFuncImp used to
        inherit from FunctionImp.)

        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/function_object.cpp:
        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for creating a layer when a transform is in effect. Add support...
hyatt [Wed, 17 Oct 2007 20:28:09 +0000 (20:28 +0000)]
    Add support for creating a layer when a transform is in effect.  Add support to RenderStyle for
        handing back a computed AffineTransform.

        Reviewed by Mitz Pettel

        * css/CSSStyleSelector.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableRow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
darin [Wed, 17 Oct 2007 20:24:10 +0000 (20:24 +0000)]
    Reviewed by Mark Rowe.

        - fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]

        * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
        Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
        It's safe to do that for functions that return integers or pointers, but not structures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add a new nightly launcher script for Windows
aroben [Wed, 17 Oct 2007 20:12:42 +0000 (20:12 +0000)]
     Add a new nightly launcher script for Windows

         This new script is for versions of Safari that don't delay-load
         WebKit. I had to make FindSafari be able to print out the nightly
         launcher script on stdout because Windows shell scripts can't capture
         the output from a command into an environment variable.

         Reviewed by Steve.

         * FindSafari/FindSafari.cpp:
         (_tmain): Added /printSafariLauncher option.
         * Scripts/run-webkit-nightly.cmd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoStop delay-loading WebKit in DRT and teskjs
aroben [Wed, 17 Oct 2007 20:12:19 +0000 (20:12 +0000)]
Stop delay-loading WebKit in DRT and teskjs


        Make testkjs not delay-load WebKit

        Soon, delay-loading WebKit will be impossible (because we will be
        using __declspec(thread) for thread-local storage). This change
        prepares testkjs for the future.

        Reviewed by Sam.

        * JavaScriptCore.vcproj/JavaScriptCore.sln: Removed WebKitInitializer,
        added FindSafari.
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Don't link against
        WebKitInitializer, don't delay-load WebKit.
        * kjs/testkjs.cpp: Don't use WebKitInitializer.


        Replace WebKitInitializer with FindSafari

        We now rely on setting the PATH environment variable to tell Windows
        where to find WebKit and its dependencies (similar to
        DYLD_FRAMEWORK_PATH on Mac).

        This change also make DumpRenderTree no longer delay-load WebKit.

        Reviewed by Sam.

        * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
        * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
        WebKitInitializer, don't delay-load WebKit.
        * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
        * Scripts/run-webkit-tests: Ditto.
        * Scripts/webkitdirs.pm:
        (sub setPathForRunningWebKitApp): Added.
        * WebKitInitializer/WebKitInitializer.cpp: Removed.
        * WebKitInitializer/WebKitInitializer.h: Removed.
        * WebKitInitializer/WebKitInitializer.vcproj: Removed.
        * WebKitInitializer/debug.vsprops: Removed.
        * WebKitInitializer/debug_internal.vsprops: Removed.
        * WebKitInitializer/release.vsprops: Removed.


        Remove WebKitInitializer

        Reviewed by Sam.

        * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
aroben [Wed, 17 Oct 2007 20:11:24 +0000 (20:11 +0000)]
 Fix Bug 15532: run-safari fails if Safari is installed in a non-default location


         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location


         FindSafari simply prints the location of an installed Safari.exe on

         Reviewed by Darin.

         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
         * FindSafari/FindSafari.vcproj: Added.
         * Scripts/webkitdirs.pm:
         (sub installedSafariPath): Added. Calls FindSafari on Windows.


         Add FindSafari

         Reviewed by Darin.

         * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for mapping of the transform CSS property into RenderStyles....
hyatt [Wed, 17 Oct 2007 19:47:00 +0000 (19:47 +0000)]
    Add support for mapping of the transform CSS property into RenderStyles.  Everything is now ready for the front
        end to use.

        Reviewed by Mitz Pettel

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        * css/CSSTransformValue.h:
        * platform/graphics/AffineTransform.cpp:
        * platform/graphics/AffineTransform.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWindows build fix part 2.
aroben [Wed, 17 Oct 2007 19:30:07 +0000 (19:30 +0000)]
Windows build fix part 2.


        Windows build fix part 2.

        Fix was by Darin, reviewed by Anders and Adam.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add
        FastMallocPCRE.cpp to the project, and let Visual Studio have its way
        with the post-build step.
        * pcre/pcre.h: Don't DLL export the entry points just because this
        is Win32 -- this is an internal copy of PCRE and should be private.
        * pcre/pcre_compile.c: Fix an uninitialized variable warning --
        there's no real problem but it's better to quiet the compiler by
        tweaking the code slightly than turn off the warning entirely.


        * page/Frame.cpp: I had to touch this file when fixing the Windows
        build. Checking it in in case it helps others, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Oct 2007 18:33:25 +0000 (18:33 +0000)]
2007-10-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        Remove a couple more uses of svg_dynamic_cast.

        No functional changes, no tests.

        * ksvg2/svg/SVGPatternElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-17 Mark Rowe <mrowe@apple.com>
bdash [Wed, 17 Oct 2007 18:05:16 +0000 (18:05 +0000)]
2007-10-17  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric and Geoff.

        <rdar://problem/5453743> Repro ASSERT in CachedResource::setEncodedSize() loading image in background tab

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::setAutoLoadImages): Don't start a load if the CachedImage is already loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix.
aroben [Wed, 17 Oct 2007 17:54:08 +0000 (17:54 +0000)]
    Windows build fix.

        Reviewed by Anders.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable
        some mismatched signed/unsigned comparison warnings.
        * pcre/pcre_exec.c:
        (match): #if-out some labels that don't seem to exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Wed, 17 Oct 2007 17:51:27 +0000 (17:51 +0000)]

        Reviewed by Harrison.

        GoogleDocs: Safari hangs when indenting a particular table twice

        Fixed by fixing problems with the selection preservation done by IndentOutdentCommand.
        It is now more difficult to create selections that cause hangs.  Those are covered by:

        * editing/IndentOutdentCommand.cpp:
        (WebCore::indexForVisiblePosition): Compute indices from the first VisiblePosition
        in the document, instead of the first Position.
        Use rangeCompliantEquivalents when creating the Range that we pass to rangeLength.
        Tell TextIterator::rangeLength that we're doing selection preservation, so that it
        will emit characters between all VisiblePositions.
        (WebCore::IndentOutdentCommand::indentRegion): Fixed a bug where the range and location
        passed to rangeFromLocationAndLength were reversed.
        Tell rangeFromLocationAndLength that we're doing doing selection preservation, as
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeLength): Rename emitSpacesForReplacedElements
        to forSelectionPreservation, to match the name of the boolean inside TextIterator and
        to match its meaning after r25522.
        (WebCore::TextIterator::rangeFromLocationAndLength): Ditto.


        Reviewed by Harrison.

        GoogleDocs: Safari hangs when indenting a particular table twice

        * editing/execCommand/5481523.html: Added.
        * platform/mac/editing/execCommand/5481523-expected.checksum: Added.
        * platform/mac/editing/execCommand/5481523-expected.png: Added.
        * platform/mac/editing/execCommand/5481523-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-17 Mark Rowe <mrowe@apple.com>
bdash [Wed, 17 Oct 2007 07:45:27 +0000 (07:45 +0000)]
2007-10-17  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * JavaScriptCore.pri: Add FastMallocPCRE.cpp.
        * pcre/pcre_get. #if out two functions that depend on pcre_get_stringnumber, which
        is currently unavailable for UTF-16.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
mjs [Wed, 17 Oct 2007 07:12:51 +0000 (07:12 +0000)]
    Reviewed by Anders.

        * TODO: Updated with info on how to do the stats properly.

        * hosted/sunspider-driver.html: Reduce timeout from 500 to 200 to
        avoid overly slowing down the benchmark.

        Added some 3D-related test cases.

        * tests/3d-cube.js: Added.
        * tests/3d-morph.js: Added.
        * tests/3d-raytrace.js: Added.
        * tests/LIST:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Wed, 17 Oct 2007 05:38:39 +0000 (05:38 +0000)]
    Reviewed by Geoff.

        - merged PCRE changes between 6.4 and 6.5

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        Removed pcre_config.c, pcre_globals.c, pcre_info.c, pcre_maketables.c,
        pcre_printint.src, pcre_refcount.c, pcre_study.c, pcre_try_flipped.c,
        pcre_ucp_findchar.c, pcre_version.c, and ucptable.c. Added pcre_ucp_searchfuncs.c.

        * pcre/AUTHORS:
        * pcre/LICENCE:
        * pcre/MERGING:
        * pcre/dftables.c:
        * pcre/pcre-config.h:
        * pcre/pcre.h:
        * pcre/pcre.pri:
        * pcre/pcre_compile.c:
        * pcre/pcre_exec.c:
        * pcre/pcre_fullinfo.c:
        * pcre/pcre_get.c:
        * pcre/pcre_internal.h:
        * pcre/pcre_maketables.c:
        * pcre/pcre_ord2utf8.c:
        * pcre/pcre_tables.c:
        * pcre/pcre_ucp_searchfuncs.c: Copied from pcre/pcre_ucp_findchar.c.
        * pcre/pcre_xclass.c:
        * pcre/ucp.h:
        * pcre/ucpinternal.h:
        * pcre/ucptable.c:
        Updated with new versions from the PCRE 6.5 release, merged with changes.

        * pcre/pcre_config.c: Removed.
        * pcre/pcre_globals.c: Removed.
        * pcre/pcre_info.c: Removed.
        * pcre/pcre_printint.src: Removed.
        * pcre/pcre_refcount.c: Removed.
        * pcre/pcre_study.c: Removed.
        * pcre/pcre_try_flipped.c: Removed.
        * pcre/pcre_ucp_findchar.c: Removed.
        * pcre/pcre_version.c: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
darin [Wed, 17 Oct 2007 04:51:50 +0000 (04:51 +0000)]
    Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15536
          need to cache missing glyph so we're not slow on pages that show missing glyphs

        - <rdar://problem/5404359> UI thread stall (>60sec) in MLANG running stress test
          (related to font data caching)

        * platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): Check for a null value
        for fontData rather than for glyph to detect non-cached entries in the glyph data.

        * platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
        * platform/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
        * platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill):
        Set fontData to 0 for missing glyph entries. Also fixed the Windows and GTK versions
        to return the proper value for haveGlyphs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-16 Mark Rowe <mrowe@apple.com>
bdash [Wed, 17 Oct 2007 03:47:35 +0000 (03:47 +0000)]
2007-10-16  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.  Replace use of assert with ASSERT_NOT_REACHED.

        * platform/gtk/FontCacheGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Wed, 17 Oct 2007 02:02:53 +0000 (02:02 +0000)]

        Reviewed by Timothy.

        <rdar://problem/5544354> Wrong delegate method called in WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
kmccullo [Wed, 17 Oct 2007 00:57:12 +0000 (00:57 +0000)]
    Reviewed by Sam.

        - Minor mac improvements based on observations I made while implementing the
        Windows code.

        * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
        then hand it to the Client who will retain it, it should just be the client who
        creates and owns the server.
        (-[DebuggerApplication attach:]):
        * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
        * Drosera/mac/DebuggerClient.mm: Creates the server.
        (-[DebuggerClient initWithServerName:]):
        * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
        can instead forward declare what it needs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago removing fixed tests
aliceli1 [Wed, 17 Oct 2007 00:36:35 +0000 (00:36 +0000)]
    removing fixed tests

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
darin [Tue, 16 Oct 2007 23:52:44 +0000 (23:52 +0000)]
    Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15534
          WebScriptObject.h has some formatting and editorial mistakes

        * bindings/objc/WebScriptObject.h: Fix wording and formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Tue, 16 Oct 2007 23:35:01 +0000 (23:35 +0000)]
    Reviewed by Darin Adler.

        Removed KJS_VERBOSE because it was getting in the way of readability,
        and the messages didn't seem very helpful.

        * kjs/function.cpp:
        * kjs/lookup.h:
        * kjs/object.cpp:
        * kjs/value.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Tue, 16 Oct 2007 23:29:55 +0000 (23:29 +0000)]
    Reviewed by Darin Adler.

        Removed the Parameter class because it was a redundant wrapper around

        * kjs/function.cpp:
        * kjs/nodes.cpp:
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Tue, 16 Oct 2007 23:25:33 +0000 (23:25 +0000)]
    Reviewed by Darin Adler.

        Global replace of assert with ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adele.
aliceli1 [Tue, 16 Oct 2007 22:34:06 +0000 (22:34 +0000)]
    Rubber-stamped by Adele.

        fixing incorrect usage of JS String search method.

        * editing/deleting/delete-by-word-001.html:
        * editing/deleting/delete-by-word-002.html:
        * fast/forms/input-text-option-delete.html:
        * fast/forms/listbox-onchange.html:
        * fast/forms/listbox-selection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the Qt build
darin [Tue, 16 Oct 2007 22:02:41 +0000 (22:02 +0000)]
    - try to fix the Qt build

        * config.h: Don't use DisallowCType.h, since it's incompatible with some C++ headers
        that are used in some Qt-specific source files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff Garen.
darin [Tue, 16 Oct 2007 21:53:20 +0000 (21:53 +0000)]
    Reviewed by Geoff Garen.

        * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
        want to turn failing tests into platform-specific test results. Also did a
        number of tweaks, including fixing a potential bug where expectedDirectoryForTest
        would take the type of results into account only some of the time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename WebKit_debug.dll to WebKit.dll for the Debug configuration
aroben [Tue, 16 Oct 2007 21:43:14 +0000 (21:43 +0000)]
 Rename WebKit_debug.dll to WebKit.dll for the Debug configuration


         Updated testkjs for the rename of WebKit_debug.dll to WebKit.dll for the Debug configuration

         Reviewed by Kevin McCullough.

         * JavaScriptCore.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.
         * JavaScriptCore.vcproj/debug_internal.vsprops: Ditto.
         * JavaScriptCore.vcproj/release.vsprops: Ditto.
         * JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Use
         WebKitDLLConfigSuffix when referring to WebKit.dll, and fixed a typo
         in the name of icuuc36[_debug].dll.


         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration

         Reviewed by Kevin McCullough.

         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
         when referring to WebKit.dll.
         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
         * DumpRenderTree/win/release.vsprops: Ditto.
         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
         never have a _debug suffix on WebKit.dll.
         * WebKitInitializer/WebKitInitializer.cpp:
         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
         * WebKitInitializer/debug_internal.vsprops: Added
         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.


         Rename WebKit_debug.dll to WebKit.dll for the Debug configuration

         This is needed so that we can stop having Safari delay-load WebKit,
         which in turn is needed so that Maciej can land a JavaScript speedup
         which breaks delay-loading.

         Reviewed by Kevin McCullough.

         * WebKit.vcproj/WebKit.vcproj: Use WebKitDLLConfigSuffix for the name
         of our DLL and module definition file.
         * WebKit.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.
         * WebKit.vcproj/debug_internal.vsprops: Ditto.
         * WebKit.vcproj/release.vsprops: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Tue, 16 Oct 2007 21:40:11 +0000 (21:40 +0000)]

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15525
          transpose (control-T) should do the last two characters on a line if at end of line
        - remove unused CommandByName class
        - move transpose command implementation here from Mac OS X WebKit

        * editing/Editor.h:
        * editing/Editor.cpp:
        (WebCore::execTranspose): Added.
        (WebCore::Editor::transpose): Added. This has the transpose implementation from
        WebCoreFrameBridge and WebHTMLView, translated into WebCore-style C++ and with
        a special case for the end of a paragraph.

        * page/Frame.h: Removed unused command() function member.
        * page/FramePrivate.h: Removed unused m_command data member.
        * page/Frame.cpp: Ditto.

        * page/mac/WebCoreFrameBridge.h: Removed rangeOfCharactersAroundCaret method.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

        * WebCore.pro: Removed CommandByName.h/cpp.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * editing/CommandByName.cpp: Removed.
        * editing/CommandByName.h: Removed.


        Reviewed by Adele.

        - moved transpose command implementation into WebCore

        * WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Tue, 16 Oct 2007 21:35:50 +0000 (21:35 +0000)]

        Reviewed by Maciej Stachowiak.

        Re-structured variable and function declaration code.

        Command-line JS iBench shows no regression.

        Here are the changes:

        1. Function declarations are now processed at the same time as var
        declarations -- namely, immediately upon entry to an execution context.
        This does not match Firefox, which waits to process a function
        declaration until the declaration's containing block executes, but it
        does match IE and the ECMA spec. (10.1.3 states that var and function
        declarations should be processed at the same time -- namely, "On
        entering an execution context." 12.2 states that "A Block does not
        define a new execution scope.")

        2. Declaration processing proceeds iteratively now, rather than
        recursively, storing the nodes is finds in stacks. This will later
        facilitate an optimization to hold on to the gathered declaration nodes,
        rather than re-fetching them in every function call.
        [ http://bugs.webkit.org/show_bug.cgi?id=14868 ]

        Modified these tests because they expected the incorrect Mozilla
        behavior described above:

        * tests/mozilla/ecma_3/Function/scope-001.js:
        * tests/mozilla/js1_5/Scope/regress-184107.js:


        Reviewed by Maciej Stachowiak.

        Layout tests for http://bugs.webkit.org/show_bug.cgi?id=15478
        Declare vars and functions iteratively upon entering an execution context

        * fast/js/function-declarations-expected.txt: Added.
        * fast/js/function-declarations.html: Added.
        * fast/js/var-declarations-expected.txt: Added.
        * fast/js/var-declarations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
aliceli1 [Tue, 16 Oct 2007 21:18:52 +0000 (21:18 +0000)]
    Reviewed by Adele.

        Fix <rdar://5134108> "fast/forms/select-accesskey.html and focus-selection-input.html fail on Windows"

        Adding code to choose the right accesskey modifier based on a useragent check for existance of mac platform.
        * fast/forms/focus-selection-input.html:
        * fast/forms/select-accesskey.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the GTK build
darin [Tue, 16 Oct 2007 20:53:21 +0000 (20:53 +0000)]
    - try to fix the GTK build

        * kjs/ustring.cpp: Include ASCIICType.h, not ASCIICtype.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the Windows build
darin [Tue, 16 Oct 2007 20:44:28 +0000 (20:44 +0000)]
    - try to fix the Windows build

        * kjs/date_object.cpp: (KJS::parseDate): A couple instances of isspace were
        in here. Not sure why it wasn't failing elsewhere. Changed to isASCIISpace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the GTK build
darin [Tue, 16 Oct 2007 20:34:01 +0000 (20:34 +0000)]
    - try to fix the GTK build

        * kjs/ustring.cpp: Include ASCIICType.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
darin [Tue, 16 Oct 2007 20:28:58 +0000 (20:28 +0000)]

        Reviewed by Adele.

        * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
        Remove now-unneeded control/alt key hack; the tests have been updated.


        Reviewed by Adele.

        - http://bugs.webkit.org/show_bug.cgi?id=15533
          some tests have hard-coded Mac-specific modifier keys

        - <rdar://problem/5102974> Layout tests fail on Windows because
          they have hard-coded Mac-specific modifier keys
        - <rdar://problem/5075449> fast/forms/listbox-onchange.html
          is failing on Windows due to modifier key differences
        - <rdar://problem/5134134> test 12 in fast/forms/listbox-selection.html
          fails on Windows

        * editing/deleting/delete-by-word-001.html: Use control key instead of alt key to
        delete a word on non-Mac platforms. Also use character 8 instead of 127.
        * editing/deleting/delete-by-word-002.html: Ditto.
        * fast/forms/input-text-option-delete.html: Ditto.
        * fast/forms/listbox-onchange.html: Use control key instead of meta key to toggle
        a single list item on non-Mac platforms.
        * fast/forms/listbox-selection.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Tue, 16 Oct 2007 20:13:24 +0000 (20:13 +0000)]

        Reviewed by Maciej and Geoff (and looked over by Eric).

        - http://bugs.webkit.org/show_bug.cgi?id=15519
          eliminate use of <ctype.h> for processing ASCII

        * wtf/ASCIICType.h: Added.
        * wtf/DisallowCType.h: Added.

        * kjs/config.h: Include DisallowCType.h.

        * kjs/date_object.cpp:
        * kjs/function.cpp:
        * kjs/ustring.cpp:
        Use ASCIICType.h functions instead of ctype.h ones.


        Reviewed by Maciej and Geoff (and looked over by Eric).

        - http://bugs.webkit.org/show_bug.cgi?id=15519
          eliminate use of <ctype.h> for processing ASCII

        * ForwardingHeaders/wtf/ASCIICType.h: Added.
        * ForwardingHeaders/wtf/DisallowCType.h: Added.

        * WebCorePrefix.h: Get rid of inclusion of <ctype.h>.
        * config.h: Include DisallowCType.h.

        * css/CSSParser.cpp:
        * css/CSSPrimitiveValue.cpp:
        * css/CSSStyleDeclaration.cpp:
        * html/HTMLSelectElement.cpp:
        * html/HTMLTokenizer.cpp:
        * loader/FTPDirectoryParser.cpp:
        * loader/TextResourceDecoder.cpp:
        * platform/DeprecatedCString.cpp:
        * platform/DeprecatedString.cpp:
        * platform/DeprecatedString.h:
        * platform/KURL.cpp:
        * platform/StringImpl.cpp:
        * platform/TextEncodingRegistry.cpp:
        * platform/mac/KeyEventMac.mm:
        * platform/win/KeyEventWin.cpp:
        * platform/win/PopupMenuWin.cpp:
        * plugins/win/PluginViewWin.cpp:
        * rendering/RenderText.cpp:
        Use ASCIICType.h functions instead of ctype.h ones.


        Reviewed by Maciej and Geoff (and looked over by Eric).

        - http://bugs.webkit.org/show_bug.cgi?id=15519
          eliminate use of <ctype.h> for processing ASCII

        * ForwardingHeaders/wtf/ASCIICType.h: Added.
        * ForwardingHeaders/wtf/DisallowCType.h: Added.

        * WebKitPrefix.h: Include DisallowCType.h.

        * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper.
        (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes,
        instead of using ispunct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix build bustage caused by merge with changes to CSSStyleSelector.cpp
hyatt [Tue, 16 Oct 2007 20:05:50 +0000 (20:05 +0000)]
Fix build bustage caused by merge with changes to CSSStyleSelector.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Tue, 16 Oct 2007 20:04:42 +0000 (20:04 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15296
          REGRESSION (r19716-r19719): width not specified for <marquee> tag is causing the alignment issue.

        Test: fast/block/float/marquee-shrink-to-avoid-floats.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::shrinkToAvoidFloats): Changed to return 'true' for <marquee>s with auto width.


        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15296
          REGRESSION (r19716-r19719): width not specified for <marquee> tag is causing the alignment issue.

        * fast/block/float/marquee-shrink-to-avoid-floats.html: Added.
        * platform/mac/fast/block: Added.
        * platform/mac/fast/block/float: Added.
        * platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.checksum: Added.
        * platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.png: Added.
        * platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin [Tue, 16 Oct 2007 19:51:33 +0000 (19:51 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5517118> REGRESSION: 9A570 - Safari renders
        Amazon seller page way too small

        The font size at Amazon was way too small because the calls to
        getComputedStyle and getPropertyValue did not cause the div to
        attach because there was a pending stylesheet. The fix is to call
        updateLayoutIgnorePendingStylesheets() instead of just

        * css/CSSComputedStyleDeclaration.cpp:


        Reviewed by Darin.

        Fix for <rdar://problem/5517118> REGRESSION: 9A570 - Safari renders
        Amazon seller page way too small

        * fast/css/pendingStylesheetFontSize.html: Added.
        * platform/mac/fast/css/pendingStylesheetFontSize-expected.checksum: Added.
        * platform/mac/fast/css/pendingStylesheetFontSize-expected.png: Added.
        * platform/mac/fast/css/pendingStylesheetFontSize-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Updated leaks list because our internal bot upgraded it's version of leopar...
kmccullo [Tue, 16 Oct 2007 19:48:28 +0000 (19:48 +0000)]
    - Updated leaks list because our internal bot upgraded it's version of leopard and
        one of the leaks was fixed between that revision and the bot's previous version of

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim.
kmccullo [Tue, 16 Oct 2007 19:45:42 +0000 (19:45 +0000)]
    Reviewed by Tim.

        - I encapsulated out the server connecton functionality because it is a specific part
        of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
        into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
        Windows.  So the majority of this patch is moving preexisting functionality.

        - Also I removed the prefix header and changed to use config.h because it is more
        standard on how we use config.h in windows and it didn't make much sense to keep
        the prefix header and the config.h

        * Drosera/DebuggerDocument.cpp:
        * Drosera/DebuggerDocument.h:
        * Drosera/config.h:
        * Drosera/mac/DebuggerApplication.mm:
        (-[DebuggerApplication attach:]):
        * Drosera/mac/DebuggerClient.h:
        * Drosera/mac/DebuggerClient.mm:
        (-[DebuggerClient initWithServerConnection:]):
        (-[DebuggerClient dealloc]):
        (-[DebuggerClient windowDidLoad]):
        (-[DebuggerClient windowWillClose:]):
        (-[DebuggerClient webView:didFinishLoadForFrame:]):
        (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
        * Drosera/mac/DebuggerDocumentPlatform.mm:
        * Drosera/mac/Drosera.pch: Removed.
        * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
        * Drosera/mac/ServerConnection.h: Added.
        * Drosera/mac/ServerConnection.mm: Added.
        (-[ServerConnection initWithServerName:]):
        (-[ServerConnection dealloc]):
        (-[ServerConnection setGlobalContext:]):
        (-[ServerConnection pause]):
        (-[ServerConnection resume]):
        (-[ServerConnection stepInto]):
        (-[ServerConnection switchToServerNamed:]):
        (-[ServerConnection applicationTerminating:]):
        (-[ServerConnection serverConnectionDidDie:]):
        (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
        (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
        (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
        (-[ServerConnection currentFrame]):
        (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
        (-[ServerConnection knownServers]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Tue, 16 Oct 2007 19:36:56 +0000 (19:36 +0000)]
2007-10-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Ollie.

        <rdar://5530789>: REGRESSION(303-310A19): Crash opening .wma files with
        MediaPlayer for the first time

        Failure to setup the stream in PluginView::didReceiveResponse will lead,
        in a full-page plugin, to the main document load being cancelled. This
        is the case with at least two versions of Windows Media Player, which
        cancels the stream and brings up its own "Welcome to Windows Media
        Player" dialog.

        As part of the main document load cancellation, m_pluginView is set to
        null, and the crash came from dereferencing this pointer. This patch
        adds a null check.

        * WebFrame.cpp:
        (WebFrame::finishedLoading): Fix some typos
        (WebFrame::committedLoad): Added a null check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Get transform-origin(x/y) mapped into the front end RenderStyle. Adds a...
hyatt [Tue, 16 Oct 2007 19:06:45 +0000 (19:06 +0000)]
    Get transform-origin(x/y) mapped into the front end RenderStyle.  Adds a new StyleTransformData struct that
        holds transform-origin (and that will also eventually hold the parsed transform operations as well).

        Reviewed by Beth

        * css/CSSStyleSelector.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Tue, 16 Oct 2007 18:30:55 +0000 (18:30 +0000)]

        Reviewed by Alice.

        Fix for <rdar://problem/5538793> REGRESSION: Failing layout test: fast/forms/select-change-listbox-to-popup.html (due to landing feature branch)

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):  When switching between types of select elements, call setRecalcListItems
          since recalcListItems updates the default selection in different ways for the different controls.


        Reviewed by Alice.

        Updating with correct results for:
        <rdar://problem/5538793> REGRESSION: Failing layout test: fast/forms/select-change-listbox-to-popup.html (due to landing feature branch)

        * platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago rubber-stamped by Darin.
aliceli1 [Tue, 16 Oct 2007 18:22:47 +0000 (18:22 +0000)]
    rubber-stamped by Darin.

        flipping my previous fix around so that mac is special-cased instead of win.

        * dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Clean up transform parsing. Fix a crash, ditch the extra parse context class...
hyatt [Tue, 16 Oct 2007 18:21:09 +0000 (18:21 +0000)]
    Clean up transform parsing.  Fix a crash, ditch the extra parse context class, and use RefPtr/PassRefPtr more
        to simplify the code.

        Reviewed by aroben

        * css/CSSParser.cpp:
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
aliceli1 [Tue, 16 Oct 2007 17:57:00 +0000 (17:57 +0000)]
    Reviewed by Adele.

        fixed <rdar://5085596> Accesskeys don't work

        * dom/Document.cpp:
        accesskey modifier is platform-depedent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben
sullivan [Tue, 16 Oct 2007 16:55:13 +0000 (16:55 +0000)]
    Reviewed by Adam Roben

        Cleaned up localizable strings

        * English.lproj/Localizable.strings:
        * StringsNotToBeLocalized.txt:
        * WebKit.xcodeproj/project.pbxproj:
        StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved conflict markers.
ddkilzer [Tue, 16 Oct 2007 11:19:54 +0000 (11:19 +0000)]
Removed conflict markers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Tue, 16 Oct 2007 07:04:40 +0000 (07:04 +0000)]
    Reviewed by Maciej.

        editing/pasteboard/paste-into-anchor-text.html accesses an external resource

        Removed the external resource reference and made the test dump as text.

        * editing/pasteboard/paste-into-anchor-text-expected.txt: Copied from platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt.
        * editing/pasteboard/paste-into-anchor-text.html:
        * platform/mac/editing/pasteboard/paste-into-anchor-text-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/paste-into-anchor-text-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Tue, 16 Oct 2007 05:53:03 +0000 (05:53 +0000)]

        Reviewed by Eric.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15002
          Script to automatically search nightly builds for regressions (bisect-builds)

        * Scripts/bisect-builds: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-15 Mark Rowe <mrowe@apple.com>
bdash [Tue, 16 Oct 2007 05:17:06 +0000 (05:17 +0000)]
2007-10-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by John.

        <rdar://problem/5494040> Reproducible assertion failure in WebCore::IconDatabase::iconForPageURL

        A race condition between icon database import and Safari asking for an icon for the empty URL
        was resulting in a PageURLRecord being created for a URL that can never be retained.  By enforcing
        that PageURLRecord's cannot be created for the empty URL we can prevent the assertion from failing.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::getOrCreatePageURLRecord): Bail out early if the URL is empty.
        (WebCore::IconDatabase::performURLImport): Don't create the PageURLRecord if the URL is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-15 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Tue, 16 Oct 2007 04:51:40 +0000 (04:51 +0000)]
2007-10-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Ollie.

        Use OwnPtr for m_deliveryData, and fix a bug where we were memmove()ing
        over m_deliveryData instead of its data buffer

        * plugins/win/PluginStreamWin.cpp:
        (WebCore::PluginStreamWin::~PluginStreamWin): Don't delete
        (WebCore::PluginStreamWin::deliverData): Fix memmove() call
        (WebCore::PluginStreamWin::didReceiveData): Assign using OwnPtr::set()
        * plugins/win/PluginStreamWin.h: Use OwnPtr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
sfalken [Tue, 16 Oct 2007 03:39:05 +0000 (03:39 +0000)]
    Reviewed by Oliver.

        Add missing null check.

        * platform/network/cf/AuthenticationCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26646 268f45cc-cd09-0410-ab3c-d52691b4dbfc