WebKit-https.git
10 years ago[chromium] Clean up some animations/ expectations.
pkasting@chromium.org [Thu, 17 Nov 2011 00:20:10 +0000 (00:20 +0000)]
[chromium] Clean up some animations/ expectations.
https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselines some tests that clearly just needed that, tries to condense
a number of other flaky tests onto one bug, updates the set of bots that
are actually failing for some expectations.

Unreviewed, gardening.

* platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png: Removed.
* platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png: Removed.
* platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png: Removed.
* platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Added.
* platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Added.
* platform/chromium-linux/animations/opacity-transform-animation-expected.png: Added.
* platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png: Added.
* platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png: Added.
* platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Added.
* platform/chromium-win/animations/missing-values-first-keyframe-expected.png:
* platform/chromium-win/animations/missing-values-last-keyframe-expected.png:
* platform/chromium-win/animations/opacity-transform-animation-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Build fix for !ENABLE(JIT) after r100363.
paroga@webkit.org [Thu, 17 Nov 2011 00:04:09 +0000 (00:04 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r100363.

* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJS wrappers of DOM objects should have no-op constructors
weinig@apple.com [Wed, 16 Nov 2011 23:46:54 +0000 (23:46 +0000)]
JS wrappers of DOM objects should have no-op constructors
https://bugs.webkit.org/show_bug.cgi?id=72556

Reviewed by Geoffrey Garen.

Stop using a RefPtr to hold DOM objects contained by JavaScript
wrappers and instead use a raw pointer. We were already releasing
the underlying object before the destructor ran (via the finalizer)
so the default behavior of destroying the RefPtr is always unnecessary
busy work.

* bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
(WebCore::JSNode::visitChildren):
Call releaseImpl() instead of clearImpl().

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch
clearImpl() to releaseImpl(), which explicitly derefs the pointer and
clear it.

(GenerateImplementation):
Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer.
Change default finalize to call releaseImpl() instead of clearImpl().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRolled back in r100375 and r100385 with 32-bit build fixed.
ggaren@apple.com [Wed, 16 Nov 2011 23:37:15 +0000 (23:37 +0000)]
Rolled back in r100375 and r100385 with 32-bit build fixed.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
* runtime/ArgList.h:
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSGlobalObject.h:
(JSC::constructArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG global variable CSE mishandles the cross-global-object inlining corner case
fpizlo@apple.com [Wed, 16 Nov 2011 23:21:39 +0000 (23:21 +0000)]
DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::globalObjectFor):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::globalObjectFor):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

* fast/js/cross-global-object-inline-global-var-expected.txt: Added.
* fast/js/cross-global-object-inline-global-var.html: Added.
* fast/js/script-tests/cross-global-object-inline-global-var.js: Added.
(foo):
(done):
(doit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r100509; change was committed twice (first time as r100491).
dpranke@chromium.org [Wed, 16 Nov 2011 23:02:01 +0000 (23:02 +0000)]
Revert r100509; change was committed twice (first time as r100491).
Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update text baselines for mq-transform-0[23] tests
jamesr@google.com [Wed, 16 Nov 2011 22:57:29 +0000 (22:57 +0000)]
[chromium] Update text baselines for mq-transform-0[23] tests

* platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt:
* platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[NRWT] speculative fix for multiple subprocess test on cygwin
tony@chromium.org [Wed, 16 Nov 2011 22:53:24 +0000 (22:53 +0000)]
[NRWT] speculative fix for multiple subprocess test on cygwin
https://bugs.webkit.org/show_bug.cgi?id=72518

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
    tries to emulate posix fd behavior.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable 8 Bit Strings in JavaScriptCore
msaboff@apple.com [Wed, 16 Nov 2011 22:46:31 +0000 (22:46 +0000)]
Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71337

Source/JavaScriptCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type.  This change rippled into WebCore code as well.

Reviewed by Geoffrey Garen.

* JavaScriptCore.exp:
* parser/Lexer.cpp:
(JSC::::append8): Changed to use 8 bit buffers.
(JSC::::parseIdentifier): Changed to use 8 bit buffers.
(JSC::::parseString): Changed to use 8 bit buffers.
* runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::translate): 8 bit version keeps data 8 bit
(JSC::Identifier::toUInt32FromCharacters): Templated helper.
(JSC::Identifier::toUInt32): Added 8 bit optimized path.
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage): Changed to be 8 bit strings
* runtime/UString.h:
(JSC::UString::characters): Now calls StringImpl::characters()
* wtf/Forward.h:
* wtf/text/StringBuffer.h: Made StringBuffer a template base on character type.
(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::characters):
(WTF::StringBuffer::release):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase): Fixed null terminated case.
(WTF::StringImpl::removeCharacters): Added 8 bit path.
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::simplifyWhiteSpace):
(WTF::equal): Removed bug from code copied from null terminated version.
(WTF::StringImpl::adopt): Added 8 bit path.
(WTF::StringImpl::createWithTerminatingNullCharacter): Fixed 8 bi flag propagation.
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl): Added new 8 bit constructor.
(WTF::StringImpl::characters8): Removed ASSERT_NOT_REACHED().
(WTF::getCharacters<LChar>): Added templated accessor for 8 bit strings.
(WTF::getCharacters<UChar>): Added templated accessor for 16 bit strings.
* wtf/text/WTFString.h:
(WTF::String::adopt): Changed to use StringBuffer template.

Source/WebCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type.  This change riplled into WebCore code as well.

Reviewed by Geoffrey Garen.

No new tests - Changes in response to refactoring StringBuffer to
be a template on character type.

* css/CSSParser.cpp:
(WebCore::quoteCSSString):
* css/CSSPrimitiveValue.cpp:
(WebCore::formatNumber):
* dom/Document.cpp:
(WebCore::canonicalizedTitle):
* platform/Length.cpp:
(WebCore::newCoordsArray):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode):
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):
* rendering/RenderText.cpp:
(WebCore::makeCapitalized):
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::writeToStringBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRun a dummy test in the gpu configurations if there's nothing to do.
dpranke@chromium.org [Wed, 16 Nov 2011 22:44:14 +0000 (22:44 +0000)]
Run a dummy test in the gpu configurations if there's nothing to do.
https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Improvements for page scale delta during commit
commit-queue@webkit.org [Wed, 16 Nov 2011 22:37:55 +0000 (22:37 +0000)]
[chromium] Improvements for page scale delta during commit
https://bugs.webkit.org/show_bug.cgi?id=72471

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

Page scale now follows the same commit flow as scroll position:
the delta is folded into m_pageScale at BFAC time, and a "sent" value
is preserved for temporary use until the commit finishes.

I also merged setPageScaleFactor and setPageScaleFactorLimits into one
function on the impl side.  The reason is that setPageFactor must
be applied after the limits are updated, but on the other hand setting
the limits first may cause an unnecessary clamp of the scale delta.
Merging the methods avoids this bind.

No new tests. (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyScrollAndScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Attempt to rebaseline a test.
pkasting@chromium.org [Wed, 16 Nov 2011 22:34:41 +0000 (22:34 +0000)]
[chromium] Attempt to rebaseline a test.
https://bugs.webkit.org/show_bug.cgi?id=54322

Unreviewed, gardening.

* platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPlatform specific results for svg/foreignObject/{clip,filter,mask}.html
commit-queue@webkit.org [Wed, 16 Nov 2011 22:24:49 +0000 (22:24 +0000)]
Platform specific results for svg/foreignObject/{clip,filter,mask}.html
https://bugs.webkit.org/show_bug.cgi?id=72532

Patch by Florin Malita <fmalita@google.com> on 2011-11-16
Reviewed by Steve Block.

* platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocontributors_by_fuzzy_match is super slow
rniwa@webkit.org [Wed, 16 Nov 2011 22:24:00 +0000 (22:24 +0000)]
contributors_by_fuzzy_match is super slow
https://bugs.webkit.org/show_bug.cgi?id=72540

Reviewed by Eric Seidel.

Make contributors_by_name do case insensitive search using a dictionary.

Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
because that's the most common case.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/committers_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Reduce nested key depth threshold, re-enable flaky test
commit-queue@webkit.org [Wed, 16 Nov 2011 22:21:50 +0000 (22:21 +0000)]
IndexedDB: Reduce nested key depth threshold, re-enable flaky test
https://bugs.webkit.org/show_bug.cgi?id=72529

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-16
Reviewed by Adam Barth.

Source/WebCore:

Drop maximum array key depth from 20k to 2k.

* bindings/v8/IDBBindingUtilities.cpp:

LayoutTests:

Re-enable flaky test, and drop the maximum depth tested to avoid
crashes/timeouts on test boxes when prepping the test.

* platform/chromium/test_expectations.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-array.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Fix incorrect multipart handling in r100311.
japhet@chromium.org [Wed, 16 Nov 2011 22:10:53 +0000 (22:10 +0000)]
Source/WebCore: Fix incorrect multipart handling in r100311.
SubresourceLoader::didReceiveData() is getting called
twice, which has unintended side effects.
https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

http/tests/multipart/invalid-image-data.html should stop
asserting after this.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):
* loader/SubresourceLoader.h:

LayoutTests: Remove CRASH expectation for
http/tests/multipart/invalid-image-data.html.
https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClear SVG filter client when its node is detached
jschuh@chromium.org [Wed, 16 Nov 2011 22:07:23 +0000 (22:07 +0000)]
Clear SVG filter client when its node is detached
https://bugs.webkit.org/show_bug.cgi?id=71741

Reviewed by Eric Seidel.

Source/WebCore:

Test: svg/filters/reparent-animated-filter-target.html

* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientDestroyed):

LayoutTests:

* svg/filters/reparent-animated-filter-target-expected.txt: Added.
* svg/filters/reparent-animated-filter-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark some CoreAnimation plugin model tests as WONTFIX on Win/
pkasting@chromium.org [Wed, 16 Nov 2011 22:02:37 +0000 (22:02 +0000)]
[chromium] Mark some CoreAnimation plugin model tests as WONTFIX on Win/
Linux, and as expected to fail for now on Mac; remove current expected
Mac baselines.
https://bugs.webkit.org/show_bug.cgi?id=47925

Unreviewed, gardening.

* platform/chromium-mac/compositing/plugins/composited-plugin-expected.txt: Removed.
* platform/chromium-mac/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
* platform/chromium-win/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
* platform/chromium-win/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
* platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPage/layer flashes after GPU-accelerated CSS transition
commit-queue@webkit.org [Wed, 16 Nov 2011 21:54:54 +0000 (21:54 +0000)]
Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <jbates@google.com> on 2011-11-16
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheck-webkit-style should recognize functions even if they have OVERRIDE after them.
levin@chromium.org [Wed, 16 Nov 2011 21:51:15 +0000 (21:51 +0000)]
check-webkit-style should recognize functions even if they have OVERRIDE after them.
https://bugs.webkit.org/show_bug.cgi?id=72515

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update chromium expectations for fast/media/mq-transform-0[23].html to...
jamesr@google.com [Wed, 16 Nov 2011 21:22:15 +0000 (21:22 +0000)]
[chromium] Update chromium expectations for fast/media/mq-transform-0[23].html to reflect that chromium DRT has
2d and 3d transforms enabled

* platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
* platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.txt: Added.
* platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-linux-x86/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-linux-x86/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
* platform/chromium-linux-x86/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-linux-x86/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-linux/fast/media/mq-transform-02-expected.png:
* platform/chromium-linux/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
* platform/chromium-linux/fast/media/mq-transform-03-expected.png:
* platform/chromium-linux/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.png:
* platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
* platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.png:
* platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-win-vista/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-win-vista/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
* platform/chromium-win-vista/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-win-vista/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-win-xp/fast/media/mq-transform-02-expected.png: Added.
* platform/chromium-win-xp/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
* platform/chromium-win-xp/fast/media/mq-transform-03-expected.png: Added.
* platform/chromium-win-xp/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
* platform/chromium-win/fast/media/mq-transform-02-expected.png:
* platform/chromium-win/fast/media/mq-transform-02-expected.txt:
* platform/chromium-win/fast/media/mq-transform-03-expected.png:
* platform/chromium-win/fast/media/mq-transform-03-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix up chromium API for creating events, initializing message events
commit-queue@webkit.org [Wed, 16 Nov 2011 21:14:18 +0000 (21:14 +0000)]
Fix up chromium API for creating events, initializing message events
https://bugs.webkit.org/show_bug.cgi?id=71478

- Fix a mistake when checking the exception code during event creation.
- Change WebFrame parameter to pointer so that NULL may be passed.

This is required for the following chromium CL: http://codereview.chromium.org/8437093/

Tested in Chromium by:
 ui_test --gtest_filter=*PPAPITest.PostMessage*

Patch by Dave Michael <dmichael@chromium.org> on 2011-11-16
Reviewed by Darin Fisher.

* public/WebDOMMessageEvent.h:
* src/WebDOMMessageEvent.cpp:
(WebKit::WebDOMMessageEvent::initMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add null pointer check in setDeviceScaleFactor
commit-queue@webkit.org [Wed, 16 Nov 2011 21:11:24 +0000 (21:11 +0000)]
[chromium] Add null pointer check in setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=72464

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

No new tests. (Tiny fix.)

* page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100438.
commit-queue@webkit.org [Wed, 16 Nov 2011 21:07:20 +0000 (21:07 +0000)]
Unreviewed, rolling out r100438.
http://trac.webkit.org/changeset/100438
https://bugs.webkit.org/show_bug.cgi?id=72536

Broke unit tests (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

* platform/PlatformScreen.h:
* platform/chromium/PlatformScreenChromium.cpp:
* platform/chromium/PlatformSupport.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

* public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
* src/PlatformSupport.cpp:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[NRWT] refactor drivers to require pixel_tests param
tony@chromium.org [Wed, 16 Nov 2011 21:03:48 +0000 (21:03 +0000)]
[NRWT] refactor drivers to require pixel_tests param
https://bugs.webkit.org/show_bug.cgi?id=72517

Reviewed by Ojan Vafai.

No tests, just a refactoring.

* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize ExecutableBase::clearCodeVirtual
mhahnenberg@apple.com [Wed, 16 Nov 2011 20:50:31 +0000 (20:50 +0000)]
De-virtualize ExecutableBase::clearCodeVirtual
https://bugs.webkit.org/show_bug.cgi?id=72337

Reviewed by Darin Adler.

Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
and had the finalize functions call the corresponding clearCode methods.

* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::NativeExecutable::finalize):
(JSC::EvalExecutable::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::finalize):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::finalize):
(JSC::FunctionExecutable::clearCode):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation):
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion failure in LayerFlushScheduler::resume() when running some layout tests...
aestes@apple.com [Wed, 16 Nov 2011 20:43:11 +0000 (20:43 +0000)]
Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=72535

Reviewed by Anders Carlsson.

LayerFlushScheduler attempted to use a counter strategy for calls to
suspend() and resume(), which allowed us to assert that these calls
were balanced. Unfortunately it is hard to guarantee this in WebKit2,
where we sometimes try to call suspend() before we've entered
compositing mode (hence before we have a LayerTreeHost and a
LayerFlushScheduler). When we later call resume(), this call ends up
being unbalanced and asserts.

For now, remove the assertions and allow unbalanced calls to suspend()
and resume().

* platform/graphics/ca/LayerFlushScheduler.cpp:
(WebCore::LayerFlushScheduler::suspend):
(WebCore::LayerFlushScheduler::resume):
* platform/graphics/ca/LayerFlushScheduler.h:
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::LayerFlushScheduler):
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
(WebCore::LayerFlushScheduler::schedule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRun a dummy test in the gpu configurations if there's nothing to do.
dpranke@chromium.org [Wed, 16 Nov 2011 20:42:38 +0000 (20:42 +0000)]
Run a dummy test in the gpu configurations if there's nothing to do.
https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100473.
robert@webkit.org [Wed, 16 Nov 2011 20:27:58 +0000 (20:27 +0000)]
Unreviewed, rolling out r100473.
http://trac.webkit.org/changeset/100473
https://bugs.webkit.org/show_bug.cgi?id=72534

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
(WebCore::RenderObject::addChild):
* rendering/RenderObject.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTable.h:
* rendering/RenderTableCaption.cpp: Removed.
* rendering/RenderTableCaption.h: Removed.

LayoutTests:

* css2.1/20110323/border-collapse-offset-002.htm: Removed.
* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
* platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
* platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
* platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/mac/fast/repaint/table-section-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100479.
robert@webkit.org [Wed, 16 Nov 2011 20:25:19 +0000 (20:25 +0000)]
Unreviewed, rolling out r100479.
http://trac.webkit.org/changeset/100479
https://bugs.webkit.org/show_bug.cgi?id=72533

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderingAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner needs to support accessibility-related DRT APIs
cfleizach@apple.com [Wed, 16 Nov 2011 20:17:22 +0000 (20:17 +0000)]
WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

Tools:

Reviewed by Beth Dakin.

Port the AX code in DRT to WKTestRunner by using IDL.

* DumpRenderTree/AccessibilityUIElement.cpp:
(horizontalScrollbarCallback):
(verticalScrollbarCallback):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
(WTR::AccessibilityController::create):
(WTR::AccessibilityController::AccessibilityController):
(WTR::AccessibilityController::~AccessibilityController):
(WTR::AccessibilityController::makeWindowObject):
(WTR::AccessibilityController::wrapperClass):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::elementAtPoint):
* WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
(WTR::AccessibilityController::logFocusEvents):
(WTR::AccessibilityController::logValueChangeEvents):
(WTR::AccessibilityController::logScrollingStartEvents):
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::notificationReceived):
(WTR::AccessibilityController::resetToConsistentState):
* WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
(WTR::AccessibilityTextMarker::create):
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::platformTextMarker):
(WTR::AccessibilityTextMarker::wrapperClass):
* WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
(WTR::AccessibilityTextMarker::isEqual):
* WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
(WTR::AccessibilityTextMarkerRange::create):
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::wrapperClass):
* WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
(WTR::AccessibilityTextMarkerRange::isEqual):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
(WTR::AccessibilityUIElement::create):
(WTR::AccessibilityUIElement::wrapperClass):
(WTR::AccessibilityUIElement::isValid):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
(WTR::AccessibilityUIElement::platformUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::accessibilityController):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
(WTR::LayoutTestController::platformName):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
(WTR::AccessibilityTextMarker::isEqual):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
(WTR::AccessibilityTextMarkerRange::isEqual):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler initWithPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
(-[AccessibilityNotificationHandler setCallback:]):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::descriptionOfValue):
(WTR::attributesOfElement):
(WTR::concatenateAttributeAndValue):
(WTR::convertNSArrayToVector):
(WTR::descriptionOfElements):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
* WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
(WTR::LayoutTestController::platformName):
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
(WTR::LayoutTestController::platformName):
* WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
(WTR::LayoutTestController::platformName):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Cleanup tests and skip lists so that accessibility tests can run
in WK2. This mostly involved handling returned elements that might be nil,
something that did not happen in DRT.

Reviewed by Beth Dakin.

* accessibility/aria-labelledby-overrides-label-expected.txt:
* accessibility/aria-labelledby-overrides-label.html:
* accessibility/non-data-table-cell-title-ui-element.html:
* accessibility/th-as-title-ui.html:
    Make sure a nil titleUIElement is accounted for in these tests.
* platform/gtk-wk2/Skipped:
* platform/mac/accessibility/aria-expanded-notifications-expected.txt:
* platform/mac/accessibility/aria-expanded-notifications.html:
* platform/mac/accessibility/aria-invalid-expected.txt:
* platform/mac/accessibility/aria-invalid.html:
* platform/mac/accessibility/aria-liveregions-addedelement-expected.txt:
* platform/mac/accessibility/aria-liveregions-addedelement.html:
* platform/mac/accessibility/aria-liveregions-changedalt-expected.txt:
* platform/mac/accessibility/aria-liveregions-changedalt.html:
* platform/mac/accessibility/aria-liveregions-changedtext-expected.txt:
* platform/mac/accessibility/aria-liveregions-changedtext.html:
* platform/mac/accessibility/aria-liveregions-removedelement-expected.txt:
* platform/mac/accessibility/aria-liveregions-removedelement.html:
     All the preceeding layout tests use alert() to output the results of notifications. This
     is causing re-ordering issues on WK2, so I've moved them all to output that notification
     data to a separate element from "console".
* platform/mac/accessibility/html-section-elements-expected.txt:
* platform/mac/accessibility/html-section-elements.html:
     Remove nil element access that is unnecessary.
* platform/mac/accessibility/html-slider-indicator-expected.txt:
* platform/mac/accessibility/html-slider-indicator.html:
* platform/mac/accessibility/search-predicate.html:
     Add an alt tag to <img> so that it always shows up in the AX tree.
* platform/mac/accessibility/selection-value-changes-for-aria-textbox.html:
* platform/mac/accessibility/textbox-role-reports-notifications-expected.txt:
     Remove the notification listener properly (was causing flakiness).
* platform/mac/accessibility/textbox-role-reports-notifications.html:
* platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt:
* platform/mac/accessibility/update-children-when-aria-role-changes.html:
     Account for when element's returned are nil.
* platform/win-wk2/Skipped:
     Skip all accessibility tests on win.
* platform/wk2/Skipped:
     Skip all accessibility tests on gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner needs to support accessibility-related DRT APIs
cfleizach@apple.com [Wed, 16 Nov 2011 20:14:58 +0000 (20:14 +0000)]
WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131

../WebCore:

Minor changes needed to support AX testing in WKTestRunner.

Reviewed by Beth Dakin.

* WebCore.exp.in:
     Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(accessibilitySearchKeyForString):
    Remove an unncessary assert that was causing issues with the WK2 test run.

../WebKit2:

Allow the injected bundle to retrieve the focused and root accessibility
objects.

Reviewed by Beth Dakin.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method...
sergio@webkit.org [Wed, 16 Nov 2011 20:12:42 +0000 (20:12 +0000)]
[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
https://bugs.webkit.org/show_bug.cgi?id=69219

Reviewed by Martin Robinson.

Source/WebCore:

Do not stop appending data to the request body if any of the blob
items to upload is not accesible.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::addEncodedBlobToSoupMessageBody):

LayoutTests:

Unskipped a test that now pass.

* platform/gtk/Skipped: unskipped http/tests/local/blob/send-hybrid-blob.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agofast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chrom...
steveblock@google.com [Wed, 16 Nov 2011 19:59:12 +0000 (19:59 +0000)]
fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg
https://bugs.webkit.org/show_bug.cgi?id=72530

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=72400
bdakin@apple.com [Wed, 16 Nov 2011 19:53:12 +0000 (19:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=72400
Scrollbar uiStateTransitionProgress requires tracking the mouse all the time
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This patch makes it so we track the mouse all the time when we have legacy
scrollbars (rather than only tracking the mouse when the window is key). When
we're in that mode, we want to do as little work as possible when handling the
mouseMoved event so that this extra tracking has little to no performance impact.
Also, we don't want to change basic behaviors by having normal web content hover
effects start happening when a window is in the background. So this patch also
introduces a way to handle a mouseMoved event that will only affect scrollbars.

EventHandler::mouseMoved() and EventHandler::handleMouseEvent() both now take a
boolean parameter that indicates if we are only updating scrollbars. If that is
the case, then we make our HitTestRequest ReadOnly, and we return early once
updateLastScrollbarUnderMouse() is called.
* WebCore.exp.in:
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):

In addition to calling Scrollbar::mouseExited() when appropriate, this function
now calls a new function, Scrollbar::mouseEntered() when appropriate.
(WebCore::EventHandler::updateLastScrollbarUnderMouse):
* page/EventHandler.h:

Scrollbar::mouseMoved() used to be responsible for calling
ScrollAnimator::mouseEnteredScrollbar(), but now Scrollbar::mouseEntered() takes
care of that instead, much like how Scrollbar::mouseExited() takes care of calling
the animator's exit function.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseEntered):
* platform/Scrollbar.h:

Source/WebKit2:

Set up our initial tracking area based on the currently recommended scrollbar
style. Track the mouse all the time if the style is legacy.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

Now that we might be getting mouseMoved events all the time even when the window
is not key, make sure we opt into the new 'onlyUpdateScrollbars' mode for
EventHandler::mouseMoved() when the window is not focused.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSValue: isInheritedValue() doesn't need a dedicated bit.
commit-queue@webkit.org [Wed, 16 Nov 2011 19:42:16 +0000 (19:42 +0000)]
CSSValue: isInheritedValue() doesn't need a dedicated bit.
<http://webkit.org/b/72514>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Remove CSSValue::m_isInherited and have isInheritedValue() check the
class type instead. There's no compelling reason for CSSInheritedValue
to have a dedicated bit, since nobody subclasses it anyway.

* css/CSSValue.h:
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::CSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build on Windows and Mac after r100473
robert@webkit.org [Wed, 16 Nov 2011 19:39:03 +0000 (19:39 +0000)]
Fix build on Windows and Mac after r100473

Unreviewed, fix build.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderingAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnskip these tests now that they should pass again.
abarth@webkit.org [Wed, 16 Nov 2011 19:34:37 +0000 (19:34 +0000)]
Unskip these tests now that they should pass again.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate test results after tightening up SecurityOrigin logic in
abarth@webkit.org [Wed, 16 Nov 2011 19:29:26 +0000 (19:29 +0000)]
Update test results after tightening up SecurityOrigin logic in
http://trac.webkit.org/changeset/100182.  These new results are (minor)
progressions on these tests.

* http/tests/security/cross-frame-access-enumeration-expected.txt:
* http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove extra GraphicsContextStateSaver restore() call.
commit-queue@webkit.org [Wed, 16 Nov 2011 19:16:45 +0000 (19:16 +0000)]
Remove extra GraphicsContextStateSaver restore() call.
https://bugs.webkit.org/show_bug.cgi?id=72497

Patch by Philip Rogers <pdr@google.com> on 2011-11-16
Reviewed by Andreas Kling.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add minimum/maximumPageScaleFactor API and clamp fixes
commit-queue@webkit.org [Wed, 16 Nov 2011 19:13:25 +0000 (19:13 +0000)]
[chromium] Add minimum/maximumPageScaleFactor API and clamp fixes
https://bugs.webkit.org/show_bug.cgi?id=72463

Patch by Alexandre Elias <aelias@google.com> on 2011-11-16
Reviewed by Darin Fisher.

We need a way to read back the computed min/max page scale factor in
order to support the software path, and for some application logic
such as zooming in/out when tapping form fields.

I also added a few clamp calls that are needed in some corner cases.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::minimumPageScaleFactor):
(WebKit::WebViewImpl::maximumPageScaleFactor):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSS 2.1 failure: border-collapse-offset-002.htm fails
robert@webkit.org [Wed, 16 Nov 2011 19:11:56 +0000 (19:11 +0000)]
CSS 2.1 failure: border-collapse-offset-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=71705

Source/WebCore:

Table captions are implemented as children of the table but have a special
requirement to expand to the full width of the table rather than just the 'available'
width, i.e. the full width minus padding and borders.

To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
to return the full width of the containing block (i.e. the table) rather than the available width.

Reviewed by Antti Koivisto.

* CMakeLists.txt: Add RenderTableCaption.[cpp|h]
* GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
* Target.pri: Add RenderTableCaption.[cpp|h]
* WebCore.gypi: Add RenderTableCaption.[cpp|h]
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
(WebCore::RenderObject::addChild): ditto
* rendering/RenderObject.h:
(WebCore::RenderObject::isTableCaption):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTable.h:
* rendering/RenderTableCaption.cpp: Added.
(WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
(WebCore::RenderTableCaption::~RenderTableCaption):
(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.
* rendering/RenderTableCaption.h: Added.
(WebCore::RenderTableCaption::isTableCaption):
(WebCore::toRenderTableCaption):

LayoutTests:

Table captions now use the width of the table rather than the width of the table minus
the borders. This allows captions to center accurately but unfortunately a lot of mozilla
table tests need to be rebaselined as many of them use captions for explaining the purpose
of individual test files!

Add border-collapse-offset-002.htm which now renders correctly.

Affected tables/mozilla tests are rebaselined in a follow-up patch.

Reviewed by Antti Koivisto.

* css2.1/20110323/border-collapse-offset-002.htm: Added.
* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
* platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
* platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/mac/fast/repaint/table-section-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Add ewk_settings_memory_cache_clear().
commit-queue@webkit.org [Wed, 16 Nov 2011 19:03:49 +0000 (19:03 +0000)]
[EFL] Add ewk_settings_memory_cache_clear().
https://bugs.webkit.org/show_bug.cgi?id=72141

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

This is the same as Qt's QWebSettings::clearMemoryCaches() and is
responsible for clearing, among others, the page, memory and font
caches.

* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
* ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
commit-queue@webkit.org [Wed, 16 Nov 2011 19:03:00 +0000 (19:03 +0000)]
ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-11-16
Reviewed by Adam Barth.

* http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Added.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] display:none has no effect on <option> element.
commit-queue@webkit.org [Wed, 16 Nov 2011 18:56:08 +0000 (18:56 +0000)]
[Gtk] display:none has no effect on <option> element.
https://bugs.webkit.org/show_bug.cgi?id=72370

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Martin Robinson.

* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::appendItem):
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::createGtkActionForMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoString new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
commit-queue@webkit.org [Wed, 16 Nov 2011 18:44:20 +0000 (18:44 +0000)]
String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
https://bugs.webkit.org/show_bug.cgi?id=71572

Patch by Yusuke Suzuki <utatane.tea@gmail.com> on 2011-11-16
Reviewed by Gavin Barraclough and Darin Adler.

Source/JavaScriptCore:

* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):

LayoutTests:

* fast/regex/script-tests/toString.js:
(testLineTerminator):
* fast/regex/toString-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][WEBKIT2] Link error running gtkdoc-scangobj
commit-queue@webkit.org [Wed, 16 Nov 2011 18:32:29 +0000 (18:32 +0000)]
[GTK][WEBKIT2] Link error running gtkdoc-scangobj
https://bugs.webkit.org/show_bug.cgi?id=72365

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-16
Reviewed by Xan Lopez.

* webkit2gtk.pc.in: Add a libjavascriptcore requirement to the WebKit2 pkgconfig
file so that the compiler links to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix platformDefersLoading to handle non-http requests, and
commit-queue@webkit.org [Wed, 16 Nov 2011 18:20:49 +0000 (18:20 +0000)]
[GTK] Fix platformDefersLoading to handle non-http requests, and
to not use broken-ish libsoup APIs.
https://bugs.webkit.org/show_bug.cgi?id=72227

Patch by Dan Winship <danw@gnome.org> on 2011-11-16
Reviewed by Martin Robinson.

* platform/network/ResourceHandleInternal.h:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::hasBeenSent):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback): rather than deferring by using
soup_session_pause_message(), let the read complete, but just don't
process the result until we're no longer deferred.
(WebCore::startNonHTTPRequest): Don't start the request if
it's deferred.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRecent svg/foreignObject tests failing on Mac & Win
commit-queue@webkit.org [Wed, 16 Nov 2011 18:16:04 +0000 (18:16 +0000)]
Recent svg/foreignObject tests failing on Mac & Win
https://bugs.webkit.org/show_bug.cgi?id=72386

Patch by Florin Malita <fmalita@google.com> on 2011-11-16
Reviewed by Simon Fraser.

Drop unnecessary text elements from the svg/FO tests to avoid platform font size variance.

* platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Removed.
* platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Removed.
* platform/chromium-win/svg/foreignObject/clip-expected.txt: Removed.
* platform/chromium-win/svg/foreignObject/filter-expected.txt: Removed.
* platform/chromium-win/svg/foreignObject/mask-expected.txt: Removed.
* platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Removed.
* platform/chromium/svg/foreignObject/clip-expected.txt: Removed.
* platform/chromium/svg/foreignObject/filter-expected.txt: Removed.
* platform/chromium/svg/foreignObject/mask-expected.txt: Removed.
* platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
* platform/qt/svg/foreignObject/background-render-phase-expected.png: Removed.
* platform/qt/svg/foreignObject/background-render-phase-expected.txt: Removed.
* platform/qt/svg/foreignObject/clip-expected.png: Removed.
* platform/qt/svg/foreignObject/clip-expected.txt: Removed.
* platform/qt/svg/foreignObject/filter-expected.png: Removed.
* platform/qt/svg/foreignObject/filter-expected.txt: Removed.
* platform/qt/svg/foreignObject/mask-expected.png: Removed.
* platform/qt/svg/foreignObject/mask-expected.txt: Removed.
* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Removed.
* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
* svg/foreignObject/background-render-phase-expected.txt:
* svg/foreignObject/background-render-phase.html:
* svg/foreignObject/clip-expected.png:
* svg/foreignObject/clip-expected.txt:
* svg/foreignObject/clip.html:
* svg/foreignObject/filter-expected.png:
* svg/foreignObject/filter-expected.txt:
* svg/foreignObject/filter.html:
* svg/foreignObject/mask-expected.png:
* svg/foreignObject/mask-expected.txt:
* svg/foreignObject/mask.html:
* svg/foreignObject/multiple-foreign-objects-expected.txt:
* svg/foreignObject/multiple-foreign-objects.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2][X11] Don't leak the colormap we created for the plugin
kbalazs@webkit.org [Wed, 16 Nov 2011 18:05:28 +0000 (18:05 +0000)]
[WK2][X11] Don't leak the colormap we created for the plugin
https://bugs.webkit.org/show_bug.cgi?id=72144

Reviewed by Xan Lopez.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Clean up the web database-related functions in ewk_settings.
commit-queue@webkit.org [Wed, 16 Nov 2011 17:33:29 +0000 (17:33 +0000)]
[EFL] Clean up the web database-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72139

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
more standard naming scheme for the related static variables.

* ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):
* ewk/ewk_settings.h: Document the default web database path on disk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpecialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
darin@apple.com [Wed, 16 Nov 2011 17:29:52 +0000 (17:29 +0000)]
Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
https://bugs.webkit.org/show_bug.cgi?id=72475

Reviewed by Adam Roben.

* wtf/HashTraits.h: Specialize HashTraits for OwnPtr.
Do overloads so we can pass a nullptr and also be sure to get the
raw pointer type from the OwnPtr template so we handle both forms
of OwnPtr: OwnPtr<T> and OwnPtr<T*>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix use of config.tests
vestbo@webkit.org [Wed, 16 Nov 2011 17:27:43 +0000 (17:27 +0000)]
[Qt] Fix use of config.tests

We were checking @buildArgs to determine if the optional argument was
passed or not, but this is not the right way to do that in Perl. The
right way is to not use a prototype for the function, and to pass
the list as a reference (to avoid list expansion). That way we can
check the number of arguments, and choose the right code path based
on that.

We were also missing a default-value of 0 for any feature that's not
set in features.prf.

Reviewed by Kenneth Rohde Christiansen.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(qtFeatureDefaults):
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Prospective fix for broken plugin tests
vestbo@webkit.org [Wed, 16 Nov 2011 17:20:25 +0000 (17:20 +0000)]
[Qt] Prospective fix for broken plugin tests

Don't hide symbols for the NPAPI test plugin

Rubber-stamped by Andreas Kling.

* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100448.
jesus@webkit.org [Wed, 16 Nov 2011 16:57:11 +0000 (16:57 +0000)]
Unreviewed, rolling out r100448.
http://trac.webkit.org/changeset/100448
https://bugs.webkit.org/show_bug.cgi?id=72512

It caused a regression breaking LayoutTests/http/tests/loading
/text-content-type-with-binary-extension.html (Requested by
jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Application cache status should be updated after swapCache().
steveblock@google.com [Wed, 16 Nov 2011 16:55:19 +0000 (16:55 +0000)]
Web Inspector: Application cache status should be updated after swapCache().
https://bugs.webkit.org/show_bug.cgi?id=72123

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2011-11-16
Reviewed by Pavel Feldman.

* http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
* http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
* http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
* http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
* http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
* http/tests/inspector/appcache/appcache-swap.html: Added.
* http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.
(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):
* http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
* http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
* http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
* http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
* platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
* platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
* platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove filenames/line numbers off to the right edge in Leaks Viewer
aroben@apple.com [Wed, 16 Nov 2011 16:50:18 +0000 (16:50 +0000)]
Move filenames/line numbers off to the right edge in Leaks Viewer

Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
because filenames/line numbers are right next to function names

Reviewed by Andreas Kling.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
(LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
function name. Use the filename as the profile node's URL (we don't have enough info to
compute a real URL currently) and the line number as the profile node's line number so the
Inspector code will put them on the right side of the callstack graph.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
passed here, just filenames.

(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyResourceAsNode):
Copied and slightly modified from inspector.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake Leaks Viewer load builds from the new Lion Leaks bot
aroben@apple.com [Wed, 16 Nov 2011 16:50:07 +0000 (16:50 +0000)]
Make Leaks Viewer load builds from the new Lion Leaks bot

Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds

Reviewed by Andreas Kling.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
SnowLeopard one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
commit-queue@webkit.org [Wed, 16 Nov 2011 16:37:29 +0000 (16:37 +0000)]
[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
https://bugs.webkit.org/show_bug.cgi?id=72392

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-16
Reviewed by Simon Hausmann.

Add QWeakPointer to SocketNotifierResourceGuard::m_socketNotifier to track
deallocation of referenced object.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::SocketNotifierResourceGuard::SocketNotifierResourceGuard):
(CoreIPC::SocketNotifierResourceGuard::~SocketNotifierResourceGuard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Application cache status should be updated after swapCache().
vsevik@chromium.org [Wed, 16 Nov 2011 16:09:45 +0000 (16:09 +0000)]
Web Inspector: Application cache status should be updated after swapCache().
https://bugs.webkit.org/show_bug.cgi?id=72123

Reviewed by Pavel Feldman.

Source/WebCore:

Application cache view resources and status are now updated after swapCache() call.
Refresh button removed from application cache view.
Application cache inspector tests are moved to their own folder.

Tests: http/tests/inspector/appcache/appcache-iframe-manifests.html
       http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
       http/tests/inspector/appcache/appcache-swap.html

* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
(WebInspector.ApplicationCacheItemsView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheItemsView.prototype._markDirty):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._deleteCallback):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::setNewestCache):
(WebCore::ApplicationCacheGroup::makeObsolete):
(WebCore::ApplicationCacheGroup::setUpdateStatus):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::swapCache):

Source/WebKit/chromium:

* src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::swapCache):

LayoutTests:

* http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
* http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
* http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
* http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
* http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
* http/tests/inspector/appcache/appcache-swap.html: Added.
* http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.
(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):
* http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
* http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
* http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
* http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
* platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
* platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
* platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoaddTrack() must throw an exception if 'kind' is unknown
eric.carlson@apple.com [Wed, 16 Nov 2011 16:05:45 +0000 (16:05 +0000)]
addTrack() must throw an exception if 'kind' is unknown
https://bugs.webkit.org/show_bug.cgi?id=71915

Reviewed by Philippe Normand.

Source/WebCore:

Tests: media/track/track-addtrack-kind.html
       media/track/track-kind.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackKindChanged): New. Will be implemented for 62885.
(WebCore::HTMLMediaElement::addTrack): Throw if  'kind' is not a known value.
(WebCore::HTMLMediaElement::addTextTrack): Call textTracks(), it will allocate the track
    list object if necessary.
(WebCore::HTMLMediaElement::textTracks): Never return NULL, a TextTrackList with no tracks
    is allowed.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::addTrack): Add variants to deal with optional parameters plus
    a mandatory ExceptionCode parameter.
* html/HTMLMediaElement.idl: addTrack can generate an exception.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::attributeChanged): kind, label, and srclang attribute changes should
    percolate down the the TextTrack.
(WebCore::HTMLTrackElement::kind): Return the TextTrack kind because it is not necessarily the
    same as the attribute value.
(WebCore::HTMLTrackElement::ensureTrack): Only pass legal 'kind' keywords to create a TextTrack.
(WebCore::HTMLTrackElement::textTrackKindChanged): Notify parent element, if any.
* html/HTMLTrackElement.h:

* html/TextTrack.cpp:
(WebCore::TextTrack::subtitlesKeyword): New, return legal kind attribute value.
(WebCore::TextTrack::captionsKeyword): Ditto.
(WebCore::TextTrack::descriptionsKeyword): Ditto.
(WebCore::TextTrack::chaptersKeyword): Ditto.
(WebCore::TextTrack::metadataKeyword): Ditto.
(WebCore::TextTrack::TextTrack): Call setKind to make sure m_kind is always set to legal value.
(WebCore::TextTrack::isValidKindKeyword): New, validate 'kind' value.
(WebCore::TextTrack::setKind): Only allow legal values.
* html/TextTrack.h:
(WebCore::TextTrack::kind):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):
(WebCore::TextTrack::readyState):
(WebCore::TextTrack::mode):

LayoutTests:

* media/track/track-addtrack-kind-expected.txt: Added.
* media/track/track-addtrack-kind.html: Added.
* media/track/track-kind-expected.txt: Added.
* media/track/track-kind.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Clean up the offline apps-related functions in ewk_settings.
commit-queue@webkit.org [Wed, 16 Nov 2011 15:58:42 +0000 (15:58 +0000)]
[EFL] Clean up the offline apps-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72132

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

`ewk_settings_cache' and `ewk_view_setting_cache' are too common
prefixes for code that is related only to the HTML5 app cache
features.

Use `ewk_settings_application_cache' and
`ewk_view_setting_application_cache' instead.

Source/WebKit/efl:

While here, improve the documentation and use a more common naming
scheme for the static variable which holds the cache path.

* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.cpp:
(ewk_settings_application_cache_path_set):
(ewk_settings_application_cache_path_get):
* ewk/ewk_settings.h:
* ewk/ewk_view.cpp:
(ewk_view_setting_application_cache_get):
(ewk_view_setting_application_cache_set):
* ewk/ewk_view.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test fix after http://trac.webkit.org/changeset/100273.
apavlov@chromium.org [Wed, 16 Nov 2011 15:57:02 +0000 (15:57 +0000)]
Unreviewed, test fix after trac.webkit.org/changeset/100273.

"font" property is no longer mapped to DOMCSSValue, so use "font-family" mapped to DOMCSSValueList instead.

* platform/mac/plugins/jsobjc-dom-wrappers-expected.txt:
* platform/mac/plugins/jsobjc-dom-wrappers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing
kbalazs@webkit.org [Wed, 16 Nov 2011 15:52:43 +0000 (15:52 +0000)]
[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing
https://bugs.webkit.org/show_bug.cgi?id=72504

Unreviewed gardening. Skip crashing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSValue: Clean up initial value construction.
commit-queue@webkit.org [Wed, 16 Nov 2011 15:49:12 +0000 (15:49 +0000)]
CSSValue: Clean up initial value construction.
<http://webkit.org/b/72502>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Instead of determining whether a given CSSInitialValue is 'implicit' or not by
querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
add a protected CSSValue member and set it from the CSSInitialValue constructor.

Also get rid of the CSSValue::m_isInitial bit since we can now replace the
checks by classType() == InitialClass.

No new tests, this is a cleanup.

* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::CSSInitialValue):

    Poke 'implicit' constructor argument into CSSValue::m_isImplicit.

* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

    Remove ImplicitInitialClass cases.

* css/CSSValue.h:
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::CSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
commit-queue@webkit.org [Wed, 16 Nov 2011 15:12:30 +0000 (15:12 +0000)]
[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
https://bugs.webkit.org/show_bug.cgi?id=72169

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-16
Reviewed by Simon Hausmann.

Currently FrameLoaderClientQt::canShowMIMEType is called after
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
PolicyUse and canShowMIMEType returns false, then we have a bug.
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
return true, following the implemenation of WebKit2.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary if check from RenderListBox::paintItemForeground.
commit-queue@webkit.org [Wed, 16 Nov 2011 15:04:58 +0000 (15:04 +0000)]
Remove unnecessary if check from RenderListBox::paintItemForeground.
https://bugs.webkit.org/show_bug.cgi?id=72488

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Andreas Kling.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test inspector/styles/svg-style.xhtml is flaky
steveblock@google.com [Wed, 16 Nov 2011 15:00:10 +0000 (15:00 +0000)]
Layout Test inspector/styles/svg-style.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2][Mac] MiniBrowser cannot create socketpair.
zeno.albisser@nokia.com [Wed, 16 Nov 2011 14:56:11 +0000 (14:56 +0000)]
[Qt][WK2][Mac] MiniBrowser cannot create socketpair.
https://bugs.webkit.org/show_bug.cgi?id=72389

Use SOCK_DGRAM on mac instead of SOCK_SEQPACKET.

Reviewed by Tor Arne Vestbø.

* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip new failing tests.
rgabor@webkit.org [Wed, 16 Nov 2011 14:54:01 +0000 (14:54 +0000)]
[Qt] Skip new failing tests.

Unreviewed gardening.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
rgabor@webkit.org [Wed, 16 Nov 2011 14:42:14 +0000 (14:42 +0000)]
[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
https://bugs.webkit.org/show_bug.cgi?id=72493

[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311
https://bugs.webkit.org/show_bug.cgi?id=72491

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100281 and r100437.
ossy@webkit.org [Wed, 16 Nov 2011 14:28:05 +0000 (14:28 +0000)]
Unreviewed, rolling out r100281 and r100437.
http://trac.webkit.org/changeset/100281
http://trac.webkit.org/changeset/100437
https://bugs.webkit.org/show_bug.cgi?id=72496

It made all plugin tests fail with paralel NRWT (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility...
hausmann@webkit.org [Wed, 16 Nov 2011 14:20:33 +0000 (14:20 +0000)]
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

* Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

* qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
magic here where we handle all TEMPLATE = lib .pro files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix path to module file in root project file
vestbo@webkit.org [Wed, 16 Nov 2011 14:17:24 +0000 (14:17 +0000)]
Fix path to module file in root project file

Reviewed by Simon Hausmann.

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test inspector/extensions/extensions-events.html is flaky
caseq@chromium.org [Wed, 16 Nov 2011 14:08:28 +0000 (14:08 +0000)]
Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Reviewed by Yury Semikhatsky.

* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Pass screen refresh rate into compositor.
commit-queue@webkit.org [Wed, 16 Nov 2011 14:04:57 +0000 (14:04 +0000)]
[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-16
Reviewed by Tony Gentilcore.

Source/WebCore:

* platform/PlatformScreen.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRefreshRate):
* platform/chromium/PlatformSupport.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

* public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenRefreshRate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening after r100281.
ossy@webkit.org [Wed, 16 Nov 2011 14:03:42 +0000 (14:03 +0000)]
[Qt] Unreviewed gardening after r100281.

* platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html
again, because it makes all plugin related tests fail intermittently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
steveblock@google.com [Wed, 16 Nov 2011 13:51:17 +0000 (13:51 +0000)]
LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=72494

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test inspector/extensions/extensions-events.html is flaky
steveblock@google.com [Wed, 16 Nov 2011 13:13:10 +0000 (13:13 +0000)]
Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] new test css3/flexbox/line-wrapping.html failing
rgabor@webkit.org [Wed, 16 Nov 2011 13:09:25 +0000 (13:09 +0000)]
[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks...
caseq@chromium.org [Wed, 16 Nov 2011 12:56:21 +0000 (12:56 +0000)]
Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
https://bugs.webkit.org/show_bug.cgi?id=72388

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/extensions/extensions-panel.html
       inspector/extensions/extensions-sidebar.html

- fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
- drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
- fix an exception when a page is replaced with object/expression.

 inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionNotifierView):
(WebInspector.ExtensionNotifierView.prototype.wasShown):
(WebInspector.ExtensionNotifierView.prototype.willHide):
(WebInspector.ExtensionSidebarPane.prototype.setObject):
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
(WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
(WebInspector.ExtensionServer.prototype._dispatchCallback):
* inspector/front-end/View.js:
(WebInspector.View.prototype.detach):

LayoutTests:

- split LayoutTests/inspector/extensions.html into extensions-panel.html & extensions-sidebar.html.

* inspector/extensions/extensions-panel-expected.txt: Added.
* inspector/extensions/extensions-panel.html: Added.
* inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
* inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExplicitly include unistd.h in TestNetscapePlugIn
commit-queue@webkit.org [Wed, 16 Nov 2011 12:52:06 +0000 (12:52 +0000)]
Explicitly include unistd.h in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=72385

This is needed for the sleep() call in the indicateTestFailure method,
which seems to be implicitly available for other platforms. This is not
the case on Android.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update Qt specific expected results.
rgabor@webkit.org [Wed, 16 Nov 2011 12:48:30 +0000 (12:48 +0000)]
[Qt] Update Qt specific expected results.

Unreviewed gardening.

* platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
* platform/qt/fast/loader/file-protocol-fragment-expected.txt:
* platform/qt/inspector: Added.
* platform/qt/inspector/console: Added.
* platform/qt/inspector/console/console-format-expected.png: Added.
* platform/qt/inspector/console/console-format-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCompositing LayoutTests failing on Chromium Mac
steveblock@google.com [Wed, 16 Nov 2011 12:33:04 +0000 (12:33 +0000)]
Compositing LayoutTests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=72487

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
steveblock@google.com [Wed, 16 Nov 2011 11:57:09 +0000 (11:57 +0000)]
LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
https://bugs.webkit.org/show_bug.cgi?id=72485

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
commit-queue@webkit.org [Wed, 16 Nov 2011 11:49:52 +0000 (11:49 +0000)]
[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=72384

Update to Android NDK r7, which was released last Friday. This adds
support for RTTI and the -mimplicit-it gcc flag, which are required to
respectively build ICU and Skia.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(buildChromiumMakefile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100266.
hausmann@webkit.org [Wed, 16 Nov 2011 10:56:52 +0000 (10:56 +0000)]
Unreviewed, rolling out r100266.
http://trac.webkit.org/changeset/100266

Broke WTR.

.:

* Source/api.pri:

Source/JavaScriptCore:

* Target.pri:

Source/WebCore:

* Target.pri:

Tools:

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][ARMv5] Websocket tests are fail, skip until fix
rgabor@webkit.org [Wed, 16 Nov 2011 10:51:34 +0000 (10:51 +0000)]
[Qt][ARMv5] Websocket tests are fail, skip until fix

Unreviewed, gardening.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
commit-queue@webkit.org [Wed, 16 Nov 2011 10:35:31 +0000 (10:35 +0000)]
[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=70720

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-11-16
Reviewed by Philippe Normand.

Source/WebCore:

Added missing overriding of Event::interfaceName()

* mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.
* mediastream/MediaStreamEvent.h:
* mediastream/MediaStreamEvent.idl: Changed module name to "events".

LayoutTests:

* platform/gtk/Skipped: Unskipped fast/events/event-creation.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Do not hide accessibility root object from AT's
mario@webkit.org [Wed, 16 Nov 2011 09:46:36 +0000 (09:46 +0000)]
[GTK] Do not hide accessibility root object from AT's
https://bugs.webkit.org/show_bug.cgi?id=72390

Reviewed by Martin Robinson.

* tests/testatk.c:
(getWebAreaObject): New helper function, to bypass the new root
object in the accessibility hierarchy, since it's not usually
needed for the unit tests.
(testWebkitAtkCaretOffsets): Use getWebAreaObject().
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
(testWebkitAtkComboBox): Ditto.
(testWebkitAtkEmbeddedObjects): Ditto.
(testWebkitAtkGetTextAtOffsetForms): Ditto.
(testWebkitAtkGetTextAtOffset): Ditto.
(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
(testWebkitAtkGetTextInTable): Ditto.
(testWebkitAtkGetHeadersInTable): Ditto.
(testWebkitAtkTextAttributes): Ditto.
(testWebkitAtkTextSelections): Ditto.
(testWebkitAtkGetExtents): Ditto.
(testWebkitAtkLayoutAndDataTables): Ditto.
(testWebkitAtkLinksWithInlineImages): Ditto.
(testWebkitAtkHypertextAndHyperlinks): Ditto.
(testWebkitAtkListsOfItems): Ditto.
(testWebkitAtkTextChangedNotifications): Ditto.
(testWebkitAtkParentForRootObject): New test, to make sure that
both top-down and bottom-up navigation among GTK and WebKit worlds
matches accordingly.
(main): Added new test.

* webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible): Remove the hack introduced
because of bug 51932, to bypass the root object here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheck-webkit-style broken by r99773: "Could not determine the port"
eric@webkit.org [Wed, 16 Nov 2011 09:06:49 +0000 (09:06 +0000)]
check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

I will continue engaging hacks, until windows improves.

* Scripts/webkitpy/common/host.py:
 - Host uses self.executive instead of self._executive like Port does.
 - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update chromium expectations for compositing tests
jamesr@google.com [Wed, 16 Nov 2011 08:48:53 +0000 (08:48 +0000)]
[chromium] Update chromium expectations for compositing tests

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheck-webkit-style broken by r99773: "Could not determine the port"
eric@webkit.org [Wed, 16 Nov 2011 08:41:36 +0000 (08:41 +0000)]
check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

Engage windows hacks harder.

This is a speculative fix for ChromiumWin.  We're now
creating an SCM object much earlier, so we need to
engage our "awesome" windows hacks earlier.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update chromium win and linux compositing baselines
jamesr@google.com [Wed, 16 Nov 2011 08:16:42 +0000 (08:16 +0000)]
[chromium] Update chromium win and linux compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png.
* platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png.
* platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
* platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
* platform/chromium-mac/compositing/self-painting-layers-expected.png: Removed.
* platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-win/compositing/self-painting-layers-expected.png:
* platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png.
* platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png.
* platform/chromium/compositing/self-painting-layers-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
mario@webkit.org [Wed, 16 Nov 2011 08:16:33 +0000 (08:16 +0000)]
[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
https://bugs.webkit.org/show_bug.cgi?id=72394

Reviewed by Martin Robinson.

No new functionality, no new tests needed.

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_class_init): Initialize GQuarks.
(getGailTextUtilForAtk): Use gailTextUtilQuark.
(getPangoLayoutForAtk): Remove unused call to
g_object_set_data_full, since that data is no used anywhere.
(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a "pass type" and "peek type" concept to HashTraits
darin@apple.com [Wed, 16 Nov 2011 08:06:09 +0000 (08:06 +0000)]
Add a "pass type" and "peek type" concept to HashTraits
https://bugs.webkit.org/show_bug.cgi?id=72473

Reviewed by Filip Pizlo.

* wtf/HashTraits.h: Added the pass type and peek type.
For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix some hash traits that don't derive from the base hash traits
darin@apple.com [Wed, 16 Nov 2011 08:05:40 +0000 (08:05 +0000)]
Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470

Reviewed by Filip Pizlo.

Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.

* runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from
HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.

* runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive
from HashTraits<SymbolTableEntry> and removed redundant members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSSShaders] Implement the style cached resources and computed style for the shader...
achicu@adobe.com [Wed, 16 Nov 2011 07:51:03 +0000 (07:51 +0000)]
[CSSShaders] Implement the style cached resources and computed style for the shader urls
https://bugs.webkit.org/show_bug.cgi?id=72378

Reviewed by Dean Jackson.

Source/WebCore:

Test: css3/filters/custom-filter-property-computed-style.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
(WebCore::CSSStyleSelector::styleShader):
(WebCore::CSSStyleSelector::cachedOrPendingStyleShaderFromValue):
(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):
* css/CSSStyleSelector.h:
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::~WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::cachedOrPendingShader):
* css/WebKitCSSShaderValue.h:
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::CachedShader):
(WebCore::CachedShader::~CachedShader):
* loader/cache/CachedShader.h:
* platform/graphics/filters/CustomFilterOperation.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::filter):
* rendering/style/StyleCachedShader.cpp:
(WebCore::StyleCachedShader::StyleCachedShader):
(WebCore::StyleCachedShader::cssValue):
* rendering/style/StyleCachedShader.h:
(WebCore::StyleCachedShader::create):
* rendering/style/StylePendingShader.h:
(WebCore::StylePendingShader::create):
(WebCore::StylePendingShader::cssValue):
(WebCore::StylePendingShader::cssShaderValue):
(WebCore::StylePendingShader::StylePendingShader):
* rendering/style/StyleShader.h:
(WebCore::StyleShader::~StyleShader):
(WebCore::StyleShader::isCachedShader):
(WebCore::StyleShader::isPendingShader):
(WebCore::StyleShader::StyleShader):

LayoutTests:

* css3/filters/custom-filter-property-computed-style-expected.txt: Added.
* css3/filters/custom-filter-property-computed-style.html: Added.
* css3/filters/script-tests/custom-filter-property-computed-style.js: Added.
(jsWrapperClass):
(expression):
(description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update chromium mac compositing baselines
jamesr@google.com [Wed, 16 Nov 2011 07:48:19 +0000 (07:48 +0000)]
[chromium] Update chromium mac compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac/animations/3d/matrix-transform-type-animation-expected.png: Removed.
* platform/chromium-cg-mac/animations/3d/state-at-end-event-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png.
* platform/chromium-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Removed.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
* platform/chromium/animations/3d/replace-filling-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/replace-filling-transform-expected.png.
* platform/chromium/animations/3d/state-at-end-event-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt.
* platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 16 Nov 2011 07:47:46 +0000 (07:47 +0000)]
[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72380

Reviewed by Martin Robinson.

It adds an initial implementation of WebKitNetworkRequest
class that only contains a URI for now.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.
(webkitNetworkRequestFinalize):
(webkitNetworkRequestGetProperty):
(webkitNetworkRequestSetProperty):
(webkit_network_request_class_init):
(webkit_network_request_init):
(webkit_network_request_new):
(webkit_network_request_get_uri):
* UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
the given WebKitNetworkRequest.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testLoadRequest):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadRequest):
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100414 268f45cc-cd09-0410-ab3c-d52691b4dbfc