commit-queue@webkit.org [Fri, 27 Jul 2012 18:25:53 +0000 (18:25 +0000)]
Add more Russian replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92462
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-07-27
Reviewed by Tony Chang.
Add more Russian sites as suggested by loislo.
* Replay/Russian/lenta.ru.replay: Added.
* Replay/Russian/www.ixbt.com.replay: Added.
* Replay/Russian/www.kp.ru.replay: Added.
* Replay/Russian/www.liveinternet.ru.replay: Added.
* Replay/Russian/www.pravda.ru.replay: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 18:25:02 +0000 (18:25 +0000)]
[Qt] platform/qt/svg/custom tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91090.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Zoltan Herczeg.
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Removed.
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Removed.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Removed.
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Removed.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Removed.
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-features-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Removed.
* platform/qt-5.0/svg/custom/text-linking-expected.png: Removed.
* platform/qt-5.0/svg/custom/text-linking-expected.txt: Removed.
* platform/qt/svg/custom/SVGMatrix-interface-expected.png:
* platform/qt/svg/custom/SVGMatrix-interface-expected.txt:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.png:
* platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.txt:
* platform/qt/svg/custom/alignment-baseline-modes-expected.png:
* platform/qt/svg/custom/alignment-baseline-modes-expected.txt:
* platform/qt/svg/custom/altglyph-expected.png:
* platform/qt/svg/custom/altglyph-expected.txt:
* platform/qt/svg/custom/baseval-animval-equality-expected.png:
* platform/qt/svg/custom/baseval-animval-equality-expected.txt:
* platform/qt/svg/custom/broken-internal-references-expected.txt:
* platform/qt/svg/custom/bug45331-expected.png: Added.
* platform/qt/svg/custom/bug45331-expected.txt: Added.
* platform/qt/svg/custom/bug86119-expected.txt:
* platform/qt/svg/custom/circle-move-invalidation-expected.png:
* platform/qt/svg/custom/circle-move-invalidation-expected.txt:
* platform/qt/svg/custom/clip-path-referencing-use-expected.png:
* platform/qt/svg/custom/clip-path-referencing-use-expected.txt:
* platform/qt/svg/custom/clip-path-referencing-use2-expected.png:
* platform/qt/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png:
* platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
* platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
* platform/qt/svg/custom/container-opacity-clip-viewBox-expected.txt:
* platform/qt/svg/custom/coords-relative-units-transforms-expected.png:
* platform/qt/svg/custom/coords-relative-units-transforms-expected.txt:
* platform/qt/svg/custom/createImageElement2-expected.png: Added.
* platform/qt/svg/custom/createImageElement2-expected.txt:
* platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
* platform/qt/svg/custom/dominant-baseline-hanging-expected.txt:
* platform/qt/svg/custom/dominant-baseline-modes-expected.png:
* platform/qt/svg/custom/dominant-baseline-modes-expected.txt:
* platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
* platform/qt/svg/custom/embedding-external-svgs-expected.png:
* platform/qt/svg/custom/embedding-external-svgs-expected.txt:
* platform/qt/svg/custom/empty-clip-path-expected.png:
* platform/qt/svg/custom/empty-clip-path-expected.txt:
* platform/qt/svg/custom/empty-mask-expected.png: Added.
* platform/qt/svg/custom/empty-mask-expected.txt:
* platform/qt/svg/custom/external-paintserver-reference-expected.png:
* platform/qt/svg/custom/external-paintserver-reference-expected.txt:
* platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
* platform/qt/svg/custom/fill-SVGPaint-interface-expected.txt:
* platform/qt/svg/custom/fill-fallback-expected.png:
* platform/qt/svg/custom/fill-fallback-expected.txt:
* platform/qt/svg/custom/focus-ring-expected.png:
* platform/qt/svg/custom/focus-ring-expected.txt:
* platform/qt/svg/custom/font-face-cascade-order-expected.png:
* platform/qt/svg/custom/font-face-cascade-order-expected.txt:
* platform/qt/svg/custom/font-face-simple-expected.png:
* platform/qt/svg/custom/font-face-simple-expected.txt:
* platform/qt/svg/custom/foreign-object-skew-expected.png:
* platform/qt/svg/custom/foreign-object-skew-expected.txt:
* platform/qt/svg/custom/foreignObject-crash-on-hover-expected.png:
* platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
* platform/qt/svg/custom/getPresentationAttribute-expected.png:
* platform/qt/svg/custom/getPresentationAttribute-expected.txt:
* platform/qt/svg/custom/getTransformToElement-expected.png:
* platform/qt/svg/custom/getTransformToElement-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
* platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
* platform/qt/svg/custom/getsvgdocument-expected.png:
* platform/qt/svg/custom/getsvgdocument-expected.txt:
* platform/qt/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt:
* platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png: Copied from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
* platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
* platform/qt/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
* platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt:
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png:
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt:
* platform/qt/svg/custom/gradient-cycle-detection-expected.png:
* platform/qt/svg/custom/gradient-cycle-detection-expected.txt:
* platform/qt/svg/custom/gradient-deep-referencing-expected.png:
* platform/qt/svg/custom/gradient-deep-referencing-expected.txt:
* platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
* platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.txt:
* platform/qt/svg/custom/hit-test-path-expected.png:
* platform/qt/svg/custom/hit-test-path-expected.txt:
* platform/qt/svg/custom/hit-test-path-stroke-expected.png:
* platform/qt/svg/custom/hit-test-path-stroke-expected.txt:
* platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.png:
* platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
* platform/qt/svg/custom/image-parent-translation-expected.png:
* platform/qt/svg/custom/image-parent-translation-expected.txt:
* platform/qt/svg/custom/image-rescale-clip-expected.png:
* platform/qt/svg/custom/image-rescale-clip-expected.txt:
* platform/qt/svg/custom/image-rescale-scroll-expected.png:
* platform/qt/svg/custom/image-rescale-scroll-expected.txt:
* platform/qt/svg/custom/image-small-width-height-expected.png:
* platform/qt/svg/custom/image-small-width-height-expected.txt:
* platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/qt/svg/custom/invalid-css-expected.png:
* platform/qt/svg/custom/invalid-css-expected.txt:
* platform/qt/svg/custom/invalid-fill-expected.png:
* platform/qt/svg/custom/invalid-fill-expected.txt:
* platform/qt/svg/custom/invalid-fill-hex-expected.png:
* platform/qt/svg/custom/invalid-fill-hex-expected.txt:
* platform/qt/svg/custom/invalid-lengthlist-expected.png:
* platform/qt/svg/custom/invalid-lengthlist-expected.txt:
* platform/qt/svg/custom/invalid-stroke-hex-expected.png: Added.
* platform/qt/svg/custom/invalid-stroke-hex-expected.txt:
* platform/qt/svg/custom/invalid-uri-stroke-expected.png: Added.
* platform/qt/svg/custom/invalid-uri-stroke-expected.txt:
* platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
* platform/qt/svg/custom/invisible-text-after-scrolling-expected.txt:
* platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/qt/svg/custom/js-late-clipPath-creation-expected.png:
* platform/qt/svg/custom/js-late-clipPath-creation-expected.txt:
* platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/qt/svg/custom/js-late-gradient-creation-expected.png:
* platform/qt/svg/custom/js-late-gradient-creation-expected.txt:
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png:
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
* platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
* platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
* platform/qt/svg/custom/linking-base-external-reference-expected.png:
* platform/qt/svg/custom/linking-base-external-reference-expected.txt:
* platform/qt/svg/custom/linking-uri-01-b-expected.png:
* platform/qt/svg/custom/linking-uri-01-b-expected.txt:
* platform/qt/svg/custom/marker-default-width-height-expected.png:
* platform/qt/svg/custom/marker-default-width-height-expected.txt:
* platform/qt/svg/custom/marker-overflow-clip-expected.png:
* platform/qt/svg/custom/marker-overflow-clip-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/qt/svg/custom/no-inherited-dashed-stroke-expected.txt:
* platform/qt/svg/custom/non-opaque-filters-expected.png:
* platform/qt/svg/custom/non-opaque-filters-expected.txt:
* platform/qt/svg/custom/object-no-size-attributes-expected.png:
* platform/qt/svg/custom/object-no-size-attributes-expected.txt:
* platform/qt/svg/custom/object-sizing-expected.png:
* platform/qt/svg/custom/object-sizing-expected.txt:
* platform/qt/svg/custom/object-sizing-explicit-height-expected.png:
* platform/qt/svg/custom/object-sizing-explicit-height-expected.txt:
* platform/qt/svg/custom/object-sizing-explicit-width-expected.png:
* platform/qt/svg/custom/object-sizing-explicit-width-expected.txt:
* platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png:
* platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-no-width-height-expected.png:
* platform/qt/svg/custom/object-sizing-no-width-height-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/path-textPath-simulation-expected.png:
* platform/qt/svg/custom/path-textPath-simulation-expected.txt:
* platform/qt/svg/custom/pattern-cycle-detection-expected.png:
* platform/qt/svg/custom/pattern-cycle-detection-expected.txt:
* platform/qt/svg/custom/pattern-deep-referencing-expected.png:
* platform/qt/svg/custom/pattern-deep-referencing-expected.txt:
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.png:
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt:
* platform/qt/svg/custom/pattern-rotate-expected.png:
* platform/qt/svg/custom/pattern-rotate-expected.txt:
* platform/qt/svg/custom/pattern-rotate-gaps-expected.png:
* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt:
* platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
* platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/qt/svg/custom/pattern-with-transformation-expected.png:
* platform/qt/svg/custom/pattern-with-transformation-expected.txt:
* platform/qt/svg/custom/percentage-of-html-parent-expected.png:
* platform/qt/svg/custom/percentage-of-html-parent-expected.txt:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/qt/svg/custom/pointer-events-image-expected.png:
* platform/qt/svg/custom/pointer-events-image-expected.txt:
* platform/qt/svg/custom/pointer-events-path-expected.png:
* platform/qt/svg/custom/pointer-events-path-expected.txt:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/qt/svg/custom/pointer-events-text-expected.png:
* platform/qt/svg/custom/pointer-events-text-expected.txt:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/qt/svg/custom/recursive-clippath-expected.png:
* platform/qt/svg/custom/recursive-clippath-expected.txt:
* platform/qt/svg/custom/recursive-filter-expected.png:
* platform/qt/svg/custom/recursive-filter-expected.txt:
* platform/qt/svg/custom/recursive-gradient-expected.png:
* platform/qt/svg/custom/recursive-gradient-expected.txt:
* platform/qt/svg/custom/recursive-mask-expected.png:
* platform/qt/svg/custom/recursive-mask-expected.txt:
* platform/qt/svg/custom/recursive-pattern-expected.png:
* platform/qt/svg/custom/recursive-pattern-expected.txt:
* platform/qt/svg/custom/relative-sized-content-expected.png: Added.
* platform/qt/svg/custom/relative-sized-content-expected.txt:
* platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
* platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
* platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-image-expected.png:
* platform/qt/svg/custom/relative-sized-image-expected.txt:
* platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
* platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.png:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.png:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
* platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.txt:
* platform/qt/svg/custom/scroll-hit-test-expected.png:
* platform/qt/svg/custom/scroll-hit-test-expected.txt:
* platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/qt/svg/custom/second-inline-text-expected.png:
* platform/qt/svg/custom/second-inline-text-expected.txt:
* platform/qt/svg/custom/shape-rendering-expected.png:
* platform/qt/svg/custom/shape-rendering-expected.txt:
* platform/qt/svg/custom/shapes-supporting-markers-expected.png:
* platform/qt/svg/custom/shapes-supporting-markers-expected.txt:
* platform/qt/svg/custom/simple-text-double-shadow-expected.png:
* platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
* platform/qt/svg/custom/simpleCDF-expected.png:
* platform/qt/svg/custom/simpleCDF-expected.txt:
* platform/qt/svg/custom/stroke-fallback-expected.png:
* platform/qt/svg/custom/stroke-fallback-expected.txt:
* platform/qt/svg/custom/stroke-width-large-expected.png:
* platform/qt/svg/custom/stroke-width-large-expected.txt:
* platform/qt/svg/custom/stroked-pattern-expected.png:
* platform/qt/svg/custom/stroked-pattern-expected.txt:
* platform/qt/svg/custom/style-attribute-font-size-expected.png:
* platform/qt/svg/custom/style-attribute-font-size-expected.txt:
* platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.png:
* platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
* platform/qt/svg/custom/svg-features-expected.txt:
* platform/qt/svg/custom/svg-float-border-padding-expected.png:
* platform/qt/svg/custom/svg-float-border-padding-expected.txt:
* platform/qt/svg/custom/svg-fonts-in-html-expected.png:
* platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
* platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt:
* platform/qt/svg/custom/svg-fonts-segmented-expected.png:
* platform/qt/svg/custom/svg-fonts-segmented-expected.txt:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.png:
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt:
* platform/qt/svg/custom/svg-overflow-types-expected.png:
* platform/qt/svg/custom/svg-overflow-types-expected.txt:
* platform/qt/svg/custom/text-clip-expected.png:
* platform/qt/svg/custom/text-clip-expected.txt:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/custom/text-decoration-visibility-expected.png:
* platform/qt/svg/custom/text-decoration-visibility-expected.txt:
* platform/qt/svg/custom/text-dom-01-f-expected.png:
* platform/qt/svg/custom/text-dom-01-f-expected.txt:
* platform/qt/svg/custom/text-filter-expected.png:
* platform/qt/svg/custom/text-filter-expected.txt:
* platform/qt/svg/custom/text-hit-test-expected.png:
* platform/qt/svg/custom/text-hit-test-expected.txt:
* platform/qt/svg/custom/text-image-opacity-expected.png:
* platform/qt/svg/custom/text-image-opacity-expected.txt:
* platform/qt/svg/custom/text-letter-spacing-expected.png:
* platform/qt/svg/custom/text-letter-spacing-expected.txt:
* platform/qt/svg/custom/text-linking-expected.png:
* platform/qt/svg/custom/text-linking-expected.txt:
* platform/qt/svg/custom/text-repaint-including-stroke-expected.png:
* platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
* platform/qt/svg/custom/text-rotated-gradient-expected.png:
* platform/qt/svg/custom/text-rotated-gradient-expected.txt:
* platform/qt/svg/custom/text-rotation-expected.png:
* platform/qt/svg/custom/text-rotation-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png:
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt:
* platform/qt/svg/custom/text-whitespace-handling-expected.png:
* platform/qt/svg/custom/text-whitespace-handling-expected.txt:
* platform/qt/svg/custom/text-x-dx-lists-expected.png:
* platform/qt/svg/custom/text-x-dx-lists-expected.txt:
* platform/qt/svg/custom/text-x-dy-lists-expected.png:
* platform/qt/svg/custom/text-x-dy-lists-expected.txt:
* platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
* platform/qt/svg/custom/text-x-override-in-tspan-child-expected.txt:
* platform/qt/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
* platform/qt/svg/custom/text-xy-updates-expected.png:
* platform/qt/svg/custom/text-xy-updates-expected.txt:
* platform/qt/svg/custom/tref-own-content-removal-expected.png:
* platform/qt/svg/custom/tref-own-content-removal-expected.txt:
* platform/qt/svg/custom/tref-update-expected.png:
* platform/qt/svg/custom/tref-update-expected.txt:
* platform/qt/svg/custom/use-clipped-hit-expected.png:
* platform/qt/svg/custom/use-clipped-hit-expected.txt:
* platform/qt/svg/custom/use-detach-expected.png:
* platform/qt/svg/custom/use-detach-expected.txt:
* platform/qt/svg/custom/use-dynamic-append-expected.png:
* platform/qt/svg/custom/use-dynamic-append-expected.txt:
* platform/qt/svg/custom/use-elementInstance-event-target-expected.png:
* platform/qt/svg/custom/use-elementInstance-event-target-expected.txt:
* platform/qt/svg/custom/use-elementInstance-methods-expected.png:
* platform/qt/svg/custom/use-elementInstance-methods-expected.txt:
* platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.png:
* platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.txt:
* platform/qt/svg/custom/use-event-handler-on-use-element-expected.png:
* platform/qt/svg/custom/use-event-handler-on-use-element-expected.txt:
* platform/qt/svg/custom/use-events-crash-expected.png:
* platform/qt/svg/custom/use-events-crash-expected.txt:
* platform/qt/svg/custom/use-instanceRoot-modifications-expected.png:
* platform/qt/svg/custom/use-instanceRoot-modifications-expected.txt:
* platform/qt/svg/custom/use-modify-container-in-target-expected.png:
* platform/qt/svg/custom/use-modify-container-in-target-expected.txt:
* platform/qt/svg/custom/use-modify-target-container-expected.png:
* platform/qt/svg/custom/use-modify-target-container-expected.txt:
* platform/qt/svg/custom/use-modify-target-symbol-expected.png:
* platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
* platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/qt/svg/custom/use-on-g-containing-use-expected.png:
* platform/qt/svg/custom/use-on-g-containing-use-expected.txt:
* platform/qt/svg/custom/use-on-g-expected.png:
* platform/qt/svg/custom/use-on-g-expected.txt:
* platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.png:
* platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
* platform/qt/svg/custom/use-on-rect-expected.png:
* platform/qt/svg/custom/use-on-rect-expected.txt:
* platform/qt/svg/custom/use-on-symbol-expected.png:
* platform/qt/svg/custom/use-on-symbol-expected.txt:
* platform/qt/svg/custom/use-on-text-expected.png:
* platform/qt/svg/custom/use-on-text-expected.txt:
* platform/qt/svg/custom/use-on-use-expected.png:
* platform/qt/svg/custom/use-on-use-expected.txt:
* platform/qt/svg/custom/use-property-changes-through-dom-expected.png:
* platform/qt/svg/custom/use-property-changes-through-dom-expected.txt:
* platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.png:
* platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.txt:
* platform/qt/svg/custom/use-recursion-1-expected.png:
* platform/qt/svg/custom/use-recursion-1-expected.txt:
* platform/qt/svg/custom/use-recursion-2-expected.png:
* platform/qt/svg/custom/use-recursion-2-expected.txt:
* platform/qt/svg/custom/use-recursion-3-expected.png:
* platform/qt/svg/custom/use-recursion-3-expected.txt:
* platform/qt/svg/custom/use-recursion-4-expected.png:
* platform/qt/svg/custom/use-recursion-4-expected.txt:
* platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/qt/svg/custom/use-setAttribute-crash-expected.png:
* platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
* platform/qt/svg/custom/use-transform-expected.png:
* platform/qt/svg/custom/use-transform-expected.txt:
* platform/qt/svg/custom/viewbox-syntax-expected.png:
* platform/qt/svg/custom/viewbox-syntax-expected.txt:
* platform/qt/svg/custom/viewport-em-expected.png:
* platform/qt/svg/custom/viewport-em-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 27 Jul 2012 18:23:18 +0000 (18:23 +0000)]
nrwt: print filtered stderr after a crash correctly
https://bugs.webkit.org/show_bug.cgi?id=92428
Reviewed by Adam Barth.
Some ports will run the stderr output from DRT/WTR through a
filter after a crash in order to print a more useful stack
trace; while that gets written to the crash log correctly, we
don't log it to the debug output properly. This change fixes
that and makes it clearer that we're logging stderr, not the
crash log.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Fri, 27 Jul 2012 18:22:23 +0000 (18:22 +0000)]
[Texmap] Performance regression in texture uploads after r121223
https://bugs.webkit.org/show_bug.cgi?id=91897
Reviewed by Jocelyn Turcotte.
Rolling out r121223, with some conflict fixes.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::swizzleBGRAToRGBA):
(WebCore):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 27 Jul 2012 18:21:08 +0000 (18:21 +0000)]
nrwt: move image diffing code to a separate module
https://bugs.webkit.org/show_bug.cgi?id=92447
Reviewed by Ryosuke Niwa.
This patch moves the code to talk to ImageDiff into its own
module, and adds more tests for it. In addition, the patch
modifies diff_image() so that we don't automatically stop
ImageDiff after a single invocation, and thus subsequent
diffs may be slightly faster. (Note that the chromium ports
don't use any of this code; that is not changed by this patch).
The main motivation for this change is to move more "generic"
code out of the port/* classes, and in particular to move more
code out of webkit.py so that we can eventually eliminate it by
merging it into base.py.
This patch also splits MockServerProcess out from driver_unittest.py
so that it can be re-used.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port.diff_image):
(Port.clean_up_test_run):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.__init__):
(Driver._start):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.clean_up_test_run):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.clean_up_test_run):
* Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
(ImageDiffer):
(ImageDiffer.__init__):
(ImageDiffer.diff_image):
(ImageDiffer._start):
(ImageDiffer._read):
(ImageDiffer.stop):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
(for):
(FakePort):
(FakePort.__init__):
(FakePort._path_to_image_diff):
(FakePort.setup_environ_for_server):
(TestImageDiffer):
(TestImageDiffer.test_diff_image):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image__missing_both):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image.make_proc):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._start):
* Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
(MockServerProcess):
(MockServerProcess.__init__):
(MockServerProcess.write):
(MockServerProcess.has_crashed):
(MockServerProcess.read_stdout_line):
(MockServerProcess.read_stdout):
(MockServerProcess.pop_all_buffered_stderr):
(MockServerProcess.read_either_stdout_or_stderr_line):
(MockServerProcess.start):
(MockServerProcess.stop):
(MockServerProcess.kill):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_driver_flags):
(WebKitPort._symbols_string):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 18:17:27 +0000 (18:17 +0000)]
Activate committer bit granted April 6th so I can garden.
https://bugs.webkit.org/show_bug.cgi?id=92500
Patch by Tom Hudson <hudson@google.com> on 2012-07-27
Reviewed by Jochen Eisinger.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 18:13:01 +0000 (18:13 +0000)]
[BlackBerry] Should support onbeforeunload event and show confirmation dialog
https://bugs.webkit.org/show_bug.cgi?id=92510
Patch by Yong Li <yoli@rim.com> on 2012-07-27
Reviewed by Antonio Gomes.
RIM PR# 155878.
1. Export dispatchBeforeUnloadEvent() so client can call it before going to close the page.
2. Forward runBeforeUnloadConfirmPanel() call to client so it can show a dialog.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::canRunBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 18:04:45 +0000 (18:04 +0000)]
[BlackBerry] Update NetworkJob::sendRequestWithCredentials to use new getProxyAddress API
https://bugs.webkit.org/show_bug.cgi?id=92457
Patch by Joe Mason <jmason@rim.com> on 2012-07-27
Reviewed by Yong Li.
getProxyAddress now returns "host:port", and getProxyPort is gone. Update NetworkJob to use
the new interface.
RIM PR: 176166
Internally reviewed by Jonathan Dong <jonathan.dong@torchmobile.com.cn>
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:59:36 +0000 (17:59 +0000)]
Improve touch adjustment for targetting small controls.
https://bugs.webkit.org/show_bug.cgi?id=92293
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.
Source/WebCore:
Modifies the touch adjustment algorithm to better discriminate small targets without introducing
a bias towards shorter links. The revised scoring algorihtm uses a normalized distance to
center-line score and a normalized overlap score. The better of the two scores is used for
determining the best candidate for target adjustment. The center-line score works well
for discriminating elements with partial overlaps, where relying solely on percent overlap
could bias towards the smaller element. Conversely, a high percentage in overlap provides a
strong measure of confidence in a candidate target. An additonal tie-break algorithm is
introduced to minimize the adjustment distance if two equally suitable candidates are found.
Test: touchadjustment/small-target-test.html
* page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::hybridDistanceFunction):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
(WebCore::findBestClickableCandidate):
LayoutTests:
Adds a test for cases that were problematic for the touch adjustment algorithm. Each example
in the test involves a small control immediately adjacent to a larger control. When the touch
area is significantly larger than the small control, it was possible for the touch element to
completely overlap the control yet select an adjacent element with a partial overlap.
* touchadjustment/small-target-test-expected.txt: Added.
* touchadjustment/small-target-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:56:49 +0000 (17:56 +0000)]
[chromium] Calendar for input type=date should be larger on devices that support touch input.
https://bugs.webkit.org/show_bug.cgi?id=92424
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Kent Tamura.
Source/WebCore:
Adds touch specific CSS rules to enlarge entries in the calendar on
screens that support touch input.
Manually tested with touch support enabled/disabled.
* Resources/calendarPicker.css:
(@media (pointer:coarse)):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):
Source/WebKit/chromium:
Plumbs the deviceSupportsTouch setting through to the popup page so
that the Calendar popup can be enlarged on screens that support touch
input.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:50:52 +0000 (17:50 +0000)]
[EFL] Add missing baselines for fast/table/table-row-outline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=92509
Unreviewed EFL gardening, add missing results for
fast/table/table-row-outline-paint.html after r123793.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27
* platform/efl/fast/table/table-row-outline-paint-expected.png: Added.
* platform/efl/fast/table/table-row-outline-paint-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:48:46 +0000 (17:48 +0000)]
Lose a timer in prerender-remove-after-stop.html
https://bugs.webkit.org/show_bug.cgi?id=92425
Patch by Gavin Peters <gavinp@chromium.org> on 2012-07-27
Reviewed by Nate Chapin.
japhet suggested that the timer wasn't needed, and testing revealed that the test works without it. I've tested that if the bug is reintroduced
that it crashes, and of course it doesn't crash with the fix. So bye-bye setTimeout!
* fast/dom/HTMLLinkElement/prerender-remove-after-stop.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:39:54 +0000 (17:39 +0000)]
[BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never fail
https://bugs.webkit.org/show_bug.cgi?id=92508
Patch by Mike Fenton <mifenton@rim.com> on 2012-07-27
Reviewed by Yong Li.
Replace common uses of malloc with fastMalloc rather
than trying to recover gracefully. If we are truly
out of memory, crash before corruption occurs.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 27 Jul 2012 17:39:01 +0000 (17:39 +0000)]
WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911
Reviewed by Darin Adler.
Update comments around code to explain rationale.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:34:27 +0000 (17:34 +0000)]
[EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
https://bugs.webkit.org/show_bug.cgi?id=92507
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kentaro Hara.
After r92466, the default navigation policy is to reject the request if the
client does not make a decision explicitly. The default policy should be
to accept. This broke ewk_view unit tests.
* ewk/ewk_view.cpp:
(ewk_view_navigation_policy_decision):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:24:49 +0000 (17:24 +0000)]
[EFL][WK2] Add download client for Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=91345
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Add download client for Ewk_Context so that
information about downloads can be reported
to the client application via Ewk_View signals.
The client application needs to listen for
"download,request" signal on the view and set
the download path for the download in the
callback in order to accept it. If the signal
is ignored or if the download path is not set
the download will fail.
A new Ewk_Download_Job type is introduced to provide
information relative to a download to the client
and to allow the client to interact with it (e.g.
set its download path, cancel it, ...).
* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit):
* UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_download_job_add):
(ewk_context_download_job_get):
(ewk_context_download_job_remove):
* UIProcess/API/efl/ewk_context_download_client.cpp: Added.
(toEwkContext):
(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):
* UIProcess/API/efl/ewk_context_download_client_private.h: Added.
* UIProcess/API/efl/ewk_context_private.h:
* UIProcess/API/efl/ewk_download_job.cpp: Added.
(_Ewk_Download_Job):
(_Ewk_Download_Job::_Ewk_Download_Job):
(_Ewk_Download_Job::~_Ewk_Download_Job):
(ewk_download_job_ref):
(ewk_download_job_unref):
(ewk_download_job_id_get):
(ewk_download_job_view_get):
(ewk_download_job_state_get):
(ewk_download_job_request_get):
(ewk_download_job_response_get):
(ewk_download_job_destination_get):
(ewk_download_job_destination_set):
(ewk_download_job_suggested_filename_get):
(ewk_download_job_cancel):
(ewk_download_job_estimated_progress_get):
(ewk_download_job_elapsed_time_get):
(ewk_download_job_response_set):
(ewk_download_job_suggested_filename_set):
(ewk_download_job_received_data):
(ewk_download_job_state_set):
(ewk_download_job_new):
* UIProcess/API/efl/ewk_download_job.h: Added.
* UIProcess/API/efl/ewk_download_job_private.h: Added.
(WebKit):
* UIProcess/API/efl/ewk_url_response.cpp:
(ewk_url_response_content_length_get): Add a function to
retrieve the content length of a URL response.
* UIProcess/API/efl/ewk_url_response.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_download_job_cancelled):
(ewk_view_download_job_requested):
(ewk_view_download_job_failed):
(ewk_view_download_job_finished):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/tests/resources/test.pdf: Added.
* UIProcess/API/efl/tests/test_ewk2_download_job.cpp: Added. This tests
the download functionality.
(DownloadTestData):
(fileExists):
(serverCallback):
(on_download_requested):
(on_download_cancelled):
(on_download_failed):
(on_download_finished):
(TEST_F):
* UIProcess/PageClient.h:
(PageClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit):
(WebKit::WebPageProxy::handleDownloadRequest):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:19:14 +0000 (17:19 +0000)]
Add runtime flag to enable/disable JS memory information
https://bugs.webkit.org/show_bug.cgi?id=92479
Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-07-27
Reviewed by Simon Hausmann.
We need console.memory JS object to be accessible because of the memory consumption
measurements of the performance tests, so I added a toggle to InternalSettings.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMemoryInfoEnabled):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:17:00 +0000 (17:17 +0000)]
Microdata: Remove toJs() and toV8Object() custom methods from JSHTMLElementCustom.cpp and V8HTMLElementCustom.cpp respectively.
https://bugs.webkit.org/show_bug.cgi?id=92482
Patch by Arko Saha <arko@motorola.com> on 2012-07-27
Reviewed by Kentaro Hara.
Removed custom methods toJS() and toV8Object(). We should use toJS() method defined in
JSMicroDataItemValueCustom.cpp and toV8() method defined in V8MicroDataItemValueCustom.cpp
in place of custom toJs() and toV8Object().
Existing tests :
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
fast/dom/MicroData/itemvalue-reflects-href-attr.html
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
fast/dom/MicroData/itemvalue-returns-element-itself.html
fast/dom/MicroData/itemvalue-returns-null.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html
* bindings/js/JSHTMLElementCustom.cpp:
(WebCore):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 17:14:41 +0000 (17:14 +0000)]
Source/WebKit: [EFL] WebKit API unit tests needs a timeout
https://bugs.webkit.org/show_bug.cgi?id=92496
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-27
Reviewed by Antonio Gomes.
Added the same timeout value that we have for WebKit2.
* PlatformEfl.cmake:
Source/WTF: Support a rational time class for use by media elements.
https://bugs.webkit.org/show_bug.cgi?id=88787
Patch by Jer Noble <jer.noble@apple.com> on 2012-07-27
Reviewed by Eric Carlson.
Add a new MediaTime class which implements rational math operations.
Add common constructors and assignment operators:
* wtf/MediaTime.cpp: Added.
(WTF::MediaTime::MediaTime):
(WTF::MediaTime::~MediaTime):
(WTF::MediaTime::operator=):
Add common math operators:
* wtf/MediaTime.cpp:
(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator<):
(WTF::MediaTime::operator>):
(WTF::MediaTime::operator==):
(WTF::MediaTime::operator>=):
(WTF::MediaTime::operator<=):
Add functions to check the MeiaTime time type flags:
* wtf/MediaTime.h:
(WTF::MediaTime::isValid):
(WTF::MediaTime::isInvalid):
(WTF::MediaTime::hasBeenRounde):
(WTF::MediaTime::isPositiveInfinite):
(WTF::MediaTime::isNegativeInfinite):
(WTF::MediaTime::isIndefinite):
Add constants for commonly used MediaTime values:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):
Add explicit conversion functions to convert to and from floating point values.
* wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::toFloat):
(WTF::MediaTime::toDouble):
Add some useful exported functions:
* wtf/MediaTime.cpp:
(WTF::MediaTime::compare): Master function for the comparison operators above.
(WTF::MediaTime::setTimeScale): Rescale the time value to a new time scale.
(WTF::abs): Return an absolute value for the current MediaTime.
Static utility functions to implement the above:
* wtf/MediaTime.cpp:
(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):
Windows-only implementations of isinf and signbit:
* wtf/MediaTime.cpp:
(std::isinf):
(std::signbit):
Add the new class to platform build files:
* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 27 Jul 2012 16:31:07 +0000 (16:31 +0000)]
Support a rational time class for use by media elements.
https://bugs.webkit.org/show_bug.cgi?id=88787
Source/JavaScriptCore:
Re-export WTF::MediaTime from JavaScriptCore.
Reviewed by Eric Carlson.
* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Source/WTF:
Reviewed by Eric Carlson.
Add a new MediaTime class which implements rational math operations.
Add common constructors and assignment operators:
* wtf/MediaTime.cpp: Added.
(WTF::MediaTime::MediaTime):
(WTF::MediaTime::~MediaTime):
(WTF::MediaTime::operator=):
Add common math operators:
* wtf/MediaTime.cpp:
(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator<):
(WTF::MediaTime::operator>):
(WTF::MediaTime::operator==):
(WTF::MediaTime::operator>=):
(WTF::MediaTime::operator<=):
Add functions to check the MeiaTime time type flags:
* wtf/MediaTime.h:
(WTF::MediaTime::isValid):
(WTF::MediaTime::isInvalid):
(WTF::MediaTime::hasBeenRounde):
(WTF::MediaTime::isPositiveInfinite):
(WTF::MediaTime::isNegativeInfinite):
(WTF::MediaTime::isIndefinite):
Add constants for commonly used MediaTime values:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):
Add explicit conversion functions to convert to and from floating point values.
* wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::toFloat):
(WTF::MediaTime::toDouble):
Add some useful exported functions:
* wtf/MediaTime.cpp:
(WTF::MediaTime::compare): Master function for the comparison operators above.
(WTF::MediaTime::setTimeScale): Rescale the time value to a new time scale.
(WTF::abs): Return an absolute value for the current MediaTime.
Static utility functions to implement the above:
* wtf/MediaTime.cpp:
(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):
Windows-only implementations of isinf and signbit:
* wtf/MediaTime.cpp:
(std::isinf):
(std::signbit):
Add the new class to platform build files:
* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
Tools:
Add unit tests for the WTF::MediaTime class.
Reviewed by Eric Carlson.
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/TestWebKitAPI.gypi:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
(WTF::operator<<):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Fri, 27 Jul 2012 16:22:06 +0000 (16:22 +0000)]
[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754
Unreviewed attempt to fix the chaos I introduced.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::processLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Fri, 27 Jul 2012 14:15:24 +0000 (14:15 +0000)]
[Qt][WK2] Gardening after r123786. It made 5 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 14:14:43 +0000 (14:14 +0000)]
set WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED for chromium android
https://bugs.webkit.org/show_bug.cgi?id=91746
Patch by Wei James <james.wei@intel.com> on 2012-07-27
Reviewed by Adam Barth.
This patch is part of efforts to enable web audio for chromium android.
Web audio component needs to use atomicIncrement and atomicDecrement,
which are enabled by this MACRO.
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=89428#c19, make
this patch standalone.
* wtf/Atomics.h:
(WTF):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 14:04:27 +0000 (14:04 +0000)]
[EFL] Rebaseline after harfbuzz-ng complex font support is enabled
https://bugs.webkit.org/show_bug.cgi?id=92120
Unreviewed, EFL rebaselining.
Now that we have complex font support using harfbuzz, we need a couple of new expected results.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-27
* platform/efl/TestExpectations:
* platform/efl/fast/dom/52776-expected.png:
* platform/efl/fast/dom/52776-expected.txt:
* platform/efl/fast/text/atsui-kerning-and-ligatures-expected.png:
* platform/efl/fast/text/atsui-kerning-and-ligatures-expected.txt:
* platform/efl/fast/text/atsui-multiple-renderers-expected.png:
* platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
* platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
* platform/efl/fast/text/atsui-negative-spacing-features-expected.txt:
* platform/efl/fast/text/atsui-partial-selection-expected.png:
* platform/efl/fast/text/atsui-partial-selection-expected.txt:
* platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png:
* platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.txt:
* platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
* platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:
* platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png:
* platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.txt:
* platform/efl/fast/text/atsui-spacing-features-expected.png:
* platform/efl/fast/text/atsui-spacing-features-expected.txt:
* platform/efl/fast/text/cg-vs-atsui-expected.png:
* platform/efl/fast/text/cg-vs-atsui-expected.txt:
* platform/efl/fast/text/complex-preferred-logical-widths-expected.png:
* platform/efl/fast/text/complex-preferred-logical-widths-expected.txt:
* platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png:
* platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
* platform/efl/fast/text/should-use-atsui-expected.png:
* platform/efl/fast/text/should-use-atsui-expected.txt:
* platform/efl/fast/text/stroking-decorations-expected.png:
* platform/efl/fast/text/stroking-decorations-expected.txt:
* platform/efl/fast/text/stroking-expected.png:
* platform/efl/fast/text/stroking-expected.txt:
* platform/efl/fast/text/wide-zero-width-space-expected.png:
* platform/efl/fast/text/wide-zero-width-space-expected.txt:
* platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
* platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
* platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
* platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
* platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
* platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
* platform/efl/transforms/2d/hindi-rotated-expected.png:
* platform/efl/transforms/2d/hindi-rotated-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 13:56:58 +0000 (13:56 +0000)]
REGRESSION(r123856): Breaks the build when disabling inspector
https://bugs.webkit.org/show_bug.cgi?id=92493
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-27
Reviewed by Kentaro Hara.
* bindings/js/ScriptGCEvent.h:
(WebCore):
* bindings/v8/ScriptGCEvent.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 13:45:16 +0000 (13:45 +0000)]
[WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91581
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-27
Reviewed by Noam Rosenthal.
Source/WebKit2:
This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
When enter accelerated compositing mode, create evas_gl, evas_gl_context, and evas_gl_surface.
* PlatformEfl.cmake:
* Shared/LayerTreeContext.h:
(LayerTreeContext):
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(ewk_view_size_get):
(ewk_view_create_gl_surface):
(ewk_view_enter_accelerated_compositing_mode):
(ewk_view_exit_accelerated_compositing_mode):
(_ewk_view_smart_calculate):
* UIProcess/API/efl/ewk_view_private.h:
Tools:
Add a MiniBrowser's option for selecting evas engine.
* MiniBrowser/efl/main.c:
(browserCreate):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Fri, 27 Jul 2012 13:41:52 +0000 (13:41 +0000)]
Unreviewed, rolling out r123869.
http://trac.webkit.org/changeset/123869
https://bugs.webkit.org/show_bug.cgi?id=92501
"it did not fix anything but made things even worst"
(Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixelsForAllTests):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/main.cpp:
(main):
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.supports_switching_pixel_tests_per_test):
(Port):
(Port._supports_switching_pixel_tests_per_test):
(Port.should_run_as_pixel_test):
(Port._should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line):
(Driver._command_from_driver_input):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.check_sys_deps):
(QtPort):
(QtPort._supports_switching_pixel_tests_per_test):
(QtPort._should_run_as_pixel_test):
(QtPort._default_pixel_test_directories):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.supports_switching_pixel_tests_per_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_pixel_test_directories):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 13:39:37 +0000 (13:39 +0000)]
[EFL][WK2] Add API to Ewk_Cookie_Manager to watch for cookie changes
https://bugs.webkit.org/show_bug.cgi?id=92484
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Make use of soup/CookieStorageSoup.cpp for EFL port instead
of defining empty implementations for cookie storage
functions.
No new tests, no behavior change.
* PlatformEfl.cmake:
* platform/efl/TemporaryLinkStubs.cpp:
Source/WebKit2:
Add API tp Ewk_Cookie_Manager so that the client can watch
for cookie changes.
* UIProcess/API/efl/ewk_cookie_manager.cpp:
* UIProcess/API/efl/ewk_cookie_manager.h:
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Add unit tests
for cookie changes watching.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Fri, 27 Jul 2012 13:11:06 +0000 (13:11 +0000)]
[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754
Reviewed by Zoltan Herczeg.
Rollout r123729 because it made Qt debug bots crasy.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixels):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/main.cpp:
(main):
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.lookup_virtual_test_args):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line):
(Driver._command_from_driver_input):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.check_sys_deps):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_missing_and_unexpected_results):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Fri, 27 Jul 2012 12:51:14 +0000 (12:51 +0000)]
[Qt] Gardening after r123786. It made 3 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 27 Jul 2012 12:27:47 +0000 (12:27 +0000)]
Replace ColorChooserClient::elementRectRelativeToWindow with elementRectRelativeToRootView
https://bugs.webkit.org/show_bug.cgi?id=92488
Reviewed by Kent Tamura.
Changing ColorChooserClient interface to return element rectangle that is relative to root view instead of window.
No new tests. Method is not used yet.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::elementRectRelativeToRootView): Replaced elementRectRelativeToWindow. Returns element rectangle relative to root view.
* html/ColorInputType.h:
(ColorInputType):
* platform/ColorChooserClient.h:
(ColorChooserClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 11:52:15 +0000 (11:52 +0000)]
[EFL][WK2] Stop using C API to interact with the page in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=92463
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Simon Hausmann.
Stop using C API to interact with the PageProxy in Ewk_View
and use the PageProxy object directly. This avoids useless
converting to WK type using toAPI() all the time.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_uri_update):
(ewk_view_uri_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_theme_get):
(ewk_view_cursor_set):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 Jul 2012 11:42:32 +0000 (11:42 +0000)]
webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
https://bugs.webkit.org/show_bug.cgi?id=92472
Reviewed by Eric Seidel.
We need to run these command periodically to keep cruft from
accumulating in bugs.webkit.org. Rather than running them manually, we
should just have a bot run them. This patch has the style-queue run the
commands, which admittedly is a bit odd but it doesn't seem worthwhile
to create another bot specifically for this purposes.
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue):
(StyleQueue.begin_work_queue):
(StyleQueue):
(StyleQueue.clean_bugzilla):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 11:32:44 +0000 (11:32 +0000)]
[Cairo] Add complex font drawing using HarfbuzzNG
https://bugs.webkit.org/show_bug.cgi?id=91864
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-27
Reviewed by Simon Hausmann and Martin Robinson.
.:
Configuring Freetype backend to use HarfBuzz by default.
* Source/cmake/FindHarfBuzz.cmake: Added pkgconfig based discovery of HarfBuzz.
* Source/cmake/OptionsEfl.cmake: Adding Harfbuzz configuration.
Source/WebCore:
Adding Harfbuzz support to EFL by implementing it with the help of cairo and cairo-ft.
Reusing Chromium's Harfbuzz-NG support.
No new tests, complex font support is covered by existing tests.
* CMakeLists.txt: Adding new cairo based implementations, removing emtpy FontEfl.cpp
* WebCore.gypi: Removing FontEfl.cpp
* platform/graphics/cairo/FontCairoHarfbuzzNG.cpp: Added. New implementation that implements cairo & harfbuzz-ng based complex font drawing.
(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/efl/FontEfl.cpp: Removed.
* platform/graphics/freetype/FontPlatformData.h: Adding a getter that retrieves a harfbuzz face.
(FontPlatformData):
* platform/graphics/freetype/FontPlatformDataFreeType.cpp: Adding a getter that retrieves a harfbuzz face.
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp: Added. Cairo-freetype based approach to get complex font metrics.
(WebCore):
(CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::lock):
(WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):
(WebCore::floatToHarfBuzzPosition):
(WebCore::doubleToHarfBuzzPosition):
(WebCore::CairoGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzCairoTextGetFontFuncs):
(WebCore::harfbuzzCairoGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
Source/WebKit:
Adding includes for harfbuzz folders.
* CMakeLists.txt:
Source/WebKit2:
Adding includes for harfbuzz folders.
* CMakeLists.txt:
Tools:
Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
* WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
* efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 11:12:56 +0000 (11:12 +0000)]
[EFL][WK2] Add more Ewk_View unit tests
https://bugs.webkit.org/show_bug.cgi?id=92407
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Add more unit tests for WebKit2 Ewk_View API.
In particular, navigation, HTML loading and
device pixel ratio functions are now tested.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp): Call ewk_init() instead
of duplicating initialization code.
(EWK2UnitTest::EWK2UnitTestBase::TearDown): call ewk_shutdown().
(TitleChangedData):
(EWK2UnitTest):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo): Add convenience
method to wait until the view main frame title changes to a given value.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
(serverCallbackNavigation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 11:09:35 +0000 (11:09 +0000)]
[Qt] platform/qt/editing/pasteboard tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91399.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Csaba Osztrogonác.
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/editing/pasteboard/
4806874-expected.txt: Added.
* platform/qt-5.0-wk2/editing/pasteboard/
4944770-1-expected.png: Removed.
* platform/qt-5.0-wk2/editing/pasteboard/
4944770-1-expected.txt: Removed.
* platform/qt-5.0-wk2/editing/pasteboard/
4944770-2-expected.png: Removed.
* platform/qt-5.0-wk2/editing/pasteboard/
4944770-2-expected.txt: Removed.
* platform/qt-5.0-wk2/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/input-field-1-expected.txt.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/editing/pasteboard/
4944770-1-expected.png: Removed.
* platform/qt-5.0/editing/pasteboard/
4944770-1-expected.txt: Removed.
* platform/qt-5.0/editing/pasteboard/
4944770-2-expected.png: Removed.
* platform/qt-5.0/editing/pasteboard/
4944770-2-expected.txt: Removed.
* platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Removed.
* platform/qt/editing/pasteboard/
3976872-expected.png: Added.
* platform/qt/editing/pasteboard/
3976872-expected.txt:
* platform/qt/editing/pasteboard/
4076267-2-expected.png:
* platform/qt/editing/pasteboard/
4076267-2-expected.txt:
* platform/qt/editing/pasteboard/
4076267-3-expected.png:
* platform/qt/editing/pasteboard/
4076267-3-expected.txt:
* platform/qt/editing/pasteboard/
4076267-expected.png:
* platform/qt/editing/pasteboard/
4076267-expected.txt:
* platform/qt/editing/pasteboard/
4242293-expected.png: Added.
* platform/qt/editing/pasteboard/
4242293-expected.txt:
* platform/qt/editing/pasteboard/
4631972-expected.png: Added.
* platform/qt/editing/pasteboard/
4631972-expected.txt:
* platform/qt/editing/pasteboard/
4641033-expected.png:
* platform/qt/editing/pasteboard/
4641033-expected.txt:
* platform/qt/editing/pasteboard/
4806874-expected.png:
* platform/qt/editing/pasteboard/
4806874-expected.txt:
* platform/qt/editing/pasteboard/
4944770-1-expected.png:
* platform/qt/editing/pasteboard/
4944770-1-expected.txt:
* platform/qt/editing/pasteboard/
4944770-2-expected.png:
* platform/qt/editing/pasteboard/
4944770-2-expected.txt:
* platform/qt/editing/pasteboard/
4989774-expected.png: Added.
* platform/qt/editing/pasteboard/
4989774-expected.txt:
* platform/qt/editing/pasteboard/
5006779-expected.png: Added.
* platform/qt/editing/pasteboard/
5006779-expected.txt:
* platform/qt/editing/pasteboard/
5028447-expected.png: Added.
* platform/qt/editing/pasteboard/
5028447-expected.txt:
* platform/qt/editing/pasteboard/
5032095-expected.png: Added.
* platform/qt/editing/pasteboard/
5032095-expected.txt:
* platform/qt/editing/pasteboard/
5071074-2-expected.png: Added.
* platform/qt/editing/pasteboard/
5071074-2-expected.txt:
* platform/qt/editing/pasteboard/
5071074-expected.png: Added.
* platform/qt/editing/pasteboard/
5071074-expected.txt:
* platform/qt/editing/pasteboard/
5075944-expected.png: Added.
* platform/qt/editing/pasteboard/
5075944-expected.txt:
* platform/qt/editing/pasteboard/
5134759-expected.png: Added.
* platform/qt/editing/pasteboard/
5134759-expected.txt:
* platform/qt/editing/pasteboard/
5156401-1-expected.png: Added.
* platform/qt/editing/pasteboard/
5156401-1-expected.txt:
* platform/qt/editing/pasteboard/
5247341-expected.png: Added.
* platform/qt/editing/pasteboard/
5247341-expected.txt:
* platform/qt/editing/pasteboard/
5387578-expected.png:
* platform/qt/editing/pasteboard/
5387578-expected.txt:
* platform/qt/editing/pasteboard/
5478250-expected.png:
* platform/qt/editing/pasteboard/
5478250-expected.txt:
* platform/qt/editing/pasteboard/
5601583-1-expected.png: Added.
* platform/qt/editing/pasteboard/
5601583-1-expected.txt:
* platform/qt/editing/pasteboard/
5780697-2-expected.txt:
* platform/qt/editing/pasteboard/7955-expected.png: Added.
* platform/qt/editing/pasteboard/7955-expected.txt:
* platform/qt/editing/pasteboard/8145-1-expected.png: Added.
* platform/qt/editing/pasteboard/8145-1-expected.txt:
* platform/qt/editing/pasteboard/8145-2-expected.png: Added.
* platform/qt/editing/pasteboard/8145-2-expected.txt:
* platform/qt/editing/pasteboard/8145-3-expected.png:
* platform/qt/editing/pasteboard/8145-3-expected.txt:
* platform/qt/editing/pasteboard/bad-placeholder-expected.png:
* platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt:
* platform/qt/editing/pasteboard/cut-text-001-expected.png:
* platform/qt/editing/pasteboard/cut-text-001-expected.txt:
* platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.png: Added.
* platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
* platform/qt/editing/pasteboard/displaced-placeholder-expected.png: Added.
* platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/qt/editing/pasteboard/input-field-1-expected.png:
* platform/qt/editing/pasteboard/input-field-1-expected.txt:
* platform/qt/editing/pasteboard/merge-after-delete-1-expected.png: Added.
* platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
* platform/qt/editing/pasteboard/merge-after-delete-2-expected.png: Added.
* platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/qt/editing/pasteboard/merge-after-delete-expected.png: Added.
* platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
* platform/qt/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/qt/editing/pasteboard/merge-end-borders-expected.png:
* platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
* platform/qt/editing/pasteboard/merge-start-blockquote-expected.png: Added.
* platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
* platform/qt/editing/pasteboard/merge-start-list-expected.png: Added.
* platform/qt/editing/pasteboard/merge-start-list-expected.txt:
* platform/qt/editing/pasteboard/paste-
4035648-fix-expected.png: Added.
* platform/qt/editing/pasteboard/paste-
4035648-fix-expected.txt:
* platform/qt/editing/pasteboard/paste-
4038267-fix-expected.png: Added.
* platform/qt/editing/pasteboard/paste-
4038267-fix-expected.txt:
* platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
* platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png: Added.
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-001-expected.png: Added.
* platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-002-expected.png: Added.
* platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-003-expected.png: Added.
* platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-004-expected.png: Added.
* platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-005-expected.png: Added.
* platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-006-expected.png: Added.
* platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-007-expected.png:
* platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-008-expected.png:
* platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-009-expected.png:
* platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-010-expected.png:
* platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/qt/editing/pasteboard/paste-match-style-002-expected.png: Added.
* platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
* platform/qt/editing/pasteboard/paste-table-003-expected.png:
* platform/qt/editing/pasteboard/paste-table-003-expected.txt:
* platform/qt/editing/pasteboard/paste-table-cells-expected.png:
* platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
* platform/qt/editing/pasteboard/paste-text-004-expected.png:
* platform/qt/editing/pasteboard/paste-text-004-expected.txt:
* platform/qt/editing/pasteboard/paste-text-005-expected.png:
* platform/qt/editing/pasteboard/paste-text-005-expected.txt:
* platform/qt/editing/pasteboard/paste-text-006-expected.png: Added.
* platform/qt/editing/pasteboard/paste-text-006-expected.txt:
* platform/qt/editing/pasteboard/paste-text-007-expected.png: Added.
* platform/qt/editing/pasteboard/paste-text-007-expected.txt:
* platform/qt/editing/pasteboard/paste-text-008-expected.png:
* platform/qt/editing/pasteboard/paste-text-008-expected.txt:
* platform/qt/editing/pasteboard/paste-text-009-expected.png:
* platform/qt/editing/pasteboard/paste-text-009-expected.txt:
* platform/qt/editing/pasteboard/paste-text-013-expected.png: Added.
* platform/qt/editing/pasteboard/paste-text-013-expected.txt:
* platform/qt/editing/pasteboard/paste-text-014-expected.png:
* platform/qt/editing/pasteboard/paste-text-014-expected.txt:
* platform/qt/editing/pasteboard/paste-text-016-expected.png: Added.
* platform/qt/editing/pasteboard/paste-text-016-expected.txt:
* platform/qt/editing/pasteboard/paste-text-019-expected.png:
* platform/qt/editing/pasteboard/paste-text-019-expected.txt:
* platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
* platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/qt/editing/pasteboard/pasting-object-expected.png:
* platform/qt/editing/pasteboard/pasting-object-expected.txt:
* platform/qt/editing/pasteboard/quirks-mode-br-1-expected.png: Added.
* platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Added.
* platform/qt/editing/pasteboard/smart-paste-007-expected.png:
* platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
* platform/qt/editing/pasteboard/styled-element-markup-expected.png: Added.
* platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
* platform/qt/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
* platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt:
* platform/qt/editing/pasteboard/unrendered-br-expected.png: Added.
* platform/qt/editing/pasteboard/unrendered-br-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Fri, 27 Jul 2012 11:04:06 +0000 (11:04 +0000)]
Unreviewed. Rolled DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 10:47:15 +0000 (10:47 +0000)]
[EFL][WK2] Keyboard events miss key location data.
https://bugs.webkit.org/show_bug.cgi?id=92235
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-27
Reviewed by Simon Hausmann.
EFL WK2 did not initialize WebKeyboardEvent::m_isKeypad field.
This caused failure of fast/events/keydown-numpad-keys.html test.
* Shared/efl/WebEventFactory.cpp: WebKeyboardEvent::m_isKeypad is initialized.
(WebKit::WebEventFactory::createWebKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 10:44:53 +0000 (10:44 +0000)]
[WK2][EFL][WTR] TestNetscapePlugin is required.
https://bugs.webkit.org/show_bug.cgi?id=88756
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-27
Reviewed by Simon Hausmann.
libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
* CMakeLists.txt:
* DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Fri, 27 Jul 2012 09:55:03 +0000 (09:55 +0000)]
[EFL] Fix wrong return value in EWK_VIEW_XXX macro.
https://bugs.webkit.org/show_bug.cgi?id=92466
Reviewed by Simon Hausmann.
There are wrong return values in EWK_VIEW_XXX macros. The wrong return values
should be fixed. In addition, API description is also modified according to returned
value change.
Source/WebKit/efl:
* ewk/ewk_view.cpp:
(ewk_view_setting_minimum_timer_interval_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_setting_enable_xss_auditor_get):
* ewk/ewk_view.h:
Source/WebKit2:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_uri_set):
(ewk_view_load_progress_get):
(ewk_view_device_pixel_ratio_get):
* UIProcess/API/efl/ewk_view.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Fri, 27 Jul 2012 09:41:55 +0000 (09:41 +0000)]
Unreviewed GTK gardening, adding a text failure expectation for an accessibility
test that started failing after r123767.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 Jul 2012 09:37:51 +0000 (09:37 +0000)]
Add a Setting to expose quantized, rate-limited MemoryInfo values
https://bugs.webkit.org/show_bug.cgi?id=80444
Reviewed by Eric Seidel.
We do not currently expose real MemoryInfo objects to the web unless
the user opts in because we're worried that this memory information
could be used in side-channel attacks.
We've gotten feedback from a number of web app developers that this
information is very useful in tracking the performance of their
applications. These developers use the setting in their testing labs
and regression harnesses to catch memory leaks and regressiosn early in
their development cycle.
Some of these developers have experimented with enabling this feature
within their enterprise and have found the memory data from the field
extremely useful in tracking down memory issues that slip through their
testing.
Based on this experience, they've asked whether we can enable this
functionality on a wider scale so they catch even more problems
including problems that don't manifest within their enterprise.
Because we're still worried about side-channel attacks, we don't want
to expose the raw data, so we've talked with these folks in more detail
to understand what information they find most valuable.
This patch is the result of those discussions. In particular, this
patch adds an option to expose quantized and rate-limited memory
information to web pages. Web pages can only learn new data every 20
minutes, which helps mitigate attacks where the attacker compares two
or readings to extract side-channel information. The patch also only
reports 100 distinct memory values, which (combined with the rate
limts) makes it difficult for attackers to learn about small changes in
memory use.
* page/MemoryInfo.cpp:
(WebCore):
(HeapSizeCache):
(WebCore::HeapSizeCache::HeapSizeCache):
(WebCore::HeapSizeCache::getCachedHeapSize):
(WebCore::HeapSizeCache::maybeUpdate):
(WebCore::HeapSizeCache::update):
(WebCore::HeapSizeCache::quantize):
(WebCore::MemoryInfo::MemoryInfo):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setQuantizedMemoryInfoEnabled):
(WebCore::Settings::quantizedMemoryInfoEnabled):
(Settings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 09:36:18 +0000 (09:36 +0000)]
[chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes).
https://bugs.webkit.org/show_bug.cgi?id=79117
Fix two issues in WebFrameImpl::visiblePositionForWindowPoint.
1) If the point is off-screen, the visiblePosition is clipped to the screen.
- The fix is to add HitTestRequest::IgnoreClipping.
2) The result is incorrect if the point is within an iframe.
- This is because we are calling convertFromContainingWindow twice: once in windowToContents,
and then explicitly as well.
- This patch removes the explicit call to convertFromContainingWindow.
Patch by Oli Lan <olilan@chromium.org> on 2012-07-27
Reviewed by Adam Barth.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Fri, 27 Jul 2012 09:32:24 +0000 (09:32 +0000)]
Unreviewed. Rolled DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 27 Jul 2012 09:26:24 +0000 (09:26 +0000)]
Source/WebCore: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
Moved formatting support from JavaScriptSource to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.searchInContent):
(WebInspector.JavaScriptSource.prototype.formattedChanged):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):
Source/WebKit2: [EFL][WK2] Add unit tests for Ewk_View form client
https://bugs.webkit.org/show_bug.cgi?id=92468
Reviewed by Simon Hausmann.
Add unit test for form client functionality in
Ewk_View.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onFormAboutToBeSubmitted):
(TEST_F):
LayoutTests: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
* inspector/debugger/script-formatter.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 27 Jul 2012 08:50:31 +0000 (08:50 +0000)]
Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
Source/WebCore:
Moved formatting support from JavaScriptSource to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.searchInContent):
(WebInspector.JavaScriptSource.prototype.formattedChanged):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):
LayoutTests:
* inspector/debugger/script-formatter.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 08:41:19 +0000 (08:41 +0000)]
[EFL] Memory leaks in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=92347
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27
Reviewed by Simon Hausmann.
Fix a memory leak in EFL's DRT code by adopting an allocation
of JSString created with JSStringCreateWithUTF8CString.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 08:34:14 +0000 (08:34 +0000)]
Page object should ascertain EditorClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92458
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Ryosuke Niwa.
The EditorClient should always be available in Page object. Added the assertion to ascertain this.
No new tests. Added assertion to make sure EditorClient always exist.
* page/Page.cpp:
(WebCore::Page::Page):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Fri, 27 Jul 2012 08:28:51 +0000 (08:28 +0000)]
[Qt] Unreviewed, rebaseline for tests introduced in r123790
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.
* platform/qt/css3/filters/effect-brightness-clamping-expected.png: Added.
* platform/qt/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/qt/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
* platform/qt/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 08:25:36 +0000 (08:25 +0000)]
Gather the duplicated timer code into CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=92332
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-27
Reviewed by Nate Chapin.
Internal review by Jae Hyun Park.
When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.
No new tests - no new testable functionality.
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
* loader/cache/CachedScript.h:
(CachedScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 07:56:34 +0000 (07:56 +0000)]
[EFL] Change prototype of run_open_panel
https://bugs.webkit.org/show_bug.cgi?id=91956
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.
In order to support all of the file chooser attributes,
change the types of parameters in run_open_panel method.
i.e., change "Eina_Bool allows_multiple_files, Eina_List *accept_types"
to "Ewk_File_Chooser *file_chooser"
In addition, Efl can support the capture attribute for HTML media capture.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runOpenPanel):
* ewk/ewk_view.cpp:
(ewk_view_run_open_panel):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 Jul 2012 07:51:54 +0000 (07:51 +0000)]
Writing a blog post for new reviewers doesn't add value to the blog
https://bugs.webkit.org/show_bug.cgi?id=92305
Reviewed by Eric Seidel.
Now that we have Peter posting weekly updates to the blog, having an
announcement on the blog for each reviewer is more noise than signal.
* coding/commit-review-policy.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 27 Jul 2012 07:48:04 +0000 (07:48 +0000)]
Simplify ExpectedFailures
https://bugs.webkit.org/show_bug.cgi?id=92216
Reviewed by Eric Seidel.
This patch simplifies the ExpectedFailures class we use to remember
which tests are currently failing on the bots. When we wrote this code
originally, we weren't entirely sure how it would work. Now that we
understand it more clearly, we can write the code more clearly.
* Scripts/webkitpy/tool/bot/expectedfailures.py:
(_has_failures):
(_is_trustworthy):
(ExpectedFailures.__init__):
(ExpectedFailures.failures_were_expected):
(ExpectedFailures.unexpected_failures_observed):
(ExpectedFailures.update):
* Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
(ExpectedFailuresTest._assert_can_trust):
(ExpectedFailuresTest.test_failures_were_expected):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Fri, 27 Jul 2012 07:44:19 +0000 (07:44 +0000)]
[chromium] Don't add a HUD layer when there is no rootLayer
https://bugs.webkit.org/show_bug.cgi?id=92442
Reviewed by Adrienne Walker.
When the compositor is shutting down in threaded mode, it does a commit
without a root layer. We should not try stick the hud layer onto the
null root layer.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::willCommit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 07:30:27 +0000 (07:30 +0000)]
IndexedDB: inject index keys on cursor/objectstore/index get success handlers
https://bugs.webkit.org/show_bug.cgi?id=91123
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-27
Reviewed by Tony Chang.
Source/WebCore:
Move key-injection into the frontend, by injecting the key into
the value on get rather than set for autoincremented keys. This
gives a potential performance win by avoiding an IPC call to the
V8 utility process on chromium, and generally cleans up the key
management.
Note that this duplicates the logic of generateIndexKeys into the
frontend until that method can be expunged from the backend. This
will be cleaned up in a later patch.
In order to account for both old data (which has the duplicate
primary key already injected and serialized) and any new data, an
assertion was removed from IDBBindingUtilities.
This also includes some minor refactoring such as the deprecation
of IDBCursorBackendInterface::update in favor of a direct call to
IDBObjectStoreBackendImpl::put, and removal of the now-defunct
IDBBackingStore::getObjectViaIndex.
Tests: storage/indexdb/index-duplicate-keypaths.html
* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore):
Source/WebKit/chromium:
Remove method no longer used.
* tests/IDBFakeBackingStore.h:
LayoutTests:
One new test to make sure that indexes with the same keypath as an
autoIncrement'ed objectStore still index their values. Also minor
tweaks to tests to make it easier to figure out which key is being
updated.
* storage/indexeddb/index-duplicate-keypaths-expected.txt: Added.
* storage/indexeddb/index-duplicate-keypaths.html: Added.
* storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
* storage/indexeddb/mozilla/resources/autoincrement-indexes.js:
* storage/indexeddb/resources/index-duplicate-keypaths.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 27 Jul 2012 07:27:44 +0000 (07:27 +0000)]
changing -webkit-order should change the paint order of flex items
https://bugs.webkit.org/show_bug.cgi?id=92041
Reviewed by Ojan Vafai.
Source/WebCore:
Override paintChildren and use the flex order iterator to determine the order to paint the children.
Test: css3/flexbox/order-painting.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Save a reference to the order iterator.
(WebCore::RenderFlexibleBox::paintChildren):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Hold a reference to the order iterator so we don't have to recreate it at paint time.
Also mark all the virtual methods with OVERRIDE.
LayoutTests:
Use a ref test since this is testing paint behavior.
* css3/flexbox/order-painting-expected.html: Added.
* css3/flexbox/order-painting.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 27 Jul 2012 07:10:06 +0000 (07:10 +0000)]
[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=88064
Reviewed by Zoltan Herczeg.
Source/WebKit/qt:
Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
Use resetInternalsObject() instead of injectInternalsObject().
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
LayoutTests:
* platform/qt-5.0-wk2/Skipped: Unskip now passing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 27 Jul 2012 06:35:38 +0000 (06:35 +0000)]
Unreviewed, rolling out r123820.
http://trac.webkit.org/changeset/123820
https://bugs.webkit.org/show_bug.cgi?id=92465
It made all tests crash on all port (Requested by Ossy_home on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26
* dom/EventNames.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 27 Jul 2012 06:21:54 +0000 (06:21 +0000)]
Qt build fix after r123788. Fixed the typo.
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::handleElementAttributes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hbono@chromium.org [Fri, 27 Jul 2012 05:53:00 +0000 (05:53 +0000)]
[Qt] Build fix for Qt after r123811
https://bugs.webkit.org/show_bug.cgi?id=92460
Reviewed by Ryosuke Niwa.
This change explicitly converts from AtomicString to String to avoid ambiguities
when compiling HTMLAppletWidget.cpp on Qt.
No new tests because it is a build fix.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Fri, 27 Jul 2012 04:32:08 +0000 (04:32 +0000)]
Make transitions work between different Length types
https://bugs.webkit.org/show_bug.cgi?id=92220
Reviewed by Simon Fraser.
Source/WebCore:
Use the existing CSS calc machinery for blending between two calculations
to blend between two Lengths of differing types.
Test: transitions/mixed-type.html
* platform/Length.cpp:
(WebCore::Length::blendMixedTypes):
* platform/Length.h:
(WebCore::Length::blend):
(Length):
LayoutTests:
* transitions/mixed-type-expected.txt: Added.
* transitions/mixed-type.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Fri, 27 Jul 2012 04:07:48 +0000 (04:07 +0000)]
[Tests] Rename fast/forms/{number,time}/*-validity-state-* to *-validity-*
https://bugs.webkit.org/show_bug.cgi?id=92449
Reviewed by Kent Tamura.
This patch renames test files in fast/forms/{number,time} for matching
with IDL attribute names.
* fast/forms/number/number-validity-rangeoverflow-expected.txt: Copied from LayoutTests/fast/forms/number/number-validitystate-range-overflow-expected.txt.
* fast/forms/number/number-validity-rangeoverflow.html: Copied from LayoutTests/fast/forms/number/number-validitystate-range-overflow.html.
* fast/forms/number/number-validity-rangeunderflow-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-range-underflow-expected.txt.
* fast/forms/number/number-validity-rangeunderflow.html: Copied from LayoutTests/fast/forms/number/number-validity-state-range-underflow.html.
* fast/forms/number/number-validity-state-range-underflow-expected.txt: Removed.
* fast/forms/number/number-validity-state-range-underflow.html: Removed.
* fast/forms/number/number-validity-state-step-mismatch-expected.txt: Removed.
* fast/forms/number/number-validity-state-step-mismatch.html: Removed.
* fast/forms/number/number-validity-state-type-mismatch-expected.txt: Removed.
* fast/forms/number/number-validity-state-type-mismatch.html: Removed.
* fast/forms/number/number-validity-stepmismatch-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-step-mismatch-expected.txt.
* fast/forms/number/number-validity-stepmismatch.html: Copied from LayoutTests/fast/forms/number/number-validity-state-step-mismatch.html.
* fast/forms/number/number-validity-typemismatch-expected.txt: Copied from LayoutTests/fast/forms/number/number-validity-state-type-mismatch-expected.txt.
* fast/forms/number/number-validity-typemismatch.html: Copied from LayoutTests/fast/forms/number/number-validity-state-type-mismatch.html.
* fast/forms/number/number-validitystate-range-overflow-expected.txt: Removed.
* fast/forms/number/number-validitystate-range-overflow.html: Removed.
* fast/forms/time/time-validity-rangeoverflow-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-range-overflow-expected.txt.
* fast/forms/time/time-validity-rangeoverflow.html: Copied from LayoutTests/fast/forms/time/time-validity-state-range-overflow.html.
* fast/forms/time/time-validity-rangeunderflow-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-range-underflow-expected.txt.
* fast/forms/time/time-validity-rangeunderflow.html: Copied from LayoutTests/fast/forms/time/time-validity-state-range-underflow.html.
* fast/forms/time/time-validity-state-range-overflow-expected.txt: Removed.
* fast/forms/time/time-validity-state-range-overflow.html: Removed.
* fast/forms/time/time-validity-state-range-underflow-expected.txt: Removed.
* fast/forms/time/time-validity-state-range-underflow.html: Removed.
* fast/forms/time/time-validity-state-step-mismatch-expected.txt: Removed.
* fast/forms/time/time-validity-state-step-mismatch.html: Removed.
* fast/forms/time/time-validity-state-type-mismatch-expected.txt: Removed.
* fast/forms/time/time-validity-state-type-mismatch.html: Removed.
* fast/forms/time/time-validity-stepmismatch-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-step-mismatch-expected.txt.
* fast/forms/time/time-validity-stepmismatch.html: Copied from LayoutTests/fast/forms/time/time-validity-state-step-mismatch.html.
* fast/forms/time/time-validity-typemismatch-expected.txt: Copied from LayoutTests/fast/forms/time/time-validity-state-type-mismatch-expected.txt.
* fast/forms/time/time-validity-typemismatch.html: Copied from LayoutTests/fast/forms/time/time-validity-state-type-mismatch.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 27 Jul 2012 03:48:18 +0000 (03:48 +0000)]
Blocks with reverse column progression don’t have layout overflow for overflowing columns
https://bugs.webkit.org/show_bug.cgi?id=92440
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/multicol/progression-reverse-overflow.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow): If column progression is reversed, then allow
layout overflow to go in the opposite direction than it would normally be allowed to go.
For example, in a block with writing-mode: horizontal-tb, direction: ltr and
column-progression: reverse, columns overflow to the left, so layout overflow would go on
the left.
LayoutTests:
* fast/multicol/progression-reverse-overflow-expected.html: Added.
* fast/multicol/progression-reverse-overflow.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 27 Jul 2012 03:24:09 +0000 (03:24 +0000)]
When Safari 6 is launched via the WebKit Xcode workspace, it does not link against the built frameworks
https://bugs.webkit.org/show_bug.cgi?id=92331
Reviewed by Mark Rowe.
Changed references to the Safari executable to the SafariForWebKitDevelopment binary.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 27 Jul 2012 03:21:46 +0000 (03:21 +0000)]
Implement ColorSuggestionPicker page popup
https://bugs.webkit.org/show_bug.cgi?id=92109
Reviewed by Kent Tamura.
.:
* ManualTests/forms/color-suggestion-picker.html: Added. Tests colorSuggestionPicker.{js,css}
Source/WebCore:
Implements ColorSuggestionPicker page popup. This will be used in
certain ports as the datalist UI for <input type=color>.
No new tests because there is no way to open the popup yet.
* Resources/colorSuggestionPicker.css: Added.
(body):
(#main):
(.color-swatch):
(.color-swatch:hover):
(.color-swatch-container):
(.other-color):
* Resources/colorSuggestionPicker.js: Added.
(getScrollbarWidth):When there are more than 20 colors we need to
increase the window width to accommodate the scroll bar.
(createElement):
(handleMessage):
(initialize):
(handleArgumentsTimeout):
(validateArguments):
(submitValue): Calls setValueAndClosePopup with a numValue of 0.
(handleCancel): Calls setValueAndClosePopup with a numValue of -1.
(chooseOtherColor): Calls setValueAndClosePopup with a numValue of -2.
(ColorPicker):
(ColorPicker.prototype._layout): Lays out the color swatches in a 5x4
grid.
(ColorPicker.prototype._handleSwatchClick):
* WebCore.gyp/WebCore.gyp: Added ColorSuggestionPicker action.
* make-file-arrays.py:
(main): Windows gets confused when "&&" is in the command, so we will replace " AND " with " && " internally.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Fri, 27 Jul 2012 02:49:04 +0000 (02:49 +0000)]
[EFL] Remove forwarding headers from MiniBrowser/Efl.
https://bugs.webkit.org/show_bug.cgi?id=91627
Reviewed by Kentaro Hara.
* MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 02:41:31 +0000 (02:41 +0000)]
[EFL] Highlight the element under mouse on web inspector
https://bugs.webkit.org/show_bug.cgi?id=91592
Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-26
Reviewed by Kentaro Hara.
Implement highlighting the nodes when using the web inspector.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::highlight):
(WebCore::InspectorClientEfl::hideHighlight):
(WebCore::InspectorClientEfl::invalidateView):
(WebCore):
* WebCoreSupport/InspectorClientEfl.h:
(InspectorClientEfl):
* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint_contents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 02:30:31 +0000 (02:30 +0000)]
De-virtualize WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=90998
Patch by Anish Bhayani <anish.bhayani@gmail.com> on 2012-07-26
Reviewed by Andreas Kling.
The destructor for WrapShapes classes did not need to use a virtual
pointer. WrapShapes.cpp is created to cast the WrapShape destructor
to the subclass type saving memory and avoiding virtual calls.
There are existing tests that cover the validity of shapes. The
added changes merely change the destructor of the shape objects
which is also tested by LayoutTests/fast/exclusions.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/style/WrapShapes.cpp: Added.
(WebCore):
(WebCore::WrapShape::destroy):
* rendering/style/WrapShapes.h:
(WebCore::WrapShape::deref):
(WrapShape):
(WebCore::WrapShape::type):
(WebCore::WrapShape::setType):
(WrapShapeRectangle):
(WebCore::WrapShapeRectangle::WrapShapeRectangle):
(WebCore::WrapShapeCircle::WrapShapeCircle):
(WebCore::WrapShapeEllipse::WrapShapeEllipse):
(WebCore::WrapShapePolygon::WrapShapePolygon):
(WrapShapePolygon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 01:48:24 +0000 (01:48 +0000)]
Unreviewed, rolling out r123808.
http://trac.webkit.org/changeset/123808
https://bugs.webkit.org/show_bug.cgi?id=92443
Broke Apple Mac debug tests ASSERTION FAILED: !hasClients()
(Requested by msaboff_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):
(WebCore):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::decodedDataDeletionTimerFired):
(WebCore):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::didAddClient):
(WebCore):
(WebCore::CachedScript::allClientsRemoved):
(WebCore::CachedScript::decodedDataDeletionTimerFired):
* loader/cache/CachedScript.h:
(CachedScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 27 Jul 2012 01:41:48 +0000 (01:41 +0000)]
[chromium] Remove some unreachable code in ClipboardChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=92427
Reviewed by Adam Barth.
convertURIListToURL does the same thing (implementation in ClipboardUtilitiesChromium.*).
No new tests, just deleting unused code.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::getData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 01:28:51 +0000 (01:28 +0000)]
Implement undoscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=88793
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-26
Reviewed by Ryosuke Niwa.
Source/WebCore:
undoscope attribute support as specified at
http://dvcs.w3.org/hg/undomanager/raw-file/tip/undomanager.html
Test: editing/undomanager/undoscope-attribute.html
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Element.cpp:
(WebCore):
(WebCore::Element::undoScope):
(WebCore::Element::setUndoScope):
(WebCore::Element::undoManager):
(WebCore::Element::disconnectUndoManager):
(WebCore::Element::disconnectUndoManagersInSubtree):
* dom/Element.h:
(Element):
* dom/Element.idl:
* dom/ElementRareData.h:
(ElementRareData):
* editing/UndoManager.cpp:
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore):
(WebCore::UndoManager::clearRedo):
(WebCore::UndoManager::clearUndoRedo):
(WebCore::UndoManager::isConnected):
* editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::length):
* editing/UndoManager.idl:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::setContentEditable):
LayoutTests:
* editing/undomanager/undoscope-attribute-expected.txt: Added.
* editing/undomanager/undoscope-attribute.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Fri, 27 Jul 2012 01:27:06 +0000 (01:27 +0000)]
[Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
https://bugs.webkit.org/show_bug.cgi?id=92339
Reviewed by Kent Tamura.
Source/WebCore:
To detect compilation errors and test failure earlier, I would like
build and run tests for input type datetime, datetime-local, month,
time and week with runtime feature flags to avoid behavior changes
other than test shell.
This patch adds runtime features for input types, datetime, datetime-local,
month, time and week and integrates them into InputType::createInputTypeFactoryMap
to follow runtime feature flags.
At this time, these runtime features are enabled by default for all
ports define ENABLE_INPUT_TYPE_XXX except for Chromium port other than
Android. I'll remove these #if after I update Chromium browser for
disabling them for non-Android.
No new tests. Enabling disabled tests (fast/forms/datetime, fast/forms/dattimelocal,
fast/forms/month, fast/forms/time, fast/forms/week)
* bindings/generic/RuntimeEnabledFeatures.cpp: Added initializations of
variables for runtime features of input types.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled): Added.
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled): Added.
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap): Register input types datetime,
datetime-local, month, time and week if corresponding runtime feature
flag is enabled.
* html/InputType.h: Changed indentation to force building *InputType.cpp for
making Chromium-win bots to be happy.
Source/WebKit/chromium:
To detect compilation errors and test failure earlier, I would like
build and run tests for input type datetime, datetime-local, month,
time and week with runtime feature flags to avoid behavior changes
on chromium browser.
This patch adds query and change functions for runtime features of
input type datetime, datetime-local, month, time and week to WebRuntimeFeatures
class for exposing DRT and chromium browser expermental flags.
* features.gypi: Turn on ENABLE_INPUT_TYPE_DATETIME, ENABLE_INPUT_TYPE_DATETIMELOCAL,
ENABLE_INPUT_TYPE_MONTH, ENABLE_INPUT_TYPE_TIME, and ENABLE_INPUT_TYPE_WEEK for all OS.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableInputTypeDateTime): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeDateTimeLocal): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeLocalEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeMonth): Added.
(WebKit::WebRuntimeFeatures::isInputTypeMonthEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeTime): Added.
(WebKit::WebRuntimeFeatures::isInputTypeTimeEnabled): Added.
(WebKit::WebRuntimeFeatures::enableInputTypeWeek): Added.
(WebKit::WebRuntimeFeatures::isInputTypeWeekEnabled): Added.
Tools:
This patch enables runtime features for input type datetime, datetime-local,
month, time and week for Chromium DRT.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
LayoutTests:
This patch enables tests for input type datetime, datetime-local,
month, time and week for Chromium ports.
* platform/chromium/TestExpectations: Removed disabled directives for
input type datetime, datetime-local, month, time and week.
* platform/chromium/fast/forms/datalist/input-list-expected.txt: Updated
expecations for input type datetime, datetime-local, month, time and week
to null for IDL list attribute. So far, these expectations specified
HTMLDataListElement for input type "text" as unsupported input types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wangxianzhu@chromium.org [Fri, 27 Jul 2012 01:07:39 +0000 (01:07 +0000)]
[Chromium-Android] Don't overlay scrollbars in layout test mode
https://bugs.webkit.org/show_bug.cgi?id=92419
Reviewed by Adam Barth.
No new tests. This fixes failures of existing tests, e.g. css1/box_properties/border.html and many others.
* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars): Returns false in layout test mode.
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb): Returns false in layout test mode (to match pixel test expectations).
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 27 Jul 2012 01:00:42 +0000 (01:00 +0000)]
Unreviewed rebaseline after r123790.
* platform/mac/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/mac/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpfau@apple.com [Fri, 27 Jul 2012 00:52:32 +0000 (00:52 +0000)]
Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
https://bugs.webkit.org/show_bug.cgi?id=84041
Reviewed by Brady Eidson.
Source/WebCore:
Previously, loadAlternateHTMLString:baseURL:forUnreachableURL: would insert a new history item, regardless of
the load type of the original frame load. This could cause navigation to a broken website to make back and
forward navigation difficult to use. This change ensures that a reload type makes it through all the way.
Added API test 'mac/BackForwardList.mm'.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load): Prevent m_loadType from being overwritten early and check if it's a reload.
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForCommit): Amend check when committing the provisional item for a reload.
(WebCore::HistoryController::isReloadTypeWithProvisionalItem): Check that a reload type has a provisional item.
(WebCore):
* loader/HistoryController.h:
(HistoryController): Add prototype for isReloadTypeWithProvisionalItem.
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
(-[BackForwardListTest webView:didFinishLoadForFrame:]):
(-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 00:48:15 +0000 (00:48 +0000)]
[Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType
https://bugs.webkit.org/show_bug.cgi?id=91333
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-07-26
Reviewed by Eric Seidel.
Source/WebCore:
MediaControlChromiumEnclosureElement now is a subclass of MediaControlElement, which
fixes the broken cast detected in the bug.
The displayType() of MediaControlChromiumEnclosureElement is set to 'MediaControlsPanel',
since the Panel element is sufficiently close in functionality to the Enclosure element.
By reusing this type, we do not need to introduce a Chromium-specific constant into
the generally used MediaControlElementType.
Test: accessibility/media-controls.html
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
Subclass MediaControlChromiumEnclosureElement from MediaControlElement.
(WebCore::MediaControlChromiumEnclosureElement::displayType):
Give the enclosure the MediaPanels type.
* html/shadow/MediaControlRootElementChromium.h:
Add the MediaControlElement.h header file.
(MediaControlChromiumEnclosureElement):
Subclass MediaControlChromiumEnclosureElement from MediaControlElement.
LayoutTests:
This new test assures that the creation of a audio element with controls does not
break when accessibility is turned on.
* accessibility/media-controls-expected.txt: Added.
* accessibility/media-controls.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 00:41:55 +0000 (00:41 +0000)]
[GTK] avoid unneeded object creation when calling Vector::append
https://bugs.webkit.org/show_bug.cgi?id=88805
Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-26
Reviewed by Alexey Proskuryakov.
No new tests: no change in functionality.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::contextMenuItemVector):
* platform/gtk/KeyBindingTranslator.h:
(WebCore::KeyBindingTranslator::addPendingEditorCommand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 27 Jul 2012 00:34:48 +0000 (00:34 +0000)]
Initialize the Event Names' strings from read only memory
https://bugs.webkit.org/show_bug.cgi?id=92435
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-26
Reviewed by Anders Carlsson.
Similarily to r123689, we can initialize the event names' strings from memory without copying the data.
This saves us memory and initialization time.
* dom/EventNames.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 00:25:04 +0000 (00:25 +0000)]
constructing TypedArray from another TypedArray is slow
https://bugs.webkit.org/show_bug.cgi?id=90838
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-26
Reviewed by Kenneth Russell.
PerformanceTests:
* Bindings/typed-array-construct-from-same-type.html: Added.
* Bindings/typed-array-construct-from-typed.html: Added.
Source/WebCore:
When constructing a typed array from an array like element, try to
determine if the argument is a typed array. If so, cast the argument
to a typed array, and read each element with .item() method. That
avoid reading the value as a JSValue, and speedups construction by
approximatively 3x (even 30x if TypedArrays are both the same type).
In order to achieve that, we use virtual getType method. We can use
this information to cast the TypedArray to the actual type, and then
read the values from the source.
Introduce constructArrayBufferViewWithTypedArrayArgument template
function which returns a new typed array if first argument is a typed
array, or 0 otherwise.
This patch also replaces previous is<Type>Array() calls with new
getType method.
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore):
(WebCore::constructArrayBufferView):
* bindings/v8/SerializedScriptValue.cpp:
* html/canvas/DataView.h:
(DataView):
(WebCore::DataView::getType):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::validateTexFuncData):
* page/Crypto.cpp:
Source/WTF:
Introduce virtual method getType on ArrayBufferView. It returns the actual
type of the view. This method replaces previous is<Type>Array() methods.
* wtf/ArrayBufferView.h:
* wtf/Float32Array.h:
(WTF::Float32Array::getType):
(Float32Array):
* wtf/Float64Array.h:
(WTF::Float64Array::getType):
(Float64Array):
* wtf/Int16Array.h:
(WTF::Int16Array::getType):
(Int16Array):
* wtf/Int32Array.h:
(WTF::Int32Array::getType):
(Int32Array):
* wtf/Int8Array.h:
(WTF::Int8Array::getType):
(Int8Array):
* wtf/IntegralTypedArrayBase.h:
* wtf/TypedArrayBase.h:
(TypedArrayBase):
(WTF::TypedArrayBase::item):
* wtf/Uint16Array.h:
(WTF::Uint16Array::getType):
(Uint16Array):
* wtf/Uint32Array.h:
(WTF::Uint32Array::getType):
(Uint32Array):
* wtf/Uint8Array.h:
(WTF::Uint8Array::getType):
(Uint8Array):
* wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::getType):
(Uint8ClampedArray):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 00:22:59 +0000 (00:22 +0000)]
Added binding and updated chromium tests.
[CSS Filters] Add V8 binding for WebKitCSSFilterValue
https://bugs.webkit.org/show_bug.cgi?id=92391
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-26
Reviewed by Adam Barth.
Source/WebCore:
No new tests. This fixes test cases in:
platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt
platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt
platform/chromium/css3/filters/filter-property-computed-style-expected.txt
platform/chromium/css3/filters/filter-property-parsing-expected.txt
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
LayoutTests:
* platform/chromium-linux/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
Removed. The chromium-linux expectations are (and were) exactly the same as the chromium expectations.
* platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
Removed. Ditto.
* platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-expected.txt:
Removed. Ditto.
* platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
Many test cases are now expected to pass instead of fail.
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
Ditto.
* platform/chromium/css3/filters/filter-property-computed-style-expected.txt:
Removed. We can use the platform-independent results now.
* platform/chromium/css3/filters/filter-property-parsing-expected.txt:
Many test cases are now expected to pass instead of fail.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 27 Jul 2012 00:11:44 +0000 (00:11 +0000)]
JSObject::reallocateStorageIfNecessary is neither used nor defined
https://bugs.webkit.org/show_bug.cgi?id=92417
Reviewed by Mark Rowe.
* runtime/JSObject.h:
(JSObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nayankk@motorola.com [Fri, 27 Jul 2012 00:05:53 +0000 (00:05 +0000)]
[WebGL] Initial size of canvas can be larger than MAX_VIEWPORT_DIMS.
https://bugs.webkit.org/show_bug.cgi?id=91976
Reviewed by Kenneth Russell.
From section 2.2 of the spec the WebGL implementation says initial size of
the canvas can be larger than MAX_VIEWPORT_DIMS. With the current WebGL
implementation, we get error when initial size if greater than MAX_VIEWPORT_DIMS.
This change limits the width and height of drawingbuffer to MAX_VIEWPORT_DIMS
when given initial size exceeds it.
Source/WebCore:
Added tests to LayoutTests/fast/canvas/webgl/drawingbuffer-test.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
LayoutTests:
* fast/canvas/webgl/drawingbuffer-test-expected.txt:
* fast/canvas/webgl/drawingbuffer-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 27 Jul 2012 00:01:08 +0000 (00:01 +0000)]
[BlackBerry] Remove synchronous spellchecking code
https://bugs.webkit.org/show_bug.cgi?id=92415
Removing synchronous spellchecking code path.
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
* Api/WebPageClient.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 26 Jul 2012 23:55:10 +0000 (23:55 +0000)]
[chromium] When computing surface content scale, use top level device scale
https://bugs.webkit.org/show_bug.cgi?id=92328
Reviewed by Kenneth Russell.
Previously, surface scale was calculated with layer->contentsScale(),
however this value is 1 for any layer that is not ContentLayerChromium
because of layer->needsContentsScale(). This would cause any surface
created with a non-content owner layer to look fuzzy on a high DPI
device. Fix by using the top level device scale.
Additionally, remove contentsScale from CCLayerImpl as it is no longer
used.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Thu, 26 Jul 2012 23:27:53 +0000 (23:27 +0000)]
Allocate Structures in a separate part of the Heap
https://bugs.webkit.org/show_bug.cgi?id=92420
Reviewed by Filip Pizlo.
To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate
part of the Heap that will be swept after all other objects. This first patch will just be separating Structures
out into their own separate MarkedAllocator. Everything else will behave identically.
* heap/Heap.h: New function to allocate Structures in the Heap.
(Heap):
(JSC):
(JSC::Heap::allocateStructure):
* heap/MarkedAllocator.cpp: Pass whether or not we're allocated Structures to the MarkedBlock.
(JSC::MarkedAllocator::allocateBlock):
* heap/MarkedAllocator.h: Add tracking for whether or not we're allocating only Structures.
(JSC::MarkedAllocator::onlyContainsStructures):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::init):
* heap/MarkedBlock.cpp: Add tracking for whether or not we're allocating only Structures. We need this to be able to
distinguish the various MarkedBlock types in MarkedSpace::allocatorFor(MarkedBlock*).
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::onlyContainsStructures):
(JSC):
* heap/MarkedSpace.cpp: Include the new Structure allocator in all the places that all the other allocators are used/modified.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::MarkedSpace::isPagedOut):
* heap/MarkedSpace.h: Add new MarkedAllocator just for Structures.
(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocateStructure):
(JSC):
(JSC::MarkedSpace::forEachBlock):
* runtime/Structure.h: Move all of the functions that call allocateCell<Structure> down below the explicit template specialization
for allocateCell<Structure>. The new inline specialization for allocateCell directly calls the allocateStructure() function in the
Heap.
(Structure):
(JSC::Structure):
(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Thu, 26 Jul 2012 23:10:19 +0000 (23:10 +0000)]
Unreviewed chromium expectations update for table-row-outline-paint.html from r123793.
* platform/chromium-mac/fast/table/table-row-outline-paint-expected.png: Added.
* platform/chromium-win/fast/table/table-row-outline-paint-expected.png: Added.
* platform/chromium/fast/table/table-row-outline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/table/table-row-outline-paint-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 26 Jul 2012 23:08:49 +0000 (23:08 +0000)]
HTMLAppletElement should inherit from HTMLPlugInImageElement
https://bugs.webkit.org/show_bug.cgi?id=92320
Reviewed by Eric Seidel.
In order to simplify the class hierarchy and eventually merge HTMLPlugInImageElement and HMTLPlugInElement,
make HTMLAppletElement inherit from HTMLPlugInImageElement. While this does mean that HTMLAppletElement will grow by
a couple of words, in practice it won't matter.
Also, make RenderApplet inherit from RenderEmbeddedObject and move the plug-in instantiation to HTMLAppletElement which matches
both HTMLEmbedElement and HTMLObjectElement.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
(WebCore::HTMLAppletElement::parseAttribute):
(WebCore::HTMLAppletElement::rendererIsNeeded):
(WebCore::HTMLAppletElement::createRenderer):
(WebCore):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
(WebCore::HTMLAppletElement::updateWidget):
* html/HTMLAppletElement.h:
(HTMLAppletElement):
* html/HTMLTagNames.in:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
* loader/SubframeLoader.h:
(SubframeLoader):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::RenderApplet):
* rendering/RenderApplet.h:
(RenderApplet):
* rendering/RenderEmbeddedObject.h:
(WebCore::toRenderEmbeddedObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 Jul 2012 23:06:44 +0000 (23:06 +0000)]
Unreviewed, rolling out r123799.
http://trac.webkit.org/changeset/123799
https://bugs.webkit.org/show_bug.cgi?id=92431
broke the Apple Mac build (Requested by bweinstein on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/GestureEvent.cpp: Removed.
* dom/GestureEvent.h: Removed.
* dom/Node.cpp:
* dom/Node.h:
(WebCore):
(Node):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
* page/EventHandler.h:
Source/WebKit/chromium:
* src/WebInputEventConversion.cpp:
(WebKit):
* src/WebInputEventConversion.h:
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
Tools:
* DumpRenderTree/chromium/TestWebPlugin.cpp:
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin::handleInputEvent):
LayoutTests:
* platform/chromium/plugins/gesture-events-expected.txt: Removed.
* platform/chromium/plugins/gesture-events.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 Jul 2012 23:05:02 +0000 (23:05 +0000)]
[BlackBerry] Support async spellcheck for the blackberry port
https://bugs.webkit.org/show_bug.cgi?id=92160
Source/WebCore:
Set USE_UNIFIED_TEXT_CHECKING for PLATFORM(BLACKBERRY) to use the
asynchronous spellchecking code path.
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
* platform/text/TextChecking.h:
(WebCore):
Source/WebKit/blackberry:
PR124517
Implementing support for async spellcheck.
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestCancelled):
(WebKit):
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebPage.h:
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isAsynchronousSpellCheckingEnabled):
(BlackBerry::WebKit::WebSettings::setAsynchronousSpellCheckingEnabled):
* Api/WebSettings.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::checkTextOfParagraph):
* WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::convertTransactionIdToSequenceId):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):
* WebKitSupport/InputHandler.h:
(WebCore):
(InputHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Thu, 26 Jul 2012 23:03:40 +0000 (23:03 +0000)]
Gather the duplicated timer code into CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=92332
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-26
Reviewed by Nate Chapin.
Internal review by Jae Hyun Park.
When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.
No new tests - no new testable functionality.
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
* loader/cache/CachedScript.h:
(CachedScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 26 Jul 2012 23:01:05 +0000 (23:01 +0000)]
JSArray has methods that are neither used nor defined
https://bugs.webkit.org/show_bug.cgi?id=92416
Reviewed by Simon Fraser.
* runtime/JSArray.h:
(JSArray):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
piman@chromium.org [Thu, 26 Jul 2012 23:00:18 +0000 (23:00 +0000)]
Unreviewed, rebaseline for tests introduced in r123790
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png: Added.
* platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 26 Jul 2012 23:00:08 +0000 (23:00 +0000)]
nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
https://bugs.webkit.org/show_bug.cgi?id=92172
Reviewed by Tony Chang.
Right now new-run-webkit-tests --verbose prints out too much
information (it's like --verbose + debugging). I plan to fix
this in bug 88702, and also clean up and simplify all of the
--print options, but in preparation for these changes I need to
pass --verbose twice to get the same level of output
temporarily (for compatibility).
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Thu, 26 Jul 2012 22:41:04 +0000 (22:41 +0000)]
Use the constant count of Tags/Attributes names instead of getting the size when obtaining the tags/attributes
https://bugs.webkit.org/show_bug.cgi?id=92411
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-26
Reviewed by Julien Chaffraix.
Since r123582, the number of tags and attributes per "namespace" is exposed in a constant in the header file.
This makes it possible to access this value through two ways:
1) The constant.
2) The first parameter of the tags/attributes getter function.
Having two ways to access the value is error prone. This patches changes the code to have all accesses done
through the constant.
* dom/make_names.pl:
(printNamesHeaderFile):
(printNamesCppFile):
Change the code generator to not provide the size in the getter function.
* html/HTMLObjectElement.cpp:
(WebCore::isRecognizedTagName):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::adjustSVGTagNameCase):
(WebCore):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::adjustForeignAttributes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
igor.o@sisa.samsung.com [Thu, 26 Jul 2012 22:40:35 +0000 (22:40 +0000)]
[Qt] Reskip fast/table WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91621
Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com>
Reviewed by Noam Rosenthal.
This patch reverts the added WK2 layout test results from r123229 "[Qt]
Added/updated missing fast/table results after rebaseline". As discussed with
Caio, these expectations are actually caused by an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990). These
tests were reskipped and reassigned to proper bugs.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Thu, 26 Jul 2012 22:31:25 +0000 (22:31 +0000)]
[Chromium] Removing http/tests/media/media-source/video-media-source-add-and-remove-ids.html from TestExpectations
Unreviewed gardening.
Recent chromium patch fixes this problem:
http://src.chromium.org/viewvc/chrome?view=rev&revision=148473
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
igor.o@sisa.samsung.com [Thu, 26 Jul 2012 22:22:08 +0000 (22:22 +0000)]
[Qt] Reskip fast/text WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91570
Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com>
Unreviewed gardening.
This patch reverts the added WK2 layout test results from r123144 "[Qt]
Added/updated missing fast/text results after rebaseline". As discussed with
Caio, these expectations are actually caused by an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990). These
tests were reskipped and reassigned to proper bugs.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 Jul 2012 22:15:56 +0000 (22:15 +0000)]
Support constructor-type static readonly attribute for CodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=92413.
Patch by Chang Shu <cshu@webkit.org> on 2012-07-26
Reviewed by Adam Barth.
Added support for constructor-type static readonly attribute for CodeGenerator.
This is achieved by putting the attribute entry in the table where static properties
belong to but leave the implementation same as a non-static constructor-type attribute.
Tested by running run-bindings-tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 26 Jul 2012 22:10:54 +0000 (22:10 +0000)]
Propagate gesture events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=92281
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-07-26
Reviewed by Adam Barth.
Source/WebCore:
Propagate gesture events to plugins. This change does not expose the gesture events
to JavaScript, since there is no spec for that at the moment. Exposing gesture events
to JavaScript will be done separately, once there is a spec for it.
Test: platform/chromium/plugins/gesture-events.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
(WebCore::EventNames::isGestureEventType):
(EventNames):
* dom/GestureEvent.cpp: Added.
(WebCore):
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::initGestureEvent):
(WebCore::GestureEvent::interfaceName):
(WebCore::GestureEvent::GestureEvent):
(WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::event):
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/GestureEvent.h: Added.
(WebCore):
(GestureEvent):
(WebCore::GestureEvent::~GestureEvent):
(WebCore::GestureEvent::deltaX):
(WebCore::GestureEvent::deltaY):
(WebCore::GestureEvent::GestureEvent):
(GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::create):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::dispatchGestureEvent):
* dom/Node.h:
(WebCore):
(Node):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
* page/EventHandler.h:
Source/WebKit/chromium:
Propagate gesture events to plugins.
* src/WebInputEventConversion.cpp:
(WebKit):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
* src/WebInputEventConversion.h:
(WebCore):
(WebKit):
(WebGestureEventBuilder):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
* src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):
Tools:
Update TestWebPlugin to receive events, and output logs for the events.
* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::handleInputEvent):
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin):
LayoutTests:
Added a layout test to show that the plugins receive the gesture events correctly.
* platform/chromium/plugins/gesture-events-expected.txt: Added.
* platform/chromium/plugins/gesture-events.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gavinp@chromium.org [Thu, 26 Jul 2012 22:07:20 +0000 (22:07 +0000)]
Guard Prerenderer against inserting prerenders into detached documents.
https://bugs.webkit.org/show_bug.cgi?id=92401
Reviewed by Adam Barth.
Source/WebCore:
If the document is detached, we should not launch a prerender.
Test: fast/dom/HTMLLinkElement/prerender-insert-after-stop.html
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::render):
LayoutTests:
If the document is detached, we should just not launch a prerender.
* fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt: Added.
* fast/dom/HTMLLinkElement/prerender-insert-after-stop.html: Added.
* fast/dom/HTMLLinkElement/resources/empty2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc