WebKit-https.git
10 years ago2011-04-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 7 Apr 2011 08:40:16 +0000 (08:40 +0000)]
2011-04-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
        https://bugs.webkit.org/show_bug.cgi?id=58017

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 7 Apr 2011 08:39:45 +0000 (08:39 +0000)]
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: build mapping for formatted scripts based on keywords positions.
        https://bugs.webkit.org/show_bug.cgi?id=57936

        Mapping based on [\$\.\w]+ was not accurate because string literals representation
        may be different in original and formatted scripts.

        * inspector/front-end/ScriptFormatterWorker.js:
        (buildMapping.regexp.b):
        (buildMapping):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 7 Apr 2011 08:30:43 +0000 (08:30 +0000)]
2011-04-07  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline after r83145. Also skip
        fast/forms/input-number-large-padding.html which fails. See bug
        58020.

        * platform/gtk/Skipped:
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 7 Apr 2011 08:00:22 +0000 (08:00 +0000)]
2011-04-07  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for 4 new tests.

        * platform/gtk/fast/history/visited-link-background-color-expected.checksum: Added.
        * platform/gtk/fast/history/visited-link-background-color-expected.png: Added.
        * platform/gtk/fast/history/visited-link-background-color-expected.txt: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
        * platform/gtk/svg/text/text-midpoint-split-bug-expected.checksum: Added.
        * platform/gtk/svg/text/text-midpoint-split-bug-expected.png: Added.
        * platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 7 Apr 2011 07:39:24 +0000 (07:39 +0000)]
2011-04-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Remove some no longer needed WebProcess sandbox allowances
        https://bugs.webkit.org/show_bug.cgi?id=58015
        <rdar://problem/9232592>

        * WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network
        and launching privileges, since the bugs that required them are fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 7 Apr 2011 07:25:51 +0000 (07:25 +0000)]
2011-04-07  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline after r83075.

        * platform/gtk/fast/blockflow/text-orientation-basic-expected.txt:
        * platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Apr 2011 07:13:02 +0000 (07:13 +0000)]
2011-04-07  Kent Tamura  <tkent@chromium.org>

        [Chromium] Fix a duplicated entry.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpinbuttons become unclickable if right padding is large.
tkent@chromium.org [Thu, 7 Apr 2011 07:03:22 +0000 (07:03 +0000)]
Spinbuttons become unclickable if right padding is large.
https://bugs.webkit.org/show_bug.cgi?id=56298

Reviewed by NOBODY (OOPS!).

Source/WebCore:

An inner-spin-button is put on the right border and ignores right
padding in RenderTextControlSingleLine::layout(), but forwardEvent()
checks if a point is in an area just right of an internal text block.
This inconsistency caused a bug that an inner-spin-button with large
padding didn't receive mouse events.

To fix this bug, we render spin buttons as layers, and remove manual
event forwarding code.

Test: fast/forms/input-number-large-padding.html

* css/html.css: Add "position:relative" to make a spin-button a layer.
(input::-webkit-inner-spin-button):
(input::-webkit-outer-spin-button):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
  Remove manual event forwarding code.

LayoutTests:

Add a test, and skip on platforms which has no inner-spin-button implementation.

* fast/forms/input-number-large-padding-expected.txt: Added.
* fast/forms/input-number-large-padding.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Apr 2011 05:58:08 +0000 (05:58 +0000)]
2011-04-06  Kent Tamura  <tkent@chromium.org>

        Fixed an error in the previous commit.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Apr 2011 05:46:43 +0000 (05:46 +0000)]
2011-04-06  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update text expectation.
        fast/repaint/scale-page-shrink.html is expected to fail because of no
        eventSender.scalePageBy().

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Apr 2011 04:58:51 +0000 (04:58 +0000)]
2011-04-06  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update test expectation.
        xhr-breakpoints.html and detailed-heapshots-summary.html are flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Apr 2011 04:43:50 +0000 (04:43 +0000)]
2011-04-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP object-src should block plugin loads
        https://bugs.webkit.org/show_bug.cgi?id=57283

        This change is pretty straight-forward.  It's slighly unclear to me
        whether this patch is correct w.r.t. the code in DocumentWriter.  I've
        added a FIXME comment, and I'll investigate that case more in the future.

        Test: http/tests/security/contentSecurityPolicy/object-src-none.html

        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::begin):
        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::requestPlugin):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowObjectFromSource):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:
2011-04-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP object-src should block plugin loads
        https://bugs.webkit.org/show_bug.cgi?id=57283

        * http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=58009
bdakin@apple.com [Thu, 7 Apr 2011 04:39:55 +0000 (04:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58009
Frame::scalePage() results in visual artifacts with scale factors less than 1
-and corresponding-
<rdar://problem/8683230>

Reviewed by Dan Bernstein.

Source/WebCore:

Fall into the case where we fill with a background base color when there is a page
scale factor that is less than 1.
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

* fast/repaint/scale-page-shrink.html: Added.
* platform/gtk/Skipped:
* platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
* platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Thu, 7 Apr 2011 03:59:58 +0000 (03:59 +0000)]
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
        https://bugs.webkit.org/show_bug.cgi?id=57984

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
        https://bugs.webkit.org/show_bug.cgi?id=57984

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundlePageSizeAndMarginsInPixels):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
        https://bugs.webkit.org/show_bug.cgi?id=57984

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Chris Rogers <crogers@google.com>
crogers@google.com [Thu, 7 Apr 2011 03:55:19 +0000 (03:55 +0000)]
2011-04-06  Chris Rogers  <crogers@google.com>

        Reviewed by Tony Chang.

        Add web audio support to DumpRenderTree (mac port)
        https://bugs.webkit.org/show_bug.cgi?id=57969

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setEncodedAudioDataCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::dumpAsAudio):
        (LayoutTestController::setDumpAsAudio):
        (LayoutTestController::encodedAudioData):
        (LayoutTestController::setEncodedAudioData):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpAudio):
        (dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 7 Apr 2011 03:49:53 +0000 (03:49 +0000)]
2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
        https://bugs.webkit.org/show_bug.cgi?id=56086

        * platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.
2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
        https://bugs.webkit.org/show_bug.cgi?id=56086

        Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
        from the LayoutTestController.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
        https://bugs.webkit.org/show_bug.cgi?id=56086

        Add the missing method.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Apr 2011 03:43:27 +0000 (03:43 +0000)]
2011-04-06  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectations for Geeza Pro and so on.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 7 Apr 2011 03:34:04 +0000 (03:34 +0000)]
2011-04-06  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
        https://bugs.webkit.org/show_bug.cgi?id=57982

        Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 7 Apr 2011 03:31:55 +0000 (03:31 +0000)]
2011-04-06  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        MediaPlayerPrivateAVFoundation does not change rate due to setRate().
        https://bugs.webkit.org/show_bug.cgi?id=57919

        * media/video-set-rate-from-pause-expected.txt: Added.
        * media/video-set-rate-from-pause.html: Added.
2011-04-06  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        MediaPlayerPrivateAVFoundation does not change rate due to setRate().
        https://bugs.webkit.org/show_bug.cgi?id=57919

        Test: media/video-set-rate-from-pause.html

        The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
        of the media; instead a subclass must do that work.  So when setRate() is called,
        inform a subclass through a new pure virtual updateRate() function that there's
        work to be done.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added.  Set the requested rate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Dai Mikurube <dmikurube@chromium.org>
kinuko@chromium.org [Thu, 7 Apr 2011 03:24:59 +0000 (03:24 +0000)]
2011-04-06  Dai Mikurube  <dmikurube@chromium.org>

        Reviewed by David Levin.

        Add QUOTA build flag for unified quota API
        https://bugs.webkit.org/show_bug.cgi?id=57918

        * win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
        * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag
2011-04-06  Dai Mikurube  <dmikurube@chromium.org>

        Reviewed by David Levin.

        Add QUOTA build flag for unified quota API
        https://bugs.webkit.org/show_bug.cgi?id=57918

        * configure.ac: Added QUOTA build flag
2011-04-06  Dai Mikurube  <dmikurube@chromium.org>

        Reviewed by David Levin.

        Add QUOTA build flag for unified quota API
        https://bugs.webkit.org/show_bug.cgi?id=57918

        * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
2011-04-06  Dai Mikurube  <dmikurube@chromium.org>

        Reviewed by David Levin.

        Add QUOTA build flag for unified quota API
        https://bugs.webkit.org/show_bug.cgi?id=57918

        * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
2011-04-06  Dai Mikurube  <dmikurube@chromium.org>

        Reviewed by David Levin.

        Add QUOTA build flag for unified quota API
        https://bugs.webkit.org/show_bug.cgi?id=57918

        * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
        * GNUmakefile.am: Added QUOTA build flag
        * WebCore.pri: Added QUOTA build flag
2011-04-06  Dai Mikurube  <dmikurube@chromium.org>

        Reviewed by David Levin.

        Add QUOTA build flag for unified quota API
        https://bugs.webkit.org/show_bug.cgi?id=57918

        * Scripts/build-webkit: Added QUOTA build flag

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCorrect results for the Geeza Pro metrics change.
mitz@apple.com [Thu, 7 Apr 2011 03:06:54 +0000 (03:06 +0000)]
Correct results for the Geeza Pro metrics change.

* platform/mac/fast/dom/52776-expected.checksum:
* platform/mac/fast/dom/52776-expected.png:
* platform/mac/fast/dom/52776-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.checksum:
* platform/mac/fast/text/complex-text-opacity-expected.png:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 7 Apr 2011 02:21:26 +0000 (02:21 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, update Chromium expectations for failing test from r83075.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 7 Apr 2011 01:47:29 +0000 (01:47 +0000)]
2011-04-06  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        Adjust the apple webkit port's default timeout to match
        old-run-webkit-tests at 35 seconds.

        https://bugs.webkit.org/show_bug.cgi?id=37738

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Scott Cameron <sccameron@rim.com>
commit-queue@webkit.org [Thu, 7 Apr 2011 01:37:24 +0000 (01:37 +0000)]
2011-04-06  Scott Cameron  <sccameron@rim.com>

        Reviewed by Eric Seidel.

        Remove global variable $httpdPath and replace with the return value of
        getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
        https://bugs.webkit.org/show_bug.cgi?id=53499

        * Scripts/run-iexploder-tests:
        * Scripts/webkitperl/httpd.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57997
slewis@apple.com [Thu, 7 Apr 2011 01:13:26 +0000 (01:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57997
<rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
Cancel all enqueued events when detaching the Document the events cannot keep the Document
alive.

Reviewed by Darin Adler.

No change in functionality so no new tests.

* dom/Document.cpp:
(WebCore::Document::detach):
* dom/EventQueue.cpp:
(WebCore::EventQueue::cancelQueuedEvents):
* dom/EventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 7 Apr 2011 01:04:30 +0000 (01:04 +0000)]
2011-04-06  David Levin  <levin@chromium.org>

        Reviewed by Ojan Vafai.

        Augment style guidelines about meaningless parameters from text the unwritten rules email.
        https://bugs.webkit.org/show_bug.cgi?id=55275

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten...
mitz@apple.com [Thu, 7 Apr 2011 01:02:27 +0000 (01:02 +0000)]
<rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
https://bugs.webkit.org/show_bug.cgi?id=58002

Reviewed by Darin Adler.

Source/WebCore:

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
does not require the vertical metrics tweaks that were needed in Leopard. That the
tweaks were being applied went mostly unnoticed until r73993, because until then it
only affected cases where Geeza Pro was specified, not when it occurred as a fallback
font.

LayoutTests:

* platform/mac/fast/dom/52776-expected.checksum:
* platform/mac/fast/dom/52776-expected.png:
* platform/mac/fast/dom/52776-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Anders Bakken <agbakken@gmail.com>
commit-queue@webkit.org [Thu, 7 Apr 2011 00:20:32 +0000 (00:20 +0000)]
2011-04-06  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] FrameLoaderClientQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40254

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtDescriptionSuitableForTestResult):
        (WebCore::FrameLoaderClientQt::hasWebView):
        (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
        (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
        (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
        (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
        (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
        (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
        (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
        (WebCore::FrameLoaderClientQt::willChangeTitle):
        (WebCore::FrameLoaderClientQt::didChangeTitle):
        (WebCore::FrameLoaderClientQt::finishedLoading):
        (WebCore::FrameLoaderClientQt::frameLoadCompleted):
        (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
        (WebCore::FrameLoaderClientQt::didFinishLoad):
        (WebCore::FrameLoaderClientQt::setTitle):
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
        (WebCore::FrameLoaderClientQt::updateGlobalHistory):
        (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
        (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
        (WebCore::FrameLoaderClientQt::committedLoad):
        (WebCore::FrameLoaderClientQt::download):
        (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
        (WebCore::FrameLoaderClientQt::createFrame):
        (WebCore::FrameLoaderClientQt::objectContentType):
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 7 Apr 2011 00:07:08 +0000 (00:07 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, update expectations for Chromium visited link test.
        https://bugs.webkit.org/show_bug.cgi?id=58000

        Apparently, this just hasn't been working for a while.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 6 Apr 2011 23:52:52 +0000 (23:52 +0000)]
2011-04-06  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 57994 - Move guardRef functionality back to Document
        https://bugs.webkit.org/show_bug.cgi?id=57994

        Move the relevant code parts from TreeScope back into Document.

        No new tests. (no new functionality)

        * dom/Document.cpp:
        (WebCore::Document::removedLastRef):
        * dom/Document.h:
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::destroyTreeScopeData):
        * dom/TreeScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Ian Henderson <ianh@apple.com>
simon.fraser@apple.com [Wed, 6 Apr 2011 23:41:51 +0000 (23:41 +0000)]
2011-04-06  Ian Henderson  <ianh@apple.com>

        Reviewed by Simon Fraser, Antti Koivisto.

        Fast path for parsing simple CSS values
        https://bugs.webkit.org/show_bug.cgi?id=57964

        Add functions to parse simple color or dimension values, skipping the
        overhead of full CSS parsing.

        Change parseValue to a static method to avoid unnecessary allocation
        of a CSSParser in the fast case.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty):
        Changed to use the new, static parseValue method.
        * css/CSSParser.cpp:
        (WebCore::isColorPropertyID):
        (WebCore::parseColorValue):
        Parses any color accepted by the existing parseColor() static method.
        We must handle color identifiers separately, since parseColor() will
        change 'red' into 'rgb(255, 0, 0)'.
        (WebCore::isSimpleLengthPropertyID):
        (WebCore::parseSimpleLengthValue):
        Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is
        false, or 'NN' is '0').  Returns false to fall back to the slow path.
        (WebCore::CSSParser::parseValue):
        * css/CSSParser.h:
        * css/WebKitCSSMatrix.cpp:
        (WebCore::WebKitCSSMatrix::setMatrixValue):
        Changed to use the new, static parseValue method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Darin Adler.
kevino@webkit.org [Wed, 6 Apr 2011 23:38:42 +0000 (23:38 +0000)]
Reviewed by Darin Adler.

Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 6 Apr 2011 23:27:46 +0000 (23:27 +0000)]
2011-04-06  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        teach run-webkit-tests to read checksums from png files
        https://bugs.webkit.org/show_bug.cgi?id=57993

        * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
          no .checksum and look for the checksum in there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 6 Apr 2011 23:20:49 +0000 (23:20 +0000)]
2011-04-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Antti Koivisto.

        Some minor style resolution optimizations
        https://bugs.webkit.org/show_bug.cgi?id=57996

        A couple of minor optimizations to style-related code.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::isCSSPropertyName):
        (WebCore::JSCSSStyleDeclaration::putDelegate):
        Avoid calling cssPropertyName() twice when setting style on an element.

        * css/CSSStyleSelector.cpp:
        (WebCore::useSVGZoomRules):
        (WebCore::CSSStyleSelector::applyProperty):
        Avoid calling isSVGElement() for every property, since only a two properties
        care about it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Ian Henderson <ianh@apple.com>
simon.fraser@apple.com [Wed, 6 Apr 2011 23:19:20 +0000 (23:19 +0000)]
2011-04-06  Ian Henderson  <ianh@apple.com>

        Reviewed by Antti Koivisto.

        Unnecessary string allocation in CSSStyleDeclaration::setProperty
        https://bugs.webkit.org/show_bug.cgi?id=57995

        Pass the bool representing the property's importance directly instead
        of constructing a string.

        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::setProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 23:08:11 +0000 (23:08 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, rebaseline more Chromium mac tests after r83075.

        * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Wed, 6 Apr 2011 23:06:03 +0000 (23:06 +0000)]
2011-04-06  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt][WK2][Symbian] Remove use of stack arrays with variable size
        https://bugs.webkit.org/show_bug.cgi?id=57877

        For better compiler portability, use new/delete for arrays when size
        isn't known at compile time. Also fix one compiler warning about bitshift
        operations on signed integers.
        * Platform/CoreIPC/qt/ConnectionQt.cpp:
        (CoreIPC::Connection::readyReadHandler):
        (CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 23:01:30 +0000 (23:01 +0000)]
2011-04-06  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
        https://bugs.webkit.org/show_bug.cgi?id=57963

        No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

        * bindings/v8/V8Utilities.h:
        (WebCore::createFunctionOnlyCallback):
        * bindings/v8/custom/V8GeolocationCustom.cpp:
        (WebCore::V8Geolocation::getCurrentPositionCallback):
        (WebCore::V8Geolocation::watchPositionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 22:56:55 +0000 (22:56 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, try to green Chromium mac tree by marking failing tests as more generally failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Support Windows 7 Gestures
bweinstein@apple.com [Wed, 6 Apr 2011 22:38:43 +0000 (22:38 +0000)]
WebKit2: Support Windows 7 Gestures
https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>

Reviewed by Adam Roben.

Source/WebCore:

Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.

* WebCore.vcproj/WebCore.vcproj:
* platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.

Source/WebKit/win:

Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
used in both WebKit and WebKit2.

* WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
* WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
* WindowsTouch.h: Removed.

Source/WebKit2:

Port code from WebKit1 -> WebKit2 to handle Windows 7 gestures.

The UIProcess gets a WM_GESTURENOTIFY message, it sends a sync message to the WebProcess to ask
if we should allow panning. The WebProcess checks if we're in a scrollable area, and the mouse
isn't over a scrollbar.

The UIProcess then gets a WM_GESTURE message, and if it is a pan gesture, it sends a message to
the WebProcess to scroll by the amount fingers have moved since the last WM_GESTURE messeage. The
X and Y are reversed because panning up -> moving the page down, and vice versa.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureWillBegin): Send a sync message to the WebProcess
    to initialize the gesture. The WebProcess returns whether or not we can start a pan
    gesture from where we are.
(WebKit::WebPageProxy::gestureDidScroll): Send a message to the WebProcess to scroll by
    pan gesture.
(WebKit::WebPageProxy::gestureDidEnd): Send a message to the WebProcess that the gesture has ended.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Add WM_GESTURE and WM_GESTURENOTIFY handlers.
(WebKit::WebView::WebView): Initialize two new variables.
(WebKit::WebView::onGestureNotify): Figure out which gestures we should support based on where
    the gesture is beginning.
(WebKit::WebView::onGesture): Support starting a gesture, ending a gesture, and panning.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add messages needed for gestures.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureWillBegin): Set the node that the gesture started on (so we
    know which layer to scroll if the user pans), and determine whether or not we should allow
    panning. If the page can't scroll, or the user is on a scrollbar, disallow panning.
(WebKit::WebPage::gestureDidScroll): Scroll the enclosing layer of the element the gesture
    started on.
(WebKit::WebPage::gestureDidEnd): Clear the node the gesture started on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 David Dorwin <ddorwin@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 22:37:09 +0000 (22:37 +0000)]
2011-04-06  David Dorwin  <ddorwin@chromium.org>

        Reviewed by David Levin.

        Enable fullscreen layout tests for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=55726

        Remove test_expectations override for fullscreen tests.

        * platform/chromium/test_expectations.txt:
2011-04-06  David Dorwin  <ddorwin@chromium.org>

        Reviewed by David Levin.

        Enable fullscreen layout tests for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=55726

        Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 22:27:22 +0000 (22:27 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, rebaseline Chromium Mac tests after r83075.

        * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
        * platform/chromium-mac/fast/multicol/nested-columns-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 6 Apr 2011 22:24:32 +0000 (22:24 +0000)]
2011-04-06  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API
        https://bugs.webkit.org/show_bug.cgi?id=57989

        Note that WKChar, which is returned by WKStringGetCharactersPtr(), is defined the same way we define JSChar in JSStringRef.h.

        * Shared/API/c/WKString.cpp:
        (WKStringGetLength): Added.
        (WKStringGetCharactersPtr): Added.
        * Shared/API/c/WKString.h: Define WKChar and added WKStringGetLength() and WKStringGetCharactersPtr().
        * Shared/WebString.h:
        (WebKit::WebString::length): Added.
        (WebKit::WebString::characters): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 6 Apr 2011 22:21:38 +0000 (22:21 +0000)]
2011-04-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Dock stays in front of Hulu.com full screen video output
        https://bugs.webkit.org/show_bug.cgi?id=57988
        <rdar://problem/9216260>

        Instead of using -[NSMenu setMenuBarVisible:] to toggle full screen, use
        -[NSApp setPresentationOptions:]. Also, make the UI process the front most app before
        setting the presentation options when exiting full screen, otherwise the dock won't
        be restored correctly.

        * PluginProcess/mac/PluginProcessShim.mm:
        Remove some shim functions that aren't needed.

        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::PluginProcessProxy):
        Initialize m_preFullscreenAppPresentationOptions.

        * UIProcess/Plugins/PluginProcessProxy.h:
        Add m_preFullscreenAppPresentationOptions.

        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
        (WebKit::PluginProcessProxy::enterFullscreen):
        Change the presentation options for the app.

        (WebKit::PluginProcessProxy::exitFullscreen):
        Restore the presentation options.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 6 Apr 2011 22:17:11 +0000 (22:17 +0000)]
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
        https://bugs.webkit.org/show_bug.cgi?id=57974

        We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

        No new tests needed, just a config flag rename.

        * features.pri:
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
        https://bugs.webkit.org/show_bug.cgi?id=57974

        We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

        No new tests needed, just a config flag rename.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        * WebCoreSupport/QtPlatformPlugin.cpp:
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::loadHtml5Video):
        * tests/tests.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 6 Apr 2011 22:15:11 +0000 (22:15 +0000)]
2011-04-06  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Stop JSObject::isUsingInlineStorage() from using the structure
        https://bugs.webkit.org/show_bug.cgi?id=57986

        Make the isUsingInlineStorage() implementation just look at
        whether the property storage is inside the object.

        * runtime/JSObject.h:
        (JSC::JSObject::isUsingInlineStorage):
        (JSC::JSObject::JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.
barraclough@apple.com [Wed, 6 Apr 2011 22:10:16 +0000 (22:10 +0000)]
Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.

Rubber stamped by Geoff Garen.

* runtime/JSImmediate.h:
* runtime/JSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Tyler Close <tjclose@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 22:02:10 +0000 (22:02 +0000)]
2011-04-06  Tyler Close  <tjclose@chromium.org>

        Reviewed by Nate Chapin.

        run-bindings-tests reference files out of sync with CodeGenerator*.pm
        https://bugs.webkit.org/show_bug.cgi?id=57967

        * bindings/scripts/test/V8/V8TestCallback.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpose the original URL of a WKBackForwardListItem.
mrowe@apple.com [Wed, 6 Apr 2011 21:57:58 +0000 (21:57 +0000)]
Expose the original URL of a WKBackForwardListItem.

Reviewed by Darin Adler.

Needed for <rdar://problem/9074651>.

* UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemCopyOriginalURL):
* UIProcess/API/C/WKBackForwardListItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Wed, 6 Apr 2011 21:53:00 +0000 (21:53 +0000)]
2011-04-06  Vincent Scheib  <scheib@chromium.org>

        Fixed GPU expectations for r80867

        * platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Asanka Herath <asanka@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 21:49:09 +0000 (21:49 +0000)]
2011-04-06  Asanka Herath  <asanka@chromium.org>

        Reviewed by Darin Fisher.

        Add new TargetType: TargetIsFavicon

        https://bugs.webkit.org/show_bug.cgi?id=57659

        No new functionality added, so no additional tests.

        * platform/network/ResourceRequestBase.h:
2011-04-06  Asanka Herath  <asanka@chromium.org>

        Reviewed by Darin Fisher.

        Add new TargetType: TargetIsFavicon

        https://bugs.webkit.org/show_bug.cgi?id=57659

        * public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a "view leaks" link to builds on SnowLeopard Intel Leaks
aroben@apple.com [Wed, 6 Apr 2011 21:47:10 +0000 (21:47 +0000)]
Add a "view leaks" link to builds on SnowLeopard Intel Leaks

Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
build's results directory here...
(ExtractTestResults.finished): ...from here.
(ExtractTestResultsAndLeaks): New class that's used by the leaks builder
(ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
leaks" link to point to Leaks Viewer for this build.
(TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
but it seemed good to add for consistency with BuildAndTestFactory.
(BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
(BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
that we'll get a "view leaks" link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] media tests are flakey
ossy@webkit.org [Wed, 6 Apr 2011 21:31:55 +0000 (21:31 +0000)]
[Qt] media tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=57983

* platform/qt/Skipped: Disable all media tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57981
hyatt@apple.com [Wed, 6 Apr 2011 21:22:56 +0000 (21:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57981

Reviewed by Simon Fraser.

Update the column count and width computation algorithm for CSS3 multi-column layout
to match the revised pseudo-algorithm in the latest draft of the spec.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 6 Apr 2011 21:08:20 +0000 (21:08 +0000)]
2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
        https://bugs.webkit.org/show_bug.cgi?id=57965

        Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
        from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
        instead of marginStartForChild and marginEndForChild respectively.

        Calling these two functions on RenderInline is okay because writing-mode cannot differ
        from that of the containing block.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::borderPaddingMarginStart):
        (WebCore::borderPaddingMarginEnd):
        (WebCore::inlineLogicalWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 6 Apr 2011 20:55:17 +0000 (20:55 +0000)]
2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83039.
        http://trac.webkit.org/changeset/83039
        https://bugs.webkit.org/show_bug.cgi?id=57978

        introduced a new regression in conjunction to
        ReplaceSelectionCommand (Requested by rniwa on #webkit).

        * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Removed.
        * editing/inserting/insert-paragraph-separator-tab-span.html: Removed.
2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83039.
        http://trac.webkit.org/changeset/83039
        https://bugs.webkit.org/show_bug.cgi?id=57978

        introduced a new regression in conjunction to
        ReplaceSelectionCommand (Requested by rniwa on #webkit).

        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::init):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Wed, 6 Apr 2011 20:52:17 +0000 (20:52 +0000)]
2011-04-06  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by David Levin.

        Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
        https://bugs.webkit.org/show_bug.cgi?id=27658

        * fast/events/select-element-expected.txt: Added to check PgUp/PgDown/Home/End keys are working correctly in SELECT tag.
        * fast/events/select-element.html: Added for expectation.
2011-04-06  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by David Levin.

        Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
        https://bugs.webkit.org/show_bug.cgi?id=27658

        Test: fast/events/select-element.html

        * dom/SelectElement.cpp:
        (WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines.
        (WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index.
        (WebCore::nextSelectableListIndex): Implemented with nextValidIndex.
        And converted to a normal static function from a private function of SelectElement.
        (WebCore::previousSelectableListIndex): Implemented with nextValidIndex.
        And converted to a normal static function from a private function of SelectElement.
        (WebCore::firstSelectableListIndex): Returns the first selectable index.
        (WebCore::lastSelectableListIndex): Returns the last selectable index.
        (WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast.
        (WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.

        * dom/SelectElement.h:
        (WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().

        * rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML.
        They can differ due to the minimum size imposed by RenderListBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57975
hyatt@apple.com [Wed, 6 Apr 2011 20:47:51 +0000 (20:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57975

Reviewed by Dan Bernstein.

The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
to just look at the style, so that it can find the InlineTextBox and not care that it's a child
of the link element and not the line box for the link element itself (since that line box got
culled).

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 20:44:35 +0000 (20:44 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, rebaseline Chromium Win tests after r83075.

        * platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline text orientation layout test on Windows.
hyatt@apple.com [Wed, 6 Apr 2011 20:37:57 +0000 (20:37 +0000)]
Rebaseline text orientation layout test on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update platform specific expected results after r83075.
ossy@webkit.org [Wed, 6 Apr 2011 20:35:49 +0000 (20:35 +0000)]
[Qt] Update platform specific expected results after r83075.

* platform/qt/editing/pasteboard/paste-text-011-expected.checksum:
* platform/qt/editing/pasteboard/paste-text-011-expected.png:
* platform/qt/editing/pasteboard/paste-text-011-expected.txt:
* platform/qt/fast/css-generated-content/014-expected.checksum:
* platform/qt/fast/css-generated-content/014-expected.png:
* platform/qt/fast/css-generated-content/014-expected.txt:
* platform/qt/fast/css/word-space-extra-expected.checksum:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug2123-expected.png:
* platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug4523-expected.png:
* platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
* platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
* platform/qt/tables/mozilla/core/bloomberg-expected.png:
* platform/qt/tables/mozilla/core/bloomberg-expected.txt:
* platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug...
beidson@apple.com [Wed, 6 Apr 2011 20:31:39 +0000 (20:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973
WK2 icon database should be able to get a CGImage of a specific size

Reviewed by Anders Carlsson.

../WebCore:

* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getFirstCGImageRefOfSize):

* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the
  first frame of the requested size.

../WebKit2:

* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching
  CGImage in the icon.
* UIProcess/API/C/cg/WKIconDatabaseCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 6 Apr 2011 20:29:22 +0000 (20:29 +0000)]
Reviewed by Kevin Ollivier.

[wx] Fix cursor handling so that we always call the chrome to set it.

https://bugs.webkit.org/show_bug.cgi?id=57972

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 20:17:50 +0000 (20:17 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, mark Chromium expectations for line-clamp.html to be a known regression.
        https://bugs.webkit.org/show_bug.cgi?id=57975

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alok Priyadarshi <alokp@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 20:14:20 +0000 (20:14 +0000)]
2011-04-06  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Add settings API to enable accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=57863

        If accelerated drawing is enabled we try to render content and
        root layers using GPU. Please note that this setting is ignored if
        accelerated compositing is disabled.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=41445
hyatt@apple.com [Wed, 6 Apr 2011 20:06:45 +0000 (20:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=41445

Reviewed by Dan Bernstein.

Visited links painting with black background. Make sure that if the visited style has
the initial background color (transparent) set that we just use the unvisited color.

Source/WebCore:

Added fast/history/visited-link-background-color.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::visitedDependentColor):

LayoutTests:

Added fast/history/visited-link-background-color.html
* fast/history/visited-link-background-color.html: Added.
* platform/mac/fast/history/visited-link-background-color-expected.checksum: Added.
* platform/mac/fast/history/visited-link-background-color-expected.png: Added.
* platform/mac/fast/history/visited-link-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Qt buildfix after r83079.
ossy@webkit.org [Wed, 6 Apr 2011 19:56:47 +0000 (19:56 +0000)]
Unreviewed Qt buildfix after r83079.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Implement TextChecker on Windows
jberlin@webkit.org [Wed, 6 Apr 2011 19:56:28 +0000 (19:56 +0000)]
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.

* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 19:46:35 +0000 (19:46 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, update Chromium expectations for set-unloaded-frame-location.html as a flaky crasher.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 19:31:03 +0000 (19:31 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, rebaseline Chromium linux tests after r83075.

        * platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Dean Jackson <dino@apple.com>
dino@apple.com [Wed, 6 Apr 2011 19:26:23 +0000 (19:26 +0000)]
2011-04-06  Dean Jackson  <dino@apple.com>

        Reviewed by Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=56936
        Crash in ImplicitAnimation::~ImplicitAnimation

        Make sure the style and start time waiting lists
        are cleared in the CompositeAnimation destructor. This
        way, no running transitions can be left in a state
        where they are destroyed as the AnimationControllerPrivate
        cleans up.

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::~CompositeAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Robert Sesek <rsesek@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 19:24:20 +0000 (19:24 +0000)]
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        No change in behavior; no new tests.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
        * editing/TextIterator.h:
        * page/Frame.cpp:
        (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebView/WebFrame.mm:
        (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
        (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
        * WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore
        (WebKit::WebPage::getMarkedRange):
        (WebKit::WebPage::getSelectedRange):
        (WebKit::WebPage::characterIndexForPoint):
        (WebKit::WebPage::performDictionaryLookupAtLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 6 Apr 2011 18:50:06 +0000 (18:50 +0000)]
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        Skip tests not passing in the Qt bot.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
steveblock@google.com [Wed, 6 Apr 2011 18:46:49 +0000 (18:46 +0000)]
2011-04-06  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
        https://bugs.webkit.org/show_bug.cgi?id=57770

        Create a template from an existing functionality in JSGeolocationCustom.cpp
        to be used by the custom bindings of both Geolocation and the Media Stream API.
        V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760

        No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/CallbackFunction.cpp: Added.
        (WebCore::checkFunctionOnlyCallback):
        * bindings/js/CallbackFunction.h: Added.
        (WebCore::createFunctionOnlyCallback):
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 6 Apr 2011 18:43:29 +0000 (18:43 +0000)]
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Implement fullscreen playback for the GStreamer backend.
        https://bugs.webkit.org/show_bug.cgi?id=56826

        Implement support for fullscreen playback when building the
        Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
        The implementation is done in FullScreenVideoQt alongside with
        the Qt Multimedia support.

        No new tests because layout tests cover it. They are not yet activated
        but will be any time soon.

        * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
        * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
        (FullScreenVideoWindow::FullScreenVideoWindow):
        (FullScreenVideoWindow::setVideoElement):
        (FullScreenVideoWindow::closeEvent):
        (FullScreenVideoWindow::keyPressEvent):
        (FullScreenVideoWindow::event):
        (FullScreenVideoWindow::showFullScreen):
        (FullScreenVideoWindow::hideCursor):
        (FullScreenVideoWindow::showCursor):
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Implement fullscreen playback for the GStreamer backend.
        https://bugs.webkit.org/show_bug.cgi?id=56826

        Implement support for fullscreen playback when building the
        Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
        The implementation is done in FullScreenVideoQt alongside with
        the Qt Multimedia support.

        No new tests because layout tests cover it. They are not yet activated
        but will be any time soon.

        * QtWebKit.pro:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
        (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
        (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
        (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
        (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
        (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Zan Dobersek <zandobersek@gmail.com>
commit-queue@webkit.org [Wed, 6 Apr 2011 18:40:50 +0000 (18:40 +0000)]
2011-04-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Unskip a newly-passing test.

        * platform/gtk/Skipped:
2011-04-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Allow an empty status text to be dumped.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 6 Apr 2011 18:34:11 +0000 (18:34 +0000)]
2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dimitri Glazkov.

        Bundle lineLeftOffset and lineRightOffset as a class
        https://bugs.webkit.org/show_bug.cgi?id=57851

        Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
        The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
        and only the difference is used to compute the width.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
        (WebCore::LineOffsets::LineOffsets): Added.
        (WebCore::LineOffsets::width): Added.
        (WebCore::LineOffsets::setLeft): Added.
        (WebCore::LineOffsets::setRight): Added.
        (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
        (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57916
hyatt@apple.com [Wed, 6 Apr 2011 18:20:52 +0000 (18:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57916

Reviewed by Dan Bernstein.

Implement an optimization to the line box tree to cull out most of the intermediate
line boxes that can occur between the root line box and the leaves of the tree (images
and text).

Source/WebCore:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
is up to date.

* page/SpatialNavigation.cpp:
(WebCore::hasOffscreenRect):
(WebCore::nodeRectInAbsoluteCoordinates):
Add asserts in spatial navigation code to catch any future bad queries that might be made
for rectangles without layout being up to date.

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::uniteIfNonZero):
* platform/graphics/IntRect.h:
Add a new unite function that is useful for the render tree to FloatRect and IntRect.  This
version allows rect unites to happen if either width or height is nonzero.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
if content inside those inlines is hit.

* rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
Fix a bug in this function for obtaining the logical frame rect of an inline box.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
addToLine now also checks line gap in the line box tree optimization checks.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
* rendering/InlineFlowBox.h:
Rewritten to add the text box overflow to the text box itself.

 * rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::destroy):
Destroy has been changed to call a helper function to remove and destroy the line boxes that
is now called from one additional spot.

(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
Text boxes now cache their own overflow in a global hash table.

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
Changed to not assume that the parent line box's renderer is the RenderText's immediate
parent, since intermediate line boxes may have been culled.

(WebCore::InlineTextBox::paint):
Paint now properly checks only the text box overflow instead of the parent line box's overflow.

* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
New accessors to obtain overflow for inline text boxes.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
text boxes may not have anything in between them and the block that contains the inline first letter
container.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
The culling optimization is done here.  Only if the RenderInline says that boxes are allowed will they
be created.

(WebCore::RenderBlock::layoutInlineChildren):
The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
This is done before any lines are built.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
The new m_alwaysCreateLineBoxes flag has been added to the constructor.

(WebCore::RenderInline::styleDidChange):
An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
(like having a layer, borders, padding, margins or backgrounds).  Some checks that depend on examining
the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
vertical alignment, line height, etc.).

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineBoundingBox):
lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).

(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::clippedOverflowRectForRepaint):
The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.

(WebCore::RenderInline::dirtyLineBoxes):
dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::createAndAppendInlineFlowBox):
Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
when line-box-contain is set to an unusual value.

(WebCore::RenderInline::addFocusRingRects):
Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.

* rendering/RenderInline.h:
(WebCore::RenderInline::firstLineBoxIncludingCulling):
(WebCore::RenderInline::lastLineBoxIncludingCulling):
Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
is all that needs checking.

(WebCore::RenderInline::alwaysCreateLineBoxes):
(WebCore::RenderInline::setAlwaysCreateLineBoxes):
Functions for getting and setting the m_alwaysCreateLineBoxes flag.

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
lines get dirtied.

* rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes):
New helper invoked by destroy and also from updateFirstLetter.

(WebCore::RenderText::destroy):
Changed to call removeAndDestroyTextBoxes.

(WebCore::RenderText::absoluteRects):
Fixed to be properly physical instead of logical.

(WebCore::RenderText::linesVisualOverflowBoundingBox):
New implementation for RenderText that gives the bounding box of the text boxes including overflow from
shadows, glyphs, text-stroke, etc.  Used by RenderInline::culledInlineVisualOverflowBoundingBox.

* rendering/RenderText.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.

* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).

LayoutTests:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

* platform/mac/fast/blockflow/text-orientation-basic-expected.txt:
* platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 6 Apr 2011 18:17:17 +0000 (18:17 +0000)]
2011-04-06  MORITA Hajime  <morrita@google.com>

        Unreviewed expectations udpate for gtk port that follows r83065.

        * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
        * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 18:15:07 +0000 (18:15 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, modify Chromium test expectations from r83065.  They need
       rebaselines, but in the meantime they should fail more generally so as
       not to trip the bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 6 Apr 2011 18:13:58 +0000 (18:13 +0000)]
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Unskip some media LayoutTests.
        https://bugs.webkit.org/show_bug.cgi?id=57855

        Unskip some media tests for Qt.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 18:12:30 +0000 (18:12 +0000)]
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundlePageNumberForElementById):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::pageNumberForElementById):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::pageNumberForElementById):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Drag & Drop Gmail Attachments doesn't work.
enrica@apple.com [Wed, 6 Apr 2011 18:03:32 +0000 (18:03 +0000)]
REGRESSION: Drag & Drop Gmail Attachments doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>

Reviewed by Darin Adler.

Source/WebCore:

In WebKit2 we cannot rely on the value returned by platformData() that
on Mac returns an NSDraggingInfo object. This is available only in the UI
process. Therefore we should use m_pasteboard instead.
We cannot change what platformData() returns on Mac, since there are
delegate methods that receive a NSDraggingInfo object (only in WebKit).

* platform/DragData.h:
(WebCore::DragData::pasteboard): Added.
* platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
* platform/mac/DragDataMac.mm:
(WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
(WebCore::DragData::asURL): Same as above.

Source/WebKit2:

Added _hitTest method to support drag and drop when the drag types cannot be matched.
This is the case for elements that do not place content
in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).

* UIProcess/API/mac/WKView.mm:
(-[WKView _hitTest:dragTypes:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 6 Apr 2011 17:56:27 +0000 (17:56 +0000)]
2011-04-06  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        fast/layer/video_layer.html has the same text output for all chromium mac platforms.

        [chromium] Fix fast/layers/video_layer.html expectations
        https://bugs.webkit.org/show_bug.cgi?id=57386

        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Wed, 6 Apr 2011 17:32:27 +0000 (17:32 +0000)]
2011-04-06  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DumpRenderTree: do not try to free NULL SoupURIs
        https://bugs.webkit.org/show_bug.cgi?id=57932

        Some Layout tests have invalid URIs that do not generate valid
        SoupURI instances. Do not try to free those NULL SoupURIs.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Wed, 6 Apr 2011 17:19:29 +0000 (17:19 +0000)]
2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Darin Adler.

        ClipboardWin has unused variables "ExceptionCode ec"
        https://bugs.webkit.org/show_bug.cgi?id=57952

        Remove the unused variable.

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::declareAndWriteDragImage):
        (WebCore::ClipboardWin::writePlainText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 6 Apr 2011 17:06:14 +0000 (17:06 +0000)]
2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dimitri Glazkov.

        Split getBorderPaddingMargin into two functions
        https://bugs.webkit.org/show_bug.cgi?id=57947

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin.
        (WebCore::borderPaddingMarginEnd): Ditto.
        (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd.
        (WebCore::RenderBlock::findNextLineBreak): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 6 Apr 2011 17:03:26 +0000 (17:03 +0000)]
2011-04-06  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] <progress> should not have manual layout code.
        https://bugs.webkit.org/show_bug.cgi?id=57801

        Updated progress-bar-value-pseudo-element.html to have wider coverage and
        follow pseudo class change.

        * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
2011-04-06  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] <progress> should not have manual layout code.
        https://bugs.webkit.org/show_bug.cgi?id=57801

        - Simplified RenderProgress, removing its custom layout code
        - Introducing ProgressValueElement and ProgressBarElement, replacing
          ProgressBarValueElement.

        Now the structure is almost identical to <meter>,
        other than:
        - RenderProgress has animated painting, thus manages its own timer.
        - Both ProgressValueElement and ProgressBarElement has pseudo classes
          which don't changes during its lifetime.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/html.css:
        (progress):
        (progress::-webkit-progress-bar):
        (progress::-webkit-progress-value):
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::~HTMLProgressElement):
        (WebCore::HTMLProgressElement::create):
        (WebCore::HTMLProgressElement::attach):
        (WebCore::HTMLProgressElement::didElementStateChange):
        (WebCore::HTMLProgressElement::createShadowSubtree):
        * html/HTMLProgressElement.h:
        * html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h.
        (WebCore::ProgressShadowElement::ProgressShadowElement):
        (WebCore::ProgressShadowElement::progressElement):
        (WebCore::ProgressShadowElement::rendererIsNeeded):
        (WebCore::ProgressBarElement::shadowPseudoId):
        (WebCore::ProgressValueElement::shadowPseudoId):
        (WebCore::ProgressValueElement::setWidthPercentage):
        * html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h.
        (WebCore::ProgressBarElement::ProgressBarElement):
        (WebCore::ProgressBarElement::create):
        (WebCore::ProgressValueElement::ProgressValueElement):
        (WebCore::ProgressValueElement::create):
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::RenderProgress):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::animationTimerFired):
        * rendering/RenderProgress.h:
        (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
        (WebCore::RenderProgress::canHaveChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 6 Apr 2011 16:50:25 +0000 (16:50 +0000)]
2011-04-06  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Do not reference AccessibilityRenderObject from platform dependent code
        https://bugs.webkit.org/show_bug.cgi?id=57955

        Do not reference AccessibilityRenderObject from platform specific code

        Added new virtual functions to AccessibilityObject.h and removed
        explicit references to AccessibilityRenderObject from GTK code.

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::renderer): New virtual method,
        returning 0 by default. Overriden by AccessibilityRenderObject.
        (WebCore::AccessibilityObject::correspondingLabelForControlElement):
        New virtual method, returning 0 by default. It complements the
        already present method correspondingControlForLabelElement().

        * accessibility/AccessibilityRenderObject.h:
        (WebCore::AccessibilityRenderObject::renderer): Made virtual.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::emitTextChanged): Reference  AccessibilityObject,
        instead of AccessibilityRenderObject.
        (WebCore::AXObjectCache::nodeTextChangePlatformNotification):
        Ditto.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name): Do not reference
        AccessibilityRenderObject.
        (webkit_accessible_get_description): Ditto.
        (setAtkRelationSetFromCoreObject): Ditto.
        (optionFromList): Ditto.
        (optionFromSelection): Ditto.
        (webkit_accessible_selection_clear_selection): Ditto.
        (webkit_accessible_selection_get_selection_count): Ditto.
        (webkit_accessible_selection_select_all_selection): Ditto.
        (textForObject): Ditto.
        (webkit_accessible_text_get_text): Ditto.
        (getPangoLayoutForAtk): Ditto.
        (webkit_accessible_text_get_caret_offset): Ditto.
        (baselinePositionForRenderObject): Ditto.
        (getAttributeSetForAccessibilityObject): Ditto.
        (accessibilityObjectLength): Ditto.
        (getSelectionOffsetsForObject): Ditto.
        (webkit_accessible_text_set_selection): Ditto.
        (webkit_accessible_text_set_caret_offset): Ditto.
        (webkit_accessible_table_get_caption): Ditto.
        (getInterfaceMaskFromObject): Ditto.

        * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
        (getRangeLengthForObject): Ditto.

        Removed unused renderer() method from AccessibilityMenuList.

        * accessibility/AccessibilityMenuList.h: Removed unused method.
        * accessibility/AccessibilityMenuList.cpp: Removed unused method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 6 Apr 2011 16:39:52 +0000 (16:39 +0000)]
2011-04-06  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        cmake: Fix build for ARMv7

        * CMakeLists.txt: add missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 6 Apr 2011 16:19:34 +0000 (16:19 +0000)]
2011-04-06  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Javascipt warning link expand and overlap with icons in js console
        https://bugs.webkit.org/show_bug.cgi?id=57939

        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 6 Apr 2011 16:12:58 +0000 (16:12 +0000)]
2011-04-06  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
        https://bugs.webkit.org/show_bug.cgi?id=57931

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Wed, 6 Apr 2011 16:09:28 +0000 (16:09 +0000)]
2011-04-06  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
        https://bugs.webkit.org/show_bug.cgi?id=57665
        <rdar://problem/7350477>

        We need to track how user modified an autocorrected word. If he changed it back to original
        text, we want to record AutocorrectionReverted response. And if he changed it to something
        else, we want to record AutocorrectionEdited response.

        To achieve this, we need to distringuish between text replacement caused by autocorrection
        from that due to other causes, such as reversion, text substitution, etc. So we added a new
        marker type "Autocorrected". We also need to be able to check for correction, even when we
        don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
        value, "CheckForCorrection".

        We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
        specified range, and of specified type.

        * dom/DocumentMarker.h:
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::hasMarkers):
        * dom/DocumentMarkerController.h:
        * editing/Editor.cpp:
        (WebCore::markerTypesForAutocorrection):
        (WebCore::markersHaveIdenticalDescription):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection):
        (WebCore::Editor::changeBackToReplacedString):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        (WebCore::Editor::applyCorrectionPanelInfo):
        (WebCore::Editor::unappliedSpellCorrection):
        (WebCore::Editor::textCheckingTypeMaskFor):
        * editing/Editor.h:
        * editing/SpellingCorrectionCommand.cpp:
        (WebCore::SpellingCorrectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Liang Qi <liang.qi@nokia.com>
commit-queue@webkit.org [Wed, 6 Apr 2011 16:09:19 +0000 (16:09 +0000)]
2011-04-06  Liang Qi  <liang.qi@nokia.com>

        Reviewed by Benjamin Poulain.

        Correct a include file name.
        https://bugs.webkit.org/show_bug.cgi?id=57839

        * wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix
        builds on Unix hosts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix after r83056
aroben@apple.com [Wed, 6 Apr 2011 15:58:57 +0000 (15:58 +0000)]
Build fix after r83056

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 6 Apr 2011 15:54:44 +0000 (15:54 +0000)]
2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, add Chromium snow leopard baseline for meter-boundary-values

        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove JavaScriptCoreGenerated's file-copying logic out to a new script
aroben@apple.com [Wed, 6 Apr 2011 15:47:57 +0000 (15:47 +0000)]
Move JavaScriptCoreGenerated's file-copying logic out to a new script

Hopefully this will make it easier to modify this logic in the future. I also made the
script much quieter than the old logic, since it didn't seem helpful to see long lists of
filenames during the copying phase.

If we like this new style, we could copy it for our other projects.

Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
modify and noisy

Reviewed by Steve Falkenburg.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy
files from here...
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd
for convenience.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoORWT shouldn't generate diff files for tests without expected files
ossy@webkit.org [Wed, 6 Apr 2011 15:45:57 +0000 (15:45 +0000)]
ORWT shouldn't generate diff files for tests without expected files
https://bugs.webkit.org/show_bug.cgi?id=57846

Reviewed by Andreas Kling.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix using UNUSED_PARAM introduced in r82907
ossy@webkit.org [Wed, 6 Apr 2011 15:44:11 +0000 (15:44 +0000)]
Fix using UNUSED_PARAM introduced in r82907
https://bugs.webkit.org/show_bug.cgi?id=57940

Reviewed by Darin Adler.

* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Wed, 6 Apr 2011 15:41:18 +0000 (15:41 +0000)]
2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83045.
        http://trac.webkit.org/changeset/83045
        https://bugs.webkit.org/show_bug.cgi?id=57953

        Broke win layout tests (Requested by podivilov on #webkit).

        * inspector/debugger/script-formatter-expected.txt: Removed.
        * inspector/debugger/script-formatter.html: Removed.
        * platform/chromium/test_expectations.txt:
2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83045.
        http://trac.webkit.org/changeset/83045
        https://bugs.webkit.org/show_bug.cgi?id=57953

        Broke win layout tests (Requested by podivilov on #webkit).

        * GNUmakefile.am:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83053 268f45cc-cd09-0410-ab3c-d52691b4dbfc