WebKit-https.git
9 years agoCSS Aspect Ratio Property Parsing Stage
fsamuel@chromium.org [Fri, 4 Nov 2011 23:07:20 +0000 (23:07 +0000)]
CSS Aspect Ratio Property Parsing Stage
https://bugs.webkit.org/show_bug.cgi?id=70707

Reviewed by Ojan Vafai.

Source/WebCore:

Added parsing support for -webkit-aspect-ratio CSS property.
The spec can be found here: http://www.xanthir.com/blog/b4810

Test: fast/css/aspect-ratio-parsing-tests.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAspectRatioValue.cpp: Added.
(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
(WebCore::CSSAspectRatioValue::cssText):
* css/CSSAspectRatioValue.h: Added.
(WebCore::CSSAspectRatioValue::create):
(WebCore::CSSAspectRatioValue::numeratorValue):
(WebCore::CSSAspectRatioValue::denominatorValue):
(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSMutableStyleDeclaration.cpp:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAspectRatio):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

* fast/css/aspect-ratio-parsing-tests-expected.txt: Added.
* fast/css/aspect-ratio-parsing-tests.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Leopard-specific code from build.webkit.org
aroben@apple.com [Fri, 4 Nov 2011 22:52:26 +0000 (22:52 +0000)]
Remove Leopard-specific code from build.webkit.org

We don't have any Leopard bots anymore.

Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
and StopATSServer steps.
(unitTestsSupported): Removed check for mac-leopard.
(TestFactory.__init__): Removed Leopard-specific steps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelete FrameLoader::isSandboxed
abarth@webkit.org [Fri, 4 Nov 2011 22:50:54 +0000 (22:50 +0000)]
Delete FrameLoader::isSandboxed
https://bugs.webkit.org/show_bug.cgi?id=71591

Reviewed by Eric Seidel.

Source/WebCore:

We should always use document->securityOrigin()->isSandboxed because
that picks up the sandbox bits that are frozen on the document rather
than the ones that could change on the Frame.

This patch starts preparing us to implement the CSP sandbox directive,
which will cause use to have document sandbox bits without any attribute.

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
    - This call site was the only functional site left where these two
      could be different. This patch causes one progression and one
      regression. The progression is that we now correctly freeze the
      allow-scripts bit when a document is created, but the regression
      is we now allow the execution of JavaScript URLs, as noted in
      fast/frames/sandboxed-iframe-scripting.html. That's even more of
      an edge case, so I think it's a win overall.
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
    - I don't think this part of the change is testable. There's no
      time to execute script between when the bits get copied off the
      Frame and when they're checked, so there's no time to change them.
* loader/FrameLoader.cpp:
    - Update FIXME comment that is now fixed.
* loader/FrameLoader.h:
    - Remove wrong API.

LayoutTests:

This patch updates this test to check a few more cases and notes a bug
in our current implementation.

* fast/frames/resources/sandboxed-iframe-script-dynamic.html:
* fast/frames/sandboxed-iframe-scripting-expected.txt:
* fast/frames/sandboxed-iframe-scripting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen CSP blocks mixed content, we shouldn't also warn about mixed content
abarth@webkit.org [Fri, 4 Nov 2011 22:32:13 +0000 (22:32 +0000)]
When CSP blocks mixed content, we shouldn't also warn about mixed content
https://bugs.webkit.org/show_bug.cgi?id=71588

Reviewed by Eric Seidel.

Source/WebCore:

Getting both warnings confused some early adopters.  They thought the
insecure loads were happening even though they blocked them with CSP.
This patch restricts the mixed content warnings to show only when the
load isn't already blocked by CSP or by the embedder.

Test: http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

These tests check what kinds of warnings we generate when blocking insecure scripts with CSP.

* http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html: Added.
* http/tests/security/contentSecurityPolicy/resources/alert-fail.js: Added.
* http/tests/security/contentSecurityPolicy/resources/mixed-content-with-csp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow ScriptExecutionContext::addMessage to be called from background threads.
commit-queue@webkit.org [Fri, 4 Nov 2011 22:24:17 +0000 (22:24 +0000)]
Allow ScriptExecutionContext::addMessage to be called from background threads.
https://bugs.webkit.org/show_bug.cgi?id=71575

Patch by Michael Nordman <michaeln@google.coom> on 2011-11-04
Reviewed by Nate Chapin.

No new tests.

* dom/Document.cpp:
(WebCore::Document::addMessage):
* dom/ScriptExecutionContext.cpp:
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Re-named the original scissorRect to clipRect
commit-queue@webkit.org [Fri, 4 Nov 2011 22:16:25 +0000 (22:16 +0000)]
[chromium] Re-named the original scissorRect to clipRect
https://bugs.webkit.org/show_bug.cgi?id=71580

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-04
Reviewed by James Robinson.

Source/WebCore:

Existing tests are updated appropriately; and no new behavior is
introduced by this patch.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setUsesLayerClipping):
(WebCore::LayerChromium::usesLayerClipping):
(WebCore::LayerChromium::clipRect):
(WebCore::LayerChromium::setClipRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::clipRect):
(WebCore::RenderSurfaceChromium::setClipRect):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setUsesLayerClipping):
(WebCore::CCLayerImpl::usesLayerClipping):
(WebCore::CCLayerImpl::clipRect):
(WebCore::CCLayerImpl::setClipRect):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::clipRect):

Source/WebKit/chromium:

* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
eric@webkit.org [Fri, 4 Nov 2011 22:09:06 +0000 (22:09 +0000)]
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=71549

Reviewed by Adam Barth.

Several members of Host didn't really belong there
and were instead specific to WebKitPatch, so I've moved
them up onto that class.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/runtests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic: bring back party time!
tony@chromium.org [Fri, 4 Nov 2011 22:01:07 +0000 (22:01 +0000)]
garden-o-matic: bring back party time!
https://bugs.webkit.org/show_bug.cgi?id=71582

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd the ability to transfer ArrayBuffer and "neuter" it.
dslomov@google.com [Fri, 4 Nov 2011 21:43:56 +0000 (21:43 +0000)]
Add the ability to transfer ArrayBuffer and "neuter" it.
https://bugs.webkit.org/show_bug.cgi?id=71535

Reviewed by David Levin.

* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::transfer):
(WebCore::ArrayBufferContents::~ArrayBufferContents):
(WebCore::ArrayBufferContents::tryAllocate):
(WebCore::ArrayBuffer::addView):
(WebCore::ArrayBuffer::removeView):
* html/canvas/ArrayBuffer.h:
(WebCore::ArrayBufferContents::ArrayBufferContents):
(WebCore::ArrayBufferContents::data):
(WebCore::ArrayBufferContents::sizeInBytes):
(WebCore::ArrayBufferContents::release):
(WebCore::ArrayBuffer::~ArrayBuffer):
* html/canvas/ArrayBufferView.cpp:
(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::neuter):
* html/canvas/ArrayBufferView.h:
* html/canvas/DataView.cpp:
(WebCore::DataView::neuter):
(WebCore::DataView::neuterBinding):
* html/canvas/DataView.h:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::neuter):
(WebCore::TypedArrayBase::neuterBinding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r99315.
commit-queue@webkit.org [Fri, 4 Nov 2011 21:42:27 +0000 (21:42 +0000)]
Unreviewed, rolling out r99315.
http://trac.webkit.org/changeset/99315
https://bugs.webkit.org/show_bug.cgi?id=71589

baselines still broken after running rebaseline script
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-04

* platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
* platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
* platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
* platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
* platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
* platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r99285.
philn@webkit.org [Fri, 4 Nov 2011 21:39:08 +0000 (21:39 +0000)]
Unreviewed, GTK rebaseline after r99285.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a test for how CSP interacts with about:blank iframes
abarth@webkit.org [Fri, 4 Nov 2011 21:32:03 +0000 (21:32 +0000)]
Add a test for how CSP interacts with about:blank iframes
https://bugs.webkit.org/show_bug.cgi?id=71578

Reviewed by Dimitri Glazkov.

This issue came up in the discussion on
http://code.google.com/p/chromium/issues/detail?id=103038.  This patch
just adds a test to make sure we don't regress.

* http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agostop running perf LayoutTests in debug builds
tony@chromium.org [Fri, 4 Nov 2011 21:27:20 +0000 (21:27 +0000)]
stop running perf LayoutTests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=71513

Reviewed by Ojan Vafai.

This allows us to get rid of SLOW on some perf tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Implement canvas.toDataURL("image/webp")
noel.gordon@gmail.com [Fri, 4 Nov 2011 21:14:24 +0000 (21:14 +0000)]
[Chromium] Implement canvas.toDataURL("image/webp")
https://bugs.webkit.org/show_bug.cgi?id=70172

Reviewed by Adam Barth.

Source/WebCore:

Add a webp image encoder for the chromium skia ports, add it to the canvas
element toDataURL() flow with support for an optional quality [0.0-1.0].
Use a webp compression method (3) that provides good speed and compression
performance for this image format, and works well for various input image
types: line-art, screen-shots, and photographic images.

Test: fast/canvas/canvas-toDataURL-webp.html

* WebCore.gypi:
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageToDataURL):
* platform/image-encoders/skia/WEBPImageEncoder.cpp: Added.
(WebCore::writeOutput):
(WebCore::importPicture):
(WebCore::importPictureBGRA):
(WebCore::importPictureRGBA):
(WebCore::encodePixels):
(WebCore::WEBPImageEncoder::encode):
* platform/image-encoders/skia/WEBPImageEncoder.h: Added.

LayoutTests:

* fast/canvas/canvas-toDataURL-webp-expected.txt: Added.
* fast/canvas/canvas-toDataURL-webp.html: Added.
* platform/chromium/test_expectations.txt: skip test on MAC CPU-CG (CoreGraphics)
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT: Fix the order of the items in the dumped history list.
commit-queue@webkit.org [Fri, 4 Nov 2011 21:04:14 +0000 (21:04 +0000)]
[EFL] DRT: Fix the order of the items in the dumped history list.
https://bugs.webkit.org/show_bug.cgi?id=71562

It did not make much sense to hold the history list in a map, as we do not need
the keys. And the printed items must be sorted by target, which is more easily
done with a vector.

Should make tests such as http/tests/navigation/error404-frames.html pass.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::childHistoryItems):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpHistoryItem.cpp:
(compareHistoryItemsByTarget):
(dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove ENABLE_SQLITE from qmake files
paroga@webkit.org [Fri, 4 Nov 2011 21:00:11 +0000 (21:00 +0000)]
[Qt] Remove ENABLE_SQLITE from qmake files
https://bugs.webkit.org/show_bug.cgi?id=71546

Reviewed by Simon Hausmann.

Source/WebCore:

ENABLE_SQLITE is required to build WebCore, so remove conditions.

* Target.pri:

Tools:

* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/webcore.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout Test storage/indexeddb/exception-in-event-aborts.html is failing
arv@chromium.org [Fri, 4 Nov 2011 20:58:00 +0000 (20:58 +0000)]
Layout Test storage/indexeddb/exception-in-event-aborts.html is failing
https://bugs.webkit.org/show_bug.cgi?id=71536

Unreviewed. Updated test and expectations.

* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed expectation rebaseline from r99286.
enne@google.com [Fri, 4 Nov 2011 20:55:37 +0000 (20:55 +0000)]
[chromium] Unreviewed expectation rebaseline from r99286.

* platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
* platform/chromium-gpu/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png.
* platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png.
* platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png.
* platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png.
* platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowatchlist for WebIDL shouldn't trigger on Internals.idl
abarth@webkit.org [Fri, 4 Nov 2011 20:48:52 +0000 (20:48 +0000)]
watchlist for WebIDL shouldn't trigger on Internals.idl
https://bugs.webkit.org/show_bug.cgi?id=70657

Reviewed by David Levin.

Internals.idl isn't part of the Web-facing IDL in the project.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale...
tony@chromium.org [Fri, 4 Nov 2011 20:43:14 +0000 (20:43 +0000)]
[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale-test2.html
https://bugs.webkit.org/show_bug.cgi?id=71587

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::hasInstance
mhahnenberg@apple.com [Fri, 4 Nov 2011 20:37:32 +0000 (20:37 +0000)]
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Null out V8NPObject::rootObject when the owning
japhet@chromium.org [Fri, 4 Nov 2011 20:24:38 +0000 (20:24 +0000)]
[V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
* bindings/v8/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSend the submissions character encoding in hidden _charset_ field.
commit-queue@webkit.org [Fri, 4 Nov 2011 19:53:21 +0000 (19:53 +0000)]
Send the submissions character encoding in hidden _charset_ field.
https://bugs.webkit.org/show_bug.cgi?id=19079

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.

Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
       http/tests/misc/char-encoding-in-text-charset-field-with-value.html
       http/tests/misc/char-encoding-without-charset-field.html

* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::isHiddenType):
(WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.
* html/HiddenInputType.h: Override appendFormData for hidden control types.

LayoutTests:

Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Added test cases to check this behavior.

* http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
* http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
* http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
* http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
* http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
* http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 4 Nov 2011 19:29:09 +0000 (19:29 +0000)]
2011-11-04  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: marked inspector/debugger/script-formatter.html
        as skipped for now - sorting it out.

        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
commit-queue@webkit.org [Fri, 4 Nov 2011 19:12:19 +0000 (19:12 +0000)]
[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
https://bugs.webkit.org/show_bug.cgi?id=71563

Patch by Robert Sesek <rsesek@chromium.org> on 2011-11-04
Reviewed by Adam Barth.

Source/WebCore:

Use libWebKitSystemInterfaceLeopard.a that's in the Chromium port,
rather in WebKitLibraries/.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Roll Chromium DEPS r108107:108476 to pull in
libWebKitSystemInterfaceLeopard.a.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderLayer::styleChanged invalidates the GraphicsLayer needlessly
jchaffraix@webkit.org [Fri, 4 Nov 2011 18:52:53 +0000 (18:52 +0000)]
RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
https://bugs.webkit.org/show_bug.cgi?id=71517

Reviewed by Simon Fraser.

Unused code removal covered by existing tests.

The current code is invalidating the whole RenderLayerBacking as part of
a style change. However this is redundant with the repainting logic which
would invalidate only the necessary bits.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Remove the invalidation code as it duplicates and defeats the repaint logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect parsing of incomplete @-webkit-region rules.
mihnea@adobe.com [Fri, 4 Nov 2011 18:38:20 +0000 (18:38 +0000)]
Correct parsing of incomplete @-webkit-region rules.
https://bugs.webkit.org/show_bug.cgi?id=71514

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/regions/parse-incomplete-region-rule.html

Make sure to set the region rule to 0 on the fail branch.
* css/CSSGrammar.y:

LayoutTests:

* fast/regions/parse-incomplete-region-rule-expected.txt: Added.
* fast/regions/parse-incomplete-region-rule.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce refcount churn in ChildListMutationScope
adamk@chromium.org [Fri, 4 Nov 2011 18:34:00 +0000 (18:34 +0000)]
Reduce refcount churn in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=71527

Reviewed by Ryosuke Niwa.

Only the ChildListMutationAccumulator needs to hold a reference to the
target node, and the added/removed children only need be ref'd if a
ChildListMutationAccumulator exists (i.e., if there are interested
observers).

* dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):
* dom/ChildListMutationScope.h:
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
hausmann@webkit.org [Fri, 4 Nov 2011 18:28:31 +0000 (18:28 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Forgot to skip this test also in r99296.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect usage of LayoutUnits in RenderImage and SVGImage
leviw@chromium.org [Fri, 4 Nov 2011 18:27:35 +0000 (18:27 +0000)]
Correct usage of LayoutUnits in RenderImage and SVGImage
https://bugs.webkit.org/show_bug.cgi?id=71525

Reviewed by Darin Adler.

Correcting incorrect usage of LayoutUnits for image sizes that should be integers and fixing overloaded functions that
should be using LayoutUnits.

No new tests -- no change in behavior.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::nodeAtPoint):
(WebCore::RenderImage::computeReplacedLogicalWidth):
* rendering/RenderImage.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix WKTR crash when running NPN_ConvertPoint test.
andersca@apple.com [Fri, 4 Nov 2011 18:20:11 +0000 (18:20 +0000)]
Fix WKTR crash when running NPN_ConvertPoint test.

Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement allow-popups for iframe@sandbox
abarth@webkit.org [Fri, 4 Nov 2011 18:14:58 +0000 (18:14 +0000)]
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Darin Adler.

Source/WebCore:

Enable allow-popups sandbox bit.  My previous patch attempted to
forward the sandbox bits during setOpener, but that interacted poorly
with out (internal) sandboxing of the initial document.  This patch
forwards the bits during createWindow, which is more targeted to the
case when a sandbox frame actually creates a new window.

* loader/FrameLoader.cpp:
(WebCore::createWindow):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

Update test results to show that we now pass.

* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt:
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html:
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html:
* http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt:
* http/tests/security/popup-allowed-by-sandbox-when-allowed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPN_ConvertPoint plug-in test should be called from NPP_SetWindow
andersca@apple.com [Fri, 4 Nov 2011 18:12:58 +0000 (18:12 +0000)]
NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=71570

Reviewed by Simon Fraser.

Tools:

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Remove the NPP parameter from NPP_SetWindow.

* DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
(NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow.

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):
Run the test from NPP_SetWindow and call notifyDone() when done.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):
Remove unnecessary parameter.

LayoutTests:

Add a call to layoutTestController.waitUntilDone(); the plug-in will call notifyDone() when it's done.
* platform/mac/plugins/convert-point.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove initMediaStreamEvent method
commit-queue@webkit.org [Fri, 4 Nov 2011 18:11:47 +0000 (18:11 +0000)]
Remove initMediaStreamEvent method
https://bugs.webkit.org/show_bug.cgi?id=71344

This method has been removed from the spec draft.
http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-04
Reviewed by Adam Barth.

No new tests. Removed method.

* mediastream/MediaStreamEvent.cpp:
* mediastream/MediaStreamEvent.h:
* mediastream/MediaStreamEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnonymous CORS fetch for WebGL texture fails when there is no appropriate server...
abarth@webkit.org [Fri, 4 Nov 2011 18:09:36 +0000 (18:09 +0000)]
Anonymous CORS fetch for WebGL texture fails when there is no appropriate server response even for the same origin requests
https://bugs.webkit.org/show_bug.cgi?id=71053

Reviewed by Darin Adler.

Source/WebCore:

The crossorigin attribute should behave like XMLHttpRequest:
same-origin images pass without and CORS headers, but CORS checks are
performed for cross-origin loads.  This patch better aligns our
behavior with Firefox, as discussed in the bug.

Test: http/tests/security/img-crossorigin-loads-same-origin.html

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that we succeed in loading a same-origin image without the help of
CORS even if the image has the crossorigin attribute.

* http/tests/security/img-crossorigin-loads-same-origin-expected.txt: Added.
* http/tests/security/img-crossorigin-loads-same-origin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLKeygenElement: Fix "keytype" handling in appendFormData.
commit-queue@webkit.org [Fri, 4 Nov 2011 17:55:14 +0000 (17:55 +0000)]
HTMLKeygenElement: Fix "keytype" handling in appendFormData.
https://bugs.webkit.org/show_bug.cgi?id=70617

This fixes a bug introduced by http://trac.webkit.org/changeset/97658
which causes all HTML Keygen elements with a keytype optional attribute
to be considered as unsupported.

A regression test is included.

Patch by Gaurav Shah <gauravsh@chromium.org> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/misc/submit-post-keygen.html

* html/HTMLKeygenElement.cpp:

LayoutTests:

* http/tests/misc/resources/check-keygen-post.php: Added.
* http/tests/misc/submit-post-keygen-expected.txt: Added.
* http/tests/misc/submit-post-keygen.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Temporarily skip failing tests after the build system refactoring.
hausmann@webkit.org [Fri, 4 Nov 2011 17:51:11 +0000 (17:51 +0000)]
[Qt] Temporarily skip failing tests after the build system refactoring.

Rubber-stamped by Ossy.

Bug #71571 tracks the failure so we can look into it next week.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Implement checkerboarding for missing layer tiles
enne@google.com [Fri, 4 Nov 2011 17:45:28 +0000 (17:45 +0000)]
[chromium] Implement checkerboarding for missing layer tiles
https://bugs.webkit.org/show_bug.cgi?id=69585

Reviewed by James Robinson.

Source/WebCore:

For tiles that have no texture or haven't even been created yet,
draw using the background color of the layer.

The only background color set is currently the non-composited content,
and all other layers use transparent black by default.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setBackgroundColor):
* platform/graphics/chromium/NonCompositedContentHost.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setBackgroundColor):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::backgroundColor):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):

Source/WebKit/chromium:

To pipe the background color of the document to the non-composited
host, set it during paint. This may be more frequent than necessary,
but it'll catch all style changes.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::nonCompositedContentHost):
(WebKit::WebViewImplContentPainter::paint):
* src/WebViewImpl.h:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix run-qtwebkit-tests execution on the build bot(s).
hausmann@webkit.org [Fri, 4 Nov 2011 17:41:15 +0000 (17:41 +0000)]
[Qt] Fix run-qtwebkit-tests execution on the build bot(s).

Rubber-stamped by Tor Arne Vestbø.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
changed slightly after the refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove most exit time destructors
thakis@chromium.org [Fri, 4 Nov 2011 17:37:25 +0000 (17:37 +0000)]
[chromium] Remove most exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=71524

Do this by using the DEFINE_STATIC_LOCAL macro, which allocates things on the heaps and then leaks them.

Reviewed by Dimitri Glazkov.

No behavior change, so no new tests.

* platform/chromium/CursorChromium.cpp:
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::aliasCursor):
(WebCore::progressCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::dummyHashSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed expectations update.
enne@google.com [Fri, 4 Nov 2011 17:29:25 +0000 (17:29 +0000)]
[chromium] Unreviewed expectations update.

Temporarily mark a few tests as failing from r99286 due to tiny
differences on scrollbars. Can be rebaselined once all bots cycle.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Expose deviceScaleFactor to WebKit API
fsamuel@chromium.org [Fri, 4 Nov 2011 17:10:03 +0000 (17:10 +0000)]
[Chromium] Expose deviceScaleFactor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=70614

Reviewed by Darin Fisher.

This exposes the device scale factor to the Chromium-WebKit API.
This scale factor is the ratio between the current device's DPI
and the target device's DPI.

For details on how this can be accessed from CSS and javascript, please
see here:

http://developer.android.com/guide/webapps/targeting.html#DensityCSS

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::deviceScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
vestbo@webkit.org [Fri, 4 Nov 2011 17:06:06 +0000 (17:06 +0000)]
[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes

Reviewed by Simon Hausmann.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NetscapePlugin::convertFromRootView
andersca@apple.com [Fri, 4 Nov 2011 17:04:15 +0000 (17:04 +0000)]
Add NetscapePlugin::convertFromRootView
https://bugs.webkit.org/show_bug.cgi?id=71526

Reviewed by Sam Weinig.

Source/WebCore:

Export some symbols that WebKit2 needs.

* WebCore.exp.in:

Source/WebKit2:

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::convertFromRootView):
New function that converts a point from root view coordinates to plug-in coordinates.
Returns false if the conversion can't be done.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::fillInCocoaEventFromMouseEvent):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Use convertFromRootView instead of subtracting m_frameRectInWindowCoordinates.location() from the
event position (which is in root view coordinates).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix svn properties on layout test result files I checked in.
tony@chromium.org [Fri, 4 Nov 2011 17:00:15 +0000 (17:00 +0000)]
Fix svn properties on layout test result files I checked in.

* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
* platform/chromium-win/printing/setPrinting-expected.txt: Added property svn:eol-style.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
* platform/mac/printing/setPrinting-expected.txt: Added property svn:eol-style.
* platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't error out on wrong Qt version when qmake does recursive includes
vestbo@webkit.org [Fri, 4 Nov 2011 16:55:42 +0000 (16:55 +0000)]
[Qt] Don't error out on wrong Qt version when qmake does recursive includes

Reviewed by Simmon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix incorrect visibility/scissor rect for threaded compositing
enne@google.com [Fri, 4 Nov 2011 16:41:19 +0000 (16:41 +0000)]
[chromium] Fix incorrect visibility/scissor rect for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70962

Reviewed by James Robinson.

Source/WebCore:

In order to properly scroll independent of layout on the compositor
thread, we have to apply the scroll to the right layer. Previously,
the NonCompositedContentHost was the root of the graphics layer tree
with all other layers underneath it. However, applying a scroll to
that layer would also scroll the clip layer for the main frame
underneath it, causing visibility issues.

This patch moves the NonCompositedHost to be a child of the
RenderLayerCompositor's scroll layer. This was exposed on
RenderLayerCompositor, because there's no other way to get to this
layer in a way that doesn't make assumptions about the structure of
the layers on a frame.

This also removes the hacks in calculateVisibleLayerRect and
tilingTransform for scroll position.

Partially tested by existing compositor tests. Manually tested
threaded compositing scrolling.

* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setScrollLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::scrollLayer):
* platform/graphics/chromium/NonCompositedContentHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::applyScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scrollLayer):
* rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Disable VIDEO_TRACK for now
philn@webkit.org [Fri, 4 Nov 2011 16:09:24 +0000 (16:09 +0000)]
[GTK] Disable VIDEO_TRACK for now
https://bugs.webkit.org/show_bug.cgi?id=71547

Reviewed by Gustavo Noronha Silva.

.:

* configure.ac: VIDEO_TRACK is still a moving target, it's best to
disable it for now.

LayoutTests:

Skip media/track tests and rebaseline involved fast/dom test results.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 4 Nov 2011 15:48:51 +0000 (15:48 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Disable inspector tests temporarily because of a bug near build system refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: 8th chunk of baselines for Chromium-Skia
caryclark@google.com [Fri, 4 Nov 2011 15:31:12 +0000 (15:31 +0000)]
Unreviewed gardening: 8th chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 602 of 608 files for brevity.]

* platform/chromium-mac-leopard/css3/bdi-element-expected.png: Added.
* platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
...
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
* platform/chromium-mac-leopard/transforms/svg-vs-css-expected.png: Added.
* platform/chromium-mac-leopard/transitions/move-after-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Disable STDIN check before cleaning build dir
vestbo@webkit.org [Fri, 4 Nov 2011 15:29:40 +0000 (15:29 +0000)]
[Qt] Disable STDIN check before cleaning build dir

It didn't work on the bots.

Reviewed by Ossy.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't build all of webkit when running build-jsc
vestbo@webkit.org [Fri, 4 Nov 2011 15:20:50 +0000 (15:20 +0000)]
[Qt] Don't build all of webkit when running build-jsc

In case the whole webkit project was built, but we then subsequently
want to build only JSC, we need to run make in the proper subdirectory.

This also means the incremental target needs to be added to all
makefiles.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir
vestbo@webkit.org [Fri, 4 Nov 2011 15:20:32 +0000 (15:20 +0000)]
[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix run-javascriptcore-tests for Qt when it's executed by the bot.
hausmann@webkit.org [Fri, 4 Nov 2011 14:54:05 +0000 (14:54 +0000)]
Fix run-javascriptcore-tests for Qt when it's executed by the bot.

Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(jscProductDir): jsc path changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Error out early if trying to build against Qt < 4.8
vestbo@webkit.org [Fri, 4 Nov 2011 14:03:20 +0000 (14:03 +0000)]
[Qt] Error out early if trying to build against Qt < 4.8

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix run-launcher for Qt and Gtk.
hausmann@webkit.org [Fri, 4 Nov 2011 13:47:23 +0000 (13:47 +0000)]
Fix run-launcher for Qt and Gtk.

Rubber-stamped by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(isWK2): Re-add isWK2(), as it's used in run-launcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
vestbo@webkit.org [Fri, 4 Nov 2011 13:39:40 +0000 (13:39 +0000)]
[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use web view title as window title in MiniBrowser
carlosgc@webkit.org [Fri, 4 Nov 2011 13:37:12 +0000 (13:37 +0000)]
[GTK] Use web view title as window title in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71544

Reviewed by Philippe Normand.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewURIChanged): Removed extra space.
(webViewTitleChanged): Set window title using
webkit_web_view_get_title().
(browser_window_init): Set initial default window title.
(browserWindowConstructed): Connect to WebView notify::title
signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Refactor and clean up the qmake build system
vestbo@webkit.org [Fri, 4 Nov 2011 13:19:58 +0000 (13:19 +0000)]
[Qt] Refactor and clean up the qmake build system

The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.

This is a short-list of the changes:

  * The rules for how to build targets are now mostly contained as
    prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
    allows us to do pre- and post-processing of each project file,
    which helps to clean up the actual project files.

  * Derived sources are no longer generated as a separate make-step
    but is part of each target's project file as a subdir. Makefile
    rules are used to ensure that we run make on the derived sources
    before running qmake on the actual target makefile. This makes
    it easier to keep a proper dependency between derived sources
    and the target.

  * We use GNU make and the compiler to generate dependencies on
    UNIX-based systems running Qt 5. This allows us to lessen the
    need to run qmake, which should reduce compile time.

  * WebKit2 is now build by default if building with Qt 5. It can
    be disabled by passing --no-webkit2 to build-webkit.

The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.

https://bugs.webkit.org/show_bug.cgi?id=71222

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Support programmatic scrolling with the QTouchWebView
kenneth@webkit.org [Fri, 4 Nov 2011 12:28:18 +0000 (12:28 +0000)]
[Qt] Support programmatic scrolling with the QTouchWebView

Reviewed by Simon Hausmann.

As more code can be shared between the programmatic scrolling and the
method for ensuring that the contents are within valid bounds, this
patch includes a bit of refactoring as well.

* UIProcess/API/qt/qdesktopwebview_p.h:
(QDesktopWebViewPrivate::scrollPositionRequested):
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scrollPositionRequested):
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::scrollPositionRequested):
* UIProcess/qt/QtTouchViewInterface.h:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::event):
(WebKit::boundPosition):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::pageDidRequestScroll):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
commit-queue@webkit.org [Fri, 4 Nov 2011 11:23:18 +0000 (11:23 +0000)]
[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=71548

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-04
Reviewed by Tony Gentilcore.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove deprecated free functions in port.factory
eric@webkit.org [Fri, 4 Nov 2011 09:20:06 +0000 (09:20 +0000)]
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed.  Fixing exception seen when running test-webkitpy.

Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
unittest, since that script is nearly ready to be deleted.  But I added
it back at the last second and failed to run the tests. :(
This fixes the exception the bots were seeing.

* Scripts/webkitpy/style/checkers/test_expectations.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WINCE] Use default LocalizationStrategy
paroga@webkit.org [Fri, 4 Nov 2011 09:13:14 +0000 (09:13 +0000)]
[WINCE] Use default LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=71495

Reviewed by Adam Roben.

Use LocalizationStrategy from WebCore instead of using a copy of the strings in WebKit.

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
* WebCoreSupport/PlatformStrategiesWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip some fast/viewport failing tests on GTK after r99195.
philn@webkit.org [Fri, 4 Nov 2011 09:04:22 +0000 (09:04 +0000)]
Unreviewed, skip some fast/viewport failing tests on GTK after r99195.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Use standard booleand data type.
gyuyoung.kim@samsung.com [Fri, 4 Nov 2011 08:53:20 +0000 (08:53 +0000)]
[EFL] Use standard booleand data type.
https://bugs.webkit.org/show_bug.cgi?id=71433

This is a fourth step in order to be more compliant with WebKit coding style.
Use standard boolean data type instead of efl boolean data type. It makes efl port
is more close to webkit coding style.

Reviewed by Zoltan Herczeg.

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
* ewk/ewk_contextmenu.cpp:
* ewk/ewk_cookies.cpp:
* ewk/ewk_frame.cpp:
* ewk/ewk_history.cpp:
* ewk/ewk_js.cpp:
* ewk/ewk_main.cpp:
* ewk/ewk_network.cpp:
* ewk/ewk_private.h:
* ewk/ewk_protocol_handler.cpp:
* ewk/ewk_protocol_handler_soup.cpp:
* ewk/ewk_settings.cpp:
* ewk/ewk_tiled_backing_store.cpp:
* ewk/ewk_tiled_matrix.cpp:
* ewk/ewk_tiled_model.cpp:
* ewk/ewk_util.cpp:
* ewk/ewk_view.cpp:
* ewk/ewk_view_single.cpp:
* ewk/ewk_view_tiled.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed CMake build fix for !ENABLE(SQL_DATABASE).
paroga@webkit.org [Fri, 4 Nov 2011 08:20:50 +0000 (08:20 +0000)]
Unreviewed CMake build fix for !ENABLE(SQL_DATABASE).

* CMakeLists.txt: Always compile the SQLite source files, since they are required for build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
yutak@chromium.org [Fri, 4 Nov 2011 08:06:45 +0000 (08:06 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt: Add more expectations for recent test flakinesses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore code clean-up in DFG 32_64
commit-queue@webkit.org [Fri, 4 Nov 2011 07:45:37 +0000 (07:45 +0000)]
More code clean-up in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71540

Remove unnecessary code duplications, and fix compilation warnings.

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-04
Reviewed by Gavin Barraclough.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::hasInstance
ossy@webkit.org [Fri, 4 Nov 2011 07:35:18 +0000 (07:35 +0000)]
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Unreviewed rolling out r99238, because it made a test crash on all platform.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, forgot to skip a new test in r99261.
eric.carlson@apple.com [Fri, 4 Nov 2011 04:53:36 +0000 (04:53 +0000)]
Unreviewed, forgot to skip a new test in r99261.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r99076): Pasting into password fields is broken
rniwa@webkit.org [Fri, 4 Nov 2011 04:52:03 +0000 (04:52 +0000)]
REGRESSION (r99076): Pasting into password fields is broken
https://bugs.webkit.org/show_bug.cgi?id=71483

Reviewed by Darin Adler.

The bug was caused by plainText serializing secured (instead of original) text.
Fixed the bug by adding new TextIterator behavior that serializes the original text
and using it in ReplacementFragment::ReplacementFragment.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::emitText):
* editing/TextIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd TrackEvent
eric.carlson@apple.com [Fri, 4 Nov 2011 04:18:05 +0000 (04:18 +0000)]
Add TrackEvent
https://bugs.webkit.org/show_bug.cgi?id=71178

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/track-event-constructor.html

* CMakeLists.txt: Add new files for TrackEvent.
* CodeGenerators.pri: Ditto.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* GNUmakefile.am: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/generic/EventConstructors.h: Ditto.
* bindings/gobject/GNUmakefile.am: Ditto.
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add method to convert to a Track.
* bindings/js/JSDictionary.h:

* bindings/js/JSEventConstructors.cpp:  Add new files for TrackEvent.

* bindings/js/JSTrackCustom.cpp: Added.
(WebCore::toTrack): New, convert from a JSValue to a Track.
(WebCore::toJS): New, return a JS wrapper for a Track.
* bindings/js/JSTrackCustom.h: Added.

* bindings/js/JSTrackEventCustom.cpp: Added.
(WebCore::JSTrackEvent::track): New, returns a TextEvent's 'track' attribute.

* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get): Returns RefPtr<TrackBase>.

* bindings/v8/custom/V8EventConstructors.cpp: Add Track initializing constructor.

* bindings/v8/custom/V8TrackEventCustom.cpp: Added.
(WebCore::V8TrackEvent::trackAccessorGetter): New, returns a TextEvent's 'track' attribute.

* dom/EventFactory.in: Add TrackEvent.

* dom/EventNames.h: Add 'addtrack' event.

* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Call new base class constructor.
* html/TextTrack.h: Now derive from BaseTrack for the day we implement VideoTrack and AudioTrack.

* html/track/TrackBase.cpp: Added.
(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::~TrackBase):
* html/track/TrackBase.h: Added.
(WebCore::TrackBase::type): Return the track type.

* html/track/TrackEvent.cpp: Added.
(WebCore::TrackEventInit::TrackEventInit):
(WebCore::TrackEvent::TrackEvent):
(WebCore::TrackEvent::~TrackEvent):
(WebCore::TrackEvent::interfaceName):
* html/track/TrackEvent.h: Added.
(WebCore::TrackEvent::create):
(WebCore::TrackEvent::isTrackEvent):
(WebCore::TrackEvent::track):
* html/track/TrackEvent.idl: Added.

* page/DOMWindow.idl: Add TrackEvent.

LayoutTests:

* fast/events/constructors/track-event-constructor-expected.txt: Added.
* fast/events/constructors/track-event-constructor.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
yutak@chromium.org [Fri, 4 Nov 2011 03:44:30 +0000 (03:44 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt: Apply recent expectation changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Remove successfullyParsed from more tests
arv@chromium.org [Fri, 4 Nov 2011 02:16:03 +0000 (02:16 +0000)]
JS Test Harness: Remove successfullyParsed from more tests
https://bugs.webkit.org/show_bug.cgi?id=71533

Reviewed by Ojan Vafai.

* LayoutTests/*: Remove successfullyParsed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize canvas fills / drawImage when covering entire canvas
commit-queue@webkit.org [Fri, 4 Nov 2011 01:55:30 +0000 (01:55 +0000)]
Optimize canvas fills / drawImage when covering entire canvas
https://bugs.webkit.org/show_bug.cgi?id=70789

Patch by Ben Wells <benwells@chromium.org> on 2011-11-03
Reviewed by Stephen White.

If we're filling a rect or drawing an image, and it covers the entire canvas, we don't
need to worry about clearing outside the area updated by the operation if we're in
a composite mode that requires this (such as source-in, copy, etc.). In this case we
can take the simple path through the code and save a clear (for copy) or a temporary
image buffer (for the other modes).

No new tests - optimization, behaviour is unchanged and covered by existing tests.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::rectContainsCanvas):
* html/canvas/CanvasRenderingContext2D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::getPropertyNames
mhahnenberg@apple.com [Fri, 4 Nov 2011 01:32:18 +0000 (01:32 +0000)]
De-virtualize JSObject::getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71306

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getPropertyNames):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
* runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
* runtime/Structure.h:

Source/JavaScriptGlue:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):

Source/WebCore:

No new tests.

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getPropertyNames):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getPropertyNames):
* bindings/js/JSDOMWindowShell.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariantMap):

Source/WebKit/mac:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
xji@chromium.org [Fri, 4 Nov 2011 01:18:16 +0000 (01:18 +0000)]
Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
https://bugs.webkit.org/show_bug.cgi?id=71163

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add m_visualWordMovementEnabled page setting, trigger visual word movement
function (instead of logical one) when it is set as true.

right|leftWordPosition() are tested in editing/selection/move-by-word-visually*
by using --webkit-visual-word flag.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::visualWordMovementEnabled):
* editing/FrameSelection.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setVisualWordMovementEnabled):
(WebCore::Settings::visualWordMovementEnabled):

Source/WebKit/chromium:

To minimize the risk to LTR users, we enable this feature first to chromium win
by command line flag. This and corresponding changset in chromium
(http://codereview.chromium.org/8400078/)
should be removed after this feature is enabled without command line flag.

The work flow is:
1. (chromium) adds command line flag --enable-visual-word-movement,
   pass it to WebCore::Settings through WebPreferences.
2. in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings,
   trigger visual word movement instead of logical one.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setVisualWordMovementEnabled):
* src/WebSettingsImpl.h:

Tools:

* DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
(WebPreferences::applyTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect usage of LayoutUnits and integers in Table rendering classes
leviw@chromium.org [Fri, 4 Nov 2011 00:56:59 +0000 (00:56 +0000)]
Correct usage of LayoutUnits and integers in Table rendering classes
https://bugs.webkit.org/show_bug.cgi?id=71500

Reviewed by Darin Adler.

Fixing the Table layout classes to operate on integers -- sub-pixel table layout breaks
the spec. Meanwhile correcting the Table rendering classes themselves to still use
LayoutUnits.

No new tests -- no change in behavior.

* rendering/AutoTableLayout.cpp: Reverting to operating on integers.
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
* rendering/AutoTableLayout.h: Reverting to operating on integers.
* rendering/FixedTableLayout.cpp: Ditto.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):
* rendering/RenderTable.h: Switching to LayoutUnits.
(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
* rendering/RenderTableCell.cpp: Switching to LayoutUnits.
(WebCore::RenderTableCell::updateLogicalWidth):
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::cellBaselinePosition):
(WebCore::RenderTableCell::scrollbarsChanged):
* rendering/RenderTableCell.h: Switching to LayoutUnits
* rendering/RenderTableSection.cpp: Ditto.
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
jamesr@google.com [Fri, 4 Nov 2011 00:31:27 +0000 (00:31 +0000)]
[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
https://bugs.webkit.org/show_bug.cgi?id=71381

Reviewed by Kenneth Russell.

* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::didSwapBuffers):
* platform/graphics/chromium/cc/CCScheduler.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Added ewk_tile_memory_size_get function
commit-queue@webkit.org [Fri, 4 Nov 2011 00:27:07 +0000 (00:27 +0000)]
[EFL] Added ewk_tile_memory_size_get function
https://bugs.webkit.org/show_bug.cgi?id=71213

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-03
Reviewed by Anders Carlsson.

Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup
the code.

* ewk/ewk_tiled_model.cpp:
(ewk_tile_memory_size_get):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):
* ewk/ewk_tiled_model.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Stub.h and Stub.cpp to Source-level WTF project
abarth@webkit.org [Fri, 4 Nov 2011 00:17:48 +0000 (00:17 +0000)]
Add Stub.h and Stub.cpp to Source-level WTF project
https://bugs.webkit.org/show_bug.cgi?id=71497

Reviewed by Eric Seidel.

This patch adds some stub files and a skelton GYP build file as a
starting point for the new Source-level WTF project.  Other build
systems and actual code will arrive in future patches.

* Stub.cpp: Added.
* Stub.h: Added.
* WTF.gyp/WTF.gyp: Added.
* WTF.gypi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of NetscapePlugin::m_clipRectInWindowCoordinates
andersca@apple.com [Fri, 4 Nov 2011 00:13:45 +0000 (00:13 +0000)]
Get rid of NetscapePlugin::m_clipRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71521

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location...
andersca@apple.com [Fri, 4 Nov 2011 00:13:39 +0000 (00:13 +0000)]
Use convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location() where possible
https://bugs.webkit.org/show_bug.cgi?id=71520

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an obsolete comment.
tony@chromium.org [Fri, 4 Nov 2011 00:10:18 +0000 (00:10 +0000)]
Remove an obsolete comment.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NetscapePlugin::convertToRootView
andersca@apple.com [Thu, 3 Nov 2011 23:55:21 +0000 (23:55 +0000)]
Add NetscapePlugin::convertToRootView
https://bugs.webkit.org/show_bug.cgi?id=71519

Reviewed by Darin Adler.

Yet another step towards eliminating uses of m_frameRectInWindowCoordinates.

Also, use the "root view" terminology, since that's really what we mean here.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
Use convertToRootView to get the plug-in location and clip rect in root view coordinates.

(WebKit::NetscapePlugin::convertToRootView):
Apply the m_pluginToRootViewTransform.mapPoint transform.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add convertToRootView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl
dbates@webkit.org [Thu, 3 Nov 2011 23:42:29 +0000 (23:42 +0000)]
CMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl

Rubber-stamped by Martin Robinson

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCMake: Only generate from WebGL IDLs when building with WebGL
dbates@webkit.org [Thu, 3 Nov 2011 23:35:04 +0000 (23:35 +0000)]
CMake: Only generate from WebGL IDLs when building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=71516

Reviewed by Martin Robinson.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove support for LegacyDefaultOptionalArguments
arv@chromium.org [Thu, 3 Nov 2011 23:26:47 +0000 (23:26 +0000)]
Remove support for LegacyDefaultOptionalArguments
https://bugs.webkit.org/show_bug.cgi?id=71489

Reviewed by Darin Adler.

This removes support for LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise].
[RequiresAllArguments=Raise] is now the standard behavior so it would be a no op.

No new tests. Covered by existing tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateArgumentsCountCheck): Check the "RequiresAllArguments" extended attribute and generate code
                               that returns undefined if there are missing arguments.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateArgumentsCountCheck): Ditto.
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): Add generated argument count checks.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Ditto.
(WebCore::jsTestObjPrototypeFunctionIdbKey): Ditto.
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Ditto.
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): Ditto.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): Ditto.
* bindings/scripts/test/TestCallback.idl: Remove LegacyDefaultOptionalArguments.
* bindings/scripts/test/TestMediaQueryListListener.idl: Ditto.
* bindings/scripts/test/TestObj.idl: Remove LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise]
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Remove LegacyDefaultOptionalArguments.
(WebCore::TestMediaQueryListListenerInternal::methodCallback): Add generated argument count checks.
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::intMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::objMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::serializedValueCallback): Ditto.
(WebCore::TestObjInternal::idbKeyCallback): Ditto.
(WebCore::TestObjInternal::optionsObjectCallback): Ditto.
(WebCore::TestObjInternal::customArgsAndExceptionCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): Ditto.
(WebCore::TestObjInternal::methodWithCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::overloadedMethod1Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod2Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod3Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod4Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod5Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod6Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod7Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove plug-in size and backing store checks to PluginProxy::updateBackingStore
andersca@apple.com [Thu, 3 Nov 2011 23:17:44 +0000 (23:17 +0000)]
Move plug-in size and backing store checks to PluginProxy::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=71508

Reviewed by Darin Adler.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...

(WebKit::PluginProxy::updateBackingStore):
...here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of PluginControllerProxy::m_frameRectInWindowCoordinates
andersca@apple.com [Thu, 3 Nov 2011 23:17:39 +0000 (23:17 +0000)]
Get rid of PluginControllerProxy::m_frameRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71506

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
This no longer needs to take the frame rect in window coordinates.

* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
Remove frameRectInWindowCoordinates from the GeometryDidChange message.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Don't pass frameRectInWindowCoordinates when sending GeometryDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of Plugin::wantsWindowRelativeCoordinates()
andersca@apple.com [Thu, 3 Nov 2011 23:17:34 +0000 (23:17 +0000)]
Get rid of Plugin::wantsWindowRelativeCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=71504

Reviewed by Darin Adler.

Since all Plugin subclasses now return false for wantsWindowRelativeCoordinates,
we can go ahead and remove it.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
andersca@apple.com [Thu, 3 Nov 2011 23:17:27 +0000 (23:17 +0000)]
NetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
https://bugs.webkit.org/show_bug.cgi?id=71501

Reviewed by Darin Adler.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().

(WebKit::NetscapePlugin::platformPaint):
No need to translate back and forth between window and plug-in relative coordinates anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange remaining callers of releaseRef to call leakRef
darin@apple.com [Thu, 3 Nov 2011 23:04:46 +0000 (23:04 +0000)]
Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422

../JavaScriptCore:

* wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.

../WebCore:

Reviewed by Darin Fisher.

* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):
* bridge/NP_jsobject.cpp:
(_NPN_CreateScriptObject):
* dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
* history/PageCache.cpp:
(WebCore::PageCache::add):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
* platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::releasePlatformDescription):
* platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::platformResource):
Use leakRef.

../WebKit/chromium:

* public/WebPrivatePtr.h:
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::operator=):
* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::WebDOMEvent):
* src/WebData.cpp:
(WebKit::WebData::assign):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
* src/WebDragData.cpp:
(WebKit::WebDragData::initialize):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::ensureMutable):
* src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::WebNodeCollection):
* src/WebNodeList.cpp:
(WebKit::WebNodeList::WebNodeList):
* src/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::operator=):
* src/WebRange.cpp:
(WebKit::WebRange::WebRange):
(WebKit::WebRange::operator=):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::WebSecurityOrigin):
(WebKit::WebSecurityOrigin::operator=):
* src/WebThreadSafeData.cpp:
(WebKit::WebThreadSafeData::WebThreadSafeData):
Use leakRef.

../WebKit/efl:

Reviewed by Darin Fisher.

* ewk/ewk_history.cpp:
(ewk_history_item_new): Use leakRef.

../WebKit/gtk:

Reviewed by Darin Fisher.

* webkit/webkitwebdatasource.cpp:
(WebKit::kitNew):
* webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_new):
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_copy):
(WebKit::kit):
* webkit/webkitwebresource.cpp:
(webkit_web_resource_new_with_core_resource):
(webkit_web_resource_init_with_core_resource):
Use leakRef.

../WebKit/mac:

Reviewed by Darin Fisher.

* History/WebBackForwardList.mm:
(-[WebBackForwardList initWithBackForwardList:]):
* History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
* WebCoreSupport/WebOpenPanelResultListener.mm:
* WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]):
* WebView/WebResource.mm:
(-[WebResourcePrivate initWithCoreResource:]):
Use leakRef.

../WebKit/win:

Reviewed by Darin Fisher.

* WebCache.cpp:
(WebCache::statistics):
* WebDatabaseManager.cpp:
(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):
* WebHistoryItem.cpp:
(WebHistoryItem::redirectURLs):
* WebKitClassFactory.cpp:
(leakRefFromCreateInstance):
(WebKitClassFactory::CreateInstance):
* WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
Use leakRef.

../WebKit2:

Reviewed by Darin Fisher.

* Platform/mac/ModuleMac.mm:
(WebKit::Module::load):
* Shared/API/c/WKArray.cpp:
(WKArrayCreate):
* Shared/API/c/WKData.cpp:
(WKDataCreate):
* Shared/API/c/WKDictionary.cpp:
(WKDictionaryCopyKeys):
* Shared/API/c/WKGeometry.cpp:
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
* Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
* Shared/API/c/WKMutableDictionary.cpp:
(WKMutableDictionaryCreate):
* Shared/API/c/WKNumber.cpp:
(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI):
(WebKit::toCopiedURLAPI):
* Shared/API/c/cf/WKErrorCF.cpp:
(WKErrorCreateWithCFError):
* Shared/API/c/cf/WKURLRequestCF.cpp:
(WKURLRequestCreateWithCFURLRequest):
* Shared/API/c/cf/WKURLResponseCF.cpp:
(WKURLResponseCreateWithCFURLResponse):
* Shared/API/c/mac/WKURLRequestNS.mm:
(WKURLRequestCreateWithNSURLRequest):
* Shared/API/c/mac/WKURLResponseNS.mm:
(WKURLResponseCreateWithNSURLResponse):
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
* UIProcess/API/C/WKBackForwardList.cpp:
(WKBackForwardListCopyBackListWithLimit):
(WKBackForwardListCopyForwardListWithLimit):
* UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
* UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
* UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
* UIProcess/API/C/WKGeolocationPosition.cpp:
(WKGeolocationPositionCreate):
* UIProcess/API/C/WKGrammarDetail.cpp:
(WKGrammarDetailCreate):
* UIProcess/API/C/WKPage.cpp:
(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateWithIdentifier):
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
* UIProcess/win/WebUndoClient.cpp:
(WebKit::WebUndoClient::registerEditCommand):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyChildFrames):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyTrackedRepaintRects):
* WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldCreateWorld):
Use leakRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::hasInstance
mhahnenberg@apple.com [Thu, 3 Nov 2011 22:40:39 +0000 (22:40 +0000)]
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove unused clipboard methods
dcheng@chromium.org [Thu, 3 Nov 2011 22:28:51 +0000 (22:28 +0000)]
[chromium] Remove unused clipboard methods
https://bugs.webkit.org/show_bug.cgi?id=71512

Reviewed by Tony Chang.

Source/WebCore:

* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/WebClipboard.h:
(WebKit::WebClipboard::getSequenceNumber):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::writeImage):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardGetSequenceNumber):
(WebCore::PlatformSupport::clipboardReadAvailableTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
commit-queue@webkit.org [Thu, 3 Nov 2011 20:37:20 +0000 (20:37 +0000)]
Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

At some points we didn't have any guarantee that a favicon has been loaded, so now
it stops to wait for the IconChanged signal. It also had some file paths in wrong format,
making some files to not be resolved and comparing meaningless bitmaps.

* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::initTestCase):
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Implement TextTrackCueList.
annacc@chromium.org [Thu, 3 Nov 2011 20:28:55 +0000 (20:28 +0000)]
Source/WebCore: Implement TextTrackCueList.
https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

Test: media/track/track-text-track-cue-list.html

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::newCuesAvailable):
    Update TextTrack's TextTrackCueList (m_cues) when new cues are discovered.
* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
    Create an empty TextTrackCueList upon TextTrack creation.
(WebCore::TextTrack::cues):
    Return this TextTrack's list of cues.

Implement TextTrackCueList functionality:
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::TextTrackCueList):
(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item):
(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::add):
(WebCore::TextTrackCueList::remove):
(WebCore::TextTrackCueList::contains):
* html/TextTrackCueList.h:
(WebCore::TextTrackCueList::~TextTrackCueList):

LayoutTests: Tests for TextTrackCueList implementation.
https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

* media/track/track-text-track-cue-list-expected.txt: Added.
* media/track/track-text-track-cue-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove deprecated free functions in port.factory
eric@webkit.org [Thu, 3 Nov 2011 20:24:16 +0000 (20:24 +0000)]
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Reviewed by Adam Barth.

I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
free functions in factory.py.  To remove these required fixing all callsites
to use MockHost, Host, or PortFactory where appropriate.  After this change
we're only left with a handfull of places where we inappropraitely use a
real Executive, FileSystem or User object during unittesting.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 - These PortFactory overrides were from an earlier edition of my previous patch
   in the end, I removed MockPortFactory so all tests ended up with this same
   real PortFactory() with a MockHost.  This was simply redundent code.
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 - Use MockHost to get a mocked-out PortFactory.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 - This code has no access to a Host object, so we just use a default PortFactory
   for now.  This will still incorrectly create real Executive/FileSystem objects
   durring unittesting, which is wrong. :(
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 - Use a MockHost to get a mocked PortFactory.
* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
 - Use a MockHost to get a mocked PortFactory.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
 - ditto.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
 - ditto.
* Scripts/webkitpy/layout_tests/port/__init__.py:
 - factory.get no longer exists.  Yay!
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 - Use a MockHost to get a mocked PortFactory.
   To do this efficiently, I created a helper function
   and combined all these (mostly redundant) tests into one test
   with several calls to the helper function.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 - Pass MockUser and MockExecutive in these port testing subclasses.
 - I also removed a bunch of unecessary uses of mocktool. namespacing.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
 - Awesome windows hacks should only happen on win32.  Once we started
   using MockExecutives these 'svn help' commands started printing in
   other tests, which is how I found this bug.
* Scripts/webkitpy/layout_tests/port/dryrun.py:
 - DryRunPort has no Host, so just use a PortFactory() directly.
   This will do the wrong thing if we're unittesting the DryRun port
   but it's no worse than the existing code.
* Scripts/webkitpy/layout_tests/port/factory.py:
 - Remove the free functions.
 - Fix argument overriding to be able to override None.
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
 - Use a mocked-out PortFactory during testing.
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 - Pass MockExecutive and MockUser to these manual Port instantiations.
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
 - No access to a Host object here, so just using PortFactory directly.
   This is wrong, but no more wrong than the existing code was.
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 - Use a MockHost to get a mocked out PortFactory.
* Scripts/webkitpy/layout_tests/port/test.py:
 - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
* Scripts/webkitpy/layout_tests/port/win.py:
 - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
   now that we're actually passing MockExecutive to most Port instantiations during testing.
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
 - Pass our new "unittesting" bool to _detect_version when actually unittesting.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 - Host is the future.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
   we don't need to pass MockUser explicitly, it does that automatically for us.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
 - Use a MockHost to get a mocked out PortFactory.
* Scripts/webkitpy/style/checkers/test_expectations.py:
 - We don't have access to a Host object, so using PortFactory() directly.
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 - Remove unused variable.
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
 - Host isn't accessible here, so using PortFactory() directly, which
   although unfortunate is no worse than before.
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
 - Testing is much easier when you don't need to hack global state...
* Scripts/webkitpy/tool/commands/expectations.py:
 - Use the port_factory on the tool.
* Scripts/webkitpy/tool/commands/rebaseline.py:
 - ditto.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
   the arguments in the right order.  Fixing that made it use a MockFileSystem
   (like it had been trying to), which then required us to actually populate
   that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
 - Get the port_factory from the tool.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
 - Ditto.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 - Use a MockHost to get a mocked out Port object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJIT-specific code should be able to refer to register types even on JIT-disabled...
fpizlo@apple.com [Thu, 3 Nov 2011 20:21:45 +0000 (20:21 +0000)]
JIT-specific code should be able to refer to register types even on JIT-disabled builds
https://bugs.webkit.org/show_bug.cgi?id=71498

Reviewed by Gavin Barraclough.

* assembler/MacroAssembler.h:
(MacroAssembler::MacroAssembler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark tests as slow in chromium.
tony@chromium.org [Thu, 3 Nov 2011 20:20:39 +0000 (20:20 +0000)]
Mark tests as slow in chromium.

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
are already marked as timing out, but maybe they will pass in release
if we give them enough time.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99231 268f45cc-cd09-0410-ab3c-d52691b4dbfc