WebKit-https.git
5 years agoMarking imported/w3c/web-platform-tests/XMLHttpRequest/send-timeout-events.htm as...
ryanhaddad@apple.com [Fri, 30 Oct 2015 22:07:11 +0000 (22:07 +0000)]
Marking imported/w3c/web-platform-tests/XMLHttpRequest/send-timeout-events.htm as flaky on win
https://bugs.webkit.org/show_bug.cgi?id=150594

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Unexpected background color behind the Continue button in the Debugger...
timothy@apple.com [Fri, 30 Oct 2015 21:57:31 +0000 (21:57 +0000)]
Web Inspector: Unexpected background color behind the Continue button in the DebuggerDashboardView
https://bugs.webkit.org/show_bug.cgi?id=150734

Reviewed by Brian Burg.

* UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger .navigation-bar .item.button):
(.dashboard.debugger .navigation-bar .item.button > .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoB3 should be able to compile a control flow diamond
fpizlo@apple.com [Fri, 30 Oct 2015 21:49:23 +0000 (21:49 +0000)]
B3 should be able to compile a control flow diamond
https://bugs.webkit.org/show_bug.cgi?id=150720

Reviewed by Benjamin Poulain.

Adds support for Branch, Jump, Upsilon, and Phi. Adds some basic strength reduction for
comparisons and boolean-like operations.

* assembler/MacroAssembler.cpp:
(WTF::printInternal):
* assembler/MacroAssembler.h:
* b3/B3BasicBlockUtils.h:
(JSC::B3::replacePredecessor):
(JSC::B3::resetReachability):
* b3/B3CheckValue.h:
* b3/B3Common.h:
(JSC::B3::isRepresentableAsImpl):
(JSC::B3::isRepresentableAs):
* b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::subConstant):
(JSC::B3::Const32Value::equalConstant):
(JSC::B3::Const32Value::notEqualConstant):
(JSC::B3::Const32Value::dumpMeta):
* b3/B3Const32Value.h:
* b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::subConstant):
(JSC::B3::Const64Value::equalConstant):
(JSC::B3::Const64Value::notEqualConstant):
(JSC::B3::Const64Value::dumpMeta):
* b3/B3Const64Value.h:
* b3/B3ConstDoubleValue.cpp:
(JSC::B3::ConstDoubleValue::subConstant):
(JSC::B3::ConstDoubleValue::equalConstant):
(JSC::B3::ConstDoubleValue::notEqualConstant):
(JSC::B3::ConstDoubleValue::dumpMeta):
* b3/B3ConstDoubleValue.h:
* b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::~ControlValue):
(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::dumpMeta):
* b3/B3ControlValue.h:
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::imm):
(JSC::B3::Air::LowerToAir::tryStackSlot):
(JSC::B3::Air::LowerToAir::tryUpsilon):
(JSC::B3::Air::LowerToAir::tryPhi):
(JSC::B3::Air::LowerToAir::tryBranch):
(JSC::B3::Air::LowerToAir::tryJump):
(JSC::B3::Air::LowerToAir::tryIdentity):
* b3/B3LoweringMatcher.patterns:
* b3/B3Opcode.h:
* b3/B3Procedure.cpp:
(JSC::B3::Procedure::resetReachability):
(JSC::B3::Procedure::dump):
* b3/B3ReduceStrength.cpp:
* b3/B3UpsilonValue.cpp:
(JSC::B3::UpsilonValue::dumpMeta):
* b3/B3UpsilonValue.h:
(JSC::B3::UpsilonValue::accepts): Deleted.
(JSC::B3::UpsilonValue::phi): Deleted.
(JSC::B3::UpsilonValue::UpsilonValue): Deleted.
* b3/B3Validate.cpp:
* b3/B3Value.cpp:
(JSC::B3::Value::subConstant):
(JSC::B3::Value::equalConstant):
(JSC::B3::Value::notEqualConstant):
(JSC::B3::Value::returnsBool):
(JSC::B3::Value::asTriState):
(JSC::B3::Value::effects):
* b3/B3Value.h:
* b3/B3ValueInlines.h:
(JSC::B3::Value::asInt32):
(JSC::B3::Value::isInt32):
(JSC::B3::Value::hasInt64):
(JSC::B3::Value::asInt64):
(JSC::B3::Value::isInt64):
(JSC::B3::Value::hasInt):
(JSC::B3::Value::asIntPtr):
(JSC::B3::Value::isIntPtr):
(JSC::B3::Value::hasDouble):
(JSC::B3::Value::asDouble):
(JSC::B3::Value::isEqualToDouble):
(JSC::B3::Value::hasNumber):
(JSC::B3::Value::representableAs):
(JSC::B3::Value::asNumber):
(JSC::B3::Value::stackmap):
* b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::dump):
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::resCond):
(JSC::B3::Air::Arg::doubleCond):
(JSC::B3::Air::Arg::special):
(JSC::B3::Air::Arg::isResCond):
(JSC::B3::Air::Arg::isDoubleCond):
(JSC::B3::Air::Arg::isSpecial):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::asResultCondition):
(JSC::B3::Air::Arg::asDoubleCondition):
(JSC::B3::Air::Arg::Arg):
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::resetReachability):
(JSC::B3::Air::Code::dump):
* b3/air/AirOpcode.opcodes:
* b3/air/opcode_generator.rb:
* b3/testb3.cpp:
(hiddenTruthBecauseNoReturnIsStupid):
(usage):
(JSC::B3::compile):
(JSC::B3::invoke):
(JSC::B3::compileAndRun):
(JSC::B3::test42):
(JSC::B3::testStoreLoadStackSlot):
(JSC::B3::testBranch):
(JSC::B3::testDiamond):
(JSC::B3::testBranchNotEqual):
(JSC::B3::testBranchFold):
(JSC::B3::testDiamondFold):
(JSC::B3::run):
(run):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[ES6] Add support for toStringTag
keith_miller@apple.com [Fri, 30 Oct 2015 21:37:25 +0000 (21:37 +0000)]
[ES6] Add support for toStringTag
https://bugs.webkit.org/show_bug.cgi?id=150696

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch adds support for Symbol.toStringTag. This is a simple
feature, if an object passed to Object.prototype.toString() has a
toStringTag we use the tag in the string rather than the class info.
Added a test that checks this works for all the default supported classes
along with the corresponding prototype and custom cases.

* runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
* runtime/CommonIdentifiers.h:
* runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
* runtime/JSDataViewPrototype.cpp:
(JSC::JSDataViewPrototype::finishCreation):
* runtime/JSDataViewPrototype.h:
* runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::finishCreation):
* runtime/JSONObject.cpp:
(JSC::JSONObject::finishCreation):
* runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::finishCreation):
* runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewProtoGetterFuncToStringTag):
(JSC::JSTypedArrayViewPrototype::finishCreation):
* runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototype::finishCreation):
* runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
* runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototype::finishCreation):
* runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::visitStrongReferences):
* runtime/SmallStrings.h:
(JSC::SmallStrings::objectStringStart):
* runtime/StringIteratorPrototype.cpp:
(JSC::StringIteratorPrototype::finishCreation):
* runtime/SymbolPrototype.cpp:
(JSC::SymbolPrototype::finishCreation):
* runtime/WeakMapPrototype.cpp:
(JSC::WeakMapPrototype::finishCreation):
* runtime/WeakSetPrototype.cpp:
(JSC::WeakSetPrototype::finishCreation):
* tests/modules/namespace.js:
* tests/stress/symbol-tostringtag.js: Added.
(toStr):
(strName):
(classes.string_appeared_here):

LayoutTests:

Symbol now has toStringTag as a member. Since Object.prototype.toString()
now does a [[Get]] on the object being stringed there are new console
error messages when accessing another window's properties.

* http/tests/history/cross-origin-replace-history-object-child-expected.txt:
* http/tests/security/cross-frame-access-custom-expected.txt:
* http/tests/security/cross-frame-access-history-get-expected.txt:
* http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
* js/Object-getOwnPropertyNames-expected.txt:
* js/script-tests/Object-getOwnPropertyNames.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agohttp/tests/notifications/legacy/events.html flakily asserts on mac-wk2, updating...
ryanhaddad@apple.com [Fri, 30 Oct 2015 21:34:42 +0000 (21:34 +0000)]
http/tests/notifications/legacy/events.html flakily asserts on mac-wk2, updating expectations
https://bugs.webkit.org/show_bug.cgi?id=150736

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMarking storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html as flaky...
ryanhaddad@apple.com [Fri, 30 Oct 2015 21:21:51 +0000 (21:21 +0000)]
Marking storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=150735

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix Mac CMake build after rr191810.
achristensen@apple.com [Fri, 30 Oct 2015 21:13:07 +0000 (21:13 +0000)]
Fix Mac CMake build after rr191810.

* PlatformMac.cmake:
Add RemoteObjectInvocation.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix Windows build.
achristensen@apple.com [Fri, 30 Oct 2015 21:02:50 +0000 (21:02 +0000)]
Fix Windows build.

* PlatformWin.cmake:
Add missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a separate object that represents a remote object invocation
andersca@apple.com [Fri, 30 Oct 2015 20:38:12 +0000 (20:38 +0000)]
Add a separate object that represents a remote object invocation
https://bugs.webkit.org/show_bug.cgi?id=150639

Reviewed by Tim Horton.

* Shared/API/Cocoa/RemoteObjectInvocation.h: Copied from Source/WebKit2/Shared/API/Cocoa/RemoteObjectRegistry.h.
(WebKit::RemoteObjectInvocation::interfaceIdentifier):
(WebKit::RemoteObjectInvocation::encodedInvocation):
* Shared/API/Cocoa/RemoteObjectInvocation.mm: Copied from Source/WebKit2/Shared/API/Cocoa/RemoteObjectRegistry.mm.
(WebKit::RemoteObjectInvocation::RemoteObjectInvocation):
(WebKit::RemoteObjectInvocation::encode):
(WebKit::RemoteObjectInvocation::decode):
* Shared/API/Cocoa/RemoteObjectRegistry.h:
* Shared/API/Cocoa/RemoteObjectRegistry.messages.in:
* Shared/API/Cocoa/RemoteObjectRegistry.mm:
(WebKit::RemoteObjectRegistry::sendInvocation):
(WebKit::RemoteObjectRegistry::invokeMethod):
* Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[_WKRemoteObjectRegistry _invokeMethod:]):
* Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother speculative build fix.
bdakin@apple.com [Fri, 30 Oct 2015 20:16:39 +0000 (20:16 +0000)]
Another speculative build fix.

* UIProcess/API/Cocoa/_WKElementAction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMarking js/regress/ftl-object-sub.html as a flaky timeout
ryanhaddad@apple.com [Fri, 30 Oct 2015 20:13:36 +0000 (20:13 +0000)]
Marking js/regress/ftl-object-sub.html as a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=150730

Unreviewed test gardening.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative build fix.
bdakin@apple.com [Fri, 30 Oct 2015 20:12:25 +0000 (20:12 +0000)]
Speculative build fix.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKView being inside WKWebView leads to weird API issues
timothy_horton@apple.com [Fri, 30 Oct 2015 20:05:05 +0000 (20:05 +0000)]
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
(-[WKView mouseEntered:]):
(-[WKView mouseExited:]):
(-[WKView otherMouseDown:]):
(-[WKView otherMouseDragged:]):
(-[WKView otherMouseUp:]):
(-[WKView rightMouseDown:]):
(-[WKView rightMouseDragged:]):
(-[WKView rightMouseUp:]):
(-[WKView _updateViewExposedRect]): Deleted.
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::mouseMoved):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::mouseUp):
(WebKit::WebViewImpl::mouseDragged):
Move mouse event handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTapping and holding a link should have a share option
bdakin@apple.com [Fri, 30 Oct 2015 19:38:40 +0000 (19:38 +0000)]
Tapping and holding a link should have a share option
https://bugs.webkit.org/show_bug.cgi?id=150693
-and corresponding-
rdar://problem/21319702

Reviewed by Tim Horton.

Source/WebCore:

* English.lproj/Localizable.strings:

Source/WebKit2:

New _WKElementActionType called _WKElementActionTypeShare.
* UIProcess/API/Cocoa/_WKElementAction.h:
* UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):

_WKElementActionTypeShare is part of the default actions for links.
* UIProcess/ios/WKActionSheetAssistant.h:
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):

Handle the sharing part!
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView actionSheetAssistant:shareElementWithURL:rect:]):

To support this in PDF, PDF need to create a _webSelectionAssistant.
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_initWithFrame:webView:]):
(-[WKPDFView actionSheetAssistant:openElementAtLocation:]):
(-[WKPDFView actionSheetAssistant:shareElementWithURL:rect:]):
(-[WKPDFView actionSheetAssistant:shouldIncludeAppLinkActionsForElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMinor CGColor leaks seen on bots allocated in WebSystemBackdropLayer.mm
commit-queue@webkit.org [Fri, 30 Oct 2015 19:09:13 +0000 (19:09 +0000)]
Minor CGColor leaks seen on bots allocated in WebSystemBackdropLayer.mm
https://bugs.webkit.org/show_bug.cgi?id=150722

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-30
Reviewed by Andreas Kling.

* platform/graphics/ca/cocoa/WebSystemBackdropLayer.mm:
(-[WebLightSystemBackdropLayer init]):
(-[WebDarkSystemBackdropLayer init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRegression(r191673): Crash in RunLoopTimer::schedule()
cdumez@apple.com [Fri, 30 Oct 2015 18:55:36 +0000 (18:55 +0000)]
Regression(r191673): Crash in RunLoopTimer::schedule()
https://bugs.webkit.org/show_bug.cgi?id=150723

Reviewed by Anders Carlsson.

We were crashing in RunLoopTimer::schedule() when iterating over the
SchedulePairHashSet. The reason is that we were passing this
SchedulePairHashSet from the main thread to a background thread, which
was not safe because the SchedulePair objects inside the HashSet were
not ThreadSafeRefCounted. This patch makes them ThreadSafeRefCounted.

* wtf/SchedulePair.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKView being inside WKWebView leads to weird API issues
timothy_horton@apple.com [Fri, 30 Oct 2015 18:52:08 +0000 (18:52 +0000)]
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _wantsKeyDownForEvent:]):
(-[WKView acceptsFirstMouse:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):
(-[WKView validAttributesForMarkedText]):
(-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]):
(-[WKView drawRect:]):
(-[WKView isOpaque]):
(-[WKView mouseDownCanMoveWindow]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
(-[WKView hitTest:]):
(-[WKView wantsUpdateLayer]):
(-[WKView canChangeFrameLayout:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
(+[WKView hideWordDefinitionWindow]):
* UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::wantsUpdateLayer):
(WebKit::WebViewImpl::mouseDownCanMoveWindow):
(WebKit::WebViewImpl::wantsKeyDownForEvent):
(WebKit::WebViewImpl::layerHostingView): Deleted.
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::isOpaque):
(WebKit::WebViewImpl::acceptsFirstMouse):
(WebKit::WebViewImpl::drawRect):
(WebKit::WebViewImpl::canChangeFrameLayout):
(WebKit::WebViewImpl::printOperationWithPrintInfo):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::windowResizeMouseLocationIsInVisibleScrollerThumb):
(WebKit::WebViewImpl::viewDidHide):
(WebKit::WebViewImpl::viewDidUnhide):
(WebKit::WebViewImpl::activeSpaceDidChange):
(WebKit::WebViewImpl::hitTest):
(WebKit::WebViewImpl::hideWordDefinitionWindow):
(WebKit::WebViewImpl::validAttributesForMarkedText):
Printing and random bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFixed the build.
mitz@apple.com [Fri, 30 Oct 2015 18:42:39 +0000 (18:42 +0000)]
Fixed the build.

* Plugins/WebPluginController.mm:
(WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
(WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Fix the debug build after r191758
ossy@webkit.org [Fri, 30 Oct 2015 18:21:28 +0000 (18:21 +0000)]
[EFL] Fix the debug build after r191758
https://bugs.webkit.org/show_bug.cgi?id=150719

Reviewed by Alex Christensen.

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFixed the build.
mitz@apple.com [Fri, 30 Oct 2015 18:07:24 +0000 (18:07 +0000)]
Fixed the build.

* platform/graphics/Image.cpp:
(WebCore::Image::draw): Deleted an infinitely-recursive implementation that caused the
  compiler to emit an error.
* platform/graphics/Image.h:
(WebCore::Image::draw): Made this pure virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r191691): Unexpected "Share" context menu when right clicking around...
andersca@apple.com [Fri, 30 Oct 2015 17:58:49 +0000 (17:58 +0000)]
REGRESSION (r191691): Unexpected "Share" context menu when right clicking around inspector
https://bugs.webkit.org/show_bug.cgi?id=150699
rdar://problem/23324522

Reviewed by Tim Horton.

Don't create a share menu item if we have nothing to share.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInitialize some new WebViewImpl members
timothy_horton@apple.com [Fri, 30 Oct 2015 17:56:56 +0000 (17:56 +0000)]
Initialize some new WebViewImpl members

* UIProcess/Cocoa/WebViewImpl.h:
Oh well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build
timothy_horton@apple.com [Fri, 30 Oct 2015 17:21:29 +0000 (17:21 +0000)]
Fix the build

* UIProcess/API/mac/WKView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModern IDB: IDBObjectStore.add() support.
beidson@apple.com [Fri, 30 Oct 2015 17:17:06 +0000 (17:17 +0000)]
Modern IDB: IDBObjectStore.add() support.
https://bugs.webkit.org/show_bug.cgi?id=150711

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/basic-add.html

* Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::add):

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::requestGetRecord):

LayoutTests:

* storage/indexeddb/modern/basic-add-expected.txt: Added.
* storage/indexeddb/modern/basic-add.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build
timothy_horton@apple.com [Fri, 30 Oct 2015 17:12:38 +0000 (17:12 +0000)]
Fix the build

* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::collectKeyboardLayoutCommandsForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] build-jsc and run-javascriptcore-tests do not work
bfulgham@apple.com [Fri, 30 Oct 2015 17:05:58 +0000 (17:05 +0000)]
[Win] build-jsc and run-javascriptcore-tests do not work
https://bugs.webkit.org/show_bug.cgi?id=150700

Reviewed by Mark Lam.

Correct our build system so that it expects Windows to be using CMake,
and to build the correct sub-projects for our JSC helper scripts.

* Scripts/build-jsc: Make sure to build the testapi harness when
  building for Windows.
* Scripts/build-webkit:
  (1) Use the existing 'cmakeBasedPortName()'
  (2) Use File::Spec rather than hard-coding path delimeters.
  (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
method rather than hard-coding the name based on conditional.
* Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
  LLVM libraries on Apple Windows build.
* Scripts/run-javascriptcore-tests:
(testapiPath): Use File::Spec rather than hard-coding path delimeters.
* Scripts/run-jsc: Ditto.
* Scripts/webkitdirs.pm:
(cmakeBasedPortName): Update to return the right value for the Apple
Windows port and the WinCairo port.
(isCMakeBuild): Expect CMake build for all Windows ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse modern for-loops in WebCore/dom.
hs85.jeong@samsung.com [Fri, 30 Oct 2015 17:04:07 +0000 (17:04 +0000)]
Use modern for-loops in WebCore/dom.
https://bugs.webkit.org/show_bug.cgi?id=150664

Reviewed by Darin Adler.

No new tests because there is no behavior change.

* dom/AuthorStyleSheets.cpp:
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::activeStyleSheetsContains):
* dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::updateValidityForAllButtons):
* dom/ClientRectList.cpp:
(WebCore::ClientRectList::ClientRectList):
(WebCore::ClientRectList::~ClientRectList):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
* dom/DOMNamedFlowCollection.cpp:
(WebCore::DOMNamedFlowCollection::DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::length):
(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):
* dom/DOMStringList.cpp:
(WebCore::DOMStringList::contains):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::removedLastRef):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale):
(WebCore::Document::updateHoverActiveState):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(DocumentMarkerController::showMarkers):
* dom/ElementData.cpp:
(WebCore::UniqueElementData::findAttributeByName):
* dom/EventDispatcher.cpp:
(WebCore::EventPath::updateTouchLists):
(WebCore::EventPath::hasEventListeners):
* dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::containsCapturing):
(WebCore::EventListenerMap::eventTypes):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::find):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
* dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::getAttributeEventListener):
(WebCore::EventTarget::removeAllEventListeners):
* dom/IdTargetObserverRegistry.cpp:
(WebCore::IdTargetObserverRegistry::notifyObserversInternal):
* dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentanglePorts):
* dom/MutationObserver.cpp:
(WebCore::MutationObserver::observe):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):
* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::namedFlows):
(WebCore::NamedFlowCollection::createCSSOMSnapshot):
* dom/Node.cpp:
(WebCore::Node::notifyMutationObserversNodeWillDetach):
* dom/Range.cpp:
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):
(WebCore::Range::absoluteBoundingBox):
(WebCore::Range::collectSelectionRects):
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::timerFired):
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::executeFastPathForIdSelector):
(WebCore::SelectorDataList::executeSingleMultiSelectorData):
(WebCore::SelectorDataList::executeCompiledSingleMultiSelectorData):
(WebCore::SelectorDataList::execute):
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKView being inside WKWebView leads to weird API issues
timothy_horton@apple.com [Fri, 30 Oct 2015 17:02:36 +0000 (17:02 +0000)]
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]):
(-[WKView insertText:]):
(-[WKView insertText:replacementRange:]):
(-[WKView inputContext]):
(-[WKView performKeyEquivalent:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView unmarkText]):
(-[WKView selectedRange]):
(-[WKView hasMarkedText]):
(-[WKView markedRange]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
(-[WKView selectedRangeWithCompletionHandler:]):
(-[WKView markedRangeWithCompletionHandler:]):
(-[WKView hasMarkedTextWithCompletionHandler:]):
(-[WKView attributedSubstringForProposedRange:completionHandler:]):
(-[WKView firstRectForCharacterRange:completionHandler:]):
(-[WKView characterIndexForPoint:completionHandler:]):
(-[WKView _superPerformKeyEquivalent:]):
(-[WKView _superKeyDown:]):
(extractUnderlines): Deleted.
(-[WKView _collectKeyboardLayoutCommandsForEvent:to:]): Deleted.
(-[WKView _interpretKeyEvent:completionHandler:]): Deleted.
(-[WKView NO_RETURN_DUE_TO_ASSERT]): Deleted.
(-[WKView _interpretKeyEvent:savingCommandsTo:]): Deleted.
(-[WKView _executeSavedKeypressCommands]): Deleted.
(-[WKView _doneWithKeyEvent:eventWasHandled:]): Deleted.
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::doneWithKeyEvent):
(WebKit::extractUnderlines):
(WebKit::WebViewImpl::collectKeyboardLayoutCommandsForEvent):
(WebKit::WebViewImpl::interpretKeyEvent):
(WebKit::WebViewImpl::doCommandBySelector):
(WebKit::WebViewImpl::insertText):
(WebKit::WebViewImpl::selectedRangeWithCompletionHandler):
(WebKit::WebViewImpl::markedRangeWithCompletionHandler):
(WebKit::WebViewImpl::hasMarkedTextWithCompletionHandler):
(WebKit::WebViewImpl::attributedSubstringForProposedRange):
(WebKit::WebViewImpl::firstRectForCharacterRange):
(WebKit::WebViewImpl::characterIndexForPoint):
(WebKit::WebViewImpl::inputContext):
(WebKit::WebViewImpl::unmarkText):
(WebKit::WebViewImpl::setMarkedText):
(WebKit::WebViewImpl::selectedRange):
(WebKit::WebViewImpl::hasMarkedText):
(WebKit::WebViewImpl::markedRange):
(WebKit::WebViewImpl::performKeyEquivalent):
(WebKit::WebViewImpl::keyUp):
(WebKit::WebViewImpl::keyDown):
(WebKit::WebViewImpl::flagsChanged):
(WebKit::WebViewImpl::executeSavedKeypressCommands):
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
Move NSTextInputClient implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake every port implement MainThreadSharedTimer instead of using global functions
carlosgc@webkit.org [Fri, 30 Oct 2015 13:25:26 +0000 (13:25 +0000)]
Make every port implement MainThreadSharedTimer instead of using global functions
https://bugs.webkit.org/show_bug.cgi?id=150498

Reviewed by Darin Adler.

Move MainThreadSharedTimer to its own files and add the common
implementation there.

* CMakeLists.txt: Add MainThreadSharedTimer.cpp.
* PlatformEfl.cmake: Update filenames.
* PlatformGTK.cmake: Ditto.
* PlatformMac.cmake: Ditto.
* PlatformWin.cmake: Ditto.
* platform/MainThreadSharedTimer.cpp: Copied from Source/WebCore/platform/efl/SharedTimerEfl.cpp.
(WebCore::MainThreadSharedTimer::singleton):
(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::setFiredFunction):
(WebCore::MainThreadSharedTimer::fired):
* platform/MainThreadSharedTimer.h: Copied from Source/WebCore/platform/gtk/SharedTimerGtk.cpp.
* platform/SharedTimer.h: Remove MainThreadSharedTimer
implementation and reindent the code.
(WebCore::SharedTimer::SharedTimer):
(WebCore::SharedTimer::~SharedTimer):
(WebCore::SharedTimer::invalidate):
* platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::ThreadTimers): Use MainThreadSharedTimer::singleton().
(WebCore::ThreadTimers::setSharedTimer): Use a lambda function
instead of a pointer to a static method.
(WebCore::ThreadTimers::sharedTimerFired): Deleted.
* platform/ThreadTimers.h: Removed unsused static method sharedTimerFired.
* platform/cf/MainThreadSharedTimerCF.cpp: Renamed from Source/WebCore/platform/cf/SharedTimerCF.cpp.
(WebCore::applicationDidBecomeActive):
(WebCore::setupPowerObserver):
(WebCore::timerFired):
(WebCore::restartSharedTimer):
(WebCore::MainThreadSharedTimer::invalidate):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
* platform/efl/MainThreadSharedTimerEfl.cpp: Renamed from Source/WebCore/platform/efl/SharedTimerEfl.cpp.
(WebCore::timerEvent):
(WebCore::MainThreadSharedTimer::stop):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::invalidate):
* platform/gtk/MainThreadSharedTimerGtk.cpp: Renamed from Source/WebCore/platform/gtk/SharedTimerGtk.cpp.
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
(WebCore::MainThreadSharedTimer::invalidate):
* platform/win/MainThreadSharedTimerWin.cpp: Renamed from Source/WebCore/platform/win/SharedTimerWin.cpp.
(WebCore::TimerWindowWndProc):
(WebCore::initializeOffScreenTimerWindow):
(WebCore::queueTimerProc):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
(WebCore::MainThreadSharedTimer::invalidate):
* workers/WorkerRunLoop.cpp: Update WorkerSharedTimer
implementation to use std::function instead of a pointer. Also
mark the class as final and the virtual implementations as override.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Move the socket polling off the WorkQueue
carlosgc@webkit.org [Fri, 30 Oct 2015 12:46:55 +0000 (12:46 +0000)]
[GTK] Move the socket polling off the WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=150593

Reviewed by Anders Carlsson.

Source/WebKit2:

Create the socket poll source in Connection::open and attach it to
the connection work queue context.

* Platform/IPC/Connection.h:
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::platformInvalidate):
(IPC::Connection::open):

Source/WTF:

It doesn't really belong to the WorkQueue, it's only used by the
WebKit2 connection, so it can be moved there.

* wtf/WorkQueue.h:
* wtf/glib/WorkQueueGLib.cpp:
(WTF::WorkQueue::registerSocketEventHandler): Deleted.
(WTF::WorkQueue::unregisterSocketEventHandler): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use RunLoop::Timer instead of GMainLoopSource
carlosgc@webkit.org [Fri, 30 Oct 2015 12:12:09 +0000 (12:12 +0000)]
[GTK] Use RunLoop::Timer instead of GMainLoopSource
https://bugs.webkit.org/show_bug.cgi?id=150592

Reviewed by Žan Doberšek.

Source/WebCore:

* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::ResourceHandle::timeoutFired):
(WebCore::ResourceHandle::sendPendingRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):

Source/WebKit2:

* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::handleResponseLater):
* UIProcess/gtk/GestureController.cpp:
(WebKit::GestureController::DragGesture::begin):
(WebKit::GestureController::DragGesture::update):
(WebKit::GestureController::DragGesture::end):
(WebKit::GestureController::DragGesture::longPressFired):
(WebKit::GestureController::DragGesture::DragGesture):
(WebKit::GestureController::ZoomGesture::scaleChanged):
(WebKit::GestureController::ZoomGesture::ZoomGesture):
* UIProcess/gtk/GestureController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use a persistent main loop source in RunLoop glib implementation
carlosgc@webkit.org [Fri, 30 Oct 2015 11:28:14 +0000 (11:28 +0000)]
[GTK] Use a persistent main loop source in RunLoop glib implementation
https://bugs.webkit.org/show_bug.cgi?id=150590

Reviewed by Žan Doberšek.

Source/WebKit2:

Use RunLoop::dispatch() instead of
GMainLoopSource::scheduleAndDeleteOnDestroy in a couple of simple
cases.

* NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::runTaskInQueue):
* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::dragLeave):

Source/WTF:

It's more efficient than creating and destroying a new source for
every dispatch and it simplifies the code.

* wtf/RunLoop.h:
* wtf/glib/MainThreadGLib.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread): Use
RunLoop::dispatch() instead of GMainLoopSource::scheduleAndDeleteOnDestroy().
* wtf/glib/RunLoopGLib.cpp:
(WTF::RunLoop::RunLoop): Create and setup the persistent source.
(WTF::RunLoop::~RunLoop): Destroy the persistent source.
(WTF::RunLoop::stop): Stop the persistent source before stopping
the main loop.
(WTF::RunLoop::wakeUp): Make the persistent source active. We
no longer need to explicitly wakeup the context.
(WTF::RunLoop::TimerBase::TimerBase): Create and setup the
persistent source.
(WTF::RunLoop::TimerBase::~TimerBase): Destroy the persistent source.
(WTF::RunLoop::TimerBase::updateReadyTime): Set the ready time
according to the fire interval.
(WTF::RunLoop::TimerBase::start): Make the persistent source active.
(WTF::RunLoop::TimerBase::stop): Stop the persistent source.
(WTF::RunLoop::TimerBase::isActive): Return whether the
persistent source is active.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Add Shadow DOM feature
gyuyoung.kim@webkit.org [Fri, 30 Oct 2015 10:51:05 +0000 (10:51 +0000)]
[EFL] Add Shadow DOM feature
https://bugs.webkit.org/show_bug.cgi?id=150611

Reviewed by Csaba Osztrogonác.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake: Add ENABLE_SHADOW_DOM cmake variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
commit-queue@webkit.org [Fri, 30 Oct 2015 08:48:08 +0000 (08:48 +0000)]
[JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
https://bugs.webkit.org/show_bug.cgi?id=150665

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2015-10-30
Reviewed by Csaba Osztrogonác.

We check it only to wipe the directory or not, but we are still
tryihng to update every module even when the configuration hasn't
changed. This is problematic because it makes the whole build fail
when any repository fails to checkout an already checked out
revision, because the server is down for example. This is even
more problematic for the bots that skip perfectly valid revisions.
It's still possible to force an update passing --force command
line argument.

* Scripts/update-webkit-libs-jhbuild:
(deleteJhbuildMd5): Delete the md5sum files if exist.
(runJhbuild): Return early if the md5sum files haven't
changed. Only write them after a successful build and delete them
if the build fails to ensure we don't skip next run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Fix MacCLang build errors in Tools
philn@webkit.org [Fri, 30 Oct 2015 08:31:24 +0000 (08:31 +0000)]
[GTK] Fix MacCLang build errors in Tools
https://bugs.webkit.org/show_bug.cgi?id=150031

Reviewed by Carlos Garcia Campos.

* TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
* WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][Mac] fix WTF build
philn@webkit.org [Fri, 30 Oct 2015 08:17:18 +0000 (08:17 +0000)]
[GTK][Mac] fix WTF build
https://bugs.webkit.org/show_bug.cgi?id=150502

Reviewed by Alex Christensen.

* wtf/CMakeLists.txt: Add CommonCryptoSPI.h in the headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r191776): EFL build broken.
hs85.jeong@samsung.com [Fri, 30 Oct 2015 08:01:16 +0000 (08:01 +0000)]
REGRESSION(r191776): EFL build broken.
https://bugs.webkit.org/show_bug.cgi?id=150713

Reviewed by Csaba Osztrogonác.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoving flaky expectations for storage/indexeddb/modern tests since the failure...
ryanhaddad@apple.com [Fri, 30 Oct 2015 06:20:14 +0000 (06:20 +0000)]
Removing flaky expectations for storage/indexeddb/modern tests since the failure was fixed in r191758
https://bugs.webkit.org/show_bug.cgi?id=150678

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Do not show JavaScriptCore builtins in inspector
commit-queue@webkit.org [Fri, 30 Oct 2015 06:00:17 +0000 (06:00 +0000)]
Web Inspector: Do not show JavaScriptCore builtins in inspector
https://bugs.webkit.org/show_bug.cgi?id=146049

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-29
Reviewed by Geoffrey Garen.

* debugger/Debugger.cpp:
When gathering scripts to notify the inspector / debuggers about
skip over sources containing host / built-in functions as those
for those won't contain source code developers expect to see.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix typo in "use strict" in TypedArray builtins
commit-queue@webkit.org [Fri, 30 Oct 2015 05:37:05 +0000 (05:37 +0000)]
Fix typo in "use strict" in TypedArray builtins
https://bugs.webkit.org/show_bug.cgi?id=150709

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-29
Reviewed by Geoffrey Garen.

* builtins/TypedArray.prototype.js:
(toLocaleString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModern IDB: autoIncrement support.
beidson@apple.com [Fri, 30 Oct 2015 04:55:12 +0000 (04:55 +0000)]
Modern IDB: autoIncrement support.
https://bugs.webkit.org/show_bug.cgi?id=150695

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/autoincrement-abort.html

* Modules/indexeddb/server/IDBBackingStore.h:
* Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::addNewObjectStore):
(WebCore::IDBServer::MemoryBackingStoreTransaction::addExistingObjectStore):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
* Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::putRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::generateKeyNumber):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:
* Modules/indexeddb/server/MemoryObjectStore.h:
(WebCore::IDBServer::MemoryObjectStore::currentKeyGeneratorValue):
(WebCore::IDBServer::MemoryObjectStore::setKeyGeneratorValue):
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):

LayoutTests:

* storage/indexeddb/modern/autoincrement-abort-expected.txt: Added.
* storage/indexeddb/modern/autoincrement-abort.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][Mac] disable OBJC JSC API
commit-queue@webkit.org [Fri, 30 Oct 2015 04:30:26 +0000 (04:30 +0000)]
[GTK][Mac] disable OBJC JSC API
https://bugs.webkit.org/show_bug.cgi?id=150500

Patch by Philippe Normand <pnormand@igalia.com> on 2015-10-29
Reviewed by Alex Christensen.

* API/JSBase.h: Disable the Objective-C API on Mac for the GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] MiniBrowser didn't work after r191749.
hs85.jeong@samsung.com [Fri, 30 Oct 2015 04:15:58 +0000 (04:15 +0000)]
[EFL] MiniBrowser didn't work after r191749.
https://bugs.webkit.org/show_bug.cgi?id=150706

Reviewed by Alex Christensen.

Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.

* Scripts/run-minibrowser:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake WebCore a framework in Mac CMake build
commit-queue@webkit.org [Fri, 30 Oct 2015 04:14:34 +0000 (04:14 +0000)]
Make WebCore a framework in Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=150702

Patch by Alex Christensen <achristensen@webkit.org> on 2015-10-29
Reviewed by Geoffrey Garen.

Source/WebCore:

* CMakeLists.txt:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* PlatformMac.cmake:

Source/WebKit:

* PlatformMac.cmake:

Source/WebKit2:

* PlatformMac.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r191766.
commit-queue@webkit.org [Fri, 30 Oct 2015 03:04:12 +0000 (03:04 +0000)]
Unreviewed, rolling out r191766.
https://bugs.webkit.org/show_bug.cgi?id=150707

Problem with Cygwin build (Requested by bfulgham_ on #webkit).

Reverted changeset:

"[Win] build-jsc and run-javascriptcore-tests do not work"
https://bugs.webkit.org/show_bug.cgi?id=150700
http://trac.webkit.org/changeset/191766

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAir::handleCalleeSaves shouldn't save/restore the frame pointer
fpizlo@apple.com [Fri, 30 Oct 2015 01:46:10 +0000 (01:46 +0000)]
Air::handleCalleeSaves shouldn't save/restore the frame pointer
https://bugs.webkit.org/show_bug.cgi?id=150688

Reviewed by Michael Saboff.

We save/restore the FP inside Air::generate().

* b3/air/AirHandleCalleeSaves.cpp:
(JSC::B3::Air::handleCalleeSaves):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Make use of other Timer details in Timeline (timeout, singleShot)
joepeck@webkit.org [Fri, 30 Oct 2015 01:33:00 +0000 (01:33 +0000)]
Web Inspector: Make use of other Timer details in Timeline (timeout, singleShot)
https://bugs.webkit.org/show_bug.cgi?id=150697

Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
Create a small object for timer details.

* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
New details object requires new path to timer identifier.

* UserInterface/Views/ScriptTimelineView.css:
(.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .navigation-sidebar-panel-content-tree-outline.script .item .alternate-subtitle):
(.navigation-sidebar-panel-content-tree-outline .item .alternate-subtitle):
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .alternate-subtitle):
(.navigation-sidebar-panel-content-tree-outline .item.small:not(.two-line) .alternate-subtitle::before):
Styles for an alternate-subtitle, a subtitle to show when the timeline
content view is showing and not a resource content view.

* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
Create alternate subtitle for Timers with the timeout millisecond details.
Differentiate between setTimeout / setInterval.

* UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
(WebInspector.ScriptTimelineDataGridNode): Deleted.
Remove dead code. Normally there would be a filter / scope bar for an eventType
column but no such column exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnimometer computes frame rate incorrectly
simon.fraser@apple.com [Fri, 30 Oct 2015 01:28:23 +0000 (01:28 +0000)]
Animometer computes frame rate incorrectly
https://bugs.webkit.org/show_bug.cgi?id=150698

Reviewed by Tim Horton.

The existing code incremented this._frameCount after checking against this._dropFrameCount.
This has the effect of setting this._measureTimeOffset one frame too late, so
we were measuring only two frames, not three, and thus computing an incorrect fps.

* Animometer/tests/resources/main.js:
(Animator.prototype.animate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEFL build fix after r191749
achristensen@apple.com [Fri, 30 Oct 2015 00:41:39 +0000 (00:41 +0000)]
EFL build fix after r191749

* CMakeLists.txt:
Only Mac should include the Cocoa directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] build-jsc and run-javascriptcore-tests do not work
bfulgham@apple.com [Fri, 30 Oct 2015 00:20:10 +0000 (00:20 +0000)]
[Win] build-jsc and run-javascriptcore-tests do not work
https://bugs.webkit.org/show_bug.cgi?id=150700

Reviewed by Mark Lam.

Correct our build system so that it expects Windows to be using CMake,
and to build the correct sub-projects for our JSC helper scripts.

* Scripts/build-jsc: Make sure to build the testapi harness when
  building for Windows.
* Scripts/build-webkit:
  (1) Use the existing 'cmakeBasedPortName()'
  (2) Use File::Spec rather than hard-coding path delimeters.
  (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
method rather than hard-coding the name based on conditional.
* Scripts/run-javascriptcore-tests:
(testapiPath): Use File::Spec rather than hard-coding path delimeters.
* Scripts/run-jsc: Ditto.
* Scripts/webkitdirs.pm:
(cmakeBasedPortName): Update to return the right value for the Apple
Windows port and the WinCairo port.
(isCMakeBuild): Expect CMake build for all Windows ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash making a tail call from a getter to a host function
msaboff@apple.com [Fri, 30 Oct 2015 00:03:22 +0000 (00:03 +0000)]
Crash making a tail call from a getter to a host function
https://bugs.webkit.org/show_bug.cgi?id=150663

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Change the inline assembly versions of getHostCallReturnValue() to pass the location of the callee
call frame to getHostCallReturnValueWithExecState().  We were passing the caller's frame address.

* jit/JITOperations.cpp:

LayoutTests:

New regression tests.

* js/regress-150663-expected.txt: Added.
* js/regress-150663.html: Added.
* js/script-tests/regress-150663.js: Added.
(Test):
(Test.prototype.get sum):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Display console.timeStamp(title) title in timeline markers
commit-queue@webkit.org [Thu, 29 Oct 2015 23:52:16 +0000 (23:52 +0000)]
Web Inspector: Display console.timeStamp(title) title in timeline markers
https://bugs.webkit.org/show_bug.cgi?id=150691

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-29
Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
(WebInspector.TimelineManager.prototype._processEvent):
Detect unused timeline records.

* UserInterface/Models/TimelineMarker.js:
(WebInspector.TimelineMarker):
(WebInspector.TimelineMarker.prototype.get details):
Give markers an optional details argument.

* UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.addMarker):
When a marker is a TimeStamp, use the details title in
the tooltip if one is available.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
Used \u in localized string. Kept this an endash since it is a range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoB3::LowerToAir::imm() should work for both 32-bit and 64-bit immediates
fpizlo@apple.com [Thu, 29 Oct 2015 23:43:42 +0000 (23:43 +0000)]
B3::LowerToAir::imm() should work for both 32-bit and 64-bit immediates
https://bugs.webkit.org/show_bug.cgi?id=150685

Reviewed by Geoffrey Garen.

In B3, a constant must match the type of its use. In Air, immediates don't have type, they
only have representation. A 32-bit immediate (i.e. Arg::imm) can be used either for 32-bit
operations or for 64-bit operations. The only difference from a Arg::imm64 is that it
requires fewer bits.

In the B3->Air lowering, we have a lot of code that is effectively polymorphic over integer
type. That code should still be able to use Arg::imm, and it should work even for 64-bit
immediates - so long as they are representable as 32-bit immediates. Therefore, the imm()
helper should happily accept either Const32Value or Const64Value.

We already sort of had this with immAnyType(), but it just turns out that anyone using
immAnyType() should really be using imm().

* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::imm):
(JSC::B3::Air::LowerToAir::tryStore):
(JSC::B3::Air::LowerToAir::tryConst64):
(JSC::B3::Air::LowerToAir::immAnyInt): Deleted.
* b3/testb3.cpp:
(JSC::B3::testAdd1):
(JSC::B3::testAdd1Ptr):
(JSC::B3::testStoreAddLoad):
(JSC::B3::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStoreOpLoad pattern matching should check effects between the Store and Load
fpizlo@apple.com [Thu, 29 Oct 2015 23:42:04 +0000 (23:42 +0000)]
StoreOpLoad pattern matching should check effects between the Store and Load
https://bugs.webkit.org/show_bug.cgi?id=150534

Reviewed by Geoffrey Garen.

If we turn:

    a = Load(addr)
    b = Add(a, 42)
    Store(b, addr)

Into:

    Add $42, (addr)

Then we must make sure that we didn't really have this to begin with:

    a = Load(addr)
    Store(666, addr)
    b = Add(a, 42)
    Store(b, addr)

That's because pattern matching doesn't care about control flow, and it finds the Load
just using data flow. This patch fleshes out B3's aliasing analysis, and makes it powerful
enough to broadly ask questions about whether such a code motion of the Load is legal.

* b3/B3Effects.cpp:
(JSC::B3::Effects::interferes):
(JSC::B3::Effects::dump):
* b3/B3Effects.h:
(JSC::B3::Effects::mustExecute):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::commitInternal):
(JSC::B3::Air::LowerToAir::crossesInterference):
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::loadAddr):
* b3/B3Procedure.cpp:
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::resetValueOwners):
(JSC::B3::Procedure::resetReachability):
* b3/B3Procedure.h:
* b3/B3Value.cpp:
(JSC::B3::Value::effects):
* b3/B3Value.h:
* b3/testb3.cpp:
(JSC::B3::testStoreAddLoad):
(JSC::B3::testStoreAddLoadInterference):
(JSC::B3::testStoreAddAndLoad):
(JSC::B3::testLoadOffsetUsingAdd):
(JSC::B3::testLoadOffsetUsingAddInterference):
(JSC::B3::testLoadOffsetUsingAddNotConstant):
(JSC::B3::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKView being inside WKWebView leads to weird API issues
timothy_horton@apple.com [Thu, 29 Oct 2015 23:13:10 +0000 (23:13 +0000)]
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Anders Carlsson.

* Platform/spi/mac/AppKitSPI.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView validRequestorForSendType:returnType:]):
(-[WKView readSelectionFromPasteboard:]):
(-[WKView changeFont:]):
(-[WKView startSpeaking:]):
(-[WKView stopSpeaking:]):
(-[WKView showGuessPanel:]):
(-[WKView checkSpelling:]):
(-[WKView changeSpelling:]):
(-[WKView toggleContinuousSpellChecking:]):
(-[WKView isGrammarCheckingEnabled]):
(-[WKView setGrammarCheckingEnabled:]):
(-[WKView toggleGrammarChecking:]):
(-[WKView toggleAutomaticSpellingCorrection:]):
(-[WKView orderFrontSubstitutionsPanel:]):
(-[WKView toggleSmartInsertDelete:]):
(-[WKView isAutomaticQuoteSubstitutionEnabled]):
(-[WKView setAutomaticQuoteSubstitutionEnabled:]):
(-[WKView toggleAutomaticQuoteSubstitution:]):
(-[WKView isAutomaticDashSubstitutionEnabled]):
(-[WKView setAutomaticDashSubstitutionEnabled:]):
(-[WKView toggleAutomaticDashSubstitution:]):
(-[WKView isAutomaticLinkDetectionEnabled]):
(-[WKView setAutomaticLinkDetectionEnabled:]):
(-[WKView toggleAutomaticLinkDetection:]):
(-[WKView isAutomaticTextReplacementEnabled]):
(-[WKView setAutomaticTextReplacementEnabled:]):
(-[WKView toggleAutomaticTextReplacement:]):
(-[WKView uppercaseWord:]):
(-[WKView lowercaseWord:]):
(-[WKView capitalizeWord:]):
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::readSelectionFromPasteboard):
(WebKit::WebViewImpl::validRequestorForSendAndReturnTypes):
(WebKit::WebViewImpl::changeFontFromFontPanel):
(WebKit::WebViewImpl::startSpeaking):
(WebKit::WebViewImpl::stopSpeaking):
(WebKit::WebViewImpl::showGuessPanel):
(WebKit::WebViewImpl::checkSpelling):
(WebKit::WebViewImpl::changeSpelling):
(WebKit::WebViewImpl::toggleContinuousSpellChecking):
(WebKit::WebViewImpl::isGrammarCheckingEnabled):
(WebKit::WebViewImpl::setGrammarCheckingEnabled):
(WebKit::WebViewImpl::toggleGrammarChecking):
(WebKit::WebViewImpl::toggleAutomaticSpellingCorrection):
(WebKit::WebViewImpl::orderFrontSubstitutionsPanel):
(WebKit::WebViewImpl::toggleSmartInsertDelete):
(WebKit::WebViewImpl::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebViewImpl::setAutomaticQuoteSubstitutionEnabled):
(WebKit::WebViewImpl::toggleAutomaticQuoteSubstitution):
(WebKit::WebViewImpl::isAutomaticDashSubstitutionEnabled):
(WebKit::WebViewImpl::setAutomaticDashSubstitutionEnabled):
(WebKit::WebViewImpl::toggleAutomaticDashSubstitution):
(WebKit::WebViewImpl::isAutomaticLinkDetectionEnabled):
(WebKit::WebViewImpl::setAutomaticLinkDetectionEnabled):
(WebKit::WebViewImpl::toggleAutomaticLinkDetection):
(WebKit::WebViewImpl::setAutomaticTextReplacementEnabled):
(WebKit::WebViewImpl::toggleAutomaticTextReplacement):
(WebKit::WebViewImpl::uppercaseWord):
(WebKit::WebViewImpl::lowercaseWord):
(WebKit::WebViewImpl::capitalizeWord):
Move spellcheck and related bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRevert inadvertent changes
eric.carlson@apple.com [Thu, 29 Oct 2015 22:35:37 +0000 (22:35 +0000)]
Revert inadvertent changes
https://bugs.webkit.org/show_bug.cgi?id=150694

Reviewed by Tim Horton.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCMake build fix.
achristensen@apple.com [Thu, 29 Oct 2015 22:32:04 +0000 (22:32 +0000)]
CMake build fix.

Source/WebCore:

* editing/mac/EditorMac.mm:
(WebCore::Editor::WebContentReader::readFilenames):
Before r191553, text was a local variable and could be changed.
This restores the same behavior and compiles correctly when ATTACHMENT_ELEMENT is disabled.
* platform/mac/CursorMac.mm:
(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):
Added preprocessor macros.

Source/WebKit2:

* CMakeLists.txt:
* PlatformMac.cmake:
I mistakenly added some mac-specific files to the shared CMakeLists.txt.  This puts them in the right place.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::didEndColorPicker):
Add preprocessor enable checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModern IDB: deleteObjectStore support.
beidson@apple.com [Thu, 29 Oct 2015 22:08:51 +0000 (22:08 +0000)]
Modern IDB: deleteObjectStore support.
https://bugs.webkit.org/show_bug.cgi?id=150673

Reviewed by Alex Christensen.

Source/JavaScriptCore:

* runtime/VM.h:

Source/WebCore:

Tests: storage/indexeddb/modern/deleteobjectstore-1.html
       storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html
       storage/indexeddb/modern/idbobjectstore-get-failures.html

* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::deleteObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::didDeleteObjectStore):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBConnectionToServerDelegate.h:

* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::deleteObjectStore):
(WebCore::IDBClient::IDBDatabase::willCommitTransaction):
(WebCore::IDBClient::IDBDatabase::willAbortTransaction):
(WebCore::IDBClient::IDBDatabase::commitTransaction): Deleted.
(WebCore::IDBClient::IDBDatabase::abortTransaction): Deleted.
* Modules/indexeddb/client/IDBDatabaseImpl.h:

* Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::markAsDeleted):
* Modules/indexeddb/client/IDBObjectStoreImpl.h:

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::abortOnServer):
(WebCore::IDBClient::IDBTransaction::commit):
(WebCore::IDBClient::IDBTransaction::commitOnServer):
(WebCore::IDBClient::IDBTransaction::deleteObjectStore):
(WebCore::IDBClient::IDBTransaction::deleteObjectStoreOnServer):
(WebCore::IDBClient::IDBTransaction::didDeleteObjectStoreOnServer):
(WebCore::IDBClient::IDBTransaction::activate):
(WebCore::IDBClient::IDBTransaction::activationTimerFired): Deleted.
(WebCore::IDBClient::IDBTransaction::createObjectStoreOnServer): Deleted.
(WebCore::IDBClient::IDBTransaction::didCreateObjectStoreOnServer): Deleted.
(WebCore::IDBClient::IDBTransaction::getRecordOnServer): Deleted.
(WebCore::IDBClient::IDBTransaction::putOrAddOnServer): Deleted.
* Modules/indexeddb/client/IDBTransactionImpl.h:

* Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::completed):
(WebCore::IDBClient::createTransactionOperation):

* Modules/indexeddb/server/IDBBackingStore.h:

* Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didDeleteObjectStore):
* Modules/indexeddb/server/IDBConnectionToClient.h:
* Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::deleteObjectStore):
* Modules/indexeddb/server/IDBServer.h:

* Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::objectStoreDeleted):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
(WebCore::IDBServer::MemoryBackingStoreTransaction::finish):
* Modules/indexeddb/server/MemoryBackingStoreTransaction.h:

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::restoreObjectStoreForVersionChangeAbort):
(WebCore::IDBServer::MemoryIDBBackingStore::takeObjectStoreByName):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformDeleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabase.h:

* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didDeleteObjectStore):
* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:

* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::deleteObjectStore):
* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:

* Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::deleteObjectStore):
* Modules/indexeddb/shared/IDBDatabaseInfo.h:

* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::deleteObjectStoreSuccess):
* Modules/indexeddb/shared/IDBResultData.h:

* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didDeleteObjectStore):
(WebCore::InProcessIDBServer::deleteObjectStore):
* Modules/indexeddb/shared/InProcessIDBServer.h:

LayoutTests:

* storage/indexeddb/modern/deleteobjectstore-1-expected.txt: Added.
* storage/indexeddb/modern/deleteobjectstore-1.html: Added.
* storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt: Added.
* storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html: Added.
* storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt: Added.
* storage/indexeddb/modern/idbobjectstore-get-failures.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKView being inside WKWebView leads to weird API issues
timothy_horton@apple.com [Thu, 29 Oct 2015 22:07:42 +0000 (22:07 +0000)]
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView browsingContextController]):
(-[WKView validateUserInterfaceItem:]):
(-[WKView saveBackForwardSnapshotForCurrentItem]):
(-[WKView saveBackForwardSnapshotForItem:]):
(-[WKView updateLayer]):
(-[WKView minimumSizeForAutoLayout]):
(-[WKView setMinimumSizeForAutoLayout:]):
(-[WKView shouldExpandToViewHeightForAutoLayout]):
(-[WKView setShouldExpandToViewHeightForAutoLayout:]):
(-[WKView underlayColor]):
(-[WKView setUnderlayColor:]):
(-[WKView _setOverlayScrollbarStyle:]):
(-[WKView _overlayScrollbarStyle]):
(-[WKView _pageExtendedBackgroundColor]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
(-[WKView waitForAsyncDrawingAreaSizeUpdate]):
(-[WKView isUsingUISideCompositing]):
(createSelectorExceptionMap): Deleted.
(commandNameForSelector): Deleted.
(menuItem): Deleted.
(toolbarItem): Deleted.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Deleted.
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::createDrawingAreaProxy):
(WebKit::WebViewImpl::isUsingUISideCompositing):
(WebKit::WebViewImpl::forceAsyncDrawingAreaSizeUpdate):
(WebKit::WebViewImpl::waitForAsyncDrawingAreaSizeUpdate):
(WebKit::WebViewImpl::updateLayer):
(WebKit::WebViewImpl::setMinimumSizeForAutoLayout):
(WebKit::WebViewImpl::minimumSizeForAutoLayout):
(WebKit::WebViewImpl::setShouldExpandToViewHeightForAutoLayout):
(WebKit::WebViewImpl::shouldExpandToViewHeightForAutoLayout):
(WebKit::WebViewImpl::setUnderlayColor):
(WebKit::WebViewImpl::underlayColor):
(WebKit::WebViewImpl::pageExtendedBackgroundColor):
(WebKit::WebViewImpl::setOverlayScrollbarStyle):
(WebKit::WebViewImpl::overlayScrollbarStyle):
(WebKit::createSelectorExceptionMap):
(WebKit::commandNameForSelector):
(WebKit::WebViewImpl::executeSavedCommandBySelector):
(WebKit::WebViewImpl::executeEditCommandForSelector):
(WebKit::menuItem):
(WebKit::toolbarItem):
(WebKit::WebViewImpl::validateUserInterfaceItem):
(WebKit::WebViewImpl::setUserInterfaceItemState):
(WebKit::WebViewImpl::browsingContextController):
(WebKit::WebViewImpl::saveBackForwardSnapshotForCurrentItem):
(WebKit::WebViewImpl::saveBackForwardSnapshotForItem):
(WebKit::WebViewImpl::executeEditCommand): Deleted.
Move UI validation and a grab-bag of other things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVery slow typing on pages with wheel event handlers on the body, and deep content
simon.fraser@apple.com [Thu, 29 Oct 2015 21:54:24 +0000 (21:54 +0000)]
Very slow typing on pages with wheel event handlers on the body, and deep content
https://bugs.webkit.org/show_bug.cgi?id=150692
rdar://problem/23242631

Reviewed by Zalan Bujtas.

On a large page with a wheel event handler on the body, we would call
Element::absoluteEventHandlerBounds() for every element under the body,
and compute an absolute bounds for each one. This is very slow.

For now, optimize computing a region for the <body> by just using the document
bounds, which will always be as big or larger. It's OK for this region to
be an overestimate.

* dom/Document.cpp:
(WebCore::Document::absoluteRegionForEventTargets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build-jsc on Mac after r191749.
achristensen@apple.com [Thu, 29 Oct 2015 21:33:18 +0000 (21:33 +0000)]
Fix build-jsc on Mac after r191749.

* Scripts/build-jsc:
Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agocdjs-tests.yaml/main.js.ftl fails due to FTL ArithSub code for supporting UntypedUse...
mark.lam@apple.com [Thu, 29 Oct 2015 21:08:05 +0000 (21:08 +0000)]
cdjs-tests.yaml/main.js.ftl fails due to FTL ArithSub code for supporting UntypedUse operands.
https://bugs.webkit.org/show_bug.cgi?id=150687

Unreviewed.

Disabling the feature while it is being debugged.  I'm doing this by effectively
rolling out only the changes in FTLCapabilities.cpp.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDate input values should not overlap with menu list dropdown button on iOS
wenson_hsieh@apple.com [Thu, 29 Oct 2015 20:18:56 +0000 (20:18 +0000)]
Date input values should not overlap with menu list dropdown button on iOS
https://bugs.webkit.org/show_bug.cgi?id=150681
<rdar://problem/19965078>

Reviewed by Zalan Bujtas.

Source/WebCore:

Adds a right margin on iOS date and time inputs so that the inner div does
not render the value of the date on top of the dropdown button on the right
of the menu list.

Tests: fast/forms/date/date-input-rendering-basic.html
       fast/forms/time/time-input-rendering-basic.html

* css/html.css:
(input::-webkit-date-and-time-value):

LayoutTests:

Tests that date and time inputs render properly. Namely, the text should not
be rendered such that it covers the dropdown button on the right of the menu
list.

* fast/forms/date/date-input-rendering-basic-expected.txt: Added.
* fast/forms/date/date-input-rendering-basic.html: Added.
* fast/forms/time/time-input-rendering-basic-expected.txt: Added.
* fast/forms/time/time-input-rendering-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, fix iOS build.
fpizlo@apple.com [Thu, 29 Oct 2015 20:09:57 +0000 (20:09 +0000)]
Unreviewed, fix iOS build.

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::store64):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix Mac CMake build
achristensen@apple.com [Thu, 29 Oct 2015 20:01:20 +0000 (20:01 +0000)]
Fix Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=150686

Reviewed by Filip Pizlo.

.:

* Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

* API/ObjCCallbackFunction.mm:
* CMakeLists.txt:
* PlatformMac.cmake:

Source/WebCore:

* PlatformMac.cmake:

Source/WebKit:

* CMakeLists.txt:
* PlatformMac.cmake:

Source/WebKit2:

* CMakeLists.txt:
* PlatformMac.cmake:

Source/WTF:

* wtf/CMakeLists.txt:
* wtf/Platform.h:
* wtf/PlatformMac.cmake:

Tools:

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(isCachedArgumentfileOutOfDate):
(wrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
(cmakeBasedPortName):
(determineIsCMakeBuild):
(isCMakeBuild):
(promptUser):
(jhbuildWrapperPrefixIfNeeded): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoOne more URTBF after r191731.
ossy@webkit.org [Thu, 29 Oct 2015 19:40:27 +0000 (19:40 +0000)]
One more URTBF after r191731.

* rendering/svg/RenderSVGResourcePattern.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTeach JSC bots to build 32bit instead of x86_64
lforschler@apple.com [Thu, 29 Oct 2015 19:39:30 +0000 (19:39 +0000)]
Teach JSC bots to build 32bit instead of x86_64

Reviewed by Mark Lam.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r191731.
ossy@webkit.org [Thu, 29 Oct 2015 19:35:31 +0000 (19:35 +0000)]
URTBF after r191731.

* rendering/svg/RenderSVGResourcePattern.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAir needs syntax for escaping StackSlots
fpizlo@apple.com [Thu, 29 Oct 2015 19:16:29 +0000 (19:16 +0000)]
Air needs syntax for escaping StackSlots
https://bugs.webkit.org/show_bug.cgi?id=150430

Reviewed by Geoffrey Garen.

This adds lowering for FramePointer and StackSlot, and to enable this, it adds the Lea
instruction for getting the value of an address. This is necessary to support arbitrary
lowerings of StackSlot, since the only way to get the "value" of a StackSlot in Air is with
this new instruction.

Lea uses a new Role, called UseAddr. This describes exactly what the Intel-style LEA opcode
would do: it evaluates an address, but does not load from it or store to it.

Lea is also the only way to escape a StackSlot. Well, more accurately, UseAddr is the only
way to escape and UseAddr is only used by Lea. The stack allocation phase now understands
that StackSlots may escape, and factors this into its analysis.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::lea):
* b3/B3AddressMatcher.patterns:
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::addr):
(JSC::B3::Air::LowerToAir::loadAddr):
(JSC::B3::Air::LowerToAir::AddressSelector::tryAdd):
(JSC::B3::Air::LowerToAir::AddressSelector::tryFramePointer):
(JSC::B3::Air::LowerToAir::AddressSelector::tryStackSlot):
(JSC::B3::Air::LowerToAir::AddressSelector::tryDirect):
(JSC::B3::Air::LowerToAir::tryConst64):
(JSC::B3::Air::LowerToAir::tryFramePointer):
(JSC::B3::Air::LowerToAir::tryStackSlot):
(JSC::B3::Air::LowerToAir::tryIdentity):
* b3/B3LoweringMatcher.patterns:
* b3/B3MemoryValue.cpp:
(JSC::B3::MemoryValue::~MemoryValue):
(JSC::B3::MemoryValue::accessByteSize):
(JSC::B3::MemoryValue::dumpMeta):
* b3/B3MemoryValue.h:
* b3/B3ReduceStrength.cpp:
* b3/B3StackSlotValue.h:
(JSC::B3::StackSlotValue::accepts): Deleted.
* b3/B3Type.h:
(JSC::B3::pointerType):
(JSC::B3::sizeofType):
* b3/B3Validate.cpp:
* b3/B3Value.h:
* b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::isUse):
(JSC::B3::Air::Arg::isDef):
(JSC::B3::Air::Arg::forEachTmp):
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::addSpecial):
* b3/air/AirCode.h:
* b3/air/AirOpcode.opcodes:
* b3/air/AirSpillEverything.cpp:
(JSC::B3::Air::spillEverything):
* b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::byteSize):
(JSC::B3::Air::StackSlot::kind):
(JSC::B3::Air::StackSlot::isLocked):
(JSC::B3::Air::StackSlot::index):
(JSC::B3::Air::StackSlot::alignment):
* b3/air/opcode_generator.rb:
* b3/testb3.cpp:
(JSC::B3::testLoadOffsetUsingAddNotConstant):
(JSC::B3::testFramePointer):
(JSC::B3::testStackSlot):
(JSC::B3::testLoadFromFramePointer):
(JSC::B3::testStoreLoadStackSlot):
(JSC::B3::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowe're incorrectly adjusting a stack location with respect to the localsOffset in...
sbarati@apple.com [Thu, 29 Oct 2015 19:14:32 +0000 (19:14 +0000)]
we're incorrectly adjusting a stack location with respect to the localsOffset in FTLCompile
https://bugs.webkit.org/show_bug.cgi?id=150655

Reviewed by Filip Pizlo.

We're recomputing this value for an *OSRExitDescriptor* for every one
of its corresponding *OSRExits*. This is having a multiplicative
effect on offsets because each computation is relative to the previous
value. We must do this computation just once per OSRExitDescriptor.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Fall back to AppleWin results in layout tests.
peavo@outlook.com [Thu, 29 Oct 2015 19:13:56 +0000 (19:13 +0000)]
[WinCairo] Fall back to AppleWin results in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=150672

Reviewed by Alex Christensen.

* Scripts/webkitpy/port/win.py:
(WinCairoPort):
(WinCairoPort.default_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAir::spillEverything() should try to replace tmps with spill slots without using...
fpizlo@apple.com [Thu, 29 Oct 2015 19:01:04 +0000 (19:01 +0000)]
Air::spillEverything() should try to replace tmps with spill slots without using registers whenever possible
https://bugs.webkit.org/show_bug.cgi?id=150657

Reviewed by Geoffrey Garen.

Also added the ability to store an immediate to memory.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::storePtr):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::store64):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::store64):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::imm):
(JSC::B3::Air::LowerToAir::immAnyInt):
(JSC::B3::Air::LowerToAir::immOrTmp):
(JSC::B3::Air::LowerToAir::tryStore):
* b3/air/AirOpcode.opcodes:
* b3/air/AirSpillEverything.cpp:
(JSC::B3::Air::spillEverything):
* b3/testb3.cpp:
(JSC::B3::testStore):
(JSC::B3::testStoreConstant):
(JSC::B3::testStoreConstantPtr):
(JSC::B3::testTrunc):
(JSC::B3::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobmalloc: AsyncTask should handle destruction
ggaren@apple.com [Thu, 29 Oct 2015 18:45:11 +0000 (18:45 +0000)]
bmalloc: AsyncTask should handle destruction
https://bugs.webkit.org/show_bug.cgi?id=150648

Reviewed by Mark Lam.

So we can use it in more places.

* bmalloc/AsyncTask.h: Use std::thread instead of pthread because it
should be more portable.

(bmalloc::Function>::AsyncTask): Renamed Signaled to RunRequested for
clarity. Added an ExitRequested state.

(bmalloc::Function>::~AsyncTask): Wait for our child thread to exit
before destroying ourselves because our child thread will modify our
data (and might modify our client's data). Note that we only need to
wait for the last child thread since any prior child thread, having
reached the Exited condition, is guaranteed not to read or write any
data.

(bmalloc::Function>::run):
(bmalloc::Function>::runSlowCase): Updated for interface changes. Also
changed to use our WebKit style for condition signal: Hold the lock
during the signal and always notify all. Technically, neither is necessary,
but it is easier to understand the code this way, and harder to make
mistakes.

(bmalloc::Function>::threadEntryPoint):
(bmalloc::Function>::threadRunLoop): Handle the new ExitRequested state.
Technically, this state has no meaningful difference from the Exited
state, but it is nice to be explicit.

(bmalloc::Function>::join): Deleted.
(bmalloc::Function>::pthreadEntryPoint): Deleted.
(bmalloc::Function>::entryPoint): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Navigation bar icons are missing
timothy@apple.com [Thu, 29 Oct 2015 18:35:17 +0000 (18:35 +0000)]
Web Inspector: Navigation bar icons are missing
https://bugs.webkit.org/show_bug.cgi?id=150677

Reviewed by Joseph Pecoraro.

The glyph width and height were not being set correctly and it broke NavigationBar buttons.
The width and height attribute was being set on a div, when it should have used the style property.
Also remove the suppressEmboss flag, which is no longer used but the clients and subclasses still did.

* UserInterface/Base/ImageUtilities.js:
(useSVGSymbol): Use style property instead of setting width and height. The attributes
didn't accomplish the same thing in all cases. Use title and className property on the
wrapper element and remove the comments, which applied when there wasn't a wrapper.

* UserInterface/Views/ActivateButtonNavigationItem.js:
(WebInspector.ActivateButtonNavigationItem): Remove suppressEmboss.
* UserInterface/Views/ActivateButtonToolbarItem.js:
(WebInspector.ActivateButtonToolbarItem): Remove suppressEmboss.

* UserInterface/Views/ButtonNavigationItem.js:
(WebInspector.ButtonNavigationItem): Remove suppressEmboss.
(WebInspector.ButtonNavigationItem.prototype.set image): Use style property instead of setting
width and height attributes. This assumed the SVG element was the glyph element, which changed
at one point without me remembering to fix this client.

* UserInterface/Views/ButtonToolbarItem.js:
(WebInspector.ButtonToolbarItem):  Remove suppressEmboss.
* UserInterface/Views/DebuggerDashboardView.js:
(WebInspector.DebuggerDashboardView): Remove suppressEmboss use.
* UserInterface/Views/FilterBar.js:
(WebInspector.FilterBar.prototype.addFilterBarButton): Remove suppressEmboss.
* UserInterface/Views/FilterBarButton.js:
(WebInspector.FilterBarButton): Remove suppressEmboss.
* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):  Remove suppressEmboss use.
* UserInterface/Views/ToggleButtonNavigationItem.js:
(WebInspector.ToggleButtonNavigationItem): Remove suppressEmboss.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove a never used SPI delegate method
andersca@apple.com [Thu, 29 Oct 2015 18:30:43 +0000 (18:30 +0000)]
Remove a never used SPI delegate method
https://bugs.webkit.org/show_bug.cgi?id=150680

Reviewed by Beth Dakin.

The webView:contextMenuItemSelected:forElement: method was added 9 years ago, seemingly for feature parity with the Windows port.
The delegate method will never be called unless a menu item has the internal WebKit action/target pair, and a tag that
is set to >= ContextMenuItemBaseApplicationTag. Because of this, we can safely remove it.

* DefaultDelegates/WebDefaultUIDelegate.m:
(-[WebDefaultUIDelegate webView:willPopupMenu:]):
(-[WebDefaultUIDelegate webView:didDrawRect:]):
(-[WebDefaultUIDelegate webView:didScrollDocumentInFrameView:]):
(-[WebDefaultUIDelegate webView:contextMenuItemSelected:forElement:]): Deleted.
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::contextMenuItemSelected): Deleted.
* WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix ENABLE(TREE_DEBUGGING) release build.
zalan@apple.com [Thu, 29 Oct 2015 18:26:33 +0000 (18:26 +0000)]
Fix ENABLE(TREE_DEBUGGING) release build.

Unreviewed build fix.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* dom/Position.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoOverlay scrollbars disappear during manual drag-scroll
bdakin@apple.com [Thu, 29 Oct 2015 18:07:46 +0000 (18:07 +0000)]
Overlay scrollbars disappear during manual drag-scroll
https://bugs.webkit.org/show_bug.cgi?id=150646
-and corresponding-
rdar://problem/23145734

Reviewed by Tim Horton.

New ScrollAnimator function so that we can tell the ScrollbarPainter whether
or not the mouse is tracking the scrollbar.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::ScrollAnimator::mouseIsDownInScrollbar):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::mouseIsDownInScrollbar):
* platform/ScrollableArea.h:

Call into the new ScrollAnimator function of mouseDown and mouseUp.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::mouseDown):

Add setTracking to the ScrollbarPainter.
* platform/mac/NSScrollerImpDetails.h:

Implement mouseIsDownInScrollbar to call setTracking appropriately and to set
begin/endScrollGesture since drag scrolling does not normally trigger that
state change.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mouseIsDownInScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMediaPlayer::getSupportedTypes only returns types from the last engine registered
eric.carlson@apple.com [Thu, 29 Oct 2015 17:58:38 +0000 (17:58 +0000)]
MediaPlayer::getSupportedTypes only returns types from the last engine registered
https://bugs.webkit.org/show_bug.cgi?id=150669

Reviewed by Jer Noble.

No new tests, fixes existing tests.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getSupportedTypes):
(WebCore::MediaPlayer::isAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agostorage/indexeddb/modern tests crashing frequently on mac-wk1, marking as flaky crashers
ryanhaddad@apple.com [Thu, 29 Oct 2015 17:43:19 +0000 (17:43 +0000)]
storage/indexeddb/modern tests crashing frequently on mac-wk1, marking as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=150678

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Clean up and audit TimelineRecordFactory records
commit-queue@webkit.org [Thu, 29 Oct 2015 17:20:42 +0000 (17:20 +0000)]
Web Inspector: Clean up and audit TimelineRecordFactory records
https://bugs.webkit.org/show_bug.cgi?id=150660

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-29
Reviewed by Brian Burg.

Source/WebCore:

Cleanup included removing unused methods and payload data that the
frontend wasn't likely to use. Also added ASCIILiteral and removed
unnecessary includes.

* inspector/InspectorNetworkAgent.cpp:
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willLayout):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createParseHTMLData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):
(WebCore::TimelineRecordFactory::createBackgroundRecord): Deleted.
(WebCore::TimelineRecordFactory::createLayoutData): Deleted.
* inspector/TimelineRecordFactory.h:
(WebCore::TimelineRecordFactory::TimelineRecordFactory):

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
(WebInspector.TimelineManager.prototype._processEvent):
Add FIXME for payload data which we are not yet using but could.
Fix typo in some rAF records where we were mistakenly using "timerId"
instead of "id" for the request identifier.

* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
Display the now correctly accessed rAF identifier in the Scripts timeline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoExploitable crash happens when an SVG contains an indirect resource inheritance cycle
said@apple.com [Thu, 29 Oct 2015 17:12:43 +0000 (17:12 +0000)]
Exploitable crash happens when an SVG contains an indirect resource inheritance cycle
https://bugs.webkit.org/show_bug.cgi?id=150203

Reviewed by Brent Fulgham.

Source/WebCore:

Detecting cycles in SVG resource references happens in two places.
1. In SVGResourcesCycleSolver::resolveCycles() which it is called from
   SVGResourcesCache::addResourcesFromRenderer(). When a cycle is deleted,
   SVGResourcesCycleSolver::breakCycle() is called to break the link. In
   the case of a cyclic resource inheritance, SVGResources::resetLinkedResource()
   is called to break this cycle.
2. SVGPatternElement::collectPatternAttributes() which is called from
   RenderSVGResourcePattern::buildPattern(). The purpose is to resolve
   the pattern attributes and to build a tile image which can be used to
   fill the SVG element renderer. Detecting the cyclic resource reference
   in this function is not sufficient and can detect simple cycles like
    <pattern id="a" xlink:href="#b"/>
    <pattern id="b" xlink:href="#a"/>.
   But it does not detect cycles like:
    <pattern id="a">
        <rect fill="url(#b)"/>
    </pattern>
    <pattern id="b" xlink:href="#a"/>.

The fix is to get rid of SVGPatternElement::collectPatternAttributes() which
uses SVGURIReference::targetElementFromIRIString() to navigates through the
referenced resource elements and tries to detect cycles. Instead we can
implement RenderSVGResourcePattern::collectPatternAttributes() which calls
SVGResourcesCache::cachedResourcesForRenderer() to get the SVGResources
of the pattern. Then we use SVGResources::linkedResource() to navigate the
resource inheritance tree. The cached SVGResources is guaranteed to be free
of cycles.

Tests: svg/custom/pattern-content-inheritance-cycle.svg

* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::collectPatternAttributes):
Collect the pattern attributes through the cachedResourcesForRenderer().

(WebCore::RenderSVGResourcePattern::buildPattern):
Direct the call to the renderer function.

* rendering/svg/RenderSVGResourcePattern.h:

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
RenderSVGRoot needs to call SVGResourcesCache::clientStyleChanged() for all
the invalidated resources. If an attribute of an SVG resource was updated
dynamically, the cached SVGResources associated with the renderer of this
resource was stale.

* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
Direct the call to the renderer function.

* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
(WebCore::setPatternAttributes): Deleted.
collectPatternAttributes() is a replacement of setPatternAttributes().

LayoutTests:

Ensure that we do not crash when an SVG has an indirect cyclic resource
inheritance. Make sure the cyclic resource was just ignored as if it did
not exist.

* svg/custom/pattern-content-inheritance-cycle-expected.svg: Added.
* svg/custom/pattern-content-inheritance-cycle.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Streams API] Turn WS states into integers and fix state initialization
calvaris@igalia.com [Thu, 29 Oct 2015 16:51:41 +0000 (16:51 +0000)]
[Streams API] Turn WS states into integers and fix state initialization
https://bugs.webkit.org/show_bug.cgi?id=150667

Reviewed by Youenn Fablet.

The goal of this patch is turning the writable stream states into integers instead of strings.

First readable stream states were reworked to be shared with writable stream too, they are now just @stream*.

Next step was having writable stream using integers instead of strings and translating those integers back to
strings to be able to return them correctly with the writable stream state attribute.

The state initialization was fixed and now it is not needed to check for the state to be undefined.

Rework, no new tests needed.

* Modules/streams/ReadableStream.js:
(initializeReadableStream):
* Modules/streams/ReadableStreamController.js:
(enqueue):
(error):
(close):
* Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamReader):
(errorReadableStream):
(cancelReadableStream):
(finishClosingReadableStream):
(closeReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader):
* Modules/streams/ReadableStreamReader.js:
(cancel):
* Modules/streams/WritableStream.js:
(initializeWritableStream):
(abort):
(close):
(write):
(state):
* Modules/streams/WritableStreamInternals.js:
(syncWritableStreamStateWithQueue):
(errorWritableStream):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation):
* bindings/js/WebCoreBuiltinNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r191728.
commit-queue@webkit.org [Thu, 29 Oct 2015 13:12:33 +0000 (13:12 +0000)]
Unreviewed, rolling out r191728.
https://bugs.webkit.org/show_bug.cgi?id=150668

Caused a lot of timeouts in layout tests (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK] Use a persistent main loop source in RunLoop glib
implementation"
https://bugs.webkit.org/show_bug.cgi?id=150590
http://trac.webkit.org/changeset/191728

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use a persistent main loop source in RunLoop glib implementation
carlosgc@webkit.org [Thu, 29 Oct 2015 12:19:37 +0000 (12:19 +0000)]
[GTK] Use a persistent main loop source in RunLoop glib implementation
https://bugs.webkit.org/show_bug.cgi?id=150590

Reviewed by Žan Doberšek.

Source/WebKit2:

Use RunLoop::dispatch() instead of
GMainLoopSource::scheduleAndDeleteOnDestroy in a couple of simple
cases.

* NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::runTaskInQueue):
* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::dragLeave):

Source/WTF:

It's more efficient than creating and destroying a new source for
every dispatch and it simplifies the code.

* wtf/RunLoop.h:
* wtf/glib/MainThreadGLib.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread): Use
RunLoop::dispatch() instead of GMainLoopSource::scheduleAndDeleteOnDestroy().
* wtf/glib/RunLoopGLib.cpp:
(WTF::RunLoop::RunLoop): Create and setup the persistent source.
(WTF::RunLoop::~RunLoop): Destroy the persistent source.
(WTF::RunLoop::stop): Stop the persistent source before stopping
the main loop.
(WTF::RunLoop::wakeUp): Make the persistent source active. We
no longer need to explicitly wakeup the context.
(WTF::RunLoop::TimerBase::TimerBase): Create and setup the
persistent source.
(WTF::RunLoop::TimerBase::~TimerBase): Destroy the persistent source.
(WTF::RunLoop::TimerBase::updateReadyTime): Set the ready time
according to the fire interval.
(WTF::RunLoop::TimerBase::start): Make the persistent source active.
(WTF::RunLoop::TimerBase::stop): Stop the persistent source.
(WTF::RunLoop::TimerBase::isActive): Return whether the
persistent source is active.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. GTK+ gardening: rebaseline more tests after r191623.
carlosgc@webkit.org [Thu, 29 Oct 2015 11:13:56 +0000 (11:13 +0000)]
Unreviewed. GTK+ gardening: rebaseline more tests after r191623.

* platform/gtk/editing/selection/5057506-expected.txt:
* platform/gtk/editing/selection/display-table-text-expected.txt:
* platform/gtk/editing/selection/iframe-expected.txt:
* platform/gtk/editing/selection/mixed-editability-3-expected.txt:
* platform/gtk/editing/selection/mixed-editability-4-expected.txt:
* platform/gtk/editing/selection/mixed-editability-5-expected.txt:
* platform/gtk/editing/selection/mixed-editability-8-expected.txt:
* platform/gtk/editing/selection/mixed-editability-9-expected.txt:
* platform/gtk/fast/css-generated-content/015-expected.txt:
* platform/gtk/fast/css/acid2-expected.txt:
* platform/gtk/fast/css/acid2-pixel-expected.txt:
* platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Added.
* platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
* platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Added.
* platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug101674-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug106795-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug106816-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug110566-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug113424-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug126742-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug128229-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug131020-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug133756-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug133948-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug139524-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug157890-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1818-3-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug1818-6-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug196870-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug219693-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug219693-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug222467-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug50695-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug63785-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug67864-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug67915-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug68998-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug69187-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug69382-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug69382-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug73321-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug78162-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8032-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug81934-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug82946-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug86708-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug88035-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug88035-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug92143-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug97138-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug97383-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug98196-expected.txt:
* platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Added.
* platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_colspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_height-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_nowrap-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_rowspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_width-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
* platform/gtk/tables/table-section-overflow-clip-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. GTK+ gardening: rebaseline more tests after r191623.
carlosgc@webkit.org [Thu, 29 Oct 2015 09:36:44 +0000 (09:36 +0000)]
Unreviewed. GTK+ gardening: rebaseline more tests after r191623.

* platform/gtk/tables/mozilla/bugs/bug100334-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug101201-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug102145-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug102145-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug102145-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug102145-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug103533-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug106158-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug106158-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug108340-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug120107-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug120364-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug131020_iframe-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug133756-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug137388-1-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug137388-3-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug139524-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug139524-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug139524-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug145572-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug154780-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug159108-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug175455-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug215629-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug221784-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug221784-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug222336-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug269566-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug275625-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug277062-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug278266-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug72359-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug75250-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug83786-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug88524-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug93363-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug96343-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99923-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. GTK+ gardening: rebaseline more tests after r191623.
carlosgc@webkit.org [Thu, 29 Oct 2015 08:45:51 +0000 (08:45 +0000)]
Unreviewed. GTK+ gardening: rebaseline more tests after r191623.

* platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug16252-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug17130-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug17138-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug17168-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug17548-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug17587-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18440-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18558-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18664-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18955-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19356-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug20579-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug20804-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug21299-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug21918-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug22019-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug22246-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug22246-2a-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug22246-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug22246-3a-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug22513-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23072-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23151-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug23235-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23299-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24503-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24627-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24880-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug25004-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug25074-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug25086-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug25367-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug25663-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug26553-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27993-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28933-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug29058-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug29157-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug29429-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30273-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30559-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30692-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30985-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32205-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32205-5-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32447-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32841-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug33137-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug34176-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug34538-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug35662-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug40828-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug41890-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug42187-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug42443-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug43039-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug43204-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug43854-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44523-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug45055-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug45055-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug45350-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug45486-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46480-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46480-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46623-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46944-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug47432-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug48028-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug48028-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug48827-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug50695-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug53690-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug53891-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55789-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57300-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57828-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug58402-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug59354-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug60013-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug60804-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug60807-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug60992-expected.txt:
* platform/gtk/tables/mozilla/marvin/th_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_span-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_width_pct-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_width_px-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_col_width_rel-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_span-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_width_pct-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_rules_none-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_colspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_height-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_nowrap-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_rowspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_width-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/gtk/tables/mozilla/other/slashlogo-expected.txt:
* platform/gtk/tables/mozilla/other/test3-expected.txt:
* platform/gtk/tables/mozilla/other/test6-expected.txt:
* platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
* platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. EFL gardening: rebaseline more tests after r191623.
hs85.jeong@samsung.com [Thu, 29 Oct 2015 08:14:31 +0000 (08:14 +0000)]
Unreviewed. EFL gardening: rebaseline more tests after r191623.

* platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
* platform/efl/editing/selection/4818145-expected.txt:
* platform/efl/editing/selection/4889598-expected.txt:
* platform/efl/editing/selection/5076323-1-expected.txt:
* platform/efl/editing/selection/5076323-2-expected.txt:
* platform/efl/editing/selection/5076323-3-expected.txt:
* platform/efl/editing/selection/7152-1-expected.txt:
* platform/efl/editing/selection/7152-2-expected.txt:
* platform/efl/editing/selection/display-table-text-expected.txt:
* platform/efl/editing/selection/mixed-editability-3-expected.txt:
* platform/efl/editing/selection/mixed-editability-4-expected.txt:
* platform/efl/editing/selection/mixed-editability-5-expected.txt:
* platform/efl/editing/selection/mixed-editability-8-expected.txt:
* platform/efl/editing/selection/mixed-editability-9-expected.txt:
* platform/efl/editing/selection/table-caret-1-expected.txt:
* platform/efl/editing/selection/table-caret-2-expected.txt:
* platform/efl/fast/table/035-vertical-expected.txt:
* platform/efl/fast/table/038-vertical-expected.txt:
* platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. GTK+ gardening: rebaseline more tests after r191623.
carlosgc@webkit.org [Thu, 29 Oct 2015 07:45:56 +0000 (07:45 +0000)]
Unreviewed. GTK+ gardening: rebaseline more tests after r191623.

* platform/gtk/editing/selection/inline-table-expected.txt:
* platform/gtk/editing/selection/move-by-line-001-expected.txt:
* platform/gtk/fast/borders/table-borders-expected.txt:
* platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10009-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10036-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10269-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10269-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10296-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10565-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10633-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug11321-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug11384q-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug11384s-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug11944-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12008-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12268-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12709-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12908-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug12910-2-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug13105-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug13169-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug13484-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug13526-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug14159-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug14323-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug14929-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug15247-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug15544-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug15933-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug16012-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug3977-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4284-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4385-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4427-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4501-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4520-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4523-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4576-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4739-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4803-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4849-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4849-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5538-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5797-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5798-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5799-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5835-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5838-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug6184-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug6304-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug6404-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug6674-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7112-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7112-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7121-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7471-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7714-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8032-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8361-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8381-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8858-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8950-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9072-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9123-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9123-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9271-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9879-1-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_0-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_1-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_2-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_3-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_cellspacing-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_default-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_height-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_width-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_height-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_width-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_width_percent-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_width_px-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/td_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Copied from LayoutTests/platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt.
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Copied from LayoutTests/platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt.
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModern IDB: Support IDBDatabase.transaction() (and transaction scheduling in general).
beidson@apple.com [Thu, 29 Oct 2015 06:16:01 +0000 (06:16 +0000)]
Modern IDB: Support IDBDatabase.transaction() (and transaction scheduling in general).
https://bugs.webkit.org/show_bug.cgi?id=150614

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* indexeddb/idbdatabase_transaction5-expected.txt: Progression!

Source/WebCore:

Tests: storage/indexeddb/modern/idbdatabase-transaction-failures.html
       storage/indexeddb/modern/transaction-scheduler-1.html
       storage/indexeddb/modern/transaction-scheduler-2.html
       storage/indexeddb/modern/transaction-scheduler-3.html
       storage/indexeddb/modern/transaction-scheduler-4.html
       storage/indexeddb/modern/transaction-scheduler-5.html
       storage/indexeddb/modern/transaction-scheduler-6.html

* Modules/indexeddb/IDBDatabase.idl:

* Modules/indexeddb/IndexedDB.h:

* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::establishTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didStartTransaction):
(WebCore::IDBClient::IDBConnectionToServer::hasRecordOfTransaction):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBConnectionToServerDelegate.h:

* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::transaction):
(WebCore::IDBClient::IDBDatabase::didStartTransaction):
* Modules/indexeddb/client/IDBDatabaseImpl.h:

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::operationTimerFired):
(WebCore::IDBClient::IDBTransaction::didStart):
(WebCore::IDBClient::IDBTransaction::establishOnServer):
(WebCore::IDBClient::IDBTransaction::activate):
(WebCore::IDBClient::IDBTransaction::deactivate):
* Modules/indexeddb/client/IDBTransactionImpl.h:

* Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didStartTransaction):
* Modules/indexeddb/server/IDBConnectionToClient.h:
* Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::establishTransaction):
* Modules/indexeddb/server/IDBServer.h:

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::removeObjectStoreForVersionChangeAbort):
(WebCore::IDBServer::MemoryIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::deleteRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::putRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::unregisterObjectStore):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::enqueueTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::transactionSchedulingTimerFired):
(WebCore::IDBServer::UniqueIDBDatabase::activateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::performActivateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformActivateTransactionInBackingStore):
(WebCore::IDBServer::scopesOverlap):
(WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted):
* Modules/indexeddb/server/UniqueIDBDatabase.h:

* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction):
* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:

* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::create):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::objectStoreIdentifiers):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::didActivateInBackingStore):
* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:

* Modules/indexeddb/shared/IDBTransactionInfo.cpp:
(WebCore::IDBTransactionInfo::clientTransaction):
(WebCore::IDBTransactionInfo::isolatedCopy):
* Modules/indexeddb/shared/IDBTransactionInfo.h:

* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::establishTransaction):
(WebCore::InProcessIDBServer::didStartTransaction):
* Modules/indexeddb/shared/InProcessIDBServer.h:

* bindings/js/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValueData):

* bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::transaction):

* bindings/js/ScriptState.cpp:
(WebCore::execStateFromPage):

LayoutTests:

* storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt: Added.
* storage/indexeddb/modern/idbdatabase-transaction-failures.html: Added.
* storage/indexeddb/modern/transaction-scheduler-1-expected.txt: Added.
* storage/indexeddb/modern/transaction-scheduler-1.html: Added.
* storage/indexeddb/modern/transaction-scheduler-2-expected.txt: Added.
* storage/indexeddb/modern/transaction-scheduler-2.html: Added.
* storage/indexeddb/modern/transaction-scheduler-3-expected.txt: Added.
* storage/indexeddb/modern/transaction-scheduler-3.html: Added.
* storage/indexeddb/modern/transaction-scheduler-4-expected.txt: Added.
* storage/indexeddb/modern/transaction-scheduler-4.html: Added.
* storage/indexeddb/modern/transaction-scheduler-5-expected.txt: Added.
* storage/indexeddb/modern/transaction-scheduler-5.html: Added.
* storage/indexeddb/modern/transaction-scheduler-6-expected.txt: Added.
* storage/indexeddb/modern/transaction-scheduler-6.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[MediaStream] Play MediaStream through media element and rendered to canvas
eric.carlson@apple.com [Thu, 29 Oct 2015 05:30:40 +0000 (05:30 +0000)]
[MediaStream] Play MediaStream through media element and rendered to canvas
https://bugs.webkit.org/show_bug.cgi?id=150449

Reviewed by Jer Noble.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create): Don't die a recursive death.
(WebCore::MediaStream::MediaStream): setClient -> addObserver. Set private stream's public stream pointer.
(WebCore::MediaStream::~MediaStream): setClient -> addObserver. Clear private stream's public stream pointer.
(WebCore::MediaStream::didAddTrack): Short circuit calling internalAddTrack when the track is unknown.
(WebCore::MediaStream::didRemoveTrack): ASSERT that the track is known.
* Modules/mediastream/MediaStream.h:

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::trackProducingDataChanged): New.
(WebCore::MediaStreamTrack::trackEnabledChanged): New.
* Modules/mediastream/MediaStreamTrack.h:

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Use the new MediaStreamPrivate::publicStream() method.

* Modules/webaudio/MediaStreamAudioSource.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRegression(r191673): [WIN][EFL][GTK] layout tests using data URLs time out
cdumez@apple.com [Thu, 29 Oct 2015 05:20:51 +0000 (05:20 +0000)]
Regression(r191673): [WIN][EFL][GTK] layout tests using data URLs time out
https://bugs.webkit.org/show_bug.cgi?id=150661

Reviewed by Gyuyoung Kim.

Do a partial revert of r191673. For some reason, using a Timer in
DataURLDecoder does not work (it does not fire). Since non COCOA ports
don't support RunLoopTimer, this patch reintroduces the use of
callOnMainThread() on non-COCOA ports.

* platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::decode):
(WebCore::DataURLDecoder::DecodingResultDispatcher::startTimer): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Rename InspectorResourceAgent to InspectorNetworkAgent
commit-queue@webkit.org [Thu, 29 Oct 2015 03:10:15 +0000 (03:10 +0000)]
Web Inspector: Rename InspectorResourceAgent to InspectorNetworkAgent
https://bugs.webkit.org/show_bug.cgi?id=150654

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-28
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* inspector/scripts/codegen/generator.py:

Source/WebCore:

* CMakeLists.txt:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorFrontendClient.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculationImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveDataImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
(WebCore::InspectorInstrumentation::didReceiveXHRResponseImpl):
(WebCore::InspectorInstrumentation::willLoadXHRSynchronouslyImpl):
(WebCore::InspectorInstrumentation::didLoadXHRSynchronouslyImpl):
(WebCore::InspectorInstrumentation::scriptImportedImpl):
(WebCore::InspectorInstrumentation::didReceiveScriptResponseImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameErrorImpl):
(WebCore::InspectorInstrumentation::didSendWebSocketFrameImpl):
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorNetworkAgent.cpp: Renamed from Source/WebCore/inspector/InspectorResourceAgent.cpp.
(WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
(WebCore::InspectorNetworkAgent::didCreateFrontendAndBackend):
(WebCore::InspectorNetworkAgent::willDestroyFrontendAndBackend):
(WebCore::buildObjectForHeaders):
(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::~InspectorNetworkAgent):
(WebCore::InspectorNetworkAgent::timestamp):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::markResourceAsCached):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::isErrorStatusCode):
(WebCore::InspectorNetworkAgent::didReceiveData):
(WebCore::InspectorNetworkAgent::didFinishLoading):
(WebCore::InspectorNetworkAgent::didFailLoading):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorNetworkAgent::setInitialScriptContent):
(WebCore::InspectorNetworkAgent::didReceiveScriptResponse):
(WebCore::InspectorNetworkAgent::didFinishXHRLoading):
(WebCore::InspectorNetworkAgent::didReceiveXHRResponse):
(WebCore::InspectorNetworkAgent::willLoadXHRSynchronously):
(WebCore::InspectorNetworkAgent::didLoadXHRSynchronously):
(WebCore::InspectorNetworkAgent::willDestroyCachedResource):
(WebCore::InspectorNetworkAgent::willRecalculateStyle):
(WebCore::InspectorNetworkAgent::didRecalculateStyle):
(WebCore::InspectorNetworkAgent::didScheduleStyleRecalculation):
(WebCore::InspectorNetworkAgent::buildInitiatorObject):
(WebCore::InspectorNetworkAgent::didCreateWebSocket):
(WebCore::InspectorNetworkAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorNetworkAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorNetworkAgent::didCloseWebSocket):
(WebCore::InspectorNetworkAgent::didReceiveWebSocketFrame):
(WebCore::InspectorNetworkAgent::didSendWebSocketFrame):
(WebCore::InspectorNetworkAgent::didReceiveWebSocketFrameError):
(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::disable):
(WebCore::InspectorNetworkAgent::setExtraHTTPHeaders):
(WebCore::InspectorNetworkAgent::getResponseBody):
(WebCore::InspectorNetworkAgent::setCacheDisabled):
(WebCore::InspectorNetworkAgent::loadResource):
(WebCore::InspectorNetworkAgent::mainFrameNavigated):
* inspector/InspectorNetworkAgent.h: Renamed from Source/WebCore/inspector/InspectorResourceAgent.h.
* inspector/InspectorPageAgent.h:
* inspector/InstrumentingAgents.cpp:
(WebCore::InstrumentingAgents::reset):
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorNetworkAgent):
(WebCore::InstrumentingAgents::setInspectorNetworkAgent):
(WebCore::InstrumentingAgents::inspectorResourceAgent): Deleted.
(WebCore::InstrumentingAgents::setInspectorResourceAgent): Deleted.
* inspector/NetworkResourcesData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoB3::reduceStrength() should do DCE
fpizlo@apple.com [Thu, 29 Oct 2015 01:57:17 +0000 (01:57 +0000)]
B3::reduceStrength() should do DCE
https://bugs.webkit.org/show_bug.cgi?id=150656

Reviewed by Saam Barati.

* b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::removeNops): This now deletes the values from the procedure, to preserve the invariant that valuesInProc == valuesInBlocks.
* b3/B3BasicBlock.h:
* b3/B3Procedure.cpp:
(JSC::B3::Procedure::deleteValue): Add a utility used by removeNops().
(JSC::B3::Procedure::addValueIndex): Make sure that we reuse Value indices so that m_values doesn't get too sparse.
* b3/B3Procedure.h:
(JSC::B3::Procedure::ValuesCollection::iterator::iterator): Teach this that m_values can be slightly sparse.
(JSC::B3::Procedure::ValuesCollection::iterator::operator++):
(JSC::B3::Procedure::ValuesCollection::iterator::operator!=):
(JSC::B3::Procedure::ValuesCollection::iterator::findNext):
(JSC::B3::Procedure::values):
* b3/B3ProcedureInlines.h:
(JSC::B3::Procedure::add): Use addValueIndex() instead of always creating a new index.
* b3/B3ReduceStrength.cpp: Implement the optimization using UseCounts and Effects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Remove unused / duplicate WebSocket timeline records
commit-queue@webkit.org [Thu, 29 Oct 2015 01:30:16 +0000 (01:30 +0000)]
Web Inspector: Remove unused / duplicate WebSocket timeline records
https://bugs.webkit.org/show_bug.cgi?id=150647

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-28
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* inspector/protocol/Timeline.json:

Source/WebCore:

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
Only send what is needed by inspector now.

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):
These can all fast return if there is no frontend because the inspector
doesn't record any information about web sockets until a frontend is connected.
The inspector in this case just sends events to the frontend when things happen.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
Stop messaging the Timeline agent, we already message the Resource agent.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateWebSocket): Deleted.
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest): Deleted.
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse): Deleted.
(WebCore::InspectorTimelineAgent::didDestroyWebSocket): Deleted.
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.h:
(WebCore::TimelineRecordFactory::createWebSocketCreateData): Deleted.
(WebCore::TimelineRecordFactory::createGenericWebSocketData): Deleted.
This is all duplicate information from the network domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoB3::LowerToAir should not duplicate Loads
fpizlo@apple.com [Thu, 29 Oct 2015 01:28:06 +0000 (01:28 +0000)]
B3::LowerToAir should not duplicate Loads
https://bugs.webkit.org/show_bug.cgi?id=150651

Reviewed by Benjamin Poulain.

The instruction selector may decide to fuse two Values into one. This ordinarily only happens
if we haven't already emitted code that uses the Value and the Value has only one direct
user. Once we have emitted such code, we ensure that everyone knows that we have "locked" the
Value: we won't emit any more code for it in the future.

The optimization to fuse Loads was forgetting to do all of these things, and so generated
code would have a lot of duplicated Loads. That's bad and this change fixes that.

Ordinarily, this is far less tricky because the pattern matcher does this for us via
acceptInternals() and acceptInternalsLate(). I added a comment to this effect. I hope that we
won't need to do this manually very often.

Also found an uninitialized value bug in UseCounts. That was making all of this super hard to
debug.

* b3/B3IndexMap.h:
(JSC::B3::IndexMap::IndexMap):
(JSC::B3::IndexMap::resize):
(JSC::B3::IndexMap::operator[]):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::canBeInternal):
(JSC::B3::Air::LowerToAir::commitInternal):
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::loadAddr):
(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::acceptInternals):
* b3/B3UseCounts.cpp:
(JSC::B3::UseCounts::UseCounts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Add "revert" to CSS value autocompletion
commit-queue@webkit.org [Thu, 29 Oct 2015 01:24:33 +0000 (01:24 +0000)]
Web Inspector: Add "revert" to CSS value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=150652

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-28
Reviewed by Timothy Hatcher.

* UserInterface/Models/CSSCompletions.js:
* UserInterface/Models/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
(WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
Treat "revert" like initial and unset. It is valid on all properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r191071): Web Inspector: Can't resize split console when the window is...
nvasilyev@apple.com [Thu, 29 Oct 2015 01:20:49 +0000 (01:20 +0000)]
REGRESSION(r191071): Web Inspector: Can't resize split console when the window is too narrow
https://bugs.webkit.org/show_bug.cgi?id=150492

Reviewed by Timothy Hatcher.

Make some items inside of the navigation bar click-through to incsease the draggable area.

* UserInterface/Views/Main.css:
(#split-content-browser > .navigation-bar > :matches(.hierarchical-path, .log-scope-bar)):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJITSubGenerator::generateFastPath() does not need to be inlined.
mark.lam@apple.com [Thu, 29 Oct 2015 01:18:49 +0000 (01:18 +0000)]
JITSubGenerator::generateFastPath() does not need to be inlined.
https://bugs.webkit.org/show_bug.cgi?id=150645

Reviewed by Geoffrey Garen.

Moving it to a .cpp file to reduce code size.  Benchmarks shows this to be
perf neutral.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* ftl/FTLCompile.cpp:
* jit/JITSubGenerator.cpp: Added.
(JSC::JITSubGenerator::generateFastPath):
* jit/JITSubGenerator.h:
(JSC::JITSubGenerator::JITSubGenerator):
(JSC::JITSubGenerator::endJumpList):
(JSC::JITSubGenerator::slowPathJumpList):
(JSC::JITSubGenerator::generateFastPath): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[B3] handleCommutativity should canonicalize commutative operations over non-constants
fpizlo@apple.com [Thu, 29 Oct 2015 00:46:06 +0000 (00:46 +0000)]
[B3] handleCommutativity should canonicalize commutative operations over non-constants
https://bugs.webkit.org/show_bug.cgi?id=150649

Reviewed by Saam Barati.

Turn this: Add(value1, value2)
Into this: Add(value2, value1)

But ony if value2 should come before value1 according to our total ordering. This will allow
CSE to observe the equality between commuted versions of the same operation, since we will
first canonicalize them into the same order.

* b3/B3ReduceStrength.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191712 268f45cc-cd09-0410-ab3c-d52691b4dbfc