pewtermoose [Mon, 16 Jul 2007 22:22:27 +0000 (22:22 +0000)]
2007-07-16 Charles Gaudette <charles@gaudette-net.com>
Reviewed by Niko.
- http://bugs.webkit.org/show_bug.cgi?id=14628
broken link on webkit.org home page - "KHTML" points to http://khtml.info/
* index.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 16 Jul 2007 22:09:05 +0000 (22:09 +0000)]
Added a manual test to test calling window.print on a subframe.
Reviewed by Darin.
* manual-tests/resources/print-subframe.html: Added.
* manual-tests/window-print-subframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 16 Jul 2007 22:01:35 +0000 (22:01 +0000)]
WebKit/win part of <rdar://problem/
5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
WebKit/win:
WebKit/win part of <rdar://problem/
5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
Reviewed by Darin.
* Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer
match the Mac method, and copy more of the Mac API comments.
* WebChromeClient.cpp:
(WebChromeClient::print): Call printFrame instead of print.
WebCore:
Added a manual test to test calling window.print on a subframe.
Reviewed by Darin.
* manual-tests/resources/print-subframe.html: Added.
* manual-tests/window-print-subframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 16 Jul 2007 22:01:23 +0000 (22:01 +0000)]
Replace Frame::print with Chrome::print and remove -[WebFrameBridge print]
WebCore:
Replace Frame::print with Chrome::print
This also adds a Frame* parameter to Chrome::print and
ChromeClient::print so that it knows which Frame to print.
Reviewed by Darin.
All tests pass.
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction): Call Chrome::print.
* editing/JSEditor.cpp: Ditto.
* bridge/win/FrameWin.cpp: Removed Frame::print.
* page/Frame.h: Ditto.
* page/mac/FrameMac.mm: Ditto.
* page/qt/FrameQt.cpp: Ditto.
* platform/gdk/FrameGdk.cpp: Ditto.
* page/mac/WebCoreFrameBridge.h: Removed -print.
* page/Chrome.cpp: Added Frame* parameter to Chrome::print and pass it
up to the ChromeClient.
* page/Chrome.h: Ditto.
* page/ChromeClient.h: Ditto.
* platform/gdk/TemporaryLinkStubs.cpp: Ditto.
* platform/graphics/svg/SVGImageEmptyClients.h: Ditto.
WebKit:
Move printing from WebFrameBridge to WebChromeClient
Reviewed by Darin.
* WebCoreSupport/WebChromeClient.h: Updated for ChromeClient changes.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::print): Moved code from WebFrameBridge.
* WebCoreSupport/WebFrameBridge.mm: Removed -print.
WebKit/win:
Updated WebChromeClient for ChromeClient changes.
Reviewed by Darin.
* WebChromeClient.cpp:
(WebChromeClient::print): Added a Frame* parameter.
* WebChromeClient.h: Ditto.
WebKitQt:
Updated ChromeClientQt for ChromeClient changes.
Reviewed by Darin.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::print): Added a Frame* parameter.
* WebCoreSupport/ChromeClientQt.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 16 Jul 2007 21:59:35 +0000 (21:59 +0000)]
Reviewed by Sam.
- Modified files to use cross-platform code.
* Drosera/DebuggerDocument.cpp: Added.
(DebuggerDocument::breakpointEditorHTML):
(DebuggerDocument::isPaused):
(DebuggerDocument::pause):
(DebuggerDocument::resume):
(DebuggerDocument::stepInto):
(DebuggerDocument::evaluateScript):
(DebuggerDocument::currentFunctionStack):
(DebuggerDocument::localScopeVariableNamesForCallFrame):
(DebuggerDocument::valueForScopeVariableNamed):
* Drosera/DebuggerDocument.h: Added.
(DebuggerDocument::DebuggerDocument):
* Drosera/config.h: Added.
* Drosera/mac/DebuggerApplication.mm:
(-[DebuggerApplication attach:]):
* Drosera/mac/DebuggerDocument.h: Removed.
* Drosera/mac/DebuggerDocument.mm: Removed.
* Drosera/mac/DebuggerDocumentMac.h: Copied from Drosera/mac/DebuggerDocument.h.
* Drosera/mac/DebuggerDocumentMac.mm: Copied from Drosera/mac/DebuggerDocument.mm.
(-[DebuggerDocumentMac initWithServerName:]):
(-[DebuggerDocumentMac dealloc]):
(-[DebuggerDocumentMac breakpointEditorHTML]):
(-[DebuggerDocumentMac isPaused]):
(-[DebuggerDocumentMac pause]):
(-[DebuggerDocumentMac resume]):
* Drosera/mac/Drosera.xcodeproj/project.pbxproj:
* Drosera/win/DebuggerApplication.cpp:
* Drosera/win/DebuggerObjectCallbacks.cpp:
(breakpointEditorHTMLCallback):
(currentFunctionStackCallback):
(evaluateScript_inCallFrame_Callback):
(isPausedCallback):
(localScopeVariableNamesForCallFrame_Callback):
(pauseCallback):
(resumeCallback):
(stepIntoCallback):
(valueForScopeVariableNamed_inCallFrame_Callback):
(staticFunctions):
* Drosera/win/Drosera.cpp:
* Drosera/win/DroseraPrefix.cpp: Added.
* Drosera/win/DroseraPrefix.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 16 Jul 2007 21:55:53 +0000 (21:55 +0000)]
* StringsNotToBeLocalized.txt: Update for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Mon, 16 Jul 2007 21:46:58 +0000 (21:46 +0000)]
LayoutTests:
Reviewed by Brady.
Test for <rdar://problem/
5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element
http://bugs.webkit.org/show_bug.cgi?id=14565
* fast/forms/hidden-input-file-expected.checksum: Added.
* fast/forms/hidden-input-file-expected.png: Added.
* fast/forms/hidden-input-file-expected.txt: Added.
* fast/forms/hidden-input-file.html: Added.
* fast/forms/hidden-listbox-expected.checksum
* fast/forms/hidden-listbox-expected.png
* fast/forms/hidden-listbox-expected.txt
* fast/forms/hidden-listbox.html
WebCore:
Reviewed by Brady.
Fix for <rdar://problem/
5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element and listbox
http://bugs.webkit.org/show_bug.cgi?id=14565
Tests:
fast/forms/hidden-input-file.html
fast/forms/hidden-listbox.html
* rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
Only paint if the control is supposed to be visible.
* rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
ditto. We already had checks to prevent drawing the text that considered the option's style too, but if visibility: hidden
was just set on the listbox then a lot of extra work was being done, and the scrollbar was drawing too. This change fixes that.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 16 Jul 2007 21:42:58 +0000 (21:42 +0000)]
Reviewed by Steve.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14630
Remove bogus assertion
* WebView.cpp:
(WebView::getIMMContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 16 Jul 2007 21:34:08 +0000 (21:34 +0000)]
Reviewed by Darin.
Add all the window's functions to cross-frame-access-put.html test.
* http/tests/security/cross-frame-access-put-expected.txt:
* http/tests/security/cross-frame-access-put.html:
* http/tests/security/resources/cross-frame-iframe-for-put-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 16 Jul 2007 21:02:02 +0000 (21:02 +0000)]
Fix for Radar
5338081, text-shadow should be reset on form controls so that
it doesn't inherit in when set e.g., on the <body>.
Reviewed by beth
* css/html4.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat [Mon, 16 Jul 2007 20:51:06 +0000 (20:51 +0000)]
skip these crashing tests
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke [Mon, 16 Jul 2007 20:39:03 +0000 (20:39 +0000)]
2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Niko.
FrameView, PlatformScrollbar and changes to the way we draw
Fix the lifetime of PlatformScrollbar, use a default width and
height and fix drawing of the PlatformScrollbar and other widgets
the following way: FrameGdk handles the expose events of the Frame
and will make the frame redraw and now it will draw the childrent of
the FrameView as well. This approach has the issue of honoring the
z-order of elements inside the RenderTree. Honoring the z-order will
be a bit more work
Widget can now handle Widget::setGtkWidget call where the GtkWidget
has not yet a GdkWindow allocated. We will lazily set the GdkDrawable.
In preparation of honoring the z-order of the RenderTree for RenderWidgets
it is started to store native objects inside the GraphicsContext. Doing this
nicely eliminates the need of RenderThemeGdk to do any drawing to a temporary
GdkPixmap. This should fix themes with rounded buttons.
ScrollView implement add- and removeChild to get a working PlatformScrollbar
* platform/Widget.h:
* platform/gdk/FrameGdk.cpp:
(frame_gdk_expose_child): Will send the expose to all children
(WebCore::FrameGdk::handleGdkEvent): Painting changes, move to mouseMoved
* platform/gdk/PlatformScreenGdk.cpp:
(WebCore::screenDepth): gdkDrawable
* platform/gdk/PlatformScrollBarGdk.cpp:
(PlatformScrollbar::PlatformScrollbar): Fix ownership
(PlatformScrollbar::~PlatformScrollbar): Fix ownership
(PlatformScrollbar::paint): Widget::paint will do the right thing soon
* platform/gdk/RenderThemeGdk.cpp: No need for using a GdkPixmap, draw directly
(WebCore::RenderThemeGdk::paintCheckbox): No need for using a GdkPixmap, draw directly
(WebCore::RenderThemeGdk::paintRadio): No need for using a GdkPixmap, draw directly
(WebCore::RenderThemeGdk::paintButton): No need for using a GdkPixmap, draw directly
* platform/gdk/RenderThemeGdk.h: remove the copyContext call
* platform/gdk/ScrollViewGdk.cpp: gdkDrawable
(WebCore::ScrollView::updateView): gdkDrawable
(WebCore::ScrollView::update): clear the area to fix repainting issues
(WebCore::ScrollView::setGtkWidget): gdkDrawable
(WebCore::ScrollView::addChild): implement
(WebCore::ScrollView::removeChild): implement
* platform/gdk/TemporaryLinkStubs.cpp: Not needed header removed
* platform/gdk/WidgetGdk.cpp:
(WebCore::Widget::gdkDrawable): Renamed from drawable
(WebCore::Widget::setGtkWidget): use gdkDrawable
(WebCore::Widget::setCursor): gdkDrawable
(WebCore::Widget::show): gdkDrawable
(WebCore::Widget::hide): gdkDrawable
* platform/graphics/GraphicsContext.h: Allow to set the GdkDrawable, e.g. used inside a expose event
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::setGdkDrawable):
(WebCore::GraphicsContext::gdkDrawable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke [Mon, 16 Jul 2007 20:21:22 +0000 (20:21 +0000)]
2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej.
Lazily update the scrollbars (e.g. on loading a page) to
generate less expose events, which will lead to laying out less often
and will fix http://bugs.webkit.org/show_bug.cgi?id=14020.
* platform/gdk/ScrollViewGdk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::update):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::updateScrollbars):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 16 Jul 2007 18:09:35 +0000 (18:09 +0000)]
Reviewed by Adam, Sam and Tim.
- Moving files to prepare for cross-platform architecture.
* Drosera/DebuggerApplication.h: Removed.
* Drosera/DebuggerApplication.m: Removed.
* Drosera/DebuggerDocument.h: Removed.
* Drosera/DebuggerDocument.m: Removed.
* Drosera/Drosera.pch: Removed.
* Drosera/Drosera.xcodeproj: Removed.
* Drosera/Drosera.xcodeproj/project.pbxproj: Removed.
* Drosera/Info.plist: Removed.
* Drosera/LauncherInfo.plist: Removed.
* Drosera/Makefile: Removed.
* Drosera/launcher.m: Removed.
* Drosera/mac: Added.
* Drosera/mac/DebuggerApplication.h: Copied from Drosera/DebuggerApplication.h.
* Drosera/mac/DebuggerApplication.mm: Copied from Drosera/DebuggerApplication.m.
* Drosera/mac/DebuggerDocument.h: Copied from Drosera/DebuggerDocument.h.
* Drosera/mac/DebuggerDocument.mm: Copied from Drosera/DebuggerDocument.m.
* Drosera/mac/Drosera.pch: Copied from Drosera/Drosera.pch.
* Drosera/mac/Drosera.xcodeproj: Copied from Drosera/Drosera.xcodeproj.
* Drosera/mac/Drosera.xcodeproj/project.pbxproj:
* Drosera/mac/Info.plist: Copied from Drosera/Info.plist.
* Drosera/mac/LauncherInfo.plist: Copied from Drosera/LauncherInfo.plist.
* Drosera/mac/Makefile: Copied from Drosera/Makefile.
* Drosera/mac/launcher.m: Copied from Drosera/launcher.m.
* Drosera/mac/main.m: Copied from Drosera/main.m.
* Drosera/main.m: Removed.
* Makefile:
* Makefile.Drosera: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 16 Jul 2007 17:53:01 +0000 (17:53 +0000)]
Reviewed by Kevin Decker and Darin Adler
- fixed <rdar://problem/
5337529> Holes in Find banner overlay on PDF pages are left in wrong place after changing scale
* WebView/WebPDFView.mm:
(-[WebPDFView _scaleOrDisplayModeChanged:]):
tell UI delegate that the entire PDF view has been redrawn
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 16 Jul 2007 17:05:34 +0000 (17:05 +0000)]
Reviewed by Kevin McCullough.
Breakup http/tests/security/cross-frame-access.html into multiple tests to
make it easier to identify flaws should they arise.
- Also factors out JS into a separate file.
* http/tests/security/cross-frame-access-custom-expected.txt: Added.
* http/tests/security/cross-frame-access-custom.html: Added.
* http/tests/security/cross-frame-access-expected.txt:
* http/tests/security/cross-frame-access-frames-expected.txt: Added.
* http/tests/security/cross-frame-access-frames.html: Added.
* http/tests/security/cross-frame-access-history-expected.txt: Added.
* http/tests/security/cross-frame-access-history.html: Added.
* http/tests/security/cross-frame-access-location-expected.txt: Added.
* http/tests/security/cross-frame-access-location.html: Added.
* http/tests/security/cross-frame-access-name-getter-expected.txt: Added.
* http/tests/security/cross-frame-access-name-getter.html: Added.
* http/tests/security/cross-frame-access.html:
* http/tests/security/resources/cross-frame-access.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 16 Jul 2007 15:20:47 +0000 (15:20 +0000)]
Forgot Skipped file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 16 Jul 2007 15:18:35 +0000 (15:18 +0000)]
Remove basic-auth.html, it no longer hangs on Leopard.
* mac/leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 16 Jul 2007 09:06:29 +0000 (09:06 +0000)]
2007-07-16 Mark Rowe <mrowe@apple.com>
Update expected result after r24302.
* fast/css/empty-script-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 16 Jul 2007 08:38:41 +0000 (08:38 +0000)]
2007-07-16 Rob Buis <buis@kde.org>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14462
non empty <style> element doesn't work
Return an empty sheet for empty <style> elements
instead of a null sheet. Clean up StyleElement a bit.
* dom/StyleElement.cpp:
(WebCore::StyleElement::StyleElement):
(WebCore::StyleElement::sheet):
(WebCore::StyleElement::childrenChanged):
(WebCore::StyleElement::createSheet):
* dom/StyleElement.h:
(WebCore::StyleElement::setLoading):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::sheet):
* html/HTMLStyleElement.h:
(WebCore::HTMLStyleElement::setLoading):
* ksvg2/svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::sheet):
(WebCore::SVGStyleElement::sheetLoaded):
* ksvg2/svg/SVGStyleElement.h:
2007-07-16 Rob Buis <buis@kde.org>
Reviewed by Maciej.
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=14462
non empty <style> element doesn't work
* fast/css/empty-script-expected.txt: Added.
* fast/css/empty-script.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 16 Jul 2007 06:13:32 +0000 (06:13 +0000)]
LayoutTests:
Reviewed by Adam.
Update for changed behaviour now that we allow tab characters in input fields again
* editing/inserting/typing-tab-designmode-forms-expected.checksum:
* editing/inserting/typing-tab-designmode-forms-expected.png:
* editing/inserting/typing-tab-designmode-forms-expected.txt:
WebCore:
Reviewed by Adam.
Fix for fix for <rdar://problem/
5336602> REGRESSION: tab characters
cannot be entered into text fields
http://bugs.webkit.org/show_bug.cgi?id=14032
Need to use UChar not char.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::constrainValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 16 Jul 2007 02:09:02 +0000 (02:09 +0000)]
LayoutTests:
Reviewed by Geoff Garen.
Update results after removing redundant calls to isSafeScript()
* http/tests/security/cross-frame-access-expected.txt:
WebCore:
Reviewed by Geoff Garen.
Remove redundant calls to isSafeScript()
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customPut):
* bindings/js/kjs_window.cpp:
(KJS::Window::put):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 16 Jul 2007 01:44:46 +0000 (01:44 +0000)]
Reviewed by Maciej Stachowiak.
Removed incorrect error log, seen while running layout tests.
Perhaps at some point FrameLoadTypeInteral had a specific meaning
that prevented it from being used in non-child frame, non-redirect
situations. However, that meaning has been lost and nobody remembers
how to get it back.
We currently use FrameLoadTypeInternal for any load that is not
initiated by a user gesture, so it's trivial to produce this error
log, even though nothing has gone wrong.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::updateHistoryForInternalLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 16 Jul 2007 01:36:49 +0000 (01:36 +0000)]
LayoutTests:
Reviewed by Maciej.
Testcase for <rdar://problem/
5336602> REGRESSION: tab characters cannot be entered into text fields
http://bugs.webkit.org/show_bug.cgi?id=14032
* fast/forms/tab-in-input-expected.txt: Added.
* fast/forms/tab-in-input.html: Added.
WebCore:
Reviewed by Maciej
Fix for <rdar://problem/
5336602> REGRESSION: tab characters cannot be entered into text fields
http://bugs.webkit.org/show_bug.cgi?id=14032
constrainValue attempted to block control characters from being inserted
by a simple less than ' ' check, which prevent tab characters from being
inserted. This patch adds an additional check to allow the tab character
again
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::constrainValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 14 Jul 2007 23:39:03 +0000 (23:39 +0000)]
Third shot at blind Qt/GDK build fix
* platform/gdk/TemporaryLinkStubs.cpp:
(FTPDirectoryDocument::createTokenizer):
* platform/qt/TemporaryLinkStubs.cpp:
(FTPDirectoryDocument::createTokenizer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 14 Jul 2007 23:25:13 +0000 (23:25 +0000)]
RUBBERSTAMPED BY SAM WEINIG - Try to (actually) fix Qt and GDK
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 14 Jul 2007 23:21:36 +0000 (23:21 +0000)]
Fix Windows build and set the pref to allow FTP directory listings in Windows nightlies
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 14 Jul 2007 22:59:57 +0000 (22:59 +0000)]
Fix Tiger build.
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 14 Jul 2007 22:58:42 +0000 (22:58 +0000)]
Blind attempt at (hopefully) fixing the Qt and GDK builds
* platform/gdk/TemporaryLinkStubs.cpp:
(FTPDirectoryDocument::FTPDirectoryDocument):
* platform/qt/TemporaryLinkStubs.cpp:
(FTPDirectoryDocument::FTPDirectoryDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 14 Jul 2007 22:25:31 +0000 (22:25 +0000)]
JavaScriptCore:
Reviewed by Sam Weinig
Initial check-in for <rdar://problem/
3154486> - Supporting FTP directory listings in the browser
* wtf/Platform.h: Add ENABLE_FTPDIR feature to handle building on platforms that don't have the
proper network-layer support
WebCore:
Reviewed by Sam Weinig
Initial check-in for <rdar://problem/
3154486> - Supporting FTP directory listings in the browser
Development has taken place on both Leopard and Windows (windows enabling patch will follow shortly)
Support will only exist on platforms whose network layers (ie, ResourceHandle) support piping the raw
FTP Directory data into the engine.
This is known to include Leopard, Windows, and CURL based platforms - probably others
Known incompatible platforms include Tiger.
The FTP listing page is built in HTML. An external HTML document can be provided as a template for the
directory listing. This document is parsed, and expected to have a <table> with a certain class in it.
As FTP directory listings come in, each entry is added to this table as a row.
If no HTML template is provided to work with, a very basic empty document is hard coded that contains only
this special table.
Upgrades to the look and feel of the directory listings can take place largely in this HTML template which,
admittedly, is conspicuously absent in this initial checkin
* WebCore.exp: New Settings symbols for WebKit
* WebCore.xcodeproj/project.pbxproj:
* config.h: If BUILDING_ON_TIGER, disable FTP directory listing support
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument): Create an FTPDirectoryDocument if the mime type is
"application/x-ftp-directory"
* loader/FTPDirectoryDocument.cpp: Added.
(WebCore::FTPDirectoryTokenizer::isWaitingForScripts):
(WebCore::FTPDirectoryTokenizer::checkBuffer):
(WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): Building on HTML tokenizer, this facilitates
parsing FTP Directory listings in the engine
(WebCore::FTPDirectoryTokenizer::appendEntry): Add a table row for a directory listing to the document
(WebCore::FTPDirectoryTokenizer::createTDForFilename): Create the TD for the filename with the anchor in it
(WebCore::processFilesizeString): Prettify the filesize
(WebCore::wasLastDayOfMonth):
(WebCore::processFileDateString): Prettify the date
(WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine):
(WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): Loads the HTML template that FTP directory listings
can build on top of
(WebCore::FTPDirectoryTokenizer::createBasicDocument): Creates a most basic document (body and one table) to
append the rows to in case the document template is not loaded and parsed
(WebCore::FTPDirectoryTokenizer::write): Add the FTP listing to the buffer and parse entries out of it
(WebCore::FTPDirectoryTokenizer::finish):
(WebCore::FTPDirectoryDocument::FTPDirectoryDocument): Special document-type for FTP directory listings
(WebCore::FTPDirectoryDocument::createTokenizer):
* loader/FTPDirectoryDocument.h: Added.
(WebCore::FTPDirectoryDocument::isImageDocument):
* loader/FTPDirectoryParser.cpp: Added.
(WebCore::parseOneFTPLine): Adapted from ParseFTPList.cpp from Firefox - parses most known
FTP directory listing styles into discrete FTP directory entries
* loader/FTPDirectoryParser.h: Added.
(WebCore::ListState::ListState): Maintains FTP Parser state
(WebCore::ListResult::ListResult): Represents one FTP directory listing
(WebCore::ListResult::clear):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkContentPolicy): If the Settings say to bypass the policy check for
"application/x-ftp-directory", skip it. This will allow people to test this feature even if their
browser/WebKit app would otherwise not allow it
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFTPDirectoryTemplatePath): Set the path to the FTP listing document template
(WebCore::Settings::setForceFTPDirectoryListings): Set to bypass the policy delegate check for mime type
"application/x-ftp-directory"
* page/Settings.h:
(WebCore::Settings::ftpDirectoryTemplatePath):
(WebCore::Settings::forceFTPDirectoryListings):
* platform/Logging.cpp: Add an "LogFTP" logging channel
* platform/Logging.h:
* platform/mac/LoggingMac.mm:
(WebCore::InitializeLoggingChannelsIfNecessary):
* platform/MimeTypeRegistry.cpp:
(WebCore::initialiseSupportedNonImageMimeTypes): Add "application/x-ftp-directory"
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile): Stub for now
* platform/SharedBuffer.h:
* platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createWithContentsOfFile): Load contents of the file into an NSData, then
wrap that NSData
WebKit:
Reviewed by Sam Weinig
Initial check-in for <rdar://problem/
3154486> - Supporting FTP directory listings in the browser
* WebView/WebPreferenceKeysPrivate.h: Added preference keys for the FTP template location, as well as to force
FTP directory listings, bypassing the policy delegate. This is necessary to test the new feature until browser
policy delegate support is added.
* WebView/WebPreferences.m:
(-[WebPreferences _setFTPDirectoryTemplatePath:]):
(-[WebPreferences _ftpDirectoryTemplatePath]):
(-[WebPreferences _setForceFTPDirectoryListings:]):
(-[WebPreferences _forceFTPDirectoryListings]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _updateWebCoreSettingsFromPreferences:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 14 Jul 2007 18:02:26 +0000 (18:02 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14618
REGRESSION(13464): drivehq.com login form doesn't work
Test: http/tests/misc/post-submit-button.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::appendFormData): Append a submit even if its value is empty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 14 Jul 2007 17:04:03 +0000 (17:04 +0000)]
2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Fixes http://bugs.webkit.org/show_bug.cgi?id=13517,
http://bugs.webkit.org/show_bug.cgi?id=14237, and
the failure of test js1_5/Scope/regress-185485.js
Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope
* kjs/nodes.cpp:
(VarDeclNode::evaluate):
* tests/mozilla/expected.html:
2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Added tests for the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=13517
http://bugs.webkit.org/show_bug.cgi?id=14237
Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope
* fast/js/resources/vardecl-blocks-init.js: Added.
* fast/js/resources/vardecl-preserve-arguments.js: Updated.
* fast/js/vardecl-blocks-init-expected.txt: Added.
* fast/js/vardecl-blocks-init.html: Added.
* fast/js/vardecl-preserve-arguments-expected.txt: Updated result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 14 Jul 2007 16:53:14 +0000 (16:53 +0000)]
2007-07-15 Mark Rowe <mrowe@apple.com>
* Scripts/generate-coverage-data: Don't fail if WebKitBuild directory does not exist.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 14 Jul 2007 08:21:24 +0000 (08:21 +0000)]
Reviewed by Darin and Alexey.
Fix for <rdar://problem/
5231528> Inline input of International text (IME)
http://bugs.webkit.org/show_bug.cgi?id=14331
This patch adds IME support to WebKit/win, it currently does not support
reconversion (<rdar://problem/
5334818>) and has issues with the chinese
IMEs (<rdar://problem/
5334826>)
* WebEditorClient.cpp:
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::handleInputMethodKeypress):
Prevent the initial keydown for an IME from triggering a keypressed event
* WebView.cpp:
(WebView::WebView):
(WebView::keyUp):
(WebView::keyDown):
(WebViewWndProc):
(IMMDict::dict):
(IMMDict::IMMDict):
Dynamic loader for IME libraries
(WebView::getIMMContext):
(WebView::releaseIMMContext):
(WebView::prepareCandidateWindow):
(selectionInsideMarkedText):
(setSelectionToEndOfRange):
(WebView::resetIME):
(WebView::updateSelectionForIME):
(WebView::selectionChanged):
(getCompositionString):
(compositionToUnderlines):
Helper functions
(WebView::onIMEStartComposition):
(WebView::onIMEComposition):
(WebView::onIMEEndComposition):
(WebView::onIMEChar):
(WebView::onIMENotify):
(WebView::onIMERequest):
(WebView::onIMESelect):
(WebView::onIMESetContext):
IME event handling, so far most of these are not implemented, but the bulk of functionality
is performed the the composition event handlers
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 14 Jul 2007 06:40:32 +0000 (06:40 +0000)]
Reviewed by Mark.
Correct expected pixel results
* fast/forms/input-appearance-readonly-expected.checksum:
* fast/forms/input-appearance-readonly-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 14 Jul 2007 06:03:39 +0000 (06:03 +0000)]
Reviewed by Sam.
Fix for
<rdar://problem/
5335265> REGRESSION: WebCore::DragController crashes if WebDragSourceActionDHTML cleared
http://bugs.webkit.org/show_bug.cgi?id=13652
Reorder logic for drag initiation: we can always preflight the clipboard, regardless as to whether
we are performing any dhtml drag handling
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Sat, 14 Jul 2007 04:51:17 +0000 (04:51 +0000)]
Reviewed by Tim Hatcher.
Bug 14401: Semi-regression: Can no longer copy anything from the inspector
http://bugs.webkit.org/show_bug.cgi?id=14401
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 14 Jul 2007 01:49:06 +0000 (01:49 +0000)]
Reviewed by Maciej.
<rdar://problem/
5290103> Assert failure when loading page with multipart resource
Don't try to call the delegate method if the resource object doesn't exist in the
identifier map. When a multipart resource has finished loading one part, it is removed from the
web view identifier map.
This is not an ideal fix, a better fix would be to special-case multipart resources and not remove
them when the first part has finished loading. I've filed <rdar://problem/
5335034> to track doing that.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
(WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebFrameLoaderClient::willCacheResponse):
(WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebFrameLoaderClient::dispatchDidFinishLoading):
(WebFrameLoaderClient::dispatchDidFailLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 14 Jul 2007 00:20:57 +0000 (00:20 +0000)]
Fix results.
* fast/text/word-break-run-rounding-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 13 Jul 2007 23:07:15 +0000 (23:07 +0000)]
Reviewed by Hyatt.
Fix for <rdar://problem/
5304742> A hang occurs when attempting to
display web clip banner at http://www.signonsandiego.com/sports/
chargers/index.html
Here is the actual fix.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects): Set topLevel to
false when we recurse to get our children's absoluteRects.
* rendering/RenderInline.h: New boolean parameter
topLevel that defaults to true.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteRects):
* rendering/RenderObject.h:
And these are just other implementations/declarations of this
(virtual) function that have to add the parameter. No behavior
change here.
* rendering/RenderPath.cpp:
(WebCore::RenderPath::absoluteRects):
* rendering/RenderPath.h:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::absoluteRects):
* rendering/RenderSVGContainer.h:
* rendering/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::absoluteRects):
* rendering/RenderSVGHiddenContainer.h:
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::absoluteRects):
* rendering/RenderSVGImage.h:
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::absoluteRects):
* rendering/RenderSVGInlineText.h:
* rendering/RenderSVGTSpan.cpp:
(WebCore::RenderSVGTSpan::absoluteRects):
* rendering/RenderSVGTSpan.h:
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::absoluteRects):
* rendering/RenderSVGText.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
* rendering/RenderText.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::absoluteRects):
* rendering/RenderView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 13 Jul 2007 22:45:11 +0000 (22:45 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=13438 <rdar://problem/
5153030>
Run rounding makes word-break:break-all/word not functional
* fast/text/word-break-run-rounding-expected.checksum: Added.
* fast/text/word-break-run-rounding-expected.png: Added.
* fast/text/word-break-run-rounding-expected.txt: Added.
* fast/text/word-break-run-rounding.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13438 <rdar://problem/
5153030>
Run rounding makes word-break:break-all/word not functional
Test: fast/text/word-break-run-rounding.html
* rendering/RenderText.cpp:
(WebCore::RenderText::calcPrefWidths): Update the maximum width only on word
boundaries to avoid rounding errors.
* rendering/bidi.cpp:
(WebCore::RenderBlock::findNextLineBreak): Integrated breakAll with the
midWordBreak/wrapW mechanism. Also made the wrapW upper bound more accurate
by resetting it when tmpW is committed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 13 Jul 2007 22:37:38 +0000 (22:37 +0000)]
LayoutTests:
Reviewed by Geoff Garen.
Tests for <rdar://problem/
5318394>
http site can read/write content of https site in same domain
Adds ssl configuration information and tests.
* http/conf/apache2-httpd.conf:
* http/conf/cygwin-httpd.conf:
* http/conf/httpd.conf:
* http/conf/webkit-httpd.pem: Added.
* http/tests/security/cross-frame-access-expected.txt:
* http/tests/security/cross-frame-access-first-time-expected.txt:
* http/tests/security/cross-frame-access-protocol-expected.txt: Added.
* http/tests/security/cross-frame-access-protocol.html: Added.
* http/tests/security/cross-frame-access-put-expected.txt:
* http/tests/ssl: Added.
* http/tests/ssl/resources: Added.
* http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Added.
* http/tests/ssl/verify-ssl-enabled-expected.txt: Added.
* http/tests/ssl/verify-ssl-enabled.php: Added.
WebCore:
Reviewed by Geoff Garen.
Patch for <rdar://problem/
5318394>
http site can read/write content of https site in same domain
Add protocol and port checks in isSafeScript.
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
WebKitTools:
Reviewed by Geoff Garen.
Add support for running SSL tests over HTTPS.
* DumpRenderTree/DumpRenderTree.m:
(runTest):
* DumpRenderTree/FrameLoadDelegate.m:
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 13 Jul 2007 22:20:13 +0000 (22:20 +0000)]
Reviewed by Mitz Pettel.
<rdar://problem/
5298870>
REGRESSION: In Yahoo Mail modal dialog, OK and Cancel buttons do not work, and descriptive text is missing (14327)
http://bugs.webkit.org/show_bug.cgi?id=14327
REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog
When creating popup windows/dialogs, prevent the window properties from being cleared by the initial frame load.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::open):
* loader/FrameLoader.h:
(WebCore::FrameLoader::setShouldClearWindowProperties):
* manual-tests/modal-dialog-arguments.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 13 Jul 2007 21:45:04 +0000 (21:45 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5333766> Can't include WebEditingDelegatePrivate.h
* WebView/WebEditingDelegatePrivate.h: Changed the include to be a framework include,
so other projects can use this header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 13 Jul 2007 21:29:14 +0000 (21:29 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 13 Jul 2007 20:17:16 +0000 (20:17 +0000)]
Update ResourceError related code to account for changes in CF interfaces.
Reviewed by Darin, Ada.
* platform/network/ResourceError.h: Change Mac conditionals to CF to share more code.
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError): Modified based on CFErrorRef changes
(WebCore::ResourceError::unpackPlatformError): Ported from ResourceErrorMac.mm.
(WebCore::ResourceError::operator CFErrorRef): Ported from ResourceErrorMac.mm.
(WebCore::ResourceError::operator CFStreamError): Modified based on CFErrorRef changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 13 Jul 2007 19:06:53 +0000 (19:06 +0000)]
Reviewed by Darin and Maciej.
<rdar://problem/
5271096> panic after Safari stress test, caused by port leak
Replace uses of -[NSObject performSelector:withObject:afterDelay:] with CFRunLoopTimer. performSelector
causes the target (the WebHTMLView in this case) to be retained until the timer fires. Furthermore, when
running the PLT or iBench, the timers will not fire until the main loop is entered (usually after running all tests).
This means that the timers and ports will not be released until after the test has finished running.
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLView _cancelUpdateMouseoverTimer]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _updateMouseoverTimerCallback:]):
(-[WebHTMLView _frameOrBoundsChanged]):
(-[WebHTMLView _updateActiveState]):
(-[WebHTMLView _updateActiveStateTimerCallback:]):
(-[WebHTMLView viewWillMoveToWindow:]):
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView mouseDown:]):
(-[WebTextCompleteController dealloc]):
* WebView/WebHTMLViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 13 Jul 2007 18:55:42 +0000 (18:55 +0000)]
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/
5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
* fast/events/onchange-click-hang-expected.txt: Added.
* fast/events/onchange-click-hang.html: Added.
WebCore:
Reviewed by Adele.
Fix <rdar://problem/
5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
Guard against generating a simulated event from within a simulated event in the same node. Try to
match Firefox behavior.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchSimulatedMouseEvent):
(WebCore::EventTargetNode::dispatchSimulatedClick):
* dom/Node.cpp:
(WebCore::Node::Node):
* dom/Node.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 13 Jul 2007 18:29:30 +0000 (18:29 +0000)]
LayoutTests:
Reviewed by Darin.
Test for x <rdar://problem/
5333387>
Combination of selection and click() on checkbox crashes
* fast/dynamic/checkbox-selection-crash-expected.txt: Added.
* fast/dynamic/checkbox-selection-crash.html: Added.
WebCore:
Reviewed by Darin.
Fix <rdar://problem/
5333387>
Combination of selection and click() on checkbox crashes
Ensure there is no pending style update before doing synchronous paint. Under certain
circumstances this ends up doing style recalc in middle of paint() which may
for example tear down the rendering tree being painted, with bad results.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::setActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 18:16:15 +0000 (18:16 +0000)]
2007-07-13 David Kilzer <ddkilzer@apple.com>
Reviewed by Darin.
Added support for -h|--help argument and verify that all command line arguments parse
correctly.
* Scripts/run-webkit-httpd:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 18:13:01 +0000 (18:13 +0000)]
Fixed comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 13 Jul 2007 18:11:02 +0000 (18:11 +0000)]
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/
5333365>
Calling click() is very slow
* fast/forms/slow-click-expected.txt: Added.
* fast/forms/slow-click.html: Added.
WebCore:
Reviewed by Adele.
Fix <rdar://problem/
5333365>
Calling click() is very slow
There is a 100ms delay in ContainerNode::setActive() to do an activation effect. It is used for
simulated mouse activations (using keyboard for example). However, it shouldn't be done when calling from javascript
(through click() interface) since it hangs script execution.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::click):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 17:21:03 +0000 (17:21 +0000)]
Update versioning of trunk.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 16:34:03 +0000 (16:34 +0000)]
2007-07-14 Mark Rowe <mrowe@apple.com>
Reviewed by Sam.
Apply the change to Apache 2 configuration from r24204 to the other two Apache configuration files.
* http/conf/cygwin-httpd.conf:
* http/conf/httpd.conf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 12:00:23 +0000 (12:00 +0000)]
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13873
Incomplete repaint of replaced element's box shadow
Tests: fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::layout): Added a call to adjustOverflowForBoxShadow().
* rendering/RenderImage.cpp:
(WebCore::RenderImage::layout): Ditto.
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::layout): Ditto.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasOverflow.
(WebCore::RenderReplaced::~RenderReplaced): Added. Removes this object from the
overflow rect map if it has overflow.
(WebCore::RenderReplaced::shouldPaint): Account for overflow.
(WebCore::RenderReplaced::adjustOverflowForBoxShadow): Added. Creates or
removes an entry for this object in the global overflow rect map.
(WebCore::RenderReplaced::overflowHeight): Added.
(WebCore::RenderReplaced::overflowWidth): Added.
(WebCore::RenderReplaced::overflowLeft): Added.
(WebCore::RenderReplaced::overflowTop): Added.
(WebCore::RenderReplaced::overflowRect): Added.
* rendering/RenderReplaced.h:
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=13873
Incomplete repaint of replaced element's box shadow
* fast/repaint/box-shadow-h-expected.checksum:
* fast/repaint/box-shadow-h-expected.png:
* fast/repaint/box-shadow-h-expected.txt:
* fast/repaint/box-shadow-h.html:
* fast/repaint/box-shadow-v-expected.checksum:
* fast/repaint/box-shadow-v-expected.png:
* fast/repaint/box-shadow-v-expected.txt:
* fast/repaint/box-shadow-v.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 11:51:40 +0000 (11:51 +0000)]
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14395
When a <p> is inside <li> two <BR>s are rendered
Test: fast/lists/marker-before-empty-inline.html
* rendering/RenderBlock.h:
* rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that
do not actually generate any line boxes. Limited the nested lists quirk to
the case where the list is a child of the list item, to match Firefox.
* rendering/bidi.cpp:
(WebCore::requiresLineBox): Added. Factored out of skipWhitespace.
(WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes
whether the child or any of its siblings following it will generate a line
box in the flow.
(WebCore::RenderBlock::skipWhitespace):
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14395
When a <p> is inside <li> two <BR>s are rendered
* editing/pasteboard/
4861080-expected.checksum:
* editing/pasteboard/
4861080-expected.png:
* editing/pasteboard/
4861080-expected.txt:
* fast/lists/marker-before-empty-inline-expected.checksum: Added.
* fast/lists/marker-before-empty-inline-expected.png: Added.
* fast/lists/marker-before-empty-inline-expected.txt: Added.
* fast/lists/marker-before-empty-inline.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 11:47:10 +0000 (11:47 +0000)]
2007-07-13 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alexey.
Move HTTP methods to parse Content-Type from xmlhttprequest.cpp
which is LGPL to HTTPParsers.cpp. As both files were written by the
same author and the advice to move them came from him I think this move
is what is meant to be done.
Move filenameFromHTTPContentDisposition to HTTPParsers as well. This parse
function uses Vector<String>::split and doesn't honor quoting. This needs
to be fixed in later versions.
http://bugs.webkit.org/show_bug.cgi?id=5954 and http://bugs.webkit.org/show_bug.cgi?id=14059
benefit from this change.
* platform/network/HTTPParsers.cpp:
(WebCore::filenameFromHTTPContentDisposition):
(WebCore::extractMIMETypeFromMediaType):
(WebCore::extractCharsetFromMediaType):
* platform/network/HTTPParsers.h:
* platform/network/cf/ResourceResponseCFNet.cpp:
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType):
(WebCore::XMLHttpRequest::didReceiveResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 05:46:07 +0000 (05:46 +0000)]
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.
* platform/gdk/ChromeClientGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:
(ChromeClientGdk::print):
* platform/graphics/svg/SVGImageEmptyClients.h:
(WebCore::SVGEmptyChromeClient::print):
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out WebChromeClient::print.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::print):
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out ChromeClientQt::print.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::print):
* WebCoreSupport/ChromeClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 13 Jul 2007 05:00:51 +0000 (05:00 +0000)]
WebCore:
Reviewed by Maciej and Steve.
fixed <rdar://
4982432> window.print() needs to be implemented
* bridge/win/FrameWin.cpp:
(WebCore::Frame::print):
* page/Chrome.cpp:
(WebCore::Chrome::print):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/win/TemporaryLinkStubs.cpp:
win:
Reviewed by Maciej and Steve.
fixed <rdar://
4982432> window.print() needs to be implemented
* Interfaces/IWebUIDelegate.idl:
* WebChromeClient.cpp:
(WebChromeClient::print):
* WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 03:16:27 +0000 (03:16 +0000)]
2007-07-12 George Staikos <staikos@kde.org>
Reviewed by NOBODY.
Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.
* http/tests/security/cross-frame-access-put.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 02:53:15 +0000 (02:53 +0000)]
2007-07-12 David Kilzer <ddkilzer@apple.com>
Reviewed by NOBODY.
Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.
* http/tests/security/cross-frame-access-put.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 12 Jul 2007 19:26:56 +0000 (19:26 +0000)]
LayoutTests:
Reviewed by Harrison.
<rdar://problem/
5300379> Mail hung on option-delete
* editing/deleting/
5300379-expected.checksum: Added.
* editing/deleting/
5300379-expected.png: Added.
* editing/deleting/
5300379-expected.txt: Added.
* editing/deleting/
5300379.html: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/
5300379> Mail hung on option-delete
We were starting backward iteration at [container, 0] and
emitting for container over and over.
* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::advance): Don't
emit characters for a node if we're starting iteration at
[container, 0]. Don't emit characters for exiting containers
if we've already done so.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 12 Jul 2007 19:14:58 +0000 (19:14 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.
* kjs/function.cpp:
(KJS::FunctionImp::passInParameters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Thu, 12 Jul 2007 17:37:06 +0000 (17:37 +0000)]
Reviewed by Mark Rowe.
<rdar://problem/
5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 12 Jul 2007 16:34:14 +0000 (16:34 +0000)]
LayoutTests:
Reviewed by Maciej.
Test for <rdar://problem/
5329841>
Calling window.closed on a closed window causes Safari to crash
* fast/dom/Window/window-closed-crash-expected.txt: Added.
* fast/dom/Window/window-closed-crash.html: Added.
WebCore:
Reviewed by Maciej.
Patch for <rdar://problem/
5329841>
Calling window.closed on a closed window causes Safari to crash
- Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
- Adds additional new null checks as necessary
- Removes bogus toBoolean method
- Removes unused scheduleClose method
Test: fast/dom/Window/window-closed-crash.html
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
(WebCore::JSDOMWindow::customPut):
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
* bindings/js/kjs_events.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSLazyEventListener::parseCode):
* bindings/js/kjs_window.cpp:
(KJS::Window::Window):
(KJS::Window::impl):
(KJS::Window::interpreter):
(KJS::Window::location):
(KJS::Window::find):
(KJS::allowPopUp):
(KJS::createWindow):
(KJS::canShowModalDialog):
(KJS::canShowModalDialogNow):
(KJS::showModalDialog):
(KJS::Window::getValueProperty):
(KJS::Window::childFrameGetter):
(KJS::Window::indexGetter):
(KJS::Window::namedItemGetter):
(KJS::Window::getOwnPropertySlot):
(KJS::Window::put):
(KJS::Window::isSafeScript):
(KJS::Window::setListener):
(KJS::Window::getListener):
(KJS::Window::clear):
(KJS::WindowFunc::callAsFunction):
(KJS::Window::updateLayout):
(KJS::ScheduledAction::execute):
(KJS::Window::disconnectFrame):
(KJS::Location::put):
(KJS::LocationFunc::callAsFunction):
* bindings/js/kjs_window.h:
* page/mac/WebCoreFrameBridge.mm:
(updateRenderingForBindings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 16:24:48 +0000 (16:24 +0000)]
2007-07-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Mark Rowe.
- try to fix hang seen on buildbot after the last fix
* fast/history/resources/history_reload_window.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 15:15:06 +0000 (15:15 +0000)]
2007-07-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Mark Rowe.
- fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
* fast/history/resources/history_reload_window.html: Delay notifyDone() until
after the window actually closes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 14:01:41 +0000 (14:01 +0000)]
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Ada.
<rdar://problem/
5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document
* dom/Document.cpp:
(WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
* dom/Document.h:
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Ada.
Remove leak suppression for xmlDocPtrForString now that <rdar://problem/
5329877> is fixed.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 11:18:53 +0000 (11:18 +0000)]
2007-07-12 Maxime Britto <mbritto@pleyo.com>
Reviewed by Mark Rowe.
Update the expected results now that they match what the test describes as the correct rendering.
* svg/custom/invalid-fill-hex-expected.txt:
* svg/custom/invalid-fill-hex-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 10:49:35 +0000 (10:49 +0000)]
2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setupPOST):
(WebCore::ResourceHandleManager::startJob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 12 Jul 2007 08:15:21 +0000 (08:15 +0000)]
Reviewed by Oliver Hunt.
Made the leaks tests pass on Leopard.
* Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
* Scripts/run-leaks: Updated parser for slight change in text output.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 07:21:00 +0000 (07:21 +0000)]
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
<rdar://problem/
5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer
The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.
* platform/DeprecatedString.cpp:
(WebCore::isCharacterAllowedInBase):
(WebCore::toIntegralType):
(WebCore::DeprecatedString::toInt):
(WebCore::DeprecatedString::toInt64):
(WebCore::DeprecatedString::toUInt):
(WebCore::DeprecatedString::toUInt64):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Thu, 12 Jul 2007 06:23:06 +0000 (06:23 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 12 Jul 2007 05:06:46 +0000 (05:06 +0000)]
remove two unused variables and fix combobox rendering
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 12 Jul 2007 04:34:48 +0000 (04:34 +0000)]
Reviewed by Maciej
Fix for <rdar://problem/
5329712> GMail crash when trying to compose new message
* platform/win/FontDataWin.cpp:
(WebCore::FontData::containsCharacters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 12 Jul 2007 04:17:17 +0000 (04:17 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14584
XMLHttpRequest treats null login/password incorrectly
Test: http/tests/xmlhttprequest/null-auth.php
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::open):
* xml/xmlhttprequest.h:
Split the open() method into three to distinguish between missing and null credentials.
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 12 Jul 2007 03:04:45 +0000 (03:04 +0000)]
Fix build in debug mode
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 12 Jul 2007 02:48:15 +0000 (02:48 +0000)]
2007-07-11 David Kilzer <ddkilzer@apple.com>
Reviewed by Maciej.
Update the iExploder list of CSS properties after box-sizing was renamed to
-webkit-box-sizing in r21026 to fix <rdar://problem/
4667227>.
* iExploder/htdocs/cssproperties.in: Added -webkit-box-sizing. Both box-sizing and
-moz-box-sizing remain.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 12 Jul 2007 02:22:33 +0000 (02:22 +0000)]
Make it compile
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 12 Jul 2007 02:07:51 +0000 (02:07 +0000)]
Build fix for windows
* page/Frame.cpp:
(WebCore::Frame::firstRectForRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 12 Jul 2007 01:20:34 +0000 (01:20 +0000)]
Reviewed by Maciej.
Fix <rdar://problem/
5329481> Character range rect code for IME support needs to be crossplatform
Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange
* page/Frame.cpp:
(WebCore::Frame::firstRectForRange):
* page/Frame.h:
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge firstRectForDOMRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 11 Jul 2007 23:17:40 +0000 (23:17 +0000)]
Reviewed by Oliver.
<rdar://problem/
5108789> WEBVIEW: Drawing artifacts when dragging in IB
Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
among other standard NSView keys. Change automaticallyNotifiesObserversForKey to
return NO only for keys WebView manually fires notifications for.
* WebView/WebView.mm:
(+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire.
(-[WebView _declaredKeys]): Code clean up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 11 Jul 2007 22:49:51 +0000 (22:49 +0000)]
Static analysis build fix.
Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.
Reviewed by Hyatt.
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 11 Jul 2007 22:49:18 +0000 (22:49 +0000)]
Static analysis build fix.
Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.
Reviewed by Hyatt.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 22:01:41 +0000 (22:01 +0000)]
Make comboboxes update when the current item is changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:59:45 +0000 (19:59 +0000)]
Add a destructor to cleanup the SQL handle (presently unused, but will be soon).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:29:16 +0000 (19:29 +0000)]
Fix build with assertions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 11 Jul 2007 19:24:17 +0000 (19:24 +0000)]
top level:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
* WebKit.pri: Adjust INCLUDEPATH
JavaScriptCore:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
* ForwardingHeaders: Added.
* ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.
WebCore:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
* ForwardingHeaders/JavaScriptCore: Removed.
* ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 19:22:39 +0000 (19:22 +0000)]
Fix build.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::didReceiveResponse):
(WebCore::didReceiveData):
(WebCore::didFinishLoading):
(WebCore::didFail):
(WebCore::didReceiveChallenge):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:20:04 +0000 (19:20 +0000)]
Another build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:16:43 +0000 (19:16 +0000)]
Repair the build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 11 Jul 2007 19:09:39 +0000 (19:09 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas
We were previously trying to leave room for 1px of space between the text and the underline.
This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
touching the text.
* rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 18:47:33 +0000 (18:47 +0000)]
Reviewed by Darin and Geoff.
<rdar://problem/
5313508>
REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs
Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.
For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
pass those if we're asked to authenticate.
For the synchronous case, implement a new connection delegate and run it in a separate mode so
no other sources will fire.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadResourceSynchronously):
(-[WebCoreResourceHandleAsDelegate dealloc]):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreSynchronousLoader _isDone]):
(-[WebCoreSynchronousLoader dealloc]):
(-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreSynchronousLoader connection:didReceiveResponse:]):
(-[WebCoreSynchronousLoader connection:didReceiveData:]):
(-[WebCoreSynchronousLoader connectionDidFinishLoading:]):
(-[WebCoreSynchronousLoader connection:didFailWithError:]):
(-[WebCoreSynchronousLoader _data]):
(-[WebCoreSynchronousLoader _response]):
(-[WebCoreSynchronousLoader _error]):
(+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 18:21:09 +0000 (18:21 +0000)]
Reviewed by Geoff.
Create the lock file in a writable directory.
* http/conf/apache2-httpd.conf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 11 Jul 2007 18:11:32 +0000 (18:11 +0000)]
Reviewed by Sam Weinig.
- fix <rdar://problem/
5315265> REGRESSION: Leopard launch time -
there are about 190 stats of icudt36b files during launch
* platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName):
Add a special case for the empty string so we don't load the extended text
encodings just so we can return 0 for that case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 17:12:22 +0000 (17:12 +0000)]
Reviewed by Darin.
Remove a bunch of unneeded accessors from ResourceHandle.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::didReceiveResponse):
(WebCore::IconLoader::didFail):
(WebCore::IconLoader::didFinishLoading):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Wed, 11 Jul 2007 12:56:05 +0000 (12:56 +0000)]
Reviewed by Mark.
Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 11 Jul 2007 10:21:09 +0000 (10:21 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5234383> REGRESSION: Sentence breaker method returning entire document length
* editing/selection/
5234383-1-expected.checksum: Added.
* editing/selection/
5234383-1-expected.png: Added.
* editing/selection/
5234383-1-expected.txt: Added.
* editing/selection/
5234383-1.html: Added.
* editing/selection/
5234383-2-expected.checksum: Added.
* editing/selection/
5234383-2-expected.png: Added.
* editing/selection/
5234383-2-expected.txt: Added.
* editing/selection/
5234383-2.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
5234383> REGRESSION: Sentence breaker method returning entire document length
The functions for moving the caret to the next/previous sentence boundary
were in many cases moving to the beginning/end of the document. The functions that
should move the caret to an equivalent position in the next/previous sentence behaved
like the aforementioned functions ought to. Put the code from the second two functions
in the first and made sure that the second two are properly FIXMEd. They're rarely
used (filed
5323691).
* editing/SelectionController.cpp:
(WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity,
so that we can test the functions that were broken from JS.
* editing/visible_units.cpp:
(WebCore::startOfSentence): Removed the FIXME about
5234383.
(WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary
current does.
(WebCore::endOfSentence): Removed the FIXME about
5234383.
(WebCore::previousSentencePosition): Removed an incorrect FIXME.
(WebCore::nextSentencePositionBoundary): Tweaked FIXME. This function is
identical, not close to endSentenceBoundary.
(WebCore::nextSentencePosition): Removed an incorrect FIXME.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Wed, 11 Jul 2007 08:10:16 +0000 (08:10 +0000)]
Reviewed by John.
Fix <rdar://problem/
4570550>
Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages
When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not
receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
each time making printing at least O(n^2).
Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
called in case WebHTMLView is embedded in the view that is being printed.
No automatic test possible, requires printing and non-Safari client.
* WebView/WebHTMLView.mm:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 11 Jul 2007 07:40:18 +0000 (07:40 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone
Be less strict for the hex color definition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc