WebKit-https.git
8 years agoAdd an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect...
commit-queue@webkit.org [Fri, 20 Sep 2013 20:35:40 +0000 (20:35 +0000)]
Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.
https://bugs.webkit.org/show_bug.cgi?id=121696

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-20
Reviewed by Antti Koivisto.

Add an argument to ImageSource::createFrameAtIndex.  A platform image decoder can decide the optimal
scale based on the hint and pass the real scale it used for decoding.

No new tests, no behavior change.

* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
* platform/graphics/ImageSource.h:
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove tests to new import location
bjonesbe@adobe.com [Fri, 20 Sep 2013 20:27:50 +0000 (20:27 +0000)]
Move tests to new import location
https://bugs.webkit.org/show_bug.cgi?id=121701

Reviewed by Dirk Schulze.

The import script was previously importing the tests into an incorrect
path. This change uses the latest import script to import all of the
shapes tests to the right location.

There are also some small changes in the tests since they had some
more metadata added upstream, but there are no functional changes in
the tests with this change.

* csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js.
(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRightRoundedRectFloatShapeOutsideRefTest):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(genRightRoundedRectFloatShapeOutsideRefTest):
* csswg/contributors/adobe/submitted/shapes/shape-outside/resources/subpixel-utils.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js.
(SubPixelLayout):
(SubPixelLayout.):
* csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log: Added.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Copied from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html.
* csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log: Added.
* csswg/submitted/shapes/shape-outside/w3c-import.log: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake JSMainThreadNullState noncopyable.
akling@apple.com [Fri, 20 Sep 2013 20:26:49 +0000 (20:26 +0000)]
Make JSMainThreadNullState noncopyable.

Blindly rubber-stamped by Antti Koivisto.

* bindings/js/JSMainThreadExecState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClobberize phase forgets to indicate that it writes GCState for several node types
mhahnenberg@apple.com [Fri, 20 Sep 2013 20:23:33 +0000 (20:23 +0000)]
Clobberize phase forgets to indicate that it writes GCState for several node types
https://bugs.webkit.org/show_bug.cgi?id=121702

Reviewed by Oliver Hunt.

Added read and write for GCState to the nodes that could end up allocating (and thereby
cause a garbage collection).

* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake extract-localizable-strings available to WebCore clients
mitz@apple.com [Fri, 20 Sep 2013 20:13:11 +0000 (20:13 +0000)]
Make extract-localizable-strings available to WebCore clients
https://bugs.webkit.org/show_bug.cgi?id=121699

Reviewed by Darin Adler.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj: Added a Scripts group with a reference to
extract-localizable-strings.pl. Added a Copy Scripts build phase to the WebCore target that
copies the script into PrivateHeaders/Scripts in the framework.
* extract-localizable-strings.pl: Copied from Tools/Scripts/extract-localizable-strings.

Tools:

* Scripts/extract-localizable-strings: Copied to
Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
executes the script from its new location. This is a temporary measure until certain code
that is external to WebKit is adapted to the new location.
* Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
from its new location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove layer hierarchy functions from RenderObject to RenderElement
antti@apple.com [Fri, 20 Sep 2013 19:56:33 +0000 (19:56 +0000)]
Move layer hierarchy functions from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121692

Reviewed by Andreas Kling.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layerCreationAllowedForSubtree):

    Move these from RenderObject.

(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):

    Factor the layer related portion of these virtuals here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStart cleaning the API of SelectorChecker
benjamin@webkit.org [Fri, 20 Sep 2013 19:29:47 +0000 (19:29 +0000)]
Start cleaning the API of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121654

Reviewed by Antti Koivisto.

Make the matching mode internal.
Remove unused accessors.
Make isFrameFocused() internal.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::isFrameFocused):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::match):
* css/StyleResolver.h:
(WebCore::checkRegionSelector):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove SelectorChecker's CrossesBoundary boundary mode
benjamin@webkit.org [Fri, 20 Sep 2013 19:28:08 +0000 (19:28 +0000)]
Remove SelectorChecker's CrossesBoundary boundary mode
https://bugs.webkit.org/show_bug.cgi?id=121653

Reviewed by Antti Koivisto.

This mode is an ancient vestige of shadow dom.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):
* css/SelectorChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove the SharingRules mode outside of SelectorChecker
benjamin@webkit.org [Fri, 20 Sep 2013 19:27:04 +0000 (19:27 +0000)]
Move the SharingRules mode outside of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121652

Reviewed by Antti Koivisto.

The SharingRules handling inside SelectorChecker is a weird hack
to hit a specific branch of ElementRuleCollector.

This patch moves the exception to ElementRuleCollector, where it is easier
to understand what it is for.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed img src URLS with multiple spaces
commit-queue@webkit.org [Fri, 20 Sep 2013 19:09:05 +0000 (19:09 +0000)]
Fixed img src URLS with multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=121592

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/loader/image-src-multiple-space.html

I've removed the simplifyWhiteSpace step from HTMLImageElement's src attribute during the srcset selection algorithm.
That step prevented URLs with multiple spaces from being loaded as images, minimizing the multiple spaces into a single one.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

This test verifies that URLs with multiple spaces can be loaded as an image resource.

* fast/loader/image-src-multiple-space-expected.txt: Added.
* fast/loader/image-src-multiple-space.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHiding a focused element should unfocus it and fire a blur event
commit-queue@webkit.org [Fri, 20 Sep 2013 19:06:52 +0000 (19:06 +0000)]
Hiding a focused element should unfocus it and fire a blur event
https://bugs.webkit.org/show_bug.cgi?id=29241

Patch by Arunprasad Rajkumar <ararunprasad@gmail.com> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html

We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):
* dom/Document.h:

LayoutTests:

* fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
* fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.

LayoutTest reused from https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
fpizlo@apple.com [Fri, 20 Sep 2013 18:42:41 +0000 (18:42 +0000)]
Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/. Rolling back in after fixing JIT-only build
and tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
* dfg/DFGAssemblyHelpers.cpp: Removed.
* dfg/DFGAssemblyHelpers.h: Removed.
* dfg/DFGBinarySwitch.h:
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGCCallHelpers.h: Removed.
* dfg/DFGDisassembler.cpp:
* dfg/DFGFPRInfo.h: Removed.
* dfg/DFGGPRInfo.h: Removed.
* dfg/DFGGraph.cpp:
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp:
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompilerCommon.h:
* dfg/DFGRegisterBank.h:
* dfg/DFGRegisterSet.h:
* dfg/DFGRepatch.cpp:
* dfg/DFGSilentRegisterSavePlan.h:
* dfg/DFGThunks.cpp:
* dfg/DFGVariableEvent.cpp:
* ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
* ftl/FTLCompile.cpp:
* ftl/FTLExitThunkGenerator.h:
* ftl/FTLLink.cpp:
* ftl/FTLThunks.cpp:
* jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
* jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.
(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):
* jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
* jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.
(WTF::printInternal):
* jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.
(WTF::printInternal):
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
* runtime/JSCJSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r156140): Srcset tests are frequently crashing
ap@apple.com [Fri, 20 Sep 2013 18:31:53 +0000 (18:31 +0000)]
REGRESSION (r156140): Srcset tests are frequently crashing
https://bugs.webkit.org/show_bug.cgi?id=121695

Reviewed by Dean Jackson.

Returning a string created without copying bytes is not safe. It used to be OK
because a new string was immediately created by decodeURLEscapeSequences().
But even that was not great, because decodeURLEscapeSequences() could potentially
return the same string, not a deep copy, if we decided to optimize it like that.

Also made a number of drive-by style fixes.
- It's URL, not Url.
- It's srcset, not srcSet.
-  We don't add ".0" in floating point value initializers. It's particularly misleading
to initialize a float with 1.0, which is a double value.
- Renamed srcSetLength to srcsetAttributeLength to match srcsetAttribute variable
whose length it caches.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator
mrobinson@webkit.org [Fri, 20 Sep 2013 18:12:05 +0000 (18:12 +0000)]
[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=121633

Reviewed by Gustavo Noronha Silva.

* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Fold in some skipping checks that are used by all callers.
(SkipFunction): Ditto.
(GenerateProperties): Rely on SkipAttribute more thoroughly.
(GenerateFunction): Rely on SkipFunction more thoroughly.
(GenerateFunctions): Rely on SkipAttribute more thoroughly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build after r156144
paroga@webkit.org [Fri, 20 Sep 2013 17:44:47 +0000 (17:44 +0000)]
Fix the build after r156144

* html/canvas/CanvasRenderingContext2D.cpp: Added missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorenderStyleOfEnclosingTextNode should update style before using a renderer
rniwa@webkit.org [Fri, 20 Sep 2013 17:32:18 +0000 (17:32 +0000)]
renderStyleOfEnclosingTextNode should update style before using a renderer
https://bugs.webkit.org/show_bug.cgi?id=121690

Reviewed by Enrica Casucci.

Merge https://chromium.googlesource.com/chromium/blink/+/65f089545e8c18cb268dfcbe56cba1cd8045527a

When accessing a renderer editing should always make sure that the style has been updated for the node.
Editing calls splitTextNode in a number of places and then accesses the renderer later. This patch is
the first of many to make sure editing always updates the style before attempting to access the renderer
(or style) of a node after calling a mutation method.

* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):
* editing/ApplyBlockElementCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove URL decoding in srcset handling
ap@apple.com [Fri, 20 Sep 2013 17:28:36 +0000 (17:28 +0000)]
Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609

Followup to <http://trac.webkit.org/changeset/156161> - that change renamed expected
results, but the new test wasn't landed.

* fast/loader/image-src-encoded.html: Copied from LayoutTests/fast/loader/image-src-question-mark.html.
* fast/loader/image-src-question-mark.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a couple more CSS leaks
darin@apple.com [Fri, 20 Sep 2013 17:18:14 +0000 (17:18 +0000)]
Fix a couple more CSS leaks
https://bugs.webkit.org/show_bug.cgi?id=121683

Reviewed by Alexey Proskuryakov.

* css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::viewSourceStyle): Put the result of the
parseUASheet into a global variable so it doesn't show up as a storage leak.

* css/CSSGrammar.y.in: Added a missing adoptRef. This was leaking any rule
we parsed individually.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNuke remaining VS2005 tools from the tree.
paroga@webkit.org [Fri, 20 Sep 2013 17:16:56 +0000 (17:16 +0000)]
Nuke remaining VS2005 tools from the tree.
https://bugs.webkit.org/show_bug.cgi?id=121691

Reviewed by Brent Fulgham.

* CLWrapper/CLWrapper.cpp: Removed.
* CLWrapper/CLWrapper.sln: Removed.
* CLWrapper/CLWrapper.vcproj: Removed.
* MIDLWrapper/MIDLWrapper.cpp: Removed.
* MIDLWrapper/MIDLWrapper.sln: Removed.
* MIDLWrapper/MIDLWrapper.vcproj: Removed.
* Scripts/parallelcl: Removed.
* vcbin/cl.exe: Removed.
* vcbin/midl.exe: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify the ShapeOutsideInfo and ShapeInfo interfaces
bjonesbe@adobe.com [Fri, 20 Sep 2013 17:16:01 +0000 (17:16 +0000)]
Simplify the ShapeOutsideInfo and ShapeInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=121685

Reviewed by Darin Adler.

With the creation ShapeInfo::computeSegmentsForLine, it became possible to
simplify the ShapeInfo classes. ShapeOutsideInfo has no need to save the
segments, and now that segment creation is in its own method, it doesn't have
to save the segments anymore. This also simplifies the public interface of
ShapeOutsideInfo, as it only has one method to do the computation.

Also, the methods in ShapeOutsideInfo have been renamed to reflect the fact
that ShapeOutsideInfo isn't really interested in segments.

No new tests, no new behavior.

* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
* rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/shapes/ShapeInfo.cpp:
* rendering/shapes/ShapeInfo.h:
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
* rendering/shapes/ShapeOutsideInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaking tests added in r156157 JS-only, given that other
commit-queue@webkit.org [Fri, 20 Sep 2013 17:10:14 +0000 (17:10 +0000)]
Making tests added in r156157 JS-only, given that other
code generators are still broken.

Original bug 121305 (StrictTypeChecking extended attribute fails for methods with sequence<T>).
https://bugs.webkit.org/show_bug.cgi?id=121305

Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2013-09-20
Rubber stamped by Alexey Proskuryakov.

* bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Poor rendering opening a Google map short link
commit-queue@webkit.org [Fri, 20 Sep 2013 17:07:07 +0000 (17:07 +0000)]
[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-20
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

JIRA 495023
Route lines on google map were shown even they were on a hidden canvas.
Include visibility on LayerWebKitThread if it's a canvas layer and respect
the visibility when compositing layers in LayerRenderer.

* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::isCanvasLayer):
(WebCore::LayerData::isVisible):
(WebCore::LayerData::includeVisibility):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to
bfulgham@apple.com [Fri, 20 Sep 2013 16:57:20 +0000 (16:57 +0000)]
[Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to
ignore Visual Studio's local user settings file.

* WebInspectorUI.vcxproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMAKE] FindHarfBuzz: Handle harfbuzz / harfbuzz-icu split
commit-queue@webkit.org [Fri, 20 Sep 2013 16:48:19 +0000 (16:48 +0000)]
[CMAKE] FindHarfBuzz: Handle harfbuzz / harfbuzz-icu split
https://bugs.webkit.org/show_bug.cgi?id=121688

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-09-20
Reviewed by Martin Robinson.

HarfBuzz 0.9.18 split ICU support into a separate harfbuzz-icu library.
To be able to build with earlier and newer versions of HarfBuzz, we should
check for harfbuzz-icu as well, if version >= 0.9.18.

* Source/cmake/FindHarfBuzz.cmake: Check for harfbuzz-icu, if version
>= 0.9.18.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix MIDL files for Visual Studio 2012
paroga@webkit.org [Fri, 20 Sep 2013 16:45:51 +0000 (16:45 +0000)]
Fix MIDL files for Visual Studio 2012
https://bugs.webkit.org/show_bug.cgi?id=121552

Reviewed by Brent Fulgham.

The MIDL compiler shipped with Visual Studio 2012 does not accept forward declarations
with typedefs. Use the struct keyword in the function signature to fix this problem.

* Interfaces/DOMPrivate.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAtomics.h does not build on MinGW
allan.jensen@digia.com [Fri, 20 Sep 2013 16:45:42 +0000 (16:45 +0000)]
Atomics.h does not build on MinGW
https://bugs.webkit.org/show_bug.cgi?id=121663

Reviewed by Darin Adler.

MinGW does not have _ReadWriteBarrier() intrinsic, but does have GCC
inline assembler, so use the GCC definitions instead of MSVC ones.

* wtf/Atomics.h:
(WTF::compilerFence):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInline method exported
allan.jensen@digia.com [Fri, 20 Sep 2013 16:35:15 +0000 (16:35 +0000)]
Inline method exported
https://bugs.webkit.org/show_bug.cgi?id=121664

Reviewed by Darin Adler.

WatchDog::didFire() is marked as an exported symbol eventhough it is
defined inline. This breaks the build on MinGW since it results in dllimport
being declared on a definition.

* runtime/Watchdog.h:
(JSC::Watchdog::didFire):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: WebArea claims to have a subrole, but always returns nil.
commit-queue@webkit.org [Fri, 20 Sep 2013 16:18:10 +0000 (16:18 +0000)]
AX: WebArea claims to have a subrole, but always returns nil.
https://bugs.webkit.org/show_bug.cgi?id=121658

Patch by Sam White <samuel_white@apple.com> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing AXWebArea related test to reflect unused attribute removal.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.

* platform/mac/accessibility/document-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
commit-queue@webkit.org [Fri, 20 Sep 2013 15:47:24 +0000 (15:47 +0000)]
[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
https://bugs.webkit.org/show_bug.cgi?id=121294

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Martin Robinson.

Provide a new patch to deal with the issue in the GTK+ module from
the internal jhbuild environment. This issue has been reported
upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).

* gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
* gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd valueForLength/minimumValueForLength wrappers to RenderElement.
akling@apple.com [Fri, 20 Sep 2013 15:34:19 +0000 (15:34 +0000)]
Add valueForLength/minimumValueForLength wrappers to RenderElement.
<https://webkit.org/b/121676>

Reviewed by Antti Koivisto.

Add two inline wrappers for these functions so we don't have to pass
the RenderView everywhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ATK][WTR] accessibility/aria-invalid.html times out
commit-queue@webkit.org [Fri, 20 Sep 2013 15:20:32 +0000 (15:20 +0000)]
[ATK][WTR] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=121668

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.

LayoutTests:

Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.

* platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
it now passes with this fix and the patch from bug 120421.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
commit-queue@webkit.org [Fri, 20 Sep 2013 15:15:22 +0000 (15:15 +0000)]
[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=120421

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Implemented the notification listener for AccessibilityUIElement for
WebKitTestRunner. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener() will then invoke
JSObjectCallAsFunction() with the respective callback function. The
notification handlers are stored in HashMap in
AccessibilityNotificationHandlerAtk.cpp.

Moved ATK signal handling (printAccessibilityEvent and
axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.

* WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
include path.
* WebKitTestRunner/GNUmakefile.am:
Added AccessibilityNotificationHandlerAtk.cpp/h.
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
listener IDs to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
listener IDs to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
notification handler for GTK+ and EFL.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
Moved printAccessibilityEvent and axObjectEventListener to
AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::resetToConsistentState): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
(WTR::printAccessibilityEvent): Prints accessibility events. This
function was moved from AccessibilityControllerAtk.cpp.
(WTR::axObjectEventListener): Callback for signals. This function was
moved from AccessibilityControllerAtk.cpp.
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
Initialize element and function callback.
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
Removes handler from HashMap and disconnects callbacks if necessary.
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
logging mode and connects callbacks.
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
Sets the notification callback and connects callback to signals.
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
Removes the notification callback from HashMap.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connects axObjectEventListener to ATK signals.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnects callback.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
(WTR::AccessibilityNotificationHandler::create): Creates a new instance
of AccessibilityNotificationHandler.
(WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
element.
(WTR::AccessibilityNotificationHandler::platformElement): Gets the
element.
(WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
Gets the notification callback.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::addNotificationListener): Creates
notification handler, set the platform element and the notification
callback.
(WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
notification handler.
* WebKitTestRunner/PlatformEfl.cmake:
Added AccessibilityNotificationHandlerAtk.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix some small style issues in the bindings
mrobinson@webkit.org [Fri, 20 Sep 2013 15:04:07 +0000 (15:04 +0000)]
[GTK] Fix some small style issues in the bindings
https://bugs.webkit.org/show_bug.cgi?id=121613

Reviewed by Carlos Garcia Campos.

* bindings/scripts/CodeGeneratorGObject.pm: When printing the license
header use the more common comment style within the WebKit project.
(GenerateProperty): Indent property definitions according to WebKit style, improve
the nick and blurb properties, and improve the various parameter spec argument layout.
(GenerateFunction): Remove the newline from function signatures to match WebKit style.
* bindings/scripts/test/GObject: Update bindings test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 14:58:52 +0000 (14:58 +0000)]
[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

* platform/qt-wk1/TestExpectations:
* platform/qt-wk2/TestExpectations:
* platform/qt-wk2/fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoModified img src and srcset encoded URL tests
commit-queue@webkit.org [Fri, 20 Sep 2013 14:43:15 +0000 (14:43 +0000)]
Modified img src and srcset encoded URL tests
https://bugs.webkit.org/show_bug.cgi?id=121677

Previous tests have broken the Windows builds, since '?' is not a valid char.
Moved to using '@'

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Anders Carlsson.

* fast/hidpi/image-srcset-encoded-expected.txt: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt.
* fast/hidpi/image-srcset-encoded.html: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark.html.
* fast/hidpi/resources/image@test.png: Renamed from LayoutTests/fast/hidpi/resources/image?test.png.
* fast/loader/image-src-encoded-expected.txt: Renamed from LayoutTests/fast/loader/image-src-question-mark-expected.txt.
* fast/loader/resources/image@test.png: Renamed from LayoutTests/fast/loader/resources/image?test.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update tests after r156066 and r156083.
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 14:12:02 +0000 (14:12 +0000)]
[Qt] Unreviewed gardening. Update tests after r156066 and r156083.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

* platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/form-element-geometry-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/form-element-geometry-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/menulist-separator-painting-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/select-baseline-expected.png: Added r156083.
* platform/qt-wk1/fast/forms/select-baseline-expected.txt: Added r156083.
* platform/qt-wk1/fast/forms/selectlist-minsize-expected.txt: Added r156083.
* platform/qt-wk1/fast/replaced/three-selects-break-expected.txt: Added r156083.
* platform/qt-wk1/js/dom/switch-behaviour-expected.txt: Added r156066.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
paroga@webkit.org [Fri, 20 Sep 2013 13:23:25 +0000 (13:23 +0000)]
[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
https://bugs.webkit.org/show_bug.cgi?id=121672

Reviewed by Gyuyoung Kim.

Since the scope of add_definitions() is always a whole file, we need to use
target properties instead to set definitions only for specific targets.

Source/JavaScriptCore:

* CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:

Source/WebKit:

* CMakeLists.txt:

Source/WTF:

* wtf/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Make "autoscroll for drag'n drop" a setting
tonikitoo@webkit.org [Fri, 20 Sep 2013 13:17:07 +0000 (13:17 +0000)]
Source/WebCore: Make "autoscroll for drag'n drop" a setting
https://bugs.webkit.org/show_bug.cgi?id=121559

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Currently, there is a ChromeClient hook to make the
feature opt'ed-in or out. That makes it harder to test the
feature on ports that do not enable it, e.g. Mac/WebKit2 port.
However, Mac/WebKit2 is the port that has the best drag'n drop
WTR implementation.

Patch changes the toggle on/off mechanism to be a setting,
and exposes it through InternalSetting interface for testing.

* page/AutoscrollController.cpp:
(WebCore::AutoscrollController::updateDragAndDrop):
* page/ChromeClient.h:
* page/Settings.in:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAutoscrollForDragAndDropEnabled):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

LayoutTests: Make "autoscroll" for drag'n drop a setting
https://bugs.webkit.org/show_bug.cgi?id=121559

* fast/events/drag-and-drop-autoscroll.html:

Adapts the test so that is toggles the feature on
via InternalSettings interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStrictTypeChecking extended attribute fails for methods with sequence<T> https:/...
tonikitoo@webkit.org [Fri, 20 Sep 2013 13:16:28 +0000 (13:16 +0000)]
StrictTypeChecking extended attribute fails for methods with sequence<T> https://bugs.webkit.org/show_bug.cgi?id=121305

Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

The extended attribute StrictTypeChecking can not be set to methods if
one of the parameters is a "sequence".
Basically, since "sequence" is not considered a native type
(see function IsNativeType) the Perl code generator tries to
include its supposedly associated header, in this case "JSsequence.h"
Compilation then fails.

It is a problem for bindings including WebGL, where all methods
are supposed to be set as StrictTypeChecking (see bug 44202 [1]). Due to this restriction,
it relaxed, but I would like to bring it back.

Patch fixes the issue by hardening the way includes are auto-added
for methods where StrictTypeChecking extended attribute is present.
Now, only wrapper types (see IsWrapperType) trigger header inclusion,
excluding arrays, sequences, basic types, etc.

[1] https://bugs.webkit.org/show_bug.cgi?id=44202

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 12:28:36 +0000 (12:28 +0000)]
[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

* platform/qt/css1/text_properties/letter_spacing-expected.png:
* platform/qt/css1/text_properties/letter_spacing-expected.txt:
* platform/qt/fast/css/first-line-text-decoration-expected.png:
* platform/qt/fast/css/first-line-text-decoration-expected.txt:
* platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
* platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
* platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
* platform/qt/fast/text/basic/003-expected.png:
* platform/qt/fast/text/basic/003-expected.txt:
* platform/qt/fast/text/basic/013-expected.png:
* platform/qt/fast/text/basic/013-expected.txt:
* platform/qt/fast/text/text-letter-spacing-expected.png:
* platform/qt/fast/text/text-letter-spacing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize fetching the Node for never-anonymous renderers.
akling@apple.com [Fri, 20 Sep 2013 12:16:13 +0000 (12:16 +0000)]
Optimize fetching the Node for never-anonymous renderers.
<https://webkit.org/b/121627>

Reviewed by Antti Koivisto.

Add a RenderObject::nodeForNonAnonymous() that can be used instead
of node() when a renderer is guaranteed non-anonymous.

Use this to implement reference element getters for the various
renderers that are known at compile-time to correspond to a DOM node.

Also renamed existingElement() => element() since using an alternate
name for a reference overload isn't actually necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove duplicated secondsPerDay variables
paroga@webkit.org [Fri, 20 Sep 2013 11:56:30 +0000 (11:56 +0000)]
Remove duplicated secondsPerDay variables
https://bugs.webkit.org/show_bug.cgi?id=121601

Reviewed by Andreas Kling.

Source/WebCore:

Use secondsPerDay from DateMath.h instead of defining it again.

* history/HistoryItem.cpp:
(WebCore::timeToDay):

Source/WebKit/win:

Use secondsPerDay from DateMath.h instead of defining it again.

* MarshallingHelpers.cpp:

Source/WTF:

Move secondsPerDay from the source into the header file
to make it accessible by other code too.

* wtf/DateMath.cpp:
* wtf/DateMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix duplicated loop variable names after r155743
paroga@webkit.org [Fri, 20 Sep 2013 11:54:46 +0000 (11:54 +0000)]
Fix duplicated loop variable names after r155743
https://bugs.webkit.org/show_bug.cgi?id=121667

Reviewed by Andreas Kling.

Do not use the same name for variables in nested loops to fix a compiler warning.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate features.pri
allan.jensen@digia.com [Fri, 20 Sep 2013 11:51:19 +0000 (11:51 +0000)]
Update features.pri
https://bugs.webkit.org/show_bug.cgi?id=121670

Reviewed by Jocelyn Turcotte.

Remove feature flags that no longer exists and new ones added to FeatureList.pm

* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake RenderObject::parent() return RenderElement
antti@apple.com [Fri, 20 Sep 2013 11:44:17 +0000 (11:44 +0000)]
Make RenderObject::parent() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121671

Reviewed by Andreas Kling.

Make RenderObject::parent() return RenderElement and adopt everywhere.
Moved addChild/removeChild from RenderObject to RenderElement.
Uninlined a few big RenderObject functions.
Renamed RenderObject::remove() -> RenderObject::removeFromParent()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildfix after r156133 for !ENABLE(WORKERS) platforms
ossy@webkit.org [Fri, 20 Sep 2013 11:32:43 +0000 (11:32 +0000)]
Buildfix after r156133 for !ENABLE(WORKERS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121669

Reviewed by Antti Koivisto.

* platform/ThreadGlobalData.cpp:
* platform/ThreadGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][WK2] accessibility/selection-states.html is failing
commit-queue@webkit.org [Fri, 20 Sep 2013 11:18:05 +0000 (11:18 +0000)]
[GTK][WK2] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116972

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

isSelectable() was not exposed in Accessibility.

* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Unskipping accessibility/selection-states.html test.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd covariant RenderElement* Element::renderer()
ossy@webkit.org [Fri, 20 Sep 2013 10:58:41 +0000 (10:58 +0000)]
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Unreviewed buildfix after r156144.

* DOMCoreClasses.cpp:
(DOMElement::boundingBox):
(DOMElement::font):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake createRenderer() return RenderElement
antti@apple.com [Fri, 20 Sep 2013 09:59:37 +0000 (09:59 +0000)]
Make createRenderer() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121666

Rubber-stamped by Andreas Kling.

Tighter typing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.
paroga@webkit.org [Fri, 20 Sep 2013 09:52:13 +0000 (09:52 +0000)]
Buildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingFilterRepaintLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WIN] Fix build without precompiled header after r154146.
paroga@webkit.org [Fri, 20 Sep 2013 09:51:53 +0000 (09:51 +0000)]
[WIN] Fix build without precompiled header after r154146.

* platform/win/WebCoreBundleWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd covariant RenderElement* Element::renderer()
antti@apple.com [Fri, 20 Sep 2013 08:59:25 +0000 (08:59 +0000)]
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Rebase tests.
zarvai@inf.u-szeged.hu [Fri, 20 Sep 2013 07:34:56 +0000 (07:34 +0000)]
[Qt] Unreviewed gardening. Rebase tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

* platform/qt-wk2/fast/css/word-space-extra-expected.png: Added r155957.
* platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Rebase after r155957.
* platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Rebase after r155957.
* platform/qt/fast/css/word-space-extra-expected.txt: Rebase after r155957.
* platform/qt/fast/forms/select-empty-option-height-expected.txt: Rebase after rr156040.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle null font families.
andersca@apple.com [Fri, 20 Sep 2013 06:08:24 +0000 (06:08 +0000)]
Handle null font families.

Reviewed by Darin Adler.

* platform/graphics/Font.cpp:
(WebCore::computeFontGlyphsCacheHash):
Don't crash when trying to hash null strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a couple mistakes in my recent CSS grammar leak patch
darin@apple.com [Fri, 20 Sep 2013 05:57:56 +0000 (05:57 +0000)]
Fix a couple mistakes in my recent CSS grammar leak patch
https://bugs.webkit.org/show_bug.cgi?id=121659

Reviewed by Alexey Proskuryakov.

* css/CSSGrammar.y.in: Added initialization to nullptr for some error cases
that were otherwise leaving a bad value for the result of the production.
Also fixed a reversed logical expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove URL decoding in srcset handling
commit-queue@webkit.org [Fri, 20 Sep 2013 05:02:59 +0000 (05:02 +0000)]
Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-19
Reviewed by Benjamin Poulain.

Source/WebCore:

Tests: fast/hidpi/image-srcset-question-mark.html
       fast/loader/image-src-question-mark.html

Removed URL decoding from src and srcset's handling algorithm, since they break encoded URLS.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcSetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

These tests make sure that encoded URLs are properly handled, and especially URLs
with a question mark in them.

* fast/hidpi/image-srcset-question-mark-expected.txt: Added.
* fast/hidpi/image-srcset-question-mark.html: Added.
* fast/hidpi/resources/image?test.png: Added.
* fast/loader/image-src-question-mark-expected.txt: Added.
* fast/loader/image-src-question-mark.html: Added.
* fast/loader/resources/image?test.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid calling AtomicString::lower() in makeFontGlyphsCacheKey
andersca@apple.com [Fri, 20 Sep 2013 04:46:59 +0000 (04:46 +0000)]
Avoid calling AtomicString::lower() in makeFontGlyphsCacheKey
https://bugs.webkit.org/show_bug.cgi?id=121656

Reviewed by Darin Adler.

Instead of lower casing AtomicStrings, store the strings as is and use the case folding
hash and case insensitive compare to determine equality.

* platform/graphics/Font.cpp:
(WebCore::operator==):
(WebCore::makeFontGlyphsCacheKey):
(WebCore::computeFontGlyphsCacheHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix leaks in CSS parser caused by overwriting owned raw pointers with 0
darin@apple.com [Fri, 20 Sep 2013 04:29:50 +0000 (04:29 +0000)]
Fix leaks in CSS parser caused by overwriting owned raw pointers with 0
https://bugs.webkit.org/show_bug.cgi?id=121655

Reviewed by Anders Carlsson.

* css/CSSGrammar.y.in: Use nullptr instead of 0. Use unique_ptr instead
of a raw pointer in cases where we might or might not actually keep
the allocated memory. This can still be cleaned up further, but this
should fix the memory leaks we have been seeing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse shouldBecomeEqual in asynchronous spellchecking tests.
g.czajkowski@samsung.com [Fri, 20 Sep 2013 04:07:13 +0000 (04:07 +0000)]
Use shouldBecomeEqual in asynchronous spellchecking tests.
https://bugs.webkit.org/show_bug.cgi?id=121483

Reviewed by Darin Adler.

Every asynchronous spellchecking layout test waits for spelling or grammar
markers using setTimeout. It duplicates the code, moreover the implementation
differs in every test.

Use shouldBecomeEqual helper (introduced in r143860) to test spellchecking
asynchronously.

* editing/spelling/grammar-markers-expected.txt:
* editing/spelling/grammar-markers-hidpi-expected.txt:
* editing/spelling/grammar-markers-hidpi.html:
* editing/spelling/grammar-markers.html:

* editing/spelling/grammar-paste-expected.txt:
* editing/spelling/grammar-paste.html:
Dump text of destination element instead of source one to show what is
really tested. It stops outputting that the input and textarea elements
can store html tags, for example,
PASS INPUT has a marker on 'I have a<b>n ki</b>wi'.

* editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
(pasteAndVerify):

* editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
* editing/spelling/spellcheck-paste-continuous-disabled.html:
* editing/spelling/spellcheck-paste-disabled-expected.txt:
* editing/spelling/spellcheck-paste-disabled.html:
At the beginning, those tests check whether spelling marker appears
synchronously. Then, spell checking is disabled to check whether
the markers have disappeared properly.
There is no need to check spelling asynchronously in the second part
of the tests. Use synchronous spellchecking path instead.

* editing/spelling/spellcheck-paste-expected.txt:
* editing/spelling/spelling-marker-description-expected.txt:
* editing/spelling/spelling-marker-description.html:
* platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
* platform/mac/editing/spelling/grammar-markers-expected.png:
* platform/mac/editing/spelling/grammar-markers-hidpi-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r156120.
bfulgham@apple.com [Fri, 20 Sep 2013 02:05:21 +0000 (02:05 +0000)]
Unreviewed, rolling out r156120.
http://trac.webkit.org/changeset/156120
https://bugs.webkit.org/show_bug.cgi?id=121651

Broke windows runtime and all tests (Requested by bfulgham on
#webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-19

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
* dfg/DFGAssemblyHelpers.cpp: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.cpp.
(JSC::DFG::AssemblyHelpers::executableFor):
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
* dfg/DFGAssemblyHelpers.h: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.h.
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::codeBlock):
(JSC::DFG::AssemblyHelpers::vm):
(JSC::DFG::AssemblyHelpers::assembler):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::branchIfNotCell):
(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):
(JSC::DFG::AssemblyHelpers::branchIfNotObject):
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
(JSC::DFG::AssemblyHelpers::boxInt52):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::globalObjectFor):
(JSC::DFG::AssemblyHelpers::strictModeFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(JSC::DFG::AssemblyHelpers::offsetOfLocals):
(JSC::DFG::AssemblyHelpers::offsetOfArgumentsIncludingThis):
* dfg/DFGBinarySwitch.h:
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGCCallHelpers.h: Renamed from Source/JavaScriptCore/jit/CCallHelpers.h.
(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
(JSC::DFG::CCallHelpers::setupResults):
* dfg/DFGDisassembler.cpp:
* dfg/DFGFPRInfo.h: Renamed from Source/JavaScriptCore/jit/FPRInfo.h.
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::toArgumentRegister):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h: Renamed from Source/JavaScriptCore/jit/GPRInfo.h.
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::payloadOnly):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
(JSC::DFG::GPRInfo::toArgumentRegister):
* dfg/DFGGraph.cpp:
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp:
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompilerCommon.h:
* dfg/DFGRegisterBank.h:
* dfg/DFGRegisterSet.h:
* dfg/DFGRepatch.cpp:
* dfg/DFGSilentRegisterSavePlan.h:
* dfg/DFGThunks.cpp:
* dfg/DFGVariableEvent.cpp:
* ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
* ftl/FTLCompile.cpp:
* ftl/FTLExitThunkGenerator.h:
* ftl/FTLLink.cpp:
* ftl/FTLThunks.cpp:
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::preserveReturnAddressAfterCall):
(JSC::JSInterfaceJIT::restoreReturnAddressBeforeReturn):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
* runtime/JSCJSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: update MediaStreamTrackEvent object to match spec
eric.carlson@apple.com [Fri, 20 Sep 2013 01:51:01 +0000 (01:51 +0000)]
MediaStream API: update MediaStreamTrackEvent object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121624

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/mediastream/MediaStreamTrackEvent-constructor.html

* Modules/mediastream/MediaStreamTrack.idl: Remove NoInterfaceObject.

* Modules/mediastream/MediaStreamTrackEvent.cpp:
(WebCore::MediaStreamTrackEventInit::MediaStreamTrackEventInit): New.
(WebCore::MediaStreamTrackEvent::create): New form that takes an initialize.
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent): Ditto.
* Modules/mediastream/MediaStreamTrackEvent.h:
* Modules/mediastream/MediaStreamTrackEvent.idl:

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): New.
* bindings/js/JSDictionary.h:

LayoutTests:

* fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt: Added.
* fast/mediastream/MediaStreamTrackEvent-constructor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
commit-queue@webkit.org [Fri, 20 Sep 2013 01:41:20 +0000 (01:41 +0000)]
ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
https://bugs.webkit.org/show_bug.cgi?id=121650

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-19
Reviewed by Benjamin Poulain.

* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove #if !ENABLE(WORKERS) code in ThreadGlobalData
andersca@apple.com [Fri, 20 Sep 2013 01:10:03 +0000 (01:10 +0000)]
Remove #if !ENABLE(WORKERS) code in ThreadGlobalData
https://bugs.webkit.org/show_bug.cgi?id=121649

Reviewed by Sam Weinig.

This lets us remove a FIXME. Also, move threadGlobalData out of line; there's no need for it to be inline.

* WebCore.exp.in:
* platform/ThreadGlobalData.cpp:
(WebCore::threadGlobalData):
* platform/ThreadGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoModernize Length setters/getters
andersca@apple.com [Fri, 20 Sep 2013 01:00:19 +0000 (01:00 +0000)]
Modernize Length setters/getters
https://bugs.webkit.org/show_bug.cgi?id=121647

Reviewed by Andreas Kling.

Add a move constructor and move assignment operator to Length and fixup some of the getters and setters.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyLineHeight::createHandler):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::LengthPropertyWrapper::LengthPropertyWrapper):
(WebCore::LengthPropertyWrapper::blend):
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper):
(WebCore::FillLayerPropertyWrapper::blend):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* platform/CalculationValue.h:
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
* platform/Length.cpp:
(WebCore::CalculationValueHandleMap::remove):
(WebCore::CalculationValueHandleMap::find):
(WebCore::Length::decrementCalculatedRef):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::moveFromLength):
* platform/LengthBox.cpp:
(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
(WebCore::LengthBox::start):
(WebCore::LengthBox::end):
* platform/LengthBox.h:
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::left):
(WebCore::LengthBox::right):
(WebCore::LengthBox::top):
(WebCore::LengthBox::bottom):
* platform/LengthSize.h:
(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::width):
(WebCore::LengthSize::setHeight):
(WebCore::LengthSize::height):
* platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::BlurFilterOperation::create):
(WebCore::FilterOperation::BlurFilterOperation::stdDeviation):
(WebCore::FilterOperation::BlurFilterOperation::BlurFilterOperation):
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::x):
(WebCore::BasicShapeRectangle::y):
(WebCore::BasicShapeRectangle::width):
(WebCore::BasicShapeRectangle::height):
(WebCore::BasicShapeRectangle::cornerRadiusX):
(WebCore::BasicShapeRectangle::cornerRadiusY):
(WebCore::BasicShapeRectangle::setX):
(WebCore::BasicShapeRectangle::setY):
(WebCore::BasicShapeRectangle::setWidth):
(WebCore::BasicShapeRectangle::setHeight):
(WebCore::BasicShapeRectangle::setCornerRadiusX):
(WebCore::BasicShapeRectangle::setCornerRadiusY):
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapePolygon::getXAt):
(WebCore::BasicShapePolygon::getYAt):
(WebCore::BasicShapePolygon::appendPoint):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):
* rendering/style/FillLayer.h:
(WebCore::FillSize::FillSize):
(WebCore::FillLayer::xPosition):
(WebCore::FillLayer::yPosition):
(WebCore::FillLayer::sizeLength):
(WebCore::FillLayer::setXPosition):
(WebCore::FillLayer::setYPosition):
* rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::NinePieceImage):
* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::computeOutset):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::specifiedLineHeight):
* rendering/style/RenderStyle.h:
* rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):
* rendering/style/StyleReflection.h:
(WebCore::StyleReflection::offset):
(WebCore::StyleReflection::setOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOut-of-line InspectorValues create() methods.
akling@apple.com [Fri, 20 Sep 2013 00:22:53 +0000 (00:22 +0000)]
Out-of-line InspectorValues create() methods.
<https://webkit.org/b/121639>

Reviewed by Joseph Pecoraro.

These functions are hardly performance-critical and are taking up
quite a lot of space.

Shrinks the WebCore binary by 70500 bytes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is...
ap@apple.com [Thu, 19 Sep 2013 23:19:56 +0000 (23:19 +0000)]
Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121458

Reviewed by Sam Weinig.

Source/WebCore:

The code to automagically produce line numbers is quite fragile. Added some FIXMEs,
and added an issue that was making reporting flaky for code is JS event handlers
executed while parsing was paused.

* page/PageConsole.cpp: (WebCore::PageConsole::addMessage): Use actual "script is
running" check instead of "parsing a script element" one.

LayoutTests:

* fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
* fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
* fast/frames/sandboxed-iframe-scripting-04-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
* http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
* media/video-controls-no-scripting-expected.txt:
We now get a line number for blocked inline scripts, which is a progression.
It is the line number for the closing </script>, which is not ideal, but better
than nothing.

* http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
* http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
Also a progression - we now get a line number for offending <script>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[iOS] Define mainThreadEstablishedAsPthreadMain to be true in WTF::initializeMainThre...
dbates@webkit.org [Thu, 19 Sep 2013 23:15:50 +0000 (23:15 +0000)]
[iOS] Define mainThreadEstablishedAsPthreadMain to be true in WTF::initializeMainThreadPlatform()

Reviewed by Joseph Pecoraro.

This change was inadvertently left out of <http://trac.webkit.org/changeset/155926>.

* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove OwnArrayPtr
weinig@apple.com [Thu, 19 Sep 2013 23:03:44 +0000 (23:03 +0000)]
Remove OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=121612

Reviewed by Anders Carlsson.

* GNUmakefile.list.am:
* WTF.pro:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
* wtf/Assertions.cpp:
* wtf/CMakeLists.txt:
* wtf/DateMath.h:
* wtf/FastBitVector.h:
* wtf/Forward.h:
* wtf/OwnArrayPtr.h: Removed.
* wtf/VectorTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSubstitute return type void for bool in function declaration for WTF::initializeWebTh...
dbates@webkit.org [Thu, 19 Sep 2013 23:02:38 +0000 (23:02 +0000)]
Substitute return type void for bool in function declaration for WTF::initializeWebThread()

Reviewed by Joseph Pecoraro.

Make the declaration of WTF::initializeWebThread() match the function prototype
of its definition.

* wtf/MainThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix Windows build part 2. m_jitCodeMap should always be there.
fpizlo@apple.com [Thu, 19 Sep 2013 22:42:35 +0000 (22:42 +0000)]
Unreviewed, fix Windows build part 2. m_jitCodeMap should always be there.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCodeMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction...
rniwa@webkit.org [Thu, 19 Sep 2013 22:38:24 +0000 (22:38 +0000)]
Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
https://bugs.webkit.org/show_bug.cgi?id=121589

Reviewed by Dean Jackson.

Replaced CSSLinearTimingFunctionValue by the identifier "linear" and used switch statements on
TimingFunction::type() in more places where we were branching on every type.

Merge https://chromium.googlesource.com/chromium/blink/+/5454f20c71090c35bdd1053e5cc572d5c0bdede7
Merge https://chromium.googlesource.com/chromium/blink/+/104ad42c523d32b67d108c6e59f4f27488fe38a5

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
* css/CSSTimingFunctionValue.cpp:
* css/CSSTimingFunctionValue.h:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isCubicBezierTimingFunctionValue):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some of the tautologies in DFGRepatch function naming.
fpizlo@apple.com [Thu, 19 Sep 2013 22:27:50 +0000 (22:27 +0000)]
Remove some of the tautologies in DFGRepatch function naming.

Rubber stamped by Mark Hahnenberg.

For example change DFG::dfgLinkFor() to be DFG::linkFor().

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
* dfg/DFGOperations.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::repatchIn):
(JSC::DFG::linkFor):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
* dfg/DFGRepatch.h:
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix Windows build. ScratchBuffer should always be available regardless of
fpizlo@apple.com [Thu, 19 Sep 2013 22:23:39 +0000 (22:23 +0000)]
Unreviewed, fix Windows build. ScratchBuffer should always be available regardless of
ENABLE_DFG_JIT.

* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[iOS] Add more iOS logic to the JavaScriptCore build configuration files
dbates@webkit.org [Thu, 19 Sep 2013 22:16:16 +0000 (22:16 +0000)]
[iOS] Add more iOS logic to the JavaScriptCore build configuration files
https://bugs.webkit.org/show_bug.cgi?id=121635

Reviewed by Geoffrey Garen.

Towards building JavaScriptCore for both OS X and iOS using the same
set of configuration files, add more iOS logic.

* Configurations/Base.xcconfig:
* Configurations/JSC.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* Configurations/ToolExecutable.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r156119.
commit-queue@webkit.org [Thu, 19 Sep 2013 22:12:26 +0000 (22:12 +0000)]
Unreviewed, rolling out r156119.
http://trac.webkit.org/changeset/156119
https://bugs.webkit.org/show_bug.cgi?id=121640

broke builds in various ways (Requested by anttik on #webkit).

* accessibility/AccessibilitySpinButton.cpp:
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* css/SelectorChecker.cpp:
* dom/ContainerNode.h:
* dom/Element.h:
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
* editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::doApply):
* editing/TypingCommand.cpp:
* html/ImageDocument.cpp:
* page/PageSerializer.cpp:
* rendering/RenderElement.h:
* rendering/RenderObject.h:
* svg/SVGAnimatedColor.cpp:
(WebCore::adjustForCurrentColor):
* svg/SVGLocatable.cpp:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
* svg/graphics/filters/SVGFEImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
fpizlo@apple.com [Thu, 19 Sep 2013 22:10:26 +0000 (22:10 +0000)]
Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
* dfg/DFGAssemblyHelpers.cpp: Removed.
* dfg/DFGAssemblyHelpers.h: Removed.
* dfg/DFGBinarySwitch.h:
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGCCallHelpers.h: Removed.
* dfg/DFGDisassembler.cpp:
* dfg/DFGFPRInfo.h: Removed.
* dfg/DFGGPRInfo.h: Removed.
* dfg/DFGGraph.cpp:
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp:
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompilerCommon.h:
* dfg/DFGRegisterBank.h:
* dfg/DFGRegisterSet.h:
* dfg/DFGRepatch.cpp:
* dfg/DFGSilentRegisterSavePlan.h:
* dfg/DFGThunks.cpp:
* dfg/DFGVariableEvent.cpp:
* ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
* ftl/FTLCompile.cpp:
* ftl/FTLExitThunkGenerator.h:
* ftl/FTLLink.cpp:
* ftl/FTLThunks.cpp:
* jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
* jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.
(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):
* jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
* jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.
(WTF::printInternal):
* jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.
(WTF::printInternal):
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
* llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
* runtime/JSCJSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd covariant RenderElement* Element::renderer()
antti@apple.com [Thu, 19 Sep 2013 22:03:01 +0000 (22:03 +0000)]
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStreamline JSMainThreadNullState.
akling@apple.com [Thu, 19 Sep 2013 21:42:44 +0000 (21:42 +0000)]
Streamline JSMainThreadNullState.
<https://webkit.org/b/121636>

Reviewed by Anders Carlsson.

JSMainThreadNullState is only used by non-JavaScript bindings and
thus won't ever call didLeaveScriptContext() on destruction.
Specialize the class for its use-case instead of sharing code
with JSMainThreadExecState.

Shrinks the WebCore binary by 82848 bytes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssume allocator success in Vector unless using try* functions.
akling@apple.com [Thu, 19 Sep 2013 21:40:20 +0000 (21:40 +0000)]
Assume allocator success in Vector unless using try* functions.
<https://webkit.org/b/121629>

Reviewed by Anders Carlsson.

Turn some Vector::begin() null checking into assertions instead.

We have try* style functions for when an allocation request is so
large that it might actually fail. fastMalloc() will never return
null (it will just CRASH() instead.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS_SHAPES not supported on AppleWin port
betravis@adobe.com [Thu, 19 Sep 2013 21:27:32 +0000 (21:27 +0000)]
CSS_SHAPES not supported on AppleWin port
https://bugs.webkit.org/show_bug.cgi?id=118810

Enabling CSS Shapes on Windows port

Reviewed by Brent Fulgham.

* LayoutTests/Changelog
* LayoutTEsts/platform/win/TestExpectations
* Source/WebCore/ChangeLog
* Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
* Source/WebCore/WebCore.vcxproj/WebCoreCommon.props
* Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
* Source/WebCore/css/CSSPropertyNames.in
* Source/WebKit/ChangeLog
* Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
* WebKitLibraries/ChangeLog
* WebKitLibraries/win/tools/vsprops/FeatureDefines.props
* WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempted build fix after r156114.
mitz@apple.com [Thu, 19 Sep 2013 21:06:13 +0000 (21:06 +0000)]
Attempted build fix after r156114.

* Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved WebCoreSQLite3. It has been unused for years.
mitz@apple.com [Thu, 19 Sep 2013 20:46:08 +0000 (20:46 +0000)]
Removed WebCoreSQLite3. It has been unused for years.

Rubber-stamped by Mark Rowe.

* WebCoreSQLite3: Removed.
* WebCoreSQLite3/sqlite3.h: Removed.
* WebCoreSQLite3/sqlite3ext.h: Removed.
* libWebCoreSQLite3.a: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()
dbates@webkit.org [Thu, 19 Sep 2013 20:29:33 +0000 (20:29 +0000)]
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()
dbates@webkit.org [Thu, 19 Sep 2013 20:27:30 +0000 (20:27 +0000)]
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
msaboff@apple.com [Thu, 19 Sep 2013 20:07:25 +0000 (20:07 +0000)]
JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
https://bugs.webkit.org/show_bug.cgi?id=121625

Rubber-stamped by Filip Pizlo.

Chenged 16, 32 and 64 bit offsets to be signed.  Kept the original tab indented
spacing to match the rest of the file.

* disassembler/udis86/udis86_syn-att.c:
(gen_operand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd SVGPropertyInfo.cpp
akling@apple.com [Thu, 19 Sep 2013 19:54:19 +0000 (19:54 +0000)]
Add SVGPropertyInfo.cpp
<https://webkit.org/b/121622>

Reviewed by Anders Carlsson.

Add a cpp file for this class to make it more hackable.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* svg/properties/SVGPropertyInfo.cpp: Added.
(WebCore::SVGPropertyInfo::SVGPropertyInfo):
* svg/properties/SVGPropertyInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r129451): run-safari --no-saved-state is broken
ap@apple.com [Thu, 19 Sep 2013 19:22:41 +0000 (19:22 +0000)]
REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566

Undo a last minute change that doesn't actually work.

* Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
via command line, <rdar://problem/15032886>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: update NavigatorUserMediaError object to match spec
eric.carlson@apple.com [Thu, 19 Sep 2013 19:06:54 +0000 (19:06 +0000)]
MediaStream API: update NavigatorUserMediaError object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121584

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, updated getusermedia.html.

* CMakeLists.txt: Add NavigatorUserMediaError.cpp.
* GNUmakefile.list.am: Ditto.

* Modules/mediastream/NavigatorUserMediaError.cpp: Added.
* Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
* Modules/mediastream/NavigatorUserMediaError.idl: Ditto.

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
(WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
(WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
(WebCore::UserMediaRequest::videoConstraints): Ditto.
(WebCore::UserMediaRequest::ownerDocument): Clean up style.
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
(WebCore::UserMediaRequest::constraintFailure):  Renamed from failConstraint.
(WebCore::UserMediaRequest::callSuccessHandler): New.
(WebCore::UserMediaRequest::callErrorHandler): New.
* Modules/mediastream/UserMediaRequest.h:

* WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp

* dom/DOMError.h: Make constructor protected.

* platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.

LayoutTests:

* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/getusermedia.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
zoltan@webkit.org [Thu, 19 Sep 2013 18:49:05 +0000 (18:49 +0000)]
[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
https://bugs.webkit.org/show_bug.cgi?id=121621

Reviewed by Andreas Kling.

* fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix handling of top margin on float with shape-outside
bjonesbe@adobe.com [Thu, 19 Sep 2013 18:18:39 +0000 (18:18 +0000)]
Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614

Reviewed by Alexandru Chiculita.

Source/WebCore:

When a float has shape outside, the top margin should be treated as if
there is no shape there, so inline content should be allowed to flow
into that space. This patch fixes two issues:

1) If the top margin is the same as the line height, a line should be
able to fit into the margin. Before this patch, that line was being
treated as if it intersected with the shape.

2) The shape should be positioned (x, y) relative to the box sizing
box of the float. While the x coordinate was being treated properly,
the y coordinate was relative to the top of the margin box. This patch
fixes this behavior.

This patch also includes a simple test for right and left margins, as
I wrote that test and then discovered the problems listed above.

This patch also removes an unused override of the
lineOverlapsShapeBounds method.

Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html

* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
* rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/shapes/ShapeInfo.h:
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
* rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.
    Test for a positive left/right margin.

* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.
    Test for a positive top margin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a style guideline regarding spacing in range-based for loops
mitz@apple.com [Thu, 19 Sep 2013 18:13:19 +0000 (18:13 +0000)]
Add a style guideline regarding spacing in range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=121620

Reviewed by Anders Carlsson.

Tools:

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing): Added checking that there are spaces around the colon in a range-based for
loop.
(CppChecker): Added whitespace/colon to the categories set.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_spacing): Added two tests for the new check.

Websites/webkit.org:

* coding/coding-style.html: Added the guideline that spaces should be placed
around the colon in a range-based for loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
rniwa@webkit.org [Thu, 19 Sep 2013 17:57:47 +0000 (17:57 +0000)]
DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
https://bugs.webkit.org/show_bug.cgi?id=121597

Reviewed by Anders Carlsson.

Fixed indentations.

* DoYouEvenBench/benchmark.html:
* DoYouEvenBench/benchmark.js:
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._finalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd XHR tests checking readyState transition when abort() is invoked in various states
rniwa@webkit.org [Thu, 19 Sep 2013 17:57:24 +0000 (17:57 +0000)]
Add XHR tests checking readyState transition when abort() is invoked in various states
https://bugs.webkit.org/show_bug.cgi?id=121585

Reviewed by Alexey Proskuryakov.

Merge https://chromium.googlesource.com/chromium/blink/+/2d854757576db590745cfb78e11ca428a1aac342

* http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
* http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd RenderElement
antti@apple.com [Thu, 19 Sep 2013 17:52:38 +0000 (17:52 +0000)]
Add RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121608

Reviewed by Dave Hyatt.

Add a common base class for all Element renderers. The class hierarchy will now look like this

RenderObject
    RenderText
    RenderElement
        RenderLayerModelObject
            ...
        RenderSVGModelObject
            ...
        RenderSVGGradientStop

This will allow tighter typing in both render and DOM trees.

The patch also moves renderer factory function to RenderElement::createFor().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoKeep chasing the definition of QAccessibleWidget
allan.jensen@digia.com [Thu, 19 Sep 2013 17:36:03 +0000 (17:36 +0000)]
Keep chasing the definition of QAccessibleWidget
https://bugs.webkit.org/show_bug.cgi?id=121611

Reviewed by Jocelyn Turcotte.

* WidgetApi/qwebviewaccessible_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
weinig@apple.com [Thu, 19 Sep 2013 16:06:06 +0000 (16:06 +0000)]
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
https://bugs.webkit.org/show_bug.cgi?id=121588

Reviewed by Anders Carlsson.

* DumpRenderTree/TestRunner.cpp:
* ImageDiff/efl/ImageDiff.cpp:
* TestWebKitAPI/JavaScriptTest.cpp:
* TestWebKitAPI/PlatformUtilities.cpp:
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
* WebKitTestRunner/StringFunctions.h:
* WebKitTestRunner/TestInvocation.cpp:
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r149928): CanvasStyle::operator= leaks everything
ap@apple.com [Thu, 19 Sep 2013 16:00:36 +0000 (16:00 +0000)]
REGRESSION (r149928): CanvasStyle::operator= leaks everything
https://bugs.webkit.org/show_bug.cgi?id=121591

Reviewed by Andreas Kling.

* html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix typo in layout test description introduced in r155974.
rego@igalia.com [Thu, 19 Sep 2013 15:11:52 +0000 (15:11 +0000)]
Unreviewed. Fix typo in layout test description introduced in r155974.

* fast/regions/selection-direction-expected.html:
* fast/regions/selection-direction.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Masking/Background] Position property should be ignored when using repeat: space
commit-queue@webkit.org [Thu, 19 Sep 2013 14:41:36 +0000 (14:41 +0000)]
[CSS Masking/Background] Position property should be ignored when using repeat: space
https://bugs.webkit.org/show_bug.cgi?id=120623

Source/WebCore:

The background/mask-position should be ignored when using repeat: space,
unless there is not enough space for two copies of the image. In that case,
only one image is placed and background/mask-position determines its position.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

Test: css3/masking/mask-repeat-one-copy.html

* rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

* css3/masking/mask-repeat-one-copy-expected.html:
* css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
* css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
m.pakula@samsung.com [Thu, 19 Sep 2013 14:39:56 +0000 (14:39 +0000)]
Unreviewed EFL gardening.

Unskip tests added to platform/efl/Skipped, which now are passing.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156096 268f45cc-cd09-0410-ab3c-d52691b4dbfc