WebKit-https.git
9 years agoSwitch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
commit-queue@webkit.org [Tue, 13 Mar 2012 06:42:41 +0000 (06:42 +0000)]
Switch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=80935

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Kent Tamura.

ICU seems to have issues with non-well-formed locale strings.
Currently, the only port that uses LocaleToScriptMappingICU.cpp is
Chromium.

No new tests. LocaleToScriptMappingDefault.cpp is already used by
other ports and covered by existing tests.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test cases for RegExp multiline
commit-queue@webkit.org [Tue, 13 Mar 2012 06:15:58 +0000 (06:15 +0000)]
Fix test cases for RegExp multiline
https://bugs.webkit.org/show_bug.cgi?id=80822

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

* tests/mozilla/js1_2/regexp/RegExp_multiline.js:
* tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js:
* tests/mozilla/js1_2/regexp/beginLine.js:
* tests/mozilla/js1_2/regexp/endLine.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix IndexedDB build with JSC
commit-queue@webkit.org [Tue, 13 Mar 2012 05:38:59 +0000 (05:38 +0000)]
Fix IndexedDB build with JSC
https://bugs.webkit.org/show_bug.cgi?id=80207

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-12
Reviewed by Adam Barth.

This fixes the build of WebKit when IndexedDB is enabled. Most functions were added
empty implementation, it compiles but IndexedDB is not working.

* DerivedSources.make: Added missing IDL files.
* Modules/indexeddb/IDBDatabaseBackendImpl.h: Fix warnings and build errors.
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: ditto.
(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase): ditto.
* Modules/indexeddb/IDBFactoryBackendImpl.cpp: ditto.
(WebCore::IDBFactoryBackendImpl::openBackingStore):
* Modules/indexeddb/IDBIndexBackendImpl.cpp: ditto.
(WebCore::IDBIndexBackendImpl::countInternal):
* Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Fix the method signature and add
an empty implementation.
(WebCore):
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Fix warnings.
(WebCore::IDBObjectStoreBackendImpl::countInternal):
* Modules/indexeddb/IDBPendingTransactionMonitor.cpp: ditto.
(WebCore::transactions):
* Modules/indexeddb/IDBRequest.cpp: ditto.
(WebCore::IDBRequest::resetReadyState):
* Modules/indexeddb/IDBRequest.h: ditto.
(WebCore::IDBRequest::onSuccessWithPrefetch):
(WebCore):
(WebCore::JSIDBVersionChangeRequest::visitChildren):
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue): Fix the creation of IDBKeys.
(WebCore::createOptionsObjectFromValue): Add an empty implementation of
the handling of database options (IDBObjectStoreParameters).
(WebCore):
* bindings/js/IDBBindingUtilities.h:
(WebCore):
* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS): Add the missing IDBAny's types.
* bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS): Add the missing IDBKey's types.
* bindings/js/JSIDBVersionChangeRequestCustom.cpp: Added.
IDBVersionChangeRequest has the attribute EventTarget so it requires
the visitChildren() function. An empty implementation was added.
* bindings/js/OptionsObject.h: Add an empty implementation.
(WebCore):
(OptionsObject):
(WebCore::OptionsObject::OptionsObject):
(WebCore::OptionsObject::isObject):
(WebCore::OptionsObject::isUndefinedOrNull):
(WebCore::OptionsObject::get):
(WebCore::OptionsObject::getWithUndefinedOrNullCheck):
* bindings/js/SerializedScriptValue.cpp: Add the missing functions needed by IndexedDB.
(WebCore):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):
* bindings/js/SerializedScriptValue.h:
(SerializedScriptValue):
* bindings/scripts/CodeGeneratorJS.pm: Modify the code generator to:
-Support the IDBKey type correctly.
-Support the OptionsObject type.
-Generate valid function call for static functions.
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r110529.
morrita@google.com [Tue, 13 Mar 2012 05:36:39 +0000 (05:36 +0000)]
Unreviewed, rolling out r110529.
http://trac.webkit.org/changeset/110529
https://bugs.webkit.org/show_bug.cgi?id=80969

breaks mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r110524.
morrita@google.com [Tue, 13 Mar 2012 05:03:08 +0000 (05:03 +0000)]
Unreviewed, rolling out r110524.
http://trac.webkit.org/changeset/110524
https://bugs.webkit.org/show_bug.cgi?id=80936

breaks chromium win build. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.idl:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
haraken@chromium.org [Tue, 13 Mar 2012 04:20:00 +0000 (04:20 +0000)]
[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=80924

Reviewed by Adam Barth.

getCachedWrapperSlow() is called by getCachedWrapper() only,
and getCachedWrapperSlow() just calls getCachedWrapperInline().
Thus, this patch expands getCachedWrapperInline() into getCachedWrapper(),
and removes getCachedWrapperSlow().

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8][Refactoring] Remove existingWrapper() from generated code
haraken@chromium.org [Tue, 13 Mar 2012 04:03:27 +0000 (04:03 +0000)]
[V8][Refactoring] Remove existingWrapper() from generated code
https://bugs.webkit.org/show_bug.cgi?id=80927

Reviewed by Adam Barth.

Currently wrap() calls existingWrapper(), and existingWrapper()
just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.

Test: bindings/scripts/test/*

* bindings/scripts/CodeGeneratorV8.pm: Removed existingWrapper().
(GenerateHeader):
(GenerateNormalAttrGetter):

* bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use tileRect instead of pointer derefs
commit-queue@webkit.org [Tue, 13 Mar 2012 03:33:31 +0000 (03:33 +0000)]
[chromium] Use tileRect instead of pointer derefs
https://bugs.webkit.org/show_bug.cgi?id=80919

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTileQuad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit-patch optimize-baselines sometimes creates a mac-future result
ojan@chromium.org [Tue, 13 Mar 2012 03:14:20 +0000 (03:14 +0000)]
webkit-patch optimize-baselines sometimes creates a mac-future result
https://bugs.webkit.org/show_bug.cgi?id=80717

Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(_baseline_search_hypergraph):
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._filter_virtual_ports):
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_no_add_mac_future):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG should support transform-origin and relative values
commit-queue@webkit.org [Tue, 13 Mar 2012 02:45:38 +0000 (02:45 +0000)]
SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Patch by Hans Muller <hmuller@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

Source/WebCore:

Added SVG support for the CSS 'transform-origin' property and for percentage
values in the transform translate function.  The changes conform to
http://dev.w3.org/csswg/css3-transforms/.

Tests: svg/transforms/percent-transform-values.xhtml
       svg/transforms/transform-origin-css-property.xhtml

* css/svg.css:
(*):
(html|* > svg):
Default transform-origin for SVG elements is 0 0.

* platform/Length.h:
(WebCore::Length::calcFloatValue):
Added a calcFloatValue overload whose max parameter (for percent lengths) is a float.
The original version will be obsolete when the sub-pixel layout support is completed.

* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
(WebCore):
(WebCore::requireTransformOrigin):
Transforms that only include translations don't depend on the transform-origin.

(WebCore::RenderStyle::applyTransform):
SVG elements interpret non-percentage/keyword transform-origin values relative to their viewport,
unlike HTML which interprets all transform-origin values relative to the element's origin.
The new FloatRect applyTransform() function handles SVG semantics. Similarly, SVG elements interpret
percentage/keyword transform-origin values relative to the origin of their objectBoundingBox(), HTML
uses the borderBox.  All this per http://dev.w3.org/csswg/css3-transforms/.

* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

LayoutTests:

Added tests for SVG CSS transform-origin property support and for
CSS translations specified with percentages and applied to an SVG element.

* svg/transforms/change-transform-origin-css-expected.xhtml: Added.
* svg/transforms/change-transform-origin-css.xhtml: Added.
* svg/transforms/change-transform-origin-presentation-attribute-expected.xhtml: Added.
* svg/transforms/change-transform-origin-presentation-attribute.xhtml: Added.
* svg/transforms/percent-transform-values-expected.txt: Added.
* svg/transforms/percent-transform-values.xhtml: Added.
* svg/transforms/transform-origin-css-property-expected.xhtml: Added.
* svg/transforms/transform-origin-css-property.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Windows build fix.
morrita@google.com [Tue, 13 Mar 2012 02:42:47 +0000 (02:42 +0000)]
Unreviewed Windows build fix.

* src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
weinig@apple.com [Tue, 13 Mar 2012 02:29:12 +0000 (02:29 +0000)]
Fix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
https://bugs.webkit.org/show_bug.cgi?id=80925

Reviewed by Maciej Stachowiak.

* fast/events/input-element-display-none-in-dragleave-crash.html:
Add call to eventSender.mouseUp().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use projectQuad to apply inverse mapRect
commit-queue@webkit.org [Tue, 13 Mar 2012 02:27:21 +0000 (02:27 +0000)]
[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform
           CCOcclusionTrackerTestPerspectiveTransform
           CCOcclusionTrackerTestPerspectiveTransformBehindCamera

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
leo.yang@torchmobile.com.cn [Tue, 13 Mar 2012 02:17:32 +0000 (02:17 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=80820

Reviewed by Rob Buis.

The BlackBerry is using the FontPlatformData from Chromium porting.

* platform/graphics/FontPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Windows build fixing.
jberlin@webkit.org [Tue, 13 Mar 2012 01:58:27 +0000 (01:58 +0000)]
More Windows build fixing.

* DumpRenderTree/win/WorkQueueItemWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAfter webgl canvas resize, bindings might be lost
zmo@google.com [Tue, 13 Mar 2012 01:52:59 +0000 (01:52 +0000)]
After webgl canvas resize, bindings might be lost
https://bugs.webkit.org/show_bug.cgi?id=80895

Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/webgl/texture-bindings-uneffected-on-resize.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::reshape): recover bindings after reshape.

LayoutTests:

* fast/canvas/webgl/texture-bindings-uneffected-on-resize-expected.txt: Added.
* fast/canvas/webgl/texture-bindings-uneffected-on-resize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
haraken@chromium.org [Tue, 13 Mar 2012 01:38:54 +0000 (01:38 +0000)]
[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
https://bugs.webkit.org/show_bug.cgi?id=80920

Reviewed by Adam Barth.

Now getWrapper() is the same as getExistingWrapper().
getWrapperSlow() is the same as getExistingWrapperSlow().
This patch removes getWrapper() and getWrapperSlow().
Also this patch renames getExistingWrapper() to getCachedWrapper().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getWrapperSlow):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getWrapper):
(V8DOMWrapper):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
arv@chromium.org [Tue, 13 Mar 2012 01:37:07 +0000 (01:37 +0000)]
[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8).

No new tests. Covered by existing tests.

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.idl:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Windows build fixing.
jberlin@webkit.org [Tue, 13 Mar 2012 01:31:25 +0000 (01:31 +0000)]
More Windows build fixing.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
* DumpRenderTree/win/EditingDelegate.cpp:
* DumpRenderTree/win/EventSender.cpp:
* DumpRenderTree/win/FrameLoadDelegate.cpp:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/win/UIDelegate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove obsolete 'CPU' modifier.
dpranke@chromium.org [Tue, 13 Mar 2012 01:29:50 +0000 (01:29 +0000)]
Remove obsolete 'CPU' modifier.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObject.defineProperty doesn't respect attributes when applied to the Global Object
barraclough@apple.com [Tue, 13 Mar 2012 01:16:08 +0000 (01:16 +0000)]
Object.defineProperty doesn't respect attributes when applied to the Global Object
https://bugs.webkit.org/show_bug.cgi?id=38636
Object.defineProperty doesn't create property on Global Object in the presence of a setter in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=48911

Rubber stamped by Michael Saboff.

* fast/js/Object-defineProperty-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
    - Added test cases for bugs #38636 & #48911.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Windows build fixing.
jberlin@webkit.org [Tue, 13 Mar 2012 01:13:57 +0000 (01:13 +0000)]
More Windows build fixing.

* MarshallingHelpers.cpp:
* WebDatabaseManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
haraken@chromium.org [Tue, 13 Mar 2012 01:10:21 +0000 (01:10 +0000)]
[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
https://bugs.webkit.org/show_bug.cgi?id=80916

Reviewed by Adam Barth.

This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getWrapperSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoArithmetic use inference should be procedure-global and should run in tandem
fpizlo@apple.com [Tue, 13 Mar 2012 01:05:54 +0000 (01:05 +0000)]
Arithmetic use inference should be procedure-global and should run in tandem
with type propagation
https://bugs.webkit.org/show_bug.cgi?id=80819
<rdar://problem/11034006>

Reviewed by Gavin Barraclough.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGArithNodeFlagsInferencePhase.cpp: Removed.
* dfg/DFGArithNodeFlagsInferencePhase.h: Removed.
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::flags):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove obsolete chromium-gpu-* platform directories for LayoutTests baselines.
dpranke@chromium.org [Tue, 13 Mar 2012 01:02:59 +0000 (01:02 +0000)]
Remove obsolete chromium-gpu-* platform directories for LayoutTests baselines.

Unreviewed, baselines change.

All of the baselines are now in platform/chromium-*/platform/chromium/virtual/gpu/*.

* platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Removed.
* platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Removed.
* platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Removed.
* platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Removed.
* platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Removed.
* platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Removed.
* platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
* platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
* platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Removed.
* platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-no-audio-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-transformed-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-zoom-expected.png: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
* platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-as-image-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-bg-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-bg-zoom-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-transform-skewed-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/image-pattern-rotate-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/patternfill-repeat-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Removed.
* platform/chromium-gpu-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-no-audio-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-transformed-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-zoom-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
* platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Removed.
* platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Removed.
* platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Removed.
* platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Removed.
* platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-win/media/video-display-toggle-expected.png: Removed.
* platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Removed.
* platform/chromium-gpu-win/media/video-layer-crash-expected.png: Removed.
* platform/chromium-gpu-win/media/video-no-audio-expected.png: Removed.
* platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Removed.
* platform/chromium-gpu-win/media/video-transformed-expected.png: Removed.
* platform/chromium-gpu-win/media/video-volume-slider-expected.png: Removed.
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-gpu-win/media/video-zoom-expected.png: Removed.
* platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Removed.
* platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Removed.
* platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoremove the 'gpu' group from the flakiness dashboard
dpranke@chromium.org [Tue, 13 Mar 2012 00:55:56 +0000 (00:55 +0000)]
remove the 'gpu' group from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80353

Reviewed by Adam Barth.

Since those bots are obsolete, we don't need this any more.

* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testPlatformAndBuildType):
(testHtmlForTestTypeSwitcherGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Refactor some header includes in V8 bindings
haraken@chromium.org [Tue, 13 Mar 2012 00:53:27 +0000 (00:53 +0000)]
[V8] Refactor some header includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80913

Reviewed by Adam Barth.

This patch refactors some header includes in V8 bindings
required for fixing bug 80841.

No tests. No change in behavior.

* bindings/v8/DOMDataStore.h:
(DOMDataStore):
* bindings/v8/V8DOMMap.h:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::isolatedContext):
* bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(V8IsolatedContext):
* bindings/v8/WorldContextHandle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoremove graphics_type from webkitpy.layout_tests.models.test_configuration
dpranke@chromium.org [Tue, 13 Mar 2012 00:50:22 +0000 (00:50 +0000)]
remove graphics_type from webkitpy.layout_tests.models.test_configuration
https://bugs.webkit.org/show_bug.cgi?id=80643

Reviewed by Ojan Vafai.

Now that the chromium-gpu ports are gone, there's no need for
the graphics_type CPU/GPU distinction. Most of this change is
just updating tests accordingly.

* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
(TestExpectationEditorTests):
* Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfiguration.__init__):
(TestConfiguration.category_order):
(TestConfiguration.__str__):
(TestConfiguration.__repr__):
(TestConfiguration.__hash__):
(TestConfigurationConverter.to_specifiers_list):
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(make_mock_all_test_configurations_set):
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_error_on_different_build_type):
(TestExpectationSerializerTests.test_parsed_to_string):
(TestExpectationSerializerTests.test_reconstitute_only_these):
* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port.name):
(Port.version):
(Port.test_configuration):
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_check_illegal_port_names):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_baseline_path):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.all_test_configurations):
(TestPort._all_build_types):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningExpectationsUpdaterTest.test_unknown_failure_type):
(GardeningExpectationsUpdaterTest.test_add_new_expectation):
(GardeningExpectationsUpdaterTest.test_replace_old_expectation):
(GardeningExpectationsUpdaterTest.test_pass_expectation):
(GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
(GardeningExpectationsUpdaterTest.test_spurious_updates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago_runtime_feature_list isn't supported on Apple Mac DRT
dpranke@chromium.org [Tue, 13 Mar 2012 00:43:10 +0000 (00:43 +0000)]
_runtime_feature_list isn't supported on Apple Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=80906

Reviewed by Eric Seidel.

It looks like this feature is actually only supported on the Win
DRT port, so this patch reworks the code to make that clearer
and reduce unnecessary overrides.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._path_to_webcore_library):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._runtime_feature_list):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(TestWebKitPort.__init__):
(TestWebKitPort.all_test_configurations):
(test_skipped_directories_for_features):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort._runtime_feature_list):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_operating_system):
(WinPortTest):
(WinPortTest.test_runtime_feature_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo in PageClientImpl where we were overriding viewLayerHostingMode with
weinig@apple.com [Tue, 13 Mar 2012 00:31:25 +0000 (00:31 +0000)]
Fix typo in PageClientImpl where we were overriding viewLayerHostingMode with
a function called layerHostingMode.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::viewLayerHostingMode):
Update name and add OVERRIDE to catch this in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r110501.
commit-queue@webkit.org [Tue, 13 Mar 2012 00:22:38 +0000 (00:22 +0000)]
Unreviewed, rolling out r110501.
http://trac.webkit.org/changeset/110501
https://bugs.webkit.org/show_bug.cgi?id=80908

Broke the Apple-Win build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/DirectoryEntry.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.cpp.
(WebCore):
(WebCore::DirectoryEntry::DirectoryEntry):
(WebCore::DirectoryEntry::createReader):
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
(WebCore::DirectoryEntry::removeRecursively):
* fileapi/DirectoryEntry.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.h.
(WebCore):
(DirectoryEntry):
(WebCore::DirectoryEntry::create):
(WebCore::DirectoryEntry::isDirectory):
* fileapi/DirectoryEntry.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.idl.
* fileapi/DirectoryEntrySync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp.
(WebCore):
(WebCore::DirectoryEntrySync::DirectoryEntrySync):
(WebCore::DirectoryEntrySync::createReader):
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
(WebCore::DirectoryEntrySync::removeRecursively):
* fileapi/DirectoryEntrySync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.h.
(WebCore):
(DirectoryEntrySync):
(WebCore::DirectoryEntrySync::create):
(WebCore::DirectoryEntrySync::isDirectory):
* fileapi/DirectoryEntrySync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl.
* fileapi/DirectoryReader.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.cpp.
(WebCore):
(WebCore::DirectoryReader::DirectoryReader):
(WebCore::DirectoryReader::readEntries):
* fileapi/DirectoryReader.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.h.
(WebCore):
(DirectoryReader):
(WebCore::DirectoryReader::create):
(WebCore::DirectoryReader::filesystem):
* fileapi/DirectoryReader.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.idl.
* fileapi/DirectoryReaderBase.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderBase.h.
(WebCore):
(DirectoryReaderBase):
(WebCore::DirectoryReaderBase::filesystem):
(WebCore::DirectoryReaderBase::setHasMoreEntries):
(WebCore::DirectoryReaderBase::DirectoryReaderBase):
* fileapi/DirectoryReaderSync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp.
(WebCore):
(WebCore::DirectoryReaderSync::DirectoryReaderSync):
(WebCore::DirectoryReaderSync::readEntries):
* fileapi/DirectoryReaderSync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.h.
(WebCore):
(DirectoryReaderSync):
(WebCore::DirectoryReaderSync::create):
* fileapi/DirectoryReaderSync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
thakis@chromium.org [Tue, 13 Mar 2012 00:15:28 +0000 (00:15 +0000)]
[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
https://bugs.webkit.org/show_bug.cgi?id=80902

Reviewed by Adam Barth.

Follow-up to http://codereview.chromium.org/9638015/

No intended behavior change.

* WebCore.gyp/mac/adjust_visibility.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
jer.noble@apple.com [Tue, 13 Mar 2012 00:09:18 +0000 (00:09 +0000)]
WebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
https://bugs.webkit.org/show_bug.cgi?id=74750

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

To account for AudioNodes which may generate non-silent audio when fed silent input
for a certain amount of time after the last non-silent audio data, add two new virtual
functions tailTime() and latencyTime().

* webaudio/AudioNode.h:
(WebCore::AudioNode::tailTime): Added. Pure virtual.
(WebCore::AudioNode::latencyTime): Added. Pure virtual.
* platform/audio/AudioProcessor.h:
(WebCore::AudioProcessor::tailTime): Added. Pure virtual.
(WebCore::AudioProcessor::latencyTime): Added. Pure virtual.
* platform/audio/AudioDSPKernel.h:
(WebCore::AudioDSPKernel::tailTime): Added. Pure virtual.
(WebCore::AudioDSPKernel::latencyTime): Added. Pure virtual.

Added tailTime() and latencyTime() overrides to the following classes:
* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::tailTime):
(WebCore::AudioDSPKernelProcessor::latencyTime):
* platform/audio/AudioDSPKernelProcessor.h:
* platform/audio/DynamicsCompressor.h:
(WebCore::DynamicsCompressor::tailTime):
(WebCore::DynamicsCompressor::latencyTime):
* platform/audio/EqualPowerPanner.h:
* platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::tailTime):
(WebCore::HRTFPanner::latencyTime):
* platform/audio/HRTFPanner.h:
* platform/audio/Panner.h:
* webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::tailTime):
(WebCore::AudioBasicProcessorNode::latencyTime):
* webaudio/AudioBasicProcessorNode.h:
* webaudio/AudioChannelMerger.h:
* webaudio/AudioChannelSplitter.h:
* webaudio/AudioDestinationNode.h:
* webaudio/AudioGainNode.h:
* webaudio/AudioPannerNode.h:
* webaudio/AudioSourceNode.h:
* webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::tailTime):
(WebCore::BiquadDSPKernel::latencyTime):
* webaudio/BiquadDSPKernel.h:
* webaudio/BiquadFilterNode.h:
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::tailTime):
(WebCore::ConvolverNode::latencyTime):
* webaudio/ConvolverNode.h:
* webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::tailTime):
(WebCore::DelayDSPKernel::latencyTime):
* webaudio/DelayDSPKernel.h:
* webaudio/DelayProcessor.h:
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::tailTime):
(WebCore::DynamicsCompressorNode::latencyTime):
* webaudio/DynamicsCompressorNode.h:
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::tailTime):
(WebCore::JavaScriptAudioNode::latencyTime):
* webaudio/JavaScriptAudioNode.h:
* webaudio/RealtimeAnalyserNode.h:
* webaudio/WaveShaperDSPKernel.h:

The following functions were added as support for the new AudioNode and AudioProcessor functions:
* platform/audio/Biquad.cpp:
(WebCore::Biquad::latencyFrames):
* platform/audio/Biquad.h:
* platform/audio/Reverb.cpp:
(WebCore::Reverb::latencyFrames):
* platform/audio/ReverbConvolver.h:
(WebCore::ReverbConvolver::latencyFrames):

The following functions were made const-correct:
* platform/audio/HRTFPanner.h:
(WebCore::HRTFPanner::fftSize):
* platform/audio/Reverb.h:
(WebCore::Reverb::impulseResponseLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebTileLayers should be opaque
andersca@apple.com [Tue, 13 Mar 2012 00:07:16 +0000 (00:07 +0000)]
WebTileLayers should be opaque
https://bugs.webkit.org/show_bug.cgi?id=80907
<rdar://problem/11034390>

Reviewed by Andreas Kling.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):
Call -[CALayer setOpaque:] on the newly created WebTileLayer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix rounding in scrollbar rect calculations
eae@chromium.org [Mon, 12 Mar 2012 23:51:09 +0000 (23:51 +0000)]
Fix rounding in scrollbar rect calculations
https://bugs.webkit.org/show_bug.cgi?id=80894

Reviewed by Eric Seidel.

Fix usage of subpixel units in RenderScrollbar::buttonRect and
RenderScrollbar::trackRect.

No new tests, no new functionality.

* rendering/LayoutTypes.h:
(WebCore::isIntegerValue):
Add dummy isIntegerValue function, will be replaced with actual
implementation once LayoutUnit is remapped to FractionalLayoutUnit.

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::trackRect):
Change rect calculations to use pixel snapped values.

* rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
(WebCore::RenderScrollbarPart::marginTop):
(WebCore::RenderScrollbarPart::marginBottom):
(WebCore::RenderScrollbarPart::marginLeft):
(WebCore::RenderScrollbarPart::marginRight):
Add ASSERT to ensure that scrollbar parts are always aligned to device
pixels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GObject IDL Parser] STRING argument should be HASHREF
commit-queue@webkit.org [Mon, 12 Mar 2012 23:46:17 +0000 (23:46 +0000)]
[GObject IDL Parser] STRING argument should be HASHREF
https://bugs.webkit.org/show_bug.cgi?id=78877

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Kentaro Hara.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunctions): extendedAttributes are hashes, not strings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Windows build fixing.
jberlin@webkit.org [Mon, 12 Mar 2012 23:43:01 +0000 (23:43 +0000)]
More Windows build fixing.

Use fully qualified paths for WTF headers.

* platform/graphics/cg/ImageSourceCGWin.cpp:
* platform/graphics/win/UniscribeController.h:
* platform/win/DragImageCGWin.cpp:
* platform/win/DragImageCairoWin.cpp:
* platform/win/DragImageWin.cpp:
* rendering/RenderThemeSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis baseline also applies to chromium-mac-snowleopard, so we can move
abarth@webkit.org [Mon, 12 Mar 2012 23:40:19 +0000 (23:40 +0000)]
This baseline also applies to chromium-mac-snowleopard, so we can move
it up the fallback chain.

* platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/events/scrollbar-double-click-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
commit-queue@webkit.org [Mon, 12 Mar 2012 23:38:34 +0000 (23:38 +0000)]
Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/filesystem: Added.
* Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
* Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
* Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
* Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
* Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
* Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
* Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
* Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
* Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
* Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
* Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
* Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
* Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/DirectoryEntry.cpp: Removed.
* fileapi/DirectoryEntry.h: Removed.
* fileapi/DirectoryEntry.idl: Removed.
* fileapi/DirectoryEntrySync.cpp: Removed.
* fileapi/DirectoryEntrySync.h: Removed.
* fileapi/DirectoryEntrySync.idl: Removed.
* fileapi/DirectoryReader.cpp: Removed.
* fileapi/DirectoryReader.h: Removed.
* fileapi/DirectoryReader.idl: Removed.
* fileapi/DirectoryReaderBase.h: Removed.
* fileapi/DirectoryReaderSync.cpp: Removed.
* fileapi/DirectoryReaderSync.h: Removed.
* fileapi/DirectoryReaderSync.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a...
beidson@apple.com [Mon, 12 Mar 2012 23:34:24 +0000 (23:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly

Reviewed by Tim Hatcher.

No new tests. (No behavior change)

Changed to hold the StorageArea directly and added a Frame* accessor:
* inspector/InspectorDOMStorageResource.h:
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
(InspectorDOMStorageResource):

* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Skia] Release CGImage used to apply color space conversion to SkBitmap
abarth@webkit.org [Mon, 12 Mar 2012 23:23:56 +0000 (23:23 +0000)]
[Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNode::op and Node::flags should be private
fpizlo@apple.com [Mon, 12 Mar 2012 23:15:45 +0000 (23:15 +0000)]
Node::op and Node::flags should be private
https://bugs.webkit.org/show_bug.cgi?id=80824
<rdar://problem/11033435>

Reviewed by Gavin Barraclough.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):
* dfg/DFGArithNodeFlagsInferencePhase.cpp:
(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::byValIsPure):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(DFG):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
* dfg/DFGNode.cpp: Removed.
* dfg/DFGNode.h:
(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::op):
(JSC::DFG::Node::flags):
(JSC::DFG::Node::setOp):
(JSC::DFG::Node::setFlags):
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::clearFlags):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
* dfg/DFGNodeFlags.cpp: Copied from Source/JavaScriptCore/dfg/DFGNode.cpp.
* dfg/DFGNodeFlags.h: Added.
(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
* dfg/DFGNodeType.h: Added.
(DFG):
(JSC::DFG::defaultFlags):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):
* dfg/DFGRedundantPhiEliminationPhase.cpp:
(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compare):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate LayoutUnit usage in RenderMathML* classes
leviw@chromium.org [Mon, 12 Mar 2012 22:59:44 +0000 (22:59 +0000)]
Update LayoutUnit usage in RenderMathML* classes
https://bugs.webkit.org/show_bug.cgi?id=77916

Reviewed by Eric Seidel.

The purpose of this patch is to ensure MathML rendering does not regress when
we switch to sub-pixel layout. A subsequent patch can likely improve MathML's
rendering when zoom is applied.

To accomplish this without changing the current heuristics for positioning,
we continue to use integers for sizes and locations, using pixel snapping
when communicating with other Rendering classes.

No new tests. No change in behavior.

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint): Cleaning up debug painting to be on
pixel boundaries instead of subpixel.
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint): Reverting to integers for determining
the vertical offset.
(WebCore::RenderMathMLFraction::baselinePosition):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint): Using integers for height and width
and only accumulating pixel snapped values.
(WebCore::RenderMathMLRoot::layout): Setting padding with integers to
avoid inconsistent rounding based on the root's location.
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint): See RenderMathMLRoot.
(WebCore::RenderMathMLSquareRoot::layout): Ditto.
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse smaller tiles for right and bottom edges
andersca@apple.com [Mon, 12 Mar 2012 22:48:42 +0000 (22:48 +0000)]
Use smaller tiles for right and bottom edges
https://bugs.webkit.org/show_bug.cgi?id=80893
<rdar://problem/11032873>

Reviewed by Sam Weinig.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::rectForTileIndex):
Intersect the rect with the tile cache bounds.

(WebCore::TileCache::revalidateTiles):
Resize already existing tiles if needed.

(WebCore::TileCache::createTileLayer):
This now takes a tile rect. Use setFrame instead of setting the bounds and position separately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
enrica@apple.com [Mon, 12 Mar 2012 22:45:47 +0000 (22:45 +0000)]
Source/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

* WebCore.exp.in: Added two exported methods.
* platform/mac/FileSystemMac.mm:
(WebCore::setMetaData): Last parameter in the call to wkSetMetadataURL
needs to be wrapped in String before casting to NSString.

Source/WebKit2: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

This patch removes the last remaining access to NSPasteboard from the WebProcess.
The code in WebDragClient::declareAndWriteDragImage now packages all the data
required for the drag and the promised drag types and sends one request to the UI
process that will place the data in the NSPasteboard when appropriate.

* UIProcess/API/mac/PageClientImpl.h: Added setPromisedData method.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setPromisedData):
* UIProcess/API/mac/WKView.mm:
(matchesExtensionOrEquivalent): Added.
(fileExists): Added.
(pathWithUniqueFilenameForPath): Added.
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
* UIProcess/API/mac/WKViewInternal.h: Added _setPromisedData.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h: Added method for the new message.
* UIProcess/WebPageProxy.messages.in: Added setPromisedData message.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPromisedData):
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added SetMetadataURL.

WebKitLibraries: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

* WebKitSystemInterface.h: Touched the file to make build system happy.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expected results after http://trac.webkit.org/changeset/110480.
abarth@webkit.org [Mon, 12 Mar 2012 22:40:02 +0000 (22:40 +0000)]
Update expected results after trac.webkit.org/changeset/110480.
These results are very similar to our previous results and seem
slightly improved AFAICT.

* platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Blackberry] Make the process of marking all matches interruptible and asynchronous...
commit-queue@webkit.org [Mon, 12 Mar 2012 22:38:05 +0000 (22:38 +0000)]
[Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=80831

Patch by Andy Chen <andchen@rim.com> on 2012-03-12
Reviewed by Antonio Gomes.

* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
* WebKitSupport/InPageSearchManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestore previous expecation for chromium-mac-leopard. rniwa says this
abarth@webkit.org [Mon, 12 Mar 2012 22:37:02 +0000 (22:37 +0000)]
Restore previous expecation for chromium-mac-leopard.  rniwa says this
is the right thing to do.

* platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYet another Mac rebaseline.
rniwa@webkit.org [Mon, 12 Mar 2012 22:28:14 +0000 (22:28 +0000)]
Yet another Mac rebaseline.

* editing/pasteboard/dataTransfer-setData-getData-expected.txt:
* platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert some fast/regions pixel tests to reftests
commit-queue@webkit.org [Mon, 12 Mar 2012 22:24:39 +0000 (22:24 +0000)]
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=79132

Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

* fast/regions/floats-basic-in-variable-width-regions-expected.html: Added.
* fast/regions/floats-basic-in-variable-width-regions.html:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago clang build fix
ap@apple.com [Mon, 12 Mar 2012 22:22:59 +0000 (22:22 +0000)]
    clang build fix

        * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): Reorder
        boolean operators, so that a warning about "use of logical || with constant operand" doesn't
        appear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in Text::splitText due to mutation events.
inferno@chromium.org [Mon, 12 Mar 2012 22:17:55 +0000 (22:17 +0000)]
Crash in Text::splitText due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=80828

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/split-text-crash.xhtml

* dom/Range.cpp:
(WebCore::Range::insertNode): replace m_start.container() calls with ref protected node.

LayoutTests:

* fast/text/split-text-crash-expected.txt: Added.
* fast/text/split-text-crash.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix clang build for CCOcclusionTracker tests
abarth@webkit.org [Mon, 12 Mar 2012 21:59:55 +0000 (21:59 +0000)]
[chromium] Fix clang build for CCOcclusionTracker tests
https://bugs.webkit.org/show_bug.cgi?id=80891

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNull argument to texSubImage2D crashes
kbr@google.com [Mon, 12 Mar 2012 21:59:15 +0000 (21:59 +0000)]
Null argument to texSubImage2D crashes
https://bugs.webkit.org/show_bug.cgi?id=80778

Reviewed by Dean Jackson.

Source/WebCore:

Generate INVALID_VALUE OpenGL error upon receiving null argument.
Final behavior still being decided on public-webgl mailing list.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncData):
* html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated tex-sub-image-2d-bad-args test to verify new behavior.

* fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt:
* fast/canvas/webgl/tex-sub-image-2d-bad-args.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version...
macpherson@chromium.org [Mon, 12 Mar 2012 21:54:35 +0000 (21:54 +0000)]
Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly.
https://bugs.webkit.org/show_bug.cgi?id=80484

Reviewed by Julien Chaffraix.

No new tests / code cleanup only.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Restore canvas2D acceleration after context loss.
senorblanco@chromium.org [Mon, 12 Mar 2012 21:52:14 +0000 (21:52 +0000)]
[chromium] Restore canvas2D acceleration after context loss.
https://bugs.webkit.org/show_bug.cgi?id=80629

Reviewed by James Robinson.

Covered by existing canvas tests, and manual testing (killing the GPU
process).

Source/WebCore:

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::applyFilters):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::get):
(WebCore):
(WebCore::SharedGraphicsContext3D::get):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
(SharedGraphicsContext3D):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore):
(WebCore::PlatformContextSkia::isAccelerated):
(WebCore::PlatformContextSkia::setAccelerated):
(PlatformContextSkia):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sharedGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt doesn't make sense to return const unsigned, and GCC warns about it.
staikos@webkit.org [Mon, 12 Mar 2012 21:36:10 +0000 (21:36 +0000)]
It doesn't make sense to return const unsigned, and GCC warns about it.
Remove const.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:
(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::offsetX):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=80888
bdakin@apple.com [Mon, 12 Mar 2012 21:33:48 +0000 (21:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>

Reviewed by Dan Bernstein.

With http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup obsolete files.
commit-queue@webkit.org [Mon, 12 Mar 2012 21:17:10 +0000 (21:17 +0000)]
Cleanup obsolete files.
https://bugs.webkit.org/show_bug.cgi?id=80737

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-12
Reviewed by James Robinson.

.:

* wscript:

Source/WebCore:

No new code.

* GNUmakefile.list.am:
* PlatformWinCE.cmake:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* platform/ScrollAnimatorWin.cpp: Removed.
* platform/ScrollAnimatorWin.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake texImage2D error for wrong size ArrayBufferView more helpful
commit-queue@webkit.org [Mon, 12 Mar 2012 21:15:23 +0000 (21:15 +0000)]
Make texImage2D error for wrong size ArrayBufferView more helpful
https://bugs.webkit.org/show_bug.cgi?id=80868

It took me about 30 minutes to figure out my texImage2D was failing
not because my ArrayBufferView was too small but because the default
alignment is 4. A better error message might help devs find this issue
faster.

Patch by Gregg Tavares <gman@google.com> on 2012-03-12
Reviewed by Kenneth Russell.

No new tests as no new functionality.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago4 shadow DOM tests fail on Mac port
dglazkov@chromium.org [Mon, 12 Mar 2012 21:08:22 +0000 (21:08 +0000)]
4 shadow DOM tests fail on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80869

Reviewed by Ryosuke Niwa.

* fast/dom/shadow/content-element-move.html: Changed to use ensureShadowRoot.
* fast/dom/shadow/iframe-shadow.html: Changed to use WebKitShadowRoot polyfil.
* fast/dom/shadow/resources/polyfill.js: Added.
* fast/dom/shadow/shadow-on-image.html: Changed to use WebKitShadowRoot polyfil.
* platform/wk2/Skipped: Added a test that should have been skipped when landed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate include path of the test scripts after r110470.
alexis.menard@openbossa.org [Mon, 12 Mar 2012 21:07:07 +0000 (21:07 +0000)]
Update include path of the test scripts after r110470.

Reviewed by Philippe Normand.

* fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html:
* fast/dom/HTMLSelectElement/select-selectedIndex.html:
* fast/dom/HTMLSelectElement/select-selectedOptions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd test expectations accidentally left out of r110465.
adamk@chromium.org [Mon, 12 Mar 2012 21:04:48 +0000 (21:04 +0000)]
Add test expectations accidentally left out of r110465.

* fast/mutation/delivery-order-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac rebaseline. Offset is always 700px now.
rniwa@webkit.org [Mon, 12 Mar 2012 20:47:26 +0000 (20:47 +0000)]
Mac rebaseline. Offset is always 700px now.

* platform/mac/fast/events/scrollbar-double-click-expected.txt: Removed.
* platform/win/fast/events/scrollbar-double-click-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove <select> related layout tests in the place they should be.
alexis.menard@openbossa.org [Mon, 12 Mar 2012 20:33:46 +0000 (20:33 +0000)]
Move <select> related layout tests in the place they should be.

Reviewed by Andreas Kling.

* fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942-expected.txt: Added.
* fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942.html: Added.
* fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Added.
* fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Added.
* fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html: Added.
* fast/dom/HTMLSelectElement/select-selectedIndex.html: Added.
* fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
* fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
* fast/dom/select-selectedIndex-bug-12942-expected.txt: Removed.
* fast/dom/select-selectedIndex-bug-12942.html: Removed.
* fast/dom/select-selectedIndex-expected.txt: Removed.
* fast/dom/select-selectedIndex-multiple-expected.txt: Removed.
* fast/dom/select-selectedIndex-multiple.html: Removed.
* fast/dom/select-selectedIndex.html: Removed.
* fast/dom/select-selectedOptions-expected.txt: Removed.
* fast/dom/select-selectedOptions.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInfinite repaint loop with SVGImageCache and deferred repaint timers
timothy_horton@apple.com [Mon, 12 Mar 2012 20:26:58 +0000 (20:26 +0000)]
Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):
* page/FrameView.h:
(FrameView):
(WebCore::FrameView::repaintsDisabled):
* rendering/RenderView.cpp:
(WebCore::RenderView::shouldRepaint):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):
* svg/graphics/SVGImage.h:
(WebCore):
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):
* svg/graphics/SVGImageCache.h:
(SVGImageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: layout test style update
dgrogan@chromium.org [Mon, 12 Mar 2012 20:26:20 +0000 (20:26 +0000)]
IndexedDB: layout test style update
https://bugs.webkit.org/show_bug.cgi?id=80555

Change layoutTestController.waitUntilDone to var jsTestIsAsync = true
and idb-specific done() to finishJSTest();

Following the uniform style results in less overall code and makes
them easier to convert to worker layout tests.

Reviewed by Tony Chang.

* storage/indexeddb/constants.html:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/createObjectStore-name-argument-required.html:
* storage/indexeddb/createObjectStore-null-name.html:
* storage/indexeddb/cursor-continue.html:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-key-order.html:
* storage/indexeddb/cursor-primary-key-order.html:
* storage/indexeddb/cursor-reverse-bug.html:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-value-argument-required.html:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-basics.html:
* storage/indexeddb/database-name-undefined.html:
* storage/indexeddb/database-odd-names.html:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/delete-closed-database-object.html:
* storage/indexeddb/delete-range.html:
* storage/indexeddb/deleteIndex.html:
* storage/indexeddb/deleteObjectStore-name-argument-required.html:
* storage/indexeddb/deleteObjectStore-null-name.html:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/factory-basics.html:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/factory-deletedatabase-interactions.html:
* storage/indexeddb/factory-deletedatabase.html:
* storage/indexeddb/index-count.html:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/index-get-key-argument-required.html:
* storage/indexeddb/index-multientry.html:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/invalid-keys.html:
* storage/indexeddb/key-generator.html:
* storage/indexeddb/key-sort-order-across-types.html:
* storage/indexeddb/key-sort-order-date.html:
* storage/indexeddb/key-type-array.html:
* storage/indexeddb/key-type-infinity.html:
* storage/indexeddb/keypath-basics.html:
* storage/indexeddb/keypath-edges.html:
* storage/indexeddb/keypath-fetch-key.html:
* storage/indexeddb/keyrange-required-arguments.html:
* storage/indexeddb/keyrange.html:
* storage/indexeddb/list-ordering.html:
* storage/indexeddb/mozilla/add-twice-failure.html:
* storage/indexeddb/mozilla/autoincrement-indexes.html:
* storage/indexeddb/mozilla/bad-keypath.html:
* storage/indexeddb/mozilla/clear.html:
* storage/indexeddb/mozilla/create-index-unique.html:
* storage/indexeddb/mozilla/create-index-with-integer-keys.html:
* storage/indexeddb/mozilla/create-objectstore-basics.html:
* storage/indexeddb/mozilla/create-objectstore-null-name.html:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
* storage/indexeddb/mozilla/cursor-mutation.html:
* storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
* storage/indexeddb/mozilla/cursors.html:
* storage/indexeddb/mozilla/delete-result.html:
* storage/indexeddb/mozilla/event-source.html:
* storage/indexeddb/mozilla/global-data.html:
* storage/indexeddb/mozilla/indexes.html:
* storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
* storage/indexeddb/mozilla/key-requirements-put-no-key.html:
* storage/indexeddb/mozilla/key-requirements-put-null-key.html:
* storage/indexeddb/mozilla/key-requirements.html:
* storage/indexeddb/mozilla/object-cursors.html:
* storage/indexeddb/mozilla/object-identity.html:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
* storage/indexeddb/mozilla/object-store-remove-values.html:
* storage/indexeddb/mozilla/objectstorenames.html:
* storage/indexeddb/mozilla/odd-result-order.html:
* storage/indexeddb/mozilla/open-database-null-name.html:
* storage/indexeddb/mozilla/put-get-values.html:
* storage/indexeddb/mozilla/readonly-transactions.html:
* storage/indexeddb/mozilla/readwrite-transactions.html:
* storage/indexeddb/mozilla/readyState.html:
* storage/indexeddb/mozilla/remove-index.html:
* storage/indexeddb/mozilla/remove-objectstore.html:
* storage/indexeddb/mozilla/versionchange-abort.html:
* storage/indexeddb/mozilla/versionchange.html:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/objectStore-required-arguments.html:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-count.html:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/odd-strings.html:
* storage/indexeddb/open-close-version.html:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/open-during-transaction.html:
* storage/indexeddb/queued-commands.html:
* storage/indexeddb/readonly-properties.html:
* storage/indexeddb/readonly.html:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/resources/shared.js:
(unexpectedSuccessCallback):
(unexpectedErrorCallback):
(unexpectedAbortCallback):
(unexpectedCompleteCallback):
(unexpectedBlockedCallback):
* storage/indexeddb/setVersion-null.html:
* storage/indexeddb/setVersion-undefined.html:
* storage/indexeddb/set_version_blocked.html:
* storage/indexeddb/set_version_queue.html:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-rollback.html:
* storage/indexeddb/transaction-storeNames-required.html:
* storage/indexeddb/two-version-changes.html:
* storage/indexeddb/value-undefined.html:
* storage/indexeddb/values-odd-types.html:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-abort.html:
* storage/indexeddb/version-change-exclusive.html:
* storage/indexeddb/versionchangerequest-activedomobject.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac rebaseline.
rniwa@webkit.org [Mon, 12 Mar 2012 20:21:31 +0000 (20:21 +0000)]
Mac rebaseline.

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] Enforce a consistent order of MutationRecord delivery
adamk@chromium.org [Mon, 12 Mar 2012 20:11:16 +0000 (20:11 +0000)]
[MutationObservers] Enforce a consistent order of MutationRecord delivery
https://bugs.webkit.org/show_bug.cgi?id=80549

Reviewed by Ojan Vafai.

Source/WebCore:

Mutations should be delivered in order of creation.

Tests: fast/mutation/create-during-delivery.html
       fast/mutation/delivery-order.html
       fast/mutation/mutate-during-delivery.html

* dom/WebKitMutationObserver.cpp:
(WebCore):
(WebCore::WebKitMutationObserver::ObserverLessThan::operator()): Functor for use with std::sort.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::deliverAllMutations): Move observers into a sorted vector before delivery.
* dom/WebKitMutationObserver.h: Add a "priority" member which monotonically increases with each construction.

LayoutTests:

* fast/mutation/create-during-delivery-expected.txt: Added.
* fast/mutation/create-during-delivery.html: Added.
* fast/mutation/delivery-order.html: Added.
* fast/mutation/mutate-during-delivery-expected.txt: Added.
* fast/mutation/mutate-during-delivery.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Force compositeAndReadback through regular scheduling flow
nduca@chromium.org [Mon, 12 Mar 2012 20:08:20 +0000 (20:08 +0000)]
[Chromium] Force compositeAndReadback through regular scheduling flow
https://bugs.webkit.org/show_bug.cgi?id=77049

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::onTimerTick):
* platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateControllerClient):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setNeedsForcedCommit):
(WebCore):
(WebCore::CCScheduler::vsyncTick):
* platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedCommit):
(WebCore):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

* tests/CCFrameRateControllerTest.cpp:
(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
(FakeCCFrameRateControllerClient):
(WebKitTests::TEST):
* tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
(WTF::TEST_F):
* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::StateMachine::setNeedsForcedCommit):
(WebCore::StateMachine::needsForcedCommit):
(StateMachine):
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Handle LevelDB database corruption
jsbell@chromium.org [Mon, 12 Mar 2012 19:57:00 +0000 (19:57 +0000)]
IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

* Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.
(WebCore::IDBLevelDBBackingStore::open):
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::destroy):
(WebCore):
* platform/leveldb/LevelDBDatabase.h:
(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
* WebKit.gypi: Add LevelDBTest.cpp
* tests/LevelDBTest.cpp: Added.
(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Temporary build-fix for the Android bot
peter@chromium.org [Mon, 12 Mar 2012 19:50:34 +0000 (19:50 +0000)]
[Chromium] Temporary build-fix for the Android bot
https://bugs.webkit.org/show_bug.cgi?id=80862

Reviewed by Adam Barth.

Manually set the environmental variables required to compile source
files through the Android NDK instead of relying on the envsetup.sh
script. A proper fix will be landed to Chromium ASAP, and following
a Chromium roll into WebKit this code will be removed.

* Scripts/webkitdirs.pm:
(buildChromiumMakefile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Use right construct to detect config_test_gccdepends
vestbo@webkit.org [Mon, 12 Mar 2012 19:44:37 +0000 (19:44 +0000)]
[Qt] Use right construct to detect config_test_gccdepends

Reviewed by Andreas Kling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Expose location of WebKit's bin and imports dir through module file
vestbo@webkit.org [Mon, 12 Mar 2012 19:44:16 +0000 (19:44 +0000)]
[Qt] Expose location of WebKit's bin and imports dir through module file

Reviewed by Andreas Kling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix regression on fast/table/table-row-compositing-repaint-crash.html
shawnsingh@chromium.org [Mon, 12 Mar 2012 19:24:45 +0000 (19:24 +0000)]
Fix regression on fast/table/table-row-compositing-repaint-crash.html
https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: enable mixed percent/absolute for font
mikelawther@chromium.org [Mon, 12 Mar 2012 19:20:56 +0000 (19:20 +0000)]
CSS3 calc: enable mixed percent/absolute for font
https://bugs.webkit.org/show_bug.cgi?id=80813

Reviewed by Ojan Vafai.

Source/WebCore:

Add support for mixed percent/absolute expressions to the font handling class.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):

LayoutTests:

* css3/calc/font-expected.txt:
* css3/calc/font-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMinor DataLog fixes
laszlo.1.gombos@nokia.com [Mon, 12 Mar 2012 19:18:14 +0000 (19:18 +0000)]
Minor DataLog fixes
https://bugs.webkit.org/show_bug.cgi?id=80826

Reviewed by Andreas Kling.

* bytecode/ExecutionCounter.cpp:
Do not include DataLog.h, it is not used.

* jit/ExecutableAllocator.cpp:
Ditto.

* wtf/DataLog.cpp:
(WTF::initializeLogFileOnce):
Add missing semi-colon to the code path where DATA_LOG_FILENAME is defined.

* wtf/HashTable.cpp:
Include DataLog as it is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoupdate expectations in preparation for bitmap-sampling fix in skia
reed@google.com [Mon, 12 Mar 2012 18:58:47 +0000 (18:58 +0000)]
update expectations in preparation for bitmap-sampling fix in skia
https://bugs.webkit.org/show_bug.cgi?id=80837

Unreviewed

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestore Attr::style() functionality.
kling@webkit.org [Mon, 12 Mar 2012 18:51:32 +0000 (18:51 +0000)]
Restore Attr::style() functionality.
<http://webkit.org/b/80678>
<rdar://problem/10933904>

Reviewed by Antti Koivisto.

The neutering of Attr::style() in r106740 broke some internal clients of the Obj-C API,
so this was definitely premature.

Since we no longer have a per-Attribute style object, synthesize one in style() and
hang it off of the Attr. This grows Attr by one pointer, but it's a low-volume object
so it shouldn't matter much.

We recreate the StylePropertySet object on every call to style(), to avoid complicating
things with custom invalidation code.

* dom/Attr.cpp:
(WebCore::Attr::style):
* dom/Attr.h:
* dom/StyledElement.h:
(WebCore::StyledElement::collectStyleForAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
rniwa@webkit.org [Mon, 12 Mar 2012 18:38:12 +0000 (18:38 +0000)]
REGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=80578

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/style-change-crash.html

* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):

LayoutTests:

* fast/regions/select-in-region-crash-expected.txt: Rebaselined.
* svg/css/style-change-crash-expected.txt: Added.
* svg/css/style-change-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch event handler count is not updated when adding handlers to the window.
commit-queue@webkit.org [Mon, 12 Mar 2012 18:28:40 +0000 (18:28 +0000)]
Touch event handler count is not updated when adding handlers to the window.
https://bugs.webkit.org/show_bug.cgi?id=80756

Source/WebCore:

Touch event handlers added to the window needs to be included when counting the number of touch event
handlers. This makes touch event handler counting identical to wheel event handler counting.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

Test: fast/events/touch/touch-handler-count.html

* dom/EventNames.h:
(EventNames):
(WebCore::EventNames::isTouchEventType):
* dom/Node.cpp:
(WebCore):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
* testing/Internals.cpp:
(WebCore::Internals::touchEventHandlerCount):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

The new layout tests add and remove touch event handlers on the window, document, and a div in the
document, and tests that the count is updated correctly when handlers are added and/or removed.

* fast/events/touch/touch-handler-count-expected.txt: Added.
* fast/events/touch/touch-handler-count.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
abecsi@webkit.org [Mon, 12 Mar 2012 18:02:58 +0000 (18:02 +0000)]
[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=80832

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Since the ScrollDecorator QML component requires a Flickable in its API
we need to expose the Flickable in QML for now and we also need to add
a notifier because we instantiate the internal Flickable only when the
WebView component completes construction.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewExperimental::flickable):
* UIProcess/API/qt/qquickwebview_p.h:

Tools:

Add a basic scroll indicator component to MiniBrowser so that it
behaves similar to the ScrollDecorator QML component.

* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/ScrollIndicator.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] r110296 included an extra $ in @$(AM_V_GEN)
commit-queue@webkit.org [Mon, 12 Mar 2012 17:50:50 +0000 (17:50 +0000)]
[GTK] r110296 included an extra $ in @$(AM_V_GEN)
https://bugs.webkit.org/show_bug.cgi?id=80809

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Philippe Normand.

* GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: extract ResourceScriptMapping from MainScriptMapping.
podivilov@chromium.org [Mon, 12 Mar 2012 17:43:51 +0000 (17:43 +0000)]
Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80834

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
ericu@chromium.org [Mon, 12 Mar 2012 17:42:36 +0000 (17:42 +0000)]
[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=75110

Reviewed by Ryosuke Niwa.

Remove expectation now that it's fixed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInteger overflow check code in arithmetic operation in classic interpreter
commit-queue@webkit.org [Mon, 12 Mar 2012 17:31:26 +0000 (17:31 +0000)]
Integer overflow check code in arithmetic operation in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465

Patch by SangGyu Lee <sg5.lee@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, unskip a media test in GTK.
philn@webkit.org [Mon, 12 Mar 2012 17:17:18 +0000 (17:17 +0000)]
Unreviewed, unskip a media test in GTK.

* platform/gtk/Skipped: media/video-volume-slider.html was fixed
in r86535.
* platform/gtk/media/video-volume-slider-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: recognize Float*Array and Int*Array as arrays.
pfeldman@chromium.org [Mon, 12 Mar 2012 17:14:39 +0000 (17:14 +0000)]
Web Inspector: recognize Float*Array and Int*Array as arrays.
https://bugs.webkit.org/show_bug.cgi?id=80850

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-external-array.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::type):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

* inspector/console/console-external-array-expected.txt: Added.
* inspector/console/console-external-array.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
commit-queue@webkit.org [Mon, 12 Mar 2012 17:13:07 +0000 (17:13 +0000)]
Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=80658

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Alexey Proskuryakov.

* fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt: Added.
* fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the...
jocelyn.turcotte@nokia.com [Mon, 12 Mar 2012 17:09:35 +0000 (17:09 +0000)]
[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.
https://bugs.webkit.org/show_bug.cgi?id=80848

Reviewed by Noam Rosenthal.

When rendering a transformed texture on the screen with a fractional
coordinate with linear filtering, the resulting pixel will be blended from
the texels around this fractional position according to their cover ratio.
This produces a slight blur of pixels which give no benefit when rendering
a texture that isn't scaled.

This patch offsets the transform by rounding the translation part of the
layer's transform to align the result to integer coordinates.
Applying the adjustment on the layer transform makes sure that all the tiles
get the same adjustment.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::BitmapTextureGL::textureSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[TexMapGL] Use textures sized exactly to their contents.
jocelyn.turcotte@nokia.com [Mon, 12 Mar 2012 17:08:18 +0000 (17:08 +0000)]
[TexMapGL] Use textures sized exactly to their contents.
https://bugs.webkit.org/show_bug.cgi?id=80845

Reviewed by Noam Rosenthal.

This fixes a regression introduced in r108273 as well as the bug it fixed.
The regressing behavior was that textures were rendered shrunk by 1 pixel
and thus would appear blurry on the screen.
The original problem was that garbage contents would appear on filtered
textures since we would reuse textures of different sizes by giving them
a slightly bigger size.

This patch will reuse the texture only if the size matches exactly to allow
edge clamping to work properly when redering with linear filtering.
Reusing textures would only saves us the allocation of graphic memory
anyway, which is negligeable compared to texture upload.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
* platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgramOpacityAndMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[TexMap] Remove BitmapTexture::destroy.
jocelyn.turcotte@nokia.com [Mon, 12 Mar 2012 17:06:44 +0000 (17:06 +0000)]
[TexMap] Remove BitmapTexture::destroy.
https://bugs.webkit.org/show_bug.cgi?id=80844

Reviewed by Noam Rosenthal.

Use the destructor directly instead.

* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::~BitmapTextureGL):
* platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(WebCore::BitmapTextureImageBuffer::~BitmapTextureImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make sure we set the right library version for Qt 4
vestbo@webkit.org [Mon, 12 Mar 2012 16:39:38 +0000 (16:39 +0000)]
[Qt] Make sure we set the right library version for Qt 4

r110272 accedentally pruned the variable that ensures this.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, slight Skipped list reorganization and unskip a bunch
philn@webkit.org [Mon, 12 Mar 2012 16:06:15 +0000 (16:06 +0000)]
Unreviewed, slight Skipped list reorganization and unskip a bunch
of inspector tests on GTK.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: DebuggerModel.Location should have scriptId property.
podivilov@chromium.org [Mon, 12 Mar 2012 15:56:06 +0000 (15:56 +0000)]
Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.location):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):

LayoutTests:

* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/search/search-in-concatenated-script.html:
* http/tests/inspector/search/search-in-script.html:
* inspector/debugger/debugger-scripts.html:
* inspector/debugger/linkifier.html:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Clean up culling tests and templatize to test impl constructs
commit-queue@webkit.org [Mon, 12 Mar 2012 15:50:27 +0000 (15:50 +0000)]
[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] A couple early-outs for occlusion tracker
commit-queue@webkit.org [Mon, 12 Mar 2012 15:47:40 +0000 (15:47 +0000)]
[chromium] A couple early-outs for occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=80742

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
zeno.albisser@nokia.com [Mon, 12 Mar 2012 15:45:43 +0000 (15:45 +0000)]
[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
https://bugs.webkit.org/show_bug.cgi?id=80840

CoreFoundation/CFBase.h needs to be included to define the type CFTypeRef.

Reviewed by Tor Arne Vestbø.

* platform/mac/WebCoreObjCExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
zeno.albisser@nokia.com [Mon, 12 Mar 2012 15:34:50 +0000 (15:34 +0000)]
[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
https://bugs.webkit.org/show_bug.cgi?id=80827

Qt on Mac uses OS(DARWIN) as well, but we do not want to enable LLINT.

Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused global static variable for BlackBerry.
staikos@webkit.org [Mon, 12 Mar 2012 15:32:47 +0000 (15:32 +0000)]
Remove unused global static variable for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110429 268f45cc-cd09-0410-ab3c-d52691b4dbfc