WebKit-https.git
11 years ago<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in...
mitz@apple.com [Wed, 18 May 2011 04:43:44 +0000 (04:43 +0000)]
<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in WebKit2 on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=61022

Reviewed by Alice Liu.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): As long as we are not loading the shim on Snow Leopard, we should not
try to initialize it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 03:56:41 +0000 (03:56 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        plugins/windowless_plugin_paint_test.html now passes on Linux, timeouts on Mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 18 May 2011 03:50:34 +0000 (03:50 +0000)]
2011-05-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Add CLOSING state
        https://bugs.webkit.org/show_bug.cgi?id=60878

        The value of WebSocket.CLOSED has been changed from 2 to 3, we have to update
        expected results of tests that dump WebSocket.readyState.

        * fast/dom/Window/window-properties-expected.txt:
        * http/tests/websocket/tests/bufferedAmount-after-close-expected.txt:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
        * http/tests/websocket/tests/handshake-error-expected.txt:
        * http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js:
        (ws.onclose):
        * http/tests/websocket/tests/script-tests/handshake-error.js:
        (ws.onclose):
        * http/tests/websocket/tests/send-after-close-on-unload-expected.txt:
        * http/tests/websocket/tests/send-after-close-on-unload.html:
        * http/tests/websocket/tests/simple-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
2011-05-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Add CLOSING state
        https://bugs.webkit.org/show_bug.cgi?id=60878

        No new tests are added because there is no change in functionality.

        * platform/network/SocketStreamHandleBase.h:
        * websockets/WebSocket.h:
        * websockets/WebSocket.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 03:47:01 +0000 (03:47 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        plugins/invalidate_rect.html now passes on Linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRolled out attempts to fix EFL build because they're not enough -- the
ggaren@apple.com [Wed, 18 May 2011 03:23:10 +0000 (03:23 +0000)]
Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.

* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore attempts to work around the EFL build system being borken.
ggaren@apple.com [Wed, 18 May 2011 03:07:23 +0000 (03:07 +0000)]
More attempts to work around the EFL build system being borken.

* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix the EFL build.
ggaren@apple.com [Wed, 18 May 2011 03:03:42 +0000 (03:03 +0000)]
Try to fix the EFL build.

* runtime/BooleanPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSource/JavaScriptCore: Rolling back in r86653 with build fixed.
ggaren@apple.com [Wed, 18 May 2011 02:39:00 +0000 (02:39 +0000)]
Source/JavaScriptCore: Rolling back in r86653 with build fixed.

Reviewed by Gavin Barraclough and Oliver Hunt.

Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933

Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.

This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

* DerivedSources.make:
* JavaScriptCore.exp: Build!

* create_hash_table: Added a special case for fromCharCode, since it uses
a custom "thunk generator".

* heap/Heap.cpp:
(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.

* interpreter/CallFrame.h:
(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.

* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h: Added new tables.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a
static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.

Even more global object properties can be made lazy, but that requires
more in-depth changes.

* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.

LayoutTests: Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933

Reviewed by Gavin Barraclough.

Added a few more expected failures, now that more code uses static hash
tables.

The fact that built-ins are not deletable, but should be, is covered by
https://bugs.webkit.org/show_bug.cgi?id=61014

* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 18 May 2011 01:48:39 +0000 (01:48 +0000)]
2011-05-16  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] ShadowContentElement should be part of dom/
        https://bugs.webkit.org/show_bug.cgi?id=59117

        - Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
        - Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
        - Added ShadowContentElement.cpp
        - Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}

        No new tests, no behavior change.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
        * dom/Node.h:
        (WebCore::Node::forceReattach): Moved from static local function to share between classes.
        * dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentElement::attach):
        * dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentElement::ShadowContentElement):
        (WebCore::ShadowContentElement::isShadowBoundary):
        (WebCore::ShadowContentElement::rendererIsNeeded):
        (WebCore::ShadowContentElement::createRenderer):
        * dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentSelector::ShadowContentSelector):
        (WebCore::ShadowContentSelector::~ShadowContentSelector):
        (WebCore::ShadowContentSelector::attachChildrenFor):
        * dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentSelector::shadowRoot):
        (WebCore::ShadowContentSelector::activeElement):
        (WebCore::ShadowContentSelector::currentInstance):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::recalcStyle):
        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsContentElement::DetailsContentElement):
        (WebCore::DetailsSummaryElement::DetailsSummaryElement):
        * html/HTMLSummaryElement.cpp:
        (WebCore::SummaryContentElement::SummaryContentElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Wed, 18 May 2011 00:53:22 +0000 (00:53 +0000)]
2011-05-17  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
        https://bugs.webkit.org/show_bug.cgi?id=61005

        Test: http/tests/loading/nested_bad_objects.php

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::renderFallbackContent):
2011-05-17  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Tests for crash when two nested image objects with invalid data are loaded.
        https://bugs.webkit.org/show_bug.cgi?id=61005

        * http/tests/loading/nested_bad_objects-expected.txt: Added.
        * http/tests/loading/nested_bad_objects.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=60595
beidson@apple.com [Wed, 18 May 2011 00:29:36 +0000 (00:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60595
Fix the rampant WebProcess crashing because we're trying to install the WebProcess shim
into QTKitServer when we launch it.

Rubberstamped by Sam Weinig.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): This is only happening on SnowLeopard, so put
  SnowLeopard build guards around the shim install path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 18 May 2011 00:21:33 +0000 (00:21 +0000)]
2011-05-17  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Simon Fraser.

        Remove empty directory.

        * fast/inspector: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 18 May 2011 00:12:46 +0000 (00:12 +0000)]
2011-05-17  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
        https://bugs.webkit.org/show_bug.cgi?id=60995

        No new tests since audio API is not yet implemented.

        * webaudio/AudioNode.cpp:
        (WebCore::AudioNode::ref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Tao Bai <michaelbai@chromium.org>
commit-queue@webkit.org [Wed, 18 May 2011 00:08:47 +0000 (00:08 +0000)]
2011-05-17  Tao Bai  <michaelbai@chromium.org>

        Reviewed by Darin Fisher.

        Clear deprecated icon APIs from chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=60989

        * public/WebFrame.h: Removed faviconURL()
        * public/WebFrameClient.h: Removed didChangeIcons()
        * src/FrameLoaderClientImpl.cpp:
             Removed the code to support deprecated API
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
        * src/WebFrameImpl.cpp: Removed faviconURL()
        * src/WebFrameImpl.h:  Removed faviconURL()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 17 May 2011 23:42:36 +0000 (23:42 +0000)]
2011-05-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/9366728> and https://webkit.org/b/60796
        Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]

        Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
        This change has the following benefits:
          - Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect
            themselves, check these variables as often, or ASSERT them.
          - ResourceLoader subclasses no longer have to call the base class ::didCancel
          - ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the
            cancellation is completed inside the last call.

        No new tests - No change in behavior for previous tests, and new test would require API usage outside
        the scope of DumpRenderTree.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work
          except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
        * loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().

        Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willCancel):
        (WebCore::MainResourceLoader::didCancel):
        * loader/MainResourceLoader.h:

        Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel()
        (WebCore::NetscapePlugInStreamLoader::willCancel):
        (WebCore::NetscapePlugInStreamLoader::didCancel):
        * loader/NetscapePlugInStreamLoader.h:

        Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::willCancel):
        (WebCore::SubresourceLoader::didCancel):
        * loader/SubresourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 17 May 2011 23:39:57 +0000 (23:39 +0000)]
2011-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86668.
        http://trac.webkit.org/changeset/86668
        https://bugs.webkit.org/show_bug.cgi?id=61001

        It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
        #webkit).

        * UIProcess/API/qt/qgraphicswkview.cpp:
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix after r86717.
bweinstein@apple.com [Tue, 17 May 2011 23:21:39 +0000 (23:21 +0000)]
Build fix after r86717.

* UIProcess/API/C/win/WKView.h: Add a forward declaration of IDropTarget

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit2: Needs API to set a custom drop target
bweinstein@apple.com [Tue, 17 May 2011 23:15:06 +0000 (23:15 +0000)]
WebKit2: Needs API to set a custom drop target
https://bugs.webkit.org/show_bug.cgi?id=60991
<rdar://problem/9090868>

Reviewed by Adam Roben.

Add API to set a custom drop target on a WKView.

* UIProcess/API/C/win/WKView.cpp:
(WKViewSetCustomDropTarget): Call through to WebView::setCustomDropTarget.
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setCustomDropTarget): Revoke the current drop target, and register the
    custom one.
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 17 May 2011 23:10:14 +0000 (23:10 +0000)]
2011-05-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        editing/pasteboard/paste-blockquote-2.html and paste-blockquote-3.html should be dump-as-markup tests
        https://bugs.webkit.org/show_bug.cgi?id=60998

        Converted the tests.

        * editing/pasteboard/paste-blockquote-2-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-2.html:
        * editing/pasteboard/paste-blockquote-3-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-3.html:
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 17 May 2011 23:03:43 +0000 (23:03 +0000)]
2011-05-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        editing/pasteboard/paste-text-012.html should be a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=60996

        Converted the test.

        * editing/pasteboard/paste-text-012-expected.txt: Added.
        * editing/pasteboard/paste-text-012.html:
        * platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-012-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/gtk/editing/pasteboard/paste-text-012-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-text-012-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 17 May 2011 22:49:36 +0000 (22:49 +0000)]
2011-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add API to determine if a frame has any form elements without going to javascript
        https://bugs.webkit.org/show_bug.cgi?id=60999

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameContainsAnyFormElements):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::containsAnyFormElements):
        * WebProcess/WebPage/WebFrame.h:
        Add WKBundleFrameContainsAnyFormElements which does a walk of the document to determine
        if there are any form elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Tue, 17 May 2011 22:34:22 +0000 (22:34 +0000)]
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Always set layerRenderer, even on non-drawn-layers
        https://bugs.webkit.org/show_bug.cgi?id=60977

        This is a defensive fixe for crbug.com/82799, in which
        a RenderLayer could not prepare itself because its owning layerImpl
        had no associated layerRenderer. The underlying issue is that we
        sometimes put renderSurfaces onto the list that won't actually render.
        For now, the priority is to reduce fragility so that invisible layers
        dont lead to crashers. We do this by being more agressive about
        binding CCLayerImpls to the LayerRenderer, doing it all the time rather
        than only when we think it will get rendered.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::paintLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 17 May 2011 22:32:47 +0000 (22:32 +0000)]
2011-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        JSGlobalContextRelease should not trigger a synchronous garbage collection
        https://bugs.webkit.org/show_bug.cgi?id=60990

        * API/JSContextRef.cpp:
        Change synchronous call to collectAllGarbage to a call to trigger the
        activityCallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 17 May 2011 22:07:53 +0000 (22:07 +0000)]
2011-05-17  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] Clipboard policy callbacks from EditorClientImpl are reversed
        https://bugs.webkit.org/show_bug.cgi?id=60994

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::canCopyCut):
        (WebKit::EditorClientImpl::canPaste):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 17 May 2011 22:00:31 +0000 (22:00 +0000)]
2011-05-17  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Csaba Osztrogonac.

        [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

        Skip on qt-mac

        http://bugs.webkit.org/show_bug.cgi?id=60838

        * platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the clang build.
andersca@apple.com [Tue, 17 May 2011 21:45:07 +0000 (21:45 +0000)]
Fix the clang build.

* rendering/RenderText.h:
(WebCore::RenderText::nodeAtPoint):
nodeAtPoint should take a const IntPoint reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Tue, 17 May 2011 21:33:23 +0000 (21:33 +0000)]
2011-05-17  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ryosuke Niwa.

        document.activeElement doesn't point to the focused frame
        https://bugs.webkit.org/show_bug.cgi?id=49509

        This tests that an iframe is the activeElement when focus is inside that frame.

        * fast/dom/HTMLDocument/active-element-frames-expected.txt: Added.
        * fast/dom/HTMLDocument/active-element-frames.html: Added.
2011-05-17  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ryosuke Niwa.

        document.activeElement doesn't point to the focused frame
        https://bugs.webkit.org/show_bug.cgi?id=49509

        This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.

        Test: fast/dom/HTMLDocument/active-element-frames.html

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 17 May 2011 20:57:56 +0000 (20:57 +0000)]
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        https://bugs.webkit.org/show_bug.cgi?id=54051

       * platform/qt/Skipped: Unskip plugins/invalidate_rect.html
       * platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        Add ChromeClientQt::allowsAcceleratedCompositing().

        https://bugs.webkit.org/show_bug.cgi?id=54051

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
        * WebCoreSupport/ChromeClientQt.h:
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        - Make the unix test netscape plugin recognize the onPaintEvent
          and windowedPlugin parameters.

        https://bugs.webkit.org/show_bug.cgi?id=54051

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventX11):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::displayInvalidatedRegion):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):
        (webkit_test_plugin_handle_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 17 May 2011 20:57:28 +0000 (20:57 +0000)]
2011-05-17  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Change nodeAtPoint to take IntPoint instead of int x, int y
        https://bugs.webkit.org/show_bug.cgi?id=60663

        Change nodeAtPoint to take a single const IntPoint& instead of a pair of
        ints for the location.

        Covered by existing tests.

        * platform/graphics/FloatPoint.h:
        (WebCore::flooredIntPoint):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::nodeAtPoint):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::nodeAtPoint):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::hitTestContents):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        * rendering/RenderBox.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::nodeAtPoint):
        * rendering/RenderFrameSet.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::nodeAtPoint):
        * rendering/RenderImage.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::nodeAtPoint):
        * rendering/RenderInline.h:
        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::hitTest):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::nodeAtPoint):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::hitTest):
        (WebCore::RenderObject::nodeAtPoint):
        * rendering/RenderObject.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/RenderTable.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::nodeAtPoint):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        * rendering/RenderText.h:
        (WebCore::RenderText::nodeAtPoint):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlMultiLine.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::nodeAtPoint):
        * rendering/RenderWidget.h:
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::nodeAtPoint):
        * rendering/RootInlineBox.h:
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
        (WebCore::RenderSVGForeignObject::nodeAtPoint):
        * rendering/svg/RenderSVGForeignObject.h:
        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::nodeAtPoint):
        * rendering/svg/RenderSVGModelObject.h:
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/svg/RenderSVGRoot.h:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::nodeAtFloatPoint):
        (WebCore::RenderSVGText::nodeAtPoint):
        * rendering/svg/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Tue, 17 May 2011 20:39:18 +0000 (20:39 +0000)]
2011-05-17  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86647.
        http://trac.webkit.org/changeset/86647
        https://bugs.webkit.org/show_bug.cgi?id=56814

        Broke tests downstream in Chromium

        * dom/DocumentMarker.h:
        (WebCore::DocumentMarker::operator==):
        (WebCore::DocumentMarker::operator!=):
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::addMarker):
        (WebCore::DocumentMarkerController::copyMarkers):
        (WebCore::DocumentMarkerController::removeMarkers):
        (WebCore::DocumentMarkerController::markerContainingPoint):
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::renderedRectsForMarkers):
        (WebCore::DocumentMarkerController::removeMarkersFromList):
        (WebCore::DocumentMarkerController::repaintMarkers):
        (WebCore::DocumentMarkerController::shiftMarkers):
        (WebCore::DocumentMarkerController::setMarkersActive):
        (WebCore::DocumentMarkerController::hasMarkers):
        (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
        (WebCore::DocumentMarkerController::showMarkers):
        * dom/DocumentMarkerController.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartHasMarkerFor):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::respondToChangedSelection):
        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::shouldStartTimerFor):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::spellingToolTip):
        (WebCore::HitTestResult::replacedString):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
2011-05-17  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86647.
        http://trac.webkit.org/changeset/86647
        https://bugs.webkit.org/show_bug.cgi?id=56814

        Broke tests downstream in Chromium

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::addMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Tue, 17 May 2011 20:38:23 +0000 (20:38 +0000)]
2011-05-17  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86656.
        http://trac.webkit.org/changeset/86656

        Broke tests downstream in Chromium

        * editing/SpellingCorrectionController.cpp:
        (WebCore::markersHaveIdenticalDescription):
        (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
        (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 17 May 2011 20:30:42 +0000 (20:30 +0000)]
2011-05-17  Tony Chang  <tony@chromium.org>

        Land linux 32 bit results.

        * platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
        * platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
        * platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Added.
        * platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt: Added.
        * platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Added.
        * platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed chromium test expectations update.
atwilson@chromium.org [Tue, 17 May 2011 20:26:11 +0000 (20:26 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yufeng Shen <miletus@chromium.org>
commit-queue@webkit.org [Tue, 17 May 2011 20:04:41 +0000 (20:04 +0000)]
2011-05-17  Yufeng Shen  <miletus@chromium.org>

        Reviewed by Darin Fisher.

        Make WebKit expose extra touch information
        https://bugs.webkit.org/show_bug.cgi?id=59030

        * fast/events/touch/document-create-touch-expected.txt:
        * fast/events/touch/script-tests/document-create-touch.js:
2011-05-17  Yufeng Shen  <miletus@chromium.org>

        Reviewed by Darin Fisher.

        Make WebKit expose extra touch information
        https://bugs.webkit.org/show_bug.cgi?id=59030

        * dom/Document.cpp:
        (WebCore::Document::createTouch):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/Touch.cpp:
        (WebCore::Touch::Touch):
        * dom/Touch.h:
        (WebCore::Touch::create):
        (WebCore::Touch::webkitRadiusX):
        (WebCore::Touch::webkitRadiusY):
        (WebCore::Touch::webkitRotationAngle):
        * dom/Touch.idl:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent):
        * platform/PlatformTouchPoint.h:
        (WebCore::PlatformTouchPoint::radiusX):
        (WebCore::PlatformTouchPoint::radiusY):
        (WebCore::PlatformTouchPoint::rotationAngle):
2011-05-17  Yufeng Shen  <miletus@chromium.org>

        Reviewed by Darin Fisher.

        Make WebKit expose extra touch information
        https://bugs.webkit.org/show_bug.cgi?id=59030

        * public/WebTouchPoint.h:
        (WebKit::WebTouchPoint::WebTouchPoint):
        * src/WebInputEventConversion.cpp:
        (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 17 May 2011 20:02:41 +0000 (20:02 +0000)]
2011-05-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Reduce code size for inline cache
        https://bugs.webkit.org/show_bug.cgi?id=60942

        This patch introduces the concept of a "compact" address that
        allows individual architectures to control the maximum offset
        used for the inline path of get_by_id.  This reduces the code
        size of get_by_id by 3 bytes on x86 and x86_64 and slightly
        improves performance on v8 tests.

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::repatchCompact):
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::repatchCompact):
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact):
        (JSC::AbstractMacroAssembler::differenceBetween):
        (JSC::AbstractMacroAssembler::repatchCompact):
        * assembler/CodeLocation.h:
        (JSC::CodeLocationDataLabelCompact::CodeLocationDataLabelCompact):
        (JSC::CodeLocationCommon::dataLabelCompactAtOffset):
        * assembler/LinkBuffer.h:
        (JSC::LinkBuffer::locationOf):
        * assembler/MIPSAssembler.h:
        (JSC::MIPSAssembler::repatchCompact):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch):
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::load32WithAddressOffsetPatch):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::repatchCompact):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
        * assembler/RepatchBuffer.h:
        (JSC::RepatchBuffer::repatch):
        * assembler/SH4Assembler.h:
        (JSC::SH4Assembler::repatchCompact):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movl_mr_disp8):
        (JSC::X86Assembler::movq_mr_disp8):
        (JSC::X86Assembler::repatchCompact):
        (JSC::X86Assembler::setInt8):
        (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8):
        (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8):
        (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::patchGetByIdSelf):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::patchGetByIdSelf):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCacheGetByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 17 May 2011 19:45:24 +0000 (19:45 +0000)]
2011-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Add a LineLayoutState object to hold global state during line layout
        https://bugs.webkit.org/show_bug.cgi?id=60113

        Like LayoutState for layout(), LineLayoutState keeps track of global information
        during an entire linebox tree layout pass (aka layoutInlineChildren).

        For now it just holds isFullLayout and the logicalRepaintTop/Bottom.
        It's possible we should hold the useRepaintBounds bool as well as
        the startLine and endLine RootInlineBox pointers.

        No change in behavior, thus no tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::LineLayoutState::LineLayoutState):
        (WebCore::LineLayoutState::markForFullLayout):
        (WebCore::LineLayoutState::isFullLayout):
        (WebCore::LineLayoutState::setRepaintRange):
        (WebCore::LineLayoutState::updateRepaintRangeFromBox):
        (WebCore::LineLayoutState::startLine):
        (WebCore::LineLayoutState::endLine):
        (WebCore::deleteLineRange):
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::checkFloatsInCleanLine):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::RenderBlock::determineEndPosition):
        (WebCore::RenderBlock::matchedEndLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Tue, 17 May 2011 19:35:37 +0000 (19:35 +0000)]
2011-05-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
        https://bugs.webkit.org/show_bug.cgi?id=60978

        Backslash to escape newlines was confusing both prepare-ChangeLog and the
        QtCreator highlight system.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::evalJSV):
        Remove usage of backslash to escape newlines in string literal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 17 May 2011 19:29:25 +0000 (19:29 +0000)]
2011-05-17  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
        https://bugs.webkit.org/show_bug.cgi?id=60895

        Update the tools to handle the move.  Lucid 32 results now go in
        chromium-linux-x86 and the default platform on Linux is now x86_64.

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
        * Scripts/webkitpy/layout_tests/port/base.py: ditto
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
        * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 17 May 2011 19:26:11 +0000 (19:26 +0000)]
2011-05-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Area element doesn't update region when dynamically altered.
        https://bugs.webkit.org/show_bug.cgi?id=54636

        * fast/images/imagemap-dynamic-area-updates-expected.txt: Added.
        * fast/images/imagemap-dynamic-area-updates.html: Added.
        * fast/images/script-tests/imagemap-dynamic-area-updates.js: Added.
        (setArea):
        (checkForArea):
2011-05-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Area element doesn't update region when dynamically altered.
        https://bugs.webkit.org/show_bug.cgi?id=54636

        Recompute the clickable region after the "shape" or "coords" attribute
        of an area element is changed.

        Test: fast/images/imagemap-dynamic-area-updates.html

        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::parseMappedAttribute):
        (WebCore::HTMLAreaElement::invalidateCachedRegion):
        * html/HTMLAreaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 17 May 2011 19:00:51 +0000 (19:00 +0000)]
2011-05-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Initial support for favicons.
        https://bugs.webkit.org/show_bug.cgi?id=58937

        Add the following API to QWKContext:

        - void setIconDatabasePath(QString)
        - void iconChangedForPageURL(QUrl) [signal]
        - QIcon iconForPageURL(QUrl)

        This is mostly analogous to the QWebSettings/QWebFrame icon API we had in WebKit1.

        * UIProcess/API/qt/ClientImpl.h: Added WKIconDatabaseClient methods.

        * UIProcess/API/qt/ClientImpl.cpp:
        (toQWKContext): Helper to cast from "void* clientInfo" to a QWKContext*.
        (qt_wk_didChangeIconForPageURL): Emits QWKContext::iconChangedForPageURL(QUrl).
        (qt_wk_didRemoveAllIcons): Stub.

        * UIProcess/API/qt/qwkcontext.h:
        * UIProcess/API/qt/qwkcontext_p.h:
        * UIProcess/API/qt/qwkcontext.cpp:
        (QWKContextPrivate::QWKContextPrivate): Set up and register a WKIconDatabaseClient.
        (QWKContext::QWKContext): Minor refactor to avoid code duplication in constructors.
        (QWKContext::setIconDatabasePath): Exactly what it sounds like.
        (QWKContext::iconForPageURL): Retrieves the favicon for a given page URL as a QIcon.

        * WebKit2API.pri: Add WKIconDatabase.cpp and WKIconDatabase.h to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
luiz@webkit.org [Tue, 17 May 2011 19:00:37 +0000 (19:00 +0000)]
[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
https://bugs.webkit.org/show_bug.cgi?id=60440

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Makes sure that the HTTP headers Content-type and Content-length are not included in
the requests that do not have any content.

Tests: http/tests/navigation/post-301-response.html
       http/tests/navigation/post-302-response.html
       http/tests/navigation/post-303-response.html
       http/tests/navigation/post-307-response.html

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendNetworkRequest):

LayoutTests:

These new tests check that no POST content is sent to the new URL after receiving http
status codes 301, 302 and 303, and checks that the POST content is sent to the new URL
after receiving a 307 http status code.

* http/tests/navigation/post-301-response-expected.txt: Added.
* http/tests/navigation/post-301-response.html: Added.
* http/tests/navigation/post-302-response-expected.txt: Added.
* http/tests/navigation/post-302-response.html: Added.
* http/tests/navigation/post-303-response-expected.txt: Added.
* http/tests/navigation/post-303-response.html: Added.
* http/tests/navigation/post-307-response-expected.txt: Added.
* http/tests/navigation/post-307-response.html: Added.
* http/tests/navigation/resources/redirected-post-request-contents.php: Added.
* http/tests/navigation/resources/redirection-response.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 4 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
beidson@apple.com [Tue, 17 May 2011 18:57:54 +0000 (18:57 +0000)]
Part 4 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

This patch actually hooks up the shim to the WebProcess shim callbacks, which messages these
4 calls up to the UIProcess and returns the result.

Note that this patch uncovered the fact that CoreIPC can't sync message out from a secondary thread,
so I filed https://bugs.webkit.org/show_bug.cgi?id=60975 as a followup to allow that.

* Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::SecItemResponseData): Reorder the constructor arguments to be
  a little cleaner.
* Shared/mac/SecItemResponseData.h:

Call the shim callbacks for each method:
* WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):

Implement the shim callbacks, which each marshall to the main thread, which then calls out to CoreIPC:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebSecItemCopyMatchingMainThread):
(WebKit::WebSecItemCopyMatching):
(WebKit::WebSecItemAddOnMainThread):
(WebKit::WebSecItemAdd):
(WebKit::WebSecItemUpdateOnMainThread):
(WebKit::WebSecItemUpdate):
(WebKit::WebSecItemDeleteOnMainThread):
(WebKit::WebSecItemDelete):

Add the 4 messages and their implementations in the UIProcess:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/mac/WebProcessProxyMac.mm: Added.
(WebKit::WebProcessProxy::secItemCopyMatching):
(WebKit::WebProcessProxy::secItemAdd):
(WebKit::WebProcessProxy::secItemUpdate):
(WebKit::WebProcessProxy::secItemDelete):

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 17 May 2011 18:37:32 +0000 (18:37 +0000)]
2011-05-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] GraphicsLayerQtImpl: Remove an unused variable.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 17 May 2011 18:08:02 +0000 (18:08 +0000)]
2011-05-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Incomplete page painting at dropbox.com
        https://bugs.webkit.org/show_bug.cgi?id=60974
        <rdar://problem/9448213>

        When we're exiting compositing mode and haven't sent an EnterAcceleratedCompositingMode
        message to the UI process, we still need to send the updated bits to the ui process.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 3 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
beidson@apple.com [Tue, 17 May 2011 18:06:20 +0000 (18:06 +0000)]
Part 3 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add CoreIPC stuff we'll need to marshall the SecItem calls to the UIProcess and back.

Teach ArgumentCodersCF about CFDateRef, SecKeychainItemRef, and generic CFTypeRefs:
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):
* Shared/cf/ArgumentCodersCF.h:

Serializable object that contains the query CFDictionaryRef and optionally the
"attributesToMatch" CFDictionaryRef:
* Shared/mac/SecItemRequestData.cpp: Added.
(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):
* Shared/mac/SecItemRequestData.h: Added.
(WebKit::SecItemRequestData::query):
(WebKit::SecItemRequestData::attributesToMatch):

Serializable object that returns an OSStatus and optionally a "result object" CFTypeRef:
* Shared/mac/SecItemResponseData.cpp: Added.
(WebKit::SecItemResponseData::SecItemResponseData):
(WebKit::SecItemResponseData::encode):
(WebKit::SecItemResponseData::decode):
* Shared/mac/SecItemResponseData.h: Added.
(WebKit::SecItemResponseData::resultObject):
(WebKit::SecItemResponseData::resultCode):

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 2 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
beidson@apple.com [Tue, 17 May 2011 17:39:59 +0000 (17:39 +0000)]
Part 2 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Hookup some of the methods we plan to shim in the patch, but just have them call through
to the actual implementations for now.

Also stub-out the future shimmed versions of the methods.

* WebProcess/mac/WebProcessShim.h: Add the methods to the shim callbacks.
* WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecItemCopyMatching): Call through to the actual function for now.
(WebKit::shimSecItemAdd): Ditto.
(WebKit::shimSecItemUpdate): Ditto.
(WebKit::shimSecItemDelete): Ditto.
(WebKit::WebKitWebProcessShimInitialize): Copy over the shim callbacks.
* WebKit2.xcodeproj/project.pbxproj: Link the shim to required frameworks.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebSecItemCopyMatching): Add placeholders for the future to-be-shimmed functions.
(WebKit::WebSecItemAdd): Ditto.
(WebKit::WebSecItemUpdate): Ditto.
(WebKit::WebSecItemDelete): Ditto.
(WebKit::WebProcess::initializeShim): Pass along those placeholders to the shim initializer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 17 May 2011 17:27:19 +0000 (17:27 +0000)]
2011-05-17  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: navigating from elements panel does not show source view.
        https://bugs.webkit.org/show_bug.cgi?id=60970

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.highlightLine):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Sakamuri Ramakrishna <ramakrishna.sakamuri@nokia.com>
commit-queue@webkit.org [Tue, 17 May 2011 17:25:15 +0000 (17:25 +0000)]
2011-05-17  Sakamuri Ramakrishna  <ramakrishna.sakamuri@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] 4 of the skipped storage layout tests pass on Qt Linux- skip list to be modified
        https://bugs.webkit.org/show_bug.cgi?id=60715

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 17 May 2011 17:23:35 +0000 (17:23 +0000)]
2011-05-17  Anton Muhin  <antonm@chromium.org>

        Unreviewed.

        Improving test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Sam Magnuson <smagnuson@netflix.com>
andreas.kling@nokia.com [Tue, 17 May 2011 17:16:26 +0000 (17:16 +0000)]
2011-05-17  Sam Magnuson  <smagnuson@netflix.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Node that have both an opacity and a transform animation on them seem not to fire.
        https://bugs.webkit.org/show_bug.cgi?id=40841

        Test: compositing/animation/busy-indicator.html

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::recache):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        (WebCore::GraphicsLayerQt::setContentsToImage):
        (WebCore::TransformAnimationQt::getAnimatedProperty):
        (WebCore::OpacityAnimationQt::getAnimatedProperty):
        (WebCore::GraphicsLayerQt::addAnimation):
2011-05-17  Sam Magnuson  <smagnuson@netflix.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Node that have both an opacity and a transform animation on them seem not to fire.
        https://bugs.webkit.org/show_bug.cgi?id=40841

        * compositing/animation/busy-indicator-no.png: Added.
        * compositing/animation/busy-indicator.html: Added.
        * compositing/animation/busy-indicator.png: Added.
        * compositing/animation/busy-indicator-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Grace Kloba <klobag@chromium.org>
commit-queue@webkit.org [Tue, 17 May 2011 17:13:03 +0000 (17:13 +0000)]
2011-05-17  Grace Kloba  <klobag@chromium.org>

        Reviewed by Kenneth Russell.

        GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
        https://bugs.webkit.org/show_bug.cgi?id=60965

        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart one of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id...
beidson@apple.com [Tue, 17 May 2011 17:12:37 +0000 (17:12 +0000)]
Part one of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add am empty shim for a new WebProcess shim and install it at launch.

Use the same Shim.xcconfig for both the web and plugin processes:
* Configurations/PluginProcessShim.xcconfig: Removed.
* Configurations/Shim.xcconfig: Copied from Configurations/PluginProcessShim.xcconfig.
* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/WebProcess.h: Add initializeShim() for Mac-only
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim): Initialize the (empty) shim callbacks.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): Call initializeShim()

* WebProcess/mac/WebProcessShim.h: Added.
* WebProcess/mac/WebProcessShim.mm: Added.
(WebKit::WebKitWebProcessShimInitialize): Empty for now.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Install the Plugin Process shim for plugin processes
  and the WebProcess shim for the web content process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 17 May 2011 17:05:55 +0000 (17:05 +0000)]
2011-05-17  Andreas Kling  <kling@webkit.org>

        Bot-matching rebaseline after r86675.

        * platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLoose end from fix for https://bugs.webkit.org/show_bug.cgi?id=60938
sullivan@apple.com [Tue, 17 May 2011 16:57:11 +0000 (16:57 +0000)]
Loose end from fix for https://bugs.webkit.org/show_bug.cgi?id=60938

Reviewed by Adam Roben.

* WebKit2.xcodeproj/project.pbxproj:
Made new header file "private" instead of "project" so clients can access it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 17 May 2011 16:34:39 +0000 (16:34 +0000)]
2011-05-17  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] rebaseline skipped tests after r83871
        https://bugs.webkit.org/show_bug.cgi?id=60961

        Rebaseline tests after r83871 and remove them from Qt Skipped file.

        * platform/qt/Skipped:
        * platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
        * platform/qt/http/tests/misc/error404-expected.txt:
        * platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
        * platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
        * platform/qt/http/tests/misc/iframe404-expected.txt:
        * platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
        * platform/qt/http/tests/uri/css-href-expected.txt:
        * platform/qt/tables/layering/paint-test-layering-1-expected.txt:
        * platform/qt/tables/layering/paint-test-layering-2-expected.txt:
        * platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
        * platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
        * platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
        * platform/qt/tables/mozilla/other/slashlogo-expected.txt:
        * platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
        * platform/qt/transforms/2d/transform-fixed-container-expected.txt:
        * platform/qt/transitions/svg-text-shadow-transition-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 17 May 2011 16:24:53 +0000 (16:24 +0000)]
2011-05-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Enter/Tab after editing a CSS property does not invoke editor on next field
        https://bugs.webkit.org/show_bug.cgi?id=60962

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.updateStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit2 needs layoutTestController.overridePreference.
jberlin@webkit.org [Tue, 17 May 2011 16:03:18 +0000 (16:03 +0000)]
WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197

Add fast/images/animated-gif-restored-from-bfcache.html to the mac-wk2 Skipped list to get
the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Tue, 17 May 2011 14:39:09 +0000 (14:39 +0000)]
2011-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86660.
        http://trac.webkit.org/changeset/86660
        https://bugs.webkit.org/show_bug.cgi?id=60958

        broke search in console panel (Requested by podivilov on
        #webkit).

        * http/tests/inspector/change-iframe-src.html:
        * http/tests/inspector/console-resource-errors.html:
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        * http/tests/inspector/network/network-size-chunked.html:
        * http/tests/inspector/network/network-size-sync.html:
        * http/tests/inspector/network/network-size.html:
        * http/tests/inspector/network/network-timing.html:
        * http/tests/inspector/resource-tree/resource-tree-frame-add.html:
        * http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/console/console-uncaught-exception.html:
        * inspector/debugger/debugger-autocontinue-on-syntax-error.html:
        * inspector/styles/styles-iframe.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
2011-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86660.
        http://trac.webkit.org/changeset/86660
        https://bugs.webkit.org/show_bug.cgi?id=60958

        broke search in console panel (Requested by podivilov on
        #webkit).

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.show):
        (WebInspector.ConsoleView.prototype.afterShow):
        (WebInspector.ConsoleView.prototype.hide):
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show.animationFinished):
        (WebInspector.Drawer.prototype.show):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake run-api-tests work on Windows when there are spaces in the path
aroben@apple.com [Tue, 17 May 2011 13:29:57 +0000 (13:29 +0000)]
Make run-api-tests work on Windows when there are spaces in the path

Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
spaces in the path to TestWebKitAPI.exe

Reviewed by David Levin.

* Scripts/run-api-tests:
(runTestTool): Use the "direct object" form of system() to avoid having the path to
TestWebKitAPI.exe be split by the shell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 17 May 2011 13:06:59 +0000 (13:06 +0000)]
2011-05-17  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed warning fix introduced by r86377.

        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 17 May 2011 11:51:10 +0000 (11:51 +0000)]
2011-05-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper
        https://bugs.webkit.org/show_bug.cgi?id=60945

        Add ThreadableWebSocketChannelClientWrapper.cpp. Uninline methods in this class and
        move these definitions into .cpp in order to allow further modifications in this class.

        No new tests, as this is just refactoring.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp: Added.
        (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
        (WebCore::ThreadableWebSocketChannelClientWrapper::create):
        (WebCore::ThreadableWebSocketChannelClientWrapper::clearSyncMethodDone):
        (WebCore::ThreadableWebSocketChannelClientWrapper::setSyncMethodDone):
        (WebCore::ThreadableWebSocketChannelClientWrapper::syncMethodDone):
        (WebCore::ThreadableWebSocketChannelClientWrapper::sent):
        (WebCore::ThreadableWebSocketChannelClientWrapper::setSent):
        (WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount):
        (WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount):
        (WebCore::ThreadableWebSocketChannelClientWrapper::clearClient):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        (WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
        (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
        (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 17 May 2011 11:39:33 +0000 (11:39 +0000)]
2011-05-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
        https://bugs.webkit.org/show_bug.cgi?id=60901

        To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
        make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 17 May 2011 11:36:55 +0000 (11:36 +0000)]
2011-05-17  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Support shadowed text in fast font path.
        https://bugs.webkit.org/show_bug.cgi?id=60462

        * platform/graphics/Font.cpp:
        (WebCore::Font::drawText): Remove complex path shortcut for shadowed text.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawGlyphs): Paint shadows for simple text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 17 May 2011 11:34:53 +0000 (11:34 +0000)]
2011-05-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Construct GraphicsLayerQtImpl::State with correct values.
        https://bugs.webkit.org/show_bug.cgi?id=60902

        The GraphicsLayerQtImpl initial state should match the initial values
        of the corresponding GraphicsLayer flags.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::State::State):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-12 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Tue, 17 May 2011 10:12:12 +0000 (10:12 +0000)]
2011-05-12  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        IndexedDB: Index population should ignore records without key for index
        https://bugs.webkit.org/show_bug.cgi?id=60697

        Test that we can create a new index for which not all current records
        have a key.

        * storage/indexeddb/index-basics-expected.txt:
        * storage/indexeddb/index-basics.html:
2011-05-12  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        IndexedDB: Index population should ignore records without key for index
        https://bugs.webkit.org/show_bug.cgi?id=60697

        When populating a new index, records which do not have a key on the
        index's key path should be ignored.

        * storage/IDBObjectStoreBackendImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Tue, 17 May 2011 09:46:54 +0000 (09:46 +0000)]
2011-05-17  Young Han Lee  <joybro@company100.net>

        Reviewed by Csaba Osztrogon√°c.

        [Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
        https://bugs.webkit.org/show_bug.cgi?id=60947

        No new tests. Build fix.

        * platform/graphics/qt/TextureMapperQt.cpp:
        (WebCore::TextureMapper::create):
        * platform/graphics/qt/TextureMapperQt.h:
        (WebCore::TextureMapperQt::create):
        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        (WebCore::GraphicsLayer::create):
2011-05-17  Young Han Lee  <joybro@company100.net>

        Reviewed by Csaba Osztrogon√°c.

        [Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
        https://bugs.webkit.org/show_bug.cgi?id=60947

        * WebCoreSupport/PageClientQt.cpp:
        (WebCore::PageClientQWidget::setRootGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 17 May 2011 09:34:49 +0000 (09:34 +0000)]
2011-05-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
        https://bugs.webkit.org/show_bug.cgi?id=60890

        * inspector/styles/up-down-numerics-and-colors-expected.txt:
        * inspector/styles/up-down-numerics-and-colors.html:
2011-05-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
        https://bugs.webkit.org/show_bug.cgi?id=60890

        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.alteredFloatNumber):
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 17 May 2011 09:31:52 +0000 (09:31 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        The following tests are flaky on Linux.
        fast/speech/input-appearance-numberandspeech.html
        fast/speech/input-appearance-searchandspeech.html
        fast/speech/input-appearance-speechbutton.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 17 May 2011 09:11:52 +0000 (09:11 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        fast/js/mozilla/strict/eval-variable-environment.html now passes.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 17 May 2011 08:59:56 +0000 (08:59 +0000)]
2011-05-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: merge ConsoleView into ConsolePanel.
        https://bugs.webkit.org/show_bug.cgi?id=54670

        * http/tests/inspector/change-iframe-src.html:
        * http/tests/inspector/console-resource-errors.html:
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
        * http/tests/inspector/network/network-size-chunked.html:
        * http/tests/inspector/network/network-size-sync.html:
        * http/tests/inspector/network/network-size.html:
        * http/tests/inspector/network/network-timing.html:
        * http/tests/inspector/resource-tree/resource-tree-frame-add.html:
        * http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/console/console-uncaught-exception.html:
        * inspector/debugger/debugger-autocontinue-on-syntax-error.html:
        * inspector/styles/styles-iframe.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
2011-05-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: merge ConsoleView into ConsolePanel.
        https://bugs.webkit.org/show_bug.cgi?id=54670

        Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
        will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsolePanel.prototype.get toolbarItemLabel):
        (WebInspector.ConsolePanel.prototype.show):
        (WebInspector.ConsolePanel.prototype.hide):
        (WebInspector.ConsolePanel.prototype.showInDrawer):
        (WebInspector.ConsolePanel.prototype.afterShowInDrawer):
        (WebInspector.ConsolePanel.prototype.hideInDrawer):
        (WebInspector.ConsolePanel.prototype.addMessage):
        (WebInspector.ConsolePanel.prototype.clearMessages):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show.animationFinished):
        (WebInspector.Drawer.prototype.show):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 17 May 2011 07:37:11 +0000 (07:37 +0000)]
2011-05-16  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: WebSocketHandshake prints a carriage return to console
        https://bugs.webkit.org/show_bug.cgi?id=60880

        * http/tests/websocket/tests/handshake-error-expected.txt:
        Remove a carriage return in the first line.

2011-05-16  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: WebSocketHandshake prints a carriage return to console
        https://bugs.webkit.org/show_bug.cgi?id=60880

        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readStatusLine):
        WebSocketHandshake should not print a carriage return to console. To fix this,
        we first check whether the status line ends with CRLF. After that,
        we can print the first (lineLength - 2) characters of the status line
        which do not contain a carriage return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 17 May 2011 06:59:15 +0000 (06:59 +0000)]
2011-05-16  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        http/tests/appcache/interrupted-update.html is flaky on win, mac, and linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 17 May 2011 06:12:46 +0000 (06:12 +0000)]
2011-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86653.
        http://trac.webkit.org/changeset/86653
        https://bugs.webkit.org/show_bug.cgi?id=60944

        "Caused regressions on Windows, OSX and EFL" (Requested by
        yutak on #webkit).

        * DerivedSources.make:
        * DerivedSources.pro:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * create_hash_table:
        * heap/Heap.cpp:
        (JSC::TypeCounter::operator()):
        * interpreter/CallFrame.h:
        (JSC::ExecState::arrayTable):
        (JSC::ExecState::numberTable):
        * runtime/ArrayConstructor.cpp:
        (JSC::ArrayConstructor::ArrayConstructor):
        * runtime/ArrayConstructor.h:
        * runtime/ArrayPrototype.cpp:
        (JSC::ArrayPrototype::getOwnPropertySlot):
        (JSC::ArrayPrototype::getOwnPropertyDescriptor):
        * runtime/ArrayPrototype.h:
        * runtime/BooleanPrototype.cpp:
        (JSC::BooleanPrototype::BooleanPrototype):
        * runtime/BooleanPrototype.h:
        * runtime/DateConstructor.cpp:
        (JSC::DateConstructor::DateConstructor):
        * runtime/DateConstructor.h:
        * runtime/ErrorPrototype.cpp:
        (JSC::ErrorPrototype::ErrorPrototype):
        * runtime/ErrorPrototype.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::~JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::addStaticGlobals):
        (JSC::JSGlobalObject::getOwnPropertySlot):
        (JSC::JSGlobalObject::getOwnPropertyDescriptor):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncJSCPrint):
        * runtime/JSGlobalObjectFunctions.h:
        * runtime/MathObject.cpp:
        * runtime/NumberConstructor.cpp:
        (JSC::NumberConstructor::getOwnPropertySlot):
        (JSC::NumberConstructor::getOwnPropertyDescriptor):
        * runtime/NumberPrototype.cpp:
        (JSC::NumberPrototype::NumberPrototype):
        * runtime/NumberPrototype.h:
        * runtime/ObjectPrototype.cpp:
        (JSC::ObjectPrototype::ObjectPrototype):
        (JSC::ObjectPrototype::put):
        (JSC::ObjectPrototype::getOwnPropertySlot):
        * runtime/ObjectPrototype.h:
        * runtime/RegExpPrototype.cpp:
        (JSC::RegExpPrototype::RegExpPrototype):
        * runtime/RegExpPrototype.h:
        * runtime/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):
        * runtime/StringConstructor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 17 May 2011 05:55:27 +0000 (05:55 +0000)]
2011-05-16  MORITA Hajime  <morrita@google.com>

        Unreviewed build fix for r86647, which broke SUPPORT_AUTOCORRECTION_PANEL.

        * editing/SpellingCorrectionController.cpp:
        (WebCore::markersHaveIdenticalDescription):
        (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
        (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 17 May 2011 05:11:49 +0000 (05:11 +0000)]
2011-05-16  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        svg/hixie/perf/00{1,2}.xml now pass on Linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 17 May 2011 04:26:25 +0000 (04:26 +0000)]
2011-05-16  Kent Tamura  <tkent@chromium.org>

        Fix Leopard build.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepUpFromRenderer): Use double instead of int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 17 May 2011 04:08:18 +0000 (04:08 +0000)]
2011-05-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Geoffrey Garen.

        Global object initialization is expensive
        https://bugs.webkit.org/show_bug.cgi?id=60933

        Changed a bunch of globals to allocate their properties lazily, and changed
        the global object to allocate a bunch of its globals lazily.

        This reduces the footprint of a global object from 287 objects with 58
        functions for 24K to 173 objects with 20 functions for 15K.

        Large patch, but it's all mechanical.

        * DerivedSources.make:
        * JavaScriptCore.exp: Build!

        * create_hash_table: Added a special case for fromCharCode, since it uses
        a custom "thunk generator".

        * heap/Heap.cpp:
        (JSC::TypeCounter::operator()): Fixed a bug where the type counter would
        overcount objects that were owned through more than one mechanism because
        it was getting in the way of counting the results for this patch.

        * interpreter/CallFrame.h:
        (JSC::ExecState::arrayConstructorTable):
        (JSC::ExecState::arrayPrototypeTable):
        (JSC::ExecState::booleanPrototypeTable):
        (JSC::ExecState::dateConstructorTable):
        (JSC::ExecState::errorPrototypeTable):
        (JSC::ExecState::globalObjectTable):
        (JSC::ExecState::numberConstructorTable):
        (JSC::ExecState::numberPrototypeTable):
        (JSC::ExecState::objectPrototypeTable):
        (JSC::ExecState::regExpPrototypeTable):
        (JSC::ExecState::stringConstructorTable): Added new tables.

        * runtime/ArrayConstructor.cpp:
        (JSC::ArrayConstructor::ArrayConstructor):
        (JSC::ArrayConstructor::getOwnPropertySlot):
        (JSC::ArrayConstructor::getOwnPropertyDescriptor):
        * runtime/ArrayConstructor.h:
        (JSC::ArrayConstructor::createStructure):
        * runtime/ArrayPrototype.cpp:
        (JSC::ArrayPrototype::getOwnPropertySlot):
        (JSC::ArrayPrototype::getOwnPropertyDescriptor):
        * runtime/ArrayPrototype.h:
        * runtime/BooleanPrototype.cpp:
        (JSC::BooleanPrototype::BooleanPrototype):
        (JSC::BooleanPrototype::getOwnPropertySlot):
        (JSC::BooleanPrototype::getOwnPropertyDescriptor):
        * runtime/BooleanPrototype.h:
        (JSC::BooleanPrototype::createStructure):
        * runtime/DateConstructor.cpp:
        (JSC::DateConstructor::DateConstructor):
        (JSC::DateConstructor::getOwnPropertySlot):
        (JSC::DateConstructor::getOwnPropertyDescriptor):
        * runtime/DateConstructor.h:
        (JSC::DateConstructor::createStructure):
        * runtime/ErrorPrototype.cpp:
        (JSC::ErrorPrototype::ErrorPrototype):
        (JSC::ErrorPrototype::getOwnPropertySlot):
        (JSC::ErrorPrototype::getOwnPropertyDescriptor):
        * runtime/ErrorPrototype.h:
        (JSC::ErrorPrototype::createStructure): Standardized these objects
        to use static tables for function properties.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::~JSGlobalData):
        * runtime/JSGlobalData.h: Added new tables.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::addStaticGlobals):
        (JSC::JSGlobalObject::getOwnPropertySlot):
        (JSC::JSGlobalObject::getOwnPropertyDescriptor):
        * runtime/JSGlobalObject.h:
        * runtime/JSGlobalObjectFunctions.cpp:
        * runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a
        static table for its global functions. This required uninlining some
        things to avoid a circular header dependency. However, those things
        probably shouldn't have been inlined in the first place.

        Even more global object properties can be made lazy, but that requires
        more in-depth changes.

        * runtime/MathObject.cpp:
        * runtime/NumberConstructor.cpp:
        (JSC::NumberConstructor::getOwnPropertySlot):
        (JSC::NumberConstructor::getOwnPropertyDescriptor):
        * runtime/NumberPrototype.cpp:
        (JSC::NumberPrototype::NumberPrototype):
        (JSC::NumberPrototype::getOwnPropertySlot):
        (JSC::NumberPrototype::getOwnPropertyDescriptor):
        * runtime/NumberPrototype.h:
        (JSC::NumberPrototype::createStructure):
        * runtime/ObjectPrototype.cpp:
        (JSC::ObjectPrototype::ObjectPrototype):
        (JSC::ObjectPrototype::put):
        (JSC::ObjectPrototype::getOwnPropertySlot):
        (JSC::ObjectPrototype::getOwnPropertyDescriptor):
        * runtime/ObjectPrototype.h:
        (JSC::ObjectPrototype::createStructure):
        * runtime/RegExpPrototype.cpp:
        (JSC::RegExpPrototype::RegExpPrototype):
        (JSC::RegExpPrototype::getOwnPropertySlot):
        (JSC::RegExpPrototype::getOwnPropertyDescriptor):
        * runtime/RegExpPrototype.h:
        (JSC::RegExpPrototype::createStructure):
        * runtime/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):
        (JSC::StringConstructor::getOwnPropertySlot):
        (JSC::StringConstructor::getOwnPropertyDescriptor):
        * runtime/StringConstructor.h:
        (JSC::StringConstructor::createStructure): Standardized these objects
        to use static tables for function properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 17 May 2011 02:51:18 +0000 (02:51 +0000)]
2011-05-16  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Decouple LayerChromium/CCLayerImpl trees
        https://bugs.webkit.org/show_bug.cgi?id=58830

        Makes the CCLayerImpl tree self-hosting and provides an explicit step
        to synchronize the LayerChromium tree to the CCLayerImpl tree.
        Tested by compositing/ layout tests and by unit tests in WebKit/chromium.

        * WebCore.gypi:
        * platform/graphics/chromium/CanvasLayerChromium.cpp:
        (WebCore::CanvasLayerChromium::createCCLayerImpl):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        (WebCore::LayerChromium::cleanupResources):
        (WebCore::LayerChromium::dumpLayer):
        (WebCore::LayerChromium::dumpLayerProperties):
        (WebCore::LayerChromium::createCCLayerImpl):
        (WebCore::LayerChromium::ccLayerImpl):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::id):
        (WebCore::LayerChromium::setCCLayerImpl):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/PluginLayerChromium.cpp:
        (WebCore::PluginLayerChromium::createCCLayerImpl):
        * platform/graphics/chromium/TreeSynchronizer.cpp: Added.
        (WebCore::TreeSynchronizer::addCCLayerImplsToMapRecursive):
        (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
        (WebCore::TreeSynchronizer::synchronizeTrees):
        * platform/graphics/chromium/TreeSynchronizer.h:
        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::createCCLayerImpl):
        * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
        (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
        * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
        (WebCore::CCCanvasLayerImpl::create):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::CCLayerImpl):
        (WebCore::CCLayerImpl::addChild):
        (WebCore::CCLayerImpl::removeFromParent):
        (WebCore::CCLayerImpl::removeAllChildren):
        (WebCore::CCLayerImpl::clearChildList):
        (WebCore::CCLayerImpl::descendantsDrawsContent):
        (WebCore::CCLayerImpl::drawsContent):
        (WebCore::CCLayerImpl::updateCompositorResources):
        * platform/graphics/chromium/cc/CCLayerImpl.h:
        (WebCore::CCLayerImpl::create):
        (WebCore::CCLayerImpl::parent):
        (WebCore::CCLayerImpl::children):
        (WebCore::CCLayerImpl::setMaskLayer):
        (WebCore::CCLayerImpl::maskLayer):
        (WebCore::CCLayerImpl::setReplicaLayer):
        (WebCore::CCLayerImpl::replicaLayer):
        (WebCore::CCLayerImpl::id):
        (WebCore::CCLayerImpl::owner):
        (WebCore::CCLayerImpl::setParent):
        * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
        (WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
        * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
        (WebCore::CCPluginLayerImpl::create):
        * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
        (WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
        * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
        (WebCore::CCVideoLayerImpl::create):
2011-05-16  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.
        https://bugs.webkit.org/show_bug.cgi?id=58830

        Add unit tests for the compositor's TreeSynchronizer.

        * WebKit.gypi:
        * tests/TreeSynchronizerTest.cpp: Added.
        (WebCore::MockCCLayerImpl::create):
        (WebCore::MockCCLayerImpl::~MockCCLayerImpl):
        (WebCore::MockCCLayerImpl::setCCLayerDestructionList):
        (WebCore::MockCCLayerImpl::MockCCLayerImpl):
        (WebCore::MockLayerChromium::create):
        (WebCore::MockLayerChromium::~MockLayerChromium):
        (WebCore::MockLayerChromium::createCCLayerImpl):
        (WebCore::MockLayerChromium::pushPropertiesTo):
        (WebCore::MockLayerChromium::MockLayerChromium):
        (WebCore::expectTreesAreIdentical):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 17 May 2011 02:49:16 +0000 (02:49 +0000)]
2011-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86648.
        http://trac.webkit.org/changeset/86648
        https://bugs.webkit.org/show_bug.cgi?id=60941

        media/controls-css-overload.html still failing on non-GPU
        tests (Requested by scherkus on #webkit).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Tue, 17 May 2011 02:34:25 +0000 (02:34 +0000)]
2011-05-16  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
        https://bugs.webkit.org/show_bug.cgi?id=60871

        * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added expected results.
        * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added test patterns when initial values are empty.
2011-05-16  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
        https://bugs.webkit.org/show_bug.cgi?id=60871

        Test: fast/forms/input-stepup-stepdown-from-renderer.html

        In number input type, if the value is not a number, including empty, the currect valued is assumed 0.
        But we have to handle it separately from the case when the value is actuall "0".

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepUpFromRenderer): Added cliping for default value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 17 May 2011 01:42:14 +0000 (01:42 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove bogus ASSERT in Document::setCompatibilityMode
        https://bugs.webkit.org/show_bug.cgi?id=60935

        This test case triggers the ASSERT.

        * fast/parser/append-child-followed-by-document-write-expected.txt: Added.
        * fast/parser/append-child-followed-by-document-write.html: Added.
2011-05-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove bogus ASSERT in Document::setCompatibilityMode
        https://bugs.webkit.org/show_bug.cgi?id=60935

        The ASSERT is invalid when the parser is in the initial state and the
        document is non-empty, which is strange but not impossible.

        Test: fast/parser/append-child-followed-by-document-write.html

        * dom/Document.cpp:
        (WebCore::Document::setCompatibilityMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 17 May 2011 01:14:55 +0000 (01:14 +0000)]
2011-05-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating expectation for media/controls-css-overload.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 17 May 2011 01:11:13 +0000 (01:11 +0000)]
2011-05-16  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Refactoring] Member variables of DocumentMarker should be encapsulated.
        https://bugs.webkit.org/show_bug.cgi?id=56814

        - Moved DocumentMarker's member variables to private and added getters for them.
        - Added DocumentMarker setters and constructors, which contain assertions against m_type values
          because description and activeMatch are used with specific type of MarkerType.
        - Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController because
          it accesses DocumentMarker internals.
        - Moved a version of DMC::addMarker() to private and add alternatives that hide
          internals of DocumentMarker. (The internal will be renewed by upcoming change.)

        * dom/DocumentMarker.h:
        (WebCore::DocumentMarker::type):
        (WebCore::DocumentMarker::startOffset):
        (WebCore::DocumentMarker::endOffset):
        (WebCore::DocumentMarker::description):
        (WebCore::DocumentMarker::hasDescription):
        (WebCore::DocumentMarker::activeMatch):
        (WebCore::DocumentMarker::clearDescription):
        (WebCore::DocumentMarker::setStartOffset):
        (WebCore::DocumentMarker::setEndOffset):
        (WebCore::DocumentMarker::operator==):
        (WebCore::DocumentMarker::DocumentMarker):
        (WebCore::DocumentMarker::shiftOffsets):
        (WebCore::DocumentMarker::setActiveMatch):
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::addMarker):
        (WebCore::DocumentMarkerController::addTextMatchMarker):
        (WebCore::DocumentMarkerController::copyMarkers):
        (WebCore::DocumentMarkerController::removeMarkers):
        (WebCore::DocumentMarkerController::markerContainingPoint):
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::renderedRectsForMarkers):
        (WebCore::DocumentMarkerController::removeMarkersFromList):
        (WebCore::DocumentMarkerController::repaintMarkers):
        (WebCore::DocumentMarkerController::shiftMarkers):
        (WebCore::DocumentMarkerController::setMarkersActive):
        (WebCore::DocumentMarkerController::hasMarkers):
        (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
        (WebCore::DocumentMarkerController::showMarkers):
        * dom/DocumentMarkerController.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartHasMarkerFor):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::respondToChangedSelection):
        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::shouldStartTimerFor):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::spellingToolTip):
        (WebCore::HitTestResult::replacedString):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
2011-05-16  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Refactoring] Member variables of DocumentMarker should be encapsulated.
        https://bugs.webkit.org/show_bug.cgi?id=56814

        Moved addMarker() implementation to
        WebCore::DocumentMarkerController::addTextMatchMarker().

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::addMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 17 May 2011 01:01:33 +0000 (01:01 +0000)]
2011-05-16  Martin Robinson  <mrobinson@igalia.com>

        Fix the Cairo build for older versions of GTK+.

        * platform/gtk/GtkWidgetBackingStoreX11.cpp: Include GtkVersioning.h to
        satisfy older versions of GTK+ 2.x.
2011-05-16  Martin Robinson  <mrobinson@igalia.com>

        Take another shot at fixing the WinCairo build.

        * Shared/cairo/LayerTreeContextCairo.cpp: Include NotImplemented.h using a framework include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 17 May 2011 00:53:52 +0000 (00:53 +0000)]
2011-05-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Jon Honeycutt.

        Add access to process pid in WebKit2 API
        https://bugs.webkit.org/show_bug.cgi?id=60938

        * UIProcess/API/C/mac/WKPagePrivateMac.cpp: Added.
        (WKPageGetProcessIdentifier):
        * UIProcess/API/C/mac/WKPagePrivateMac.h: Added.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::processIdentifier):
        * UIProcess/WebPageProxy.h:
        * WebKit2.xcodeproj/project.pbxproj:
        Add WKPageGetProcessIdentifier as SPI for the mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Ian Henderson <ianh@apple.com>
commit-queue@webkit.org [Tue, 17 May 2011 00:50:20 +0000 (00:50 +0000)]
2011-05-16  Ian Henderson  <ianh@apple.com>

        Reviewed by Joseph Pecoraro.

        Page::goToItem doesn't work while loading is deferred
        https://bugs.webkit.org/show_bug.cgi?id=60412

        * loader/navigation-while-deferring-loads-expected.txt: Added.
        * loader/navigation-while-deferring-loads.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-16  Ian Henderson  <ianh@apple.com>

        Reviewed by Joseph Pecoraro.

        Page::goToItem doesn't work while loading is deferred
        https://bugs.webkit.org/show_bug.cgi?id=60412

        If goToItem is called while loading is deferred, save the arguments
        and try again later instead of doing nothing.

        Test: loader/navigation-while-deferring-loads.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setDefersLoading):
        Pipe the "defersLoading" state into HistoryController.
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::HistoryController):
        (WebCore::HistoryController::goToItem):
        Save the HistoryItem and FrameLoadType if loading is deferred.
        (WebCore::HistoryController::setDefersLoading):
        If we have a saved HistoryItem after resuming, try going to it.
        * loader/HistoryController.h:
        * page/Page.cpp:
        (WebCore::Page::goToItem):
        No longer bail early if loading is deferred, since HistoryController
        now handles this case.
2011-05-16  Ian Henderson  <ianh@apple.com>

        Reviewed by Joseph Pecoraro.

        Page::goToItem doesn't work while loading is deferred
        https://bugs.webkit.org/show_bug.cgi?id=60412

        Add setDefersLoading and goBack methods to LayoutTestController.  We
        need to use goBack() instead of history.back() because the latter goes
        through NavigationScheduler, hence doesn't exhibit the bug.

        * DumpRenderTree/LayoutTestController.cpp:
        (goBackCallback):
        (setDefersLoadingCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::goBack):
        (LayoutTestController::setDefersLoading):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::goBack):
        (LayoutTestController::setDefersLoading):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::goBack):
        (LayoutTestController::setDefersLoading):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::goBack):
        (LayoutTestController::setDefersLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 17 May 2011 00:31:51 +0000 (00:31 +0000)]
2011-05-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, checking in new baselines for media/video-canvas-alpha.html for chromium-gpu-{linux,win}.

        * platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
        * platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 17 May 2011 00:27:34 +0000 (00:27 +0000)]
2011-05-16  Martin Robinson  <mrobinson@igalia.com>

        Add file missing from my previous commit.

        * Shared/cairo/LayerTreeContextCairo.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 17 May 2011 00:22:23 +0000 (00:22 +0000)]
2011-05-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, un-skipping a few Chromium layout test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Tue, 17 May 2011 00:21:05 +0000 (00:21 +0000)]
2011-05-16  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86625.
        http://trac.webkit.org/changeset/86625
        https://bugs.webkit.org/show_bug.cgi?id=60719

        Caused failed assertion on Chromium gpu canary bots

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::create):
        (WebCore::ContentLayerChromium::ContentLayerChromium):
        (WebCore::ContentLayerChromium::~ContentLayerChromium):
        (WebCore::ContentLayerChromium::paintContentsIfDirty):
        (WebCore::ContentLayerChromium::setLayerRenderer):
        (WebCore::ContentLayerChromium::createTilerIfNeeded):
        (WebCore::ContentLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/ContentLayerChromium.h:
        (WebCore::ContentLayerChromium::drawsContent):
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        (WebCore::ImageLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerPainterChromium.h: Removed.
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
        * platform/graphics/chromium/LayerTextureSubImage.h: Removed.
        * platform/graphics/chromium/LayerTextureUpdater.h: Removed.
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Removed.
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::setLayerRenderer):
        (WebCore::LayerTilerChromium::setTileSize):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::uploadCanvas):
        (WebCore::LayerTilerChromium::updateFromPixels):
        (WebCore::LayerTilerChromium::draw):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::Tile::Tile):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
2011-05-16  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86625.
        http://trac.webkit.org/changeset/86625
        https://bugs.webkit.org/show_bug.cgi?id=60719

        Caused failed assertion on Chromium gpu canary bots

        * src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo need to compile .js files, that is what the JIT is for.
mitz@apple.com [Mon, 16 May 2011 23:50:16 +0000 (23:50 +0000)]
No need to compile .js files, that is what the JIT is for.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Mon, 16 May 2011 23:48:16 +0000 (23:48 +0000)]
2011-05-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, marking media/video-transformed.html as passing on all platforms.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 23:43:35 +0000 (23:43 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Attempt to fix baselines for xss-DENIED-set-opener.html.  This is too hard.

        * platform/chromium-linux/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
        * platform/chromium-win-vista/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 23:40:21 +0000 (23:40 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Attempt to fix baselines for set-href-attribute-hash.html.  This is too hard.

        * platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
        * platform/chromium-win-vista/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=60927
antti@apple.com [Mon, 16 May 2011 23:39:09 +0000 (23:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60927
fastCheckSelector() does not inline correctly in all cases

Reviewed by Dave Kilzer.

Use anonymous namespace instead of static qualifier to get internal linkage.
Use functions as template arguments instead of classes.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Martin Robinson <martin.james.robinson@gmail.com>
mrobinson@webkit.org [Mon, 16 May 2011 23:36:55 +0000 (23:36 +0000)]
2011-05-16  Martin Robinson  <martin.james.robinson@gmail.com>

        Try to fix the WinCairo build after r86612.

        Move the LayerTreeContextGtk.cpp stub to LayerTreeContextCairo.cpp and add
        it to the WinCairo build.

        * GNUmakefile.am: Update the source list.
        * Shared/cairo/LayerTreeContextCairo.cpp: Renamed from Source/WebKit2/Shared/gtk/LayerTreeContextGtk.cpp.
        * win/WebKit2.vcproj: Update the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 16 May 2011 23:36:22 +0000 (23:36 +0000)]
2011-05-16  Chris Rogers  <crogers@google.com>

        Unreviewed build fix.

        Just return "nullptr" to fix compile errors
        https://bugs.webkit.org/show_bug.cgi?id=60932

        * platform/audio/mac/AudioBusMac.mm:
        (WebCore::AudioBus::loadPlatformResource):
        * platform/audio/mac/AudioFileReaderMac.cpp:
        (WebCore::AudioFileReader::createBus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Mon, 16 May 2011 23:33:51 +0000 (23:33 +0000)]
2011-05-16  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Replace docTop/Right/Bottom/Left/Width/Height with documentRect
        https://bugs.webkit.org/show_bug.cgi?id=60743

        Change RenderView::documentRect to compute rect once rather than four times.
        Replace all uses of docTop/Right/Bottom/Left/Width/Height with documentRect to
        simplify the code and reduce complexity.

        Covered by existing tests.

        * WebCore.exp.in:
        * page/FrameView.cpp:
        (WebCore::FrameView::adjustViewSize):
        (WebCore::FrameView::forceLayoutForPagination):
        * page/PrintContext.cpp:
        (WebCore::PrintContext::computePageRects):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintRootBoxFillLayers):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateRootLayerPosition):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::documentRect):
        * rendering/RenderView.h:
2011-05-16  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Replace docTop/Right/Bottom/Left/Width/Height with documentRect
        https://bugs.webkit.org/show_bug.cgi?id=60743

        Replace uses of docWidth/Height with documentRect.

        * WebView/WebFrame.mm:
        (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 16 May 2011 23:32:31 +0000 (23:32 +0000)]
2011-05-16  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] shard V8DerivedSources into 19 files
        https://bugs.webkit.org/show_bug.cgi?id=60926

        This reduces the clobber build time by 4s on my machine.  It helps
        by making the slowest to compile V8DerivedSources faster (and thus
        more parallelizable).  With 8 files, the 3 slowest are 23s, 18s and
        10s.  With 19 files, the 3 slowest are 16s, 10s, and 10s.

        * WebCore.gyp/WebCore.gyp:
        * storage/IDBObjectStore.h: Fix a missing include that was working
          because a different .cpp file before it was including the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-16 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 16 May 2011 23:13:14 +0000 (23:13 +0000)]
2011-05-16  Chris Rogers  <crogers@google.com>

        Unreviewed build fix.

        Fix web audio enabled mac port compile errors
        https://bugs.webkit.org/show_bug.cgi?id=60930

        * platform/audio/mac/AudioBusMac.mm:
        (WebCore::AudioBus::loadPlatformResource):
        * platform/audio/mac/AudioFileReaderMac.cpp:
        (WebCore::AudioFileReader::createBus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86630 268f45cc-cd09-0410-ab3c-d52691b4dbfc