kenneth@webkit.org [Mon, 16 Nov 2009 13:43:11 +0000 (13:43 +0000)]
Rubberstamped by Simon Hausmann.
Added new Qt expected results for animation tests.
* platform/qt/animations/change-transform-in-end-event-expected.txt: Added.
* platform/qt/animations/state-at-end-event-expected.txt: Added.
* platform/qt/animations/state-at-end-event-transform-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 13:34:54 +0000 (13:34 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
The commit-queue should use land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31548
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 13:25:11 +0000 (13:25 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547
Also fixes a bug in workqueue and adds a test!
* Scripts/bugzilla-tool:
* Scripts/modules/workqueue.py:
* Scripts/modules/workqueue_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 16 Nov 2009 13:20:31 +0000 (13:20 +0000)]
Fix Qt build on Windows CE 6.
Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-11-16
Reviewed by Simon Hausmann.
* JavaScriptCore.pri: Add missing include path.
* wtf/Platform.h: Include ce_time.h for Windows CE 6.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 13:05:10 +0000 (13:05 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547
Also fixes a bug in workqueue and adds a test!
* Scripts/bugzilla-tool:
* Scripts/modules/workqueue.py:
* Scripts/modules/workqueue_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 12:29:21 +0000 (12:29 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move StyleQueue over to using PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31544
That's what the class it's for.
* Scripts/bugzilla-tool:
* Scripts/modules/patchcollection.py:
* Scripts/modules/patchcollection_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 12:11:54 +0000 (12:11 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31543
Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 12:04:18 +0000 (12:04 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Disable the style queue from posting to the commit queue status page.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 11:54:21 +0000 (11:54 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541
This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.
* Scripts/modules/patchcollection.py: Added.
* Scripts/modules/patchcollection_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 11:47:56 +0000 (11:47 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541
This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.
* Scripts/modules/patchcollection.py: Added.
* Scripts/modules/patchcollection_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 11:31:30 +0000 (11:31 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool check-style should work with attachment ids instead of bug ids
https://bugs.webkit.org/show_bug.cgi?id=31540
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 11:04:09 +0000 (11:04 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WorkQueue is the only place that should know about special exit codes
https://bugs.webkit.org/show_bug.cgi?id=31534
Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
and add tests for handling exit codes.
I also cleaned up workqueue_unittest.py more.
* Scripts/bugzilla-tool:
* Scripts/modules/workqueue.py:
* Scripts/modules/workqueue_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 11:02:32 +0000 (11:02 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Re-factor workqueue_unittest to allow for more than one test.
https://bugs.webkit.org/show_bug.cgi?id=31535
* Scripts/modules/workqueue_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 11:00:24 +0000 (11:00 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532
* Scripts/bugzilla-tool: fix a couple obvious typos.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 10:50:50 +0000 (10:50 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532
The next patch will move these methods into WebKitLandingScripts.
* Scripts/bugzilla-tool:
- Split out _land_patch and _close_bug_if_no_active_patches.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 10:45:32 +0000 (10:45 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix silly copy-and-paste code. I am a terrible coder.
* Scripts/modules/bugzilla.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 10:34:46 +0000 (10:34 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement a StyleQueue
https://bugs.webkit.org/show_bug.cgi?id=31537
The first iteration of the style queue only produces output locally.
There is also a limit of 10 patches because it's not that useful to
iterate through the entire review queue at this point. We can remove
the limit later.
* Scripts/bugzilla-tool:
* Scripts/modules/bugzilla.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 09:25:03 +0000 (09:25 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Unit test WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=31531
Adds basic unit testing for WorkQueue. Just runs through one cycle.
* Scripts/bugzilla-tool:
* Scripts/modules/statusbot.py:
* Scripts/modules/workqueue.py:
* Scripts/modules/workqueue_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 08:49:00 +0000 (08:49 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=31530
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 08:39:15 +0000 (08:39 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs apply-attachment
https://bugs.webkit.org/show_bug.cgi?id=31528
* Scripts/bugzilla-tool:
- Add ApplyAttachment command.
- Abstract applying code into WebKitApplyingScripts.
- Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
* Scripts/modules/bugzilla.py:
- Add fetch_attachment and bug_id_for_attachment_id.
* Scripts/modules/bugzilla_unittest.py:
- Add test for new parsing.
- Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 16 Nov 2009 08:38:57 +0000 (08:38 +0000)]
2009-11-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Document check-style's use of force_clean.
* Scripts/bugzilla-tool:
* Scripts/modules/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 08:28:18 +0000 (08:28 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move WorkQueue to its own file
https://bugs.webkit.org/show_bug.cgi?id=31529
WorkQueue and WorkQueueDelegate are separate concerns from
bugzilla-tool. Also added a missing include to logging.py.
* Scripts/bugzilla-tool:
* Scripts/modules/logging.py:
* Scripts/modules/workqueue.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 08:11:58 +0000 (08:11 +0000)]
2009-11-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Siedel.
Move OutputTee to logging.py.
* Scripts/bugzilla-tool:
* Scripts/modules/logging.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Nov 2009 08:07:38 +0000 (08:07 +0000)]
2009-11-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Refactor bugzilla-tool to allow for multiple queues
https://bugs.webkit.org/show_bug.cgi?id=31513
Divide the commit queue class into three class to make creating
additional queues easier.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 16 Nov 2009 06:19:03 +0000 (06:19 +0000)]
Fixing broken layout test.
Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516
Lists are not supported on Leopard or Tiger, so the test for this
bug needs to be skipped.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Mon, 16 Nov 2009 06:02:09 +0000 (06:02 +0000)]
2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
svn-apply may not handle git patches created by bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31457
* Scripts/modules/scm.py:
* Scripts/modules/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 16 Nov 2009 04:44:33 +0000 (04:44 +0000)]
2009-11-15 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
Correct an error in the previous commit
* public/WebAccessibilityRole.h: It should be WebAccessibilityRoleDirectory,
not WebAccessibilityDirectoryRole.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 16 Nov 2009 03:48:22 +0000 (03:48 +0000)]
2009-11-15 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
Bring WebAccessibilityRole up to sync after
http://trac.webkit.org/changeset/51007.
* public/WebAccessibilityRole.h: Added WebAccessibilityRoleDirectory.
* src/AssertMatchingEnums.cpp: Added a match between DirectoryRole and
WebAccessibilityRoleDirectory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 16 Nov 2009 02:05:24 +0000 (02:05 +0000)]
Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-directory.html
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isOrderedList):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::createARIARoleMap):
WebKit/mac:
Fix a spelling error in the comment of a localized (accessibility) string.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
LayoutTests:
* platform/mac/accessibility/aria-directory-expected.txt: Added.
* platform/mac/accessibility/aria-directory.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 15 Nov 2009 23:34:04 +0000 (23:34 +0000)]
2009-11-15 Dave Tapuska <dtapuska@rim.com>
Reviewed by George Staikos.
Compare UChars single unit at a time as opposed to the uint32_t
approach as casting to unaligned addresses may cause a bus failure
on ARMv5 and below. This change replicates the same defines that
exists in AtomicString.cpp
https://bugs.webkit.org/show_bug.cgi?id=31475
* platform/text/StringHash.h:
(WebCore::StringHash::equal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 15 Nov 2009 23:32:34 +0000 (23:32 +0000)]
2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
bugzilla-tool should post git binary diff
https://bugs.webkit.org/show_bug.cgi?id=31458
Add --binary option to Git.create_patch.
* Scripts/modules/scm.py:
* Scripts/modules/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 15 Nov 2009 23:29:31 +0000 (23:29 +0000)]
2009-11-15 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
https://bugs.webkit.org/show_bug.cgi?id=31490
* bindings/v8/V8DOMWrapper.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 15 Nov 2009 23:28:02 +0000 (23:28 +0000)]
2009-11-15 Maxime Simon <simon.maxime@gmail.com>
Reviewed by Adam Barth.
[Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
* platform/haiku/FileChooserHaiku.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 15 Nov 2009 23:26:36 +0000 (23:26 +0000)]
2009-11-15 Maxime Simon <simon.maxime@gmail.com>
Reviewed by Adam Barth.
[Haiku] Build fix. ColorSpace name had a wrong CamelCase.
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::setPlatformStrokeColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 15 Nov 2009 23:24:34 +0000 (23:24 +0000)]
2009-11-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add bugzilla-tool check-style
https://bugs.webkit.org/show_bug.cgi?id=31515
* Scripts/bugzilla-tool:
* Scripts/modules/bugzilla.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 15 Nov 2009 23:15:07 +0000 (23:15 +0000)]
2009-11-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r50999.
http://trac.webkit.org/changeset/50999
Need to fix some issues in the Windows build. Missed some places where
RenderTextControl::isEdited is called.
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::setInnerTextValue):
(WebCore::RenderTextControl::setUserEdited):
(WebCore::RenderTextControl::subtreeHasChanged):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::isEdited):
(WebCore::RenderTextControl::setEdited):
(WebCore::RenderTextControl::isUserEdited):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 15 Nov 2009 22:55:41 +0000 (22:55 +0000)]
2009-11-15 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31186
Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.
No functionality was changed. So, no tests were included.
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::setInnerTextValue):
(WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
(WebCore::RenderTextControl::subtreeHasChanged):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
(WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
(WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 14 Nov 2009 20:55:09 +0000 (20:55 +0000)]
WebCore: Fix for <rdar://problem/
6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
Reviewed by Dan Bernstein.
Test: fast/overflow/line-clamp.html
* css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
* css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
* css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
* rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
if there is anchor as the last child box, still allow adding the ellipsis.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
(WebCore::RenderLayer::scrollRectToVisible): ditto.
* WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
* rendering/style/LineClampValue.h: Added.
(WebCore::LineClampValue::LineClampValue):
(WebCore::LineClampValue::value):
(WebCore::LineClampValue::isPercentage):
(WebCore::LineClampValue::isNone):
(WebCore::LineClampValue::operator==):
(WebCore::LineClampValue::operator!=):
* rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
* rendering/style/RenderStyle.h: Use LineClampValue.
(WebCore::InheritedFlags::lineClamp):
(WebCore::InheritedFlags::setLineClamp):
(WebCore::InheritedFlags::initialLineClamp):
* rendering/style/StyleRareNonInheritedData.h:
LayoutTests: Test for <rdar://problem/
6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
Reviewed by Dan Bernstein.
* fast/overflow/line-clamp.html: Added.
* platform/mac/fast/overflow/line-clamp-expected.checksum: Added.
* platform/mac/fast/overflow/line-clamp-expected.png: Added.
* platform/mac/fast/overflow/line-clamp-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 14 Nov 2009 17:53:34 +0000 (17:53 +0000)]
2009-11-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/
7287487>
Do not use QuickTime version to detect media controller theme
* WebCore.base.exp: Export wkMediaControllerThemeAvailable
* platform/mac/WebCoreSystemInterface.h: Ditto.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2009-11-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/
7287487>
Do not use QuickTime version to detect media controller theme
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Initialize wkMediaControllerThemeAvailable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Sat, 14 Nov 2009 15:21:46 +0000 (15:21 +0000)]
2009-11-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add tests for reading/writing .type property of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=29004
* fast/forms/input-type-change3-expected.txt: Added.
* fast/forms/input-type-change3.html: Added.
* fast/forms/script-tests/input-type-change3.js: Added.
2009-11-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
- Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
They have no dedicated UI and no type validation for now.
- Clean up setInputType() and formControlType() of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=29004
Test: fast/forms/input-type-change3.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::valueMissing):
(WebCore::HTMLInputElement::patternMismatch):
(WebCore::HTMLInputElement::tooLong):
(WebCore::createTypeMap): Initializer for a static local variable.
(WebCore::HTMLInputElement::setInputType):
(WebCore::createFormControlTypes): Initializer for a static local variable.
(WebCore::HTMLInputElement::formControlType):
(WebCore::HTMLInputElement::saveFormControlState):
(WebCore::HTMLInputElement::restoreFormControlState):
(WebCore::HTMLInputElement::accessKeyAction):
(WebCore::HTMLInputElement::rendererIsNeeded):
(WebCore::HTMLInputElement::createRenderer):
(WebCore::HTMLInputElement::appendFormData):
(WebCore::HTMLInputElement::isTextField):
(WebCore::HTMLInputElement::valueWithDefault):
(WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::isRequiredFormControl):
(WebCore::HTMLInputElement::dataList):
* html/HTMLInputElement.h: Add new values to InputType enum, and define numberOfTypes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Sat, 14 Nov 2009 14:08:35 +0000 (14:08 +0000)]
Skip new test that needs new DRT infrastructure, with bug filled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 14 Nov 2009 06:24:43 +0000 (06:24 +0000)]
WAI-ARIA: checkbox does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=31456
Reviewed by Darin Adler.
WebCore:
Test: accessibility/aria-checkbox-text.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
LayoutTests:
* accessibility/aria-checkbox-text.html: Added.
* platform/gtk/Skipped:
* platform/mac/accessibility/aria-checkbox-text-expected.txt: Added.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 14 Nov 2009 04:54:15 +0000 (04:54 +0000)]
WebCore:
2009-11-13 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
This is just enough changes to unbreak the port.
* bindings/v8/ScriptController.cpp:
(WebCore::mainThreadNormalWorld):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::initContextIfNeeded):
* loader/FrameLoaderClient.h:
WebKit/chromium:
2009-11-13 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Rename windowObjectCleared to dispatchDidClearWindowObjectInWorld
to catch up http://trac.webkit.org/changeset/50973.
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
* src/FrameLoaderClientImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Sat, 14 Nov 2009 03:34:08 +0000 (03:34 +0000)]
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix for Chromium build.
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Provide an empty implementation of this method because I don't know
what it is supposed to do on Chromium.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Sat, 14 Nov 2009 03:11:06 +0000 (03:11 +0000)]
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix for Chromium build.
* loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
public, as Chromium's V8Proxy calls it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Sat, 14 Nov 2009 02:58:50 +0000 (02:58 +0000)]
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix to Chromium build.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Sat, 14 Nov 2009 02:45:28 +0000 (02:45 +0000)]
2009-11-13 Aaron Boodman <aa@chromium.org>
Unreviewed fix for Chromium build.
* platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 14 Nov 2009 02:29:50 +0000 (02:29 +0000)]
2009-11-13 Adam Barth <abarth@webkit.org>
Unreviewed partial build fix for Chromium. Should fix failure #4.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* bindings/v8/ScriptController.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::initContextIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 14 Nov 2009 02:18:30 +0000 (02:18 +0000)]
2009-11-13 Adam Barth <abarth@webkit.org>
Unreviewed partial build fix for Chromium.
* bindings/v8/ScriptController.h:
(WebCore::ScriptController::getAllWorlds):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 14 Nov 2009 01:47:33 +0000 (01:47 +0000)]
Disable websocket tests on Tiger, as they time out.
Filed <https://bugs.webkit.org/show_bug.cgi?id=31501> to investigate this issue.
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 14 Nov 2009 01:40:45 +0000 (01:40 +0000)]
2009-11-13 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium WebKit Port to compile as dynamic lib
https://bugs.webkit.org/show_bug.cgi?id=31478
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 14 Nov 2009 01:33:49 +0000 (01:33 +0000)]
wx build fix after r50923 change to externalRepresentation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Sat, 14 Nov 2009 01:22:56 +0000 (01:22 +0000)]
woo
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Sat, 14 Nov 2009 01:07:01 +0000 (01:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31050
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-13
Reviewed by Gavin Barraclough.
Adding optimization support for mode JSVALUE32_64
on ARM systems.
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Sat, 14 Nov 2009 00:44:42 +0000 (00:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31050
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-14
Reviewed by Gavin Barraclough.
Adding JSVALUE32_64 support for ARM (but not turning it
on by default). All optimizations must be disabled, since
this patch is only the first of a series of patches.
During the work, a lot of x86 specific code revealed and
made platform independent.
See revisions: 50531 50541 50593 50594 50595
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fdivd_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::set8):
(JSC::MacroAssemblerARM::setTest8):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::zeroDouble):
* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
* wtf/StdLibExtras.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 14 Nov 2009 00:39:40 +0000 (00:39 +0000)]
2009-11-13 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
* WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
* WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Sat, 14 Nov 2009 00:27:25 +0000 (00:27 +0000)]
2009-11-12 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitry Titov.
LocalStorage quota should include key sizes in its count
https://bugs.webkit.org/show_bug.cgi?id=31451
* storage/StorageMap.cpp:
(WebCore::StorageMap::setItem):
Count keys in the quota when adding a new item.
(WebCore::StorageMap::removeItem):
Remove the key's length from the quota if we're removing the item.
(WebCore::StorageMap::importItem):
Assume that we're adding things for the first time.
Count keys in the quota.
2009-11-12 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitry Titov.
Now that we're tracking key size in the quota, we can't fit as much in.
https://bugs.webkit.org/show_bug.cgi?id=31451
* storage/domstorage/quota-expected.txt:
* storage/domstorage/script-tests/quota.js:
(testQuota):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 14 Nov 2009 00:25:35 +0000 (00:25 +0000)]
2009-11-13 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Added to the WebKit Coding Style Guidelines not to use
"using namespace" statements in header files.
* coding/coding-style.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 14 Nov 2009 00:09:41 +0000 (00:09 +0000)]
2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Eric Seidel.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
Adding isAlphanumeric abstraction, required
by TextBoundaries.cpp.
* wtf/unicode/glib/UnicodeGLib.h:
(WTF::Unicode::isAlphanumeric):
* wtf/unicode/icu/UnicodeIcu.h:
(WTF::Unicode::isAlphanumeric):
2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Eric Seidel.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
Moving TextBoundariesICU.cpp to TextBoundaries.cpp
by removing the direct ICU dependency and replacing it
with WTF functions and WebCore's own TextBreakIterator
abstractions.
* GNUmakefile.am:
* platform/graphics/gtk/SimpleFontDataGtk.cpp:
* platform/text/TextBoundaries.cpp: Added.
(WebCore::findNextWordFromIndex):
(WebCore::findWordBoundary):
* platform/text/TextBoundariesICU.cpp: Removed.
* platform/text/TextBreakIterator.h:
* platform/text/TextBreakIteratorICU.cpp:
(WebCore::textBreakLast):
(WebCore::textBreakPrevious):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Sat, 14 Nov 2009 00:07:03 +0000 (00:07 +0000)]
2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
WebCore::externalRepresentation should update layout before getting render object
https://bugs.webkit.org/show_bug.cgi?id=31459
Before this change, the render tree output for this test was wrong.
Note that #FF0000 (red) becomes #008000 (green) now.
* platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
WebCore::externalRepresentation should update layout before getting render object
https://bugs.webkit.org/show_bug.cgi?id=31459
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 14 Nov 2009 00:06:25 +0000 (00:06 +0000)]
Update WebKitSystemInterface.
Reviewed by Dan Bernstein.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 23:56:13 +0000 (23:56 +0000)]
Build fix
* Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 23:49:05 +0000 (23:49 +0000)]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Fixes <http://webkit.org/b/31124>.
Reviewed by Dave Hyatt.
WebCore:
Tell FrameLoaderClient when window objects in isolated worlds are
cleared
Test: http/tests/security/isolatedWorld/didClearWindowObject.html
* bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
worlds in m_worldSet to the passed-in Vector.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds): Added. Calls through to
WebCoreJSClientData.
(WebCore::ScriptController::initScript): Changed to call
FrameLoader::dispatchDidClearWindowObjectInWorld.
* bindings/js/ScriptController.h: Added getAllWorlds.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Updated for FrameLoaderClient change.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::begin):
Changed to call dispatchDidClearWindowObjectsInAllWorlds.
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
Added. Retrieves all the worlds, then calls through to
dispatchDidClearWindowObjectInWorld for each one.
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
dispatchWindowObjectAvailable. Calls up to the client, then, if the
world is the mainThreadNormalWorld(), tells the Inspector about it,
too.
* loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
dispatchDidClearWindowObjectInWorld. Added
dispatchDidClearWindowObjectsInAllWorlds.
* loader/FrameLoaderClient.h: Replaced windowObjectCleared with
dispatchDidClearWindowObjectForWorld.
WebKit:
Add WebFrameLoadDelegatePrivat.h to WebKit.xcodeproj
* WebKit.xcodeproj/project.pbxproj: Added
WebFrameLoadDelegatePrivate.h, which already existed.
WebKit/gtk:
Update for changes to FrameLoaderClient
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
* WebCoreSupport/FrameLoaderClientGtk.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKit/haiku:
Update for changes to FrameLoaderClient
* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::dispatchDidClearWindowObjectInWorld):
* WebCoreSupport/FrameLoaderClientHaiku.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKit/mac:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Replaced windowObjectCleared with this function. If the delegate
implements it, call
-webView:didClearWindowObjectForFrame:inScriptWorld:. Otherwise, if
the passed-in world is the mainThreadNormalWorld(), call
-webView:didClearWindowObject:forFrame:.
* WebView/WebDelegateImplementationCaching.h: Added a new entry in the
frame load delegate implementation cache for the new delegate method.
* WebView/WebFrameLoadDelegatePrivate.h:
* WebView/WebScriptWorld.mm:
(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(-[WebScriptWorld initWithWorld:]): Add ourselves to allWorlds().
(-[WebScriptWorld dealloc]): Remove ourselves from allWorlds().
(+[WebScriptWorld findOrCreateWorld:]): Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.
* WebView/WebScriptWorldInternal.h: Declared +findOrCreateWorld:.
* WebView/WebView.mm:
(-[WebView _cacheFrameLoadDelegateImplementations]): Cache the
implementation of the new frame load delegate method.
WebKit/qt:
Update for changes to FrameLoaderClient
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
* WebCoreSupport/FrameLoaderClientQt.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKit/win:
* Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added
didClearWindowObjectForFrameInScriptWorld.
* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld):
* WebFrame.h:
Replaced windowObjectCleared with this function. If the delegate
implements IWebFrameLoadDelegatePrivate2, call
didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
world is the mainThreadNormalWorld(), call
didClearWindowObjectForFrame.
* WebScriptWorld.cpp:
(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
(WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
(WebScriptWorld::standardWorld): Added this non-COM getter for the
standard world, which the COM getter now calls through to.
(WebScriptWorld::findOrCreateWorld): Added. Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.
* WebScriptWorld.h: Added new standardWorld overload, made one
overload of createInstance private, and added findOrCreateWorld.
WebKit/wx:
Update for changes to FrameLoaderClient
* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::dispatchDidClearWindowObjectInWorld):
* WebKitSupport/FrameLoaderClientWx.h:
Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().
WebKitTools:
Add support for
http/tests/security/isolatedWorld/didClearWindowObject.html
* DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
Added. Moved code here from -webView:didClearWindowObject:forFrame:.
(-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
Added. Sets a __worldID property on the global object whose value is
the ID of this world.
(-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
Respond to this new delegate callback by calling through to one of the
above new methods.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID for this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.
* DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didClearWindowObject): Moved code from hear to
didClearWindowObjectForFrameInStandardWorld.
(FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
Respond to this new delegate callback by calling through to one of the
below new methods.
(FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
Added. Sets a __worldID property on the gobal object whose value is
the ID of this world.
(FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
Added. Moved code here from didClearWindowObject.
* DumpRenderTree/win/FrameLoadDelegate.h: Added the
didClearWindowObjectForFrame* functions.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID of this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.
LayoutTests:
Test that delegates can modify global objects in isolated worlds
* http/tests/security/isolatedWorld/didClearWindowObject-expected.txt: Added.
* http/tests/security/isolatedWorld/didClearWindowObject.html: Added.
Tests that the global object in the normal world does not have a
__worldID property, and that the global object in isolated worlds has
a __worldID property whose value is equal to the world's ID.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 13 Nov 2009 23:46:30 +0000 (23:46 +0000)]
2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix SVG context assignment for pod types.
https://bugs.webkit.org/show_bug.cgi?id=31497
I broke this in r50958.
Tested by svg/custom/viewport-update2.svg.
* bindings/scripts/CodeGeneratorV8.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 13 Nov 2009 23:38:23 +0000 (23:38 +0000)]
Bring the platform/android files inline with Android 2.0
https://bugs.webkit.org/show_bug.cgi?id=31423
Patch by Andrei Popescu <andreip@google.com> on 2009-11-13
Reviewed by Dmitry Titov.
No new tests required: these are all Android-specific files.
* platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::files):
* platform/android/ClipboardAndroid.h:
* platform/android/FileChooserAndroid.cpp:
(WebCore::FileChooser::basenameForWidth):
(WebCore::fileButtonChooseFileLabel):
* platform/android/KeyEventAndroid.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::searchableIndexIntroduction):
(WebCore::resetButtonDefaultLabel):
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):
* platform/android/RenderThemeAndroid.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeAndroid::baselinePosition):
(WebCore::RenderThemeAndroid::paintButton):
(WebCore::adjustMenuListStyleCommon):
(WebCore::RenderThemeAndroid::paintCombo):
* platform/android/ScreenAndroid.cpp:
* platform/android/ScrollViewAndroid.cpp:
(WebCore::ScrollView::platformOffscreenContentRectangle):
* platform/android/TemporaryLinkStubs.cpp:
(JSC::Bindings::dispatchJNICall):
* platform/android/WidgetAndroid.cpp:
(WebCore::Widget::setFrameRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 23:21:33 +0000 (23:21 +0000)]
2009-11-13 Norbert Leser <norbert.leser&nokia.com>
Reviewed by Eric Seidel.
Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).
* JavaScriptCore.pri:
2009-11-13 Norbert Leser <norbert.leser&nokia.com>
Reviewed by Eric Seidel.
Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 13 Nov 2009 23:20:38 +0000 (23:20 +0000)]
Remove the unnecessary call to dumpDatabaseCallbacks().
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31495
* storage/hash-change-with-xhr.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 13 Nov 2009 21:51:22 +0000 (21:51 +0000)]
Implement composition events introduced in DOM Level 3.
This change adds a new IDL which defines the composition events, adds a class which
implements the composition events, and sends the composition events according to
the specification.
https://bugs.webkit.org/show_bug.cgi?id=26310
Patch by Hironori Bono <hbono@chromium.org> on 2009-11-13
Reviewed by Oliver Hunt.
WebCore:
Test: fast/events/ime-composition-events-001.html
* DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
* GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
* WebCore.gypi: ditto.
* WebCore.pro: ditto
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
* WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
* bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
* bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
* bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
(WebCore::V8DOMWrapper::convertEventToV8Object):
* bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
* bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
* dom/CompositionEvent.cpp: Implements the CompositionEvent class.
(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::~CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):
(WebCore::CompositionEvent::isCompositionEvent):
* dom/CompositionEvent.h: Declares the CompositionEvent class.
(WebCore::CompositionEvent::create):
(WebCore::CompositionEvent::data):
* dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
* dom/Event.cpp:
(WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
* dom/Event.h:
* dom/EventNames.h: Added composition{start,update,end} to eventNames.
* editing/Editor.cpp:
(WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
(WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
LayoutTests:
* fast/events/ime-composition-events-001-expected.txt: Added.
* fast/events/ime-composition-events-001.html: Added.
* platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
* platform/qt/Skipped: ditto.
* platform/win/Skipped: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
snej@chromium.org [Fri, 13 Nov 2009 21:26:38 +0000 (21:26 +0000)]
Fix a link error in unofficial GCC 4.4 builds on Linux.
https://bugs.webkit.org/show_bug.cgi?id=31477
Reviewed by Dimitri Glazkov.
* bindings/v8/V8Binding.cpp: Add explicit instantiations of v8StringToWebCoreString template.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 20:55:51 +0000 (20:55 +0000)]
2009-11-13 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix Debug build after http://trac.webkit.org/changeset/50960.
The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
https://bugs.webkit.org/show_bug.cgi?id=31213
* rendering/CounterNode.cpp:
(WebCore::showTreeAndMark):
* rendering/RenderCounter.cpp:
(WebCore::destroyCounterNodeChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 13 Nov 2009 20:50:33 +0000 (20:50 +0000)]
WebKitTools: Make the Qt Linux only --valgrind feature, suppress errors
defined in the SuppressedValgrindErrors file.
Reviewed by Simon Hausmann.
* Scripts/run-webkit-tests:
LayoutTests: Add a file for suppressing invalid valgrind errors (Qt / Linux only)
Reviewed by Simon Hausmann.
* platform/qt/SuppressedValgrindErrors: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 13 Nov 2009 20:42:16 +0000 (20:42 +0000)]
JSValueProtect and JSValueUnprotect don't protect API wrapper values
https://bugs.webkit.org/show_bug.cgi?id=31485
Reviewed by Geoff Garen.
Make JSValueProtect/Unprotect use a new 'toJS' function, 'toJSForGC' that
does not attempt to to strip out API wrapper objects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 13 Nov 2009 20:35:46 +0000 (20:35 +0000)]
2009-11-13 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha.
[CAIRO] shadow support for Canvas and SVG
[https://bugs.webkit.org/show_bug.cgi?id=30960]
We currently fill a path with solid color instead of filling
a clipping path. This causes problems on some composite operators,
since Cairo modifies the area outside the path.
This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
Thanks to Benjamin Otte for tracking the bug down.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 20:29:54 +0000 (20:29 +0000)]
2009-11-13 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Antti Koivisto.
Fix typo, ce_time.cpp should be ce_time.c
* JavaScriptCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 13 Nov 2009 20:25:06 +0000 (20:25 +0000)]
Adding Chromium's DatabaseTracker implementation.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31440
WebCore:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* storage/DatabaseTracker.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
* storage/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::updateDatabaseSize):
* storage/chromium/QuotaTracker.h:
WebKit/chromium:
* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::exceededDatabaseQuota):
* src/DatabaseObserver.cpp: Added.
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
* src/WebDatabase.cpp:
(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::toString):
(WebKit::WebSecurityOrigin::databaseIdentifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 20:21:44 +0000 (20:21 +0000)]
2009-11-13 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
https://bugs.webkit.org/show_bug.cgi?id=31213
Added tree navigation methods that permit full implementation of CSS2.1
counter feature without using recursion proportional to the counter
tree depth.
No new tests because I did not find any bug that is fixed by this
commit yet, this just reduces the size of the patch for 11031 and
helps respond to some concerns regarding that patch.
* rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::nextInPreOrderAfterChildren):
(WebCore::CounterNode::nextInPreOrder):
Added to support non-recursive tree traversal necessary for
efficient full implementation of CSS2.1 counters.
(WebCore::CounterNode::lastDescendant):
(WebCore::CounterNode::previousInPreOrder):
Moved this methods such that they occupy a place similar to that of
identically named methods on the render tree. This allows for their
broader use needed in full implementation of CSS2.1 counters.
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
Changed such that insertion/removal of a counter, triggers not only
recalculation of PrefixWidths, but also reassesment of values in
counter nodes. This is the basis full implementation of CSS2.1
counters. It does not change current behavior by much because of
changes needed to the recalculation algorithm, but those are comming
in the patch for 11031.
(WebCore::showTreeAndMark):
* rendering/CounterNode.h:
* rendering/RenderCounter.cpp:
(WebCore::counter):
Only changed argument type to prepare for implementation of Darin
Adler's recommendation for the patch to 11031.
(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeChildren):
(WebCore::RenderCounter::destroyCounterNodes):
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::invalidateCountersInContainer):
(WebCore::RenderObjectChildList::invalidateCounters):
* rendering/RenderObjectChildList.h:
Added the ability to restrict invalidation to counters with a given
identifier.
Also invalidated counters that are on the child container itself
which were missed by the previous algorithm, but were a valid case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 13 Nov 2009 20:04:24 +0000 (20:04 +0000)]
Set the locale to C and not to the current one in use on the system.
Reviewed by Simon Hausmann.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 19:56:43 +0000 (19:56 +0000)]
2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Protect SVG animated properties from destruction in bindings.
https://bugs.webkit.org/show_bug.cgi?id=31474
See http://crbug.com/26719.
Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
under Valgrind.
Made sure we keep a reference to SVG properties while setting a
context:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::withSVGContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 19:30:29 +0000 (19:30 +0000)]
Disable websocket tests on Windows, as the server cannot start on buildbot.
Filed <https://bugs.webkit.org/show_bug.cgi?id=31479> to investigate this issue.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 13 Nov 2009 19:21:24 +0000 (19:21 +0000)]
[CAIRO] shadow support for Canvas and SVG.
[https://bugs.webkit.org/show_bug.cgi?id=30960]
Reviewed by Alexey Proskuryakov.
Incorporate Benjamin Otte's recommendations to avoid
a buffer overrun, and small performance improvement.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::copyContextProperties): Correctly size output
storage for cairo_get_dash to avoid buffer overrun.
(WebCore::drawPathShadow): Prefer cairo_fill_extents
to slower cairo_stroke_extents when not drawing shadows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 19:19:39 +0000 (19:19 +0000)]
Restoring parst of ChangeLog that were somehow deleted with my latest commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 13 Nov 2009 19:14:56 +0000 (19:14 +0000)]
Do not register Chromium's HTML5 DB VFS as the default
VFS. Otherwise, other sqlite DB users in the same process will
stop working.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31462
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 18:51:48 +0000 (18:51 +0000)]
Windows build fix
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
avoiding a sign mismatch warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 18:47:40 +0000 (18:47 +0000)]
Release build fix.
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
Use ASSERT_UNUSED for unused stream parameter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 18:14:59 +0000 (18:14 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31441
Implement SocketStreamHandleCFNet
Existing WebSocket tests now pass on Mac. No proxy support yet.
* platform/network/SocketStreamHandleClient.h:
* platform/network/cf/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::shouldUseSSL):
(WebCore::SocketStreamHandle::refAuthenticationClient):
(WebCore::SocketStreamHandle::derefAuthenticationClient):
(WebCore::SocketStreamHandle::):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::chooseProxy):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::copyCFStreamDescription):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::receivedCredential):
(WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
(WebCore::SocketStreamHandle::receivedCancellation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 13 Nov 2009 18:07:03 +0000 (18:07 +0000)]
Fix worker-timeout.html layout test that fails in Chromium harness.
https://bugs.webkit.org/show_bug.cgi?id=31452
Reviewed by Darin Adler.
* fast/workers/worker-timeout.html:
Stop logging timer messages at the same time as calling NotifyDone() because
in test harness Chromium uses for workers it does not capture the output immediately.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 13 Nov 2009 17:51:15 +0000 (17:51 +0000)]
Build correction. No review.
The WinCairo build requires ENABLE_FILTERS to work properly.
* win/tools/vsprops/WinCairo.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 17:50:11 +0000 (17:50 +0000)]
2009-11-13 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling Chromium dependencies to match Chromium revision 31834.
https://bugs.webkit.org/show_bug.cgi?id=31445
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Nov 2009 17:26:27 +0000 (17:26 +0000)]
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: preload status bar button glyphs
in order to prevent them from flickering (take 2).
https://bugs.webkit.org/show_bug.cgi?id=31439
* inspector/front-end/inspector.js:
(preloadImages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Nov 2009 17:10:48 +0000 (17:10 +0000)]
2009-11-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Barth.
Chromium: [REGRESSION] Crash while stopping on a breakpoint.
Rolling back r50890.
https://bugs.webkit.org/show_bug.cgi?id=31467
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::canAccessPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 17:10:45 +0000 (17:10 +0000)]
Build fix
* Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
are order-dependent!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 17:05:38 +0000 (17:05 +0000)]
Touch WebKit.idl to fix the Windows build
* Interfaces/WebKit.idl: Sorted #includes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 16:58:58 +0000 (16:58 +0000)]
Finish replacing worldIDs with world objects
The only remaining use of worldIDs was in a method only used by DRT
for the isolated worlds tests.
Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
Reviewed by Mark Rowe.
WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
* WebView/WebFramePrivate.h:
Renamed from
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGobalObject:FromString:.
Now takes a WebScriptWorld instead of a worldID, so we don't need to
maintain a map of worldID -> world anymore.
WebKit/win:
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebFrame.h:
Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
IWebScriptWorld instead of a worldID, so we don't need to maintain a
map of worldID -> world anymore.
WebKitTools:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
Updated for changes to WebFrame. Now holds the map of worldID -> world
at this level instead of making WebKit do it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Nov 2009 16:43:10 +0000 (16:43 +0000)]
[Qt] Ensure the DRT does not output anything until first test is run
Reviewed by Simon Hausmann.
* DumpRenderTree/qt/DumpRenderTree.cpp:
* DumpRenderTree/qt/DumpRenderTree.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 13 Nov 2009 16:11:47 +0000 (16:11 +0000)]
Clear the undo stack in before each new test run.
Reviewed by Tor Arne Vestbø.
Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Nov 2009 15:06:34 +0000 (15:06 +0000)]
Update documentation for the Qt API
Reviewed by Simon Hausmann.
* Api/qgraphicswebview.cpp:
* Api/qwebelement.cpp:
* Api/qwebframe.cpp:
* Api/qwebsettings.cpp:
* Api/qwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 13 Nov 2009 14:57:13 +0000 (14:57 +0000)]
2009-11-13 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha.
[CAIRO] shadow support for Canvas and SVG
[https://bugs.webkit.org/show_bug.cgi?id=30960]
This is the fix of a regression, caused by the shadow patch
from the bug above. Reinserted the save and restore calls
that were accidently removed by the previous patch.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
Skip fast/canvas/canvas-shadow.html we need to enable filters
on cairo to pass this test.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 13:49:29 +0000 (13:49 +0000)]
2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable Page Cache if setMaximumPagesInCache needs it.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31266.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::setMaximumPagesInCache):
2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 13:21:34 +0000 (13:21 +0000)]
2009-11-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix initial QWebView focus behavior.
focusController->setFocused(true) was not always called.
https://bugs.webkit.org/show_bug.cgi?id=31466
* Api/qwebpage.cpp:
(QWebPagePrivate::focusInEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Nov 2009 13:12:35 +0000 (13:12 +0000)]
Use correct install-path when running qdoc3
Reviewed by Simon Hausmann.
* docs/docs.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc