WebKit-https.git
9 years ago[chromium] Add a layout test for losing the compositor context with a video playing
jamesr@google.com [Wed, 8 Feb 2012 21:47:51 +0000 (21:47 +0000)]
[chromium] Add a layout test for losing the compositor context with a video playing
https://bugs.webkit.org/show_bug.cgi?id=78060

Reviewed by Eric Carlson.

Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
frame to be displayed).

Prior to r106610 this test times out in debug and crashes in ASAN.

* platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
* platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
* platform/chromium/compositing/lost-compositor-context-with-video.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhoops, fix the build.
oliver@apple.com [Wed, 8 Feb 2012 21:46:42 +0000 (21:46 +0000)]
Whoops, fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove incorrect early exit in CCDamageTracker
shawnsingh@chromium.org [Wed, 8 Feb 2012 21:41:47 +0000 (21:41 +0000)]
[chromium] Remove incorrect early exit in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76924

Reviewed by James Robinson.

Source/WebCore:

New unit test added to CCDamageTrackerTest.cpp

This patch does three things: (1) adds unit test that demonstrates
that early exiting in CCDamageTracker is wrong, (2) removes the
early exit and cleans up the surrounding code, and (3) re-names
several functions in CCDamageTracker so that state updating is
implied by the name, and not just a bad side-effect of the functions.

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):
* platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream DumpRenderTreeBlackBerry
rwlbuis@webkit.org [Wed, 8 Feb 2012 21:37:31 +0000 (21:37 +0000)]
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream more parts of our DRT implementation.

* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/EventSender.cpp: Added.
* DumpRenderTree/blackberry/EventSender.h: Added.
* DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix issue encountered while debugging stacktraces
oliver@apple.com [Wed, 8 Feb 2012 21:35:34 +0000 (21:35 +0000)]
Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147

Reviewed by Gavin Barraclough.

Debugging is easier if we always ensure that we have a non-null
inferred name.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Check that we can make the SharedGraphicsContext3D current before returning
jamesr@google.com [Wed, 8 Feb 2012 21:32:54 +0000 (21:32 +0000)]
[chromium] Check that we can make the SharedGraphicsContext3D current before returning
https://bugs.webkit.org/show_bug.cgi?id=78142

Reviewed by Stephen White.

If we can't make the context current, we can't use it.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoupdateTopCallframe in the baseline JIT doesn't provide enough information to the...
oliver@apple.com [Wed, 8 Feb 2012 21:22:49 +0000 (21:22 +0000)]
updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145

Reviewed by Gavin Barraclough.

Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.

* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for pinch gesture processing in the MT compositor.
commit-queue@webkit.org [Wed, 8 Feb 2012 21:12:58 +0000 (21:12 +0000)]
Add support for pinch gesture processing in the MT compositor.
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-08
Reviewed by James Robinson.

* public/WebInputEvent.h:
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
* tests/WebCompositorInputHandlerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style failing with "Path does not exist."
dpranke@chromium.org [Wed, 8 Feb 2012 21:02:53 +0000 (21:02 +0000)]
check-webkit-style failing with "Path does not exist."
https://bugs.webkit.org/show_bug.cgi?id=77873

Reviewed by Ojan Vafai.

This change fixes the way the style checker determines which
Port class to use for a given test_expectations.txt path; the
previous version used a heuristic that didn't really work in the
first place.

* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
(TestExpectationsChecker.__init__):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.test_determine_port_from_expectations_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in Node::normalize.
inferno@chromium.org [Wed, 8 Feb 2012 20:53:54 +0000 (20:53 +0000)]
Crash in Node::normalize.
https://bugs.webkit.org/show_bug.cgi?id=78135

Reviewed by Ryosuke Niwa.

No new tests. Original testcase does not reduce to manageable
extent.

* dom/Node.cpp:
(WebCore::Node::normalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate pixel table test expectations for mac to match new DRT scrollbars
eae@chromium.org [Wed, 8 Feb 2012 20:42:19 +0000 (20:42 +0000)]
Update pixel table test expectations for mac to match new DRT scrollbars
https://bugs.webkit.org/show_bug.cgi?id=76938

Rubber stamped by Eric Seidel.

* platform/mac/tables/mozilla/bugs/bug101674-expected.png:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-3-expected.png:
* platform/mac/tables/mozilla/bugs/bug11944-expected.png:
* platform/mac/tables/mozilla/bugs/bug120364-expected.png:
* platform/mac/tables/mozilla/bugs/bug131020-expected.png:
* platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug22019-expected.png:
* platform/mac/tables/mozilla/bugs/bug23151-expected.png:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug29314-expected.png:
* platform/mac/tables/mozilla/bugs/bug32205-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug38916-expected.png:
* platform/mac/tables/mozilla/bugs/bug43039-expected.png:
* platform/mac/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug44505-expected.png:
* platform/mac/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug50695-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug56405-expected.png:
* platform/mac/tables/mozilla/bugs/bug67915-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/mac/tables/mozilla/bugs/bug92143-expected.png:
* platform/mac/tables/mozilla/bugs/bug96334-expected.png:
* platform/mac/tables/mozilla/bugs/bug96343-expected.png:
* platform/mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_height-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_height-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/columns-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/standards1-expected.png:
* platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebGL context current early to check validity
jamesr@google.com [Wed, 8 Feb 2012 20:39:37 +0000 (20:39 +0000)]
Make WebGL context current early to check validity
https://bugs.webkit.org/show_bug.cgi?id=78141

Patch by Antoine Labour <piman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Covered by existing tests

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Disable root layer clears on release builds.
commit-queue@webkit.org [Wed, 8 Feb 2012 20:35:06 +0000 (20:35 +0000)]
[chromium] Disable root layer clears on release builds.
https://bugs.webkit.org/show_bug.cgi?id=77478

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):

LayoutTests:

* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
* platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a content shadow layer to the render layer compositor
andersca@apple.com [Wed, 8 Feb 2012 20:24:57 +0000 (20:24 +0000)]
Add a content shadow layer to the render layer compositor
https://bugs.webkit.org/show_bug.cgi?id=78133
<rdar://problem/10797742>

Reviewed by Beth Dakin.

Have the render layer compositor optionally create a content shadow layer,
and add a ScrollbarTheme::setUpContentShadowLayer member function that subclasses
can use to set content shadow properties.

* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
Set the layer properties once, and set the shadow path on every call, since we know that this
function will be called every time the size of the content shadow layer changes.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Reposition the content shadow layer, and call ScrollbarTheme::setUpContentShadowLayer if the size changes.

(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
Add new helper function.

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Create a content shadow layer if needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until...
aestes@apple.com [Wed, 8 Feb 2012 20:20:41 +0000 (20:20 +0000)]
REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize
https://bugs.webkit.org/show_bug.cgi?id=77167

Reviewed by Eric Seidel.

Source/WebCore:

Test: plugins/layout-in-beforeload-listener-affects-plugin-loading.html

r102983 made FrameView::updateWidgets() check if the DOM node actually
needs a widget update before calling updateWidget(). Due to historical
reasons, however, updateWidget() can be legitimately called twice: once
at attach time for non-Netscape plug-ins and once at layout time for
Netscape plug-ins.

If the widget represents a Netscape plug-in, but updateWidget() is
called for the CreateOnlyNonNetscapePlugins case after the DOM node was
marked as needing an update, updateWidget() will clear the update flag
and prevent a second call to updateWidget() at layout time for the
CreateAnyWidgetType case.

As much as I loathe adding to the code duplication between
HTMLEmbedElement::updateWidget() and HTMLObjectElement::updateWidget(),
the simplest solution seems to be marking the DOM node as needing
update in the case where we are calling updateWidget() for the
CreateOnlyNonNetscapePlugins case and we know we will be loading a
Netscape plug-in.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Call
setNeedsWidgetUpdate(true) if pluginCreationOption is
CreateOnlyNonNetscapePlugins but we will load a Netscape plug-in.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Ditto.
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent): Remove an
invalid assertion that prevents the layout test from running in a Debug
configuration.

LayoutTests:

* plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt: Added.
* plugins/layout-in-beforeload-listener-affects-plugin-loading.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make dependency on Accelerate.framework explicit.
commit-queue@webkit.org [Wed, 8 Feb 2012 20:17:40 +0000 (20:17 +0000)]
[chromium] Make dependency on Accelerate.framework explicit.
https://bugs.webkit.org/show_bug.cgi?id=78131

It's used by platform/audio/mac/FFTFrameMac.cpp. The explicit
dependency is needed to build a libwebkit.dylib.

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Don't add selection from password fields to context menu.
commit-queue@webkit.org [Wed, 8 Feb 2012 20:16:21 +0000 (20:16 +0000)]
[Chromium] Don't add selection from password fields to context menu.
https://bugs.webkit.org/show_bug.cgi?id=77733

Patch by Bernhard Bauer <bauerb@google.com> on 2012-02-08
Reviewed by Adam Barth.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaselines for vertical text tests.
caryclark@google.com [Wed, 8 Feb 2012 20:11:28 +0000 (20:11 +0000)]
Unreviewed rebaselines for vertical text tests.
See https://bugs.webkit.org/show_bug.cgi?id=78120

* platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
[...]
* platform/chromium-mac-snowleopard/fast/writing-mode/vertical-font-fallback-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: make --skip-pixel-test-if-no-baseline option
commit-queue@webkit.org [Wed, 8 Feb 2012 19:59:33 +0000 (19:59 +0000)]
nrwt: make --skip-pixel-test-if-no-baseline option
https://bugs.webkit.org/show_bug.cgi?id=70484

Patch by Fehér Zsolt <feherzs@inf.u-szeged.hu> on 2012-02-08
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
(SingleTestRunner._should_fetch_expected_checksum):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.__init__):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_pixel_test_if_no_baseline_option):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
* WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::setSkipPixelTestOption):
(TestInvocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFloated flexboxes render as regular RenderBlocks
ojan@chromium.org [Wed, 8 Feb 2012 19:58:35 +0000 (19:58 +0000)]
Floated flexboxes render as regular RenderBlocks
https://bugs.webkit.org/show_bug.cgi?id=77909

Reviewed by Eric Seidel.

Source/WebCore:

Add grid/flexbox cases to adjusting the display of floated/positioned
elements. Also, move this logic into a switch statement. This makes
the code more readable and gives compile warnings when new display types
are added that aren't handled here.

Test: css3/flexbox/floated-flexbox.html

* css/CSSStyleSelector.cpp:
(WebCore::adjustDisplay):
(WebCore):
(WebCore::CSSStyleSelector::adjustRenderStyle):

LayoutTests:

* css3/flexbox/floated-flexbox-expected.txt: Added.
* css3/flexbox/floated-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
commit-queue@webkit.org [Wed, 8 Feb 2012 19:44:55 +0000 (19:44 +0000)]
[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
https://bugs.webkit.org/show_bug.cgi?id=78130

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor107042 caused compile breakages on chromium try bots
jamesr@google.com [Wed, 8 Feb 2012 19:29:59 +0000 (19:29 +0000)]
r107042 caused compile breakages on chromium try bots
https://bugs.webkit.org/show_bug.cgi?id=78125

Reviewed by Adam Barth.

Replace the copy script with a copies GYP action since the MSVS generator tracks dependencies on a per-file
basis.

* Platform.gyp/Platform.gyp:
* Platform.gyp/copy_webcore_headers.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 8 Feb 2012 19:26:29 +0000 (19:26 +0000)]
Unreviewed gardening.

* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt: Added.
More rebaseline of those (I pulled the trigger too early).

* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png:
* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png:
* platform/chromium/rubberbanding/custom-scrollbars-se-expected.png:
* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png:
Update the expected files. I don't know how we ended up with a blue color when the html specifies
an orange.

* platform/chromium/test_expectations.txt:
Mark a test as timing out as it has been raising an exception on the bots fairly regularly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoviewBox on nested SVG causes wrong content size for relative values
krit@webkit.org [Wed, 8 Feb 2012 19:19:03 +0000 (19:19 +0000)]
viewBox on nested SVG causes wrong content size for relative values
https://bugs.webkit.org/show_bug.cgi?id=69459

Reviewed by Nikolas.

Source/WebCore:

In the past we just checked the change of the viewport size of the root SVG element. If the size changed, all childs
with relative length values needed a relayout. We did not consider that we might have other viewports in the document.
Childs with relative lengths had a strange zooming, if just the viewport size of an inner SVG element changed.

With this patch we check if the size of the nearest viewport changes. Is this the case, childs with relative lengths
need a relayout.

Test: inner-svg-change-viewBox.svg

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/RenderSVGContainer.h:
(RenderSVGContainer):
(WebCore::RenderSVGContainer::determineIfLayoutSizeChanged): Check if we need layout and have relative length values.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout): Remove resetting 'viewport size changed' flag for code operability. No influence on the layout.
* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): Add a flag that indicates that the viewport size changes.
(WebCore::RenderSVGViewportContainer::determineIfLayoutSizeChanged): The flag gets set during the layout phase of the SVG element if the size changes.
(WebCore):
* rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::isLayoutSizeChanged): Added getter to get flag status.
(RenderSVGViewportContainer):
(WebCore::toRenderSVGViewportContainer): Added casting function for constant RenderObjects.
(WebCore):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::layoutSizeOfNearestViewportChanged): Search the nearest viewport and check if the size changed.
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren): Don't check the roots viewport for size changes, but the nearest viewport.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged): Added viewBoxAttr to the list of attributes that cause relayout.

LayoutTests:

Test relayout of content of inner SVG on change of relative length values.

* svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
* svg/repaint/inner-svg-change-viewBox.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement new WEBGL compressed texture extensions
commit-queue@webkit.org [Wed, 8 Feb 2012 19:13:56 +0000 (19:13 +0000)]
Implement new WEBGL compressed texture extensions
https://bugs.webkit.org/show_bug.cgi?id=77066

Source/WebCore:

This removes the old experimental compressed
texture extension and implements the first new
one.

A test is in the WebGL conformance tests in
extensions/webgl-compressed-texture-s3tc.html
and will be copied here in a future patch.

Patch by Gregg Tavares <gman@google.com> on 2012-02-08
Reviewed by Kenneth Russell.

No new tests. Test coming in future patch.

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLCompressedTextureS3TC.cpp: Added.
(WebCore):
(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::~WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::getName):
(WebCore::WebGLCompressedTextureS3TC::create):
(WebCore::WebGLCompressedTextureS3TC::supported):
* html/canvas/WebGLCompressedTextureS3TC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLCompressedTextureS3TC):
* html/canvas/WebGLCompressedTextureS3TC.idl: Renamed from Source/WebCore/html/canvas/WebGLCompressedTextures.idl.
* html/canvas/WebGLCompressedTextures.cpp: Removed.
* html/canvas/WebGLCompressedTextures.h: Removed.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore):
(WebCore::WebGLGetInfo::getWebGLUnsignedIntArray):
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::addCompressedTextureFormat):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFormat):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions):
* html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
* html/canvas/WebGLRenderingContext.idl:

LayoutTests:

Patch by Gregg Tavares <gman@chromium.org> on 2012-02-08
Reviewed by Kenneth Russell.

* fast/canvas/webgl/constants.html:
* fast/canvas/webgl/gl-get-calls-expected.txt:
* fast/canvas/webgl/gl-get-calls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: heap snapshot: implement Distance column in Object's retaining tree.
loislo@chromium.org [Wed, 8 Feb 2012 18:49:55 +0000 (18:49 +0000)]
Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=78113

Retaining path list was replaced with Retaining tree some time ago.
But it was not so useful when we want to track the retaining path from an object to a DOM Window node.

Drive by fix: sort doesn't work in retaining tree panel.
Drive by fix: save/load child nodes doesn't work for the retaining tree panel.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotRetainerEdge.prototype.set retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndEdge):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid td.distanceToWindow-column):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream DumpRenderTreeBlackBerry
commit-queue@webkit.org [Wed, 8 Feb 2012 18:35:50 +0000 (18:35 +0000)]
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Patch by Rob Buis <rbuis@rim.com> on 2012-02-08
Reviewed by Antonio Gomes.

Source/WebKit:

Add abstract interface for our DumpRenderTree solution.

* blackberry/Api/DumpRenderTreeClient.h: Added.

Tools:

Add implementation for our DumpRenderTree solution.

* DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
ossy@webkit.org [Wed, 8 Feb 2012 18:29:48 +0000 (18:29 +0000)]
[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=78128

* platform/qt/Skipped: Skip it until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed morning gardening.
jchaffraix@webkit.org [Wed, 8 Feb 2012 18:27:10 +0000 (18:27 +0000)]
Unreviewed morning gardening.

* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Added.
Rebaselined this file (font difference).

* platform/chromium/test_expectations.txt: Marked one test as SLOW on Window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
andersca@apple.com [Wed, 8 Feb 2012 18:00:00 +0000 (18:00 +0000)]
Fix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
https://bugs.webkit.org/show_bug.cgi?id=78126

Reviewed by Dan Bernstein.

This broke in r106977 when I tried to change an early return into an ASSERT,
so let's bring back the early return.

* page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r106920, r106924, r106933, r106939,
ossy@webkit.org [Wed, 8 Feb 2012 17:56:22 +0000 (17:56 +0000)]
Unreviewed, rolling out r106920, r106924, r106933, r106939,
and r107090.
http://trac.webkit.org/changeset/106920
http://trac.webkit.org/changeset/106924
http://trac.webkit.org/changeset/106933
http://trac.webkit.org/changeset/106939
http://trac.webkit.org/changeset/107090
https://bugs.webkit.org/show_bug.cgi?id=78124

Something is completely wrong this change (Requested by
Ossy_gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08

Source/WebCore:

* platform/FileSystem.h:
(WebCore):
* platform/qt/FileSystemQt.cpp:

Source/WebKit2:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
antti@apple.com [Wed, 8 Feb 2012 17:35:44 +0000 (17:35 +0000)]
REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
https://bugs.webkit.org/show_bug.cgi?id=78080

Source/WebKit/mac:

Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

* WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):

Tools:

Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

Add API test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78122
hyatt@apple.com [Wed, 8 Feb 2012 17:34:22 +0000 (17:34 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78122

Add support for the "contains" value for line-grid-snap. This value centers the line box in between the
text-top and text-bottom of the minimum number of grid lines that enclose the line box. This is useful for
centering headers in a line grid.

Reviewed by Adam Roben.

Added a new test in fast/line-grid.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78122

Add a new test that shows the "contains" value in action.

Reviewed by Adam Roben.

* fast/line-grid/line-grid-contains-value.html: Added.
* platform/mac/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fails to build docs with non-standard build directories
commit-queue@webkit.org [Wed, 8 Feb 2012 17:31:44 +0000 (17:31 +0000)]
[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2012-02-08
Reviewed by Martin Robinson.

* gtk/common.py:
(get_build_path): also try the current directory as a valid build
dir, which makes non-standard build directories such as build-2.0
and build-3.0 work

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Skia Mac] Make misspelling underline dots unclipped
caryclark@google.com [Wed, 8 Feb 2012 17:15:42 +0000 (17:15 +0000)]
[Skia Mac] Make misspelling underline dots unclipped
https://bugs.webkit.org/show_bug.cgi?id=78117
http://code.google.com/p/chromium/issues/detail?id=113154

Reviewed by Stephen White.

No new tests. Existing layout tests cover this.

As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoved a Mac-specific test to platform/mac.
mitz@apple.com [Wed, 8 Feb 2012 17:05:08 +0000 (17:05 +0000)]
Moved a Mac-specific test to platform/mac.

* fast/text/synthetic-bold-transformed-expected.html: Removed.
* fast/text/synthetic-bold-transformed.html: Removed.
* platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
* platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInitial upstreaming of input handling for BlackBerry port
commit-queue@webkit.org [Wed, 8 Feb 2012 17:01:35 +0000 (17:01 +0000)]
Initial upstreaming of input handling for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77992

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-08
Reviewed by Rob Buis.

* blackberry/WebKitSupport/InputHandler.cpp: Added.
* blackberry/WebKitSupport/InputHandler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium: Fix Mac rubber band overhang drawing on composited pages and re-enable...
commit-queue@webkit.org [Wed, 8 Feb 2012 16:57:45 +0000 (16:57 +0000)]
Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: bind entire subtree upon childNodeInserted so that text node were...
pfeldman@chromium.org [Wed, 8 Feb 2012 16:42:23 +0000 (16:42 +0000)]
Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
https://bugs.webkit.org/show_bug.cgi?id=78116

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._unbind):

LayoutTests:

* inspector/elements/insert-node-expected.txt:
* inspector/elements/insert-node.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix a crash when WebKitWebView is created without a WebContext
carlosgc@webkit.org [Wed, 8 Feb 2012 16:31:14 +0000 (16:31 +0000)]
[GTK] Fix a crash when WebKitWebView is created without a WebContext
https://bugs.webkit.org/show_bug.cgi?id=78104

Reviewed by Philippe Normand.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
property is initialized to the default web context when a web
context is not passed to g_object_new().
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewDefaultContext): Check that a web view created with
g_object_new has the default context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Optional out arguments are not supported in the Web Inspector protocol...
commit-queue@webkit.org [Wed, 8 Feb 2012 16:17:20 +0000 (16:17 +0000)]
Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
https://bugs.webkit.org/show_bug.cgi?id=77967

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-08
Reviewed by Yury Semikhatsky.

Condition for RefPtr-based types added. This is more-or-less a hack
and it's should be redone together with the switch to type-safe API.

* inspector/CodeGeneratorInspector.py:
(Generator.process_command):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Compute and set cache capacities using the current CacheModel
commit-queue@webkit.org [Wed, 8 Feb 2012 16:02:31 +0000 (16:02 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
CacheModelPrimaryWebBrowser.

LayoutTests:

* platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: inspected object wrapper should be released by InjectedScript when...
yurys@chromium.org [Wed, 8 Feb 2012 15:51:53 +0000 (15:51 +0000)]
Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
https://bugs.webkit.org/show_bug.cgi?id=77972

When object popover is shown the object under cursor is resolved and its
wrapper is put into 'popover' object wrapper group. The group is discarded
when the popover closes.

Reviewed by Pavel Feldman.

* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/js/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
carlosgc@webkit.org [Wed, 8 Feb 2012 15:51:08 +0000 (15:51 +0000)]
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78099

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): Check whether it's a link clicked with the
middle mouse button and load the request in a new window.
(browserWindowConstructed): Connect to
WebKitWebView::decide-policy signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix WebKitWebView::decide-policy API documentation
carlosgc@webkit.org [Wed, 8 Feb 2012 15:48:51 +0000 (15:48 +0000)]
[GTK] Fix WebKitWebView::decide-policy API documentation
https://bugs.webkit.org/show_bug.cgi?id=78101

Reviewed by Martin Robinson.

- It refers to WebKitPolicyClient instead of WebKitWebView
- Trailing ':' is missing
- References @decision as WebKitNavigationPolicyDecision instead
of WebKitPolicyDecision

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items...
mario@webkit.org [Wed, 8 Feb 2012 15:38:19 +0000 (15:38 +0000)]
[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=73431

Reviewed by Chris Fleizach.

Source/WebCore:

Don't replace item's markers with the objectReplacementCharacter
character, as they will be treated in an special way later on.

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Don't append the objectReplacementCharacter
character for list item's markers.

Source/WebKit/gtk:

Updated unit test to check text wrapping accross different lines
inside list items with bullet markers.

* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemote web inspector reentrancy fixes
commit-queue@webkit.org [Wed, 8 Feb 2012 15:11:37 +0000 (15:11 +0000)]
Remote web inspector reentrancy fixes
https://bugs.webkit.org/show_bug.cgi?id=77022

Patch by Leo Franchi <lfranchi@kde.org> on 2012-02-08
Reviewed by Joseph Pecoraro.

* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.
podivilov@chromium.org [Wed, 8 Feb 2012 14:57:37 +0000 (14:57 +0000)]
Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.

* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: do not clear entire tree map upon last element deletion.
pfeldman@chromium.org [Wed, 8 Feb 2012 14:49:26 +0000 (14:49 +0000)]
Web Inspector: do not clear entire tree map upon last element deletion.
https://bugs.webkit.org/show_bug.cgi?id=78112

Reviewed by Yury Semikhatsky.

* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._forgetChildrenRecursive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMigrate createObjectURL & revokeObjectURL to static (Class) methods.
commit-queue@webkit.org [Wed, 8 Feb 2012 14:39:18 +0000 (14:39 +0000)]
Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Move createObjectURL & revokeObjectURL from DOMURL implementation to
static methods as per specs - http://www.w3.org/TR/FileAPI/#creating-revoking

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
    fast/files/revoke-blob-url.html
    fast/dom/window-domurl-crash.html
    fast/files/apply-blob-url-to-img.html
    fast/files/create-blob-url-crash.html
    fast/files/workers/inline-worker-via-blob-url.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
* html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
* html/DOMURL.idl:
* html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
* page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
* page/DOMWindow.h: ditto.
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
* platform/gtk/fast/js/global-constructors-expected.txt: ditto.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
* platform/qt/fast/js/global-constructors-expected.txt: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 8 Feb 2012 14:06:04 +0000 (14:06 +0000)]
2012-02-08  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium svg expectations after r107067.
podivilov@chromium.org [Wed, 8 Feb 2012 14:02:21 +0000 (14:02 +0000)]
Unreviewed, update chromium svg expectations after r107067.

* platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add changes for Spectrum colorpicker
apavlov@chromium.org [Wed, 8 Feb 2012 13:22:33 +0000 (13:22 +0000)]
Web Inspector: Add changes for Spectrum colorpicker
https://bugs.webkit.org/show_bug.cgi?id=75454

Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-01
Reviewed by Pavel Feldman.

* inspector/front-end/Color.js:
(WebInspector.Color.fromRGB):
* inspector/front-end/utilities.js:
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 8 Feb 2012 13:00:54 +0000 (13:00 +0000)]
2012-02-08  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
        https://bugs.webkit.org/show_bug.cgi?id=78084

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline and skipping 2 new failing tests.
philn@webkit.org [Wed, 8 Feb 2012 12:59:38 +0000 (12:59 +0000)]
Unreviewed, GTK rebaseline and skipping 2 new failing tests.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressi...
apavlov@chromium.org [Wed, 8 Feb 2012 12:58:19 +0000 (12:58 +0000)]
Web Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressionsSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=78102

Reviewed by Vsevolod Vlasov.

* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] New http/tests/security/ introduced r107046 fail
ossy@webkit.org [Wed, 8 Feb 2012 12:48:11 +0000 (12:48 +0000)]
[Qt] New http/tests/security/ introduced r107046 fail
https://bugs.webkit.org/show_bug.cgi?id=78093

Unskip these tests and rebaselines for Qt and GTK.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-08
Reviewed by Csaba Osztrogonác.

* platform/gtk/Skipped:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
* platform/qt/Skipped:
* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.
ossy@webkit.org [Wed, 8 Feb 2012 12:38:46 +0000 (12:38 +0000)]
[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.

* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/qt/svg/custom/getTransformToElement-expected.png:
* platform/qt/svg/custom/getTransformToElement-expected.txt:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/custom/text-hit-test-expected.png:
* platform/qt/svg/custom/text-hit-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 8 Feb 2012 12:37:31 +0000 (12:37 +0000)]
2012-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline Gtk/SVG results.

        * platform/gtk/svg/carto.net/scrollbar-expected.txt:
        * platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is...
commit-queue@webkit.org [Wed, 8 Feb 2012 12:34:24 +0000 (12:34 +0000)]
CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
https://bugs.webkit.org/show_bug.cgi?id=69993

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-08
Reviewed by Simon Fraser.

Source/WebCore:

The issue was that for overflow:scroll, currently webkit always places the horizontal
and vertical scrollbar. But Since the listbox renderer handles its scrolling,
we should not set scrollbar for list-box.

Tests: fast/css/getComputedStyle/computed-style-select-overflow.html
       fast/forms/select-overflow-scroll-inherited.html
       fast/forms/select-overflow-scroll.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

LayoutTests:

* fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
* fast/forms/select-overflow-scroll-inherited.html: Added.
* fast/forms/select-overflow-scroll.html: Added.
* platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoqt fixes
zimmermann@webkit.org [Wed, 8 Feb 2012 12:31:11 +0000 (12:31 +0000)]
qt fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build broken if qt missing openssl
mahesh.kulkarni@nokia.com [Wed, 8 Feb 2012 12:24:50 +0000 (12:24 +0000)]
[Qt] Build broken if qt missing openssl
https://bugs.webkit.org/show_bug.cgi?id=77894

Reviewed by Chang Shu.

Build fix. No new test content.

* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::onSslErrors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaselined the test that has been failing since r107046.
haraken@chromium.org [Wed, 8 Feb 2012 12:18:40 +0000 (12:18 +0000)]
Unreviewed. Rebaselined the test that has been failing since r107046.

* http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Text notifications should have an iconURL
yael.aharon@nokia.com [Wed, 8 Feb 2012 12:13:50 +0000 (12:13 +0000)]
[WK2] Text notifications should have an iconURL
https://bugs.webkit.org/show_bug.cgi?id=77968

Reviewed by Simon Hausmann.

Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.

* UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyiconURL):
* UIProcess/API/C/WKNotification.h:
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofeImage doesn't invalidate when its target SVG element is animated
zimmermann@webkit.org [Wed, 8 Feb 2012 12:12:31 +0000 (12:12 +0000)]
feImage doesn't invalidate when its target SVG element is animated
https://bugs.webkit.org/show_bug.cgi?id=73860

Reviewed by Dirk Schulze.

Source/WebCore:

Consider following testcase:
<defs>
    <rect id="rect" fill="red" width="50" height="50"/>
    <filter id="filter">
        <feImage xlink:href="#rect"/>
    </filter>
</defs>
<rect width="50" height="50" filter="url(#filter)"/>

If the <rect id="rect"> gets changed dynamically (attribute/property/style change) the <feImage>
doesn't notice this, as there's no link between the <rect> and the <feImage>, as the <rect> is not
a child of the <feImage/>. To get invalidations working for these situations, we have to track
the referencingElement & referencedElement in SVGDocumentExtensions.

Fixes parts the SVG-Wow twirl testcase and David Daileys SVG waves example.

Tests: svg/filters/feImage-animated-transform-on-target-rect.svg
       svg/filters/feImage-late-indirect-update.svg
       svg/filters/feImage-mutliple-targets-id-change.svg
       svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
       svg/filters/feImage-target-attribute-change-with-use-indirection.svg
       svg/filters/feImage-target-attribute-change.svg
       svg/filters/feImage-target-inline-style-change.svg
       svg/filters/feImage-target-property-change.svg
       svg/filters/feImage-target-style-change.svg

* rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromFilterCacheAndInvalidateDependencies): Renamed from removeFromFilterCache, as it has another purpose now.
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): s/removeFromFilterCache/removeFromFilterCacheAndInvalidateDependencies/.
* rendering/svg/RenderSVGResource.h: Removed removeFromFilterCache, it got inlined.
* svg/SVGDocumentExtensions.cpp: Add a new HashMap<SVGElement*, OwnPtr<HashSet<SVGElement*> > > used for dependency tracking.
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget): Returns all elements the passed in element depends on.
(WebCore::SVGDocumentExtensions::addElementReferencingTarget): Register element 'a' referencing target 'b'.
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): Called by element 'a' on destruction or any target change.
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Called by element 'b' on destruction.
* svg/SVGDocumentExtensions.h: Expose new methods.
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement): Call remove removeAllElementReferencesForTarget on destruction.
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

LayoutTests:

Add lots of new testcases covering <feImage> invalidation, when the referenced target changes.
Thanks to the repaint harness, it uncovered a bug with feImage-late-indirect-update.svg - there no gray
overlay rects are visible, as the whole screen gets repainted, which is a bug!

* platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/mac/svg/filters/feImage-change-target-id-expected.png: Added.
* platform/mac/svg/filters/feImage-change-target-id-expected.txt: Added.
* platform/mac/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/mac/svg/filters/feImage-late-indirect-update-expected.txt: Added.
* platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
* platform/mac/svg/filters/feImage-remove-target-expected.png: Added.
* platform/mac/svg/filters/feImage-remove-target-expected.txt: Added.
* platform/mac/svg/filters/feImage-target-add-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-add-to-document-expected.png.
* platform/mac/svg/filters/feImage-target-add-to-document-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-add-to-document-expected.txt.
* platform/mac/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
* platform/mac/svg/filters/feImage-target-changes-id-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.png.
* platform/mac/svg/filters/feImage-target-changes-id-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-id-change-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.png.
* platform/mac/svg/filters/feImage-target-id-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.txt.
* platform/mac/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-inline-style-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-property-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.png.
* platform/mac/svg/filters/feImage-target-reappend-to-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.txt.
* platform/mac/svg/filters/feImage-target-remove-from-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.png.
* platform/mac/svg/filters/feImage-target-remove-from-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.txt.
* platform/mac/svg/filters/feImage-target-style-change-expected.png: Added.
* platform/mac/svg/filters/feImage-target-style-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
* svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
* svg/filters/feImage-animated-transform-on-target-rect.svg: Added.
* svg/filters/feImage-change-target-id.svg: Added.
* svg/filters/feImage-late-indirect-update.svg: Added.
* svg/filters/feImage-multiple-targets-id-change.svg: Added.
* svg/filters/feImage-remove-target.svg: Added.
* svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg: Added.
* svg/filters/feImage-target-attribute-change-with-use-indirection.svg: Added.
* svg/filters/feImage-target-attribute-change.svg: Added.
* svg/filters/feImage-target-inline-style-change.svg: Added.
* svg/filters/feImage-target-property-change.svg: Added.
* svg/filters/feImage-target-style-change.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.
ossy@webkit.org [Wed, 8 Feb 2012 12:02:42 +0000 (12:02 +0000)]
[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.

* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Using string method instead of char* operation in the platformLanguage().
commit-queue@webkit.org [Wed, 8 Feb 2012 11:53:13 +0000 (11:53 +0000)]
[EFL] Using string method instead of char* operation in the platformLanguage().
https://bugs.webkit.org/show_bug.cgi?id=78077

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.

No new tests. Just fix a bug of platformLanguage function.

* platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):
Change char* operation to string operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert a part of the change in r106687 as a build fix.
rniwa@webkit.org [Wed, 8 Feb 2012 11:40:09 +0000 (11:40 +0000)]
Revert a part of the change in r106687 as a build fix.

Since Chromium port doesn't checkout the entire WebKit trunk,
we can't run "svn info" on webkit_base.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
haraken@chromium.org [Wed, 8 Feb 2012 11:15:40 +0000 (11:15 +0000)]
Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
The test needs rebaselining.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Touch event emulation fails for iframes
apavlov@chromium.org [Wed, 8 Feb 2012 11:13:03 +0000 (11:13 +0000)]
Web Inspector: Touch event emulation fails for iframes
https://bugs.webkit.org/show_bug.cgi?id=77987

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/events/touch/emulated-touch-iframe.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

* fast/events/touch/emulated-touch-iframe-expected.txt: Added.
* fast/events/touch/emulated-touch-iframe.html: Added.
* fast/events/touch/resources/emulated-touch-iframe2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
kling@webkit.org [Wed, 8 Feb 2012 11:03:52 +0000 (11:03 +0000)]
StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
<http://webkit.org/b/78068>

Rubber-stamped by Ryosuke Niwa.

Turns out that setProperty() with a CSSProperty has quite different behavior from
the other setProperty() methods. We should probably clean that up (separately.)
For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
use setProperty(CSSProperty).

* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r107050.
morrita@google.com [Wed, 8 Feb 2012 10:55:20 +0000 (10:55 +0000)]
Unreviewed, rolling out r107050.
http://trac.webkit.org/changeset/107050
https://bugs.webkit.org/show_bug.cgi?id=78094

May crash editing tests (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with...
ossy@webkit.org [Wed, 8 Feb 2012 10:42:55 +0000 (10:42 +0000)]
[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=77995

Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-08
Reviewed by Csaba Osztrogonác.

Source/WebCore:

From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
from frameDetached(). There's no point in redrawing there, so we should just stop it.

Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.
* svg/graphics/SVGImage.h:

LayoutTests:

* platform/qt/Skipped: Unskip previously skipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd state attribute to history's dom interface.
commit-queue@webkit.org [Wed, 8 Feb 2012 10:39:13 +0000 (10:39 +0000)]
Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-object-types.html
       fast/loader/stateobjects/state-attribute-only-one-deserialization.html

* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::state):
(WebCore):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
(WebCore):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* page/History.cpp:
(WebCore::History::History):
(WebCore::History::state):
(WebCore):
(WebCore::History::stateInternal):
(WebCore::History::stateChanged):
* page/History.h:
(History):
* page/History.idl:

LayoutTests:

* fast/dom/Window/window-appendages-cleared-expected.txt:
* fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-object-types.html: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVGLoad event fires too early
zimmermann@webkit.org [Wed, 8 Feb 2012 10:21:49 +0000 (10:21 +0000)]
SVGLoad event fires too early
https://bugs.webkit.org/show_bug.cgi?id=78084

Reviewed by Hajime Morita.

Source/WebCore:

SVGLoad event fires too early, making it impossible to use the vanilla repaint.js harness (runRepaintTest).

We're using a hack called runSVGRepaintTest() at the moment in trunk, which runs runRepaintTest() from a 0ms timer,
which is not reliable. The main difference between HTML onload and SVG onload is that HTMLs event is a "window event",
thus dispatched through DOMWindow (eg. <body onload="alert(event.target)" will yield Document,
<svg onload="alert(evt.target)"> will say SVGSVGElement).

Consider:
<svg onload="alert('1')>
<g onload="alert('2)">
<rect onload="alert('3')"/>
</svg>

As soon as the <rect> finishes parsing (SVGElement::finishedParsingChildren), it's SVGLoad event is fired.
So first you'll see '3', then '2', then '1'.

Using:
<svg onload="alert('1')>
<g onload="alert('2)">
<image xlink:href="someExternal.jpg" onload="alert('3')"/>
</svg>

will yield the same SVGLoad order. When using <image externalREsourcesRequired="true", first the '1' will fire,
then '3', then '2', all as expected and specified in SVG.

http://www.w3.org/TR/SVG/interact.html#LoadEvent says:
"The event is triggered at the point at which the user agent has fully parsed the element and its descendants and is
ready to act appropriately upon that element, such as being ready to render the element to the target device. Referenced
external resources that are required must be loaded, parsed and ready to render before the event is triggered. Optional
external resources are not required to be ready for the event to be triggered."

What we don't implement correctly is the second part of the first sentence: "and is ready to act appropriately upon that
element, such as being ready to render the element to the target device". We currently fire the SVGLoad event, right after
</svg> is seen, if no externalResourceRequired="true" attributes are set anywhere. This is not wrong, but not correct for
WebKit, as we're not yet "ready to render".

HTML fires its window onload event from Document::implicitClose(), where it calls Document::dispatchWindowLoadEvent.
At this point we're ready to render. So I'm now aligning the timing of the outermost <svg> elements SVGLoad event, to be
equal to HTML. This lets use use the repaint.js harness w/o any special SVG tricks.

Covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::implicitClose): Dispatch SVGLoad event for outermost <svg> elements from here, as HTML does for its window onload event.
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Sends a SVGLoad event to all outermost <svg> elements in a document, if possible.
There can be multiple ones, if using <svg><foreignObject><svg>... - the <svg> in the <fO> also acts as outermost <svg> element.
* svg/SVGDocumentExtensions.h: Add new dispatchSVGLoadEventToOutermostSVGElements() helper.
* svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement): Moved from SVGSVGElement into SVGElement, and renamed from isOutermostSVG().
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't dispatch load events to outermost <svg> elements, if Document::implicitClose() wasn't called yet.
(WebCore::SVGElement::finishParsingChildren): Stop using the default SVGLoad dispatching logic for outermost <svg> elements.
* svg/SVGElement.h: Add isOutermostSVGSVGElement().
* svg/SVGSVGElement.cpp: Rename isOutermostSVG to isOutermostSVGSVGElement.
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::createRenderer):
* svg/SVGSVGElement.h: Move isOutermostSVG() to SVGElement.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Rename isOutermostSVG to isOutermostSVGSVGElement.

LayoutTests:

Remove runSVGRepaintTest() from repaint.js again, and convert all *.svg tests to use runRepaintTest() directly.
This is now possible as the outermost <svg> elements load event timing as aligned with HTML.

* fast/repaint/resources/repaint.js: Remove runSVGRepaintTest(), it's no longer needed.
(runRepaintTest): s/document.rootElement/document.documentElement/ to make it work for all HTML/XHTML and SVG documents (XHTML was broken).
* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/mac/svg/custom/getTransformToElement-expected.png:
* platform/mac/svg/custom/getTransformToElement-expected.txt:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.png:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/mac/svg/custom/text-ctm-expected.png:
* platform/mac/svg/custom/text-ctm-expected.txt:
* platform/mac/svg/custom/text-hit-test-expected.png:
* platform/mac/svg/custom/text-hit-test-expected.txt:
* platform/mac/svg/filters/filter-refresh-expected.png:
* svg/carto.net/tabgroup.svg:
* svg/carto.net/window.svg:
* svg/css/shadow-changes.svg:
* svg/custom/loadevents-externalresourcesrequired.svg:
* svg/dom/SVGPathSegList-segment-modification.svg:
* svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
* svg/dom/SVGRectElement/rect-modify-rx.svg:
* svg/filters/animate-fill.svg:
* svg/filters/feImage-reference-invalidation.svg:
* svg/filters/feImage-target-add-to-document.svg:
* svg/filters/feImage-target-changes-id.svg:
* svg/filters/feImage-target-id-change.svg:
* svg/filters/feImage-target-reappend-to-document.svg:
* svg/filters/feImage-target-remove-from-document.svg:
* svg/filters/filter-refresh.svg:
* svg/filters/filter-width-update.svg:
* svg/filters/invalidate-on-child-layout.svg:
* svg/hixie/perf/001.xml:
* svg/hixie/perf/002.xml:
* svg/hixie/perf/003.xml:
* svg/hixie/perf/004.xml:
* svg/hixie/perf/005.xml:
* svg/hixie/perf/006.xml:
* svg/hixie/perf/007.xml:
* svg/repaint/container-repaint.svg:
* svg/repaint/filter-child-repaint.svg:
* svg/repaint/image-href-change.svg:
* svg/repaint/image-with-clip-path.svg:
* svg/text/text-text-05-t.svg:
* svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
* svg/zoom/page/absolute-sized-document-scrollbars.svg:
* svg/zoom/page/relative-sized-document-scrollbars.svg:
* svg/zoom/page/zoom-coords-viewattr-01-b.svg:
* svg/zoom/page/zoom-foreignObject.svg:
* svg/zoom/page/zoom-mask-with-percentages.svg:
* svg/zoom/resources/testPageZoom.js:
(repaintTest):
* svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
* svg/zoom/text/absolute-sized-document-scrollbars.svg:
* svg/zoom/text/relative-sized-document-scrollbars.svg:
* svg/zoom/text/zoom-coords-viewattr-01-b.svg:
* svg/zoom/text/zoom-foreignObject.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
apavlov@chromium.org [Wed, 8 Feb 2012 10:11:31 +0000 (10:11 +0000)]
Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
https://bugs.webkit.org/show_bug.cgi?id=78090

Reviewed by Vsevolod Vlasov.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
apavlov@chromium.org [Wed, 8 Feb 2012 10:00:52 +0000 (10:00 +0000)]
Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/lazy-computed-style.html

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
* inspector/elements/elements-panel-styles.html:
* inspector/styles/css-live-edit.html:
* inspector/styles/lazy-computed-style-expected.txt: Added.
* inspector/styles/lazy-computed-style.html: Added.
* inspector/styles/styles-computed-trace.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: Adding the onstatechange callback to PeerConnection
tommyw@google.com [Wed, 8 Feb 2012 09:52:17 +0000 (09:52 +0000)]
MediaStream API: Adding the onstatechange callback to PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=77954

When readyState changes a callback should be triggered.

Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* dom/EventNames.h:
(WebCore):
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::changeReadyState):
* mediastream/PeerConnection.h:
(PeerConnection):
(WebCore::PeerConnection::didChangeState):
* mediastream/PeerConnection.idl:
* platform/mediastream/PeerConnectionHandlerClient.h:
(PeerConnectionHandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-perf-tests doesn't recognize paths that start with PerformanceTests
rniwa@webkit.org [Wed, 8 Feb 2012 09:51:14 +0000 (09:51 +0000)]
run-perf-tests doesn't recognize paths that start with PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=78012

Reviewed by Adam Barth.

Use resolve paths using filesystem.relpath before passing it to find_files.find.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):
(test_collect_tests.add_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r106982.
ossy@webkit.org [Wed, 8 Feb 2012 09:17:27 +0000 (09:17 +0000)]
Unreviewed gardening after r106982.
Skip a new test because of missing AuthenticationChallenges support.

* platform/qt/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
haraken@chromium.org [Wed, 8 Feb 2012 08:57:50 +0000 (08:57 +0000)]
Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
https://bugs.webkit.org/show_bug.cgi?id=77963

Reviewed by Adam Barth.

This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
* bindings/scripts/test/TestInterface.idl:
* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop calling Element::ensureShadowRoot() if it is used in construction phase.
commit-queue@webkit.org [Wed, 8 Feb 2012 08:57:08 +0000 (08:57 +0000)]
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 8 Feb 2012 08:47:02 +0000 (08:47 +0000)]
2012-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing results for a new SVG test.

        * platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
        * platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 8 Feb 2012 08:37:01 +0000 (08:37 +0000)]
2012-02-08  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating expectations to SKIP test that times out or crashes on most...
dmazzoni@google.com [Wed, 8 Feb 2012 08:29:22 +0000 (08:29 +0000)]
Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace [CheckNodeSecurity] with [CheckAccessToNode]
haraken@chromium.org [Wed, 8 Feb 2012 08:13:58 +0000 (08:13 +0000)]
Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

* page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

* http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
* http/tests/security/cross-frame-access-frameelement.html: Added.
* http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
haraken@chromium.org [Wed, 8 Feb 2012 08:05:56 +0000 (08:05 +0000)]
Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
https://bugs.webkit.org/show_bug.cgi?id=78081

Reviewed by Adam Barth.

[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/Node.idl:
* html/HTMLElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WK2] enable-webaudio WebSetting
philn@webkit.org [Wed, 8 Feb 2012 08:05:05 +0000 (08:05 +0000)]
[GTK][WK2] enable-webaudio WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77959

Reviewed by Martin Robinson.

Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WK2] Add WebKitResponsePolicyDecision
mrobinson@webkit.org [Wed, 8 Feb 2012 07:21:31 +0000 (07:21 +0000)]
[GTK] [WK2] Add WebKitResponsePolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=76789

Reviewed by Philippe Normand.

Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.

* GNUmakefile.am: Added new source files to the list.
* UIProcess/API/gtk/WebKitPolicyClient.cpp:
(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.
* UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
* UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
* UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
* UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:
(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Move geometry headers in Platform API to Platform directory
commit-queue@webkit.org [Wed, 8 Feb 2012 06:56:26 +0000 (06:56 +0000)]
[chromium] Move geometry headers in Platform API to Platform directory
https://bugs.webkit.org/show_bug.cgi?id=78067

Patch by James Robinson <jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

Source/Platform:

This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.

Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.

* Platform.gyp/Platform.gyp:
* Platform.gyp/copy_webcore_headers.py: Added.
(CopyHeaders):
(Main):
* chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.
(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.
(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):
* chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.
(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.
(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.
(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.
(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):

Source/WebKit/chromium:

Add forwarding headers for several API types moved into Platform.

* public/platform/WebFloatPoint.h:
* public/platform/WebFloatQuad.h:
* public/platform/WebFloatRect.h:
* public/platform/WebPoint.h:
* public/platform/WebRect.h:
* public/platform/WebSize.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd "JS" prefix to JSC-specific IDLs
haraken@chromium.org [Wed, 8 Feb 2012 06:40:54 +0000 (06:40 +0000)]
Add "JS" prefix to JSC-specific IDLs
https://bugs.webkit.org/show_bug.cgi?id=77846

Reviewed by Darin Adler.

In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:

[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject]  (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate]  (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/TestTypedArray.idl:
* dom/Attr.idl:
* dom/DataTransferItemList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Node.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/DOMFormData.idl:
* html/DOMURL.idl:
* html/HTMLAppletElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLVideoElement.idl:
* html/TextTrackCue.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* mediastream/LocalMediaStream.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/StorageInfo.idl:
* svg/SVGElement.idl:
* svg/SVGElementInstance.idl:
* workers/DedicatedWorkerContext.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] WebTextCheckingResult should have new default constructor
morrita@google.com [Wed, 8 Feb 2012 06:33:11 +0000 (06:33 +0000)]
[Chromium] WebTextCheckingResult should have new default constructor
https://bugs.webkit.org/show_bug.cgi?id=78066

Reviewed by Ryosuke Niwa.

Added a new default constructor. ex-default constructor will be removed
in an upcoming change.

* public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
haraken@chromium.org [Wed, 8 Feb 2012 05:47:36 +0000 (05:47 +0000)]
Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
https://bugs.webkit.org/show_bug.cgi?id=78076

Reviewed by Adam Barth.

This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].

Test: bindings/scripts/test/TestCustomNamedGetter.idl

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

* html/HTMLDocument.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameSetElement.idl:

* bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.

* bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.
(WebCore):
(WebDOMTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.
(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.
(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.
(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.
(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.
(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert TableSection cell and border calculations to integers
eae@chromium.org [Wed, 8 Feb 2012 05:37:54 +0000 (05:37 +0000)]
Revert TableSection cell and border calculations to integers
https://bugs.webkit.org/show_bug.cgi?id=77918

Reviewed by Eric Seidel.

Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.

No new tests.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlumb through webGLErrorsToConsoleEnable in WebSettings
commit-queue@webkit.org [Wed, 8 Feb 2012 05:34:09 +0000 (05:34 +0000)]
Plumb through webGLErrorsToConsoleEnable in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=78061

Patch by Gregg Tavares <gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessar...
commit-queue@webkit.org [Wed, 8 Feb 2012 05:06:33 +0000 (05:06 +0000)]
Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* wtf/Platform.h:

Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* WebCore.gypi:
* platform/PlatformGestureRecognizer.h: Removed.
* platform/chromium/FramelessScrollView.h:
(WebCore):
(FramelessScrollView):
* platform/chromium/GestureRecognizerChromium.cpp: Removed.
* platform/chromium/GestureRecognizerChromium.h: Removed.
* platform/chromium/PopupContainer.cpp:
(WebCore):
* platform/chromium/PopupContainer.h:
* platform/chromium/PopupListBox.cpp:
(WebCore):
* platform/chromium/PopupListBox.h:
(PopupListBox):

Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* blackberry/WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* WebKit.gypi:
* features.gypi:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
* tests/InnerGestureRecognizerTest.cpp: Removed.

LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
* fast/events/touch/page-scaled-touch-gesture-click.html:
* fast/events/touch/touch-gesture-click-expected.txt: Removed.
* fast/events/touch/touch-gesture-click.html: Removed.
* fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
* fast/events/touch/touch-gesture-scroll.html: Removed.
* platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
* platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
arv@chromium.org [Wed, 8 Feb 2012 04:23:34 +0000 (04:23 +0000)]
[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052

Reviewed by Nate Chapin.

Source/WebCore:

Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.

Covered by existing tests

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
haraken@chromium.org [Wed, 8 Feb 2012 04:14:02 +0000 (04:14 +0000)]
[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
leo.yang@torchmobile.com.cn [Wed, 8 Feb 2012 04:05:20 +0000 (04:05 +0000)]
[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd pixelSnappedX/Y/Width/Height methods
eae@chromium.org [Wed, 8 Feb 2012 03:56:27 +0000 (03:56 +0000)]
Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040

Reviewed by Eric Seidel.

Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.

When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.

In summary, the values are computed as follows:
        x: round(x)
        y: round(y)
        maxX: round(x + width)
        maxY: round(y + height)
        width: round(x + width) - round(x)
        height: round(y + height) - round(y)

We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.

No new tests, no functionality changes.

* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
* rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107032 268f45cc-cd09-0410-ab3c-d52691b4dbfc