WebKit-https.git
10 years agoHide the typeinfo name symbols for std::exception and std::bad_alloc too.
mrowe@apple.com [Wed, 2 Mar 2011 04:25:55 +0000 (04:25 +0000)]
Hide the typeinfo name symbols for std::exception and std::bad_alloc too.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 04:21:07 +0000 (04:21 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed expectations update. This is a follow-up to r80061.

        Leopard has a slightly different error message, so
        platform/mac-leopard needs its own expected results for the
        websocket test. Added platform specific expected results for
        the other tests which are consistently failing with an extra
        console message on the bots.

        * platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
        * platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
        * platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 David Grogan <dgrogan@chromium.org>
jorlow@chromium.org [Wed, 2 Mar 2011 03:57:56 +0000 (03:57 +0000)]
2011-03-01  David Grogan  <dgrogan@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: public webkit interfaces for firing versionchange events to IDBDatabase objects
        https://bugs.webkit.org/show_bug.cgi?id=55548

        * WebKit.gyp:
        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::createObjectStore):
        (WebKit::WebIDBDatabase::open):
        * public/WebIDBDatabaseCallbacks.h: Added.
        (WebKit::WebIDBDatabaseCallbacks::~WebIDBDatabaseCallbacks):
        (WebKit::WebIDBDatabaseCallbacks::onVersionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Wed, 2 Mar 2011 03:22:59 +0000 (03:22 +0000)]
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/OptionsWinCE.cmake:
        * Source/cmakeconfig.h.cmake:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * wtf/Platform.h:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * features.gypi:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * features.pri:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 03:14:59 +0000 (03:14 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed expectations update. This is expected
        behavior after r80061, which enabled printing
        of more console messages.

        * http/tests/xmlviewer/dumpAsText/wml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix after removal of Frame::isContentEditable.
kevino@webkit.org [Wed, 2 Mar 2011 03:05:55 +0000 (03:05 +0000)]
[wx] Build fix after removal of Frame::isContentEditable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Wed, 2 Mar 2011 02:54:12 +0000 (02:54 +0000)]
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80078.
        http://trac.webkit.org/changeset/80078
        https://bugs.webkit.org/show_bug.cgi?id=55545

        underlying change was rolled out (Requested by tonyg-cr on
        #webkit).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 02:45:23 +0000 (02:45 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed new baselines

        [chromium] Add expectations for new tests in r80049
        https://bugs.webkit.org/show_bug.cgi?id=55543

        * platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
        * platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 2 Mar 2011 02:35:44 +0000 (02:35 +0000)]
2011-02-25  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Abstract "pixels with a graphics context" into its own class
        https://bugs.webkit.org/show_bug.cgi?id=55259

        This creates new PlatformCanvas/PlatformImage classes which wrap
        all of the #ifdef Skia/Cg warts from the compositor.  All classes
        (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
        modified to use these abstractions.

        Tests: LayoutTests/compositing

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateContentsIfDirty):
        (WebCore::ContentLayerChromium::resizeUploadBuffer):
        (WebCore::ContentLayerChromium::updateTextureIfNeeded):
        (WebCore::ContentLayerChromium::updateTexture):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        (WebCore::ImageLayerChromium::updateTextureIfNeeded):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::updateFromPixels):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp: Added.
        (WebCore::PlatformCanvas::PlatformCanvas):
        (WebCore::PlatformCanvas::~PlatformCanvas):
        (WebCore::PlatformCanvas::resize):
        (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
        (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
        (WebCore::PlatformCanvas::Painter::Painter):
        (WebCore::PlatformCanvas::Painter::~Painter):
        * platform/graphics/chromium/PlatformCanvas.h: Added.
        (WebCore::PlatformCanvas::AutoLocker::pixels):
        (WebCore::PlatformCanvas::Painter::context):
        (WebCore::PlatformCanvas::size):
        * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
        (WebCore::PlatformImage::PlatformImage):
        (WebCore::PlatformImage::updateFromImage):
        * platform/graphics/chromium/PlatformImage.h: Added.
        (WebCore::PlatformImage::pixels):
        (WebCore::PlatformImage::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebKit2: Add verification scripts to WebKit2 project and fix the issues they...
mrowe@apple.com [Wed, 2 Mar 2011 02:24:24 +0000 (02:24 +0000)]
Source/WebKit2: Add verification scripts to WebKit2 project and fix the issues they reveal.

Reviewed by Sam Weinig.

* Configurations/Base.xcconfig: Add linker flags to prevent C++ standard
library functions from being exported as weak externals.
* Configurations/WebKit2.xcconfig: Inherit linker flags from the project level.
* Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::separatorItem): Use DEFINE_STATIC_LOCAL.
* UIProcess/WebPageGroup.cpp:
(WebKit::webPageGroupMap): Ditto.
* WebKit2.xcodeproj/project.pbxproj: Don't copy .in files in to the framework.
Run verification scripts at the appropriate times.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didBeginEditing): Use DEFINE_STATIC_LOCAL.
(WebKit::WebEditorClient::respondToChangedContents): Ditto.
(WebKit::WebEditorClient::respondToChangedSelection): Ditto.
(WebKit::WebEditorClient::didEndEditing): Ditto.
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::idToHistoryItemMap): Ditto.
(WebKit::historyItemToIDMap): Ditto.

Tools: Update verification scripts to handle WebKit2.

Reviewed by Sam Weinig.

* Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
* Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Wed, 2 Mar 2011 02:15:26 +0000 (02:15 +0000)]
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/OptionsWinCE.cmake:
        * Source/cmakeconfig.h.cmake:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * wtf/Platform.h:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * features.pri:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * features.gypi:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Scripts/build-webkit:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 02:10:30 +0000 (02:10 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations

        [chromium] Skip new viewport tests added by r80068
        https://bugs.webkit.org/show_bug.cgi?id=55539

        LayoutTestController doesn't implement dumpConfigurationForViewport() which is needed for this test.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 02:04:19 +0000 (02:04 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 2 Mar 2011 02:02:28 +0000 (02:02 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        IDBKeyRange.bound() should not use the optional options object
        https://bugs.webkit.org/show_bug.cgi?id=55419

        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        * storage/indexeddb/objectstore-cursor.html:
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        IDBKeyRange.bound() should not use the optional options object
        https://bugs.webkit.org/show_bug.cgi?id=55419

        http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept

        Added some code to existing tests to cover these cases.

        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::bound):
        * storage/IDBKeyRange.h:
        * storage/IDBKeyRange.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Wed, 2 Mar 2011 01:46:15 +0000 (01:46 +0000)]
Build fix.

* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Mar 2011 01:39:22 +0000 (01:39 +0000)]
2011-03-01  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Apply sort-Xcode-project-file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 01:30:22 +0000 (01:30 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed, missed updating a call to WebCore::computeViewportAttributes
        who's prototype changed.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::viewportAttributesForSize): pass in a value for the document argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 2 Mar 2011 01:23:44 +0000 (01:23 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        V8 code generator doesn't properly support a single SerializedScriptValue attribute
        https://bugs.webkit.org/show_bug.cgi?id=55530

        This is tested by the bindings tests changes.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added.
        (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
        (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface):
        (WebDOMTestSerializedScriptValueInterface::operator=):
        (WebDOMTestSerializedScriptValueInterface::impl):
        (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface):
        (WebDOMTestSerializedScriptValueInterface::value):
        (toWebCore):
        (toWebKit):
        * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added.
        (WebKit::kit):
        (webkit_dom_test_serialized_script_value_interface_get_value):
        (WebKit::core):
        (webkit_dom_test_serialized_script_value_interface_finalize):
        (webkit_dom_test_serialized_script_value_interface_set_property):
        (webkit_dom_test_serialized_script_value_interface_get_property):
        (webkit_dom_test_serialized_script_value_interface_constructed):
        (webkit_dom_test_serialized_script_value_interface_class_init):
        (webkit_dom_test_serialized_script_value_interface_init):
        (WebKit::wrapTestSerializedScriptValueInterface):
        * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
        (WebCore::JSTestInterface::JSTestInterface):
        * bindings/scripts/test/JS/JSTestInterface.h:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
        (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
        (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::JSTestObjConstructor::JSTestObjConstructor):
        (WebCore::JSTestObj::JSTestObj):
        (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
        (WebCore::jsTestObjPrototypeFunctionSerializedValue):
        (WebCore::jsTestObjPrototypeFunctionIdbKey):
        (WebCore::jsTestObjPrototypeFunctionOptionsObject):
        (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
        (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
        (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added.
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
        (WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
        (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
        (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
        (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
        (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
        (WebCore::jsTestSerializedScriptValueInterfaceValue):
        (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
        (WebCore::JSTestSerializedScriptValueInterface::getConstructor):
        (WebCore::toJS):
        (WebCore::toTestSerializedScriptValueInterface):
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
        (WebCore::JSTestSerializedScriptValueInterface::createStructure):
        (WebCore::JSTestSerializedScriptValueInterface::impl):
        (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
        (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
        * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
        * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added.
        (-[DOMTestSerializedScriptValueInterface dealloc]):
        (-[DOMTestSerializedScriptValueInterface finalize]):
        (-[DOMTestSerializedScriptValueInterface value]):
        (core):
        (kit):
        * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
        * bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
        * bindings/scripts/test/V8/V8TestInterface.cpp:
        (WebCore::ConfigureV8TestInterfaceTemplate):
        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
        (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
        (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
        (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
        (WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
        (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
        (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
        (WebCore::V8TestSerializedScriptValueInterface::derefObject):
        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added.
        (WebCore::V8TestSerializedScriptValueInterface::toNative):
        (WebCore::V8TestSerializedScriptValueInterface::wrap):
        (WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 01:23:39 +0000 (01:23 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update

        [chromium] Expectations updates from r80061
        https://bugs.webkit.org/show_bug.cgi?id=55533

        * platform/chromium-linux/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
        * platform/chromium-linux/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
        * platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 2 Mar 2011 01:23:00 +0000 (01:23 +0000)]
2011-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Joseph Pecoraro.

        Misaligned memory access in CloneDeserializer on all ARM arch.
        https://bugs.webkit.org/show_bug.cgi?id=48742

        Add a CPU class for architectures that need aligned addresses
        for memory access.

        * wtf/Platform.h:
2011-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Joseph Pecoraro.

        Misaligned memory access in CloneDeserializer on all ARM arch.
        https://bugs.webkit.org/show_bug.cgi?id=48742

        Push platforms that need aligned memory access down the
        endian independent serialization and deserialization
        paths.

        * bindings/js/SerializedScriptValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Helder Correia <helder@sencha.com>
helder@sencha.com [Wed, 2 Mar 2011 01:16:30 +0000 (01:16 +0000)]
2011-03-01  Helder Correia  <helder@sencha.com>

        Unreviewed Qt skipped tests update.

        The manually committed patch didn't include the update to
        fast/canvas/canvas-strokePath-gradient-shadow.html by mistake:
        No shadow when stroking a path with a gradient
        https://bugs.webkit.org/show_bug.cgi?id=55436

        * platform/qt/Skipped: Skip new test since it fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 00:59:59 +0000 (00:59 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        Added tests specifically to test Console warnings.

        * fast/viewport/viewport-warnings-1.html: Added.
        * fast/viewport/viewport-warnings-2.html: Added.
        * fast/viewport/viewport-warnings-3.html: Added.
        * fast/viewport/viewport-warnings-4.html: Added.
        * fast/viewport/viewport-warnings-5.html: Added.
        * fast/viewport/viewport-warnings-6.html: Added.
        * fast/viewport/viewport-warnings-7.html: Added.

2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        Correct and improve the error messages for viewport
        parsing. Clarify the difference between incorrect
        keys, values, and when to use the device-width or
        device-height constants.

        * dom/ViewportArguments.cpp:
        (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height.
        (WebCore::numericPrefix):
        (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
        (WebCore::setViewportFeature): report a warning for an unrecognized key.
        (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
        (WebCore::viewportErrorMessageLevel):
        * dom/ViewportArguments.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Mar 2011 00:56:50 +0000 (00:56 +0000)]
2011-03-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WKPluginSiteDataManagerClearAllSiteData is not working
        https://bugs.webkit.org/show_bug.cgi?id=55528
        <rdar://problem/9071823>

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryGetSitesWithData):
        Remove version checks, checking that the function pointer is not null is enough.

        (WebKit::NetscapePluginModule::tryClearSiteData):
        Remove version checks, checking that the function pointer is not null is enough.
        Also, correctly convert a null String to a null CString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 00:50:30 +0000 (00:50 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed baseline

        [chromium] Add baseline for test added by r80040
        https://bugs.webkit.org/show_bug.cgi?id=55529

        * platform/chromium-mac/fast/table/table-and-parts-outline-expected.checksum: Added.
        * platform/chromium-mac/fast/table/table-and-parts-outline-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Mar 2011 00:47:56 +0000 (00:47 +0000)]
2011-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add pre- and post-build actions for JavaScriptCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=55507

        After this patch, we have all the steps for building the main
        JavaScriptCore framework except the "copy headers" step, which I'll do
        next.

        * gyp/JavaScriptCore.gyp:
2011-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add pre- and post-build actions for JavaScriptCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=55507

        Remove the portion of this file that was split out into common.gypi.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 00:45:02 +0000 (00:45 +0000)]
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
        https://bugs.webkit.org/show_bug.cgi?id=55523

        The marked text is at offset 0 with length 1, not at offset 1 with length 0.

        * platform/mac/editing/input/selection-change-closes-typing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 00:34:09 +0000 (00:34 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations

        [chromium] Add expectations for new tests in r80049
        https://bugs.webkit.org/show_bug.cgi?id=55526

        * platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 00:28:20 +0000 (00:28 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport parsing no longer accepts "1.0;" value as valid.
        https://bugs.webkit.org/show_bug.cgi?id=53705

        Adding expected results generated from the build-bot. They look
        correct, as the viewport "123x135" has the expected width of "123".

        * fast/viewport/viewport-129-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 00:21:37 +0000 (00:21 +0000)]
2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

LayoutTests:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            All Console Messages should be passed to ChromeClients.
            https://bugs.webkit.org/show_bug.cgi?id=54926

            Passing more message types to the ChromeClient allows
            some more messages to get output during tests. Specifically
            HTML, XML, and Other message types.

            * inspector/audits/audits-panel-functional.html: correct a legitimate HTML parse error.
            * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
            * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
            * http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
            * http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
            * http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
            * http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
            * http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
            * http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
            * http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
            * http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
            * http/tests/security/xss-DENIED-xsl-document-expected.txt:
            * http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
            * platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
            * platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
            * platform/mac/http/tests/inspector/console-websocket-error-expected.txt:

Source/WebCore:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            All Console Messages should be passed to ChromeClients.
            https://bugs.webkit.org/show_bug.cgi?id=54926

            Do not filter the message type here, allow clients
            to filter and deal with the different message types.

            * page/Console.cpp:
            (WebCore::Console::addMessage):

Source/WebKit/mac:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            All Console Messages should be passed to ChromeClients.
            https://bugs.webkit.org/show_bug.cgi?id=54926

            Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
            which supersedes -webView:addMessageToConsole if it exists. The new delegate
            does not filter to only JavaScript originated console messages. The old
            delegate is left around for clients that expect filtered messages, like
            DashCode and older versions of Safari.

            The dictionary message passed to the delegate now includes more information
            about the message source, type, and level.

            * WebCoreSupport/WebChromeClient.mm:
            (stringForMessageSource):
            (stringForMessageType):
            (stringForMessageLevel):
            (WebChromeClient::addMessageToConsole):
            * WebView/WebUIDelegatePrivate.h:

Tools:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            All Console Messages should be passed to ChromeClients.
            https://bugs.webkit.org/show_bug.cgi?id=54926

            Update DumpRenderTree's UIDelegate to use the new console message delegate.

            * DumpRenderTree/mac/UIDelegate.mm:
            (-[UIDelegate webView:addMessageToConsole:withSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 00:14:34 +0000 (00:14 +0000)]
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit does not merge text decorations in the typing style and the selected element properly
        https://bugs.webkit.org/show_bug.cgi?id=55349

        Added a test to ensure WebKit merges text decorations in the typing style and the inline style
        of the element around the caret when computing the style at the selection start.

        * editing/execCommand/merge-text-decoration-with-typing-style-expected.txt: Added.
        * editing/execCommand/merge-text-decoration-with-typing-style.html: Added.
        * editing/style/push-down-inline-styles-expected.txt: Rebaselined due to the change in which text decoration
        values appear.
        * editing/style/script-tests/push-down-inline-styles.js: Ditto.
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit does not merge text decorations in the typing style and the selected element properly
        https://bugs.webkit.org/show_bug.cgi?id=55349

        The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
        Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
        calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.

        Test: editing/execCommand/merge-text-decoration-with-typing-style.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*;
        calls mergeInlineStyleOfElement.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
        (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
        (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
        * editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 2 Mar 2011 00:06:11 +0000 (00:06 +0000)]
2011-03-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Stop instantiating legacy editing Positions in VisiblePosition
        https://bugs.webkit.org/show_bug.cgi?id=52919

        Changing usage of legacy VisiblePosition constructor. Since we were dealing
        with positions from DOM Ranges, we're guaranteed a parent-anchored position.

        * WebView/WebFrame.mm:
        (-[WebFrame _caretRectAtPosition:affinity:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController doCompletion]):
2011-03-01  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Stop instantiating legacy editing Positions in VisiblePosition
        https://bugs.webkit.org/show_bug.cgi?id=52919

        Changing VisiblePosition completely away from legacy positions.

        No new tests since this is functionaly equivalent.

        * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
        adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
        outside of WebCore, they should be parent anchored.
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
        * accessibility/AccessibilityObject.cpp:
        (WebCore::startOfStyleRange):
        (WebCore::endOfStyleRange):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (objectAndOffsetUnignored):
        * dom/Position.cpp:
        (WebCore::Position::document): Added this inline function to avoid the necessity
        of calling anchorNode to assure a document from a Position.
        (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
        (WebCore::Position::downstream): ditto
        * dom/Range.cpp:
        (WebCore::Range::editingStartPosition):
        * editing/Editor.cpp:
        (WebCore::Editor::canDeleteRange):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::setSelectedRange):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::canonicalPosition):
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::localCaretRect):
        (WebCore::makeRange):
        (WebCore::startVisiblePosition):
        (WebCore::endVisiblePosition):
        (WebCore::setStart):
        (WebCore::setEnd):
        (WebCore::isFirstVisiblePositionInNode):
        (WebCore::isLastVisiblePositionInNode):
        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::VisiblePosition):
        * editing/htmlediting.cpp:
        (WebCore::firstInSpecialElement):
        (WebCore::lastInSpecialElement):
        (WebCore::visiblePositionBeforeNode):
        (WebCore::visiblePositionAfterNode):
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::endPositionForLine):
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        (WebCore::endOfBlock):
        (WebCore::startOfDocument):
        (WebCore::endOfDocument):
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::collapse):
        (WebCore::DOMSelection::setBaseAndExtent):
        (WebCore::DOMSelection::setPosition):
        (WebCore::DOMSelection::extend):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::visiblePositionForIndex):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::selectSubString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 00:04:03 +0000 (00:04 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update

        [chromium] Rebaseline fast/ruby/base-shorter-than-text.html
        https://bugs.webkit.org/show_bug.cgi?id=55522

        This changed as a result of r80015.

        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum: Added.
        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 1 Mar 2011 23:57:39 +0000 (23:57 +0000)]
2011-03-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Tragically, we stopped running the python unit tests
        on Chromium Win just as I was getting them to be green.
        This patch turns them back on.

        https://bugs.webkit.org/show_bug.cgi?id=55521

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 1 Mar 2011 23:57:38 +0000 (23:57 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        Add a primaryKey method to IDBCursor
        https://bugs.webkit.org/show_bug.cgi?id=55518

        In prep for https://bugs.webkit.org/show_bug.cgi?id=55443

        * public/WebIDBCursor.h:
        (WebKit::WebIDBCursor::primaryKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 1 Mar 2011 23:55:36 +0000 (23:55 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

       Reviewed by Steve Block.

       When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
       https://bugs.webkit.org/show_bug.cgi?id=54785

       * storage/indexeddb/transaction-abort.html: Added
       * storage/indexeddb/transaction-abort-expected.txt: Added
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

       Reviewed by Steve Block.

       When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
       https://bugs.webkit.org/show_bug.cgi?id=54785

       This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
       the right thing and continue to do the right thing. It also modifies EventQueue
       so that we can cancel an event. To do this efficiently, the vector is now a
       ListHashSet.

       Cancelling the event is harder/messier, but the most deterministic thing to do.
       To the user, the work isn't done until we fire the onsuccess/onerror handler.
       So the event (which does fire that) needs to be cancelable.

       transaction-abort.html tests this.

       * dom/EventQueue.cpp:
       (WebCore::EventQueue::enqueueEvent):
       (WebCore::EventQueue::cancelEvent):
       (WebCore::EventQueue::pendingEventTimerFired):
       (WebCore::EventQueue::dispatchEvent):
       * dom/EventQueue.h:
       * dom/ExceptionCode.cpp:
       * storage/IDBCursor.cpp:
       (WebCore::IDBCursor::update):
       (WebCore::IDBCursor::deleteFunction):
       * storage/IDBDatabaseBackendImpl.cpp:
       (WebCore::IDBDatabaseBackendImpl::close):
       * storage/IDBDatabaseException.h:
       * storage/IDBIndex.cpp:
       (WebCore::IDBIndex::openCursor):
       (WebCore::IDBIndex::openKeyCursor):
       (WebCore::IDBIndex::get):
       (WebCore::IDBIndex::getKey):
       * storage/IDBObjectStore.cpp:
       (WebCore::IDBObjectStore::get):
       (WebCore::IDBObjectStore::add):
       (WebCore::IDBObjectStore::put):
       (WebCore::IDBObjectStore::deleteFunction):
       (WebCore::IDBObjectStore::clear):
       (WebCore::IDBObjectStore::openCursor):
       * storage/IDBRequest.cpp:
       (WebCore::IDBRequest::IDBRequest):
       (WebCore::IDBRequest::~IDBRequest):
       (WebCore::IDBRequest::readyState):
       (WebCore::IDBRequest::markEarlyDeath):
       (WebCore::IDBRequest::source):
       (WebCore::IDBRequest::abort):
       (WebCore::IDBRequest::onSuccess):
       (WebCore::IDBRequest::dispatchEvent):
       (WebCore::IDBRequest::enqueueEvent):
       * storage/IDBRequest.h:
       * storage/IDBTransaction.cpp:
       (WebCore::IDBTransaction::registerRequest):
       (WebCore::IDBTransaction::unregisterRequest):
       (WebCore::IDBTransaction::onAbort):
       * storage/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 1 Mar 2011 23:54:02 +0000 (23:54 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Mihai Parparita.

        EventQueue needs to be ref counted
        https://bugs.webkit.org/show_bug.cgi?id=55512

        EventQueue needs to be ref counted because it's possible for its instance
        to be deleted while it's dispatching events. This is the reason why
        https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.

        No change of behavior, so no tests.

        * dom/Document.h:
        * dom/EventQueue.cpp:
        (WebCore::EventQueue::create):
        * dom/EventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIncorporate a review comment I missed in r80051
aroben@apple.com [Tue, 1 Mar 2011 23:45:09 +0000 (23:45 +0000)]
Incorporate a review comment I missed in r80051

* Shared/Plugins/Netscape/NetscapePluginModule.cpp: Clarified error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Mar 2011 23:36:53 +0000 (23:36 +0000)]
2011-03-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Rolled back in r79627 now that the underlying cause for it crashing is fixed.
        https://bugs.webkit.org/show_bug.cgi?id=55159

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/Heap.cpp:
        (JSC::Heap::allocateSlowCase):
        * runtime/Heap.h:
        * runtime/JSCell.h:
        (JSC::JSCell::MarkedSpace::sizeClassFor):
        (JSC::JSCell::Heap::allocate):
        (JSC::JSCell::JSCell::operator new):
        * runtime/MarkedBlock.h:
        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::reset):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::SizeClass::SizeClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the PLUGIN_ARCHITECTURE() macro work with MSVC
aroben@apple.com [Tue, 1 Mar 2011 23:36:21 +0000 (23:36 +0000)]
Make the PLUGIN_ARCHITECTURE() macro work with MSVC

Fixes <http://webkit.org/b/55513> <rdar://problem/9069189> REGRESSION (r79925): Lots of
plugins tests crashing in NetscapePlugin::initialize on Windows

Reviewed by Anders Carlsson.

* Shared/Plugins/Netscape/NetscapePluginModule.cpp: Added a compile-time check to make sure
PLUGIN_ARCHITECTURE() is defined for some platform.

* config.h: Removed the parentheses from the use of "defined" in the PLUGIN_ARCHITECTURE()
macro. This matches PLATFORM(), OS(), etc., and makes the macro work on Windows. Also
replaced the nonsense OS(WIN) with OS(WINDOWS).

* win/WebKit2.vcproj: Added config.h for editing convenience. Let VS do its thang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 23:27:17 +0000 (23:27 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed new baseline

        [chromium] Add win baseline for fast/table/table-and-parts-outline.html
        https://bugs.webkit.org/show_bug.cgi?id=55517

        Test was added by r80040

        * platform/chromium-win/fast/table/table-and-parts-outline-expected.checksum: Added.
        * platform/chromium-win/fast/table/table-and-parts-outline-expected.png: Added.
        * platform/chromium-win/fast/table/table-and-parts-outline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Helder Correia <helder@sencha.com>
helder@sencha.com [Tue, 1 Mar 2011 23:24:33 +0000 (23:24 +0000)]
2011-03-01  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        No shadow when stroking a path with a gradient
        https://bugs.webkit.org/show_bug.cgi?id=55436

        This happens in CG and is related to bug 52509, this time to be fixed
        in GraphicsContext::strokePath(). The gradient needs to be drawn
        clipped to the stroke on a CGLayer first, then the layer drawn on the
        GraphicsContext.

        * fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
        * fast/canvas/canvas-strokePath-gradient-shadow.html: Added.
        * fast/canvas/script-tests/canvas-strokePath-gradient-shadow.js: Added.
        * platform/chromium/test_expectations.txt: Skip new test since it fails.
        * platform/mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
        * platform/mac/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
        * platform/qt/Skipped: Skip new test since it fails.
        * platform/qt/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/qt/svg/css/path-gradient-stroke-shadow-expected.png: Added.
        * platform/qt/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
        * svg/css/path-gradient-stroke-shadow.svg: Added.
2011-03-01  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        No shadow when stroking a path with a gradient
        https://bugs.webkit.org/show_bug.cgi?id=55436

        This happens in CG and is related to bug 52509, this time to be fixed
        in GraphicsContext::strokePath(). The gradient needs to be drawn
        clipped to the stroke on a CGLayer first, then the layer drawn on the
        GraphicsContext.

        Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
               svg/css/path-gradient-stroke-shadow.svg

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::strokePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 1 Mar 2011 23:19:58 +0000 (23:19 +0000)]
2011-03-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Roben.

        Disable
        webkitpy.common.system.executive_unittest.ExecutiveTest.\
           test_kill_all fails on win until it can be properly triaged.

        https://bugs.webkit.org/show_bug.cgi?id=54790

        * Scripts/webkitpy/common/system/executive_unittest.py:

    2011-03-01  Helder Correia  <helder@sencha.com>

            Unreviewed. Add myself to committers.py.

            * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Font::spaceWidth() to be a float instead of an int.
hyatt@apple.com [Tue, 1 Mar 2011 23:13:18 +0000 (23:13 +0000)]
Fix Font::spaceWidth() to be a float instead of an int.

Reviewed by Dan Bernstein.

* platform/graphics/Font.h:
(WebCore::Font::spaceWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Helder Correia <helder@sencha.com>
helder@sencha.com [Tue, 1 Mar 2011 23:01:58 +0000 (23:01 +0000)]
2011-03-01  Helder Correia  <helder@sencha.com>

        Unreviewed. Add myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 22:56:08 +0000 (22:56 +0000)]
2011-02-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Chromium gypi file should include Java bridge files from WebCore/bridge
        https://bugs.webkit.org/show_bug.cgi?id=55387

        No new tests, no code changes.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 22:55:31 +0000 (22:55 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed new baseline

        [chromium] Add linux baseline for fast/table/table-and-parts-outline.html
        https://bugs.webkit.org/show_bug.cgi?id=55511

        Test was added by r80040

        * platform/chromium-linux/fast/table/table-and-parts-outline-expected.checksum: Added.
        * platform/chromium-linux/fast/table/table-and-parts-outline-expected.png: Added.
        * platform/chromium-linux/fast/table/table-and-parts-outline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 1 Mar 2011 22:34:38 +0000 (22:34 +0000)]
2011-03-01  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] Handle the case where no responseEnd time is available.
        https://bugs.webkit.org/show_bug.cgi?id=55444

        * platform/chromium/test_expectations.txt: Remove CRASH from fast/dom/prototype-inheritance-2.html
2011-03-01  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] Handle the case where no responseEnd time is available.
        https://bugs.webkit.org/show_bug.cgi?id=55444

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0.
        (WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 1 Mar 2011 22:31:15 +0000 (22:31 +0000)]
2011-03-01  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed, adding missing change for r80034.

        Add a handler class for Win32 HANDLE
        https://bugs.webkit.org/show_bug.cgi?id=55334

        * platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Tue, 1 Mar 2011 22:22:21 +0000 (22:22 +0000)]
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80037.
        http://trac.webkit.org/changeset/80037
        https://bugs.webkit.org/show_bug.cgi?id=55508

        broke compile on SL (Requested by tonyg-cr on #webkit).

        * fast/css/content/content-quotes-01-expected.txt: Removed.
        * fast/css/content/content-quotes-01.html: Removed.
        * fast/css/content/content-quotes-02-expected.txt: Removed.
        * fast/css/content/content-quotes-02.html: Removed.
        * fast/css/content/content-quotes-03-expected.txt: Removed.
        * fast/css/content/content-quotes-03.html: Removed.
        * fast/css/content/content-quotes-04-expected.txt: Removed.
        * fast/css/content/content-quotes-04.html: Removed.
        * fast/css/content/content-quotes-05-expected.txt: Removed.
        * fast/css/content/content-quotes-05.html: Removed.
        * fast/css/content/content-quotes-06-expected.txt: Removed.
        * fast/css/content/content-quotes-06.html: Removed.
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80037.
        http://trac.webkit.org/changeset/80037
        https://bugs.webkit.org/show_bug.cgi?id=55508

        broke compile on SL (Requested by tonyg-cr on #webkit).

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSParser.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/html.css:
        (q:before):
        (q:after):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::dirtyLineBoxesForRenderer):
        * rendering/RenderObject.h:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        (WebCore::RenderObjectChildList::appendChildNode):
        (WebCore::RenderObjectChildList::insertChildNode):
        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
        * rendering/RenderQuote.cpp: Removed.
        * rendering/RenderQuote.h: Removed.
        * rendering/RenderingAllInOne.cpp:
        * rendering/style/ContentData.cpp:
        (WebCore::ContentData::dataEquivalent):
        (WebCore::ContentData::deleteContent):
        * rendering/style/ContentData.h:
        * rendering/style/QuotesData.cpp: Removed.
        * rendering/style/QuotesData.h: Removed.
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:
        * rendering/style/StyleAllInOne.cpp:
        * rendering/style/StyleRareInheritedData.cpp:
        (WebCore::StyleRareInheritedData::operator==):
        * rendering/style/StyleRareInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 1 Mar 2011 22:18:32 +0000 (22:18 +0000)]
2011-03-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Paint outline for tables.
        https://bugs.webkit.org/show_bug.cgi?id=55474

        Test: fast/table/table-and-parts-outline.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintObject):
2011-03-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we draw outlines for table and table cells.
        https://bugs.webkit.org/show_bug.cgi?id=55474

        * fast/table/table-and-parts-outline.html: Added.
        * platform/mac/fast/table/table-and-parts-outline-expected.checksum: Added.
        * platform/mac/fast/table/table-and-parts-outline-expected.png: Added.
        * platform/mac/fast/table/table-and-parts-outline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace two script phases that do nothing but copy files with copy files build phases.
mrowe@apple.com [Tue, 1 Mar 2011 22:07:28 +0000 (22:07 +0000)]
Replace two script phases that do nothing but copy files with copy files build phases.

Reviewed by Sam Weinig.

This speeds up the build by a few seconds on high-end Mac Pros.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Tue, 1 Mar 2011 22:05:36 +0000 (22:05 +0000)]
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80028.
        http://trac.webkit.org/changeset/80028
        https://bugs.webkit.org/show_bug.cgi?id=55502

        'caused crashes; rolling out while investigating' (Requested
        by jorlow on #webkit).

        * storage/indexeddb/transaction-abort-expected.txt: Removed.
        * storage/indexeddb/transaction-abort.html: Removed.
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80028.
        http://trac.webkit.org/changeset/80028
        https://bugs.webkit.org/show_bug.cgi?id=55502

        'caused crashes; rolling out while investigating' (Requested
        by jorlow on #webkit).

        * dom/EventQueue.cpp:
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::pendingEventTimerFired):
        (WebCore::EventQueue::dispatchEvent):
        * dom/EventQueue.h:
        * dom/ExceptionCode.cpp:
        * storage/IDBCursor.cpp:
        (WebCore::IDBCursor::update):
        (WebCore::IDBCursor::deleteFunction):
        * storage/IDBDatabaseException.h:
        * storage/IDBDatabaseException.idl:
        * storage/IDBIndex.cpp:
        (WebCore::IDBIndex::openCursor):
        (WebCore::IDBIndex::openKeyCursor):
        (WebCore::IDBIndex::get):
        (WebCore::IDBIndex::getKey):
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::get):
        (WebCore::IDBObjectStore::add):
        (WebCore::IDBObjectStore::put):
        (WebCore::IDBObjectStore::deleteFunction):
        (WebCore::IDBObjectStore::clear):
        (WebCore::IDBObjectStore::openCursor):
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::~IDBRequest):
        (WebCore::IDBRequest::readyState):
        (WebCore::IDBRequest::dispatchEvent):
        (WebCore::IDBRequest::enqueueEvent):
        (WebCore::IDBRequest::source):
        * storage/IDBRequest.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::onAbort):
        * storage/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocontent property doesn't support quotes
carol.szabo@nokia.com [Tue, 1 Mar 2011 22:01:36 +0000 (22:01 +0000)]
content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503

Reviewed by David Hyatt  <hyatt@apple.com>

Source/WebCore:

Added full support for quotes as defined by CSS 2.1.

Tests: fast/css/content/content-quotes-01.html
       fast/css/content/content-quotes-02.html
       fast/css/content/content-quotes-03.html
       fast/css/content/content-quotes-04.html
       fast/css/content/content-quotes-05.html

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):
* css/CSSParser.h:
Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.
* css/html.css:
(q:before):
(q:after):
replaced the '"' workaround with open/close-quote
* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.
* rendering/RenderObject.h:
(WebCore::RenderObject::isQuote):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderQuote.cpp: Added.
(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
* rendering/RenderQuote.h: Added.
(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):
* rendering/RenderingAllInOne.cpp:
Included RenderQuote.cpp
* rendering/style/StyleAllInOne.cpp:
Included QuotesData.cpp
* rendering/style/ContentData.cpp:
(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.
* rendering/style/ContentData.h:
(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.
* rendering/style/StyleRareInheritedData.h:
Added quotes

LayoutTests:

Added new tests for quotes.

* fast/css/content/content-quotes-01-expected.txt: Added.
* fast/css/content/content-quotes-01.html: Added.
* fast/css/content/content-quotes-02-expected.txt: Added.
* fast/css/content/content-quotes-02.html: Added.
* fast/css/content/content-quotes-03-expected.txt: Added.
* fast/css/content/content-quotes-03.html: Added.
* fast/css/content/content-quotes-04-expected.txt: Added.
* fast/css/content/content-quotes-04.html: Added.
* fast/css/content/content-quotes-05-expected.txt: Added.
* fast/css/content/content-quotes-05.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Michael Nordman <michaeln@google.com>
michaeln@google.com [Tue, 1 Mar 2011 21:57:14 +0000 (21:57 +0000)]
2011-03-01  Michael Nordman  <michaeln@google.com>

        Reviewed by Alexey Proskuryakov.

        Tests for the correct relative priorities of network vs fallback namespaces in the appcache.
        If a resource url is in an appcache's network namespace and fallback namespace, the network
        namespace wins (with the exception of the special '*' network namespace which does not take
        priority over the fallback namespace.
        https://bugs.webkit.org/show_bug.cgi?id=49292

        * http/tests/appcache/online-fallback-layering-expected.txt: Added.
        * http/tests/appcache/online-fallback-layering.html: Added.
        * http/tests/appcache/resources/fallbacknamespace-fallback-resource.txt: Added.
        * http/tests/appcache/resources/fallbacknamespace-networknamespace-existing-resource.html: Added.
        * http/tests/appcache/resources/online-fallback-layering.manifest: Added.
2011-03-01  Michael Nordman  <michaeln@google.com>

        Reviewed by Alexey Proskuryakov.

        Alter the relative priorities of network vs fallback namespaces in the appcache.
        If a resource url is in an appcache's network namespace and fallback namespace, the network
        namespace wins (with the exception of the special '*' network namespace which does not take
        priority over the fallback namespace.
        https://bugs.webkit.org/show_bug.cgi?id=49292

        Test: http/tests/appcache/online-fallback-layering.html

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::isURLInOnlineWhitelist):
        * loader/appcache/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
        (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Add myself to the list of committers.
jennb@chromium.org [Tue, 1 Mar 2011 21:55:52 +0000 (21:55 +0000)]
Unreviewed. Add myself to the list of committers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 1 Mar 2011 21:38:12 +0000 (21:38 +0000)]
2011-03-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Add a handler class for Win32 HANDLE
        https://bugs.webkit.org/show_bug.cgi?id=55334

        This class will call CloseHandle in the destructor for valid handles.

        * platform/win/Win32Handle.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGive up if a crash log for the web process is taking too long to be saved on Windows
aroben@apple.com [Tue, 1 Mar 2011 21:29:15 +0000 (21:29 +0000)]
Give up if a crash log for the web process is taking too long to be saved on Windows

This should keep the bots from getting stuck while waiting for a crash log, if writing a
crash log ever hangs or the UI process for some reason doesn't notice it's finished.

Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
to be saved for the web process

Reviewed by Steve Falkenburg.

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
Generalized the code slightly to handle the optional object to wait on.
(WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
it (with a timeout) when waiting for a crash log for the web process to be saved. This will
prevent us from waiting forever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 21:13:48 +0000 (21:13 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update.

        [chromium] fast/text/font-size-zero.html
        https://bugs.webkit.org/show_bug.cgi?id=55497

        Appears to have been fixed by r79694.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fix GTK DumpRenderTree crash.
joepeck@webkit.org [Tue, 1 Mar 2011 21:07:24 +0000 (21:07 +0000)]
Unreviewed, fix GTK DumpRenderTree crash.

2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed, fix GTK DumpRenderTree crash.

        Viewport parsing no longer accepts "1.0;" value as valid.
        https://bugs.webkit.org/show_bug.cgi?id=53705

        Follow-up fix. Pass the correct number of arguments
        into layoutTestController.dumpConfigurationForViewport.

        * fast/viewport/viewport-129.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 1 Mar 2011 20:54:37 +0000 (20:54 +0000)]
2011-03-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Chris Marrin.

        <audio> and <video> should respect private browsing mode
        https://bugs.webkit.org/show_bug.cgi?id=55287
        <rdar://problem/9057699>

        No new tests, this is just the plumbing.

        * dom/Document.cpp:
        (WebCore::Document::privateBrowsingStateDidChange): New.
        (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto.
        (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
        * dom/Document.h:

        * dom/Element.h:
        (WebCore::Element::privateBrowsingStateDidChange): New.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes.
        (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes.
        (WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode.
        (WebCore::HTMLMediaElement::privateBrowsingStateDidChange):  New, call through to MediaPlayer.
        * html/HTMLMediaElement.h:

        * page/Page.cpp:
        (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):  Declare new interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Kamil Blank <k.blank@samsung.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 20:45:54 +0000 (20:45 +0000)]
2011-03-01  Kamil Blank  <k.blank@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Fixing headers order in webkit.h.
        https://bugs.webkit.org/show_bug.cgi?id=55316

        * webkit/webkit.h: Style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-18 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 1 Mar 2011 20:42:17 +0000 (20:42 +0000)]
2011-02-18  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
        https://bugs.webkit.org/show_bug.cgi?id=54785

        * storage/indexeddb/transaction-abort.html: Added
        * storage/indexeddb/transaction-abort-expected.txt: Added
2011-02-18  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
        https://bugs.webkit.org/show_bug.cgi?id=54785

        This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
        the right thing and continue to do the right thing. It also modifies EventQueue
        so that we can cancel an event. To do this efficiently, the vector is now a
        ListHashSet.

        Canelling the event is harder/messier, but the most deterministic thing to do.
        To the user, the work isn't done until we fire the onsuccess/onerror handler.
        So the event (which does fire that) needs to be cancelable.

        transaction-abort.html tests this.

        * dom/EventQueue.cpp:
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::cancelEvent):
        (WebCore::EventQueue::pendingEventTimerFired):
        (WebCore::EventQueue::dispatchEvent):
        * dom/EventQueue.h:
        * dom/ExceptionCode.cpp:
        * storage/IDBCursor.cpp:
        (WebCore::IDBCursor::update):
        (WebCore::IDBCursor::deleteFunction):
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::close):
        * storage/IDBDatabaseException.h:
        * storage/IDBIndex.cpp:
        (WebCore::IDBIndex::openCursor):
        (WebCore::IDBIndex::openKeyCursor):
        (WebCore::IDBIndex::get):
        (WebCore::IDBIndex::getKey):
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::get):
        (WebCore::IDBObjectStore::add):
        (WebCore::IDBObjectStore::put):
        (WebCore::IDBObjectStore::deleteFunction):
        (WebCore::IDBObjectStore::clear):
        (WebCore::IDBObjectStore::openCursor):
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::~IDBRequest):
        (WebCore::IDBRequest::readyState):
        (WebCore::IDBRequest::markEarlyDeath):
        (WebCore::IDBRequest::source):
        (WebCore::IDBRequest::abort):
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::dispatchEvent):
        (WebCore::IDBRequest::enqueueEvent):
        * storage/IDBRequest.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::registerRequest):
        (WebCore::IDBTransaction::unregisterRequest):
        (WebCore::IDBTransaction::onAbort):
        * storage/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 20:40:54 +0000 (20:40 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] Skip test added w/o expectations
        https://bugs.webkit.org/show_bug.cgi?id=55496

        Added by r80012 without expectations

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Mar 2011 20:39:07 +0000 (20:39 +0000)]
2011-03-01  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change. Remove failing expectations for
        editing/ tests that pass after r79961.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 1 Mar 2011 20:37:25 +0000 (20:37 +0000)]
2011-02-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Only IndexedDB's error event should be cancelable
        https://bugs.webkit.org/show_bug.cgi?id=55413

        Add checks to existing tests.

        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/transaction-basics.html:
2011-02-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Only IndexedDB's error event should be cancelable
        https://bugs.webkit.org/show_bug.cgi?id=55413

        * storage/IDBRequest.cpp:
        (WebCore::createSuccessEvent):
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::onAbort):
        (WebCore::IDBTransaction::onComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGive WebKitLauncherWin's PDB file a name different from WebKit's
aroben@apple.com [Tue, 1 Mar 2011 20:34:13 +0000 (20:34 +0000)]
Give WebKitLauncherWin's PDB file a name different from WebKit's

WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
fighting over the same PDB file, meaning that one of them was going to lose and not have
symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.

Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
runs (due to missing symbols)

Reviewed by David Kilzer.

* WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
"WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 20:31:40 +0000 (20:31 +0000)]
2011-03-01  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Remove CorrectionIndicator markers sooner.
        https://bugs.webkit.org/show_bug.cgi?id=54893
        <rdar://problem/8997524>

        See WebCore/ChangeLog for detail.

        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
        * platform/mac/editing/spelling/autocorrection-simple-expected.png:
        * platform/mac/editing/spelling/autocorrection-simple-expected.txt:
        * platform/mac/editing/spelling/autocorrection-simple.html:
        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
        * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.checksum: Added.
        * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Added.
        * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple-expected.txt.
        * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html.
2011-03-01  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Remove CorrectionIndicator markers sooner.
        https://bugs.webkit.org/show_bug.cgi?id=54893
        <rdar://problem/8997524>

        Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html

        This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
        marker after any editing command if the command:
        1. is not a SpellingCorrectionCommand itself.
        2. is not the command that triggers the autocorrection.
        This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns
        false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function
        always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member
        variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
        public functions.

        To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
        to cache whether there is any marker of a particular type.

        This patch also fixes two minor existing bugs.

        1. We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because
        CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement
        marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
        marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel
        if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.

        This works as following:
        When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
        as the marker's description. If the user edited the corrected word afterward, we set description to null.
        So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
        marker, but also check if description is null.

        2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would
        occur when deleting the first character in an editable area.

        * dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
           completely in from the document.

        * dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
           the return value of possiblyHasMarkers() at beginning.
        (WebCore::DocumentMarkerController::possiblyHasMarkers):
        (WebCore::DocumentMarkerController::DocumentMarkerController):
        (WebCore::DocumentMarkerController::detach):
        (WebCore::DocumentMarkerController::removeMarkers):
        (WebCore::DocumentMarkerController::addMarker):
        (WebCore::DocumentMarkerController::copyMarkers):
        (WebCore::DocumentMarkerController::markerContainingPoint):
        (WebCore::DocumentMarkerController::renderedRectsForMarkers):
        (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
        (WebCore::DocumentMarkerController::repaintMarkers):
        (WebCore::DocumentMarkerController::shiftMarkers):
        (WebCore::DocumentMarkerController::setMarkersActive):
        (WebCore::DocumentMarkerController::hasMarkers):
        (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
        * dom/DocumentMarkerController.h:
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply):
        (WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
        (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
        * editing/EditCommand.h:
        * editing/Editor.cpp:
        (WebCore::Editor::respondToChangedSelection):
        (WebCore::Editor::appliedEditing):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::insertLineBreak):
        (WebCore::Editor::insertParagraphSeparator):
        (WebCore::Editor::markMisspellingsAfterTypingToWord):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
        (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::executeInsertLineBreak):
        (WebCore::executeInsertParagraph):
        (WebCore::executeInsertText):
        * editing/SpellingCorrectionCommand.cpp:
        (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
        * editing/SpellingCorrectionCommand.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::TypingCommand):
        (WebCore::TypingCommand::deleteSelection):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::insertLineBreak):
        (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
        (WebCore::TypingCommand::insertParagraphSeparator):
        * editing/TypingCommand.h:
        (WebCore::TypingCommand::create):
        (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
        (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
        * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Tue, 1 Mar 2011 20:15:20 +0000 (20:15 +0000)]
2011-03-01  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FEDisplacementMapElement changes doesn't require relayout
        https://bugs.webkit.org/show_bug.cgi?id=55454

        When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
        to relayout the filter.

        No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.

        * platform/graphics/filters/FEDisplacementMap.cpp:
        (WebCore::FEDisplacementMap::setXChannelSelector):
        (WebCore::FEDisplacementMap::setYChannelSelector):
        (WebCore::FEDisplacementMap::setScale):
        * platform/graphics/filters/FEDisplacementMap.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute):
        (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
        * svg/SVGFEDisplacementMapElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpring cleaning!
ddkilzer@apple.com [Tue, 1 Mar 2011 20:10:03 +0000 (20:10 +0000)]
Spring cleaning!

Rubber-stamped by Mark Rowe.

* JavaScriptCore.xcodeproj/project.pbxproj:
(Copy Into Framework): Remove "set -x" and its comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 20:03:21 +0000 (20:03 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] pass fast/table/fixed-with-auto-with-colspan-vertical.html
        https://bugs.webkit.org/show_bug.cgi?id=55491

        Fixed by r79760.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCount web process crashes toward the --exit-after-n-crashes-or-timeouts limit
aroben@apple.com [Tue, 1 Mar 2011 20:02:51 +0000 (20:02 +0000)]
Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit

Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
--exit-after-n-crashes-or-timeouts limit

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
the number of tests that caused the web process to crash when exiting early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Tue, 1 Mar 2011 19:54:39 +0000 (19:54 +0000)]
2011-03-01  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        TinyMCE not working in nightlies
        https://bugs.webkit.org/show_bug.cgi?id=54978

        Disabling setupBeginChars() to temporarily work arround the test
        failure.  Filed https://bugs.webkit.org/show_bug.cgi?id=55479
        to track fixing the issue.

        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPattern::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Tue, 1 Mar 2011 19:53:24 +0000 (19:53 +0000)]
2011-03-01  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Create layout test for progress event and remove test for suspend event.

        LayoutTests/http/tests/media/video-play-suspend is now hanging on chromium
        https://bugs.webkit.org/show_bug.cgi?id=55198

        * http/tests/media/video-play-progress-expected.txt: Added.
        * http/tests/media/video-play-progress.html: Added.
        * http/tests/media/video-play-suspend-expected.txt: Removed.
        * http/tests/media/video-play-suspend.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 1 Mar 2011 19:49:39 +0000 (19:49 +0000)]
2011-03-01  Martin Robinson  <mrobinson@igalia.com>

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Add new GTK+ test results.

        * platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
        * platform/gtk/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
        * platform/gtk/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
mitz@apple.com [Tue, 1 Mar 2011 19:48:04 +0000 (19:48 +0000)]
<rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
https://bugs.webkit.org/show_bug.cgi?id=55487

Reviewed by Darin Adler.

Source/WebCore:

* css/html.css:
(ruby > rt): Changed the default text-align value to -webkit-auto to signal
the default expansion behavior.
* rendering/RenderBlock.h:
(WebCore::RenderRubyText::textAlignmentForLine): Made protected.
(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
* rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
-webkit-auto, returns JUSTIFY to allow expansion.
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
text-align is -webkit-auto, insets the line such that the inset on each side
is the half the inter-ideograph expansion, or one ruby character wide,
whichever is smaller.
* rendering/RenderRubyText.h:

LayoutTests:

* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 needs to be made localizable
weinig@apple.com [Tue, 1 Mar 2011 19:41:03 +0000 (19:41 +0000)]
WebKit2 needs to be made localizable
https://bugs.webkit.org/show_bug.cgi?id=55483

Reviewed by Timothy Hatcher.

Source/WebCore:

* English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
* WebCore.xcodeproj/project.pbxproj:
Move Localizable.strings to WebCore.

* WebCore.exp.in:
Add export for localizedString function.

* platform/LocalizedStrings.h:
* platform/mac/LocalizedStringsMac.mm: Added.
Add function to get localized version of a string from the WebCore bundle.

Source/WebKit:

* StringsNotToBeLocalized.txt: Removed.
* WebKit.xcodeproj/project.pbxproj:
Copied Localizable.strings to WebCore, it can't be removed entirely
yet since Windows is still using it.

Source/WebKit/mac:

* WebCoreSupport/WebPlatformStrategies.mm:
Use WebCore's localizedString function instead of WebLocalizableStrings
since WebCore is now responsible for localization.

Source/WebKit2:

* PluginProcess/mac/PluginProcessMainMac.mm:
* WebProcess/mac/WebProcessMainMac.mm:
Set the default localization from the passed in parameter.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Add the preferred localization as a parameter when launching processes
so that they can set their localization to match the launching app.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
Use WebCore's localizedString function on the mac, to actually localize
these strings.

(WebKit::WebPlatformStrategies::imageTitle):
Switch to using replace, instead of concatenation, to give localizers a chance
to rearrange the wording.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 1 Mar 2011 19:26:44 +0000 (19:26 +0000)]
2011-03-01  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Added new GTK test expectations.

        * platform/gtk/fast/block/positioning/auto/vertical-lr/: 7 tests.
        * platform/gtk/fast/block/positioning/auto/vertical-rl/: 7 tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoViewport parsing no longer accepts "1.0;" value as valid.
joepeck@webkit.org [Tue, 1 Mar 2011 19:03:14 +0000 (19:03 +0000)]
Viewport parsing no longer accepts "1.0;" value as valid.

Reviewed by Kenneth Rohde Christiansen.

LayoutTests:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport parsing no longer accepts "1.0;" value as valid.
            https://bugs.webkit.org/show_bug.cgi?id=53705

            Add a new test to check viewport argument parsing of
            value "123x456", which although not completely a number
            should return the numeric prefix "123" as the value.
            Note that this affects "semicolons as separators" even
            though semicolons are not valid separators.

            * fast/viewport/viewport-129.html: Added.

Source/JavaScriptCore:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport parsing no longer accepts "1.0;" value as valid.
            https://bugs.webkit.org/show_bug.cgi?id=53705

            Include a didReadNumber parameter to String -> float / double
            conversion functions. This way, if the "ok" boolean out
            parameter is false, you can check to see if there in fact
            was a valid number parsed with garbage at the end. Examples
            of that would be parsing "123x456" would have ok = false,
            but didReadNumber = true.

            * JavaScriptCore.exp:
            * wtf/text/StringImpl.cpp:
            (WTF::StringImpl::toDouble):
            (WTF::StringImpl::toFloat):
            * wtf/text/StringImpl.h:
            * wtf/text/WTFString.cpp:
            (WTF::String::toDouble):
            (WTF::String::toFloat):
            (WTF::charactersToDouble):
            (WTF::charactersToFloat):
            * wtf/text/WTFString.h:

Source/WebCore:

    2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport parsing no longer accepts "1.0;" value as valid.
            https://bugs.webkit.org/show_bug.cgi?id=53705

            When parsing numeric values, the "css-viewport" spec says
            to use the number prefix, and the non numeric part of the
            string can be ignored. This matches our behavior before
            r67376. The change was that checking the error out condition
            of String::toFloat doesn't necessarily mean that there
            was a non-numeric prefix. This patch checks if there was
            or wasn't a non-numeric prefix.

            There is a console warning in any case where a numeric
            value is not parsed cleanly. There is an error warning
            when it is not a number at all, and a tip warning when
            it has been truncated.

            Error messages are slightly improved to provide more
            context, both the key and value, when an error happens.

            Test: fast/viewport/viewport-129.html

            * dom/ViewportArguments.cpp:
            (WebCore::numericPrefix):
            (WebCore::findSizeValue):
            (WebCore::findScaleValue):
            (WebCore::findUserScalableValue):
            (WebCore::findTargetDensityDPIValue):
            (WebCore::viewportErrorMessageTemplate):
            (WebCore::viewportErrorMessageLevel):
            (WebCore::reportViewportWarning):
            * dom/ViewportArguments.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 needs to be made localizable
weinig@apple.com [Tue, 1 Mar 2011 18:45:59 +0000 (18:45 +0000)]
WebKit2 needs to be made localizable
<rdar://problem/8728860>

Reviewed by Anders Carlsson.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 1 Mar 2011 18:26:18 +0000 (18:26 +0000)]
2011-03-01  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Removed accessibility/canvas-fallback-content.html from Skipped
        list as it was removed in 79920

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSave a crash log when the web process crashes
aroben@apple.com [Tue, 1 Mar 2011 18:13:54 +0000 (18:13 +0000)]
Save a crash log when the web process crashes

On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
until it has finished crashing, which guarantees that the crash log will have had time to be
saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
log, so all we have to do is choose the right crash log out of the CrashReporter directory.

Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive

Reviewed by Sam Weinig.

* Scripts/old-run-webkit-tests:
(testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
(captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
WebProces_*.crash files when the web process crashes.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
along to platformInitialize.

* WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.

* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
(WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):
Updated function signature.

* WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
(WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
webProcessCrashingEvent, then lets the crash continue as normal.

(WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
event we should use to tell the UI process we're crashing from the initializationUserData,
and get a handle to that event.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController): Initialize new members.
(WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
only print the "#CRASHED - WebProcess" message once, since this can be called more than once
when a crash log is being saved on Windows. Exit right away if specified. (This is the
default.)

* WebKitTestRunner/TestController.h: Added new members.

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize): Set up the event the web process will use to tell
us it's crashing.
(WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
so the test harness will know the web process has crashed and not try to kill us, then wait
for the web process to finish crashing so a crash log will have time to be saved.
(WTR::toWK): Simple hepler function.
(WTR::TestController::platformInitializeContext): Pass along the name of the event the web
process should use to tell us it is crashing in the context's initialization user data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Mar 2011 18:00:23 +0000 (18:00 +0000)]
2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Tony Gentilcore.

        Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
        https://bugs.webkit.org/show_bug.cgi?id=55476

        Chromium Win uses BuildAndTestFactory, not TestFactory.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 1 Mar 2011 17:47:11 +0000 (17:47 +0000)]
2011-03-01  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        Apply the quirks that are necessary for the flash plugin
        to not crash on X11.

        * Platform/qt/ModuleQt.cpp:
        (WebKit::Module::load): Use the ResolveAllSymbols hint as we do in WebCore.
        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad): Call applyX11QuirksBeforeLoad
        if PLUGIN_ARCHITECTURE is X11.
        * Shared/Plugins/Netscape/NetscapePluginModule.h:
        * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
        (WebKit::initializeGTK):  The same hack that we do in WebCore.
        Call gtk_init because flash don't do it for itself.
        (WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad): Added for X11.
        Do the hacks that we need to do before calling NP_Initialize on the
        flash plugin to save it form crashing.
        * Shared/Plugins/PluginQuirks.h: Use PLUGIN_ARCHITECTURE macros.
        Added RequiresGTKToolKit quirk for X11.
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue): Handle the RequiresGTKToolKit quirk on X11.
        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        (WebKit::NetscapePlugin::quirks): Added getter for the PluginModule's
        quirks to be available in NPN_GetValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Mar 2011 17:41:12 +0000 (17:41 +0000)]
2011-02-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Past-the-end writes in VM exceptions (caused crashes in r79627)
        https://bugs.webkit.org/show_bug.cgi?id=55448

        Some exceptions had the wrong structures, so they misoverestimated their
        inline storage sizes.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Use the right structure.

        * runtime/JSObject.h:
        (JSC::JSNonFinalObject::JSNonFinalObject):
        (JSC::JSFinalObject::JSFinalObject): ASSERT that our structure capacity
        is correct to verify this doesn't happen again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 1 Mar 2011 17:28:39 +0000 (17:28 +0000)]
2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: InjectedScript.setPropertyValue doesn't work.
        https://bugs.webkit.org/show_bug.cgi?id=55475

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::setPropertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 17:23:39 +0000 (17:23 +0000)]
2011-03-01  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Remove unused JavaString::uchars()
        https://bugs.webkit.org/show_bug.cgi?id=55465

        No new tests, removing dead code only.

        * bridge/jni/JNIBridge.h:
        * bridge/jni/jsc/JavaStringJSC.h:
        (JSC::Bindings::JavaStringImpl::utf8):
        * bridge/jni/v8/JavaStringV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 1 Mar 2011 16:51:03 +0000 (16:51 +0000)]
2011-03-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Extremely slow DOM search in GMail
        https://bugs.webkit.org/show_bug.cgi?id=55456

        The solution comprises three major parts:
        - avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
        - cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
        - replace hand-written Text nodes iteration with a snapshot-based ".//text()" XPathResult.

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        ():
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix multiple-definition linker warnings introduced by r79978 on Windows
aroben@apple.com [Tue, 1 Mar 2011 15:42:00 +0000 (15:42 +0000)]
Fix multiple-definition linker warnings introduced by r79978 on Windows

* rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
compiled separately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert seconds to milliseconds before calling ::SetTimer
aroben@apple.com [Tue, 1 Mar 2011 15:29:44 +0000 (15:29 +0000)]
Convert seconds to milliseconds before calling ::SetTimer

Fixes <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
early on Windows

Reviewed by Anders Carlsson.

Source/WebKit2:

* Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::start): Convert the timeout interval to milliseconds, since that's what
::SetTimer expects.

Tools:

Test that the WebKit2 responsiveness timer doesn't fire too early

* TestWebKitAPI/PlatformUtilities.h: Added sleep().

* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::processDidBecomeUnresponsive):
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::setPageLoaderClient):
Simple helper functions.

(TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
tell the web process to pause and press the spacebar key. The spacebar keypress should cause
the responsiveness timer to start, but the web process should unpause before it has a chance
to fire. Run until the web process has unpaused, and assert that the timer didn't fire.

* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
Call up to the base class.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
pause, sleep for 0.5 seconds, then send back a message saying we paused.

* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rebaselining Chromium expectations.
antonm@chromium.org [Tue, 1 Mar 2011 15:14:09 +0000 (15:14 +0000)]
Unreviewed.  Rebaselining Chromium expectations.

*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
*    platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 1 Mar 2011 15:13:25 +0000 (15:13 +0000)]
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        Mac related changes suggested by Prasanth Ullattil <prasanth.ullattil@nokia.com>

        * Source/WebKit.pri: Common options should be here.
        Also move Mac options to this file to fix the Mac build.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * JavaScriptCore.pri: Move options also needed in WebCore into WebKit.pri.
        * JavaScriptCore.pro: Deduplicate options.
        * jsc.pro: Ditto.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * api/QtScript.pro: Deduplicate options.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        No new tests needed.

        * WebCore.pri: Move common options to WebKit.pri.
        * WebCore.pro: Ditto.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * QtWebKit.pro: Move common options to WebKit.pri.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * WebKit2.pro: Deduplicate options.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 14:31:22 +0000 (14:31 +0000)]
2011-03-01  Steve Block  <steveblock@google.com>

        Reviewed by Pavel Feldman.

        JNI code in Java bridge is not correctly guarded
        https://bugs.webkit.org/show_bug.cgi?id=55459

        No new tests, build fix only.

        * bridge/jni/v8/JNIBridgeV8.cpp:
        * bridge/jni/v8/JNIBridgeV8.h:
        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        * bridge/jni/v8/JNIUtilityPrivate.h:
        * bridge/jni/v8/JavaClassV8.cpp:
        * bridge/jni/v8/JavaClassV8.h:
        * bridge/jni/v8/JavaInstanceV8.cpp:
        * bridge/jni/v8/JavaInstanceV8.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        * bridge/jni/v8/JavaNPObjectV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Juha Savolainen <juha.savolainen@weego.fi>
commit-queue@webkit.org [Tue, 1 Mar 2011 14:13:04 +0000 (14:13 +0000)]
2011-03-01  Juha Savolainen  <juha.savolainen@weego.fi>

        Reviewed by Andreas Kling.

        [Qt] WebKit2 needs to support font size changing and getting default font size
        https://bugs.webkit.org/show_bug.cgi?id=53671

        Added new enum for font size type and added methods to set and get default font sizes.

        * UIProcess/API/qt/qwkpreferences.cpp:
        (QWKPreferences::setFontSize): Added.
        (QWKPreferences::fontSize): Added.
        * UIProcess/API/qt/qwkpreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 14:01:04 +0000 (14:01 +0000)]
2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Simon Hausmann.

        [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
        https://bugs.webkit.org/show_bug.cgi?id=55319

        The test case required internet connection to be able to connect to
        google.com. Added new html file which refers to local html file.

        * tests/qwebpage/resources/content.html: Added.
        * tests/qwebpage/resources/frame_c.html: Added.
        * tests/qwebpage/resources/framedindex.html: Added.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::backActionUpdate):
        * tests/qwebpage/tst_qwebpage.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Mar 2011 13:55:02 +0000 (13:55 +0000)]
2011-03-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove manual watchdog from the inspector tests.
        https://bugs.webkit.org/show_bug.cgi?id=55447

        * http/tests/inspector/inspector-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another timing-out test on Windows XP
aroben@apple.com [Tue, 1 Mar 2011 13:53:16 +0000 (13:53 +0000)]
Skip another timing-out test on Windows XP

<http://webkit.org/b/51596> tracks the failure.

* platform/win-xp/Skipped: Added http/tests/xmlhttprequest/basic-auth-nouser.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another multiprocessing test on Windows
aroben@apple.com [Tue, 1 Mar 2011 13:52:50 +0000 (13:52 +0000)]
Skip another multiprocessing test on Windows

It is sometimes failing (and may be leaving child Python processes around).
<http://webkit.org/b/55087> tracks the failure.

* Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
(FuncitonTests.test_get__processes): Skip this test on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip fast/events/pageshow-pagehide-on-back-cached.html on Windows
aroben@apple.com [Tue, 1 Mar 2011 13:52:20 +0000 (13:52 +0000)]
Skip fast/events/pageshow-pagehide-on-back-cached.html on Windows

It is flaky. The failure is tracked by <http://webkit.org/b/55329>.

* platform/win/Skipped:
* platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in Windows pixel results to match text results added in r79979
aroben@apple.com [Tue, 1 Mar 2011 13:51:47 +0000 (13:51 +0000)]
Check in Windows pixel results to match text results added in r79979

Fixes <http://webkit.org/b/55451> [Win] select-listbox-multiple-no-focusring.html needs
rebaseline

* platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
* platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 1 Mar 2011 13:14:35 +0000 (13:14 +0000)]
2011-03-01  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip one crashing tests on GTK. See also
        https://bugs.webkit.org/show_bug.cgi?id=53146

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79990 268f45cc-cd09-0410-ab3c-d52691b4dbfc