WebKit-https.git
9 years agoVersioning.
lforschler@apple.com [Fri, 20 Apr 2012 05:35:07 +0000 (05:35 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
commit-queue@webkit.org [Fri, 20 Apr 2012 03:35:56 +0000 (03:35 +0000)]
[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=84380

Patch by Tay Grigg <tgrigg@rim.com> on 2012-04-19
Reviewed by George Staikos.

Reviewed Internally by: George Rizkalla, Lyon Chen

Set the limit on the http connection count per host to the default
of 10000, queue the requests in the networking layer instead,
this should increase parallelism at the WebKit layer to remove
any potential bottlenecks.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMedia Stream API: Piece of code cleanup for the chromium port
commit-queue@webkit.org [Fri, 20 Apr 2012 03:29:35 +0000 (03:29 +0000)]
Media Stream API: Piece of code cleanup for the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84328

Patch by Jeremy Mao <yujie.mao@intel.com> on 2012-04-19
Reviewed by Kent Tamura.

Source/WebKit/chromium:

Remove some deprecated interfaces.

No new tests. No behavior changes.

* public/WebUserMediaClient.h:
Remove deprecated requestUserMedia interface.
* public/WebUserMediaRequest.h:
Remove deprecated requestSucceeded interface.
* src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
Use the requestUserMedia split sources implementation.
* src/WebUserMediaRequest.cpp:
Remove deprecated requestSucceeded implementation.

Tools:

WebUserMediaClientMock use an old requestUserMedia interface and
Replace it with the new interface.

* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):
Remove the old requestUserMedia and replace it with the new.
* DumpRenderTree/chromium/WebUserMediaClientMock.h:
(WebUserMediaClientMock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114711.
dimich@chromium.org [Fri, 20 Apr 2012 02:32:34 +0000 (02:32 +0000)]
Unreviewed, rolling out r114711.
http://trac.webkit.org/changeset/114711
https://bugs.webkit.org/show_bug.cgi?id=84412

Many tests crash in RenderObject::container() (Requested by
dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, re-update baselines for new tests
dimich@chromium.org [Fri, 20 Apr 2012 02:07:51 +0000 (02:07 +0000)]
Not reviewed, re-update baselines for new tests
added in http://trac.webkit.org/changeset/114666
and then modified in http://trac.webkit.org/changeset/114685

* platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt.
* platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocomputeNonFastScrollableRegion needs to traverse the entire frame tree
andersca@apple.com [Fri, 20 Apr 2012 01:40:56 +0000 (01:40 +0000)]
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>

Reviewed by Dan Bernstein.

Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
in the set if they have scrollbars that are enabled.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
computeNonFastScrollableRegion now takes the main frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] IndexedDB: Prep for changing keyPath return type
jsbell@chromium.org [Fri, 20 Apr 2012 00:58:09 +0000 (00:58 +0000)]
[Chromium] IndexedDB: Prep for changing keyPath return type
https://bugs.webkit.org/show_bug.cgi?id=84208

To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
changing the method names to keyPathString with compatibility shims (on the WebKit side)
then switching the implementation in the Chromium port in a follow-up patch.

Reviewed by Kent Tamura.

* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPathString):
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPathString):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFocus ring on wikipedia gets blobs when you type
andersca@apple.com [Fri, 20 Apr 2012 00:50:19 +0000 (00:50 +0000)]
Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
<rdar://problem/11011847>

Reviewed by Dan Bernstein.

Make it possible to override the focus ring visible rect from layer drawing code.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.

* platform/mac/ThemeMac.h:
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
and just return the view's visible rect.

(WebCore::ThemeMac::setFocusRingClipRect):
Update the focus clip rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRollout r114674.
jer.noble@apple.com [Fri, 20 Apr 2012 00:48:27 +0000 (00:48 +0000)]
Rollout r114674.

New tests added in http://trac.webkit.org/changeset/114685 made the
platform results added in http://trac.webkit.org/changeset/114674
unnecessary.

* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled...
ostapenko.viatcheslav@nokia.com [Fri, 20 Apr 2012 00:37:02 +0000 (00:37 +0000)]
[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
https://bugs.webkit.org/show_bug.cgi?id=84278

Reviewed by Noam Rosenthal.

Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
page becomes visible again.

* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::purgeBackingStores):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::appendUpdate):
(WebKit::WebLayerTreeRenderer::setActive):
(WebKit):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::purgeBackingStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPartial rollout of r114673.
jer.noble@apple.com [Fri, 20 Apr 2012 00:33:11 +0000 (00:33 +0000)]
Partial rollout of r114673.

Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2,
but fails on mac.  Update test_expectations so that both results are expected.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114690.
dimich@chromium.org [Fri, 20 Apr 2012 00:33:05 +0000 (00:33 +0000)]
Unreviewed, rolling out r114690.
http://trac.webkit.org/changeset/114690
https://bugs.webkit.org/show_bug.cgi?id=84408

Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
test_shell_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoException stack traces aren't complete when the exception starts in native code
oliver@apple.com [Fri, 20 Apr 2012 00:17:41 +0000 (00:17 +0000)]
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.

Also fixed a few LLInt paths that failed to correctly update the
topCallFrame.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* dfg/DFGJITCompiler.h:
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jsc.cpp:
(functionJSCStack):
* llint/LLIntExceptions.cpp:
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* parser/Parser.h:
(JSC::::parse):
* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
* runtime/Error.h:
(JSC):

LayoutTests:

Update tests to show complete trace information

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js:
(selfRecursive1):
* fast/js/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaselining new tests added in http://trac.webkit.org/changeset/114666
dimich@chromium.org [Fri, 20 Apr 2012 00:12:17 +0000 (00:12 +0000)]
[Chromium] Rebaselining new tests added in trac.webkit.org/changeset/114666
Not reviewed.

* platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElementAttributeData should be fast-malloc'd.
kling@webkit.org [Fri, 20 Apr 2012 00:11:11 +0000 (00:11 +0000)]
ElementAttributeData should be fast-malloc'd.
<http://webkit.org/b/84405>

Reviewed by Antti Koivisto.

Sprinkle missing WTF_MAKE_FAST_ALLOCATED.

* dom/ElementAttributeData.h:
(ElementAttributeData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r112177): Numbered list item rendered bulleted
commit-queue@webkit.org [Fri, 20 Apr 2012 00:08:22 +0000 (00:08 +0000)]
REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216

Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.

Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.

No new tests; updated existing tests that should have caught this.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):

LayoutTests:

* css3/flexbox/css-properties.html:
* fast/css/cssText-shorthand.html:
* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:
* fast/dom/css-dom-read-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWe're collecting pathologically due to small allocations
mhahnenberg@apple.com [Fri, 20 Apr 2012 00:05:37 +0000 (00:05 +0000)]
We're collecting pathologically due to small allocations
https://bugs.webkit.org/show_bug.cgi?id=84404

Reviewed by Geoffrey Garen.

No change in performance on run-jsc-benchmarks.

* dfg/DFGSpeculativeJIT.h: Replacing m_firstFreeCell with m_freeList.
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
* heap/CopiedSpace.cpp: Getting rid of any water mark related stuff, since it's no
longer useful.
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::tryAllocateSlowCase): We now only call didAllocate here rather than
carrying out a somewhat complicated accounting job for our old water mark throughout CopiedSpace.
(JSC::CopiedSpace::tryAllocateOversize):  Call the new didAllocate to notify the Heap of
newly allocated stuff.
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::destroy):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying):
* heap/Heap.cpp: Removed water mark related stuff, replaced with new bytesAllocated and
bytesAllocatedLimit to track how much memory has been allocated since the last collection.
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::collect): We now set the new limit of bytes that we can allocate before triggering
a collection to be the size of the Heap after the previous collection. Thus, we still have our
2x allocation amount.
(JSC::Heap::didAllocate): Notifies the GC activity timer of how many bytes have been allocated
thus far and then adds the new number of bytes to the current total.
(JSC):
* heap/Heap.h: Removed water mark related stuff.
(JSC::Heap::notifyIsSafeToCollect):
(Heap):
(JSC::Heap::shouldCollect):
(JSC):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Refactored to use MarkedBlock's new FreeList struct.
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::zapFreeList): Refactored to take in a FreeList instead of a FreeCell.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::zapFreeList):
* heap/MarkedBlock.h:
(FreeList): Added a new struct that keeps track of the current MarkedAllocator's
free list including the number of bytes of stuff in the free list so that when the free list is
exhausted, the correct amount can be reported to Heap.
(MarkedBlock):
(JSC::MarkedBlock::FreeList::FreeList):
(JSC):
* heap/MarkedSpace.cpp: Removing all water mark related stuff.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC):
* heap/WeakSet.cpp:
(JSC::WeakSet::findAllocator): Refactored to use the didAllocate interface with the Heap. This
function still needs work though now that the Heap knows how many bytes have been allocated
since the last collection.
* jit/JITInlineMethods.h: Refactored to use MarkedBlock's new FreeList struct.
(JSC::JIT::emitAllocateBasicJSObject): Ditto.
* llint/LowLevelInterpreter.asm: Ditto.
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):
* runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::didAllocate): Renamed willAllocate to didAllocate to indicate that
the allocation that is being reported has already taken place.
(DefaultGCActivityCallback):
* runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::didAllocate): Refactored to return early if the amount of
allocation since the last collection is not above a threshold (initially arbitrarily chosen to
be 128KB).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Don't compile FontCacheSkia for Android
peter@chromium.org [Fri, 20 Apr 2012 00:05:36 +0000 (00:05 +0000)]
[Chromium] Don't compile FontCacheSkia for Android
https://bugs.webkit.org/show_bug.cgi?id=84392

Reviewed by Kent Tamura.

Chromium for the Android platform uses its own FontCacheAndroid
implementation. Compile errors show up when trying to build the
content shell.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
commit-queue@webkit.org [Thu, 19 Apr 2012 23:54:49 +0000 (23:54 +0000)]
[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
https://bugs.webkit.org/show_bug.cgi?id=83475

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-19
Reviewed by Daniel Bates.

No new tests. This does not change functionality.

Remove some obsolete patch files for Cairo that were used in some
very old versions of Safari for Windows.

* platform/graphics/cairo/rgb24-hacks.txt: Removed.
* platform/graphics/cairo/scale-removal.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
fpizlo@apple.com [Thu, 19 Apr 2012 23:52:46 +0000 (23:52 +0000)]
MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
https://bugs.webkit.org/show_bug.cgi?id=84401

Reviewed by Gavin Barraclough.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT console messages should contain only the file name part of local URIs
commit-queue@webkit.org [Thu, 19 Apr 2012 23:50:39 +0000 (23:50 +0000)]
[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-19
Reviewed by Kentaro Hara.

Tools:

Process console messages before printing them in EFL's DumpRenderTree
them so that they contain only the file name part of local URIs. This
is what is expected by test cases.

* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(urlSuitableForTestResult):
(onConsoleMessage):

LayoutTests:

Remove from the skip list the tests which expect only the file name
part of local URIs to be displayed in console messages now that it has
been fixed in EFL's DumpRenderTree.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotransforms/no_transform_hit_testing.html is flaky
commit-queue@webkit.org [Thu, 19 Apr 2012 23:46:20 +0000 (23:46 +0000)]
transforms/no_transform_hit_testing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82415

Patch by Florin Malita <fmalita@google.com> on 2012-04-19
Reviewed by Simon Fraser.

Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.

* platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
* transforms/no_transform_hit_testing-expected.txt: Added.
* transforms/no_transform_hit_testing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, update chromium expectations for various compositing layout...
jamesr@google.com [Thu, 19 Apr 2012 23:41:01 +0000 (23:41 +0000)]
[chromium] Unreviewed, update chromium expectations for various compositing layout tests

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
peter@chromium.org [Thu, 19 Apr 2012 23:38:47 +0000 (23:38 +0000)]
Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=84403

Reviewed by Andreas Kling.

r114679 broke Chromium Win and Android bots due to call
ambiguity between a double and float argument.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDefault to null value for HistoryItem::m_pageScaleFactor
commit-queue@webkit.org [Thu, 19 Apr 2012 23:30:28 +0000 (23:30 +0000)]
Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385

Patch by Alexandre Elias <aelias@google.com> on 2012-04-19
Reviewed by Nate Chapin.

Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1.  This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.

This is a no-op change for common navigation scenarios.  The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device.  In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.

No new tests.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt build warning fix.
alexis.menard@openbossa.org [Thu, 19 Apr 2012 23:27:28 +0000 (23:27 +0000)]
Unreviewed Qt build warning fix.

The file editing/StringHelper.h does not exist.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove empty directory Source/WebCore/webaudio
dbates@webkit.org [Thu, 19 Apr 2012 23:01:48 +0000 (23:01 +0000)]
Remove empty directory Source/WebCore/webaudio

Changeset 111474 <http://trac.webkit.org/changeset/111474> moved all the files in
Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the
empty directory Source/WebCore/webaudio.

* webaudio: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
mahesh.kulkarni@nokia.com [Thu, 19 Apr 2012 23:00:06 +0000 (23:00 +0000)]
[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
https://bugs.webkit.org/show_bug.cgi?id=84293

Reviewed by Tor Arne Vestbø.

Unskipped page-reload-cancel-permission-requests after r105988.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add simplified API for iterating over a WebElement's attributes.
kling@webkit.org [Thu, 19 Apr 2012 22:59:58 +0000 (22:59 +0000)]
[chromium] Add simplified API for iterating over a WebElement's attributes.
<http://webkit.org/b/84183>

Reviewed by Dimitri Glazkov.

Add attributeCount(), attributeLocalName(index) and attributeValue(index) to the
WebElement API so that call sites currently using WebNamedNodeMap can be
converted, which will ultimately allow us to refactor WebCore::Attribute
on <http://webkit.org/b/83440>.

* public/WebElement.h:
* src/WebElement.cpp:
(WebKit::WebElement::attributeCount):
(WebKit::WebElement::attributeLocalName):
(WebKit::WebElement::attributeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew ruby tests broken on Mac
commit-queue@webkit.org [Thu, 19 Apr 2012 22:49:04 +0000 (22:49 +0000)]
New ruby tests broken on Mac
https://bugs.webkit.org/show_bug.cgi?id=84382

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Eric Seidel.

Tweaking new tests to make them render the same on all platforms.

* fast/ruby/floating-ruby-text-expected.txt:
* fast/ruby/floating-ruby-text.html:
* fast/ruby/positioned-ruby-text-expected.txt:
* fast/ruby/positioned-ruby-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKeywordLookupGenerator.py should take an output file as an argument
commit-queue@webkit.org [Thu, 19 Apr 2012 22:44:40 +0000 (22:44 +0000)]
KeywordLookupGenerator.py should take an output file as an argument
https://bugs.webkit.org/show_bug.cgi?id=84292

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-19
Reviewed by Eric Seidel.

Extended KeywordLookupGenerator to accept an additional argument specifying an output file. If this argument is found stdout is redirected to a file for the duration of the script.

* KeywordLookupGenerator.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect inter-caps in “ShouldSkipMetaData” etc.
psolanki@apple.com [Thu, 19 Apr 2012 22:33:30 +0000 (22:33 +0000)]
Incorrect inter-caps in “ShouldSkipMetaData” etc.
https://bugs.webkit.org/show_bug.cgi?id=72159

Reviewed by Dan Bernstein.

No new tests since no change in functionality.

* platform/graphics/ImageSource.h:
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
commit-queue@webkit.org [Thu, 19 Apr 2012 22:12:42 +0000 (22:12 +0000)]
[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
https://bugs.webkit.org/show_bug.cgi?id=84169

All databases were being created inside ~/.webkit which was causing
flaky tests when running multiple tests in parallel, specially timeouts
due to concurrency.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-19
Reviewed by Eric Seidel.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Build Location notice on Mac debug instructions to reflect changes in Xcode...
dbates@webkit.org [Thu, 19 Apr 2012 22:10:11 +0000 (22:10 +0000)]
Update Build Location notice on Mac debug instructions to reflect changes in Xcode 4.3.2
https://bugs.webkit.org/show_bug.cgi?id=84364

Reviewed by Eric Seidel.

As of Xcode 4.3.2, the build location "Locations Specified by Targets" has been renamed to
"Legacy".

* building/debug-mac-uiprocess.html:
* building/debug.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCanvas more precisely makes the bounding rect for stroke rendering.
commit-queue@webkit.org [Thu, 19 Apr 2012 22:07:51 +0000 (22:07 +0000)]
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792

Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.

* fast/canvas/canvas-strokePath-cap-join-expected.txt: Added.
* fast/canvas/canvas-strokePath-cap-join.html: Added.
* fast/canvas/script-tests/canvas-strokePath-cap-join.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCanvas more precisely makes the bounding rect for stroke rendering.
commit-queue@webkit.org [Thu, 19 Apr 2012 22:05:38 +0000 (22:05 +0000)]
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792

Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
(WebCore):
* html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAtt...
macpherson@chromium.org [Thu, 19 Apr 2012 22:03:01 +0000 (22:03 +0000)]
Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
https://bugs.webkit.org/show_bug.cgi?id=84366

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix null-pointer dereference in ApplyPropertyZoom::applyValue().
macpherson@chromium.org [Thu, 19 Apr 2012 22:00:09 +0000 (22:00 +0000)]
Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
https://bugs.webkit.org/show_bug.cgi?id=84279

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/zoom-on-unattached.html

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyZoom::applyValue):

LayoutTests:

* fast/css/zoom-on-unattached-expected.txt: Added.
* fast/css/zoom-on-unattached.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to...
macpherson@chromium.org [Thu, 19 Apr 2012 21:56:59 +0000 (21:56 +0000)]
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369

Reviewed by Simon Fraser.

No new tests / code cleanup only.

* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt should be possible to perform debugCall on ARMv7
fpizlo@apple.com [Thu, 19 Apr 2012 21:55:00 +0000 (21:55 +0000)]
It should be possible to perform debugCall on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84381

Reviewed by Oliver Hunt.

debugCall() was clobbering the argument to the call it was making, leading to a
corrupt ExecState*. This change fixes that issue by using a scratch register that
does not clobber arguments, and it also introduces more assertions that we have
a valid call frame.

* dfg/DFGAssemblyHelpers.cpp:
(DFG):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::selectScratchGPR):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby...
jer.noble@apple.com [Thu, 19 Apr 2012 21:32:41 +0000 (21:32 +0000)]
REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84384

Add platform/mac baselines for new ruby tests.

* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in correct expectations for some passing tests.
barraclough@apple.com [Thu, 19 Apr 2012 21:29:41 +0000 (21:29 +0000)]
Check in correct expectations for some passing tests.

Rubber stamped by Oliver Hunt.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove description from calls to indexedDB.open
dgrogan@chromium.org [Thu, 19 Apr 2012 21:26:45 +0000 (21:26 +0000)]
Remove description from calls to indexedDB.open
https://bugs.webkit.org/show_bug.cgi?id=84109

open() used to take two parameters, a database name and an optional
string database description.  The description was deprecated.  An
optional integer version parameter was recently added in its place.

This change removes the description parameter from calls that still
had it so that it's not interpreted as a version.

Reviewed by Eric Seidel.

* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/createObjectStore-null-name-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required-expected.txt:
* storage/indexeddb/database-odd-names-expected.txt:
* storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/deleteObjectStore-null-name-expected.txt:
* storage/indexeddb/factory-basics-expected.txt:
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-sort-order-across-types-expected.txt:
* storage/indexeddb/key-sort-order-date-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-infinity-expected.txt:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/keypath-fetch-key-expected.txt:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/readonly-properties-expected.txt:
* storage/indexeddb/resources/create-object-store-options.js:
(test):
* storage/indexeddb/resources/createObjectStore-name-argument-required.js:
(test):
* storage/indexeddb/resources/createObjectStore-null-name.js:
(test):
* storage/indexeddb/resources/cursor-update-value-argument-required.js:
(test):
* storage/indexeddb/resources/database-odd-names.js:
(openNextDatabase):
* storage/indexeddb/resources/deleteObjectStore-name-argument-required.js:
(test):
* storage/indexeddb/resources/deleteObjectStore-null-name.js:
(test):
* storage/indexeddb/resources/factory-basics.js:
(test):
(getDatabaseNamesSuccess1):
* storage/indexeddb/resources/index-get-key-argument-required.js:
(test):
* storage/indexeddb/resources/invalid-keys.js:
(test):
* storage/indexeddb/resources/key-sort-order-across-types.js:
(test):
* storage/indexeddb/resources/key-sort-order-date.js:
(test):
* storage/indexeddb/resources/key-type-array.js:
(test):
* storage/indexeddb/resources/key-type-infinity.js:
(test):
* storage/indexeddb/resources/keypath-basics.js:
(test):
* storage/indexeddb/resources/keypath-fetch-key.js:
(test):
* storage/indexeddb/resources/objectStore-required-arguments.js:
(test):
* storage/indexeddb/resources/odd-strings.js:
(openNextDatabase):
(verifyNextDatabase):
* storage/indexeddb/resources/readonly-properties.js:
(test):
* storage/indexeddb/resources/readonly.js:
(test):
* storage/indexeddb/resources/setVersion-null.js:
(test):
* storage/indexeddb/resources/setVersion-undefined.js:
(test):
* storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(test):
* storage/indexeddb/resources/transaction-storeNames-required.js:
(test):
* storage/indexeddb/resources/value-undefined.js:
(test):
* storage/indexeddb/resources/values-odd-types.js:
(test):
* storage/indexeddb/setVersion-null-expected.txt:
* storage/indexeddb/setVersion-undefined-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/value-undefined-expected.txt:
* storage/indexeddb/values-odd-types-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Call signedPublicKeyAndChallengeString directly
pilgrim@chromium.org [Thu, 19 Apr 2012 21:24:09 +0000 (21:24 +0000)]
[Chromium] Call signedPublicKeyAndChallengeString directly
https://bugs.webkit.org/show_bug.cgi?id=84372

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
macpherson@chromium.org [Thu, 19 Apr 2012 21:22:29 +0000 (21:22 +0000)]
Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
https://bugs.webkit.org/show_bug.cgi?id=84368

Reviewed by Simon Fraser.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInitialize all member variables in CSSImageSetValue's copy constructor.
macpherson@chromium.org [Thu, 19 Apr 2012 21:20:23 +0000 (21:20 +0000)]
Initialize all member variables in CSSImageSetValue's copy constructor.
https://bugs.webkit.org/show_bug.cgi?id=84379

Reviewed by Simon Fraser.

No new tests / code cleanup only.

* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Call audioHardwareBufferSize directly
pilgrim@chromium.org [Thu, 19 Apr 2012 20:53:03 +0000 (20:53 +0000)]
[Chromium] Call audioHardwareBufferSize directly
https://bugs.webkit.org/show_bug.cgi?id=84370

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK test_expectations update after r114640.
philn@webkit.org [Thu, 19 Apr 2012 20:34:13 +0000 (20:34 +0000)]
Unreviewed, GTK test_expectations update after r114640.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPositioned children of ruby runs not handled correctly during layout
commit-queue@webkit.org [Thu, 19 Apr 2012 20:15:18 +0000 (20:15 +0000)]
Positioned children of ruby runs not handled correctly during layout
https://bugs.webkit.org/show_bug.cgi?id=84157

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Julien Chaffraix.

Source/WebCore:

A positioned ruby text causes a problem because it is excluded from
normal layout by its parent and instead gets layout from
RenderRubyRun::layoutSpecialExcludedChild; however this means it gets
skipped over during the loop in RenderBlock::layoutBlockChildren,
which is where positioned RenderBlocks get added to the appropriate
positioned object lists. As a result, a dirty positioned ruby text
will not get layout again unless the RenderRubyRun also needs layout
which is not guaranteed.

This patch disqualifies ruby text elements from being positioned.
If it is necessary to support this in future, ruby text layout will
have to be modified to ensure the renderers are added to the
appropriate block lists.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::rubyText):

LayoutTests:

* fast/ruby/modify-positioned-ruby-text-crash-expected.txt: Added
* fast/ruby/modify-positioned-ruby-text-crash.html: Exercises the crash condition
in but 84157 relating to positioned ruby text. This is being added
in case support for positioned ruby text is added in future, so that
we can guard against regression.
* fast/ruby/floating-ruby-text-expected.png: Added
* fast/ruby/floating-ruby-text-expected.txt: Added
* fast/ruby/floating-ruby-text.html: Creates a positioned ruby text. The
position should be ignored.
* fast/ruby/positioned-ruby-text-expected.png: Added
* fast/ruby/positioned-ruby-text-expected.txt: Added
* fast/ruby/positioned-ruby-text.html: Creates a floating ruby text. The
float should be ignored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDevTools: assertion failure upon devtools window reopen.
commit-queue@webkit.org [Thu, 19 Apr 2012 19:12:42 +0000 (19:12 +0000)]
DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-19
Reviewed by Pavel Feldman.

The pointers pointed to by WebInspector must be reset explicitly
in WebInspector::didClose() method

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes...
fpizlo@apple.com [Thu, 19 Apr 2012 19:08:58 +0000 (19:08 +0000)]
LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that
the PB/PC has been preserved
https://bugs.webkit.org/show_bug.cgi?id=84367

Reviewed by Oliver Hunt.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: No response body available for cached resource requests with error...
vsevik@chromium.org [Thu, 19 Apr 2012 18:56:01 +0000 (18:56 +0000)]
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265

Reviewed by Pavel Feldman.

Source/WebCore:

InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.

Test: http/tests/inspector/network/network-image-404.html

* inspector/InspectorResourceAgent.cpp:
(WebCore::isErrorStatusCode):
(WebCore):
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::purgeContent):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceContent):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):

LayoutTests:

* http/tests/inspector/network/network-image-404-expected.txt: Added.
* http/tests/inspector/network/network-image-404.html: Added.
* http/tests/inspector/network/resources/404.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector / Heap snapshots: "Object's retaining tree" view doesn't get cleared...
yurys@chromium.org [Thu, 19 Apr 2012 18:50:44 +0000 (18:50 +0000)]
Web Inspector / Heap snapshots: "Object's retaining tree" view doesn't get cleared when navigating between objects
https://bugs.webkit.org/show_bug.cgi?id=84337

When DataGrid root node is reset, make sure all existing rows are removed.

Reviewed by Vsevolod Vlasov.

* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setRootNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=80534
bdakin@apple.com [Thu, 19 Apr 2012 18:47:27 +0000 (18:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80534
REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
hover

Reviewed by Adele Peterson.

This patch just adds some code back that was removed by
http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
bug and should not have been removed.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt should be possible to load from Float64 arrays on ARMv7 without crashing
fpizlo@apple.com [Thu, 19 Apr 2012 18:44:04 +0000 (18:44 +0000)]
It should be possible to load from Float64 arrays on ARMv7 without crashing
https://bugs.webkit.org/show_bug.cgi?id=84361

Reviewed by Oliver Hunt.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDevTools highlights elements in frames at un-scaled positions
wangxianzhu@chromium.org [Thu, 19 Apr 2012 18:42:00 +0000 (18:42 +0000)]
DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181

Source/WebCore:

On mobile platforms (e.g. chromium-android), normally pages are scaled,
thus the coordinations of highlight rect inside of a frame needs to
consider not only the offset, but also the scale. The change uses
FrameView::contentsToRootView() to map the coordinates of a node in
a frame to the coordinates in the main frame, instead of calculating
by only the offset.

Reviewed by Pavel Feldman.

Test: inspector/elements/highlight-node-scaled.html

* inspector/DOMNodeHighlighter.cpp:

LayoutTests:

The new test case is a scaled web page containing an iframe. It tests
if the highlight rect of an element in the iframe is correct.

Reviewed by Pavel Feldman.

* inspector/elements/highlight-node-scaled-expected.txt: Added.
* inspector/elements/highlight-node-scaled.html: Added.
* inspector/elements/resources/highlight-node-scaled-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector / Heap snapshots: "Objects allocated ..." views are empty
yurys@chromium.org [Thu, 19 Apr 2012 18:38:34 +0000 (18:38 +0000)]
Web Inspector / Heap snapshots: "Objects allocated ..." views are empty
https://bugs.webkit.org/show_bug.cgi?id=84347

Pass parsed maxJSObjectId value to the profile header constructor.

Reviewed by Pavel Feldman.

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is...
ap@apple.com [Thu, 19 Apr 2012 18:27:45 +0000 (18:27 +0000)]
AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66601

Reviewed by Eric Carlson.

* platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Added.
Copied passing result, since this doesn't fail on Snow Leopard.

* platform/mac/media/video-size-intrinsic-scale-expected.txt: Added a failing results to make
bots green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10664148> and https://bugs.webkit.org/show_bug.cgi?id=84360 StorageTh...
beidson@apple.com [Thu, 19 Apr 2012 18:25:44 +0000 (18:25 +0000)]
<rdar://problem/10664148> and https://bugs.webkit.org/show_bug.cgi?id=84360 StorageThread should have an autorelease pool in place for Cocoa clients

Reviewed by Eric Carlson.

No new tests. (Not practical to test this with current tools)

* storage/StorageThread.cpp:
(WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix potential null pointer dereference in RuleSet::addRulesFromSheet().
macpherson@chromium.org [Thu, 19 Apr 2012 18:20:08 +0000 (18:20 +0000)]
Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
https://bugs.webkit.org/show_bug.cgi?id=84258

Reviewed by Andreas Kling.

Fix variable that is dereferenced without null check here, but checked in code above and below.

No new test / code cleanup from coverity analysis.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: exception when hovering object while paused
yurys@chromium.org [Thu, 19 Apr 2012 18:18:01 +0000 (18:18 +0000)]
Web Inspector: exception when hovering object while paused
https://bugs.webkit.org/show_bug.cgi?id=84358

Added missing boolean parameter to the call site of evaluate method
on call frame.

Reviewed by Vsevolod Vlasov.

* inspector/front-end/AdvancedSearchController.js:
* inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
method so that closure compiler catches errors like in the bug report.
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
commit-queue@webkit.org [Thu, 19 Apr 2012 18:17:58 +0000 (18:17 +0000)]
[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
https://bugs.webkit.org/show_bug.cgi?id=82484

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.

Tools:

Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

LayoutTests:

Unskipping tests that were previously failing due to a bug in libsoup.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: nodes are not removed from the summary view when switching between...
yurys@chromium.org [Thu, 19 Apr 2012 18:11:31 +0000 (18:11 +0000)]
Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354

Clear all top level nodes not only those visible in the viewport when populating
the constructors view with new content.

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium] Allow scrolling non-root layers in the compositor thread
commit-queue@webkit.org [Thu, 19 Apr 2012 18:03:46 +0000 (18:03 +0000)]
Source/WebCore: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.

This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.

If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.

Added new webkit_unit_tests to verify scrolling behavior.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::scrollBy):
(WebCore):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerDelegate):
(ContentLayerChromium):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::didScroll):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::scrollBy):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::findLayerInSubtree):
(WebCore):
(WebCore::CCLayerImpl::tryScroll):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::findLayerById):
(WebCore):
(WebCore::findFirstScrollableLayer):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateVisibleLayers):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findRootScrollLayer):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):
(CCLayerTreeHostImpl):
(LayerGeometry):

Source/WebKit/chromium: [chromium] Add tests for scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::didScroll):
(WebKit):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::createScrollableLayer):
(CCLayerTreeHostImplTest):
(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):
(WebKitTests):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestOpacityChangeLayerDelegate::didScroll):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::didScroll):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpace out captions-fast.vtt to prevent flakiness in media/track/track-mode.html.
annacc@chromium.org [Thu, 19 Apr 2012 17:53:37 +0000 (17:53 +0000)]
Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html.
https://bugs.webkit.org/show_bug.cgi?id=83878

Reviewed by Eric Carlson.

* media/track/captions-webvtt/captions-fast.vtt:
* media/track/track-mode-expected.txt:
* media/track/track-mode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: make constructors and diff heap snapshot data grids use viewport
yurys@chromium.org [Thu, 19 Apr 2012 17:11:15 +0000 (17:11 +0000)]
Web Inspector: make constructors and diff heap snapshot data grids use viewport
https://bugs.webkit.org/show_bug.cgi?id=84348

HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only
visible rows. HeapSnapshotConstructorsDataGrid and HeapSnapshotDiffDataGrid are
inherited from this class which makes them operate well on large amounts of nodes.

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.nodeHeight):
(WebInspector.DataGridNode.prototype._attach):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendTopLevelNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._addPaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._removePaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotPaddingNode):
(WebInspector.HeapSnapshotPaddingNode.prototype.setHeight):
(WebInspector.HeapSnapshotPaddingNode.prototype.removeFromTable):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.collapse):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
* inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode.prototype.createCells):
(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):

LayoutTests:

* inspector/profiler/heap-snapshot-test.js: since summary and containment views are
now viewports, we should make sure all lazy clean up is done before collecting visible
rows content.
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] [DRT] Unskip KeyEvent related tests which are passing now
commit-queue@webkit.org [Thu, 19 Apr 2012 17:07:10 +0000 (17:07 +0000)]
[EFL] [DRT] Unskip KeyEvent related tests which are passing now
https://bugs.webkit.org/show_bug.cgi?id=84345

Unreviewed, unskip passing KeyEvent tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Stub out IDBCursor.advance for landing
commit-queue@webkit.org [Thu, 19 Apr 2012 17:05:36 +0000 (17:05 +0000)]
IndexedDB: Stub out IDBCursor.advance for landing
https://bugs.webkit.org/show_bug.cgi?id=84280

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-19
Reviewed by Dimitri Glazkov.

Just a stub method so it can be implemented on chromium

* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::advance):
* src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::advance):
(WebKit):
* src/WebIDBCursorImpl.h:
(WebIDBCursorImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove apple-xserve-10 from Lion Test to SnowLeopard Debug Build
lforschler@apple.com [Thu, 19 Apr 2012 17:00:28 +0000 (17:00 +0000)]
Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114421.
haraken@chromium.org [Thu, 19 Apr 2012 17:00:21 +0000 (17:00 +0000)]
Unreviewed, rolling out r114421.
http://trac.webkit.org/changeset/114421
https://bugs.webkit.org/show_bug.cgi?id=84103

Chromium crash

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
* bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
* bindings/v8/V8Binding.h:
(WebCore::v8ExternalString):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114626.
vsevik@chromium.org [Thu, 19 Apr 2012 16:59:34 +0000 (16:59 +0000)]
Unreviewed, rolling out r114626.
http://trac.webkit.org/changeset/114626
https://bugs.webkit.org/show_bug.cgi?id=84349

caused new assertions in debug builds (Requested by smfr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

Source/WebCore:

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
* inspector/NetworkResourcesData.h:
(ResourceData):
(NetworkResourcesData):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):

LayoutTests:

* http/tests/inspector/network/network-image-404-expected.txt: Removed.
* http/tests/inspector/network/network-image-404.html: Removed.
* http/tests/inspector/network/resources/404.php: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Call mimeRegistry directly
pilgrim@chromium.org [Thu, 19 Apr 2012 16:40:28 +0000 (16:40 +0000)]
[Chromium] Call mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=84334

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::layoutTestMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisplay a TextTrackCue when snap-to-lines flag is not set
commit-queue@webkit.org [Thu, 19 Apr 2012 16:27:25 +0000 (16:27 +0000)]
Display a TextTrackCue when snap-to-lines flag is not set
https://bugs.webkit.org/show_bug.cgi?id=79750

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-19
Reviewed by Eric Carlson.

Source/WebCore:

Support for positioning of a cue on top of the video element when snap-to-lines is not set.

Test: media/track/track-cue-rendering-snap-to-lines-not-set.html

* css/mediaControls.css:
(video::-webkit-media-text-track-container): Marked the container as
flexible box in order to use all the available space on top of the controls.
(video::-webkit-media-text-track-background): Added background default settings.
(video::-webkit-media-text-track-display): Added default position.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Updated comments.
* html/track/TextTrackCue.cpp:
(WebCore):
(WebCore::TextTrackCue::TextTrackCue): Updated constructor to calculate
the computed line position.
(WebCore::TextTrackCue::setLine): Updated call to calculate the computed line
position.
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::calculateComputedLinePosition): Partial calculation of the
computated line position.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated display parameter computations
required by the spec.
(WebCore::TextTrackCue::getDisplayTree): Updated positioning attributes when snap-to-lines
is not set. Added extra anonymous box for background, because setting position:absolute
on the display tree determines the background to cover the whole block, not just inline.
(WebCore::TextTrackCue::getPositionCoordinates): Determine coordinates as required by the spec.
* html/track/TextTrackCue.h:
(TextTrackCue):

LayoutTests:

Added tests to support positioning of cues when snap-to-lines set.

* media/media-controls.js:
(textTrackDisplayElement): Added an extra parameter, to return the display
box of the N-th active cue.
* media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Added.
* media/track/track-cue-rendering-expected.txt: Updated background color check.
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
* media/track/track-cue-rendering-snap-to-lines-not-set.html: Added.
* media/track/track-cue-rendering.html: Updated background color check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC testing should have complete coverage over typed array types
fpizlo@apple.com [Thu, 19 Apr 2012 16:23:44 +0000 (16:23 +0000)]
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Rubber stamped by Gavin Barraclough.

Added float64 array test coverage.

* fast/js/dfg-float64array-expected.txt: Added.
* fast/js/dfg-float64array.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-float64array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: introduce styles panel as an experiment
pfeldman@chromium.org [Thu, 19 Apr 2012 16:19:59 +0000 (16:19 +0000)]
Web Inspector: introduce styles panel as an experiment
https://bugs.webkit.org/show_bug.cgi?id=84331

Reviewed by Vsevolod Vlasov.

This change introduces new "Styles" panel that looks like the "Scripts" one,
but operates stylesheets. This is happening under the experimental flag.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.showAnchorLocation):
* inspector/front-end/ResourceView.js:
(WebInspector.EditableResourceSourceFrame.prototype.didEditContent):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._clearLineHighlight):
* inspector/front-end/StylesPanel.js: Added.
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype.wasShown):
(WebInspector.StylesPanel.prototype._initialize):
(WebInspector.StylesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.StylesPanel.prototype._populateResourceTree):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._cachedResourcesLoaded):
(WebInspector.StylesPanel.prototype.get toolbarItemLabel):
(WebInspector.StylesPanel.prototype.viewForFile.get if):
(WebInspector.StylesPanel.prototype.viewForFile):
(WebInspector.StylesPanel.prototype._textEdited):
(WebInspector.StylesPanel.prototype._scriptSelected):
(WebInspector.StylesPanel.prototype._showFile):
(WebInspector.StylesPanel.prototype.canShowAnchorLocation):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector._showAnchorLocationInPanel):
* inspector/front-end/scriptsPanel.css:
* inspector/front-end/splitView.css:
(.sidebar-overlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollow up to r114632: build fix.
vsevik@chromium.org [Thu, 19 Apr 2012 16:16:45 +0000 (16:16 +0000)]
Follow up to r114632: build fix.

* inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Call sampleGamepads directly
pilgrim@chromium.org [Thu, 19 Apr 2012 15:57:26 +0000 (15:57 +0000)]
[Chromium] Call sampleGamepads directly
https://bugs.webkit.org/show_bug.cgi?id=84339

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/GamepadsChromium.cpp:
(WebCore::sampleGamepads):
* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Call audioHardwareSampleRate directly
pilgrim@chromium.org [Thu, 19 Apr 2012 15:51:26 +0000 (15:51 +0000)]
[Chromium] Call audioHardwareSampleRate directly
https://bugs.webkit.org/show_bug.cgi?id=84335

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::hardwareSampleRate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] dispatchDidCancelClientRedirect needs implementation
commit-queue@webkit.org [Thu, 19 Apr 2012 15:37:16 +0000 (15:37 +0000)]
[EFL] dispatchDidCancelClientRedirect needs implementation
https://bugs.webkit.org/show_bug.cgi?id=83669

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-19
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit a new "redirect,cancelled" signal on the ewk_frame when a
redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
frame load callbacks information.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):
* ewk/ewk_frame.cpp:
(ewk_frame_redirect_cancelled):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:

Tools:

Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
and print out information that is expected by several test cases if
LayoutTestController's dumpFrameLoadCallback() returns true.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectCancelled):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: x-frame security errors logged when typing in the console are annoying.
vsevik@chromium.org [Thu, 19 Apr 2012 15:34:31 +0000 (15:34 +0000)]
Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970

Reviewed by Pavel Feldman.

Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):
* inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):
* inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):
* inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
* inspector/front-end/WorkerManager.js:
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):
* page/Console.h:
(Console):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Zoom out on the second double click does not always scale right.
commit-queue@webkit.org [Thu, 19 Apr 2012 15:26:32 +0000 (15:26 +0000)]
[Qt][WK2] Zoom out on the second double click does not always scale right.
https://bugs.webkit.org/show_bug.cgi?id=84332

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-19
Reviewed by Simon Hausmann.

Zoom out to the minimum scale value instead of the fixed 1.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114628.
commit-queue@webkit.org [Thu, 19 Apr 2012 14:46:33 +0000 (14:46 +0000)]
Unreviewed, rolling out r114628.
http://trac.webkit.org/changeset/114628
https://bugs.webkit.org/show_bug.cgi?id=84341

Breaks EFL and GTK builds (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
* inspector/PageDebuggerAgent.cpp:
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/PageRuntimeAgent.cpp:
* inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
* inspector/WorkerRuntimeAgent.cpp:
* inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
* inspector/front-end/WorkerManager.js:
* page/Console.cpp:
(WebCore):
(WebCore::Console::addMessage):
(WebCore::Console::warn):
* page/Console.h:
(Console):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd expectation for flaky svg/custom/foreign-object-skew.svg
schenney@chromium.org [Thu, 19 Apr 2012 13:42:42 +0000 (13:42 +0000)]
Add expectation for flaky svg/custom/foreign-object-skew.svg

Unreviewed Chromium expectations fix.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: x-frame security errors logged when typing in the console are annoying.
vsevik@chromium.org [Thu, 19 Apr 2012 13:28:25 +0000 (13:28 +0000)]
Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970

Reviewed by Pavel Feldman.

Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):
* inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):
* inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):
* inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
* inspector/front-end/WorkerManager.js:
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):
* page/Console.h:
(Console):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix Qt-Mac build after libxml patch
noam.rosenthal@nokia.com [Thu, 19 Apr 2012 13:11:39 +0000 (13:11 +0000)]
[Qt] Fix Qt-Mac build after libxml patch
https://bugs.webkit.org/show_bug.cgi?id=84313

Use direct include/library paths instead of PKGCONFIG when on Mac.

Reviewed by Simon Hausmann.

No new tests, build fix.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: No response body available for cached resource requests with error...
vsevik@chromium.org [Thu, 19 Apr 2012 12:08:39 +0000 (12:08 +0000)]
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265

Source/WebCore:

Reviewed by Pavel Feldman.

InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.

Test: http/tests/inspector/network/network-image-404.html

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::httpStatusCode):
(WebCore):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
(ResourceData):
(NetworkResourcesData):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):

LayoutTests:

* http/tests/inspector/network/network-image-404-expected.txt: Added.
* http/tests/inspector/network/network-image-404.html: Added.
* http/tests/inspector/network/resources/404.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening. Skip failing reftest after 114574.
kkristof@inf.u-szeged.hu [Thu, 19 Apr 2012 11:55:10 +0000 (11:55 +0000)]
[Qt] Gardening. Skip failing reftest after 114574.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-19
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
commit-queue@webkit.org [Thu, 19 Apr 2012 11:44:21 +0000 (11:44 +0000)]
[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=84323

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-19
Reviewed by Antonio Gomes.

PR 150750
Regardless of whether there's a WebPageCompositorClient, we want the
AnimationFrameRateController to manage animation frames.
Reviewed internally by Andrew Lo.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: reuse ParsedUrl in the UISourceCode
pfeldman@chromium.org [Thu, 19 Apr 2012 11:39:50 +0000 (11:39 +0000)]
Web Inspector: reuse ParsedUrl in the UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=84326

Reviewed by Yury Semikhatsky.

Source/WebCore:

Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
TabbedEditorContainer.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.SourceMapParser.prototype._canonicalizeURL):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get parsedURL):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/ui-source-code-display-name.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Build fix after r114575
commit-queue@webkit.org [Thu, 19 Apr 2012 09:08:18 +0000 (09:08 +0000)]
[CMake] Build fix after r114575
https://bugs.webkit.org/show_bug.cgi?id=84322

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Simon Hausmann.

Build fix, adding WTF when linking jsc shell.

* shell/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize for DARWIN in DirectConvolver::process()
commit-queue@webkit.org [Thu, 19 Apr 2012 07:20:36 +0000 (07:20 +0000)]
Optimize for DARWIN in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80256

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-04-19
Reviewed by Chris Rogers.

* platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .
toyoshim@chromium.org [Thu, 19 Apr 2012 07:07:22 +0000 (07:07 +0000)]
Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .

* http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
noel.gordon@gmail.com [Thu, 19 Apr 2012 06:56:22 +0000 (06:56 +0000)]
[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=84319

Reviewed by Eric Seidel.

No change in behavior. Covered by existing canvas 2d and 3d tests:

  canvas/philip/tests/toDataURL.jpeg.alpha.html
  fast/canvas/webgl/premultiplyalpha-test.html

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html
toyoshim@chromium.org [Thu, 19 Apr 2012 06:35:57 +0000 (06:35 +0000)]
Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html

* platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary rounding/conversions in RenderBoxModelObject
eae@chromium.org [Thu, 19 Apr 2012 05:40:08 +0000 (05:40 +0000)]
Remove unnecessary rounding/conversions in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=84288

Reviewed by Eric Seidel.

No new tests, no change in functionality.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
commit-queue@webkit.org [Thu, 19 Apr 2012 05:21:50 +0000 (05:21 +0000)]
[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
https://bugs.webkit.org/show_bug.cgi?id=82830

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

Source/WebCore:

RFC 2965
3.2.2
Domain = value
If an explicitly specified value does not start with a dot, the user agent supplies
a leading dot.
3.3.1
Domain  Defaults to the effective request-host.  (Note that because there is no dot
at the beginning of effective request-host, the default Domain can only domain-match
itself.)

The first char can show the difference even though it is from the cookie database.
But m_hasDefaultDomain is set to false if the cookie is from database although the
domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.

In sum,  we shouldn't use m_hasDefaultDomain.

Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::shouldRejectForSecurityReason):
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
* platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::ParsedCookie):
* platform/blackberry/ParsedCookie.h:
(ParsedCookie):

LayoutTests:

* http/tests/security/cookies/cookies-wrong-domain-rejected-expected.txt: Added.
* http/tests/security/cookies/cookies-wrong-domain-rejected-result.php: Added.
* http/tests/security/cookies/cookies-wrong-domain-rejected.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
enne@google.com [Thu, 19 Apr 2012 04:51:19 +0000 (04:51 +0000)]
[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
https://bugs.webkit.org/show_bug.cgi?id=83840

Reviewed by James Robinson.

The same logic to decide when to make text use LCD rendering is copy
and pasted in all the different font classes. It seems like this
should live in a single place.

* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::adjustTextRenderMode):
(WebCore):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::setupPaintForFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium/mac] Fix build.
thakis@chromium.org [Thu, 19 Apr 2012 04:45:40 +0000 (04:45 +0000)]
[chromium/mac] Fix build.
https://bugs.webkit.org/show_bug.cgi?id=84314

Unreviewed, build fix after http://trac.webkit.org/changeset/114604

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker...
hbono@chromium.org [Thu, 19 Apr 2012 03:51:56 +0000 (03:51 +0000)]
Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748

Reviewed by Ryosuke Niwa.

Source/WebCore:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and  didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

Test: platform/chromium/editing/spelling/delete-misspelled-word.html

* WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.
* editing/SpellChecker.h:
(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.

Source/WebKit/chromium:

This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.

* public/WebTextCheckingCompletion.h:
(WebKit::WebTextCheckingCompletion::didCancelCheckingText):
* src/WebTextCheckingCompletionImpl.cpp:
(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
* src/WebTextCheckingCompletionImpl.h:
(WebTextCheckingCompletionImpl):

Source/WebKit/mac:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().

* WebCoreSupport/WebEditorClient.mm:
(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.

Tools:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.

LayoutTests:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and  didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

* platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
* platform/chromium/editing/spelling/delete-misspelled-word.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
jamesr@google.com [Thu, 19 Apr 2012 02:48:16 +0000 (02:48 +0000)]
[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=84120

Reviewed by Adrienne Walker.

Source/Platform:

This adds support for IO surface backed WebExternalTextureLayer, used by CoreAnimation plugins on OS X and moves
some functionality used by multiple WebLayer subclasses up to the base class.

* chromium/public/WebContentLayer.h:
(WebContentLayer):
* chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::unwrap):

Source/WebCore:

This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
WebExternalTextureLayer and cleans it up slightly.

* WebCore.gypi:
* platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
(WebCore):
(WebCore::TextureLayerChromium::create):
(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::createCCLayerImpl):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setFlipped):
(WebCore::TextureLayerChromium::setUVRect):
(WebCore::TextureLayerChromium::setIOSurfaceProperties):
(WebCore::TextureLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::flipped):
(WebCore::TextureLayerChromium::uvRect):

Source/WebKit/chromium:

This ports WebPluginContainerImpl over to use WebExternalTextureLayer instead of directly using a *LayerChromium
type for better layering and code sharing. The changes to WebPluginContainerImpl are fairly straightforward.  In
addition to renames I also moved some state tracking into WPCI instead of having it exposed on the interface. I
also removed the WebExternalTextureLayerImpl intermediate class since it wasn't doing anything useful.

* WebKit.gyp:
* WebKit.gypi:
* src/WebContentLayer.cpp:
* src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setIOSurfaceProperties):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
* src/WebExternalTextureLayerImpl.cpp: Removed.
* src/WebExternalTextureLayerImpl.h: Removed.
* src/WebLayer.cpp:
(WebKit::WebLayer::invalidateRect):
(WebKit):
(WebKit::WebLayer::invalidate):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
* src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):
* tests/WebExternalTextureLayerImplTest.cpp: Removed.
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114604 268f45cc-cd09-0410-ab3c-d52691b4dbfc