WebKit-https.git
9 years ago Unreviewed, another attempt to fix GTK build after r94038.
philn@webkit.org [Tue, 30 Aug 2011 07:43:15 +0000 (07:43 +0000)]
    Unreviewed, another attempt to fix GTK build after r94038.

        * Source/autotools/symbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch Internals.cpp in an attempt to fix GTK+ build.
rniwa@webkit.org [Tue, 30 Aug 2011 06:40:07 +0000 (06:40 +0000)]
Touch Internals.cpp in an attempt to fix GTK+ build.

* testing/Internals.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix two layout tests which fails on Qt port with latest pywebsocket.
commit-queue@webkit.org [Tue, 30 Aug 2011 06:37:56 +0000 (06:37 +0000)]
Fix two layout tests which fails on Qt port with latest pywebsocket.
https://bugs.webkit.org/show_bug.cgi?id=66929

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-29
Reviewed by Kent Tamura.

hanging-handshake_wsh.py read socket to hang in opening handshake.
Then client initiated closing handshakes or abnormal closures caused
exception or resulted in http error response on hybi-10 compliant new
pywebsocket. Because tests finished at closure, it depends on timing
whether tests detects the error response. Actually, two tests failed on
Qt port by chance.
Essentially, hangings is unnecessary because open event must be queued
and WebSocket's readyState could not be changed to OPEN until the next
event loop is executed. That's why we can use echo_wsh.py instead of
hanging-handshake_wsh.py safely.

close-unref-websocket tests call close() before GC. These tests expect
GC cause close event. But close() itself also queues close event.
These close() are redandant. If GC doesn't cause close event, these
tests can pass by close event that close() queues. This change also
remove these redandant close() calls.

* http/tests/websocket/tests/hixie76/close-before-open.html:
Use echo_wsh.py instead of hanging-handshake_wsh.py.
* http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt:
* http/tests/websocket/tests/hixie76/close-unref-websocket.html:
Used echo_wsh.py, remove ws.close() and fix expectation.
* http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Removed.
* http/tests/websocket/tests/hybi/close-before-open.html:
Use echo_wsh.py instead of hanging-handshake_wsh.py.
* http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt:
* http/tests/websocket/tests/hybi/close-unref-websocket.html:
Used echo_wsh.py, remove ws.close() and fix expectation.
* http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Removed.
* http/tests/websocket/tests/hybi/close-code-and-reason.html:
* http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:
Use echo_wsh.py instead of hanging-handshake_wsh.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother Windows build fix after r94047.
rniwa@webkit.org [Tue, 30 Aug 2011 06:29:16 +0000 (06:29 +0000)]
Another Windows build fix after r94047.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix attempt after r94038.
rniwa@webkit.org [Tue, 30 Aug 2011 06:19:34 +0000 (06:19 +0000)]
Build fix attempt after r94038.

* Source/autotools/symbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
rniwa@webkit.org [Tue, 30 Aug 2011 06:07:29 +0000 (06:07 +0000)]
Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
to HTMLTextFormControlElement.

* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add exception due to missing results for r94037.
levin@chromium.org [Tue, 30 Aug 2011 05:55:54 +0000 (05:55 +0000)]
[chromium] Add exception due to missing results for r94037.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
rniwa@webkit.org [Tue, 30 Aug 2011 05:51:19 +0000 (05:51 +0000)]
Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Reviewed by Darin Adler.

Moved setInnerTextValue from RenderTextControl to HTMLTextFormControlElement.

Also moved m_lastChangeWasUserEdit from RenderTextControl to HTMLTextFormControlElement
and related inline functions from RenderTextControl to HTMLTextFormControlElement.
Because m_lastChangeWasUserEdit is no longer reset when RenderTextControl is recreated,
added explicit calls to setLastChangeWasNotUserEdit in setValue functions of HTMLInputElement
and HTMLTextAreaElement.

This patch also fixes the bug that lastChangeWasUserEdit() incorrectly returns false
when input or textarea don't have renderer (e.g. invisible).

Unfortunately, there is no way to test this behavioral change from layout tests.

* WebCore.exp.in: Exports lastChangeWasUserEdit in HTMLTextFormControlElement instead of
that of HTMLInputElement and HTMLTextAreaElement.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Explicitly calls setLastChangeWasNotUserEdit.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setValueCommon): Ditto.
* html/HTMLTextAreaElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Sets m_lastChangeWasUserEdit true
as it used to do via respondToChangeByUser.
(WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit): Moved from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): Moved from RenderTextControl.
* html/HTMLTextFormControlElement.h:
(WebCore::HTMLTextFormControlElement::setLastChangeWasNotUserEdit): Added.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl): No longer initializes m_lastChangeWasUserEdit.
* rendering/RenderTextControl.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::updateFromElement): Calls setInnerTextValue.
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::updateFromElement): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed marking skip.
morrita@google.com [Tue, 30 Aug 2011 05:27:45 +0000 (05:27 +0000)]
Unreviewed marking skip.

* platform/win/Skipped: Skipped editing/spelling/spelling-insert-html.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
tkent@chromium.org [Tue, 30 Aug 2011 05:22:37 +0000 (05:22 +0000)]
REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/file/disabling-file-busy-loop.html

* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.

LayoutTests:

* fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
* fast/forms/file/disabling-file-busy-loop.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd HAVE(VASPRINTF) macro to test for vasprintf() support
dbates@webkit.org [Tue, 30 Aug 2011 05:01:47 +0000 (05:01 +0000)]
Add HAVE(VASPRINTF) macro to test for vasprintf() support
https://bugs.webkit.org/show_bug.cgi?id=67156

Reviewed by Darin Adler.

Source/JavaScriptCore:

Encapsulate testing of vasprintf() support in a HAVE macro
instead of hardcoding the list of supported/unsupported
compilers at the call site.

* wtf/Platform.h:

Source/WebCore:

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Minor update for test that is timing out.
levin@chromium.org [Tue, 30 Aug 2011 04:57:51 +0000 (04:57 +0000)]
[chromium] Minor update for test that is timing out.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Misc test expectations updates.
levin@chromium.org [Tue, 30 Aug 2011 04:51:28 +0000 (04:51 +0000)]
[chromium] Misc test expectations updates.

* platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.
* platform/chromium/fast/files/create-blob-url-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt.
   Added due to it being different from normal OSX result.
* platform/chromium/test_expectations.txt: Changes due to expectation
  update for media-document-audio-repaint.html leading to only an image mismatch
  and a test that is a slow on OS X as well as Linux and Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Receive binary message as Blob
yutak@chromium.org [Tue, 30 Aug 2011 03:38:50 +0000 (03:38 +0000)]
WebSocket: Receive binary message as Blob
https://bugs.webkit.org/show_bug.cgi?id=67115

Reviewed by Kent Tamura.

Source/WebCore:

Make WebSocketChannel be able to receive WebSocket binary messages and deliver them via
didReceiveBinaryData() callback of WebSocketChannelClient.

Tests: http/tests/websocket/tests/hybi/fragmented-binary-frames.html
       http/tests/websocket/tests/hybi/receive-blob.html
       http/tests/websocket/tests/hybi/workers/receive-blob.html

* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data): Convert Blob to JSValue.
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter): Convert Blob to v8::Value.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
* dom/MessageEvent.h:
Added DataTypeBlob and Blob-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsBlob):
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
If binaryType attribute is "blob", construct a Blob using BlobData filled with the given
binary message.
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):
Create continuousFrameData as OwnPtr<> rather than stack-allocated value so we can easily
pass it to didReceiveBinaryData() callback.
Save the content of a fragmented message even if it is a binary opcode.
* websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didReceiveBinaryData):
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
Pass binaryData as PassOwnPtr<Vector<char> > to deliver the value efficiently (without
copying the content) across threads.
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hybi/binary-frames_wsh.py: Added. Used from receive-blob.html.
* http/tests/websocket/tests/hybi/fragmented-binary-frames-expected.txt: Added.
* http/tests/websocket/tests/hybi/fragmented-binary-frames.html:
Added. The content of this test is almost identical to receive-blob.html.
* http/tests/websocket/tests/hybi/fragmented-binary-frames_wsh.py: Added.
* http/tests/websocket/tests/hybi/receive-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/receive-blob.html:
Added. It is a bit complicated to validate the content of a Blob, because a Blob must be read
asynchronously. FileReader is used to read a blob as an ArrayBuffer, each byte of which is
compared with the expected result.
* http/tests/websocket/tests/hybi/workers/receive-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/receive-blob.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/binary-frames_wsh.py:
Added. Same as above binary-frames_wsh.py.
* http/tests/websocket/tests/hybi/workers/resources/receive-blob.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExport more symbols for r94038.
rniwa@webkit.org [Tue, 30 Aug 2011 02:29:25 +0000 (02:29 +0000)]
Export more symbols for r94038.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix for r94038.
rniwa@webkit.org [Tue, 30 Aug 2011 02:19:19 +0000 (02:19 +0000)]
Windows build fix for r94038.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
rniwa@webkit.org [Tue, 30 Aug 2011 02:03:52 +0000 (02:03 +0000)]
Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=67173

Reviewed by Darin Adler.

Source/WebCore:

Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
an input element or a textarea element lastChangeWasUserEdit is called upon.

Test: fast/forms/textfield-lastchange-was-useredit.html

* testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
HTMLTextAreaElement::lastChangeWasUserEdit.

* fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
* fast/forms/textfield-lastchange-was-useredit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement CSSPropertyWebkitColumns in CSSStyleApplyProperty.
macpherson@chromium.org [Tue, 30 Aug 2011 01:49:10 +0000 (01:49 +0000)]
Implement CSSPropertyWebkitColumns in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67106

Reviewed by Darin Adler.

Tests:
LayoutTests/fast/multicol/inherit-column-values.html
LayoutTests/fast/multicol/initial-column-values.html

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handler for CSSPropertyWebkitColumns.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementation for CSSPropertyWebkitColumns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosheriffbot "usage" help statements are wrong
commit-queue@webkit.org [Tue, 30 Aug 2011 01:43:57 +0000 (01:43 +0000)]
sheriffbot "usage" help statements are wrong
https://bugs.webkit.org/show_bug.cgi?id=67170

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnzip initialization lists and constructors in JSCell hierarchy (3/7)
commit-queue@webkit.org [Tue, 30 Aug 2011 01:43:46 +0000 (01:43 +0000)]
Unzip initialization lists and constructors in JSCell hierarchy (3/7)
https://bugs.webkit.org/show_bug.cgi?id=67064

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-29
Reviewed by Darin Adler.

Source/JavaScriptCore:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::finishCreation):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
(JSC::Arguments::finishCreation):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::finishCreation):
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
Moved the assignment of m_firstLine and m_lastLine into the
FunctionExecutable::finishCreation() method in Executable.h
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::finishCreation):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::finishCreation):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
* runtime/JSObject.h:
(JSC::JSNonFinalObject::JSNonFinalObject):
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::finishCreation):
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::finishCreation):
* runtime/ObjectPrototype.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):

Source/JavaScriptGlue:

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* UserObjectImp.cpp:
(UserObjectImp::UserObjectImp):

Source/WebCore:

No new tests.

Completed the third level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::finishCreation):
* bindings/js/JSDOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add missing API documentation.
commit-queue@webkit.org [Tue, 30 Aug 2011 01:29:59 +0000 (01:29 +0000)]
[EFL] Add missing API documentation.
https://bugs.webkit.org/show_bug.cgi?id=66927

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-29
Reviewed by Kent Tamura.

Adds missing documentation for ewk_context_menu_item_checked_get/set.
Moves API documentation from cpp to the headers.
Adds brief and file commands for ewk_js.h.

* ewk/ewk_contextmenu.h:
* ewk/ewk_cookies.cpp:
* ewk/ewk_cookies.h:
* ewk/ewk_frame.cpp:
* ewk/ewk_frame.h:
* ewk/ewk_js.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QTouchWebView url property test missing
commit-queue@webkit.org [Mon, 29 Aug 2011 23:47:23 +0000 (23:47 +0000)]
[Qt] QTouchWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67159

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property of QTouchWebView. Since url is a readonly property, we make sure that it's set after load() is called.

* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for chomium-mac (non-CoreGraphics) baselines
abarth@webkit.org [Mon, 29 Aug 2011 23:39:51 +0000 (23:39 +0000)]
Add support for chomium-mac (non-CoreGraphics) baselines
https://bugs.webkit.org/show_bug.cgi?id=67163

Reviewed by Eric Seidel.

This patch teaches the non-CG chromium-mac bots to look at non-CG
baselines.  However, the patch still leaves CG as the default set of
baselines.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdating forms survey with non-standard wrap for textarea and more data-list driven...
jonlee@apple.com [Mon, 29 Aug 2011 23:37:25 +0000 (23:37 +0000)]
Updating forms survey with non-standard wrap for textarea and more data-list driven text fields.

* projects/forms/survey.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Added new rebaselines for media/media-document-audio-repaint.
imasaki@chromium.org [Mon, 29 Aug 2011 23:21:22 +0000 (23:21 +0000)]
[Chromium] Added new rebaselines for media/media-document-audio-repaint.
These are obtained by the rebaseline tool.
https://bugs.webkit.org/show_bug.cgi?id=67070

Reviewed by David Levin.

* platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-cg-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-cg-mac/media/media-document-audio-repaint-expected.txt:
* platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QDesktopWebView url property test missing
commit-queue@webkit.org [Mon, 29 Aug 2011 23:19:43 +0000 (23:19 +0000)]
[Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-29
Reviewed by Noam Rosenthal.

Added qml test case to check url property. Since url is a readonly property, we make sure that it's set after load() is called.

* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeed up texImage from BGRA
commit-queue@webkit.org [Mon, 29 Aug 2011 22:54:06 +0000 (22:54 +0000)]
Speed up texImage from BGRA
https://bugs.webkit.org/show_bug.cgi?id=66884

Patch by John Bauman <jbauman@chromium.org> on 2011-08-29
Reviewed by Kenneth Russell.

BGRA input is common coming from skia, so optimize BGRA->RGBA
conversion and also avoid the pointless RGBA to RGBA conversion.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore::doUnpackingAndPacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix path to style sheet in fast/events/constructors/event-constructors.html.
weinig@apple.com [Mon, 29 Aug 2011 22:53:05 +0000 (22:53 +0000)]
Fix path to style sheet in fast/events/constructors/event-constructors.html.

Reviewed by Gavin Barraclough.

* fast/events/constructors/event-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
mdelaney@apple.com [Mon, 29 Aug 2011 22:52:36 +0000 (22:52 +0000)]
[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
https://bugs.webkit.org/show_bug.cgi?id=67099

Reviewed by Simon Fraser.

No new tests. Testing the "fallback to old path" behavior is not easily testable.

* platform/graphics/cg/ImageBufferCG.cpp: Rearranged backing store creation to fall back to
  old path if IOSurface creation path fails.
(WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate results for fast/files/create-blob-url-crash.html to match
weinig@apple.com [Mon, 29 Aug 2011 22:51:21 +0000 (22:51 +0000)]
Update results for fast/files/create-blob-url-crash.html to match
exception text.

* fast/files/create-blob-url-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnly enable font smoothing as requested (Skia on Mac)
caryclark@google.com [Mon, 29 Aug 2011 21:57:09 +0000 (21:57 +0000)]
Only enable font smoothing as requested (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=67143

This adjusts LayoutTest pixel output to more closely
match other platforms.

Reviewed by Kenneth Russell.

No new tests. This platform is not yet enabled.

* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
LCD text was always enabled to test the code path. With this change,
it is only enabled when instructed by the font state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test_expectation.txt typo.
levin@chromium.org [Mon, 29 Aug 2011 21:47:48 +0000 (21:47 +0000)]
Fix test_expectation.txt typo.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate test expections due to r94006 and r93978.
levin@chromium.org [Mon, 29 Aug 2011 21:36:56 +0000 (21:36 +0000)]
Update test expections due to r94006 and r93978.

* platform/chromium/test_expectations.txt: Add failing test due to r93978.
* platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt: Change to use of dfn tag and
  behavior change in r94006.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure in RenderLayer::computeRepaintRects when scrolling
jchaffraix@webkit.org [Mon, 29 Aug 2011 21:32:06 +0000 (21:32 +0000)]
Assertion failure in RenderLayer::computeRepaintRects when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67140

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/scroll-fixed-layer-with-no-visible-content.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeRepaintRects): Fixed style after r93837.

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Tweaked the code
to bail early if our layer has no visible content. This avoids the ASSERT
and also makes sense as we shouldn't repaint / update empty layers.

LayoutTests:

This test checks that a fixed element with no visible content does not ASSERT and
renders properly.

* fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
* fast/repaint/scroll-fixed-layer-with-no-visible-content.html: Added.
* platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement WebVTT Cue Text Parsing rules and DOM construction
commit-queue@webkit.org [Mon, 29 Aug 2011 20:47:06 +0000 (20:47 +0000)]
Implement WebVTT Cue Text Parsing rules and DOM construction
https://bugs.webkit.org/show_bug.cgi?id=64132

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-29
Reviewed by Adam Barth.

Tests in media/track, particularly track-webvtt-tc[022 - 028]*.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* html/TextTrackCue.cpp:
* html/TextTrackCue.h:
* platform/track/CueParser.cpp:
* platform/track/CueParser.h:
* platform/track/WebVTTParser.cpp:
* platform/track/WebVTTParser.h:
* platform/track/WebVTTToken.h: Added.
* platform/track/WebVTTTokenizer.cpp: Added.
* platform/track/WebVTTTokenizer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd parsing support for extended attributes on IDL constants
paroga@webkit.org [Mon, 29 Aug 2011 20:32:32 +0000 (20:32 +0000)]
Add parsing support for extended attributes on IDL constants
https://bugs.webkit.org/show_bug.cgi?id=65046

Reviewed by Brent Fulgham.

With support for extended attributes on constants we can
replace some preprocessor lines from the IDL files with
the corresponding [Conditional=XXX] later.
Using the preprocessor causes much pain on native windows.

CodeGenerator support will be added in separate patches.

* bindings/scripts/IDLParser.pm:
* bindings/scripts/IDLStructure.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlV...
rniwa@webkit.org [Mon, 29 Aug 2011 20:18:46 +0000 (20:18 +0000)]
Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
https://bugs.webkit.org/show_bug.cgi?id=67141

Reviewed by Eric Seidel.

No new tests since this is a refactoring.

* dom/Element.h: Removed formControlValueMatchesRenderer and setFormControlValueMatchesRenderer.
* html/HTMLInputElement.cpp: Removed notifyFormStateChanged.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateValue): Calls notifyFormStateChanged; modifies m_wasModifiedByUser.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls notifyFormStateChanged; also renamed value to newValue
to avoid the conflict with value().
* html/HTMLTextAreaElement.h: Made m_wasModifiedByUser mutable.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::notifyFormStateChanged): Extracted from notifyFormStateChanged in
HTMLInputElement.cpp and HTMLTextAreaElement.cpp.
* html/HTMLTextFormControlElement.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setInnerTextValue): Calls setFormControlValueMatchesRenderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSmall fix in chromium port of new-run-webkit-tests.
commit-queue@webkit.org [Mon, 29 Aug 2011 20:16:50 +0000 (20:16 +0000)]
Small fix in chromium port of new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=67078

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-29
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r93987, r93992, r93995, r93998, and
commit-queue@webkit.org [Mon, 29 Aug 2011 20:09:45 +0000 (20:09 +0000)]
Unreviewed, rolling out r93987, r93992, r93995, r93998, and
r93999.
http://trac.webkit.org/changeset/93987
http://trac.webkit.org/changeset/93992
http://trac.webkit.org/changeset/93995
http://trac.webkit.org/changeset/93998
http://trac.webkit.org/changeset/93999
https://bugs.webkit.org/show_bug.cgi?id=67147

Many failing tests (Requested by ap on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-29

Source/WebCore:

* WebCore.exp.in:
* platform/mac/CookieJar.mm:
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/CookieStorage.h:
* platform/network/ResourceHandle.cpp:
(WebCore::privateStorageSession):
(WebCore::privateBrowsingStorageSessionIdentifierBase):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):
* platform/network/ResourceHandle.h:
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::privateBrowsingCookieStorage):
(WebCore::defaultSessionCookieStorage):
(WebCore::defaultCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
(WebCore::ResourceHandle::currentStorageSession):
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):
* platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

Source/WebKit/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

* WebCookieManagerCFNet.cpp:
(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):
* WebView.cpp:
(updateSharedSettingsFromPreferencesIfNeeded):

Source/WebKit2:

* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAs per HTML specification, default font style of dfn tag should be italic.
commit-queue@webkit.org [Mon, 29 Aug 2011 20:06:52 +0000 (20:06 +0000)]
As per HTML specification, default font style of dfn tag should be italic.
https://bugs.webkit.org/show_bug.cgi?id=56670

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-29
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/dfn-default-font-style.html

* css/html.css:
(i, cite, em, var, address, dfn):

LayoutTests:

* fast/css/dfn-default-font-style-expected.txt: Added.
* fast/css/dfn-default-font-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConsider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValu...
paroga@webkit.org [Mon, 29 Aug 2011 20:03:33 +0000 (20:03 +0000)]
Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
https://bugs.webkit.org/show_bug.cgi?id=65040

Reviewed by Brent Fulgham.

JSValueToNative and NativeToJSValue add additional include statements
to the implementation and need to handle the Conditional attribute from
the IDL file. The Conditional attribute adds appropriate #if ENABLE()
lines for the preprocessor around the include statements to remove
some unneeded build dependencies.

* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add ability to do static SerializedScriptValue deserialization
commit-queue@webkit.org [Mon, 29 Aug 2011 19:35:08 +0000 (19:35 +0000)]
[Chromium] Add ability to do static SerializedScriptValue deserialization
https://bugs.webkit.org/show_bug.cgi?id=66877

Patch by Greg Billock <gbillock@google.com> on 2011-08-29
Reviewed by Darin Fisher.

* public/WebSerializedScriptValue.h:
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::deserialize):
(WebKit::WebSerializedScriptValue::serialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
japhet@chromium.org [Mon, 29 Aug 2011 19:26:46 +0000 (19:26 +0000)]
Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
This will be needed in order for DocumentThreadableLoader to become a CachedResourceClient.
https://bugs.webkit.org/show_bug.cgi?id=66018

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
       (WebCore::CachedResource::load):
(WebCore::CachedResource::setResourceLoaderOptions):
(WebCore::CachedResource::sendResourceLoadCallbacks):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):
* loader/cache/CachedResourceRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix failures when FFT size is changed.
commit-queue@webkit.org [Mon, 29 Aug 2011 19:23:00 +0000 (19:23 +0000)]
Source/WebCore: Fix failures when FFT size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

Test: webaudio/fft-sizing.html

* webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
(WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.
* webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).

LayoutTests: Fix failures when FFT array size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916

Patch by Chris Palmer <palmer@google.com> on 2011-08-29
Reviewed by Kenneth Russell.

* webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
* webaudio/realtimeanalyser-fft-sizing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in InlineBox::deleteLine due to accessing removed
inferno@chromium.org [Mon, 29 Aug 2011 19:19:52 +0000 (19:19 +0000)]
Crash in InlineBox::deleteLine due to accessing removed
renderer.
https://bugs.webkit.org/show_bug.cgi?id=66015

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/line-layout/inline-box-wrapper-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox): Make sure that the
previous inline box wrapper is destroyed properly, before
setting a new one.

LayoutTests:

* fast/block/line-layout/inline-box-wrapper-crash-expected.txt: Added.
* fast/block/line-layout/inline-box-wrapper-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Xan Lopez.
mrobinson@webkit.org [Mon, 29 Aug 2011 19:19:02 +0000 (19:19 +0000)]
Reviewed by Xan Lopez.

[GTK] Build WebKit2 unconditionally
https://bugs.webkit.org/show_bug.cgi?id=62749

Build WebKit2 by default. This will make the bots build it and catch
build errors when they occur.

* GNUmakefile.am: Enable WebKit2 by default, but remove references to the WebKit2
PC file, which should not be shipped until WebKit2 is actually shipped officially.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Windows build fix.
ap@apple.com [Mon, 29 Aug 2011 19:07:27 +0000 (19:07 +0000)]
    Windows build fix.

WebKit/win:
        * WebView.cpp:
        (updateSharedSettingsFromPreferencesIfNeeded):
        Updated for new function name and signature: currentCFHTTPCookieStorage().

WebKit2:
        * WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
        (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
        (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
        Updated for new function name and signature: currentCFHTTPCookieStorage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Lion build fix.
ap@apple.com [Mon, 29 Aug 2011 18:59:15 +0000 (18:59 +0000)]
    Lion build fix.

        * WebCore.exp.in: We have different definitions of CFURLStorageSessionRef on different versions
        of Mac OS X, and need separate exports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 29 Aug 2011 18:54:44 +0000 (18:54 +0000)]
2011-08-29  Chris Marrin  <cmarrin@apple.com>

        Fixing LayoutTests broken by http://trac.webkit.org/changeset/93980

        Unreviewed.

        Add Mac specific tests to take into account new requestAnimationFrame functionality

        * platform/mac/fast/dom/Window/window-properties-expected.txt: Added.
        * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Added.
        * platform/mac/fast/dom/prototype-inheritance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement -webkit-flex-pack for horizontal flexboxen
tony@chromium.org [Mon, 29 Aug 2011 18:53:54 +0000 (18:53 +0000)]
Implement -webkit-flex-pack for horizontal flexboxen
https://bugs.webkit.org/show_bug.cgi?id=66898

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/004.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::hasPackingSpace):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal):

LayoutTests:

* css3/flexbox/004-expected.txt: Added.
* css3/flexbox/004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Windows build fix.
ap@apple.com [Mon, 29 Aug 2011 18:46:30 +0000 (18:46 +0000)]
    Windows build fix.

        * platform/network/cf/CookieJarCFNet.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        (WebCore::getHostnamesWithCookies):
        (WebCore::deleteCookiesForHostname):
        (WebCore::deleteAllCookies):
        Updated for new function name and signature: currentCFHTTPCookieStorage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate tests after landing Event constructors.
weinig@apple.com [Mon, 29 Aug 2011 18:46:28 +0000 (18:46 +0000)]
Update tests after landing Event constructors.

Reviewed by Anders Carlsson.

* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
senorblanco@chromium.org [Mon, 29 Aug 2011 18:45:22 +0000 (18:45 +0000)]
Unreviewed gardening.

Mark test fast/canvas/setWidthResetAfterForcedRender.html as failing
after r93988.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Mac build fix.
ap@apple.com [Mon, 29 Aug 2011 18:34:21 +0000 (18:34 +0000)]
    Mac build fix.

        * platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r93990.
andreas.kling@nokia.com [Mon, 29 Aug 2011 18:31:27 +0000 (18:31 +0000)]
Unreviewed build fix after r93990.

* wtf/HashTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoViewing a post on reddit.com wastes a lot of memory on event listeners.
andreas.kling@nokia.com [Mon, 29 Aug 2011 18:24:18 +0000 (18:24 +0000)]
Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add a minimum table size to the HashTraits, instead of having it hard coded.
The default value remains at 64, but can now be specialized.

* runtime/StructureTransitionTable.h:
* wtf/HashTable.h:
(WTF::HashTable::shouldShrink):
(WTF::::expand):
(WTF::::checkTableConsistencyExceptSize):
* wtf/HashTraits.h:

Source/WebCore:

Specialize the HashMap used to store registered listeners on an EventTarget
to have a minimum size of 32 (rather than the default 64.)
It's very rare for pages to register listeners for so many different events
and this cuts memory consumption in half for the common case.

As an example, for a typical post on the reddit.com front page,
this reduces memory used by ~700kB on 64-bit.

* dom/EventTarget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTemporary suppression for new test added in r93982.
levin@chromium.org [Mon, 29 Aug 2011 18:22:44 +0000 (18:22 +0000)]
Temporary suppression for new test added in r93982.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer
senorblanco@chromium.org [Mon, 29 Aug 2011 18:16:32 +0000 (18:16 +0000)]
Skia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=67050

Reviewed by Kenneth Russell.

Covered by existing tests.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::drawsContent):
Construct Canvas2DLayerChromium with a GraphicsContext3D, not a
DrawingBuffer.
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
Flush the GrContext and GraphicsContext3D on compositor update.
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
* platform/graphics/chromium/CanvasLayerChromium.h:
Put textureId() back on the base class (CanvasLayerChromium) and
de-virtualize it.
(WebCore::CanvasLayerChromium::textureId):
(WebCore::CanvasLayerChromium::setTextureId):
Move m_textureId from WebGLLayerChromium, since canvas2D now uses
it too.  Provide getters and setters.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
Remove all Canvas2D-related calls from DrawingBuffer.
(WebCore::DrawingBuffer::publishToPlatformLayer):
Remove GrContext::flush call, since it's now handled by the platform layer.
(WebCore::DrawingBuffer::platformLayer):
Return NULL for now (WebGL may rescussitate this later).
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
Remove a useless #include.
* platform/graphics/chromium/ImageBufferDataSkia.h:
Add ownership of the Canvas2DLayerChromium.
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.h:
Remove all texture ID stuff (now on base class).
* platform/graphics/gpu/DrawingBuffer.h:
Remove Canvas2DLayerChromium and all Ganesh datatypes from
DrawingBuffer, since it's no longer used by canvas2D.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
On accelerated ImageBuffer creation, create a GrTexture instead of a
DrawingBuffer.  If all is cool, create and set the SkGpuDevice here,
and create a Canvas2DLayerChromium platform layer.
(WebCore::ImageBuffer::platformLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setGraphicsContext3D):
* platform/graphics/skia/PlatformContextSkia.h:
Remove all GrContext creation and DrawingBuffer "scraping" from
PlatformContextSkia::setGraphicsContext3D().  This is handled in
the ImageBuffer constructor instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago DumpRenderTree should begin each test with an empty cookie store
ap@apple.com [Mon, 29 Aug 2011 18:15:38 +0000 (18:15 +0000)]
    DumpRenderTree should begin each test with an empty cookie store
        https://bugs.webkit.org/show_bug.cgi?id=63545
        <rdar://problem/5666907>

        Reviewed by Darin Adler.

        Use a clean CFURLStorageSession when this functionality is available.

        * WebCore.exp.in: Added exports

        * platform/mac/CookieJar.mm:
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::setCookies):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        Updated for privateBrowsingCookieStorage->currentCFHTTPCookieStorage change.

        * platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.

        * platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp.
        This file contains cross platform functionality, and we no longer need to put code in it to
        share it between Mac and Windows.

        * platform/network/ResourceHandle.h: Expose methods to manipulate default session on Mac, too.

        * platform/network/cf/CookieStorageCFNet.cpp:
        (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API.
        (WebCore::overrideCookieStorage): Ditto.
        (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable,
        unless it has been overridden on Windows. We can always get it from a session.
        (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just
        use private session's storage. Note that Mac has a separate code path for OS versions that
        don't support sessions.

        * platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change.
        (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK),
        as this function is also used with NSURLConnection when sessions are enabled.
        (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session
        is now supported on Mac, too.
        (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK).
        (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer
        adopt the session, because nothing in method name says that it will steal a reference from
        the caller.
        (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK).
        (WebCore::privateStorageSession): Moved from ResourceHandle.cpp.
        (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.

        * platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
        We no longer store a reference to cookie storage in a static variable, so nothing to do here.
        On older OS versiosn, we still need to enable legacy private browsing mode.

        * platform/network/mac/ResourceHandleMac.mm: (WebCore::shouldRelaxThirdPartyCookiePolicy):
        Updated to use the new currentCFHTTPCookieStorage function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agopostMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
levin@chromium.org [Mon, 29 Aug 2011 17:57:55 +0000 (17:57 +0000)]
postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
https://bugs.webkit.org/show_bug.cgi?id=66713

Reviewed by Dmitry Titov.

Source/WebCore:

See http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#posting-messages for postMessage

* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::getMessagePortArray):
* dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentanglePorts):

LayoutTests:

* fast/events/message-port-clone-expected.txt: Output changed from INVALID_STATE_ERR to DATA_CLONE_ERR.
* fast/events/message-port-multi-expected.txt: Ditto.
* fast/workers/worker-context-multi-port-expected.txt:  Ditto.
* fast/workers/worker-multi-port-expected.txt:  Ditto.
* platform/chromium-win/fast/events/message-port-multi-expected.txt: Ditto.
* platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Ditto.
* platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure in WebCore::RenderFlow::rightmostPosition
jchaffraix@webkit.org [Mon, 29 Aug 2011 17:31:52 +0000 (17:31 +0000)]
Assertion failure in WebCore::RenderFlow::rightmostPosition
https://bugs.webkit.org/show_bug.cgi?id=12085

Reviewed by Alexey Proskuryakov.

The bug got solved. Landed the test to avoid regressing.

* fast/css/assert-marquee-not-last-element-expected.txt: Added.
* fast/css/assert-marquee-not-last-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 17:30:38 +0000 (17:30 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.

        * platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocanvas arc() missing line to start of arc if swing is zero
commit-queue@webkit.org [Mon, 29 Aug 2011 17:14:57 +0000 (17:14 +0000)]
canvas arc() missing line to start of arc if swing is zero
https://bugs.webkit.org/show_bug.cgi?id=55696

Source/WebCore:

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Test: fast/canvas/canvas-arc-zero-lineto.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::arc):

LayoutTests:

LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html misinterprets pruning requirement
https://bugs.webkit.org/show_bug.cgi?id=66832

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-29
Reviewed by Andreas Kling.

Update to 2d.path.stroke.prune.arc.html was reviewed by Philip Taylor and will be part of the
next update to http://philip.html5.org/tests/canvas/suite/tests/2d.path.stroke.prune.arc.html

* canvas/philip/tests/2d.path.stroke.prune.arc.html:
* fast/canvas/canvas-arc-zero-lineto-expected.txt: Added.
* fast/canvas/canvas-arc-zero-lineto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 29 Aug 2011 17:12:55 +0000 (17:12 +0000)]
2011-08-29  Chris Marrin  <cmarrin@apple.com>

        Fixed a build problem caused by http://trac.webkit.org/changeset/93980

        Unreviewed.

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[mac] requestAnimationFrame support for mac port
cmarrin@apple.com [Mon, 29 Aug 2011 16:38:56 +0000 (16:38 +0000)]
[mac] requestAnimationFrame support for mac port
https://bugs.webkit.org/show_bug.cgi?id=59146

Reviewed by Simon Fraser.

Source/WebCore:

Enable REQUEST_ANIMATION_FRAME logic and add ScriptedAnimationController
to build. Added JavaScript support for Mac, too.

* CodeGenerators.pri:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSRequestAnimationFrameCallbackCustom.cpp: Added.
(WebCore::JSRequestAnimationFrameCallback::handleEvent):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
* dom/RequestAnimationFrameCallback.idl:

Source/WebKit/mac:

Implement requestAnimationFrame for WebKit. Add a
CFRunLoopObserver to WebView, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

* Configurations/FeatureDefines.xcconfig:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scheduleAnimation):
* WebView/WebView.mm:
(-[WebView _close]):
(-[WebView _unscheduleAnimation]):
(-[WebView _scheduleCompositingLayerSync]):
(requestAnimationFrameRunLoopObserverCallback):
(-[WebView _scheduleAnimation]):
* WebView/WebViewData.h:
* WebView/WebViewInternal.h:

Source/WebKit2:

Implement requestAnimationFrame for WebKit2. Add a
CFRunLoopObserver to WebPage, which runs just before
the syncCompositingState RLO and calls into the
ScriptedAnimationController if scheduleAnimation() has
been called.

* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scheduleAnimation):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::requestAnimationFrameRunLoopObserverCallback):
(WebKit::WebPage::scheduleAnimation):
(WebKit::WebPage::unscheduleAnimation):
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.cpp:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

Tools:

Add support for request-animation-callback flag

* Scripts/build-webkit:

LayoutTests:

Enable requestAnimationFrame tests for Mac. Tests were also
modified to work on Mac. Before the tests would assume the
requestAnimationFrame callbacks would be called by calling
LayoutTestController.display(). This is not a valid assumption
for Mac, since it skips display() if nothing was dirty.

Tests were changed to use timeouts to wait for callbacks and
ensure they get called. Also added more positive indications
that test failed or succeeded, rather than relying on the lack
of an error message to indicate success.

* fast/animation/request-animation-frame-cancel-expected.txt:
* fast/animation/request-animation-frame-cancel.html:
* fast/animation/request-animation-frame-cancel2-expected.txt:
* fast/animation/request-animation-frame-cancel2.html:
* fast/animation/request-animation-frame-display.html:
* fast/animation/request-animation-frame-during-modal-expected.txt:
* fast/animation/request-animation-frame-during-modal.html:
* fast/animation/request-animation-frame-timestamps.html:
* fast/animation/request-animation-frame-within-callback.html:
* fast/animation/request-animation-frame.html:
* fast/animation/script-tests/request-animation-frame-cancel.js:
(window):
(if):
* fast/animation/script-tests/request-animation-frame-cancel2.js:
(if):
* fast/animation/script-tests/request-animation-frame-display.js:
(if):
* fast/animation/script-tests/request-animation-frame-timestamps.js:
(var):
* fast/animation/script-tests/request-animation-frame-within-callback.js:
* fast/animation/script-tests/request-animation-frame.js:
(if):
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API define in WebKit2
commit-queue@webkit.org [Mon, 29 Aug 2011 16:07:29 +0000 (16:07 +0000)]
[Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API define in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67123

We could simply use the defines already in place for this.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-08-29
Reviewed by Andreas Kling.

* WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: <button hidden>..</button> has a different computed "display" value...
apavlov@chromium.org [Mon, 29 Aug 2011 15:15:30 +0000 (15:15 +0000)]
Web Inspector: <button hidden>..</button> has a different computed "display" value than "none"
https://bugs.webkit.org/show_bug.cgi?id=67124

Source/WebCore:

Attribute styles have a higher priority than user agent styles and thus should be rendered above them.

Reviewed by Yury Semikhatsky.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-computed-trace.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.
podivilov@chromium.org [Mon, 29 Aug 2011 15:14:07 +0000 (15:14 +0000)]
Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=66769

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresenationCallFrame.prototype.sourceLine.didGetUILocation):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.UILocation):

LayoutTests:

* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] The square-button-appearance test is wrong
loki@webkit.org [Mon, 29 Aug 2011 14:55:40 +0000 (14:55 +0000)]
[Qt] The square-button-appearance test is wrong
https://bugs.webkit.org/show_bug.cgi?id=67128

Unreviewed skip until square-button fix on qt-arm.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Zsolt Fehér <feherzs@inf.u-szeged.hu>
loki@webkit.org [Mon, 29 Aug 2011 14:14:45 +0000 (14:14 +0000)]
2011-08-29 Zsolt Fehér <feherzs@inf.u-szeged.hu>

        Unreviewed Qt gardening.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: cached permanent redirects don't show redirect code and text in Networ...
loislo@chromium.org [Mon, 29 Aug 2011 14:11:32 +0000 (14:11 +0000)]
Web Inspector: cached permanent redirects don't show redirect code and text in Network panel.
https://bugs.webkit.org/show_bug.cgi?id=67126

Reviewed by Yury Semikhatsky.

* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 12:34:22 +0000 (12:34 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: extract FormattedContentProvider from RawSourceCode.
podivilov@chromium.org [Mon, 29 Aug 2011 12:19:39 +0000 (12:19 +0000)]
Web Inspector: extract FormattedContentProvider from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66938

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 12:03:57 +0000 (12:03 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark fast/dom/dom-constructors.html as TEXT in chromium.

        * platform/chromium/fast/dom/dom-constructors-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 11:45:15 +0000 (11:45 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix event-constructors.html test.
        https://bugs.webkit.org/show_bug.cgi?id=63878

        * fast/events/constructors/event-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: link UISourceCode to RawSourceCode.
podivilov@chromium.org [Mon, 29 Aug 2011 11:36:57 +0000 (11:36 +0000)]
Web Inspector: link UISourceCode to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=66944

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get rawSourceCode):

LayoutTests:

* inspector/debugger/ui-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Skip failing and flaky results after r93937
zoltan@webkit.org [Mon, 29 Aug 2011 11:19:10 +0000 (11:19 +0000)]
[Qt] Skip failing and flaky results after r93937
https://bugs.webkit.org/show_bug.cgi?id=67118

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r93637) Build break because header file is missing.
ryuan.choi@samsung.com [Mon, 29 Aug 2011 09:55:30 +0000 (09:55 +0000)]
REGRESSION(r93637) Build break because header file is missing.
https://bugs.webkit.org/show_bug.cgi?id=67113

Unreviewed build fix after r93637.

* CMakeListsEfl.txt: Add ewk_js.h in EWebKit_HEADERS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 09:35:51 +0000 (09:35 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark overflow-scroll-overlap.html as flaky on chromium gpu.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 09:17:19 +0000 (09:17 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, add new chromium mac cg baseline for square-button-appearance added in r93953.

        * platform/chromium-cg-mac-leopard/fast/css/square-button-appearance-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 09:09:16 +0000 (09:09 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update chromium expectations. Mark frame-removed-during-resize.html and scrollbar-buttons.html
        as crashing on win linux debug only.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove RawSourceCode.setFormatted.
podivilov@chromium.org [Mon, 29 Aug 2011 09:06:43 +0000 (09:06 +0000)]
Web Inspector: remove RawSourceCode.setFormatted.
https://bugs.webkit.org/show_bug.cgi?id=66947

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):

LayoutTests:

* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoin...
podivilov@chromium.org [Mon, 29 Aug 2011 08:53:30 +0000 (08:53 +0000)]
Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.
https://bugs.webkit.org/show_bug.cgi?id=67030

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/set-breakpoint.html

* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

LayoutTests:

* inspector/debugger/set-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint-expected.txt.
* inspector/debugger/set-breakpoint.html: Renamed from LayoutTests/inspector/debugger/debugger-pause-on-breakpoint.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 08:37:24 +0000 (08:37 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix event-constructors.html test.
        https://bugs.webkit.org/show_bug.cgi?id=63878

        * fast/events/constructors/event-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WK2] Compilation error in WebKit2 GTK - Revision 93953
commit-queue@webkit.org [Mon, 29 Aug 2011 08:22:07 +0000 (08:22 +0000)]
[GTK][WK2] Compilation error in WebKit2 GTK - Revision 93953
https://bugs.webkit.org/show_bug.cgi?id=67111

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-08-29
Reviewed by Martin Robinson.

WebKit2 GTK build error.

* WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
Include <WebCore/ResourceError.h> explicitly to remove WebCore::ResourceError
inclusion error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 08:10:30 +0000 (08:10 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark event-constructors.html as failing in chromium.
        https://bugs.webkit.org/show_bug.cgi?id=66756

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 07:40:27 +0000 (07:40 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, adding custom expectation for dom-constructors test in chromium
        until bug 66756 is resolved.
        https://bugs.webkit.org/show_bug.cgi?id=66756

        * platform/chromium/fast/dom/dom-constructors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/canvas/shadow-offset-*.html fail on Leopard/Snow Leopard when removing the work...
mdelaney@apple.com [Mon, 29 Aug 2011 07:34:19 +0000 (07:34 +0000)]
fast/canvas/shadow-offset-*.html fail on Leopard/Snow Leopard when removing the work around for <rdar://problem/5539388>.
https://bugs.webkit.org/show_bug.cgi?id=67107

Reviewed by David Levin.

No new tests. Effectively reverting the change from https://bugs.webkit.org/show_bug.cgi?id=67052 for Leopard and SL
because it caused test regressions on Leopard and SL, but not Lion.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 29 Aug 2011 07:16:18 +0000 (07:16 +0000)]
2011-08-29  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark scrollbars/scrollbar-buttons.html as crashing in chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed minimal-build buildfix after r93937.
zherczeg@webkit.org [Mon, 29 Aug 2011 07:07:27 +0000 (07:07 +0000)]
[Qt] Unreviewed minimal-build buildfix after r93937.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintInnerSpinButton):
* platform/qt/RenderThemeQt.h:

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-08-29

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium Win: Setting square-button appearance reaches NOTREACHED
keishi@webkit.org [Mon, 29 Aug 2011 03:49:03 +0000 (03:49 +0000)]
Chromium Win: Setting square-button appearance reaches NOTREACHED
https://bugs.webkit.org/show_bug.cgi?id=66918

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/css/square-button-appearance.html

* rendering/RenderThemeChromiumWin.cpp:
(WebCore::supportsFocus): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::supportsFocusRing): Add case for SquareButtonPart.
(WebCore::RenderThemeChromiumWin::getThemeData): Add case for SquareButtonPart.

LayoutTests:

* fast/css/square-button-appearance-expected.txt: Added.
* fast/css/square-button-appearance.html: Added. Test rendering of square-button appearance.
* platform/chromium-linux/fast/css/square-button-appearance-expected.png: Added.
* platform/chromium-win/fast/css/square-button-appearance-expected.png: Added.
* platform/gtk/test_expectations.txt: Added this test as expected to fail.
* platform/mac/fast/css/square-button-appearance-expected.png: Added.
* platform/qt/test_expectations.txt: Added this test as expected to fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix reference counting of values in CSSSelector.
macpherson@chromium.org [Mon, 29 Aug 2011 00:26:19 +0000 (00:26 +0000)]
Fix reference counting of values in CSSSelector.
https://bugs.webkit.org/show_bug.cgi?id=66452

Reviewed by Darin Adler.

No new tests / no functionality changed.

Call deref when reassigning the value.

* css/CSSSelector.h:
(WebCore::CSSSelector::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for constructor syntax for Events
weinig@apple.com [Sun, 28 Aug 2011 23:58:25 +0000 (23:58 +0000)]
Add support for constructor syntax for Events
https://bugs.webkit.org/show_bug.cgi?id=63878

Reviewed by Oliver Hunt.

Source/WebCore:

Add basic support for Event constructors, starting with just supporting
the constructor for the base Event class and just JSC support.  This lays
the infrastructure for the other events as well.

Test: fast/events/event-constructors.html

* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
Add files.

* bindings/generic/EventConstructors.h: Added.
Add binding agnostic header that defines the Event initializers
using a macro based DSL.

* bindings/js/JSEventConstructors.cpp: Added.
(WebCore::convertValue):
(WebCore::tryGetProperty):
(WebCore::constructJSEventWithInitializer):
Add JSC implementation of Event initializer DSL.

* dom/Event.cpp:
(WebCore::EventInit::EventInit):
(WebCore::Event::Event):
* dom/Event.h:
(WebCore::Event::create):
Add Event initializer interface for base Event.

* dom/Event.idl:
Mark Event as having a custom constructor function.

LayoutTests:

Add basic test for Event constructors.

* fast/events/constructors/event-constructors-expected.txt: Added.
* fast/events/constructors/event-constructors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build error when compiling with MinGW-w64 by disabling JIT
commit-queue@webkit.org [Sun, 28 Aug 2011 19:24:40 +0000 (19:24 +0000)]
Fix build error when compiling with MinGW-w64 by disabling JIT
on Windows 64-bit
https://bugs.webkit.org/show_bug.cgi?id=61235

Patch by Jonathan Liu <net147@gmail.com> on 2011-08-28
Reviewed by Gavin Barraclough.

The fixed mmap executable allocator for JIT on x86_64 requires
sys/mman.h which is not available on Windows.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed build fix.
kbalazs@webkit.org [Sun, 28 Aug 2011 19:14:17 +0000 (19:14 +0000)]
[Qt][WK2] Unreviewed build fix.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init): Initialize the WKPageUIClient with memset
to avoid missing initializer warning. The missing initializer is the
result of using a version 0 WKPageUIClient while it has newer version (1).
We have nothing to do with the callbacks in the new version so I voted
for memset.
* WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Include ResourceError.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't rely on hardcoded position in absolute-appended-to-inline.html
robert@webkit.org [Sat, 27 Aug 2011 22:01:33 +0000 (22:01 +0000)]
Don't rely on hardcoded position in absolute-appended-to-inline.html

Allow test added in r93944 to pass on platforms other than Chromium-Linux.

Unreviewed, fix on r93944.

* fast/block/positioning/absolute-appended-to-inline.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC::Executable is inconsistent about using weak handle finalizers
fpizlo@apple.com [Sat, 27 Aug 2011 21:49:46 +0000 (21:49 +0000)]
JSC::Executable is inconsistent about using weak handle finalizers
and destructors for releasing memory
https://bugs.webkit.org/show_bug.cgi?id=67072

Reviewed by Darin Adler.

Moved more of the destruction of Executable state into the finalizer,
which also resulted in an opportunity to mostly combine this with
discardCode().  This also means that the finalizer is now enabled even
when the JIT is turned off.  This is performance neutral on SunSpider,
V8, and Kraken.

* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::ExecutableFinalizer::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCode):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a build bot for Chromium with OS(ANDROID)
commit-queue@webkit.org [Sat, 27 Aug 2011 21:31:09 +0000 (21:31 +0000)]
Add a build bot for Chromium with OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66687

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-27
Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
commit-queue@webkit.org [Sat, 27 Aug 2011 21:12:25 +0000 (21:12 +0000)]
SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
https://bugs.webkit.org/show_bug.cgi?id=67090

Patch by Andreas Kling <kling@webkit.org> on 2011-08-27
Reviewed by Darin Adler.

* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::getColumnText): Use sqlite3_column_bytes16()
to get the length of the column text without looking for the null terminator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe child div element with position:absolute will overlap with its parent div when...
robert@webkit.org [Sat, 27 Aug 2011 21:03:41 +0000 (21:03 +0000)]
The child div element with position:absolute will overlap with its parent div when a 'break' element is present in between
https://bugs.webkit.org/show_bug.cgi?id=21934

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/block/positioning/absolute-appended-to-inline.html

Appending a positioned child node to an inline flow should dirty the lines in the flow, just as
inserting a positioned child node does. Treating an appended and inserted node differently meant that updating the display type
from 'none' to 'block' for the following markup would result in the div getting positioned correctly under
the line block:

    <div><a onMouseOver="mopen()">Hover</a><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"><br></div></div>

but this would not happen with the following markup (the <br> is before the child div rather than after it):

    <div><a onMouseOver="mopen()">Hover</a><br><div style="display:none; position:absolute; background:#4682b4; height:10px; width:20px"></div></div>

This problem is specific to cases where an object is appended to a line block whose last child is a <br>. When the line is relaid out after appending
the positioned object the last line in the line block is always considered dirty unless it broke cleanly (ie. with a <br>, see RenderBlock::determineStartPosition),
So in the second case above, the clean break and failing to dirty any lines in the block when appending the object means that the line block doesn't get relaid out
to position the new positioned object relative to its containing line block.

So the change could special-case appending a node when the previous sibling isBR(), but it seems just as well to behave the same way as insertChildNode().

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
    Call dirtyLinesFromChangedChild() if the child is positioned, just like insertChildNode().

LayoutTests:

* fast/block/positioning/absolute-appended-to-inline-expected.txt: Added.
* fast/block/positioning/absolute-appended-to-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93944 268f45cc-cd09-0410-ab3c-d52691b4dbfc