WebKit-https.git
14 years ago2008-11-05 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Wed, 5 Nov 2008 09:07:52 +0000 (09:07 +0000)]
2008-11-05  Pierre-Olivier Latour  <pol@apple.com>

        Rubber-stamped by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=21821

        Imported more image bases for a representative set of pixel tests in order to
        fully validate latest DRT and test script changes. These results were generated
        by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
        QuickTime 7.5.5.

        (file listing elided)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Tiger build fix
mitz@apple.com [Wed, 5 Nov 2008 08:45:18 +0000 (08:45 +0000)]
    - Tiger build fix

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView stop]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 01:44:47 +0000 (01:44 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Don't leak the CALayer.

        * Plugins/WebBaseNetscapePluginView.h:
        Make the layer a RetainPtr.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):

        (-[WebBaseNetscapePluginView stop]):
        Make sure to clear out the layer here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 00:58:47 +0000 (00:58 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Steve Falkenburg.

        Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
        their movement in the filesystem.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 00:49:41 +0000 (00:49 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore, and remove
        its unused forwarding header in WebKit/mac.

        JavaScriptCore:

        * AllInOneFile.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/dtoa.cpp: Removed.
        * kjs/dtoa.h: Removed.
        * wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
        * wtf/dtoa.h: Copied from kjs/dtoa.h.

        WebCore:

        * ForwardingHeaders/kjs/dtoa.h: Removed.
        * ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
        * css/CSSParser.cpp:
        * platform/text/String.cpp:
        * platform/text/StringImpl.cpp:

        WebKit/mac:

        * ForwardingHeaders/kjs/dtoa.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 00:45:00 +0000 (00:45 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        More cleanup. Make a bunch of instance variables RetainPtrs.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView visibleRect]):
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView sendActivateEvent:]):
        (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
        (-[WebBaseNetscapePluginView stopTimers]):
        (-[WebBaseNetscapePluginView restartTimers]):
        (-[WebBaseNetscapePluginView setHasFocus:]):
        (-[WebBaseNetscapePluginView mouseDown:]):
        (-[WebBaseNetscapePluginView mouseUp:]):
        (-[WebBaseNetscapePluginView mouseEntered:]):
        (-[WebBaseNetscapePluginView mouseExited:]):
        (-[WebBaseNetscapePluginView handleMouseMoved:]):
        (-[WebBaseNetscapePluginView mouseDragged:]):
        (-[WebBaseNetscapePluginView scrollWheel:]):
        (-[WebBaseNetscapePluginView keyUp:]):
        (-[WebBaseNetscapePluginView keyDown:]):
        (-[WebBaseNetscapePluginView flagsChanged:]):
        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        (-[WebBaseNetscapePluginView didStart]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView stop]):
        (-[WebBaseNetscapePluginView dataSource]):
        (-[WebBaseNetscapePluginView pluginPackage]):
        (-[WebBaseNetscapePluginView setPluginPackage:]):
        (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        (-[WebBaseNetscapePluginView fini]):
        (-[WebBaseNetscapePluginView dealloc]):
        (-[WebBaseNetscapePluginView pluginView:receivedError:]):
        (-[WebBaseNetscapePluginView requestWithURLCString:]):
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        (-[WebBaseNetscapePluginView userAgent]):
        (-[WebBaseNetscapePluginView getVariable:value:]):
        (-[WebBaseNetscapePluginView setVariable:value:]):
        (-[WebBaseNetscapePluginView _createPlugin]):
        (-[WebBaseNetscapePluginView _redeliverStream]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Jonathan Haas <myrdred@gmail.com>
pam@chromium.org [Wed, 5 Nov 2008 00:24:44 +0000 (00:24 +0000)]
2008-11-04  Jonathan Haas  <myrdred@gmail.com>

        Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>

        Reviewed by Darin Adler.

        Fixed an issue which could cause memory corruption using ToT libxml.
        See https://bugs.webkit.org/show_bug.cgi?id=15715

        Test: fast/xsl/xslt-nested-stylesheets.xml

        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet
        (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary
        (WebCore::XSLStyleSheet::setParentStyleSheet): Added
        * xml/XSLStyleSheet.h: Added m_parentStyleSheet member

2008-11-04  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Added test for crash resulting from nested stylesheets using certain
        builds of libxml2.  See https://bugs.webkit.org/show_bug.cgi?id=15715 .

        * fast/xsl/resources/xslt-nested-stylesheets0.xsl: Added.
        * fast/xsl/resources/xslt-nested-stylesheets1.xsl: Added.
        * fast/xsl/xslt-nested-stylesheets-expected.txt: Added.
        * fast/xsl/xslt-nested-stylesheets.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 23:44:19 +0000 (23:44 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move kjs/config.h to the top level of JavaScriptCore.

        * GNUmakefile.am:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * config.h: Copied from kjs/config.h.
        * kjs/config.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Nov 2008 23:00:23 +0000 (23:00 +0000)]
2008-11-04  Simon Fraser  <simon.fraser@apple.com>

        Add AccessibilityObject.o to the exclude list for the
        check for global destructors.

        * Scripts/check-for-exit-time-destructors:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Nov 2008 22:40:53 +0000 (22:40 +0000)]
2008-11-04  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Improved buid fix: include MathExtras.h to get roundf on all platforms.

        * platform/graphics/FloatPoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 22:08:44 +0000 (22:08 +0000)]
2008-11-04  Darin Adler  <darin@apple.com>

        * Scripts/check-for-exit-time-destructors: Fix failures seen on the
        bot, but for some reason not on my computer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Tue, 4 Nov 2008 20:55:13 +0000 (20:55 +0000)]
WebCore:

2008-11-04  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Add a simple "visited" method to HistoryItem for use by global history

        * WebCore.base.exp:

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::visited):  Update the title on the item, set last visited time,
          and bump the visit count.  All things that should happen when a url is visited again!
        * history/HistoryItem.h:

WebKit/mac:

2008-11-04  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Cleanup global history a tad.

        Used to _addItemForURL always create a new item and merge it with a previous item if one existed.

        It is more efficient and less complicated to update the previous item if one exists.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]):
        (-[WebHistory _visitedURL:withTitle:]):  Instead of calling the general purpose [WebHistoryPrivate addItem:]
          with a new history item, call the new special purposed visitedURL:withTitle:
        * History/WebHistoryInternal.h:

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _visitedWithTitle:]): Call "visited()" on the WebCore history item with the pertinent info.
        * History/WebHistoryItemInternal.h:

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 4 Nov 2008 20:08:57 +0000 (20:08 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        https://bugs.webkit.org/show_bug.cgi?id=22065

        Only create the plug-in stream loader when the stream is started.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        (WebNetscapePluginStream::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Tue, 4 Nov 2008 19:43:58 +0000 (19:43 +0000)]
2008-11-04  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Build fix. Not reviewed.

        * platform/graphics/FloatPoint.h: include math.h.
        reported by zdobersek in #webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 4 Nov 2008 19:40:56 +0000 (19:40 +0000)]
2008-11-04  Darin Fisher  <darin@chromium.org>

        Reviewed by Anders Carlsson.

        No need to clobber all ResourceRequest fields in FrameLoader::reload()
        https://bugs.webkit.org/show_bug.cgi?id=21949

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::reload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 19:00:58 +0000 (19:00 +0000)]
2008-11-04  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        * storage/Database.cpp:
        (WebCore::databaseVersionKey): Tweaked formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:59:56 +0000 (18:59 +0000)]
2008-11-04  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        * wtf/ThreadingNone.cpp: Tweak formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:58:45 +0000 (18:58 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * WebCore.xcodeproj/project.pbxproj: Added a script
        phase that runs the check-for-exit-time-destructors script.

        * html/HTMLAttributeNames.in: Removed some unused attribute names.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that
        sets the write-only m_pluginPage.
        * html/HTMLEmbedElement.h: Ditto.

        * platform/mac/CursorMac.mm:
        (WebCore::leakNamedCursor): Changed to return a Cursor&.
        (WebCore::pointerCursor): Changed to leak an object to avoid an
        exit-time destructor.
        (WebCore::crossCursor): Ditto.
        (WebCore::handCursor): Ditto.
        (WebCore::moveCursor): Ditto.
        (WebCore::verticalTextCursor): Ditto.
        (WebCore::cellCursor): Ditto.
        (WebCore::contextMenuCursor): Ditto.
        (WebCore::aliasCursor): Ditto.
        (WebCore::zoomInCursor): Ditto.
        (WebCore::zoomOutCursor): Ditto.
        (WebCore::copyCursor): Ditto.
        (WebCore::noneCursor): Ditto.
        (WebCore::progressCursor): Ditto.
        (WebCore::noDropCursor): Ditto.
        (WebCore::notAllowedCursor): Ditto.
        (WebCore::iBeamCursor): Ditto.
        (WebCore::waitCursor): Ditto.
        (WebCore::helpCursor): Ditto.
        (WebCore::eastResizeCursor): Ditto.
        (WebCore::northResizeCursor): Ditto.
        (WebCore::northEastResizeCursor): Ditto.
        (WebCore::northWestResizeCursor): Ditto.
        (WebCore::southResizeCursor): Ditto.
        (WebCore::southEastResizeCursor): Ditto.
        (WebCore::southWestResizeCursor): Ditto.
        (WebCore::westResizeCursor): Ditto.
        (WebCore::northSouthResizeCursor): Ditto.
        (WebCore::eastWestResizeCursor): Ditto.
        (WebCore::northEastSouthWestResizeCursor): Ditto.
        (WebCore::northWestSouthEastResizeCursor): Ditto.
        (WebCore::columnResizeCursor): Ditto.
        (WebCore::rowResizeCursor): Ditto.
        (WebCore::grabCursor): Ditto.
        (WebCore::grabbingCursor): Ditto.

        * storage/Database.cpp:
        (WebCore::guidMutex): Changed to leak an object to avoid an
        exit-time destructor. Also added a comment explaining why it's
        thread safe.
        (WebCore::guidToVersionMap): Ditto.
        (WebCore::guidToDatabaseMap): Ditto.
        (WebCore::Database::databaseInfoTableName): Ditto.
        (WebCore::databaseVersionKey): Ditto.
        (WebCore::Database::getVersionFromDatabase): Ditto.
        (WebCore::Database::setVersionInDatabase): Ditto.
        (WebCore::guidForOriginAndName): Ditto.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::tracker): Ditto.
        (WebCore::notificationMutex): Ditto.
        (WebCore::notificationQueue): Ditto.
        (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Tue, 4 Nov 2008 18:57:53 +0000 (18:57 +0000)]
2008-11-04  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Dan Bernstein.

        - part of https://bugs.webkit.org/show_bug.cgi?id=21821
          Removed pixel results in platform/mac-tiger that were only slightly different
          (within 1% tolerance) from the platform/mac results.
          Removed results in platform/mac-tiger where the results in platform/mac were
          also correct for Tiger.

        (file listing elided)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:57:26 +0000 (18:57 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * WebKit.xcodeproj/project.pbxproj: Added a script
        phase that runs the check-for-exit-time-destructors script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:57:01 +0000 (18:57 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * JavaScriptCore.exp: Changed to export functions rather than
        a global for the atomically initialized static mutex.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added a script
        phase that runs the check-for-exit-time-destructors script.

        * wtf/MainThread.cpp:
        (WTF::mainThreadFunctionQueueMutex): Changed to leak an object
        rather than using an exit time destructor.
        (WTF::functionQueue): Ditto.
        * wtf/unicode/icu/CollatorICU.cpp:
        (WTF::cachedCollatorMutex): Ditto.

        * wtf/Threading.h: Changed other platforms to share the Windows
        approach where the mutex is internal and the functions are exported.
        * wtf/ThreadingGtk.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        * wtf/ThreadingNone.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        * wtf/ThreadingPthreads.cpp:
        (WTF::threadMapMutex): Changed to leak an object rather than using
        an exit time destructor.
        (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        (WTF::threadMap): Changed to leak an object rather than using
        an exit time destructor.
        * wtf/ThreadingQt.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        * wtf/ThreadingWin.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:56:28 +0000 (18:56 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * Scripts/check-for-exit-time-destructors: Added.
        Started as a copy of check-for-global-initializers.

        * Scripts/check-for-global-initializers: Added code to make
        this script rerun any time it's modified, and also to properly
        run again after the first time it reports an error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 4 Nov 2008 18:55:41 +0000 (18:55 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        https://bugs.webkit.org/show_bug.cgi?id=22065

        Remove some old, unused plug-in code.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView setVariable:value:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Nov 2008 18:54:50 +0000 (18:54 +0000)]
2008-11-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=21941

        Rename absolutePosition() to localToAbsolute(), and add the ability
        to optionally take transforms into account (which will eventually be the
        default behavior).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hausmann@webkit.org [Tue, 4 Nov 2008 16:22:05 +0000 (16:22 +0000)]
WebCore:
    2008-11-03  Yael Aharon  <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            Add methods for getting and setting user data on History Item.
            This change is limited to QT port only. Tests were added in
            the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.

            Minor change by Simon: made the functions inline and added a missing
            const.

WebKit/qt:
    2008-10-24  Yael Aharon <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            Add userData() and setUserData() to QWebHistoryItem.
            Add setMaximumItemCount() and maximumItemCount() to QWebHistory.
            Add currentItemIndex() to QWebHistory.

            See also https://bugs.webkit.org/show_bug.cgi?id=21864

            Small cleanup by Simon (docs and forward declaration of QWebHistoryItem in qwebframe.h)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben@apple.com [Tue, 4 Nov 2008 14:15:17 +0000 (14:15 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update
        the location of JSStaticScopeObject.{cpp,h}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 10:59:50 +0000 (10:59 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Alexey Proskuryakov.

        Move AllInOneFile.cpp to the top level of JavaScriptCore.

        * AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
        * GNUmakefile.am:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/AllInOneFile.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 4 Nov 2008 10:46:13 +0000 (10:46 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22030
        Make EventNames usable from multiple threads

        * platform/text/AtomicString.cpp:
        (WebCore::stringTable):
        (WebCore::AtomicString::add):
        (WebCore::AtomicString::remove):
        (WebCore::AtomicString::find):
        (WebCore::AtomicString::init):
        * platform/text/AtomicString.h:
        Atomic string table is now per-thread. Individual strings cannot be shared between threads,
        so global AtomicString constants cannot be used from threads other than the main one.

        * dom/EventNames.cpp:
        (WebCore::EventNames::EventNames):
        (WebCore::eventNames):
        (WebCore::EventNames::init):
        * dom/EventNames.h:
        Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
        eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
        threads.

        * <Many files>: Access event names via eventNames() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 10:40:55 +0000 (10:40 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Alexey Proskuryakov.

        Add NodeInfo.h to the JavaScriptCore Xcode project.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 09:43:49 +0000 (09:43 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Mark Rowe.

        Delete unused forwarding headers.

        WebCore:

        * ForwardingHeaders/kjs/Activation.h: Removed.
        * ForwardingHeaders/kjs/Register.h: Removed.
        * ForwardingHeaders/kjs/RegisterID.h: Removed.

        WebKit/mac:

        * ForwardingHeaders/kjs/string_object.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 08:58:22 +0000 (08:58 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Mark Rowe.

        Remove JavaScriptGlue forwarding headers that are no longer necessary,
        and correct the path of the ExecState.h forwarding header.

        * ForwardingHeaders/kjs: Removed.
        * ForwardingHeaders/kjs/CTI.h: Removed.
        * ForwardingHeaders/kjs/ExecState.h: Removed.
        * ForwardingHeaders/kjs/JSValue.h: Removed.
        * ForwardingHeaders/kjs/PutPropertySlot.h: Removed.
        * ForwardingHeaders/kjs/ustring.h: Removed.
        * ForwardingHeaders/runtime: Added.
        * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 08:07:41 +0000 (08:07 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix stupid typo in previous build fix.

        * bindings/js/JSStorageCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 07:56:20 +0000 (07:56 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the build for all non-Mac platforms.

        * ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
        * ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
        * bindings/js/JSStorageCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 07:33:36 +0000 (07:33 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the wxWindows build.

        * bridge/c/c_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 07:10:41 +0000 (07:10 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Maciej Stachowiak.

        Move more files into the runtime subdirectory of JavaScriptCore.

        JavaScriptCore:

        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSClassRef.cpp:
        * API/OpaqueJSString.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/ArgList.cpp: Removed.
        * kjs/ArgList.h: Removed.
        * kjs/Arguments.cpp: Removed.
        * kjs/Arguments.h: Removed.
        * kjs/BatchedTransitionOptimizer.h: Removed.
        * kjs/CollectorHeapIterator.h: Removed.
        * kjs/CommonIdentifiers.cpp: Removed.
        * kjs/CommonIdentifiers.h: Removed.
        * kjs/ExecState.cpp: Removed.
        * kjs/ExecState.h: Removed.
        * kjs/GetterSetter.cpp: Removed.
        * kjs/GetterSetter.h: Removed.
        * kjs/InitializeThreading.cpp: Removed.
        * kjs/InitializeThreading.h: Removed.
        * kjs/JSActivation.cpp: Removed.
        * kjs/JSActivation.h: Removed.
        * kjs/JSGlobalData.cpp: Removed.
        * kjs/JSGlobalData.h: Removed.
        * kjs/JSLock.cpp: Removed.
        * kjs/JSLock.h: Removed.
        * kjs/JSStaticScopeObject.cpp: Removed.
        * kjs/JSStaticScopeObject.h: Removed.
        * kjs/JSType.h: Removed.
        * kjs/PropertyNameArray.cpp: Removed.
        * kjs/PropertyNameArray.h: Removed.
        * kjs/ScopeChain.cpp: Removed.
        * kjs/ScopeChain.h: Removed.
        * kjs/ScopeChainMark.h: Removed.
        * kjs/SymbolTable.h: Removed.
        * kjs/Tracing.d: Removed.
        * kjs/Tracing.h: Removed.
        * runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
        * runtime/ArgList.h: Copied from kjs/ArgList.h.
        * runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
        * runtime/Arguments.h: Copied from kjs/Arguments.h.
        * runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
        * runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
        * runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
        * runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
        * runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
        * runtime/ExecState.h: Copied from kjs/ExecState.h.
        * runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
        * runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
        * runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
        * runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
        * runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
        * runtime/JSActivation.h: Copied from kjs/JSActivation.h.
        * runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
        * runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
        * runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
        * runtime/JSLock.h: Copied from kjs/JSLock.h.
        * runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
        * runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
        * runtime/JSType.h: Copied from kjs/JSType.h.
        * runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
        * runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
        * runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
        * runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
        * runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
        * runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
        * runtime/Tracing.d: Copied from kjs/Tracing.d.
        * runtime/Tracing.h: Copied from kjs/Tracing.h.

        WebCore:

        * ForwardingHeaders/kjs/ArgList.h: Removed.
        * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
        * ForwardingHeaders/kjs/ExecState.h: Removed.
        * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
        * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * ForwardingHeaders/kjs/SymbolTable.h: Removed.
        * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
        * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
        * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
        * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
        * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
        * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
        * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
        * bindings/js/GCController.cpp:
        * bindings/js/JSCustomPositionCallback.cpp:
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSNodeFilterCondition.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptControllerMac.mm:
        * bindings/objc/WebScriptObject.mm:
        * bridge/NP_jsobject.cpp:
        * bridge/c/c_class.cpp:
        * bridge/c/c_instance.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/c/c_utility.cpp:
        * bridge/jni/jni_class.cpp:
        * bridge/jni/jni_instance.cpp:
        * bridge/jni/jni_jsobject.mm:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jni_runtime.cpp:
        * bridge/jni/jni_runtime.h:
        * bridge/jni/jni_utility.cpp:
        * bridge/npruntime.cpp:
        * bridge/objc/objc_instance.mm:
        * bridge/objc/objc_runtime.mm:
        * bridge/objc/objc_utility.mm:
        * bridge/runtime.cpp:
        * dom/Document.cpp:
        * dom/Node.cpp:
        * dom/NodeFilter.cpp:
        * dom/NodeIterator.cpp:
        * dom/TreeWalker.cpp:
        * history/CachedPage.cpp:
        * inspector/InspectorController.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptDebugServer.cpp:
        * inspector/JavaScriptProfileNode.cpp:
        * loader/FrameLoader.cpp:
        * loader/icon/IconDatabase.cpp:
        * page/Console.cpp:
        * page/Page.cpp:
        * page/mac/FrameMac.mm:
        * plugins/PluginView.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/qt/PluginViewQt.cpp:
        * plugins/win/PluginViewWin.cpp:
        * storage/Database.cpp:
        * xml/XMLHttpRequest.cpp:

        WebKit/gtk:

        * webkit/webkitprivate.cpp:

        WebKit/mac:

        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * ForwardingHeaders/kjs/SymbolTable.h: Removed.
        * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
        * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
        * Misc/WebCoreStatistics.mm:
        * Plugins/WebBaseNetscapePluginStream.mm:
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebPluginController.mm:
        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebView.mm:

        WebKit/qt:

        * Api/qwebpage.cpp:

        WebKit/win:

        * WebJavaScriptCollector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Steve Falkenburg.
mitz@apple.com [Tue, 4 Nov 2008 07:01:26 +0000 (07:01 +0000)]
    Reviewed by Steve Falkenburg.

        - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
        - add and implement WebMutableURLRequest::mutableCopy()

        * Interfaces/IWebURLRequest.idl:
        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::setHTTPShouldHandleCookies):
        (WebMutableURLRequest::mutableCopy):
        * WebMutableURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the 64-bit build.
mrowe@apple.com [Tue, 4 Nov 2008 06:38:11 +0000 (06:38 +0000)]
Fix the 64-bit build.

Pull the frequently-made check for drawingModel == NPDrawingModelQuickDraw out into a
helper function to avoid #ifdef'ing all of the new places that this check is made.

A few other #ifdef's are moved inside functions to allow their call sites to remain #ifdef-free,
and we rely on the compiler to optimise out the check (which will always be false in 64-bit) instead.

* Plugins/WebBaseNetscapePluginView.mm:
(isDrawingModelQuickDraw):
(-[WebBaseNetscapePluginView fixWindowPort]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView tellQuickTimeToChill]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView _viewHasMoved]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 4 Nov 2008 04:25:52 +0000 (04:25 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        autotools distcleancheck fix. Add dolt-generated files and
        webkitenumtypes.h to the list of files that need to be cleaned.
        Unreviewed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 04:00:31 +0000 (04:00 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Sam Weinig.

        Remove the forwarding header for FunctionCallProfile, because it was
        renamed to ProfileNode in r33466.

        * ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Tue, 4 Nov 2008 02:32:44 +0000 (02:32 +0000)]
2008-11-03  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Dan Bernstein.

        Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.

        https://bugs.webkit.org/show_bug.cgi?id=22054

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 4 Nov 2008 00:33:31 +0000 (00:33 +0000)]
2008-11-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Kevin Decker.

        - fix release build (and unitialized variable for CG drawing model!)

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): initialize portState in all code paths

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 3 Nov 2008 22:43:00 +0000 (22:43 +0000)]
2008-11-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move #define to turn on dumping StructureID statistics to StructureID.cpp so that
        turning it on does not require a full rebuild.

        * runtime/StructureID.cpp:
        (JSC::StructureID::dumpStatistics):
        * runtime/StructureID.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 3 Nov 2008 22:37:00 +0000 (22:37 +0000)]
2008-11-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=22026

        When computing the bounds of the transparency layer, we need to
        map the clipRect through the enclosing transform.

        Test: fast/layers/opacity-transforms.html

        * rendering/RenderLayer.cpp:
        (WebCore::transparencyClipBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Mon, 3 Nov 2008 20:52:50 +0000 (20:52 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=22053

        This patch adds initial support for the NPDrawingModelCoreAnimation drawing model.

        * Plugins/WebBaseNetscapePluginView.h: Added _layer ivar.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation.
        (-[WebBaseNetscapePluginView restorePortState:]): Ditto.
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState.
        Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState.
        (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation
        (-[WebBaseNetscapePluginView updateAndSetWindow]):  Ditto.
        (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto.
        (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it.
        (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins.
        (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports
         NPDrawingModelCoreAnimation.
        (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode.
        (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to
        CoreGraphics and QuickDraw plug-ins.

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=22053

        Added additional support needed for the NPDrawingModelCoreAnimation drawing model.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 3 Nov 2008 20:47:20 +0000 (20:47 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        Reviewed by Geoffrey Garen.

        Fix warning when building on Darwin without JSC_MULTIPLE_THREADS
        enabled.

        * kjs/InitializeThreading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 3 Nov 2008 20:29:51 +0000 (20:29 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        Reviewed by Holger Freyther.

        Deprecate flawed webkit_web_frame_new() function. This would never
        have worked properly when used outside WebCore since Frame::create()
        can only be called without an owner element once in the lifetime of a
        Page and would result in assertions, leaks and an unusable WebView
        instance.

        Frame creation may be exposed in API some time later via the DOM
        binding but probably not in the WebKit GTK+ core API.

        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebframe.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Xan Lopez <xan@gnome.org>
alp@webkit.org [Mon, 3 Nov 2008 19:15:13 +0000 (19:15 +0000)]
2008-11-03  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        Update parseDataUrl() function in the libsoup http backend with
        the one from the curl backend which has recent correctness and crash
        fixes.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 3 Nov 2008 18:37:17 +0000 (18:37 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        Reviewed by Holger Freyther.

        Redundant scrollbars appear in frames where they shouldn't be visible
        eg. embedded Google adverts.

        Call setCanHaveScrollbars() when necessary. The Mac and Win ports
        already have this but it was missing in FrameLoaderClientGtk.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 3 Nov 2008 18:26:08 +0000 (18:26 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Holger Freyther.

        Sync WebKit GTK+ default UA version string to 528.5+. (We're still
        doing this manually!)

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::composeUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 3 Nov 2008 17:27:55 +0000 (17:27 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Holger Freyther.

        Do not enable RTTI or exceptions in debug builds, matching release
        builds. They don't help much with debugging and significantly slow
        down and increase the size of the debug build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
alp@webkit.org [Mon, 3 Nov 2008 17:11:19 +0000 (17:11 +0000)]
2008-11-03  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=22041
        Fix CURL crashes on the test suite

        Fix segfault with setDefersLoading(). Do not call into curl when we
        don't have a CURL handle.

        It is attempted to defer the loading before the load has been
        started (no curl handle was allocated yet). If that happens then
        just remember that. ResourceHandleManager::startJob is already taking
        care of this and in initResourceHandle the the downloading will
        be paused if needed.

        Fixes fast/loader/simultaneous-reloads-assert.html

        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::setDefersLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
alp@webkit.org [Mon, 3 Nov 2008 16:50:16 +0000 (16:50 +0000)]
2008-11-03  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=22041
        Fix CURL crashes on the test suite

        Do not send "no data" to WebCore in parseDataUrl().

        Fixes assert on fast/tokenizer/image-empty-crash.html

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 3 Nov 2008 15:59:02 +0000 (15:59 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Holger Freyther.

        Add mingw32 case to dolt for faster GTK+ Windows builds.

        * acinclude.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-02 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sun, 2 Nov 2008 21:14:48 +0000 (21:14 +0000)]
2008-11-02  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Cameron Zwarich.

        Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
        <https://bugs.webkit.org/show_bug.cgi?id=22042>

        Rename parameter name to avoid ASSERT.

        * VM/CodeBlock.h:
        (JSC::CodeBlock::CodeBlock):
        (JSC::ProgramCodeBlock::ProgramCodeBlock):
        (JSC::EvalCodeBlock::EvalCodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-02 Xan Lopez <xan@gnome.org>
christian@webkit.org [Sun, 2 Nov 2008 20:23:14 +0000 (20:23 +0000)]
2008-11-02  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther

        https://bugs.webkit.org/show_bug.cgi?id=22009
        HTML5 Video with GStreamer pulls gnome-vfs without using it.

        * configure.ac:
        Remove gnome-vfs from configure.ac, it's unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-11-02 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sun, 2 Nov 2008 11:29:58 +0000 (11:29 +0000)]
2008-11-02  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Oliver Hunt.

        Bug 22035: Remove the '_' suffix on constructor parameter names for structs
        <https://bugs.webkit.org/show_bug.cgi?id=22035>

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
        * VM/CodeBlock.h:
        (JSC::CodeBlock::CodeBlock):
        (JSC::ProgramCodeBlock::ProgramCodeBlock):
        (JSC::EvalCodeBlock::EvalCodeBlock):
        * wrec/WREC.h:
        (JSC::Quantifier::Quantifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Sat, 1 Nov 2008 09:31:42 +0000 (09:31 +0000)]
WebCore:

2008-11-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Be sure to check the final URLs of requested resources to make sure we
        don't get fooled by HTTP redirects.

        https://bugs.webkit.org/show_bug.cgi?id=21963

        Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml
               http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::openFunc):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::canRequest):
        (WebCore::DocLoader::requestResource):
        * loader/DocLoader.h:
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):

LayoutTests:

2008-11-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Test that we properly block non-same-origin redirects for these
        esoteric loads.

        https://bugs.webkit.org/show_bug.cgi?id=21963

        * http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
        * http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
        * http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
        * http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
        * http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
        * http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ap@webkit.org [Sat, 1 Nov 2008 07:21:53 +0000 (07:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22001
        AtomicStringImpl* keys of event listener maps can outlive their strings

        Test: fast/events/destroyed-atomic-string.html

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::addEventListener):
        (WebCore::MessagePort::removeEventListener):
        (WebCore::MessagePort::dispatchEvent):
        * dom/MessagePort.h:
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::addEventListener):
        (WebCore::DOMApplicationCache::removeEventListener):
        (WebCore::DOMApplicationCache::dispatchEvent):
        * loader/appcache/DOMApplicationCache.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::addEventListener):
        (WebCore::XMLHttpRequest::removeEventListener):
        (WebCore::XMLHttpRequest::dispatchEvent):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequestUpload.cpp:
        (WebCore::XMLHttpRequestUpload::addEventListener):
        (WebCore::XMLHttpRequestUpload::removeEventListener):
        (WebCore::XMLHttpRequestUpload::dispatchEvent):
        * xml/XMLHttpRequestUpload.h:
        Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ap@webkit.org [Sat, 1 Nov 2008 07:11:09 +0000 (07:11 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=21998
        Use JSDOMGlobalObject in EventListener-related bindings

        * dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.

        * bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS
        bindings for inline event handlers.

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSEventTargetNodeCustom.cpp:
        (WebCore::JSEventTargetNode::addEventListener):
        (WebCore::JSEventTargetNode::removeEventListener):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        Use ScriptExecutionContext and JSDOMGlobalObject in bindings.

        * dom/EventTarget.h:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::scriptExecutionContext):
        * dom/EventTargetNode.h:
        * dom/MessagePort.cpp:
        * dom/MessagePort.h:
        (WebCore::MessagePort::scriptExecutionContext):
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::scriptExecutionContext):
        * loader/appcache/DOMApplicationCache.h:
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::scriptExecutionContext):
        * svg/SVGElementInstance.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::scriptExecutionContext):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequestUpload.cpp:
        (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
        * xml/XMLHttpRequestUpload.h:
        Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't
        available yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Sat, 1 Nov 2008 04:28:56 +0000 (04:28 +0000)]
2008-10-31  Stephanie Lewis  <slewis@apple.com>

        Fix build by including right files.

        * JSRun.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sat, 1 Nov 2008 01:05:21 +0000 (01:05 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Geoff Garen.

        Rename SourceRange.h to SourceCode.h.

        JavaScriptCore:

        * API/JSBase.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * VM/CodeBlock.h:
        * kjs/SourceCode.h: Copied from kjs/SourceRange.h.
        * kjs/SourceRange.h: Removed.
        * kjs/grammar.y:
        * kjs/lexer.h:
        * kjs/nodes.cpp:
        (JSC::ForInNode::ForInNode):
        * kjs/nodes.h:
        (JSC::ThrowableExpressionData::setExceptionSourceCode):

        WebCore:

        * ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
        * ForwardingHeaders/kjs/SourceRange.h: Removed.
        * bindings/js/StringSourceProvider.h:
        * bridge/NP_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sat, 1 Nov 2008 00:35:14 +0000 (00:35 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Darin Adler.

        Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
        <https://bugs.webkit.org/show_bug.cgi?id=22019>

        The JSC::Interpreter::shouldPrintExceptions() function is not used at
        all in JavaScriptCore, so it should be moved to WebCore::Console, its
        only user.

        JavaScriptCore:

        * JavaScriptCore.exp:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:

        WebCore:

        * WebCore.base.exp:
        * page/Console.cpp:
        (WebCore::printToStandardOut):
        (WebCore::Console::shouldPrintExceptions):
        (WebCore::Console::setShouldPrintExceptions):
        * page/Console.h:

        WebKit/mac:

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics shouldPrintExceptions]):
        (+[WebCoreStatistics setShouldPrintExceptions:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark Rowe.
christian@webkit.org [Sat, 1 Nov 2008 00:26:57 +0000 (00:26 +0000)]
Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=22018
enable-developer-extras doesn't toggle WebInspector

* webkit/webkitwebview.cpp:
Add missing 'if' in notification for 'enable-developer-extras'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 31 Oct 2008 23:35:00 +0000 (23:35 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

        * dom/Document.cpp:
        (WebCore::Document::cookie): Added checking if cookies are disabled.
        (WebCore::Document::setCookie): Ditto.
        * page/Navigator.cpp:
        (WebCore::Navigator::cookieEnabled): Ditto.
        * page/Page.cpp:
        (WebCore::Page::Page): Initialize m_cookieEnabled to true.
        * page/Page.h:
        (WebCore::Page::cookieEnabled): Added.
        (WebCore::Page::setCookieEnabled): Added.

WebKit/mac:

        Reviewed by John Sullivan.

        - WebKit/mac part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

        * WebView/WebView.mm:
        (-[WebView _cookieEnabled]):
        (-[WebView _setCookieEnabled:]):
        * WebView/WebViewPrivate.h:

WebKit/win:

        Reviewed by John Sullivan.

        - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::setCookieEnabled):
        (WebView::cookieEnabled):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele@apple.com [Fri, 31 Oct 2008 23:25:48 +0000 (23:25 +0000)]
WebCore:

2008-10-31  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
        https://bugs.webkit.org/show_bug.cgi?id=22008

        * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon):
        Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
        * platform/graphics/Icon.h: ditto.
        * platform/graphics/gtk/IconGtk.cpp:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): ditto.
        * platform/graphics/mac/IconMac.mm:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): ditto.
        * platform/graphics/qt/IconQt.cpp:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): ditto.
        * platform/wx/TemporaryLinkStubs.cpp:
        (Icon::createIconForFile): ditto.
        (Icon::createIconForFiles): ditto.
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::createIconForFile): ditto.
        (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.

        * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
        Improve icon creation code to match new code in Icon::createIconForFiles

WebKit/win:

2008-10-31  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
        https://bugs.webkit.org/show_bug.cgi?id=22008

        * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel):
        Add support for mulitple file selection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 31 Oct 2008 22:56:15 +0000 (22:56 +0000)]
2008-10-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Move WebNetscapePluginEventHandler classes to a subgroup of Netscape Plug-Ins.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 22:26:22 +0000 (22:26 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 22:18:39 +0000 (22:18 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Remove the call to Interpreter::setShouldPrintExceptions() from the
        GlobalObject constructor in the shell. The shouldPrintExceptions()
        information is not used anywhere in JavaScriptCore, only in WebCore.

        * kjs/Shell.cpp:
        (GlobalObject::GlobalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoA couple wxMSW build fixes.
kevino@webkit.org [Fri, 31 Oct 2008 21:59:03 +0000 (21:59 +0000)]
A couple wxMSW build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 21:40:34 +0000 (21:40 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move more files from the kjs subdirectory of JavaScriptCore to the
        runtime subdirectory.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/RegExpConstructor.cpp: Removed.
        * kjs/RegExpConstructor.h: Removed.
        * kjs/RegExpMatchesArray.h: Removed.
        * kjs/RegExpObject.cpp: Removed.
        * kjs/RegExpObject.h: Removed.
        * kjs/RegExpPrototype.cpp: Removed.
        * kjs/RegExpPrototype.h: Removed.
        * runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
        * runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
        * runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
        * runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
        * runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
        * runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
        * runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRevert an incorrect portion of r38034.
mrowe@apple.com [Fri, 31 Oct 2008 21:19:24 +0000 (21:19 +0000)]
Revert an incorrect portion of r38034.

* profiler/ProfilerServer.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the 64-bit build.
mrowe@apple.com [Fri, 31 Oct 2008 21:19:21 +0000 (21:19 +0000)]
Fix the 64-bit build.

Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
with the common Obj-C idiom self = [super init];

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 20:47:35 +0000 (20:47 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        * Scripts/do-webcore-rename:

        Add some renames to contemplate for the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 20:44:47 +0000 (20:44 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Alexey Proskuryakov.

        Change a header guard to match our coding style.

        * kjs/InitializeThreading.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 31 Oct 2008 19:59:08 +0000 (19:59 +0000)]
2008-10-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed a small bit of https://bugs.webkit.org/show_bug.cgi?id=21962
        AST uses way too much memory

        Removed a word from StatementNode by nixing LabelStack and turning it
        into a compile-time data structure managed by CodeGenerator.

        v8 tests and SunSpider, run by Gavin, report no change.

        * GNUmakefile.am:
        * JavaScriptCore.order:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/AllInOneFile.cpp:
        * JavaScriptCoreSources.bkl: I sure hope this builds!

        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::CodeGenerator):
        (JSC::CodeGenerator::newLabelScope):
        (JSC::CodeGenerator::breakTarget):
        (JSC::CodeGenerator::continueTarget):
        * VM/CodeGenerator.h: Nixed the JumpContext system because it depended
        on a LabelStack in the AST, and it was a little cumbersome on the client
        side. Replaced with LabelScope, which tracks all break / continue
        information in the CodeGenerator, just like we track LabelIDs and other
        stacks of compile-time data.

        * kjs/LabelScope.h: Added.
        (JSC::LabelScope::):
        (JSC::LabelScope::LabelScope):
        (JSC::LabelScope::ref):
        (JSC::LabelScope::deref):
        (JSC::LabelScope::refCount):
        (JSC::LabelScope::breakTarget):
        (JSC::LabelScope::continueTarget):
        (JSC::LabelScope::type):
        (JSC::LabelScope::name):
        (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything
        you might want to know about a break-able / continue-able scope.

        * kjs/LabelStack.cpp: Removed.
        * kjs/LabelStack.h: Removed.

        * kjs/grammar.y: No need to push labels at parse time -- we don't store
        LabelStacks in the AST anymore.

        * kjs/nodes.cpp:
        (JSC::DoWhileNode::emitCode):
        (JSC::WhileNode::emitCode):
        (JSC::ForNode::emitCode):
        (JSC::ForInNode::emitCode):
        (JSC::ContinueNode::emitCode):
        (JSC::BreakNode::emitCode):
        (JSC::SwitchNode::emitCode):
        (JSC::LabelNode::emitCode):
        * kjs/nodes.h:
        (JSC::StatementNode::):
        (JSC::LabelNode::): Use LabelScope where we used to use JumpContext.
        Simplified a bunch of code. Touched up label-related error messages a
        bit.

        * kjs/nodes2string.cpp:
        (JSC::LabelNode::streamTo): Updated for rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 19:53:20 +0000 (19:53 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Darin Adler.

        Bug 22005: Move StructureIDChain into its own file
        <https://bugs.webkit.org/show_bug.cgi?id=22005>

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * runtime/StructureID.cpp:
        * runtime/StructureID.h:
        * runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
        * runtime/StructureIDChain.h: Copied from runtime/StructureID.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 31 Oct 2008 19:53:08 +0000 (19:53 +0000)]
2008-10-31  Darin Adler  <darin@apple.com>

        Requested by Mark Rowe.

        * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Fri, 31 Oct 2008 19:44:07 +0000 (19:44 +0000)]
2008-10-31  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/jsc/jsc.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoExpand that name!
beidson@apple.com [Fri, 31 Oct 2008 19:35:01 +0000 (19:35 +0000)]
Expand that name!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 31 Oct 2008 19:34:27 +0000 (19:34 +0000)]
2008-10-31  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        [WebHistory setLastVisitedTimeInterval:forItem] was internal to WebHistory.mm and
        completely unused.  Nuke it!

        * History/WebHistory.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Fri, 31 Oct 2008 18:53:56 +0000 (18:53 +0000)]
2008-10-31  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoEmit the WillExecuteStatement debugger hook before the for loop body when the stateme...
timothy@apple.com [Fri, 31 Oct 2008 18:49:52 +0000 (18:49 +0000)]
Emit the WillExecuteStatement debugger hook before the for loop body when the statement node for the body isn't a block. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-31  Timothy Hatcher  <timothy@apple.com>

        Emit the WillExecuteStatement debugger hook before the for loop body
        when the statement node for the body isn't a block. This allows
        breakpoints on those statements in the Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=22004

        Reviewed by Darin Adler.

        * kjs/nodes.cpp:
        (JSC::ForNode::emitCode): Emit the WillExecuteStatement
        debugger hook before the statement node if isn't a block.
        Also emit the WillExecuteStatement debugger hook for the
        loop as the first op-code.
        (JSC::ForInNode::emitCode): Ditto.

WebCore:

2008-10-31  Timothy Hatcher  <timothy@apple.com>

        Add manual tests that check breakpoints on a blockless body of "for" loops.

        https://bugs.webkit.org/show_bug.cgi?id=22004

        Reviewed by Darin Adler.

        * manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
        * manual-tests/inspector/debugger-pause-on-for-statements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 31 Oct 2008 18:45:19 +0000 (18:45 +0000)]
2008-10-31  Darin Adler  <darin@apple.com>

        - fix build

        * platform/win/WCDataObject.cpp: Added missing include of "config.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Bug 21997: prepare-ChangeLog should filter out ChangeLog files
ddkilzer@apple.com [Fri, 31 Oct 2008 18:08:02 +0000 (18:08 +0000)]
    Bug 21997: prepare-ChangeLog should filter out ChangeLog files

        <https://bugs.webkit.org/show_bug.cgi?id=21997>

        Reviewed by Darin Adler.

        * Scripts/prepare-ChangeLog:
        (generateFileList): Don't add ChangeLog files to %{$functionLists}.
        This prevents them from showing up in the new ChangeLog entry.  They
        were already excluded from @{$changedFiles}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 31 Oct 2008 17:59:14 +0000 (17:59 +0000)]
2008-10-31  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        - fix storage leak seen on buildbot

        Some other cleanup too. The storage leak was caused by the fact
        that HashTraits<CallIdentifier>::needsDestruction was false, so
        the call identifier objects didn't get deleted.

        * profiler/CallIdentifier.h:

        Added a default constructor to create empty call identifiers.

        Changed the normal constructor to use const UString&
        to avoid extra copying and reference count thrash.

        Removed the explicit copy constructor definition, since it's what
        the compiler will automatically generate. (Rule of thumb: Either
        you need both a custom copy constructor and a custom assignment
        operator, or neither.)

        Moved the CallIdentifier hash function out of the WTF namespace;
        there's no reason to put it there.

        Changed the CallIdentifier hash function to be a struct rather than
        a specialization of the IntHash struct template. Having it be
        a specialization made no sense, since CallIdentifier is not an integer,
        and did no good.

        Removed explicit definition of emptyValueIsZero in the hash traits,
        since inheriting from GenericHashTraits already makes that false.

        Removed explicit definition of emptyValue, instead relying on the
        default constructor and GenericHashTraits.

        Removed explicit definition of needsDestruction, because we want it
        to have its default value: true, not false. This fixes the leak!

        Changed constructDeletedValue and isDeletedValue to use a line number
        of numeric_limits<unsigned>::max() to indicate a value is deleted.
        Previously this used empty strings for the empty value and null strings
        for the deleted value, but it's more efficient to use null for both.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 31 Oct 2008 17:56:33 +0000 (17:56 +0000)]
2008-10-31  Darin Adler  <darin@apple.com>

        - try to fix build

        * WebView.cpp:
        (WebView::setCacheModel): Roll out the part of my last change
        that involved no longer using wkCopyFoundationCacheDirectory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView...
cfleizach@apple.com [Fri, 31 Oct 2008 17:15:51 +0000 (17:15 +0000)]
Bug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView does not allow scrolling
https://bugs.webkit.org/show_bug.cgi?id=22002

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixes console warnings about not having an autorelease pool.
timothy@apple.com [Fri, 31 Oct 2008 10:17:50 +0000 (10:17 +0000)]
    Fixes console warnings about not having an autorelease pool.
        Also fixes the build for Snow Leopard, by including individual
        Foundation headers instead of Foundation.h.

        https://bugs.webkit.org/show_bug.cgi?id=21995

        Reviewed by Oliver Hunt.

        * profiler/ProfilerServer.mm:
        (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 31 Oct 2008 09:44:03 +0000 (09:44 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=21970
        Make MessagePort event dispatch work in workers

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
        (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
        (WebCore::JSDOMGlobalObject::jsEventListeners):
        (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
        (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners):
        (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners):
        (WebCore::JSDOMGlobalObject::setCurrentEvent):
        (WebCore::JSDOMGlobalObject::currentEvent):
        (WebCore::toJSDOMGlobalObject):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
        * bindings/js/JSDOMWindowBase.h:
        Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
        (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
        (WebCore::JSUnprotectedEventListener::globalObject):
        (WebCore::JSUnprotectedEventListener::clearGlobalObject):
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::~JSEventListener):
        (WebCore::JSEventListener::globalObject):
        (WebCore::JSEventListener::clearGlobalObject):
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/JSEventListener.h:
        (WebCore::JSUnprotectedEventListener::create):
        (WebCore::JSEventListener::create):
        (WebCore::JSLazyEventListener::create):
        Changed to use JSDOMGlobalObject and ScriptExecutionContext.

        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::startConversation):
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        (WebCore::JSMessagePort::setOnmessage):
        (WebCore::JSMessagePort::setOnclose):
        Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit
        such code, and stop using a custom implementation for JSMessagePort inline event handler
        getters and setters.

        * dom/Document.cpp:
        (WebCore::Document::virtualURL):
        * dom/Document.h:
        * dom/ScriptExecutionContext.h:
        Expose url() method on ScriptExecutionContext (necessary for compiling scripts in
        JSLazyEventListener).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 08:18:20 +0000 (08:18 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Speculative wxWindows build fix.

        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 07:42:30 +0000 (07:42 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Speculative wxWindows build fix.

        * JavaScriptCoreSources.bkl:
        * jscore.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 07:37:53 +0000 (07:37 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Maciej Stachowiak.

        Move VM/JSPropertyNameIterator.cpp and VM/JSPropertyNameIterator.h to
        the runtime directory.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/JSPropertyNameIterator.cpp: Removed.
        * VM/JSPropertyNameIterator.h: Removed.
        * runtime/JSPropertyNameIterator.cpp: Copied from VM/JSPropertyNameIterator.cpp.
        * runtime/JSPropertyNameIterator.h: Copied from VM/JSPropertyNameIterator.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-31 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 07:12:54 +0000 (07:12 +0000)]
2008-10-31  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Speculative wxWindows build fix.

        * jscore.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoExplicitly default to building for only the native architecture in debug and release...
mrowe@apple.com [Fri, 31 Oct 2008 06:13:07 +0000 (06:13 +0000)]
Explicitly default to building for only the native architecture in debug and release builds.

Reviewed by Jon Homeycutt.

* Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-10-30 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 31 Oct 2008 05:56:58 +0000 (05:56 +0000)]
2008-10-30  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Create a debugger directory in JavaScriptCore and move the relevant
        files to it.

        JavaScriptCore:

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * VM/CodeBlock.cpp:
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        * debugger: Added.
        * debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
        * debugger/Debugger.h: Copied from kjs/debugger.h.
        * debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
        * debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
        * kjs/AllInOneFile.cpp:
        * kjs/DebuggerCallFrame.cpp: Removed.
        * kjs/DebuggerCallFrame.h: Removed.
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/debugger.cpp: Removed.
        * kjs/debugger.h: Removed.
        * kjs/interpreter.cpp:
        * kjs/nodes.cpp:
        * runtime/FunctionConstructor.cpp:
        * runtime/JSGlobalObject.cpp:

        WebCore:

        * ForwardingHeaders/debugger: Added.
        * ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
        * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
        * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
        * ForwardingHeaders/kjs/debugger.h: Removed.
        * WebCore.pro:
        * bindings/js/ScriptController.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptDebugServer.cpp:
        * inspector/JavaScriptDebugServer.h:

        WebKit/mac:

        * ForwardingHeaders/debugger: Added.
        * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
        * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebScriptDebugger.h:
        * WebView/WebScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a bug where when V8's or UBENCH's test suite list file is missing
timothy@apple.com [Fri, 31 Oct 2008 05:54:37 +0000 (05:54 +0000)]
    Fix a bug where when V8's or UBENCH's test suite list file is missing
        the error message is suggesting that SunSpider's list file is missing.

        Reviewed by Sam Weinig.

        * sunspider:
        (loadTestsList): Fix the error message to use the right list name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix 2 Windows theme bugs:
timothy@apple.com [Fri, 31 Oct 2008 05:49:22 +0000 (05:49 +0000)]
    Fix 2 Windows theme bugs:
        1) Checkboxes marked readonly were rendered incorrectly
        2) If a button has focus and is pressed, it was rendered
           as focused rather than pressed.

        https://bugs.webkit.org/show_bug.cgi?id=21859

        Reviewed by Dave Hyatt.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::determineState):
        (WebCore::RenderThemeWin::determineButtonState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd parentheses to fix some gcc warnings.
timothy@apple.com [Fri, 31 Oct 2008 05:36:06 +0000 (05:36 +0000)]
Add parentheses to fix some gcc warnings.

JavaScriptCore:

2008-10-30  Benjamin K. Stuhl  <bks24@cornell.edu>

        gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
        warnings; add some parentheses to disambiguate things. No functional
        changes, so no tests.

        https://bugs.webkit.org/show_bug.cgi?id=21973
        Add parentheses to clean up some gcc warnings

        Reviewed by Dan Bernstein.

        * wtf/ASCIICType.h:
        (WTF::isASCIIAlphanumeric):
        (WTF::isASCIIHexDigit):

WebCore:

2008-10-30  Benjamin K. Stuhl  <bks24@cornell.edu>

        gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
        warnings; add some parentheses to disambiguate things. No functional
        changes, so no tests.

        https://bugs.webkit.org/show_bug.cgi?id=21973
        Add parentheses to clean up some gcc warnings

        Reviewed by Dan Bernstein.

        * platform/graphics/Font.h:
        (WebCore::Font::treatAsZeroWidthSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added an explicit dependency on HashMap.h. It was getting pulled in via
timothy@apple.com [Fri, 31 Oct 2008 05:29:01 +0000 (05:29 +0000)]
    Added an explicit dependency on HashMap.h. It was getting pulled in via
        <kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.

        Reviewed by Darin Adler.

        * platform/text/PlatformString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Adds ProfilerServer, which is a distributed notification listener
timothy@apple.com [Fri, 31 Oct 2008 05:24:46 +0000 (05:24 +0000)]
    Adds ProfilerServer, which is a distributed notification listener
        that allows starting and stopping the profiler remotely for use
        in conjunction with the profiler's DTace probes.

        https://bugs.webkit.org/show_bug.cgi?id=21719

        Reviewed by Timothy Hatcher.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Calls startProfilerServerIfNeeded.
        * profiler/ProfilerServer.h: Added.
        * profiler/ProfilerServer.mm: Added.
        (+[ProfilerServer sharedProfileServer]):
        (-[ProfilerServer init]):
        (-[ProfilerServer startProfiling]):
        (-[ProfilerServer stopProfiling]):
        (JSC::startProfilerServerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38022 268f45cc-cd09-0410-ab3c-d52691b4dbfc