WebKit-https.git
8 years agorunCount in runner.js should be renamed to iterationCount
rniwa@webkit.org [Wed, 14 Nov 2012 19:34:49 +0000 (19:34 +0000)]
runCount in runner.js should be renamed to iterationCount
https://bugs.webkit.org/show_bug.cgi?id=102208

Reviewed by Tony Chang.

Prior to this patch, there were terminology confusions between "runs" and "iterations".
The term "run" should refer to running a performance test once, and "iteration" should
refer to one measurement in the test. i.e. Executing run-perf-should once will result in
a single "run" of performance tests and each test may execute multiple "iterations"
to complete the run.

Unfortunately, we still overload the meaning of "runs" in "runs/s" (is "function calls/s")
but that could be addressed in a separate patch.

* Animation/balls.html:
* DOM/DOMTable.html:
* DOM/resources/dom-perf.js:
* Layout/floats_100_100.html:
* Layout/floats_100_100_nested.html:
* Layout/floats_20_100.html:
* Layout/floats_20_100_nested.html:
* Layout/floats_2_100.html:
* Layout/floats_2_100_nested.html:
* Layout/floats_50_100.html:
* Layout/floats_50_100_nested.html:
* Layout/subtree-detaching.html:
* Parser/html5-full-render.html:
* SVG/SvgHitTesting.html:
* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove uses of deprecated unittest.TestCase aliases
zandobersek@gmail.com [Wed, 14 Nov 2012 19:29:25 +0000 (19:29 +0000)]
Remove uses of deprecated unittest.TestCase aliases
https://bugs.webkit.org/show_bug.cgi?id=102253

Reviewed by Dirk Pranke.

Replace the deprecated unittest.TestCase methods with the corresponding methods
everywhere inside the Tools directory. The following replacements are done:
- assertEquals -> assertEqual
- assert_ -> assertTrue
- failUnlessRaises -> assertRaises

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(SVNMirrorTest.test_CheckOutSource):
* QueueStatusServer/model/queuepropertymixin_unittest.py:
(QueuePropertyMixinTest.test_queue_property):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest._assert_short_name):
(QueueTest._assert_display_name):
(QueueTest._assert_name_with_underscores):
* QueueStatusServer/model/workitems_unittest.py:
(WorkItemsTest.test_display_position_for_attachment):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_log_entries_from_changelog):
(test_parse_log_entries_from_annotated_file):
(_assert_parse_reviewer_text_and_list):
(_assert_parse_reviewer_text_list):
(_assert_fuzzy_reviewer_match):
(_assert_parse_authors):
(test_latest_entry_parse):
(test_latest_entry_parse_single_entry):
(test_set_reviewer):
(test_set_short_description_and_bug_url):
* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
(DiffParserTest.test_diff_parser):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitSVNTest.test_revisions_changing_files_with_local_commit):
(GitSVNTest.test_upstream_branch):
(GitSVNTest.test_create_patch_with_rm_and_changed_files):
(GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_efl_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_chromium_port):
(DeprecatedPortTest.test_chromium_android_port):
(DeprecatedPortTest.test_chromium_xvfb_port):
* Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
(URLsTest.test_parse_attachment_id):
* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.assert_filesystem_normalizes):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_url_creation):
(test_parse_bug_id):
(_assert_dictionaries_equal):
(test_parse_bugs_from_xml):
(test_attachment_detail_bug_parsing):
(_assert_result_count):
(test_request_page_parsing):
(test_quip_page_parsing):
(EditUsersParserTest._assert_login_userid_pairs):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_status_parsing):
(test_latest_cached_build):
(test_results_zip_url):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_credentials_from_environment):
* Scripts/webkitpy/common/net/failuremap_unittest.py:
(FailureMapTest.test_failing_revisions):
(FailureMapTest.test_new_failures):
(FailureMapTest.test_new_failures_with_old_revisions):
(FailureMapTest.test_new_failures_with_more_old_revisions):
(FailureMapTest.test_tests_failing_for):
(FailureMapTest.test_failing_tests):
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(LayoutTestResultsTest.test_set_failure_limit_count):
* Scripts/webkitpy/common/net/unittestresults_unittest.py:
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
* Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
(ReadChecksumFromPngTest.test_read_checksum):
* Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
(LoggingTest.assert_log_equals):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ScriptErrorTest.test_string_from_args):
(ScriptErrorTest.test_message_with_output):
(ExecutiveTest.test_run_command_with_bad_command):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.serial_test_run_in_parallel):
* Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
(MockFileSystemTest.quick_check):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(GenericFileSystemTests.test_glob__trailing_asterisk):
(GenericFileSystemTests.test_glob__leading_asterisk):
(GenericFileSystemTests.test_glob__middle_asterisk):
(GenericFileSystemTests.test_glob__period_is_escaped):
(RealFileSystemTest.test_chdir):
(RealFileSystemTest.test_remove_file_with_retry):
(RealFileSystemTest.test_sep):
* Scripts/webkitpy/common/system/logtesting.py:
(TestLogStream.assertMessages):
* Scripts/webkitpy/common/system/logutils_unittest.py:
(GetLoggerTest.test_get_logger_in_webkitpy):
(GetLoggerTest.test_get_logger_not_in_webkitpy):
* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCaptureTestCaseBase.assertStdout):
(OutputCaptureTestCaseBase.assertStderr):
* Scripts/webkitpy/common/system/path_unittest.py:
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_real_code):
(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/common/system/user_unittest.py:
(UserTest.test_confirm.mock_raw_input):
(UserTest.test_confirm):
* Scripts/webkitpy/common/system/zipfileset_unittest.py:
(ZipFileSetTest.test_open):
(ZipFileSetTest.test_read):
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
(WatchListTest.test_filename_definition_no_matches):
(WatchListTest.test_filename_definition):
(WatchListTest.test_cc_rules_simple):
(WatchListTest.test_cc_rules_complex):
(WatchListTest.test_cc_and_message_rules_complex):
(WatchListTest.test_cc_and_message_rules_no_matches):
(WatchListTest.test_added_match):
(WatchListTest.test_deleted_match):
(WatchListTest.test_more_and_less_match):
(WatchListTest.test_complex_match):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LockCheckingRunner.handle_finished_list):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
(LayoutTestRunnerTests.test_servers_started):
(SharderTests.assert_shards):
(SharderTests.test_shard_in_two_has_no_locked_shards):
(SharderTests.test_shard_in_two_has_no_unlocked_shards):
(NaturalCompareTest.assert_cmp):
(KeyCompareTest.assert_cmp):
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_init):
(SpecifierSorterTest.test_add_specifier):
(SpecifierSorterTest.test_add_macros):
(SpecifierSorterTest.test_category_priority):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_macro_collapsing):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
(TestConfigurationConverterTest.test_specifier_converter_access):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_exp):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(MiscTests.test_get_expectations_string):
(SkippedTests.check):
(ExpectationSyntaxTests.assert_tokenize_exp):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(TestExpectationSerializationTests.test_reconstitute_only_these):
* Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_crashes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_nonexistant_expectations):
(PortTest.test_additional_expectations):
* Scripts/webkitpy/layout_tests/port/builders_unittest.py:
(BuildersTest.test_path_from_name):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_default_timeout_ms):
(ChromiumAndroidPortTest.test_get_devices_one_device):
(ChromiumAndroidPortTest.test_get_devices_two_devices):
(ChromiumAndroidPortTest.test_get_device_serial_one_device):
(ChromiumAndroidPortTest.test_get_device_serial_two_devices):
(ChromiumAndroidPortTest.test_must_require_http_server):
(ChromiumAndroidDriverTest.test_get_last_stacktrace):
(ChromiumAndroidDriverTest.test_get_crash_log):
(ChromiumAndroidDriverTest.test_cmd_line):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_command_from_driver_input):
(ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_determine_architecture_fails):
(ChromiumLinuxPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.assert_name):
(ChromiumMacPortTest.test_baseline_path):
(ChromiumMacPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_max_locked_shards):
(ChromiumPortTestCase.test_default_timeout_ms):
(ChromiumPortTestCase.test_default_pixel_tests):
(ChromiumPortTestCase.test_all_test_configurations):
(ChromiumPortTestCase.test_default_configuration):
(ChromiumPortTestCase.test_diff_image):
(ChromiumPortTestCase.test_diff_image_crashed):
(ChromiumPortTestCase.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_setup_environ_for_server_cygpath):
(ChromiumWinTest.assert_name):
(ChromiumWinTest.test_baseline_path):
(ChromiumWinTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_no_timeout):
(DriverTest.test_check_for_driver_crash.assert_crash):
(DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_get_from_builder_name):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
(HttpLockTest.test_current_lock_pid):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image_failed):
(TestImageDiffer.test_diff_image_passed):
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
(LeakDetectorTest.test_leaks_args):
(test_parse_leaks_output):
(test_leaks_files_in_directory):
(test_count_total_leaks):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.test_default_timeout_ms):
(assert_name):
(test_setup_environ_for_server):
(_assert_search_path):
(test_32bit):
(test_64bit):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockTestShellTest.test_pixeltest__fails):
(MockTestShellTest.test_test_shell_parse_options):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_max_locked_shards):
(PortTestCase.test_default_timeout_ms):
(PortTestCase.test_default_pixel_tests):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_get_crash_log):
(PortTestCase.assert_build_path):
(PortTestCase.test_expectations_ordering):
(_assert_config_file_for_platform):
(test_path_to_apache_config_file):
(test_additional_platform_directory):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):
(QtPortTest.test_setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_basic):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest._assert_search_path):
(WinPortTest._assert_version):
(WinPortTest.test_runtime_feature_list):
(WinPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations):
(MainTest.test_all):
(MainTest.test_repeat_each):
(MainTest.test_skipped_flag):
(MainTest.test_iterations):
(MainTest.test_run_chunk):
(MainTest.test_run_part):
(MainTest.test_run_singly):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_single_file):
(MainTest.test_single_file_with_prefix):
(MainTest.test_single_skipped_file):
(MainTest.test_stderr_is_saved):
(MainTest.test_test_list):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_exit_after_n_failures):
(MainTest.test_exit_after_n_crashes):
(MainTest.test_retrying_and_flaky_tests):
(MainTest.test_run_order__inline):
(MainTest.test_reftest_run):
(MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
(MainTest.test_reftest_skip_reftests_if_no_ref_tests):
(MainTest.test_reftest_expected_html_should_be_ignored):
(MainTest.test_reftest_driver_should_run_expected_html):
(MainTest.test_reftest_driver_should_run_expected_mismatch_html):
(MainTest.test_output_diffs):
(MainTest.test_unsupported_platform):
(EndToEndTest.test_end_to_end):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
* Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
(BaseTest.integration_test_server__normal):
(BaseTest.integration_test_server__fails):
(BaseTest.integration_test_port_and_root):
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_start_cmd):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest.test_logging_not_included):
(RegularTest._basic):
(RegularTest.test_basic):
(RegularTest.test_log_after_update):
(RegularTest.test_log_args):
(TtyTest.test_basic):
(TtyTest.test_log_after_update):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
(VerboseTest.test_log_args):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.assertWritten):
(test_test_status_line):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.assertWritten):
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_webkit_base_filter_rules):
(CheckerDispatcherSkipTest._assert_should_skip_without_warning):
(CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
(CheckerDispatcherDispatchTest.assert_checker):
(CheckerDispatcherDispatchTest.test_changelog_paths):
(CheckerDispatcherDispatchTest.test_cpp_paths):
(CheckerDispatcherDispatchTest.test_json_paths):
(CheckerDispatcherDispatchTest.test_python_paths):
(CheckerDispatcherDispatchTest.test_text_paths):
(CheckerDispatcherDispatchTest.test_xml_paths):
(StyleProcessorConfigurationTest.test_init):
(StyleProcessorConfigurationTest.test_write_style_error_emacs):
(StyleProcessorConfigurationTest.test_write_style_error_vs7):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.assert_error.handle_style_error):
(ChangeLogCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/common_unittest.py:
(CarriageReturnCheckerTest.assert_carriage_return):
(TabCheckerTest.assert_tab):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppFunctionsTest.test_convert_to_lower_with_underscores):
(CppFunctionsTest.test_create_acronym):
(CppFunctionsTest.test_parameter):
(CppFunctionsTest.test_single_line_view):
(CppFunctionsTest.test_create_skeleton_parameters):
(CppFunctionsTest.test_find_parameter_name_index):
(CppFunctionsTest.test_parameter_list):
(CppFunctionsTest.test_check_parameter_against_text):
(CppStyleTestBase.perform_lint):
(CppStyleTestBase.assert_lint):
(CppStyleTestBase.assert_lint_one_of_many_errors_re):
(CppStyleTestBase.assert_multi_line_lint):
(CppStyleTestBase.assert_language_rules_check):
(CppStyleTestBase.assert_include_what_you_use):
(CppStyleTestBase.assert_blank_lines_check):
(CppStyleTestBase.assert_positions_equal):
(FunctionDetectionTest.perform_function_detection):
(CppStyleTest.test_get_line_width):
(CppStyleTest.test_find_next_multi_line_comment_start):
(CppStyleTest.test_find_next_multi_line_comment_end):
(CppStyleTest.test_remove_multi_line_comments_from_range):
(CppStyleTest.test_position):
(CppStyleTest.test_rfind_in_lines):
(CppStyleTest.test_close_expression):
(CppStyleTest.test_include_what_you_use_no_implementation_files):
(CppStyleTest.test_include_what_you_use):
(CppStyleTest.test_files_belong_to_same_module):
(CppStyleTest.test_cleanse_line):
(CppStyleTest.test_multiline_strings):
(CppStyleTest.test_newline_at_eof.do_test):
(CppStyleTest.test_invalid_utf8.do_test):
(CppStyleTest.test_is_blank_line):
(CppStyleTest.test_allow_blank_line_before_closing_namespace):
(CppStyleTest.test_allow_blank_line_before_if_else_chain):
(CppStyleTest.test_else_on_same_line_as_closing_braces):
(CppStyleTest.test_build_header_guard):
(CppStyleTest.test_legal_copyright):
(CleansedLinesTest.test_init):
(CleansedLinesTest.test_init_empty):
(CleansedLinesTest.test_collapse_strings):
(CheckForFunctionLengthsTest.assert_function_lengths_check):
(PassPtrTest.assert_pass_ptr_check):
(LeakyPatternTest.assert_leaky_pattern_check):
(WebKitStyleTest.test_parameter_names):
(WebKitStyleTest.test_webkit_export_check):
(CppCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
(JSONCheckerTest.assert_error.handle_style_error):
(JSONCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_init):
(PNGCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_init):
(PythonCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):
* Scripts/webkitpy/style/checkers/text_unittest.py:
(TextStyleTestCase.assertNoError):
(TextStyleTestCase.assertError.error_for_test):
(TextStyleTestCase.assertError):
(TextCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/watchlist_unittest.py:
(WatchListTest.test_basic_error_message.handle_style_error):
(WatchListTest):
* Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
(XcodeProjectFileCheckerTest.assert_error):
* Scripts/webkitpy/style/checkers/xml_unittest.py:
(XMLCheckerTest.assert_error.handle_style_error):
(XMLCheckerTest.test_init):
* Scripts/webkitpy/style/error_handlers_unittest.py:
(DefaultStyleErrorHandlerTest._check_initialized):
(DefaultStyleErrorHandlerTest.test_non_reportable_error):
(DefaultStyleErrorHandlerTest.test_max_reports_per_category):
(DefaultStyleErrorHandlerTest.test_line_numbers):
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest._assert_file_reader):
(TextFileReaderTest.test_process_file__does_not_exist):
(TextFileReaderTest.test_count_delete_only_file):
* Scripts/webkitpy/style/filter_unittest.py:
(CategoryFilterTest.test_init):
(CategoryFilterTest.test_init_default_arguments):
(CategoryFilterTest.test_str):
(FilterConfigurationTest.test_init):
(FilterConfigurationTest.test_default_arguments):
* Scripts/webkitpy/style/main_unittest.py:
(ChangeDirectoryTest._assert_result):
* Scripts/webkitpy/style/optparser_unittest.py:
(ArgumentPrinterTest.test_to_flag_string):
(ArgumentParserTest.test_parse_default_arguments):
(ArgumentParserTest.test_parse_explicit_arguments):
(ArgumentParserTest.test_parse_files):
(CommandOptionValuesTest.test_init):
* Scripts/webkitpy/style/patchreader_unittest.py:
(PatchReaderTest._assert_checked):
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.test_additional_system_paths):
(FinderTest.test_to_module):
(FinderTest.check_names):
* Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_individual_names_are_not_run_twice):
(TesterTest.test_integration_tests_are_not_found_by_default):
(TesterTest.test_integration_tests_are_found):
(TesterTest.integration_test_coverage_works):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_run):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(_expect_validate):
* Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
(ExpectedFailuresTest._assert_can_trust):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
(test_patches_with_acceptable_review_flag):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
(IRCCommandTest.test_create_bug):
(IRCCommandTest.test_roll_chromium_deps):
(IRCCommandTest.test_rollout):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
(test_missing_unit_test_results_path):
(test_layout_test_results):
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.process_work_item):
(LoggingDelegate.handle_unexpected_error):
(QueueEngineTest.test_trivial):
(QueueEngineTest.test_unexpected_error):
(QueueEngineTest.test_handled_error):
(QueueEngineTest._test_terminating_queue):
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest.test_find_bugs_in_string):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
(PrintExpectationsTest.run_test):
(PrintBaselinesTest.test_basic):
(PrintBaselinesTest.test_multiple):
(PrintBaselinesTest.test_csv):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest.test_log_directory):
(AbstractPatchQueueTest.test_next_patch):
(test_auto_retry):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineJson.test_move_overwritten):
(TestRebaselineJson.test_no_optimize):
(TestRebaselineJson.test_results_directory):
(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations_noop):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):
* Scripts/webkitpy/tool/commands/roll_unittest.py:
(PostRollCommandsTest.test_prepare_state):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
(AddSvnMimetypeForPngTest.test_run):
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_ensure_bug_url):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(_assert_message_for_revert_output):
* TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest._test_merge):
(JsonResultsTest._test_get_test_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 19:28:14 +0000 (19:28 +0000)]
Unreviewed GTK gardening.

Adding or updating baselines for changes in r134618.
Adding timeout expectations for
- fast/dom/Window/open-window-min-size.html, added in r134586 and
- inspector-protocol/nmi-webaudio.html, added in r134593.

* platform/gtk/TestExpectations:
* platform/gtk/fast/files/workers/worker-read-blob-sync-expected.txt: Added.
* platform/gtk/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace (typeof(x) != <"object", "undefined", ...>) with
bfulgham@webkit.org [Wed, 14 Nov 2012 19:26:04 +0000 (19:26 +0000)]
Replace (typeof(x) != <"object", "undefined", ...>) with
!(typeof(x) == <"object",..>). Later is_object, is_<...>  bytecode operation
will be used.

https://bugs.webkit.org/show_bug.cgi?id=98893

Patch by Valery Ignatyev <valery.ignatyev@ispras.ru> on 2012-11-14
Reviewed by Filip Pizlo.

This eliminates expensive  typeof implementation and
allows to use DFG optimizations, which doesn't support 'typeof'.

* bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaselined video LayoutTests for software compositor
enne@google.com [Wed, 14 Nov 2012 19:24:57 +0000 (19:24 +0000)]
[Chromium] Rebaselined video LayoutTests for software compositor
https://bugs.webkit.org/show_bug.cgi?id=101973

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-12
Reviewed by Adrienne Walker.

Rebaselined failing video LayouTests caused by different filtering
result between Skia and Mesa for the software compositor.

* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd DOMRequestState to maintain world/ScriptExecutionContext state
alecflett@chromium.org [Wed, 14 Nov 2012 19:16:36 +0000 (19:16 +0000)]
Add DOMRequestState to maintain world/ScriptExecutionContext state
https://bugs.webkit.org/show_bug.cgi?id=102102

Reviewed by Adam Barth.

Introduce DOMRequestState, and convert IndexedDB over.

No new tests, this is an abstraction layer for existing code.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* WebCore.gypi:
* bindings/v8/DOMRequestState.h: Added.
(WebCore):
(DOMRequestState):
(WebCore::DOMRequestState::DOMRequestState):
(Scope):
(WebCore::DOMRequestState::Scope::Scope):
(WebCore::DOMRequestState::scope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBoxes with rounded corners and thin borders are too slow to draw
junov@google.com [Wed, 14 Nov 2012 19:12:02 +0000 (19:12 +0000)]
Boxes with rounded corners and thin borders are too slow to draw
https://bugs.webkit.org/show_bug.cgi?id=101974

Reviewed by Simon Fraser.

Source/WebCore:

With the current implementation RenderBox::
determineBackgroundBleedAvoidance() uses the slow path
BackgroundBleedUseTransparencyLayer for some very common use cases,
notably for drawing rectangles with rounded corners that have thin
borders. This is because the BackgroundBleedShrinkBackground
strategy requires a border at least two pixels wide on all sides. This
patch introduce drawing strategy BackgroundBleedBackgroundOverBorder.
This approach consists in drawing the border first, with an inset inner
edge (for anti-aliased compositing to work well).  This approach only
works with opaque solid edges and opaque single-layer backgrounds.
By using this approach rather than BackgroundBleedUseTransparencyLayer,
we save two clipPath, one save and one saveLayer on the
GraphicsContext. This patch gets good coverage from existing layout
tests. One additional test was added to exercise mitring, thick edges
and anti-aliasing edge cases under the new painting algorithm.

Test: fast/borders/border-radius-wide-border-05.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance):
Added selection criteria for BackgroundOverBorder
(WebCore::RenderBox::paintBoxDecorations):
Added a preliminary paintBorder pass for BackgroundOverBorder
(WebCore::RenderBox::paintBackground):
Insetting the background to to innerBorder when bleedAvoidance is
BackgroundOverBorder.  This why BackgroundOverBorder only works for
Opaque solid edges.
(WebCore):
(WebCore::RenderBox::backgroundIsSingleOpaqueLayer):
Utility method use by determineBackgroundBleedAvoidance to test the
background's eligibility for BackgroundOverBorder bleed avoidance
strategy.  The reason the background must be a single layer is to avoid
color bleeding from layer compositing along anti-aliased edges
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::borderInnerRectAdjustedForBleedAvoidance):
Added support for BackgroundOverBorder by applying a one pixel inset.
(WebCore::RenderBoxModelObject::backgroundRoundedRectAdjustedForBleedAvoidance):
Set the background rect to the inner border for BackgroundOverBorder
(WebCore):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Added support for BackgroundOverBorder by using
backgroundRoundedRectAdjustedForBleedAvoidance
(WebCore::RenderBoxModelObject::paintBorderSides):
Added support for BackgroundOverBorder by applying per-side inset
adjustments.
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
Added support for BackgroundOverBorder by using an adjusted inner
border, but not if sides are painted individually.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):

LayoutTests:

New test that purposely triggers the BackgroundOverBorder painting path
in WebCore::RenderBox, to test it with thick borders, off-diagonal
mitring, an anti-aliased rounded border wedge, and a border of width 0.

* fast/borders/border-radius-wide-border-05.html: Added.
* fast/borders/border-radius-wide-border-05-expected.txt: Added.
* LayoutTests/platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png: Added.
* LayoutTests/platform/chromium/TestExpectations: Added Expectations.
Added expectations for tests pixels results that require rebaselining

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Break suspend/resume of the backingstore and screen into separate methods
commit-queue@webkit.org [Wed, 14 Nov 2012 19:03:10 +0000 (19:03 +0000)]
[BlackBerry] Break suspend/resume of the backingstore and screen into separate methods
https://bugs.webkit.org/show_bug.cgi?id=102126

Patch by Adam Treat <atreat@rim.com> on 2012-11-14
Reviewed by George Staikos.
PR 219976

Modify the suspend/resume methods so that they can be called from the UI thread
itself and split up the suspend/resume methods so that we can suspend/resume
the screen or backingstore separately.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
(BlackBerry::WebKit::BackingStore::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStore::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStore::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStore::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::destroy):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setBatchEditingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Fix cairo_t* memory leak in GraphicsContext::platformInit
bfulgham@webkit.org [Wed, 14 Nov 2012 18:53:36 +0000 (18:53 +0000)]
[WinCairo] Fix cairo_t* memory leak in GraphicsContext::platformInit
https://bugs.webkit.org/show_bug.cgi?id=76219

Patch by Hideki Yoshida <yoshida-hxa@necst.nec.co.jp> on 2012-11-14
Reviewed by Brent Fulgham.

This patch is to fix a memory leak problem which occurs
in every rendering process on Wincairo port.
By applying this patch, the memory allocated in cairo
library will be released by calling cairo_destroy.

* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize painting of composited scrolling layers
commit-queue@webkit.org [Wed, 14 Nov 2012 18:51:51 +0000 (18:51 +0000)]
Optimize painting of composited scrolling layers
https://bugs.webkit.org/show_bug.cgi?id=96087

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-14
Reviewed by Simon Fraser.

Source/WebCore:

Don't completely repaint accelerated scrolling layers when the scroll offset
changes.

Test: compositing/overflow/scrolling-without-painting.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setOffsetFromRenderer):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

Test that accelerated scrolling layers can be scrolled without repainting
their contents. Note that this test will not pass unless
ENABLE_ACCELERATED_OVERFLOW_SCROLLING is enabled.

* compositing/overflow/scrolling-without-painting-expected.txt: Added.
* compositing/overflow/scrolling-without-painting.html: Added.
* platform/chromium/TestExpectations: Mark test as expected to fail
  by default.
* platform/mac/TestExpectations: Skip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: keep track of mutation observers and disconnect them upon upload
pfeldman@chromium.org [Wed, 14 Nov 2012 18:48:59 +0000 (18:48 +0000)]
Web Inspector: keep track of mutation observers and disconnect them upon upload
https://bugs.webkit.org/show_bug.cgi?id=102239

Reviewed by Vsevolod Vlasov.

Otherwise we hit memory leaks.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._wasShown):
(WebInspector.TextEditorMainPanel.prototype._willHide):
(WebInspector.TextEditorMainPanel.prototype._attachMutationObserver):
(WebInspector.TextEditorMainPanel.prototype._detachMutationObserver):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice().
reed@google.com [Wed, 14 Nov 2012 18:43:21 +0000 (18:43 +0000)]
Dynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice().
https://bugs.webkit.org/show_bug.cgi?id=102242

Reviewed by Stephen White.

This change should not change any test results, it is an equivalent implementation that avoids
using a (now) DEPRECATED function.

* tests/DeferredImageDecoderTest.cpp:
(WebCore::createRasterCanvas):
(WebCore):
(WebCore::DeferredImageDecoderTest::SetUp):
(DeferredImageDecoderTest):
(WebCore::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline fast/media/mq-js-media-except-01.html after r134618.
dglazkov@chromium.org [Wed, 14 Nov 2012 18:39:37 +0000 (18:39 +0000)]
Rebaseline fast/media/mq-js-media-except-01.html after r134618.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add FocusBased context node detection strategy
commit-queue@webkit.org [Wed, 14 Nov 2012 18:37:56 +0000 (18:37 +0000)]
[BlackBerry] Add FocusBased context node detection strategy
https://bugs.webkit.org/show_bug.cgi?id=102238

Patch by Andy Chen <andchen@rim.com> on 2012-11-14
Reviewed by Rob Buis.

If last fat finger result is invalid, we need to return current
focus element as context node, because when user tap on selection
overlay, there is not touch event sent to webkit.
PR 241382

Internally reviewed by Genevieve Mak and Mike Fenton.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
* Api/WebPage.h:
* WebKitSupport/InputHandler.h:
(BlackBerry::WebKit::InputHandler::currentFocusElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeliver data from NetworkProcess to resources progressively.
beidson@apple.com [Wed, 14 Nov 2012 18:20:52 +0000 (18:20 +0000)]
Deliver data from NetworkProcess to resources progressively.
https://bugs.webkit.org/show_bug.cgi?id=102171

Reviewed by Alexey Proskuryakov.

Instead of buffering up the data for an entire resource and delivering it in one chunk, we need
to deliver data progressively.

This allows progressive parsing of textual resources and progressive rendering of images,
as well as allows endless multipart resources (e.g., multipart jpegs) to work at all.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveData): Don't buffer data locally (for now) but rather
  pass it straight through to the WebProcess.
(WebKit::NetworkResourceLoader::didFinishLoading): Only notify didFinishLoading instead of
  delivering a chunk of buffered data.
(WebKit::NetworkResourceLoader::didFail):
* NetworkProcess/NetworkResourceLoader.h:

* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveData): Pass through towards ResourceLoader.
(WebKit::NetworkProcessConnection::didFinishResourceLoad):
(WebKit::NetworkProcessConnection::didFailResourceLoad):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::didReceiveData): Hand this chunk of data to the ResourceLoader directly.
(WebKit::WebResourceLoadScheduler::didFinishResourceLoad):
* WebProcess/Network/WebResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Mark webgl-background-color.html as failing.
dglazkov@chromium.org [Wed, 14 Nov 2012 18:07:01 +0000 (18:07 +0000)]
[Chromium] Mark webgl-background-color.html as failing.
http://webkit.org/b/102247

* platform/chromium/TestExpectations: Marked as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
arv@chromium.org [Wed, 14 Nov 2012 17:57:27 +0000 (17:57 +0000)]
Unreviewed gardening.

Updating pixel tests expectations after r134613

* LayoutTests/platform/chromium/TestExpectations:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png:
* platform/efl-wk1/svg/dom/SVGLengthList-getItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-getItem-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-removeItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-removeItem-expected.png.
* platform/efl-wk1/svg/dom/SVGTransformList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGTransformList-basics-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use a node image if there is no drag image set for Drag&Drop
sergio@webkit.org [Wed, 14 Nov 2012 17:46:26 +0000 (17:46 +0000)]
[Qt] Use a node image if there is no drag image set for Drag&Drop
https://bugs.webkit.org/show_bug.cgi?id=102124

Reviewed by Simon Hausmann.

Use the nodeImage provided by the frame if there is no dragImage in
the clipboard for the current drag&drop operation.

* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCall to enclosingFilterLayer() in RenderObject::containerForRepaint() is expensive
commit-queue@webkit.org [Wed, 14 Nov 2012 17:37:48 +0000 (17:37 +0000)]
Call to enclosingFilterLayer() in RenderObject::containerForRepaint() is expensive
https://bugs.webkit.org/show_bug.cgi?id=101846

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-11-14
Reviewed by Simon Fraser.

If software-rendered CSS Filters have not been used in the document, avoid doing the second
tree walk in RenderObject::containerForRepaint, which determines the RenderObject's
enclosing filter layer.

No new tests. We now avoid a filters related code path for a performance improvement when
we're not using filters.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
* page/FrameView.h:
(FrameView):
(WebCore::FrameView::setHasSoftwareFilters):
(WebCore::FrameView::hasSoftwareFilters):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: NotFoundError
arv@chromium.org [Wed, 14 Nov 2012 17:33:01 +0000 (17:33 +0000)]
Update DOMException name: NotFoundError
https://bugs.webkit.org/show_bug.cgi?id=102137

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 8 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/Document/replaceChild-null-oldChild-expected.txt:
* fast/dom/Document/script-tests/replaceChild-null-oldChild.js:
* fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
* fast/dom/Range/range-intersectsNode-expected.txt:
* fast/dom/incompatible-operations-expected.txt:
* fast/dom/incompatible-operations.html:
* fast/dom/setter-type-enforcement-expected.txt:
* fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* fast/events/remove-target-with-shadow-in-drag-expected.txt:
* fast/files/workers/worker-read-blob-sync-expected.txt:
* fast/files/workers/worker-read-file-sync-expected.txt:
* fast/inspector-support/uncaught-dom8-exception-expected.txt:
* fast/js/dot-node-base-exception-expected.txt:
* fast/js/script-tests/dot-node-base-exception.js:
* fast/mutation/observe-exceptions-expected.txt:
* platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
* platform/chromium-win/fast/media/mq-js-media-except-01-expected.txt:
* platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
* platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* platform/chromium/fast/events/remove-target-with-shadow-in-drag-expected.txt:
* platform/chromium/fast/files/workers/worker-read-blob-sync-expected.txt:
* platform/chromium/fast/inspector-support/uncaught-dom8-exception-expected.txt:
* platform/chromium/fast/media/mq-js-media-except-01-expected.txt:
* platform/efl/fast/media/mq-js-media-except-01-expected.txt:
* platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt:
* platform/gtk/fast/media/mq-js-media-except-01-expected.txt:
* platform/mac/fast/media/mq-js-media-except-01-expected.txt:
* platform/qt/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark files that need rebaselines as failing.
dglazkov@chromium.org [Wed, 14 Nov 2012 17:07:11 +0000 (17:07 +0000)]
Mark files that need rebaselines as failing.
https://bugs.webkit.org/show_bug.cgi?id=102087

* platform/chromium/TestExpectations: Added expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Use mispelled-marker offsets relative to the element
commit-queue@webkit.org [Wed, 14 Nov 2012 17:04:30 +0000 (17:04 +0000)]
[BlackBerry] Use mispelled-marker offsets relative to the element
https://bugs.webkit.org/show_bug.cgi?id=102236

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-14
Reviewed by Rob Buis.

DocumentMarker offsets are calculated relative to a node. This is causing
problems for contenteditable which can have numerous nodes. Creating a Range around a word
and calculating its location and length gives us the correct override in this case for starting
and ending points to pass to IMF.

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Updating BB Cookie database to use WAL
commit-queue@webkit.org [Wed, 14 Nov 2012 16:53:06 +0000 (16:53 +0000)]
[BlackBerry] Updating BB Cookie database to use WAL
https://bugs.webkit.org/show_bug.cgi?id=102237

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-14
Reviewed by Rob Buis.

The cookie database is accessed by one process only and should be updated to
use the WAL journal mode for better I/O performance.

PR 236553

cookieCollection.db-wal is created after the conversion to WAL.
Tested cookie persistence by logging on to random sites and restarting the browser and
check if it automatically logs in.
Also tested using Opera's cookie persistence test.

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::invokeOpen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
commit-queue@webkit.org [Wed, 14 Nov 2012 16:31:03 +0000 (16:31 +0000)]
[Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
https://bugs.webkit.org/show_bug.cgi?id=102083

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Modified compiler name regex in condition that tests if -std=c++0x, c++11,
gnu++0x or gnu++11 are enabled in order to match linux-arm-gnueabi-g++ too,
thus enabling -Wno-c++0x-compat also on ARM compiler.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: IndexSizeError
arv@chromium.org [Wed, 14 Nov 2012 16:26:18 +0000 (16:26 +0000)]
Update DOMException name: IndexSizeError
https://bugs.webkit.org/show_bug.cgi?id=102087

Reviewed by Ojan Vafai.

Source/WebCore:

This is the first in a series of updates to DOMException name to match
the spec and Firefox.

Patch 1 of 25

Updated existing tests.

* dom/DOMCoreException.cpp:
(WebCore):

LayoutTests:

Updated tests and expectations.

* editing/selection/extend-expected.txt:
* fast/canvas/canvas-getImageData-invalid-expected.txt:
* fast/canvas/canvas-overloads-drawImage-expected.txt:
* fast/canvas/script-tests/canvas-getImageData-invalid.js:
* fast/canvas/script-tests/canvas-overloads-drawImage.js:
* fast/canvas/webgl/data-view-test-expected.txt:
* fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
* fast/dom/HTMLInputElement/input-size-attribute.html:
* fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
* fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
* fast/dom/css-mediarule-functions-expected.txt:
* fast/dom/css-mediarule-functions.html:
* fast/forms/input-maxlength-expected.txt:
* fast/forms/input-maxlength.html:
* fast/forms/number/number-size-expected.txt:
* fast/forms/number/number-size.html:
* fast/forms/search/search-setrangetext-expected.txt:
* fast/forms/setrangetext-expected.txt:
* fast/forms/textarea-maxlength-expected.txt:
* fast/forms/textarea-maxlength.html:
* fast/forms/textarea/textarea-setrangetext-expected.txt:
* fast/html/marquee-element-expected.txt:
* fast/inspector-support/uncaught-dom1-exception-expected.txt:
* fast/js/select-options-add-expected.txt:
* fast/speech/scripted/speechgrammar-basics-expected.txt:
* inspector/styles/set-property-boundaries-expected.txt:
* platform/chromium-mac/fast/dynamic/015-expected.txt:
* platform/chromium-win/fast/dynamic/015-expected.txt:
* platform/chromium/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/chromium/fast/inspector-support/uncaught-dom1-exception-expected.txt:
* platform/efl/fast/dynamic/015-expected.txt:
* platform/gtk/fast/dynamic/015-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/mac/fast/dynamic/015-expected.txt:
* platform/qt/fast/dynamic/015-expected.txt:
* svg/custom/acid3-test-77-expected.txt:
* svg/custom/getSubStringLength-expected.txt:
* svg/custom/selectSubString-expected.txt:
* svg/dom/SVGLengthList-appendItem-expected.txt:
* svg/dom/SVGLengthList-basics-expected.txt:
* svg/dom/SVGLengthList-getItem-expected.txt:
* svg/dom/SVGLengthList-initialize-expected.txt:
* svg/dom/SVGLengthList-insertItemBefore-expected.txt:
* svg/dom/SVGLengthList-removeItem-expected.txt:
* svg/dom/SVGLengthList-replaceItem-expected.txt:
* svg/dom/SVGNumberList-basics-expected.txt:
* svg/dom/SVGPathSegList-clear-and-initialize-expected.txt:
* svg/dom/SVGPointList-basics-expected.txt:
* svg/dom/SVGStringList-basics-expected.txt:
* svg/dom/SVGTransformList-basics-expected.txt:
* svg/dom/svglist-exception-on-out-bounds-error-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][ARM]REGRESSION(r133985): It broke the build
ossy@webkit.org [Wed, 14 Nov 2012 16:18:10 +0000 (16:18 +0000)]
[Qt][ARM]REGRESSION(r133985): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=101740

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Changed the emitGenericContiguousPutByVal to accept the additional IndexingType argument.
This information was passed as a template parameter.

* jit/JIT.h:
(JSC::JIT::emitInt32PutByVal):
(JSC::JIT::emitDoublePutByVal):
(JSC::JIT::emitContiguousPutByVal):
(JIT):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGenericContiguousPutByVal):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGenericContiguousPutByVal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix [-Wmissing-braces] warnings in graphics/cpu/arm/GraphicsContext3DNEON.h
rgabor@webkit.org [Wed, 14 Nov 2012 16:02:43 +0000 (16:02 +0000)]
Fix [-Wmissing-braces] warnings in graphics/cpu/arm/GraphicsContext3DNEON.h
https://bugs.webkit.org/show_bug.cgi?id=102205

Reviewed by Csaba Osztrogonác.

Fixing some warnings in GraphicsContext3DNEON.h which have been caused by missing braces.

* platform/graphics/cpu/arm/GraphicsContext3DNEON.h:
(WebCore::ARM::unpackOneRowOfRGBA4444ToRGBA8NEON):
(WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON):
(WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: NoDataAllowedError
arv@chromium.org [Wed, 14 Nov 2012 15:55:48 +0000 (15:55 +0000)]
Update DOMException name: NoDataAllowedError
https://bugs.webkit.org/show_bug.cgi?id=102132

Reviewed by Darin Adler.

Patch 6 of 25 to update DOMException name to match the spec and Firefox.

NO_DATA_ALLOWED_ERR is historical and not used in any spec or in our code.

* dom/DOMCoreException.cpp:
(WebCore):
* dom/ExceptionCode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][ARM] Enable the DFG JIT on ARMv7(Thumb2)
ossy@webkit.org [Wed, 14 Nov 2012 15:35:38 +0000 (15:35 +0000)]
[Qt][ARM] Enable the DFG JIT on ARMv7(Thumb2)
https://bugs.webkit.org/show_bug.cgi?id=101747

Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the MIPS build after r134332
commit-queue@webkit.org [Wed, 14 Nov 2012 15:25:25 +0000 (15:25 +0000)]
Fix the MIPS build after r134332
https://bugs.webkit.org/show_bug.cgi?id=102227

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Added missing methods for the MacroAssemblerMIPS, based on the MacroAssemblerARMv7.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add some missing pixel expectations.
rakuco@webkit.org [Wed, 14 Nov 2012 15:20:02 +0000 (15:20 +0000)]
[EFL] Add some missing pixel expectations.

* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
* platform/efl/fast/replaced/width100percent-textarea-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] WK1 gardening.
rakuco@webkit.org [Wed, 14 Nov 2012 15:14:41 +0000 (15:14 +0000)]
[EFL] WK1 gardening.

Skip fast/dom/Window/open-window-min-size.html and add some
WK1-specific pixel results which do not look wrong per se.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk1/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
* platform/efl-wk1/fast/repaint/selection-after-delete-expected.png: Added.
* platform/efl-wk1/fast/repaint/selection-after-remove-expected.png: Added.
* platform/efl-wk1/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: "Reveal in Element Panel" doesn't work if Elements panel hasn't been...
pfeldman@chromium.org [Wed, 14 Nov 2012 15:12:08 +0000 (15:12 +0000)]
Web Inspector: "Reveal in Element Panel" doesn't work if Elements panel hasn't been opened
https://bugs.webkit.org/show_bug.cgi?id=102219

Reviewed by Alexander Pavlov.

Force elements module load upon context menu invocation.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip failing tests.
kadam@inf.u-szeged.hu [Wed, 14 Nov 2012 14:52:25 +0000 (14:52 +0000)]
[Qt] Unreviewed gardening. Skip failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the [-Wreturn-type] warning in JavaScriptCore/assembler/MacroAssemblerARM.h
ossy@webkit.org [Wed, 14 Nov 2012 14:51:59 +0000 (14:51 +0000)]
Fix the [-Wreturn-type] warning in JavaScriptCore/assembler/MacroAssemblerARM.h
https://bugs.webkit.org/show_bug.cgi?id=102206

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Add a return value for the function to suppress the warning.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134599.
ossy@webkit.org [Wed, 14 Nov 2012 14:41:46 +0000 (14:41 +0000)]
Unreviewed, rolling out r134599.
http://trac.webkit.org/changeset/134599
https://bugs.webkit.org/show_bug.cgi?id=102225

It broke the 32 bit EFL build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
(JSC):
(JSC::JIT::emitGenericContiguousPutByVal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134523.
commit-queue@webkit.org [Wed, 14 Nov 2012 14:40:23 +0000 (14:40 +0000)]
Unreviewed, rolling out r134523.
http://trac.webkit.org/changeset/134523
https://bugs.webkit.org/show_bug.cgi?id=102218

brake chrome windows build, as it references a non existing
header js/DOMRequestState.h (Requested by jochen__ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

Source/WebCore:

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* WebCore.gypi:
* bindings/v8/DOMRequestState.h: Removed.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValue):
(WebCore::idbKeyToScriptValue):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):

Source/WebKit/chromium:

* src/WebIDBKey.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd platform implementation of remote web inspector server for GTK port.
commit-queue@webkit.org [Wed, 14 Nov 2012 14:26:14 +0000 (14:26 +0000)]
Add platform implementation of remote web inspector server for GTK port.
https://bugs.webkit.org/show_bug.cgi?id=88094

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2012-11-14
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Extra SocketStreamHandle constructor is added to accept existing GSocketConnection.
Needed to pass remote inspector server socket connection. The change is tested with
inspector server API tests.

* platform/network/soup/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
(SocketStreamHandle):
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

Source/WebKit2:

The platform implementation is based on GSocket API (WebInspectorServerGtk.cpp and WebSocketServerGtk.cpp).
The server listens on port 2999 by default. IP address of the server can be set
in WEBKIT_INSPECTOR_SERVER (for example export WEBKIT_INSPECTOR_SERVER="192.168.124.130:2999").
The server is started during WebKit context initialization.
Once a page is loaded insector server can be accessed via other WebKit based browser.
New WebKit API gtk tests have beed added.
inspectorPageIndex.html has been moved to new location to share the file between GTK and Qt ports.

Test: test-page-list, test-remote-debugging-message, test-open-debugging-session

* GNUmakefile.am:
* GNUmakefile.list.am:
* Platform/Logging.cpp:
(WebKit):
(WebKit::getChannelFromName):
(WebKit::initializeLogChannelsIfNecessary):
* Platform/Logging.h:
(WebKit):
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/InspectorTestServer.cpp: Added.
(loadChangedCallback):
(main):
* UIProcess/API/gtk/tests/TestInspectorServer.cpp: Added.
(stopTestServer):
(sigAbortHandler):
(testServerMonitorThreadFunc):
(startTestServerMonitor):
(startTestServer):
(testInspectorServerPageList):
(testRemoteDebuggingMessage):
(openRemoteDebuggingSession):
(beforeAll):
(afterAll):
* UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
* UIProcess/InspectorServer/WebSocketServer.h:
(WebSocketServer):
* UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::shutdownAfterSendOrNow):
(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
(WebKit):
(WebKit::WebSocketServerConnection::didUpdateBufferedAmount):
* UIProcess/InspectorServer/WebSocketServerConnection.h:
(WebSocketServerConnection):
* UIProcess/InspectorServer/front-end: Added.
* UIProcess/InspectorServer/front-end/inspectorPageIndex.html: Added.
* UIProcess/InspectorServer/gtk: Added.
* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp: Added.
(WebKit):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):
* UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp: Added.
(WebKit):
(WebKit::connectionCallback):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::initInspectorServer):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
* WebKit2.qrc:
* config.h:
* qt/Resources/inspectorPageIndex.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][ARM]REGRESSION(r133985): It broke the build
ossy@webkit.org [Wed, 14 Nov 2012 14:23:35 +0000 (14:23 +0000)]
[Qt][ARM]REGRESSION(r133985): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=101740

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Template function body moved to fix VALUE_PROFILER disabled case.

* jit/JITPropertyAccess.cpp:
(JSC):
(JSC::JIT::emitGenericContiguousPutByVal):
* jit/JITPropertyAccess32_64.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix for r134593.
loislo@chromium.org [Wed, 14 Nov 2012 14:03:20 +0000 (14:03 +0000)]
Unreviewed test fix for r134593.

* inspector-protocol/nmi-webaudio.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 14 Nov 2012 13:35:16 +0000 (13:35 +0000)]
[EFL] Unreviewed gardening.

anchor-*download.html wander between crashing and failing.
Marking winsize test as failure and added to bug.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
ossy@webkit.org [Wed, 14 Nov 2012 13:29:16 +0000 (13:29 +0000)]
[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237

Reviewed by Jocelyn Turcotte.

Uncomment this API test, because it works fine now.

* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame):
(tst_QWebFrame::setUrlWithPendingLoads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: context menu on ObjectPropertyTreeElement's values is masked by the...
pfeldman@chromium.org [Wed, 14 Nov 2012 13:14:42 +0000 (13:14 +0000)]
Web Inspector: context menu on ObjectPropertyTreeElement's values is masked by the section.
https://bugs.webkit.org/show_bug.cgi?id=102212

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r133757): Causing webkitpy unit tests to fail
commit-queue@webkit.org [Wed, 14 Nov 2012 12:39:09 +0000 (12:39 +0000)]
REGRESSION(r133757): Causing webkitpy unit tests to fail
https://bugs.webkit.org/show_bug.cgi?id=101444

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-14
Reviewed by Csaba Osztrogonác.

Updated the bot name on the unit tests.

* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: NMI add instrumentation for WebAudo related stuff.
loislo@chromium.org [Wed, 14 Nov 2012 12:13:06 +0000 (12:13 +0000)]
Web Inspector: NMI add instrumentation for WebAudo related stuff.
They use about 16Mb for shared data on pages with webaudio.
As example Angry Birds app.
https://bugs.webkit.org/show_bug.cgi?id=101729

Reviewed by Yury Semikhatsky.

Plain vanilla instrumentation for audio and webaudio classes.
AudioContext is a kind of ActiveDOMObject. I found that these objects
are accessible through ScriptExecutuionContext and ScriptExecutionContext
is an ancestor of Document. Document class was instrumented earler.
I instrumented ActiveDOMObject, ScriptExecutionContext and other ancestors
and now AudioContext and other ActiveDOMObjects are reacheable from Document.

Source/WebCore:

Test: inspector-protocol/nmi-webaudio.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::reportMemoryUsage):
(WebCore):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::reportMemoryUsage):
(WebCore):
* Modules/webaudio/AudioNode.h:
(AudioNode):
* dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::reportMemoryUsage):
(WebCore):
* dom/ActiveDOMObject.h:
(ActiveDOMObject):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportMemoryUsage):
(WebCore):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::reportMemoryUsage):
(WebCore):
* dom/SecurityContext.h:
(SecurityContext):
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* platform/audio/AudioArray.h:
(AudioArray):
(WebCore::AudioArray::reportMemoryUsage):
* platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
(WebCore):
* platform/audio/FFTFrame.h:
(FFTFrame):
* platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::reportMemoryUsage):
(WebCore):
* platform/audio/HRTFDatabase.h:
(HRTFDatabase):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::reportMemoryUsage):
(WebCore):
* platform/audio/HRTFDatabaseLoader.h:
(HRTFDatabaseLoader):
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::reportMemoryUsage):
(WebCore):
* platform/audio/HRTFElevation.h:
(HRTFElevation):
* platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::reportMemoryUsage):
(WebCore):
* platform/audio/HRTFKernel.h:
(HRTFKernel):

LayoutTests:

* inspector-protocol/nmi-webaudio-expected.txt: Added.
* inspector-protocol/nmi-webaudio.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Settings screen: close button overlays view title on mac.
commit-queue@webkit.org [Wed, 14 Nov 2012 11:45:49 +0000 (11:45 +0000)]
Web Inspector: Settings screen: close button overlays view title on mac.
https://bugs.webkit.org/show_bug.cgi?id=102198

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-14
Reviewed by Pavel Feldman.

Added margin-left for mac. Adjusted title height and vertical positioning.

* inspector/front-end/helpScreen.css:
(.help-window-caption): Adjusted title height.
(.help-window-title): Adjusted title vertical positioning.
(body.platform-mac .help-window-main .help-window-title): Fixed margin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: use last selection as complementary signal when applying DOM changes...
pfeldman@chromium.org [Wed, 14 Nov 2012 11:32:35 +0000 (11:32 +0000)]
Web Inspector: use last selection as complementary signal when applying DOM changes to the text model.
https://bugs.webkit.org/show_bug.cgi?id=101905

Reviewed by Vsevolod Vlasov.

Currently we use heuristics for detecting damaged model range upon DOM mutation.
This change adds signals from the last selection and keyboard events in order to
further improve the heuristics quality.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.EditInfo):
(WebInspector.DefaultTextEditor.prototype._handleTextInput):
(WebInspector.DefaultTextEditor.prototype._handleKeyDown):
(WebInspector.DefaultTextEditor.prototype.lastSelection):
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnDiff):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.prototype.compareTo):
(WebInspector.TextRange.prototype.shift):
(WebInspector.TextEditorModel.endsWithBracketRegex.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2][AC] Print out warning if we fallback back to software mode
commit-queue@webkit.org [Wed, 14 Nov 2012 11:24:53 +0000 (11:24 +0000)]
[EFL][WK2][AC] Print out warning if we fallback back to software mode
https://bugs.webkit.org/show_bug.cgi?id=102188

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-14
Reviewed by Kenneth Rohde Christiansen.

Print out a warning if accelerated compositing is enabled but the
implementation is falling back to software mode for some reason.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::createGLSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: proper baselines for inspector's timeline-timer-fired-from-eval-call...
pfeldman@chromium.org [Wed, 14 Nov 2012 11:21:49 +0000 (11:21 +0000)]
Not reviewed: proper baselines for inspector's timeline-timer-fired-from-eval-call-site.

* inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] use toV8Fast in all relevant Node getters
commit-queue@webkit.org [Wed, 14 Nov 2012 11:14:20 +0000 (11:14 +0000)]
[V8] use toV8Fast in all relevant Node getters
https://bugs.webkit.org/show_bug.cgi?id=100851

Patch by Dan Carney <dcarney@google.com> on 2012-11-14
Reviewed by Kentaro Hara.

The toV8Fast function for Node objects is now called in all getters
instead of toV8.

No new tests. Test coverage extensive.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(IsDOMNodeType):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8Fast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] QStyleFacadeImp should use a QPointer to store the application style
abecsi@webkit.org [Wed, 14 Nov 2012 11:05:55 +0000 (11:05 +0000)]
[Qt] QStyleFacadeImp should use a QPointer to store the application style
https://bugs.webkit.org/show_bug.cgi?id=102084

Reviewed by Simon Hausmann.

QStyleFacadeImp implicitly creates a default style during the first
call to QApplication::style() in QStyleFacadeImp::style() but this
style is deleted when a custom style is set, thus the stored m_style
raw pointer in QStyleFacadeImp becomes dangling.
Use a QPointer to cache the style instead of a raw pointer.

This fixes the start-up crash in the anomaly example.
(https://bugreports.qt-project.org/browse/QTBUG-27924)

* WebCoreSupport/QStyleFacadeImp.h:
(QStyleFacadeImp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up use of adjustWindowRect
kenneth@webkit.org [Wed, 14 Nov 2012 11:05:20 +0000 (11:05 +0000)]
Clean up use of adjustWindowRect
https://bugs.webkit.org/show_bug.cgi?id=102072

Reviewed by Gyuyoung Kim.

Source/WebCore:

Tested by fast/dom/Window/open-window-min-size.html

* loader/FrameLoader.cpp:
(WebCore::createWindow):

    Validate the window size here so that it is not just done for
    .open, but also for .showModalDialog. This is compatible with
    other browsers such as IE and Firefox (though IE > 6, enforces
    a minimum width of 250 instead of 100 as Firefox and us.)

* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect):

    Make it a static method which only takes page. It was never
    called from anywhere without a valid page, so the page check
    has been turned into an assert, and two of the arguments have
    been removed as they can be accessed via the page.

(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

    Update use of adjustWindowRect.

(WebCore::DOMWindow::open):

    Avoid modifying the WindowFeatures as the WebCore::createWindow
    validates and adjusts the arguments.

* page/DOMWindow.h:
(DOMWindow):

LayoutTests:

Test that minimum sizes are honored.

* fast/dom/Window/open-window-min-size.html: Added.
* fast/dom/Window/open-window-min-size-expected.txt: Added.
* fast/dom/Window/resources/report-size-and-close.html: Added.
* platform/mac/TestExpectations: Skipped as it times out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixed lint error.
haraken@chromium.org [Wed, 14 Nov 2012 10:57:21 +0000 (10:57 +0000)]
Unreviewed. Fixed lint error.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when replacing parts of text inputs with content: url(...)
tasak@google.com [Wed, 14 Nov 2012 10:47:15 +0000 (10:47 +0000)]
Crash when replacing parts of text inputs with content: url(...)
https://bugs.webkit.org/show_bug.cgi?id=101133

Reviewed by Kent Tamura.

Source/WebCore:

Disable directly setting content of elements in an input element's
shadow dom tree, because the setting breaks input element's behavior.

Tests: fast/forms/number/number-content-url-crash.html
       fast/forms/search/search-content-url-crash.html

* css/html.css:
(input::-webkit-textfield-decoration-container):
Use important to disable overriding an input element's content
property.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attach):
Added ASSERTION. No content should be applied to
input::-webkit-textfield-decoration-container.

LayoutTests:

* fast/forms/number/number-content-url-crash-expected.txt: Added.
* fast/forms/number/number-content-url-crash.html: Added.
* fast/forms/search/search-content-url-crash-expected.txt: Added.
* fast/forms/search/search-content-url-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Rename variables, structures and functions of the MiniBrowser.
commit-queue@webkit.org [Wed, 14 Nov 2012 10:44:16 +0000 (10:44 +0000)]
[EFL][WK2] Rename variables, structures and functions of the MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=101517

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-14
Reviewed by Gyuyoung Kim.

Rename variables, structures and functions of the MiniBrowser
for the naming consistency.

1) Browser_Window* {app_data|browser_window|window} -> window

2) Browser_Window::webview -> Browser_Window::ewk_view
     The webkit API functions are ewk_view_xxx not webview_xxx.
     So using ewk_view will be better than webview.

3) Browser_Window::window -> Browser_Window::elm_window
     The name is changed to be distinguished with 'Browser_Window *window'

4) browser_{window|view}_find() -> window_find_with_{elm_window|ewk_view}()
     This is changed because the name of the function can be confused.
     Currently, browser_window_find() returns Browser_Window*. And
     browser_view_find() also returns Browser_Window*.

5) FileSelectorData -> File_Selector_Data / AuthData -> Auth_Data
     The type definition is moved to the top of the source file
     and the name is changed to follow EFL style.

* MiniBrowser/efl/main.c:
(miniBrowserViewSmartClass):
(_Browser_Window):
(_File_Selector_Data):
(_Auth_Data):
(window_find_with_ewk_view):
(window_free):
(on_key_down):
(view_focus_set):
(on_mouse_down):
(title_set):
(on_title_changed):
(on_url_changed):
(on_back_forward_list_changed):
(on_new_window):
(on_close_window):
(on_progress):
(on_error):
(on_download_request):
(close_file_picker):
(on_filepicker_parent_deletion):
(on_filepicker_deletion):
(on_fileselector_done):
(on_file_chooser_request):
(on_download_finished):
(on_download_failed):
(on_favicon_received):
(on_view_icon_changed):
(on_url_bar_activated):
(on_url_bar_clicked):
(on_back_button_clicked):
(on_forward_button_clicked):
(on_refresh_button_clicked):
(on_javascript_alert):
(on_javascript_confirm):
(on_javascript_prompt):
(on_window_geometry_get):
(on_window_geometry_set):
(on_fullscreen_deny):
(on_fullscreen_enter):
(on_fullscreen_exit):
(auth_popup_close):
(on_auth_cancel):
(on_auth_ok):
(on_authentication_request):
(on_tooltip_text_set):
(on_tooltip_text_unset):
(on_home_button_clicked):
(on_window_deletion):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests results.
haraken@chromium.org [Wed, 14 Nov 2012 10:38:32 +0000 (10:38 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::wrapSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 14 Nov 2012 10:24:39 +0000 (10:24 +0000)]
[EFL] Unreviewed gardening.

The bots don't have mercy today.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProvide return types for custom WebGLRenderingContext methods
antonm@chromium.org [Wed, 14 Nov 2012 10:06:37 +0000 (10:06 +0000)]
Provide return types for custom WebGLRenderingContext methods
https://bugs.webkit.org/show_bug.cgi?id=100777

Reviewed by Kenneth Russell.

No new tests as doesn't change generated code.

* html/canvas/WebGLRenderingContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport for localization tests of calendar picker
tkent@chromium.org [Wed, 14 Nov 2012 10:05:15 +0000 (10:05 +0000)]
Support for localization tests of calendar picker
https://bugs.webkit.org/show_bug.cgi?id=102181

Reviewed by Kentaro Hara.

Source/WebCore:

Introduce DateTimeChooserParameters::locale to inform locale to
DateTimeChooser implementations. However we pass defaultLanguage
unless tests calls internals.settings.
setLangAttributeAwareFormControlUIEnabled(true) explicitly.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
Set DateTimeChooserParameters::locale up.
* platform/DateTimeChooser.h:
(DateTimeChooserParameters): Add 'locale' member.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
Use DateTimeChooserParameters::locale.
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::writeDocument):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Turn on error on warnings for "sign-compare"
commit-queue@webkit.org [Wed, 14 Nov 2012 09:57:50 +0000 (09:57 +0000)]
[EFL] Turn on error on warnings for "sign-compare"
https://bugs.webkit.org/show_bug.cgi?id=101761

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-14
Reviewed by Gyuyoung Kim.

Remove "-Wno-error=sign-compare" to turn on error on warnings for "sign-compare"

* Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: highlight is not updating as one edits CSS properties
pfeldman@chromium.org [Wed, 14 Nov 2012 09:57:24 +0000 (09:57 +0000)]
Web Inspector: highlight is not updating as one edits CSS properties
https://bugs.webkit.org/show_bug.cgi?id=102191

Reviewed by Alexander Pavlov.

We should update highlight upon layout / style recalculation.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::didScroll):
(WebCore):
(WebCore::InspectorPageAgent::didRecalculateStyle):
* inspector/InspectorPageAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134566.
haraken@chromium.org [Wed, 14 Nov 2012 09:54:14 +0000 (09:54 +0000)]
Unreviewed, rolling out r134566.
http://trac.webkit.org/changeset/134566
https://bugs.webkit.org/show_bug.cgi?id=102197

"it broke Chromium Android Release build" (Requested by
haraken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

Source/WebCore:

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
* platform/DateTimeChooser.h:
(DateTimeChooserParameters):

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::writeDocument):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.txt: Removed.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 09:34:47 +0000 (09:34 +0000)]
Unreviewed GTK gardening.

Updating the platform-specific baseline for fast/js/global-constructors.html
and removing the failure expectation for said test.

* platform/gtk/TestExpectations:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: No content available for requests made from flash
vsevik@chromium.org [Wed, 14 Nov 2012 09:30:34 +0000 (09:30 +0000)]
Web Inspector: No content available for requests made from flash
https://bugs.webkit.org/show_bug.cgi?id=101560

Reviewed by Pavel Feldman.

Network request data is now saved to inspector cache in following cases:
 - Error status code;
 - No cached resource available;
 - Cached resource has ShouldNotBufferData option set.
Drive-by: refactored didReceiveResponse logic to be clearer.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldBufferData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Timeline: 'undefined' javascript filenames.
commit-queue@webkit.org [Wed, 14 Nov 2012 09:29:18 +0000 (09:29 +0000)]
Web Inspector: Timeline: 'undefined' javascript filenames.
https://bugs.webkit.org/show_bug.cgi?id=101334

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-14
Reviewed by Yury Semikhatsky.

Test that callSite for TimerFired is resolved even for evaled scripts.

* inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt: Added.
* inspector/timeline/timeline-timer-fired-from-eval-call-site.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanging pseudoClass (:target) should cause distribution
shinyak@chromium.org [Wed, 14 Nov 2012 09:28:11 +0000 (09:28 +0000)]
Changing pseudoClass (:target) should cause distribution
https://bugs.webkit.org/show_bug.cgi?id=101699

Reviewed by Hajime Morita.

Source/WebCore:

When cssTarget element is changed, we might have to invalidate distribution. We check its necessity
by consulting with SelectRuleFeatureSet.

We also implement invalidateParentDistributionIfNecessary for all collected features in this patch.

Test: fast/dom/shadow/pseudoclass-update-target.html

* dom/Document.cpp:
(WebCore::Document::setCSSTarget):
* dom/ElementShadow.cpp:
(WebCore::invalidateParentDistributionIfNecessary):
(WebCore):
* dom/ElementShadow.h:
(WebCore):
* html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorFor):
(SelectRuleFeatureSet):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-target-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134531.
dominik.rottsches@intel.com [Wed, 14 Nov 2012 09:24:14 +0000 (09:24 +0000)]
Unreviewed, rolling out r134531.
http://trac.webkit.org/changeset/134531
https://bugs.webkit.org/show_bug.cgi?id=102193

Makes >70 tests crash on EFL and Qt bots. (Requested by drott
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
(WebCore::CoordinatedGraphicsLayer::setCoordinatedGraphicsLayerClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::createGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 14 Nov 2012 09:22:30 +0000 (09:22 +0000)]
[EFL] Unreviewed gardening.

Mark two failures after r134456.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] DOM wrapper objects should be collected in minor GC cycles
haraken@chromium.org [Wed, 14 Nov 2012 08:54:48 +0000 (08:54 +0000)]
[V8] DOM wrapper objects should be collected in minor GC cycles
https://bugs.webkit.org/show_bug.cgi?id=98725

Reviewed by Adam Barth.

Previously minor GC cycles cannot collect DOM Nodes. All DOM Nodes
have to survive two minor GC cycles, be promoted to the old space
and wait for a heavy major GC cycle.

This patch enables V8 to collect DOM Nodes in minor GC cycles.
For real world applications, I confirmed that minor GC cycles
reclaims a substantial amount of memory (24 MB for Facebook,
235 MB for Google Calendar) with acceptable overhead (~10 ms
per minor GC cycle). No performance regression in Dromaeo
DOM tests.

A design document: https://docs.google.com/a/google.com/document/d/16DeHrzkm3cO9XCPT1aK3Y5qgUxXB3RFmueqQWYmN2rI/edit
Performance results: https://docs.google.com/a/google.com/document/d/1h0-EsHu7T0sSMuZm5eE0r1e8sCAzY3weLvsDUpOSngE/edit
A slide: https://docs.google.com/a/google.com/presentation/d/1uifwVYGNYTZDoGLyCb7sXa7g49mWNMW2gaWvMN5NLk8/edit#slide=id.p

* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::set):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::initializeV8IfNeeded):
* bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::newWrapperBorn):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::minorGCEpilogue):
(WebCore::V8GCController::majorGCEpilogue):
* bindings/v8/V8GCController.h:
(WebCore):
(V8GCController):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):
* dom/Element.cpp:
(WebCore::Element::focus):
* dom/Node.h:
(WebCore::Node::inEden):
(WebCore::Node::setEden):
(Node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Update the EFL list of bots
commit-queue@webkit.org [Wed, 14 Nov 2012 08:52:18 +0000 (08:52 +0000)]
webkitpy: Update the EFL list of bots
https://bugs.webkit.org/show_bug.cgi?id=102121

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-14
Reviewed by Kenneth Rohde Christiansen.

Update the EFL bots so we can use garden-o-matic.

* Scripts/webkitpy/layout_tests/port/builders.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Replace setDOMWrapper() + setJSWrapperForDOMObject() with createDOMWrapper()
haraken@chromium.org [Wed, 14 Nov 2012 08:49:23 +0000 (08:49 +0000)]
[V8] Replace setDOMWrapper() + setJSWrapperForDOMObject() with createDOMWrapper()
https://bugs.webkit.org/show_bug.cgi?id=101917

Reviewed by Adam Barth.

setJSWrapperForDOMObject() is always coupled with setDOMWrapper().
We can replace setDOMWrapper() + setJSWrapperForDOMObject() with
createDOMWrapper(). (c.f. CREATE_DOM_WRAPPER() in JSC)

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::createDOMWrapper):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport for localization tests of calendar picker
tkent@chromium.org [Wed, 14 Nov 2012 08:43:26 +0000 (08:43 +0000)]
Support for localization tests of calendar picker
https://bugs.webkit.org/show_bug.cgi?id=102181

Reviewed by Kentaro Hara.

Source/WebCore:

Introduce DateTimeChooserParameters::locale to inform locale to
DateTimeChooser implementations. However we pass defaultLanguage
unless tests calls internals.settings.
setLangAttributeAwareFormControlUIEnabled(true) explicitly.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
Set DateTimeChooserParameters::locale up.
* platform/DateTimeChooser.h:
(DateTimeChooserParameters): Add 'locale' member.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
Use DateTimeChooserParameters::locale.
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::writeDocument):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 08:29:44 +0000 (08:29 +0000)]
Unreviewed GTK gardening.

Moving some expectations into a more proper section while
merging the others.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Show total memory in the NMI snapshot header
commit-queue@webkit.org [Wed, 14 Nov 2012 08:20:18 +0000 (08:20 +0000)]
Web Inspector: Show total memory in the NMI snapshot header
https://bugs.webkit.org/show_bug.cgi?id=101922

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-14
Reviewed by Pavel Feldman.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAfter r134205 was rolled out in http://trac.webkit.org/changeset/134425,
mihnea@adobe.com [Wed, 14 Nov 2012 08:18:59 +0000 (08:18 +0000)]
After r134205 was rolled out in trac.webkit.org/changeset/134425,
we have to re-enable the skipped tests that were failing because of r134205.
https://bugs.webkit.org/show_bug.cgi?id=102090

Reviewed by Adam Barth.

The initial rollout for r134205 and the related r134226, r134419 failed.

* platform/chromium/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove MemoryInstrumentationTest.ImageObserver
yurys@chromium.org [Wed, 14 Nov 2012 08:18:31 +0000 (08:18 +0000)]
Remove MemoryInstrumentationTest.ImageObserver
https://bugs.webkit.org/show_bug.cgi?id=102185

Reviewed by Pavel Feldman.

Removed obsolete memory instrumenation unit test.

* WebKit.gypi:
* tests/MemoryInstrumentationTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CodeMirrorTextEditor fails to scroll breakpoint into view after the...
commit-queue@webkit.org [Wed, 14 Nov 2012 08:12:22 +0000 (08:12 +0000)]
Web Inspector: CodeMirrorTextEditor fails to scroll breakpoint into view after the first time
https://bugs.webkit.org/show_bug.cgi?id=102142

Patch by Jan Keromnes <janx@linux.com> on 2012-11-14
Reviewed by Pavel Feldman.

Calling revealLine in highlightLine like in DefaultTextEditor does the trick.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add API to expose WebCore::DateTimeChooser
tkent@chromium.org [Wed, 14 Nov 2012 08:08:23 +0000 (08:08 +0000)]
[Chromium] Add API to expose WebCore::DateTimeChooser
https://bugs.webkit.org/show_bug.cgi?id=101196

Reviewed by Hajime Morita.

Add ability to open date/time choosers to WebViewClient.

- ExternalDateTimeChooser forwards DateTimeChooser requests from WebCore
  to WebViewClient, and waits for WebDateTimeChooerCompletion notifications.
- WebDateTimeChooserParams contains various information to create
  chooser UI.
- WebDateTimeChooserCompletion informs value selection by users to
  ExternalDateTimeChooser.

The design is very similar to existing WebFileChooserParams and
WebFileChooserCompletion.

These interfaces are used only if ENABLE_INPUT_MULTIPLE_FIELDS_UI is not
enabled, that is to say, in Chromium-Android port. Non-Android Chromium
ports use DateTimeChooserImpl and WebKit-internal choosers.

* WebKit.gyp: Add WebDateTimeChooserCompletion.h,
WebDateTimeChooserParams.h, ExternalDateTimeChooser.cpp, and
ExternalDateTimeChooser.h.
* public/WebDateTimeChooserCompletion.h: Added.
(WebDateTimeChooserCompletion):
(WebKit::WebDateTimeChooserCompletion::~WebDateTimeChooserCompletion):
* public/WebDateTimeChooserParams.h: Added.
(WebDateTimeChooserParams):
(WebKit::WebDateTimeChooserParams::WebDateTimeChooserParams):
* public/WebViewClient.h:
(WebKit): Add some forward declarations.
(WebKit::WebViewClient::openDateTimeChooser): Added.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Creates ExternalDateTimeChooser if !ENABLE(INPUT_MULTIPLE_FIELDS_UI).
* src/ExternalDateTimeChooser.cpp: Added.
(WebDateTimeChooserCompletionImpl): An implementation of
WebDateTimeChooserCompletion. When didChooseValue or didCancelChooser is
called, it notifies to an ExternalDateTimeChooser and kill itself.
(WebKit::ExternalDateTimeChooser::~ExternalDateTimeChooser): Added.
(WebKit::ExternalDateTimeChooser::ExternalDateTimeChooser): Added.
(WebKit::ExternalDateTimeChooser::create):
Cretes an object, then asks the WebViewClient to open date/time chooser.
If an open request fails, an empty PassRefPtr<> is returned.
We don't ask to open in the constructor because open requests might fail
and it's hard for the constructor to tell the failure.
(WebKit::ExternalDateTimeChooser::openDateTimeChooser): Prepares a
WebDateTimeChooserParams and a WebDateTimeChooserCompletion, calls
WebViewClient::openDateTimeChooser, and kill the
WebDateTimeChooserCompletion if openDateTimeChooser fails.
(WebKit::ExternalDateTimeChooser::didChooseValue):
Called by WebDateTimeChooserCompletion.
We need to check m_client because the requester is already dead.
(WebKit::ExternalDateTimeChooser::didCancelChooser): Ditto.
(WebKit::ExternalDateTimeChooser::endChooser):
Called by the requester when it wants to close the chooser.
We don't close the chooser here, and just disconnect the association of
the client and this object.
* src/ExternalDateTimeChooser.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplementation for mehods in WebMutableURLRequest.cpp
commit-queue@webkit.org [Wed, 14 Nov 2012 08:04:02 +0000 (08:04 +0000)]
Implementation for mehods in WebMutableURLRequest.cpp
https://bugs.webkit.org/show_bug.cgi?id=83671

Patch by George Tsoumalis <tsumalis96@gmail.com> on 2012-11-14
Reviewed by Brent Fulgham..

* WebMutableURLRequest.cpp:
(WebMutableURLRequest::addValue):
(WebMutableURLRequest::setMainDocumentURL):
(WebMutableURLRequest::setHTTPShouldHandleCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse menulist-button instead of menulist for date/time input types
tkent@chromium.org [Wed, 14 Nov 2012 07:56:51 +0000 (07:56 +0000)]
Use menulist-button instead of menulist for date/time input types
https://bugs.webkit.org/show_bug.cgi?id=101886

Reviewed by Hajime Morita.

Both of Chromium-Android and iOS use -webkit-appearance:menulist-button,
not menulist. We had better apply common one by default.

No new tests. Covered by fast/forms/*/*-appearance-*.html.

* css/html.css:
(input[type="date"]): Switch menulist-button from menulist.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-date-and-time-value):
Add top, right, bottom margins. The right margin is important when
dir=rtl is specified.
whitespace:pre is needed to align baseline in a case of empty values.
* css/themeChromiumAndroid.css:
Remove redundant style declaration.
* css/themeWin.css:
Remove padding adjustment for date/time input types. It is for
textfields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RuntimeEnabledFeatures::isPointerLockEnabled.
scheib@chromium.org [Wed, 14 Nov 2012 07:49:44 +0000 (07:49 +0000)]
Remove RuntimeEnabledFeatures::isPointerLockEnabled.
https://bugs.webkit.org/show_bug.cgi?id=102107

Reviewed by Adam Barth.

The runtime flag is always true now that the feature is enabled by default in Chromium.

Source/WebCore:

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* dom/Document.idl:
* dom/Element.idl:
* dom/MouseEvent.idl:

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit):
(WebKit::WebRuntimeFeatures::enablePointerLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 07:24:01 +0000 (07:24 +0000)]
Unreviewed GTK gardening.

Expanding failure expectations for the inspector/debugger/live-edit.html test.
Adding failure and timeout expectations for two tests that regressed after r134495.
Adding failure expectation for a test added in r134099.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG CreateThis should be able to statically account for the structure of the object...
fpizlo@apple.com [Wed, 14 Nov 2012 07:22:57 +0000 (07:22 +0000)]
DFG CreateThis should be able to statically account for the structure of the object it creates, if profiling indicates that this structure is always the same
https://bugs.webkit.org/show_bug.cgi?id=102017

Reviewed by Geoffrey Garen.

This adds a watchpoint in JSFunction on the cached inheritor ID. It also changes
NewObject to take a structure as an operand (previously it implicitly used the owning
global object's empty object structure). Any GetCallee where the callee is predictable
is turned into a CheckFunction + WeakJSConstant, and any CreateThis on a WeakJSConstant
where the inheritor ID watchpoint is still valid is turned into an InheritorIDWatchpoint
followed by a NewObject. NewObject already accounts for the structure it uses for object
creation in the CFA.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkFunctionElimination):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasFunction):
(JSC::DFG::Node::function):
(JSC::DFG::Node::hasStructure):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Executable.h:
(JSC::JSFunction::JSFunction):
* runtime/JSBoundFunction.cpp:
(JSC):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
* runtime/JSFunction.h:
(JSC::JSFunction::tryGetKnownInheritorID):
(JSFunction):
(JSC::JSFunction::addInheritorIDWatchpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip new failing tests.
ossy@webkit.org [Wed, 14 Nov 2012 07:19:56 +0000 (07:19 +0000)]
Unreviewed gardening, skip new failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
abarth@webkit.org [Wed, 14 Nov 2012 07:17:06 +0000 (07:17 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: JsDoc-annotate KeyboardShortcuts
commit-queue@webkit.org [Wed, 14 Nov 2012 07:12:17 +0000 (07:12 +0000)]
Web Inspector: JsDoc-annotate KeyboardShortcuts
https://bugs.webkit.org/show_bug.cgi?id=101301

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.

JsDoc-annotate KeyboardShortcuts to improve readability.

* inspector/front-end/AdvancedSearchController.js: Fix parameter type.
* inspector/front-end/KeyboardShortcut.js: Add annotations.
* inspector/front-end/Panel.js: Make event parameter typed.
* inspector/front-end/inspector.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Marked platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specifi...
haraken@chromium.org [Wed, 14 Nov 2012 07:06:18 +0000 (07:06 +0000)]
Unreviewed. Marked platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specified-width.html
as Slow.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Extract common interface for StatusBarButton and StatusBarCombo
commit-queue@webkit.org [Wed, 14 Nov 2012 06:57:36 +0000 (06:57 +0000)]
Web Inspector: Extract common interface for StatusBarButton and StatusBarCombo
https://bugs.webkit.org/show_bug.cgi?id=101907

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.

Status bar control element should have common interface for
easier management.
In this patch getter/setter for StatusBarButton "disabled" are replaced
with regular functions "enabled"/"setEnabled"; added "setEnabled"
to StatusBarCombo; added new base class StatusBarItem with
method "setEnabled" and member "element".

* inspector/front-end/CPUProfileView.js: Adopted refactoring.
* inspector/front-end/DockController.js: Ditto.
* inspector/front-end/ScriptsPanel.js: Ditto.
* inspector/front-end/TimelinePanel.js: Ditto.
* inspector/front-end/inspector.js: Ditto.
* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarItem): Added.
(WebInspector.StatusBarButton): Replaced getter/setter with
regular functions.
(WebInspector.StatusBarComboBox.prototype.setEnabled): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, update expected files after r134435.
ossy@webkit.org [Wed, 14 Nov 2012 06:56:27 +0000 (06:56 +0000)]
Unreviewed gardening, update expected files after r134435.

* dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
* fast/dom/DOMException/prototype-object-expected.txt:
* fast/dom/DOMException/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Console: update tab/shift-tab shortcut description.
commit-queue@webkit.org [Wed, 14 Nov 2012 06:55:12 +0000 (06:55 +0000)]
Web Inspector: Console: update tab/shift-tab shortcut description.
https://bugs.webkit.org/show_bug.cgi?id=102175

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.

For "Tab / Shift-Tab" it said "Next/previous suggestion".
Actually, shift-tab to do nothing, and tab auto-completes common prefix.

* English.lproj/localizedStrings.js: Replaced string.
* inspector/front-end/ConsoleView.js: Updated shortcut registration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the...
danakj@chromium.org [Wed, 14 Nov 2012 06:37:20 +0000 (06:37 +0000)]
[chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the GraphicsLayer border width setting.
https://bugs.webkit.org/show_bug.cgi?id=102130

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

The current method of setting debug borders on GraphicsLayers requires
every GraphicsLayerClient to set the value on the layer(s) it
represents. This skips the NonCompositedContentHost as well as any
other clients other than RenderLayerBacking - including layers from the
inspector.

Instead, pass the debug border setting directly to the
WebLayerTreeSettings where the compositor can use the flag to enable
borders on all layers globally.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable calendar picker for input types datetime/datetime-local
commit-queue@webkit.org [Wed, 14 Nov 2012 06:30:04 +0000 (06:30 +0000)]
Enable calendar picker for input types datetime/datetime-local
https://bugs.webkit.org/show_bug.cgi?id=101889

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-13
Reviewed by Kent Tamura.

Source/WebCore:

This adds calendar picker to <input type=datetime> and <input type=datetime-local>.
When a user choose a date from calendar picker, year/month/day fields of the input
element are updated and hour/minute/second fields are unchanged.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-local.html
       platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html

* Resources/pagepopups/calendarPicker.js: Day.parse accepts datetime string (just drops time part).
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue):
If the given value is not valid for the element, try to parse it as a date string.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::formatDateTimeFieldsState): DateTimeFieldsState::month() returns 1-12, not 0-11.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState): Ditto.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::setOnlyYearMonthDay): Added.
(WebCore):
* html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker): Return true for datetime and datetimelocal too.

LayoutTests:

Added tests for calendar picker for inpt type=datetime/datetime-local.

* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134524.
haraken@chromium.org [Wed, 14 Nov 2012 06:18:03 +0000 (06:18 +0000)]
Unreviewed, rolling out r134524.
http://trac.webkit.org/changeset/134524
https://bugs.webkit.org/show_bug.cgi?id=102177

"Chromiium build broken" (Requested by haraken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* rendering/RenderThemeChromiumFontProvider.cpp: Removed.
* rendering/RenderThemeChromiumFontProvider.h: Removed.
* rendering/RenderThemeChromiumFontProviderLinux.cpp: Removed.
* rendering/RenderThemeChromiumFontProviderWin.cpp: Removed.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::defaultGUIFont):
(WebCore::RenderThemeChromiumSkia::systemFont):
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::getNonClientMetrics):
(WebCore::systemFontSize):
(WebCore::pointsToPixels):
(WebCore::RenderThemeChromiumWin::systemFont):
(WebCore::RenderThemeChromiumWin::setDefaultFontSize):
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix compile warning [-Wsign-compare]
commit-queue@webkit.org [Wed, 14 Nov 2012 06:15:12 +0000 (06:15 +0000)]
Fix compile warning [-Wsign-compare]
https://bugs.webkit.org/show_bug.cgi?id=101458

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-13
Reviewed by Alexey Proskuryakov.

Currently, lossy check has been done by comparing file size(posix signed integral value) with conversioned(standard c++ unsigned integral value).
However, it leads -Wsign-compare compile warning.
Therefore, this patch assigns the file size to the biggest possible unsigned variable, then does the lossy check.

* platform/posix/SharedBufferPOSIX.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable datalist UI for input types week and month
keishi@webkit.org [Wed, 14 Nov 2012 06:13:52 +0000 (06:13 +0000)]
Enable datalist UI for input types week and month
https://bugs.webkit.org/show_bug.cgi?id=102041

Reviewed by Kent Tamura.

Source/WebCore:

Enabling datalist UI for input types week and month.

No new tests. Tests will be added later in Bug 102039 and Bug 102040.

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add month and week to the list.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): If the type supports calendar picker show the "Other..." option.

LayoutTests:

* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheckbox to toggle FPS counter in the inspector's settings
commit-queue@webkit.org [Wed, 14 Nov 2012 05:52:55 +0000 (05:52 +0000)]
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660

Patch by Eberhard Graether <egraether@google.com> on 2012-11-13
Reviewed by Pavel Feldman.

Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowFPSCounter):

Source/WebCore:

No new tests.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowFPSCounter):
(WebCore::InspectorClient::setShowFPSCounter):
(InspectorClient):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowFPSCounter):
(WebCore):
(WebCore::InspectorPageAgent::setShowFPSCounter):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showFPSCounterChanged):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCollect necessary features for SelectRuleFeatureSet
shinyak@chromium.org [Wed, 14 Nov 2012 05:51:12 +0000 (05:51 +0000)]
Collect necessary features for SelectRuleFeatureSet
https://bugs.webkit.org/show_bug.cgi?id=102160

Reviewed by Dimitri Glazkov.

Source/WebCore:

When pseudo class is changed, we might have to invalidate distribution. To determine whether we should invalidate
distribution, we would like to collect RuleFeature from select attributes.

According to ShadowDOM spec, we have to collect the following pseudo classes: checked, enabled, disabled,
indeterminate, link, target, and visited. We collect them in this patch.

Test: fast/dom/shadow/shadow-select-attribute-featureset.html

* html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet): Uses int as bitset so that we can use bit operator.
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector): Collects necessary features from CSSSelector.
* html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorForChecked):
(WebCore::SelectRuleFeatureSet::hasSelectorForEnabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForDisabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
(WebCore::SelectRuleFeatureSet::hasSelectorForLink):
(WebCore::SelectRuleFeatureSet::hasSelectorForTarget):
(WebCore::SelectRuleFeatureSet::hasSelectorForVisited):
(SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::setSelectRuleFeature):
(WebCore::SelectRuleFeatureSet::hasSelectorFor):
* testing/Internals.cpp:
(WebCore::Internals::hasSelectorForPseudoClassInShadow):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/shadow-select-attribute-featureset-expected.txt:
* fast/dom/shadow/shadow-select-attribute-featureset.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
gyuyoung.kim@samsung.com [Wed, 14 Nov 2012 05:45:43 +0000 (05:45 +0000)]
[EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
https://bugs.webkit.org/show_bug.cgi?id=102065

Reviewed by Laszlo Gombos.

mouseClick(), mouseDown() and mouseUp() test functions are only able to test a left button of mouse now.
However, EFL API test framwork needs to test various mouse buttons. For example, context menu test needs
to simulate a right mouse button. So, button type parameter needs to be added for it.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseClick):
(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove inline style logic from ElementAttributeData to StyledElement.
kling@webkit.org [Wed, 14 Nov 2012 05:39:17 +0000 (05:39 +0000)]
Move inline style logic from ElementAttributeData to StyledElement.
<http://webkit.org/b/102120>

Reviewed by Antti Koivisto.

Source/WebCore:

Move all the logic dealing with element inline style from ElementAttributeData to StyledElement.
No difference in behavior, just making ElementAttributeData dumber.

* css/StylePropertySet.cpp:
* css/StylePropertySet.h:
(WebCore::StylePropertySet::hasCSSOMWrapper):
(WebCore::StylePropertySet::cssStyleDeclaration):

    Added as complements to ensureCSSStyleDeclaration() for the case where we don't want
    to instantiate a CSSOM wrapper unnecessarily.

* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyle):
* dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::inlineStyle):
(ElementAttributeData):

    Renamed m_inlineStyleDecl to m_inlineStyle. Finally.

* dom/StyledElement.cpp:
(WebCore::StyledElement::~StyledElement):

    Detach the CSSOM wrapper from the inline style if there is one.

(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::style):

    Renamed ensureInlineStyle() to ensureMutableInlineStyle() since that's what it
    actually does. Update call sites accordingly.

(WebCore::StyledElement::inlineStyleCSSOMWrapper):

    Added helper to get the CSSOM wrapper for the element's inline style if there is one.

(WebCore::StyledElement::styleAttributeChanged):

    Do the work to parse/update/replace the inline style attribute here instead of
    in an ElementAttributeData method.

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::removeAllInlineStyleProperties):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
* html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):

    s/ensureInlineStyle/ensureMutableInlineStyle/

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/forms/file/input-file-write-files.html should cover correct setting value
commit-queue@webkit.org [Wed, 14 Nov 2012 05:35:11 +0000 (05:35 +0000)]
fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085

Patch by Li Yin <li.yin@intel.com> on 2012-11-13
Reviewed by Kentaro Hara.

Fix the GObject and Objective C bindings comparibility issue. Preserving existing
behavior for those may be important in idl.

No new tests, because fast/forms/file/input-file-value.html has covered it.

* html/HTMLInputElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134538 268f45cc-cd09-0410-ab3c-d52691b4dbfc