WebKit-https.git
14 years ago... and now the non-symlink file, in a separate commit as SVN is also special about...
bdash [Fri, 20 Jul 2007 11:07:27 +0000 (11:07 +0000)]
... and now the non-symlink file, in a separate commit as SVN is also special about symlinks :-/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-20 Mark Rowe <mrowe@apple.com>
bdash [Fri, 20 Jul 2007 11:06:31 +0000 (11:06 +0000)]
2007-07-20  Mark Rowe  <mrowe@apple.com>

        Replace symlink with a PHP-level include to allow use of git on Windows without cygwin.
        WordPress will replace the file with a symlink when it's first accessed, and the PHP-level
        include is functionally identical for our purposes on the first use.

        * blog/wp-content/advanced-cache.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove some files that are not used anymore.
lars [Fri, 20 Jul 2007 11:00:39 +0000 (11:00 +0000)]
Remove some files that are not used anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agouse the correct font for spaces.
lars [Fri, 20 Jul 2007 10:40:20 +0000 (10:40 +0000)]
use the correct font for spaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agospaces where not correctly taken into account for both offsetForPosition and selectio...
lars [Fri, 20 Jul 2007 10:39:59 +0000 (10:39 +0000)]
spaces where not correctly taken into account for both offsetForPosition and selectionRectForText. Because of that selections sort of worked in LTR text, but completely failed in RTL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix up some smaller issues in selection handling. It's still not perfect and selectio...
lars [Fri, 20 Jul 2007 10:39:44 +0000 (10:39 +0000)]
fix up some smaller issues in selection handling. It's still not perfect and selections in mixed rtl/ltr text are still broken, but it's getting there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomake offsetForPosition and selectionRectForText work correctly with small caps.
lars [Fri, 20 Jul 2007 10:39:23 +0000 (10:39 +0000)]
make offsetForPosition and selectionRectForText work correctly with small caps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoclip the drawn text correctly when needed.
lars [Fri, 20 Jul 2007 10:39:05 +0000 (10:39 +0000)]
clip the drawn text correctly when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix offsetForPosition and selectionRectForText methods.
lars [Fri, 20 Jul 2007 10:38:49 +0000 (10:38 +0000)]
Fix offsetForPosition and selectionRectForText methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix BiDi text rendering.
lars [Fri, 20 Jul 2007 10:38:28 +0000 (10:38 +0000)]
fix BiDi text rendering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
oliver [Fri, 20 Jul 2007 10:01:04 +0000 (10:01 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5349668> WebKit/Win needs to send same key events during IME composition as it does on mac

        Removed guards against sending key events during composition, and added a flag
        to indicate a key event is IME related.  This is needed to prevent the first
        keydown from firing a keypress event, and makes WebEditorClient::handleInputMethodKeypress
        somewhat cleaner.

        * WebEditorClient.cpp:
        (WebEditorClient::handleInputMethodKeypress):
        * WebView.cpp:
        (WebView::keyUp):
        (WebView::keyDown):
        * WebView.h:
        (WebView::inIMEKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-20 Mark Rowe <mrowe@apple.com>
bdash [Fri, 20 Jul 2007 09:23:44 +0000 (09:23 +0000)]
2007-07-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
        to avoid creating a global initializer.  This fixes the build for x86_64.

        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/commit-log-editor: Small fix to make an all-whitespace log
aroben [Fri, 20 Jul 2007 07:11:47 +0000 (07:11 +0000)]
    * Scripts/commit-log-editor: Small fix to make an all-whitespace log
        message not count as an existing log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ggaren [Fri, 20 Jul 2007 05:54:48 +0000 (05:54 +0000)]
    Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/5347849> Cache eviction of live decoded data is
        thrash-y

        The solution here is to evict live decoded data based on a strict LRU
        model. This should work well as a "scrolling window."

        With this patch, I see a substantial reduction in CPU while scrolling
        through a page with large images on a low memory system. Layout tests
        pass.

        * loader/Cache.h: Changed from a size-based vector of LRU lists to a
        single LRU list in order to implement strict LRU.

        * loader/CachedResource.h: Removed tracking of access count, since that
        was the old cache eviction model.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
oliver [Fri, 20 Jul 2007 05:13:33 +0000 (05:13 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
        <rdar://problem/5346167> DOM key events triggered during IME composition differ in webkit/mac vs all windows browsers

        We now basically match the behaviour of IE/Windows. This means that during composition keydown and autorepeat
        keys generate keydown events with a keyCode of 229, which correlates to the windows VK_PROCESSKEY message.
        keyup events are generated with the keyCode of the actual key that was pressed.

        The only difference is on the first keydown of a composition, in which IE will use keyCode == 229, and we will
        send an event with the keyCode for the actual key that was pressed.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent):
        * platform/PlatformKeyboardEvent.h:
        (WebCore::PlatformKeyboardEvent::setWindowsKeyCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
mjs [Fri, 20 Jul 2007 04:09:11 +0000 (04:09 +0000)]
    Reviewed by Adam.

        - WebKit part of fix for <rdar://problem/5262230> Crash while loading a popup in addictinggames.com

        Made closeWindowSoon fire on a timer instead of happening synchronously.

        * WebChromeClient.cpp:
        (WebChromeClient::closeWindowSoon): Actually close the window on a timer, not immediately.
        * WebKit.vcproj/WebKit.vcproj:
        * WebView.cpp:
        (WebView::WebView):
        (WebView::closeWindowSoon):
        (WebView::closeWindowTimerFired):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam
beidson [Fri, 20 Jul 2007 03:47:26 +0000 (03:47 +0000)]
    Reviewed by Sam

        <rdar://problem/5134929> REGRESSION: Colon detected as delimiting an empty port is stripped

        The fix for this was in KURL::parse() which had a slightly changed rule that would strip the colon if there
        was no port.

        An additional canonicalization fix was made in window.location.host to match the expected behavior of leaving
        the colon in place - before this fix, if the colon was there but no port was there, we'd see the port as 0.

        * bindings/js/kjs_window.cpp:
        (KJS::Location::put): Call setHostAndPort instead of setHost and setPort seperately

        * manual-tests/location-host-canonicalization.html: Added.

        * platform/KURL.cpp:
        (WebCore::KURL::setHostAndPort): Set the host and port as one string component then reparse the URL
        (WebCore::KURL::parse): Change one line to consider the empty colon as part of the host name
        * platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse the right radar number
andersca [Fri, 20 Jul 2007 03:15:30 +0000 (03:15 +0000)]
Use the right radar number

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca [Fri, 20 Jul 2007 02:59:04 +0000 (02:59 +0000)]
    Reviewed by Adam.

        <rdar://problem/5334742>
        Windows Beta: Crash playing a very large QuickTime movie in Safari

        <rdar://problem/5271174>
        http://bugs.webkit.org/show_bug.cgi?id=14148
        LEAK: Serious memory consumption and leak when loading QT movies.

        Don't keep plugin stream data in memory since some plugin resources (like QT movies)
        can be really big. If a plug-in wants data in a file, create a file and write data to it
        as it's coming from the wire, instead of using a big buffer.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::addData):
        (WebCore::ResourceLoader::willStopBufferingData):
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::setShouldBufferData):
        * plugins/win/PluginStreamWin.cpp:
        (WebCore::PluginStreamWin::PluginStreamWin):
        (WebCore::PluginStreamWin::start):
        (WebCore::PluginStreamWin::startStream):
        (WebCore::PluginStreamWin::destroyStream):
        (WebCore::PluginStreamWin::didReceiveData):
        (WebCore::PluginStreamWin::didFinishLoading):
        * plugins/win/PluginStreamWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-19 Ada Chan <adachan@apple.com>
adachan [Fri, 20 Jul 2007 02:55:54 +0000 (02:55 +0000)]
2007-07-19  Ada Chan  <adachan@apple.com>

        Rubber-stamped by Adam.

        Update libraries.

        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Fri, 20 Jul 2007 02:12:54 +0000 (02:12 +0000)]
JavaScriptCore:

        Reviewed by Darin Adler.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=10880 | <rdar://problem/5335694>
        REGRESSION: JavaScript menu doesn't appear on pricepoint.com (14595)

        Though the ECMA spec says auto-semicolon insertion should not occur
        without a newline or '}', Firefox treats do-while specially, and the
        library used by pricepoint.com requires that special treatment.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/grammar.y:

LayoutTests:

        Reviewed by Darin Adler.

        Test for http://bugs.webkit.org/show_bug.cgi?id=10880 | <rdar://problem/5335694>
        REGRESSION: JavaScript menu doesn't appear on pricepoint.com (14595)

        * fast/js/do-while-without-semicolon-expected.txt: Added.
        * fast/js/do-while-without-semicolon.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ggaren [Fri, 20 Jul 2007 02:07:37 +0000 (02:07 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Fixed <rdar://problem/5348384> Restore old return value behavior of
        stringByEvaluatingJavaScriptFromString

        Return an empty string unless you have a string, boolean, or number
        result.

        * WebCore.xcodeproj/project.pbxproj:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

WebKitTools:

        Reviewed by Darin Adler.

        Updated DumpRenderTree for <rdar://problem/5348384> Restore old return
        value behavior of stringByEvaluatingJavaScriptFromString

        * DumpRenderTree/DumpRenderTree.m:
        (testStringByEvaluatingJavaScriptFromString):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDo a recursive layout on frame's children.
treat [Thu, 19 Jul 2007 23:48:42 +0000 (23:48 +0000)]
Do a recursive layout on frame's children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Alexey.
darin [Thu, 19 Jul 2007 22:22:17 +0000 (22:22 +0000)]
    Reviewed by Alexey.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14666
          remove unused xxx-encodings.txt for all platforms other than Mac

        * platform/gdk/gdk-encodings.txt: Removed.
        * platform/win/win-encodings.txt: Removed.
        * platform/wx/wx-encodings.txt: Removed.

        * platform/character-sets.txt: Moved into mac subdirectory since it's only used for Mac; at some
        point I hope to remove it completely.
        * platform/make-charset-table.pl: Ditto.
        * platform/mac/character-sets.txt: Copied from platform/character-sets.txt.
        * platform/mac/make-charset-table.pl: Copied from platform/make-charset-table.pl.

        * DerivedSources.make: Moved CharsetData.cpp into the MACOS section.
        Changed the build rule to use Mac-specific paths for everything and got rid of
        make variables.

        * WebCore.vcproj/build-generated-files.sh: Removed code to set ENCODINGS_FILE and ENCODINGS_PREFIX.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * make-generated-sources.sh: Ditto.

        * Projects/gdk/webcore-gdk.bkl: Removed code to pass gdk-encodings.txt to make-generated-sources.sh.
        * Projects/wx/webcore-wx.bkl: Ditto, but for wx-encodings.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Thu, 19 Jul 2007 21:10:40 +0000 (21:10 +0000)]
    Reviewed by Geoff.

        - fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers
          on named recursion or subexpressions

        It's challenging to implement proper preflighting for compiling these advanced features.
        But we don't want them in the JavaScript engine anyway.

        Turned off the following features of PCRE (some of these are simply parsed and not implemented):

            \C \E \G \L \N \P \Q \U \X \Z
            \e \l \p \u \z
            [::] [..] [==]
            (?#) (?<=) (?<!) (?>)
            (?C) (?P) (?R)
            (?0) (and 1-9)
            (?imsxUX)

        Added the following:

            \u \v

        Because of \v, the js1_2/regexp/special_characters.js test now passes.

        To be conservative, I left some features that JavaScript doesn't want, such as
        \012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
        related to avoiding the incorrect preflighting.

        I also didn't try to remove unused opcodes and remove code from the execution engine.
        That could save code size and speed things up a bit, but it would require more changes.

        * kjs/regexp.h:
        * kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for
        lack of \u support, since the PCRE code now has \u support.

        * pcre/pcre-config.h: Set JAVASCRIPT to 1.
        * pcre/pcre_internal.h: Added ESC_v.

        * pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that
        omits all the escapes we don't want interpreted and includes '\v'.
        (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U',
        and added code to handle '\u2013' inside JAVASCRIPT.
        (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we
        don't want.
        (pcre_compile2): Ditto.

        * tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now
        passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
antti [Thu, 19 Jul 2007 20:09:18 +0000 (20:09 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/5257371>
        Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator

        * fast/flexbox/inline-children-crash-expected.txt: Added.
        * fast/flexbox/inline-children-crash.html: Added.

WebCore:

        Reviewed by Darin.

        Fix <rdar://problem/5257371>
        Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator

        FlexibleBoxes should never have inline children. Don't move children out from last remaining anonymous block.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild): real fix
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox): just to be sure, this is checked elsewhere too

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Thu, 19 Jul 2007 20:04:46 +0000 (20:04 +0000)]
    Reviewed by Darin.

        <rdar://problem/5322268>
        Safari Crash at http://www.exlibrisgroup.com/sfx_openurl.htm

        Add a real copy constructor and assignment operator for CollectionInfo
        so that the vectors in the cache maps will be copied correctly.

        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::CollectionInfo::CollectionInfo):
        (WebCore::HTMLCollection::CollectionInfo::swap):
        * html/HTMLCollection.h:
        (WebCore::HTMLCollection::CollectionInfo::operator=):
        (WebCore::HTMLCollection::CollectionInfo::copyCacheMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for 5237574, Colloquy main view does not size correctly. Make
hyatt [Thu, 19 Jul 2007 20:01:26 +0000 (20:01 +0000)]
    Fix for 5237574, Colloquy main view does not size correctly.  Make
        sure to reset the baseilne when calculating a row's height/baseline, so
        that old values don't stick around.

        Reviewed by Tim Hatcher

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make commit-log-editor work with git
aroben [Thu, 19 Jul 2007 17:24:03 +0000 (17:24 +0000)]
 Make commit-log-editor work with git

        Reviewed by Sam.

        * Scripts/commit-log-editor: Use VCSUtils and accept a git-style
        commit message template. Also removed the unused $breakPoint variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move generally-useful VCS code into a new VCSUtils.pm module
aroben [Thu, 19 Jul 2007 17:23:54 +0000 (17:23 +0000)]
 Move generally-useful VCS code into a new VCSUtils.pm module

        This is in preparation for making commit-log-editor git-friendly.

        Reviewed by Sam.

        * Scripts/VCSUtils.pm: Added. Code moved here from prepare-ChangeLog.
        * Scripts/prepare-ChangeLog: Use VCSUtils.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
antti [Thu, 19 Jul 2007 16:58:01 +0000 (16:58 +0000)]
LayoutTests:

        Reviewed by John.

        Update test case to work better as a pixel test.

        * fast/layers/layer-visibility-expected.checksum:
        * fast/layers/layer-visibility-expected.png:
        * fast/layers/layer-visibility-expected.txt:
        * fast/layers/layer-visibility.html:

WebCore:

        Reviewed by John.

        Fix <rdar://problem/5346697>
        REGRESSION(r23773): Visibile children on invisible layer are not painted (fast/layers/layer-visibility.html fails)

        Test m_hasVisibleContent instead of renderer()->style()->visibility().
        This takes children into account too.

        Regression spotted by Mitz.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a crash on exit when running DRT against a current
lars [Thu, 19 Jul 2007 13:19:47 +0000 (13:19 +0000)]
    Fix a crash on exit when running DRT against a current
        Qt 4.4 snapshot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to...
aroben [Thu, 19 Jul 2007 08:40:58 +0000 (08:40 +0000)]
Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)

Reviewed by Oliver.

* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix changelog to match reality
oliver [Thu, 19 Jul 2007 05:46:31 +0000 (05:46 +0000)]
Fix changelog to match reality

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by maciej
oliver [Thu, 19 Jul 2007 05:42:10 +0000 (05:42 +0000)]
    Rubber stamped by maciej

        Rollout previous patch.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt.
ggaren [Thu, 19 Jul 2007 04:26:43 +0000 (04:26 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/5345099>

        Reduced default WebCore cache size from 32 MB to 23 MB on systems below
        512 MB RAM. This improves RPRVT usage in the Safari pageout test by
        ~10% on a system with 384 MB RAM.

        At 23 MB, no extra resources are evicted from the cache during a PLT
        run, so this is a safe change PLT-wise. 23 MB is also seems to be a
        generous number in real world usage.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoIdentify the appropriate Kevin in changelog
oliver [Thu, 19 Jul 2007 04:16:57 +0000 (04:16 +0000)]
Identify the appropriate Kevin in changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin.
oliver [Thu, 19 Jul 2007 04:14:02 +0000 (04:14 +0000)]
    Reviewed by Kevin.

        Fix for <rdar://problem/5346167> DOM key events triggered during
                IME composition differ in webkit/mac vs all windows browsers

        We no longer send DOM key events during IME composition.  This behaviour
        matches the behaviour of WebKit/Win.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
weinig [Thu, 19 Jul 2007 04:11:36 +0000 (04:11 +0000)]
LayoutTests:

        Reviewed by Oliver.

        Test for http://bugs.webkit.org/show_bug.cgi?id=14646
        WebKit border radius properties are unavailable via JavaScript

        * fast/dom/getComputedStyle-borderRadius-expected.txt: Added.
        * fast/dom/getComputedStyle-borderRadius.html: Added.

WebCore:

        Reviewed by Oliver.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14646
        WebKit border radius properties are unavailable via JavaScript

        Test: fast/dom/getComputedStyle-borderRadius.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::getBorderRadiusCornerValue): Helper function that returns a single value if
        width and the height of the corner radius are equal, and otherwise a pair.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDon't try to use an SSL certificate on Windows until <rdar://problem/5345985> is...
aroben [Thu, 19 Jul 2007 03:44:46 +0000 (03:44 +0000)]
Don't try to use an SSL certificate on Windows until <rdar://problem/5345985> is fixed

Reviewed by Mark.

* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Thu, 19 Jul 2007 02:40:12 +0000 (02:40 +0000)]
    Reviewed by Darin.

        <rdar://problem/5262136> Double form repost alert going forward on britishairways.com

        When checking if the request has changed and a new policy callback needs to be sent,
        ignore the request headers. NSURLConnection in Leopard will always call willSendRequest,
        with a request that was different from the one passed to -[NSURLConnection connectionWithRequest:]
        (a few Accept headers are added).

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkNavigationPolicy):
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::equalIgnoringHeaderFields):
        (WebCore::operator==):
        * platform/network/ResourceRequestBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot to commit the actual fix!
aroben [Thu, 19 Jul 2007 01:41:03 +0000 (01:41 +0000)]
Forgot to commit the actual fix!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMore git friendliness for prepare-ChangeLog
aroben [Thu, 19 Jul 2007 01:38:59 +0000 (01:38 +0000)]
More git friendliness for prepare-ChangeLog

The overall change is to remove the use of git-status and replace it
with git-diff --name-status (which we were already using in the
--git-commit case).

This lets us respect directories specified on the command line when
using git, just as we do for Subversion. It also speeds things up a
bit, especially in the subdirectory case, as git-status is pretty slow.

I also fixed some issues where we wouldn't detect copied files and
would reverse the new filename and the original filename for renamed files.

Reviewed by Mark.

* Scripts/prepare-ChangeLog:
(sub diffFromToString): Added.
(sub diffCommand): Don't append the paths in the --git-commit case, as
we should be operating on the entire commit.
(sub statusCommand): Always use git-diff --name-status, and added an
extra -C option to git-diff to make it find a few more copied files.
(sub createPatchCommand): Collapsed the two git cases a bit, and added
the extra -C option as above.
(sub generateFileList): Remove the git-status codepath, and recognize
file copies in the --name-status output.
(sub isModifiedOrAddedStatus): Collapsed the status codes into one
dictionary.
(sub isConflictStatus): Updated the git dictionary.
(sub statusDescription): Updated the git dictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDisable SSL tests on Windows
aroben [Thu, 19 Jul 2007 01:26:29 +0000 (01:26 +0000)]
Disable SSL tests on Windows

<rdar://problem/5345985> tracks making these tests work

Rubberstamed by Mark.

* http/conf/cygwin-httpd.conf:
* win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Thu, 19 Jul 2007 00:44:16 +0000 (00:44 +0000)]
JavaScriptCore:

        Reviewed by Oliver Hunt.

        - fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[**]"

        Test: fast/js/regexp-charclass-crash.html

        * pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls
        check_posix_syntax to match the actual regular expression compilation code;
        before it was missing the check of the first character.

LayoutTests:

        Reviewed by Oliver Hunt.

        - test for <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[**]"

        * fast/js/regexp-charclass-crash-expected.txt: Added.
        * fast/js/regexp-charclass-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
andersca [Wed, 18 Jul 2007 23:31:38 +0000 (23:31 +0000)]
LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5340098>
        http://bugs.webkit.org/show_bug.cgi?id=13366
        REGRESSION (r10935): AOL beta music player doesn't play

        * fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Added.
        * fast/dom/HTMLDocument/object-by-name-unknown-child-element.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/5340098>
        http://bugs.webkit.org/show_bug.cgi?id=13366
        REGRESSION (r10935): AOL beta music player doesn't play

        The AOL beta music player has a typo, causing it to create an <embed"> element inside of
        an <object> element
        Because of this, it will not be treated as an embed tag, so its name will not be added
        to the document's named item map. Furthermore, since the <object> contains a child that
        is not a <param>, the object's name won't be added either.

        The (somewhat ugly) fix is to add <object> to the named map only if it has <param> or
        unknown elements as children.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::updateDocNamedItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-19 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Wed, 18 Jul 2007 22:56:33 +0000 (22:56 +0000)]
2007-07-19  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        Define __BUILDING_GDK when building for Gdk to fix building testkjs on OSX.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/build-drosera: Update where we look for the Xcode project.
thatcher [Wed, 18 Jul 2007 22:45:32 +0000 (22:45 +0000)]
    * Scripts/build-drosera: Update where we look for the Xcode project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse the old wording for safari
treat [Wed, 18 Jul 2007 22:45:04 +0000 (22:45 +0000)]
Use the old wording for safari

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
andersca [Wed, 18 Jul 2007 22:34:19 +0000 (22:34 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5341133> REGRESSION (Safari 2->Safari 3): DjVu plug-in doesn't load in Safari 3

        The DjVu plug-in uses the size of the passed in NPNetscapeFuncs struct to copy it over to a NPNetscapeFuncs struct
        whose size was determined when DjVu was compiled. This means that when we add extra functions to the vtable,
        DjVu will segfault copying it into the (too small) destination struct.

        Fix this by special-casing the DjVu plug-in and setting the NPNetscapeFuncs size to be the same size as what DjVu expects.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _applyDjVuWorkaround]):
        (-[WebNetscapePluginPackage load]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot the changelog
treat [Wed, 18 Jul 2007 22:26:51 +0000 (22:26 +0000)]
Forgot the changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd a script for launching test app for Qt and Gdk ports.
treat [Wed, 18 Jul 2007 22:23:19 +0000 (22:23 +0000)]
Add a script for launching test app for Qt and Gdk ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
thatcher [Wed, 18 Jul 2007 21:35:14 +0000 (21:35 +0000)]
WebCore:

        Reviewed by Adam.

        <rdar://problem/5343767> Should have a way to disable the Web Inspector

        This change facilitates the ability to turn the Web Inspector on and off.

        Makes the InspectorClient be required to create a new Page. This also means that
        InspectorController will never be NULL. Adds a new function on Page to test
        if the inspector is enabled.

        * WebCore.exp: New symbol for the Page constructor.
        * WebCore.pro: Add InspectorClientGdk.cpp.
        * WebCoreSources.bkl: ditto.
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createTokenizer):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::detachFromParent): Don't null check the InspectorCOntroller.
        (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto.
        (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto.
        (WebCore::FrameLoader::dispatchWillSendRequest): Ditto.
        (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto.
        (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto.
        (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto.
        (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Ask the InspectorController if it is enabled.
        (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::enabled): Ask the Page's settings if developer extras are enabled.
        (WebCore::InspectorController::inspect): Check if the InspectorController is enabled.
        (WebCore::InspectorController::focusNode): Ditto.
        (WebCore::InspectorController::highlight): Ditto.
        (WebCore::InspectorController::hideHighlight): Ditto.
        (WebCore::InspectorController::addMessageToConsole): Ditto.
        (WebCore::InspectorController::attachWindow): Ditto.
        (WebCore::InspectorController::detachWindow): Ditto.
        (WebCore::InspectorController::windowScriptObjectAvailable): Ditto.
        (WebCore::InspectorController::didCommitLoad): Ditto.
        (WebCore::InspectorController::frameDetachedFromParent): Ditto.
        (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
        (WebCore::InspectorController::identifierForInitialRequest): Ditto.
        (WebCore::InspectorController::willSendRequest): Ditto.
        (WebCore::InspectorController::didReceiveResponse): Ditto.
        (WebCore::InspectorController::didReceiveContentLength): Ditto.
        (WebCore::InspectorController::didFinishLoading): Ditto.
        (WebCore::InspectorController::didFailLoading): Ditto.
        * page/InspectorController.h:
        * page/Page.cpp:
        (WebCore::Page::Page): Require an InspectorClient.
        (WebCore::Page::~Page): Always call pageDestroyed on the InspectorController.
        (WebCore::Page::inspectorEnabled): Check the WebCore settings if the developer extras are enabled.
        * page/Page.h:
        * page/gdk/InspectorClientGdk.cpp: Added.
        (WebCore::InspectorClientGdk::inspectorDestroyed): Empty stub calling notImplemented.
        (WebCore::InspectorClientGdk::createPage): Ditto.
        (WebCore::InspectorClientGdk::showWindow): Ditto.
        (WebCore::InspectorClientGdk::closeWindow): Ditto.
        (WebCore::InspectorClientGdk::attachWindow): Ditto.
        (WebCore::InspectorClientGdk::detachWindow): Ditto.
        (WebCore::InspectorClientGdk::highlight): Ditto.
        (WebCore::InspectorClientGdk::hideHighlight): Ditto.
        (WebCore::InspectorClientGdk::inspectedURLChanged): Ditto.
        * page/gdk/InspectorClientGdk.h: Added.
        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged): Pass in a dummy InspectorClient.
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyInspectorClient::~SVGEmptyInspectorClient): Empty dummy implementation.
        (WebCore::SVGEmptyInspectorClient::inspectorDestroyed): Ditto.
        (WebCore::SVGEmptyInspectorClient::createPage): Ditto.
        (WebCore::SVGEmptyInspectorClient::showWindow): Ditto.
        (WebCore::SVGEmptyInspectorClient::closeWindow): Ditto.
        (WebCore::SVGEmptyInspectorClient::attachWindow): Ditto.
        (WebCore::SVGEmptyInspectorClient::detachWindow): Ditto.
        (WebCore::SVGEmptyInspectorClient::highlight): Ditto.
        (WebCore::SVGEmptyInspectorClient::hideHighlight): Ditto.
        (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.

WebKit:

        Reviewed by Adam.

        <rdar://problem/5343767> Should have a way to disable the Web Inspector

        Adds a new DisableWebKitDeveloperExtras default that will force the Web Inspector to be disabled.
        This overrides the WebKitDeveloperExtras and IncludeDebugMenu default. It also disables
        the Web Inspector in Debug builds.

        * WebView/WebView.mm:
        (+[WebView _developerExtrasEnabled]): Check for the DisableWebKitDeveloperExtras default.
        (-[WebView _commonInitializationWithFrameName:groupName:]): Make a new WebInspectorClient when making the Page.

WebKitQt:

        Reviewed by Adam.

        Make the Page with the now required InspectorClient.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * WebKitPart/WebKitPart.cpp:
        (WebKitPart::initView):

WebKitTools:

        Reviewed by Adam.

        Make the Page with the now required InspectorClient.

        * GdkLauncher/main.cpp:
        (main):

win:

        Reviewed by Adam.

        Make the Page with the now required InspectorClient.

        * WebView.cpp:
        (WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Wed, 18 Jul 2007 21:11:54 +0000 (21:11 +0000)]
WebCore:

        Make some headers private instead of project.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Build fix.

        * Misc/WebNSAttributedStringExtras.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej and Kevin Decker
sullivan [Wed, 18 Jul 2007 21:07:20 +0000 (21:07 +0000)]
    Reviewed by Maciej and Kevin Decker

        - fixed <rdar://problem/5315926> REGRESSION: ~.4% PLT regression from r23949 (canonicalization change)

        * loader/mac/LoaderNSURLExtras.m:
        (canonicalURL):
        Rolled out the fix for 5249730 that caused this regression. 5249730 is addressed a different way now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Wed, 18 Jul 2007 21:04:10 +0000 (21:04 +0000)]
WebCore:

        Build fix.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::objectContentType):
        * platform/graphics/win/ImageWin.cpp:
        * platform/network/cf/ResourceResponseCFNet.cpp:
        * platform/win/ClipboardWin.cpp:
        (WebCore::createGlobalImageFileDescriptor):

WebKitQt:

        Build fix.

        * Api/qwebnetworkinterface.cpp:
        (QWebNetworkManager::started):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::canShowMIMEType):
        (WebCore::FrameLoaderClientQt::objectContentType):

win:

        Build fix.

        * WebFrame.cpp:
        (WebFrame::dispatchDecidePolicyForMIMEType):
        (WebFrame::objectContentType):
        * WebView.cpp:
        (WebView::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFinish rename and fix the builds
weinig [Wed, 18 Jul 2007 20:43:03 +0000 (20:43 +0000)]
Finish rename and fix the builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Wed, 18 Jul 2007 20:37:20 +0000 (20:37 +0000)]
WebCore:

        Rubber-stamped by Adam Roben.

        Rename MimeTypeRegistry to MIMETypeRegistry and xmlhttprequest to XMLHttpRequest

        * WebCore.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_dom.cpp:
        * dom/Document.cpp:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::containsJavaApplet):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestObject):
        * loader/mac/LoaderNSURLExtras.m:
        (suggestedFilenameWithMIMEType):
        * platform/MIMETypeRegistry.cpp: Copied from platform/MimeTypeRegistry.cpp.
        (WebCore::initialiseSupportedImageMIMETypes):
        (WebCore::initialiseMIMETypeRegistry):
        (WebCore::MIMETypeRegistry::getMIMETypeForPath):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
        (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
        * platform/MIMETypeRegistry.h: Copied from platform/MimeTypeRegistry.h.
        * platform/MimeTypeRegistry.cpp: Removed.
        * platform/MimeTypeRegistry.h: Removed.
        * platform/gdk/MIMETypeRegistryGdk.cpp: Copied from platform/gdk/MimeTypeRegistryGdk.cpp.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/gdk/MimeTypeRegistryGdk.cpp: Removed.
        * platform/graphics/BitmapImage.cpp:
        * platform/graphics/Image.cpp:
        (WebCore::Image::supportsType):
        * platform/mac/DragDataMac.mm:
        * platform/mac/MIMETypeRegistryMac.mm: Copied from platform/mac/MimeTypeRegistryMac.mm.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getExtensionsForMIMEType):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        * platform/mac/MimeTypeRegistryMac.mm: Removed.
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage):
        * platform/qt/MIMETypeRegistryQt.cpp: Copied from platform/qt/MimeTypeRegistryQt.cpp.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/qt/MimeTypeRegistryQt.cpp: Removed.
        * platform/win/MIMETypeRegistryWin.cpp: Copied from platform/win/MimeTypeRegistryWin.cpp.
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/win/MimeTypeRegistryWin.cpp: Removed.
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        * xml/xmlhttprequest.cpp: Removed.
        * xml/xmlhttprequest.h: Removed.
        * xml/XMLHttpRequest.cpp: Copied from xml/xmlhttprequest.cpp.
        * xml/XMLHttpRequest.h: Copied from xml/xmlhttprequest.h.

WebKit:

        Rubber-stamped by Adam Roben.

        Update after renaming MimeTypeRegistry to MIMETypeRegistry.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _documentFragmentWithArchive:]):
        * WebView/WebHTMLRepresentation.mm:
        (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
        (+[WebHTMLRepresentation supportedImageMIMETypes]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _imageExistsAtPaths:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFinish rename, fix build
weinig [Wed, 18 Jul 2007 20:00:08 +0000 (20:00 +0000)]
Finish rename, fix build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
weinig [Wed, 18 Jul 2007 19:56:40 +0000 (19:56 +0000)]
    Rubber-stamped by Adam Roben.

        Rename csshelper.h, csshelper.cpp, cssparser.h, cssparser.cpp,
        cssstyleselector.h, and cssstyleselector.cpp to be CamelCase.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMHTML.mm:
        * css/CSSGrammar.y:
        * css/CSSMediaRule.cpp:
        * css/CSSMutableStyleDeclaration.cpp:
        * css/CSSPrimitiveValue.cpp:
        * css/CSSStyleSheet.cpp:
        * css/MediaList.cpp:
        * css/MediaQueryExp.cpp:
        * css/csshelper.cpp: Removed.
        * css/csshelper.h: Removed.
        * css/CSSHelper.cpp: Copied from css/csshelper.cpp.
        * css/CSSHelper.h: Copied from css/csshelper.h.
        * css/cssparser.cpp: Removed.
        * css/cssparser.h: Removed.
        * css/CSSParser.cpp: Copied from css/cssparser.cpp.
        * css/CSSParser.h: Copied from css/cssparser.h.
        * css/cssstyleselector.cpp: Removed.
        * css/cssstyleselector.h: Removed.
        * css/CSSStyleSelector.cpp: Copied from css/cssstyleselector.cpp.
        * css/CSSStyleSelector.h: Copied from css/cssstyleselector.h.
        * dom/Document.cpp:
        * dom/Element.cpp:
        * dom/StyledElement.cpp:
        * editing/ApplyStyleCommand.cpp:
        * editing/markup.cpp:
        * html/CanvasGradient.cpp:
        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasStyle.cpp:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLBaseElement.cpp:
        * html/HTMLBodyElement.cpp:
        * html/HTMLDocument.cpp:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLFormElement.cpp:
        * html/HTMLFrameElementBase.cpp:
        * html/HTMLImageElement.cpp:
        * html/HTMLImageLoader.cpp:
        * html/HTMLLinkElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/HTMLOptGroupElement.cpp:
        * html/HTMLOptionElement.cpp:
        * html/HTMLSelectElement.cpp:
        * html/HTMLTableElement.cpp:
        * html/HTMLTablePartElement.cpp:
        * html/HTMLTokenizer.cpp:
        * ksvg2/css/SVGCSSParser.cpp:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGUseElement.cpp:
        * page/DOMWindow.cpp:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * rendering/HitTestResult.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Adam
beidson [Wed, 18 Jul 2007 17:18:07 +0000 (17:18 +0000)]
    Rubberstamped by Adam

        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile): Correct license on this newly checked in file from yesterday

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build, call dftables from the right directory.
hausmann [Wed, 18 Jul 2007 15:46:28 +0000 (15:46 +0000)]
Fix the Qt build, call dftables from the right directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDon't call gcc directly when building the dftables tool but use a separate .pro file...
hausmann [Wed, 18 Jul 2007 15:16:23 +0000 (15:16 +0000)]
Don't call gcc directly when building the dftables tool but use a separate .pro file for the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago We really don't want to compare non text only tests to the Mac results if we don...
lars [Wed, 18 Jul 2007 14:01:53 +0000 (14:01 +0000)]
 We really don't want to compare non text only tests to the Mac results if we don't have a result for Qt, as this would give a failure and not a notification that the test is new.

        Skip a test that pops up a message box and makes the test hang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agotop level:
thatcher [Wed, 18 Jul 2007 13:55:11 +0000 (13:55 +0000)]
top level:

        Add a SCRIPTS_PATH variable so Makefiles of differnet nested directories can
        still use this one Makefile.shared as an include.

        * Makefile.shared:

WebKitTools:

        Remove the redundant copies of Makefile.shared and the new Makefile.Drosera.
        Now included the main Makefile.shared and change the SCRIPTS_PATH variable as needed.

        * Drosera/Makefile: Added.
        * Drosera/mac/Makefile:
        * DumpRenderTree/Makefile:
        * Makefile:
        * Makefile.Drosera: Removed.
        * Makefile.shared: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago The console log was 20px down from the top for no reason, move it up.
thatcher [Wed, 18 Jul 2007 13:30:47 +0000 (13:30 +0000)]
    The console log was 20px down from the top for no reason, move it up.

        * Drosera/console.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Use contentDocument to get the source view's iframe document.
thatcher [Wed, 18 Jul 2007 13:28:57 +0000 (13:28 +0000)]
    Use contentDocument to get the source view's iframe document.
        Also adds a null/undefined check for localVariableNames.

        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Zack & Simon
lars [Wed, 18 Jul 2007 12:22:29 +0000 (12:22 +0000)]
    Reviewed by Zack & Simon

        Reallow setting of scrollbar policies on QWebFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Wed, 18 Jul 2007 09:07:30 +0000 (09:07 +0000)]
LayoutTests:

        Reviewed by Oliver.

        - test for <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari

        * fast/tokenizer/badscript-expected.txt: Added.
        * fast/tokenizer/badscript.html: Added.

WebCore:

        Reviewed by Oliver.

        - fixed <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari

        Test Case: fast/tokenizer/badscript.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag): Don't apply our self-closing
        <script> quirk in cases where the / appears in a mangled attribtue
        value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
tristan [Wed, 18 Jul 2007 08:20:28 +0000 (08:20 +0000)]
    Reviewed by Maciej Stachowiak.

        <rdar://problem/5341334> Alt-clicking a link in Safari does not register original URL info with gatekeeper
        <rdar://problem/5342570> REGRESSION: A hang occurs when attempting to open a attached file from a .Mac web mail message

        * WebCoreSupport/WebFrameLoaderClient.h:
        Added a new method, setOriginalURLForDownload, for both download()
        and startDownload() to share.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        Moved all the gatekeeper code into setOriginalURLForDownload.

        (WebFrameLoaderClient::setOriginalURLForDownload):
        Same code that was in download() but moved into a single place for both
        startDownload and download to use.  Also returned the boolean logic
        for detecting _wasUserGesture back to it's previous state, since my prior change
        was incorrect.  Additionally I found a loop index bug with backListCount and fixed it.

        (WebFrameLoaderClient::startDownload):
        Calls out to setOriginalURLForDownload after a download is created.

        * WebView/WebView.mm:
        (-[WebView _downloadURL:]):
        Changed to return the WebDownload object created inside _downloadURL

        * WebView/WebViewInternal.h:
        Changed _downloadURL to return the WebDownload it creates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCleanliness is next to ... well, it's a Good Thing
bdash [Wed, 18 Jul 2007 06:36:58 +0000 (06:36 +0000)]
Cleanliness is next to ... well, it's a Good Thing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Blind Windows build fix from r24395
beidson [Wed, 18 Jul 2007 06:33:00 +0000 (06:33 +0000)]
    Blind Windows build fix from r24395

        * WebView.cpp:
        (WebView::initWithFrame): BSTR, not BString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
weinig [Wed, 18 Jul 2007 06:27:57 +0000 (06:27 +0000)]
    Reviewed by Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=13618
        Don't set link targets to "_blank" on middle-click; rely on the policy
        delegate to do the right thing.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-18 Mark Rowe <mrowe@apple.com>
bdash [Wed, 18 Jul 2007 06:20:34 +0000 (06:20 +0000)]
2007-07-18  Mark Rowe  <mrowe@apple.com>

        Update path to the Drosera Xcode project now that it has moved into a subdirectory.

        * BuildSlaveSupport/build-launcher-app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
oliver [Wed, 18 Jul 2007 06:01:24 +0000 (06:01 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4799967> Safari and other WebKit
        apps sometimes crash in WebCore::FontData::platformInit

        Always retain/release our font handle, instead of only retaining
        in the presence of GC.

        * platform/mac/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::~FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
weinig [Wed, 18 Jul 2007 05:40:54 +0000 (05:40 +0000)]
LayoutTests:

        Reviewed by Geoff Garen.

        Test for <rdar://problem/5333957>

        * http/tests/security/cross-frame-access-protocol.html: Fix a few typos.
        * http/tests/security/cross-frame-access-selection-expected.txt: Added.
        * http/tests/security/cross-frame-access-selection.html: Added.
        * http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Added.

WebCore:

        Reviewed by Geoff Garen.

        Fix for <rdar://problem/5333957>
                http://bugs.webkit.org/show_bug.cgi?id=14610

        Original patch by Feng Qian.

        - Clear the selection object when disconnecting a frame.

        Test: http/tests/security/cross-frame-access-selection.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::disconnectFrame):
        (WebCore::DOMWindow::clear):
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::clearScriptProxy):
        (WebCore::Frame::clearDOMWindow):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
oliver [Wed, 18 Jul 2007 04:44:18 +0000 (04:44 +0000)]
LayoutTests:

        Reviewed by Sam.

        Correct layout test.

        * fast/events/keydown-keypress-preventDefault-expected.txt:
        * fast/events/keydown-keypress-preventDefault.html:

WebCore:

        Reviewed by Sam.

        Fix for <rdar://problem/5154518> REGRESSION: Hitting return does
        nothing in ruby terminal at http://tryruby.hobix.com/

        Calling event.preventDefault() during a keydown event should not
        prevent the keypress event from firing.

        * WebCore.xcodeproj/project.pbxproj:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::defaultKeyboardEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
andersca [Wed, 18 Jul 2007 03:46:10 +0000 (03:46 +0000)]
LayoutTests:

        Reviewed by Geoff.

        <rdar://problem/4993463>
        http://bugs.webkit.org/show_bug.cgi?id=12732
        REGRESSION: Comments fields on ircimages not showing up in nightly

        * fast/frames/iframe-set-inner-html-expected.txt: Added.
        * fast/frames/iframe-set-inner-html.html: Added.

WebCore:

        Reviewed by Geoff.

        <rdar://problem/4993463>
        http://bugs.webkit.org/show_bug.cgi?id=12732
        REGRESSION: Comments fields on ircimages not showing up in nightly

        Postpone setting the frame name to just right before we request the frame. Otherwise,
        two calls to FrameTree::uniqueChildName will return the same frame name and in that case only
        one Frame object will actually be created and multiple iframe elements will refer to it.

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::openURL):
        (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
        (WebCore::HTMLFrameElementBase::setNameAndOpenURLCallback):
        (WebCore::HTMLFrameElementBase::insertedIntoDocument):
        (WebCore::HTMLFrameElementBase::attach):
        * html/HTMLFrameElementBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore: 2007-07-17 Brady Eidson <beidson@apple.com>
beidson [Wed, 18 Jul 2007 02:39:03 +0000 (02:39 +0000)]
WebCore: 2007-07-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Steve

        Required for <rdar://problem/4516185> - FTP Directory Listings

        * WebCore.vcproj/WebCore.vcproj: Added SharedBufferWin

        * platform/SharedBuffer.cpp: Windows doesn't get the default empty resource anymore
        * platform/win/SharedBufferWin.cpp: Added.
        (WebCore::SharedBuffer::createWithContentsOfFile):

WebKit/win: 2007-07-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Steve

        <rdar://problem/4516185> - FTP Directory Listings

        * Interfaces/IWebUIDelegate.idl: Add IWebUIDelegate2 method for getting the path to the template

        * WebView.cpp:
          (WebView::initWithFrame): Set the preference for the template path in WebCore when the first
          WebView is initialized

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Wed, 18 Jul 2007 02:25:38 +0000 (02:25 +0000)]
JavaScriptCore:

        Reviewed by Darin, Maciej, and Adam.

        Fixes <http://bugs.webkit.org/show_bug.cgi?id=9697>,
              the failure of ecma/GlobalObject/15.1.2.2-2.js,
              the failure of ecma/LexicalConventions/7.7.3-1.js,
              and most of the failures of tests in ecma/TypeConversion/9.3.1-3.js.

        Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53

        This patch also fixes similar issues in the lexer and UString::toDouble().

        * kjs/function.cpp:
        (KJS::parseIntOverflow):
        (KJS::parseInt):
        * kjs/function.h:
        * kjs/lexer.cpp:
        (KJS::Lexer::lex):
        * kjs/ustring.cpp:
        (KJS::UString::toDouble):
        * tests/mozilla/expected.html:

LayoutTests:

        Reviewed by Darin.

        Added tests for:
        http://bugs.webkit.org/show_bug.cgi?id=9697

        Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53

        * fast/js/numeric-conversion-expected.txt: Added.
        * fast/js/numeric-conversion.html: Added.
        * fast/js/resources/numeric-conversion.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
thatcher [Tue, 17 Jul 2007 23:39:54 +0000 (23:39 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5336267> loadData:MIMEType:textEncodingName:baseURL: doesn't like relative URLs

        Get the absoluteURL from any user supplied NSURL before we pass it down to WebCore.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
        * WebView/WebView.mm:
        (-[WebView userAgentForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove WebKit.LP64.exp from te target membership.
thatcher [Tue, 17 Jul 2007 23:28:09 +0000 (23:28 +0000)]
Remove WebKit.LP64.exp from te target membership.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-17 Ada Chan <adachan@apple.com>
adachan [Tue, 17 Jul 2007 22:08:07 +0000 (22:08 +0000)]
2007-07-17  Ada Chan  <adachan@apple.com>

        Rubbet-stamped by Adam.

        Fixed build.

        * Interfaces/IWebFramePrivate.idl:
        * WebContextMenuClient.cpp:
        (fixMenuReceivedFromOldSafari):
        * WebFrame.cpp:
        (WebFrame::loadURLIntoChild):
        (WebFrame::download):
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the build.
treat [Tue, 17 Jul 2007 22:03:05 +0000 (22:03 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMade the recently added functions static so that they'll have internal linkage.
justing [Tue, 17 Jul 2007 21:55:05 +0000 (21:55 +0000)]
Made the recently added functions static so that they'll have internal linkage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-17 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Tue, 17 Jul 2007 21:28:08 +0000 (21:28 +0000)]
2007-07-17  Holger Hans Peter Freyther  <zecke@selfish.org>

        Blind build fix for Qt after r24366 by adding the additional
        WebCore::ResourceRequest& parameter to the download method.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::download):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher
beidson [Tue, 17 Jul 2007 21:27:27 +0000 (21:27 +0000)]
    Reviewed by Tim Hatcher

        Tweak the class names we give to the icon table cell to make it easier to style

        * loader/FTPDirectoryDocument.cpp:
          (WebCore::FTPDirectoryTokenizer::appendEntry): The the table cell a "IconCell" class name and
          either a "FileType" or "DirectoryType" class name depending on the type

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Tue, 17 Jul 2007 21:27:01 +0000 (21:27 +0000)]
LayoutTests:

        Reviewed by Kevin Decker.

        Layout test that demonstrates why an old ASSERT in WebCore was wrong.

        * ChangeLog:
        * fast/history/go-back-to-changed-name-expected.txt: Added.
        * fast/history/go-back-to-changed-name.html: Added.
        * fast/history/resources/go-back-to-changed-name2.html: Added.
        * fast/history/resources/go-back-to-changed-name3.html: Added.
        * http/tests/security/cross-frame-access-data-url-expected.txt: Added.
        * http/tests/security/cross-frame-access-data-url.html: Added.

WebCore:

        Reviewed by NOBODY.

        Build fix after r24366 add an additional ResourceRequest parameter to
        the download method.

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::download):
        * loader/gdk/FrameLoaderClientGdk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-17 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Tue, 17 Jul 2007 21:22:40 +0000 (21:22 +0000)]
2007-07-17  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by NOBODY.

        Build fix after r24366 add an additional ResourceRequest parameter to
        the download method.

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::download):
        * loader/gdk/FrameLoaderClientGdk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
aroben [Tue, 17 Jul 2007 21:17:25 +0000 (21:17 +0000)]
Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item

WebCore:

        Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
        http://bugs.webkit.org/show_bug.cgi?id=14324

        Reviewed by Tim.

        No regression test possible.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Add the
        Inspect Element item to the menu before passing it to the
        ContextMenuClient so that the UI delegate has a chance to
        modify/remove the item.

WebKit:

        Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
        http://bugs.webkit.org/show_bug.cgi?id=14324

        Only clients linking against new versions of WebKit will see the item.
        I've maintained our behavior for old clients of not including the
        Inspect Element item in the menu items passed to the UI delegate.

        Reviewed by Tim.

        * Misc/WebKitVersionChecks.h: Added a new constant.
        * WebCoreSupport/WebContextMenuClient.mm:
        (isPreInspectElementTagClient): Added.
        (fixMenusToSendToOldClients): Return an array of items that should be
        appended to the menu received from the delegate.
        (fixMenusReceivedFromOldClients): Append the saved items to the array.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Retain/release
        the saved items.

WebKit/win:

        Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
        http://bugs.webkit.org/show_bug.cgi?id=14324

        If we detect that we're running against the Safari 3 Beta, we add back
        the Inspect Element menu item after passing it off to the delegate
        because Safari's UI delegate will remove it.

        Reviewed by Tim.

        * WebContextMenuClient.cpp:
        (isPreInspectElementTagSafari): Added.
        (fixMenuReceivedFromOldSafari): Added.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
        fixMenuReceivedFromOldSafari before returning the new menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove ContextMenuClient::shouldIncludeInspectElementItem
aroben [Tue, 17 Jul 2007 21:17:14 +0000 (21:17 +0000)]
Remove ContextMenuClient::shouldIncludeInspectElementItem

WebCore:

        Remove ContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        No regression test possible.

        * page/ContextMenuClient.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Use Settings
        to determine whether to include the Inspect Element item.
        * page/gdk/ContextMenuClientGdk.cpp:
        * page/gdk/ContextMenuClientGdk.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:

WebKit:

        Remove WebContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:

WebKit/win:

        Remove WebContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebContextMenuClient.cpp:
        * WebContextMenuClient.h:

WebKitQt:

        Remove ContextMenuClientQt::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebCoreSupport/ContextMenuClientQt.cpp:
        * WebCoreSupport/ContextMenuClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoInitialize ContextMenuController::m_page
aroben [Tue, 17 Jul 2007 21:17:00 +0000 (21:17 +0000)]
Initialize ContextMenuController::m_page

Somehow this variable had never been initialized before.

Reviewed by Tim.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
* page/ContextMenuController.h:
* page/Page.cpp:
(WebCore::Page::Page):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd/initialize Settings::developerExtrasEnabled
aroben [Tue, 17 Jul 2007 21:16:21 +0000 (21:16 +0000)]
Add/initialize Settings::developerExtrasEnabled

WebCore:

        Add Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebCore.exp:
        * page/Settings.cpp:
        * page/Settings.h:

WebKit:

        Initialize Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

        Initialize Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebView.cpp:
        (WebView::updateWebCoreSettingsFromPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
ggaren [Tue, 17 Jul 2007 21:13:20 +0000 (21:13 +0000)]
    Build fix.

        * WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle): Pass false for lockHistory
        like we do elsewhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Antti Koivisto.
ggaren [Tue, 17 Jul 2007 21:10:17 +0000 (21:10 +0000)]
    Reviewed by Antti Koivisto.

        Added watchdog timer to waitUntilDone to prevent a run-away test from
        hanging the test harness.

        * DumpRenderTree/DumpRenderTree.m:
        (dump):
        (-[LayoutTestController waitUntilDone]):
        (-[LayoutTestController waitUntilDoneWatchdogFired]):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 17 Jul 2007 21:05:21 +0000 (21:05 +0000)]
LayoutTests:

        Reviewed by Antti.

        <rdar://problem/5206311>
        Whitespace can't be removed when editing text pasted into from web page

        * editing/deleting/5206311-1-expected.checksum: Added.
        * editing/deleting/5206311-1-expected.png: Added.
        * editing/deleting/5206311-1-expected.txt: Added.
        * editing/deleting/5206311-1.html: Added.
        * editing/deleting/5206311-2-expected.checksum: Added.
        * editing/deleting/5206311-2-expected.png: Added.
        * editing/deleting/5206311-2-expected.txt: Added.
        * editing/deleting/5206311-2.html: Added.

WebCore:

        Reviewed by Antti.

        <rdar://problem/5206311>
        Whitespace can't be removed when editing text pasted into from web page

        The whitespace comes from table rows that aren't being removed after they are
        emptied out during a deletion.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::isTableCell):
        (WebCore::isTableRow):
        (WebCore::isTableCellEmpty):
        (WebCore::isTableRowEmpty):
        (WebCore::DeleteSelectionCommand::initializePositionData): Remember the table
        rows that contained the start and end of the selection.
        (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
        Remove table rows that come before the end of the selection
        that was removed (except for the row that contained the start of the selection
        and any before that).
        Remove table rows that are come after the start of the selection
        that was removed (except for the row that contained the end of the selection
        and any after that).
        (WebCore::DeleteSelectionCommand::doApply): Call the new function.
        * editing/DeleteSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullo [Tue, 17 Jul 2007 21:03:21 +0000 (21:03 +0000)]
    Reviewed by Adam.

        - Implemented cross-platform code for functions calling into the JavaScript.

        * Drosera/DebuggerDocument.cpp:
        (DebuggerDocument::callAsFunction):
        (DebuggerDocument::pauseJS):
        (DebuggerDocument::resumeJS):
        (DebuggerDocument::stepIntoJS):
        (DebuggerDocument::stepOverJS):
        (DebuggerDocument::stepOutJS):
        (DebuggerDocument::showConsoleJS):
        (DebuggerDocument::closeCurrentFileJS):
        (DebuggerDocument::updateFileSource):
        (DebuggerDocument::didParseScript):
        (DebuggerDocument::willExecuteStatement):
        (DebuggerDocument::didEnterCallFrame):
        (DebuggerDocument::willLeaveCallFrame):
        (DebuggerDocument::exceptionWasRaised):
        * Drosera/DebuggerDocument.h:
        * Drosera/mac/DebuggerDocumentMac.mm:
        (-[DebuggerDocumentMac pause:]):
        (-[DebuggerDocumentMac resume:]):
        (-[DebuggerDocumentMac stepInto:]):
        (-[DebuggerDocumentMac stepOver:]):
        (-[DebuggerDocumentMac stepOut:]):
        (-[DebuggerDocumentMac showConsole:]):
        (-[DebuggerDocumentMac closeCurrentFile:]):
        (-[DebuggerDocumentMac webView:didLoadMainResourceForDataSource:]):
        (-[DebuggerDocumentMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[DebuggerDocumentMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[DebuggerDocumentMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[DebuggerDocumentMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        (-[DebuggerDocumentMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
ggaren [Tue, 17 Jul 2007 20:57:49 +0000 (20:57 +0000)]
    Build fix.

        * plugins/win/PluginViewWin.cpp: Pass false for lockHistory like we
        do elsewhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-07-17 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Tue, 17 Jul 2007 20:51:53 +0000 (20:51 +0000)]
2007-07-17  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Implement the callback responsible for handling HTTP headers. This
        callback gets called for every header.
        We will add these headers to our ResourceResponse and on the 'end-of-header'
        indicator we will update the ResourceResponse and dispatch it.

        This patch adds various set methods to ResourceResponse. This improves
        the readability of the headerCallback and avoids storing a CURL handle inside
        the ResourceResponse which would be needed to implement ResourceResponse::doUpdateResourceResponse

        Add a destructor for ResourceHandleManager which would free the resources and remove
        a unused variable.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/ResourceResponse.cpp:
        (WebCore::ResourceResponse::setUrl):
        (WebCore::ResourceResponse::setMimeType):
        (WebCore::ResourceResponse::setExpectedContentLength):
        (WebCore::ResourceResponse::setTextEncodingName):
        (WebCore::ResourceResponse::setSuggestedFilename):
        * platform/network/ResourceResponse.h:
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::~ResourceHandleManager):
        (WebCore::ResourceHandleManager::sharedInstance):
        (WebCore::headerCallback):
        * platform/network/curl/ResourceHandleManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
weinig [Tue, 17 Jul 2007 20:31:58 +0000 (20:31 +0000)]
LayoutTests:

        Reviewed by Adam Roben.

        * fast/dom/Window/alert-undefined-expected.txt: Added.
        * fast/dom/Window/alert-undefined.html: Added.

WebCore:

        Reviewed by Adam Roben.

        Convert JS undefined to the empty string when calling alert, confirm, and prompt.

        Test: fast/dom/Window/alert-undefined.html

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24371 268f45cc-cd09-0410-ab3c-d52691b4dbfc