commit-queue@webkit.org [Mon, 20 Dec 2010 06:44:33 +0000 (06:44 +0000)]
Move WebKitExamplePlugins to Examples
https://bugs.webkit.org/show_bug.cgi?id=51291
Reviewed by Sam Weinig.
.:
* Examples: Copied from WebKitExamplePlugins.
* WebKitExamplePlugins: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/MenuHandler.h: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/MenuHandler.m: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeCocoaPlugin/test.html: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Pause.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Play.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/test.html: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/Composition.qtz: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeCoreAnimationPlugin/test.html: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/English.lproj: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/English.lproj/InfoPlist.strings: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/Info.plist: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj/project.pbxproj: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/main.m: Removed.
* WebKitExamplePlugins/NetscapeInputMethodPlugin/test.html: Removed.
* cmake/WebKitPackaging.cmake:
BugsSite:
* PrettyPatch/PrettyPatch.rb:
Tools:
* Scripts/webkitpy/common/config/build.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Dec 2010 05:24:21 +0000 (05:24 +0000)]
2010-12-19 Benjamin Kalman <kalman@chromium.org>
Reviewed by Antonio Gomes.
[chromium] editing/selection/extend-selection-home-end.html should have one expected result
https://bugs.webkit.org/show_bug.cgi?id=49873
Change 100px to 5em in editing/selection/extend-selection-home-end.html so that chromium
results are the same as the non-chromium results.
* editing/selection/resources/extend-selection.js: Change 100px to 5em.
* platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 20 Dec 2010 03:05:52 +0000 (03:05 +0000)]
Improve the fix for <rdar://problem/8769525>.
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Do not retain the view. Doing so is necessary in
-[WebHTMLView performKeyEquivalent:], which this method was based upon, but not here, because
there is no way for the web process to cause the WKView to be released while it is handling
the event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 20 Dec 2010 02:42:52 +0000 (02:42 +0000)]
<rdar://problem/8769525> WKView leak when performing key equivalents
https://bugs.webkit.org/show_bug.cgi?id=51315
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Use a RetainPtr to ensure that the view is released in the
early return code path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Dec 2010 01:02:20 +0000 (01:02 +0000)]
2010-12-19 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Blur distance should not be affected by transformations
https://bugs.webkit.org/show_bug.cgi?id=51161
From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
"The shadowBlur attribute specifies the level of the blurring effect.
(The units do not map to coordinate space units, and are not affected
by the current transformation matrix.)"
Add test to ensure that the blur radius is not affected by the CTM.
* fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* fast/canvas/canvas-scale-shadowBlur.html: Added.
* fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Increase
shadowBlur and test tolerance to ease testing and support the
different blurring algorithms.
* fast/canvas/script-tests/canvas-scale-shadowBlur.js: Added.
* fast/canvas/script-tests/canvas-scale-strokePath-shadow.js:
2010-12-19 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Blur distance should not be affected by transformations
https://bugs.webkit.org/show_bug.cgi?id=51161
From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
"The shadowBlur attribute specifies the level of the blurring effect.
(The units do not map to coordinate space units, and are not affected
by the current transformation matrix.)"
Test: fast/canvas/canvas-scale-shadowBlur.html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::adjustBlurDistance):
* platform/graphics/ContextShadow.h:
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::beginShadowLayer):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Sun, 19 Dec 2010 21:34:51 +0000 (21:34 +0000)]
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] QWKPagePrivate::paint() does not need to save the graphics context
https://bugs.webkit.org/show_bug.cgi?id=51300
Remove the unnecessary save() and restore() on the QPainter.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 19 Dec 2010 21:29:35 +0000 (21:29 +0000)]
Text emphasis marks are not repainted correctly in flipped writing modes
https://bugs.webkit.org/show_bug.cgi?id=51307
Reviewed by Cameron Zwarich.
WebCore:
Tests: fast/repaint/text-emphasis-h.html
fast/repaint/text-emphasis-v.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added flippedness check.
LayoutTests:
* fast/repaint/text-emphasis-h-expected.checksum: Added.
* fast/repaint/text-emphasis-h-expected.png: Added.
* fast/repaint/text-emphasis-h-expected.txt: Added.
* fast/repaint/text-emphasis-h.html: Added.
* fast/repaint/text-emphasis-v-expected.checksum: Added.
* fast/repaint/text-emphasis-v-expected.png: Added.
* fast/repaint/text-emphasis-v-expected.txt: Added.
* fast/repaint/text-emphasis-v.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sun, 19 Dec 2010 18:44:24 +0000 (18:44 +0000)]
2010-12-19 Rob Buis <rwlbuis@gmail.com>
Reviewed by Andreas Kling.
Remove m_drawsContents from RenderSVGContainer.h
https://bugs.webkit.org/show_bug.cgi?id=51305
Remove m_drawsContents, its getter and setter and the call
sites, since it has no effect anymore.
* WebCore.order:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGContainer.h:
* rendering/RenderSVGResourceContainer.h:
* rendering/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Sun, 19 Dec 2010 17:24:07 +0000 (17:24 +0000)]
2010-12-19 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
[Qt] [WK2] Client are expected to render their own background for WebPages
https://bugs.webkit.org/show_bug.cgi?id=51296
Remove the rendering of the checkerboard from the tiled DrawingAreaProxy
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::paint):
* UIProcess/TiledDrawingAreaTile.h:
* UIProcess/qt/TiledDrawingAreaTileQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Sun, 19 Dec 2010 15:57:12 +0000 (15:57 +0000)]
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit does not build with worker but without the javascript debugger
https://bugs.webkit.org/show_bug.cgi?id=51293
Add missing guard for calls depending on the debugger.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::postWorkerNotificationToFrontend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Sun, 19 Dec 2010 15:28:30 +0000 (15:28 +0000)]
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Client are expected to render their own background for WebPages
https://bugs.webkit.org/show_bug.cgi?id=51296
Do not render a white background before rendering the page with DrawingAreaProxy.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Dec 2010 06:51:21 +0000 (06:51 +0000)]
2010-12-18 Tom Sepez <tsepez@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=51055
Fix a null de-reference when an XML file contains a malformed entity
of the form "&:;".
* fast/parser/resources/xml-colon-entity.xml: Added.
* fast/parser/xml-colon-entity-expected.txt: Added.
* fast/parser/xml-colon-entity.html: Added.
2010-12-18 Tom Sepez <tsepez@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=51055
Fix a null de-reference when an XML file contains a malformed entity
of the form "&:;".
Test: fast/parser/xml-colon-entity.html
* html/parser/HTMLEntitySearch.cpp:
(WebCore::HTMLEntitySearch::advance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Dec 2010 02:55:34 +0000 (02:55 +0000)]
2010-12-18 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Simplify the PNG encoder.
https://bugs.webkit.org/show_bug.cgi?id=50905
Remove PNGEncoderState class - it was a proxy for the encoder output, and
that is a Vector<>, so just write into it directly using append() to make
use of Vector<>'s resize() smarts. Simplify the preMultipliedBGRAtoRGBA()
and encode() routines, replace the OwnArrayPtr<> with a Vector<>.
canvas.toDataURL("image/png") is covered by existing tests.
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::writeOutput): Use a Vector<>, append() the encoded data to it.
(WebCore::preMultipliedBGRAtoRGBA): simplified.
(WebCore::PNGImageEncoder::encode): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 18 Dec 2010 23:32:32 +0000 (23:32 +0000)]
Text emphasis marks are not always included in the selection highlight
https://bugs.webkit.org/show_bug.cgi?id=51299
Reviewed by Cameron Zwarich.
WebCore:
Affects pixel results of fast/text/emphasis.html
Account for annotations in selectionTop() and selectionBottom().
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
LayoutTests:
* platform/mac/fast/text/emphasis-expected.checksum:
* platform/mac/fast/text/emphasis-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 18 Dec 2010 22:49:45 +0000 (22:49 +0000)]
In flipped writing modes, opposite text emphasis marks from adjacent lines overlap
https://bugs.webkit.org/show_bug.cgi?id=51298
Reviewed by Cameron Zwarich.
WebCore:
Test: fast/text/emphasis-overlap.html
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Changed + to -.
LayoutTests:
* fast/text/emphasis-overlap-expected.checksum: Added.
* fast/text/emphasis-overlap-expected.png: Added.
* fast/text/emphasis-overlap-expected.txt: Added.
* fast/text/emphasis-overlap.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 18 Dec 2010 18:44:48 +0000 (18:44 +0000)]
2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422
On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows
"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."
NOTE: this applies only to canvas, not to box shadows.
Add new test to ensure that shadows are correctly transformed keeping
the relative offset to the shape.
* fast/canvas/canvas-scale-strokePath-shadow-expected.txt: See strokePath below.
* fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
* fast/canvas/canvas-transforms-fillRect-shadow.html: Added.
* fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
* fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
* fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Now using
a lineWidth > 1 to make it easier to test and more fair among all
ports, since there can be different transformation smoothness or
aliasing settings.
* fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Added.
* platform/gtk/Skipped: GTK port needs to implement this feature.
* platform/gtk/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Removed.
* platform/gtk/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Removed.
* platform/gtk/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422
On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows
"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."
NOTE: this applies only to canvas, not to box shadows.
Test: fast/canvas/canvas-transforms-fillRect-shadow.html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
(WebCore::ContextShadow::setShadowsIgnoreTransforms):
(WebCore::ContextShadow::shadowsIgnoreTransforms):
(WebCore::ContextShadow::offset):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::mustUseContextShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Sat, 18 Dec 2010 17:41:05 +0000 (17:41 +0000)]
2010-12-18 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[Qt] TransparencyLayer should inherit its container render hints
https://bugs.webkit.org/show_bug.cgi?id=51283
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 18 Dec 2010 09:23:56 +0000 (09:23 +0000)]
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
* fast/dom/Window/window-properties-performance-expected.txt:
* fast/dom/script-tests/webtiming.js:
(checkTimingBeforeLoad):
(checkTimingWhileDeferred):
(checkWebTimingOnDOMContentLoaded):
(checkWebTimingWhileAsync):
(checkWebTimingOnLoad):
(checkWebTimingAfterLoad):
* fast/dom/webtiming-document-open-expected.txt:
* fast/dom/webtiming-expected.txt:
* fast/dom/webtiming-navigate-within-document-expected.txt:
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
See: http://test.w3.org/webperf/specs/NavigationTiming/#nt-dom-content-event-start
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
* dom/DocumentTiming.h:
(WebCore::DocumentTiming::DocumentTiming):
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::domContentLoadedEventStart):
(WebCore::PerformanceTiming::domContentLoadedEventEnd):
* page/PerformanceTiming.h:
* page/PerformanceTiming.idl:
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
Exposes all dom* times to the chromium port. I'm particularly interested in
domContentLoadedEventEnd as it compares to the FinishDoc metric.
* public/WebPerformance.h:
* src/WebPerformance.cpp:
(WebKit::WebPerformance::domLoading):
(WebKit::WebPerformance::domInteractive):
(WebKit::WebPerformance::domContentLoadedEventStart):
(WebKit::WebPerformance::domContentLoadedEventEnd):
(WebKit::WebPerformance::domComplete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 18 Dec 2010 06:20:39 +0000 (06:20 +0000)]
2010-12-17 Tony Gentilcore <tonyg@chromium.org>
Unreviewed.
[chromium] Mark fast/text/emphasis* failing
https://bugs.webkit.org/show_bug.cgi?id=51288
They have square characters that appear broken.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 18 Dec 2010 05:20:41 +0000 (05:20 +0000)]
2010-12-17 Tony Gentilcore <tonyg@chromium.org>
Unreviewed fix.
Fix JS syntax to avoid V8 error message
https://bugs.webkit.org/show_bug.cgi?id=51287
* transitions/interrupted-accelerated-transition.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Sat, 18 Dec 2010 04:22:55 +0000 (04:22 +0000)]
2010-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Andreas Kling.
Style fix for r73927
https://bugs.webkit.org/show_bug.cgi?id=51194
No functionality change. No new tests needed.
* html/HTMLCanvasElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Dec 2010 02:37:35 +0000 (02:37 +0000)]
2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Buttons rendering was broken in r74129
https://bugs.webkit.org/show_bug.cgi?id=51173
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintRenderObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Sat, 18 Dec 2010 02:32:24 +0000 (02:32 +0000)]
2010-12-17 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Improve 'arithmetic' operator on feComposite
https://bugs.webkit.org/show_bug.cgi?id=51105
Fixing style errors and bug description for r74177.
* platform/graphics/filters/FEComposite.cpp:
(WebCore::arithmetic):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Sat, 18 Dec 2010 02:01:13 +0000 (02:01 +0000)]
2010-12-17 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
RegExp Jit'ed expression crashes clicking link on yelp.com
https://bugs.webkit.org/show_bug.cgi?id=51284
When transitioning between an non-repeating beginning of line
anchored expression and the remaining refactored repeating
expression, we should not clear any residual datalabel in
state's m_backtrack. It will be resolved and cleared in subsequent
code when linkAlternativeBacktracks() is called for the repeating
alternative(s).
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::BacktrackDestination::clear):
(JSC::Yarr::RegexGenerator::TermGenerationState::clearBacktrack):
2010-12-17 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
RegExp Jit'ed expression crashes clicking link on yelp.com
https://bugs.webkit.org/show_bug.cgi?id=51284
New tests to validate changes made in regex JIT.
* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 18 Dec 2010 01:57:20 +0000 (01:57 +0000)]
Updated for the renaming of WebKitTools to Tools
Rubber-stamped by Mark Rowe.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
WebCore:
* WebCore.vcproj/build-generated-files.sh:
* WebCore.vcproj/migrate-scripts.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 18 Dec 2010 01:56:16 +0000 (01:56 +0000)]
2010-12-17 Tony Gentilcore <tonyg@chromium.org>
Unreviewed, build fix.
Add WebKitTools -> Tools rename that got missed.
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 18 Dec 2010 01:42:54 +0000 (01:42 +0000)]
2010-12-17 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Window title for image documents shows corrupted characters instead of multiplication sign when using WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43505
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Changed UI_STRING macros to return
WebCore::String objects instead of C strings.
(WebKit::formatLocalizedString): Added. Uses the Core Foundation string formatting function for
reasons explained in the comment.
(WebKit::WebPlatformStrategies::multipleFileUploadText): Use formatLocalizedString instead of
String::format.
(WebKit::WebPlatformStrategies::imageTitle): Ditto.
(WebKit::WebPlatformStrategies::localizedMediaTimeDescription): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 18 Dec 2010 01:24:00 +0000 (01:24 +0000)]
Add expected results for Windows XP to get the bot green for
http://trac.webkit.org/changeset/74281.
Unreviewed.
* platform/win-xp/fast/text/emphasis-expected.txt: Added.
* platform/win-xp/fast/text/emphasis-vertical-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 18 Dec 2010 01:14:59 +0000 (01:14 +0000)]
2010-12-17 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Add WebKitTools -> Tools rename that got missed.
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 18 Dec 2010 01:07:25 +0000 (01:07 +0000)]
2010-12-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Resizing a WKView while loading a page can leave the page at a size that doesn't match the window
https://bugs.webkit.org/show_bug.cgi?id=51282
<rdar://problem/8133142>
Fix a race condition in waitForMessage. If we time out on the wait condition, we would keep the
m_waitForMessageMutex mutex unlocked for a brief period of time before taking the lock again and
then removing the messageID/destinationID pair from the hash map. Under some circumstances, the
connection queue would update the hash map right before we removed it, leading to a lost message.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 18 Dec 2010 00:30:09 +0000 (00:30 +0000)]
Unreviewed Qt buildfix after r74301.
Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861
* MiniBrowser/DerivedSources.pro:
* MiniBrowser/qt/MiniBrowser.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 18 Dec 2010 00:02:12 +0000 (00:02 +0000)]
Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861
Reviewed by Simon Fraser.
.:
* DerivedSources.pro:
* GNUmakefile.am:
* MakeFile:
* MakeFile.shared:
* Tools: Renamed from WebKitTools.
* WebKit.pro:
* cmake/WebKitPackaging.cmake:
* wscript:
BugsSite:
* PrettyPatch/PrettyPatch.rb:
* committers-autocomplete.js:
Tools:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* CodeCoverage/README:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initializeFonts):
* EWSTools/start-commit-queue.sh:
* EWSTools/start-queue.sh:
* GNUmakefile.am:
* MIDLWrapper/MIDLWrapper.cpp:
(wmain):
* MiniBrowser/qt/MiniBrowser.pro:
* Scripts/build-api-tests:
* Scripts/build-dumprendertree:
* Scripts/build-webkit:
* Scripts/build-webkittestrunner:
* Scripts/generate-coverage-data:
* Scripts/old-run-webkit-tests:
* Scripts/run-api-tests:
* Scripts/run-iexploder-tests:
* Scripts/run-javascriptcore-tests:
* Scripts/run-mangleme-tests:
* Scripts/run-sunspider:
* Scripts/run-webkit-websocketserver:
* Scripts/sunspider-compare-results:
* Scripts/test-webkitperl:
* Scripts/test-webkitpy:
* Scripts/update-iexploder-cssproperties:
* Scripts/update-webkit:
* Scripts/update-webkit-localizable-strings:
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
* Scripts/webkitpy/common/config/committervalidator.py:
* Scripts/webkitpy/common/config/committervalidator_unittest.py:
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
* Scripts/webkitpy/common/system/logutils_unittest.py:
* Scripts/webkitpy/common/system/ospath_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/config.py:
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
* Scripts/webkitpy/layout_tests/port/http_server.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* wx/build/build_utils.py:
WebKitSite:
* asking_questions.html:
* building/tools.html:
* coding/scripts.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Dec 2010 23:35:30 +0000 (23:35 +0000)]
Clean up ChunkedUpdateDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=51277
Reviewed by Simon Fraser.
Get rid of m_lastSetViewSize since it was always equal to m_size.
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::sizeDidChange):
Call sendSetSize().
(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Call sendSetSize if the size differs.
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
Move code from sizeDidChange over here.
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::setSize):
Add back the early return if the sizes are equal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 17 Dec 2010 23:28:29 +0000 (23:28 +0000)]
2010-12-17 Ariya Hidayat <ariya@sencha.com>
Reviewed by Oliver Hunt.
[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
https://bugs.webkit.org/show_bug.cgi?id=51268
* parser/JSParser.cpp:
(JSC::JSParser::parseAssignmentExpression):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 17 Dec 2010 23:03:24 +0000 (23:03 +0000)]
Unreviewed build fix.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::canHandleRequest): Provide alternative for
non-CFNetwork implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 17 Dec 2010 22:48:40 +0000 (22:48 +0000)]
2010-12-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed RChunk from PageAllocation/PageReservation, since it's now unused.
https://bugs.webkit.org/show_bug.cgi?id=51276
* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation):
* wtf/PageReservation.h:
(WTF::PageReservation::PageReservation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 17 Dec 2010 22:43:49 +0000 (22:43 +0000)]
Reviewed by Anders Carlsson.
Implement WKView::setInitialFocus().
https://bugs.webkit.org/show_bug.cgi?id=51274
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetInitialFocus):
* UIProcess/API/C/win/WKView.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setInitialFocus): Send message to the Web Process to set
initial focus.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setInitialFocus):
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setInitialFocus): Set the focused node to null initially. Then
ask FocusController to set the initial focus based on the focus direction.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add a new message for SetInitialFocus.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Dec 2010 22:24:05 +0000 (22:24 +0000)]
Remove a check that probably uncovered a resizing bug.
Reviewed by Sam Weinig.
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::setSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Dec 2010 22:11:32 +0000 (22:11 +0000)]
2010-12-17 Brian Weinstein <bweinstein@apple.com>
Qt build fix.
* UIProcess/qt/WebPopupMenuProxyQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 17 Dec 2010 21:54:11 +0000 (21:54 +0000)]
2010-12-17 Simon Fraser <simon.fraser@apple.com>
Change this test to use the pause API by testing the individual properties,
rather than the compound property.
* transitions/mask-transitions-expected.txt: Removed.
* transitions/mask-transitions.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carol.szabo@nokia.com [Fri, 17 Dec 2010 21:39:19 +0000 (21:39 +0000)]
2010-12-17 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270
This patch replaces the hack introduced for fixing bug 43812
with code that addresses the underlying problem for that bug.
No new layout tests provided as there is no identified scenario when
visible behavior would be different, the internal datastructures
are maintained properly through this fix so the previous hack
introduced for bug 43812 is now removed. The fact that the
layout test introduced for 43812 continues to pass is proof that the
code works.
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Removed hack.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Moved call to counter nodes updater to lower level
functions to avoid bypass.
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Changed to update the values of the counters that
may be inserted in the tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 17 Dec 2010 21:38:49 +0000 (21:38 +0000)]
2010-12-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Incorrect encoding of some constants in ARMv7 JIT
https://bugs.webkit.org/show_bug.cgi?id=51273
<rdar://problem/8650210>
When using immediate encoding 3 we need to write the byte
that holds a duplicated value.
* assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::makeEncodedImm):
2010-12-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Incorrect encoding of some constants in ARMv7 JIT
https://bugs.webkit.org/show_bug.cgi?id=51273
Add a few tests for different byte patterns in immediates.
* fast/js/constant-encoding-expected.txt: Added.
* fast/js/constant-encoding.html: Added.
* fast/js/script-tests/constant-encoding.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 17 Dec 2010 21:37:16 +0000 (21:37 +0000)]
Add Windows-specific expected results for the the tests added in
http://trac.webkit.org/changeset/74281.
Rubber-stamped by Dan Bernstein.
* platform/win/fast/text/emphasis-expected.checksum: Added.
* platform/win/fast/text/emphasis-expected.png: Added.
* platform/win/fast/text/emphasis-expected.txt: Added.
* platform/win/fast/text/emphasis-vertical-expected.checksum: Added.
* platform/win/fast/text/emphasis-vertical-expected.png: Added.
* platform/win/fast/text/emphasis-vertical-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 17 Dec 2010 21:29:30 +0000 (21:29 +0000)]
Qt build fix.
* UIProcess/qt/WebPopupMenuProxyQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 21:24:43 +0000 (21:24 +0000)]
2010-12-17 Shimeng (Simon) Wang <swang@google.com>
Reviewed by Steve Block.
Fix V8 JNI binding.
https://bugs.webkit.org/show_bug.cgi?id=51156
There're LayoutTests in:
http://trac.webkit.org/browser/trunk/LayoutTests/java/lc3/JSNumber
to exercise these code paths.
Though Chromium don't run them.
Tested on Android fast/events/touch tests.
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertNPVariantToJValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 17 Dec 2010 21:22:47 +0000 (21:22 +0000)]
2010-12-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Interrupted accelerated animation can break later transitions
<rdar://problem/8767714>
https://bugs.webkit.org/show_bug.cgi?id=51264
If we're still waiting for the 'animationDidStart' callback when renderers
get destroyed, then the m_waitingForStartTimeResponse flag could be left
set to 'true', which causes later transitions to never start.
Fix by clearing the m_waitingForStartTimeResponse flag when the m_startTimeResponseWaiters
becomes empty.
Test: transitions/interrupted-accelerated-transition.html
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 17 Dec 2010 21:22:34 +0000 (21:22 +0000)]
2010-12-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Interrupted accelerated animation can break later transitions
https://bugs.webkit.org/show_bug.cgi?id=51264
Step 1: code cleanup.
Rename "responseWait" variables to "startTimeResponseWait", to make it clear
the kind of response that is being waited for.
Make a couple of methods private.
No behavioral changes, so no tests.
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::endAnimationUpdate):
(WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
(WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
(WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
(WebCore::AnimationControllerPrivate::startTimeResponse):
* page/animation/AnimationControllerPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 17 Dec 2010 21:08:36 +0000 (21:08 +0000)]
Text area does not update when you arrow through a <select> in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51269
<rdar://problem/8612853>
Reviewed by Anders Carlsson.
Patch by Sam Weinig.
Insteaed of keeping track of the selected index of a <select> just in the UI process, we
need to pass this information along to the web process so that the web process can draw
the correct text in the text field at the top of the select, when the selection changes (via
the arrows or other typing while the select is opened).
When the selected item in a popup changes, the UI process sends a message to the web process, telling
it about the new selected index. The web process gets this message, and then sets the text that
is visible in the select element.
* UIProcess/API/mac/PageClientImpl.h: CreatePopupMenuProxy now takes a WebPageProxy.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createPopupMenuProxy): Pass the WebPageProxy to create.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createPopupMenuProxy):
* UIProcess/API/qt/qwkpage_p.h: CreatePopupMenuProxy now takes a WebPageProxy.
* UIProcess/PageClient.h: CreatePopupMenuProxy now takes a WebPageProxy.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::valueChangedForPopupMenu): Send that the selected index changed to the
web process.selected
(WebKit::WebPageProxy::setTextFromItemForPopupMenu): Send that we should update the text for the
active popup menu (with the index of the item to show).
(WebKit::WebPageProxy::showPopupMenu): Pass the WebPageProxy to createPopupMenuProxy.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPopupMenuProxy.h: Add a client who has virtual functions for the state changing of the
popup menu. ShowPopupMenu doesn't take a new selected index anymore, that is handled by the client,
and calling down to the web process.
(WebKit::WebPopupMenuProxy::Client::~Client):
(WebKit::WebPopupMenuProxy::WebPopupMenuProxy): Initialize the client.
* UIProcess/mac/WebPopupMenuProxyMac.h:
(WebKit::WebPopupMenuProxyMac::create): Takes a WebPopupMenuProxy::Client, and passes it to the constructor.
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac): Update what's initialized by the constructor.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Call through to the web process that the value changed.
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt): Update what's initialized by the constructor.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin): Ditto.
(WebKit::WebPopupMenuProxyWin::showPopupMenu): Call through to the web process that the value changed.
(WebKit::WebPopupMenuProxyWin::setFocusedIndex): Resolve a FIXME to set the text of the popup menu.
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::create): Take in a WebPopupMenuProxy::client, and pass it to the constructor.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy): Pass the WebPageProxy to create.
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::setTextForIndex): Call through to setTextFromItem to set the select text.
* WebProcess/WebCoreSupport/WebPopupMenu.h:
* WebProcess/WebPage/WebPage.cpp: Call through to setTextForIndex on the active popup menu.
(WebKit::WebPage::setTextForActivePopupMenu):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add a new message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Dec 2010 21:06:48 +0000 (21:06 +0000)]
Add a WebPageProxy parameter to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=51271
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::create):
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::create):
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
* UIProcess/LayerBackedDrawingAreaProxy.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 17 Dec 2010 19:45:12 +0000 (19:45 +0000)]
Add API for "Always Use the Complex Text Code Path"
https://bugs.webkit.org/show_bug.cgi?id=51265
Reviewed by Darin Adler.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::encode): Encode shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::decode): Decode shouldAlwaysUseComplexTextCodePath.
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(_WKContextSetAlwaysUsesComplexTextCodePath): Added.
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize m_alwaysUsesComplexTextCodePath.
(WebKit::WebContext::ensureWebProcess): Set shouldAlwaysUseComplexTextCodePath in the creation parameters.
(WebKit::WebContext::setAlwaysUsesComplexTextCodePath): Added. Sets m_alwaysUsesComplexTextCodePath and
sends a message to the WebProcess.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Call setAlwaysUsesComplexTextCodePath() based on the creation
parameters.
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Added.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Added SetAlwaysUsesComplexTextCodePath.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 17 Dec 2010 19:35:46 +0000 (19:35 +0000)]
WebKit2: Implement a title attribute per frame
https://bugs.webkit.org/show_bug.cgi?id=51266
Reviewed by Darin Adler.
Cache the title of each frame on the WebFrameProxy. Removes
the WebPageProxy's cache of the main frame title to just
access the main frame.
We clear the cached title on new committed loads and on failures
to load.
* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyTitle):
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didChangeTitle):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::title):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 17 Dec 2010 19:31:16 +0000 (19:31 +0000)]
WebCore: Layout and rendering of CSS text-emphasis
Final part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539
Reviewed by Dave Hyatt.
Tests: fast/text/emphasis-vertical.html
fast/text/emphasis.html
Emphasis marks behave like they are stuck just above the ascender (or just below the
descender). They occupy space in the leading and in padding, and only grow the line space
if they cannot fit.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Renamed the containsRuby parameter to
hasAnnotationsBefore, and added hasAnnotationsAfter. Line annotations include ruby and text emphasis
marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added overflow from emphasis marks.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Remaned computeBlockDirectionRubyAdjustment()
to this and added adjustment for text emphasis marks.
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added. Similar to the previous function,
but for annotations under the glyphs. These can only be text emphasis marks.
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows): Paint emphasis marks.
(WebCore::InlineTextBox::paint): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Generalized the code that adjusts the last line for
ruby in flipped writing mode to also adjust the last line for emphasis marks under the line in non-
flipped writing mode.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionColor): Added this helper method which generalizes selectionForegroundColor().
(WebCore::RenderObject::selectionForegroundColor): Moved most of the code to selectionColor().
(WebCore::RenderObject::selectionEmphasisMarkColor): Added.
* rendering/RenderObject.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox): Updated initialization for new members.
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Update new members.
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Renamed blockDirectionRubyAdjustment() to this
and extended to deal with annotations over and under the line and the previous line. If both lines have
annotations into the space between the lines, maintain separation so that the annotations do not overlap.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::hasAnnotationsBefore): Added this accessor.
(WebCore::RootInlineBox::hasAnnotationsAfter): Ditto.
LayoutTests: <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539
Reviewed by Dave Hyatt.
* fast/text/emphasis-vertical.html: Added.
* fast/text/emphasis.html: Added.
* platform/mac/fast/text/emphasis-expected.checksum: Added.
* platform/mac/fast/text/emphasis-expected.png: Added.
* platform/mac/fast/text/emphasis-expected.txt: Added.
* platform/mac/fast/text/emphasis-vertical-expected.checksum: Added.
* platform/mac/fast/text/emphasis-vertical-expected.png: Added.
* platform/mac/fast/text/emphasis-vertical-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Dec 2010 19:12:44 +0000 (19:12 +0000)]
2010-12-17 Antonio Gomes <agomes@rim.com>
Unreviewed fix for Windows bots.
r74270 removed the windows specific result for extend-selection-home-end.html
since it was matching the cross platform expectation result. However, when there is
no win specific test result but there is a mac one for the same test, the later
is picked before the cross platform one.
* platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 17 Dec 2010 18:58:23 +0000 (18:58 +0000)]
2010-12-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Antonio Gomes.
editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=51261
Modified the test to run each test case using each editing behavior, eliminating the need for
platform-specific expected results.
* editing/execCommand/script-tests/toggle-compound-styles.js:
(testSingleToggle):
* platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
* platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
* platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
* platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 18:56:27 +0000 (18:56 +0000)]
2010-12-17 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833
A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.
External behaviour not changed, so no tests.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::prepareToDrawLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::isCompositingOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 17 Dec 2010 18:37:24 +0000 (18:37 +0000)]
2010-12-17 Ojan Vafai <ojan@chromium.org>
Increment psuedo-version number to avoid pulling cached version.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 17 Dec 2010 18:33:47 +0000 (18:33 +0000)]
2010-12-17 Ojan Vafai <ojan@chromium.org>
Speculative fix for the code review tool in Firefox.
Fixes a JS error and makes the status bubble mostly work
if postMessage is not supported.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 17 Dec 2010 17:57:44 +0000 (17:57 +0000)]
2010-12-16 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
Add text encoding menu API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51226
* UIProcess/API/C/WKPage.cpp:
(WKPageSupportsTextEncoding): Added.
(WKPageCopyCustomTextEncodingName): Added.
(WKPageSetCustomTextEncodingName): Added.
* UIProcess/API/C/WKPage.h: Added the functions above.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize
m_mainFrameHasCustomRepresentation to false.
(WebKit::WebPageProxy::supportsTextEncoding): Added.
(WebKit::WebPageProxy::setCustomTextEncodingName): Added.
(WebKit::WebPageProxy::didCommitLoadForFrame): Set
m_mainFrameHasCustomRepresentation.
* UIProcess/WebPageProxy.h: Added supportsTextEncoding,
setCustomTextEncodingName, customTextEncodingName, and
m_mainFrameHasCustomRepresentation.
* UIProcess/WebPageProxy.messages.in: Tweaked formatting
(added a blank line).
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setCustomTextEncodingName): Added.
* WebProcess/WebPage/WebPage.h: Added setCustomTextEncodingName.
* WebProcess/WebPage/WebPage.messages.in: Added the
SetCustomTextEncodingName message. Tweaked formatting of the
dummy message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 17:37:04 +0000 (17:37 +0000)]
2010-12-17 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
Fix test failures where NULL GeolocationClient is provided
https://bugs.webkit.org/show_bug.cgi?id=51256
* src/GeolocationClientProxy.cpp:
(WebKit::GeolocationClientProxy::geolocationDestroyed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Dec 2010 17:12:56 +0000 (17:12 +0000)]
2010-12-17 Antonio Gomes <agomes@rim.com>
Unreviewed expectation result update.
editing/execCommand/toggle-compound-styles.html needs new expected results after r74269.
Default editing behavior of GTK+ DRT was changed from Mac to Unix, and this test is wrongly
going through platform specific editing behavior code path without making calls to
LayoutTestController::setEditingBehavior. Filed bug 51261 for the proper fix.
* platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 17 Dec 2010 16:43:05 +0000 (16:43 +0000)]
2010-12-17 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[Qt] Default image interpolation should reset the render hint
https://bugs.webkit.org/show_bug.cgi?id=51233
Save initial SmoothPixmapTransform render hint so that it can be used
with default image interpolation quality to reset back the render hints.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::setImageInterpolationQuality):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 17 Dec 2010 16:26:55 +0000 (16:26 +0000)]
2010-12-17 Ariya Hidayat <ariya@sencha.com>
Reviewed by Antonio Gomes.
[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208
Adjust the test since SmoothPixmapTransform is set by default.
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::renderHints):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Dec 2010 16:16:08 +0000 (16:16 +0000)]
2010-12-05 Antonio Gomes <agomes@rim.com>
Reviewed by Ariya Hidayat.
[Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536
WebKit/qt:
Caret browsing can consume editing commands even when the start
of current selection is not a editable content. r69582 missed this
case because caret browsing feature testing is very poor today.
This commit reintroduces part of the removed code in r69582 but
guarded by a isCaretBrowsingEnabled() check. No regression found.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
LayoutTests:
/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
is one of the few tests actually tests the caret browsing feature.
Patch makes the test not Gtk+ specific, and Qt now passes on it.
* editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx t.
* editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
* fast/events/multiline-link-arrow-navigation.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Dec 2010 16:15:41 +0000 (16:15 +0000)]
2010-12-16 Antonio Gomes <agomes@rim.com>
Reviewed by Martin Robinson.
Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
https://bugs.webkit.org/show_bug.cgi?id=51163
WebKitTools:
Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
GTK+'s DRT should also reset to UNIX after each test execution.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests:
Removed platform specific expected result files for gtk and windows
for editing/selection/extend-selection-home-end.html, since they all match
the cross platform result file.
Note: chromium-win and mac still have their own expected file each.
* platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
* platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 15:54:44 +0000 (15:54 +0000)]
2010-12-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74201.
http://trac.webkit.org/changeset/74201
https://bugs.webkit.org/show_bug.cgi?id=51248
It broke ~6000 layout tests (Requested by Ossy_ on #webkit).
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::setGeometry):
(QGraphicsWKView::itemChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 17 Dec 2010 15:11:51 +0000 (15:11 +0000)]
2010-12-17 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Remove custom expectations for fast/js/regexp-ranges-and-escaped-hyphens.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Fri, 17 Dec 2010 15:10:21 +0000 (15:10 +0000)]
2010-12-17 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193
Update layout tests to check that having Date objects as keys work.
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2010-12-17 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
Use the new IDBKey factory functions, and support Date objects.
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
Create Date objects from DateType keys.
* storage/IDBKey.cpp:
(WebCore::IDBKey::fromQuery):
(WebCore::IDBKey::isEqual):
(WebCore::IDBKey::whereSyntax):
(WebCore::IDBKey::lowerCursorWhereFragment):
(WebCore::IDBKey::upperCursorWhereFragment):
(WebCore::IDBKey::bind):
(WebCore::IDBKey::bindWithNulls):
Update all SQL related functions to handle Date keys.
* storage/IDBKey.h:
(WebCore::IDBKey::createNull):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
Rename the create factories; since both number and date is just a
double, function overloading can't be used to discriminate between
the factories.
(WebCore::IDBKey::date):
Add getter for the date value.
2010-12-17 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193
Update to match the underlying WebCore IDBKey class:
add the DateType, add create() functions for each type,
deprecate the public constructors (will be removed once
Chromium side is updated).
* public/WebIDBKey.h:
(WebKit::WebIDBKey::WebIDBKey):
* src/AssertMatchingEnums.cpp:
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::createString):
(WebKit::WebIDBKey::createDate):
(WebKit::WebIDBKey::createNumber):
(WebKit::WebIDBKey::assignNull):
(WebKit::WebIDBKey::assignString):
(WebKit::WebIDBKey::assignDate):
(WebKit::WebIDBKey::assignNumber):
(WebKit::WebIDBKey::date):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 17 Dec 2010 14:55:18 +0000 (14:55 +0000)]
2010-12-17 Sergio Villar Senin <svillar@igalia.com>
Unreviewed, tests were skipped due to a bug in libsoup
https://bugzilla.gnome.org/show_bug.cgi?id=631679. Now that it was
fixed we can safely unskip them again.
[GTK] Failing http/tests/xmlhttprequest tests
https://bugs.webkit.org/show_bug.cgi?id=30582
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 17 Dec 2010 14:47:45 +0000 (14:47 +0000)]
2010-12-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add scripts parsed after resource load to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51243
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addScript):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 17 Dec 2010 14:39:13 +0000 (14:39 +0000)]
2010-12-17 Anton Muhin <antonm@chromium.org>
Reviewed by Yury Semikhatsky.
[v8] The last portion of CSS GC work: fixing fast/dom/StyleSheet/gc-stylesheet-wrapper.html
https://bugs.webkit.org/show_bug.cgi?id=51121
Properly group style elements of HTML links, style elements and processing instructions.
* bindings/v8/V8GCController.cpp:
(WebCore::NodeGrouperVisitor::visitDOMWrapper):
(WebCore::NodeGrouperVisitor::addDOMObjectToGroup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 17 Dec 2010 14:37:02 +0000 (14:37 +0000)]
2010-12-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
https://bugs.webkit.org/show_bug.cgi?id=51101
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 17 Dec 2010 14:33:42 +0000 (14:33 +0000)]
2010-12-17 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/test_expectations.txt: Collect and correct failures about vertical writing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Fri, 17 Dec 2010 14:15:57 +0000 (14:15 +0000)]
2010-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Laszlo Gombos.
The inspector does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=51246
Fix the build, m_extraHeaders does not depend on JAVASCRIPT_DEBUGGER.
* inspector/InspectorController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 17 Dec 2010 13:52:53 +0000 (13:52 +0000)]
2010-12-17 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: clear extra/override headers when front-end is closed
https://bugs.webkit.org/show_bug.cgi?id=51244
* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::willSendRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 17 Dec 2010 13:15:23 +0000 (13:15 +0000)]
2010-12-17 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style should understand WTF #include guards
https://bugs.webkit.org/show_bug.cgi?id=44911
* Scripts/webkitpy/style/checkers/cpp.py:
(get_header_guard_cpp_variable): modify to suggest the WTF style
of header guard when appropriate.
(check_for_header_guard): handle multiple return values from
get_header_guard_cpp_variable
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_build_header_guard): Added tests for the WTF
header style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 17 Dec 2010 13:07:20 +0000 (13:07 +0000)]
Unreviewed.
[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245
* platform/qt/Skipped: http/tests/misc/webtiming-ssl.php added until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 17 Dec 2010 12:52:18 +0000 (12:52 +0000)]
2010-12-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=50893
Now Mac shortcuts are:
- Cmd F/G = find / next
- Cmd L = go to line
Win/Linux:
- Ctrl+G = go to line
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 17 Dec 2010 12:50:38 +0000 (12:50 +0000)]
2010-12-17 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 17 Dec 2010 12:46:10 +0000 (12:46 +0000)]
2010-12-16 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
Wrong check in ResourceHandleSoup in error cases
https://bugs.webkit.org/show_bug.cgi?id=51171
Calling didReceiveData with no data causes a crash in debug
builds. Checking for soupMsg->response_body->data is not correct as libsoup
always creates a buffer for that. Instead we should check for
soupMsg->response_body->length
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 17 Dec 2010 12:27:58 +0000 (12:27 +0000)]
2010-12-17 Sergio Villar Senin <svillar@igalia.com>
Unreviewed, skipping a failing test in the bots.
[GTK] fast/dom/global-constructors.html failing on bots
https://bugs.webkit.org/show_bug.cgi?id=51242
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 17 Dec 2010 12:19:02 +0000 (12:19 +0000)]
2010-12-17 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix typo in Chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 17 Dec 2010 12:05:22 +0000 (12:05 +0000)]
2010-12-17 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Avoid unnecessary calls to GraphicsContextPlatformPrivate::p()
https://bugs.webkit.org/show_bug.cgi?id=49954
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginTransparencyLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 17 Dec 2010 11:13:13 +0000 (11:13 +0000)]
2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Compile warning introduced in r74129
https://bugs.webkit.org/show_bug.cgi?id=51181
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::gtkContainer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 17 Dec 2010 11:05:27 +0000 (11:05 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 10:51:35 +0000 (10:51 +0000)]
2010-12-17 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPage sends out a RequestSoftwareInputPanel event
incorrectly in particular case
https://bugs.webkit.org/show_bug.cgi?id=50419
Add HitTestResult check before firing RequestSoftwareInputPanel event.
* Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
* Api/qwebpage_p.h:
* tests/qwebpage/tst_qwebpage.cpp:
(clickOnPage):
(tst_QWebPage::inputMethods):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 10:37:55 +0000 (10:37 +0000)]
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Add sslHandshakeStart to interface
https://bugs.webkit.org/show_bug.cgi?id=50400
* fast/dom/Window/window-properties-performance-expected.txt: Added sslHandshakeStart.
* fast/dom/script-tests/webtiming.js: Ditto.
(checkTimingBeforeLoad):
(checkTimingWhileDeferred):
(checkWebTimingOnDOMContentLoaded):
(checkWebTimingWhileAsync):
(checkWebTimingOnLoad):
(checkWebTimingAfterLoad):
* fast/dom/webtiming-document-open-expected.txt: Ditto.
* fast/dom/webtiming-expected.txt: Ditto.
* fast/dom/webtiming-navigate-within-document-expected.txt: Ditto.
* http/tests/misc/resources/webtiming-ssl.html: Added.
* http/tests/misc/webtiming-ssl-expected.txt: Added.
* http/tests/misc/webtiming-ssl.php: Added.
* platform/gtk/Skipped: WebTiming disabled here.
* platform/mac/Skipped: Ditto.
* platform/win/Skipped: Ditto.
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Add sslHandshakeStart to interface
https://bugs.webkit.org/show_bug.cgi?id=50400
Test: http/tests/misc/webtiming-ssl.php
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::connectStart): Update comment.
(WebCore::PerformanceTiming::connectEnd): Remove SSL time.
(WebCore::PerformanceTiming::sslHandshakeStart): Added.
* page/PerformanceTiming.h: Added sslHandshakeStart.
* page/PerformanceTiming.idl: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 10:19:46 +0000 (10:19 +0000)]
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200
* fast/dom/Window/window-properties-performance-expected.txt: Added TYPE_ to navigation types and added TYPE_RESERVED.
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200
* page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::type): Added TYPE_ to navigation types.
* page/PerformanceNavigation.h: Ditto and added TYPE_RESERVED.
* page/PerformanceNavigation.idl: Ditto.
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200
* src/WebPerformance.cpp:
(WebKit::WebPerformance::navigationType): Added TYPE_ to navigation types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Fri, 17 Dec 2010 10:05:59 +0000 (10:05 +0000)]
Fix build with Geolocation disabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 17 Dec 2010 09:48:06 +0000 (09:48 +0000)]
2010-12-17 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test fix: removed real user agent from test expectations.
* http/tests/inspector/extensions-headers-expected.txt:
* http/tests/inspector/extensions-headers.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 17 Dec 2010 09:17:52 +0000 (09:17 +0000)]
2010-12-17 Patrick Gansterer <paroga@webkit.org>
Unreviewed. WinCE build fix.
* platform/graphics/GraphicsContext.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 17 Dec 2010 09:13:27 +0000 (09:13 +0000)]
2010-12-17 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Clean up extra headers set in test to avoid side effects on other tests.
* http/tests/inspector/extensions-headers-expected.txt:
* http/tests/inspector/extensions-headers.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 17 Dec 2010 08:29:52 +0000 (08:29 +0000)]
2010-12-17 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove unnecessary dependencies from InspectorBackendStub.
InspectorBackendStub is a transport-only thing but it has dependencies with
Callback.js and WebInspector namespace. Callback can be integrated into
InspectorBackendStub because it is the only client.
Without these dependencies InspectorBackendStub can be used as an API
wrapper for Inspector Protocol.
https://bugs.webkit.org/show_bug.cgi?id=51184
* WebCore.gypi:
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/Callback.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 17 Dec 2010 08:23:56 +0000 (08:23 +0000)]
2010-12-17 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r74229.
http://trac.webkit.org/changeset/74229
https://bugs.webkit.org/show_bug.cgi?id=50536
Broken on Snow Leopard and possibly other platforms
* platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt.
* platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html.
* platform/mac/Skipped:
* platform/win/Skipped:
2010-12-17 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r74229.
http://trac.webkit.org/changeset/74229
https://bugs.webkit.org/show_bug.cgi?id=50536
Broken on Snow Leopard and possibly other platforms
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 17 Dec 2010 08:22:16 +0000 (08:22 +0000)]
2010-12-15 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
https://bugs.webkit.org/show_bug.cgi?id=50493
Test: http/tests/inspector/extensions-headers.html
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest): Apply extra headers.
(WebCore::InspectorController::setExtraHeaders):
* inspector/InspectorController.h:
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
(WebInspector.injectedExtensionAPI.Resources.prototype.addRequestHeaders):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
2010-12-15 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
Moved extensions test frameworks under http/tests/inspector, so HTTP tests may reuse it.
https://bugs.webkit.org/show_bug.cgi?id=50493
* http/tests/inspector/extensions-headers-expected.txt: Added.
* http/tests/inspector/extensions-headers.html: Added.
* http/tests/inspector/extensions-test.js: Renamed from LayoutTests/inspector/extensions-test.js.
(log):
(extensionFunctions):
(initialize_ExtensionsTest.InspectorTest.dispatchOnMessage):
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
(initialize_ExtensionsTest.extensionOutput):
(initialize_ExtensionsTest.dumpSidebarContent):
(initialize_ExtensionsTest.reloadPage):
(test):
* http/tests/inspector/resources/echo-headers.php: Added.
* http/tests/inspector/resources/extension-main.html: Renamed from LayoutTests/inspector/resources/extension-main.html.
* http/tests/inspector/resources/extension-main.js: Renamed from LayoutTests/inspector/resources/extension-main.js.
(fetchTests.callback):
(fetchTests):
(runTests):
(onTestsDone):
(dispatchOnFrontend.callbackWrapper):
(dispatchOnFrontend):
(callbackAndNextTest.callbackWrapper):
(callbackAndNextTest):
* http/tests/inspector/resources/extension-panel.html: Renamed from LayoutTests/inspector/resources/extension-panel.html.
* http/tests/inspector/resources/extension-sidebar.html: Renamed from LayoutTests/inspector/resources/extension-sidebar.html.
* inspector/extensions-api-expected.txt:
* inspector/extensions-api.html:
* inspector/extensions-audits-api.html:
* inspector/extensions-audits.html:
* inspector/extensions-eval.html:
* inspector/extensions-events.html:
* inspector/extensions-resources-expected.txt:
* inspector/extensions-resources.html:
* inspector/extensions.html:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 17 Dec 2010 05:46:05 +0000 (05:46 +0000)]
Unreviewed, test expectation update.
Update Chromium-Linux results changed by r74232.
https://bugs.webkit.org/show_bug.cgi?id=50365
* platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum:
* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png:
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 17 Dec 2010 05:19:32 +0000 (05:19 +0000)]
2010-12-16 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Kent Tamura.
Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=50365
No new tests. But this makes Chromimium Linux show
fast/blockflow/japanese-*-text.html and other vertical
writing text correctly as on WebKit and Chromimum for Mac.
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::hash):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::orientation):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::substituteWithVerticalGlyphs):
(WebCore::GlyphPage::fill):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 17 Dec 2010 05:06:39 +0000 (05:06 +0000)]
2010-12-16 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/test_expectations.txt: Remove SLOW for fail-on-update-2.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 03:51:59 +0000 (03:51 +0000)]
2010-12-16 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ojan Vafai.
Update BUG comment in test expectations files
https://bugs.webkit.org/show_bug.cgi?id=51216
Change the BUG[0-9]+ description to BUG(CR|WK|V8_)[0-9]+ where necessary.
* platform/chromium/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 17 Dec 2010 03:36:48 +0000 (03:36 +0000)]
2010-12-05 Antonio Gomes <agomes@rim.com>
Reviewed by Ariya Hidayat.
[Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536
WebKit/qt:
Caret browsing can consume editing commands even when the start
of current selection is not a editable content. r69582 missed this
case because caret browsing feature testing is very poor today.
This commit reintroduces part of the removed code in r69582 but
guarded by a isCaretBrowsingEnabled() check. No regression found.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
LayoutTests:
/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
is one of the few tests actually tests the caret browsing feature.
Patch makes the test not Gtk+ specific, and Qt now passes on it.
* editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx t.
* editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
* fast/events/multiline-link-arrow-navigation.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Dec 2010 03:28:51 +0000 (03:28 +0000)]
2010-12-16 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia.com>
Reviewed by Eric Carlson.
Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133
Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
to launch fullscreen video player for playing the html5 video. The
idea is that a browser vendor can specify this behavior through the
platform plugin or something else by using this interface.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::exitFullscreen):
* page/Chrome.cpp:
(WebCore::Chrome::requiresFullscreenForVideoPlayback):
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::requiresFullscreenForVideoPlayback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log