mjs [Mon, 9 Oct 2006 09:09:14 +0000 (09:09 +0000)]
Reviewed by Oliver.
- remove dependency on WebNSURLRequestExtras.h
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 08:59:55 +0000 (08:59 +0000)]
Reviewed by Oliver.
- removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency
* Loader/WebFrameLoader.m:
(-[WebFrameLoader setState:]):
(-[WebFrameLoader clientRedirectCancelledOrFinished:]):
(-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader checkLoadCompleteForThisFrame]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 08:44:58 +0000 (08:44 +0000)]
Reviewed by Oliver.
- remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)
* Loader/WebDocumentLoader.h:
* Loader/WebDocumentLoader.m:
(-[WebDocumentLoader dealloc]):
(-[WebDocumentLoader initialRequest]):
(-[WebDocumentLoader URL]):
(-[WebDocumentLoader unreachableURL]):
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader setState:]):
(-[WebFrameLoader startLoading]):
(-[WebFrameLoader startProvisionalLoad:]):
(-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader opened]):
(-[WebFrameLoader commitProvisionalLoad:]):
(-[WebFrameLoader initialRequest]):
(-[WebFrameLoader _finishedLoading]):
(-[WebFrameLoader _notifyIconChanged:]):
(-[WebFrameLoader _URL]):
(-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
(-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
(-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
(-[WebFrameLoader frameLoadCompleted]):
(-[WebFrameLoader transitionToCommitted:]):
(-[WebFrameLoader checkLoadCompleteForThisFrame]):
(-[WebFrameLoader safeLoadURL:]):
* Loader/WebFrameLoaderClient.h:
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge originalRequestURL]):
* WebView/WebDataSource.m:
(-[WebDataSource _URL]):
(-[WebDataSource dealloc]):
(-[WebDataSource initialRequest]):
(-[WebDataSource unreachableURL]):
* WebView/WebFrame.m:
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _prepareForDataSourceReplacement]):
(-[WebFrame provisionalDataSource]):
(-[WebFrame dataSource]):
(-[WebFrame _makeDocumentView]):
(-[WebFrame _updateHistoryForReload]):
(-[WebFrame _updateHistoryForStandardLoad]):
(-[WebFrame _updateHistoryForInternalLoad]):
(-[WebFrame _forceLayoutForNonHTML]):
(-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
(-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
(-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]):
(-[WebFrame _makeRepresentationForDocumentLoader:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 9 Oct 2006 07:40:41 +0000 (07:40 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in filter classes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 9 Oct 2006 07:36:45 +0000 (07:36 +0000)]
Reviewed by olliej.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in SVGPath* classes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 07:32:58 +0000 (07:32 +0000)]
Reviewed by Darin.
- removed need for WebFrameLoader to now about WebDocumentLoaderMac
* Loader/WebFrameLoader.m:
(-[WebFrameLoader loadDataSource:withLoadType:formState:]):
* WebView/WebDocumentLoaderMac.h:
* WebView/WebDocumentLoaderMac.m:
(-[WebDocumentLoaderMac setFrameLoader:]):
(-[WebDocumentLoaderMac detachFromFrameLoader]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 9 Oct 2006 07:27:36 +0000 (07:27 +0000)]
Reviewed by aroben.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg shape classes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 07:23:47 +0000 (07:23 +0000)]
Reviewed by Maciej.
- passed calls that require WebScriptDebugServer across the client interface
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _finishedLoading]):
(-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 07:03:11 +0000 (07:03 +0000)]
Reviewed by Maciej.
- passed calls that require WebHTMLView or WebFrameView calls across
the client interface
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(isCaseInsensitiveEqual):
(isBackForwardLoadType):
(-[WebFrameLoader opened]):
(-[WebFrameLoader cancelledErrorWithRequest:]):
(-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader transitionToCommitted:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _forceLayout]):
(-[WebFrame _setDocumentViewFromPageCache:]):
(-[WebFrame _setCopiesOnScroll]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 06:46:15 +0000 (06:46 +0000)]
Reviewed by Darin.
- pass remaining delegate methods across client interface
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
(-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
(-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
(-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
(-[WebFrameLoader didFirstLayout]):
(-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _dispatchDidFirstLayoutInFrame]):
(-[WebFrame _dispatchCreateWebViewWithRequest:]):
(-[WebFrame _dispatchShow]):
(-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]):
(-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
(-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]):
(-[WebFrame _dispatchUnableToImplementPolicyWithError:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 06:30:55 +0000 (06:30 +0000)]
WebCore:
Reviewed by Maciej.
- added a bit more WebCoreSystemInterface
wkGetNSURLResponseCalculatedExpiration
wkGetNSURLResponseLastModifiedDate
wkGetNSURLResponseMustRevalidate
* WebCore.exp: Added the new symbols.
* platform/mac/WebCoreSystemInterface.h: Ditto.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
- quiet down the code generation script
* bindings/scripts/CodeGenerator.pm:
WebKit:
Reviewed by Maciej.
- use WebCoreSystemInterface instead of WebSystemInterface in Loader directory
* Loader/WebFrameLoader.m: Update includes.
(-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK.
(-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
Added the three new symbols, and resorted the list.
* Loader/WebDataProtocol.m:
* Loader/WebLoader.m:
* Loader/WebMainResourceLoader.h:
* Loader/WebMainResourceLoader.m:
* Loader/WebNetscapePlugInStreamLoader.h:
* Loader/WebNetscapePlugInStreamLoader.m:
* Loader/WebSubresourceLoader.h:
* Loader/WebSubresourceLoader.m:
Changed import statements to consistently use the "" format.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 06:19:50 +0000 (06:19 +0000)]
Not reviewed.
- fix accidental build break due to editing while committing
* Loader/WebFrameLoader.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 06:17:56 +0000 (06:17 +0000)]
Reviewed by Darin.
- move all WebFrameLoadDelegate methods across client interface
* Loader/WebFrameLoader.m:
(-[WebFrameLoader clientRedirectCancelledOrFinished:]):
(-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
(-[WebFrameLoader closeOldDataSources]):
(-[WebFrameLoader _notifyIconChanged:]):
(-[WebFrameLoader prepareForLoadStart]):
(-[WebFrameLoader didChangeTitleForDocument:]):
(-[WebFrameLoader transitionToCommitted:]):
(-[WebFrameLoader checkLoadCompleteForThisFrame]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _dispatchDidCancelClientRedirectForFrame]):
(-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]):
(-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]):
(-[WebFrame _dispatchWillCloseFrame]):
(-[WebFrame _dispatchDidReceiveIcon:]):
(-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
(-[WebFrame _dispatchDidReceiveTitle:]):
(-[WebFrame _dispatchDidCommitLoadForFrame]):
(-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
(-[WebFrame _dispatchDidFailLoadWithError:]):
(-[WebFrame _dispatchDidFinishLoadForFrame]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 05:44:32 +0000 (05:44 +0000)]
Reviewed by Maciej.
- removed some of the WebKit dependencies in WebFrameLoader
* Loader/WebFrameLoader.m:
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader didChangeTitleForDocument:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _setTitle:forURL:]):
(-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
* WebView/WebFrameInternal.h:
- some other tweaks
* Misc/WebNSURLRequestExtras.m:
(-[NSMutableURLRequest _web_setHTTPReferrer:]):
(-[NSMutableURLRequest _web_setHTTPUserAgent:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 05:42:55 +0000 (05:42 +0000)]
Reviewed by Darin.
- pass all WebResourceLoadDelegate methods across client, removing need to include related headers
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
(-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didReceiveResponse:forResource:]):
(-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
(-[WebFrameLoader _didFinishLoadingForResource:]):
(-[WebFrameLoader _didFailLoadingWithError:forResource:]):
(-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
(-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
(-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
(-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
(-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
(-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
(-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
(-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
(-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
(-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
(-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 05:23:24 +0000 (05:23 +0000)]
Reviewed by Darin.
- started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch
* Loader/WebFrameLoader.m:
(-[WebFrameLoader startLoading]):
(-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
* Loader/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge handledOnloadEvents]):
* WebView/WebFrame.m:
(dataSource):
(-[WebFrame _dataSourceForDocumentLoader:]):
(-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
(-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
(-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 04:30:30 +0000 (04:30 +0000)]
Reviewed by Maciej.
- moved more methods to WebFrameLoader from WebFrame
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader defersCallbacksChanged]):
(-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
(-[WebFrameLoader setState:]):
(-[WebFrameLoader clearProvisionalLoad]):
(-[WebFrameLoader markLoadComplete]):
(-[WebFrameLoader commitProvisionalLoad]):
(-[WebFrameLoader stopLoading]):
(-[WebFrameLoader startProvisionalLoad:]):
(-[WebFrameLoader setupForReplace]):
(-[WebFrameLoader _identifierForInitialRequest:]):
(-[WebFrameLoader _finishedLoadingResource]):
(-[WebFrameLoader _receivedError:]):
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
(-[WebFrameLoader opened]):
(-[WebFrameLoader commitProvisionalLoad:]):
(-[WebFrameLoader _finishedLoading]):
(-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
(-[WebFrameLoader subframeIsLoading]):
(-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
(-[WebFrameLoader continueAfterNewWindowPolicy:]):
(-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
(-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
(-[WebFrameLoader loadRequest:inFrameNamed:]):
(-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrameLoader detachChildren]):
(-[WebFrameLoader detachFromParent]):
(-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
(-[WebFrameLoader safeLoadURL:]):
(-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
(-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
(-[WebFrameLoader checkLoadComplete]):
* Loader/WebFrameLoaderClient.h:
* Loader/WebSubresourceLoader.m:
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge close]):
(-[WebFrameBridge tokenizerProcessedData]):
(-[WebFrameBridge frameDetached]):
* WebView/WebDataSourceInternal.h:
* WebView/WebFrame.m:
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _prepareForDataSourceReplacement]):
(-[WebFrame _detachedFromParent1]):
(-[WebFrame _detachedFromParent2]):
(-[WebFrame _detachedFromParent3]):
(-[WebFrame _detachedFromParent4]):
(-[WebFrame _updateHistoryAfterClientRedirect]):
(-[WebFrame _loadedFromPageCache]):
* WebView/WebFrameInternal.h:
* WebView/WebPDFView.m:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
* WebView/WebView.m:
(-[WebView _close]):
(-[WebView setDefersCallbacks:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 03:56:09 +0000 (03:56 +0000)]
WebCore:
Reviewed by Darin.
- more code laundering - add wkSupportsMultipartXMixedReplace
* WebCore.exp:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
WebKit:
Reviewed by Darin.
- avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace
* Loader/WebDocumentLoader.m:
(-[WebDocumentLoader initWithRequest:]):
* Loader/WebMainResourceLoader.m:
* Loader/WebSubresourceLoader.m:
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
* WebView/WebDataSource.m:
(-[WebDataSource _initWithDocumentLoader:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 9 Oct 2006 03:23:23 +0000 (03:23 +0000)]
Release build fix: silence warning about unused variable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 02:43:55 +0000 (02:43 +0000)]
- build fix (also a fix for a crasher I forgot to commit before)
* Loader/WebFrameLoader.m: Added some missing includes.
(-[WebFrameLoader checkLoadCompleteForThisFrame]):
Added a needed retain/release.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 02:35:29 +0000 (02:35 +0000)]
Reviewed by Anders.
- quick fix to loader problem causing layout test failures
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge
that we retain/release.
(-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
Same here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 9 Oct 2006 02:09:52 +0000 (02:09 +0000)]
Reviewed by Adam.
- removed a few includes from WebFrameLoader, fixed up as appropriate
- segregated header includes into ones that need to go away to move the code and ones that don't
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _privateBrowsingEnabled]):
(-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[WebFrame _privateBrowsingEnabled]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Oct 2006 01:48:10 +0000 (01:48 +0000)]
Reviewed by Maciej.
- moved a few methods from WebFrame to WebFrameLoader
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _setState:]):
(-[WebFrameLoader stopLoadingSubframes]):
(-[WebFrameLoader _receivedMainResourceError:complete:]):
(-[WebFrameLoader closeOldDataSources]):
(-[WebFrameLoader commitProvisionalLoad:]):
(-[WebFrameLoader _finishedLoading]):
(isBackForwardLoadType):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader didFirstLayout]):
(-[WebFrameLoader frameLoadCompleted]):
(-[WebFrameLoader transitionToCommitted:]):
(-[WebFrameLoader checkLoadCompleteForThisFrame]):
(-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
(-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
(-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
(-[WebFrameLoader loadRequest:inFrameNamed:]):
(-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
* Loader/WebFrameLoaderClient.h:
* Plugins/WebPluginController.m:
(-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
(-[WebFrameBridge dealloc]):
(-[WebFrameBridge frameLoader]):
(-[WebFrameBridge setTitle:]):
(-[WebFrameBridge receivedData:textEncodingName:]):
(-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
(-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
(-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
(-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
(-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameBridge reportClientRedirectCancelled:]):
(-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
(-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrameBridge didFirstLayout]):
(-[WebFrameBridge notifyIconChanged:]):
(-[WebFrameBridge originalRequestURL]):
(-[WebFrameBridge isLoadTypeReload]):
* WebView/WebFrame.m:
(-[WebFrame _opened]):
(-[WebFrame _checkLoadComplete]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _currentBackForwardListItemToResetTo]):
(-[WebFrame _updateBackground]):
(-[WebFrame _frameLoader]):
(-[WebFrame _frameLoadCompleted]):
(-[WebFrame _makeDocumentView]):
(-[WebFrame _updateHistoryForCommit]):
(-[WebFrame _updateHistoryForReload]):
(-[WebFrame _updateHistoryForStandardLoad]):
(-[WebFrame _updateHistoryForBackForwardNavigation]):
(-[WebFrame _updateHistoryForInternalLoad]):
(-[WebFrame _tokenForLoadErrorReset]):
(-[WebFrame _resetAfterLoadError:]):
(-[WebFrame _doNotResetAfterLoadError:]):
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 9 Oct 2006 00:44:47 +0000 (00:44 +0000)]
2006-10-09 Mark Rowe <bdash@webkit.org>
Rubber-stamped by Darin.
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that
is triggering an assertion failure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 9 Oct 2006 00:33:47 +0000 (00:33 +0000)]
2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Darin and Oliver.
Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
* platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
(WebCore::GraphicsContext::drawConvexPolygon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 8 Oct 2006 23:52:05 +0000 (23:52 +0000)]
Reviewed by Darin.
- remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into
two coincidentally matching enums)
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader commitProvisionalLoad:]):
(isBackForwardLoadType):
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader isReplacing]):
(-[WebFrameLoader setReplacing]):
(-[WebFrameLoader loadType]):
(-[WebFrameLoader setLoadType:]):
(-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader loadDataSource:withLoadType:formState:]):
(-[WebFrameLoader didFirstLayout]):
* WebCoreSupport/WebFrameBridge.m:
* WebView/WebFrame.m:
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _provisionalLoadStarted]):
(-[WebFrame _opened]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
(-[WebFrame _goToItem:withLoadType:]):
(-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
(-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrame _currentBackForwardListItemToResetTo]):
(-[WebFrame _itemForRestoringDocState]):
(-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
(-[WebFrame _loadType]):
(-[WebFrame loadRequest:]):
* WebView/WebFrameInternal.h:
* WebView/WebView.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 8 Oct 2006 23:33:50 +0000 (23:33 +0000)]
2006-10-08 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
* page/Frame.cpp:
(WebCore::Frame::submitForm):
No need to use latin1() here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 8 Oct 2006 22:47:03 +0000 (22:47 +0000)]
Reviewed by Maciej.
- move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge
* Loader/WebFrameLoader.m:
(-[WebFrameLoader stopLoadingSubframes]):
(-[WebFrameLoader closeOldDataSources]):
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
(-[WebFrameBridge dealloc]):
(-[WebFrameBridge loader]):
(-[WebFrameBridge setTitle:]):
(-[WebFrameBridge receivedData:textEncodingName:]):
(-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
(-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
(-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameBridge reportClientRedirectCancelled:]):
(-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
(-[WebFrameBridge didFirstLayout]):
(-[WebFrameBridge imageTitleForFilename:size:]):
(-[WebFrameBridge notifyIconChanged:]):
(-[WebFrameBridge originalRequestURL]):
(-[WebFrameBridge isLoadTypeReload]):
* WebView/WebFrame.m:
(-[NSView setWebFrame::]):
(-[WebFramePrivate dealloc]):
(-[WebFramePrivate setWebFrameView:]):
(-[WebFramePrivate setProvisionalItem:]):
(-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
(-[WebFrame _createItem:]):
(-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
(-[WebFrame _detachFromParent]):
(-[WebFrame _makeDocumentView]):
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _provisionalLoadStarted]):
(-[WebFrame _opened]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
(-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrame _setTitle:]):
(-[WebFrame _defersCallbacksChanged]):
(-[WebFrame _currentBackForwardListItemToResetTo]):
(-[WebFrame _itemForSavingDocState]):
(-[WebFrame _itemForRestoringDocState]):
(-[WebFrame _saveDocumentAndScrollState]):
(-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
(-[WebFrame _loadRequest:inFrameNamed:]):
(-[WebFrame _initWithWebFrameView:webView:bridge:]):
(-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
(-[WebFrame _frameLoader]):
(-[WebFrame _prepareForDataSourceReplacement]):
(-[WebFrame _restoreScrollPositionAndViewState]):
(-[WebFrame _firstLayoutDone]):
(-[WebFrame _loadType]):
(-[WebFrame frameView]):
(-[WebFrame provisionalDataSource]):
(-[WebFrame dataSource]):
(-[WebFrame loadRequest:]):
(-[WebFrame loadArchive:]):
(-[WebFrame stopLoading]):
(-[WebFrame reload]):
(-[WebFrame _resetBackForwardList]):
(-[WebFrame _invalidateCurrentItemPageCache]):
(-[WebFrame _provisionalItemIsTarget]):
(-[WebFrame _loadProvisionalItemFromPageCache]):
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 8 Oct 2006 22:45:34 +0000 (22:45 +0000)]
2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Darin.
Kill warnings when generating IDL files on Qt/Linux, as the
SOURCE_ROOT environment variable is not defined (and not needed) for us.
* bindings/scripts/CodeGenerator.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 8 Oct 2006 22:24:18 +0000 (22:24 +0000)]
Reviewed by Darin.
- split didNotOpenURL: into general and page-cache-specific parts
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge didNotOpenURL:]):
(-[WebCoreFrameBridge invalidatePageCache:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 8 Oct 2006 22:10:24 +0000 (22:10 +0000)]
Reviewed by Darin.
- move remaining movable data fields from WebFrameLoader to WebFrame
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState commitIfReady]):
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader provisionalLoadStarted]):
(-[WebFrameLoader _setState:]):
(-[WebFrameLoader stopLoadingSubframes]):
(-[WebFrameLoader stopLoading]):
(-[WebFrameLoader startLoading]):
(-[WebFrameLoader _receivedMainResourceError:complete:]):
(-[WebFrameLoader clientRedirectCancelledOrFinished:]):
(-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
(-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
(-[WebFrameLoader closeOldDataSources]):
(-[WebFrameLoader commitProvisionalLoad:]):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader isQuickRedirectComing]):
* Loader/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge frameLoader]):
(-[WebFrameBridge setTitle:]):
(-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
(-[WebFrameBridge reportClientRedirectCancelled:]):
(-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
* WebView/WebDataSource.m:
(-[WebDataSource _loadFromPageCache:]):
* WebView/WebFrame.m:
(-[NSView setWebFrame::]):
(-[WebFrame _addHistoryItemForFragmentScroll]):
(-[WebFrame _didFinishLoad]):
(-[WebFrame _provisionalLoadStarted]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _frameLoadCompleted]):
(-[WebFrame stopLoading]):
(-[WebFrame _invalidateCurrentItemPageCache]):
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 8 Oct 2006 21:40:01 +0000 (21:40 +0000)]
2006-10-08 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
* loader/loader.cpp:
Remove DeprecatedStringList.h include.
* page/Frame.cpp:
(WebCore::Frame::submitForm):
Don't remove "attach" from mailto URLs, we don't do it anywhere else.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 8 Oct 2006 21:28:53 +0000 (21:28 +0000)]
Rubber stamped by Maciej.
- changed "document load state" to "document loader"
* Loader/WebDocumentLoadState.h: Removed.
* Loader/WebDocumentLoadState.m: Removed.
* Loader/WebDocumentLoader.h: Added.
* Loader/WebDocumentLoader.m: Added.
(-[WebDocumentLoader setMainDocumentError:]):
(-[WebDocumentLoader mainReceivedError:complete:]):
(-[WebDocumentLoader finishedLoading]):
(-[WebDocumentLoader commitLoadWithData:]):
(-[WebDocumentLoader setupForReplaceByMIMEType:]):
(-[WebDocumentLoader updateLoading]):
(-[WebDocumentLoader setTitle:]):
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader dealloc]):
(-[WebFrameLoader activeDocumentLoader]):
(-[WebFrameLoader activeDataSource]):
(-[WebFrameLoader addPlugInStreamLoader:]):
(-[WebFrameLoader removePlugInStreamLoader:]):
(-[WebFrameLoader addSubresourceLoader:]):
(-[WebFrameLoader removeSubresourceLoader:]):
(-[WebFrameLoader dataSource]):
(-[WebFrameLoader setDocumentLoader:]):
(-[WebFrameLoader documentLoader]):
(-[WebFrameLoader policyDataSource]):
(-[WebFrameLoader setPolicyDocumentLoader:]):
(-[WebFrameLoader clearDataSource]):
(-[WebFrameLoader provisionalDataSource]):
(-[WebFrameLoader provisionalDocumentLoader]):
(-[WebFrameLoader setProvisionalDocumentLoader:]):
(-[WebFrameLoader _clearProvisionalDataSource]):
(-[WebFrameLoader _setState:]):
(-[WebFrameLoader clearProvisionalLoad]):
(-[WebFrameLoader commitProvisionalLoad]):
(-[WebFrameLoader stopLoading]):
(-[WebFrameLoader startLoading]):
(-[WebFrameLoader startProvisionalLoad:]):
(-[WebFrameLoader setupForReplace]):
(-[WebFrameLoader _didReceiveResponse:forResource:]):
(-[WebFrameLoader _originalRequest]):
(-[WebFrameLoader _receivedMainResourceError:complete:]):
(-[WebFrameLoader _receivedData:]):
(-[WebFrameLoader _setRequest:]):
(-[WebFrameLoader _isStopping]):
(-[WebFrameLoader _setupForReplaceByMIMEType:]):
(-[WebFrameLoader _setResponse:]):
(-[WebFrameLoader _mainReceivedError:complete:]):
(-[WebFrameLoader _finishedLoading]):
(-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader finishedLoadingDocument:]):
(-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
(-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
(-[WebFrameLoader documentLoader:setMainDocumentError:]):
(-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
(-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
(-[WebFrameLoader willChangeTitleForDocument:]):
(-[WebFrameLoader didChangeTitleForDocument:]):
(-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader loadDataSource:withLoadType:formState:]):
* Plugins/WebPluginController.m:
(-[WebPluginController pluginView:receivedResponse:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge setTitle:]):
(-[WebFrameBridge receivedData:textEncodingName:]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _mainDocumentError]):
(-[WebDataSource _loadFromPageCache:]):
(-[WebDataSource _bridge]):
(-[WebDataSource _webView]):
(-[WebDataSource _URLForHistory]):
(-[WebDataSource _documentLoader]):
(-[WebDataSource _initWithDocumentLoader:]):
(-[WebDataSource initWithRequest:]):
(-[WebDataSource dealloc]):
(-[WebDataSource data]):
(-[WebDataSource webFrame]):
(-[WebDataSource initialRequest]):
(-[WebDataSource request]):
(-[WebDataSource response]):
(-[WebDataSource textEncodingName]):
(-[WebDataSource isLoading]):
(-[WebDataSource unreachableURL]):
(-[WebDataSource webArchive]):
* WebView/WebDataSourceInternal.h:
* WebView/WebDocumentLoadStateMac.h: Removed.
* WebView/WebDocumentLoadStateMac.m: Removed.
* WebView/WebDocumentLoaderMac.h: Added.
* WebView/WebDocumentLoaderMac.m: Added.
* WebView/WebFrame.m:
(-[WebFrame _createItem:]):
(-[WebFrame _receivedMainResourceError:]):
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _opened]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrame _addChild:]):
(-[WebFrame _provisionalLoadStarted]):
(-[WebFrame _dataSourceForDocumentLoader:]):
(-[WebFrame _createDocumentLoaderWithRequest:]):
* WebView/WebFrameInternal.h:
* WebView/WebHTMLRepresentation.m:
(-[WebHTMLRepresentation title]):
* WebView/WebView.m:
(-[WebView _mainFrameOverrideEncoding]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 8 Oct 2006 20:44:27 +0000 (20:44 +0000)]
More change log tweaking -- it's well worth it!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 8 Oct 2006 20:42:51 +0000 (20:42 +0000)]
Fixed grammar mistake in change log entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 8 Oct 2006 20:42:22 +0000 (20:42 +0000)]
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=11218
REGRESSION: Assertion failure in WebFrameLoader when going back from a file: or data: URL
Also added a helper function in WebFrameLoader so code that checks for back/forward load types
is easier to read.
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load
state to nil instead of the passed-in object.
(isBackForwardLoadType): Added.
(-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType.
(-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
Ditto.
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 8 Oct 2006 19:19:39 +0000 (19:19 +0000)]
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
Yet another round of Objective-C SVG DOM bindings auto-generation
- Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement,
DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement,
DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement,
DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement,
DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement,
DOMSVGZoomAndPan and DOMSVGZoomEvent.
- Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
using the new [ConvertFromString] property.
- Add forward declarations for NS* types to auto-generated classes.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMHTMLAppletElement.mm: Removed.
* bindings/objc/DOMHTMLEmbedElement.mm: Removed.
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMSVG.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* ksvg2/svg/SVGPatternElement.idl:
* ksvg2/svg/SVGPolygonElement.idl:
* ksvg2/svg/SVGPolylineElement.idl:
* ksvg2/svg/SVGRadialGradientElement.idl:
* ksvg2/svg/SVGRenderingIntent.idl:
* ksvg2/svg/SVGScriptElement.idl:
* ksvg2/svg/SVGSetElement.idl:
* ksvg2/svg/SVGStopElement.idl:
* ksvg2/svg/SVGSwitchElement.idl:
* ksvg2/svg/SVGSymbolElement.idl:
* ksvg2/svg/SVGTRefElement.idl:
* ksvg2/svg/SVGTSpanElement.idl:
* ksvg2/svg/SVGTextContentElement.idl:
* ksvg2/svg/SVGTextElement.idl:
* ksvg2/svg/SVGTextPositioningElement.idl:
* ksvg2/svg/SVGTitleElement.idl:
* ksvg2/svg/SVGUseElement.idl:
* ksvg2/svg/SVGViewElement.idl:
* ksvg2/svg/SVGZoomEvent.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 8 Oct 2006 13:53:55 +0000 (13:53 +0000)]
Reviewed by Maciej.
- fix two recently introduced leaks: one of an NSString, the other of a WebDataSource
* Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]):
Rearranged code to avoid storage leak in case of identical title.
* Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method
from the header.
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader
as needed if this load state is going away rather than moving on to become the provisional
load state.
(-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting.
(-[WebFrameLoader _loadRequest:archive:]): Added an assertion.
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion.
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion.
(-[WebFrameLoader reload]): Added an assertion.
(-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid
calling _documentLoadState over and over again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 8 Oct 2006 01:08:27 +0000 (01:08 +0000)]
2006-10-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.
* loader/loader.cpp:
(WebCore::Loader::servePendingRequests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 8 Oct 2006 00:44:23 +0000 (00:44 +0000)]
2006-10-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Convert a bunch of RefPtr<StringImpl> to String.
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::didTellBridgeAboutLoad):
(WebCore::FrameMac::haveToldBridgeAboutLoad):
* dom/BeforeUnloadEvent.cpp:
(WebCore::BeforeUnloadEvent::storeResult):
* dom/BeforeUnloadEvent.h:
(WebCore::BeforeUnloadEvent::result):
* dom/Document.cpp:
(WebCore::Document::createEntityReference):
* dom/Entity.cpp:
(WebCore::Entity::Entity):
(WebCore::Entity::nodeName):
(WebCore::Entity::toString):
* dom/Entity.h:
(WebCore::Entity::publicId):
(WebCore::Entity::systemId):
(WebCore::Entity::notationName):
* dom/EntityReference.cpp:
(WebCore::EntityReference::EntityReference):
(WebCore::EntityReference::nodeName):
(WebCore::EntityReference::cloneNode):
(WebCore::EntityReference::toString):
* dom/EntityReference.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::initKeyboardEvent):
* dom/KeyboardEvent.h:
(WebCore::KeyboardEvent::keyIdentifier):
* dom/MutationEvent.cpp:
(WebCore::MutationEvent::MutationEvent):
(WebCore::MutationEvent::initMutationEvent):
* dom/MutationEvent.h:
(WebCore::MutationEvent::prevValue):
(WebCore::MutationEvent::newValue):
(WebCore::MutationEvent::attrName):
* dom/Notation.cpp:
(WebCore::Notation::Notation):
(WebCore::Notation::nodeName):
* dom/Notation.h:
(WebCore::Notation::publicId):
(WebCore::Notation::systemId):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction):
(WebCore::ProcessingInstruction::setData):
(WebCore::ProcessingInstruction::nodeName):
(WebCore::ProcessingInstruction::nodeValue):
(WebCore::ProcessingInstruction::cloneNode):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::toString):
* dom/ProcessingInstruction.h:
(WebCore::ProcessingInstruction::target):
(WebCore::ProcessingInstruction::data):
(WebCore::ProcessingInstruction::localHref):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 7 Oct 2006 18:53:57 +0000 (18:53 +0000)]
Reviewed/landed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.
* COM/WebFrame.cpp:
(WebFrame::receivedResponse):
(WebFrame::receivedAllData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 7 Oct 2006 17:24:56 +0000 (17:24 +0000)]
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
10 more SVG Objective-C auto-generated bindings
- Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox,
DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement,
DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
- Auto-generate the text method for DOMRange.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMPrivate.h:
* bindings/objc/DOMRGBColor.mm:
* bindings/objc/DOMSVG.h:
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/Range.idl:
* ksvg2/svg/SVGFilterElement.cpp:
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGFilterElement.idl:
* ksvg2/svg/SVGForeignObjectElement.idl:
* ksvg2/svg/SVGGElement.idl:
* ksvg2/svg/SVGGradientElement.idl:
* ksvg2/svg/SVGImageElement.idl:
* ksvg2/svg/SVGLineElement.idl:
* ksvg2/svg/SVGLinearGradientElement.idl:
* ksvg2/svg/SVGMarkerElement.idl:
* ksvg2/svg/SVGMaskElement.idl:
* ksvg2/svg/SVGPaint.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 7 Oct 2006 12:58:25 +0000 (12:58 +0000)]
WebCore:
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces
- Fully auto-generate DOMAbstractView and DOMRange.
- Auto-generate just the interface for DOMRGBColor.
- Add DOMRanges.h as the new top level file for Ranges
module.
- Add DOMRanges.h and DOMXPath.h to DOM.mm
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.h:
* bindings/objc/DOM.mm:
* bindings/objc/DOMAbstractView.h: Removed.
* bindings/objc/DOMAbstractView.mm: Removed.
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMPrivate.h:
* bindings/objc/DOMRGBColor.h: Removed.
* bindings/objc/DOMRGBColor.mm:
* bindings/objc/DOMRange.h: Removed.
* bindings/objc/DOMRanges.h: Added.
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* css/RGBColor.idl:
* dom/Range.idl:
* page/AbstractView.idl: Added.
WebKit:
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 7 Oct 2006 12:39:48 +0000 (12:39 +0000)]
2006-10-07 Andrew Wellington <proton@wiretapped.net>
Reviewed by Eric.
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Return null when there is no frame. This matches Firefox.
* bindings/js/kjs_html.cpp:
(KJS::JSHTMLDocument::getValueProperty):
2006-10-07 Andrew Wellington <proton@wiretapped.net>
Reviewed by Eric.
Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
* fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 7 Oct 2006 12:04:21 +0000 (12:04 +0000)]
Fix win32 and qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 7 Oct 2006 11:41:23 +0000 (11:41 +0000)]
Implement scroll corner painting (a white rect fill) for overflow areas to cover up
scrollbar joins properly.
Refactor painting of scrollbars and resizers into common functions. Eliminate the
extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
Reviewed by mitz
* page/FrameView.cpp:
(WebCore::selectCursor):
(WebCore::FrameView::handleMouseMoveEvent):
* platform/mac/PlatformScrollBar.h:
(WebCore::PlatformScrollbar::horizontalScrollbarHeight):
(WebCore::PlatformScrollbar::verticalScrollbarWidth):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::scrollCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::paintLayer):
* rendering/RenderLayer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 7 Oct 2006 10:42:47 +0000 (10:42 +0000)]
2006-10-07 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Fix memory leak from -[WebDocumentLoadState setTitle:].
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is
zero, and untangle the confusing logic around this case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 7 Oct 2006 09:32:55 +0000 (09:32 +0000)]
2006-10-07 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
matching recent ResourceLoader changes.
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdk::openURL):
(WebCore::FrameGdk::urlSelected):
* platform/gdk/PlatformScrollBar.h:
* platform/gdk/ResourceLoaderCurl.cpp:
(WebCore::ResourceLoader::start):
* platform/gdk/ScrollViewGdk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::hScrollbarMode):
(WebCore::ScrollView::vScrollbarMode):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
* platform/gdk/TemporaryLinkStubs.cpp:
(FrameView::passMousePressEventToScrollbar):
(Widget::removeFromParent):
(ScrollView::addChild):
(ScrollView::updateScrollbars):
(ScrollView::scrollbarUnderMouse):
(PlatformScrollbar::PlatformScrollbar):
(PlatformScrollbar::~PlatformScrollbar):
(PlatformScrollbar::width):
(PlatformScrollbar::height):
(PlatformScrollbar::setEnabled):
(PlatformScrollbar::paint):
(PlatformScrollbar::updateThumbPosition):
(PlatformScrollbar::updateThumbProportion):
(PlatformScrollbar::setRect):
(Scrollbar::Scrollbar):
(Scrollbar::setSteps):
(Scrollbar::scroll):
(Scrollbar::setValue):
(Scrollbar::setProportion):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 7 Oct 2006 06:06:22 +0000 (06:06 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 7 Oct 2006 06:04:52 +0000 (06:04 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 7 Oct 2006 06:03:59 +0000 (06:03 +0000)]
Remove x/y from the log message on debug Mac builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 7 Oct 2006 05:55:26 +0000 (05:55 +0000)]
Reviewed by Darin
Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
* History/WebHistoryItem.m:
* Loader/WebFrameLoader.h:
* Misc/WebCoreStatistics.m:
* Misc/WebElementDictionary.m:
* Plugins/WebNetscapePluginEmbeddedView.m:
* Plugins/WebPluginController.m:
* WebCoreSupport/WebViewFactory.m:
* WebView/WebArchiver.m:
* WebView/WebDataSource.m:
* WebView/WebFrame.m:
(-[WebFrame _isDescendantOfFrame:]):
(-[WebFrame _setShouldCreateRenderers:]):
(-[WebFrame _bodyBackgroundColor]):
(-[WebFrame _isFrameSet]):
(-[WebFrame _firstLayoutDone]):
(-[WebFrame _loadType]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
* WebView/WebHTMLRepresentation.m:
* WebView/WebScriptDebugDelegate.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 7 Oct 2006 05:32:26 +0000 (05:32 +0000)]
Add a new method for obtaining accurate window-level clip rectangles. Can be used even by windowed plugins to clip properly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 7 Oct 2006 03:31:22 +0000 (03:31 +0000)]
2006-10-06 David Smith <catfish.man@gmail.com>
Reviewed by Timothy.
Bug 9665: [Drosera] Conditional breakpoints. http://bugs.webkit.org/show_bug.cgi?id=9665
* Drosera/Drosera.xcodeproj/project.pbxproj: Added new files
* Drosera/breakpointEditor.css: Added.
* Drosera/breakpointEditor.html: Added.
* Drosera/breakpointEditor.js: Added.
* Drosera/debugger.js: Added conditional breakpoint support, and the ability to open the breakpoint editor window on option-clicking a breakpoint.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 7 Oct 2006 00:42:31 +0000 (00:42 +0000)]
Reviewed by Darin.
- Move all delegate dispatching code out of WebDataSource.
* Loader/WebFrameLoader.m:
(-[WebFrameLoader startLoading]):
(-[WebFrameLoader _identifierForInitialRequest:]):
(-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
(-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didReceiveResponse:forResource:]):
(-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
(-[WebFrameLoader _didFinishLoadingForResource:]):
(-[WebFrameLoader _didFailLoadingWithError:forResource:]):
(-[WebFrameLoader _receivedMainResourceError:complete:]):
(-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
(-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
* WebView/WebDataSource.m:
(-[WebDataSource _setLoadingFromPageCache:]):
(-[WebDataSource _stopLoadingWithError:]):
* WebView/WebDataSourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 7 Oct 2006 00:36:13 +0000 (00:36 +0000)]
Reviewed by Maciej.
- moved firstLayoutDone BOOL from WebFrame to WebFrameLoader
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader didFirstLayout]):
(-[WebFrameLoader provisionalLoadStarted]):
(-[WebFrameLoader frameLoadCompleted]):
(-[WebFrameLoader firstLayoutDone]):
* WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
* WebView/WebFrame.m:
(-[WebFrame _firstLayoutDone]):
(-[WebFrame _provisionalLoadStarted]):
(-[WebFrame _frameLoadCompleted]):
(-[WebFrame _restoreScrollPositionAndViewState]):
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 7 Oct 2006 00:19:23 +0000 (00:19 +0000)]
Reviewed by Maciej.
- moved more data and the corresponding code from WebFrame to WebFrameLoader
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader cannotShowMIMETypeForURL:]):
(-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
(-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
(-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
(-[WebFrameLoader _continueAfterNewWindowPolicy:]):
(-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
(-[WebFrameLoader continueAfterNavigationPolicy:]):
(-[WebFrameLoader continueAfterWillSubmitForm:]):
(-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrameLoader loadDataSource:withLoadType:formState:]):
(-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
(-[WebFrameLoader delegateIsHandlingProvisionalLoadError]):
(-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
* Loader/WebFrameLoaderClient.h:
* WebView/WebFrame.m:
(-[NSView setWebFrame::]):
(-[WebFramePrivate dealloc]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrame _loadRequest:inFrameNamed:]):
(-[WebFrame stopLoading]):
(-[WebFrame _resetBackForwardList]):
(-[WebFrame _quickRedirectComing]):
(-[WebFrame _provisionalItemIsTarget]):
(-[WebFrame _loadProvisionalItemFromPageCache]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 22:49:02 +0000 (22:49 +0000)]
Rubber stamped by Darin.
- removed includes of unused headers.
* WebView/WebDataSource.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 22:42:38 +0000 (22:42 +0000)]
Not reviewed.
- fix build breakage
* Loader/WebFrameLoader.m:
(-[WebFrameLoader willChangeTitleForDocumentLoadState:]):
(-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 22:38:07 +0000 (22:38 +0000)]
Reviewed by Darin.
- move remaining movable WebDataSource fields to WebDocumentLoadState
* Loader/WebDocumentLoadState.h:
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState dealloc]):
(-[WebDocumentLoadState isLoadingInAPISense]):
(-[WebDocumentLoadState addResponse:]):
(-[WebDocumentLoadState stopRecordingResponses]):
(-[WebDocumentLoadState title]):
(-[WebDocumentLoadState setLastCheckedRequest:]):
(-[WebDocumentLoadState lastCheckedRequest]):
(-[WebDocumentLoadState triggeringAction]):
(-[WebDocumentLoadState setTriggeringAction:]):
(-[WebDocumentLoadState responses]):
(-[WebDocumentLoadState setOverrideEncoding:]):
(-[WebDocumentLoadState overrideEncoding]):
(-[WebDocumentLoadState setTitle:]):
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _setState:]):
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
(-[WebFrameLoader reload]):
(-[WebFrameLoader willChangeTitleForDocumentLoadState:]):
(-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge setTitle:]):
(-[WebFrameBridge receivedData:textEncodingName:]):
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _didReceiveResponse:forResource:]):
(-[WebDataSource textEncodingName]):
* WebView/WebDataSourceInternal.h:
* WebView/WebFrame.m:
(-[WebFrame _opened]):
(-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrame _addChild:]):
(-[WebFrame _loadDataSource:withLoadType:formState:]):
* WebView/WebHTMLRepresentation.m:
(-[WebHTMLRepresentation title]):
* WebView/WebView.m:
(-[WebView _mainFrameOverrideEncoding]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 6 Oct 2006 21:52:08 +0000 (21:52 +0000)]
Reviewed by Maciej.
- moved loadType into WebFrameLoader
* WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's
currently used by Safari.
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader isReplacing]):
(-[WebFrameLoader setReplacing]):
(-[WebFrameLoader loadType]):
(-[WebFrameLoader setLoadType:]):
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge isLoadTypeReload]):
* WebView/WebFrame.m:
(-[WebFrame _loadType]):
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _commitProvisionalLoad:]):
(-[WebFrame _opened]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _currentBackForwardListItemToResetTo]):
(-[WebFrame _itemForRestoringDocState]):
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
(-[WebFrame _didFirstLayout]):
(-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
(-[WebFrame _provisionalLoadStarted]):
(-[WebFrame loadRequest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 6 Oct 2006 21:25:16 +0000 (21:25 +0000)]
2006-10-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Add another method we'll need for scrollbar dodging
* platform/ScrollView.h:
* platform/win/TemporaryLinkStubs.cpp:
(ScrollView::resizerOverlapsContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 6 Oct 2006 21:25:08 +0000 (21:25 +0000)]
Reviewed by Maciej.
- added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame
* Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol.
Eventually we'll be removing the dependency on WebFrame entirely.
* WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method
by its new name.
* Loader/WebFrameLoaderClient.h: Added.
* WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 6 Oct 2006 21:13:09 +0000 (21:13 +0000)]
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
Auto-generate the interfaces even for Objective-C DOM
bindings that need custom implementations
- Fully auto-generate DOMEventTarget, DOMNodeFilter and
DOMHTMLOptionElement.
- Auto-generate just the interface for DOMHTMLAppletElement,
DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
using the new IDL property ObjCCustomImplementation.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMEventTarget.h: Removed.
* bindings/objc/DOMHTMLAppletElement.h: Removed.
* bindings/objc/DOMHTMLEmbedElement.h: Removed.
* bindings/objc/DOMHTMLOptionElement.h: Removed.
* bindings/objc/DOMHTMLOptionElement.mm: Removed.
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMNodeFilter.h: Removed.
* bindings/objc/DOMSVGNumber.h: Removed.
* bindings/objc/DOMSVGPoint.h: Removed.
* bindings/objc/DOMSVGPoint.mm:
(-[DOMSVGPoint matrixTransform:]):
* bindings/objc/DOMSVGRect.h: Removed.
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/EventTarget.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLOptionElement.idl:
* ksvg2/svg/SVGNumber.idl:
* ksvg2/svg/SVGPoint.idl:
* ksvg2/svg/SVGRect.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 21:11:29 +0000 (21:11 +0000)]
Reviewed by Darin.
- segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to
Also removed useless WebFrameLoader part
* WebView/WebFrame.m:
(-[WebFramePrivate dealloc]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 6 Oct 2006 20:48:50 +0000 (20:48 +0000)]
WebCore:
Reviewed by Tim H.
Make Qt/Linux compile again completly.
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::removeFromParent):
WebKitTools:
Reviewed by Tim H.
Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ changes.
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 20:42:01 +0000 (20:42 +0000)]
Reviewed by Anders.
- moved more data from WebDataSource to WebDocumentLoadState
* Loader/WebDocumentLoadState.h:
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState commitLoadWithData:]):
(-[WebDocumentLoadState prepareForLoadStart]):
(-[WebDocumentLoadState loadingStartedTime]):
(-[WebDocumentLoadState setIsClientRedirect:]):
(-[WebDocumentLoadState isClientRedirect]):
(-[WebDocumentLoadState setPrimaryLoadComplete:]):
(-[WebDocumentLoadState isLoadingInAPISense]):
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _setState:]):
(-[WebFrameLoader _finishedLoading]):
(-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
(-[WebFrameLoader prepareForLoadStart]):
(-[WebFrameLoader subframeIsLoading]):
* WebView/WebDataSource.m:
(-[WebDataSource _fileWrapperForURL:]):
(-[WebDataSource _startLoading]):
(-[WebDataSource _loadFromPageCache:]):
(-[WebDataSource isLoading]):
* WebView/WebDataSourceInternal.h:
* WebView/WebFrame.m:
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _opened]):
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 6 Oct 2006 20:36:10 +0000 (20:36 +0000)]
Reviewed by Tim H.
Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
* platform/qt/PlatformScrollBar.h:
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::hScrollbarMode):
(WebCore::ScrollView::vScrollbarMode):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::scrollbarUnderMouse):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::setSteps):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::setValue):
(WebCore::Scrollbar::setProportion):
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::~PlatformScrollbar):
(WebCore::PlatformScrollbar::width):
(WebCore::PlatformScrollbar::height):
(WebCore::PlatformScrollbar::setEnabled):
(WebCore::PlatformScrollbar::paint):
(WebCore::PlatformScrollbar::updateThumbPosition):
(WebCore::PlatformScrollbar::updateThumbProportion):
(WebCore::PlatformScrollbar::setRect):
(FrameView::passMousePressEventToScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Fri, 6 Oct 2006 18:16:38 +0000 (18:16 +0000)]
Reviewed by Brady.
DST and TimeZones were wrong in some cases, specifically on some of the dates where DST changes.
* kjs/DateMath.cpp:
(KJS::equivalentYearForDST):
(KJS::getUTCOffset):
(KJS::getDSTOffsetSimple):
(KJS::getDSTOffset):
(KJS::dateToMseconds):
(KJS::msToTM):
* kjs/DateMath.h:
* kjs/date_object.cpp:
(KJS::gmtoffset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 6 Oct 2006 17:55:21 +0000 (17:55 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11183
REGRESSION: Safari loads error pages unstyled
* WebView/WebFrame.m:
(-[WebFrame _loadHTMLString:baseURL:unreachableURL:]):
Use utf-8 encoding instead of the string's "fastest" encoding.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 6 Oct 2006 12:25:52 +0000 (12:25 +0000)]
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
Another round of Objective-C SVG DOM bindings auto-generation
- Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect,
DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement,
DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement,
DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement,
DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement,
DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement,
DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement,
DOMSVGFEOffsetElement, DOMSVGFEPointLightElement,
DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement,
DOMSVGFETileElement, DOMSVGFETurbulenceElement,
DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
- Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
and DOMSVGRect.
- IDL clean up.
- Make numOctaves in SVGFETurbulenceElement use a long instead of an int
in it's macro declaration and definition.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMCSS.mm:
(+[DOMCSSValue _CSSValueWith:WebCore::]):
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMSVG.h:
* bindings/objc/DOMSVGNumber.h: Added.
* bindings/objc/DOMSVGNumber.mm: Added.
(-[DOMSVGNumber dealloc]):
(-[DOMSVGNumber finalize]):
(-[DOMSVGNumber value]):
(-[DOMSVGNumber setValue:]):
(-[DOMSVGNumber _SVGNumber]):
(-[DOMSVGNumber _initWithFloat:]):
(+[DOMSVGNumber _SVGNumberWith:]):
* bindings/objc/DOMSVGPoint.h: Added.
* bindings/objc/DOMSVGPoint.mm: Added.
(-[DOMSVGPoint dealloc]):
(-[DOMSVGPoint finalize]):
(-[DOMSVGPoint x]):
(-[DOMSVGPoint setX:]):
(-[DOMSVGPoint y]):
(-[DOMSVGPoint setY:]):
(-[DOMSVGPoint WebCore::]):
(-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
(+[DOMSVGPoint _SVGPointWith:WebCore::]):
* bindings/objc/DOMSVGRect.h: Added.
* bindings/objc/DOMSVGRect.mm: Added.
(-[DOMSVGRect dealloc]):
(-[DOMSVGRect finalize]):
(-[DOMSVGRect x]):
(-[DOMSVGRect setX:]):
(-[DOMSVGRect y]):
(-[DOMSVGRect setY:]):
(-[DOMSVGRect width]):
(-[DOMSVGRect setWidth:]):
(-[DOMSVGRect height]):
(-[DOMSVGRect setHeight:]):
(-[DOMSVGRect WebCore::]):
(-[DOMSVGRect _initWithFloatRect:WebCore::]):
(+[DOMSVGRect _SVGRectWith:WebCore::]):
* bindings/scripts/CodeGeneratorObjC.pm:
* ksvg2/svg/SVGAnimatedNumberList.idl:
* ksvg2/svg/SVGAnimatedRect.idl:
* ksvg2/svg/SVGComponentTransferFunctionElement.idl:
* ksvg2/svg/SVGCursorElement.idl:
* ksvg2/svg/SVGFEBlendElement.idl:
* ksvg2/svg/SVGFEColorMatrixElement.idl:
* ksvg2/svg/SVGFEComponentTransferElement.idl:
* ksvg2/svg/SVGFECompositeElement.idl:
* ksvg2/svg/SVGFEDiffuseLightingElement.idl:
* ksvg2/svg/SVGFEDisplacementMapElement.idl:
* ksvg2/svg/SVGFEDistantLightElement.idl:
* ksvg2/svg/SVGFEFloodElement.idl:
* ksvg2/svg/SVGFEFuncAElement.idl:
* ksvg2/svg/SVGFEFuncBElement.idl:
* ksvg2/svg/SVGFEFuncGElement.idl:
* ksvg2/svg/SVGFEFuncRElement.idl:
* ksvg2/svg/SVGFEGaussianBlurElement.idl:
* ksvg2/svg/SVGFEImageElement.idl:
* ksvg2/svg/SVGFEMergeElement.idl:
* ksvg2/svg/SVGFEMergeNodeElement.idl:
* ksvg2/svg/SVGFEOffsetElement.idl:
* ksvg2/svg/SVGFEPointLightElement.idl:
* ksvg2/svg/SVGFESpecularLightingElement.idl:
* ksvg2/svg/SVGFESpotLightElement.idl:
* ksvg2/svg/SVGFETileElement.idl:
* ksvg2/svg/SVGFETurbulenceElement.cpp:
* ksvg2/svg/SVGFETurbulenceElement.h:
* ksvg2/svg/SVGFETurbulenceElement.idl:
* ksvg2/svg/SVGNumberList.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 11:18:54 +0000 (11:18 +0000)]
Reviewed by Adam.
- fixed the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=11136
"REGRESSION: Safari snippet editor doesn't work"
http://bugs.webkit.org/show_bug.cgi?id=11140
"REGRESSION: view source window blank"
http://bugs.webkit.org/show_bug.cgi?id=11146
"REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"
Possibly more.
* Loader/WebDocumentLoadState.h:
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState actualRequest]): New method.
* WebView/WebDataSource.m:
(-[WebDataSource _startLoading]): We need to make sure not to start loading the main
resource with the fake external request for an applewebdata: request.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:30:17 +0000 (10:30 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:28:22 +0000 (10:28 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:22:30 +0000 (10:22 +0000)]
Fix build bustage on many platforms by making sure the includes of ScrollBar stay the way they were.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Oct 2006 10:18:40 +0000 (10:18 +0000)]
Backing out my previous change.
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:17:27 +0000 (10:17 +0000)]
Fix build bustage like... everywhere.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Oct 2006 10:06:48 +0000 (10:06 +0000)]
Build fix.
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::windowResizerRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:01:54 +0000 (10:01 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Oct 2006 09:43:24 +0000 (09:43 +0000)]
Reviewed by Maciej.
More loader tweaks.
* platform/ResourceLoader.h:
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::ResourceLoader::newHTTPRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 6 Oct 2006 07:44:42 +0000 (07:44 +0000)]
2006-10-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Stub out some methods that we'll be able to use to dodge a window resizer.
* bridge/win/FrameWin.h:
* page/Frame.h:
(WebCore::Frame::windowResizerRect):
* page/FrameView.h:
* platform/ScrollView.h:
(WebCore::ScrollView::windowResizerRect):
* platform/Widget.h:
* platform/win/TemporaryLinkStubs.cpp:
(FrameView::windowResizerRect):
(Widget::setParent):
(Widget::parent):
(FrameWin::windowResizerRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 06:14:34 +0000 (06:14 +0000)]
Stub out setFrameGeometry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 05:30:09 +0000 (05:30 +0000)]
Temporary hack.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 6 Oct 2006 05:18:36 +0000 (05:18 +0000)]
Reverting autoscroll fix. I need to rework this a little.
* page/Frame.cpp:
(WebCore::Frame::handleAutoscroll):
(WebCore::Frame::autoscrollTimerFired):
(WebCore::Frame::stopAutoscrollTimer):
* page/Frame.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 6 Oct 2006 04:48:14 +0000 (04:48 +0000)]
2006-10-05 Oliver Hunt <ohunt@apple.com>
Reviewed by Anders.
* Scripts/run-webkit-tests:
Fix pixel tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 6 Oct 2006 03:57:08 +0000 (03:57 +0000)]
Reviewed by Adam.
Fixed <rdar://problem/
4731778>
* editing/CommandByName.cpp:
(WebCore::Frame::Command::):
was calling the wrong enabledFn for arrow selection and navigation
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 6 Oct 2006 03:34:36 +0000 (03:34 +0000)]
Reviewed by Maciej.
- Fix for <rdar://problem/
4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
and <rdar://problem/
4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
* rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
* rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
* page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
(WebCore::Frame::handleAutoscroll):
(WebCore::Frame::autoscrollTimerFired):
(WebCore::Frame::autoscrollRenderer):
(WebCore::Frame::setAutoscrollRenderer):
(WebCore::Frame::stopAutoscrollTimer):
* page/Frame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 6 Oct 2006 02:48:36 +0000 (02:48 +0000)]
2006-10-05 Don Gibson <dgibson77@gmail.com>
Reviewed by Eric.
Fix win32 build bustage after ggaren's Scrollbar renaming changes.
Properly include PlatformScrollBar.h in WbCore.vcproj.
Clean up WidgetWin.cpp a bit.
* WebCore.vcproj/WebCore/WebCore.vcproj:
* platform/Widget.h:
* platform/win/PlatformScrollBar.h:
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::hScrollbarMode):
(WebCore::ScrollView::vScrollbarMode):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::updateScrollbars):
* platform/win/TemporaryLinkStubs.cpp:
(FrameView::passMousePressEventToScrollbar):
(Widget::removeFromParent):
(ScrollView::scrollbarUnderMouse):
(PlatformScrollbar::PlatformScrollbar):
(PlatformScrollbar::~PlatformScrollbar):
(PlatformScrollbar::width):
(PlatformScrollbar::height):
(PlatformScrollbar::setEnabled):
(PlatformScrollbar::paint):
(PlatformScrollbar::updateThumbPosition):
(PlatformScrollbar::updateThumbProportion):
(PlatformScrollbar::setRect):
(Scrollbar::Scrollbar):
(Scrollbar::setSteps):
(Scrollbar::scroll):
(Scrollbar::setValue):
(Scrollbar::setProportion):
* platform/win/WidgetWin.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::Widget):
(WebCore::Widget::setContainingWindow):
(WebCore::Widget::containingWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 6 Oct 2006 01:23:47 +0000 (01:23 +0000)]
Reviewed by the letter 'B'.
More build fixes.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView setAllowsScrolling:]):
(-[WebDynamicScrollBarsView allowsScrolling]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
(-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
(-[WebDynamicScrollBarsView setScrollingMode:]):
* WebView/WebView.m:
(-[WebView setAlwaysShowVerticalScroller:]):
(-[WebView alwaysShowVerticalScroller]):
(-[WebView setAlwaysShowHorizontalScroller:]):
(-[WebView alwaysShowHorizontalScroller]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 6 Oct 2006 01:01:59 +0000 (01:01 +0000)]
build fix.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::createFrame):
* bridge/mac/FrameViewMac.mm:
(WebCore::FrameView::passMousePressEventToScrollbar):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge installInFrame:]):
* bridge/mac/WebCoreFrameView.h:
* platform/ScrollBar.cpp:
* platform/Widget.h:
* platform/mac/PlatformScrollBar.h:
* platform/mac/PlatformScrollBarMac.mm:
(NSControlSizeForScrollBarControlSize):
(-[WebCoreScrollBar initWithPlatformScrollbar:]):
(-[WebCoreScrollBar detachPlatformScrollbar]):
(-[WebCoreScrollBar scroll:]):
(-[WebCoreScrollBar widget]):
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::~PlatformScrollbar):
(WebCore::PlatformScrollbar::updateThumbPosition):
(WebCore::PlatformScrollbar::updateThumbProportion):
(WebCore::PlatformScrollbar::scrollbarHit):
(WebCore::PlatformScrollbar::width):
(WebCore::PlatformScrollbar::height):
(WebCore::PlatformScrollbar::setRect):
(WebCore::PlatformScrollbar::setEnabled):
(WebCore::PlatformScrollbar::paint):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::vScrollbarMode):
(WebCore::ScrollView::hScrollbarMode):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::removeFromParent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::destroyScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 6 Oct 2006 00:02:40 +0000 (00:02 +0000)]
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by Tim H.
* coding/coding-style.html: use css styles, add example for whitespace, add example for c++ constructors
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 22:26:29 +0000 (22:26 +0000)]
2006-10-06 Mitz Pettel <mitz@webkit.org>
http://bugs.webkit.org/show_bug.cgi?id=8276
Fix broken manual test added back in r13990.
Add resource forks for test resources.
* manual-tests/resources/plain-text-paste/._1.textClipping: Added.
* manual-tests/resources/plain-text-paste/._2.textClipping: Added.
* manual-tests/resources/plain-text-paste/._4.txt: Added.
* manual-tests/resources/plain-text-paste/._5.webloc: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 5 Oct 2006 22:14:49 +0000 (22:14 +0000)]
Rename addClip to clip.
Reviewed by darin
* kcanvas/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::paint):
* kcanvas/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* platform/GraphicsContext.h:
* platform/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clip):
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
* platform/cg/GraphicsContextPlatformPrivate.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::rotate):
(WebCore::GraphicsContextPlatformPrivate::translate):
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::addRoundedRectClip):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBackground):
(WebCore::InlineFlowBox::paintBackgroundAndBorder):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintTextMatchMarker):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::paintObject):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::setClip):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintObject):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::paintObject):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 22:03:43 +0000 (22:03 +0000)]
2006-10-05 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=10386
Delete RenderImageButton.* and remove references from .vcproj and .bkl files
* CMakeLists.txt:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCoreSources.bkl:
* rendering/RenderImageButton.cpp: Removed.
* rendering/RenderImageButton.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:56:17 +0000 (21:56 +0000)]
2006-10-05 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=11067
manual-tests/scrollbar-hittest2.html is invalid
* manual-tests/scrollbar-hittest2.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:53:59 +0000 (21:53 +0000)]
2006-10-05 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Timothy.
Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
Continuous spell checking now remembers user's setting. The change is applied globally,
meaning, both TextArea and TextField are affected when either of them enables/disables
spell checking.
* WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
* WebView/WebView.m:
(-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults
(-[WebView setContinuousSpellCheckingEnabled:]):
(-[WebView isContinuousSpellCheckingEnabled]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:43:22 +0000 (21:43 +0000)]
2006-10-05 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11162
* COM/WebFrame.cpp:
(WebFrame::loadDataSource):
(WebFrame::receivedResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:40:04 +0000 (21:40 +0000)]
2006-10-05 David Carson <dacarson@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11152
Adjust the tokenizer chunk size to be smaller for
mobile devices, and also decrease the yield timer
for the tokenizer so that it can resume earlier.
* html/HTMLTokenizer.cpp:
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Oct 2006 21:38:44 +0000 (21:38 +0000)]
Removing accidentally-checked-in do-nothing code.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:35:58 +0000 (21:35 +0000)]
2006-10-05 David Carson <dacarson@gmail.com>
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11158
Initialize class variables
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log