loislo@chromium.org [Tue, 22 Feb 2011 16:01:30 +0000 (16:01 +0000)]
2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Inspector.IDL change. rename attribute notify -> event.
https://bugs.webkit.org/show_bug.cgi?id=54958
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 22 Feb 2011 15:44:31 +0000 (15:44 +0000)]
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78691.
http://trac.webkit.org/changeset/78691
https://bugs.webkit.org/show_bug.cgi?id=54956
Leopard Debug is successfully building again (Requested by
aroben on #webkit).
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 22 Feb 2011 15:32:29 +0000 (15:32 +0000)]
2011-02-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951
* inspector/timeline/timeline-network-resource.html:
* inspector/timeline/timeline-script-tag-1.html:
* inspector/timeline/timeline-script-tag-2.html:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
* inspector/timeline/timeline-trivial.html:
2011-02-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
(WebCore::InspectorAgent::loadEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::startTimelineProfiler):
(WebCore::InspectorController::stopTimelineProfiler):
(WebCore::InspectorController::timelineProfilerEnabled):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::retrieveTimelineAgent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::setFrontend):
(WebCore::InspectorTimelineAgent::clearFrontend):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::startTimelineProfiler):
(WebCore::InspectorTimelineAgent::stopTimelineProfiler):
(WebCore::InspectorTimelineAgent::timelineProfilerStarted):
(WebCore::InspectorTimelineAgent::didCommitLoad):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::clearRecordStack):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 22 Feb 2011 15:28:20 +0000 (15:28 +0000)]
2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by NOBODY (OOPS!).
Web Inspector: flakyness of inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=54729
As far as we have the protocol with sequence numbers we can simplify test harness support
and drop out chomium specific methods.
Source/WebCore:
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/TestController.js:
(WebInspector.TestController):
(WebInspector.TestController.prototype.notifyDone):
(WebInspector.TestController.prototype.runAfterPendingDispatches):
(WebInspector.TestController.prototype._evaluateForTestInFrontend):
* inspector/front-end/inspector.js:
(WebInspector.dispatch):
Source/WebKit/chromium:
* src/js/DevTools.js:
LayoutTests:
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):
Tools:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::sendMessageToInspectorFrontend):
(DRTDevToolsAgent::runtimePropertyChanged):
(DRTDevToolsAgent::asyncCall):
(DRTDevToolsAgent::call):
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
* DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::sendMessageToBackend):
(DRTDevToolsClient::asyncCall):
(DRTDevToolsClient::call):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 22 Feb 2011 15:26:23 +0000 (15:26 +0000)]
2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
New GTK-specific layout test to check the right signals are emitted.
* platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
* platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.
2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
Emit the selection-changed signals when the menu list value has changed
Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::getListObject): New, return the right list object for
menu lists and list boxes.
(WebCore::notifyChildrenSelectionChange): Support menu lists.
(WebCore::AXObjectCache::postPlatformNotification): Call function
notifyChildrenSelectionChange for AXMenuListValueChanged.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Tue, 22 Feb 2011 15:14:57 +0000 (15:14 +0000)]
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* Source/WebKit.pri: Add common include paths
* Source/WebKit.pro: Add new project file to SUBDIRS
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* JavaScriptCore.pri: Remove the workaround.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* QtWebKit.pro: Added.
Project file for the final build step.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
No new tests needed.
* WebCore.pri: Add needed rules for handling the static library.
* WebCore.pro: Reorganize API and linker options to QtWebKit.pro.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* WebKit2.pri: Add include paths.
* WebKit2.pro: Move include paths to WebKit2.pri and move
the API source to WebKit/qt/QtWebKit.pro
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 22 Feb 2011 15:09:12 +0000 (15:09 +0000)]
2011-02-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
https://bugs.webkit.org/show_bug.cgi?id=54947
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::loadFromCookie):
* inspector/InspectorState.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 22 Feb 2011 15:07:16 +0000 (15:07 +0000)]
2011-02-15 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142
Added a repaint test which ensures the timeline controls repaint in an audio-only MediaDocument. Since
the change also affects in-page audio, also added a repaint test for those cases as well.
Other platforms will need to have results generated.
* media/audio-repaint.html: Added.
* media/media-document-audio-repaint-expected.txt: Added.
* media/media-document-audio-repaint.html: Added.
* platform/mac/media/audio-repaint-expected.checksum: Added.
* platform/mac/media/audio-repaint-expected.png: Added.
* platform/mac/media/audio-repaint-expected.txt: Added.
* platform/mac/media/media-document-audio-repaint-expected.checksum: Added.
* platform/mac/media/media-document-audio-repaint-expected.png: Added.
2011-02-15 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142
Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
container elements. This is necessary because, during layout(), the child renderers
query the current LayoutState to determine where they will be repainting. If a new
LayoutState is not pushed here, child renderers will attempt to repaint relative to
their grandparent's origin instead of their parents', and repaint operations will fail.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Tue, 22 Feb 2011 14:49:45 +0000 (14:49 +0000)]
2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
https://bugs.webkit.org/show_bug.cgi?id=54952
Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
a valid reference for the input type FileInputType.
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Tue, 22 Feb 2011 13:25:15 +0000 (13:25 +0000)]
2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Improve the memory handling of the context menu for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=54902
Refactor the context menu handling of Qt to make it simpler to manage memory.
WebContextMenuProxyQt uses smart pointer for all the references to menu so
there is no need to delete it explicitely.
Passing the QMenu from QWKPage to the client of the signal now uses a QSharedPointer so
the client can choose to handle the memory, but there is no leak if it does not.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::showContextMenu):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.h:
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:20:42 +0000 (13:20 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip crashing inspector test on GTK
* platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:20:31 +0000 (13:20 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
* GNUmakefile.am:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:20:20 +0000 (13:20 +0000)]
2011-02-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671
- factored toolbar handling out of inspector.js
- added toolbar dropdown
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.get toolbarItem):
* inspector/front-end/Toolbar.js: Added.
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.resize):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._onClose):
(WebInspector.Toolbar.prototype._setDropdownVisible):
(WebInspector.Toolbar.prototype._toggleDropdown):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
(WebInspector.ToolbarDropdown):
(WebInspector.ToolbarDropdown.prototype.show):
(WebInspector.ToolbarDropdown.prototype.hide):
(WebInspector.ToolbarDropdown.prototype.get visible):
(WebInspector.ToolbarDropdown.prototype._populate):
(WebInspector.ToolbarDropdown.prototype._onKeyDown):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(#toolbar):
(.toolbar-item):
(.toolbar-item.toggleable):
(.toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-icon):
(#toolbar-dropdown .toolbar-label):
(#toolbar-controls):
(#toolbar-dropdown-arrow):
(body.attached #toolbar-dropdown-arrow):
(#toolbar-dropdown-arrow.dropdown-visible):
(#toolbar-dropdown-arrow:hover):
(#toolbar-dropdown-arrow:active):
(#toolbar-dropdown):
(body.detached.platform-mac-snowleopard #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-icon):
(#toolbar-dropdown .toolbar-label):
(#toolbar-controls):
(#toolbar-dropdown-arrow):
(body.attached #toolbar-dropdown-arrow):
(#toolbar-dropdown-arrow.dropdown-visible):
(#toolbar-dropdown-arrow:hover):
(#toolbar-dropdown-arrow:active):
(#toolbar-dropdown):
(body.detached.platform-mac-snowleopard #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-item:hover):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
(#toolbar-dropdown .toolbar-item:active .toolbar-icon):
(.scrollable-content):
(.scrollable-content::-webkit-scrollbar):
(.scrollable-content::-webkit-resizer):
(.scrollable-content::-webkit-scrollbar-thumb:vertical):
(.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
(.scrollable-content::-webkit-scrollbar-track:vertical):
(.toolbar-search-item):
(#search):
(body.attached #search):
(#search-results-matches):
(#close-button-left, #close-button-right):
(.close-left):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.addPanel):
(WebInspector.windowResize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:20:07 +0000 (13:20 +0000)]
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 22 Feb 2011 13:17:02 +0000 (13:17 +0000)]
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=54645
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.createWrapper.return.try):
(initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
(initialize_DebuggerTest.InspectorTest.showScriptSource):
* inspector/debugger/source-frame-expected.txt: Added.
* inspector/debugger/source-frame.html: Added.
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=54645
This is needed to map one script to several source files.
Test: inspector/debugger/source-frame.html
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DebuggerPresentationModel.js: Added.
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
(WebInspector.ScriptsPanel.prototype._addSourceFrame):
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.get loaded):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._setTextViewerDecorations):
(WebInspector.SourceFrame.prototype.setExecutionLine):
(WebInspector.SourceFrame.prototype.clearExecutionLine):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype.removeBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._findBreakpoint.filter):
(WebInspector.SourceFrame.prototype._findBreakpoint):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=54645
* src/js/Tests.js:
(.TestSuite.prototype._checkExecutionLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:11:52 +0000 (13:11 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline of fast/forms/placeholder-position.html
* platform/gtk/fast/forms/placeholder-position-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:08:05 +0000 (13:08 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline of media/video-aspect-ratio.html
* platform/gtk/media/video-aspect-ratio-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:06:11 +0000 (13:06 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip crashing inspector test on GTK
* platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 13:05:58 +0000 (13:05 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
* GNUmakefile.am:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 22 Feb 2011 12:16:42 +0000 (12:16 +0000)]
2011-02-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671
- factored toolbar handling out of inspector.js
- added toolbar dropdown
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.get toolbarItem):
* inspector/front-end/Toolbar.js: Added.
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.resize):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._onClose):
(WebInspector.Toolbar.prototype._setDropdownVisible):
(WebInspector.Toolbar.prototype._toggleDropdown):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
(WebInspector.ToolbarDropdown):
(WebInspector.ToolbarDropdown.prototype.show):
(WebInspector.ToolbarDropdown.prototype.hide):
(WebInspector.ToolbarDropdown.prototype.get visible):
(WebInspector.ToolbarDropdown.prototype._populate):
(WebInspector.ToolbarDropdown.prototype._onKeyDown):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(#toolbar):
(.toolbar-item):
(.toolbar-item.toggleable):
(.toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-icon):
(#toolbar-dropdown .toolbar-label):
(#toolbar-controls):
(#toolbar-dropdown-arrow):
(body.attached #toolbar-dropdown-arrow):
(#toolbar-dropdown-arrow.dropdown-visible):
(#toolbar-dropdown-arrow:hover):
(#toolbar-dropdown-arrow:active):
(#toolbar-dropdown):
(body.detached.platform-mac-snowleopard #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-icon):
(#toolbar-dropdown .toolbar-label):
(#toolbar-controls):
(#toolbar-dropdown-arrow):
(body.attached #toolbar-dropdown-arrow):
(#toolbar-dropdown-arrow.dropdown-visible):
(#toolbar-dropdown-arrow:hover):
(#toolbar-dropdown-arrow:active):
(#toolbar-dropdown):
(body.detached.platform-mac-snowleopard #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-item:hover):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
(#toolbar-dropdown .toolbar-item:active .toolbar-icon):
(.scrollable-content):
(.scrollable-content::-webkit-scrollbar):
(.scrollable-content::-webkit-resizer):
(.scrollable-content::-webkit-scrollbar-thumb:vertical):
(.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
(.scrollable-content::-webkit-scrollbar-track:vertical):
(.toolbar-search-item):
(#search):
(body.attached #search):
(#search-results-matches):
(#close-button-left, #close-button-right):
(.close-left):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.addPanel):
(WebInspector.windowResize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 22 Feb 2011 12:12:52 +0000 (12:12 +0000)]
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 22 Feb 2011 11:11:34 +0000 (11:11 +0000)]
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
* GNUmakefile.am:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 22 Feb 2011 09:34:15 +0000 (09:34 +0000)]
2011-02-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54891
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::instrumentingAgents):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::setFrontend):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::selectDOMStorage):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::clearResources):
* inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::clearResources):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::databaseForId):
(WebCore::InspectorDatabaseAgent::selectDatabase):
* inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::create):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 22 Feb 2011 09:12:14 +0000 (09:12 +0000)]
2011-02-22 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtWebProcess should be installed with 'make install'
https://bugs.webkit.org/show_bug.cgi?id=44100
Follow the standard in other project files and allow install
location to be changed with INSTALL_BINS variable.
* WebProcess.pro: Install QtWebProcess.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 22 Feb 2011 09:03:17 +0000 (09:03 +0000)]
2011-02-22 Steve Lacey <sjl@chromium.org>
Reviewed by Darin Fisher.
Rename new media statistics apis to better names
https://bugs.webkit.org/show_bug.cgi?id=54784
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAudioDecodedByteCount):
(WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitDecodedFrameCount):
(WebCore::HTMLVideoElement::webkitDroppedFrameCount):
* html/HTMLVideoElement.h:
* html/HTMLVideoElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::decodedFrameCount):
(WebCore::MediaPlayer::droppedFrameCount):
(WebCore::MediaPlayer::audioDecodedByteCount):
(WebCore::MediaPlayer::videoDecodedByteCount):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::decodedFrameCount):
(WebCore::MediaPlayerPrivateInterface::droppedFrameCount):
(WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount):
(WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 08:41:23 +0000 (08:41 +0000)]
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Removed more BUGWK54736 lines which are no longer failed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 08:32:11 +0000 (08:32 +0000)]
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Mark styles-update-from-js.html as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Tue, 22 Feb 2011 08:23:55 +0000 (08:23 +0000)]
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
https://bugs.webkit.org/show_bug.cgi?id=54435
Changed the function to a series of early-exit 'if's,
removed most temporary variables.
No new tests. (refactoring)
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 22 Feb 2011 08:18:18 +0000 (08:18 +0000)]
Unreviewed, rolling out r79296.
http://trac.webkit.org/changeset/79296
https://bugs.webkit.org/show_bug.cgi?id=54941
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-22
Breaks compilation on SnowLeapard Intel Release (Requested by
kbalazs_ on #webkit).
* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
* config.h:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 22 Feb 2011 07:42:12 +0000 (07:42 +0000)]
notImplemented() should behave identical in WebCore and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=54449
Reviewed by Anders Carlsson.
Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().
* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Removed.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 22 Feb 2011 07:21:09 +0000 (07:21 +0000)]
2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
https://bugs.webkit.org/show_bug.cgi?id=54806
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): spatial navigation setting initialization added
2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
https://bugs.webkit.org/show_bug.cgi?id=54806
* EWebLauncher/main.c:
(on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 22 Feb 2011 07:05:28 +0000 (07:05 +0000)]
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::showInRect):
(WebCore::PopupMenuChromium::show):
* platform/chromium/PopupMenuChromium.h:
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutoFillSuggestions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 22 Feb 2011 06:48:22 +0000 (06:48 +0000)]
2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
Improve the local{SharedStyle,CousinList} algorithm
https://bugs.webkit.org/show_bug.cgi?id=45507
This change improves the algorithm to find shared styles: the old
algorithm would stop the search after the first cousin, even if
the search threshold is not met. As such, the algorithm would
systematically miss sharings across second cousins and beyond.
The new algorithm continues the search, as long as threshold is
not met. It also separates the threshold for sibling/cousins
search, from that on the levels of search, which is easier to
optimize.
The new algorithm finds up to 30% more sharings on some sites
(e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.
No new test, refactoring only.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::locateSharedStyle):
While changing the algorithm, cleaned up the style of those 2 methods
(use early return, renamed some variables).
* css/CSSStyleSelector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 22 Feb 2011 06:46:24 +0000 (06:46 +0000)]
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54922
RenderTableCell::baselinePosition() has the same name as a virtual
method in superclass RenderBlock. Rename the subclass method to make
it clear it's not an attempted override.
No intended functionality change.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::cellBaselinePosition):
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 06:45:15 +0000 (06:45 +0000)]
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
r79285 removes too much lines. recover failed one.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kalman@chromium.org [Tue, 22 Feb 2011 06:24:36 +0000 (06:24 +0000)]
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.
* editing/selection/extend-left-right-by-lineboundary-expected.txt:
* editing/selection/extend-left-right-by-lineboundary.html:
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
extending from the end when for the "right" direction (e.g. pressing right arrow key).
However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
direction is obviously reversed) and likewise extend from the start when extending right.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modify):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 06:19:39 +0000 (06:19 +0000)]
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation rebaseline for r79284.
* platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/forms/search-styled-expected.checksum:
* platform/chromium-linux/fast/forms/search-styled-expected.png:
* platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
* platform/chromium-win/fast/forms/placeholder-position-expected.png:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.checksum:
* platform/chromium-win/fast/forms/search-styled-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 22 Feb 2011 06:10:29 +0000 (06:10 +0000)]
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
ImageDocument::imageChanged() confuses clang's -Woverride-virtual
https://bugs.webkit.org/show_bug.cgi?id=54924
Rename ImageDocument::imageChanged() to imageUpdated() to make clear
that it's not an override of CachedResourceClient::imageChanged().
* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::imageUpdated):
* html/ImageDocument.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Tue, 22 Feb 2011 05:58:49 +0000 (05:58 +0000)]
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54934 - Sort the WebCore project file(s)
https://bugs.webkit.org/show_bug.cgi?id=54934
No new tests. (no code affected)
* GNUmakefile.am:
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 22 Feb 2011 05:51:51 +0000 (05:51 +0000)]
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54909
Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
unconfuse clang. No intended functionality change.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineCanAccommodateEllipsis):
* rendering/RootInlineBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 05:14:59 +0000 (05:14 +0000)]
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Removed BUGWK54736 lines which are no longer failed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Tue, 22 Feb 2011 04:56:14 +0000 (04:56 +0000)]
Source/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Reviewed by Dan Bernstein.
Test: updated fast/forms/placeholder-position.html and tested manually
Consider padding and margin for the results and cancel buttons. This is important for the Windows
theme which uses padding to correctly position those buttons. This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Reviewed by Dan Bernstein.
Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.
* fast/forms/placeholder-position.html: Added a case for a search field with the results button.
* platform/mac/fast/forms/placeholder-position-expected.checksum:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 22 Feb 2011 03:59:52 +0000 (03:59 +0000)]
2011-02-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] focus comment on accept
https://bugs.webkit.org/show_bug.cgi?id=54930
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 22 Feb 2011 03:57:28 +0000 (03:57 +0000)]
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
GIFImageDecoder::setSize() tries to override the superclass method but fails
https://bugs.webkit.org/show_bug.cgi?id=54305
The superclass uses unsigned instead of int for its parameters, so
GIFImageDecoder::setSize() was an overload, not an override.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setSize):
* platform/image-decoders/gif/GIFImageDecoder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 22 Feb 2011 03:44:54 +0000 (03:44 +0000)]
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
This patch changes a test to work around a bug in PrettyPatch where
it will crash if lines starting with "--" are missing from the actual
output. The actual fix needed to PrettyPatch is described in the
bug.
https://bugs.webkit.org/show_bug.cgi?id=54918
* platform/mac/fast/objc/dom-html-select-activate-expected.txt:
* platform/mac/fast/objc/dom-html-select-activate.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 22 Feb 2011 03:38:28 +0000 (03:38 +0000)]
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] avoid overriding ctrl/cmd + r
https://bugs.webkit.org/show_bug.cgi?id=54852
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 22 Feb 2011 03:31:35 +0000 (03:31 +0000)]
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kent Tamura.
nrwt: revert behavior on 10.5 to "old-threads". It's possible
that r79062 has introduced a bunch of flakiness, although I
can't explain why right now. This change should restore the
old behavior, and then we can look at the build logs to see
if the tests stop timing out or being flaky.
https://bugs.webkit.org/show_bug.cgi?id=54925
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 22 Feb 2011 02:28:19 +0000 (02:28 +0000)]
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
https://bugs.webkit.org/show_bug.cgi?id=54528
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::init): Allows style to be a null pointer.
(WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of
-webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement
to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property.
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto.
(WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
(WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because
ApplyStyleCommand::applyInlineStyle already does it.
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
(WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
* editing/EditingStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 22 Feb 2011 02:14:10 +0000 (02:14 +0000)]
<webkit.org/b/54919> / <rdar://problem/
7689300> WebCore should retrieve unclamped frame delays from ImageIO
Reviewed by Darin Adler and Alexey Proskuryakov.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 22 Feb 2011 02:08:08 +0000 (02:08 +0000)]
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
[chromium] ChromePluginPrintContext::begin() fails to override superclass method
https://bugs.webkit.org/show_bug.cgi?id=54914
Update subclass method signature to match superclass again. This
regressed in http://trac.webkit.org/changeset/71964
* src/WebFrameImpl.cpp:
(WebKit::ChromePluginPrintContext::begin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 02:07:26 +0000 (02:07 +0000)]
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Disabled "BUGWK54322 MAC SNOWLEOPARD" lines, which sesms no longer needed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 22 Feb 2011 02:01:26 +0000 (02:01 +0000)]
Fix Windows build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 22 Feb 2011 01:43:39 +0000 (01:43 +0000)]
Set and update the window title for the Web Inspector in WebKit2.
https://webkit.org/b/50945
rdar://problem/
8762410
Reviewed by Adam Roben.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.
* WebProcess/WebPage/WebInspector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 22 Feb 2011 01:40:17 +0000 (01:40 +0000)]
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt clenaup.
Removed disabled lines which I commented out.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 22 Feb 2011 01:27:09 +0000 (01:27 +0000)]
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
* fast/html/tabindex-removal-expected.txt: Added.
* fast/html/tabindex-removal.html: Added.
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
Test: fast/html/tabindex-removal.html
* dom/Node.cpp:
(WebCore::Node::clearTabIndexExplicitly):
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::NodeRareData::clearTabIndexExplicitly):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 22 Feb 2011 01:23:04 +0000 (01:23 +0000)]
Reviewed by Mark Rowe.
<rdar://problem/
8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods
* platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 22 Feb 2011 01:22:18 +0000 (01:22 +0000)]
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations update.
Removed fast/js/kde/math.html because it has been passing since r79246.
Removed fast/text/capitalize-boundaries.html on Mac and Windows because it has been steadily passing.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 22 Feb 2011 01:18:23 +0000 (01:18 +0000)]
2011-02-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Overhang areas need to be invalidated on scroll
<rdar://problem/
9032194>
https://bugs.webkit.org/show_bug.cgi?id=54917
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
We need to explicitly invalidate the overhang areas when we scroll the contents
of a ScrollView, since they could contain arbitrary content that cannot be blitted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Tue, 22 Feb 2011 01:01:33 +0000 (01:01 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Tue, 22 Feb 2011 00:56:44 +0000 (00:56 +0000)]
Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
Reviewed by Stephanie Lewis.
No new tests required.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Tue, 22 Feb 2011 00:13:58 +0000 (00:13 +0000)]
Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905
Reviewed by Darin Adler.
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 21 Feb 2011 23:57:25 +0000 (23:57 +0000)]
Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/
8978624>
Reviewed by Anders Carlsson.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 21 Feb 2011 23:47:22 +0000 (23:47 +0000)]
2011-02-18 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
https://bugs.webkit.org/show_bug.cgi?id=54771
Now that video is accelerated, we no longer need to special case
video playing within a media document.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 21 Feb 2011 23:42:59 +0000 (23:42 +0000)]
Fix linker warning on Windows
r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.
Rubber-stamped by Anders Carlsson.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 Feb 2011 23:34:03 +0000 (23:34 +0000)]
2011-02-21 Ami Fischman <fischman@chromium.org>
Reviewed by Eric Carlson.
Add regression test for clean shutdown during video playback.
DumpRenderTree used to crash if the test was ended while a video
was still playing. (http://crbug.com/72730).
https://bugs.webkit.org/show_bug.cgi?id=54888
* media/video-plays-past-end-of-test-expected.txt: Added.
* media/video-plays-past-end-of-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 21 Feb 2011 23:29:37 +0000 (23:29 +0000)]
2011-02-21 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Initialize DrawingAreaProxy::m_size
https://bugs.webkit.org/show_bug.cgi?id=54913
This was removed in r76962 since it caused flashes when switching drawing areas due to
entering and exiting composited mode, but since we no longer switch drawing areas we can
put it back.
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 21 Feb 2011 23:21:06 +0000 (23:21 +0000)]
Add some assertions about the state IDs we receive from the web process
Rubber-stamped by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 21 Feb 2011 23:20:35 +0000 (23:20 +0000)]
Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".
As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.
This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:
- Messages::DrawingArea::SetSize -> UpdateState
- Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
- DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
- DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
- DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
- DrawingAreaImpl::m_inSetSize -> m_inUpdateState
- generateSequenceNumber -> generateStateID
- sequenceNumber -> stateID
Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Performed the renames described above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 21 Feb 2011 22:47:03 +0000 (22:47 +0000)]
Reviewed by Adam Roben.
REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/
9006592>
WebCore:
It's now possible to set a default timeout to be used at ResourceRequest creation. If one
hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
or use INT_MAX on other platforms).
* WebCore.exp.in:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of
default timeout interval (may be 0 if using NSURLRequest default).
(WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable.
(WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource
request is updated. Plaform code often calls updateResourceRequest() indirectly from this
function, and that must obviously be a no-op.
(WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite
direction.
* platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to
"defaultTimeoutInterval". It has been used as default by most platforms anyway.
(WebCore::ResourceRequestBase::ResourceRequestBase):
* platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither
setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.
WebKit2:
* Shared/API/c/WKURLRequest.cpp:
(WKURLRequestSetDefaultTimeoutInterval):
* Shared/API/c/WKURLRequest.h:
Added an API to set a default timeout interval for requests created from URLs. The API
affects both the UI process and requests created internally by the Web process. Requests
created from NSURLRequest or CFURLRequest take timeout from those.
* Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
* Shared/WebURLRequest.h:
Pipe the default timeout interval from WKURLRequest down to actual implementation. Since
WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects
NSURLRequest default timeout interval.
* UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
* UIProcess/WebProcessManager.h:
Added a way to enumerate all contexts running in separate processes.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::setDefaultRequestTimeoutInterval):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setDefaultRequestTimeoutInterval):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Use UI process default timeout interval in separate process contexts, too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 21 Feb 2011 22:26:56 +0000 (22:26 +0000)]
Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/
8971738>
Reviewed by Adam Roben.
Add a new use flag for using the CFURLCache.
* wtf/Platform.h:
Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/
8971738>
Reviewed by Adam Roben.
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add
create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.
(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for
the origin's hostname.
* WebProcess/ResourceCache/WebResourceCacheManager.h:
* WebProcess/ResourceCache/cf: Added.
* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.
* win/WebKit2.vcproj: Added new file.
* WebKit2.xcodeproj/project.pbxproj: Ditto.
WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/
8971738>
Reviewed by Adam Roben.
Update WebKitSystemInterface headers and libraries with new functions.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 21 Feb 2011 22:21:13 +0000 (22:21 +0000)]
Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl
DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.
Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.
When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.
The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.
This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.
This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).
Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.
* WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.
* WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to
match the base class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 21 Feb 2011 22:02:31 +0000 (22:02 +0000)]
Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.
Rubber-stamped by Dan Bernstein.
* WebKitSystemInterface.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 21 Feb 2011 21:35:26 +0000 (21:35 +0000)]
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Update the results for this test which now includes a few more passing
lines. We maintain separate results, because we seem to pass more tests
than other platforms.
* platform/gtk/Skipped: Unskip a test which is now passing.
* platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Correct the GTK+ clipboard implementation to know that "text" is an alias
for "text/html" data. This corrects the failing test.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text".
(WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 21 Feb 2011 21:23:57 +0000 (21:23 +0000)]
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
nrwt: fix typo causing us to try and repeatedly shut down the servers
https://bugs.webkit.org/show_bug.cgi?id=54904
* Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 21 Feb 2011 21:14:57 +0000 (21:14 +0000)]
2011-02-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=54901
* jit/JIT.h: swap actual and expected values in message, they were
reversed.
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of
a simple ASSERT.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check): ditto.
(JSC::JIT::compileGetByIdHotPath): ditto.
(JSC::JIT::compileGetByIdSlowCase): ditto.
(JSC::JIT::emit_op_put_by_id): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 21 Feb 2011 20:46:50 +0000 (20:46 +0000)]
Ruber stamped by Sam Weinig
Bug 54899 - Math.LOG10E should be 0.
4342944819032518
This value is quoted in section 15.8.1.5 of the spec.
Source/JavaScriptCore:
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
LayoutTests:
* fast/js/kde/math-expected.txt:
* fast/js/kde/script-tests/math.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 Feb 2011 20:30:51 +0000 (20:30 +0000)]
2011-02-21 Anna Cavender <annacc@timberline.sea.corp.google.com>
Reviewed by Eric Carlson.
new baselines for video-transformed.html on mac
https://bugs.webkit.org/show_bug.cgi?id=54765
* platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
* platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
* platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 Feb 2011 19:58:59 +0000 (19:58 +0000)]
2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
ProcessingInstruction should provide a way to know if it is of CSS type.
https://bugs.webkit.org/show_bug.cgi?id=54868
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* dom/ProcessingInstruction.h:
(WebCore::ProcessingInstruction::isCSS):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 21 Feb 2011 19:55:31 +0000 (19:55 +0000)]
2011-02-21 Simon Fraser <simon.fraser@apple.com>
Put JSDOMImplementationCustom.cpp where it belongs in the project.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 21 Feb 2011 19:49:03 +0000 (19:49 +0000)]
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip
editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=54895
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 21 Feb 2011 19:33:23 +0000 (19:33 +0000)]
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 21 Feb 2011 19:31:42 +0000 (19:31 +0000)]
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
Reviewed by Sam Weinig.
The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.
Source/JavaScriptCore:
* API/JSCallbackConstructor.cpp:
* API/JSCallbackFunction.cpp:
* API/JSCallbackObjectFunctions.h:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
* runtime/BooleanObject.cpp:
* runtime/DateInstance.cpp:
* runtime/DatePrototype.cpp:
* runtime/ErrorInstance.cpp:
* runtime/InternalFunction.cpp:
* runtime/JSActivation.cpp:
* runtime/JSArray.cpp:
* runtime/JSFunction.cpp:
* runtime/JSONObject.cpp:
* runtime/JSObject.h:
* runtime/JSZombie.h:
* runtime/MathObject.cpp:
* runtime/NativeErrorConstructor.cpp:
* runtime/NumberConstructor.cpp:
* runtime/NumberObject.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.cpp:
* runtime/StringObject.cpp:
* runtime/StringPrototype.cpp:
Source/WebCore:
* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_object.cpp:
Source/WebKit2:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 Feb 2011 19:16:36 +0000 (19:16 +0000)]
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: skip new inspector test on wk2.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 21 Feb 2011 19:07:56 +0000 (19:07 +0000)]
Fix radar url.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 21 Feb 2011 19:06:54 +0000 (19:06 +0000)]
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Csaba Osztrogonác.
REGRESSION(r79157):
plugins/get-url-with-javascript-destroying-plugin.html make the
next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 21 Feb 2011 18:45:37 +0000 (18:45 +0000)]
2011-02-21 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Skip WebKit2 tests that need EventSender
https://bugs.webkit.org/show_bug.cgi?id=54890
These tests fail because EventSender is missing.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 21 Feb 2011 18:40:16 +0000 (18:40 +0000)]
Unreviewed.
REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
Bug was fixed by http://trac.webkit.org/changeset/79231.
* platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 Feb 2011 18:29:27 +0000 (18:29 +0000)]
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: navigation does not work after reopening frontend.
https://bugs.webkit.org/show_bug.cgi?id=54879
Test: http/tests/inspector-enabled/open-close-open.html
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::unmute):
* inspector/InspectorState.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 21 Feb 2011 18:03:36 +0000 (18:03 +0000)]
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Add results for tests missing results and unskip a test that
is passing locally and when run manually on the bots.
* platform/gtk/Skipped: Unskip tests that are now passing.
* platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
* platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
* platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
* platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
* platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
* platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
* platform/gtk/fast/runin/generated2-expected.checksum: Added.
* platform/gtk/fast/runin/generated2-expected.png: Added.
* platform/gtk/fast/runin/generated2-expected.txt: Added.
* platform/gtk/fast/runin/generated3-expected.checksum: Added.
* platform/gtk/fast/runin/generated3-expected.png: Added.
* platform/gtk/fast/runin/generated3-expected.txt: Added.
* platform/gtk/fast/runin/generated4-expected.checksum: Added.
* platform/gtk/fast/runin/generated4-expected.png: Added.
* platform/gtk/fast/runin/generated4-expected.txt: Added.
* platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
* platform/gtk/media/video-aspect-ratio-expected.png: Added.
* platform/gtk/media/video-aspect-ratio-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 21 Feb 2011 18:01:36 +0000 (18:01 +0000)]
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Unreviewed added more tests with pixel differences between bots.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 21 Feb 2011 17:48:50 +0000 (17:48 +0000)]
Protect the PluginView when evaluating javascript: URLs
Fixes <http://webkit.org/b/54884> <rdar://problem/
9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added
Reviewed by Sam Weinig.
* plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 21 Feb 2011 17:44:40 +0000 (17:44 +0000)]
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Fix GTK+ build after r79223.
* GNUmakefile.am: Add file missing from the source list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 21 Feb 2011 17:35:47 +0000 (17:35 +0000)]
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: audits should not warn about gzip compression for 304s
https://bugs.webkit.org/show_bug.cgi?id=54343
Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Mon, 21 Feb 2011 17:25:37 +0000 (17:25 +0000)]
Unreviewed expectations change to mark tests as timing out.
Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Mon, 21 Feb 2011 16:36:45 +0000 (16:36 +0000)]
Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.
Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 21 Feb 2011 16:36:39 +0000 (16:36 +0000)]
Another followup to 79223: correct QT project file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 21 Feb 2011 16:18:05 +0000 (16:18 +0000)]
Followup to 79223: forgotten file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 21 Feb 2011 16:13:35 +0000 (16:13 +0000)]
2011-02-21 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement WorkQueue::sheduleWorkAfterDelay
https://bugs.webkit.org/show_bug.cgi?id=54878
* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::scheduleWorkAfterDelay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 21 Feb 2011 16:01:41 +0000 (16:01 +0000)]
2011-02-08 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.
Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.
* Android.jscbindings.mk:
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/V8GCController.cpp:
(WebCore::NodeGrouperVisitor::visitDOMWrapper):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::DOMImplementation):
(WebCore::DOMImplementation::createDocument):
* dom/DOMImplementation.h:
(WebCore::DOMImplementation::create):
(WebCore::DOMImplementation::documentDestroyed):
(WebCore::DOMImplementation::parentDocument):
* dom/DOMImplementation.idl:
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::implementation):
* dom/Document.h:
2011-02-21 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
Additional test which checks case when parent document can be collected while
its implementation is alive.
* fast/dom/gc-9.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 21 Feb 2011 15:55:45 +0000 (15:55 +0000)]
Export JSObject::s_info from JavaScriptCore.dll
This matches what we do for all other ClassInfo objects that WebCore needs access to.
Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows
Reviewed by Sam Weinig.
* runtime/JSObject.h: Added JS_EXPORTDATA to s_info.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log