eric@webkit.org [Sat, 21 Nov 2009 15:50:16 +0000 (15:50 +0000)]
2009-11-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
https://bugs.webkit.org/show_bug.cgi?id=31767
What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.
* Scripts/bugzilla-tool:
- Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
* Scripts/modules/commands/queues.py:
- Use tool.path() instead of __file__.
* Scripts/modules/multicommandtool.py:
- Add a new path() method to MultiComandTool.
* Scripts/modules/multicommandtool_unittest.py:
- Provide a path() method. Little point in testing this mock implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 15:37:56 +0000 (15:37 +0000)]
2009-11-21 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.
* Scripts/modules/commands/download.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 15:29:00 +0000 (15:29 +0000)]
2009-11-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert check-style to use LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31763
Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.
* Scripts/modules/commands/download.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 21 Nov 2009 04:50:21 +0000 (04:50 +0000)]
DOMElement::tagName() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31746
Reviewed by Darin Adler.
* DOMCoreClasses.cpp:
(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 21 Nov 2009 04:50:05 +0000 (04:50 +0000)]
DOMNode::childNodes() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31745
Reviewed by Darin Adler.
* DOMCoreClasses.cpp:
(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 04:06:06 +0000 (04:06 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Unit test query commands
https://bugs.webkit.org/show_bug.cgi?id=31755
These tests are pretty rough, but hopefully they'll grow.
* Scripts/modules/commands/queries_unittest.py: Added.
* Scripts/modules/mock_bugzillatool.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 03:53:27 +0000 (03:53 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
https://bugs.webkit.org/show_bug.cgi?id=31758
* Scripts/modules/multicommandtool.py:
- Allow passing of explicit commands to MultiCommandTool.__init__
* Scripts/modules/multicommandtool_unittest.py:
- Use new Command.name naming system.
- Test Command auto-discovery.
* Scripts/modules/workqueue.py:
- bug_id no longer exists, use patch['bug_id'] instead.
* Scripts/modules/workqueue_unittest.py:
- WorkQueues require names now.
- should_proceed_with_work_item must return a patch object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 21 Nov 2009 03:29:38 +0000 (03:29 +0000)]
WAI-ARIA: add support for aria-owns
https://bugs.webkit.org/show_bug.cgi?id=31702
Reviewed by Beth Dakin.
WebCore:
Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.
Test: platform/mac/accessibility/aria-owns.html
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIAOwns):
(WebCore::AccessibilityObject::ariaOwnsElements):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::supportsARIAOwns):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLAttributeNames.in:
WebKitTools:
* DumpRenderTree/AccessibilityUIElement.cpp:
(ariaOwnsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
LayoutTests:
* platform/mac/accessibility/aria-owns-expected.txt: Added.
* platform/mac/accessibility/aria-owns.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 03:14:51 +0000 (03:14 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix exception thrown when running the commit-queue.
* Scripts/modules/statusbot.py: patch is optional.
* Scripts/modules/workqueue.py: WorkQUeue requires a name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 21 Nov 2009 02:54:23 +0000 (02:54 +0000)]
Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.
Reviewed by Jon Honeycutt.
Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
* Interfaces/IWebSerializedJSValue.idl:
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 21 Nov 2009 02:36:38 +0000 (02:36 +0000)]
Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.
Reviewed by Dave Hyatt.
* Interfaces/IWebSerializedJSValue.idl:
* Interfaces/JavaScriptCoreAPITypes.idl:
* WebKit.vcproj/Interfaces.vcproj:
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 21 Nov 2009 02:07:15 +0000 (02:07 +0000)]
Make sure to export WebSerializedJSValue.
Reviewed by Darin Adler.
* WebKit.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 21 Nov 2009 01:54:59 +0000 (01:54 +0000)]
Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.
Reviewed by Dave Hyatt.
* Interfaces/IWebFrameLoadDelegate.idl:
* Interfaces/IWebSerializedJSValue.idl:
* Interfaces/JavaScriptCoreAPITypes.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 21 Nov 2009 01:44:04 +0000 (01:44 +0000)]
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
* css/mediaControls.css:
Define closed caption toggle button.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::updateControls):
Create closed caption toggle button in display order.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
Remove closed captions test from skipped list.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sat, 21 Nov 2009 01:34:22 +0000 (01:34 +0000)]
Not reviewed. Fix chromium build.
* public/WebAccessibilityRole.h:
(WebKit::):
* src/AssertMatchingEnums.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Sat, 21 Nov 2009 01:18:59 +0000 (01:18 +0000)]
2009-11-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Running code in the Console that ends with a
single line comment no longer produces a parse error.
* inspector/front-end/InjectedScript.js:
(InjectedScript._evaluateOn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 21 Nov 2009 01:17:18 +0000 (01:17 +0000)]
Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.
Reviewed by Oliver Hunt and Jon Honeycutt.
WebKit:
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
* WebView/WebSerializedJSValue.h: Added.
* WebView/WebSerializedJSValue.mm: Added.
(-[WebSerializedJSValue initWithValue:context:]):
(-[WebSerializedJSValue deserialize:]):
(-[WebSerializedJSValue dealloc]):
WebKit/win:
* Interfaces/IWebSerializedJSValue.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/WebKit.vcproj:
* WebSerializedJSValue.cpp: Added.
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 01:15:40 +0000 (01:15 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
* Scripts/modules/workqueue.py: Another typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 01:09:28 +0000 (01:09 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
* Scripts/modules/commands/queues.py: Fix silly typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 01:02:41 +0000 (01:02 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
* CommitQueueStatus/index.yaml:
- Add indices required for the new queries.
* CommitQueueStatus/queue_status.py:
- Add a patch-status page and move update_status to update-status.
- Only display "commit-queue" status records for the commit-queue.
- Add support for a queue_name property on status records.
- Fix _int_from_request to actually work.
* CommitQueueStatus/update_status.html:
- Add support for a queue_name on status records.
- Remove unused list of bug ids.
* Scripts/modules/commands/queues.py
- Make the queues pass the patch instead of the bug_id to StatusBot.
* Scripts/modules/statusbot.py:
- Support passing the queue_name to the status updates.
- Support fetching patch status with patch_status().
* Scripts/modules/workqueue.py:
- Pass the patch to the StatusBot instead of the bug_id.
- Let WorkQueues have a name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 00:15:23 +0000 (00:15 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move bugzilla-tool commands into their own file
https://bugs.webkit.org/show_bug.cgi?id=31752
This will let us write unit tests.
* Scripts/bugzilla-tool:
* Scripts/modules/commands/__init__.py: Added.
* Scripts/modules/commands/download.py: Added.
* Scripts/modules/commands/queries.py: Added.
* Scripts/modules/commands/queues.py: Added.
* Scripts/modules/commands/upload.py: Added.
* Scripts/modules/grammar.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 00:00:21 +0000 (00:00 +0000)]
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* platform/mac/accessibility/aria-grouping-roles-expected.txt:
* platform/mac/accessibility/aria-grouping-roles.html:
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 22:54:24 +0000 (22:54 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 22:52:47 +0000 (22:52 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Reviewed by Eric Seidel.
BuildQueue should check if the tree is currently buildable
https://bugs.webkit.org/show_bug.cgi?id=31744
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
* Scripts/modules/webkitlandingscripts.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 22:51:56 +0000 (22:51 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move prepare_clean_working_directory into the LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31743
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 20 Nov 2009 22:34:04 +0000 (22:34 +0000)]
Unreviewed fix.
Fix file names in the skipped list, for files added in http://trac.webkit.org/changeset/51257.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 20 Nov 2009 21:40:38 +0000 (21:40 +0000)]
NPN_ReloadPlugins does not reload the page even if reloadPages is true.
https://bugs.webkit.org/show_bug.cgi?id=30460
Reviewed by Kenneth Rohde Christiansen.
WebCore:
Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
It already refreshes plugins and reloads pages when necessary.
Tests: plugins/reloadplugins-and-pages.html
plugins/reloadplugins-no-pages.html
* plugins/PluginInfoStore.cpp:
(WebCore::refreshPlugins):
WebKitTools:
Added code for calling NPN_ReloadPlugins with reloadPages true and false.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvoke):
LayoutTests:
Added tests for calling NPN_ReloadPlugins with reloadPages being true and false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 20 Nov 2009 21:32:03 +0000 (21:32 +0000)]
<rdar://
7409188> WebKit needs to be able to serialize and deserialize objects.
Reviewed by Dave Hyatt.
Expose WebCore object serialization to WebKit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 21:29:12 +0000 (21:29 +0000)]
Fixes <http://webkit.org/b/31741>.
Web Inspector: User Entered Data on the console should show up no matter what filters.
Reviewed by Tim Hatcher.
Always show .console-user-command-result, no matter what the filter say
we should do with the other classes.
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 21:29:00 +0000 (21:29 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25381
Needs test: jQuery animation crashing Safari
Adding a regression test for a bug that doesn't reproduce in ToT.
* fast/dynamic/jQuery-animation-crash-expected.txt: Added.
* fast/dynamic/jQuery-animation-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 21:03:12 +0000 (21:03 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pass the port information to the child process
https://bugs.webkit.org/show_bug.cgi?id=31736
We need to do this so the child process knows what to build!
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
* Scripts/modules/webkitport.py:
* Scripts/modules/webkitport_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 20:26:49 +0000 (20:26 +0000)]
WebSocket tests still don't work on Windows, disabling for futher invesigation.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 19:55:45 +0000 (19:55 +0000)]
Fix a closing tag issue in the vcproj and remove tabs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 19:51:38 +0000 (19:51 +0000)]
Fixes <http://webkit.org/b/31700>.
Web Inspector: isMac should be in one central location + Cached.
Reviewed by Tim Hatcher.
We should cache the value of isMac, and make the indexOf call in one
single location, because we are calling it from multiple places, and saving
the result can save us time, and make the call sites simpler.
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._updateFilter):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.isMac):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 19:31:39 +0000 (19:31 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support Qt port in build-queue
https://bugs.webkit.org/show_bug.cgi?id=31733
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 19:22:46 +0000 (19:22 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement a build-queue
https://bugs.webkit.org/show_bug.cgi?id=31725
Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 19:22:07 +0000 (19:22 +0000)]
Enabling WebSocket tests on Windows - let's see if they pass after the recent fixes.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Nov 2009 19:19:05 +0000 (19:19 +0000)]
2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
Removed .DS_Store accidentally added in last (r51245).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Nov 2009 19:11:32 +0000 (19:11 +0000)]
2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add Console Only Layout Mode
https://bugs.webkit.org/show_bug.cgi?id=30282
Adds a Console Panel, which allows for a Full size Console. This
extends the Drawer to the size of a Panel. This also fixes previous
resize issues with the Drawer.
* inspector/front-end/ConsolePanel.js: added.
(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.set visibleView):
(WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
(WebInspector.Drawer.prototype.enterPanelMode):
(WebInspector.Drawer.prototype.exitPanelMode):
(WebInspector.Drawer.prototype.immediatelyExitPanelMode):
(WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._animationDuration):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):
Miscellaneous changes and cleanup.
* English.lproj/localizedStrings.js: "Console" toolbar title.
* inspector/front-end/ConsoleView.js: removed unnecessary element reordering
* inspector/front-end/Images/consoleIcon.png: added.
* inspector/front-end/inspector.css: added icon.
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels): create console panel
(WebInspector.windowResize): resize drawer if necessary
(WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
(WebInspector.animateStyle): start animation interval, returns the interval key
(WebInspector.toggleAttach): resize drawer if necessary
(WebInspector.showConsolePanel): restore the panel when the inspector restarts
(WebInspector.showProfileForURL): style fix
Restore the panel when the inspector restarts.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::specialPanelForJSName):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::showPanel):
Build files.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/WebKit.qrc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 19:06:02 +0000 (19:06 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make commit-queue and style-queue show up in help
https://bugs.webkit.org/show_bug.cgi?id=31724
We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 18:57:50 +0000 (18:57 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement bugzilla-tool build-attachment
https://bugs.webkit.org/show_bug.cgi?id=31722
This command builds an attachment from bugzilla. It leaves the built
patch in the working copy.
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
* Scripts/modules/webkitlandingscripts.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 18:40:57 +0000 (18:40 +0000)]
Fixes <http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().
Reviewed by Tim Hatcher.
Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._updateFilter):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
* inspector/front-end/inspector.js:
(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 17:53:27 +0000 (17:53 +0000)]
2009-11-20 Victor Wang <victorw@chromium.org>
Reviewed by Darin Adler.
Add expected pixel result for layout test input-file-re-render
https://bugs.webkit.org/show_bug.cgi?id=31696
* platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
* platform/mac/fast/forms/input-file-re-render-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 20 Nov 2009 17:49:15 +0000 (17:49 +0000)]
2009-11-20 Dirk Schulze <krit@webkit.org>
Unreviewed build fix for filters enabled builds.
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* svg/graphics/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::applyFilter):
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 17:45:30 +0000 (17:45 +0000)]
2009-11-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT release event does not create the state correctly
https://bugs.webkit.org/show_bug.cgi?id=31717
* WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 20 Nov 2009 17:27:01 +0000 (17:27 +0000)]
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7389945> QTKit based media engine should not claim to support
fullscreen on Leopard
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::supportsFullscreen):
Only return true on SnowLeopard for now.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
No need to special case MediaFullscreenButtonPart as the default implementation
asks the media engine if it supports fullscreen.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7389945> QTKit based media engine should not claim to support fullscreen on Leopard
Update test results.
* platform/mac/media/audio-controls-rendering-expected.checksum:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/audio-controls-rendering-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 14:54:34 +0000 (14:54 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
MultiCommandTool should find Command objects automatically instead of with a manual list
https://bugs.webkit.org/show_bug.cgi?id=31710
* Scripts/bugzilla-tool:
* Scripts/modules/multicommandtool.py:
- Use some wild python-fu to crawl all the known subclasses of Command.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 14:45:35 +0000 (14:45 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Added missing import.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 14:44:03 +0000 (14:44 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. I failed to update LandingSequence.test
properly.
* Scripts/modules/landingsequence.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
girish@forwardbias.in [Fri, 20 Nov 2009 11:18:31 +0000 (11:18 +0000)]
[Qt] Implement support for rendering plugins on Qt/Mac when a page is used
without a QWebView or when inside QGraphicsWebView.
Reviewed by Simon Hausmann.
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
Girish Ramakrishnan <girish@forwardbias.in>
Currently, the code provides the cgcontext of the PlatformPluginWidget to
the plugin. This approach does not work when we are printing, or using
QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
of the QPaintDevice's context.
To solve all cases and keep the code simple, we render the plugin to an
offscreen pixmap in all cases. This way, the plugin always renders to the
CGContext of the pixmap and we then use QPainter to blit the pixmap into
the QPaintDevice. We also create a fake window and set it's WindowRef in
NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
Now, that's the theory. In practice, ATM, mouse events do not work when using
the fake window. So, setPlatformPluginWidget() is still called when using QWebView
so that there are no regressions after this patch. Once we get mouse events
working, setPlatformPluginWidget will be removed.
https://bugs.webkit.org/show_bug.cgi?id=31183
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 09:01:02 +0000 (09:01 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Create LandingSequence as the all-sing, all-dance landing class
https://bugs.webkit.org/show_bug.cgi?id=31709
Client can inherit from this class to carefully control exactly which
steps they wish to have happen in the landing sequence.
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py: Added.
* Scripts/modules/webkitlandingscripts.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 07:01:26 +0000 (07:01 +0000)]
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
https://bugs.webkit.org/show_bug.cgi?id=31707
This is to help when we implement build-attachment.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 06:43:40 +0000 (06:43 +0000)]
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support Qt port in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31701
Now we support building with Qt!
* Scripts/bugzilla-tool:
* Scripts/modules/webkitport.py: Added.
* Scripts/modules/webkitport_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 06:20:51 +0000 (06:20 +0000)]
2009-11-19 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Adam Barth.
Remove inserting stderr into patch in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=29914
Modify SCM python module's run_command function to avoid return of stderr
by default, so stderr won't be inserted into the patches.
Modify the related unit test.
* Scripts/modules/scm.py:
* Scripts/modules/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Nov 2009 06:17:30 +0000 (06:17 +0000)]
2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Resync Resources Backend and Frontend
https://bugs.webkit.org/show_bug.cgi?id=31705
* inspector/front-end/Resource.js: resync enum values with backend
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 06:03:15 +0000 (06:03 +0000)]
2009-11-19 Steve Block <steveblock@google.com>
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
* wtf/Platform.h: Modified. Added Android-specific configuration.
2009-11-19 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
Build change only. No new tests possible.
* config.h: Modified. Added Android-specific configuration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Fri, 20 Nov 2009 05:44:06 +0000 (05:44 +0000)]
2009-11-20 Roland Steiner <rolandsteiner@chromium.org>
WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
Test: fast/ruby/ruby-text-indent.html
* css/html.css: reset text-indent on <ruby> and <rt> elements
LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
* fast/ruby/ruby-text-indent-expected.txt: Added.
* fast/ruby/ruby-text-indent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 02:18:44 +0000 (02:18 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs per-command help
https://bugs.webkit.org/show_bug.cgi?id=31697
Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.
* Scripts/modules/multicommandtool.py:
* Scripts/modules/multicommandtool_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 02:12:21 +0000 (02:12 +0000)]
Fixes <http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.
Reviewed by Darin Adler.
Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 01:09:49 +0000 (01:09 +0000)]
2009-11-19 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Make chromium/webkit/glue/FormFieldValues use the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31650
* public/WebElement.h:
* public/WebFormElement.h:
* public/WebInputElement.h:
(WebKit::WebInputElement::):
* public/WebNode.h:
* src/AssertMatchingEnums.cpp:
* src/DOMUtilitiesPrivate.cpp:
(WebKit::nameOfInputElement):
* src/DOMUtilitiesPrivate.h:
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::autofill):
(WebKit::EditorClientImpl::doAutofill):
* src/WebFormElement.cpp:
(WebKit::WebFormElement::name):
(WebKit::WebFormElement::method):
(WebKit::WebFormElement::getNamedElements):
(WebKit::WebFormElement::getInputElements):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isEnabledFormControl):
(WebKit::WebInputElement::inputType):
(WebKit::WebInputElement::formControlType):
(WebKit::WebInputElement::value):
(WebKit::WebInputElement::dispatchFormControlChangeEvent):
(WebKit::WebInputElement::setSelectionRange):
(WebKit::WebInputElement::name):
(WebKit::WebInputElement::nameForAutofill):
* src/WebNode.cpp:
(WebKit::WebNode::frame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 00:55:19 +0000 (00:55 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move MultiCommandTool and Command into a separate file and add some basic unit tests
https://bugs.webkit.org/show_bug.cgi?id=31695
* Scripts/bugzilla-tool:
* Scripts/modules/multicommandtool.py: Added.
* Scripts/modules/multicommandtool_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 00:53:38 +0000 (00:53 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows
* WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
* platform/network/ResourceHandle.h: Removed loaderRunLoop().
* platform/network/cf/LoaderRunLoopCF.cpp: Added.
(WebCore::emptyPerform):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):
* platform/network/cf/LoaderRunLoopCF.h: Added.
Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
it's needed for more than just resource loading.
* platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
* platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
* platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
main thread.
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
inoperable main run loop.
(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 00:47:08 +0000 (00:47 +0000)]
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Quick style fix.
https://bugs.webkit.org/show_bug.cgi?id=27777
* platform/graphics/cg/PDFDocumentImage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 00:30:34 +0000 (00:30 +0000)]
Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 20 Nov 2009 00:25:38 +0000 (00:25 +0000)]
Build fix. No review needed.
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 20 Nov 2009 00:02:16 +0000 (00:02 +0000)]
Build fix. No review needed.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:58:41 +0000 (23:58 +0000)]
Build fix. No review needed.
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
* platform/graphics/qt/StillImageQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:53:33 +0000 (23:53 +0000)]
Build fix. No review needed.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:50:18 +0000 (23:50 +0000)]
Build fix. No review needed.
* plugins/PluginView.cpp:
(WebCore::PluginView::paintMissingPluginIcon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:46:49 +0000 (23:46 +0000)]
Build fix. No review needed.
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:38:24 +0000 (23:38 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
No review, just adding a FIXME.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
* Scripts/bugzilla-tool: Add an extra comment about current design failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:36:58 +0000 (23:36 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
color-correction work with untagged images
Reviewed by Darin Adler.
Image's draw(), drawPattern(), and fillWithSolidColor() functions
now take a ColorSpace. A bunch of classes inherit from Image, so
draw() and drawPattern() functions there must also take a
ColorSpace.
* platform/graphics/Image.cpp:
(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
* platform/graphics/BitmapImage.h:
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::draw):
(WebCore::GeneratedImage::drawPattern):
* platform/graphics/GeneratedImage.h:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::draw):
* platform/graphics/cg/PDFDocumentImage.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
* svg/graphics/SVGImage.h:
All of the drawImage() functions and drawTiled() functions of
GraphicsContext now take a ColorSpace.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
This is where the actual work is done.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::imageWithColorSpace): New static function that returns a
copy of the given image in the given ColorSpace *IF* we should use
the given ColorSpace. We will ignore the color space if the image
is tagged and return 0.
(WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
call imageWithColorSpace().
(WebCore::Image::drawPattern): Same.
Attempt to keep all ports building.
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/haiku/ImageHaiku.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::drawPattern):
Callers of GraphicsContext's drawImage() and drawTiled() functions
now need to send a ColorSpace.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintResizer):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* svg/graphics/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::applyFilter):
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31321 Make
-webkit-color-correction work with untagged images
Reviewed by Darin Adler.
* fast/css/color-correction-on-background-image.html: Added.
* fast/css/color-correction-untagged-images.html: Added.
* fast/css/resources/purple-noprofile.png: Added.
* platform/mac/fast/css/color-correction-on-background-image-expected.checksum: Added.
* platform/mac/fast/css/color-correction-on-background-image-expected.png: Added.
* platform/mac/fast/css/color-correction-on-background-image-expected.txt: Added.
* platform/mac/fast/css/color-correction-untagged-images-expected.checksum: Added.
* platform/mac/fast/css/color-correction-untagged-images-expected.png: Added.
* platform/mac/fast/css/color-correction-untagged-images-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 19 Nov 2009 23:32:05 +0000 (23:32 +0000)]
isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
https://bugs.webkit.org/show_bug.cgi?id=31693
Reviewed by David Levin.
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michelangelo@webkit.org [Thu, 19 Nov 2009 23:30:56 +0000 (23:30 +0000)]
2009-11-19 Michelangelo De Simone <michelangelo@webkit.org>
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>
Files missed when landing patch.
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:28:59 +0000 (23:28 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
* Scripts/bugzilla-tool:
- Add new MultiCommandTool class to contain option parsing and help printing logic.
- Rename private methods to use _ pattern.
- MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
-
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:21:03 +0000 (23:21 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Re-factor help printing to use modern python idioms
https://bugs.webkit.org/show_bug.cgi?id=31685
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:12:56 +0000 (23:12 +0000)]
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Properly create a CGImageRef on non-PLATFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=27777
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::sharedBufferGetBytesAtPosition):
(WebCore::sharedBufferRelease):
(WebCore::ImageSource::setData):
* platform/graphics/cg/ImageSourceCG.h:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::dataChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Nov 2009 22:16:50 +0000 (22:16 +0000)]
Trying to enable WebSocket tests on Tiger again, as the bot seems to behave now.
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 19 Nov 2009 22:04:51 +0000 (22:04 +0000)]
-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
https://bugs.webkit.org/show_bug.cgi?id=31656
Reviewed Dave Hyatt
Make sure we're a child of the painting root before drawing overflow features.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 19 Nov 2009 21:29:47 +0000 (21:29 +0000)]
Not reviewed, attempt to fix Chromium build.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 21:02:30 +0000 (21:02 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
commit-queue empty queue logs twice
https://bugs.webkit.org/show_bug.cgi?id=31679
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 20:28:09 +0000 (20:28 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
bugzilla-tool's reviewer/committer rejection message should be clearer
https://bugs.webkit.org/show_bug.cgi?id=31126
Add more explanatory prose to bugzilla-tool's flag permission rejection message.
* Scripts/modules/bugzilla.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 20:25:19 +0000 (20:25 +0000)]
2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Darin Adler.
Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652
* fast/lists/ol-start-roman.html: Added.
* platform/mac/fast/lists/ol-start-roman-expected.txt: Added.
2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Darin Adler.
Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652
Test: fast/lists/ol-start-roman.html
* rendering/RenderListMarker.cpp:
(WebCore::toRoman): Increase the char array size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 19 Nov 2009 20:14:52 +0000 (20:14 +0000)]
Rubber-stamped by Oliver Hunt.
Add translatable strings to cover validationMessage, after
r51172. Already covered by existing test.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 20:12:40 +0000 (20:12 +0000)]
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(STRING_H) guard from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31668
* config.h:
* runtime/UString.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 19 Nov 2009 19:59:38 +0000 (19:59 +0000)]
Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=31657
* wtf/MessageQueue.h:
(WTF::MessageQueue::removeIf):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 19:54:50 +0000 (19:54 +0000)]
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.
* runtime/DatePrototype.cpp: Remove include directive
for float.h as it is included in MathExtras.h already.
* runtime/Operations.cpp: Ditto.
* runtime/UString.cpp: Ditto.
* wtf/dtoa.cpp: Ditto.
* wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
* wtf/Platform.h: Ditto.
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
WebCore has a dependency on float.h, there is
no need to guard float.h.
No new tests as there is no functional change.
* html/HTMLInputElement.cpp: Remove include directive
for float.h as it is included in MathExtras.h already.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 19:41:16 +0000 (19:41 +0000)]
2009-11-19 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Updated timeline paint test to ignore width and height. GTK+ testing
uses a different top level window size than other platforms.
https://bugs.webkit.org/show_bug.cgi?id=31402
* inspector/timeline-paint-expected.txt:
* inspector/timeline-test.js:
* platform/win/Skipped:
2009-11-19 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Forces a WM_PAINT event on calling layoutTestController.display()
in order to enable the timeline-paint.html test on Windows.
::UpdateWindow() does not force an event becaue the window is
not visible.
https://bugs.webkit.org/show_bug.cgi?id=31402
* DumpRenderTree/win/DumpRenderTree.cpp:
(displayWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 19:28:24 +0000 (19:28 +0000)]
2009-11-19 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
WAI-ARIA roles not supported on image map <area>
https://bugs.webkit.org/show_bug.cgi?id=31525
* accessibility/aria-used-on-image-maps-expected.txt: Added.
* accessibility/aria-used-on-image-maps.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 19 Nov 2009 19:03:02 +0000 (19:03 +0000)]
2009-11-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Pavel Feldman.
Instrumentation should account for painting in compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31674
Add calls to InspectorTimelineAgent for painting into compositing layers,
which is not accounted for in FrameView::paintContents().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
Avoid fetching the FrameView multiple times.
(WebCore::inspectorTimelineAgent):
(WebCore::RenderLayerBacking::paintContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michelangelo@webkit.org [Thu, 19 Nov 2009 18:21:46 +0000 (18:21 +0000)]
2009-11-19 Michelangelo De Simone <michelangelo@webkit.org>
No review needed.
Added myself to committers list.
* Scripts/modules/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 18:16:51 +0000 (18:16 +0000)]
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bugzilla-tool command classes should match command names
https://bugs.webkit.org/show_bug.cgi?id=31666
I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 19 Nov 2009 18:14:01 +0000 (18:14 +0000)]
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
Test: media/media-captions.html
* WebCore.base.exp:
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlTypeName):
Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Add MediaToggleClosedCaptionsButtonPart.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
Define and match mediaControlsToggleClosedCaptionsButton.
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Define and match PseudoMediaControlsToggleClosedCaptions.
* css/CSSValueKeywords.in:
Define and use media-toggle-closed-captions-button.
* css/mediaControls.css:
* css/mediaControlsQuickTime.css:
Add webkit-media-controls-toggle-closed-captions-button.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
Initialize m_closedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal):
Set m_closedCaptionsVisible to false.
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::closedCaptionsVisible):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
New, captions internal methods.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitHasClosedCaptions):
New, captions DOM API.
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
Declare methods needed for captions API.
* platform/ThemeTypes.h:
Add MediaToggleClosedCaptionsButtonPart.
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
Add empty implmentations.
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
(WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
New, empty implementations of media engine closed caption functions.
(WebCore::MediaPlayer::hasClosedCaptions):
(WebCore::MediaPlayer::setClosedCaptionsVisible):
New, call media engine closed caption functions.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
(WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
Declare new media engine methods.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::hasClosedCaptions):
(WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
New, QTKit implementation of closed caption methods.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement):
Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
New, implement the closed caption toggle button,
* rendering/MediaControlElements.h:
Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
declare MediaControlToggleClosedCaptionsButtonElement.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::styleDidChange):
(WebCore::RenderMedia::createToggleClosedCaptionsButton):
(WebCore::RenderMedia::createStatusDisplay):
(WebCore::RenderMedia::updateControls):
(WebCore::RenderMedia::forwardEvent):
* rendering/RenderMedia.h:
Deal with m_toggleClosedCaptionsButton.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
Deal with MediaToggleClosedCaptionsButtonPart.
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
Declare paintMediaToggleClosedCaptionsButton.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
New.
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't render captions toggle button unless we are using the new theme, the
movie has captions, and the movie is in a <video> element since we currently
rely on QTKit to render the captions.
* rendering/style/RenderStyleConstants.h:
Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* media/media-captions-expected.txt: Added.
* media/media-captions.html: Added.
* media/content/counting-captioned.mov: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/win/Skipped:
Skipped on platforms that don't support closed captions yet.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* English.lproj/Localizable.strings:
Add strings for toggle captions button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
Add QTMovieHasClosedCaptions and QTMovieSetShowClosedCaptions.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory localizedMediaControlElementString:]):
(-[WebViewFactory localizedMediaControlElementHelpText:]):
Add accessibility help strings for media controller closed caption button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* WebCoreLocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
Add accessibility help strings for media controller closed caption button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7035231>
Support closed caption in <video> element
* WebKitSystemInterface.h:
Add prototypes for WKQTMovieHasClosedCaptions and WKQTMovieSetShowClosedCaptions,
define WKMediaUIPartToggleClosedCaptionsButton.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 19 Nov 2009 18:10:05 +0000 (18:10 +0000)]
wx build fix. Add missing header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Nov 2009 17:43:30 +0000 (17:43 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31634
Ignore realm for proxy protection spaces
Only affects WebSocket proxy authentication, cannot be tested in DRT.
* platform/network/ProtectionSpace.cpp:
(WebCore::operator==):
* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 17:42:38 +0000 (17:42 +0000)]
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
https://bugs.webkit.org/show_bug.cgi?id=31669
* platform/gtk/Skipped:
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
https://bugs.webkit.org/show_bug.cgi?id=31669
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_show):
* webkit/webkitwebinspector.h:
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
https://bugs.webkit.org/show_bug.cgi?id=31669
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::showWebInspector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 19 Nov 2009 14:23:35 +0000 (14:23 +0000)]
Minor refactoring + more documentation.
Reviewed by Simon Hausmann.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::clearHistory):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 14:12:05 +0000 (14:12 +0000)]
2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add instantiation tests for QWebInspector.
* tests/qwebinspector/qwebinspector.pro: Added.
* tests/qwebinspector/tst_qwebinspector.cpp: Added.
(tst_QWebInspector::attachAndDestroy):
* tests/tests.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 14:04:26 +0000 (14:04 +0000)]
2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix QWebInspector destruction problem.
https://bugs.webkit.org/show_bug.cgi?id=31664
* Api/qwebpage.cpp:
(QWebPage::~QWebPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 19 Nov 2009 13:47:01 +0000 (13:47 +0000)]
[Qt] Normalize signal and slot signatures.
Patch by Olivier Goffart <ogoffart@trolltech.com> on 2009-11-19
Reviewed by Simon Hausmann.
WebCore:
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
WebKit/qt:
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
* Api/qwebview.cpp:
(QWebView::setPage):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setFrame):
* docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:
(wrapInFunction):
* tests/qwebframe/tst_qwebframe.cpp:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::modified):
(tst_QWebPage::database):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log