beidson [Fri, 30 Mar 2007 18:24:51 +0000 (18:24 +0000)]
Reviewed by Brian Dash
Fixes an intermittent failure in the port blocking layout test where
some sort of indeterminacy would change the error code the networking
layer reported.
* security/block-test-expected.txt:
* security/block-test.html: Use 255.255.255.255 instead of a bogus domain name
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 30 Mar 2007 18:13:54 +0000 (18:13 +0000)]
WebCore:
Reviewed by Darin.
Added DeleteWordBackward and DeleteWordForward to execCommand.
* editing/Editor.cpp:
(WebCore::execDeleteWordBackward):
(WebCore::execDeleteWordForward):
(WebCore::CommandEntry::):
WebKit:
Reviewed by Darin.
Call execCommand for deleteWordForward and deleteWordBackward instead of calling
deleteWithDirection directly.
* WebView/WebHTMLView.mm:
(-[WebHTMLView deleteWordForward:]):
(-[WebHTMLView deleteWordBackward:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 30 Mar 2007 18:10:53 +0000 (18:10 +0000)]
Build fix.
* bindings/NP_jsobject.cpp:
(_NPN_Enumerate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 30 Mar 2007 17:29:50 +0000 (17:29 +0000)]
JavaScriptCore:
Reviewed by Geoff.
Implement _NPN_Enumerate support.
* JavaScriptCore.exp:
* bindings/NP_jsobject.cpp:
(_NPN_Enumerate):
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames):
* bindings/c/c_instance.h:
* bindings/npapi.h:
* bindings/npruntime.h:
* bindings/npruntime_impl.h:
* bindings/runtime.h:
(KJS::Bindings::Instance::getPropertyNames):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::getPropertyNames):
* bindings/runtime_object.h:
(KJS::RuntimeObjectImp::getInternalInstance):
LayoutTests:
Reviewed by Geoff.
Add enumeration test.
* plugins/netscape-enumerate-expected.txt: Added.
* plugins/netscape-enumerate.html: Added.
WebKit:
Reviewed by Geoff.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
Initialize pushpopupsenabledstate, poppopupsenabledstate and enumerate.
* Plugins/npapi.m:
(NPN_PushPopupsEnabledState):
(NPN_PopPopupsEnabledState):
Add stubs for these functions.
* Plugins/npfunctions.h:
Add new methods to NPNetscapeFuncs.
WebKitTools:
Reviewed by Geoff.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add TestObject.c and TestObject.h
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
(pluginGetProperty):
Implement the testObject property.
(pluginInvoke):
Implement testEnumerate which takes an object and an array and enumerates
the properties of the object and adds them to the array.
(pluginAllocate):
Allocate the test object.
(pluginDeallocate):
Free the test object.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Added.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Added.
Add a test object with two enumerable properties.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 30 Mar 2007 15:33:11 +0000 (15:33 +0000)]
Fix Qt release builds
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 30 Mar 2007 12:55:51 +0000 (12:55 +0000)]
Reviewed by bdash.
Spotted an int that should be float in previous patch.
* platform/Font.cpp:
(WebCore::WidthIterator::advance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 30 Mar 2007 09:59:57 +0000 (09:59 +0000)]
Reviewed by Hyatt.
Render tree memory savings, part 1
- Eliminate caching of monospace char width from RenderText. This optimization is not needed
anymore since Font already caches space width (RenderText -4 bytes)
- Eliminate caching of tab width from RenderBlock. Similary this optimization has become
obsolete (RenderBlock -4 bytes)
* platform/Font.cpp:
(WebCore::WidthIterator::advance):
(WebCore::Font::spaceWidth):
* platform/Font.h:
(WebCore::Font::tabWidth):
* platform/TextStyle.h:
(WebCore::TextStyle::TextStyle):
(WebCore::TextStyle::allowTabs):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintMarkedTextBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/RenderBlock.cpp:
(WebCore:::RenderFlow):
(WebCore::RenderBlock::setStyle):
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::setStyle):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedMinMaxWidth):
(WebCore::RenderText::calcMinMaxWidthInternal):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::width):
* rendering/RenderText.h:
(WebCore::RenderText::allowTabs):
* rendering/bidi.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 30 Mar 2007 09:51:24 +0000 (09:51 +0000)]
Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency.
Reviewed by mitz
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 30 Mar 2007 03:17:50 +0000 (03:17 +0000)]
Layout test for <rdar://problem/
5061807>. (This one's for you, Boyscout!)
* fast/frames/remove-frame-with-scrollbars-crash-expected.txt: Added.
* fast/frames/remove-frame-with-scrollbars-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 30 Mar 2007 02:36:16 +0000 (02:36 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=13166
REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
* fast/tokenizer/write-partial-entity-expected.txt: Added.
* fast/tokenizer/write-partial-entity.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13166
REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
Test: fast/tokenizer/write-partial-entity.html
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position
after script execution which can write to the buffer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 30 Mar 2007 00:11:24 +0000 (00:11 +0000)]
LayoutTests:
Reviewed by john
<rdar://problem/
5099303> Deleting after a ToDo puts the caret in the wrong position
Tests for the bug:
* editing/deleting/
5099303-expected.checksum: Added.
* editing/deleting/
5099303-expected.png: Added.
* editing/deleting/
5099303-expected.txt: Added.
* editing/deleting/
5099303.html: Added.
Tests that extending an editable selection skips non-editable
content:
* editing/selection/
5099303-expected.checksum: Added.
* editing/selection/
5099303-expected.png: Added.
* editing/selection/
5099303-expected.txt: Added.
* editing/selection/
5099303.html: Added.
WebCore:
Reviewed by john
<rdar://problem/
5099303> Deleting after a ToDo puts the caret in the wrong position
We were failing to create the correct selection
for DeleteSelectionCommand because the selection extension
operations don't skip over non-editable content for editable
selections.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRightForward):
When extending an editable selection, don't extend into
non-editable content.
(WebCore::SelectionController::modifyExtendingLeftBackward):
Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 29 Mar 2007 23:26:30 +0000 (23:26 +0000)]
LayoutTests:
Reviewed by Beth Dakin.
Layout test for <rdar://problem/
5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)
* plugins/destroy-stream-twice-expected.txt: Added.
* plugins/destroy-stream-twice.html: Added.
WebKit:
Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.
Layout test for <rdar://problem/
5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)
Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
every time you run it.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView destroyStream:reason:]):
WebKitTools:
Reviewed by Beth Dakin.
Layout test for <rdar://problem/
5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)
Added hasStream property and destroyStream function, used by layout test.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
(pluginGetProperty):
(pluginInvoke):
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
(NPP_NewStream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Thu, 29 Mar 2007 23:24:41 +0000 (23:24 +0000)]
Rubber-stamped by Adam.
Keep OpenSource building.
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pyeh [Thu, 29 Mar 2007 23:24:05 +0000 (23:24 +0000)]
<rdar://problem/
4918397> Exception raise inspecting note contents in the background
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject subrole]):
(-[WebCoreAXObject title]):
Check that attachment supports the attribute before requesting it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 29 Mar 2007 23:16:44 +0000 (23:16 +0000)]
I forgot add this expected result in my previous checkin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Thu, 29 Mar 2007 23:13:03 +0000 (23:13 +0000)]
Reviewed by Brady.
Fix for <rdar://problem/
4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise
-and-
<rdar://problem/
4992521> Please adjust WebKit's Acrobat-workaround
methodology
The fix for the first bug is to compare against the bundle
identifiers for Adobe Reader and the non-Pro Adobe Acrobat in
addition to Adobe Acrobat Pro. The fix for the second bug is to
check the version number of Acrobat/Reader through
WebKitSystemInterface instead of checking which version of WebKit
it has been linked against.
* English.lproj/StringsNotToBeLocalized.txt: Two new bundle
identifiers.
* Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
* WebView/WebView.mm:
(-[WebView _updateWebCoreSettingsFromPreferences:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 29 Mar 2007 22:34:28 +0000 (22:34 +0000)]
LayoutTests:
Reviewed by john
<rdar://problem/
5032066> <Delete> should work between To Dos
Demonstrates the fix:
* editing/deleting/
5032066-expected.checksum: Added.
* editing/deleting/
5032066-expected.png: Added.
* editing/deleting/
5032066-expected.txt: Added.
* editing/deleting/
5032066.html: Added.
Fixed:
* editing/deleting/delete-block-table-expected.checksum:
* editing/deleting/delete-block-table-expected.png:
* editing/deleting/delete-block-table-expected.txt:
shouldInsertNode:... now being called during moves:
* editing/deleting/delete-
3857753-fix-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* editing/deleting/delete-block-merge-contents-001-expected.txt:
* editing/deleting/delete-block-merge-contents-002-expected.txt:
* editing/deleting/delete-block-merge-contents-003-expected.txt:
* editing/deleting/delete-block-merge-contents-004-expected.txt:
* editing/deleting/delete-block-merge-contents-005-expected.txt:
* editing/deleting/delete-block-merge-contents-006-expected.txt:
* editing/deleting/delete-block-merge-contents-007-expected.txt:
* editing/deleting/delete-block-merge-contents-008-expected.txt:
* editing/deleting/delete-block-merge-contents-009-expected.txt:
* editing/deleting/delete-block-merge-contents-010-expected.txt:
* editing/deleting/delete-block-merge-contents-012-expected.txt:
* editing/deleting/delete-block-merge-contents-013-expected.txt:
* editing/deleting/delete-block-merge-contents-014-expected.txt:
* editing/deleting/delete-block-merge-contents-015-expected.txt:
* editing/deleting/delete-block-merge-contents-016-expected.txt:
* editing/deleting/delete-block-merge-contents-017-expected.txt:
* editing/deleting/delete-block-merge-contents-018-expected.txt:
* editing/deleting/delete-block-merge-contents-019-expected.txt:
* editing/deleting/delete-block-merge-contents-020-expected.txt:
* editing/deleting/delete-block-merge-contents-021-expected.txt:
* editing/deleting/delete-block-merge-contents-022-expected.txt:
* editing/deleting/delete-br-010-expected.txt:
* editing/deleting/delete-line-002-expected.txt:
* editing/deleting/delete-line-004-expected.txt:
* editing/deleting/delete-line-006-expected.txt:
* editing/deleting/delete-line-007-expected.txt:
* editing/deleting/delete-line-008-expected.txt:
* editing/deleting/delete-line-011-expected.txt:
* editing/deleting/delete-line-012-expected.txt:
* editing/deleting/delete-listitem-001-expected.txt:
* editing/deleting/delete-to-end-of-paragraph-expected.txt:
* editing/deleting/merge-different-styles-expected.txt:
* editing/deleting/merge-no-br-expected.txt:
* editing/deleting/pruning-after-merge-1-expected.txt:
* editing/deleting/pruning-after-merge-2-expected.txt:
* editing/execCommand/create-list-from-range-selection-expected.txt:
* editing/execCommand/create-list-with-hr-expected.txt:
* editing/execCommand/format-block-expected.txt:
* editing/execCommand/format-block-from-range-selection-expected.txt:
* editing/execCommand/format-block-with-braces-expected.txt:
* editing/execCommand/format-block-with-trailing-br-expected.txt:
* editing/execCommand/indent-list-item-expected.txt:
* editing/execCommand/indent-selection-expected.txt:
* editing/execCommand/insert-list-and-stitch-expected.txt:
* editing/execCommand/insert-list-with-id-expected.txt:
* editing/execCommand/nsresponder-indent-expected.txt:
* editing/execCommand/outdent-selection-expected.txt:
* editing/execCommand/queryCommandState-01-expected.txt:
* editing/execCommand/remove-list-1-expected.txt:
* editing/execCommand/remove-list-from-range-selection-expected.txt:
* editing/execCommand/remove-list-item-1-expected.txt:
* editing/execCommand/remove-list-items-expected.txt:
* editing/execCommand/switch-list-type-expected.txt:
* editing/inserting/insert-
3907422-fix-expected.txt:
* editing/inserting/insert-div-026-expected.txt:
* editing/inserting/multiple-lines-selected-expected.txt:
* editing/inserting/return-key-with-selection-001-expected.txt:
* editing/inserting/return-key-with-selection-002-expected.txt:
* editing/pasteboard/
4076267-2-expected.txt:
* editing/pasteboard/
4700297-expected.txt:
* editing/pasteboard/8145-3-expected.txt:
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* editing/pasteboard/interchange-newline-1-expected.txt:
* editing/pasteboard/interchange-newline-2-expected.txt:
* editing/pasteboard/merge-after-delete-1-expected.txt:
* editing/pasteboard/merge-after-delete-2-expected.txt:
* editing/pasteboard/merge-after-delete-expected.txt:
* editing/pasteboard/merge-end-1-expected.txt:
* editing/pasteboard/merge-end-2-expected.txt:
* editing/pasteboard/merge-end-3-expected.txt:
* editing/pasteboard/merge-end-4-expected.txt:
* editing/pasteboard/merge-end-5-expected.txt:
* editing/pasteboard/merge-end-blockquote-expected.txt:
* editing/pasteboard/merge-end-borders-expected.txt:
* editing/pasteboard/merge-end-list-expected.txt:
* editing/pasteboard/merge-end-table-expected.txt:
* editing/pasteboard/paste-line-endings-007-expected.txt:
* editing/pasteboard/paste-line-endings-008-expected.txt:
* editing/pasteboard/paste-line-endings-009-expected.txt:
* editing/pasteboard/paste-match-style-001-expected.txt:
* editing/pasteboard/paste-text-002-expected.txt:
* editing/pasteboard/paste-text-003-expected.txt:
* editing/pasteboard/paste-text-004-expected.txt:
* editing/pasteboard/paste-text-005-expected.txt:
* editing/pasteboard/paste-text-006-expected.txt:
* editing/pasteboard/paste-text-008-expected.txt:
* editing/pasteboard/paste-text-009-expected.txt:
* editing/pasteboard/paste-text-010-expected.txt:
* editing/pasteboard/smart-paste-001-expected.txt:
* editing/pasteboard/smart-paste-002-expected.txt:
* editing/pasteboard/smart-paste-003-expected.txt:
* editing/pasteboard/smart-paste-004-expected.txt:
* editing/pasteboard/smart-paste-005-expected.txt:
* editing/pasteboard/smart-paste-006-expected.txt:
* editing/pasteboard/smart-paste-007-expected.txt:
* editing/pasteboard/smart-paste-008-expected.txt:
* editing/style/create-block-for-style-001-expected.txt:
* editing/style/create-block-for-style-002-expected.txt:
* editing/style/create-block-for-style-003-expected.txt:
* editing/style/create-block-for-style-004-expected.txt:
* editing/style/create-block-for-style-007-expected.txt:
* editing/style/create-block-for-style-009-expected.txt:
* editing/style/create-block-for-style-010-expected.txt:
* editing/style/create-block-for-style-011-expected.txt:
* editing/style/create-block-for-style-012-expected.txt:
* editing/style/create-block-for-style-013-expected.txt:
* editing/style/smoosh-styles-001-expected.txt:
* editing/style/smoosh-styles-002-expected.txt:
* editing/style/style-boundary-005-expected.txt:
* editing/unsupported-content/list-delete-001-expected.txt:
WebCore:
Reviewed by john
<rdar://problem/
5032066> Delete should work between ToDos
Stop selecting the table when the user attempts to delete
the line break just after it, instead, extend the selection
into the last table cell.
Let deletion merge content into table cells (as long as
its not from another table cell).
Start calling shouldInsertNode:replacingDOMRange:givenAction:
when moving content with moveParagraphs, so that Mail can
modify content before it is moved into a ToDo during a delete.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Ask the
delegate before performing the move. This will let Mail
prevent styles from entering a ToDo.
Added a FIXME about adding a new WebViewInsertAction
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializePositionData):
Allow merging into table cells from content not in a table.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRightForward):
Don't select the table when extending by character/word from
just before it. This code was here to make it easier to select
tables in order to delete them, but the deletion UI makes it
largely unnecessary.
(WebCore::SelectionController::modifyExtendingLeftBackward):
Ditto.
* editing/TypingCommand.cpp:
(WebCore::isFirstPositionAfterTable): Added.
(WebCore::isLastPositionBeforeTable): Ditto.
(WebCore::TypingCommand::deleteKeyPressed): When pressing
the delete key with a caret at the beginning of a paragraph
just after a table, move the paragraph into the last table
cell.
Do not do this if it would mean moving a block table.
Removed some old irrelevant comments.
* editing/htmlediting.cpp: Removed unused functions.
* editing/htmlediting.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 29 Mar 2007 22:14:49 +0000 (22:14 +0000)]
Build fix for Leopard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 29 Mar 2007 19:00:27 +0000 (19:00 +0000)]
Add a comment since our current fix is not really acceptable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 29 Mar 2007 18:44:02 +0000 (18:44 +0000)]
Remove redundant line.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 29 Mar 2007 17:07:25 +0000 (17:07 +0000)]
correct the changelog entry for the patch author.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 29 Mar 2007 17:05:28 +0000 (17:05 +0000)]
Take into account the entire run length to get a proper selection.
Doesn't seem to affect the Mac build but is a problem for Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 29 Mar 2007 17:01:21 +0000 (17:01 +0000)]
Rubber stamped by Beth Dakin.
WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
it's ObjC++ now.
* Plugins/WebBaseNetscapePluginStream.m: Removed.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 29 Mar 2007 16:59:01 +0000 (16:59 +0000)]
Layout test for <rdar://problem/
4545060>, technorati and arstechnica fail
because of getComputedStyle not reporting display:none.
http://bugs.webkit.org/show_bug.cgi?id=13103
* fast/css/computed-style-display-none.html: Added.
* fast/css/computed-style-display-none-expected.txt: Added.
* fast/css/computed-style-negative-top.html: Updated to work with Gecko.
* fast/css/computed-style-negative-top-expected.txt: Newline change needed
because of change above.
* fast/css/computed-style.html: Updated to work with Gecko.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 29 Mar 2007 15:18:35 +0000 (15:18 +0000)]
Reluctantly tolerated by Darin Adler.
Fixed <rdar://problem/
5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)
The problem was that the DivX plug-in would ask us to destroy an NPStream
that had already been destroyed, causing us to wander off into freed
memory. (I believe the reason this was a regression was that we never used
to destroy plug-in streams, period.)
The solution here is to track the NPStreams belonging to a plug-in, and
guard against plug-ins making calls with NPStreams that don't belong to
them. (It turns out that NPN_DestroyStream is the only stream-based
plug-in call we support.)
(CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix.
Use helper method to guard against a plug-in using an NPStream that doesn't
belong to it.
* WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++
so I could use HashMap.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 29 Mar 2007 08:41:22 +0000 (08:41 +0000)]
Fix for <rdar://problem/
4545060>, technorati and arstechnica fail because of getComputedStyle not
reporting display:none properly when it is set. This is bugzilla bug 13103.
Reviewed by mitz
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith [Thu, 29 Mar 2007 06:20:38 +0000 (06:20 +0000)]
JavaScriptCore:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:
- holes in arrays should be skipped, not treated as undefined,
by all such methods
- an element with value undefined is not a hole
- Array.prototype.forEach should return undefined
* kjs/array_object.cpp:
(ArrayInstance::getOwnPropertySlot):
(ArrayProtoFunc::callAsFunction):
LayoutTests:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:
- holes in arrays should be skipped, not treated as undefined,
by all such methods
- an element with value undefined is not a hole
- Array.prototype.forEach should return undefined
* fast/js/array-every-expected.txt:
* fast/js/array-filter-expected.txt: Added.
* fast/js/array-filter.html: Added.
* fast/js/array-foreach-expected.txt:
* fast/js/array-foreach.html:
* fast/js/array-indexof-expected.txt:
* fast/js/array-indexof.html:
* fast/js/array-lastIndexOf-expected.txt:
* fast/js/array-map-expected.txt: Added.
* fast/js/array-map.html: Added.
* fast/js/array-some-expected.txt:
* fast/js/array-some.html:
* fast/js/resources/array-every.js:
* fast/js/resources/array-lastIndexOf.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 29 Mar 2007 06:15:27 +0000 (06:15 +0000)]
2007-03-28 Oliver Hunt <oliver@apple.com>
Reviewed by Hyatt.
Rename DocLoader::setPasteInProgress, etc to more generic
setAllowStaleResources, etc
* editing/Editor.cpp:
(WebCore::Editor::paste):
* loader/DocLoader.cpp:
(WebCore::DocLoader::DocLoader):
(WebCore::DocLoader::checkForReload):
* loader/DocLoader.h:
(WebCore::DocLoader::setAllowStaleResources):
* page/DragController.cpp:
(WebCore::DragController::concludeDrag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 29 Mar 2007 04:59:45 +0000 (04:59 +0000)]
2007-03-28 Oliver Hunt <oliver@apple.com>
Reviewed by Anders and Steve.
Add a flag to DocLoader to prevent it from reloading
when performing a paste or drop operation.
Remove m_cachePolicy from CachedResource as it is never used
Fixes rdar://problem/
5044366 : REGRESSION: Repro ASSERT failures
dragging image into GMail message in _web_writeImage and
documentFragmentFromDragData
* editing/Editor.cpp:
(WebCore::Editor::paste):
prevent the docloader from reloading resources on paste
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::updateFromElement):
* loader/Cache.cpp:
(WebCore::createResource):
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
* loader/CachedCSSStyleSheet.h:
* loader/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
* loader/CachedImage.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/CachedResource.h:
* loader/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
* loader/CachedScript.h:
* loader/CachedXBLDocument.cpp:
(WebCore::CachedXBLDocument::CachedXBLDocument):
* loader/CachedXBLDocument.h:
* loader/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
* loader/CachedXSLStyleSheet.h:
* loader/DocLoader.cpp:
(WebCore::DocLoader::DocLoader):
Tidy up constructor initialise new field
(WebCore::DocLoader::checkForReload):
Prevent reload when pasting
* loader/DocLoader.h:
(WebCore::DocLoader::setPasteInProgress):
new field and setter
* page/DragController.cpp:
(WebCore::DragController::concludeDrag):
prevent the docloader from reloading resources on drop
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kjk [Thu, 29 Mar 2007 01:45:00 +0000 (01:45 +0000)]
Not reviewed - fix typo in gdk build.
* platform/gdk/ScrollViewGdk.cpp:
(WebCore::ScrollView::contentsToWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 29 Mar 2007 01:17:07 +0000 (01:17 +0000)]
LayoutTests:
Reviewed by Darin.
- <rdar://problem/
4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
* fast/overflow/scrollRevealButton-expected.checksum:
* fast/overflow/scrollRevealButton-expected.png:
* fast/overflow/scrollRevealButton-expected.txt:
WebCore:
Reviewed by Darin.
- fixed <rdar://problem/
4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
Handle scrolling external scrollviews around the webview during
autoscroll or when scrolling into view.
This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.
* page/FrameView.cpp:
(WebCore::FrameView::scrollRectIntoViewRecursively):
* page/FrameView.h:
* platform/ScrollView.h:
* platform/gdk/ScrollViewGdk.cpp:
(WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
(WebCore::ScrollView::scrollRectIntoViewRecursively):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
(WebCore::ScrollView::scrollRectIntoViewRecursively):
(WebCore::ScrollView::updateContents):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
(WebCore::ScrollView::scrollRectIntoViewRecursively):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::ScrollView::scrollRectIntoViewRecursively):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 28 Mar 2007 22:18:31 +0000 (22:18 +0000)]
Reviewed by Brady.
Update to last fix.
* Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
* WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
Added check to only use the VitalSource workaround if the app is not linked on or after
the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 28 Mar 2007 21:52:54 +0000 (21:52 +0000)]
Reviewed and landed by Darin
Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
http://bugs.webkit.org/show_bug.cgi?id=13138
* platform/StringImpl.cpp:
(WebCore::StringImpl::isLower):
(WebCore::StringImpl::lower):
(WebCore::StringImpl::equalIgnoringCase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Wed, 28 Mar 2007 21:28:17 +0000 (21:28 +0000)]
Reviewed by Hyatt.
Fix <rdar://problem/
5092653>
REGRESSION: Image decoding making scrolling slow
If decoder gave back a null frame (which I think happens regularly if you don't have full frame
data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
led to massive growth in calculated image size and eventually made cache prune constantly.
No test, I don't know how to make one for this.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::cacheFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 28 Mar 2007 20:59:59 +0000 (20:59 +0000)]
WebCore:
Reviewed by Kevin M.
WebCore part of fix for <rdar://problem/
5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
* page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
Convert return value to a string. This matches the behavior in Safari 2.0.
WebKit:
Reviewed by Kevin M.
WebKit part of fix for <rdar://problem/
5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings. We used to allow this
but now we throw a JavaScript exception for return statements that aren't in functions.
Filed this evangelism bug so we can notify VitalSource of the problem:
<rdar://problem/
5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
* WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 28 Mar 2007 16:48:16 +0000 (16:48 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=13190
XPath incorrectly handles namespaces on attributes
WebCore:
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but
measurable performance improvement for bug 13021.
(WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
* xml/XPathStep.h:
(WebCore::XPath::Step::NodeTest::NodeTest):
(WebCore::XPath::Step::NodeTest::namespaceURI):
(WebCore::XPath::Step::nodeTest):
(WebCore::XPath::Step::setNodeTest):
Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
* xml/XPathGrammar.y:
* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::optimizeStepPair):
Accounted for the above change.
LayoutTests:
* fast/xpath/attr-namespace-expected.txt: Added.
* fast/xpath/attr-namespace.html: Added.
* fast/xpath/xpath-namespaces-expected.txt:
* fast/xpath/xpath-namespaces.html:
Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Wed, 28 Mar 2007 11:31:45 +0000 (11:31 +0000)]
Update libWebKitSystemInterface, previous version was out of date.
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 28 Mar 2007 08:41:04 +0000 (08:41 +0000)]
2007-03-28 Oliver Hunt <oliver@apple.com>
rs=Hyatt.
Rollout local changes :-/
* loader/Cache.cpp:
(WebCore::Cache::pruneAllResources):
(WebCore::Cache::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 28 Mar 2007 08:38:05 +0000 (08:38 +0000)]
2007-03-28 Oliver Hunt <oliver@apple.com>
Reviewed by Hyatt.
Roll out r20511 due to incredible badness
* loader/Cache.cpp:
(WebCore::Cache::pruneAllResources):
(WebCore::Cache::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 28 Mar 2007 05:05:49 +0000 (05:05 +0000)]
* svg/hixie/text/003-expected.txt: Updated results for this one test that now has
different results due to the painting Adele added to DumpRenderTree. Long term,
we just have to fix SVG so that painting doesn't cause changes to the render tree!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 28 Mar 2007 04:22:34 +0000 (04:22 +0000)]
2007-03-27 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
Don't enforce text-selection drag delay when we are
going to drag an image anyway.
Fixes rdar://problem/
4668935
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
Layout tests:
Test to ensure there is no delay forced when dragging a selected image
* editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
* editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
* editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
* editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 27 Mar 2007 23:38:23 +0000 (23:38 +0000)]
JavaScriptCore:
Reviewed by Geoff.
* bindings/NP_jsobject.cpp:
(_NPN_InvokeDefault):
Call JSObject:call for native JavaScript objects.
LayoutTests:
Reviewed by Geoff.
Add NPN_InvokeDefault test.
* plugins/netscape-invoke-default-expected.txt: Added.
* plugins/netscape-invoke-default.html: Added.
WebKitTools:
Reviewed by Geoff.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
(pluginInvoke):
Add new function which takes a function and calls it using NPN_InvokeDefault.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 27 Mar 2007 23:29:43 +0000 (23:29 +0000)]
Build fix
* editing/markup.cpp:
(WebCore::startMarkup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 27 Mar 2007 22:55:03 +0000 (22:55 +0000)]
LayoutTests:
Reviewed by darin
<rdar://problem/
5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
Demonstrates the bug fixed:
* editing/style/
5091898-expected.checksum: Added.
* editing/style/
5091898-expected.png: Added.
* editing/style/
5091898-expected.txt: Added.
* editing/style/
5091898.html: Added.
Demonstrates a related bug fixed (deleting
the line break before a paragraph could remove
its underlining):
* editing/deleting/
5091898-expected.checksum: Added.
* editing/deleting/
5091898-expected.png: Added.
* editing/deleting/
5091898-expected.txt: Added.
* editing/deleting/
5091898.html: Added.
Demonstrates that a link now (correctly) exists,
instead of just underlined text:
* editing/pasteboard/
4840662-expected.txt:
WebCore:
Reviewed by darin
<rdar://problem/
5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
createMarkup skipped elements if they were blocks
when called from moveParagraphs (because that function
must receive only inline content). This patch adds
code to inline these blocks instead of skipping them
so that we don't lose any of the style that they
contribute to the copied markup.
* editing/markup.cpp:
(WebCore::startMarkup): Add an inlineBlocks option.
Make sure to overwrite display:block coming from
a style sheet or the inline style declaration.
(WebCore::createMarkup): Don't refuse to include a
specialCommonAncestor that's a block if we were asked
to include only inline content, since we can now inline
block elements in startMarkup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 27 Mar 2007 22:53:53 +0000 (22:53 +0000)]
Oops- my comment was missing a word.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 27 Mar 2007 22:50:26 +0000 (22:50 +0000)]
Adding comment.
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 27 Mar 2007 22:41:20 +0000 (22:41 +0000)]
Fix svg tests by calling displayIfNeeded.
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 27 Mar 2007 22:10:08 +0000 (22:10 +0000)]
Reviewed by Tim
- fixed <rdar://problem/
5092556> Default UA spoofing is always off until explicitly toggled
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not
be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 27 Mar 2007 21:58:28 +0000 (21:58 +0000)]
Reviewed by Hyatt.
Fix for <rdar://problem/
5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery
This disables the paint that occurs after WebCore finishes loading the document. We should reenable this when we
move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call. See <rdar://problem/
5092361>.
* dom/Document.cpp: (WebCore::Document::implicitClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 27 Mar 2007 20:09:21 +0000 (20:09 +0000)]
LayoutTests:
Reviewed by darin
<rdar://problem/
5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/
5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/
5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/
4916887> GMAIL: Can't apply color to text once it becomes indented
* editing/pasteboard/
5065605-expected.checksum: Added.
* editing/pasteboard/
5065605-expected.png: Added.
* editing/pasteboard/
5065605-expected.txt: Added.
* editing/pasteboard/
5065605.html: Added.
* editing/style/
4916887-expected.checksum: Added.
* editing/style/
4916887-expected.png: Added.
* editing/style/
4916887-expected.txt: Added.
* editing/style/
4916887.html: Added.
* editing/style/
5065910-expected.checksum: Added.
* editing/style/
5065910-expected.png: Added.
* editing/style/
5065910-expected.txt: Added.
* editing/style/
5065910.html: Added.
* editing/style/
5084241-expected.checksum: Added.
* editing/style/
5084241-expected.png: Added.
* editing/style/
5084241-expected.txt: Added.
* editing/style/
5084241.html: Added.
WebCore:
Reviewed by darin
<rdar://problem/
5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/
5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/
5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/
4916887> GMAIL: Can't apply color to text once it becomes indented
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
If a node's text fill color is invalid, then its children use
their font-color as their text fill color (they don't inherit
it). Likewise for stroke color.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 27 Mar 2007 16:40:11 +0000 (16:40 +0000)]
* platform/ScrollBar.h:
Use wtf/MathExtras.h instead of math.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 27 Mar 2007 12:49:41 +0000 (12:49 +0000)]
2007-03-27 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Harrison.
* Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Tue, 27 Mar 2007 11:08:12 +0000 (11:08 +0000)]
Fix the build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 27 Mar 2007 10:02:45 +0000 (10:02 +0000)]
2007-03-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
The WebArchiver needs all the subresources of a document to be accessible
through the DocLoader, so we can't remove a CachedResource simultaneously
from the global Cache and all DocLoaders, just because it needs to be
reloaded in one.
Fixes rdar://problem/
5044366
* loader/Cache.cpp:
(WebCore::Cache::remove):
Don't evict the resource from all DocLoaders
* manual-tests/test-iframes-loading-the-same-resource.html: Added.
Alas it wasn't possible to make a nice layout test, even this manual test
is not entirely deterministic
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 27 Mar 2007 09:14:33 +0000 (09:14 +0000)]
2007-03-27 Mark Rowe <mrowe@apple.com>
Build fix.
* platform/GlyphBuffer.h:
(WebCore::GlyphBuffer::clear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Tue, 27 Mar 2007 09:04:22 +0000 (09:04 +0000)]
Fix the rendering crashes due to triggered
asserts and improve a bit the layout scheduling in the
Qt port
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 27 Mar 2007 08:52:54 +0000 (08:52 +0000)]
Add support for glyph offsets to the GlyphBuffer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Tue, 27 Mar 2007 08:32:01 +0000 (08:32 +0000)]
Keep buildbot happy.
* platform/mac/PlatformScrollBarMac.mm:
(WebCore::PlatformScrollbar::scrollbarHit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Tue, 27 Mar 2007 08:03:58 +0000 (08:03 +0000)]
WebCore:
Reviewed by Darin.
On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/
5076249?
* WebCore.exp:
Export _wkGetWheelEventDeltas
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
Remove (0, 0) scroll event hack, it is not needed anymore.
Do per-pixel scrolling for fine grained events.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::isContinuous):
Add new m_isContinuous boolean to indicate fine grained wheel events.
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::setValue):
(WebCore::Scrollbar::setSteps):
(WebCore::Scrollbar::scroll):
* platform/ScrollBar.h:
(WebCore::Scrollbar::value):
Use float to represent current position to support finer grained scrolling.
Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)
* platform/ScrollTypes.h:
(WebCore::):
* platform/gdk/WheelEventGdk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Initalize m_isContinuous
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Add wkGetWheelEventDeltas for getting fine grained wheel events
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Get the wheel deltas using new wkGetWheelEventDeltas interface
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Initalize m_isContinuous
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::calcHeight):
Pass item height to scrollbar
WebKit:
Reviewed by Darin.
On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/
5076249?
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface): Expose GetWheelEventDeltas()
WebKitLibraries:
Reviewed by Darin.
Added wkGetWheelEventDeltas
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Tue, 27 Mar 2007 03:49:17 +0000 (03:49 +0000)]
Added Radar references.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 27 Mar 2007 02:46:48 +0000 (02:46 +0000)]
fixed up order of ChangeLog entries
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 27 Mar 2007 02:36:38 +0000 (02:36 +0000)]
LayoutTests:
Reviewed by Darin Adler.
Layout tests for <rdar://problem/
5088234> REGRESSION: Crash occurs at
WebCore::Node::createRendererIfNeeded() when changing map views with MS
Virtual Earth (http://www.ziprealty.com/)
* fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
* fast/dom/mutation-event-remove-inserted-node.html: Added.
* fast/dom/script-element-remove-self-expected.txt: Added.
* fast/dom/script-element-remove-self.html: Added.
WebCore:
Reviewed by Darin, landed by Anders.
Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142
* manual-tests/liveconnect-applet-get-boolean.html: Added.
* manual-tests/resources/CheckerApplet.class: Added.
* manual-tests/resources/CheckerApplet.java: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 27 Mar 2007 01:57:55 +0000 (01:57 +0000)]
JavaScriptCore:
Reviewed by Darin, landed by Anders.
Fix for: http://bugs.webkit.org/show_bug.cgi?id=13142
The previous fix http://bugs.webkit.org/show_bug.cgi?id=12636
introduced new JNIType to enum in jni_utility.h This is a
problem on the Mac as it seems that the JNIType enum is also
used in the JVM, it is used to specify the return type in
jni_objc.mm
Corrected the fix by moving type to the end, and changing
jni_objc.mm to convert the new type to an old compatible
type.
* bindings/jni/jni_objc.mm:
(KJS::Bindings::dispatchJNICall):
* bindings/jni/jni_utility.h:
WebCore:
Reviewed by Darin, landed by Anders.
Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142
* manual-tests/liveconnect-applet-get-boolean.html: Added.
* manual-tests/resources/CheckerApplet.class: Added.
* manual-tests/resources/CheckerApplet.java: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 27 Mar 2007 01:11:29 +0000 (01:11 +0000)]
Reviewed/landed by Adam.
Bug 13198: Move build settings from project file to xcconfig file for apollo
port JSCore
http://bugs.webkit.org/show_bug.cgi?id=13198
- Moving build settings from xcode project file to xcconfig files.
* JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
* JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
* JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
* JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 26 Mar 2007 23:52:40 +0000 (23:52 +0000)]
Rubberstamped by Anders and Maciej aand Geoff (oh my!)
Since CFTypeRef is really void*, a RetainPtr couldn't be used.
RefType was "void", which doesn't actually exist as a type.
Since RefType only existed for operator*(), and since that operator
doesn't make any sense for RetainPtr, I removed them!
* kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the
compiler with dependencies
* wtf/RetainPtr.h: Nuke RefType and operator*()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 26 Mar 2007 23:46:55 +0000 (23:46 +0000)]
LayoutTests:
Reviewed and landed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=13194
REGRESSION: Selection rects are wrong for images in search results from images.google.com
* fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
* fast/replaced/selection-rect-in-table-cell-expected.png: Added.
* fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
* fast/replaced/selection-rect-in-table-cell.html: Added.
WebCore:
Reviewed and landed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13194
<rdar://problem/
5087738>
REGRESSION: Selection rects are wrong for images in search results from images.google.com
Test: fast/replaced/selection-rect-in-table-cell.html
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 26 Mar 2007 22:09:11 +0000 (22:09 +0000)]
Reviewed by Dave Harrison
- fixed <rdar://problem/
4769772> Problem with Find on certain PDF page
* WebView/WebPDFView.mm:
(-[WebPDFView _scaledAttributedString:]):
We were hitting an exception trying to set the font attribute to nil, which was happening because
the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now
filed separately, but this works around the exception.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 26 Mar 2007 20:32:49 +0000 (20:32 +0000)]
Touched a file to (hopefully) help the compiler with RetainPtr dependencies.
* kjs/nodes.cpp:
(Node::deref):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 26 Mar 2007 20:31:39 +0000 (20:31 +0000)]
Removed now-stale #includes of <assert.h>.
* WebCorePrefix.h:
* config.h:
* css/CSSGrammar.y:
* platform/Arena.cpp:
* platform/KURL.cpp:
* platform/SegmentedString.h:
* rendering/DataRef.h:
* rendering/RenderArena.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 26 Mar 2007 20:08:53 +0000 (20:08 +0000)]
Reviewed by Kevin McCulough.
Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
one instance of commented-out code containing "assert(" instead of replacing it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 26 Mar 2007 16:57:39 +0000 (16:57 +0000)]
* coding/coding-style.html: Let's misquote George Orwell: "Wrong is right. Right is wrong."
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 26 Mar 2007 04:10:00 +0000 (04:10 +0000)]
* coding/coding-style.html: Put !important on right/wrong colors so they override the
green color that comes from the green.css stylesheet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 26 Mar 2007 04:07:20 +0000 (04:07 +0000)]
* coding/RefPtr.html: A couple minor wording tweaks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 26 Mar 2007 04:05:56 +0000 (04:05 +0000)]
* coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Sun, 25 Mar 2007 22:42:31 +0000 (22:42 +0000)]
LayoutTests:
Reviewed by Adam.
Test for <rdar://problem/
5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()
* editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added.
* editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
* editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
* editing/pasteboard/drag-drop-dead-frame.html: Added.
WebCore:
Reviewed by Adam.
Fix <rdar://problem/
5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()
Null check frame in m_dragTarget, it might be gone already.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 25 Mar 2007 15:10:10 +0000 (15:10 +0000)]
2007-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Upload crash logs from DumpRenderTree as part of the test results to ease debugging
of hard-to-reproduce crashes.
* BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 25 Mar 2007 10:33:07 +0000 (10:33 +0000)]
2007-03-25 Mark Rowe <mrowe@apple.com>
Fix grammar error that Mitz pointed out. Replace raw ampersands in hyperlink URL with named entity.
* coding/RefPtr.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 25 Mar 2007 08:39:27 +0000 (08:39 +0000)]
Reviewed by Darin.
A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow
* xml/XPathExpression.cpp:
(WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document
from being destroyed in time.
* dom/Attr.cpp:
(WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
* dom/ContainerNode.h:
(WebCore::ContainerNode::fastSetFirstChild):
(WebCore::ContainerNode::fastSetLastChild):
Added operations that let Attr hack internal ContainerNode data (evil, but fast!).
* xml/XPathStep.cpp:
(WebCore::XPath::Step::evaluate):
(WebCore::XPath::Step::nodesInAxis):
(WebCore::XPath::Step::nodeMatches):
* xml/XPathStep.h:
Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future
optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 07:43:51 +0000 (07:43 +0000)]
* coding/RefPtr.html: A couple wording tweaks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 07:11:36 +0000 (07:11 +0000)]
* coding/RefPtr.html: More formatting tweaks. Added a possible new topic for the document,
suggested by Anders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 06:52:22 +0000 (06:52 +0000)]
* css/main.css: Try tighter spacing for code examples.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 06:48:17 +0000 (06:48 +0000)]
* coding/RefPtr.html: <span> -> </span>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 06:44:30 +0000 (06:44 +0000)]
* coding/RefPtr.html: "smart pointer" -> "smart pointers"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 06:38:56 +0000 (06:38 +0000)]
* coding/RefPtr.html: Added. First draft of a document about RefPtr.
Also tweaked the MIME types of a few files and removed a stray executable bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 25 Mar 2007 06:37:55 +0000 (06:37 +0000)]
Amend the statistics reporting for the WebCore cache to include XSL and to report live/decoded sizes.
* Misc/WebCache.mm:
(+[WebCache statistics]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 25 Mar 2007 06:28:19 +0000 (06:28 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=13156
REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar
* fast/text/midword-break-after-breakable-char-expected.checksum: Added.
* fast/text/midword-break-after-breakable-char-expected.png: Added.
* fast/text/midword-break-after-breakable-char-expected.txt: Added.
* fast/text/midword-break-after-breakable-char.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13156
REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar
Test: fast/text/midword-break-after-breakable-char.html
Breaking in the middle of the word
is allowed only if no breaking opportunity between words has occurred yet. The
first position on the line should not be considered "between words" even if
it is a breaking opportunity.
* rendering/bidi.cpp:
(WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also
cleaned up a couple of lines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 25 Mar 2007 05:53:42 +0000 (05:53 +0000)]
Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be
tossed.
Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
than to all the lists at once. This allows the cache to evict large encoded resources before flushing small
or frequently accessed decoded onces.
Added information on live/decoded data to the cache statistics.
Reviewed by darin
* loader/Cache.cpp:
(WebCore::Cache::Cache):
(WebCore::Cache::pruneLiveResources):
(WebCore::Cache::pruneAllResources):
(WebCore::Cache::setMaximumSize):
(WebCore::Cache::remove):
(WebCore::Cache::lruListFor):
(WebCore::Cache::removeFromLRUList):
(WebCore::Cache::insertInLRUList):
(WebCore::Cache::liveLRUListFor):
(WebCore::Cache::removeFromLiveResourcesList):
(WebCore::Cache::insertInLiveResourcesList):
(WebCore::Cache::addToLiveResourcesSize):
(WebCore::Cache::removeFromLiveResourcesSize):
(WebCore::Cache::adjustSize):
(WebCore::Cache::getStatistics):
* loader/Cache.h:
(WebCore::Cache::TypeStatistic::TypeStatistic):
* loader/CachedImage.cpp:
(WebCore::CachedImage::decodedSizeWillChange):
(WebCore::CachedImage::decodedSizeChanged):
* loader/CachedImage.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::ref):
(WebCore::CachedResource::deref):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::liveResourceAccessed):
* loader/CachedResource.h:
(WebCore::CachedResource::liveAccessCount):
(WebCore::CachedResource::resetLiveAccessCount):
(WebCore::CachedResource::increaseLiveAccessCount):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::cacheFrame):
* platform/graphics/ImageObserver.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintBorderImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 25 Mar 2007 02:48:31 +0000 (02:48 +0000)]
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=13123
CSS selectors that use :lang, :not, and namespaces do not serialize correctly
* fast/css/css-selector-text-expected.txt: Added.
* fast/css/css-selector-text.html: Added.
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=13123
CSS selectors that use :lang, :not, and namespaces do not serialize correctly
Test: fast/css/css-selector-text.html
* css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace
prefix for tag or attribute names, the sub-selector for :not, and the argument
for :lang.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sun, 25 Mar 2007 01:22:28 +0000 (01:22 +0000)]
JavaScriptCore:
Reviewed by Adam
Whoops, RetainPtr should be in the WTF namespace
* wtf/RetainPtr.h:
WebKit:
Reviewed by Adam
RetainPtr is no longer in the WebCore namespace
* History/WebBackForwardList.mm:
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebView/WebDocumentLoaderMac.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 24 Mar 2007 23:21:50 +0000 (23:21 +0000)]
JavaScriptCore:
Reviewed by Adam
<rdar://problem/
5086210> - Move RetainPtr to WTF
* wtf/RetainPtr.h: Added
* JavaScriptCore.xcodeproj/project.pbxproj: Add it to the project file
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto
WebCore:
Reviewed by Adam
<rdar://problem/
5086210> - Move RetainPtr to WTF
* ForwardingHeaders/wtf/RetainPtr.h: Added.
* WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h
* history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
* history/PageCache.h: Ditto
* page/mac/WebCoreFrameBridge.mm: Ditto
* platform/ContextMenu.h: Ditto
* platform/ContextMenuItem.h: Ditto
* platform/DragImage.h: Ditto
* platform/FileChooser.h: Ditto
* platform/PlatformKeyboardEvent.h: Ditto
* platform/PopupMenu.h: Ditto
* platform/SharedBuffer.h: Ditto
* platform/cf/RetainPtr.h: Removed.
* platform/graphics/Icon.h: Changed #include
* platform/mac/ClipboardMac.h: Ditto
* platform/mac/PasteboardMac.mm: Ditto
* platform/mac/WidgetMac.mm: Ditto
* platform/network/AuthenticationChallenge.h: Ditto
* platform/network/ResourceError.h: Ditto
* platform/network/ResourceHandle.h: Ditto
* platform/network/ResourceRequest.h: Ditto
* platform/network/ResourceResponse.h: Ditto
* rendering/RenderThemeMac.mm: Ditto
WebKit:
Reviewed by Adam
<rdar://problem/
5086210> - Move RetainPtr to WTF
* ForwardingHeaders/wtf/RetainPtr.h: Added.
* History/WebBackForwardList.mm: Changed #import to <wtf/RetainPtr.h>
* WebCoreSupport/WebEditorClient.h: Ditto
* WebCoreSupport/WebFrameLoaderClient.h: Ditto
* WebView/WebDocumentLoaderMac.h: Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 24 Mar 2007 23:15:02 +0000 (23:15 +0000)]
Fix for <rdar://problem/
5086797>, layoutPending is now reporting incorrect results, which will lead
to all sorts of layout issues. This is in bugzilla as 13179.
Reviewed by hyatt
- fix http://bugs.webkit.org/show_bug.cgi?id=13179
REGRESSION (r20410): In debug builds, loading a certain page is suspended until redisplay is forced
Moved the root->needsLayout() check from layoutPending() to needsLayout()
to restore the behavior before r20324.
* page/FrameView.cpp:
(WebCore::FrameView::layoutPending):
(WebCore::FrameView::needsLayout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 24 Mar 2007 22:13:04 +0000 (22:13 +0000)]
WebCore:
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=13180
<rdar://problem/
5084478>
Another debug build crash from ASSERTION FAILED: !needsLayout()
No test possible because updateRendering() is always called after script
execution.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Get the layout root after calling recalcStyle()
since a style recalc may result in needing to do start layout at the root.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Sat, 24 Mar 2007 21:53:03 +0000 (21:53 +0000)]
Not reviewed. Build fix.
Fix FloatRect vs. IntRect confusion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Sat, 24 Mar 2007 17:25:09 +0000 (17:25 +0000)]
Reviewed by Adele
- fixed <rdar://problem/
5084872> Need to add flickr to spoof list in WebKit
- only do site-specific spoofing if a preference is set
* WebView/WebPreferenceKeysPrivate.h:
added WebKitUseSiteSpecificSpoofingPreferenceKey
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
initialize WebKitUseSiteSpecificSpoofingPreferenceKey to false
(-[WebPreferences _useSiteSpecificSpoofing]):
get value of WebKitUseSiteSpecificSpoofingPreferenceKey
(-[WebPreferences _setUseSiteSpecificSpoofing:]):
set value of WebKitUseSiteSpecificSpoofingPreferenceKey
* WebView/WebPreferencesPrivate.h:
declare _useSiteSpecificSpoofing and _setUseSiteSpecificSpoofing
* WebView/WebView.mm:
cache the value of WebKitUseSiteSpecificSpoofingPreferenceKey in a bool in _private
(-[WebView _preferencesChangedNotification:]):
update the cached value
(-[WebView setPreferences:]):
ditto
(-[WebView WebCore::_userAgentForURL:WebCore::]):
Only spoof here if the new site-specific spoofing preference is enabled. If it is, pass
Safari 2.0.4's user agent string for flickr.com. We can remove this case when
5081617 is addressed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 24 Mar 2007 13:26:13 +0000 (13:26 +0000)]
Fix incorrect radar number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Sat, 24 Mar 2007 12:27:34 +0000 (12:27 +0000)]
Reviewed by Oliver.
Fix all known RenderSVGImage problems.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)
Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 24 Mar 2007 10:25:31 +0000 (10:25 +0000)]
2007-03-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- http://bugs.webkit.org/show_bug.cgi?id=13177
Suppress control characters in the ATSUI code path
* platform/mac/FontMac.mm:
(WebCore::overrideLayoutOperation):
(WebCore::ATSULayoutParameters::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 24 Mar 2007 10:16:11 +0000 (10:16 +0000)]
Fix for <rdar://problem/
5086400>, images scrolled offscreen continue to animate. Safari 2 would
halt animations when images were no longer visible.
Reviewed by mjs, olliej
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::advanceAnimation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 24 Mar 2007 09:20:33 +0000 (09:20 +0000)]
2007-03-24 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Hyatt.
* JavaScriptGlue.xcodeproj/project.pbxproj: Use GCC 4.0 for testjsglue.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 24 Mar 2007 07:07:24 +0000 (07:07 +0000)]
Fix for <rdar://problem/508328>, sluggish text entry in search field. Make sure
our size actually changed before we decide to do a full repaint because of background/border
complexities.
Reviewed by aroben
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc