From: commit-queue@webkit.org Date: Fri, 16 Mar 2012 16:56:57 +0000 (+0000) Subject: [BlackBerry] Input processing mode should be cancelled when processing hot keys X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=ee609ecae72f9ffaf4062b0d3235c6b458884d6b;ds=sidebyside [BlackBerry] Input processing mode should be cancelled when processing hot keys https://bugs.webkit.org/show_bug.cgi?id=81348 Patch by Mike Fenton on 2012-03-16 Reviewed by Rob Buis. Don't suppress IMF notifications if we are handling the event as a hotkey. Reviewed Internally by Nima Ghanavatian. * WebCoreSupport/EditorClientBlackBerry.cpp: (WebCore::EditorClientBlackBerry::handleKeyboardEvent): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111019 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Source/WebKit/blackberry/ChangeLog b/Source/WebKit/blackberry/ChangeLog index 8bb4d1a95a5c..d90a4be6137f 100644 --- a/Source/WebKit/blackberry/ChangeLog +++ b/Source/WebKit/blackberry/ChangeLog @@ -1,3 +1,18 @@ +2012-03-16 Mike Fenton + + [BlackBerry] Input processing mode should be cancelled when processing hot keys + https://bugs.webkit.org/show_bug.cgi?id=81348 + + Reviewed by Rob Buis. + + Don't suppress IMF notifications if we are handling + the event as a hotkey. + + Reviewed Internally by Nima Ghanavatian. + + * WebCoreSupport/EditorClientBlackBerry.cpp: + (WebCore::EditorClientBlackBerry::handleKeyboardEvent): + 2012-03-16 Robin Cao [BlackBerry] Can not open certain links from bridge applications diff --git a/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp b/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp index ff92bd91b4c8..c1002361de32 100644 --- a/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp +++ b/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp @@ -464,6 +464,8 @@ void EditorClientBlackBerry::handleKeyboardEvent(KeyboardEvent* event) String commandName = interpretKeyEvent(event); if (!commandName.isEmpty()) { + // Hot key handling. Cancel processing mode. + m_webPagePrivate->m_inputHandler->setProcessingChange(false); if (frame->editor()->command(commandName).execute()) event->setDefaultHandled(); return;