From: mcatanzaro@igalia.com Date: Fri, 10 Jul 2015 12:33:18 +0000 (+0000) Subject: [GTK] ar warning when linking static libraries X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=ec4993fc5d6e6b37f9d94c4a91be301fc2d7b707;hp=ec4993fc5d6e6b37f9d94c4a91be301fc2d7b707;ds=sidebyside [GTK] ar warning when linking static libraries https://bugs.webkit.org/show_bug.cgi?id=144988 Reviewed by Carlos Garcia Campos. Do not use 'u' when calling ar. This argument conflicts with 'D' and is ignored if 'D' is used, and 'D' is used by default if binutils is built with --enable-deterministic-archives. Using 'u' with 'D' causes a warning to be printed when linking static libraries. At least Fedora and Debian have recently both chosen to use --enable-deterministic-archives, so we should either stop using 'u' or else add 'U' as well in order to disable deterministic archives. Using 'U' should result in a somewhat faster build (at least when using the Makefile generator), but it's unlikely that the difference is significant, so let's simply remove 'u' until someone determines otherwise. This seems like a better option than adding 'U' so as not to foil distributions' attempts to perform deterministic builds. This also aligns us with the behavior of upstream CMake (which has never used 'u'). This is a minor behavior change on distributions that do not use --enable-deterministic-archives, notably Arch and openSUSE. * Source/cmake/OptionsCommon.cmake: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186670 268f45cc-cd09-0410-ab3c-d52691b4dbfc ---