From: commit-queue@webkit.org Date: Thu, 7 Feb 2013 15:08:22 +0000 (+0000) Subject: [BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser... X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=c19aa996da8b478dfcf6008e76d2ee63177e9efe [BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state https://bugs.webkit.org/show_bug.cgi?id=109124 Patch by Sean Wang on 2013-02-07 Reviewed by Yong Li. RIM BUG 291246 Internally reviewed by YongLi. Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow() into WebPageClientImpl::createWindow() to make it more close to its protecting place. * WebCoreSupport/ChromeClientBlackBerry.cpp: (WebCore::ChromeClientBlackBerry::createWindow): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142117 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Source/WebKit/blackberry/ChangeLog b/Source/WebKit/blackberry/ChangeLog index 3c405b651c91..fb63314ad6b0 100644 --- a/Source/WebKit/blackberry/ChangeLog +++ b/Source/WebKit/blackberry/ChangeLog @@ -1,3 +1,17 @@ +2013-02-07 Sean Wang + + [BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state + https://bugs.webkit.org/show_bug.cgi?id=109124 + + Reviewed by Yong Li. + + RIM BUG 291246 Internally reviewed by YongLi. + Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow() + into WebPageClientImpl::createWindow() to make it more close to its protecting place. + + * WebCoreSupport/ChromeClientBlackBerry.cpp: + (WebCore::ChromeClientBlackBerry::createWindow): + 2013-02-07 Mike Fenton [BlackBerry] Send type details with IMF mask as part of focus gained. diff --git a/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp b/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp index 10847e2f46b4..720cc6ee4504 100644 --- a/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp +++ b/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp @@ -236,9 +236,6 @@ Page* ChromeClientBlackBerry::createWindow(Frame* frame, const FrameLoadRequest& return 0; #endif - PageGroupLoadDeferrer deferrer(m_webPagePrivate->m_page, true); - TimerBase::fireTimersInNestedEventLoop(); - int x = features.xSet ? features.x : 0; int y = features.ySet ? features.y : 0; int width = features.widthSet? features.width : -1;