From: mmaxfield@apple.com Date: Wed, 7 Jan 2015 23:56:01 +0000 (+0000) Subject: Update css3/flexbox/auto-margins.html after r177774 X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=bb06bd0c016176d2bd684dfaa188a089871ef2b3 Update css3/flexbox/auto-margins.html after r177774 https://bugs.webkit.org/show_bug.cgi?id=139975 Patch by Myles C. Maxfield on 2015-01-07 Reviewed by Darin Adler. This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire box and therefore does all its math in floating point, while the -expected uses the regular renderer hierarchy and therefore fixed-point math. This patch updates the test to use Ahem so that the character widths divide the same way in both cases. * css3/flexbox/auto-margins-expected.html: * css3/flexbox/auto-margins.html: * platform/mac/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@178063 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 4507731f6e8a..cda1dd44c5ba 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,20 @@ +2015-01-07 Myles C. Maxfield + + Update css3/flexbox/auto-margins.html after r177774 + https://bugs.webkit.org/show_bug.cgi?id=139975 + + Reviewed by Darin Adler. + + This is a subpixel problem. Flexbox uses SimpleLineLayout for the entire + box and therefore does all its math in floating point, while the + -expected uses the regular renderer hierarchy and therefore fixed-point + math. This patch updates the test to use Ahem so that the character + widths divide the same way in both cases. + + * css3/flexbox/auto-margins-expected.html: + * css3/flexbox/auto-margins.html: + * platform/mac/TestExpectations: + 2015-01-07 Brent Fulgham [Win] Unreviewed test gardening (writing-mode). diff --git a/LayoutTests/css3/flexbox/auto-margins-expected.html b/LayoutTests/css3/flexbox/auto-margins-expected.html index 66d52c3c5127..0cc382ef4bbe 100644 --- a/LayoutTests/css3/flexbox/auto-margins-expected.html +++ b/LayoutTests/css3/flexbox/auto-margins-expected.html @@ -16,13 +16,13 @@

These tests are from the spec: http://dev.w3.org/csswg/css3-flexbox/#auto-margins.

The word OK should be centered vertically and horizontally.

A black box should be centered vertically and horizontally.

You should see 3 blue concentric circles.

diff --git a/LayoutTests/css3/flexbox/auto-margins.html b/LayoutTests/css3/flexbox/auto-margins.html index b63e3ca05c4d..edf580e9e1bb 100644 --- a/LayoutTests/css3/flexbox/auto-margins.html +++ b/LayoutTests/css3/flexbox/auto-margins.html @@ -23,13 +23,13 @@

These tests are from the spec: http://dev.w3.org/csswg/css3-flexbox/#auto-margins.

The word OK should be centered vertically and horizontally.

A black box should be centered vertically and horizontally.

You should see 3 blue concentric circles.

diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations index 3f500233f23f..541f7b803fe6 100644 --- a/LayoutTests/platform/mac/TestExpectations +++ b/LayoutTests/platform/mac/TestExpectations @@ -1339,7 +1339,6 @@ fast/canvas/canvas-fillRect-gradient-shadow.html [ Pass Failure ] # Kerning, Ligatures, and Printer Fonts caused these tests to fail # The following tests are reftests -webkit.org/b/139968 css3/flexbox/auto-margins.html [ ImageOnlyFailure ] webkit.org/b/139968 css3/flexbox/csswg/flexbox_direction-row-reverse.html [ ImageOnlyFailure ] webkit.org/b/139968 fast/box-decoration-break/box-decoration-break-rendering.html [ ImageOnlyFailure ] webkit.org/b/139968 fast/css-generated-content/after-with-inline-continuation.html [ ImageOnlyFailure ]